12 years agoFix off-by-one error in launch_other_browser
Steven Luo [Sun, 13 Dec 2009 08:45:12 +0000 (00:45 -0800)]
Fix off-by-one error in launch_other_browser

quote+1 has length one less than quote, so asking memmove() to move
strlen(quote)+1 bytes (including the \0) starting at quote+1 results in
writing one byte beyond the end of the memory area.  Found by valgrind.

12 years agoActually initialize sa_mask properly
Steven Luo [Sun, 13 Dec 2009 08:35:18 +0000 (00:35 -0800)]
Actually initialize sa_mask properly

sigset_t isn't necessarily an integer, so we can't assign an integer to
it -- use the appropriate function instead.

12 years agoInitialize sa_mask in sigaction structure
Steven Luo [Sun, 13 Dec 2009 08:29:04 +0000 (00:29 -0800)]
Initialize sa_mask in sigaction structure

Found by valgrind.

12 years agoCreate and register two different OssoBrowser objects instead of reusing one
Steven Luo [Sun, 13 Dec 2009 08:21:46 +0000 (00:21 -0800)]
Create and register two different OssoBrowser objects instead of reusing one

Valgrind complains about a memory leak otherwise.

12 years agoFix thinko in open_address
Steven Luo [Sun, 13 Dec 2009 08:15:41 +0000 (00:15 -0800)]
Fix thinko in open_address

if (!uri && uri[0] = '/') is obviously never going to be true ...
Fix by just giving up in the !uri case.

Strangely enough, I'm not hitting this in testing on the tablet --
perhaps gcc is optimizing out the test?

12 years agoDon't exit if pidof dies abnormally
Steven Luo [Fri, 11 Dec 2009 10:28:27 +0000 (02:28 -0800)]
Don't exit if pidof dies abnormally

There's no need to quit if pidof is killed or otherwise dies abnormally
instead of exiting normally, we just can't check its exit status.

12 years agoMake "make install" install the /usr/bin/browser wrapper and dbus service too
Steven Luo [Fri, 11 Dec 2009 10:24:58 +0000 (02:24 -0800)]
Make "make install" install the /usr/bin/browser wrapper and dbus service too

12 years agoRemove a stray debugging printf()
Steven Luo [Fri, 11 Dec 2009 10:21:42 +0000 (02:21 -0800)]
Remove a stray debugging printf()

12 years agoClean up string handling
Steven Luo [Fri, 11 Dec 2009 10:18:05 +0000 (02:18 -0800)]
Clean up string handling

Revise the handling of strings in several places to be less confusing
and safer.  Fix at least two definite bugs in launcher.c concerning
integer overflows and realloc() possibly moving memory.

Also a few indentation changes.

12 years agoStyle changes
Steven Luo [Fri, 11 Dec 2009 05:28:12 +0000 (21:28 -0800)]
Style changes

12 years agoMake config file parsing (mostly) compatible with the Python implementation
Steven Luo [Fri, 11 Dec 2009 05:15:39 +0000 (21:15 -0800)]
Make config file parsing (mostly) compatible with the Python implementation

Redo the config file parsing using POSIX regular expressions, so that
it's mostly compatible with the Python implementation.  Full
compatibility isn't happening, of course, since the Python
implementation's config file is being sourced by the interpreter.

12 years agoRemove a redundant -Wall from CPPFLAGS
Steven Luo [Fri, 11 Dec 2009 04:53:26 +0000 (20:53 -0800)]
Remove a redundant -Wall from CPPFLAGS

12 years agoCommit a plain C reimplementation of browser-switchboard
Steven Luo [Fri, 11 Dec 2009 04:08:23 +0000 (20:08 -0800)]
Commit a plain C reimplementation of browser-switchboard

The C implementation has a ~2 second startup time advantage over the
Python version, very noticeable when continuous_mode is disabled.

For now, the config file format is incompatible with the Python

12 years agoMake browser-switchboard launch MicroB if unconfigured and Tear is not installed
Steven Luo [Fri, 11 Dec 2009 02:09:23 +0000 (18:09 -0800)]
Make browser-switchboard launch MicroB if unconfigured and Tear is not installed

Make browser-switchboard launch MicroB if there is no config file and
Tear is not installed.  Do this by handling default_browser == ""
specially, and by setting default_browser to the empty string by

This allows us to drop the Depends: on tear in the packaging.

12 years agoFinish changing the name from browser-proxy to browser-switchboard
Steven Luo [Fri, 11 Dec 2009 00:47:48 +0000 (16:47 -0800)]
Finish changing the name from browser-proxy to browser-switchboard

Rename the script to browser-switchboard, and change the D-Bus .service
file and the docs accordingly.  Change the config file location from
$HOME/.config/browser-proxy to $HOME/.config/browser-switchboard.

Also, get rid of the # in front of every line of the README.

12 years agoZap the welcome file
Steven Luo [Fri, 11 Dec 2009 00:27:35 +0000 (16:27 -0800)]
Zap the welcome file

12 years agoMerge branch 'master' of
Steven Luo [Fri, 11 Dec 2009 00:20:53 +0000 (16:20 -0800)]
Merge branch 'master' of

12 years agoInitial commit.
Steven Luo [Fri, 11 Dec 2009 00:18:38 +0000 (16:18 -0800)]
Initial commit.

12 years agowelcome
www-data [Thu, 10 Dec 2009 12:40:32 +0000 (14:40 +0200)]