modest
13 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 11:39:46 +0000 (11:39 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* libmodest-dbus-client/libmodest-dbus-client.c:
        * libmodest-dbus-client/libmodest-dbus-client.h:
        Removed libmodest_dbus_client_send_mail() because it is not used by anything.
        libmodest_dbus_client_compose_mail() is what things actually use.

        * src/dbus_api/modest-dbus-api.h:
        * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
        * tests/dbus_api/Makefile.am:
        * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
        D-Bus method.

pmo-trunk-r2424

13 years ago * Added an extra check that was causing a crash when the folder returns no stats
Sergio Villar Senin [Tue, 26 Jun 2007 11:00:32 +0000 (11:00 +0000)]
* Added an extra check that was causing a crash when the folder returns no stats

pmo-trunk-r2423

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 26 Jun 2007 10:33:24 +0000 (10:33 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Added gtk_text_iter_forward_search_insensitive to implement
          case insensitive search of strings using the find toolbar.
        * Added proper information banners for no matches, search
          complete and empty find.
        * Rework the find in page, to work similar to the upcoming
          find in page new implementation of viewer.

pmo-trunk-r2422

13 years agoChanged the configure.ac file. corrected the helplib variable used instead of mimelib.
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 09:39:29 +0000 (09:39 +0000)]
Changed the configure.ac file. corrected the helplib variable used instead of mimelib.

pmo-trunk-r2421

13 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 09:10:53 +0000 (09:10 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* src/modest-init.c: (modest_init_local_folders):
        For memory-card (or other non local-folders) maildir accounts,
        always create an Archive folder, so that there is somewhere to put
        messages. This should be less confusing, because the user does not need
        to guess that the need to create a folder.

pmo-trunk-r2420

13 years ago* Add a new check of new folder name string length in
Javier Fernandez Garcia-Boente [Tue, 26 Jun 2007 09:05:20 +0000 (09:05 +0000)]
* Add a new check of new folder name string length in
'entry-changed' signal handler.
* Fixes: NB#61576

pmo-trunk-r2419

13 years agoCompilation error
Philip Van Hoof [Tue, 26 Jun 2007 08:25:56 +0000 (08:25 +0000)]
Compilation error

pmo-trunk-r2418

13 years ago* call osso_abook_init before doing anything with the addressbook.
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 08:03:16 +0000 (08:03 +0000)]
* call osso_abook_init before doing anything with the addressbook.
  this fixes NB#57415

pmo-trunk-r2417

13 years agoBugfix for 61408
Philip Van Hoof [Mon, 25 Jun 2007 20:07:50 +0000 (20:07 +0000)]
Bugfix for 61408

pmo-trunk-r2416

13 years ago * Added an attribute sent to the msg edit window that specifies that the mail has...
Sergio Villar Senin [Mon, 25 Jun 2007 18:56:49 +0000 (18:56 +0000)]
* Added an attribute sent to the msg edit window that specifies that the mail has scheduled to be sent
* Modified the window destruction code in the window manager. Now checks that the message has not been sent before trying to save it to drafsts
* Some code reorganization in the window manager

pmo-trunk-r2415

13 years ago* Added new dimming rules for Attachment menu option in
Javier Fernandez Garcia-Boente [Mon, 25 Jun 2007 18:00:05 +0000 (18:00 +0000)]
* Added new dimming rules for Attachment menu option in
viewer window.
* Fixes: NB#61148

pmo-trunk-r2414

13 years ago2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Mon, 25 Jun 2007 17:46:07 +0000 (17:46 +0000)]
2007-06-25  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/easysetup/modest-wizard-dialog.c: (init):
Fixed icon size by using (50, 50) which is the same as defined by
newer hildon-libs

pmo-trunk-r2413

13 years ago* sync the folders when when we're moving to another one.
Dirk-Jan C. Binnema [Mon, 25 Jun 2007 17:28:16 +0000 (17:28 +0000)]
* sync the folders when when we're moving to another one.
  this fixes NB#57773

pmo-trunk-r2412

13 years ago * Fixes NB#61266, now the user can navigate between the tabs of global settings...
Sergio Villar Senin [Mon, 25 Jun 2007 16:37:02 +0000 (16:37 +0000)]
 * Fixes NB#61266, now the user can navigate between the tabs of global settings dialog using the hardware keys

pmo-trunk-r2411

13 years ago * Partially reverted last commit, sometimes the gdk_threads_enter blocks, still...
Sergio Villar Senin [Mon, 25 Jun 2007 16:00:42 +0000 (16:00 +0000)]
* Partially reverted last commit, sometimes the gdk_threads_enter blocks, still need to review it

pmo-trunk-r2410

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Mon, 25 Jun 2007 15:48:18 +0000 (15:48 +0000)]
* src/modest-ui-actions.c:
        * Fixed translation of message retrieval information note
          (fixes NB#61620).

pmo-trunk-r2409

13 years ago * Added two missing gdk_threads_enter/leave statements
Sergio Villar Senin [Mon, 25 Jun 2007 15:48:08 +0000 (15:48 +0000)]
* Added two missing gdk_threads_enter/leave statements

pmo-trunk-r2408

13 years ago * Removed an invalid g_object_unref
Sergio Villar Senin [Mon, 25 Jun 2007 15:44:03 +0000 (15:44 +0000)]
* Removed an invalid g_object_unref
* Added some gdk_threads_enter/leave in the mail operations

pmo-trunk-r2407

13 years agoUpdated yje
Dirk-Jan C. Binnema [Mon, 25 Jun 2007 15:36:12 +0000 (15:36 +0000)]
Updated yje

pmo-trunk-r2406

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 25 Jun 2007 14:47:55 +0000 (14:47 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now Paste is dimmed when focus is in attachments view
          (fixes NB#60552).
        * Added proper information banners for insensitive press
          of Paste.

pmo-trunk-r2405

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Mon, 25 Jun 2007 14:26:47 +0000 (14:26 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Added information banner for search complete and no matches.
        * Fixed translation of confirm overwrite dialog (fixes
          NB#60401).

pmo-trunk-r2404

13 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Mon, 25 Jun 2007 14:11:52 +0000 (14:11 +0000)]
* src/maemo/modest-main-window.c:
        * Now "No messages to show" message is aligned to top
          instead of center (fixes NB#60298).

pmo-trunk-r2403

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 25 Jun 2007 14:02:59 +0000 (14:02 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now CC and BCC fields are shown even when show_cc and s
          show_bcc are FALSE in settings, if these fields have any
          values (for example replying to all in a message with Cc)
          (fixes NB#60253).

pmo-trunk-r2402

13 years ago2007-06-25 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Mon, 25 Jun 2007 13:18:44 +0000 (13:18 +0000)]
2007-06-25  Armin Burgmeier  <armin@openismus.com>

* src/widgets/modest-window-mgr.c:
* src/modest-init.c:
* configure.ac: Correctly recognize hildon-notify presence and fixed
the build without it being installed.

pmo-trunk-r2401

13 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Mon, 25 Jun 2007 13:12:39 +0000 (13:12 +0000)]
* src/modest-ui-dimming-rules.c:
        * Added dimming rule for trying to remove attachments from a
          POP message (fixes NB#59869).

pmo-trunk-r2400

13 years ago2007-06-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 25 Jun 2007 12:26:37 +0000 (12:26 +0000)]
2007-06-25  Murray Cumming  <murrayc@murrayc.com>

* libmodest-dbus-client/libmodest-dbus-client.c:
(libmodest_dbus_client_search): Fix the build. Sorry.
* src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
(reply_forward_cb): Initialize variables to fix the build.

* src/modest-tny-account-store.c:
(modest_tny_account_store_get_tny_account_by): Fix the account URI
comparison (a silly typo) so that email search results can be opened
when there are more than one account.

pmo-trunk-r2398

13 years ago * Fixes NB#59138, message is saved to drafts when main window is closed
Sergio Villar Senin [Mon, 25 Jun 2007 11:36:41 +0000 (11:36 +0000)]
* Fixes NB#59138, message is saved to drafts when main window is closed
* modest_msg_edit_window_is_modified is now public
* modest_window_mgr.c: added a hash table to store the "window-destroy" signal handlers
* modest_window_mgr.c: replaced a g_object_unref by gtk_widget_destroy
* moved the save_to_drafts call from the edit window to the window manager
* added some missing unrefs to the UI actions
* fixed save_to_drafts mail operation, it was not reporting the mail operation status

pmo-trunk-r2397

13 years ago2007-06-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 25 Jun 2007 10:46:33 +0000 (10:46 +0000)]
2007-06-25  Murray Cumming  <murrayc@murrayc.com>

* libmodest-dbus-client/libmodest-dbus-client.c:
(libmodest_dbus_client_search),
(libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
instead of 1 second, because the search gets folders and messages from
the server, which can take a long time. When it times out,
osso-global-search will report no results.

We need to specify whether we should search only cached information
(maybe with a user preference), and the osso-email-search-plugin
API should really be improved to allow that option, and to allow results
to be delivered asynchronously in batches.|

pmo-trunk-r2395

13 years ago* Review dimming rules of attachment menu option.
Javier Fernandez Garcia-Boente [Mon, 25 Jun 2007 10:45:12 +0000 (10:45 +0000)]
* Review dimming rules of attachment menu option.
* Fixes: NB#61295

pmo-trunk-r2394

13 years ago2007-06-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 25 Jun 2007 09:06:51 +0000 (09:06 +0000)]
2007-06-25  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-wizard-dialog.c: (init):
        Fix a typo to fix the osso 1.1. build. See the TODO comment though -
        GTK_ICON_SIZE_DIALOG is probably the wrong size.

pmo-trunk-r2393

13 years ago2007-06-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 25 Jun 2007 08:58:55 +0000 (08:58 +0000)]
2007-06-25  Murray Cumming  <murrayc@murrayc.com>

* src/modest-search.c: (modest_search_folder): Ignore a seach folder
        that is an empty string. D-Bus seems to give us these instead of NULL.

pmo-trunk-r2392

13 years ago2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Mon, 25 Jun 2007 08:50:55 +0000 (08:50 +0000)]
2007-06-25  Johannes Schmid <johannes.schmid@openismus.com>

* src/dbus_api/modest-dbus-callbacks.c:
* src/maemo/easysetup/modest-easysetup-wizard.h:
* src/maemo/easysetup/modest-wizard-dialog.c: (init):
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(modest_connection_specific_smtp_edit_window_init):
* src/maemo/modest-maemo-global-settings-dialog.c:
(on_range_error):
* src/maemo/modest-maemo-utils.c:
(modest_maemo_utils_setup_images_filechooser):
* src/maemo/modest-main-window.c: (create_details_widget):
* src/maemo/modest-msg-edit-window.c:
(modest_msg_edit_window_attach_file_noninteractive),
(modest_msg_edit_window_color_button_change),
(modest_msg_edit_window_set_zoom):
* src/modest-mail-operation.c: (update_account_thread):
* src/modest-tny-account-store.c:
* src/modest-tny-account.c:
* src/widgets/modest-global-settings-dialog.c:
* src/widgets/modest-window.h:

Fixed build on bora!

pmo-trunk-r2391

13 years ago* src/widgets/modest-attachments-view.c:
Jose Dapena Paz [Mon, 25 Jun 2007 08:38:45 +0000 (08:38 +0000)]
* src/widgets/modest-attachments-view.c:
        * Now it updates properly the selected attachments list when
          an attachment is removed. It also updates properly the
          primary clipboard (fixes NB#61453).

pmo-trunk-r2390

13 years ago2007-06-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 25 Jun 2007 08:37:19 +0000 (08:37 +0000)]
2007-06-25  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
* src/modest-search.c: (modest_search_folder),
(modest_search_all_accounts): Actually search only in the specified folder,
doing a simple match on the folder ID.
* src/modest-search.h: Added a folder field to the ModestSearch struct,
and added some documentation.

pmo-trunk-r2389

13 years ago* Add a new gettext macro to use holdon-common-strings
Javier Fernandez Garcia-Boente [Mon, 25 Jun 2007 07:42:57 +0000 (07:42 +0000)]
* Add a new gettext macro to use holdon-common-strings
translate domain.
* Add a new notification banner to edit/copy operation.

pmo-trunk-r2388

13 years ago- fix order of header fields in viewer; fixes NB#61497
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 16:50:03 +0000 (16:50 +0000)]
- fix order of header fields in viewer; fixes NB#61497

pmo-trunk-r2387

13 years ago* gnome is currently broken; tell our users
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 11:02:40 +0000 (11:02 +0000)]
* gnome is currently broken; tell our users

pmo-trunk-r2386

13 years ago* fix the fallout of the configuration changes - builds again now
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 10:48:17 +0000 (10:48 +0000)]
* fix the fallout of the configuration changes - builds again now

pmo-trunk-r2385

13 years ago* remove some unintended changes in the last checkin
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 10:17:13 +0000 (10:17 +0000)]
* remove some unintended changes in the last checkin

pmo-trunk-r2384

13 years ago* cleanup the configuration system a bit:
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 10:09:45 +0000 (10:09 +0000)]
* cleanup the configuration system a bit:
- don't have an overall 'hildon0' or 'hildon1' check, because this causes problems with sardine
- check for ogs, hildon-help, hildon-notify etc. separately
- turn on -Werr for *all* maemo builds

pmo-trunk-r2383

13 years ago* fix bora build (there's no hildonnotification there)
Dirk-Jan C. Binnema [Sat, 23 Jun 2007 09:02:13 +0000 (09:02 +0000)]
* fix bora build (there's no hildonnotification there)

pmo-trunk-r2382

13 years ago2007-06-22 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Fri, 22 Jun 2007 20:03:30 +0000 (20:03 +0000)]
2007-06-22  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-maemo-utils.h:
* src/maemo/modest-maemo-utils.c: Added a GError parameter to
modest_maemo_utils_get_supported_secure_authentication_methods.

* src/maemo/easysetup/modest-easysetup-wizard.c:
* src/maemo/modest-account-settings-dialog.c: Show correct error if
one occured, not just "Server does not support secure authentication".

pmo-trunk-r2381

13 years ago2007-06-22 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 22 Jun 2007 16:13:17 +0000 (16:13 +0000)]
2007-06-22  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (get_password):
        Restored the call to tny_account_set_user() because Philip seems to have
        stopped this from crashing (by not using the freed string). It still does
        not work, but now we can test it.

pmo-trunk-r2380

13 years ago* src/widgets/modest-msg-view.[ch]:
Jose Dapena Paz [Fri, 22 Jun 2007 15:11:11 +0000 (15:11 +0000)]
* src/widgets/modest-msg-view.[ch]:
        * Remove an attachment mime part from view.
* src/widgets/modest-msg-view-window.[ch]:
        * Implemented dialog for removing attachments, but dropped
          any remove attachment implementation until we know how to
          remove attachments only from cache.

pmo-trunk-r2379

13 years ago2007-06-22 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 22 Jun 2007 14:09:23 +0000 (14:09 +0000)]
2007-06-22  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-msg-edit-window.c: (init_window):
        Comment out use of an uninitialzed GtkScrolledWindow variable,
        to fix the build and stop a crash. Yet again.

pmo-trunk-r2378

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Fri, 22 Jun 2007 12:15:57 +0000 (12:15 +0000)]
* src/modest-ui-actions.c:
        * Now saving to drafts shows a proper information
          banner (fixes NB#59333).

pmo-trunk-r2377

13 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Fri, 22 Jun 2007 12:07:28 +0000 (12:07 +0000)]
* src/widgets/modest-folder-view.c:
        * Now local folder is bolded too (fixes NB#59314).

pmo-trunk-r2376

13 years ago* src/modest-text-utils.[ch]:
Jose Dapena Paz [Fri, 22 Jun 2007 11:53:46 +0000 (11:53 +0000)]
* src/modest-text-utils.[ch]:
        * Added new method modest_text_utils_get_color_string, that
          obtains a color string proper for inserting in pango markup
          or html from a GdkColor.
* src/maemo/modest-main-window.c:
        * Now the folder details view puts secondary text color on field
          names (fixes NB#59310).

pmo-trunk-r2375

13 years ago2007-06-22 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 22 Jun 2007 11:20:51 +0000 (11:20 +0000)]
2007-06-22  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (get_password):
        Remove the call to tny_account_set_user() because this actually crashes.
        As mentioned in the last commit, it is known to not work anyway.

pmo-trunk-r2374

13 years ago* src/maemo/modest-address-book.c:
Jose Dapena Paz [Fri, 22 Jun 2007 10:26:15 +0000 (10:26 +0000)]
* src/maemo/modest-address-book.c:
        * Removed call to osso_abook_select_dialog_set_new_contact
          as this has been removed from new osso abook API.
* src/maemo/modest-msg-edit-window.c:
        * Now inserted images size are limited to a width of 640
          on insertion to buffer, to avoid requiring horizontal
          scroll.
        * Now images are also obtained using Gnome VFS. This way we can
          obtain remote images.
        * Now we accept selecting multiple image files to insert
          (fixes NB#59820).
        * Now we open the insert image filechooser dialog in the
          images special folder.
* src/maemo/modest-maemo-utils.[ch]:
        * New modest_maemo_utils_setup_images_filechooser method,
          that sets up a filechooser for saving or browsing images.
          Sets the filter to images mimetype category, and the
          default folder to the images one.

pmo-trunk-r2373

13 years ago2007-06-22 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 22 Jun 2007 09:57:08 +0000 (09:57 +0000)]
2007-06-22  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (get_password):
        Use tny_account_set_username() to tell tinymail that the username might
        have changed too. But tinymail ignores this: see projects.maemo.org
        bug #61463.
        * src/modest-ui-actions.c:
        (modest_ui_actions_on_password_requested): Remove the useless attempt to
        reset the connection when changing the username, and improve the comments.
        Save the changed username to gconf at least, so it is used when Modest is
        restarted.

pmo-trunk-r2372

13 years ago2007-06-21 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 21 Jun 2007 17:44:44 +0000 (17:44 +0000)]
2007-06-21  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
Do not use a query, so that we get all folders, including for POP and
local-folders. They work as search criteria too.
This fixes projects.maemo.org bug NB#57740.

pmo-trunk-r2371

13 years ago* src/widgets/modest-msg-edit-window.h:
Jose Dapena Paz [Thu, 21 Jun 2007 17:23:33 +0000 (17:23 +0000)]
* src/widgets/modest-msg-edit-window.h:
        * Added zoom actions for 80% and 120%.
* src/maemo/modest-msg-edit-window.c:
        * Now zoom menu is updated properly on inherited zooms
          (fixes NB#61337).
* src/maemo/ui/modest-msg-edit-window-ui.xml:
        * Added 80% and 120% menu levels actions.

pmo-trunk-r2370

13 years ago2007-06-21 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 21 Jun 2007 17:20:51 +0000 (17:20 +0000)]
2007-06-21  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-platform.c: (modest_platform_on_new_msg):
Comment out the use of hildon_notification_set_sound() because it is
not declared, to fix the build. Warnings are serious, people.

pmo-trunk-r2368

13 years agoRefactoring work to make new folder and rename folder share
Jose Dapena Paz [Thu, 21 Jun 2007 16:55:08 +0000 (16:55 +0000)]
Refactoring work to make new folder and rename folder share
the same implementation (fixes NB#58817).
* src/modest-platform.h:
        * New rename_folder_dialog method.
* src/modest-ui-actions.c:
        * Now rename uses a dialog in modest platform, sharing the
          implementation with new folder dialog. Also removed old
          dialog implementation.
* src/maemo/modest-platform.c:
        * New method rename_folder_dialog, and refactored
          new_folder_dialog, creating name_folder_dialog
          that implements the same logic and controls for
          both UI actions.

pmo-trunk-r2367

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Thu, 21 Jun 2007 16:11:41 +0000 (16:11 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now, if you're not focusing the body editor, zoom is not
          allowed from menu nor hardware keys (fixes NB#58800).
        * Fixed translation strings for zoom information banners.
          Now they use the hildon-common-strings domain strings.
* src/maemo/modest-msg-view-window.c:
        * Fix translation strings for zoom information banners.
* src/maemo/modest-main-window.c:
        * Add unable to zoom information banner in main window.
* src/maemo/modest-main-window-ui.xml:
        * Added zoom hardware key actions.

pmo-trunk-r2366

13 years ago2007-06-21 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Thu, 21 Jun 2007 15:48:43 +0000 (15:48 +0000)]
2007-06-21  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-maemo-utils.h:
* src/maemo/modest-maemo-utils.c: Added a username parameter to the
modest_maemo_utils_get_supported_secure_authentication_methods()
to query authentication methods for a specific user. This should fix
projects.maemo.org bug NB#61369.

* src/maemo/easysetup/modest-easysetup-wizard.c:
* src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
function.

pmo-trunk-r2365

13 years ago * Added a callback to the update_account operation that notifies about the new messa...
Sergio Villar Senin [Thu, 21 Jun 2007 15:09:15 +0000 (15:09 +0000)]
* Added a callback to the update_account operation that notifies about the new messages received
* Fixed the Empty view problem
* Removed the new message notification from the header view

pmo-trunk-r2364

13 years ago* src/maemo/modest-folder-view.c:
Jose Dapena Paz [Thu, 21 Jun 2007 14:17:53 +0000 (14:17 +0000)]
* src/maemo/modest-folder-view.c:
        * Now it sorts local folders in a different way. It puts
          first the special folders outbox, drafts and sent, and then
          all the user created folders (fixes NB#60361).

pmo-trunk-r2363

13 years ago* Fix bug about how set_flags function was being used.
Javier Fernandez Garcia-Boente [Thu, 21 Jun 2007 13:46:27 +0000 (13:46 +0000)]
* Fix bug about how set_flags function was being used.
* Fixes: NB#59193

pmo-trunk-r2362

13 years ago2007-06-21 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 21 Jun 2007 13:28:14 +0000 (13:28 +0000)]
2007-06-21  Murray Cumming  <murrayc@murrayc.com>

* ossoemailinterface.c: (osso_email_get_folder_list):
Implement this with the new libmodest_dbus_client_get_folders()
function. This should help with projects.maemo.org bug NB#57740.

pmo-trunk-r2361

13 years agoRemoved junk.
Murray Cumming [Thu, 21 Jun 2007 12:46:58 +0000 (12:46 +0000)]
Removed junk.

pmo-trunk-r2360

13 years ago2007-06-21 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 21 Jun 2007 12:42:31 +0000 (12:42 +0000)]
2007-06-21  Murray Cumming  <murrayc@murrayc.com>

* libmodest-dbus-client/libmodest-dbus-client.h:
* libmodest-dbus-client/libmodest-dbus-client.c:
(modest_dbus_message_iter_get_search_hit),
(libmodest_dbus_client_search):
Reorganised and commented this.
Removed modest_search_hit_free() from the public API because it
is not needed.

Added libmodest_dbus_client_get_folders() and
modest_folder_result_list_free().

* src/dbus_api/modest-dbus-api.h:
* src/dbus_api/modest-dbus-callbacks.c:
(modest_dbus_req_filter): Commented. Moved most code to
on_dbus_method_search() and added on_dbus_method_get_folders().

* src/maemo/modest-platform.c: (modest_platform_init): Commented the use
of the extra D-Bus handler.

* tests/dbus_api/Makefile.am:
* tests/dbus_api/test_get_folders.c: New test for
libmodest_dbus_client_get_folders(). This seems to return an empty list
at the moment. That could be the same error that causes the message list
to be empty sometimes.
This should help with projects.maemo.org bug NB#57740.

pmo-trunk-r2358

13 years ago* update
Dirk-Jan C. Binnema [Thu, 21 Jun 2007 12:17:17 +0000 (12:17 +0000)]
* update

pmo-trunk-r2357

13 years ago2007-06-21 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Thu, 21 Jun 2007 11:47:07 +0000 (11:47 +0000)]
2007-06-21  Armin Burgmeier  <armin@openismus.com>

* src/modest-mail-operation.c: Do not call
modest_mail_operation_queue_cancel_all() in _cancel() but do instead
notify the operation's end after having set the status to CANCELED for
the operation queue to listen on. This fixes a deadlock when there
were mail operations in the queue during its finalization.

* src/modest-singletons.c: Reordered uninitialization of the account
manager to happen after the mail operation queue was uninitialized
because the mail operation's in the queue might still try to access
the account manager (see modest_mail_operation_notify_end()). This
fixes a potential crash when terminating the application.

pmo-trunk-r2354

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Thu, 21 Jun 2007 10:53:43 +0000 (10:53 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now "Select all" is dimmed when focus is on an area without anything
          to select (for example, an empty body) (fixes NB#59393).
        * Minor API fix on usage of priority flags.

pmo-trunk-r2353

13 years agoremoved junk
Murray Cumming [Thu, 21 Jun 2007 10:14:44 +0000 (10:14 +0000)]
removed junk

pmo-trunk-r2352

13 years ago2007-06-21 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 21 Jun 2007 10:13:42 +0000 (10:13 +0000)]
2007-06-21  Murray Cumming  <murrayc@murrayc.com>

* src/modest-search.c:
(search_mime_part_and_child_parts): Moved some code here so we
can search recursively in child folders.
(modest_search_folder): Search in the message as a mime part, instead
of just its child mime parts.
(read_chunk), (search_mime_part_ogs):
Check how many bytes were read, to prevent an endless loop.
Searching in message bodies now works. This finishes the fix for
projects.maemo.org bug NB#61007.

pmo-trunk-r2351

13 years ago* src/modest-platform.h:
Jose Dapena Paz [Thu, 21 Jun 2007 09:35:23 +0000 (09:35 +0000)]
* src/modest-platform.h:
        * Added a new platform function for showing information banner. Should
          remove a new dependency in common non specific maemo code.
* src/modest-dimming-rules-group.c:
        * Now it does not use hildon information banner, but the new platform
          equivalent.
* src/modest-ui-actions.c:
        * Now it shows an information banner on copying the messages to outbox
          (fixes NB#59332).
* src/maemo/modest-platform.c:
        * Added implementation of the new information banner platform function,
          that uses the hildon information banner.

pmo-trunk-r2350

13 years ago* Add some utility funcitons to email clipboard to check
Javier Fernandez Garcia-Boente [Thu, 21 Jun 2007 08:45:19 +0000 (08:45 +0000)]
* Add some utility funcitons to email clipboard to check
if changes made on any folder must force to clear clipboard
data.
* Add new dimming rules for paste messages operation.
* Fixes: NB#59395

pmo-trunk-r2349

13 years ago* src/modest-init.c:
Jose Dapena Paz [Thu, 21 Jun 2007 08:37:11 +0000 (08:37 +0000)]
* src/modest-init.c:
        * Now sort values are initialized to useful default values
          (fixes NB#59321).

pmo-trunk-r2348

13 years ago* src/maemo/modest-msg-edit-window-ui.xml:
Jose Dapena Paz [Wed, 20 Jun 2007 17:39:01 +0000 (17:39 +0000)]
* src/maemo/modest-msg-edit-window-ui.xml:
        * Removed delete message action, as it's not in new UI specs
          (fixes NB#59245).

pmo-trunk-r2347

13 years ago* src/maemo/modest-msg-edit-window-ui.xml:
Jose Dapena Paz [Wed, 20 Jun 2007 17:34:00 +0000 (17:34 +0000)]
* src/maemo/modest-msg-edit-window-ui.xml:
        * Removed delete message action, as it's not in new UI specs
          (fixes NB#59245).

pmo-trunk-r2346

13 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Wed, 20 Jun 2007 17:26:29 +0000 (17:26 +0000)]
* src/maemo/modest-main-window.c:
        * Now "send & receive/all" is hidden when there's only one
          account available (fixes NB#59238).

pmo-trunk-r2345

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Wed, 20 Jun 2007 16:49:04 +0000 (16:49 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now it dims remove attachments action when there's no
          attachment selected, and when there are more than one.
          Also added insensitive press messages for both
          (fixes NB#59176).

pmo-trunk-r2344

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Wed, 20 Jun 2007 16:25:05 +0000 (16:25 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now it dims properly the Paste menu option (fixes NB#58809).

pmo-trunk-r2343

13 years ago2007-06-20 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 20 Jun 2007 15:47:22 +0000 (15:47 +0000)]
2007-06-20  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-actions.c: (modest_ui_actions_on_details):
Add a g_warning when the item is not a folder.

* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
when selected item is not a folder (for instance, an account), because
the UI spec only talks about folders.
I am not sure what the UI spec wants, so this might not totally fix
projects.maemo.org bug NB#60794.

pmo-trunk-r2342

13 years ago* src/widgets/modest-header-view.c:
Jose Dapena Paz [Wed, 20 Jun 2007 15:42:31 +0000 (15:42 +0000)]
* src/widgets/modest-header-view.c:
        * Fix sort by priority, as it wasn't comparing the
          fields values properly.
* src/maemo/modest-platform.c:
        * Fix recovering the sort status from header view to
          create the sort dialog.
        * Save the new widget status on finishing the sort
          (fixes NB#58628).
* src/modest-widget-memory.c:
        * Fix the recovering of sort status from header view.

pmo-trunk-r2341

13 years ago2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
Murray Cumming [Wed, 20 Jun 2007 15:03:06 +0000 (15:03 +0000)]
2007-06-20  Murray Cumming  <murrayc@murrayc-desktop>

* src/maemo/easysetup/modest-easysetup-country-combo-box.c:
        (load_from_file): Sort the list. The unsorted list would be more noticeable
        in non-English locales.

        * src/maemo/modest-msg-edit-window.c:
        (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
        warning and fix the build.

        * src/maemo/modest-progress-bar-widget.c:
        (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
        avoid a g_warning, and probably to avoid a crash.

pmo-trunk-r2340

13 years agoAdd some notifications to dimmed rules.
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 14:40:02 +0000 (14:40 +0000)]
Add some notifications to dimmed rules.

pmo-trunk-r2339

13 years ago2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
Murray Cumming [Wed, 20 Jun 2007 14:25:17 +0000 (14:25 +0000)]
2007-06-20  Murray Cumming  <murrayc@murrayc-desktop>

* src/modest-search.c: (modest_search_folder): Check for a GError
        when calling tny_folder_get_headers(), to show that this is not the cause
        of later failure.

pmo-trunk-r2338

13 years ago2007-06-20 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 20 Jun 2007 14:11:31 +0000 (14:11 +0000)]
2007-06-20  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
Actually set the body query instead of the subject query.

* src/modest-search.c: (search_mime_part_ogs),
(search_mime_part_strcmp): Remove extra space from the text/* regex,
which would probably cause it to fail if we got this far.

(modest_search_folder): Use simple #ifdefs instead of the function pointer,
to simplify the code.
Warn when tny_mime_part_get_parts() returns an empty list, which seems to
be causing search-in-body to fail.

pmo-trunk-r2337

13 years ago* src/maemo/modest-address-book.c:
Jose Dapena Paz [Wed, 20 Jun 2007 14:02:17 +0000 (14:02 +0000)]
* src/maemo/modest-address-book.c:
        * Minor change to avoid problems with addressbook init.
* src/maemo/modest-msg-edit-window.c:
        * Support attaching more than one file at a time
          (fixes NB#58614).
* src/maemo/modest-msg-view-window.c:
        * Add an information banner for trying to search an empty
          string.

pmo-trunk-r2336

13 years ago* Increase performance of dimming rules manager, avoiding call
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 13:51:37 +0000 (13:51 +0000)]
* Increase performance of dimming rules manager, avoiding call
get_selected_headers to check if no headers were selected to
perform operation.

pmo-trunk-r2335

13 years ago * Added ending notification to the send_mail operation
Sergio Villar Senin [Wed, 20 Jun 2007 13:36:05 +0000 (13:36 +0000)]
* Added ending notification to the send_mail operation
* Fixed a problem with armin's modest_tny_send_queue code, it was causing a crash due to a g_assert

pmo-trunk-r2334

13 years ago* src/widget/modest-attachments-view.c:
Jose Dapena Paz [Wed, 20 Jun 2007 13:28:26 +0000 (13:28 +0000)]
* src/widget/modest-attachments-view.c:
        * Crashed when there was an attached message with
          a NULL subject. Fixed (fixes NB#61283).

pmo-trunk-r2333

13 years agoAdded listening on an extra signal
Philip Van Hoof [Wed, 20 Jun 2007 13:19:54 +0000 (13:19 +0000)]
Added listening on an extra signal

pmo-trunk-r2332

13 years ago * Added progress information to open single message operation
Sergio Villar Senin [Wed, 20 Jun 2007 11:57:49 +0000 (11:57 +0000)]
* Added progress information to open single message operation
* Added byte information to the ModestMailOperationStatus struct

pmo-trunk-r2331

13 years ago* Fixed problem with focus and move_to operation.
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 11:48:47 +0000 (11:48 +0000)]
* Fixed problem with focus and move_to operation.

pmo-trunk-r2330

13 years ago2007-06-20 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 20 Jun 2007 10:10:19 +0000 (10:10 +0000)]
2007-06-20  Murray Cumming  <murrayc@murrayc.com>

* libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
struct item.
* src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
Better debug message when the folder cannot be found.
This should help with fixing projects.maemo.org bug #61287.
* src/modest-search.c: (add_hit): Do not leak the furl string.

pmo-trunk-r2329

13 years ago * Fixed a lot of reference leaks
Sergio Villar Senin [Wed, 20 Jun 2007 09:45:50 +0000 (09:45 +0000)]
* Fixed a lot of reference leaks
* Fixed a problem when closing the main window

pmo-trunk-r2328

13 years ago* don't make in the po/ directory
Dirk-Jan C. Binnema [Wed, 20 Jun 2007 09:12:19 +0000 (09:12 +0000)]
* don't make in the po/ directory
* add libogs1.2-dev as a dep for debian packaging (maemo1)

pmo-trunk-r2327

13 years ago2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
Murray Cumming [Wed, 20 Jun 2007 08:53:06 +0000 (08:53 +0000)]
2007-06-20  Murray Cumming  <murrayc@murrayc-desktop>

* src/modest-ui-actions.c:
(modest_ui_actions_on_folder_selection_changed):
Do not special-case TNY_MERGE_FOLDER here, because
modest_tny_folder_get_account() already does that. This fixes
projects.maemo.org bug NB#60955 (The smtp connections dialog was not
shown when the Outbox was selected).

pmo-trunk-r2326

13 years ago* set the folder name in instead of the folder-url for the search results
Dirk-Jan C. Binnema [Wed, 20 Jun 2007 08:50:22 +0000 (08:50 +0000)]
* set the folder name in instead of the folder-url for the search results

pmo-trunk-r2325

13 years agoFixes: NB#61019
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 07:52:49 +0000 (07:52 +0000)]
Fixes: NB#61019

pmo-trunk-r2323

13 years ago* Fixes: NB#59203
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 07:12:04 +0000 (07:12 +0000)]
* Fixes: NB#59203

pmo-trunk-r2322

13 years ago* Changes in the localization structure. GETTEXT package is
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 06:47:03 +0000 (06:47 +0000)]
* Changes in the localization structure. GETTEXT package is
configure in configure.ac, checking version of application
in order to use trnaslation packages or .po files.

* Avoid using GTK_WIDGET_HAS_FOCUS to check if some widget has
the focus, because we need to check window local focus, rather
than global focus.

pmo-trunk-r2321

13 years ago2007-06-19 Murray Cumming,,, <murrayc@murrayc-desktop>
Murray Cumming [Tue, 19 Jun 2007 17:16:26 +0000 (17:16 +0000)]
2007-06-19  Murray Cumming,,,  <murrayc@murrayc-desktop>

* libmodest-dbus-client/libmodest-dbus-client.c:
        (_dbus_iter_get_string_or_null): Initialize the string variable in
        case this helps with Dirk's crash.

2007-06-19  Murray Cumming  <murrayc@murrayc.com>

        * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
        though it is not implemented yet (this function is maybe not even used),
        to avoid breaking ABI in future.
        * libmodest-dbus-client/libmodest-dbus-client.c:
        (get_attachments_string): Moved some code into this generic function.
        (libmodest_dbus_client_send_mail): Corrected the documentation. This really
        sends email. It is maybe not used.
        * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
        (on_send_mail): Use attachments.

        * src/widgets/modest-msg-edit-window.h: Improve the documentation.
        * src/maemo/modest-msg-edit-window.c:
        (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
        a filename before using it, to fix projects.maemo.org bug NB#58233.

pmo-trunk-r2319

13 years agoFix for some issues in translation of plural strings (fixes NB#61146).
Jose Dapena Paz [Tue, 19 Jun 2007 16:36:53 +0000 (16:36 +0000)]
Fix for some issues in translation of plural strings (fixes NB#61146).
* src/modest-ui-actions.c:
* src/modest-msg-edit-window.c:
        * Changed translations of plurals to use ngettext.

pmo-trunk-r2318

13 years ago* src/maemo/modest-platform.c:
Jose Dapena Paz [Tue, 19 Jun 2007 15:20:50 +0000 (15:20 +0000)]
* src/maemo/modest-platform.c:
        * (modest_platform_show_uri_popup): now it uses the translation
          domain of the actions (fixes NB#61049).

pmo-trunk-r2316