modest
13 years ago* trivial: make the zoomlevels in the editor follow the UI guidelines.
Dirk-Jan C. Binnema [Sat, 7 Jul 2007 13:19:28 +0000 (13:19 +0000)]
* trivial: make the zoomlevels in the editor follow the UI guidelines.
  fixes: NB#62269

pmo-trunk-r2623

13 years ago2007-07-06 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 6 Jul 2007 21:17:55 +0000 (21:17 +0000)]
2007-07-06  Murray Cumming <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
        Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
        give a more exact error message that can be partly translated.

pmo-trunk-r2622

13 years ago * Added msg-changed signal to the viewer window, to notify about the change in the...
Sergio Villar Senin [Fri, 6 Jul 2007 19:38:21 +0000 (19:38 +0000)]
* Added msg-changed signal to the viewer window, to notify about the change in the message that it is shown
* Fixes NB#62532, only prevent the message currently being shown from deleting

pmo-trunk-r2621

13 years ago* Fixed bug on header-view-render, getting header flags.
Javier Fernandez Garcia-Boente [Fri, 6 Jul 2007 18:03:36 +0000 (18:03 +0000)]
* Fixed bug on header-view-render, getting header flags.

pmo-trunk-r2620

13 years ago* Uncomment flush call to tny_send_queue.
Javier Fernandez Garcia-Boente [Fri, 6 Jul 2007 17:51:08 +0000 (17:51 +0000)]
* Uncomment flush call to tny_send_queue.
* Implement cancel sending operation, seting the
TNY_HEADER_FLAG_SUSPENDED_PRIORITY flag.

pmo-trunk-r2619

13 years ago* src/widgets/modest-attachment-view.c:
Jose Dapena Paz [Fri, 6 Jul 2007 16:26:31 +0000 (16:26 +0000)]
* src/widgets/modest-attachment-view.c:
        * Now purged attachments are shown in grey and italics.

pmo-trunk-r2618

13 years ago* src/widgets/modest-attachment-view.c:
Jose Dapena Paz [Fri, 6 Jul 2007 16:15:40 +0000 (16:15 +0000)]
* src/widgets/modest-attachment-view.c:
        * Now it retrieves the mime part size properly even when it was
          local.

pmo-trunk-r2617

13 years ago* src/modest-mail-operation.c:
Jose Dapena Paz [Fri, 6 Jul 2007 15:59:17 +0000 (15:59 +0000)]
* src/modest-mail-operation.c:
        * Now we store the attachments flag in the header of the
          message to store. This way the attachment gets correctly stored
          in local folders (fixes NB#61809).

pmo-trunk-r2616

13 years ago * Execute all pending gtk+ events before destroying the dialogs
Sergio Villar Senin [Fri, 6 Jul 2007 15:27:32 +0000 (15:27 +0000)]
* Execute all pending gtk+ events before destroying the dialogs

pmo-trunk-r2615

13 years ago* src/widgets/modest-attachment-view.c:
Jose Dapena Paz [Fri, 6 Jul 2007 14:43:49 +0000 (14:43 +0000)]
* src/widgets/modest-attachment-view.c:
        * Count the decoded attachment size instead of the encoded size.
          This should make the size be the expected one (fixes NB#61088).

pmo-trunk-r2614

13 years agoAdded the fixes made on july 6th.
Dirk-Jan C. Binnema [Fri, 6 Jul 2007 14:31:14 +0000 (14:31 +0000)]
Added the fixes made on july 6th.

pmo-trunk-r2613

13 years ago2007-07-06 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 6 Jul 2007 13:52:59 +0000 (13:52 +0000)]
2007-07-06  Murray Cumming  <murrayc@murrayc.com>

* libtinymail/tny-enums.h:
* libtinymail/tny-error.h: Added
TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED,
TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE and
TNY_ACCOUNT_ERROR_TRY_CONNECT_AUTHENTICATION_NOT_SUPPORTED so
that the TnyAccountStore::alert_func() callback can sometimes get
more specific information, so that it doesn't need to just blindly show
the camel internal error message.
* libtinymail/tny-error.c: Updated tny_error_get_type(), though this should be
generated code as in GTK+.

* libtinymail-camel/tny-camel-account-priv.h:
* libtinymail-camel/tny-camel-account.c:
Added _tny_camel_account_get_tny_error_code_for_camel_exception_id() for
choosing a suitable tinymail GError code.
(_tny_camel_account_try_connect), (_tny_camel_account_set_online):
Use a specific error code for the GErrors.

* libtinymail-camel/tny-session-camel.c:
(tny_session_camel_alert_user): Add a TODO noting that this is where we
lose some specific error codes, and where we do a dodgy string comparison
on the message text.

* camel/camel-exception-list.def: Added a
CAMEL_EXCEPTION_SYSTEM_HOST_LOOKUP_FAILED error code enum value.
* camel/camel-net-utils.c: (camel_getaddrinfo):
Use the new error code when appropriate.

pmo-trunk-r2612

13 years agoApplied patch for NB#59107.
Dirk-Jan C. Binnema [Fri, 6 Jul 2007 13:39:12 +0000 (13:39 +0000)]
Applied patch for NB#59107.

pmo-trunk-r2611

13 years agoApplied patch for NB#57631
Dirk-Jan C. Binnema [Fri, 6 Jul 2007 13:38:43 +0000 (13:38 +0000)]
Applied patch for NB#57631

pmo-trunk-r2610

13 years agoApplied the patch sent for NB#59004. changes to en_GB.po and src/maemo/modest-msg...
Dirk-Jan C. Binnema [Fri, 6 Jul 2007 13:33:04 +0000 (13:33 +0000)]
Applied the patch sent for NB#59004. changes to en_GB.po and src/maemo/modest-msg-view-window.c

pmo-trunk-r2609

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Fri, 6 Jul 2007 13:22:09 +0000 (13:22 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Removed all insenstive handlers for menu actions, as we don't show
          insensitive information banners from menus, only from toolbar
* src/widgets/modest-attachments-view.c:
        * Lose selection when the window focus leaves (fixes NB#61455).

pmo-trunk-r2608

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Fri, 6 Jul 2007 11:02:04 +0000 (11:02 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * The base font scale of wpeditor is 1.5, and not one. Then, we multiply
          by 1.5 all the zooms set to the wptextbuffer. This way we get the proper
          font scale.

pmo-trunk-r2607

13 years ago * Fixes NB#57458, now the currently selected folder is refreshed when doing a send...
Sergio Villar Senin [Fri, 6 Jul 2007 10:05:32 +0000 (10:05 +0000)]
* Fixes NB#57458, now the currently selected folder is refreshed when doing a send&receive

pmo-trunk-r2606

13 years ago* Disable notifications for dimmed menu items.
Javier Fernandez Garcia-Boente [Fri, 6 Jul 2007 09:28:52 +0000 (09:28 +0000)]
* Disable notifications for dimmed menu items.
* Fixes: NB#62283, NB#62392, NB#62398, NB#61244, NB#61501

pmo-trunk-r2605

13 years ago* check the parameters for
Dirk-Jan C. Binnema [Fri, 6 Jul 2007 09:13:00 +0000 (09:13 +0000)]
* check the parameters for
   modest_tny_account_store_get_transport_account_for_open_connection
  this fixes the crasher when other applications where invoking email over dbus
  while there were no accounts yet (bug #61676)

pmo-trunk-r2604

13 years ago* unitialize modest-window-mgr before the other singletons, so
Dirk-Jan C. Binnema [Fri, 6 Jul 2007 07:10:51 +0000 (07:10 +0000)]
* unitialize modest-window-mgr before the other singletons, so
  it can still save it's settings etc. in its finalize
  (this was causing GLib-Criticals upon exit in some cases,
  as well as forgetting settings)
* before doing gtk_main_quit in modest-window-mgr, check that we
  haven't already done that (not sure if we actually *ever* should
  call gtk_main_quit there, but at least now this clears up
  another Glib-Critical upon exit in some cases

pmo-trunk-r2603

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Thu, 5 Jul 2007 20:32:12 +0000 (20:32 +0000)]
* src/maemo/modest-msg-view-window.c:
        * (..._find_toolbar_search): invalidate search if there are no
          matches, just as we do with search complete (fixes NB#62257).

pmo-trunk-r2602

13 years agoWork to improve drafts handling, mainly from the UI pov. This, with
Jose Dapena Paz [Thu, 5 Jul 2007 20:23:03 +0000 (20:23 +0000)]
Work to improve drafts handling, mainly from the UI pov. This, with
the last changes in tinymail, fixes NB#62652.
* src/widgets/modest-platform.h, src/maemo/modest-platform.c:
        * Added new function modest_platform_run_yes_no_dialog. It's
          required in some dialogs in specs.
* src/widgets/modest-msg-edit-window.h,
  src/maemo/modest-msg-edit-window.c:
        * New method to set the draft message from outside. This is used
          to properly update the draft message when it's a new one.
        * On setting a new draft message, it replaces the registered
          header in the window manager. This way we can open a drafts
          message more than one time.
* src/widgets/modest-window-mgr.c:
        * Now the save to drafts confirmation dialog shows Yes/no
          alternatives instead of Ok/Cancel.
* src/modest-ui-actions.c:
        * Now, when a draft is saved from the editor, we set the
          created draft as the new draft message of editor. This
          should make saving drafts more than one time work as
          expected.
* src/modest-mail-operation.[ch]:
        * Now ..._save_to_drafts returns the newly created message.

pmo-trunk-r2601

13 years ago* Set focus on next header after drag&drop operaiton.
Javier Fernandez Garcia-Boente [Thu, 5 Jul 2007 19:08:12 +0000 (19:08 +0000)]
* Set focus on next header after drag&drop operaiton.
* Fixes: NB#61502

pmo-trunk-r2600

13 years ago* Delete dimming rule about NON_WRITABLE folders.
Javier Fernandez Garcia-Boente [Thu, 5 Jul 2007 18:36:35 +0000 (18:36 +0000)]
* Delete dimming rule about NON_WRITABLE folders.
* Fixes: NB#62603

pmo-trunk-r2599

13 years ago* Add a new check of toolbar dimming rules
Javier Fernandez Garcia-Boente [Thu, 5 Jul 2007 18:03:53 +0000 (18:03 +0000)]
* Add a new check of toolbar dimming rules
on 'focus-in' event of both, folder view
and headers view windows.
* Fixes: NB#61029

pmo-trunk-r2598

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Thu, 5 Jul 2007 17:34:32 +0000 (17:34 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now constructor checks the folder of the msg parameter.
          Only if it's in a drafts folder, it asigns it to the
          drafts_msg parameter. SHould prevent a warning when
          you save a draft and the message does not come from
          another draft.

pmo-trunk-r2597

13 years ago2007-07-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 5 Jul 2007 16:09:44 +0000 (16:09 +0000)]
2007-07-05  Murray Cumming <murrayc@murrayc.com>

* src/maemo/modest-address-book.c:
        (select_email_addrs_for_contact): Specify a default window size for the
        select-email-address dialog, so that it is probably big enough for the
        title. This should fix projects.maemo.org bug NB#62277.

pmo-trunk-r2596

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Thu, 5 Jul 2007 15:43:06 +0000 (15:43 +0000)]
* src/modest-ui-actions.c:
        * Now we add set_can_store to copy actions, so that the buffer
          survives application end.
        * Removed a typo using a call to header view in clipboard
          handler of text view (removes a runtime warning).
* src/modest-msg-edit-window.c:
        * Register serialize and deserialize target for wp-text-buffer.
          This way we can cut/copy/paste rich text among buffers
          (fixes NB#62365).
        * Now the dimming detection for copy simply detects there's a
          selection available. This way we can properly copy a selection
          with only an image (fixes NB#62416).
* src/modest-main-window.c:
        * Remove rules hint of header view (this way it does not show
          alternate colors for rows, as stated in specs).

pmo-trunk-r2595

13 years ago2007-07-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 5 Jul 2007 14:19:35 +0000 (14:19 +0000)]
2007-07-05  Murray Cumming <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_complete_easysetup): Use
        gtk_widget_set_size() request to ensure that the text wraps
        even in osso 1.1.

pmo-trunk-r2594

13 years ago * Fixes a compilation warning in ARMEL
Sergio Villar Senin [Thu, 5 Jul 2007 14:15:30 +0000 (14:15 +0000)]
* Fixes a compilation warning in ARMEL

pmo-trunk-r2593

13 years ago2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Thu, 5 Jul 2007 14:05:32 +0000 (14:05 +0000)]
2007-07-05  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
(on_entry_invalid_character), (create_page_account_details),
(create_page_user_details):
Use new API of ModestValidatingEntry. But for some reason the banner is
not shown. I will have to investigate that further.

* src/widgets/modest-validating-entry.c: (on_insert_text),
(modest_validating_entry_set_func):
* src/widgets/modest-validating-entry.h:
Added a new callback function to be able to react to prevented
characters whitespaces to e.g show a banner.

pmo-trunk-r2592

13 years ago2007-07-05 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Thu, 5 Jul 2007 13:53:08 +0000 (13:53 +0000)]
2007-07-05  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-account-settings-dialog.c: Use the notify::value
notification of HildonNumberEditor instead of remembering the port
number. Thanks to Johannes for pointing this out.

pmo-trunk-r2591

13 years agoAdded the fixes made on w27, day 4.
Dirk-Jan C. Binnema [Thu, 5 Jul 2007 13:32:59 +0000 (13:32 +0000)]
Added the fixes made on w27, day 4.

pmo-trunk-r2590

13 years agofixed bug number...
Johannes Schmid [Thu, 5 Jul 2007 13:32:41 +0000 (13:32 +0000)]
fixed bug number...

pmo-trunk-r2589

13 years ago2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Thu, 5 Jul 2007 13:28:10 +0000 (13:28 +0000)]
2007-07-05  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
Check if there are any user changes before showing a confirmation
dialog (projects.maemo.org NB#59361)

pmo-trunk-r2588

13 years agoAdded an extra folder to be looked into to confirm with the changes made to osso...
Dirk-Jan C. Binnema [Thu, 5 Jul 2007 13:24:11 +0000 (13:24 +0000)]
Added an extra folder to be looked into to confirm with the changes made to osso-af-settings.

pmo-trunk-r2587

13 years ago2007-07-05 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Thu, 5 Jul 2007 12:58:00 +0000 (12:58 +0000)]
2007-07-05  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-account-settings-dialog.c: Remember custom port
number at the beginning of the dialog and set the modified flag at the
end if the port number has changed. This is necessary because
HildonNumberEditor does not support notification when the value has
changed.

pmo-trunk-r2586

13 years ago * Changed the signature of the refresh folder callback. This will allow us to know...
Sergio Villar Senin [Thu, 5 Jul 2007 11:16:27 +0000 (11:16 +0000)]
* Changed the signature of the refresh folder callback. This will allow us to know if the operation was a success or not

pmo-trunk-r2585

13 years ago* Change save_settings call of main and viewer windows to
Javier Fernandez Garcia-Boente [Thu, 5 Jul 2007 10:37:37 +0000 (10:37 +0000)]
* Change save_settings call of main and viewer windows to
'delete-event' signal handler at modest-window-mgr.
* Review Copy menu item dimming rules.
* Fixes: NB#62502, NB#62342

pmo-trunk-r2584

13 years agoRenamed a symbol that has changed in tinymail
Philip Van Hoof [Thu, 5 Jul 2007 10:05:34 +0000 (10:05 +0000)]
Renamed a symbol that has changed in tinymail

pmo-trunk-r2583

13 years ago2007-07-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 5 Jul 2007 09:56:15 +0000 (09:56 +0000)]
2007-07-05  Murray Cumming <murrayc@murrayc.com>

* src/modest-ui-actions.c:
(modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
a connection before asking anything else. Correct the check for the destination
folder so that it succeeds when online.
This fixed projects.maemo.org bug NB#61645.

pmo-trunk-r2582

13 years ago2007-07-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 5 Jul 2007 09:41:39 +0000 (09:41 +0000)]
2007-07-05  Murray Cumming <murrayc@murrayc.com>

* src/modest-ui-actions.c: (modest_ui_actions_on_send):
Call modest_platform_connect_and_wait() to ask for a connection if necessary,
to fix projects.maemo.org bug NB#62439.

pmo-trunk-r2581

13 years ago2007-07-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 5 Jul 2007 07:11:41 +0000 (07:11 +0000)]
2007-07-05  Murray Cumming <murrayc@murrayc.com>

* src/modest-tny-account.c: (on_connection_status_changed):
Really do not use tny_device_force_offline() here. See the previous comment.

pmo-trunk-r2580

13 years ago* show the size unit correctly for the local Total size
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 17:59:51 +0000 (17:59 +0000)]
* show the size unit correctly for the local Total size
  Fixes: NB#62594

(the bug is about MCC folders, but this issues applies to
   all local folders)

pmo-trunk-r2579

13 years ago2007-07-04 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 4 Jul 2007 17:37:38 +0000 (17:37 +0000)]
2007-07-04  Murray Cumming <murrayc@murrayc.com>

* src/modest-tny-account.c: (on_connection_status_changed):
        Do not use tny_device_force_offline() when tinymail says that something
        went wrong with the connection. It seems to report this unnecessarily.

pmo-trunk-r2578

13 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Wed, 4 Jul 2007 17:35:28 +0000 (17:35 +0000)]
* src/maemo/modest-main-window.c:
        * Now proper Contextual menus for header view
          are shown, depending on the type of folder (drafts, sent,
          outbox, inbox...) (fixes NB#60352, NB#60355, NB#60356).

pmo-trunk-r2577

13 years ago* closing ModestMsgEditWindows with attachments no longer crashes modest
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 17:28:27 +0000 (17:28 +0000)]
* closing ModestMsgEditWindows  with attachments no longer crashes modest
  there was some confusion when TnyMimeParts were treated as gchar*s....

Fixes: NB#62598

pmo-trunk-r2576

13 years ago* copy the list of attachments; this fixes the first
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 17:02:33 +0000 (17:02 +0000)]
* copy the list of attachments; this fixes the first
  crash when closing a edit window with a message with an attachment

pmo-trunk-r2575

13 years ago2007-07-04 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 4 Jul 2007 16:58:03 +0000 (16:58 +0000)]
2007-07-04  Murray Cumming <murrayc@murrayc.com>

* src/maemo/modest-connection-specific-smtp-window.c:
(modest_connection_specific_smtp_window_init):
Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
does not seem to have any effect in osso 1.1 (though it works in
Maemo Bora). This fixes bug projects.maemo.org NB#59212.

pmo-trunk-r2574

13 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Wed, 4 Jul 2007 16:15:36 +0000 (16:15 +0000)]
* src/widgets/modest-folder-view.c:
        * Now folders get proper expanded/collapsed emblems. This
          way we can know if a folder has children (fixes NB#60310).

pmo-trunk-r2573

13 years agoAdded new bugs, bulding package for w27-04-1830.
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 15:35:02 +0000 (15:35 +0000)]
Added new bugs, bulding package for w27-04-1830.

pmo-trunk-r2572

13 years ago2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 4 Jul 2007 15:31:24 +0000 (15:31 +0000)]
2007-07-04  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/modest-connection-specific-smtp-window.c:
Fix UI specification problems with projects.meamo.org NB#60479

pmo-trunk-r2571

13 years ago2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 4 Jul 2007 14:58:09 +0000 (14:58 +0000)]
2007-07-04  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/modest-connection-specific-smtp-window.c:
Fix UI specification problems with projects.meamo.org NB#60479

pmo-trunk-r2570

13 years ago2007-07-04 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 4 Jul 2007 14:23:38 +0000 (14:23 +0000)]
2007-07-04   Murray Cumming <murrayc@murrayc.com>

* src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
clue when this has failed, because the error dialog is not always shown
(at least in earlier version).

(modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
GError message, because the generic error dialog is not helpful.
I am getting
'This message is not currently available (can't let a new connection go online)'
when trying to open an IMAP message.

(_modest_ui_actions_open): Offer a connection when some messages would
have to be downloaded and we are offline.

pmo-trunk-r2569

13 years ago2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 4 Jul 2007 14:01:11 +0000 (14:01 +0000)]
2007-07-04  Johannes Schmid <johannes.schmid@openismus.com>

* src/widgets/modest-folder-view.c:
Don\'t check for MERGE type anymore as we use the correct type
now.
NOTE: For the last two changes you need to update your tinymail copy
because of API changes!

pmo-trunk-r2568

13 years ago2007-07-04 Johanens Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 4 Jul 2007 13:48:47 +0000 (13:48 +0000)]
2007-07-04  Johanens Schmid <johannes.schmid@openismus.com>

* src/modest-tny-local-folders-account.c:
Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
(see projects.maemo.org NB#61580)

pmo-trunk-r2567

13 years agoCorrected the versioning mistake.
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 13:43:44 +0000 (13:43 +0000)]
Corrected the versioning mistake.

pmo-trunk-r2566

13 years ago * Added a method to unregister a header in the window manager in case of error
Sergio Villar Senin [Wed, 4 Jul 2007 13:37:34 +0000 (13:37 +0000)]
* Added a method to unregister a header in the window manager in case of error
* Changed the way the information dialogs are shown, now they do not use gtk_dialog_run
* Refactored the code that opens a message in the msg view window
* Refactored the code that asks the user for a download approval
* Reverted some changes in the modest_mail_operation_get_msg, the callback must be always called even in case of error
* Modified all the modest_mail_operation_get_msg callbacks to handle properly errors in the mail operation

pmo-trunk-r2565

13 years agoAdded new fixes made.
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 13:23:30 +0000 (13:23 +0000)]
Added new fixes made.

pmo-trunk-r2564

13 years agoAdded redo in editor (fixes NB#60257).
Jose Dapena Paz [Wed, 4 Jul 2007 13:13:10 +0000 (13:13 +0000)]
Added redo in editor (fixes NB#60257).
* src/widget/modest-msg-edit-window.h,
src/maemo/modest-msg-edit-window.c:
        * Added implementation for redo action, using wpeditor backend.
* src/widgets/modest-msg-edit-window-ui.h:
        * Added redo action.
* src/modest-ui-actions.[ch]:
        * Added redo ui action with implementation for editor.
* src/maemo/ui/modest-msg-edit-window-ui.xml:
        * Added redo action.

pmo-trunk-r2563

13 years ago2007-07-04 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 4 Jul 2007 12:51:40 +0000 (12:51 +0000)]
2007-07-04  Murray Cumming <murrayc@murrayc.com>

* src/modest-tny-account.c: (on_connection_status_changed):
Commented out the call to modest_platform_connect_and_wait() because this
seems to always hang, and I would like to know if this is the only thing
that causes a hang when showing the connection dialog.
It is not very useful anyway.

pmo-trunk-r2562

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Wed, 4 Jul 2007 12:37:50 +0000 (12:37 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Now we show a confirmation dialog for "next message"
          and "previous message" actions, when the message is
          not currently cached (fixes NB#59472).

pmo-trunk-r2561

13 years ago2007-07-04 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 4 Jul 2007 10:12:09 +0000 (10:12 +0000)]
2007-07-04  Murray Cumming <murrayc@murrayc.com>

* src/maemo/modest-msg-view-window.c:
(modest_msg_view_window_select_next_message):

* src/modest-platform.h:
* src/maemo/modest-platform.c:
Added modest_platform_connect_and_wait(), which calls
tny_maemo_conic_device_connect() always in the main thread, by calling it
in an idle handler and waiting for the idle handler to run. It should be
in the main thread because it uses GTK+ UI code. It just returns TRUE
if the device is already online.

There is some nasty code to ensure that subsequent calls to
modest_platform_connect_and_wait() just wait for the first one to finish,
by checking repeatedly in another idle handler. This is necessary,
because other threads (or even the main thread, via another idle handler)
can call modest_platform_connect_and_wait() while
modest_platform_connect_and_wait() is running.

(modest_platform_connect_and_wait_if_network_account),
(modest_platform_connect_and_wait_if_network_folderstore):
Convenience functions that calls modest_platform_connect_and_wait() if
the account or folder might want network access.

* src/modest-mail-operation.c:
(modest_mail_operation_update_account):
* src/modest-ui-actions.c: (download_uncached_messages),
(modest_ui_actions_on_rename_folder), (delete_folder),
(modest_ui_actions_on_main_window_move_to),
(modest_ui_actions_on_msg_view_window_move_to):
* src/widgets/modest-folder-view.c:
(drag_and_drop_from_folder_view):
Offer a connection if we are offline.

* src/modest-tny-account.c: (on_connection_status_changed):
Document this as only handling errors during network operations in progress,
and replace the idle code with a simple call to
modest_platform_connect_and_wait(), which does this instead.

pmo-trunk-r2560

13 years ago* Changes on xfer_folder async mail operation to add two new
Javier Fernandez Garcia-Boente [Wed, 4 Jul 2007 09:12:05 +0000 (09:12 +0000)]
* Changes on xfer_folder async mail operation to add two new
parameters (user callback function).
* Add a new user callback funciton to destroy ifnromation
banner about progress of paste operation.
* Fixes: NB#62302

pmo-trunk-r2559

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 3 Jul 2007 23:15:46 +0000 (23:15 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * If you try to move to plain text, but do not confirm
          the action, the menu radio action should return to plain
          text (fixes NB#60650).

pmo-trunk-r2558

13 years ago* src/modest-text-utils.[ch]:
Jose Dapena Paz [Tue, 3 Jul 2007 22:44:33 +0000 (22:44 +0000)]
* src/modest-text-utils.[ch]:
        * Now validate_email_address and validate_recipient also
          return the position of the invalid char in case validation
          failed because of this.
        * Added & as invalid character.
* src/maemo/modest-address-book.c:
        * Now we show a proper information banner when we enter invalid
          characters (fixes NB#59494).

pmo-trunk-r2557

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Tue, 3 Jul 2007 21:10:47 +0000 (21:10 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Fixed a crash after scrolling up/down with keyboard the
          msg view. I forgot to provide a receptor for return value
          of a signal emition (fixes NB#62434).

pmo-trunk-r2556

13 years ago* fix some memory leaks (valgrind helps)
Dirk-Jan C. Binnema [Tue, 3 Jul 2007 20:06:02 +0000 (20:06 +0000)]
* fix some memory leaks (valgrind helps)

pmo-trunk-r2555

13 years ago* src/maemo/modest-maemo-global-settings-dialog.c:
Jose Dapena Paz [Tue, 3 Jul 2007 16:03:53 +0000 (16:03 +0000)]
* src/maemo/modest-maemo-global-settings-dialog.c:
* Now minimum and maximum values information banners use the
  correct translation domain (fixes NB#62471).

pmo-trunk-r2554

13 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Tue, 3 Jul 2007 15:58:44 +0000 (15:58 +0000)]
* src/modest-ui-dimming-rules.c:
* Now unable to paste message is obtained from the correct
  translation domain (fixes NB#62441).

pmo-trunk-r2553

13 years ago* src/modest-tny-msg.c:
Jose Dapena Paz [Tue, 3 Jul 2007 15:54:14 +0000 (15:54 +0000)]
* src/modest-tny-msg.c:
        * Now copy the mime parts of TnyMsg attachments. This does not fix
          the problem with forwarding attached messages, but at least now
          the contents are forwarded (in a bad format unfortunately).

pmo-trunk-r2552

13 years agoUpgraded the version number for integration.
Dirk-Jan C. Binnema [Tue, 3 Jul 2007 14:18:35 +0000 (14:18 +0000)]
Upgraded the version number for integration.

pmo-trunk-r2551

13 years agoAdded all the bugs sent by the testers.
Dirk-Jan C. Binnema [Tue, 3 Jul 2007 11:57:03 +0000 (11:57 +0000)]
Added all the bugs sent by the testers.

pmo-trunk-r2549

13 years ago2007-07-03 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 3 Jul 2007 11:39:52 +0000 (11:39 +0000)]
2007-07-03  Murray Cumming <murrayc@murrayc.com>

* src/modest-tny-account.c:
        (modest_tny_account_get_special_folder): (util_on_idle),
        Handle the GError so we can see when tny_folder_store_get_folders()
        fails, as it currently does while something else is connecting.

        Added util_run_in_main_thread_and_wait()
        which uses an idlen handler and mainloop to ensure that the function
        is called in the main thread.
        (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
        to make sure that we call attempt the connection in the mainloop only,
        which might solve some hangs.

pmo-trunk-r2548

13 years ago * Commented some code that is causing a hang on the device, we still need to investi...
Sergio Villar Senin [Tue, 3 Jul 2007 11:26:53 +0000 (11:26 +0000)]
* Commented some code that is causing a hang on the device, we still need to investigate a little bit more why it was happening
* Changed the nofify_end function, it does not need the locking because the signal handlers are executed into the main lock

pmo-trunk-r2547

13 years ago * Commented some code that seems to be unmaintained, and that causes a crash in...
Sergio Villar Senin [Tue, 3 Jul 2007 11:14:58 +0000 (11:14 +0000)]
* Commented some code that seems to be unmaintained, and that causes a crash in the device

pmo-trunk-r2546

13 years ago* fix for #62336
Dirk-Jan C. Binnema [Tue, 3 Jul 2007 10:16:22 +0000 (10:16 +0000)]
* fix for #62336

pmo-trunk-r2545

13 years ago2007-07-03 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 3 Jul 2007 10:05:33 +0000 (10:05 +0000)]
2007-07-03  Murray Cumming <murrayc@murrayc.com>

(modest_tny_account_store_get_tny_account_by): Do not allow accounts to
        be found by their display name. This is never useful.
        * src/modest-tny-account-store.c: (on_account_removed): Find the account
        by its ID, instead of trying to use its ID as its display name.

        * src/modest-tny-account-store.h:
        * src/modest-tny-account.c:
        (modest_tny_account_get_special_folder): Add a g_warning() when
        tny_folder_store_get_folders() returns an empty list for the maildir.

        * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
        Add a g_warning() when this returns NULL, because that it not allowed
        by tinymail.

pmo-trunk-r2544

13 years ago2007-07-02 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Mon, 2 Jul 2007 21:16:20 +0000 (21:16 +0000)]
2007-07-02  Armin Burgmeier  <armin@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
note when trying to cancel the wizard. This fixes projects.maemo.org
bug NB#60946.

pmo-trunk-r2543

13 years ago* small cleanup + fix runtime gtk warning
Dirk-Jan C. Binnema [Mon, 2 Jul 2007 19:05:14 +0000 (19:05 +0000)]
* small cleanup + fix runtime gtk warning

pmo-trunk-r2542

13 years ago * This and another previous changes fixes NB#61982
Sergio Villar Senin [Mon, 2 Jul 2007 18:03:48 +0000 (18:03 +0000)]
* This and another previous changes fixes NB#61982

pmo-trunk-r2541

13 years agoFixed some bugs in Escape HW key managment.
Javier Fernandez Garcia-Boente [Mon, 2 Jul 2007 17:46:33 +0000 (17:46 +0000)]
Fixed some bugs in Escape HW key managment.

pmo-trunk-r2540

13 years ago* src/maemo/modest-platform.c:
Jose Dapena Paz [Mon, 2 Jul 2007 17:28:32 +0000 (17:28 +0000)]
* src/maemo/modest-platform.c:
        * (modest_platform_get_icon_name): now gnome-mime-message
          and gnome-mime-message-rfc822 obtain the modest app icon
          (fixes NB#58262).

pmo-trunk-r2539

13 years ago* Fixes: NB#61649
Javier Fernandez Garcia-Boente [Mon, 2 Jul 2007 17:06:28 +0000 (17:06 +0000)]
* Fixes: NB#61649

pmo-trunk-r2538

13 years ago * Fixed a crash when removing messages from the viewer
Sergio Villar Senin [Mon, 2 Jul 2007 16:47:45 +0000 (16:47 +0000)]
* Fixed a crash when removing messages from the viewer
* When removing messages from the viewer, if there are more messages, go to the next

pmo-trunk-r2537

13 years agoUpdated the changelog with the Fixes made.
Dirk-Jan C. Binnema [Mon, 2 Jul 2007 16:11:37 +0000 (16:11 +0000)]
Updated the changelog with the Fixes made.

pmo-trunk-r2536

13 years agoReverted
Murray Cumming [Mon, 2 Jul 2007 16:11:14 +0000 (16:11 +0000)]
Reverted

pmo-trunk-r2535

13 years ago* commented out the stuff that depends on the w27 gtkhtml for now
Dirk-Jan C. Binnema [Mon, 2 Jul 2007 15:19:43 +0000 (15:19 +0000)]
* commented out the stuff that depends on the w27 gtkhtml for now

pmo-trunk-r2534

13 years ago2007-07-02 Murray Cumming <murrayc@murrayc.com
Murray Cumming [Mon, 2 Jul 2007 14:50:40 +0000 (14:50 +0000)]
2007-07-02  Murray Cumming  <murrayc@murrayc.com

* src/modest-tny-account.c: Added util_run_in_main_thread_and_wait()
which uses an idlen handler and mainloop to ensure that the function
is called in the main thread.
(on_connection_status_changed): Use util_run_in_main_thread_and_wait()
to make sure that we call attempt the connection in the mainloop only,
which might solve some hangs.

pmo-trunk-r2533

13 years ago* src/maemo/modest-main-window-ui.h:
Jose Dapena Paz [Mon, 2 Jul 2007 14:28:10 +0000 (14:28 +0000)]
* src/maemo/modest-main-window-ui.h:
        * Now Email/New menu option is shown as Email/New message
          as requested in specs (NB#60222).

pmo-trunk-r2532

13 years ago* make the second row in the header list grey; thus it's closer to the
Dirk-Jan C. Binnema [Mon, 2 Jul 2007 14:23:00 +0000 (14:23 +0000)]
* make the second row in the header list grey; thus it's closer to the
  the details of the ui spec

pmo-trunk-r2531

13 years ago* src/widgets/modest-msg-view.c:
Jose Dapena Paz [Mon, 2 Jul 2007 14:11:29 +0000 (14:11 +0000)]
* src/widgets/modest-msg-view.c:
        * Now that gtkhtml0 includes a way to get selected area,
          activate the scroll on finding in page in view
          (fixes NB#58611).

pmo-trunk-r2530

13 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Mon, 2 Jul 2007 11:46:01 +0000 (11:46 +0000)]
* src/maemo/modest-main-window.c:
        * Now moving with keyboard focus from folder view to header
          view updates the window title properly (fixes NB#61023).

pmo-trunk-r2529

13 years ago* src/widgets/modest-window.c:
Jose Dapena Paz [Mon, 2 Jul 2007 11:32:12 +0000 (11:32 +0000)]
* src/widgets/modest-window.c:
        * Fix keyboard handling.

pmo-trunk-r2528

13 years ago2007-07-02 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 2 Jul 2007 10:59:32 +0000 (10:59 +0000)]
2007-07-02  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account.h:
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account),
(modest_tny_account_new_from_server_account_name),
(modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
because this must now be set before setting the proto. This is usd in
modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
warning in camel_session_get_service() caused by
tny_camel_transport_account_prepare().

* src/modest-tny-account-store.c: (get_server_accounts): Pass the new
session parameter.

pmo-trunk-r2527

13 years ago * Fixes NB#62003, application do not longer hang when forwarding messages
Sergio Villar Senin [Mon, 2 Jul 2007 10:57:12 +0000 (10:57 +0000)]
* Fixes NB#62003, application do not longer hang when forwarding messages
* the reply_forward_cb only allows now to reply/forward more than one mail, did that in order to get progress information, while get_msgs_full is not migrated to use the async calls to tinymail

pmo-trunk-r2526

13 years ago* add checks that session != NULL
Dirk-Jan C. Binnema [Mon, 2 Jul 2007 10:50:19 +0000 (10:50 +0000)]
* add checks that session != NULL

pmo-trunk-r2525

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 2 Jul 2007 10:33:46 +0000 (10:33 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Added insensitve information banner for copy menu action. Fixes NB#60661.

pmo-trunk-r2524

13 years ago* fix removing of messages:
Dirk-Jan C. Binnema [Mon, 2 Jul 2007 10:10:48 +0000 (10:10 +0000)]
* fix removing of messages:
  for imap folders: mark as deleted, for pop, local: really remove

pmo-trunk-r2523