modest
13 years ago* Change save_settings call of main and viewer windows to
Javier Fernandez Garcia-Boente [Thu, 5 Jul 2007 10:37:37 +0000 (10:37 +0000)]
* Change save_settings call of main and viewer windows to
'delete-event' signal handler at modest-window-mgr.
* Review Copy menu item dimming rules.
* Fixes: NB#62502, NB#62342

pmo-trunk-r2584

13 years agoRenamed a symbol that has changed in tinymail
Philip Van Hoof [Thu, 5 Jul 2007 10:05:34 +0000 (10:05 +0000)]
Renamed a symbol that has changed in tinymail

pmo-trunk-r2583

13 years ago2007-07-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 5 Jul 2007 09:56:15 +0000 (09:56 +0000)]
2007-07-05  Murray Cumming <murrayc@murrayc.com>

* src/modest-ui-actions.c:
(modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
a connection before asking anything else. Correct the check for the destination
folder so that it succeeds when online.
This fixed projects.maemo.org bug NB#61645.

pmo-trunk-r2582

13 years ago2007-07-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 5 Jul 2007 09:41:39 +0000 (09:41 +0000)]
2007-07-05  Murray Cumming <murrayc@murrayc.com>

* src/modest-ui-actions.c: (modest_ui_actions_on_send):
Call modest_platform_connect_and_wait() to ask for a connection if necessary,
to fix projects.maemo.org bug NB#62439.

pmo-trunk-r2581

13 years ago2007-07-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 5 Jul 2007 07:11:41 +0000 (07:11 +0000)]
2007-07-05  Murray Cumming <murrayc@murrayc.com>

* src/modest-tny-account.c: (on_connection_status_changed):
Really do not use tny_device_force_offline() here. See the previous comment.

pmo-trunk-r2580

13 years ago* show the size unit correctly for the local Total size
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 17:59:51 +0000 (17:59 +0000)]
* show the size unit correctly for the local Total size
  Fixes: NB#62594

(the bug is about MCC folders, but this issues applies to
   all local folders)

pmo-trunk-r2579

13 years ago2007-07-04 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 4 Jul 2007 17:37:38 +0000 (17:37 +0000)]
2007-07-04  Murray Cumming <murrayc@murrayc.com>

* src/modest-tny-account.c: (on_connection_status_changed):
        Do not use tny_device_force_offline() when tinymail says that something
        went wrong with the connection. It seems to report this unnecessarily.

pmo-trunk-r2578

13 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Wed, 4 Jul 2007 17:35:28 +0000 (17:35 +0000)]
* src/maemo/modest-main-window.c:
        * Now proper Contextual menus for header view
          are shown, depending on the type of folder (drafts, sent,
          outbox, inbox...) (fixes NB#60352, NB#60355, NB#60356).

pmo-trunk-r2577

13 years ago* closing ModestMsgEditWindows with attachments no longer crashes modest
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 17:28:27 +0000 (17:28 +0000)]
* closing ModestMsgEditWindows  with attachments no longer crashes modest
  there was some confusion when TnyMimeParts were treated as gchar*s....

Fixes: NB#62598

pmo-trunk-r2576

13 years ago* copy the list of attachments; this fixes the first
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 17:02:33 +0000 (17:02 +0000)]
* copy the list of attachments; this fixes the first
  crash when closing a edit window with a message with an attachment

pmo-trunk-r2575

13 years ago2007-07-04 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 4 Jul 2007 16:58:03 +0000 (16:58 +0000)]
2007-07-04  Murray Cumming <murrayc@murrayc.com>

* src/maemo/modest-connection-specific-smtp-window.c:
(modest_connection_specific_smtp_window_init):
Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
does not seem to have any effect in osso 1.1 (though it works in
Maemo Bora). This fixes bug projects.maemo.org NB#59212.

pmo-trunk-r2574

13 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Wed, 4 Jul 2007 16:15:36 +0000 (16:15 +0000)]
* src/widgets/modest-folder-view.c:
        * Now folders get proper expanded/collapsed emblems. This
          way we can know if a folder has children (fixes NB#60310).

pmo-trunk-r2573

13 years agoAdded new bugs, bulding package for w27-04-1830.
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 15:35:02 +0000 (15:35 +0000)]
Added new bugs, bulding package for w27-04-1830.

pmo-trunk-r2572

13 years ago2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 4 Jul 2007 15:31:24 +0000 (15:31 +0000)]
2007-07-04  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/modest-connection-specific-smtp-window.c:
Fix UI specification problems with projects.meamo.org NB#60479

pmo-trunk-r2571

13 years ago2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 4 Jul 2007 14:58:09 +0000 (14:58 +0000)]
2007-07-04  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/modest-connection-specific-smtp-window.c:
Fix UI specification problems with projects.meamo.org NB#60479

pmo-trunk-r2570

13 years ago2007-07-04 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 4 Jul 2007 14:23:38 +0000 (14:23 +0000)]
2007-07-04   Murray Cumming <murrayc@murrayc.com>

* src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
clue when this has failed, because the error dialog is not always shown
(at least in earlier version).

(modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
GError message, because the generic error dialog is not helpful.
I am getting
'This message is not currently available (can't let a new connection go online)'
when trying to open an IMAP message.

(_modest_ui_actions_open): Offer a connection when some messages would
have to be downloaded and we are offline.

pmo-trunk-r2569

13 years ago2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 4 Jul 2007 14:01:11 +0000 (14:01 +0000)]
2007-07-04  Johannes Schmid <johannes.schmid@openismus.com>

* src/widgets/modest-folder-view.c:
Don\'t check for MERGE type anymore as we use the correct type
now.
NOTE: For the last two changes you need to update your tinymail copy
because of API changes!

pmo-trunk-r2568

13 years ago2007-07-04 Johanens Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 4 Jul 2007 13:48:47 +0000 (13:48 +0000)]
2007-07-04  Johanens Schmid <johannes.schmid@openismus.com>

* src/modest-tny-local-folders-account.c:
Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
(see projects.maemo.org NB#61580)

pmo-trunk-r2567

13 years agoCorrected the versioning mistake.
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 13:43:44 +0000 (13:43 +0000)]
Corrected the versioning mistake.

pmo-trunk-r2566

13 years ago * Added a method to unregister a header in the window manager in case of error
Sergio Villar Senin [Wed, 4 Jul 2007 13:37:34 +0000 (13:37 +0000)]
* Added a method to unregister a header in the window manager in case of error
* Changed the way the information dialogs are shown, now they do not use gtk_dialog_run
* Refactored the code that opens a message in the msg view window
* Refactored the code that asks the user for a download approval
* Reverted some changes in the modest_mail_operation_get_msg, the callback must be always called even in case of error
* Modified all the modest_mail_operation_get_msg callbacks to handle properly errors in the mail operation

pmo-trunk-r2565

13 years agoAdded new fixes made.
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 13:23:30 +0000 (13:23 +0000)]
Added new fixes made.

pmo-trunk-r2564

13 years agoAdded redo in editor (fixes NB#60257).
Jose Dapena Paz [Wed, 4 Jul 2007 13:13:10 +0000 (13:13 +0000)]
Added redo in editor (fixes NB#60257).
* src/widget/modest-msg-edit-window.h,
src/maemo/modest-msg-edit-window.c:
        * Added implementation for redo action, using wpeditor backend.
* src/widgets/modest-msg-edit-window-ui.h:
        * Added redo action.
* src/modest-ui-actions.[ch]:
        * Added redo ui action with implementation for editor.
* src/maemo/ui/modest-msg-edit-window-ui.xml:
        * Added redo action.

pmo-trunk-r2563

13 years ago2007-07-04 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 4 Jul 2007 12:51:40 +0000 (12:51 +0000)]
2007-07-04  Murray Cumming <murrayc@murrayc.com>

* src/modest-tny-account.c: (on_connection_status_changed):
Commented out the call to modest_platform_connect_and_wait() because this
seems to always hang, and I would like to know if this is the only thing
that causes a hang when showing the connection dialog.
It is not very useful anyway.

pmo-trunk-r2562

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Wed, 4 Jul 2007 12:37:50 +0000 (12:37 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Now we show a confirmation dialog for "next message"
          and "previous message" actions, when the message is
          not currently cached (fixes NB#59472).

pmo-trunk-r2561

13 years ago2007-07-04 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 4 Jul 2007 10:12:09 +0000 (10:12 +0000)]
2007-07-04  Murray Cumming <murrayc@murrayc.com>

* src/maemo/modest-msg-view-window.c:
(modest_msg_view_window_select_next_message):

* src/modest-platform.h:
* src/maemo/modest-platform.c:
Added modest_platform_connect_and_wait(), which calls
tny_maemo_conic_device_connect() always in the main thread, by calling it
in an idle handler and waiting for the idle handler to run. It should be
in the main thread because it uses GTK+ UI code. It just returns TRUE
if the device is already online.

There is some nasty code to ensure that subsequent calls to
modest_platform_connect_and_wait() just wait for the first one to finish,
by checking repeatedly in another idle handler. This is necessary,
because other threads (or even the main thread, via another idle handler)
can call modest_platform_connect_and_wait() while
modest_platform_connect_and_wait() is running.

(modest_platform_connect_and_wait_if_network_account),
(modest_platform_connect_and_wait_if_network_folderstore):
Convenience functions that calls modest_platform_connect_and_wait() if
the account or folder might want network access.

* src/modest-mail-operation.c:
(modest_mail_operation_update_account):
* src/modest-ui-actions.c: (download_uncached_messages),
(modest_ui_actions_on_rename_folder), (delete_folder),
(modest_ui_actions_on_main_window_move_to),
(modest_ui_actions_on_msg_view_window_move_to):
* src/widgets/modest-folder-view.c:
(drag_and_drop_from_folder_view):
Offer a connection if we are offline.

* src/modest-tny-account.c: (on_connection_status_changed):
Document this as only handling errors during network operations in progress,
and replace the idle code with a simple call to
modest_platform_connect_and_wait(), which does this instead.

pmo-trunk-r2560

13 years ago* Changes on xfer_folder async mail operation to add two new
Javier Fernandez Garcia-Boente [Wed, 4 Jul 2007 09:12:05 +0000 (09:12 +0000)]
* Changes on xfer_folder async mail operation to add two new
parameters (user callback function).
* Add a new user callback funciton to destroy ifnromation
banner about progress of paste operation.
* Fixes: NB#62302

pmo-trunk-r2559

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 3 Jul 2007 23:15:46 +0000 (23:15 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * If you try to move to plain text, but do not confirm
          the action, the menu radio action should return to plain
          text (fixes NB#60650).

pmo-trunk-r2558

13 years ago* src/modest-text-utils.[ch]:
Jose Dapena Paz [Tue, 3 Jul 2007 22:44:33 +0000 (22:44 +0000)]
* src/modest-text-utils.[ch]:
        * Now validate_email_address and validate_recipient also
          return the position of the invalid char in case validation
          failed because of this.
        * Added & as invalid character.
* src/maemo/modest-address-book.c:
        * Now we show a proper information banner when we enter invalid
          characters (fixes NB#59494).

pmo-trunk-r2557

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Tue, 3 Jul 2007 21:10:47 +0000 (21:10 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Fixed a crash after scrolling up/down with keyboard the
          msg view. I forgot to provide a receptor for return value
          of a signal emition (fixes NB#62434).

pmo-trunk-r2556

13 years ago* fix some memory leaks (valgrind helps)
Dirk-Jan C. Binnema [Tue, 3 Jul 2007 20:06:02 +0000 (20:06 +0000)]
* fix some memory leaks (valgrind helps)

pmo-trunk-r2555

13 years ago* src/maemo/modest-maemo-global-settings-dialog.c:
Jose Dapena Paz [Tue, 3 Jul 2007 16:03:53 +0000 (16:03 +0000)]
* src/maemo/modest-maemo-global-settings-dialog.c:
* Now minimum and maximum values information banners use the
  correct translation domain (fixes NB#62471).

pmo-trunk-r2554

13 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Tue, 3 Jul 2007 15:58:44 +0000 (15:58 +0000)]
* src/modest-ui-dimming-rules.c:
* Now unable to paste message is obtained from the correct
  translation domain (fixes NB#62441).

pmo-trunk-r2553

13 years ago* src/modest-tny-msg.c:
Jose Dapena Paz [Tue, 3 Jul 2007 15:54:14 +0000 (15:54 +0000)]
* src/modest-tny-msg.c:
        * Now copy the mime parts of TnyMsg attachments. This does not fix
          the problem with forwarding attached messages, but at least now
          the contents are forwarded (in a bad format unfortunately).

pmo-trunk-r2552

13 years agoUpgraded the version number for integration.
Dirk-Jan C. Binnema [Tue, 3 Jul 2007 14:18:35 +0000 (14:18 +0000)]
Upgraded the version number for integration.

pmo-trunk-r2551

13 years agoAdded all the bugs sent by the testers.
Dirk-Jan C. Binnema [Tue, 3 Jul 2007 11:57:03 +0000 (11:57 +0000)]
Added all the bugs sent by the testers.

pmo-trunk-r2549

13 years ago2007-07-03 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 3 Jul 2007 11:39:52 +0000 (11:39 +0000)]
2007-07-03  Murray Cumming <murrayc@murrayc.com>

* src/modest-tny-account.c:
        (modest_tny_account_get_special_folder): (util_on_idle),
        Handle the GError so we can see when tny_folder_store_get_folders()
        fails, as it currently does while something else is connecting.

        Added util_run_in_main_thread_and_wait()
        which uses an idlen handler and mainloop to ensure that the function
        is called in the main thread.
        (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
        to make sure that we call attempt the connection in the mainloop only,
        which might solve some hangs.

pmo-trunk-r2548

13 years ago * Commented some code that is causing a hang on the device, we still need to investi...
Sergio Villar Senin [Tue, 3 Jul 2007 11:26:53 +0000 (11:26 +0000)]
* Commented some code that is causing a hang on the device, we still need to investigate a little bit more why it was happening
* Changed the nofify_end function, it does not need the locking because the signal handlers are executed into the main lock

pmo-trunk-r2547

13 years ago * Commented some code that seems to be unmaintained, and that causes a crash in...
Sergio Villar Senin [Tue, 3 Jul 2007 11:14:58 +0000 (11:14 +0000)]
* Commented some code that seems to be unmaintained, and that causes a crash in the device

pmo-trunk-r2546

13 years ago* fix for #62336
Dirk-Jan C. Binnema [Tue, 3 Jul 2007 10:16:22 +0000 (10:16 +0000)]
* fix for #62336

pmo-trunk-r2545

13 years ago2007-07-03 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 3 Jul 2007 10:05:33 +0000 (10:05 +0000)]
2007-07-03  Murray Cumming <murrayc@murrayc.com>

(modest_tny_account_store_get_tny_account_by): Do not allow accounts to
        be found by their display name. This is never useful.
        * src/modest-tny-account-store.c: (on_account_removed): Find the account
        by its ID, instead of trying to use its ID as its display name.

        * src/modest-tny-account-store.h:
        * src/modest-tny-account.c:
        (modest_tny_account_get_special_folder): Add a g_warning() when
        tny_folder_store_get_folders() returns an empty list for the maildir.

        * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
        Add a g_warning() when this returns NULL, because that it not allowed
        by tinymail.

pmo-trunk-r2544

13 years ago2007-07-02 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Mon, 2 Jul 2007 21:16:20 +0000 (21:16 +0000)]
2007-07-02  Armin Burgmeier  <armin@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
note when trying to cancel the wizard. This fixes projects.maemo.org
bug NB#60946.

pmo-trunk-r2543

13 years ago* small cleanup + fix runtime gtk warning
Dirk-Jan C. Binnema [Mon, 2 Jul 2007 19:05:14 +0000 (19:05 +0000)]
* small cleanup + fix runtime gtk warning

pmo-trunk-r2542

13 years ago * This and another previous changes fixes NB#61982
Sergio Villar Senin [Mon, 2 Jul 2007 18:03:48 +0000 (18:03 +0000)]
* This and another previous changes fixes NB#61982

pmo-trunk-r2541

13 years agoFixed some bugs in Escape HW key managment.
Javier Fernandez Garcia-Boente [Mon, 2 Jul 2007 17:46:33 +0000 (17:46 +0000)]
Fixed some bugs in Escape HW key managment.

pmo-trunk-r2540

13 years ago* src/maemo/modest-platform.c:
Jose Dapena Paz [Mon, 2 Jul 2007 17:28:32 +0000 (17:28 +0000)]
* src/maemo/modest-platform.c:
        * (modest_platform_get_icon_name): now gnome-mime-message
          and gnome-mime-message-rfc822 obtain the modest app icon
          (fixes NB#58262).

pmo-trunk-r2539

13 years ago* Fixes: NB#61649
Javier Fernandez Garcia-Boente [Mon, 2 Jul 2007 17:06:28 +0000 (17:06 +0000)]
* Fixes: NB#61649

pmo-trunk-r2538

13 years ago * Fixed a crash when removing messages from the viewer
Sergio Villar Senin [Mon, 2 Jul 2007 16:47:45 +0000 (16:47 +0000)]
* Fixed a crash when removing messages from the viewer
* When removing messages from the viewer, if there are more messages, go to the next

pmo-trunk-r2537

13 years agoUpdated the changelog with the Fixes made.
Dirk-Jan C. Binnema [Mon, 2 Jul 2007 16:11:37 +0000 (16:11 +0000)]
Updated the changelog with the Fixes made.

pmo-trunk-r2536

13 years agoReverted
Murray Cumming [Mon, 2 Jul 2007 16:11:14 +0000 (16:11 +0000)]
Reverted

pmo-trunk-r2535

13 years ago* commented out the stuff that depends on the w27 gtkhtml for now
Dirk-Jan C. Binnema [Mon, 2 Jul 2007 15:19:43 +0000 (15:19 +0000)]
* commented out the stuff that depends on the w27 gtkhtml for now

pmo-trunk-r2534

13 years ago2007-07-02 Murray Cumming <murrayc@murrayc.com
Murray Cumming [Mon, 2 Jul 2007 14:50:40 +0000 (14:50 +0000)]
2007-07-02  Murray Cumming  <murrayc@murrayc.com

* src/modest-tny-account.c: Added util_run_in_main_thread_and_wait()
which uses an idlen handler and mainloop to ensure that the function
is called in the main thread.
(on_connection_status_changed): Use util_run_in_main_thread_and_wait()
to make sure that we call attempt the connection in the mainloop only,
which might solve some hangs.

pmo-trunk-r2533

13 years ago* src/maemo/modest-main-window-ui.h:
Jose Dapena Paz [Mon, 2 Jul 2007 14:28:10 +0000 (14:28 +0000)]
* src/maemo/modest-main-window-ui.h:
        * Now Email/New menu option is shown as Email/New message
          as requested in specs (NB#60222).

pmo-trunk-r2532

13 years ago* make the second row in the header list grey; thus it's closer to the
Dirk-Jan C. Binnema [Mon, 2 Jul 2007 14:23:00 +0000 (14:23 +0000)]
* make the second row in the header list grey; thus it's closer to the
  the details of the ui spec

pmo-trunk-r2531

13 years ago* src/widgets/modest-msg-view.c:
Jose Dapena Paz [Mon, 2 Jul 2007 14:11:29 +0000 (14:11 +0000)]
* src/widgets/modest-msg-view.c:
        * Now that gtkhtml0 includes a way to get selected area,
          activate the scroll on finding in page in view
          (fixes NB#58611).

pmo-trunk-r2530

13 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Mon, 2 Jul 2007 11:46:01 +0000 (11:46 +0000)]
* src/maemo/modest-main-window.c:
        * Now moving with keyboard focus from folder view to header
          view updates the window title properly (fixes NB#61023).

pmo-trunk-r2529

13 years ago* src/widgets/modest-window.c:
Jose Dapena Paz [Mon, 2 Jul 2007 11:32:12 +0000 (11:32 +0000)]
* src/widgets/modest-window.c:
        * Fix keyboard handling.

pmo-trunk-r2528

13 years ago2007-07-02 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 2 Jul 2007 10:59:32 +0000 (10:59 +0000)]
2007-07-02  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account.h:
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account),
(modest_tny_account_new_from_server_account_name),
(modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
because this must now be set before setting the proto. This is usd in
modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
warning in camel_session_get_service() caused by
tny_camel_transport_account_prepare().

* src/modest-tny-account-store.c: (get_server_accounts): Pass the new
session parameter.

pmo-trunk-r2527

13 years ago * Fixes NB#62003, application do not longer hang when forwarding messages
Sergio Villar Senin [Mon, 2 Jul 2007 10:57:12 +0000 (10:57 +0000)]
* Fixes NB#62003, application do not longer hang when forwarding messages
* the reply_forward_cb only allows now to reply/forward more than one mail, did that in order to get progress information, while get_msgs_full is not migrated to use the async calls to tinymail

pmo-trunk-r2526

13 years ago* add checks that session != NULL
Dirk-Jan C. Binnema [Mon, 2 Jul 2007 10:50:19 +0000 (10:50 +0000)]
* add checks that session != NULL

pmo-trunk-r2525

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 2 Jul 2007 10:33:46 +0000 (10:33 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Added insensitve information banner for copy menu action. Fixes NB#60661.

pmo-trunk-r2524

13 years ago* fix removing of messages:
Dirk-Jan C. Binnema [Mon, 2 Jul 2007 10:10:48 +0000 (10:10 +0000)]
* fix removing of messages:
  for imap folders: mark as deleted, for pop, local: really remove

pmo-trunk-r2523

13 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Mon, 2 Jul 2007 10:09:26 +0000 (10:09 +0000)]
* src/maemo/modest-main-window.c:
        * Now the window title is updated in more cases when you go
          from split view to single view (fix NB#61490).

pmo-trunk-r2522

13 years ago* Fixes some bugs in modest-ui-actions, related with
Javier Fernandez Garcia-Boente [Mon, 2 Jul 2007 08:33:26 +0000 (08:33 +0000)]
* Fixes some bugs in modest-ui-actions, related with
mail operation IDs.
* Add a tree_model_filter_refilter call after remove_message
mail operation.

pmo-trunk-r2521

13 years ago * Fixed a compilation warning on ARM
Sergio Villar Senin [Mon, 2 Jul 2007 07:49:20 +0000 (07:49 +0000)]
* Fixed a compilation warning on ARM

pmo-trunk-r2520

13 years ago* don't expunge messages after marking them as deleted
Dirk-Jan C. Binnema [Mon, 2 Jul 2007 06:55:03 +0000 (06:55 +0000)]
* don't expunge messages after marking them as deleted

pmo-trunk-r2519

13 years ago* Add a new dimming rule to prevetn move messages
Javier Fernandez Garcia-Boente [Sun, 1 Jul 2007 18:17:58 +0000 (18:17 +0000)]
* Add a new dimming rule to prevetn move messages
which are already opened in a viewer.
* Fixes: NB#58799

pmo-trunk-r2518

13 years ago* Fixed some compilation errors.
Javier Fernandez Garcia-Boente [Sun, 1 Jul 2007 17:54:47 +0000 (17:54 +0000)]
* Fixed some compilation errors.

pmo-trunk-r2517

13 years ago* Add a notification dialog to avoid move messages
Javier Fernandez Garcia-Boente [Sun, 1 Jul 2007 17:41:16 +0000 (17:41 +0000)]
* Add a notification dialog to avoid move messages
to the same folder.
* Fixes: NB#58330

pmo-trunk-r2516

13 years ago* modest-main.c:
Dirk-Jan C. Binnema [Sun, 1 Jul 2007 09:02:34 +0000 (09:02 +0000)]
* modest-main.c:
- return 0 iff there are no errors
* modest-ui-actions:
- clear the queue when closing down
* modest-runtime.h:
- remove unimplemented modest_runtime_init_ui
* modest-tny-account-store:
- debugging messages

pmo-trunk-r2515

13 years ago* don't set the window icon explicitly; maemo seems to
Dirk-Jan C. Binnema [Sun, 1 Jul 2007 08:32:40 +0000 (08:32 +0000)]
* don't set the window icon explicitly; maemo seems to
  ignore it, and as we could not find the icon anyway,
  this saves a runtime warning

pmo-trunk-r2514

13 years ago * Signal handlers are executed in the main lock, so no need to block
Sergio Villar Senin [Sat, 30 Jun 2007 17:35:24 +0000 (17:35 +0000)]
* Signal handlers are executed in the main lock, so no need to block

pmo-trunk-r2512

13 years ago2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Sat, 30 Jun 2007 16:53:11 +0000 (16:53 +0000)]
2007-06-30  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/modest-connection-specific-smtp-edit-window.c:
(on_value_changed),
(modest_connection_specific_smtp_edit_window_init):

Fixed project.maemo.org bug NB#60479 by using \"notify::value\" instead
of \"changed\" for now

pmo-trunk-r2511

13 years ago* remove unneeded stuff from modest-main (the batch mode stuff which wasn't working...
Dirk-Jan C. Binnema [Sat, 30 Jun 2007 16:39:14 +0000 (16:39 +0000)]
* remove unneeded stuff from modest-main (the batch mode stuff which wasn't working anyway
* cleanup the initialization, which should make it more clear what happens
* don't do separate ui/core init

pmo-trunk-r2510

13 years ago* leak fix; unref the icon
Dirk-Jan C. Binnema [Sat, 30 Jun 2007 16:37:26 +0000 (16:37 +0000)]
* leak fix; unref the icon

pmo-trunk-r2509

13 years ago* leak fixes
Dirk-Jan C. Binnema [Sat, 30 Jun 2007 15:39:24 +0000 (15:39 +0000)]
* leak fixes

pmo-trunk-r2508

13 years ago* Add a error_handler for send_receive operation.
Javier Fernandez Garcia-Boente [Sat, 30 Jun 2007 11:49:10 +0000 (11:49 +0000)]
* Add a error_handler for send_receive operation.
* Review dimming rules of 'Cancel sending' command.
* Fixes: NB#61952

pmo-trunk-r2507

13 years ago* Review dimming rules of 'delete' and 'delete folder'
Javier Fernandez Garcia-Boente [Sat, 30 Jun 2007 10:28:04 +0000 (10:28 +0000)]
* Review dimming rules of 'delete' and 'delete folder'
* Fixes: NB#61254

pmo-trunk-r2506

13 years ago2007-06-29 Murray Cumming <murrayc@murrayc.com
Murray Cumming [Fri, 29 Jun 2007 18:11:21 +0000 (18:11 +0000)]
2007-06-29  Murray Cumming  <murrayc@murrayc.com

* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account):
Handle the TnyAccount::connection-status-changed signal, which tinymail
now uses to request a connection when it needs one, and which it uses
to tell us that something is wrong with the connection, so we can force
the accounts offline to prevent further problems.

* src/modest-defs.h:
* src/modest-init.c: (init_default_settings):
* src/modest-mail-operation.c:
(modest_mail_operation_update_account):
* src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
This should not be necessary anymore. Do not set the conf key that
determined this (it was always TRUE and not set anywhere else).

* src/modest-ui-actions.h: Remove unused and unimplemented
modest_ui_actions_on_online_toggle_toggled().

pmo-trunk-r2505

13 years ago * Fixed a compilation warning
Sergio Villar Senin [Fri, 29 Jun 2007 17:40:51 +0000 (17:40 +0000)]
* Fixed a compilation warning

pmo-trunk-r2504

13 years ago* fix a memleak in the msg edit window
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 17:05:42 +0000 (17:05 +0000)]
* fix a memleak in the msg edit window
* fix a memleak when registering the update_interval for the alarm daemon

pmo-trunk-r2503

13 years ago* src/widgets/modest-header-view-render.c:
Jose Dapena Paz [Fri, 29 Jun 2007 16:58:46 +0000 (16:58 +0000)]
* src/widgets/modest-header-view-render.c:
        * Added some implementation work to retrieve the send status of
          mails in outbox. get_status_string() obtains the proper string
          for a status, get_status_of_uid() should retrieve the current
          status trying in all send queues, the cell renderer has a
          specific path for the case of outbox.
        * As currently it does not get the proper status from the
          send queue, we set always "waiting".
* src/widgets/modest-header-view-priv.h:
        * Added an enum of the types of compact cell renderer.
* src/widgets/modest-header-view.c:
        * Pass the proper mode to the compact cell renderer (incoming,
          outgoing, outbox).

pmo-trunk-r2502

13 years ago* Use an user handler for 'key-press-event' signal on
Javier Fernandez Garcia-Boente [Fri, 29 Jun 2007 15:36:37 +0000 (15:36 +0000)]
* Use an user handler for 'key-press-event' signal on
ModestWindow class.
* Fixes: NB#61828, NB#61825

pmo-trunk-r2501

13 years agoUpdated the changelog with the fixes made on week26 29th june.
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 15:03:56 +0000 (15:03 +0000)]
Updated the changelog with the fixes made on week26 29th june.

pmo-trunk-r2500

13 years agoFixed the bug 61219, changed from showing dialog to showing banner if the account...
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 14:52:09 +0000 (14:52 +0000)]
Fixed the bug 61219, changed from showing dialog to showing banner if the account already exists.

pmo-trunk-r2499

13 years ago* Fixed bug in select_next function.
Javier Fernandez Garcia-Boente [Fri, 29 Jun 2007 14:29:04 +0000 (14:29 +0000)]
* Fixed bug in select_next function.

pmo-trunk-r2498

13 years ago* fix logical error, don't call
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 12:55:47 +0000 (12:55 +0000)]
* fix logical error, don't call
  search_mime_part_and_child_parts
   if msg == NULL. This fixes a crash if msg happens to be NULL

pmo-trunk-r2497

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Fri, 29 Jun 2007 12:46:44 +0000 (12:46 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now the font size toolbutton always get the default font face
          (it was getting the default font, but then it was replaced
          with Serif on first font size change).

pmo-trunk-r2496

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Fri, 29 Jun 2007 12:37:57 +0000 (12:37 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Fixed some typo errors in set_format_state function.
        * Use set_attribute instead of set_format in font size change
          handler.

pmo-trunk-r2495

13 years ago2007-06-29 Murray Cumming <murrayc@murrayc-desktop>
Murray Cumming [Fri, 29 Jun 2007 11:58:12 +0000 (11:58 +0000)]
2007-06-29  Murray Cumming  <murrayc@murrayc-desktop>

* src/maemo/modest-main-window.c: (connect_signals):
Don't connect to delete_event twice. Maybe this was harmless.

pmo-trunk-r2494

13 years ago2007-06-29 Murray Cumming <murrayc@murrayc.com
Murray Cumming [Fri, 29 Jun 2007 11:52:15 +0000 (11:52 +0000)]
2007-06-29  Murray Cumming  <murrayc@murrayc.com

* libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
* src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
Debug output to give some more clue when a folder move is not allowed.

pmo-trunk-r2493

13 years ago* update the various places where the modest-window-mgr was used to register
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 11:31:07 +0000 (11:31 +0000)]
* update the various places where the modest-window-mgr was used to register
  the header *before* the message is opened (see previous patch).
* also update the dimming rules, so opened messages will  have the delete
  button in the main window dimmed, as well, as when selecting multiple of
  which one or more are opened already.

pmo-trunk-r2492

13 years ago* update the modest-window-manager; together with the next patch, this
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 11:28:00 +0000 (11:28 +0000)]
* update the modest-window-manager; together with the next patch, this
  fixes NB#57297
- we do this by adding modest_window_mgr_register_header,
modest_window_mgr_find_registered_header. in the next patch, these will
be called *before* actually opening the message, so it will be impossible
to open the same message several times. the problem used to be that
the windows were only registered after the message was retrieved, so
plenty time to have doubles, esp. on a slow connection
- also fix a bug where really the registered *window* is returned,
instead of the GList* (casting hid this bug), this enables us to popup
a msg-view-window if it was already opened for the activated message

pmo-trunk-r2491

13 years ago * Reverted a do not wanted change
Sergio Villar Senin [Fri, 29 Jun 2007 10:55:30 +0000 (10:55 +0000)]
* Reverted a do not wanted change

pmo-trunk-r2490

13 years ago * Do "pulse" when done=0 and total=0
Sergio Villar Senin [Fri, 29 Jun 2007 10:51:30 +0000 (10:51 +0000)]
* Do "pulse" when done=0 and total=0

pmo-trunk-r2489

13 years ago * Do not block signal emissions into idles callbacks, because signal handlers are...
Sergio Villar Senin [Fri, 29 Jun 2007 10:27:11 +0000 (10:27 +0000)]
* Do not block signal emissions into idles callbacks, because signal handlers are already executed into the main lock

pmo-trunk-r2488

13 years ago* Fixes some warning about uninitialized valrables.
Javier Fernandez Garcia-Boente [Fri, 29 Jun 2007 08:27:34 +0000 (08:27 +0000)]
* Fixes some warning about uninitialized valrables.

pmo-trunk-r2487

13 years agosmall change for Fixed bug 58983, changed the labels from the previous commit.
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 08:23:07 +0000 (08:23 +0000)]
small change for Fixed bug 58983, changed the labels from the previous commit.

pmo-trunk-r2486

13 years agoFixed bug 58983, changed the order and labels for delete account.
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 08:20:39 +0000 (08:20 +0000)]
Fixed bug 58983, changed the order and labels for delete account.

pmo-trunk-r2485

13 years ago* Review 'move to' callback from viewer window with pop
Javier Fernandez Garcia-Boente [Thu, 28 Jun 2007 23:06:52 +0000 (23:06 +0000)]
* Review 'move to' callback from viewer window with pop
accounts.
* Fixes: NB#61929

pmo-trunk-r2484

13 years ago* Fixes: NB#61955
Javier Fernandez Garcia-Boente [Thu, 28 Jun 2007 20:03:08 +0000 (20:03 +0000)]
* Fixes: NB#61955

pmo-trunk-r2483