modest
13 years ago2007-07-23 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 23 Jul 2007 17:29:29 +0000 (17:29 +0000)]
2007-07-23  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
(add_folders_to_list), (on_dbus_method_get_folders),
(modest_dbus_req_filter):
* src/maemo/modest-maemo-utils.c:
(on_camel_account_get_supported_secure_authentication):
* src/maemo/modest-main-window.c: (modest_main_window_set_style),
(on_header_view_focus_in):
* src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
* src/modest-formatter.c: (modest_formatter_create_body_part):
* src/modest-mail-operation.c: (recurse_folders),
(update_account_thread), (get_msgs_full_thread),
(modest_mail_operation_get_msgs_full),
(modest_mail_operation_xfer_msgs):
* src/modest-search.c: (search_mime_part_and_child_parts),
(modest_search_account), (modest_search_all_accounts):
* src/modest-tny-account.c:
(modest_tny_account_get_special_folder), (recurse_folders):
* src/modest-tny-local-folders-account.c:
(modest_tny_local_folders_account_query_passes):
* src/modest-tny-msg.c: (copy_mime_part),
(modest_tny_msg_find_body_part_from_mime_part):
* src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
(modest_tny_send_queue_try_to_send):
* src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
(_modest_ui_actions_open), (download_uncached_messages),
(reply_forward), (modest_ui_actions_on_copy),
(modest_ui_actions_on_details), (has_retrieved_msgs),
(msgs_move_to_confirmation), (open_msg_for_purge_cb),
(do_headers_action):
* src/modest-ui-dimming-rules.c: (_already_opened_msg),
(_selected_msg_marked_as), (_msg_download_completed),
(_selected_msg_sent_in_progress):
* src/widgets/modest-attachments-view.c:
(modest_attachments_view_set_message):
* src/widgets/modest-msg-view.c: (find_cid_image):
* tests/check_folder-transfer.c: (find_folders):
* tests/check_update-account.c: (func):
* tests/dbus_api/test_get_folders.c: (main):
Checked all uses of tny_iterator_get_current(), making sure
that the object is unreferenced (3 or 4 places did not),
and adding checks for NULL.

pmo-trunk-r2776

13 years ago * Update the next_row_reference if it was invalidated previously
Sergio Villar Senin [Mon, 23 Jul 2007 17:06:20 +0000 (17:06 +0000)]
* Update the next_row_reference if it was invalidated previously
* Fixes NB#63349, the viewer moves to the next message even if the old following one was deleted

pmo-trunk-r2775

13 years ago * ModestAccountMgr: the account manager is just a facade to the configuration...
Sergio Villar Senin [Mon, 23 Jul 2007 16:38:03 +0000 (16:38 +0000)]
    * ModestAccountMgr: the account manager is just a facade to the configuration system, so it should
not know TnyAccounts only ModestAccounts. TnyAccounts are managed by the TnyAccountStore
        - removed the server_account parametter from the account_removed signal
        - removed the server_account parametter from the remove_account method
        - Changed the signature of the methods that handled the signal
        - completetly rewritten the account removal code
        * ModestTnyAccountStore
        - now it issues a account_removed for both the store and the transport account
        - completety rewritten the get_server_account method, it makes no sense to use the account mgr, because we h
ave the accounts
        * ModestFolderView
        - added a missing check
        - added a missing select inbox
- added a condition to the filter_row method, do not take into account the visible_account_id if we aren't in SHOW_ONE style

pmo-trunk-r2774

13 years ago2007-07-23 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 23 Jul 2007 14:52:44 +0000 (14:52 +0000)]
2007-07-23  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c:
(on_idle_open_default_inbox): Make sure that the application UI is
visible.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(on_entry_invalid_character): Show the word whitespace instead
of (null) in the banner when whitespace was entered.
(show_error): Add a comment that  this does not work in
Maemo Bora, though we do not know why.

pmo-trunk-r2773

13 years agos/__FUNCTION/__FUNCTION__/
Dirk-Jan C. Binnema [Mon, 23 Jul 2007 13:09:48 +0000 (13:09 +0000)]
s/__FUNCTION/__FUNCTION__/

pmo-trunk-r2772

13 years agoAdded new fixes to changelog - week 30.
Dirk-Jan C. Binnema [Mon, 23 Jul 2007 12:51:32 +0000 (12:51 +0000)]
Added new fixes to changelog -  week 30.

pmo-trunk-r2771

13 years ago2007-07-23 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 23 Jul 2007 12:07:22 +0000 (12:07 +0000)]
2007-07-23  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account.c:
(modest_tny_account_get_special_folder): Use an if instead of
an assert for when the parent account name is NULL, because this
might be causing a crash in projects.maemo.org bug 63192.
* src/modest-mail-operation.c:
(modest_mail_operation_send_new_mail_cb),
(modest_mail_operation_remove_folder): unref the folder that is
returned from modest_tny_account_get_special_folder().

pmo-trunk-r2770

13 years agoAdded a comment.
Murray Cumming [Mon, 23 Jul 2007 11:43:49 +0000 (11:43 +0000)]
Added a comment.

pmo-trunk-r2769

13 years ago * Reverted some changes from one of the latest armin's commits. We can never call...
Sergio Villar Senin [Mon, 23 Jul 2007 10:18:00 +0000 (10:18 +0000)]
* Reverted some changes from one of the latest armin's commits. We can never call gtk_widget_destroy over a window, we need to do all the window management always through the window manager

pmo-trunk-r2768

13 years ago2007-07-23 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 23 Jul 2007 08:53:45 +0000 (08:53 +0000)]
2007-07-23  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-actions.c:
(modest_ui_actions_on_password_requested):
Show mail_ib_login_cancelled info banner when the user cancels
the protected password dialog, to fix projects.maemo.org
bug NB#63617.

pmo-trunk-r2767

13 years ago2007-07-23 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 23 Jul 2007 08:18:21 +0000 (08:18 +0000)]
2007-07-23  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-settings-dialog.c:
(create_page_outgoing): Put this page in a GtkScrolledWindow,
matching the UI mock-up in the UI spec, and allowing access
to all widgets even when the on-screen keyboard is active.

pmo-trunk-r2766

13 years ago2007-07-16 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 23 Jul 2007 08:04:12 +0000 (08:04 +0000)]
2007-07-16  Murray Cumming  <murrayc@murrayc.com>

Reverted this previous commit from Johannes,
because the scrollbars are always visible and because
I think we only need it on onepage of the account
settings, not the account wizard.
(I wrote the wrong instructions in the bug.)

* src/maemo/easysetup/modest-easysetup-wizard.c:
Added scrollbars to account wizard dialog.
Fixed projects.maemo.org NB #62744

pmo-trunk-r2765

13 years ago2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Sun, 22 Jul 2007 14:48:44 +0000 (14:48 +0000)]
2007-07-22  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_user_details):
Use auto-cap for name (projects.maemo.org NB#63716)
* src/widgets/modest-account-view.c: (on_account_busy_changed):

pmo-trunk-r2764

13 years ago2007-07-22 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Sun, 22 Jul 2007 13:17:17 +0000 (13:17 +0000)]
2007-07-22  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-ui-actions.c: Use current account instead of
default account for creating viewer windows, so that the viewer
window knows to which account the viewed message belongs.

* src/maemo/modest-msg-view-window.c: Destroy the window when the
corresponding account is deleted. This fixes projects.maemo.org bug

pmo-trunk-r2763

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Fri, 20 Jul 2007 16:52:01 +0000 (16:52 +0000)]
* src/modest-ui-actions.c:
* If there's no header view, then proper information banner
  "nothing to sort" is shown.
* src/modest-ui-dimming-rules.c:
* Dim sort action if folder is empty. IN toolbar we show the
  corresponding information banner (fixes NB#60446).

pmo-trunk-r2762

13 years ago* src/maemo/modest-maemo-utils.[ch]:
Jose Dapena Paz [Fri, 20 Jul 2007 09:48:31 +0000 (09:48 +0000)]
* src/maemo/modest-maemo-utils.[ch]:
* New method modest_maemo_gtk_toggle_action_set_active_block_notify
  that disables handlers on changing the current status of a
  toggle action. This was duplicated in msg view and editor, so
  it's been refactored to make them share the implementation.
  Using this in msg edit implementation change is pending on
  other changes in wpeditor.
* src/maemo/modest-msg-view-window.c:
* Now we use the new modest-maemo-utils refactored toggle action
  notify block method.

pmo-trunk-r2761

13 years agoSome improvements on the header view layout. It puts finally the
Jose Dapena Paz [Thu, 19 Jul 2007 21:44:28 +0000 (21:44 +0000)]
Some improvements on the header view layout. It puts finally the
priority icon in its place
* src/maemo/modest-icon-names.h:
        * Added standard high and low priority icons, to be used
          from the custom icon renderers in thumbable headers.
* src/widgets/modest-header-view-render.c:
* Use the proper icons for high and low priority, instead
  of the old composed ones used for the shared priority and
  attachments cell renderer (fixes NB#62262).
* src/widgets/modest-header-view.c:
* Some other layout fixes in compact header view.

pmo-trunk-r2760

13 years ago* src/widgets/modest-recpt-view.c:
Jose Dapena Paz [Thu, 19 Jul 2007 19:47:25 +0000 (19:47 +0000)]
* src/widgets/modest-recpt-view.c:
* Now we accept a small threshold (32 pixels) in press/release
  cycles, to prevent when the click is done with a small
  movement (as it can happen in maemo touchscreen)
  (fixes NB#60728).

pmo-trunk-r2759

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Thu, 19 Jul 2007 17:36:12 +0000 (17:36 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now we show properly the find toolbar, as we attach it
  using hildon_window_add_toolbar API. This partially fixes
  (NB#63201) as this only fixes toolbar in view.

pmo-trunk-r2758

13 years ago* src/widgets/modest-recpt-editor.c:
Jose Dapena Paz [Thu, 19 Jul 2007 17:20:10 +0000 (17:20 +0000)]
* src/widgets/modest-recpt-editor.c:
* Now we discard invalid chars (bullets and images) on pasting
  in recipient editor. This way, if we paste from the editor
  these symbols, they should be removed from text pasted in
  the recipient editor (fixes NB#62575).

pmo-trunk-r2757

13 years ago* src/widgets/modest-msg-view.c:
Jose Dapena Paz [Thu, 19 Jul 2007 16:39:42 +0000 (16:39 +0000)]
* src/widgets/modest-msg-view.c:
* Added implementation of get_message_is_empty method. It uses
  gtk_html_export method to know if the buffer has any text
  representation and this is empty or not.
* src/maemo/modest-msg-view-window.c:
* Removed check for empty buffer to show "nothing to find"
  banner on toggling the toolbar. This should be shown on trying
  to search in the toolbar, not on trying to show the toolbar.
* Added the nothing to find banner on searching empty buffers,
  using the new implementation. This is a partial fix to
  NB#62350.

pmo-trunk-r2756

13 years ago* src/modest-formatter.c:
Jose Dapena Paz [Thu, 19 Jul 2007 15:15:09 +0000 (15:15 +0000)]
* src/modest-formatter.c:
* Add an unref to avoid leaking a reference.

pmo-trunk-r2755

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Thu, 19 Jul 2007 15:13:51 +0000 (15:13 +0000)]
* src/modest-ui-actions.c:
* (folder_refreshed_cb): Now I check if the folder refreshed
  message corresponds to the currently selected folder in
  header view. This should prevent showing the empty folder
  message for a populated folder when other folder request
  finishes later.

pmo-trunk-r2754

13 years ago* src/modest-tny-msg.c:
Jose Dapena Paz [Thu, 19 Jul 2007 15:10:23 +0000 (15:10 +0000)]
* src/modest-tny-msg.c:
* Now we simplify the way we copy mime parts when the mime part
  is an attachment. This, with a pending patch in tinymail,
  should fix NB#61280.

pmo-trunk-r2753

13 years ago2007-07-18 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Wed, 18 Jul 2007 15:52:17 +0000 (15:52 +0000)]
2007-07-18  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
the dialog close after entering an invalid port number and clicking
OK. This fixes projects.maemo.org bug NB#63602.

pmo-trunk-r2752

13 years ago2007-07-18 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Wed, 18 Jul 2007 13:49:22 +0000 (13:49 +0000)]
2007-07-18  Armin Burgmeier  <armin@openismus.com>

* src/modest-tny-account-store.c:
(get_server_accounts): Set parent modest account name for each
connection-specific transport account so that special folders of such
an account can be looked up. This fixes a crash when changing account
settings. This might also be related to projects.maemo.org bug
NB#63594.

pmo-trunk-r2751

13 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Tue, 17 Jul 2007 16:19:16 +0000 (16:19 +0000)]
* src/modest-ui-dimming-rules.c:
* Use the proper domain for "unable to delete" information
  banner (fixes NB#63494).

pmo-trunk-r2750

13 years ago* src/modest-mail-operation.c:
Jose Dapena Paz [Tue, 17 Jul 2007 15:51:27 +0000 (15:51 +0000)]
* src/modest-mail-operation.c:
* Now it checks if there's no account already, and then cancel cannot
  be run. Avoids a crash.

pmo-trunk-r2749

13 years agoChanged the changelog to build for week 29.
Dirk-Jan C. Binnema [Tue, 17 Jul 2007 14:07:44 +0000 (14:07 +0000)]
Changed the changelog to build for week 29.

pmo-trunk-r2748

13 years agoUpdated the resolved fixed bugs into changelog for week 29.
Dirk-Jan C. Binnema [Tue, 17 Jul 2007 13:10:08 +0000 (13:10 +0000)]
Updated the resolved fixed bugs into changelog for week 29.

pmo-trunk-r2747

13 years ago2007-07-16 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Mon, 16 Jul 2007 18:50:23 +0000 (18:50 +0000)]
2007-07-16  Armin Burgmeier  <armin@openismus.com>

* src/modest-ui-actions.c: Added a button to create a folder to the
move-to dialog. This fixes projects.maemo.org bug NB#.

pmo-trunk-r2745

13 years agofixed Changelog...
Johannes Schmid [Mon, 16 Jul 2007 17:18:44 +0000 (17:18 +0000)]
fixed Changelog...

pmo-trunk-r2744

13 years ago2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Mon, 16 Jul 2007 17:17:13 +0000 (17:17 +0000)]
2007-07-16  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
Added scrollbars to account wizard dialog.
Fixed projects.maemo.org NB #6274

pmo-trunk-r2743

13 years ago2007-07-16 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 16 Jul 2007 12:15:00 +0000 (12:15 +0000)]
2007-07-16  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-msg-view.h:
* src/widgets/modest-msg-view.c:
Added modest_msg_view_get_message_is_empty() but this needs
to be implemented.
* src/maemo/modest-msg-edit-window.c: (message_is_empty):
Check if there is any text in the message yet.
But this needs to be implemented properly.
(modest_msg_edit_window_toggle_find_toolbar):
* src/maemo/modest-msg-view-window.c:
(modest_msg_view_window_toggle_find_toolbar):
Show a banner warning if there is no text to search, when
trying to start a search. This partially fixes
projects.maemo.org bug NB#62350.

pmo-trunk-r2742

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Mon, 16 Jul 2007 09:08:01 +0000 (09:08 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Now we use GtkTreePath's instead of iterators
          for message_reader function. This should be more
          reliable against model changes that change the
          stamp available for iterators, and avoid a crash
          then (fixes NB#63270).

pmo-trunk-r2740

13 years ago * Fixes NB#63080, size=0 is also translated by modest text utils
Sergio Villar Senin [Fri, 13 Jul 2007 19:23:42 +0000 (19:23 +0000)]
* Fixes NB#63080, size=0 is also translated by modest text utils

pmo-trunk-r2738

13 years ago2007-07-13 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 13 Jul 2007 18:10:39 +0000 (18:10 +0000)]
2007-07-13  Murray Cumming  <murrayc@murrayc.com>

* src/modest-mail-operation.c: (update_account_thread):
Initialized num_new_headers to fix the build.

pmo-trunk-r2737

13 years ago2007-07-13 MMurray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 13 Jul 2007 17:31:13 +0000 (17:31 +0000)]
2007-07-13  MMurray Cumming  <murrayc@murrayc.com>

* src/modest-account-mgr.c: (modest_account_mgr_account_names):
Ignore modest accounts whose server accounts don't exist in gconf.
This prevents us trying to create TnyAccount instances for those
server accounts when the server account has been removed from gconf,
but the parent modest account has not yet been removed from modest.
I don't know why this is only noticeable now. It was probably just
a harmeless g_warning() anyway.

pmo-trunk-r2736

13 years ago * Added the operation cancel_all_operations to the progress objects
Sergio Villar Senin [Fri, 13 Jul 2007 17:05:36 +0000 (17:05 +0000)]
* Added the operation cancel_all_operations to the progress objects
* The cancel button now invokes the cancel_all operation
* Fixed modest_mail_operation cancel, now it really calls tny_account_cancel
* Removed the ugly did_a_cancel static boolean in the mail operations
* Fixed a leak with the new headers received when doing a send&receive
* Fixes NB#62946, several clicks on cancel do not make the application crash when S&R
* Fixed the new_headers count that was returned by the update_account_thread, it was wrong and was returning always 0 because the new_headers were freed before

pmo-trunk-r2735

13 years agoAdded all the bugs in resolved fixed status.
Dirk-Jan C. Binnema [Fri, 13 Jul 2007 14:20:25 +0000 (14:20 +0000)]
Added all the bugs in resolved fixed status.

pmo-trunk-r2734

13 years ago2007-07-13 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 13 Jul 2007 09:15:50 +0000 (09:15 +0000)]
2007-07-13  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.

pmo-trunk-r2733

13 years ago * Wrap all the signal emissions with gdk_threads_* stuff, we need to ensure that...
Sergio Villar Senin [Fri, 13 Jul 2007 07:39:54 +0000 (07:39 +0000)]
* Wrap all the signal emissions with gdk_threads_* stuff, we need to ensure that only one thread enter Gtk+ at the same time

pmo-trunk-r2732

13 years ago2007-07-12 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Thu, 12 Jul 2007 17:03:45 +0000 (17:03 +0000)]
2007-07-12  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-main-window.c: Make default account appear bold
in view, tools/send & receive and toolbar/send & receive SCM menus.
This fixes projects.maemo.org bug NB#59010.

pmo-trunk-r2731

13 years ago2007-07-12 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 12 Jul 2007 15:00:58 +0000 (15:00 +0000)]
2007-07-12  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
Add a short-cut, by checking if the folder store is an account.
This ensures that the Sort menu item and toolbar is dimmed for
the local-folders account root item, fixing
projects.maemo.org bug NB#62545.

pmo-trunk-r2730

13 years ago2007-07-12 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 12 Jul 2007 14:25:33 +0000 (14:25 +0000)]
2007-07-12  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (get_password):
Show the password dialog (via the signal) only in the mainloop, via
an idle handler that we wait for. This could theoretically prevent
hangs, though I worry that it could introduce some too.

pmo-trunk-r2729

13 years ago * Added support to get_folders call in the local folder account to filter by query
Sergio Villar Senin [Thu, 12 Jul 2007 14:22:11 +0000 (14:22 +0000)]
* Added support to get_folders call in the local folder account to filter by query
* Removed get_folders_async from the local folder account because it makes no sense to redefine it to just call the parent
* Redefined the create_folder method in the local folder account in order not to allow to create folders with the same name than the extra folders
* Removed some invalid string comparisons in the guess_folder_type_from_name
* Now Modest do not allow to create a folder called outbox, nor to move another one with that name to the local folders account

pmo-trunk-r2728

13 years ago2007-07-12 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 12 Jul 2007 14:00:57 +0000 (14:00 +0000)]
2007-07-12  Murray Cumming  <murrayc@murrayc.com>

* src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
* src/maemo/modest-platform.c:
(modest_platform_connect_and_wait):
Take a TnyAccount* parameter and try to set it to online
(a TnyCamel-only API), because tinymail sets accounts to offline
when the user cancels a password dialog, and doesn't ask again until
it has been set to online.
However, this is commented out because it causes a hang now.

(modest_platform_connect_and_wait_if_network_account):
* src/modest-mail-operation.c:
(modest_mail_operation_update_account):
* src/modest-platform.h:
* src/modest-ui-actions.c: (_modest_ui_actions_open),
(download_uncached_messages), (modest_ui_actions_on_send): Adapted.

pmo-trunk-r2727

13 years ago2007-07-12 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Thu, 12 Jul 2007 13:20:03 +0000 (13:20 +0000)]
2007-07-12  Armin Burgmeier  <armin@openismus.com>

* src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.

* src/modest-mail-operation.c:
* src/modest-ui-actions.c: Check for already existing folder before
querying the server, show error message from camel if the request
still fails. This fixes projects.maemo.org bug NB#58701.

pmo-trunk-r2726

13 years ago2007-07-12 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 12 Jul 2007 13:02:57 +0000 (13:02 +0000)]
2007-07-12  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.h:
* src/modest-tny-account-store.c:
Added modest_tny_account_store_forget_password_in_memory(),
(get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
when creating a new account, so that new passwords will be used, instead of
us thinking that it's a second request as a result of a failed password again.

pmo-trunk-r2725

13 years agoUnselecting when a rename or a delete should happen
Philip Van Hoof [Thu, 12 Jul 2007 12:15:10 +0000 (12:15 +0000)]
Unselecting when a rename or a delete should happen

pmo-trunk-r2724

13 years ago * Removed some comments
Sergio Villar Senin [Thu, 12 Jul 2007 11:16:36 +0000 (11:16 +0000)]
* Removed some comments
* Fixes NB#63055
* Added query capabilities to the get_folders method of our local account store
* Added the name Outbox for the local merged folder with the same name

pmo-trunk-r2723

13 years ago2007-07-12 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 12 Jul 2007 09:36:00 +0000 (09:36 +0000)]
2007-07-12  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c:
(on_idle_open_message): If the message is in drafts then open it
in an edit window instead of a view window. This fixes
projects.maemo.org bug NB#63005.

pmo-trunk-r2722

13 years ago2007-07-12 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 12 Jul 2007 08:14:42 +0000 (08:14 +0000)]
2007-07-12  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
Avoided a harmless g_warning().

pmo-trunk-r2721

13 years agoRemoved a debug printf.
Murray Cumming [Thu, 12 Jul 2007 08:01:11 +0000 (08:01 +0000)]
Removed a debug printf.

pmo-trunk-r2720

13 years ago2007-07-12 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 12 Jul 2007 07:59:04 +0000 (07:59 +0000)]
2007-07-12  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
Pass the modest account name, not the TnyAccount display name to
modest_msg_view_window_new() so that the reply feature works,
fixing projects.maemo.org bug NB#62892.

* src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
(modest_msg_view_window_new_with_header_model):
* src/maemo/modest-msg-view-window.c:
(modest_msg_view_window_new_with_header_model),
(modest_msg_view_window_new):
* src/modest-ui-actions.c: (reply_forward):
* src/widgets/modest-msg-view-window.h:
* src/widgets/modest-window.c: (modest_window_set_active_account):
Rename an account parameter to modest_account_name to make this clearer.

2007-07-11  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-actions.h:
* src/modest-ui-actions.c: (headers_action_delete): Moved some code into
modest_do_message_delete().
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
Call modest_do_message_delete(), hoping that this would cause messages
to be really deleted from search instead of just marked with strike through.
Does not seem to help.

pmo-trunk-r2719

13 years agoAdded the fixes made till july 12th.
Dirk-Jan C. Binnema [Thu, 12 Jul 2007 07:58:58 +0000 (07:58 +0000)]
Added the fixes made till july 12th.

pmo-trunk-r2718

13 years ago2007-07-11 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Wed, 11 Jul 2007 18:25:49 +0000 (18:25 +0000)]
2007-07-11  Armin Burgmeier  <armin@openismus.com>

* src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
priv->reselect to FALSE prior to calling
modest_folder_view_select_first_inbox_or_local() to prevent endless
recursion and thus a crash on startup.

pmo-trunk-r2717

13 years ago2007-07-11 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Wed, 11 Jul 2007 17:31:02 +0000 (17:31 +0000)]
2007-07-11  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-account-settings-dialog.h: Include
<gtk/gtknotebook.h> to fix the build (at least for me).

* src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
Use "New FolderN" as default suggested name if "New folder" already
exists, with N being the first free number, though never exceed "New
folder99" in which case we just fall back to "New Folder" even though
it already exists. This fixes projects.maemo.org bug NB#58663.

pmo-trunk-r2716

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Wed, 11 Jul 2007 16:52:45 +0000 (16:52 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Reactivate the focus vadjustment
* src/widgets/modest-window.c:
        * Now escape sends a delete event to msg view and editor if
          they're not fullscreen (fixes NB#58618).

pmo-trunk-r2715

13 years ago2007-07-11 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 11 Jul 2007 16:43:54 +0000 (16:43 +0000)]
2007-07-11  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-view-window.c: (on_new_button_clicked):
Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
projects.maemo.org bug NB#62778.

pmo-trunk-r2714

13 years ago* auto expand the folder list again; we need to check if this works now.
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 16:15:05 +0000 (16:15 +0000)]
* auto expand the folder list again; we need to check if this works now.
  Fixes: NB#62355

pmo-trunk-r2713

13 years ago2007-07-11 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 11 Jul 2007 15:58:08 +0000 (15:58 +0000)]
2007-07-11  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
Ignore the wrong (for now) secure-smtp setting in the presets -
just default to requiring secure authentication for SMTP, because
that is most common.

pmo-trunk-r2712

13 years ago* src/modest-init.c:
Jose Dapena Paz [Wed, 11 Jul 2007 15:52:47 +0000 (15:52 +0000)]
* src/modest-init.c:
        * Now we set properly the default settings of the columns
          and we don't set random values due to random array values
          (fixes NB#62593).

pmo-trunk-r2711

13 years agoAdded a TODO.
Murray Cumming [Wed, 11 Jul 2007 15:33:49 +0000 (15:33 +0000)]
Added a TODO.

pmo-trunk-r2710

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Wed, 11 Jul 2007 15:30:34 +0000 (15:30 +0000)]
* src/modest-ui-actions.c:
        * Unregister header after finishing attachment purge
          (fixes NB#63007).

pmo-trunk-r2709

13 years ago * Fixed some reference leaks
Sergio Villar Senin [Wed, 11 Jul 2007 15:29:19 +0000 (15:29 +0000)]
* Fixed some reference leaks
* Removed an unneeded ref/unref pair

pmo-trunk-r2708

13 years ago2007-07-11 Murray Cumming <murrayc@murrayc-desktop>
Murray Cumming [Wed, 11 Jul 2007 15:22:41 +0000 (15:22 +0000)]
2007-07-11  Murray Cumming  <murrayc@murrayc-desktop>

* src/modest-ui-actions.h:
* src/modest-ui-actions.c:
(modest_ui_actions_on_delete_message):
Move some code into a new
modest_ui_actions_refresh_message_window_after_delete()
function so we can use it from elsewhere.

* src/dbus_api/modest-dbus-callbacks.c:
(on_idle_delete_message), (on_delete_message): Used an idle
handler, as we do for the other D-Bus method handlers.
Call modest_ui_actions_refresh_message_window_after_delete()
if the deleted message was open in a window. This fixed
projects.maemo.org bug NB#62862.

pmo-trunk-r2707

13 years ago* logical-id fix, fixes: NB #63117
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 15:20:17 +0000 (15:20 +0000)]
* logical-id fix, fixes: NB #63117

pmo-trunk-r2706

13 years ago2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 11 Jul 2007 15:17:45 +0000 (15:17 +0000)]
2007-07-11  Johannes Schmid <johannes.schmid@openismus.com>

* src/widgets/modest-folder-view.c: (filter_row)
Do not show drafts folder (see UI specs)

pmo-trunk-r2705

13 years ago2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 11 Jul 2007 15:13:16 +0000 (15:13 +0000)]
2007-07-11  Johannes Schmid <johannes.schmid@openismus.com>

* src/modest-ui-actions.c:
Remove call to show_non_move_folders(TRUE) which was moved to a wrong
place and also not necessary.

* src/widgets/modest-folder-view.c: (filter_row)
Guess folder type and hide Sent & Outbox if necessary.
Fixed project.maemo.org NB#57328

pmo-trunk-r2704

13 years agoMoving some code
Philip Van Hoof [Wed, 11 Jul 2007 14:53:03 +0000 (14:53 +0000)]
Moving some code

pmo-trunk-r2703

13 years agoAdded all the bugs in resolved fixed status for w28.
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 14:47:15 +0000 (14:47 +0000)]
Added all the bugs in resolved fixed status for w28.

pmo-trunk-r2702

13 years agoAdded all the bugs in resolved fixed status for w28.
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 14:44:02 +0000 (14:44 +0000)]
Added all the bugs in resolved fixed status for w28.

pmo-trunk-r2701

13 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Wed, 11 Jul 2007 14:23:05 +0000 (14:23 +0000)]
* src/widgets/modest-folder-view.c:
        * Removed a posible leak of a reference to folders if
          folders retrieval failed.
* src/widgets/modest-header-view.c:
        * Put null to some headers initial values to prevent using it
          without values.
* src/modest-tny-msg.c:
        * Add a reference owned by the attachments list
* src/maemo/modest-msg-view-window.c:
        * We don't run the clipboard owner change handler if the
          window is not visible.

pmo-trunk-r2700

13 years agoClearing the folder before rename
Philip Van Hoof [Wed, 11 Jul 2007 14:15:11 +0000 (14:15 +0000)]
Clearing the folder before rename

pmo-trunk-r2699

13 years ago* src/widgets/modest-header-view-render.c:
Jose Dapena Paz [Wed, 11 Jul 2007 14:04:08 +0000 (14:04 +0000)]
* src/widgets/modest-header-view-render.c:
* Now we unref the header instance for outgoing folders
  after using it.

pmo-trunk-r2698

13 years ago2007-07-11 Murray Cumming <murrayc@murrayc-desktop>
Murray Cumming [Wed, 11 Jul 2007 13:34:57 +0000 (13:34 +0000)]
2007-07-11  Murray Cumming  <murrayc@murrayc-desktop>

* src/modest-main.c: (main): Only show the UI at the start if
the showui command line option was given. For instance,
run-standalone src/modest showui
Otherwise, we wait for the top_application D-Bus method to
be sent by hildon-desktop when the application is selected
from the menu.
This allows us to run without a UI when osso-global-search
uses our D-Bus methods.

pmo-trunk-r2697

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Wed, 11 Jul 2007 12:43:35 +0000 (12:43 +0000)]
* src/modest-ui-actions.c:
        * Removed annoying warning for check retrieval in message open
          handler. THis was appearing everytime we cancelled a
          message retrieval.
* src/modest-mail-operation.c:
        * Now we notify the end of the mail operation before
          unreferencing. This prevents a crash.
        * Now we do a tny_account_cancel in status handler when we
          get a cancel status. This way we properly cancel the
          message download (and then we can try again to open the
          message as expected (fixes NB#62444).

pmo-trunk-r2696

13 years ago* improve modest_folder_view_select_folder:
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 12:08:59 +0000 (12:08 +0000)]
* improve modest_folder_view_select_folder:
  - move the cursor as well (this fixes the seemingly double selection prob
  - expand the the treeview if we created an invisible subfolder

pmo-trunk-r2695

13 years ago2007-07-11 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 11 Jul 2007 11:50:59 +0000 (11:50 +0000)]
2007-07-11  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-api.h: Added a define for a
top-application D-Bus method.
* src/dbus_api/modest-dbus-callbacks.c:
(on_top_application),
(modest_dbus_req_handler): Handle the top-application D-Bus
method, which might be an undocumented D-Bus signal sent by
hildon-desktop when it starts the application from the menu.
But I am not sure and I need to test it on the device, because
my scratchbox does not have the application in the menu now.
This method shows the main window, so that it can be invisible
when started, for instance, just for email searching from
osso-global-search.

* src/maemo/modest-main-window.c: (restore_settings),
(modest_main_window_new): Do not show the window immediately
upon creation. We show it later.
* src/modest-widget-memory.c: (save_settings_paned):
Try (unsuccessfully) to avoid saving the paned position when
it is not even visible.
(restore_settings_paned): Do not allow a silly paned position.
This seems necessary when not showing the window at first.

* tests/dbus_api/Makefile.am:
* tests/dbus_api/test_top_application.c: (main): Test for the
new D-Bus method.

pmo-trunk-r2694

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Wed, 11 Jul 2007 09:35:02 +0000 (09:35 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Refactored the save_attachments dialog construction to share
          more code for checkings and file chooser management.
        * Now saving attachments is asynchronous, and then we can show a
          proper information banner while saving (fixes NB#62823).
        * Added information banner for "saved".
        * Removed some leaks.

pmo-trunk-r2693

13 years ago* Fixed some bugs about last revision of dimming rules.
Javier Fernandez Garcia-Boente [Wed, 11 Jul 2007 09:16:50 +0000 (09:16 +0000)]
* Fixed some bugs about last revision of dimming rules.

pmo-trunk-r2692

13 years ago* Review dimming rules, according new specs about
Javier Fernandez Garcia-Boente [Wed, 11 Jul 2007 09:09:10 +0000 (09:09 +0000)]
* Review dimming rules, according new specs about
main view and viewer windows toolbar and menu items.

pmo-trunk-r2691

13 years ago * Updated the help ids to the new specs
Sergio Villar Senin [Wed, 11 Jul 2007 08:43:54 +0000 (08:43 +0000)]
* Updated the help ids to the new specs
* Fixed an issue when detecting the type of the folder when showing the help

pmo-trunk-r2690

13 years ago * Refactored the "Move to" stuff in the ui actions
Sergio Villar Senin [Wed, 11 Jul 2007 08:10:51 +0000 (08:10 +0000)]
* Refactored the "Move to" stuff in the ui actions
* Added a next_row_reference field to help the viewer when the current message is transfered
* Fixes NB#61931 consecutive move operations from the viewer are working now
* Fixes NB#62925 trying to move to root folders shows an error dialog and no longer crashes

pmo-trunk-r2689

13 years agoAdded all the bugs in resolved fixed status for w28.
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 07:39:12 +0000 (07:39 +0000)]
Added all the bugs in resolved fixed status for w28.

pmo-trunk-r2688

13 years ago* switch the focus to the renamed folder... fixes NB#63002
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 23:59:26 +0000 (23:59 +0000)]
* switch the focus to the renamed folder... fixes NB#63002

pmo-trunk-r2687

13 years ago* compilation fix
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 23:58:41 +0000 (23:58 +0000)]
* compilation fix

pmo-trunk-r2686

13 years ago* let the dbus-invoked msgs use the same uids as other messages,
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 23:13:08 +0000 (23:13 +0000)]
* let the dbus-invoked msgs use the same uids as other messages,
  so, modest-window-mgr will do the right thing.

also fixed up modest-window-mgr a bit.

  fixes: NB#62897

pmo-trunk-r2685

13 years ago* select the newly created folder.
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 19:04:52 +0000 (19:04 +0000)]
* select the newly created folder.
  when creating a new folder, we do a
modest_folder_view_select_folder (view, folder, TRUE)
   the TRUE means that we will register the changed
   folder in the folder view, and it will be selected
   as soon as the folder view is updated

pmo-trunk-r2684

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 10 Jul 2007 19:03:29 +0000 (19:03 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Changed max width of images as using the thumbable scrollbar
  we have less space for the editor (fixes NB#62804).

pmo-trunk-r2683

13 years ago* select the inbox of the newly selected account; fixes NB#58667
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 18:46:40 +0000 (18:46 +0000)]
* select the inbox of the newly selected account; fixes NB#58667

pmo-trunk-r2682

13 years ago2007-07-10 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 10 Jul 2007 18:24:30 +0000 (18:24 +0000)]
2007-07-10  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_new_msg),
(modest_ui_dimming_rules_on_reply_msg),
(modest_ui_dimming_rules_on_delete_msg),
(modest_ui_dimming_rules_on_details),
(modest_ui_dimming_rules_on_view_window_move_to),
(modest_ui_dimming_rules_on_view_previous),
(modest_ui_dimming_rules_on_view_next),
(_invalid_folder_for_purge): Added checks before
casting the window. This looks like an actual
logic error in _invalid_folder_for_purge(), because it
tries to use a ModestMainWindow as a message window.

pmo-trunk-r2681

13 years ago2007-07-10 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 10 Jul 2007 17:13:46 +0000 (17:13 +0000)]
2007-07-10  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-settings-dialog.c:
(show_error): Use the same implementation as in
modest-easysetup-wizard.c:
(on_entry_invalid_character): The logical ID contains a %s.
Guessed what it should be.
(on_entry_max), (check_data), (on_response): Adapt to
changed show_error().
(create_page_account_details): Really call
modest_validating_entry_set_func() on the correct widgets.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(on_entry_invalid_character): Fix the logical ID here too.
 (create_page_account_details),
(create_page_user_details):
Really call
modest_validating_entry_set_func() on the correct widgets.

* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Do not try to use the account if it is NULL.

pmo-trunk-r2680

13 years ago2007-07-10 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 10 Jul 2007 17:13:37 +0000 (17:13 +0000)]
2007-07-10  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-settings-dialog.c:
(show_error): Use the same implementation as in
modest-easysetup-wizard.c:
(on_entry_invalid_character): The logical ID contains a %s.
Guessed what it should be.
(on_entry_max), (check_data), (on_response): Adapt to
changed show_error().
(create_page_account_details): Really call
modest_validating_entry_set_func() on the correct widgets.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(on_entry_invalid_character): Fix the logical ID here too.
 (create_page_account_details),
(create_page_user_details):
Really call
modest_validating_entry_set_func() on the correct widgets.

* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Do not try to use the account if it is NULL.

pmo-trunk-r2679

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 10 Jul 2007 16:42:33 +0000 (16:42 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now we load the pixbuf that goes to the buffer before adding
          the attachment, as this causes reads to the vfs stream, and
          then, corruption of data.

pmo-trunk-r2678

13 years ago* Call refilter function on header view only when header delete
Javier Fernandez Garcia-Boente [Tue, 10 Jul 2007 16:25:36 +0000 (16:25 +0000)]
* Call refilter function on header view only when header delete
change is notified.
* Fixes: NB#60389

pmo-trunk-r2677

13 years ago* src/modest-mail-operation.[ch]:
Jose Dapena Paz [Tue, 10 Jul 2007 16:13:57 +0000 (16:13 +0000)]
* src/modest-mail-operation.[ch]:
        * New mail operation "get_mime_part_size", asynchronous. This
          is used to show the mime part size in attachment view without
          blocking the UI when the size is big enough.
        * New mail operation "create_msg", asynchronous, that contains
          the old work done in save to drafts and send new mail for
          creating a valid TnyMsg instance to send. This is required
          because the operation can take long when the attachments are
          big enough. This operation is private.
        * Now send_new_mail and save_to_drafts use the new "create_msg"
          mail operation to avoid stalling the UI.
* src/widgets/modest-attachment-view.c:
        * Now we use the new mail operation for getting the attachment
          size. This way we don't block on attaching big files or
          from slow folders (as shared folders). We also remove the
          old synchronous implementation.
* src/modest-tny-msg.[ch]:
        * Now the constructors get a GList of attachments, not a (really
          fake) GSList.
* src/modest-ui-actions.c:
        * Now the save to drafts action does not remove the old draft
          itself, as it's now done internally in the mail operation. We
          also provide the edit window.
* src/maemo/modest-msg-edit-window.c:
        * We don't hang looping when there's an error in mime parts.
        * Now we check if the widget is visible on clipboard owner
          handler to prevent crashes on calling the handler after
          destroiying and before finalizing.

pmo-trunk-r2676

13 years ago2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Tue, 10 Jul 2007 16:00:52 +0000 (16:00 +0000)]
2007-07-10  Johannes Schmid <johannes.schmid@openismus.com>

* src/modest-ui-actions.c: (create_move_to_dialog),
(modest_ui_actions_on_main_window_move_to),
(modest_ui_actions_on_msg_view_window_move_to):
* src/widgets/modest-folder-view.c: (modest_folder_view_init),
(filter_row), (modest_folder_view_show_non_move_folders):
* src/widgets/modest-folder-view.h:

Hide Sent & Outbox folder in \"move to\"-dialog. Does not work for
the Sent folder yet as it does not report the correct folder type.

pmo-trunk-r2675

13 years ago* Review status management of OUTBOX messages while
Javier Fernandez Garcia-Boente [Tue, 10 Jul 2007 14:59:21 +0000 (14:59 +0000)]
* Review status management of OUTBOX messages while
are being processed by TnySendQueue.
* Connect handlers to 'msg-sending' and 'msg-sent'
signals emmited by TnyCamelSendQueue.

pmo-trunk-r2674