modest
13 years ago2007-07-31 Philip Van Hoof <pvanhoof@gnome.org>
Philip Van Hoof [Tue, 31 Jul 2007 08:24:20 +0000 (08:24 +0000)]
2007-07-31  Philip Van Hoof  <pvanhoof@gnome.org>

* Merging back devel/sessionwork to trunk/

pmo-trunk-r2866

13 years ago* src/modest-text-utils.[ch]:
Jose Dapena Paz [Tue, 31 Jul 2007 08:19:43 +0000 (08:19 +0000)]
* src/modest-text-utils.[ch]:
        * New method (modest_text_utils_text_buffer_get_text): wrapper
          around gtk_text_buffer_get_slice, that replaces the image
          pixbuf special character 0xFFFC with a blank space.
* src/modest-msg-edit-window.c:
        * Use the new modest_text_utils_text_buffer_get_text to get the
          plain body representation of a formatted html mail. This
          makes a mail with only images return a length greater than 0
          (fixes NB#64627).

pmo-trunk-r2865

13 years ago2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Tue, 31 Jul 2007 08:05:46 +0000 (08:05 +0000)]
2007-07-30  Johannes Schmid <johannes.schmid@openismus.com>

* src/modest-ui-actions.c: (modest_ui_actions_on_send):

Show account wizard if no accounts are defined while sending
(automatic sending after the account wizard finished does not
work because it takes some time until the accoun

pmo-trunk-r2862

13 years agoAdded new fixes to changelog - week 31 - 31th july.
Dirk-Jan C. Binnema [Tue, 31 Jul 2007 07:42:45 +0000 (07:42 +0000)]
Added new fixes to changelog -  week 31 - 31th july.

pmo-trunk-r2861

13 years ago* explicitely undim the Ok-button after an entry_changed, so Ok is enabled
Dirk-Jan C. Binnema [Tue, 31 Jul 2007 07:07:05 +0000 (07:07 +0000)]
* explicitely undim the Ok-button after an entry_changed, so Ok is enabled
  again after the some condition that made it disabled before, disappears.

Fixes: NB#64621

pmo-trunk-r2860

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Mon, 30 Jul 2007 17:09:29 +0000 (17:09 +0000)]
* src/modest-ui-actions.c:
        * If we get a folder empty selection, and focus is in
          headers view, move focus to folder view.
* src/maemo/modest-main-window.c:
        * If the message count of the folder is 0 then move the focus to
          the folder view (fixes NB#63198).

pmo-trunk-r2859

13 years ago* src/maemo/modest-address-book.c:
Jose Dapena Paz [Mon, 30 Jul 2007 16:13:11 +0000 (16:13 +0000)]
* src/maemo/modest-address-book.c:
        * Now check names information banner can only be shown if the
          operation lasts for more than 2 seconds (fixes NB#63057).

pmo-trunk-r2858

13 years ago* src/widgets/modest-recpt-editor.c:
Jose Dapena Paz [Mon, 30 Jul 2007 15:46:53 +0000 (15:46 +0000)]
* src/widgets/modest-recpt-editor.c:
* WOps, forgot to take into account quoted address names.
  With this we really fix NB#62993.

pmo-trunk-r2857

13 years ago* src/widgets/modest-recpt-editor.c:
Jose Dapena Paz [Mon, 30 Jul 2007 15:35:44 +0000 (15:35 +0000)]
* src/widgets/modest-recpt-editor.c:
        * Now validation functions remove \n and \t characters
        * Now validation functions add a \n after each , or ; if they're
          not at the end, and no \n has been inserted before
        * Now we validate the string on set_recipients. This way, the
          characters get proper layout on setting fields in editor
          (fixes NB#62993).

pmo-trunk-r2856

13 years ago2007-07-30 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 30 Jul 2007 14:55:58 +0000 (14:55 +0000)]
2007-07-30  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (on_account_removed),
(on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
account is removed from the View menu. We have TnyAccountStore
and ModestTnyAccountStore signals that seem very similar, but this
seems to work for now.

* src/maemo/modest-main-window.c:
(on_show_account_action_activated): Prevent dereference
of a NULL if the accoutn does not really exist, though that
should not happen anymore.

This fixes projects.maemo.org bug NB#64606.

pmo-trunk-r2855

13 years agoAdded new fixes to changelog - week 31 - 30th july.
Dirk-Jan C. Binnema [Mon, 30 Jul 2007 14:52:04 +0000 (14:52 +0000)]
Added new fixes to changelog -  week 31 - 30th july.

pmo-trunk-r2854

13 years ago* src/maemo/modest-account-settings-dialog.c:
Jose Dapena Paz [Mon, 30 Jul 2007 14:05:07 +0000 (14:05 +0000)]
* src/maemo/modest-account-settings-dialog.c:
        * (create_page_user_details): use a scrolled window for options
          so that showing vkb does not hide the ok/cancel buttons. We
          also add proper focus adjustment (fixes NB#64537).
        * (create_page_outgoing): add proper focus adjustment.

pmo-trunk-r2852

13 years ago* src/maemo/ui/modest-msg-edit-window-ui.xml:
Jose Dapena Paz [Mon, 30 Jul 2007 13:44:54 +0000 (13:44 +0000)]
* src/maemo/ui/modest-msg-edit-window-ui.xml:
* Added 80% and 120% to editor so that we use the zoom levels
  specified in Email UI specs 2.2 document wiki. Fixes NB#61337.

pmo-trunk-r2851

13 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Mon, 30 Jul 2007 13:35:02 +0000 (13:35 +0000)]
* src/maemo/modest-main-window.c:
* Show only "Send&Receive/All" option when there are 2 or more
  accounts. The older condition was "there are 1 or more"
  (fixes NB#59238).

pmo-trunk-r2850

13 years ago* src/modest-tny-msg.[ch]:
Jose Dapena Paz [Mon, 30 Jul 2007 13:07:41 +0000 (13:07 +0000)]
* src/modest-tny-msg.[ch]:
        * (create_reply_forward_mail): now get a TnyHeader attribute
          for the case we don't have a full TnyMsg available.
        * (modest_tny_msg_create_forward_msg): use the new
          create_reply_forward_mail api.
        * (modest_tny_msg_create_reply_msg): now it gets a TnyHeader
          parameter for the case there's no TnyMsg available (it should
          happen at least on replying without original message in main
          window.
* src/modest-ui-actions.c:
        * (reply_forward_cb): uses the new
          modest_tny_msg_create_reply_msg api.
        * (reply_forward_cb): now we don't free the header parameter
          in this callback, as this should be done by callers.
        * (reply_forward): now we don't show the retrieve confirmation
          dialog on replying without original message in reply. We don't
          retrieve the original message too (fixes NB#63674).

pmo-trunk-r2849

13 years ago* src/maemo/modest-platform.c:
Jose Dapena Paz [Mon, 30 Jul 2007 11:23:39 +0000 (11:23 +0000)]
* src/maemo/modest-platform.c:
* (modest_platform_run_folder_name_dialog): we don't show
  insensitive information banner for ok button (fixes NB#64174).

pmo-trunk-r2847

13 years ago* src/modest-tny-msg.[ch]:
Jose Dapena Paz [Mon, 30 Jul 2007 11:15:49 +0000 (11:15 +0000)]
* src/modest-tny-msg.[ch]:
        * Now modest_tny_msg_get_body tells if the original body was
          plain text or html.
* src/widgets/modest-msg-edit-window.h:
        * Now modest_msg_edit_window_new gets a new parameter
          preserve_is_rich, that sets the format to the one in the
          original message in case it's set.
* src/maemo/modest-msg-edit-window.c:
        * Preserves the plain text format in case it's requested
          (fixes NB#64170).
        * Now we reset modified status on constructor to prevent getting
          modifications from construction process.
* src/modest-ui-actions.c:
        * Use the new modest_msg_edit_window_new api. For messages
          opened from drafts, it preserves the format (plain or html).
          For other messages, it respects the configuration preference.
* src/gnome/modest-msg-edit-window.c:
        * Fill the new is_html parameter in modest_tny_msg_new method.

pmo-trunk-r2846

13 years ago* Outbox messsages are opened in edit window.
Javier Fernandez Garcia-Boente [Mon, 30 Jul 2007 10:38:58 +0000 (10:38 +0000)]
* Outbox messsages are opened in edit window.
* If they are modifed, they are saved to draf if ther was not send.
* Otherwise, they are saved again into outbox
* Messages which are being edited are excluded from sent-queue.
* Fixes: NB#57915

pmo-trunk-r2843

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 30 Jul 2007 09:46:26 +0000 (09:46 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Fixed an error in the condition to change colors in
  modest_msg_edit_window_set_format_state. The condition to
  declare a changeset was reversed.
* (modest_msg_edit_window_set_format_state): now we set
  the bullet attribute out of the freeze/thaw region, as
  bullet format is applied only if not frozen (fixes NB#63500).

pmo-trunk-r2842

13 years ago2007-07-30 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 30 Jul 2007 08:22:37 +0000 (08:22 +0000)]
2007-07-30  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-actions.c: (run_account_setup_wizard),
(modest_ui_actions_on_accounts): Revert a change that set these
to modal dialogs, freezing the UI when they show secondary dialogs.
This fixed projects.maemo.org bug NB#64519.

pmo-trunk-r2839

13 years ago* small optimization; we don't need to retrieve name, message count for the
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 18:40:30 +0000 (18:40 +0000)]
* small optimization; we don't need to retrieve name, message count for the
  icon-cell rendering.

pmo-trunk-r2836

13 years ago* refresh header view after deleting a message from outbox.
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 16:51:36 +0000 (16:51 +0000)]
* refresh header view after deleting a message from outbox.
  fixes: NB#63428, and maybe some others (will check)

pmo-trunk-r2834

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Fri, 27 Jul 2007 16:37:36 +0000 (16:37 +0000)]
* src/modest-ui-actions.c:
* Added modality and transiency for settings, accounts,
  header and folder details (fixes NB#64326).

pmo-trunk-r2833

13 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Fri, 27 Jul 2007 16:19:11 +0000 (16:19 +0000)]
* src/modest-ui-dimming-rules.c:
* Now rename is disabled also for "Archive" folder
  (fixes NB#64259).

pmo-trunk-r2832

13 years ago* don't accept folder names starting with ' ', take copy-paste into account
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 16:07:03 +0000 (16:07 +0000)]
* don't accept folder names starting with ' ', take copy-paste into account
  this should fix NB#58923

pmo-trunk-r2831

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Fri, 27 Jul 2007 16:05:36 +0000 (16:05 +0000)]
* src/modest-ui-actions.c:
        * (modest_ui_actions_on_cut, modest_ui_actions_on_copy):
          now we store the clipboard on copy operation for gtkhtml. We
          add storing for all the text clipboard operations
          (fixes NB#64206).

pmo-trunk-r2830

13 years ago2007-07-27 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 27 Jul 2007 15:38:16 +0000 (15:38 +0000)]
2007-07-27  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-header-view-render.c:
(_modest_header_view_compact_header_cell_data):
Some checks and initialization to try to deal with a crash,
probably ineffective.

pmo-trunk-r2829

13 years ago* trivial fix for NB#64328
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 14:58:08 +0000 (14:58 +0000)]
* trivial fix for NB#64328

pmo-trunk-r2828

13 years ago* let the folder view honour the modest-folder-rules, for drag&drop of
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 14:35:04 +0000 (14:35 +0000)]
* let the folder view honour the modest-folder-rules, for drag&drop of
  both headers and messages; fixes #64263

pmo-trunk-r2827

13 years agoAdded wpeditor0 as dependency.
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 14:21:57 +0000 (14:21 +0000)]
Added wpeditor0 as dependency.

pmo-trunk-r2826

13 years ago* modest_text_utils_get_display_date: we do a quick check whether the date
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 13:35:24 +0000 (13:35 +0000)]
* modest_text_utils_get_display_date: we do a quick check whether the date
  is within the last 24h before doing the expensive extra strftime. As this
  function is called for every header in the header view, this should help
  a bit (it was showing up high in the profile before)

pmo-trunk-r2825

13 years agoAdded new fixes to changelog - week 31 - 27th july.
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 12:53:52 +0000 (12:53 +0000)]
Added new fixes to changelog -  week 31 - 27th july.

pmo-trunk-r2823

13 years ago* make the hyperlinkify regexp code a bit faster, also don't try
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 12:00:30 +0000 (12:00 +0000)]
* make the hyperlinkify regexp code a bit faster, also don't try
  to hyperlinkify really big parts, because it will take very, very
  long even in sbox. limit is 100KB now.

pmo-trunk-r2822

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Fri, 27 Jul 2007 11:45:45 +0000 (11:45 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now opening attached messages inherits zoom level
  (fixes NB#64130).

pmo-trunk-r2821

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Fri, 27 Jul 2007 10:17:59 +0000 (10:17 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Now we use window manager on reading messages. If a message
          is already shown in another window, it closes the window
          and presents the other (fixes NB#64051).

pmo-trunk-r2819

13 years ago2007-07-27 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 27 Jul 2007 10:03:32 +0000 (10:03 +0000)]
2007-07-27  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-utils.c:
(modest_maemo_utils_get_supported_secure_authentication_methods):
Make sure that we have a connection, asking the user for one
if necessary.
* src/maemo/modest-main-window.c: (modest_main_window_on_show):
Check for a connection before showing the wizard, because
the wizard needs a connection to check for server capabilities.

pmo-trunk-r2818

13 years ago2007-07-27 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 27 Jul 2007 09:12:10 +0000 (09:12 +0000)]
2007-07-27  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-view-window.c:
(on_new_button_clicked): Remember the wizard dialog instance,
so we can just present it again if necessary. This prevents
multiple windows from appearing if you click again quickly on the
New button before the dialog appears, fixing projects.maemo.org
bug NB#64169.

pmo-trunk-r2817

13 years ago2007-07-27 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 27 Jul 2007 08:41:38 +0000 (08:41 +0000)]
2007-07-27  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-main-window.c: (modest_main_window_on_show):
Offer a connection dialog if there is no connection when
starting modest. This should fix projects.maemo.org bug NB#61134.

pmo-trunk-r2816

13 years ago2007-07-27 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 27 Jul 2007 08:17:05 +0000 (08:17 +0000)]
2007-07-27  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
Reverted my last commit. I was able to fix the build by doing
apt-get install wpeditor0 (replacing other wpeditor packages) and
an explicit apt-get install wpeditor-dev to upgrade the -dev
package.

pmo-trunk-r2815

13 years ago2007-07-27 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 27 Jul 2007 08:08:49 +0000 (08:08 +0000)]
2007-07-27  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
Commented out the use of wp_text_buffer_replace_image()
because it does not exist, to break the build. Added a TODO for it.

pmo-trunk-r2814

13 years ago * Fixes NB#64200, do not ask for a new connection when trying to open a message...
Sergio Villar Senin [Thu, 26 Jul 2007 20:12:16 +0000 (20:12 +0000)]
* Fixes NB#64200, do not ask for a new connection when trying to open a message if it was already downloaded

pmo-trunk-r2813

13 years ago* src/maemo/modest-msg-view-window-ui-dimming.h:
Jose Dapena Paz [Thu, 26 Jul 2007 19:23:42 +0000 (19:23 +0000)]
* src/maemo/modest-msg-view-window-ui-dimming.h:
* Added dimming rule for delete in menu (fixes NB#63246).

pmo-trunk-r2812

13 years ago * Select the INBOX with the proper GtkTreeView call instead of trying to select...
Sergio Villar Senin [Thu, 26 Jul 2007 18:57:29 +0000 (18:57 +0000)]
* Select the INBOX with the proper GtkTreeView call instead of trying to select it with the GtkTreeSelection

pmo-trunk-r2811

13 years ago * Fixes NB#64270, now it's not possible to move a folder into itself
Sergio Villar Senin [Thu, 26 Jul 2007 18:55:02 +0000 (18:55 +0000)]
* Fixes NB#64270, now it's not possible to move a folder into itself

pmo-trunk-r2810

13 years ago* src/widgets/modest-msg-edit-window.h:
Jose Dapena Paz [Thu, 26 Jul 2007 16:48:08 +0000 (16:48 +0000)]
* src/widgets/modest-msg-edit-window.h:
        * New API method for adding a part as an attachment.
* src/widgets/modest-folder-view.h:
        * Removed non implemented method ..._get_selected_name.
* src/widgets/modest-ui-actions.c:
        * Now, if we have messages in clipboard and we paste them in
          editor, they're pasted as attachments (fixes NB#63810).
* src/maemo/modest-msg-edit-window.c:
        * Added DEBUG_BUFFER method and calls for debugging buffer
          status. This throw messages only if DEBUG is defined.
        * Now we update properly the visibility of BCC and CC fields
          (fixes NB#62722).
        * Refactored the way we obtain a pixbuf from a stream, to
          share implementation among new image attachment or replaced
          image attachment.
        * Now we have a method to fill attachment replacements with
          the images. This way we can recover the images in the buffer
          properly for a mail opened from drafts (fixes NB#62369).
        * Now we add the find toolbar using HildonWindow API. This
          way the frame is properly configured (fixes NB#63201).
        * Now we use the refactored toggle action block notify in maemo
          utils.
        * Now, if the buffer is empty, we show the "nothing to find"
          warning on performing find in page (fixes NB#62350).
        * Update dimming implementation of paste action to make paste
          available also when there are messages in the clipboard.
        * Now we replace the image replacements with images also when
          tags are applied. This way, undo works better for inline
          images (fixes NB#63336, NB#60993).
        * New method to add parts as attachments.
        * Now we register that deserializer can create new tags. This
          should prevent crashes on copying buffers with tags
          (fixes NB#64214 and NB#64368).

pmo-trunk-r2809

13 years ago* Open outbox messages in a draft view window.
Javier Fernandez Garcia-Boente [Thu, 26 Jul 2007 16:42:09 +0000 (16:42 +0000)]
* Open outbox messages in a draft view window.
* Fixes: NB#57915

pmo-trunk-r2808

13 years ago2007-07-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 26 Jul 2007 16:09:24 +0000 (16:09 +0000)]
2007-07-26  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (recreate_all_accounts):
Recreate them even if they were NULL before. I guess something
else was already creating them before, or this would never
have worked.
(modest_tny_account_store_get_server_account): Make sure that
the tny accounts have been created before trying to find one.
This allows libmodest_dbus_client_compose_mail() to work
when the UI is not yet visible.
This is probably useful in other cases too.

(get_password): When the password is wrong after it is entered
in the protected password dialog, show an info banner (in an
idle handler) before showing the protected password dialog
again.

pmo-trunk-r2807

13 years agoAdded new fixes to changelog - week 31.
Dirk-Jan C. Binnema [Thu, 26 Jul 2007 12:46:24 +0000 (12:46 +0000)]
Added new fixes to changelog -  week 31.

pmo-trunk-r2806

13 years ago * Deleted a private method that made no sense. Replaced it by gtk_tree_view_set_cursor
Sergio Villar Senin [Thu, 26 Jul 2007 12:40:40 +0000 (12:40 +0000)]
* Deleted a private method that made no sense. Replaced it by gtk_tree_view_set_cursor

pmo-trunk-r2805

13 years ago * Fixes blocker NB#60968, it now shows Fullscreen instead of the logical id
Sergio Villar Senin [Thu, 26 Jul 2007 12:18:22 +0000 (12:18 +0000)]
* Fixes blocker NB#60968, it now shows Fullscreen instead of the logical id

pmo-trunk-r2804

13 years ago* src/widgets/modest-msg-view.c:
Jose Dapena Paz [Thu, 26 Jul 2007 11:35:04 +0000 (11:35 +0000)]
* src/widgets/modest-msg-view.c:
* Arg, the new size was wrong, setting a right one
  (re fixes NB#62820).

pmo-trunk-r2803

13 years ago* src/widgets/modest-msg-view.c:
Jose Dapena Paz [Thu, 26 Jul 2007 11:31:45 +0000 (11:31 +0000)]
* src/widgets/modest-msg-view.c:
* Now we readjust the scrolls in a timeout of 250
  milliseconds after setting a new message. This should
  prevent being able to scroll the body inside its area
  when it shouldn't (fixes NB#62820).

pmo-trunk-r2802

13 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Thu, 26 Jul 2007 08:06:06 +0000 (08:06 +0000)]
* src/widgets/modest-folder-view.c:
* Send display name update signal more frequently

pmo-trunk-r2801

13 years ago* src/widgets/modest-details-dialog.c:
Jose Dapena Paz [Thu, 26 Jul 2007 08:01:31 +0000 (08:01 +0000)]
* src/widgets/modest-details-dialog.c:
* Reorganisation of fields shown in details dialog.

pmo-trunk-r2800

13 years ago* src/modest-mail-operation.c:
Jose Dapena Paz [Thu, 26 Jul 2007 07:52:11 +0000 (07:52 +0000)]
* src/modest-mail-operation.c:
* (modest_mail_operation_cancel): a mail operation without an
  account is a not expected status, so we show a warning for
  this.

pmo-trunk-r2799

13 years ago2007-07-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 26 Jul 2007 07:33:06 +0000 (07:33 +0000)]
2007-07-26  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-actions.h:
* src/modest-ui-actions.c: Added
modest_do_refresh_current_folder() containing some code from
modest_ui_actions_on_send_receive().
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
Call modest_do_refresh_current_folder() before refreshing the
requested account, as in modest_ui_actions_on_send_receive().
This is strange, but seems to be necessary to show new mails.
Now new emails are finally visible in the UI when downloaded
via the automatic update interval, fixing bug NB#57458.
This also works because bug NB#57458 has been fixed somehow.

pmo-trunk-r2798

13 years agoUpdate the ChangeLog: This fixes projects.maemo.org bug
Murray Cumming [Thu, 26 Jul 2007 06:43:26 +0000 (06:43 +0000)]
Update the ChangeLog: This fixes projects.maemo.org bug
NB#64225.

pmo-trunk-r2797

13 years ago2007-07-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 26 Jul 2007 06:42:47 +0000 (06:42 +0000)]
2007-07-26  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
        printf more details when we get unhandled D-Bus methods, because
        it is interesting.

        * src/modest-mail-operation.c: (update_account_thread):
        Comment out the tny_camel_pop_store_account_reconnect(), because this
        is apparently no longer needed, and it did not work before anyway.
        See the comment in the code.

        * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
        by checking the header flags.

pmo-trunk-r2796

13 years ago* make the memory card Archive folder a localized one,
Dirk-Jan C. Binnema [Wed, 25 Jul 2007 16:03:50 +0000 (16:03 +0000)]
* make the memory card Archive folder a localized one,
  make sure the folder rules understand it's a special folder

pmo-trunk-r2795

13 years ago* add new addresses to the addressbook automatically when sending.
Dirk-Jan C. Binnema [Wed, 25 Jul 2007 15:15:30 +0000 (15:15 +0000)]
* add new addresses to the addressbook automatically when sending.
  fixes major bug NB#63631

pmo-trunk-r2794

13 years ago* inliner. save the bcc field as wel. Fixes major bug NB#64120
Dirk-Jan C. Binnema [Wed, 25 Jul 2007 12:44:59 +0000 (12:44 +0000)]
* inliner. save the bcc field as wel. Fixes major bug NB#64120

pmo-trunk-r2793

13 years ago2007-07-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 25 Jul 2007 12:34:45 +0000 (12:34 +0000)]
2007-07-25  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-utils.h:
* src/maemo/modest-maemo-utils.c: Added
modest_maemo_show_information_note_in_main_context_and_forget().
* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Use the new function to show simple error dialogs in the main
context, though question dialogs are still in the current context,
which is unfortunately usually not the main context. This should
fix some hangs.

pmo-trunk-r2792

13 years ago* don't do a regexp-search when doing search-in-page.
Dirk-Jan C. Binnema [Wed, 25 Jul 2007 12:20:42 +0000 (12:20 +0000)]
* don't do a regexp-search when doing search-in-page.
  this actually fixes #64261 when searching for "\", and
  the not-yet-discovered bug that we were doing regexp searches.

the crashing bug is actually in gtkhtml, will move the bug
  there.

pmo-trunk-r2791

13 years ago2007-07-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 25 Jul 2007 11:37:37 +0000 (11:37 +0000)]
2007-07-25  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (get_password):
Never save the entered username and password in gconf,
because the UI spec says we should not. This helps
slightly with projects.maemo.org bug NB#63671.

pmo-trunk-r2790

13 years ago2007-07-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 25 Jul 2007 09:52:49 +0000 (09:52 +0000)]
2007-07-25  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-msg-edit-window.h:
* src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
Moved some code here to make it simpler.
(modest_msg_edit_window_attach_file_one): Renamed from
modest_msg_edit_window_attach_file_interactive().
(modest_msg_edit_window_offer_attach_file): Renamed from
modest_msg_edit_window_attach_file() and used
modest_msg_edit_window_attach_file_one() instead of
copy/pasting the code. The old code for one was not using
GnomeVFS. This allows use of smb:// URLs when using send-as
from external applications, fixing bug NB#63741.

(modest_msg_edit_window_insert_image),
(modest_msg_edit_window_add_attachment_clicked):
* src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
Adapted to the new function names.

pmo-trunk-r2789

13 years ago2007-07-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 25 Jul 2007 08:58:32 +0000 (08:58 +0000)]
2007-07-25  Murray Cumming  <murrayc@murrayc.com>

(modest_platform_set_update_interval): Set the alarm recurrence
fields so that auto-update does not just happen the first time.
This should have fixed projects.maemo.org bug NB#63938.

When this happens you can see a printf when the D-Bus method is
called:
GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive

However, I do not actually seem to get new POP messages even when
clicking the refresh button manually. A restart gets them.
This might be a problem in today's tinymail only.

pmo-trunk-r2788

13 years ago2007-07-24 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 24 Jul 2007 16:54:32 +0000 (16:54 +0000)]
2007-07-24  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-global-settings-dialog.c:
(current_connection):
Avoid a crash (probably only in scratchbox) when strcmp()ing a
NULL when closing the dialog.

pmo-trunk-r2787

13 years agoAdded fixes made on 24 july.
Dirk-Jan C. Binnema [Tue, 24 Jul 2007 13:17:33 +0000 (13:17 +0000)]
Added fixes made on 24 july.

pmo-trunk-r2786

13 years ago* let modest_platform_get_file_icon_name accept files with NULL
Dirk-Jan C. Binnema [Tue, 24 Jul 2007 10:06:10 +0000 (10:06 +0000)]
* let modest_platform_get_file_icon_name accept files with NULL
  filenames as well. this should fix some icon / Criticals-issues.

pmo-trunk-r2784

13 years ago2007-07-24 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 24 Jul 2007 09:49:17 +0000 (09:49 +0000)]
2007-07-24  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
Remove the hacky send/receive that didn't work, and instead
refilter the treemodel to make the deleted email really vanish from
the UI (though the delete-from-menu code does has commented out
the code that does that). This fixes projects.maemo.org bug
NB#62859.

pmo-trunk-r2783

13 years ago2007-07-24 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 24 Jul 2007 09:07:54 +0000 (09:07 +0000)]
2007-07-24  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
Try a couple of tricks to force the treeview to update (
poke the folder, and do a send/receive refresh), but the deleted
email still appears with a strike-through instead of really being
removed.

pmo-trunk-r2782

13 years ago * Fixes NB#58923, an information banner is shown when trying to create/rename a...
Sergio Villar Senin [Tue, 24 Jul 2007 08:06:54 +0000 (08:06 +0000)]
* Fixes NB#58923, an information banner is shown when trying to create/rename a folder with an empty string

pmo-trunk-r2780

13 years ago * Fixes NB#60774, the logical id was deleted in version 1.1 of the specs
Sergio Villar Senin [Mon, 23 Jul 2007 19:45:40 +0000 (19:45 +0000)]
* Fixes NB#60774, the logical id was deleted in version 1.1 of the specs

pmo-trunk-r2779

13 years ago * Reverting some of the changes of commit 2431 because they're no longer valid since...
Sergio Villar Senin [Mon, 23 Jul 2007 18:57:00 +0000 (18:57 +0000)]
* Reverting some of the changes of commit 2431 because they're no longer valid since 2521

pmo-trunk-r2778

13 years ago2007-07-23 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 23 Jul 2007 18:18:25 +0000 (18:18 +0000)]
2007-07-23  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c:
(add_single_folder_to_list): Ignore TnyMergeFolder folders,
because their ID is not human-readable (see the comment about
improvements needed to the osso-email-interface API) and
TnyMergeFolder::get_id_func() currently crashes with DBC enabled.

pmo-trunk-r2777

13 years ago2007-07-23 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 23 Jul 2007 17:29:29 +0000 (17:29 +0000)]
2007-07-23  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
(add_folders_to_list), (on_dbus_method_get_folders),
(modest_dbus_req_filter):
* src/maemo/modest-maemo-utils.c:
(on_camel_account_get_supported_secure_authentication):
* src/maemo/modest-main-window.c: (modest_main_window_set_style),
(on_header_view_focus_in):
* src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
* src/modest-formatter.c: (modest_formatter_create_body_part):
* src/modest-mail-operation.c: (recurse_folders),
(update_account_thread), (get_msgs_full_thread),
(modest_mail_operation_get_msgs_full),
(modest_mail_operation_xfer_msgs):
* src/modest-search.c: (search_mime_part_and_child_parts),
(modest_search_account), (modest_search_all_accounts):
* src/modest-tny-account.c:
(modest_tny_account_get_special_folder), (recurse_folders):
* src/modest-tny-local-folders-account.c:
(modest_tny_local_folders_account_query_passes):
* src/modest-tny-msg.c: (copy_mime_part),
(modest_tny_msg_find_body_part_from_mime_part):
* src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
(modest_tny_send_queue_try_to_send):
* src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
(_modest_ui_actions_open), (download_uncached_messages),
(reply_forward), (modest_ui_actions_on_copy),
(modest_ui_actions_on_details), (has_retrieved_msgs),
(msgs_move_to_confirmation), (open_msg_for_purge_cb),
(do_headers_action):
* src/modest-ui-dimming-rules.c: (_already_opened_msg),
(_selected_msg_marked_as), (_msg_download_completed),
(_selected_msg_sent_in_progress):
* src/widgets/modest-attachments-view.c:
(modest_attachments_view_set_message):
* src/widgets/modest-msg-view.c: (find_cid_image):
* tests/check_folder-transfer.c: (find_folders):
* tests/check_update-account.c: (func):
* tests/dbus_api/test_get_folders.c: (main):
Checked all uses of tny_iterator_get_current(), making sure
that the object is unreferenced (3 or 4 places did not),
and adding checks for NULL.

pmo-trunk-r2776

13 years ago * Update the next_row_reference if it was invalidated previously
Sergio Villar Senin [Mon, 23 Jul 2007 17:06:20 +0000 (17:06 +0000)]
* Update the next_row_reference if it was invalidated previously
* Fixes NB#63349, the viewer moves to the next message even if the old following one was deleted

pmo-trunk-r2775

13 years ago * ModestAccountMgr: the account manager is just a facade to the configuration...
Sergio Villar Senin [Mon, 23 Jul 2007 16:38:03 +0000 (16:38 +0000)]
    * ModestAccountMgr: the account manager is just a facade to the configuration system, so it should
not know TnyAccounts only ModestAccounts. TnyAccounts are managed by the TnyAccountStore
        - removed the server_account parametter from the account_removed signal
        - removed the server_account parametter from the remove_account method
        - Changed the signature of the methods that handled the signal
        - completetly rewritten the account removal code
        * ModestTnyAccountStore
        - now it issues a account_removed for both the store and the transport account
        - completety rewritten the get_server_account method, it makes no sense to use the account mgr, because we h
ave the accounts
        * ModestFolderView
        - added a missing check
        - added a missing select inbox
- added a condition to the filter_row method, do not take into account the visible_account_id if we aren't in SHOW_ONE style

pmo-trunk-r2774

13 years ago2007-07-23 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 23 Jul 2007 14:52:44 +0000 (14:52 +0000)]
2007-07-23  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c:
(on_idle_open_default_inbox): Make sure that the application UI is
visible.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(on_entry_invalid_character): Show the word whitespace instead
of (null) in the banner when whitespace was entered.
(show_error): Add a comment that  this does not work in
Maemo Bora, though we do not know why.

pmo-trunk-r2773

13 years agos/__FUNCTION/__FUNCTION__/
Dirk-Jan C. Binnema [Mon, 23 Jul 2007 13:09:48 +0000 (13:09 +0000)]
s/__FUNCTION/__FUNCTION__/

pmo-trunk-r2772

13 years agoAdded new fixes to changelog - week 30.
Dirk-Jan C. Binnema [Mon, 23 Jul 2007 12:51:32 +0000 (12:51 +0000)]
Added new fixes to changelog -  week 30.

pmo-trunk-r2771

13 years ago2007-07-23 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 23 Jul 2007 12:07:22 +0000 (12:07 +0000)]
2007-07-23  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account.c:
(modest_tny_account_get_special_folder): Use an if instead of
an assert for when the parent account name is NULL, because this
might be causing a crash in projects.maemo.org bug 63192.
* src/modest-mail-operation.c:
(modest_mail_operation_send_new_mail_cb),
(modest_mail_operation_remove_folder): unref the folder that is
returned from modest_tny_account_get_special_folder().

pmo-trunk-r2770

13 years agoAdded a comment.
Murray Cumming [Mon, 23 Jul 2007 11:43:49 +0000 (11:43 +0000)]
Added a comment.

pmo-trunk-r2769

13 years ago * Reverted some changes from one of the latest armin's commits. We can never call...
Sergio Villar Senin [Mon, 23 Jul 2007 10:18:00 +0000 (10:18 +0000)]
* Reverted some changes from one of the latest armin's commits. We can never call gtk_widget_destroy over a window, we need to do all the window management always through the window manager

pmo-trunk-r2768

13 years ago2007-07-23 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 23 Jul 2007 08:53:45 +0000 (08:53 +0000)]
2007-07-23  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-actions.c:
(modest_ui_actions_on_password_requested):
Show mail_ib_login_cancelled info banner when the user cancels
the protected password dialog, to fix projects.maemo.org
bug NB#63617.

pmo-trunk-r2767

13 years ago2007-07-23 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 23 Jul 2007 08:18:21 +0000 (08:18 +0000)]
2007-07-23  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-settings-dialog.c:
(create_page_outgoing): Put this page in a GtkScrolledWindow,
matching the UI mock-up in the UI spec, and allowing access
to all widgets even when the on-screen keyboard is active.

pmo-trunk-r2766

13 years ago2007-07-16 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 23 Jul 2007 08:04:12 +0000 (08:04 +0000)]
2007-07-16  Murray Cumming  <murrayc@murrayc.com>

Reverted this previous commit from Johannes,
because the scrollbars are always visible and because
I think we only need it on onepage of the account
settings, not the account wizard.
(I wrote the wrong instructions in the bug.)

* src/maemo/easysetup/modest-easysetup-wizard.c:
Added scrollbars to account wizard dialog.
Fixed projects.maemo.org NB #62744

pmo-trunk-r2765

13 years ago2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Sun, 22 Jul 2007 14:48:44 +0000 (14:48 +0000)]
2007-07-22  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_user_details):
Use auto-cap for name (projects.maemo.org NB#63716)
* src/widgets/modest-account-view.c: (on_account_busy_changed):

pmo-trunk-r2764

13 years ago2007-07-22 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Sun, 22 Jul 2007 13:17:17 +0000 (13:17 +0000)]
2007-07-22  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-ui-actions.c: Use current account instead of
default account for creating viewer windows, so that the viewer
window knows to which account the viewed message belongs.

* src/maemo/modest-msg-view-window.c: Destroy the window when the
corresponding account is deleted. This fixes projects.maemo.org bug

pmo-trunk-r2763

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Fri, 20 Jul 2007 16:52:01 +0000 (16:52 +0000)]
* src/modest-ui-actions.c:
* If there's no header view, then proper information banner
  "nothing to sort" is shown.
* src/modest-ui-dimming-rules.c:
* Dim sort action if folder is empty. IN toolbar we show the
  corresponding information banner (fixes NB#60446).

pmo-trunk-r2762

13 years ago* src/maemo/modest-maemo-utils.[ch]:
Jose Dapena Paz [Fri, 20 Jul 2007 09:48:31 +0000 (09:48 +0000)]
* src/maemo/modest-maemo-utils.[ch]:
* New method modest_maemo_gtk_toggle_action_set_active_block_notify
  that disables handlers on changing the current status of a
  toggle action. This was duplicated in msg view and editor, so
  it's been refactored to make them share the implementation.
  Using this in msg edit implementation change is pending on
  other changes in wpeditor.
* src/maemo/modest-msg-view-window.c:
* Now we use the new modest-maemo-utils refactored toggle action
  notify block method.

pmo-trunk-r2761

13 years agoSome improvements on the header view layout. It puts finally the
Jose Dapena Paz [Thu, 19 Jul 2007 21:44:28 +0000 (21:44 +0000)]
Some improvements on the header view layout. It puts finally the
priority icon in its place
* src/maemo/modest-icon-names.h:
        * Added standard high and low priority icons, to be used
          from the custom icon renderers in thumbable headers.
* src/widgets/modest-header-view-render.c:
* Use the proper icons for high and low priority, instead
  of the old composed ones used for the shared priority and
  attachments cell renderer (fixes NB#62262).
* src/widgets/modest-header-view.c:
* Some other layout fixes in compact header view.

pmo-trunk-r2760

13 years ago* src/widgets/modest-recpt-view.c:
Jose Dapena Paz [Thu, 19 Jul 2007 19:47:25 +0000 (19:47 +0000)]
* src/widgets/modest-recpt-view.c:
* Now we accept a small threshold (32 pixels) in press/release
  cycles, to prevent when the click is done with a small
  movement (as it can happen in maemo touchscreen)
  (fixes NB#60728).

pmo-trunk-r2759

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Thu, 19 Jul 2007 17:36:12 +0000 (17:36 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now we show properly the find toolbar, as we attach it
  using hildon_window_add_toolbar API. This partially fixes
  (NB#63201) as this only fixes toolbar in view.

pmo-trunk-r2758

13 years ago* src/widgets/modest-recpt-editor.c:
Jose Dapena Paz [Thu, 19 Jul 2007 17:20:10 +0000 (17:20 +0000)]
* src/widgets/modest-recpt-editor.c:
* Now we discard invalid chars (bullets and images) on pasting
  in recipient editor. This way, if we paste from the editor
  these symbols, they should be removed from text pasted in
  the recipient editor (fixes NB#62575).

pmo-trunk-r2757

13 years ago* src/widgets/modest-msg-view.c:
Jose Dapena Paz [Thu, 19 Jul 2007 16:39:42 +0000 (16:39 +0000)]
* src/widgets/modest-msg-view.c:
* Added implementation of get_message_is_empty method. It uses
  gtk_html_export method to know if the buffer has any text
  representation and this is empty or not.
* src/maemo/modest-msg-view-window.c:
* Removed check for empty buffer to show "nothing to find"
  banner on toggling the toolbar. This should be shown on trying
  to search in the toolbar, not on trying to show the toolbar.
* Added the nothing to find banner on searching empty buffers,
  using the new implementation. This is a partial fix to
  NB#62350.

pmo-trunk-r2756

13 years ago* src/modest-formatter.c:
Jose Dapena Paz [Thu, 19 Jul 2007 15:15:09 +0000 (15:15 +0000)]
* src/modest-formatter.c:
* Add an unref to avoid leaking a reference.

pmo-trunk-r2755

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Thu, 19 Jul 2007 15:13:51 +0000 (15:13 +0000)]
* src/modest-ui-actions.c:
* (folder_refreshed_cb): Now I check if the folder refreshed
  message corresponds to the currently selected folder in
  header view. This should prevent showing the empty folder
  message for a populated folder when other folder request
  finishes later.

pmo-trunk-r2754

13 years ago* src/modest-tny-msg.c:
Jose Dapena Paz [Thu, 19 Jul 2007 15:10:23 +0000 (15:10 +0000)]
* src/modest-tny-msg.c:
* Now we simplify the way we copy mime parts when the mime part
  is an attachment. This, with a pending patch in tinymail,
  should fix NB#61280.

pmo-trunk-r2753

13 years ago2007-07-18 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Wed, 18 Jul 2007 15:52:17 +0000 (15:52 +0000)]
2007-07-18  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
the dialog close after entering an invalid port number and clicking
OK. This fixes projects.maemo.org bug NB#63602.

pmo-trunk-r2752