modest
13 years agoWhen moving messages to a local folder don't try to connect if the
Alberto Garcia [Fri, 7 Sep 2007 10:33:36 +0000 (10:33 +0000)]
When moving messages to a local folder don't try to connect if the
remote folder is POP3 and all messages are already cached. It's not
necessary as in POP3 all messages are removed from the server when
they're opened.

Fixes NB#65235

pmo-trunk-r3238

13 years ago* moved the tny alert dialog stuff to modest-platform
Dirk-Jan C. Binnema [Fri, 7 Sep 2007 10:11:00 +0000 (10:11 +0000)]
* moved the tny alert dialog stuff to modest-platform
* cleaned up the tnyalert handling a bit modest-tny-account-store
* implemented the SSL certificate handling dialogs; not hooked up yet

pmo-trunk-r3237

13 years ago* move the instantiation of modest-tny-account-store to modest runtime;
Dirk-Jan C. Binnema [Fri, 7 Sep 2007 09:50:23 +0000 (09:50 +0000)]
* move the instantiation of modest-tny-account-store to modest runtime;
  (from singletons). before, we were seeing various chicken & egg problems,
  and Glib-Criticals at startup.

pmo-trunk-r3236

13 years agoDon't ask for confirmation on modest_ui_actions_xfer_messages_from_move_to(), it...
Alberto Garcia [Fri, 7 Sep 2007 09:01:53 +0000 (09:01 +0000)]
Don't ask for confirmation on modest_ui_actions_xfer_messages_from_move_to(), it's redundant

pmo-trunk-r3235

13 years ago * Removed a duplicated save_state call
Sergio Villar Senin [Fri, 7 Sep 2007 07:32:10 +0000 (07:32 +0000)]
* Removed a duplicated save_state call

pmo-trunk-r3233

13 years agoUpdated to Tinymail's recent API change
Philip Van Hoof [Thu, 6 Sep 2007 20:05:49 +0000 (20:05 +0000)]
Updated to Tinymail's recent API change

pmo-trunk-r3232

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Thu, 6 Sep 2007 17:35:21 +0000 (17:35 +0000)]
* src/maemo/modest-msg-view-window.c:
* Added a method that catches move-focus signal. In case the
  focus is on attachments view, it stops signal handler,
  preventing this way the focus (fixes NB#66802).

pmo-trunk-r3231

13 years ago* src/maemo/modest-maemo-global-settings-dialog.c:
Jose Dapena Paz [Thu, 6 Sep 2007 17:17:59 +0000 (17:17 +0000)]
* src/maemo/modest-maemo-global-settings-dialog.c:
* Added "notify" signal handler for the size limit
  editor. This way we track the value. If the value is 0
  we dim it (fixes NB#62647).

pmo-trunk-r3230

13 years ago* Select previous row if last rheader is deleted.
Javier Fernandez Garcia-Boente [Thu, 6 Sep 2007 13:58:20 +0000 (13:58 +0000)]
* Select previous row if last rheader is deleted.
* Fixes: NB#65265

pmo-trunk-r3228

13 years agoDon't pass the GtkWindow to header_list_count_uncached_msgs(), it's
Alberto Garcia [Thu, 6 Sep 2007 13:46:31 +0000 (13:46 +0000)]
Don't pass the GtkWindow to header_list_count_uncached_msgs(), it's
not necessary.

pmo-trunk-r3227

13 years ago* fix for NB#63690
Dirk-Jan C. Binnema [Thu, 6 Sep 2007 12:47:48 +0000 (12:47 +0000)]
* fix for NB#63690

pmo-trunk-r3226

13 years ago* src/modest-mail-operation.c:
Jose Dapena Paz [Thu, 6 Sep 2007 11:01:27 +0000 (11:01 +0000)]
* src/modest-mail-operation.c:
* (idle_create_msg_cb): do gdk_threads_leave to protect also
  the unref's, as they can cause locks (fixes NB#65540).

pmo-trunk-r3225

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Wed, 5 Sep 2007 21:25:58 +0000 (21:25 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now set zoom updates the radio menu option properly
  (fixes NB#65274).

pmo-trunk-r3222

13 years ago* src/modest-tny-folder.c:
Jose Dapena Paz [Wed, 5 Sep 2007 19:46:31 +0000 (19:46 +0000)]
* src/modest-tny-folder.c:
* (modest_tny_folder_guess_folder_type_from_name): fixed
  this function. We were downcasing the name, but not the
  strings we were comparing with (fixes NB#65059).

pmo-trunk-r3221

13 years ago* Check for opened edit-windows before close all windows.
Javier Fernandez Garcia-Boente [Wed, 5 Sep 2007 17:55:28 +0000 (17:55 +0000)]
* Check for opened edit-windows before close all windows.
* Fixes: NB#64364

pmo-trunk-r3220

13 years ago* src/maemo/modest-account-settings-dialog.c:
Jose Dapena Paz [Wed, 5 Sep 2007 16:07:39 +0000 (16:07 +0000)]
* src/maemo/modest-account-settings-dialog.c:
* Now the account details tab is also including a scroll to
  prevent some weird problems that hide the buttons sometimes
  (fixes NB#64537).

pmo-trunk-r3219

13 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Wed, 5 Sep 2007 13:49:44 +0000 (13:49 +0000)]
* src/maemo/modest-main-window.c:
* Pending change for disabling toggling cut/copy/paste CSM actions in main menu.

pmo-trunk-r3218

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Wed, 5 Sep 2007 12:50:35 +0000 (12:50 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Rework the cut/copy dimming in editor in order to be accurate
  (fixes NB#63877).

pmo-trunk-r3217

13 years ago* Add information banner (Opening) when user open
Javier Fernandez Garcia-Boente [Wed, 5 Sep 2007 12:01:59 +0000 (12:01 +0000)]
* Add information banner (Opening) when user open
messages from Draft or Outbox folders.
* Fixes: NB#64296

pmo-trunk-r3215

13 years agounified all the bugs into a single entry in the changelog, for week 36 - release...
Vivek Sekar [Wed, 5 Sep 2007 11:36:23 +0000 (11:36 +0000)]
unified all the bugs into a single entry in the changelog, for week 36 - release, 05th sept.

pmo-trunk-r3213

13 years ago* src/modest-mail-operation.c:
Jose Dapena Paz [Wed, 5 Sep 2007 09:35:04 +0000 (09:35 +0000)]
* src/modest-mail-operation.c:
* Now we only show the move folder error as copy is not
  present in translation.

pmo-trunk-r3212

13 years ago2007-09-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 5 Sep 2007 08:35:02 +0000 (08:35 +0000)]
2007-09-05  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-utils.c:
(on_camel_account_get_supported_secure_authentication),
(modest_maemo_utils_get_supported_secure_authentication_methods):
Adapted to the changed tinymail signature of the callback, and
printf a warning when there is an exception, as a clue.

pmo-trunk-r3211

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 4 Sep 2007 16:11:41 +0000 (16:11 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now we use the primary selection clipboard for checking
  cut/copy dimming (fixes NB#62432).

pmo-trunk-r3209

13 years ago* Fixed some strange behaviour on send-queues and
Javier Fernandez Garcia-Boente [Tue, 4 Sep 2007 16:05:40 +0000 (16:05 +0000)]
* Fixed some strange behaviour on send-queues and
sending status management.

pmo-trunk-r3208

13 years ago* src/widgets/modest-msg-view.c:
Jose Dapena Paz [Tue, 4 Sep 2007 15:47:13 +0000 (15:47 +0000)]
* src/widgets/modest-msg-view.c:
* Reenabled message view scroll on find in page (fixes
  NB#62258).

pmo-trunk-r3207

13 years ago* src/maemo/modest-retrieve-combo-box.c:
Jose Dapena Paz [Tue, 4 Sep 2007 15:43:00 +0000 (15:43 +0000)]
* src/maemo/modest-retrieve-combo-box.c:
* Finally disabled "messages" retrieval options. Now we only
  support "headers only" and "messages with attachments"
  options (fixes NB#58475).

pmo-trunk-r3206

13 years ago * Fixes NB#64093 the message count in folders is now recursive
Sergio Villar Senin [Tue, 4 Sep 2007 15:34:24 +0000 (15:34 +0000)]
* Fixes NB#64093 the message count in folders is now recursive

pmo-trunk-r3205

13 years ago* src/widgets/modest-recpt-view.c:
Jose Dapena Paz [Tue, 4 Sep 2007 15:33:54 +0000 (15:33 +0000)]
* src/widgets/modest-recpt-view.c:
* Grab focus on click, so that clipboard operations do what we
  expect them to do (fixes NB#64898).

pmo-trunk-r3204

13 years ago * Fixes NB#64415, now the show_toolbar options are per window type specific
Sergio Villar Senin [Tue, 4 Sep 2007 13:54:21 +0000 (13:54 +0000)]
* Fixes NB#64415, now the show_toolbar options are per window type specific
* Deleted some unused methods

pmo-trunk-r3202

13 years ago * Replaced the casting by a proper variable definition
Sergio Villar Senin [Tue, 4 Sep 2007 13:28:37 +0000 (13:28 +0000)]
* Replaced the casting by a proper variable definition

pmo-trunk-r3201

13 years agoCompilation warning
Philip Van Hoof [Tue, 4 Sep 2007 11:59:22 +0000 (11:59 +0000)]
Compilation warning

pmo-trunk-r3200

13 years ago* src/maemo/modest-main-window-ui-dimming.h:
Jose Dapena Paz [Tue, 4 Sep 2007 09:27:18 +0000 (09:27 +0000)]
* src/maemo/modest-main-window-ui-dimming.h:
* Removed the dimming rules for cut/copy/paste actions in main
  window.

pmo-trunk-r3199

13 years agoAdded fixed bugs. - week 36, 4th sept.
Vivek Sekar [Tue, 4 Sep 2007 09:24:52 +0000 (09:24 +0000)]
Added fixed bugs. -  week 36, 4th sept.

pmo-trunk-r3198

13 years ago* src/maemo/ui/modest-main-window-ui.xml:
Jose Dapena Paz [Tue, 4 Sep 2007 09:04:47 +0000 (09:04 +0000)]
* src/maemo/ui/modest-main-window-ui.xml:
* Removed cut/copy/paste actions from main window menus
  (fixes NB#67792).

pmo-trunk-r3197

13 years ago* src/widgets/modest-recpt-editor.c:
Jose Dapena Paz [Tue, 4 Sep 2007 09:03:02 +0000 (09:03 +0000)]
* src/widgets/modest-recpt-editor.c:
* Limited text insertion to 1024 characters. This should prevent
  getting too big input (fixes NB#64721).

pmo-trunk-r3196

13 years ago2007-09-03 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Mon, 3 Sep 2007 17:32:12 +0000 (17:32 +0000)]
2007-09-03  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-maemo-utils.c: Don't set the temporary account
online that checks for supported authentication methods. This fixes
projects.maemo.org bug NB#61369.

pmo-trunk-r3195

13 years agoChanged an idle to a non-idle because it's not needed anymore
Philip Van Hoof [Mon, 3 Sep 2007 16:58:43 +0000 (16:58 +0000)]
Changed an idle to a non-idle because it's not needed anymore

pmo-trunk-r3194

13 years agoAPI change
Philip Van Hoof [Mon, 3 Sep 2007 15:35:05 +0000 (15:35 +0000)]
API change

pmo-trunk-r3193

13 years ago2007-09-03 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 3 Sep 2007 14:20:07 +0000 (14:20 +0000)]
2007-09-03  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-folder-view.c: (strings_are_equal),
(on_model_foreach_set_name), (on_get_mmc_account_name),
(text_cell_data): Restored this code that was removed in
svn revision 3165 by jfernandez, because this late name-discovery
really is necessary sometimes. This is the correct fix to the endless
calling of this function:
* src/modest-tny-account.c: (on_modest_file_system_info):
Don't call tny_account_set_name() when the name is already correct,
to avoid unnecessary (endless) updates to the tree model.

pmo-trunk-r3192

13 years ago* fix for NB#67837, NB#63633
Dirk-Jan C. Binnema [Mon, 3 Sep 2007 13:33:42 +0000 (13:33 +0000)]
* fix for NB#67837, NB#63633
  - don't try to convert ' --> &apos; [ while technically correct,
    apparently, wpeditor does not like it
  - clean up writing of reply/forward msgs a bit. it could use more cleanup

pmo-trunk-r3191

13 years agoremoved 2 bugs to start integration. - week 36, 3rd sept.
Vivek Sekar [Mon, 3 Sep 2007 13:28:31 +0000 (13:28 +0000)]
removed 2 bugs to start integration. -  week 36, 3rd sept.

pmo-trunk-r3190

13 years agoAdded new fixes to changelog - week 36, 3rd sept.
Vivek Sekar [Mon, 3 Sep 2007 12:34:32 +0000 (12:34 +0000)]
Added new fixes to changelog -  week 36, 3rd sept.

pmo-trunk-r3188

13 years agoshow the correct icons for debian packages
Dirk-Jan C. Binnema [Mon, 3 Sep 2007 11:38:55 +0000 (11:38 +0000)]
show the correct icons for debian packages

pmo-trunk-r3187

13 years ago* Review dimming rules to detect when modest is sedning mails.
Javier Fernandez Garcia-Boente [Mon, 3 Sep 2007 11:30:20 +0000 (11:30 +0000)]
* Review dimming rules to detect when modest is sedning mails.
* Use the new tinymail API function to add mails to send queue
asynchronously.
* Fixes: NB#61607, NB#61952, NB#64146, NB#64924

pmo-trunk-r3186

13 years ago* fix NB#67791
Dirk-Jan C. Binnema [Mon, 3 Sep 2007 10:59:04 +0000 (10:59 +0000)]
* fix NB#67791

pmo-trunk-r3185

13 years ago * Fixed a leak with folders when refreshing
Sergio Villar Senin [Mon, 3 Sep 2007 09:56:30 +0000 (09:56 +0000)]
* Fixed a leak with folders when refreshing

pmo-trunk-r3184

13 years ago* show the correct icon, even for osso-notes attachments.
Dirk-Jan C. Binnema [Mon, 3 Sep 2007 08:14:07 +0000 (08:14 +0000)]
* show the correct icon, even for osso-notes attachments.

pmo-trunk-r3183

13 years ago * Fixes NB#65015 the Outbox folder is no longer missing in the folder view when...
Sergio Villar Senin [Mon, 3 Sep 2007 07:48:30 +0000 (07:48 +0000)]
* Fixes NB#65015 the Outbox folder is no longer missing in the folder view when an account is added. It's also properly removed, when no account is defined

pmo-trunk-r3182

13 years ago* Add Shortcuts to Send, Replay and Forward actions.
Javier Fernandez Garcia-Boente [Sat, 1 Sep 2007 14:58:30 +0000 (14:58 +0000)]
* Add Shortcuts to Send, Replay and Forward actions.
* Fixes: NB#65668

pmo-trunk-r3181

13 years ago* fix the glaring security issue with the previous commit, ie,
Dirk-Jan C. Binnema [Sat, 1 Sep 2007 11:59:03 +0000 (11:59 +0000)]
* fix the glaring security issue with the previous commit, ie,
  when someone would specify a file name
  "../../etc/passwd". fixed now.

pmo-trunk-r3180

13 years ago* fix for NB#63391, where a notes-attachment would be opened in the browser instead
Dirk-Jan C. Binnema [Sat, 1 Sep 2007 11:43:50 +0000 (11:43 +0000)]
* fix for NB#63391, where a notes-attachment would be opened in the browser instead
  - code would make a temp file <random>.ext and ask the mime system to open that,
  however, it only took the *last* extension, so foo.notes.html would become
  <random>.html, and thus opened in browser
  - second, it would open with these funny random chars in the name
  - solution: we now make a temporary-directory (with random name), and save the
  attachment file there with it's real name
  - one issue remaining are attachments without a name.

* make #define hildon_foo --> osso_foo for the functions in modest-platform, so we can
  get rid of the ugly #ifdef blocks.

pmo-trunk-r3179

13 years ago* sort the folder names in the way the spec wants; this work is not complete:
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 16:08:56 +0000 (16:08 +0000)]
* sort the folder names in the way the spec wants; this work is not complete:
  - we're still missing the outbox
  - we need to take care of localization (urgh)
  - what about 'All mail folders'?

pmo-trunk-r3178

13 years ago2007-08-31 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 31 Aug 2007 16:02:51 +0000 (16:02 +0000)]
2007-08-31  Murray Cumming  <murrayc@murrayc.com>

* src/modest-defs.h: Rename MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST to
MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST and make it a global list
for use by all accounts that enable the MODEST_ACCOUNT_USE_CONNECTION_SPECIFIC_SMTP
boolean, because this is the specified behaviour in the UI spec.
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
(modest_account_mgr_set_connection_specific_smtp),
(modest_account_mgr_remove_connection_specific_smtp),
(modest_account_mgr_get_connection_specific_smtp): Remove the account_name
parameter.
* src/maemo/modest-connection-specific-smtp-window.h:
* src/maemo/modest-connection-specific-smtp-window.c:
(modest_connection_specific_smtp_window_finalize),
(modest_connection_specific_smtp_window_fill_with_connections),
(modest_connection_specific_smtp_window_save_server_accounts):
Remove the account_name parameters and member variable.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(on_button_outgoing_smtp_servers), (create_account):
* src/maemo/modest-account-settings-dialog.c:
(on_button_outgoing_smtp_servers), (check_data),
(modest_account_settings_dialog_set_account_name),
(save_configuration):
* src/maemo/modest-maemo-utils.c: (on_account_online),
(modest_maemo_utils_get_supported_secure_authentication_methods):
* src/modest-tny-account-store.c:
(get_smtp_specific_transport_account_for_open_connection),
(insert_account), (add_connection_specific_transport_accounts):
* src/modest-ui-actions.c: (on_smtp_servers_window_hide),
(modest_ui_actions_on_smtp_servers):
 Adapt to the changed API.

pmo-trunk-r3176

13 years ago* tiny optimization for the header view: avoid one needless
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 15:08:56 +0000 (15:08 +0000)]
* tiny optimization for the header view: avoid one needless
  copy of the subject

pmo-trunk-r3174

13 years ago* only use modest_window_set_active_account with real, non-pseudo accounts.
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 14:10:13 +0000 (14:10 +0000)]
* only use modest_window_set_active_account with real, non-pseudo accounts.
  this makes send/receive/open aware of the active account in many cases,
  fixes NB#67071, and maybe some others.

Note: I think the 'active_account' could probable be tracked more easy with
  a function on modest_folder_view.

pmo-trunk-r3173

13 years ago* only allow real, non-pseudo accounts
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 14:06:54 +0000 (14:06 +0000)]
* only allow real, non-pseudo accounts

pmo-trunk-r3172

13 years agoRemoved bugs not accepted by the system.
Vivek Sekar [Fri, 31 Aug 2007 13:00:40 +0000 (13:00 +0000)]
Removed bugs not accepted by the system.

pmo-trunk-r3171

13 years agoRemoved bugs not accepted by the system.
Vivek Sekar [Fri, 31 Aug 2007 12:44:23 +0000 (12:44 +0000)]
Removed bugs not accepted by the system.

pmo-trunk-r3170

13 years agoAdded unreleased bugs from week 35 into the new week 36 pre release.
Vivek Sekar [Fri, 31 Aug 2007 12:21:19 +0000 (12:21 +0000)]
Added unreleased bugs from week 35 into the new week 36 pre release.

pmo-trunk-r3169

13 years ago * Reverts some changes of commit 3159 with is causing some annoying side effects...
Sergio Villar Senin [Fri, 31 Aug 2007 12:19:08 +0000 (12:19 +0000)]
* Reverts some changes of commit 3159 with is causing some annoying side effects, we need to find a better way to place the passive focus. The commit 3159 was placing the active focus by error

pmo-trunk-r3167

13 years ago* Show a "Pasting" banner when moving messages
Alberto Garcia [Fri, 31 Aug 2007 11:54:52 +0000 (11:54 +0000)]
* Show a "Pasting" banner when moving messages
Fixes NB#63479

pmo-trunk-r3166

13 years ago* Avoid to get MMC root folder name in text_cell_data.
Javier Fernandez Garcia-Boente [Fri, 31 Aug 2007 10:30:52 +0000 (10:30 +0000)]
* Avoid to get MMC root folder name in text_cell_data.
* Fixes: NB#65331

pmo-trunk-r3165

13 years ago* remove some annoying debug warnings
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 06:35:21 +0000 (06:35 +0000)]
* remove some annoying debug warnings
* remember the parent-uid for messages (needed to check if a reply to a message
  is already ongoing)

pmo-trunk-r3163

13 years ago* remove some needless warnings (ie. edit windows don't have to
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 06:29:55 +0000 (06:29 +0000)]
* remove some needless warnings (ie. edit windows don't have to
  warn about not having a UID)

pmo-trunk-r3162

13 years ago* New Message toolbar button and menu item will be dimmed
Javier Fernandez Garcia-Boente [Thu, 30 Aug 2007 19:18:15 +0000 (19:18 +0000)]
* New Message toolbar button and menu item will be dimmed
when no accounts have been defined.
* Fixes: NB#64278

pmo-trunk-r3161

13 years ago * Fixes NB#64311 show the proper help depending on the folder that is selected in...
Sergio Villar Senin [Thu, 30 Aug 2007 18:11:56 +0000 (18:11 +0000)]
* Fixes NB#64311 show the proper help depending on the folder that is selected in the folder view

pmo-trunk-r3160

13 years agofixes NB#58917
Peter Csaszar [Thu, 30 Aug 2007 16:21:37 +0000 (16:21 +0000)]
fixes NB#58917

pmo-trunk-r3159

13 years ago* Fixed crash on dimmin rules when M;MC root account is selected.
Javier Fernandez Garcia-Boente [Thu, 30 Aug 2007 13:57:12 +0000 (13:57 +0000)]
* Fixed crash on dimmin rules when M;MC root account is selected.

pmo-trunk-r3156

13 years ago* Commented out modest_folder_view_set_folder_selected because
Javier Fernandez Garcia-Boente [Thu, 30 Aug 2007 12:23:06 +0000 (12:23 +0000)]
* Commented out modest_folder_view_set_folder_selected because
it caused some hangs after folder transfer was completed.

pmo-trunk-r3154

13 years ago * Moving back to the old version of has_subfolder_with_name because the new version...
Sergio Villar Senin [Thu, 30 Aug 2007 11:17:47 +0000 (11:17 +0000)]
* Moving back to the old version of has_subfolder_with_name because the new version needs some tinymail changes
* Fixed a problem when creating folders related to folder names, now it uses the has_subfolder_with_name function
* Fixes NB#62026, folder moves is fixed right now

pmo-trunk-r3153

13 years ago * Select the folder that has been moved
Sergio Villar Senin [Thu, 30 Aug 2007 10:03:21 +0000 (10:03 +0000)]
* Select the folder that has been moved

pmo-trunk-r3152

13 years ago* fix some mem leaks (50Kb after clicking around a bit, according to valgrind)
Dirk-Jan C. Binnema [Thu, 30 Aug 2007 09:57:48 +0000 (09:57 +0000)]
* fix some mem leaks (50Kb after clicking around a bit, according to valgrind)

pmo-trunk-r3151

13 years ago * added led-pattern hint to notification based on the code of the old client
Sergio Villar Senin [Thu, 30 Aug 2007 09:31:20 +0000 (09:31 +0000)]
* added led-pattern hint to notification based on the code of the old client

pmo-trunk-r3150

13 years agoModified changelog to reflect week 35, as queue is still not frozen.
Vivek Sekar [Thu, 30 Aug 2007 08:21:32 +0000 (08:21 +0000)]
Modified changelog to reflect week 35, as queue is still not frozen.

pmo-trunk-r3148

13 years agoAdded new fixes and moved the week 35-2 fixes to week 36-1 build on 30th aug.
Vivek Sekar [Thu, 30 Aug 2007 08:00:06 +0000 (08:00 +0000)]
Added new fixes and moved the week 35-2 fixes to week 36-1 build on 30th aug.

pmo-trunk-r3146

13 years ago* activate the maemo-launcher once more
Dirk-Jan C. Binnema [Thu, 30 Aug 2007 06:14:27 +0000 (06:14 +0000)]
* activate the maemo-launcher once more

pmo-trunk-r3145

13 years ago2007-08-29 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Wed, 29 Aug 2007 21:35:54 +0000 (21:35 +0000)]
2007-08-29  Armin Burgmeier  <armin@openismus.com>

* src/modest-protocol-info.h:
* src/modest-protocol-info.c: Added
modest_protocol_info_get_auth_protocol() to translate an
authentication protocol name to the corresponding enum value.

* src/maemo/modest-maemo-utils.c: Fixed supported auth protocol list
generation using the newly added function.

* src/maemo/modest-account-settings-dialog.c: Use the current element
when traversing through the list of supported authentication methods,
not always the first.

pmo-trunk-r3144

13 years ago * Improved my last commit, only invalidate cur_folder_store and folder_to_select...
Sergio Villar Senin [Wed, 29 Aug 2007 17:39:18 +0000 (17:39 +0000)]
* Improved my last commit, only invalidate cur_folder_store and folder_to_select when the account that it's being removed is the same account than the accounts of any of these folders

pmo-trunk-r3143

13 years ago * Fixed a SIGSEV when renaming folders caused by the delayed selection
Sergio Villar Senin [Wed, 29 Aug 2007 17:24:04 +0000 (17:24 +0000)]
* Fixed a SIGSEV when renaming folders caused by the delayed selection
* Implemented a TODO related to the delayed selection
* Fixed the delayed selection when renaming folders

pmo-trunk-r3142

13 years ago2007-08-29 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 29 Aug 2007 17:02:14 +0000 (17:02 +0000)]
2007-08-29   Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
(check_first_supported_auth_method), (on_before_next),
(create_account):
* src/maemo/modest-account-settings-dialog.c: (check_data):
Some cleanup, to make the code clearer.

pmo-trunk-r3141

13 years ago2007-08-29 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 29 Aug 2007 17:01:45 +0000 (17:01 +0000)]
2007-08-29   Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
(check_first_supported_auth_method), (on_before_next),
(create_account):
* src/maemo/modest-account-settings-dialog.c: (check_data):
Some cleanup, to make the code clearer.

pmo-trunk-r3140

13 years ago * Fixes NB#66485, the "rename" option is now available also from the Main menu
Sergio Villar Senin [Wed, 29 Aug 2007 16:23:57 +0000 (16:23 +0000)]
* Fixes NB#66485, the "rename" option is now available also from the Main menu

pmo-trunk-r3139

13 years ago * Fixes NB#66280, does not allow to move a folder to a POP inbox in the "move to...
Sergio Villar Senin [Wed, 29 Aug 2007 15:52:14 +0000 (15:52 +0000)]
* Fixes NB#66280, does not allow to move a folder to a POP inbox in the "move to" dialog

pmo-trunk-r3138

13 years ago* Review dimming rules to add not_deletable, not_moveable and
Javier Fernandez Garcia-Boente [Wed, 29 Aug 2007 15:44:21 +0000 (15:44 +0000)]
* Review dimming rules to add not_deletable, not_moveable and
not_renameable utility functions.
* fixes: NB#67113

pmo-trunk-r3137

13 years ago * src/modest-ui-actions.c
Alberto Garcia [Wed, 29 Aug 2007 15:33:16 +0000 (15:33 +0000)]
   * src/modest-ui-actions.c
   (delete_folder):
   Ask for confirmation before trying to connect to the network
   Fixes NB#66762

pmo-trunk-r3136

13 years agofixes NB#66803
Peter Csaszar [Wed, 29 Aug 2007 15:25:17 +0000 (15:25 +0000)]
fixes NB#66803

pmo-trunk-r3135

13 years ago2007-08-29 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 29 Aug 2007 15:21:10 +0000 (15:21 +0000)]
2007-08-29  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Use the mail_ni_ssl_certificate_error (Secure connection failed)
logical ID when the secure authentication method is not supported by
the server, as requested by Mox on the wiki, though I hate not
giving the user the clue.

pmo-trunk-r3134

13 years agofixes NB#66495
Peter Csaszar [Wed, 29 Aug 2007 15:09:11 +0000 (15:09 +0000)]
fixes NB#66495

pmo-trunk-r3133

13 years ago * src/modest-ui-actions.c
Alberto Garcia [Wed, 29 Aug 2007 15:05:05 +0000 (15:05 +0000)]
   * src/modest-ui-actions.c
   (modest_ui_actions_on_rename_folder):
   Don't try to connect before showing the rename dialog

pmo-trunk-r3132

13 years ago * Renamed on_paste_msg by on_paste
Sergio Villar Senin [Wed, 29 Aug 2007 14:27:32 +0000 (14:27 +0000)]
* Renamed on_paste_msg by on_paste

pmo-trunk-r3131

13 years ago * src/modest-platform.h
Alberto Garcia [Wed, 29 Aug 2007 14:12:33 +0000 (14:12 +0000)]
   * src/modest-platform.h
   * src/modest-platform.c
   (modest_platform_is_network_folderstore):
   Checks whether a folder store is remote
   * src/modest-ui-actions.c
   (modest_ui_actions_on_move_to):
   Don't try to connect to the internet, leave that for the following
   functions.
   (modest_ui_actions_on_main_window_move_to):
   (modest_ui_actions_on_msg_view_window_move_to):
   Ask for confirmation if the device is offline and the source folder
   is remote

pmo-trunk-r3130

13 years agotries to solve NB#66463, I am not sure if this is enough
Peter Csaszar [Wed, 29 Aug 2007 14:12:01 +0000 (14:12 +0000)]
tries to solve NB#66463, I am not sure if this is enough

pmo-trunk-r3129

13 years ago* fix a mem leak
Dirk-Jan C. Binnema [Wed, 29 Aug 2007 13:49:27 +0000 (13:49 +0000)]
* fix a mem leak

pmo-trunk-r3128

13 years ago* remove annoying g_debug
Dirk-Jan C. Binnema [Wed, 29 Aug 2007 13:34:01 +0000 (13:34 +0000)]
* remove annoying g_debug

pmo-trunk-r3127

13 years agofixes NB#66461
Peter Csaszar [Wed, 29 Aug 2007 11:08:14 +0000 (11:08 +0000)]
fixes NB#66461

pmo-trunk-r3124

13 years ago * Fixes NB#66968, there is no limit on the number of sub-folders that the user...
Sergio Villar Senin [Wed, 29 Aug 2007 10:24:18 +0000 (10:24 +0000)]
 * Fixes NB#66968, there is no limit on the number of sub-folders that the user can have

pmo-trunk-r3123

13 years ago2007-08-29 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 29 Aug 2007 10:08:04 +0000 (10:08 +0000)]
2007-08-29  Murray Cumming  <murrayc@murrayc.com>

* src/modest-search.c: (modest_search_all_accounts):
* src/modest-platform.h:
* src/maemo/modest-platform.c: Moved and renamed
check_and_wait_for_account_is_online() to
modest_platform_check_and_wait_for_account_is_online() so it
can be used in more places.

pmo-trunk-r3122

13 years ago * Fixes NB#67061, do not ask the user to download the msg if we're online
Sergio Villar Senin [Wed, 29 Aug 2007 09:59:55 +0000 (09:59 +0000)]
* Fixes NB#67061, do not ask the user to download the msg if we're online

pmo-trunk-r3121

13 years ago * Partially fixes NB#67060, now this bug is reassigned to the language component
Sergio Villar Senin [Wed, 29 Aug 2007 09:35:15 +0000 (09:35 +0000)]
* Partially fixes NB#67060, now this bug is reassigned to the language component

pmo-trunk-r3120

13 years ago2007-08-29 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 29 Aug 2007 09:29:49 +0000 (09:29 +0000)]
2007-08-29  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
Removed the sleep(1) experiment because it does not seem to help,
and I should not have checked the experiment in anyway.
The problem is maybe in the TnyAccount connected state - I will
investigate that instead.

pmo-trunk-r3119