modest
13 years ago* fix a memleak in the msg edit window
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 17:05:42 +0000 (17:05 +0000)]
* fix a memleak in the msg edit window
* fix a memleak when registering the update_interval for the alarm daemon

pmo-trunk-r2503

13 years ago* src/widgets/modest-header-view-render.c:
Jose Dapena Paz [Fri, 29 Jun 2007 16:58:46 +0000 (16:58 +0000)]
* src/widgets/modest-header-view-render.c:
        * Added some implementation work to retrieve the send status of
          mails in outbox. get_status_string() obtains the proper string
          for a status, get_status_of_uid() should retrieve the current
          status trying in all send queues, the cell renderer has a
          specific path for the case of outbox.
        * As currently it does not get the proper status from the
          send queue, we set always "waiting".
* src/widgets/modest-header-view-priv.h:
        * Added an enum of the types of compact cell renderer.
* src/widgets/modest-header-view.c:
        * Pass the proper mode to the compact cell renderer (incoming,
          outgoing, outbox).

pmo-trunk-r2502

13 years ago* Use an user handler for 'key-press-event' signal on
Javier Fernandez Garcia-Boente [Fri, 29 Jun 2007 15:36:37 +0000 (15:36 +0000)]
* Use an user handler for 'key-press-event' signal on
ModestWindow class.
* Fixes: NB#61828, NB#61825

pmo-trunk-r2501

13 years agoUpdated the changelog with the fixes made on week26 29th june.
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 15:03:56 +0000 (15:03 +0000)]
Updated the changelog with the fixes made on week26 29th june.

pmo-trunk-r2500

13 years agoFixed the bug 61219, changed from showing dialog to showing banner if the account...
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 14:52:09 +0000 (14:52 +0000)]
Fixed the bug 61219, changed from showing dialog to showing banner if the account already exists.

pmo-trunk-r2499

13 years ago* Fixed bug in select_next function.
Javier Fernandez Garcia-Boente [Fri, 29 Jun 2007 14:29:04 +0000 (14:29 +0000)]
* Fixed bug in select_next function.

pmo-trunk-r2498

13 years ago* fix logical error, don't call
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 12:55:47 +0000 (12:55 +0000)]
* fix logical error, don't call
  search_mime_part_and_child_parts
   if msg == NULL. This fixes a crash if msg happens to be NULL

pmo-trunk-r2497

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Fri, 29 Jun 2007 12:46:44 +0000 (12:46 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now the font size toolbutton always get the default font face
          (it was getting the default font, but then it was replaced
          with Serif on first font size change).

pmo-trunk-r2496

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Fri, 29 Jun 2007 12:37:57 +0000 (12:37 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Fixed some typo errors in set_format_state function.
        * Use set_attribute instead of set_format in font size change
          handler.

pmo-trunk-r2495

13 years ago2007-06-29 Murray Cumming <murrayc@murrayc-desktop>
Murray Cumming [Fri, 29 Jun 2007 11:58:12 +0000 (11:58 +0000)]
2007-06-29  Murray Cumming  <murrayc@murrayc-desktop>

* src/maemo/modest-main-window.c: (connect_signals):
Don't connect to delete_event twice. Maybe this was harmless.

pmo-trunk-r2494

13 years ago2007-06-29 Murray Cumming <murrayc@murrayc.com
Murray Cumming [Fri, 29 Jun 2007 11:52:15 +0000 (11:52 +0000)]
2007-06-29  Murray Cumming  <murrayc@murrayc.com

* libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
* src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
Debug output to give some more clue when a folder move is not allowed.

pmo-trunk-r2493

13 years ago* update the various places where the modest-window-mgr was used to register
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 11:31:07 +0000 (11:31 +0000)]
* update the various places where the modest-window-mgr was used to register
  the header *before* the message is opened (see previous patch).
* also update the dimming rules, so opened messages will  have the delete
  button in the main window dimmed, as well, as when selecting multiple of
  which one or more are opened already.

pmo-trunk-r2492

13 years ago* update the modest-window-manager; together with the next patch, this
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 11:28:00 +0000 (11:28 +0000)]
* update the modest-window-manager; together with the next patch, this
  fixes NB#57297
- we do this by adding modest_window_mgr_register_header,
modest_window_mgr_find_registered_header. in the next patch, these will
be called *before* actually opening the message, so it will be impossible
to open the same message several times. the problem used to be that
the windows were only registered after the message was retrieved, so
plenty time to have doubles, esp. on a slow connection
- also fix a bug where really the registered *window* is returned,
instead of the GList* (casting hid this bug), this enables us to popup
a msg-view-window if it was already opened for the activated message

pmo-trunk-r2491

13 years ago * Reverted a do not wanted change
Sergio Villar Senin [Fri, 29 Jun 2007 10:55:30 +0000 (10:55 +0000)]
* Reverted a do not wanted change

pmo-trunk-r2490

13 years ago * Do "pulse" when done=0 and total=0
Sergio Villar Senin [Fri, 29 Jun 2007 10:51:30 +0000 (10:51 +0000)]
* Do "pulse" when done=0 and total=0

pmo-trunk-r2489

13 years ago * Do not block signal emissions into idles callbacks, because signal handlers are...
Sergio Villar Senin [Fri, 29 Jun 2007 10:27:11 +0000 (10:27 +0000)]
* Do not block signal emissions into idles callbacks, because signal handlers are already executed into the main lock

pmo-trunk-r2488

13 years ago* Fixes some warning about uninitialized valrables.
Javier Fernandez Garcia-Boente [Fri, 29 Jun 2007 08:27:34 +0000 (08:27 +0000)]
* Fixes some warning about uninitialized valrables.

pmo-trunk-r2487

13 years agosmall change for Fixed bug 58983, changed the labels from the previous commit.
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 08:23:07 +0000 (08:23 +0000)]
small change for Fixed bug 58983, changed the labels from the previous commit.

pmo-trunk-r2486

13 years agoFixed bug 58983, changed the order and labels for delete account.
Dirk-Jan C. Binnema [Fri, 29 Jun 2007 08:20:39 +0000 (08:20 +0000)]
Fixed bug 58983, changed the order and labels for delete account.

pmo-trunk-r2485

13 years ago* Review 'move to' callback from viewer window with pop
Javier Fernandez Garcia-Boente [Thu, 28 Jun 2007 23:06:52 +0000 (23:06 +0000)]
* Review 'move to' callback from viewer window with pop
accounts.
* Fixes: NB#61929

pmo-trunk-r2484

13 years ago* Fixes: NB#61955
Javier Fernandez Garcia-Boente [Thu, 28 Jun 2007 20:03:08 +0000 (20:03 +0000)]
* Fixes: NB#61955

pmo-trunk-r2483

13 years ago * Fixes NB#62026, folders can now be moved to the root local account
Sergio Villar Senin [Thu, 28 Jun 2007 18:34:06 +0000 (18:34 +0000)]
* Fixes NB#62026, folders can now be moved to the root local account
* Added some checking to cmp_rows of the folders view
* Removed some code of the mail operations that didn't allow a folder to be moved to an account
* The UI actions allows now a move to to an account, if it's the local account

pmo-trunk-r2482

13 years ago * Fixes NB#61826, the outbox folder is shown as Outbox in the folder details dialog
Sergio Villar Senin [Thu, 28 Jun 2007 17:59:12 +0000 (17:59 +0000)]
* Fixes NB#61826, the outbox folder is shown as Outbox in the folder details dialog
* Fixed some warnings

pmo-trunk-r2481

13 years ago * Fixes NB#61948, the accounts could not be cut nor copied
Sergio Villar Senin [Thu, 28 Jun 2007 17:45:45 +0000 (17:45 +0000)]
* Fixes NB#61948, the accounts could not be cut nor copied

pmo-trunk-r2480

13 years ago * Fixes NB#58923, do not allow '/' in folder names
Sergio Villar Senin [Thu, 28 Jun 2007 17:09:48 +0000 (17:09 +0000)]
* Fixes NB#58923, do not allow '/' in folder names

pmo-trunk-r2479

13 years agoWork to complete implementation of purge attachments operation
Jose Dapena Paz [Thu, 28 Jun 2007 17:06:34 +0000 (17:06 +0000)]
Work to complete implementation of purge attachments operation
(fixes NB#61240).
* src/widget/modest-msg-view.[ch]:
        * Added API function to get all the attachments in
          the view, and not only the selected ones.
* src/widgets/modest-attachment-view.c:
        * Support for showing purged files improved (still pending
          a proper logical id).
* src/widgets/modest-msg-view-window.[ch]:
* src/modest-ui-actions.[ch]:
        * Added support for purging attachments of a message from the
          main window, with lots of exception conditions (trying to
          remove messages with all attachments already purged, etc).
        * Added confirmation dialog for removing attachments from
          main window.
* src/maemo/modest-main-window-ui.h:
        * Attach remove attachments action in main window.
* src/widgets/modest-msg-view-window.[ch]:
        * Now you cannot save or view a purged attachment.
        * Now you can choose in ..._remove_attachments to remove
          only selected attachments or all the available attachments.
        * Skip already removed attachments
        * More informationbanners for purge operation.
        * Now the message is correctly reloaded after being purged.
* src/widgets/modest-ui-dimming-rules.[ch]:
        * Added a lot of dimming rules for removing attachments both
          from main window and msg view window.

pmo-trunk-r2478

13 years agoupdated the changelog with fixes.
Dirk-Jan C. Binnema [Thu, 28 Jun 2007 15:50:00 +0000 (15:50 +0000)]
updated the changelog with fixes.

pmo-trunk-r2477

13 years agoFix for the bug 59012, changed appedn to prepend.
Dirk-Jan C. Binnema [Thu, 28 Jun 2007 15:38:58 +0000 (15:38 +0000)]
Fix for the bug 59012, changed appedn to prepend.

pmo-trunk-r2476

13 years ago* Fixed some diomming rules.
Javier Fernandez Garcia-Boente [Thu, 28 Jun 2007 15:17:25 +0000 (15:17 +0000)]
* Fixed some diomming rules.
* Set flags DELETED just after tny_folder_remove_msg
* Add a filter in heder view to hide deleted rows

pmo-trunk-r2475

13 years ago2007-06-28 Murray Cumming <murrayc@murrayc.com
Murray Cumming [Thu, 28 Jun 2007 12:57:41 +0000 (12:57 +0000)]
2007-06-28  Murray Cumming  <murrayc@murrayc.com

pmo-trunk-r2474

13 years agoSome debug output to help me with testing.
Murray Cumming [Thu, 28 Jun 2007 10:31:04 +0000 (10:31 +0000)]
Some debug output to help me with testing.

pmo-trunk-r2473

13 years ago * Commented some code that causes a hang. It reopens a bug, but it's a normal one...
Sergio Villar Senin [Thu, 28 Jun 2007 09:25:19 +0000 (09:25 +0000)]
* Commented some code that causes a hang. It reopens a bug, but it's a normal one and Modest won't hang

pmo-trunk-r2472

13 years ago* set all accounts offline when finalizing the modest-tny-account-store;
Dirk-Jan C. Binnema [Thu, 28 Jun 2007 09:18:00 +0000 (09:18 +0000)]
* set all accounts offline when finalizing the modest-tny-account-store;
  this should help with the problem where the modest window is closed,
  but it's still running, which make restarting modest impossible.

pmo-trunk-r2471

13 years ago * Wrap the gtk_main between gdk_threads_enter/leave code as documentation says
Sergio Villar Senin [Thu, 28 Jun 2007 08:30:19 +0000 (08:30 +0000)]
* Wrap the gtk_main between gdk_threads_enter/leave code as documentation says

pmo-trunk-r2470

13 years ago * Fixed an issue whith signal handlers when unregistering windows
Sergio Villar Senin [Thu, 28 Jun 2007 07:21:17 +0000 (07:21 +0000)]
* Fixed an issue whith signal handlers when unregistering windows
* Make a more fine-grained gdk threads locking
* Added msg view window registration in the dbus callbacks
* Removed an uneeded gdk_threads_enter/leave

pmo-trunk-r2469

13 years ago * Signal handlers are executed in the main lock, so no need to lock it again
Sergio Villar Senin [Thu, 28 Jun 2007 06:41:06 +0000 (06:41 +0000)]
* Signal handlers are executed in the main lock, so no need to lock it again

pmo-trunk-r2468

13 years ago2007-06-27 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Wed, 27 Jun 2007 18:25:44 +0000 (18:25 +0000)]
2007-06-27  Armin Burgmeier  <armin@openismus.com>

* src/modest-mail-operation.c: Fixed a crash when canceling a mail
receive operation.

pmo-trunk-r2467

13 years ago* fixed some bugs on dimming rules.
Javier Fernandez Garcia-Boente [Wed, 27 Jun 2007 17:10:36 +0000 (17:10 +0000)]
* fixed some bugs on dimming rules.

pmo-trunk-r2466

13 years ago* Review dimming rules of paste operation.
Javier Fernandez Garcia-Boente [Wed, 27 Jun 2007 16:45:25 +0000 (16:45 +0000)]
* Review dimming rules of paste operation.
* Review dimming rules of viewer window toolbar.
* Fixes: NB#60441, NB#61044

pmo-trunk-r2465

13 years ago2007-06-27 Murray Cumming <murrayc@murrayc.com
Murray Cumming [Wed, 27 Jun 2007 15:28:30 +0000 (15:28 +0000)]
2007-06-27  Murray Cumming  <murrayc@murrayc.com

* src/modest-tny-account.h:
* src/modest-tny-account.c:
Added modest_tny_account_get_mmc_account_name(), to set the memory
card name asynchronously for the given account and then notify.
(modest_tny_account_new_for_local_folders): Use this new function instead
of using hildon_file_system_info_async_new() directly.

* src/widgets/modest-folder-view.c: (text_cell_data):
Use modest_tny_account_get_mmc_account_name() to get the real name, calling
gtk_tree_model_row_changed() when it is available.

This should fix projects.maemo.org bug NB#59301.

pmo-trunk-r2464

13 years ago* Connect an insensitive-press signal handler to
Javier Fernandez Garcia-Boente [Wed, 27 Jun 2007 14:49:37 +0000 (14:49 +0000)]
* Connect an insensitive-press signal handler to
OK button of new folder dialog.
* Add a new dimming rules to check folder depth, only
for Context Sensitive Menu of folder view.
* Fixes NB#60458, NB#61835

pmo-trunk-r2463

13 years agoCommented out bugfix for setting new accounts online - regression problem
Philip Van Hoof [Wed, 27 Jun 2007 14:29:52 +0000 (14:29 +0000)]
Commented out bugfix for setting new accounts online - regression problem

pmo-trunk-r2462

13 years agoupdated the changelog with the fixes on 27.june
Dirk-Jan C. Binnema [Wed, 27 Jun 2007 14:14:49 +0000 (14:14 +0000)]
updated the changelog with the fixes on 27.june

pmo-trunk-r2461

13 years agoReverted again the gdk_threads_enter/leave sentences:
Jose Dapena Paz [Wed, 27 Jun 2007 14:13:18 +0000 (14:13 +0000)]
Reverted again the gdk_threads_enter/leave sentences:
* src/widgets/modest-attachment-view.c
* src/widgets/modest-header-view.c
* src/maemo/modest-maemo-global-settings-dialog.c
* src/modest-mail-operation.c

Misc changes (mainly work to implement attachment purging):
* src/widgets/modest-msg-view.c:
        * Added find toolbar scroll fix, disabled as we're waiting
          for the new gtkhtml gtk_html_get_selection_area API.
        * Now we don't remove the attached part on removing attachments
          from view.
* src/widgets/modest-attachment-view.c:
        * Added support for showing purged files as purged. The icon is
          the default document one, and the text is a currently non
          translated string.
        * Now size is only shown for file attachments (if they're not
          purged).
* src/maemo/modest-msg-view-window.c:
        * Use the new Tinymail mime part purge API. It purges really the
          attachments. The UI is a work in progress still, but the
          cache seems to get updated as expected. This implementation
          replaces the old delete_attachments tinymail API based
          implementation.
* src/ui/modest-ui-dimming-rules.c:
        * Added some dimming rules for remove attachments in message view.
          It's not complete yet.
        * Now "move to" operation does not check if the source folder is
          writeable (fixes NB#61860).

pmo-trunk-r2460

13 years agoFixes: NB#61843
Javier Fernandez Garcia-Boente [Wed, 27 Jun 2007 13:08:11 +0000 (13:08 +0000)]
Fixes: NB#61843

pmo-trunk-r2458

13 years ago2007-06-27 Murray Cumming <murrayc@murrayc.com
Murray Cumming [Wed, 27 Jun 2007 12:26:50 +0000 (12:26 +0000)]
2007-06-27  Murray Cumming  <murrayc@murrayc.com

* src/modest-mail-operation.c: (update_account_thread),
(get_msgs_full_thread): Fix typo failures in the revert
to fix the build.

pmo-trunk-r2457

13 years ago2007-06-27 Murray Cumming <murrayc@murrayc.com
Murray Cumming [Wed, 27 Jun 2007 12:16:09 +0000 (12:16 +0000)]
2007-06-27  Murray Cumming  <murrayc@murrayc.com

* src/maemo/modest-maemo-global-settings-dialog.c:
(idle_select_default_focus):
* src/modest-mail-operation.c: (idle_notify_progress),
(idle_notify_progress_once), (set_last_updated_idle),
(update_account_thread), (get_msgs_full_thread):
* src/widgets/modest-attachment-view.c: (get_size_idle_func):
* src/widgets/modest-header-view.c:
(idle_notify_headers_count_changed_destroy),
(idle_notify_headers_count_changed):
Reverted the additions of gdk_threads_enter/leave(), in case this
helps with a startup hang on the device.

pmo-trunk-r2456

13 years ago* Check main window toolbar dimming rules after
Javier Fernandez Garcia-Boente [Wed, 27 Jun 2007 10:34:33 +0000 (10:34 +0000)]
* Check main window toolbar dimming rules after
open some message (delete toolbar must dimmed).

pmo-trunk-r2455

13 years ago* Fixes: NB#61846
Javier Fernandez Garcia-Boente [Wed, 27 Jun 2007 10:18:23 +0000 (10:18 +0000)]
* Fixes: NB#61846

pmo-trunk-r2454

13 years ago * Deleted some invalid unreferences, tinymail does take care about the objects passe...
Sergio Villar Senin [Wed, 27 Jun 2007 10:11:08 +0000 (10:11 +0000)]
* Deleted some invalid unreferences, tinymail does take care about the objects passed to callbacks

pmo-trunk-r2453

13 years ago * Fixes NB#61225 the application no longer hangs due to threading locks
Sergio Villar Senin [Wed, 27 Jun 2007 08:58:07 +0000 (08:58 +0000)]
* Fixes NB#61225 the application no longer hangs due to threading locks
* Modified modest_mail_operation_notify_end, now it receives a second argument that specifies if the signal emission should be blocked or NOT, we need to do this if we're calling it from a different thread
* Removed an invalid double-lock in the mail operations
* Added an empty error handler for the rename operation, no specs for the error message?

pmo-trunk-r2452

13 years ago* leak fix
Dirk-Jan C. Binnema [Wed, 27 Jun 2007 07:54:28 +0000 (07:54 +0000)]
* leak fix

pmo-trunk-r2451

13 years ago * Fixed a memory leak in modest folder view
Sergio Villar Senin [Wed, 27 Jun 2007 07:42:11 +0000 (07:42 +0000)]
* Fixed a memory leak in modest folder view
* Fixes NB#61607, the renaming was not working because we're getting the wrong response from the dialog

pmo-trunk-r2450

13 years ago* leak fix
Dirk-Jan C. Binnema [Wed, 27 Jun 2007 07:15:01 +0000 (07:15 +0000)]
* leak fix

pmo-trunk-r2449

13 years ago2007-06-26 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Tue, 26 Jun 2007 19:49:24 +0000 (19:49 +0000)]
2007-06-26  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
for supported secure authentication methods from server by
gtk_dialog_run(), saving CPU time and a potential race condition.

pmo-trunk-r2448

13 years ago2007-06-26 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Tue, 26 Jun 2007 19:11:48 +0000 (19:11 +0000)]
2007-06-26  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-maemo-utils.h:
* src/maemo/modest-maemo-utils.c: Added a
ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
only error code to tell the calling code when the user canceled the
operation.

* src/maemo/modest-account-settings-dialog.h:
* src/maemo/modest-account-settings-dialog.c:
* src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
message if the retrieval of secure authentication methods was canceled
by the user. Perform the check before saving anything to configuration
to not end up with half-committed configuration changes, do not show
a "Saving to configuration failed" note when authentication methods
could not be retrieved.

* src/maemo/modest-main-window.c: Fixed a crash on startup when built
with old hildon.

pmo-trunk-r2447

13 years ago* Add some notifications on dimming rules.
Javier Fernandez Garcia-Boente [Tue, 26 Jun 2007 18:54:57 +0000 (18:54 +0000)]
* Add some notifications on dimming rules.

pmo-trunk-r2446

13 years ago* libmodest-dbus-client depends on modest
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 18:28:30 +0000 (18:28 +0000)]
* libmodest-dbus-client depends on modest

pmo-trunk-r2445

13 years ago* fix leak (gtk_tree_row_reference_get_path needs a free)
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 18:27:42 +0000 (18:27 +0000)]
* fix leak (gtk_tree_row_reference_get_path needs a free)

pmo-trunk-r2444

13 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 18:20:26 +0000 (18:20 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
Only return the first level of folders under accounts, because the
osso-global-search UI spec doesn't want the rest.
This fixed projects.maemo.org bug NB#61811.

pmo-trunk-r2443

13 years ago* Add new dimming rules for copy,cut and paste operations.
Javier Fernandez Garcia-Boente [Tue, 26 Jun 2007 18:17:25 +0000 (18:17 +0000)]
* Add new dimming rules for copy,cut and paste operations.
* Add dimming rules for undo operations.
* Implement undo operation for copy and cut operations.
* Fixes: NB#59325

pmo-trunk-r2442

13 years ago* some other apps (sketch) send attachment list that start with ','.
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 18:06:07 +0000 (18:06 +0000)]
* some other apps (sketch) send attachment list that start with ','.
  strip that one, to prevent a warnings later.

pmo-trunk-r2441

13 years ago* leak fix (modest-init)
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 18:03:58 +0000 (18:03 +0000)]
* leak fix (modest-init)
* modest-main: sometimes, 'ui' was a not a valid gobject, which caused glib warnings

pmo-trunk-r2440

13 years agoBugfix when creating an account
Philip Van Hoof [Tue, 26 Jun 2007 16:41:14 +0000 (16:41 +0000)]
Bugfix when creating an account

pmo-trunk-r2438

13 years ago* replace the unnecessary fill_server_account_cache_if_need with
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 16:26:39 +0000 (16:26 +0000)]
* replace the unnecessary fill_server_account_cache_if_need with
  direct calls to modest_tny_account_store_get_accounts. No need
  to make modest-tny-account-store even uglier.

(as always, murray is right)

pmo-trunk-r2437

13 years ago* Added a new reference to priv->draft_msg of edit window
Javier Fernandez Garcia-Boente [Tue, 26 Jun 2007 16:25:38 +0000 (16:25 +0000)]
* Added a new reference to priv->draft_msg of edit window
to manages its own reference, becasue sometines, this object
was unreference and application crashed when get_msg method of
this window was called.

pmo-trunk-r2436

13 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 16:25:34 +0000 (16:25 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c:
* src/modest-tny-account-store.h:
Added modest_tny_account_is_memory_card_account().
* src/maemo/modest-main-window.c: (create_details_widget):
Show the same information items for the memory card as we show for the
local-folders, to fix projects.maemo.org bug NB#59307.

pmo-trunk-r2435

13 years ago* do lazy initialization of the server accounts; this avoids
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 16:06:35 +0000 (16:06 +0000)]
* do lazy initialization of the server accounts; this avoids
  a chicken-egg problem at startup where modest_runtime_get_account_store would
  be needed before initialized

pmo-trunk-r2434

13 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 15:57:57 +0000 (15:57 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (get_password):
Added some checks for NULL to maybe prevent crashes, though I think
it was Philip's last commit that actually prevented the crash here
when creating a first new account.
But the new account is still not usable (no messages are shown)
until a restart of the application.

pmo-trunk-r2433

13 years agoBugfix when setting the account to online
Philip Van Hoof [Tue, 26 Jun 2007 15:51:46 +0000 (15:51 +0000)]
Bugfix when setting the account to online

pmo-trunk-r2432

13 years ago* Check headers flags (CACHED) to determine if some message
Javier Fernandez Garcia-Boente [Tue, 26 Jun 2007 14:27:50 +0000 (14:27 +0000)]
* Check headers flags (CACHED) to determine if some message
was already retreived, and sets a different id in get_message
mail operation (OPEN). This new id will be used by progress
bar widget to show a different message.
* Fixes: NB#56201

pmo-trunk-r2431

13 years ago* expunge deleted messages when switching folders or closing;
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 14:05:47 +0000 (14:05 +0000)]
* expunge deleted messages when switching folders or closing;
  otherwise it's not possible to delete at all...

this should fix NB#61769, NB#61764

pmo-trunk-r2430

13 years agoUpdated the changelog with the fixes, june, 26th, 16:50.
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 13:51:42 +0000 (13:51 +0000)]
Updated the changelog with the fixes, june, 26th, 16:50.

pmo-trunk-r2429

13 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 12:48:36 +0000 (12:48 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-global-settings-dialog.c:
(idle_select_default_focus):
* src/modest-mail-operation.c: (idle_notify_progress),
(idle_notify_progress_once), (idle_notify_update_account_queue),
(set_last_updated_idle), (update_account_thread),
(notify_get_msgs_full), (get_msgs_full_destroyer),
(get_msgs_full_thread):
* src/widgets/modest-attachment-view.c: (get_size_idle_func):
* src/widgets/modest-header-view.c:
(idle_notify_headers_count_changed_destroy),
(idle_notify_headers_count_changed):
Use gdk_threads_enter() and gdk_threads_enter_leave() in
all idle handlers, because some other thread could be blocking
the GDK lock, so that it can do GUI stuff.

pmo-trunk-r2428

13 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 12:31:38 +0000 (12:31 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
(on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
(on_idle_send_receive), (on_idle_open_default_inbox):
* src/maemo/modest-msg-edit-window.c:
(modest_msg_edit_window_attach_file_noninteractive):
Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
to prevent a hang. I don't quite understand why these are necessary,
beause we should already be in the main loop. I guess something outside
of the main loop is taking the lock.

* tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
we are really using URIs, and use files that are more likely to exist.

pmo-trunk-r2427

13 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 12:05:41 +0000 (12:05 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* tests/dbus_api/Makefile.am: Fix the build of the tests. This was
        necessary because configure.ac now defines different variables.

pmo-trunk-r2426

13 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 11:39:46 +0000 (11:39 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* libmodest-dbus-client/libmodest-dbus-client.c:
        * libmodest-dbus-client/libmodest-dbus-client.h:
        Removed libmodest_dbus_client_send_mail() because it is not used by anything.
        libmodest_dbus_client_compose_mail() is what things actually use.

        * src/dbus_api/modest-dbus-api.h:
        * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
        * tests/dbus_api/Makefile.am:
        * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
        D-Bus method.

pmo-trunk-r2424

13 years ago * Added an extra check that was causing a crash when the folder returns no stats
Sergio Villar Senin [Tue, 26 Jun 2007 11:00:32 +0000 (11:00 +0000)]
* Added an extra check that was causing a crash when the folder returns no stats

pmo-trunk-r2423

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 26 Jun 2007 10:33:24 +0000 (10:33 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Added gtk_text_iter_forward_search_insensitive to implement
          case insensitive search of strings using the find toolbar.
        * Added proper information banners for no matches, search
          complete and empty find.
        * Rework the find in page, to work similar to the upcoming
          find in page new implementation of viewer.

pmo-trunk-r2422

13 years agoChanged the configure.ac file. corrected the helplib variable used instead of mimelib.
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 09:39:29 +0000 (09:39 +0000)]
Changed the configure.ac file. corrected the helplib variable used instead of mimelib.

pmo-trunk-r2421

13 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 09:10:53 +0000 (09:10 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* src/modest-init.c: (modest_init_local_folders):
        For memory-card (or other non local-folders) maildir accounts,
        always create an Archive folder, so that there is somewhere to put
        messages. This should be less confusing, because the user does not need
        to guess that the need to create a folder.

pmo-trunk-r2420

13 years ago* Add a new check of new folder name string length in
Javier Fernandez Garcia-Boente [Tue, 26 Jun 2007 09:05:20 +0000 (09:05 +0000)]
* Add a new check of new folder name string length in
'entry-changed' signal handler.
* Fixes: NB#61576

pmo-trunk-r2419

13 years agoCompilation error
Philip Van Hoof [Tue, 26 Jun 2007 08:25:56 +0000 (08:25 +0000)]
Compilation error

pmo-trunk-r2418

13 years ago* call osso_abook_init before doing anything with the addressbook.
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 08:03:16 +0000 (08:03 +0000)]
* call osso_abook_init before doing anything with the addressbook.
  this fixes NB#57415

pmo-trunk-r2417

13 years agoBugfix for 61408
Philip Van Hoof [Mon, 25 Jun 2007 20:07:50 +0000 (20:07 +0000)]
Bugfix for 61408

pmo-trunk-r2416

13 years ago * Added an attribute sent to the msg edit window that specifies that the mail has...
Sergio Villar Senin [Mon, 25 Jun 2007 18:56:49 +0000 (18:56 +0000)]
* Added an attribute sent to the msg edit window that specifies that the mail has scheduled to be sent
* Modified the window destruction code in the window manager. Now checks that the message has not been sent before trying to save it to drafsts
* Some code reorganization in the window manager

pmo-trunk-r2415

13 years ago* Added new dimming rules for Attachment menu option in
Javier Fernandez Garcia-Boente [Mon, 25 Jun 2007 18:00:05 +0000 (18:00 +0000)]
* Added new dimming rules for Attachment menu option in
viewer window.
* Fixes: NB#61148

pmo-trunk-r2414

13 years ago2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Mon, 25 Jun 2007 17:46:07 +0000 (17:46 +0000)]
2007-06-25  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/easysetup/modest-wizard-dialog.c: (init):
Fixed icon size by using (50, 50) which is the same as defined by
newer hildon-libs

pmo-trunk-r2413

13 years ago* sync the folders when when we're moving to another one.
Dirk-Jan C. Binnema [Mon, 25 Jun 2007 17:28:16 +0000 (17:28 +0000)]
* sync the folders when when we're moving to another one.
  this fixes NB#57773

pmo-trunk-r2412

13 years ago * Fixes NB#61266, now the user can navigate between the tabs of global settings...
Sergio Villar Senin [Mon, 25 Jun 2007 16:37:02 +0000 (16:37 +0000)]
 * Fixes NB#61266, now the user can navigate between the tabs of global settings dialog using the hardware keys

pmo-trunk-r2411

13 years ago * Partially reverted last commit, sometimes the gdk_threads_enter blocks, still...
Sergio Villar Senin [Mon, 25 Jun 2007 16:00:42 +0000 (16:00 +0000)]
* Partially reverted last commit, sometimes the gdk_threads_enter blocks, still need to review it

pmo-trunk-r2410

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Mon, 25 Jun 2007 15:48:18 +0000 (15:48 +0000)]
* src/modest-ui-actions.c:
        * Fixed translation of message retrieval information note
          (fixes NB#61620).

pmo-trunk-r2409

13 years ago * Added two missing gdk_threads_enter/leave statements
Sergio Villar Senin [Mon, 25 Jun 2007 15:48:08 +0000 (15:48 +0000)]
* Added two missing gdk_threads_enter/leave statements

pmo-trunk-r2408

13 years ago * Removed an invalid g_object_unref
Sergio Villar Senin [Mon, 25 Jun 2007 15:44:03 +0000 (15:44 +0000)]
* Removed an invalid g_object_unref
* Added some gdk_threads_enter/leave in the mail operations

pmo-trunk-r2407

13 years agoUpdated yje
Dirk-Jan C. Binnema [Mon, 25 Jun 2007 15:36:12 +0000 (15:36 +0000)]
Updated yje

pmo-trunk-r2406

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 25 Jun 2007 14:47:55 +0000 (14:47 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now Paste is dimmed when focus is in attachments view
          (fixes NB#60552).
        * Added proper information banners for insensitive press
          of Paste.

pmo-trunk-r2405

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Mon, 25 Jun 2007 14:26:47 +0000 (14:26 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Added information banner for search complete and no matches.
        * Fixed translation of confirm overwrite dialog (fixes
          NB#60401).

pmo-trunk-r2404

13 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Mon, 25 Jun 2007 14:11:52 +0000 (14:11 +0000)]
* src/maemo/modest-main-window.c:
        * Now "No messages to show" message is aligned to top
          instead of center (fixes NB#60298).

pmo-trunk-r2403

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 25 Jun 2007 14:02:59 +0000 (14:02 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now CC and BCC fields are shown even when show_cc and s
          show_bcc are FALSE in settings, if these fields have any
          values (for example replying to all in a message with Cc)
          (fixes NB#60253).

pmo-trunk-r2402

13 years ago2007-06-25 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Mon, 25 Jun 2007 13:18:44 +0000 (13:18 +0000)]
2007-06-25  Armin Burgmeier  <armin@openismus.com>

* src/widgets/modest-window-mgr.c:
* src/modest-init.c:
* configure.ac: Correctly recognize hildon-notify presence and fixed
the build without it being installed.

pmo-trunk-r2401