modest
13 years ago* make modest handle mailing lists somewhat correcter (RFC2369):
Dirk-Jan C. Binnema [Sun, 16 Dec 2007 12:48:55 +0000 (12:48 +0000)]
* make modest handle mailing lists somewhat correcter (RFC2369):
- with-reply all, reply to both the old From: and the Reply-To: address
  (in non-mailinglist cases, we ignore From: if there's a Reply-To:)
- remove duplicate entries in the To: field
- added modest_text_utils_remove_duplicate_addresses (name says it all)
- rewrote modest_text_utils_split_addresses_list; the old version appended
          the ","-seperator in some cases; the old impl is still there but #ifdef'd-out
  jdapena: please check the new impl, I think you wrote the old one
- added modest_tny_msg_get_header to get some header; I think a version
          of this function should go to Tinymail instead;

should fix NB #78638

Note: the real bug there seems to be that tny_header_get_reply_to always(?)
returns NULL; I worked around it by using the abovementioned,
modest_tny_msg_get_header (msg, "Reply-To")
now it works.

pmo-trunk-r3927

13 years ago* compile for tinymail API change
Dirk-Jan C. Binnema [Sun, 16 Dec 2007 10:08:45 +0000 (10:08 +0000)]
* compile for tinymail API change

pmo-trunk-r3926

13 years agoUpdate Modest to latest API change in Tinymail - rev. 3141
Philip Van Hoof [Sat, 15 Dec 2007 19:24:30 +0000 (19:24 +0000)]
Update Modest to latest API change in Tinymail - rev. 3141

pmo-trunk-r3925

13 years ago* no need for maemo-providers-data
Dirk-Jan C. Binnema [Fri, 14 Dec 2007 20:52:50 +0000 (20:52 +0000)]
* no need for maemo-providers-data

pmo-trunk-r3924

13 years ago * Fixed a memory leak
Sergio Villar Senin [Fri, 14 Dec 2007 17:09:47 +0000 (17:09 +0000)]
* Fixed a memory leak
* Removed some notification stuff since it's no longer needed since Felipe's changes to progress bar

pmo-trunk-r3923

13 years agoFixes NB#78637
Felipe Erias Morandeira [Fri, 14 Dec 2007 15:53:38 +0000 (15:53 +0000)]
Fixes NB#78637

pmo-trunk-r3922

13 years agoWeek 51 bug fixes.
Vivek Sekar [Fri, 14 Dec 2007 14:04:06 +0000 (14:04 +0000)]
Week 51 bug fixes.

pmo-trunk-r3920

13 years agoCorrected two g_object_unref
Felipe Erias Morandeira [Fri, 14 Dec 2007 12:43:48 +0000 (12:43 +0000)]
Corrected two g_object_unref

pmo-trunk-r3919

13 years agoCorrected ref and unref of mail operations.
Felipe Erias Morandeira [Fri, 14 Dec 2007 12:30:42 +0000 (12:30 +0000)]
Corrected ref and unref of mail operations.

pmo-trunk-r3918

13 years agoFixes NB#78602
Felipe Erias Morandeira [Fri, 14 Dec 2007 12:05:20 +0000 (12:05 +0000)]
Fixes NB#78602
   * modest-mail-operation-queue.[hc]:
      (modest_mail_operation_queue_get_by_source): returns the mail operations
         in the queue associated with a given source
   * widgets/modest-window-mgr.c:
      (modest_window_mgr_unregister_window): if the window that is being
         closed is a ModestMsgViewWindow, it cancels "open" and "receive"
         operations that have it as their source
   * maemo/modest-main-window.c:
      (on_mail_operation_started): only goes to transfer mode if it is the
         source of the operation whose start has been notified
   * maemo/modest-msg-view-window.c:
      (on_mail_operation_started): only goes to transfer mode if it is the
         source of the operation whose start has been notified
      (view_msg_cb): added checks for cancelled operations and empty fields

pmo-trunk-r3917

13 years agomodest-tny-msg: fixed leak in add_images()
Alberto Garcia [Fri, 14 Dec 2007 11:16:56 +0000 (11:16 +0000)]
modest-tny-msg: fixed leak in add_images()

pmo-trunk-r3916

13 years ago * Speeds up the progress bar, makes things "feel" faster
Sergio Villar Senin [Thu, 13 Dec 2007 18:51:55 +0000 (18:51 +0000)]
* Speeds up the progress bar, makes things "feel" faster

pmo-trunk-r3915

13 years ago* Use the old To: to determine the new To:
Dirk-Jan C. Binnema [Thu, 13 Dec 2007 16:17:50 +0000 (16:17 +0000)]
* Use the old To: to determine the new To:
* Use the old Cc: to determine the new Cc:
* _don't_ add the Bcc:
* code-cleanup

* Together with Sergio's tny patch, fixes:
NB#78589
  and
https://bugs.maemo.org/show_bug.cgi?id=2539

pmo-trunk-r3914

13 years ago* sometimes, the text->html conversion screwed up, because
Dirk-Jan C. Binnema [Thu, 13 Dec 2007 16:01:18 +0000 (16:01 +0000)]
* sometimes, the text->html conversion screwed up, because
  the hyperlinkify happens *after* text->html, and it would
  mistakenly recognize some of the things as part of urls.

https://bugs.maemo.org/show_bug.cgi?id=2540

  Now, we put \007 instead of & when doing the text->html,
  then do the hyperlinkify, then replace \007 with &

pmo-trunk-r3913

13 years agoPartially fixes NB#78521
Felipe Erias Morandeira [Thu, 13 Dec 2007 15:30:38 +0000 (15:30 +0000)]
Partially fixes NB#78521
  * src/maemo/modest-progress-bar-widget.c:
    When the progress bar receives a "progress-changed" signal from its mail operation
    where state->done = 0 and state->total = 0, it begins to pulse periodically until
    the mail operation finishes or it receives a "progress-changed" signal with
    positive values.
    * (modest_progress_bar_widget_is_pulsating) :
    * (modest_progress_bar_widget_set_pulsating_mode) : manage this pulsating mode

* src/modest-mail-operation.c
    * (modest_mail_operation_update_account) :
    * (modest_mail_operation_get_msg) :
    * (modest_mail_operation_get_msgs_full) :
    * (modest_mail_operation_refresh_folder) : these functions send an initial "progress-changed"
        signal because it could happen that the first signal with "real" data takes a long time
        to happen, or in some cases doesn't happen at all, leaving the user with an empty
        progress bar for a while.

pmo-trunk-r3912

13 years ago * Expunge the messages of the local accounts when removing them to save disk space
Sergio Villar Senin [Thu, 13 Dec 2007 13:42:23 +0000 (13:42 +0000)]
* Expunge the messages of the local accounts when removing them to save disk space

pmo-trunk-r3911

13 years agoWork to fix glitches with progress toolbar (fixes NB#78458).
Jose Dapena Paz [Thu, 13 Dec 2007 12:18:52 +0000 (12:18 +0000)]
Work to fix glitches with progress toolbar (fixes NB#78458).
* src/maemo/modest-progress-bar-widget.c:
        * Now we make sure we never set a NULL string as label of the
          progress bar, and we get an initial " " string. This is for
          getting always the expected height. This should prevent some
          toolbar resizements.
* src/maemo/modest-msg-view-window.c,
  src/maemo/modest-main-window.c:
        * Rework the toolbar buttons size management. This way the
          progress toolbar does not cause a resize of the other buttons.
* src/maemo/ui/modest-msg-view-window-ui.xml,
  src/maemo/ui/modest-main-window-ui.xml:
        * Add position attributes to toolbar.

pmo-trunk-r3910

13 years ago * Fixes NB#78587, Modest no longer crashes when closing while s&r
Sergio Villar Senin [Thu, 13 Dec 2007 11:48:56 +0000 (11:48 +0000)]
* Fixes NB#78587, Modest no longer crashes when closing while s&r

pmo-trunk-r3909

13 years ago* src/maemo/modest-main-window-ui.h:
Jose Dapena Paz [Thu, 13 Dec 2007 09:03:25 +0000 (09:03 +0000)]
* src/maemo/modest-main-window-ui.h:
        * Add shortcut for "new email" in message view.
* src/maemo/modest-maemo-utils.[ch]:
        * New method ..._get_manager_menubar_as_menu. This converts
          a GtkMenuBar obtained from ui manager to a GtkMenu as
          expected in hildon_window_set_menu (). Using this instead
          of popup menus in ui manager fixes the shortcuts
          (fixes NB#75525).
* src/maemo/modest-msg-edit-window.c,
  src/maemo/modest-msg-view-window.c,
  src/maemo/modest-main-window.c:
        * Remove menubar_to_menu, as this is now a common method in
         modest_maemo_utils. Use the new method.
* src/maemo/ui/modest-main-window.xml,
  src/maemo/ui/modest-msg-edit-window.xml,
  src/maemo/ui/modest-msg-view-window.xml:
        * Use again menubars.

pmo-trunk-r3908

13 years ago* src/modest-tny-send-queue.c:
Jose Dapena Paz [Wed, 12 Dec 2007 20:41:57 +0000 (20:41 +0000)]
* src/modest-tny-send-queue.c:
* Now we remove the "current" sending message from the send
  queue also when the message sending fails (fixes NB#75510).

pmo-trunk-r3907

13 years ago* src/dbus_api/modest-dbus-callbacks.c:
Jose Dapena Paz [Wed, 12 Dec 2007 19:59:02 +0000 (19:59 +0000)]
* src/dbus_api/modest-dbus-callbacks.c:
        * If message is not found in folder, then we show an error
          dialog (fixes NB#77958).
        * Behave as if the message was not found if the message is
          deleted.
        * Mark the message as seen on opening from dbus callback
          (fixes NB#77847).
* src/maemo/modest-msg-view-window.c:
        * Now it works better without header model or row reference.
        * Update message priority on opening from search.

pmo-trunk-r3906

13 years agoAdd correctly the "Content-Disposition" header to attachments
Alberto Garcia [Wed, 12 Dec 2007 18:42:15 +0000 (18:42 +0000)]
Add correctly the "Content-Disposition" header to attachments
in modest-tny-msg

pmo-trunk-r3905

13 years agoFix memory leak in copy_mime_part()
Alberto Garcia [Wed, 12 Dec 2007 18:11:57 +0000 (18:11 +0000)]
Fix memory leak in copy_mime_part()

pmo-trunk-r3904

13 years agoFix leak in modest-tny-msg
Alberto Garcia [Wed, 12 Dec 2007 17:11:18 +0000 (17:11 +0000)]
Fix leak in modest-tny-msg

pmo-trunk-r3903

13 years agoFix memory leak in create_msg_thread()
Alberto Garcia [Wed, 12 Dec 2007 15:55:46 +0000 (15:55 +0000)]
Fix memory leak in create_msg_thread()

pmo-trunk-r3902

13 years agoFixes NB#78203
Felipe Erias Morandeira [Wed, 12 Dec 2007 12:14:35 +0000 (12:14 +0000)]
Fixes NB#78203
   * The modest_mail_operation_remove_msgs operation takes into account the "leave on server" setting.

pmo-trunk-r3901

13 years ago * Fixes NB#64997, Modest is now able to send an email after removing the trailing...
Sergio Villar Senin [Wed, 12 Dec 2007 11:11:19 +0000 (11:11 +0000)]
* Fixes NB#64997, Modest is now able to send an email after removing the trailing ";" from the recipient address

pmo-trunk-r3900

13 years ago * Fixed an error in the documentation
Sergio Villar Senin [Tue, 11 Dec 2007 16:01:33 +0000 (16:01 +0000)]
* Fixed an error in the documentation
* Replaced the call to tny_folder_store_create_folder by tny_folder_store_create_folder_async
* Fixes NB#78382, Modest UI is not blocked while creating a folder

pmo-trunk-r3899

13 years agoAdd checks for some callbacks that are used with connect_and_perform: on_rename_folde...
Felipe Erias Morandeira [Tue, 11 Dec 2007 14:18:24 +0000 (14:18 +0000)]
Add checks for some callbacks that are used with connect_and_perform: on_rename_folder_cb, on_delete_folder_cb, xfer_messages_from_move_to_cb and on_move_folder_cb.

pmo-trunk-r3898

13 years ago * Fixes NB#78470, the account name is now properly updated in the menus when changed
Sergio Villar Senin [Tue, 11 Dec 2007 12:51:43 +0000 (12:51 +0000)]
* Fixes NB#78470, the account name is now properly updated in the menus when changed

pmo-trunk-r3897

13 years agoFixes NB#77454
Felipe Erias Morandeira [Tue, 11 Dec 2007 12:33:55 +0000 (12:33 +0000)]
Fixes NB#77454
Adding support for connect_and_perform() in modest-ui-actions.c, for the public functions:
    * modest_ui_actions_on_move_to(..), both folder->folder and emails->folder
    * modest_ui_actions_on_delete_folder(..)
    * modest_ui_actions_on_move_folder_to_trash_folder(..)

pmo-trunk-r3896

13 years ago* some email programs (e.g. outlook in html mode) put 'normal'
Dirk-Jan C. Binnema [Mon, 10 Dec 2007 16:55:09 +0000 (16:55 +0000)]
* some email programs (e.g. outlook in html mode) put 'normal'
  http://foo.bar/image.jpg links in the html, and then attach
  the image, with Content-Location set to http://foo.bar/image.jpg,
  but the content embedded.

this fix makes sure we will find & show those images

pmo-trunk-r3895

13 years agoAdded the base64 encoded icon file into the chinook control file.
Vivek Sekar [Mon, 10 Dec 2007 15:51:15 +0000 (15:51 +0000)]
Added the base64 encoded icon file into the chinook control file.

pmo-trunk-r3894

13 years agoFix shortcut for Send in the message editor
Alberto Garcia [Mon, 10 Dec 2007 13:55:45 +0000 (13:55 +0000)]
Fix shortcut for Send in the message editor
Fixes NB#65668

pmo-trunk-r3893

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 10 Dec 2007 12:40:51 +0000 (12:40 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * We use lacy detection of mime types on adding files, so that
          it works equal to file manager (fixes NB#63391).

pmo-trunk-r3892

13 years ago* use the correctly sized icons for various things;
Dirk-Jan C. Binnema [Mon, 10 Dec 2007 12:29:21 +0000 (12:29 +0000)]
* use the correctly sized icons for various things;
added a parameter to modest_platform_get_icon
to do this.
  now, the window (editor/viewer) icons don't look
  blurry anymore. improved fix for NB#78393

pmo-trunk-r3891

13 years agoShow a generic error (instead of the one from Tinymail) when
Alberto Garcia [Mon, 10 Dec 2007 12:17:32 +0000 (12:17 +0000)]
Show a generic error (instead of the one from Tinymail) when
a move-to operation fails.
Fixes NB#78371

pmo-trunk-r3890

13 years ago* src/widgets/modest-attachments-view.c:
Jose Dapena Paz [Mon, 10 Dec 2007 10:28:54 +0000 (10:28 +0000)]
* src/widgets/modest-attachments-view.c:
        * Now purged attachments cannot be focused (fixes NB#78368).

pmo-trunk-r3889

13 years agoFix compilation problem
Alberto Garcia [Mon, 10 Dec 2007 09:15:32 +0000 (09:15 +0000)]
Fix compilation problem

pmo-trunk-r3888

13 years ago* some param checks (should prevent a crash )
Dirk-Jan C. Binnema [Mon, 10 Dec 2007 08:54:39 +0000 (08:54 +0000)]
* some param checks (should prevent a crash )

pmo-trunk-r3887

13 years agoremove needless g_warning
Dirk-Jan C. Binnema [Fri, 7 Dec 2007 13:12:28 +0000 (13:12 +0000)]
remove needless g_warning

pmo-trunk-r3886

13 years agoAdded bug fixes for week 50 release.
Vivek Sekar [Fri, 7 Dec 2007 13:00:57 +0000 (13:00 +0000)]
Added bug fixes for week 50 release.

pmo-trunk-r3884

13 years ago* show the specific icons for the edit-window and the viewer-window.
Dirk-Jan C. Binnema [Fri, 7 Dec 2007 11:51:44 +0000 (11:51 +0000)]
* show the specific icons for the edit-window and the viewer-window.
  problem was that hildon expect 64x54 icons (undocumented); so
  now we're scaling the icons a bit. unfortunately, the scaled icons
  look a bit blurry (GDK_INTERP_BILINEAR), so filing a bug against
  graphics to get better icons.

Fixes: NB#78366, NB#78367

pmo-trunk-r3883

13 years ago* it makes sense not to allow '&' and '#' in new folder names,
Dirk-Jan C. Binnema [Fri, 7 Dec 2007 11:17:04 +0000 (11:17 +0000)]
* it makes sense not to allow '&' and '#' in new folder names,
  as IMAP RFC says they should be 'avoided', and are troublesome
  anyway for cmdline users.

Fixes: NB#78380

pmo-trunk-r3882

13 years ago * Removed some weird const
Sergio Villar Senin [Wed, 5 Dec 2007 17:58:22 +0000 (17:58 +0000)]
* Removed some weird const

pmo-trunk-r3881

13 years agoNew function modest_platform_information_banner_with_timeout()
Alberto Garcia [Wed, 5 Dec 2007 15:26:45 +0000 (15:26 +0000)]
New function modest_platform_information_banner_with_timeout()
Set a short timeout to the "Opening" banner so it disappears earlier
Fixes NB#76842

pmo-trunk-r3880

13 years ago* src/maemo/modest-platform.c:
Jose Dapena Paz [Wed, 5 Dec 2007 13:51:57 +0000 (13:51 +0000)]
* src/maemo/modest-platform.c:
* Small fix for the sort type dialog. We were setting a limit of
  5 sort types when we have 6 (fixes NB#78350).

pmo-trunk-r3879

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Wed, 5 Dec 2007 13:36:46 +0000 (13:36 +0000)]
* src/modest-ui-actions.c:
        * Removed unused code.
* src/modest-ui-dimming-rules.c:
        * Add dimming rule to prevent removing attachments of messages
          we're sending (fixes NB#76634).

pmo-trunk-r3878

13 years agoFixes a GLIB WARNING by providing empty implementations to set_zoom() and get_zoom().
Felipe Erias Morandeira [Wed, 5 Dec 2007 12:15:51 +0000 (12:15 +0000)]
Fixes a GLIB WARNING by providing empty implementations to set_zoom() and get_zoom().

pmo-trunk-r3877

13 years ago * Fixes NB#78338, the summary.mmap files are deleted once the account is removed
Sergio Villar Senin [Wed, 5 Dec 2007 12:05:44 +0000 (12:05 +0000)]
* Fixes NB#78338, the summary.mmap files are deleted once the account is removed

pmo-trunk-r3876

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Wed, 5 Dec 2007 11:35:46 +0000 (11:35 +0000)]
* src/modest-ui-actions.c:
        * (modest_ui_actions_on_send_receive): we do not force a set
          folder here for currently focused folder. This prevents an
          unnecessary refresh of focused folder if it's not inbox.
        * (on_send_receive_finished): replaced the second set_folder
          with a mail operation to refresh the currently focused folder
          if it's not the inbox. THis way we finally don't lose focus on
          refresh (fixes NB#64670).

pmo-trunk-r3875

13 years agoFixes NB#78266
Felipe Erias Morandeira [Wed, 5 Dec 2007 11:15:08 +0000 (11:15 +0000)]
Fixes NB#78266

pmo-trunk-r3874

13 years ago * Fixes NB#77589, modest asks the user if they want to retrieve more mails than...
Sergio Villar Senin [Wed, 5 Dec 2007 11:07:47 +0000 (11:07 +0000)]
* Fixes NB#77589, modest asks the user if they want to retrieve more mails than the retrieve limit
* Fixes a very stupid bug by myself that was preventing opening messages in offline mode

pmo-trunk-r3873

13 years ago* Revert changes made in r3868. We have a better solution now
Alberto Garcia [Wed, 5 Dec 2007 10:59:51 +0000 (10:59 +0000)]
* Revert changes made in r3868. We have a better solution now
* New function easysetup_country_combo_box_load_data(), to actually
  fill the combo with the list of countries.
* Call it in an idle function so Modest startup time is even faster.

pmo-trunk-r3872

13 years ago* only output message/header registering/opening debug stuff
Dirk-Jan C. Binnema [Wed, 5 Dec 2007 10:21:44 +0000 (10:21 +0000)]
* only output message/header registering/opening debug stuff
  if MODEST_DEBUG contains "debug-code"

pmo-trunk-r3871

13 years agoPartially fixes NB#77528
Felipe Erias Morandeira [Wed, 5 Dec 2007 10:03:30 +0000 (10:03 +0000)]
Partially fixes NB#77528
Solves a memory problem when obtaining the size of an attachemnt
   * modest-count-stream.[ch] : implementation of TnyStream to get the size of a stream withou wasting extra memory
   * widgets/modest-attachment-view.c : uses the former to get the size of attachments
   * modest-mail-operation.c : removed two redundant lines
   * modest-tny-send-queue.c : check for NULL value before a strdup()

pmo-trunk-r3870

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Wed, 5 Dec 2007 09:18:32 +0000 (09:18 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * (modest_msg_edit_window_select_font): preserve old font size
          in case it's not set in font selector.

pmo-trunk-r3869

13 years agoDelay call to gtk_widget_show(self->combo_account_country)
Alberto Garcia [Wed, 5 Dec 2007 08:56:08 +0000 (08:56 +0000)]
Delay call to gtk_widget_show(self->combo_account_country)
This makes startup faster
Fixes NB#77425

pmo-trunk-r3868

13 years ago* src/widgets/modest-header-view-render.c,
Jose Dapena Paz [Tue, 4 Dec 2007 22:38:18 +0000 (22:38 +0000)]
* src/widgets/modest-header-view-render.c,
src/modest-tny-send-queue.[ch]:
        * Removed internal method get_status_of_uid, as it's now public
          in modest-tny-send-queue, with name
          modest_tny_all_send_queues_get_msg_status.
* src/maemo/modest-msg-view-window.c:
        * Now we skip failed messages in outbox for next/prev messages
          (fixes NB#78132).

pmo-trunk-r3867

13 years ago* src/maemo/modest-connection-specific-smtp-edit-window.c:
Jose Dapena Paz [Tue, 4 Dec 2007 18:24:35 +0000 (18:24 +0000)]
* src/maemo/modest-connection-specific-smtp-edit-window.c:
* Preserve the account name in connection specific smtp editor.
  This fixes modifying connection specific smtp accounts.

pmo-trunk-r3866

13 years agoCall gtk_combo_box_set_model() *after* loading countries from
Alberto Garcia [Tue, 4 Dec 2007 17:26:10 +0000 (17:26 +0000)]
Call gtk_combo_box_set_model() *after* loading countries from
file, it saves some 2-3 seconds

pmo-trunk-r3865

13 years ago * Partially fixes NB#78203, expunge messages in POP if leave message from server...
Sergio Villar Senin [Tue, 4 Dec 2007 16:49:51 +0000 (16:49 +0000)]
 * Partially fixes NB#78203, expunge messages in POP if leave message from server is unchecked

pmo-trunk-r3864

13 years ago * Do not check if the account is connected in the case of local accounts. Thx Dape...
Sergio Villar Senin [Tue, 4 Dec 2007 13:08:20 +0000 (13:08 +0000)]
* Do not check if the account is connected in the case of local accounts. Thx Dape for reporting this very bad mistake by myself

pmo-trunk-r3863

13 years ago* src/widgets/modest-mozembed-mime-part-view.c renamed as
Jose Dapena Paz [Tue, 4 Dec 2007 11:20:45 +0000 (11:20 +0000)]
* src/widgets/modest-mozembed-mime-part-view.c renamed as
  src/widgets/modest-mozembed-mime-part-view.cpp.
        * Added integration with mozembed glue.
        * Type castings to prevent warnings.
* src/widgets/Makefile.am:
        * Updated.
* configure.ac:
        * Check c++ compiler.

pmo-trunk-r3862

13 years ago* don't use ANONYMOUS@ for non-login SMTP accounts; discussed
Dirk-Jan C. Binnema [Tue, 4 Dec 2007 10:57:05 +0000 (10:57 +0000)]
* don't use ANONYMOUS@ for non-login SMTP accounts; discussed
  this with pvanhoof, and it was meaningless it seems.

this unbreaks support for at least MS Exchange SMTP servers
  without login

pmo-trunk-r3861

13 years agoCheck for NULL in tny_header_get_message_id()
Alberto Garcia [Tue, 4 Dec 2007 10:34:15 +0000 (10:34 +0000)]
Check for NULL in tny_header_get_message_id()

pmo-trunk-r3860

13 years agoFixes NB#66958
Felipe Erias Morandeira [Tue, 4 Dec 2007 10:14:32 +0000 (10:14 +0000)]
Fixes NB#66958
Added ellipsize to the details widget in the main window and to the account name column in the accounts dialog.

pmo-trunk-r3859

13 years agoUse msg id instead of msg url to compare e-mail in both
Alberto Garcia [Mon, 3 Dec 2007 18:44:40 +0000 (18:44 +0000)]
Use msg id instead of msg url to compare e-mail in both
send_mail_msg_sent_handler() and send_mail_error_happened_handler()
Fixes NB#77426

pmo-trunk-r3858

13 years ago* src/widget/Makefile.am, src/maemo/Makefile.am:
Jose Dapena Paz [Mon, 3 Dec 2007 17:36:28 +0000 (17:36 +0000)]
* src/widget/Makefile.am, src/maemo/Makefile.am:
        * Now modest-scroll-area is in widgets instead of maemo.
* Moved src/maemo/modest-scroll-area.[ch] to
  src/widgets/modest-scroll-area.[ch].

pmo-trunk-r3857

13 years ago* modest-detect-tap-and-hold:
Dirk-Jan C. Binnema [Mon, 3 Dec 2007 17:24:55 +0000 (17:24 +0000)]
* modest-detect-tap-and-hold:
- patch contributed by Loic Minier to check
            for the existence of tap-and-old instead
          of MAEMO_CHANGES

pmo-trunk-r3856

13 years ago * The notifications are now opened again after clicking on them
Sergio Villar Senin [Mon, 3 Dec 2007 17:21:50 +0000 (17:21 +0000)]
* The notifications are now opened again after clicking on them
* Fixes NB#77978, the messages from a search result can be opened again

pmo-trunk-r3855

13 years agoCorrection to the chinook control file- now replaces modest-l10n-engb, helps in insta...
Vivek Sekar [Mon, 3 Dec 2007 13:31:18 +0000 (13:31 +0000)]
Correction to the chinook control file- now replaces modest-l10n-engb, helps in installing in diablo.

pmo-trunk-r3854

13 years ago* src/maemo/modest-connection-specific-smtp-window.c:
Jose Dapena Paz [Mon, 3 Dec 2007 13:20:49 +0000 (13:20 +0000)]
* src/maemo/modest-connection-specific-smtp-window.c:
        * Now cancelling edit window does not show confirmation dialog.
* src/maemo/modest-connection-specific-smtp-edit-window.c:
        * Now the range error we show is not the standard number editor
          one. We show it in a timeout, to be able to cancel showing
          it if we press cancel in dialog (fixes NB#76854).

pmo-trunk-r3853

13 years agochinook control file conflicts with modest-l10n-engb, helps in installing in diablo.
Vivek Sekar [Mon, 3 Dec 2007 12:25:11 +0000 (12:25 +0000)]
chinook control file conflicts with modest-l10n-engb, helps in installing in diablo.

pmo-trunk-r3852

13 years ago* src/maemo/modest-account-settings-dialog.c:
Jose Dapena Paz [Mon, 3 Dec 2007 12:17:42 +0000 (12:17 +0000)]
* src/maemo/modest-account-settings-dialog.c:
* Added UI checking. Now ok button is dimmed if we set
  an outgoing auth protocol, and outgoing login is empty
  (fixes NB#78104).

pmo-trunk-r3851

13 years ago * Added an extra error check
Sergio Villar Senin [Mon, 3 Dec 2007 11:35:27 +0000 (11:35 +0000)]
* Added an extra error check

pmo-trunk-r3850

13 years ago* src/modest-account-mgr-helpers.c:
Jose Dapena Paz [Mon, 3 Dec 2007 10:26:48 +0000 (10:26 +0000)]
* src/modest-account-mgr-helpers.c:
* (modest_account_mgr_load_account_settings): now we properly
  set the retrieve limit from manager.

pmo-trunk-r3849

13 years ago* src/maemo/modest-connection-specific-smtp-edit-window.c:
Jose Dapena Paz [Mon, 3 Dec 2007 09:39:08 +0000 (09:39 +0000)]
* src/maemo/modest-connection-specific-smtp-edit-window.c:
* Now we also set the transport protocol. This fixes the
  behavior of connection specific smtp settings.

pmo-trunk-r3848

13 years ago* set the X-Mailer header for outgoing mail. Fixes: NB#77997
Dirk-Jan C. Binnema [Mon, 3 Dec 2007 08:52:06 +0000 (08:52 +0000)]
* set the X-Mailer header for outgoing mail. Fixes: NB#77997

pmo-trunk-r3847

13 years agoThis patch includes a lot of work to refactor and reorganize the
Jose Dapena Paz [Mon, 3 Dec 2007 08:04:03 +0000 (08:04 +0000)]
This patch includes a lot of work to refactor and reorganize the
account settings dialogs. The main improvement is the implementation
of ModestAccountSettings and ModestServerAccountSettings. These
classes represent the settings of accounts and server accounts in
memory, avoiding storage in ModestConf for temporal or non persistent
account settings.

* src/modest-protocol-info.[ch]:
        * New method modest_protocol_info_get_connection_protocol, that
          obtains a ModestConnectionProtocol from a string.
* src/modest-server-account-settings.[ch]:
        * New class, that represents server settings (common for
          store and transport server settings. It's only a memory
          storage. Persistence is managed in ModestAccountMgr.
* src/modest-account-settings.[ch]:
        * New class, that represents an account. It contains two
          ModestServerStoreSettings for store and transport accounts
          associated with the account. It represents all the common
          account information (display name, user fullname, email
          address, etc).
* src/modest-account-mgr-helpers.[ch]:
        * Added internal method null_means_empty for avoiding setting
          NULL to values we shouldn't put NULL.
        * (modest_account_mgr_get_store_protocol): use the new
          settings api.
        * (get_secure_auth_for_conf_string): removed, as it's also
          in ModestProtocolInfo. Also use
          modest_protocol_info_get_auth_protocol_name instead of
          the big if.
        * (get_security_for_conf_string): removed, as it's also in
          ModestProtocolInfo. Also removed if.
        * Replaced modest_account_mgr_get_server_account_data with
          modest_account_mgr_load_server_settings. The method creates
          an instance of ModestServerAccountSettings from a ModestConf
          account.
        * Removed free method for server account data.
        * Added method modest_account_mgr_save_server_settings. It
          stores a ModestServerAccountSettings in ModestConf.
        * Replaced modest_account_mgr_get_account_data with
          modest_account_mgr_load_account_settings. This fills a
          ModestAccountSettings instance with information, and
          also obtains the store and transport server settings. Also
          removed old ModestAccountData and ModestServerAccountData
          structs.
        * New method modest_account_mgr_save_account_settings, that
          saves an account to ModestConf. It's more intended for
  updating an existing accoung.
        * Methods get_retrieve_type_name and get_retrieve_type, to
  convert from string representation of retrieve types into
  modest ModestAccountRetrieveType and viceversa.
* src/modest-account-mgr.[ch]:
        * New (modest_account_mgr_add_account_from_settings): creates
          a new account in ModestConf, and emits the signal to register
          it in the list of available accounts.
        * Usage of ModestAccountRetrieveType instead of conf strings.
        * Use ModestAccountSettings and ModestServerAccountSettings
          instead of deprecated ModestAccountData and
          ModestServerAccountData.
* src/modest-tny-account.c:
        * Use ModestAccountSettings and ModestServerAccountSettings.
* src/modest-tny-account-store.c:
        * Use ModestAccountSettings.
* src/modest-mail-operation.c:
        * Use ModestAccountRetrieveType instead of strings.
* src/modest-widget-memory.c:
        * Use ModestAccountSettings.
* src/widgets/modest-retrieve-combo-box.[ch]:
        * Use ModestAccountRetrieveType instead of strings.
* src/widgets/modest-account-view.c:
        * Use ModestServerAccountSettings and ModestAccountSettings.
* src/widgets/modest-header-view.c:
        * Small change, if model is NULL, expose returns silently.
* src/modest-ui-actions.c:
        * Use ModestAccountSettings api.
        * Make some specific maemo code be now usable again also
          in gnome port.
* src/maemo/modest-connection-specific-smtp-window.c:
        * User ModestServerAccountSettings api.
* src/maemo/easysetup/modest-easysetup-wizard.[ch]:
        * Big work here to adapt to ModestAccountSettings. As a benefit,
          now we use it to pass the settings to
ModestAccountSettingsDialog
          (advanced settings). We only save to the account manager on
          finishing and approving changes.
        * Moved code to create the account to ModestAccountMgr, and
  added code to fill the ModestAccountSettings.
* src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
        * New method to set the provider to others.
* src/maemo/modest-account-view-window.c:
        * Use ModestAccountSettings.
* src/maemo/modest-account-settings-dialog.c:
        * Use ModestAccountSettings.
        * Move storage and fetch code from ModestConf to account
  manager.
        * Added code to fill and retrieve information in
  ModestAccountSettings and ModestServerAccountSettings.
        * Now it works with ModestAccountSettings, instead of storing
  directly to ModestConf.
* src/maemo/modest-main-window.c:
        * Use ModestAccountSettings for management of accounts menu
          options.
* src/maemo/modest-connection-specific-smtp-edit-window.c:
        * Use ModestServerAccountSettings.
* src/modes-platform.h, src/maemo/modest-plaform.c,
  src/gnome/modest-platform.c:
        * Provide methods to retrieve an instance of the account
          settings dialog and the account settings wizard.
        * Provide valid implementation of some dialogs in gnome port.

And some work for splitting modest-maemo-utils in modest-utils (for
common usable methods) and modest-maemo-utils (specific maemo platform):
* src/modest-utils.[ch]:
        * New set of methods, now available for all modest platforms.
        * Reworked many other objects, to use this split.
* src/maemo/modest-maemo-utils.[ch]:
        * Moved a lot of methods to modest-utils.

pmo-trunk-r3846

13 years ago* added Gmail/IMAP to our provider list, add (c), cleanup
Dirk-Jan C. Binnema [Sat, 1 Dec 2007 11:39:02 +0000 (11:39 +0000)]
* added Gmail/IMAP to our provider list, add (c), cleanup
* some cosmetics

pmo-trunk-r3844

13 years ago* don't try to open file:-uri's, and don't add them to CSMs
Dirk-Jan C. Binnema [Fri, 30 Nov 2007 14:44:53 +0000 (14:44 +0000)]
* don't try to open file:-uri's, and don't add them to CSMs

pmo-trunk-r3843

13 years agoAdded the week 49 bug fixes.
Vivek Sekar [Fri, 30 Nov 2007 09:36:52 +0000 (09:36 +0000)]
Added the week 49 bug fixes.

pmo-trunk-r3842

13 years ago* add some parameter checks to public functions
Dirk-Jan C. Binnema [Fri, 30 Nov 2007 07:49:41 +0000 (07:49 +0000)]
* add some parameter checks to public functions

pmo-trunk-r3841

13 years ago * Needed initialization
Sergio Villar Senin [Thu, 29 Nov 2007 09:40:40 +0000 (09:40 +0000)]
* Needed initialization

pmo-trunk-r3839

13 years ago * Add connection error handling to message opening
Sergio Villar Senin [Thu, 29 Nov 2007 08:43:58 +0000 (08:43 +0000)]
* Add connection error handling to message opening

pmo-trunk-r3838

13 years agoAfter a server has been modified in the in the connection-specific
Alberto Garcia [Wed, 28 Nov 2007 12:28:41 +0000 (12:28 +0000)]
After a server has been modified in the in the connection-specific
SMTP window, update the treeview using the new values rather than the
old values taken from the modest-account-mgr
Fixes NB#77361

pmo-trunk-r3837

13 years agoFixes NB#77388
Felipe Erias Morandeira [Wed, 28 Nov 2007 12:09:30 +0000 (12:09 +0000)]
Fixes NB#77388
In modest_mail_operation_send_new_mail(..), sets the initial status of the mail operation to MODEST_MAIL_OPERATION_STATUS_IN_PROGRESS.

pmo-trunk-r3836

13 years agoDon't set the username if it's empty in update_tny_account()
Alberto Garcia [Wed, 28 Nov 2007 11:39:48 +0000 (11:39 +0000)]
Don't set the username if it's empty in update_tny_account()
or it will cause an assertion in tinymail to fail

pmo-trunk-r3835

13 years agoChange resize-mode of ModestAttachmentsView so all attachments
Alberto Garcia [Wed, 28 Nov 2007 11:12:34 +0000 (11:12 +0000)]
Change resize-mode of ModestAttachmentsView so all attachments
are visible
Fixes NB#77277

pmo-trunk-r3834

13 years agoFixes NB#77038
Felipe Erias Morandeira [Wed, 28 Nov 2007 10:34:49 +0000 (10:34 +0000)]
Fixes NB#77038
* modest/src/modest-mail-operation.c: the "last_updated" field off an account is updated also when there aren't new headers to get
* modest/src/modest-account-mgr.[ch]: added a new signal, "account_updated"
* modest/src/widgets/modest-account-view.c: connected to the former signal to refresh the "last updated" column
* modest/src/maemo/modest-main-window.c: connected to the former signal to refresh the details widget

pmo-trunk-r3833

13 years agoUpdate all accounts after they have been modified,
Alberto Garcia [Wed, 28 Nov 2007 10:28:10 +0000 (10:28 +0000)]
Update all accounts after they have been modified,
no matter their status
Fixes NB#73627

pmo-trunk-r3832

13 years agoFix regular expression used to check domain names.
Alberto Garcia [Wed, 28 Nov 2007 10:01:54 +0000 (10:01 +0000)]
Fix regular expression used to check domain names.
This one allows things like '10.0.1.1'

pmo-trunk-r3831

13 years ago* add some parameter checks to public functions
Dirk-Jan C. Binnema [Tue, 27 Nov 2007 12:36:30 +0000 (12:36 +0000)]
* add some parameter checks to public functions

pmo-trunk-r3830

13 years ago * Removed some comments
Sergio Villar Senin [Tue, 27 Nov 2007 12:24:53 +0000 (12:24 +0000)]
* Removed some comments
* Removed a function that was only emitting a signal

pmo-trunk-r3829

13 years ago * Fixes NB#77103, the message is not sent if the user does not select any recipient...
Sergio Villar Senin [Tue, 27 Nov 2007 12:17:27 +0000 (12:17 +0000)]
* Fixes NB#77103, the message is not sent if the user does not select any recipient clicking cancel in the dialog

pmo-trunk-r3828

13 years ago* remove some g_asserts, add warnings instead
Dirk-Jan C. Binnema [Tue, 27 Nov 2007 11:21:58 +0000 (11:21 +0000)]
* remove some g_asserts, add warnings instead

pmo-trunk-r3827

13 years ago * The password request dialog was appearing bellow the accounts dialog and it's...
Sergio Villar Senin [Tue, 27 Nov 2007 10:22:25 +0000 (10:22 +0000)]
* The password request dialog was appearing bellow the accounts dialog and it's modal, so the user was unable to click on it or on the accounts dialog, so it seemed that modest is hanged

pmo-trunk-r3826

13 years agoFix platform detection in configure.ac
Alberto Garcia [Tue, 27 Nov 2007 10:00:08 +0000 (10:00 +0000)]
Fix platform detection in configure.ac

pmo-trunk-r3825

13 years ago* don't drink and code
Dirk-Jan C. Binnema [Mon, 26 Nov 2007 22:39:09 +0000 (22:39 +0000)]
* don't drink and code

pmo-trunk-r3824