modest
13 years ago* src/modest-mail-operation.c:
Alberto Garcia [Wed, 27 Feb 2008 17:44:51 +0000 (17:44 +0000)]
* src/modest-mail-operation.c:
(get_msg_async_cb): If the operation has been canceled by the user,
ignore then error that comes from Tinymail and don't touch the error
code of the mail operation.

* src/modest-mail-operation-queue.c:
(modest_mail_operation_queue_remove): Don't call the error handler if
the operation has been canceled by the user.

Fixes NB#81459

pmo-trunk-r4235

13 years ago * Fixes NB#81429, Delete HW button was not behaving correctly when header view was...
Sergio Villar Senin [Wed, 27 Feb 2008 13:02:52 +0000 (13:02 +0000)]
* Fixes NB#81429, Delete HW button was not behaving correctly when header view was focused

pmo-trunk-r4234

13 years ago * Fixes NB#81413, Esc key closes the "Save changes" dialog and the editor window...
Sergio Villar Senin [Wed, 27 Feb 2008 12:43:56 +0000 (12:43 +0000)]
* Fixes NB#81413, Esc key closes the "Save changes" dialog and the editor window instead of saving the message

pmo-trunk-r4233

13 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Wed, 27 Feb 2008 09:47:08 +0000 (09:47 +0000)]
* src/maemo/modest-main-window.c:
        * Now, when the window is destroyed, we destroy the
          pending information banners (redundantly) and information
          banner handlers (to avoid showing them when the window is
          already closed) (fixes NB#81215).

pmo-trunk-r4232

13 years ago * Partially fixes NB#81238, fixes some problems reported by coverity
Sergio Villar Senin [Tue, 26 Feb 2008 18:23:18 +0000 (18:23 +0000)]
* Partially fixes NB#81238, fixes some problems reported by coverity

pmo-trunk-r4231

13 years ago * Fixes NB#81095, UI is now properly updated when deleting an account while retrievi...
Sergio Villar Senin [Tue, 26 Feb 2008 17:37:43 +0000 (17:37 +0000)]
* Fixes NB#81095, UI is now properly updated when deleting an account while retrieving a message

pmo-trunk-r4230

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 26 Feb 2008 17:24:09 +0000 (17:24 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * If the body buffer is marked as modified we evaluate the
          dimming rules, to know if we should dim save to drafts or
          not (fixes NB#81353).

pmo-trunk-r4229

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 26 Feb 2008 15:23:21 +0000 (15:23 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now we get the decoded stream from messages, to show the
          expected attached images in editor (fixes NB#79624).

pmo-trunk-r4228

13 years ago* src/modest-text-utils.[ch]:
Jose Dapena Paz [Tue, 26 Feb 2008 13:10:56 +0000 (13:10 +0000)]
* src/modest-text-utils.[ch]:
        * Added a new method to escape mnemonics
* src/maemo/modest-main-window.c:
        * Now we escape mnemonics on account names in menus and toolbar
          (fixes NB#81327).

pmo-trunk-r4227

13 years ago* src/maemo/modest-account-settings-dialog.[ch]:
Jose Dapena Paz [Tue, 26 Feb 2008 12:30:20 +0000 (12:30 +0000)]
* src/maemo/modest-account-settings-dialog.[ch]:
        * Added methods to set the modified state, and to avoid showing
          the "settings saved" ib if we showed the dialog because of an
          auth error.
* src/modest-tny-account-store.c:
        * If an auth error has been produced and we want to show the
          account settings dialog, then we force the dialog to save its
          results always (fixes partially NB#81055).

pmo-trunk-r4226

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 25 Feb 2008 12:10:29 +0000 (12:10 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Update properly the alignment radio menu items from current
  alignment status (fixes NB#81024).

pmo-trunk-r4225

13 years agoremoved the internet-mail.svg file.
Vivek Sekar [Mon, 25 Feb 2008 10:54:18 +0000 (10:54 +0000)]
removed the internet-mail.svg file.

pmo-trunk-r4224

13 years agoAdded the week 09 bug fixes to debian/changelog
Vivek Sekar [Mon, 25 Feb 2008 09:51:53 +0000 (09:51 +0000)]
Added the week 09 bug fixes to debian/changelog

pmo-trunk-r4222

13 years ago* src/modest-tny-account-store.[ch]:
Jose Dapena Paz [Fri, 22 Feb 2008 14:53:39 +0000 (14:53 +0000)]
* src/modest-tny-account-store.[ch]:
        * (modest_tny_account_store_show_account_settings_dialog):
          new method for single access to create the account settings
          dialog. This should make all attempts to show settings dialog
          when it's already shown go through this (fixes NB#80817).
* src/maemo/modest-account-view-window.c:
        * Use the new show account settings method.

pmo-trunk-r4221

13 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Thu, 21 Feb 2008 19:06:29 +0000 (19:06 +0000)]
* src/widgets/modest-folder-view.c:
        * Now we highlight on all valid destinations of dnd, not only on
          valid ones that will be expanded (fixes NB#81198).

pmo-trunk-r4220

13 years ago * Fixes NB#81189, able to drop a folder in the root MMC account
Sergio Villar Senin [Thu, 21 Feb 2008 16:48:10 +0000 (16:48 +0000)]
* Fixes NB#81189, able to drop a folder in the root MMC account

pmo-trunk-r4219

13 years ago * Fixed a lot of reference leaks
Sergio Villar Senin [Thu, 21 Feb 2008 10:55:06 +0000 (10:55 +0000)]
* Fixed a lot of reference leaks
* Updated some documentation

pmo-trunk-r4218

13 years agoChanges to fix NB#80521.
Jose Dapena Paz [Thu, 21 Feb 2008 09:31:22 +0000 (09:31 +0000)]
Changes to fix NB#80521.
* src/modest-tny-mime-part.c:
        * Now we recognise a purged attachment as an attachment for
          modest.
* src/maemo/modest-msg-view-window.c:
        * As we now detect purged attachments as attachments, we filter
          here to disallow saving purged attachments.
* src/modest-ui-dimming-rules.c:
        * Remove invalid_account_for_purge as it was wrong, and it's now
          superseeded by _invalid_folder_for_purge.

pmo-trunk-r4217

13 years ago* po/en_GB.po:
Jose Dapena Paz [Thu, 21 Feb 2008 09:25:57 +0000 (09:25 +0000)]
* po/en_GB.po:
* Fix the translation issue of
  mcen_nc_unable_to_delete_n_messages, as now it expects a %d
  instead of a %s.

pmo-trunk-r4216

13 years ago* src/widgets/modest-details-dialog.c:
Jose Dapena Paz [Wed, 20 Feb 2008 17:00:39 +0000 (17:00 +0000)]
* src/widgets/modest-details-dialog.c:
* Now up/down keys scroll the details (fixes NB#79330).

pmo-trunk-r4215

13 years ago* src/widgets/modest-header-view-render.c:
Jose Dapena Paz [Wed, 20 Feb 2008 15:49:04 +0000 (15:49 +0000)]
* src/widgets/modest-header-view-render.c:
* Fix rendering of already opened messages.

pmo-trunk-r4214

13 years agoFix obsolete string mail_ib_unable_to_purge_editable_msg
Alberto Garcia [Wed, 20 Feb 2008 15:03:21 +0000 (15:03 +0000)]
Fix obsolete string mail_ib_unable_to_purge_editable_msg

pmo-trunk-r4213

13 years ago * src/modest-ui-dimming-rules.c
Alberto Garcia [Wed, 20 Feb 2008 14:49:27 +0000 (14:49 +0000)]
* src/modest-ui-dimming-rules.c
(_invalid_folder_for_purge):
Don't allow removal of attachments from messages in remote
folders.
Fixes NB#75422

pmo-trunk-r4212

13 years ago * Fixes NB#80917, added wimax support
Sergio Villar Senin [Wed, 20 Feb 2008 12:51:42 +0000 (12:51 +0000)]
* Fixes NB#80917, added wimax support
* Most of work had been already commited in revision 4203

pmo-trunk-r4211

13 years ago * src/modest-ui-actions.c:
Alberto Garcia [Wed, 20 Feb 2008 12:49:04 +0000 (12:49 +0000)]
* src/modest-ui-actions.c:
(modest_ui_actions_on_save_to_drafts):
Change string shown on banner according to UI Specs v3.0
Fixes NB#80964

pmo-trunk-r4210

13 years ago * Fixes NB#81063, now it's not possible to select purged attachments using select all
Sergio Villar Senin [Wed, 20 Feb 2008 12:25:47 +0000 (12:25 +0000)]
* Fixes NB#81063, now it's not possible to select purged attachments using select all
* It's no longer possible to select them using the HW keys as well

pmo-trunk-r4209

13 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Wed, 20 Feb 2008 11:58:33 +0000 (11:58 +0000)]
* src/modest-ui-dimming-rules.c:
* Now we can send messages without body (fixes NB#80962).

pmo-trunk-r4208

13 years ago* src/maemo/modest-maemo-global-settings-dialog.c:
Jose Dapena Paz [Wed, 20 Feb 2008 11:27:50 +0000 (11:27 +0000)]
* src/maemo/modest-maemo-global-settings-dialog.c:
* Changed the default width of the dialog to 700 to fit the
  translation strings for most languages (fixes NB#80866).

pmo-trunk-r4207

13 years ago* src/widgets/modest-header-view.c:
Jose Dapena Paz [Wed, 20 Feb 2008 11:07:32 +0000 (11:07 +0000)]
* src/widgets/modest-header-view.c:
        * Set the fixed height from font in text cell renderers.
* src/widgets/modest-header-view-render.c:
        * Avoid using pango markup as pango parsing is expensive.
          Instead of this use cell renderer properties to set the
          default fonts.
        * We set the properties now using freeze and thaw, for avoiding
          preparing the font as many times as properties we have.
* src/modest-ui-actions.c:
        * Show proper information banner on opening a drafts message.
* src/maemo/modest-msg-edit-window.c:
        * Delay show all just until all the window is ready to be shown.
          This should reduce expensive redraws and relocations.
* src/maemo/modest-msg-view-window.c:
        * Also delay show all until all the window is ready to be shown.

pmo-trunk-r4206

13 years ago * Fixes NB#80896, fixes an endless reconnection against Welho.com
Sergio Villar Senin [Wed, 20 Feb 2008 10:39:30 +0000 (10:39 +0000)]
* Fixes NB#80896, fixes an endless reconnection against Welho.com

pmo-trunk-r4205

13 years ago * Fixes NB#81047, the colon after "folders" is now getting the proper "dimmed" color
Sergio Villar Senin [Wed, 20 Feb 2008 09:52:54 +0000 (09:52 +0000)]
* Fixes NB#81047, the colon after "folders" is now getting the proper "dimmed" color

pmo-trunk-r4204

13 years ago * Partially fixes NB#80917, we still need the strings from the translation team
Sergio Villar Senin [Tue, 19 Feb 2008 19:06:55 +0000 (19:06 +0000)]
* Partially fixes NB#80917, we still need the strings from the translation team

pmo-trunk-r4203

13 years ago * src/maemo/modest-signature-editor-dialog.c
Alberto Garcia [Tue, 19 Feb 2008 17:52:03 +0000 (17:52 +0000)]
* src/maemo/modest-signature-editor-dialog.c
(modest_signature_editor_dialog_set_settings):
Don't let the "Signature for account" label be truncated
Partially fixes NB#80914

pmo-trunk-r4202

13 years ago * Fixes NB#80994, adds a "retrieving" info banner when opening a message takes more...
Sergio Villar Senin [Tue, 19 Feb 2008 17:09:16 +0000 (17:09 +0000)]
* Fixes NB#80994, adds a "retrieving" info banner when opening a message takes more than 2 seconds

pmo-trunk-r4201

13 years ago * src/maemo/modest-platform.c:
Alberto Garcia [Tue, 19 Feb 2008 17:08:00 +0000 (17:08 +0000)]
* src/maemo/modest-platform.c:
(modest_platform_run_folder_name_dialog):
Make the width of the text entry proportional to the size of
the default text, so it works OK in all languages.
Fixes NB#81007

pmo-trunk-r4200

13 years ago * Fixes NB#81009, show the proper title when saving multiple attachments
Sergio Villar Senin [Tue, 19 Feb 2008 16:30:13 +0000 (16:30 +0000)]
* Fixes NB#81009, show the proper title when saving multiple attachments

pmo-trunk-r4199

13 years ago * Fixes NB#80959, Modest does not crash if the username is left empty
Sergio Villar Senin [Tue, 19 Feb 2008 16:08:39 +0000 (16:08 +0000)]
* Fixes NB#80959, Modest does not crash if the username is left empty
* Fixes NB#80991, show the information banner on top of the password dialo
M    modest-ui-actions.c

pmo-trunk-r4198

13 years ago * Fixes NB#80965, the OK button is selected by default in the certificate confirmati...
Sergio Villar Senin [Tue, 19 Feb 2008 11:11:28 +0000 (11:11 +0000)]
* Fixes NB#80965, the OK button is selected by default in the certificate confirmation dialog
* Reverts changes of 4194

pmo-trunk-r4197

13 years agoSet correctly the transient window in the connection-specific servers
Alberto Garcia [Tue, 19 Feb 2008 11:09:30 +0000 (11:09 +0000)]
Set correctly the transient window in the connection-specific servers
Fixes NB#80977

pmo-trunk-r4196

13 years ago * Fixes NB#80734, now dimming rules of menubar are evaluated when the mail operation...
Sergio Villar Senin [Tue, 19 Feb 2008 11:01:42 +0000 (11:01 +0000)]
* Fixes NB#80734, now dimming rules of menubar are evaluated when the mail operations start, in order to properly update accelerators

pmo-trunk-r4195

13 years ago * Fixes NB#80965, focus the view button in the certificate confirmation dialog
Sergio Villar Senin [Tue, 19 Feb 2008 10:30:33 +0000 (10:30 +0000)]
 * Fixes NB#80965, focus the view button in the certificate confirmation dialog

pmo-trunk-r4194

13 years ago * Fixes NB#80952, added a missing colon, and fixed the new folder dialog title
Sergio Villar Senin [Tue, 19 Feb 2008 10:04:03 +0000 (10:04 +0000)]
 *  Fixes NB#80952, added a missing colon, and fixed the new folder dialog title

pmo-trunk-r4193

13 years ago * Fixes NB#80296, added semicolons removed by the translation
Sergio Villar Senin [Mon, 18 Feb 2008 17:06:39 +0000 (17:06 +0000)]
* Fixes NB#80296, added semicolons removed by the translation

pmo-trunk-r4192

13 years ago * Fixes NB#80895, show proper info banner when trying to delete messages
Sergio Villar Senin [Mon, 18 Feb 2008 15:18:15 +0000 (15:18 +0000)]
* Fixes NB#80895, show proper info banner when trying to delete messages

pmo-trunk-r4191

13 years ago * Fixes NB#80729, allow to save all the mime parts that are attachments from Modest POV
Sergio Villar Senin [Fri, 15 Feb 2008 17:25:31 +0000 (17:25 +0000)]
* Fixes NB#80729, allow to save all the mime parts that are attachments from Modest POV

pmo-trunk-r4190

13 years agoAdded a comment
Sergio Villar Senin [Fri, 15 Feb 2008 16:43:21 +0000 (16:43 +0000)]
Added a comment

pmo-trunk-r4189

13 years ago * Fixes NB#80791 place the buttons in their proper place in the unknown certificate...
Sergio Villar Senin [Fri, 15 Feb 2008 16:41:59 +0000 (16:41 +0000)]
* Fixes NB#80791 place the buttons in their proper place in the unknown certificate dialog (same positions as the browser)

pmo-trunk-r4188

13 years agocommiting the debian/changelog with week 08 fixes.
Vivek Sekar [Fri, 15 Feb 2008 14:00:49 +0000 (14:00 +0000)]
commiting the debian/changelog with week 08 fixes.

pmo-trunk-r4187

13 years ago * src/modest-text-utils.c:
Alberto Garcia [Fri, 15 Feb 2008 12:33:31 +0000 (12:33 +0000)]
* src/modest-text-utils.c:
(modest_text_utils_quote_plain_text):
Place signature before the original message
Fixes NB#80646

pmo-trunk-r4183

13 years ago * Fixes NB#79777, now it's possible to continuously delete msgs in viewer using...
Sergio Villar Senin [Fri, 15 Feb 2008 12:22:40 +0000 (12:22 +0000)]
* Fixes NB#79777, now it's possible to continuously delete msgs in viewer using the HW Backspace

pmo-trunk-r4182

13 years ago * Fixes NB#80391, do not show the "Saving" banner if the editor is closed and it...
Sergio Villar Senin [Fri, 15 Feb 2008 10:01:46 +0000 (10:01 +0000)]
* Fixes NB#80391, do not show the "Saving" banner if the editor is closed and it's the only window

pmo-trunk-r4180

13 years ago* src/maemo/modest-address-book.c:
Jose Dapena Paz [Fri, 15 Feb 2008 09:34:39 +0000 (09:34 +0000)]
* src/maemo/modest-address-book.c:
* We were storing the origin address after it was resolved in
  contacts. Fixes NB#80606.

pmo-trunk-r4179

13 years ago * Added some comments
Sergio Villar Senin [Thu, 14 Feb 2008 20:32:02 +0000 (20:32 +0000)]
 * Added some comments

pmo-trunk-r4178

13 years ago * Replaced modest_msg_edit_window_reset_modified by modest_msg_edit_window_se...
Sergio Villar Senin [Thu, 14 Feb 2008 12:36:53 +0000 (12:36 +0000)]
    * Replaced modest_msg_edit_window_reset_modified by modest_msg_edit_window_set_modified with a new boolean parametter
        * Added a new parametter to modest_ui_actions_compose_msg that instructs the method to set the edit window as modified or not
        * Opening a new editor from Contacts plugin and closing it without modifying it no longer shows the "Save message" dialog
        * Fixes NB#78911, set the edit window as modified when a new email is created from an external application

pmo-trunk-r4177

13 years ago * src/modest-mail-operation.c
Alberto Garcia [Thu, 14 Feb 2008 11:25:03 +0000 (11:25 +0000)]
* src/modest-mail-operation.c
(modest_mail_operation_cancel): All calls to this function
should be able to call tny_account_cancel()
Partially fixes NB#78460

pmo-trunk-r4176

13 years ago * Fixes a terrible mistake by my side that could cause SIGSEV's in some situations...
Sergio Villar Senin [Thu, 14 Feb 2008 09:12:28 +0000 (09:12 +0000)]
* Fixes a terrible mistake by my side that could cause SIGSEV's in some situations, I was incorrectly unref'ing the outbox folder
* Replaced a tny_folder_sync by the async version

pmo-trunk-r4175

13 years ago* updated NEWS for W08 (so far), made it org-mode compliant
Dirk-Jan C. Binnema [Wed, 13 Feb 2008 23:52:21 +0000 (23:52 +0000)]
* updated NEWS for W08 (so far), made it org-mode compliant

pmo-trunk-r4174

13 years ago* fix for a rare crash; fixes NB#80616.
Dirk-Jan C. Binnema [Wed, 13 Feb 2008 20:02:12 +0000 (20:02 +0000)]
* fix for a rare crash; fixes NB#80616.

it's debatable whether this bug was not  already fixed by the send-queue fixes done before; but as this crash was seen with W06, there *might* still be a problem.
so, fixing the symptom here. not sure what led to the crash, but it should not happen anymore.

pmo-trunk-r4173

13 years ago * src/modest-ui-actions.c:
Alberto Garcia [Wed, 13 Feb 2008 18:30:10 +0000 (18:30 +0000)]
* src/modest-ui-actions.c:
(modest_ui_actions_get_msgs_full_error_handler)
* src/widgets/modest-header-view.c:
(refresh_folder_error_handler)
Don't show an error message if the mail operation has been
cancelled, because that's not an error.

pmo-trunk-r4172

13 years ago * Fixes NB#80619, do not force the width of the accounts dialog in order not to...
Sergio Villar Senin [Wed, 13 Feb 2008 13:25:26 +0000 (13:25 +0000)]
* Fixes NB#80619, do not force the width of the accounts dialog in order not to truncate the column titles

pmo-trunk-r4171

13 years ago * Dramatically refactored the message transfers, now the same code is used for a...
Sergio Villar Senin [Wed, 13 Feb 2008 12:57:18 +0000 (12:57 +0000)]
* Dramatically refactored the message transfers, now the same code is used for a lot of cases (d&d is still pending)
* Fixes NB#78546, "connection canceled" is no longer shown after moving a message, now we consider all the cases that could take place in offline mode

pmo-trunk-r4170

13 years agoRevert fix for modest_text_utils_convert_buffer_to_html_start()
Alberto Garcia [Wed, 13 Feb 2008 12:32:10 +0000 (12:32 +0000)]
Revert fix for modest_text_utils_convert_buffer_to_html_start()
in r4166 and apply a more optimal one instead

pmo-trunk-r4169

13 years ago * Removed an unused method
Sergio Villar Senin [Tue, 12 Feb 2008 19:37:31 +0000 (19:37 +0000)]
* Removed an unused method
* Do not try to connect when transferring messages if they're already downloaded

pmo-trunk-r4168

13 years ago * Fixed a ARMEL compilation warning
Sergio Villar Senin [Tue, 12 Feb 2008 17:33:09 +0000 (17:33 +0000)]
* Fixed a ARMEL compilation warning
* Fixes NB#79816, show the proper message when trying to save an attachment and there is no space left on device

pmo-trunk-r4167

13 years agoFix a problem in modest_text_utils_convert_buffer_to_html_start()
Alberto Garcia [Tue, 12 Feb 2008 12:34:45 +0000 (12:34 +0000)]
Fix a problem in modest_text_utils_convert_buffer_to_html_start()
that might produce non-UTF8 output.
Partially fixes NB#80213

pmo-trunk-r4166

13 years ago * Fixes NB#80554, show the proper error message when deleting a sending message...
Sergio Villar Senin [Tue, 12 Feb 2008 10:25:09 +0000 (10:25 +0000)]
* Fixes NB#80554, show the proper error message when deleting a sending message even though we have a viewer opened with that message

pmo-trunk-r4165

13 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Tue, 12 Feb 2008 09:30:05 +0000 (09:30 +0000)]
* src/modest-ui-dimming-rules.c:
        * Now we check the active account of the message view or
          main window to dim purge if it's a pop account
          (fixes NB#80377).

pmo-trunk-r4164

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Mon, 11 Feb 2008 18:26:50 +0000 (18:26 +0000)]
* src/modest-ui-actions.c:
        * Added a forgotten return in on_delete_folder_cb, for the
          case we cancelled the attempt to connect (fixes NB#79872).

pmo-trunk-r4163

13 years ago * Do not run the alarm if the device is offline -> fix by earth saver djcb
Sergio Villar Senin [Mon, 11 Feb 2008 17:41:18 +0000 (17:41 +0000)]
* Do not run the alarm if the device is offline -> fix by earth saver djcb

pmo-trunk-r4162

13 years ago* src/widgets/modest-gtkhtml-msg-view.c:
Jose Dapena Paz [Mon, 11 Feb 2008 17:37:51 +0000 (17:37 +0000)]
* src/widgets/modest-gtkhtml-msg-view.c:
        * Add support for vertical panning in maemo. This way, panning
          vertically changes properly the vertical adjustment of the
          msg view (fixes NB#80484).

pmo-trunk-r4161

13 years ago * created a new method in modest-platform to make it easy to connect to two accounts
Sergio Villar Senin [Mon, 11 Feb 2008 17:27:35 +0000 (17:27 +0000)]
* created a new method in modest-platform to make it easy to connect to two accounts
* Fixes NB#80155, IMAP folders could be moved again to the MMC account

pmo-trunk-r4160

13 years agoDecode the mime part when copying it
Alberto Garcia [Mon, 11 Feb 2008 15:55:06 +0000 (15:55 +0000)]
Decode the mime part when copying it
Fixes NB#78802

pmo-trunk-r4159

13 years ago* src/widgets/modest-progress-bar.c:
Jose Dapena Paz [Mon, 11 Feb 2008 11:59:27 +0000 (11:59 +0000)]
* src/widgets/modest-progress-bar.c:
        * Show "receiving" string also for send/receive mail operation
          (fixes NB#79684).

pmo-trunk-r4158

13 years ago* src/maemo/modest-connection-specific-smtp-edit-window.c:
Jose Dapena Paz [Mon, 11 Feb 2008 11:13:03 +0000 (11:13 +0000)]
* src/maemo/modest-connection-specific-smtp-edit-window.c:
        * Now the dialog fields are inside a scrolled window, and then,
          vkb does not spoil the dialog layout (fixes NB#80471).

pmo-trunk-r4157

13 years agoAdded bug fixes for week 07, 11th Feb.
Vivek Sekar [Mon, 11 Feb 2008 09:09:37 +0000 (09:09 +0000)]
Added bug fixes for week 07, 11th Feb.

pmo-trunk-r4156

13 years agoChanges to disable cut/copy with images (fixes NB#80355).
Jose Dapena Paz [Mon, 11 Feb 2008 07:27:52 +0000 (07:27 +0000)]
Changes to disable cut/copy with images (fixes NB#80355).
* src/modest-text-utils.[ch], src/modest-ui-dimming-rules.c:
        * Refactored a method to check if a GtkTextBuffer has a valid
          cut/copy selection (currently it means it's not empty and does
          not contain images inside).
* src/modest-ui-actions.c:
        * Don't cut/copy if the selection is not valid.
* src/maemo/modest-msg-edit-window.c:
        * Disable default cut/copy handlers if no selection is valid.

pmo-trunk-r4155

13 years ago* add some extra error checking; fixes NB#80432
Dirk-Jan C. Binnema [Fri, 8 Feb 2008 20:41:15 +0000 (20:41 +0000)]
* add some extra error checking; fixes NB#80432

pmo-trunk-r4154

13 years agocorrected a typo, and bug was added to w06 tag.
Vivek Sekar [Fri, 8 Feb 2008 13:39:04 +0000 (13:39 +0000)]
corrected a typo, and bug was added to w06 tag.

pmo-trunk-r4152

13 years agoAdded week 07 bug fixes, and updated the NEWS file.
Vivek Sekar [Fri, 8 Feb 2008 13:34:59 +0000 (13:34 +0000)]
Added week 07 bug fixes, and updated the NEWS file.

pmo-trunk-r4150

13 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Fri, 8 Feb 2008 11:35:35 +0000 (11:35 +0000)]
* src/modest-ui-dimming-rules.c:
* Disable copying images (fixes NB#80355).

pmo-trunk-r4149

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Fri, 8 Feb 2008 10:53:51 +0000 (10:53 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now we properly scroll on find in page (fixes NB#80341).
        * Also fixed the algorithm to recalculate the new scroll
          position.

pmo-trunk-r4148

13 years ago* src/modest-tny-mime-part.[ch]:
Jose Dapena Paz [Fri, 8 Feb 2008 10:26:56 +0000 (10:26 +0000)]
* src/modest-tny-mime-part.[ch]:
        * New method to know if a TnyMsg instance is really a message
          or in fact it's a direct attachment.
* src/widgets/modest-attachments-view.c:
        * On setting a message, if it's an application
          multipart/related, show its contents as attachments (should
          help showing smil messages).
        * On setting a message, if the top mime part is a file, then
          show it as attachment.
* src/modest-tny-msg.c:
        * Modify code to detect body, to take into account the
          application multiparts (as smil) and direct attachments. These
          shouldn't show a body.
        * On creating forward messages, attach properly the direct
          attachments (we don't show any body for them).
* src/maemo/modest-msg-view-window.c:
        * Manage properly the application multiparts and top mime part
          attachments.
* src/modest-formatter.c:
        * Modify attach method to work if body is NULL.

pmo-trunk-r4147

13 years ago* use the correct toolbar icon for "Send"; fixes NB#80382
Dirk-Jan C. Binnema [Thu, 7 Feb 2008 22:18:04 +0000 (22:18 +0000)]
* use the correct toolbar icon for "Send"; fixes NB#80382

pmo-trunk-r4146

13 years agoTreat a message as modified if the From: field changes
Alberto Garcia [Thu, 7 Feb 2008 10:40:59 +0000 (10:40 +0000)]
Treat a message as modified if the From: field changes
Fixes NB#80271

pmo-trunk-r4145

13 years agoWhen opening an e-mail from the Drafts folder, maintain the
Alberto Garcia [Wed, 6 Feb 2008 19:33:39 +0000 (19:33 +0000)]
When opening an e-mail from the Drafts folder, maintain the
same From: address
Partially fixes NB#80271

pmo-trunk-r4144

13 years agoIf, after moving or deleting a message from the message viewer, no
Alberto Garcia [Wed, 6 Feb 2008 16:41:14 +0000 (16:41 +0000)]
If, after moving or deleting a message from the message viewer, no
other message can be selected then close the viewer
Fixes NB#80276

pmo-trunk-r4143

13 years agoRemoved obsolete comments now that Modest works with maemo launcher
Alberto Garcia [Wed, 6 Feb 2008 15:38:49 +0000 (15:38 +0000)]
Removed obsolete comments now that Modest works with maemo launcher

pmo-trunk-r4142

13 years agoAdded maemo-launcher-dev to the Build-Depends, since maemo-launcher has been enabled.
Vivek Sekar [Wed, 6 Feb 2008 15:30:41 +0000 (15:30 +0000)]
Added maemo-launcher-dev to the Build-Depends, since maemo-launcher has been enabled.

pmo-trunk-r4141

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Wed, 6 Feb 2008 13:29:10 +0000 (13:29 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Reviewed reference counting of tree row reference. There
          were some cases we were leaking this (fixes NB#78857).

pmo-trunk-r4140

13 years ago* include the domain name in the list of providers, so users can distinguish between...
Dirk-Jan C. Binnema [Wed, 6 Feb 2008 07:44:43 +0000 (07:44 +0000)]
* include the domain name in the list of providers, so users can distinguish between "AOL (aol.com)" and "AOL (aol.fr)".

Fixes: NB#79501

pmo-trunk-r4139

13 years ago* debian/rules:
Jose Dapena Paz [Tue, 5 Feb 2008 12:58:48 +0000 (12:58 +0000)]
* debian/rules:
* Reenable maemo launcher (fixes NB#79471).
* Also respect debug DEB_BUILD_OPTIONS parameter.

pmo-trunk-r4138

13 years ago* src/modest-tny-account-store.c:
Jose Dapena Paz [Tue, 5 Feb 2008 12:57:03 +0000 (12:57 +0000)]
* src/modest-tny-account-store.c:
* Shutdown camel on finishing account store. This is done to
  store the certdb on disk.

pmo-trunk-r4137

13 years ago* if called at the wrong time, tny_send_queue_get_outbox may return NULL;
Dirk-Jan C. Binnema [Tue, 5 Feb 2008 08:20:42 +0000 (08:20 +0000)]
* if called at the wrong time, tny_send_queue_get_outbox may return NULL;
  check for this, fixes a crash (NB#80225)

pmo-trunk-r4136

13 years ago* fix some coverity warnings (bug NB#80246, the modest part)
Dirk-Jan C. Binnema [Tue, 5 Feb 2008 07:50:41 +0000 (07:50 +0000)]
* fix some coverity warnings (bug NB#80246, the modest part)

pmo-trunk-r4135

13 years ago* src/modest-text-utils.[ch]:
Jose Dapena Paz [Mon, 4 Feb 2008 09:41:25 +0000 (09:41 +0000)]
* src/modest-text-utils.[ch]:
        * Refactorized method to get the current selection of a label in
          text utils. This will be now used in ui actions and dimming
          rules.
* src/modest-ui-actions.c:
        * (modest_ui_actions_on_copy): now copy gets the selection of
          a focused label, instead of the full label (fixes NB#80195).
        * (folder_move_to_cb): now we focus the new position of a folder
          after a move to operation to avoid losing focus (fixes
          NB#78939).
* src/modest-ui-dimming-rules.c:
        * (..._on_add_to_contacts): now we use the text utils method
          to retrieve current selection of a GtkLabel.

pmo-trunk-r4134

13 years agoAdded tny_mime_part_set_transfer_encoding usage when forwarding
Philip Van Hoof [Sun, 3 Feb 2008 11:21:20 +0000 (11:21 +0000)]
Added tny_mime_part_set_transfer_encoding usage when forwarding

pmo-trunk-r4133

13 years agoAdded tny_mime_part_set_transfer_encoding usage when forwarding
Philip Van Hoof [Sun, 3 Feb 2008 11:16:26 +0000 (11:16 +0000)]
Added tny_mime_part_set_transfer_encoding usage when forwarding

pmo-trunk-r4132

13 years ago* in some weird cases, the msg-id and/or the 'item' might be NULL.
Dirk-Jan C. Binnema [Fri, 1 Feb 2008 20:16:56 +0000 (20:16 +0000)]
* in some weird cases, the msg-id and/or the 'item' might be NULL.
  handle that case (fixes a crash, NB#80177)

pmo-trunk-r4131

13 years agoRemove (harmless) GLIB CRITICAL
Alberto Garcia [Fri, 1 Feb 2008 17:25:53 +0000 (17:25 +0000)]
Remove (harmless) GLIB CRITICAL

pmo-trunk-r4130

13 years agoAdded bugs fixed and functional requirements implemented for week 06 release.
Vivek Sekar [Fri, 1 Feb 2008 13:03:35 +0000 (13:03 +0000)]
Added bugs fixed and functional requirements implemented for week 06 release.

pmo-trunk-r4128