modest
13 years ago* sort the providers (almost) correctly,
Dirk-Jan C. Binnema [Tue, 6 Nov 2007 15:16:39 +0000 (15:16 +0000)]
* sort the providers (almost) correctly,
  fixes NB#75213

pmo-trunk-r3654

13 years agoPut the subject of the message on the editor window
Alberto Garcia [Tue, 6 Nov 2007 15:13:26 +0000 (15:13 +0000)]
Put the subject of the message on the editor window
Fixes NB#75081

pmo-trunk-r3653

13 years ago * Added "queue-empty" signal to the mail operation queue
Sergio Villar Senin [Tue, 6 Nov 2007 10:16:38 +0000 (10:16 +0000)]
* Added "queue-empty" signal to the mail operation queue
* Added "window-list-empty" signal to the window manager
* Moved the code that closes modest to modest-main.c
* Now modest is closed when there are no more windows and there are no more pending mail operations
* Now Modest is properly finalized when a D-Bus action is performed, event if there is no main window
* Fixes NB#74402, Modest is now closed if compose mail is invoked through D-Bus

pmo-trunk-r3652

13 years agoAllow creation of folders under the MMC root folder
Alberto Garcia [Tue, 6 Nov 2007 08:49:33 +0000 (08:49 +0000)]
Allow creation of folders under the MMC root folder
from the "Move to" dialog.
Fixes NB#75279

pmo-trunk-r3651

13 years agoMove messages from the viewer if the source folder is local
Alberto Garcia [Mon, 5 Nov 2007 17:21:15 +0000 (17:21 +0000)]
Move messages from the viewer if the source folder is local
Fixes NB#74626

pmo-trunk-r3650

13 years ago* prevent possible NULL dereference, add parameter check
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 15:21:54 +0000 (15:21 +0000)]
* prevent possible NULL dereference, add parameter check

pmo-trunk-r3649

13 years ago* some extra error handling to prevent NULL dereferences
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 14:53:12 +0000 (14:53 +0000)]
* some extra error handling to prevent NULL dereferences

pmo-trunk-r3648

13 years agofix possible NULL dereference
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 14:37:17 +0000 (14:37 +0000)]
fix possible NULL dereference

pmo-trunk-r3647

13 years ago* fix the use of an local variable outside its scope in
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 14:27:09 +0000 (14:27 +0000)]
* fix the use of an local variable outside its scope in
modest_msg_edit_window_select_background_color
  + some cleanups

are we actually using the select_background_color still?

pmo-trunk-r3646

13 years ago* check to prevent NULL-dereference (headers)
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 13:25:29 +0000 (13:25 +0000)]
* check to prevent NULL-dereference (headers)

pmo-trunk-r3645

13 years ago * Always notify the queue that the operation finished, otherwise it won't be removed
Sergio Villar Senin [Mon, 5 Nov 2007 13:01:54 +0000 (13:01 +0000)]
* Always notify the queue that the operation finished, otherwise it won't be removed

pmo-trunk-r3644

13 years ago* fix some potential NULL-dereferences
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 12:45:42 +0000 (12:45 +0000)]
* fix some potential NULL-dereferences

pmo-trunk-r3643

13 years ago* Fix the condition that tests whether to use the dummy address book
Alberto Garcia [Mon, 5 Nov 2007 12:18:30 +0000 (12:18 +0000)]
* Fix the condition that tests whether to use the dummy address book
Fixes NB#75187

pmo-trunk-r3641

13 years ago * Added some code, that allows the folder view to unref its reference to the selecte...
Sergio Villar Senin [Mon, 5 Nov 2007 12:03:32 +0000 (12:03 +0000)]
* Added some code, that allows the folder view to unref its reference to the selected folder before trying to move it using the move to dialog. The problem was that the handler of unselect_all was not happening before the mail operation

pmo-trunk-r3639

13 years ago * Fixes NB#74764, NB#74260, NB#74639
Sergio Villar Senin [Mon, 5 Nov 2007 11:04:29 +0000 (11:04 +0000)]
* Fixes NB#74764, NB#74260, NB#74639
* Removed an invalid set_transient_for that was provoking weird behaviours, like menus not shown, dialogs shown in the background, etc

pmo-trunk-r3635

13 years ago* GETTEXT_PACKAGE: osso-email=>modest
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 10:52:38 +0000 (10:52 +0000)]
* GETTEXT_PACKAGE: osso-email=>modest

pmo-trunk-r3634

13 years agoPerformance improvement for icon_cell_data
Philip Van Hoof [Mon, 5 Nov 2007 10:33:55 +0000 (10:33 +0000)]
Performance improvement for icon_cell_data

pmo-trunk-r3632

13 years ago* modest-tny-msg.c:
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 10:32:42 +0000 (10:32 +0000)]
* modest-tny-msg.c:
- fix leak when searching through multipart/ messages
  (modest_tny_msg_find_body_part_from_mime_part)
* modest-account-mgr.c:
- fix possible NULL dereference
* modest-ui-actions.c:
- remove some dead code
- fix possible NULL dereference
* modest-platform.c:
- small cleanup

pmo-trunk-r3631

13 years ago* check return values of gtk_tree_selection_get_selected and
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 09:02:23 +0000 (09:02 +0000)]
* check return values of gtk_tree_selection_get_selected and
gtk_tree_model_get_iter_first

pmo-trunk-r3630

13 years ago* check return value of alarm_event_del
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 08:46:57 +0000 (08:46 +0000)]
* check return value of alarm_event_del

pmo-trunk-r3629

13 years ago* check return value of hildon_uri_open, small cleanups
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 08:31:53 +0000 (08:31 +0000)]
* check return value of hildon_uri_open, small cleanups

pmo-trunk-r3628

13 years ago* remove obsolete files
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 08:07:43 +0000 (08:07 +0000)]
* remove obsolete files

pmo-trunk-r3627

13 years ago* save attachments with 0444 instead of 0777.
Dirk-Jan C. Binnema [Fri, 2 Nov 2007 14:55:58 +0000 (14:55 +0000)]
* save attachments with 0444 instead of 0777.
This fixes: NB#75099

pmo-trunk-r3626

13 years agoreverted back to using microb-engine-nss
Vivek Sekar [Fri, 2 Nov 2007 14:53:17 +0000 (14:53 +0000)]
reverted back to using microb-engine-nss

pmo-trunk-r3625

13 years ago* add help context id's for all dialogs
Dirk-Jan C. Binnema [Fri, 2 Nov 2007 14:22:17 +0000 (14:22 +0000)]
* add help context id's for all dialogs
* turned content-specific-smtp-window into a GtkDialog
  (instead of a GtkWindow), otherwise the help won't work.

This fixes NB#74670 (but we're still missing the actual help contents)

pmo-trunk-r3624

13 years ago* maintain the osso_context_t ptr in modest_maemo_utils,
Dirk-Jan C. Binnema [Fri, 2 Nov 2007 14:19:32 +0000 (14:19 +0000)]
* maintain the osso_context_t ptr in modest_maemo_utils,
  a global + accessors
* do a proper osso_deinitialize before exiting modest
* some small fixes / cleanups

pmo-trunk-r3623

13 years agoremoved the maemo-launcher option.
Vivek Sekar [Fri, 2 Nov 2007 13:14:18 +0000 (13:14 +0000)]
removed the maemo-launcher option.

pmo-trunk-r3622

13 years agoadded bug fixes for week 45 pre release.
Vivek Sekar [Fri, 2 Nov 2007 12:21:27 +0000 (12:21 +0000)]
added bug fixes for week 45 pre release.

pmo-trunk-r3618

13 years ago* some further cleanups of the help system, added:
Dirk-Jan C. Binnema [Fri, 2 Nov 2007 11:28:26 +0000 (11:28 +0000)]
* some further cleanups of the help system, added:
modest_window_mgr_register_help_id, and
modest_window_mgr_get_help_id
  which will give you the right help_id for the
  current window; windows register the help id in their
  _init. For the main window, we check what the
  selected folder is, and use modest_tny_folder_get_help_id
  to get the help_id from there.

pmo-trunk-r3617

13 years agoremoved microb-engine-nss dependecy from configure.ac and debian/control file.
Vivek Sekar [Fri, 2 Nov 2007 11:13:54 +0000 (11:13 +0000)]
removed microb-engine-nss dependecy from configure.ac and debian/control file.

pmo-trunk-r3616

13 years ago* cleanup: added modest_tny_folder_get_help_id, and let modest-ui-actions use that
Dirk-Jan C. Binnema [Fri, 2 Nov 2007 10:35:55 +0000 (10:35 +0000)]
* cleanup: added modest_tny_folder_get_help_id, and let modest-ui-actions use that

pmo-trunk-r3615

13 years ago* make dragging of headers to folders work again
Dirk-Jan C. Binnema [Thu, 1 Nov 2007 17:32:37 +0000 (17:32 +0000)]
* make dragging of headers to folders work again

pmo-trunk-r3614

13 years ago* make libalarm an optional (no longer required) dependency for maemo
Dirk-Jan C. Binnema [Thu, 1 Nov 2007 16:52:16 +0000 (16:52 +0000)]
* make libalarm an optional (no longer required) dependency for maemo

pmo-trunk-r3613

13 years ago* warn when some weird folder rename error occurs that pvanhoof encountered
Dirk-Jan C. Binnema [Thu, 1 Nov 2007 15:59:32 +0000 (15:59 +0000)]
* warn when some weird folder rename error occurs that pvanhoof encountered

pmo-trunk-r3612

13 years ago* make modest_text_utils_get_display_date return a ptr to
Dirk-Jan C. Binnema [Thu, 1 Nov 2007 15:58:51 +0000 (15:58 +0000)]
* make modest_text_utils_get_display_date return a ptr to
  as static gchar[]; the saves us a g_strdup / free for
  each of the display_date (esp. in renderer this counts)

Note: it's *not* re-entrent/thread safe anymore, but that
  should not matter, as we're only using it in the UI

pmo-trunk-r3611

13 years agoremoved microb-engine-dev and added libnss3-dev
Vivek Sekar [Thu, 1 Nov 2007 08:18:15 +0000 (08:18 +0000)]
removed microb-engine-dev and added libnss3-dev

pmo-trunk-r3610

13 years agoAdded bug fixes, and microb-engine to control file.
Vivek Sekar [Thu, 1 Nov 2007 08:10:40 +0000 (08:10 +0000)]
Added bug fixes, and microb-engine to control file.

pmo-trunk-r3609

13 years agotny_header_{set,unset}_flags() renamed to tny_header_{set,unset}_flag()
Alberto Garcia [Wed, 31 Oct 2007 15:02:10 +0000 (15:02 +0000)]
tny_header_{set,unset}_flags() renamed to tny_header_{set,unset}_flag()

pmo-trunk-r3608

13 years agoFix for bug NB#74675. Now we limit the retrieval size for texts shown,
Jose Dapena Paz [Wed, 31 Oct 2007 13:11:38 +0000 (13:11 +0000)]
Fix for bug NB#74675. Now we limit the retrieval size for texts shown,
and make the load much more efficient.
* src/modest-text-utils.[ch]:
        * Now convert_to_html_body method accepts two new parameters,
          one to enable disable linkify and other for processing char
          buffers with a size limit.
        * Now we provide the methods modest_text_utils_linkify_begin
          and modest_text_utils_linkify_end, to cache the regex patterns
          in processing of a big set of strings.
* src/widgets/modest-gtkhtml-mime-part-view.c:
        * Now we use the new ModestStreamTextToHtml decorator for
          gtkhtml stream instead of a big hack we did before to
          convert the text to html and send it to the gtkhtml widget.
        * Now we set the maximum size of text with hyperlinkify (64KB)
          and a maximum size of the text document to show (640KB).
* src/modest-stream-text-to-html.[ch], src/Makefile.am:
        * New stream implementation that proxies a write stream. With
          this all text written to this stream is converted to html and
          sent to the decorated stream.

pmo-trunk-r3607

13 years ago* this is dirk's version of sergio's patch to only create
Dirk-Jan C. Binnema [Wed, 31 Oct 2007 10:50:09 +0000 (10:50 +0000)]
* this is dirk's version of sergio's patch to only create
  main-windows when we really need to.

it adds a boolean 'create' parameter to modest_window_mgr_get_main_window,
  and only if this parameter is TRUE will this function create a main_window
  if it was not yet existing.

  also, patch makes warning dialogs not show up if there is no main window,
  including password, cert verification dialogs. thus, the user will not be
  annoyed unexpectedly anymore.

pmo-trunk-r3606

13 years ago* don't accept certificate when user clicked cancel
Dirk-Jan C. Binnema [Tue, 30 Oct 2007 13:30:05 +0000 (13:30 +0000)]
* don't accept certificate when user clicked cancel

pmo-trunk-r3604

13 years agospelling: s/conformation/confirmation
Dirk-Jan C. Binnema [Tue, 30 Oct 2007 12:13:51 +0000 (12:13 +0000)]
spelling: s/conformation/confirmation

pmo-trunk-r3602

13 years ago* fix for the crash in NB#74605
Dirk-Jan C. Binnema [Tue, 30 Oct 2007 11:49:38 +0000 (11:49 +0000)]
* fix for the crash in NB#74605
* code cleanup

pmo-trunk-r3601

13 years ago* src/modest-account-mgr-helpers.c:
Jose Dapena Paz [Tue, 30 Oct 2007 11:10:49 +0000 (11:10 +0000)]
* src/modest-account-mgr-helpers.c:
        * On removing a smtp connection account, we shouldn't spoil
          the list of accounts.
* src/maemo/modest-connection-specific-smtp-window.c:
        * Now we can remove accounts simply removing the hostname of the
          server (fixes NB#65559).
* src/maemo/modest-connection-specific-smtp-edit-window.c:
        * Now we accept empty hostnames as valid, so that we can remove
          accounts.

pmo-trunk-r3600

13 years ago* do some parameter checks for is_busy / set_busy,
Dirk-Jan C. Binnema [Tue, 30 Oct 2007 10:56:04 +0000 (10:56 +0000)]
* do some parameter checks for is_busy / set_busy,
  and code style cleanup

pmo-trunk-r3599

13 years ago* check for invalid folders in many places
Dirk-Jan C. Binnema [Mon, 29 Oct 2007 14:06:11 +0000 (14:06 +0000)]
* check for invalid folders in many places
* add TNY_FOLDER_TYPE_INVALID (todo: move this to tinymail)
* add the check when moving messages to folders (this fixes
  a crasher)

Fixes: NB#74469

pmo-trunk-r3597

13 years agofixes NB#66958
Felipe Erias Morandeira [Mon, 29 Oct 2007 12:04:28 +0000 (12:04 +0000)]
fixes NB#66958

pmo-trunk-r3596

13 years agoPriority flags changes.
Jose Dapena Paz [Mon, 29 Oct 2007 10:27:50 +0000 (10:27 +0000)]
Priority flags changes.
* src/widgets/modest-gtkhtml-msg-view.c:
        * Remove all internal priority mask to delefate on headers view.
* src/widgets/modest-header-view.c:
        * Replace old priority comparison code to be proper for the
          priority flags after last changes in tinymail.
* src/widgets/modest-header-view-render.c:
        * If we try to get the pixbuf for 0, we get NULL pixbuf.
        * Update the priority flags management showing priority pixbufs.
* src/widgets/modest-mail-header-view.c:
        * Use new priority flags in tinymail.
* src/widgets/modest-mozembed-msg-view.c:
        * Use mail header view priorities instead of storing a local
          copy of priorities.
* src/maemo/modest-msg-edit-window.c:
        * Use new priority flags api from tinymail.
* src/maemo/modest-platform.c:
        * Use new priority flags api from tinymail.
* src/modest-tny-send-queue.c:
        * Use the new priority/suspended flags api. Now we don't unset
          the flags if message send failed.

Mozembed changes:
* src/widgets/modest-mozembed-msg-view.c:
        * Use scroll area (pending on changes in gtkmozembed to be
          scrollable).
* src/widgets/modest-mozembed-mime-part-view.c:
        * Implementation of ModestISearchView interface for incremental
          search.
* src/maemo/modest-msg-view-window.c:
        * More integration with mozembed (adaptation for future
          scrollable gtkmozembed widget).

pmo-trunk-r3595

13 years agoremove garbage in function comment
Dirk-Jan C. Binnema [Fri, 26 Oct 2007 15:19:22 +0000 (15:19 +0000)]
remove garbage in function comment

pmo-trunk-r3594

13 years ago* add support for special port numbers; this fixes the
Dirk-Jan C. Binnema [Fri, 26 Oct 2007 15:12:09 +0000 (15:12 +0000)]
* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts

pmo-trunk-r3593

13 years ago* forgot these (see r3591)
Dirk-Jan C. Binnema [Fri, 26 Oct 2007 14:11:25 +0000 (14:11 +0000)]
* forgot these (see r3591)

pmo-trunk-r3592

13 years ago* make osso-addressbook (libosso-abook-dev) optional; if it's
Dirk-Jan C. Binnema [Fri, 26 Oct 2007 14:06:34 +0000 (14:06 +0000)]
* make osso-addressbook (libosso-abook-dev) optional; if it's
  not there, we'll use modest-address-book-dummy.c

pmo-trunk-r3591

13 years agoweek 44 bugs added.
Vivek Sekar [Fri, 26 Oct 2007 12:42:35 +0000 (12:42 +0000)]
week 44 bugs added.

pmo-trunk-r3587

13 years ago * Some improvements for the connect_and_wait, there is no need to disconnect the...
Sergio Villar Senin [Fri, 26 Oct 2007 08:41:13 +0000 (08:41 +0000)]
* Some improvements for the connect_and_wait, there is no need to disconnect the signal when we've called tny_camel_account_set_online

pmo-trunk-r3582

13 years ago * Fixed a very stupid mistake by myself in the connect_and_wait function. It could...
Sergio Villar Senin [Thu, 25 Oct 2007 17:50:27 +0000 (17:50 +0000)]
* Fixed a very stupid mistake by myself in the connect_and_wait function. It could cause a SIGSEV and was not taking into account the case where the device was online and the account was not and was not reconnecting as well.

pmo-trunk-r3581

13 years agoFixed typo
Alberto Garcia [Thu, 25 Oct 2007 17:49:12 +0000 (17:49 +0000)]
Fixed typo

pmo-trunk-r3580

13 years ago* modest-tny-account-store:
Alberto Garcia [Thu, 25 Oct 2007 17:22:47 +0000 (17:22 +0000)]
* modest-tny-account-store:
  (modest_tny_account_store_get_transport_account_from_outbox_header)
  New function to obtain the transport account from a message in the
  outbox

* modest-ui-actions:
  (open_msg_cb)
  Open Failed messages in the outbox with the editor and not with the
  viewer.

Fixes NB#74147

pmo-trunk-r3579

13 years ago* only set auto-update alarms when there are accounts;
Dirk-Jan C. Binnema [Thu, 25 Oct 2007 15:42:12 +0000 (15:42 +0000)]
* only set auto-update alarms when there are accounts;
  also check with account addition/deletion.

Fixes: NB#64945

pmo-trunk-r3578

13 years ago * Removed a public method
Sergio Villar Senin [Thu, 25 Oct 2007 11:42:51 +0000 (11:42 +0000)]
* Removed a public method

pmo-trunk-r3577

13 years ago * Reimplementation of the connect_and_wait function
Sergio Villar Senin [Thu, 25 Oct 2007 10:22:14 +0000 (10:22 +0000)]
* Reimplementation of the connect_and_wait function
* Fixes NB#66769

pmo-trunk-r3576

13 years ago * Fixes NB#74180, the New folder, Rename and Delete options of the folder CSM are...
Sergio Villar Senin [Wed, 24 Oct 2007 17:03:06 +0000 (17:03 +0000)]
* Fixes NB#74180, the New folder, Rename and Delete options of the folder CSM are dimmed when in transfer mode

pmo-trunk-r3574

13 years agoUse the constant name (TNY_HEADER_FLAG_NORMAL_PRIORITY) and
Alberto Garcia [Wed, 24 Oct 2007 15:21:27 +0000 (15:21 +0000)]
Use the constant name (TNY_HEADER_FLAG_NORMAL_PRIORITY) and
not its value (0) to check the priority of a message.

pmo-trunk-r3573

13 years ago * Fixes NB#74182, the paste option is removed from the csm
Sergio Villar Senin [Wed, 24 Oct 2007 15:03:52 +0000 (15:03 +0000)]
* Fixes NB#74182, the paste option is removed from the csm

pmo-trunk-r3572

13 years ago* fix for NB#74144 (modest thinks foo/drafts is Drafts)
Dirk-Jan C. Binnema [Wed, 24 Oct 2007 12:01:50 +0000 (12:01 +0000)]
* fix for NB#74144 (modest thinks foo/drafts is Drafts)
  - made the check more precise, ie. compare the full path, not just the name
  - cleaned up the code and its callers

pmo-trunk-r3569

13 years agofixes NB#74061
Felipe Erias Morandeira [Wed, 24 Oct 2007 09:06:25 +0000 (09:06 +0000)]
fixes NB#74061

pmo-trunk-r3567

13 years ago * Fixed a typo
Sergio Villar Senin [Wed, 24 Oct 2007 08:03:02 +0000 (08:03 +0000)]
* Fixed a typo

pmo-trunk-r3566

13 years ago * Restored some code deleted by error
Sergio Villar Senin [Wed, 24 Oct 2007 07:58:36 +0000 (07:58 +0000)]
* Restored some code deleted by error

pmo-trunk-r3565

13 years ago* remove package dependency of libmodest-dbus-client on modest
Dirk-Jan C. Binnema [Wed, 24 Oct 2007 07:50:20 +0000 (07:50 +0000)]
* remove package dependency of libmodest-dbus-client on modest

pmo-trunk-r3564

13 years agopatch for NB#73896
Felipe Erias Morandeira [Tue, 23 Oct 2007 16:37:58 +0000 (16:37 +0000)]
patch for NB#73896

pmo-trunk-r3563

13 years agoShow all accounts in the "Move To" dialog, not just the active one
Alberto Garcia [Tue, 23 Oct 2007 15:51:59 +0000 (15:51 +0000)]
Show all accounts in the "Move To" dialog, not just the active one

pmo-trunk-r3562

13 years ago * Removed an invalid indirection of a function call as Philip correctly suggested
Sergio Villar Senin [Tue, 23 Oct 2007 11:59:54 +0000 (11:59 +0000)]
* Removed an invalid indirection of a function call as Philip correctly suggested

pmo-trunk-r3561

13 years ago * The viewer handler could not exist if the viewer window was created without a...
Sergio Villar Senin [Tue, 23 Oct 2007 11:06:16 +0000 (11:06 +0000)]
* The viewer handler could not exist if the viewer window was created without a main window present (for example when opening a message through D-Bus)

pmo-trunk-r3560

13 years ago* use _CS to get translation from right domain, fixes #NB74006
Dirk-Jan C. Binnema [Tue, 23 Oct 2007 10:02:10 +0000 (10:02 +0000)]
* use _CS to get translation from right domain, fixes #NB74006

pmo-trunk-r3559

13 years agoFix DBUS mailto: test
Alberto Garcia [Tue, 23 Oct 2007 09:19:56 +0000 (09:19 +0000)]
Fix DBUS mailto: test

pmo-trunk-r3558

13 years ago * Fixed an invalid g_object_ref/unref
Sergio Villar Senin [Tue, 23 Oct 2007 06:35:59 +0000 (06:35 +0000)]
* Fixed an invalid g_object_ref/unref
* Added a refilter whenever an account is added/removed/modified in the folder view widget (following a Philip's comment)

pmo-trunk-r3557

13 years ago* Offer the account creation in the MailTo DBUS handler
Alberto Garcia [Mon, 22 Oct 2007 15:33:51 +0000 (15:33 +0000)]
* Offer the account creation in the MailTo DBUS handler
* Fixed memory leaks

pmo-trunk-r3556

13 years agoSimplified the MailTo DBUS handler
Alberto Garcia [Mon, 22 Oct 2007 15:02:50 +0000 (15:02 +0000)]
Simplified the MailTo DBUS handler

pmo-trunk-r3555

13 years agoMore refactoring of the ComposeMail DBUS handler, now everything
Alberto Garcia [Mon, 22 Oct 2007 14:56:42 +0000 (14:56 +0000)]
More refactoring of the ComposeMail DBUS handler, now everything
is done in modest-ui-actions

pmo-trunk-r3554

13 years agoRefactored the code of modest_ui_actions_on_new_msg() and
Alberto Garcia [Mon, 22 Oct 2007 14:22:21 +0000 (14:22 +0000)]
Refactored the code of modest_ui_actions_on_new_msg() and
the ComposeMessage DBUS handler

pmo-trunk-r3553

13 years ago * Fixes NB#65926, do not show Junk numbers (actually bytes transferred) when moving...
Sergio Villar Senin [Mon, 22 Oct 2007 07:42:27 +0000 (07:42 +0000)]
* Fixes NB#65926, do not show Junk numbers (actually bytes transferred) when moving messages. Now we show "Receiving x of y and the progress bar shows the amount of bytes transferred
* Removed some commented code

pmo-trunk-r3544

13 years ago * Do not modify the header view contents style when new messages are received
Sergio Villar Senin [Fri, 19 Oct 2007 17:06:33 +0000 (17:06 +0000)]
* Do not modify the header view contents style when new messages are received

pmo-trunk-r3543

13 years ago * Remove some invalid code from the D-Bus callback, the refresh of the curren...
Sergio Villar Senin [Fri, 19 Oct 2007 16:51:22 +0000 (16:51 +0000)]
    * Remove some invalid code from the D-Bus callback, the refresh of the current folder was automatically done by the ui acti
on
        * Do not refresh the current folder when send&receive unless we're viewing any window
        * Reverted a method to static

pmo-trunk-r3542

13 years ago * Added a dbus test that updates (Send&Receive) the default account
Sergio Villar Senin [Fri, 19 Oct 2007 16:37:27 +0000 (16:37 +0000)]
* Added a dbus test that updates (Send&Receive) the default account

pmo-trunk-r3541

13 years agoSimplified the mailto uri parser
Alberto Garcia [Fri, 19 Oct 2007 16:04:54 +0000 (16:04 +0000)]
Simplified the mailto uri parser

pmo-trunk-r3540

13 years ago* Removed unused struct SendMailIdleData
Alberto Garcia [Fri, 19 Oct 2007 14:58:43 +0000 (14:58 +0000)]
* Removed unused struct SendMailIdleData
* Reworked a bit the code of uri_parse_mailto()

pmo-trunk-r3539

13 years agoIn mailto: urls parameters after the first one are separated by '&',
Alberto Garcia [Fri, 19 Oct 2007 14:06:14 +0000 (14:06 +0000)]
In mailto: urls parameters after the first one are separated by '&',
not by '?'

pmo-trunk-r3538

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Fri, 19 Oct 2007 12:49:42 +0000 (12:49 +0000)]
* src/modest-ui-actions.c:
        * Now, for saving or sending messages, we use the from part of
          the message information in editor (fixes NB#65189).
        * We also don't ignore the from in the message in drafts folder
          when opening an editor from it.

pmo-trunk-r3537

13 years agoSimplified the code of the dbus 'mailto:' handler, to remove redundant
Alberto Garcia [Fri, 19 Oct 2007 12:42:25 +0000 (12:42 +0000)]
Simplified the code of the dbus 'mailto:' handler, to remove redundant
code and reuse the handler written for the "Compose" action.

Fixed usage of 'mailto:' parameters (they were not being actually
used).

pmo-trunk-r3536

13 years agoadded bugs fixed for week 43.
Vivek Sekar [Fri, 19 Oct 2007 12:19:09 +0000 (12:19 +0000)]
added bugs fixed for week 43.

pmo-trunk-r3534

13 years agoWork to make attachments be opened in a single instance (raise window
Jose Dapena Paz [Fri, 19 Oct 2007 09:10:40 +0000 (09:10 +0000)]
Work to make attachments be opened in a single instance (raise window
if they're already openened) (fixes NB#65279).
* src/widgets/modest-window-mgr.[ch]:
        * Now modest_window_mgr_register_header accepts an alt_uid
          parameter in case the header does not provide an uid.
* src/maemo/modest-msg-view-window.c:
        * Now we pass a hash base to the create_temp_stream method used
          to create a temporary file to view an attachment. This hash
          is used to open always the file in the same directory.
        * Now the attachment messages are opened passing a "attachment
          id" that works similar to a message id. This identifies the
          message in the window manager properly.
* src/modest-ui-actions.c, src/dbus_api/modest-dbus-callbacs.c:
        * Use new modest_window_mgr_register_header call.
* src/maemo/modest-maemo-utils.[ch]:
        * Now ..._create_temp_stream accepts an additional parameter
          hash_base. This hash_base is used to generate the "random"
          directory the temporary file is created. This is used to
          force files created from attachments get the same path.

pmo-trunk-r3529

13 years agoRemoved unused variable
Alberto Garcia [Thu, 18 Oct 2007 12:42:59 +0000 (12:42 +0000)]
Removed unused variable

pmo-trunk-r3528

13 years ago* src/dbus_api/modest-dbus-callbacks.c:
Jose Dapena Paz [Thu, 18 Oct 2007 10:20:25 +0000 (10:20 +0000)]
* src/dbus_api/modest-dbus-callbacks.c:
* Now get_folders method also obtains folders from mmc
  (fixes NB#65058).
* src/modest-tny-account-store.[ch]:
* Added new method to obtain the mmc account.

pmo-trunk-r3527

13 years agoAdded fixed bugs for week 42 release.
Vivek Sekar [Wed, 17 Oct 2007 11:54:27 +0000 (11:54 +0000)]
Added fixed bugs for week 42 release.

pmo-trunk-r3524

13 years agoCheck properly the contents of the clipboard before
Alberto Garcia [Wed, 17 Oct 2007 11:38:46 +0000 (11:38 +0000)]
Check properly the contents of the clipboard before
deciding whether to dim the "Paste" menu option
Fixes NB#73404

pmo-trunk-r3523

13 years agoThis commit includes a complete refactor of ModestMsgView. Now
Jose Dapena Paz [Wed, 17 Oct 2007 11:19:37 +0000 (11:19 +0000)]
This commit includes a complete refactor of ModestMsgView. Now
ModestMsgView is an interface, and we have ModestGtkhtmlMsgView and
ModestMozembedMsgView.
* src/modest-tny-platform-factory.c:
        * Get ModestMozembedMsgView from factory, if enabled.
* src/modest-msg-view.[ch]:
        * Now this is an interface. ModestGtkhtmlMsgView and
          ModestMozembedMsgView implement this interface. This
          way we make easier to use one or another implementation.
* Added src/widgets/modest-gtkhtml-msg-view.[ch]:
        * ModestGtkhtmlMsgView contains the old ModestMsgView widget
          (with all the gtkhtml related things). It implements the
          new ModestMsgView interface, and uses all available
          interfaces (zoomable, isearch view, etc).
        * Reorganized the code, to separate the internal code from
          interfaces implementation.
* Added src/widgets/modest-mozembed-mime-part-view.[ch]:
        * Inherits from TnyMozembedMimePartView, adding implementation
          for ModestZoomable, ModestMimePartView, and stub
          implementation of  ModestISearchView.
* Added src/widgets/modest-mozembed-msg-view.[ch]:
        * Implementation of ModestMsgView interface using mozembed
          backend. It's not finished nor really working, but it's
          a technology preview.
* src/widgets/Makefile.am, src/Makefile.am:
        * Added new widgets.
* src/maemo/modest-msg-view-window.c:
        * Removed dependency on gtkhtml code. Update access to
          ModestMsgView to use the proper interfaces.
        * Now construct does not use a msg parameter. Message is set
          after construction.
        * Update event names of ModestMsgView.
* configure.ac:
        * Add mozembed parameter, to be able to activate mozembed
          support.

pmo-trunk-r3521

13 years ago * Fixed a critical when drag&drop, we're not considering that we can hover an account
Sergio Villar Senin [Wed, 17 Oct 2007 10:47:15 +0000 (10:47 +0000)]
* Fixed a critical when drag&drop, we're not considering that we can hover an account

pmo-trunk-r3520

13 years agoMessages in the Outbox are opened with the viewer, not
Alberto Garcia [Wed, 17 Oct 2007 10:46:05 +0000 (10:46 +0000)]
Messages in the Outbox are opened with the viewer, not
with the editor
Fixes NB#65333

pmo-trunk-r3519

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Wed, 17 Oct 2007 09:44:50 +0000 (09:44 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now, on saving to drafts, we unregister the window (with the
  old header) and register it again (with the new header). If
  the window has been destroyed previously, we don't register
  (fixes NB#66687).

pmo-trunk-r3518

13 years agoHighlight the first message when selecting a new folder, but don't let
Alberto Garcia [Wed, 17 Oct 2007 08:25:33 +0000 (08:25 +0000)]
Highlight the first message when selecting a new folder, but don't let
it get the active focus.
Fixes NB#58917

pmo-trunk-r3517

13 years ago * Fixed a bug in the easysetup, the connection specific SMTP servers dialog was...
Sergio Villar Senin [Tue, 16 Oct 2007 17:27:24 +0000 (17:27 +0000)]
* Fixed a bug in the easysetup, the connection specific SMTP servers dialog was not modal

pmo-trunk-r3516