modest
13 years ago* fix for NB#67837, NB#63633
Dirk-Jan C. Binnema [Mon, 3 Sep 2007 13:33:42 +0000 (13:33 +0000)]
* fix for NB#67837, NB#63633
  - don't try to convert ' --> ' [ while technically correct,
    apparently, wpeditor does not like it
  - clean up writing of reply/forward msgs a bit. it could use more cleanup

pmo-trunk-r3191

13 years agoremoved 2 bugs to start integration. - week 36, 3rd sept.
Vivek Sekar [Mon, 3 Sep 2007 13:28:31 +0000 (13:28 +0000)]
removed 2 bugs to start integration. -  week 36, 3rd sept.

pmo-trunk-r3190

13 years agoAdded new fixes to changelog - week 36, 3rd sept.
Vivek Sekar [Mon, 3 Sep 2007 12:34:32 +0000 (12:34 +0000)]
Added new fixes to changelog -  week 36, 3rd sept.

pmo-trunk-r3188

13 years agoshow the correct icons for debian packages
Dirk-Jan C. Binnema [Mon, 3 Sep 2007 11:38:55 +0000 (11:38 +0000)]
show the correct icons for debian packages

pmo-trunk-r3187

13 years ago* Review dimming rules to detect when modest is sedning mails.
Javier Fernandez Garcia-Boente [Mon, 3 Sep 2007 11:30:20 +0000 (11:30 +0000)]
* Review dimming rules to detect when modest is sedning mails.
* Use the new tinymail API function to add mails to send queue
asynchronously.
* Fixes: NB#61607, NB#61952, NB#64146, NB#64924

pmo-trunk-r3186

13 years ago* fix NB#67791
Dirk-Jan C. Binnema [Mon, 3 Sep 2007 10:59:04 +0000 (10:59 +0000)]
* fix NB#67791

pmo-trunk-r3185

13 years ago * Fixed a leak with folders when refreshing
Sergio Villar Senin [Mon, 3 Sep 2007 09:56:30 +0000 (09:56 +0000)]
* Fixed a leak with folders when refreshing

pmo-trunk-r3184

13 years ago* show the correct icon, even for osso-notes attachments.
Dirk-Jan C. Binnema [Mon, 3 Sep 2007 08:14:07 +0000 (08:14 +0000)]
* show the correct icon, even for osso-notes attachments.

pmo-trunk-r3183

13 years ago * Fixes NB#65015 the Outbox folder is no longer missing in the folder view when...
Sergio Villar Senin [Mon, 3 Sep 2007 07:48:30 +0000 (07:48 +0000)]
* Fixes NB#65015 the Outbox folder is no longer missing in the folder view when an account is added. It's also properly removed, when no account is defined

pmo-trunk-r3182

13 years ago* Add Shortcuts to Send, Replay and Forward actions.
Javier Fernandez Garcia-Boente [Sat, 1 Sep 2007 14:58:30 +0000 (14:58 +0000)]
* Add Shortcuts to Send, Replay and Forward actions.
* Fixes: NB#65668

pmo-trunk-r3181

13 years ago* fix the glaring security issue with the previous commit, ie,
Dirk-Jan C. Binnema [Sat, 1 Sep 2007 11:59:03 +0000 (11:59 +0000)]
* fix the glaring security issue with the previous commit, ie,
  when someone would specify a file name
  "../../etc/passwd". fixed now.

pmo-trunk-r3180

13 years ago* fix for NB#63391, where a notes-attachment would be opened in the browser instead
Dirk-Jan C. Binnema [Sat, 1 Sep 2007 11:43:50 +0000 (11:43 +0000)]
* fix for NB#63391, where a notes-attachment would be opened in the browser instead
  - code would make a temp file <random>.ext and ask the mime system to open that,
  however, it only took the *last* extension, so foo.notes.html would become
  <random>.html, and thus opened in browser
  - second, it would open with these funny random chars in the name
  - solution: we now make a temporary-directory (with random name), and save the
  attachment file there with it's real name
  - one issue remaining are attachments without a name.

* make #define hildon_foo --> osso_foo for the functions in modest-platform, so we can
  get rid of the ugly #ifdef blocks.

pmo-trunk-r3179

13 years ago* sort the folder names in the way the spec wants; this work is not complete:
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 16:08:56 +0000 (16:08 +0000)]
* sort the folder names in the way the spec wants; this work is not complete:
  - we're still missing the outbox
  - we need to take care of localization (urgh)
  - what about 'All mail folders'?

pmo-trunk-r3178

13 years ago2007-08-31 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 31 Aug 2007 16:02:51 +0000 (16:02 +0000)]
2007-08-31  Murray Cumming  <murrayc@murrayc.com>

* src/modest-defs.h: Rename MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST to
MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST and make it a global list
for use by all accounts that enable the MODEST_ACCOUNT_USE_CONNECTION_SPECIFIC_SMTP
boolean, because this is the specified behaviour in the UI spec.
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
(modest_account_mgr_set_connection_specific_smtp),
(modest_account_mgr_remove_connection_specific_smtp),
(modest_account_mgr_get_connection_specific_smtp): Remove the account_name
parameter.
* src/maemo/modest-connection-specific-smtp-window.h:
* src/maemo/modest-connection-specific-smtp-window.c:
(modest_connection_specific_smtp_window_finalize),
(modest_connection_specific_smtp_window_fill_with_connections),
(modest_connection_specific_smtp_window_save_server_accounts):
Remove the account_name parameters and member variable.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(on_button_outgoing_smtp_servers), (create_account):
* src/maemo/modest-account-settings-dialog.c:
(on_button_outgoing_smtp_servers), (check_data),
(modest_account_settings_dialog_set_account_name),
(save_configuration):
* src/maemo/modest-maemo-utils.c: (on_account_online),
(modest_maemo_utils_get_supported_secure_authentication_methods):
* src/modest-tny-account-store.c:
(get_smtp_specific_transport_account_for_open_connection),
(insert_account), (add_connection_specific_transport_accounts):
* src/modest-ui-actions.c: (on_smtp_servers_window_hide),
(modest_ui_actions_on_smtp_servers):
 Adapt to the changed API.

pmo-trunk-r3176

13 years ago* tiny optimization for the header view: avoid one needless
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 15:08:56 +0000 (15:08 +0000)]
* tiny optimization for the header view: avoid one needless
  copy of the subject

pmo-trunk-r3174

13 years ago* only use modest_window_set_active_account with real, non-pseudo accounts.
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 14:10:13 +0000 (14:10 +0000)]
* only use modest_window_set_active_account with real, non-pseudo accounts.
  this makes send/receive/open aware of the active account in many cases,
  fixes NB#67071, and maybe some others.

Note: I think the 'active_account' could probable be tracked more easy with
  a function on modest_folder_view.

pmo-trunk-r3173

13 years ago* only allow real, non-pseudo accounts
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 14:06:54 +0000 (14:06 +0000)]
* only allow real, non-pseudo accounts

pmo-trunk-r3172

13 years agoRemoved bugs not accepted by the system.
Vivek Sekar [Fri, 31 Aug 2007 13:00:40 +0000 (13:00 +0000)]
Removed bugs not accepted by the system.

pmo-trunk-r3171

13 years agoRemoved bugs not accepted by the system.
Vivek Sekar [Fri, 31 Aug 2007 12:44:23 +0000 (12:44 +0000)]
Removed bugs not accepted by the system.

pmo-trunk-r3170

13 years agoAdded unreleased bugs from week 35 into the new week 36 pre release.
Vivek Sekar [Fri, 31 Aug 2007 12:21:19 +0000 (12:21 +0000)]
Added unreleased bugs from week 35 into the new week 36 pre release.

pmo-trunk-r3169

13 years ago * Reverts some changes of commit 3159 with is causing some annoying side effects...
Sergio Villar Senin [Fri, 31 Aug 2007 12:19:08 +0000 (12:19 +0000)]
* Reverts some changes of commit 3159 with is causing some annoying side effects, we need to find a better way to place the passive focus. The commit 3159 was placing the active focus by error

pmo-trunk-r3167

13 years ago* Show a "Pasting" banner when moving messages
Alberto Garcia [Fri, 31 Aug 2007 11:54:52 +0000 (11:54 +0000)]
* Show a "Pasting" banner when moving messages
Fixes NB#63479

pmo-trunk-r3166

13 years ago* Avoid to get MMC root folder name in text_cell_data.
Javier Fernandez Garcia-Boente [Fri, 31 Aug 2007 10:30:52 +0000 (10:30 +0000)]
* Avoid to get MMC root folder name in text_cell_data.
* Fixes: NB#65331

pmo-trunk-r3165

13 years ago* remove some annoying debug warnings
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 06:35:21 +0000 (06:35 +0000)]
* remove some annoying debug warnings
* remember the parent-uid for messages (needed to check if a reply to a message
  is already ongoing)

pmo-trunk-r3163

13 years ago* remove some needless warnings (ie. edit windows don't have to
Dirk-Jan C. Binnema [Fri, 31 Aug 2007 06:29:55 +0000 (06:29 +0000)]
* remove some needless warnings (ie. edit windows don't have to
  warn about not having a UID)

pmo-trunk-r3162

13 years ago* New Message toolbar button and menu item will be dimmed
Javier Fernandez Garcia-Boente [Thu, 30 Aug 2007 19:18:15 +0000 (19:18 +0000)]
* New Message toolbar button and menu item will be dimmed
when no accounts have been defined.
* Fixes: NB#64278

pmo-trunk-r3161

13 years ago * Fixes NB#64311 show the proper help depending on the folder that is selected in...
Sergio Villar Senin [Thu, 30 Aug 2007 18:11:56 +0000 (18:11 +0000)]
* Fixes NB#64311 show the proper help depending on the folder that is selected in the folder view

pmo-trunk-r3160

13 years agofixes NB#58917
Peter Csaszar [Thu, 30 Aug 2007 16:21:37 +0000 (16:21 +0000)]
fixes NB#58917

pmo-trunk-r3159

13 years ago* Fixed crash on dimmin rules when M;MC root account is selected.
Javier Fernandez Garcia-Boente [Thu, 30 Aug 2007 13:57:12 +0000 (13:57 +0000)]
* Fixed crash on dimmin rules when M;MC root account is selected.

pmo-trunk-r3156

13 years ago* Commented out modest_folder_view_set_folder_selected because
Javier Fernandez Garcia-Boente [Thu, 30 Aug 2007 12:23:06 +0000 (12:23 +0000)]
* Commented out modest_folder_view_set_folder_selected because
it caused some hangs after folder transfer was completed.

pmo-trunk-r3154

13 years ago * Moving back to the old version of has_subfolder_with_name because the new version...
Sergio Villar Senin [Thu, 30 Aug 2007 11:17:47 +0000 (11:17 +0000)]
* Moving back to the old version of has_subfolder_with_name because the new version needs some tinymail changes
* Fixed a problem when creating folders related to folder names, now it uses the has_subfolder_with_name function
* Fixes NB#62026, folder moves is fixed right now

pmo-trunk-r3153

13 years ago * Select the folder that has been moved
Sergio Villar Senin [Thu, 30 Aug 2007 10:03:21 +0000 (10:03 +0000)]
* Select the folder that has been moved

pmo-trunk-r3152

13 years ago* fix some mem leaks (50Kb after clicking around a bit, according to valgrind)
Dirk-Jan C. Binnema [Thu, 30 Aug 2007 09:57:48 +0000 (09:57 +0000)]
* fix some mem leaks (50Kb after clicking around a bit, according to valgrind)

pmo-trunk-r3151

13 years ago * added led-pattern hint to notification based on the code of the old client
Sergio Villar Senin [Thu, 30 Aug 2007 09:31:20 +0000 (09:31 +0000)]
* added led-pattern hint to notification based on the code of the old client

pmo-trunk-r3150

13 years agoModified changelog to reflect week 35, as queue is still not frozen.
Vivek Sekar [Thu, 30 Aug 2007 08:21:32 +0000 (08:21 +0000)]
Modified changelog to reflect week 35, as queue is still not frozen.

pmo-trunk-r3148

13 years agoAdded new fixes and moved the week 35-2 fixes to week 36-1 build on 30th aug.
Vivek Sekar [Thu, 30 Aug 2007 08:00:06 +0000 (08:00 +0000)]
Added new fixes and moved the week 35-2 fixes to week 36-1 build on 30th aug.

pmo-trunk-r3146

13 years ago* activate the maemo-launcher once more
Dirk-Jan C. Binnema [Thu, 30 Aug 2007 06:14:27 +0000 (06:14 +0000)]
* activate the maemo-launcher once more

pmo-trunk-r3145

13 years ago2007-08-29 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Wed, 29 Aug 2007 21:35:54 +0000 (21:35 +0000)]
2007-08-29  Armin Burgmeier  <armin@openismus.com>

* src/modest-protocol-info.h:
* src/modest-protocol-info.c: Added
modest_protocol_info_get_auth_protocol() to translate an
authentication protocol name to the corresponding enum value.

* src/maemo/modest-maemo-utils.c: Fixed supported auth protocol list
generation using the newly added function.

* src/maemo/modest-account-settings-dialog.c: Use the current element
when traversing through the list of supported authentication methods,
not always the first.

pmo-trunk-r3144

13 years ago * Improved my last commit, only invalidate cur_folder_store and folder_to_select...
Sergio Villar Senin [Wed, 29 Aug 2007 17:39:18 +0000 (17:39 +0000)]
* Improved my last commit, only invalidate cur_folder_store and folder_to_select when the account that it's being removed is the same account than the accounts of any of these folders

pmo-trunk-r3143

13 years ago * Fixed a SIGSEV when renaming folders caused by the delayed selection
Sergio Villar Senin [Wed, 29 Aug 2007 17:24:04 +0000 (17:24 +0000)]
* Fixed a SIGSEV when renaming folders caused by the delayed selection
* Implemented a TODO related to the delayed selection
* Fixed the delayed selection when renaming folders

pmo-trunk-r3142

13 years ago2007-08-29 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 29 Aug 2007 17:02:14 +0000 (17:02 +0000)]
2007-08-29   Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
(check_first_supported_auth_method), (on_before_next),
(create_account):
* src/maemo/modest-account-settings-dialog.c: (check_data):
Some cleanup, to make the code clearer.

pmo-trunk-r3141

13 years ago2007-08-29 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 29 Aug 2007 17:01:45 +0000 (17:01 +0000)]
2007-08-29   Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
(check_first_supported_auth_method), (on_before_next),
(create_account):
* src/maemo/modest-account-settings-dialog.c: (check_data):
Some cleanup, to make the code clearer.

pmo-trunk-r3140

13 years ago * Fixes NB#66485, the "rename" option is now available also from the Main menu
Sergio Villar Senin [Wed, 29 Aug 2007 16:23:57 +0000 (16:23 +0000)]
* Fixes NB#66485, the "rename" option is now available also from the Main menu

pmo-trunk-r3139

13 years ago * Fixes NB#66280, does not allow to move a folder to a POP inbox in the "move to...
Sergio Villar Senin [Wed, 29 Aug 2007 15:52:14 +0000 (15:52 +0000)]
* Fixes NB#66280, does not allow to move a folder to a POP inbox in the "move to" dialog

pmo-trunk-r3138

13 years ago* Review dimming rules to add not_deletable, not_moveable and
Javier Fernandez Garcia-Boente [Wed, 29 Aug 2007 15:44:21 +0000 (15:44 +0000)]
* Review dimming rules to add not_deletable, not_moveable and
not_renameable utility functions.
* fixes: NB#67113

pmo-trunk-r3137

13 years ago * src/modest-ui-actions.c
Alberto Garcia [Wed, 29 Aug 2007 15:33:16 +0000 (15:33 +0000)]
   * src/modest-ui-actions.c
   (delete_folder):
   Ask for confirmation before trying to connect to the network
   Fixes NB#66762

pmo-trunk-r3136

13 years agofixes NB#66803
Peter Csaszar [Wed, 29 Aug 2007 15:25:17 +0000 (15:25 +0000)]
fixes NB#66803

pmo-trunk-r3135

13 years ago2007-08-29 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 29 Aug 2007 15:21:10 +0000 (15:21 +0000)]
2007-08-29  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Use the mail_ni_ssl_certificate_error (Secure connection failed)
logical ID when the secure authentication method is not supported by
the server, as requested by Mox on the wiki, though I hate not
giving the user the clue.

pmo-trunk-r3134

13 years agofixes NB#66495
Peter Csaszar [Wed, 29 Aug 2007 15:09:11 +0000 (15:09 +0000)]
fixes NB#66495

pmo-trunk-r3133

13 years ago * src/modest-ui-actions.c
Alberto Garcia [Wed, 29 Aug 2007 15:05:05 +0000 (15:05 +0000)]
   * src/modest-ui-actions.c
   (modest_ui_actions_on_rename_folder):
   Don't try to connect before showing the rename dialog

pmo-trunk-r3132

13 years ago * Renamed on_paste_msg by on_paste
Sergio Villar Senin [Wed, 29 Aug 2007 14:27:32 +0000 (14:27 +0000)]
* Renamed on_paste_msg by on_paste

pmo-trunk-r3131

13 years ago * src/modest-platform.h
Alberto Garcia [Wed, 29 Aug 2007 14:12:33 +0000 (14:12 +0000)]
   * src/modest-platform.h
   * src/modest-platform.c
   (modest_platform_is_network_folderstore):
   Checks whether a folder store is remote
   * src/modest-ui-actions.c
   (modest_ui_actions_on_move_to):
   Don't try to connect to the internet, leave that for the following
   functions.
   (modest_ui_actions_on_main_window_move_to):
   (modest_ui_actions_on_msg_view_window_move_to):
   Ask for confirmation if the device is offline and the source folder
   is remote

pmo-trunk-r3130

13 years agotries to solve NB#66463, I am not sure if this is enough
Peter Csaszar [Wed, 29 Aug 2007 14:12:01 +0000 (14:12 +0000)]
tries to solve NB#66463, I am not sure if this is enough

pmo-trunk-r3129

13 years ago* fix a mem leak
Dirk-Jan C. Binnema [Wed, 29 Aug 2007 13:49:27 +0000 (13:49 +0000)]
* fix a mem leak

pmo-trunk-r3128

13 years ago* remove annoying g_debug
Dirk-Jan C. Binnema [Wed, 29 Aug 2007 13:34:01 +0000 (13:34 +0000)]
* remove annoying g_debug

pmo-trunk-r3127

13 years agofixes NB#66461
Peter Csaszar [Wed, 29 Aug 2007 11:08:14 +0000 (11:08 +0000)]
fixes NB#66461

pmo-trunk-r3124

13 years ago * Fixes NB#66968, there is no limit on the number of sub-folders that the user...
Sergio Villar Senin [Wed, 29 Aug 2007 10:24:18 +0000 (10:24 +0000)]
 * Fixes NB#66968, there is no limit on the number of sub-folders that the user can have

pmo-trunk-r3123

13 years ago2007-08-29 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 29 Aug 2007 10:08:04 +0000 (10:08 +0000)]
2007-08-29  Murray Cumming  <murrayc@murrayc.com>

* src/modest-search.c: (modest_search_all_accounts):
* src/modest-platform.h:
* src/maemo/modest-platform.c: Moved and renamed
check_and_wait_for_account_is_online() to
modest_platform_check_and_wait_for_account_is_online() so it
can be used in more places.

pmo-trunk-r3122

13 years ago * Fixes NB#67061, do not ask the user to download the msg if we're online
Sergio Villar Senin [Wed, 29 Aug 2007 09:59:55 +0000 (09:59 +0000)]
* Fixes NB#67061, do not ask the user to download the msg if we're online

pmo-trunk-r3121

13 years ago * Partially fixes NB#67060, now this bug is reassigned to the language component
Sergio Villar Senin [Wed, 29 Aug 2007 09:35:15 +0000 (09:35 +0000)]
* Partially fixes NB#67060, now this bug is reassigned to the language component

pmo-trunk-r3120

13 years ago2007-08-29 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 29 Aug 2007 09:29:49 +0000 (09:29 +0000)]
2007-08-29  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
Removed the sleep(1) experiment because it does not seem to help,
and I should not have checked the experiment in anyway.
The problem is maybe in the TnyAccount connected state - I will
investigate that instead.

pmo-trunk-r3119

13 years agofixes NB#64231
Peter Csaszar [Wed, 29 Aug 2007 09:18:07 +0000 (09:18 +0000)]
fixes NB#64231

pmo-trunk-r3118

13 years agosome modification that helps solving NB#66762
Peter Csaszar [Wed, 29 Aug 2007 06:22:56 +0000 (06:22 +0000)]
some modification that helps solving NB#66762

pmo-trunk-r3117

13 years ago * Fixed the signature of the "folder-selection-changed" signal
Sergio Villar Senin [Tue, 28 Aug 2007 18:43:18 +0000 (18:43 +0000)]
* Fixed the signature of the "folder-selection-changed" signal
* Fixes NB#66937
* Fixes NB#62966

pmo-trunk-r3116

13 years agoshould fix NB#65097 and NB#63178
Peter Csaszar [Tue, 28 Aug 2007 17:08:30 +0000 (17:08 +0000)]
should fix NB#65097 and NB#63178

pmo-trunk-r3115

13 years ago* Define a new mail-operation to remove several messages.
Javier Fernandez Garcia-Boente [Tue, 28 Aug 2007 16:46:16 +0000 (16:46 +0000)]
* Define a new mail-operation to remove several messages.
* Sync folder after send mail from Draft folder, to actually remove it.
* Sync folder after remove message from outbox, after they were sent.
* Changes on header-view-render to get send-queus of all defined accounts
if they were not in send-queue cache.
* Define a new status for header-view to determine if all messages in
the current selected folder are marked as deleted.
* Allow to enable and disable dimming rules. This feature could
improve performance in operations which require that a lot of headers
were selected.
* Fixes: NB#64359, NB#64321, NB#61954, NB#63011

pmo-trunk-r3114

13 years ago2007-08-28 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 28 Aug 2007 14:55:13 +0000 (14:55 +0000)]
2007-08-28  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
Added a sleep(1) in case it helps with bug #66769.

pmo-trunk-r3113

13 years agoAdded new fixes. week 35-28 aug.
Vivek Sekar [Tue, 28 Aug 2007 13:48:48 +0000 (13:48 +0000)]
Added new fixes. week 35-28 aug.

pmo-trunk-r3111

13 years ago * src/widgets/modest-msg-edit-window-ui.h
Alberto Garcia [Tue, 28 Aug 2007 13:12:07 +0000 (13:12 +0000)]
   * src/widgets/modest-msg-edit-window-ui.h
   Added shortcut for "Save as draft" (Ctrl+S)

pmo-trunk-r3110

13 years ago2007-08-28 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 28 Aug 2007 12:50:44 +0000 (12:50 +0000)]
2007-08-28  Murray Cumming  <murrayc@murrayc.com>

* src/modest-search.c: (on_timeout_check_account_is_online),
(check_and_wait_for_account_is_online):
It is OK for local-folder and mmc accounts to be used when they
are in the _INIT folder, instead of waiting for them to change
(they never do).
For POP and IMAP, wait from them to stop being _INIT, rather than
waiting from them to be _CONNECTED, because that seems to be
the status that causes the problems.

pmo-trunk-r3109

13 years ago2007-08-28 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 28 Aug 2007 11:37:08 +0000 (11:37 +0000)]
2007-08-28  Murray Cumming  <murrayc@murrayc.com>

* src/modest-search.c: (check_and_wait_for_account_is_online):
        Actually pass the account to the timeout callback.

pmo-trunk-r3107

13 years agooptimized dimming rule for select all
Peter Csaszar [Tue, 28 Aug 2007 11:28:30 +0000 (11:28 +0000)]
optimized dimming rule for select all

pmo-trunk-r3106

13 years ago * src/widgets/modest-msg-edit-window-ui.h
Alberto Garcia [Tue, 28 Aug 2007 10:01:32 +0000 (10:01 +0000)]
   * src/widgets/modest-msg-edit-window-ui.h
   Defined new keyboard shortcuts:
   Ctrl+Return: send message
   Ctrl+Z: undo
   Ctrl+X: cut
   Ctrl+C: copy
   Ctrl+V: paste
   Ctrl+W: close window
   Ctrl+Q: close application
   Ctrl+E: search e-mails
   Ctrl+F: find in page

Fixes NB#63393

pmo-trunk-r3104

13 years ago2007-08-28 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 28 Aug 2007 09:42:00 +0000 (09:42 +0000)]
2007-08-28  Murray Cumming  <murrayc@murrayc.com>

* src/modest-search.c: (on_timeout_check_account_is_online):
Added some debug output to help me debug a problem on the N800.
(check_and_wait_for_account_is_online): Fail immediately if the
device is offline.
modest_search_all_accounts(): Try the search even if the account does
not seem to be online, because this can work sometimes, and should work
with the cache if there is no active libconic connection.

pmo-trunk-r3103

13 years ago * Partially fixes NB#63588, it works but we still need to find a proper solution...
Sergio Villar Senin [Tue, 28 Aug 2007 08:37:56 +0000 (08:37 +0000)]
* Partially fixes NB#63588, it works but we still need to find a proper solution for detecting duplicates in local folders
* Fixes NB#66839, delete folders in cascade no longer crashes the application

pmo-trunk-r3102

13 years ago* fix some leaks, turn an assert into a runtime warning
Dirk-Jan C. Binnema [Tue, 28 Aug 2007 06:51:52 +0000 (06:51 +0000)]
* fix some leaks, turn an assert into a runtime warning

pmo-trunk-r3101

13 years ago* check whether folder_view actually exists before calling it;
Dirk-Jan C. Binnema [Tue, 28 Aug 2007 06:25:27 +0000 (06:25 +0000)]
* check whether folder_view actually exists before calling it;
  this fixes some GLib-Criticals.

pmo-trunk-r3100

13 years agoReverted my previous changes, this will be fixed in another way.
Armin Burgmeier [Mon, 27 Aug 2007 14:32:18 +0000 (14:32 +0000)]
Reverted my previous changes, this will be fixed in another way.

pmo-trunk-r3097

13 years ago * src/maemo/modest-msg-view-window.c
Alberto Garcia [Mon, 27 Aug 2007 13:48:47 +0000 (13:48 +0000)]
   * src/maemo/modest-msg-view-window.c
   (save_mime_parts_to_file_with_checks):
   Check whether there are one or many files about to be overwritten
   and show a different confirmation message in each case
   (idle_save_mime_part_show_result):
   If there are still unsaved files then save them directly without
   asking. The user should only be asked once.
   Fixes NB#66450

pmo-trunk-r3094

13 years ago2007-08-27 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Mon, 27 Aug 2007 13:40:24 +0000 (13:40 +0000)]
2007-08-27  Armin Burgmeier  <armin@openismus.com>

* src/modest-tny-send-queue.c: Implement TnyFolderObserver and
observe outbox for added messages to assign them a status. Previously,
this was done in modest_tny_send_queue_add(), but the message id might
not yet be known at that point. This reduces warnings when sending
mail, though I am not sure how this even worked before.

pmo-trunk-r3093

13 years ago2007-08-27 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 27 Aug 2007 12:38:29 +0000 (12:38 +0000)]
2007-08-27  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_init):
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(modest_connection_specific_smtp_edit_window_init):
* src/maemo/modest-connection-specific-smtp-window.c:
(modest_connection_specific_smtp_window_init):
* src/maemo/modest-maemo-utils.c:
(modest_maemo_utils_get_supported_secure_authentication_methods):
* src/maemo/modest-platform.c:
(modest_platform_run_folder_name_dialog):
* src/maemo/modest-signature-editor-dialog.c:
(modest_signature_editor_dialog_init):
* src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
(modest_ui_actions_on_password_requested), (create_move_to_dialog):
* src/widgets/modest-global-settings-dialog.c:
(modest_global_settings_dialog_init):
Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
mcen_bd_dialog_ok,
GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
GTK_STOCK_EDIT with mcen_bd_edit, and
GTK_STOCK_CLOSE with mcen_bd_close,
to fix projects.maemo.org bug NB#64995.
I strongly believe that Maemo's GTK+ should have the wanted translations
instead of duplicating this in each application and complicating the code.

pmo-trunk-r3092

13 years agofixes NB#64181
Peter Csaszar [Mon, 27 Aug 2007 12:18:54 +0000 (12:18 +0000)]
fixes NB#64181

pmo-trunk-r3091

13 years ago * src/modest-search.c
Alberto Garcia [Mon, 27 Aug 2007 11:55:32 +0000 (11:55 +0000)]
   * src/modest-search.c
   Fix build problem caused by latest commit by murrayc

pmo-trunk-r3088

13 years ago2007-08-27 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Mon, 27 Aug 2007 11:47:07 +0000 (11:47 +0000)]
2007-08-27  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
recursion when entering text in the subject field.

pmo-trunk-r3087

13 years ago2007-08-27 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 27 Aug 2007 11:35:03 +0000 (11:35 +0000)]
2007-08-27  Murray Cumming  <murrayc@murrayc.com>

* src/modest-search.c: Added check_and_wait_for_account_is_online(),
which checks every second, 10 times, to wait until the account is online
so that we can use it, if the account is in the process of going online.
(modest_search_all_accounts): Use check_and_wait_for_account_is_online()
so that searching works even when the application was not yet started before.
This fixes projects.maemo.org bug NB#63784, at least in scratchbox.

pmo-trunk-r3085

13 years ago * src/modest-text-utils.c
Alberto Garcia [Mon, 27 Aug 2007 11:06:28 +0000 (11:06 +0000)]
   * src/modest-text-utils.c
   Replaced unlocalised strings in message forwarding by
   localised ones.
   Fixes NB#63783

pmo-trunk-r3083

13 years agoWeek 35 Pre Release, added bug fixed in the week.
Vivek Sekar [Mon, 27 Aug 2007 10:53:16 +0000 (10:53 +0000)]
Week 35 Pre Release, added bug fixed in the week.

pmo-trunk-r3082

13 years agotwo small modification
Peter Csaszar [Mon, 27 Aug 2007 10:36:31 +0000 (10:36 +0000)]
two small modification

pmo-trunk-r3080

13 years agofixes NB#64201
Peter Csaszar [Mon, 27 Aug 2007 09:54:44 +0000 (09:54 +0000)]
fixes NB#64201

pmo-trunk-r3079

13 years ago* small fix, this commit mainly for testing commit message delivery
Dirk-Jan C. Binnema [Mon, 27 Aug 2007 09:21:49 +0000 (09:21 +0000)]
* small fix, this commit mainly for testing commit message delivery

pmo-trunk-r3078

13 years agofixes NB#66161 (dimming on Edit>SelectAll)
Peter Csaszar [Mon, 27 Aug 2007 08:04:19 +0000 (08:04 +0000)]
fixes NB#66161 (dimming on Edit>SelectAll)

pmo-trunk-r3076

13 years ago* cleaner version of the patch to make sure no double account-setup-wizards are
Dirk-Jan C. Binnema [Mon, 27 Aug 2007 07:00:14 +0000 (07:00 +0000)]
* cleaner version of the patch to make sure no double account-setup-wizards are
  shown
* fixes a critical G-Warning in modest-window-mgr
* apparently also fixes: NB#66304

pmo-trunk-r3075

13 years ago * Fixed a double-leak in the last commit
Sergio Villar Senin [Sun, 26 Aug 2007 09:28:28 +0000 (09:28 +0000)]
* Fixed a double-leak in the last commit

pmo-trunk-r3074

13 years agofixes NB#63872
Peter Csaszar [Fri, 24 Aug 2007 19:12:13 +0000 (19:12 +0000)]
fixes NB#63872

pmo-trunk-r3073

13 years ago * Fixed a hang when moving folders using the "Move to" dialog
Sergio Villar Senin [Fri, 24 Aug 2007 17:42:32 +0000 (17:42 +0000)]
* Fixed a hang when moving folders using the "Move to" dialog
* The "Move to" dialog show now the proper account

pmo-trunk-r3072

13 years ago * Fixed a bug added with armin's commit 3066, the key need to be initialized
Sergio Villar Senin [Fri, 24 Aug 2007 16:58:16 +0000 (16:58 +0000)]
* Fixed a bug added with armin's commit 3066, the key need to be initialized

pmo-trunk-r3071

13 years ago* Always check how many rows are selected before open it
Javier Fernandez Garcia-Boente [Fri, 24 Aug 2007 14:09:39 +0000 (14:09 +0000)]
* Always check how many rows are selected before open it
using hardware select key.
* Fixes: NB#61649

pmo-trunk-r3068

13 years ago * Renamed a function
Sergio Villar Senin [Fri, 24 Aug 2007 14:01:18 +0000 (14:01 +0000)]
* Renamed a function
* Added a new define for hildon-libs domain translation
* Fixes NB#65969

pmo-trunk-r3067

13 years ago2007-08-24 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Fri, 24 Aug 2007 13:49:45 +0000 (13:49 +0000)]
2007-08-24  Armin Burgmeier  <armin@openismus.com>

* src/modest-widget-memory.c: Always show the default account when the
application is started, as stated in the UI spec. This fixes
projects.maemo.org bug NB#66630.

pmo-trunk-r3066

13 years ago2007-08-24 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Fri, 24 Aug 2007 12:44:29 +0000 (12:44 +0000)]
2007-08-24  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-platform.c:
(modest_platform_run_rename_folder_dialog): Use logical IDs instead of
english text for strings in the rename folder dialog, fixing
projects.maemo.org bug NB#66338.

pmo-trunk-r3065