modest
13 years ago* show Ok/Cancel instead of Yes/No, fixes NB#59428
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 09:20:16 +0000 (09:20 +0000)]
* show Ok/Cancel instead of Yes/No, fixes NB#59428

pmo-trunk-r2665

13 years ago* Set focus on next row after delete selected headers
Javier Fernandez Garcia-Boente [Tue, 10 Jul 2007 08:51:20 +0000 (08:51 +0000)]
* Set focus on next row after delete selected headers
on main window.
* Add a check for msg_id after get it from header just
after moved it to OUTBOX folder.
* Fixes: NB#61937

pmo-trunk-r2664

13 years ago2007-07-10 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 10 Jul 2007 08:13:22 +0000 (08:13 +0000)]
2007-07-10  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (on_idle_wrong_password):
A compilation fix, though the build wasn't broken for me.

pmo-trunk-r2663

13 years agoPerformance improvement and bugfix for 62489
Philip Van Hoof [Tue, 10 Jul 2007 08:03:48 +0000 (08:03 +0000)]
Performance improvement and bugfix for 62489

pmo-trunk-r2662

13 years ago* src/maemo/modest-platform.c:
Jose Dapena Paz [Tue, 10 Jul 2007 07:06:00 +0000 (07:06 +0000)]
* src/maemo/modest-platform.c:
        * Fixed a crash that happened on moving messages to outbox.
          The code to connect and wait, didn't consider the case of
          a message from a folder without an account (fixes NB#62872).

pmo-trunk-r2661

13 years ago* fix for the logical string part of NB#62872
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 06:11:53 +0000 (06:11 +0000)]
* fix for the logical string part of NB#62872

pmo-trunk-r2660

13 years ago2007-07-09 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 9 Jul 2007 21:26:20 +0000 (21:26 +0000)]
2007-07-09  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
Do not try to unref a NULL folder store, to avoid a runtime warning.
This seems to happen sometimes when changing accounts settings.

pmo-trunk-r2659

13 years ago2007-07-09 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 9 Jul 2007 20:25:32 +0000 (20:25 +0000)]
2007-07-09  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c:
(modest_tny_account_store_instance_init),
(modest_tny_account_store_finalize),
(on_account_settings_hide), (on_idle_wrong_password):
Use a GHashTable to ensure that we only show one account settings
dialog per modest account. This avoids us having a dialog open for
both the store and transport accounts, or due to repeated get_password()
calls that shouldn't happen anyway.

pmo-trunk-r2658

13 years ago2007-07-09 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 9 Jul 2007 19:29:53 +0000 (19:29 +0000)]
2007-07-09  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-utils.c: (on_hide),
(modest_maemo_show_dialog_and_forget): Handle the response, because
the window is not even hidden by default.

* src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
* src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
which seems to prevent some modality problems.

* src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
Ignore user cancellation errors.

* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
Added modest_server_account_get_password() and
modest_server_account_get_has_password() to avoid direct use of
conf enums.

* src/maemo/modest-account-settings-dialog.h:
* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_init): Store the notebook so we can
use it later.
Added modest_account_settings_dialog_switch_to_user_info().

* src/modest-tny-account-store.c:
(get_password): When the password in the account settings is wrong (we think),
show the relevant page of the account settings dialog, in the mainloop.
However, we currently get many of these at once because cancel does not
seem to cancel.
(forget_password): Do not forget the password
from the account settings, because this causes side-effects when
tinymail seems to call it at strange time, maybe because of how we
are cancelling get_password().
(modest_tny_account_store_alert): Ignore user cancellations.

pmo-trunk-r2657

13 years ago * The set_first_account_as_default does no longer select the same account than the...
Sergio Villar Senin [Mon, 9 Jul 2007 17:18:32 +0000 (17:18 +0000)]
* The set_first_account_as_default does no longer select the same account than the one it currently has

pmo-trunk-r2656

13 years ago* set the uber-ugly thumbable scrollbar as required by the spec. for main, viewer...
Dirk-Jan C. Binnema [Mon, 9 Jul 2007 16:19:53 +0000 (16:19 +0000)]
* set the uber-ugly thumbable scrollbar as required by the spec. for main, viewer and editor
  fixes: NB#62858

pmo-trunk-r2655

13 years ago * Removed some comments
Sergio Villar Senin [Mon, 9 Jul 2007 15:59:12 +0000 (15:59 +0000)]
* Removed some comments
* Fixed the removal of accounts, now the cache is deleted again
* Fixed a bug when retrieving server accouns, that could cause crashes when refreshing the accounts

pmo-trunk-r2654

13 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Mon, 9 Jul 2007 14:59:28 +0000 (14:59 +0000)]
* src/modest-ui-dimming-rules.c:
        * We also dim if there's no folder nor message selected
          (fixes NB#60595).

pmo-trunk-r2653

13 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Mon, 9 Jul 2007 14:47:45 +0000 (14:47 +0000)]
* src/modest-ui-dimming-rules.c:
        * Dim delete action for archive folder.

pmo-trunk-r2652

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 9 Jul 2007 14:26:18 +0000 (14:26 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now we truncate multiline pastes to first line in
          subject (fixes NB#62320).

pmo-trunk-r2651

13 years ago* src/widgets/modest-header-view-render.c:
Jose Dapena Paz [Mon, 9 Jul 2007 14:12:42 +0000 (14:12 +0000)]
* src/widgets/modest-header-view-render.c:
        * Change the way we set the grey color in the field that
          require this. This way when we select a header, it does not
          get black color.
* src/widgets/modest-header-view.c:
        * Added alignments to fields of the header, to make the message
          appear clearly separated (fixes NB#62262).

pmo-trunk-r2650

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Mon, 9 Jul 2007 13:25:42 +0000 (13:25 +0000)]
* src/modest-ui-actions.c:
        * Now we really copy from GtkHTML widgets (this widget was
          not considered in _on_copy) (fixes NB#61491).
* src/modest-msg-edit-window.c:
        * Now we update the dimming status of "paste" only on showing
          edit menu.

pmo-trunk-r2649

13 years ago* src/maemo/modest-icon-names.h:
Jose Dapena Paz [Mon, 9 Jul 2007 12:59:07 +0000 (12:59 +0000)]
* src/maemo/modest-icon-names.h:
        * Add maemo icons for next, previous and find in page.
* src/maemo/modest-main-window-ui.h, src/maemo/modest-msg-view-window.c:
        * Use the maemo theme icons for next, previous and find in page
          toolbar buttons (fixes NB#61158).

pmo-trunk-r2648

13 years agoThe set_pass_func is not always the last to set
Philip Van Hoof [Mon, 9 Jul 2007 11:44:11 +0000 (11:44 +0000)]
The set_pass_func is not always the last to set

pmo-trunk-r2647

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 9 Jul 2007 11:23:24 +0000 (11:23 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Improved the way we get the files to attach. Now we get
          correctly the filenames if they come from a remote uri. Now
          the filenames get the escapes removed too. And we get the
          mime types better.

pmo-trunk-r2646

13 years agoUpdate ChangeLog2: This fixes projects.maemo.org bug NB#62646
Murray Cumming [Mon, 9 Jul 2007 11:15:51 +0000 (11:15 +0000)]
Update ChangeLog2: This fixes projects.maemo.org bug NB#62646

pmo-trunk-r2645

13 years ago2007-07-09 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 9 Jul 2007 11:14:59 +0000 (11:14 +0000)]
2007-07-09  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-utils.h:
* src/maemo/modest-maemo-utils.c:
Added modest_maemo_show_information_note_and_forget() for use instead of
gtk_dialog_run() when the response is not needed, to avoid an extra
mainloop which could cause a hang.

* src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
Use the logical IDs for the error message, though they are not
specific enough. Note that I used modest_maemo_show_information_note_and_forget()
because gtk_dialog_run() caused a hang here (the window did not close).

pmo-trunk-r2644

13 years agoAdded the fixes made.
Dirk-Jan C. Binnema [Mon, 9 Jul 2007 10:39:06 +0000 (10:39 +0000)]
Added the fixes made.

pmo-trunk-r2643

13 years ago* Some changes to cancel sending operation
Javier Fernandez Garcia-Boente [Mon, 9 Jul 2007 10:37:14 +0000 (10:37 +0000)]
* Some changes to cancel sending operation
using ModestTnySendQueue.

pmo-trunk-r2642

13 years ago* add some argument checking to
Dirk-Jan C. Binnema [Mon, 9 Jul 2007 09:14:29 +0000 (09:14 +0000)]
* add some argument checking to
  modest_tny_account_store_get_transport_account_for_open_connection
  that might help with #62210

pmo-trunk-r2641

13 years ago * Fixes NB#60725 which affects systest, now an information note is shown instead...
Sergio Villar Senin [Mon, 9 Jul 2007 08:50:13 +0000 (08:50 +0000)]
* Fixes NB#60725 which affects systest, now an information note is shown instead of a information banner when notifying the user that an attachments has no registered viewer

pmo-trunk-r2640

13 years agoSetting the headers to SEEN after deleting them
Philip Van Hoof [Mon, 9 Jul 2007 08:32:44 +0000 (08:32 +0000)]
Setting the headers to SEEN after deleting them

pmo-trunk-r2639

13 years ago* Enable modest-tny-send-queue to store information about
Javier Fernandez Garcia-Boente [Mon, 9 Jul 2007 08:30:17 +0000 (08:30 +0000)]
* Enable modest-tny-send-queue to store information about
mails to be sent.
* Sending operation wont show progress information.
* Implement cancel sending operation by setting SUSPENDED priority
flags on all outbox headers.
* Fixes: NB#58571, NB#60517, NB#60916, NB#62448

pmo-trunk-r2638

13 years ago2007-07-09 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 9 Jul 2007 08:28:11 +0000 (08:28 +0000)]
2007-07-09  Murray Cumming  <murrayc@murrayc.com>

* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
Added modest_account_mgr_get_store_protocol().

* src/maemo/modest-account-view-window.c:
(on_delete_button_clicked): Show different warning text depending on
the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
NB#59037.

pmo-trunk-r2637

13 years ago * Fixes NB#62776 which affects systest, now the root folders shows the main view...
Sergio Villar Senin [Mon, 9 Jul 2007 08:20:08 +0000 (08:20 +0000)]
* Fixes NB#62776 which affects systest, now the root folders shows the main view help when help is clicked in their CSM

pmo-trunk-r2636

13 years ago* src/widgets/modest-details-dialog.c:
Jose Dapena Paz [Mon, 9 Jul 2007 07:45:10 +0000 (07:45 +0000)]
* src/widgets/modest-details-dialog.c:
        * Now we show the "created" field for all types. In particular
          it shows proper date information for outbox and drafts folder
          (fixes NB#58615).

pmo-trunk-r2635

13 years ago * Modest was not replying to messages in the msg view window due to the lack of...
Sergio Villar Senin [Mon, 9 Jul 2007 07:13:14 +0000 (07:13 +0000)]
* Modest was not replying to messages in the msg view window due to the lack of this check

pmo-trunk-r2634

13 years ago* restore the window-icons
Dirk-Jan C. Binnema [Mon, 9 Jul 2007 05:47:10 +0000 (05:47 +0000)]
* restore the window-icons

pmo-trunk-r2633

13 years ago* unbreak deleting messages from the viewer
Dirk-Jan C. Binnema [Mon, 9 Jul 2007 05:33:06 +0000 (05:33 +0000)]
* unbreak deleting messages from the viewer

pmo-trunk-r2632

13 years ago2007-07-09 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Sun, 8 Jul 2007 22:20:11 +0000 (22:20 +0000)]
2007-07-09  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-msg-edit-window.c:
(modest_msg_edit_window_attach_file): Set the file chooser dialog title
as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.

pmo-trunk-r2631

13 years agovery minor stuff.
Murray Cumming [Sun, 8 Jul 2007 22:11:41 +0000 (22:11 +0000)]
very minor stuff.

pmo-trunk-r2630

13 years ago* fix for tiny reply-toolbar-csm bug, thanks to leonid's comment.
Dirk-Jan C. Binnema [Sun, 8 Jul 2007 14:09:21 +0000 (14:09 +0000)]
* fix for tiny reply-toolbar-csm bug, thanks to leonid's comment.
  fixes: NB#59001

pmo-trunk-r2629

13 years ago* modest-folder-view.c: change sorting for remote folders: make Inbox be the first...
Dirk-Jan C. Binnema [Sun, 8 Jul 2007 12:12:37 +0000 (12:12 +0000)]
* modest-folder-view.c: change sorting for remote folders: make Inbox be the first folder in remote
* modest-tny-folder: don't try to be too smart about guessing folder types. a local folder
   called "Inbox" should not be treated as an Inbox folder.

pmo-trunk-r2628

13 years ago* include artificial breakpoints in very long (>256 chars) lines; this will make...
Dirk-Jan C. Binnema [Sun, 8 Jul 2007 10:32:26 +0000 (10:32 +0000)]
* include artificial breakpoints in very long (>256 chars) lines; this will make sure the regexp parsing is not DoS'ing modest in some pathological cases.

the problem was that we do a text->html conversion for showing messages, and
  run some regexps to hyperlinkify things that look like email addresses etc.,
  when lines are really long, this takes a *lot* of time.

  Fixes: NB#62530

pmo-trunk-r2627

13 years ago2007-07-07 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Sat, 7 Jul 2007 18:28:59 +0000 (18:28 +0000)]
2007-07-07  Armin Burgmeier  <armin@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c: Translate
ckdg_ib_maximum_characters_reached from correct package.

* src/modest-ui-actions.c: Show an error message when a folder could
not be created. Tinymail does not give us specific error codes about
what has gone wrong, so we assume that a folder with that name
already exists, though there might be other reasons.

pmo-trunk-r2626

13 years ago* when pushing the delete toolbar button in the main window, or choosing
Dirk-Jan C. Binnema [Sat, 7 Jul 2007 16:29:16 +0000 (16:29 +0000)]
* when pushing the delete toolbar button in the main window, or choosing
  the delete menu item, delete either message or folder, depending on the
  focus. the dimming rules already implemented this.

Fixes: NB#62765, NB#62748

pmo-trunk-r2625

13 years ago* fix logical ID bug #62763.
Dirk-Jan C. Binnema [Sat, 7 Jul 2007 14:26:10 +0000 (14:26 +0000)]
* fix logical ID bug #62763.
* while tracking this bug down, found that modest-platform was
  measuring string character lengths with strlen, changed this
  in g_utf8_strlen. also make the length check greater-than
  instead of equal, as copy-paste may change the length with
  more than one at a time.

pmo-trunk-r2624

13 years ago* trivial: make the zoomlevels in the editor follow the UI guidelines.
Dirk-Jan C. Binnema [Sat, 7 Jul 2007 13:19:28 +0000 (13:19 +0000)]
* trivial: make the zoomlevels in the editor follow the UI guidelines.
  fixes: NB#62269

pmo-trunk-r2623

13 years ago2007-07-06 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 6 Jul 2007 21:17:55 +0000 (21:17 +0000)]
2007-07-06  Murray Cumming <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
        Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
        give a more exact error message that can be partly translated.

pmo-trunk-r2622

13 years ago * Added msg-changed signal to the viewer window, to notify about the change in the...
Sergio Villar Senin [Fri, 6 Jul 2007 19:38:21 +0000 (19:38 +0000)]
* Added msg-changed signal to the viewer window, to notify about the change in the message that it is shown
* Fixes NB#62532, only prevent the message currently being shown from deleting

pmo-trunk-r2621

13 years ago* Fixed bug on header-view-render, getting header flags.
Javier Fernandez Garcia-Boente [Fri, 6 Jul 2007 18:03:36 +0000 (18:03 +0000)]
* Fixed bug on header-view-render, getting header flags.

pmo-trunk-r2620

13 years ago* Uncomment flush call to tny_send_queue.
Javier Fernandez Garcia-Boente [Fri, 6 Jul 2007 17:51:08 +0000 (17:51 +0000)]
* Uncomment flush call to tny_send_queue.
* Implement cancel sending operation, seting the
TNY_HEADER_FLAG_SUSPENDED_PRIORITY flag.

pmo-trunk-r2619

13 years ago* src/widgets/modest-attachment-view.c:
Jose Dapena Paz [Fri, 6 Jul 2007 16:26:31 +0000 (16:26 +0000)]
* src/widgets/modest-attachment-view.c:
        * Now purged attachments are shown in grey and italics.

pmo-trunk-r2618

13 years ago* src/widgets/modest-attachment-view.c:
Jose Dapena Paz [Fri, 6 Jul 2007 16:15:40 +0000 (16:15 +0000)]
* src/widgets/modest-attachment-view.c:
        * Now it retrieves the mime part size properly even when it was
          local.

pmo-trunk-r2617

13 years ago* src/modest-mail-operation.c:
Jose Dapena Paz [Fri, 6 Jul 2007 15:59:17 +0000 (15:59 +0000)]
* src/modest-mail-operation.c:
        * Now we store the attachments flag in the header of the
          message to store. This way the attachment gets correctly stored
          in local folders (fixes NB#61809).

pmo-trunk-r2616

13 years ago * Execute all pending gtk+ events before destroying the dialogs
Sergio Villar Senin [Fri, 6 Jul 2007 15:27:32 +0000 (15:27 +0000)]
* Execute all pending gtk+ events before destroying the dialogs

pmo-trunk-r2615

13 years ago* src/widgets/modest-attachment-view.c:
Jose Dapena Paz [Fri, 6 Jul 2007 14:43:49 +0000 (14:43 +0000)]
* src/widgets/modest-attachment-view.c:
        * Count the decoded attachment size instead of the encoded size.
          This should make the size be the expected one (fixes NB#61088).

pmo-trunk-r2614

13 years agoAdded the fixes made on july 6th.
Dirk-Jan C. Binnema [Fri, 6 Jul 2007 14:31:14 +0000 (14:31 +0000)]
Added the fixes made on july 6th.

pmo-trunk-r2613

13 years ago2007-07-06 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 6 Jul 2007 13:52:59 +0000 (13:52 +0000)]
2007-07-06  Murray Cumming  <murrayc@murrayc.com>

* libtinymail/tny-enums.h:
* libtinymail/tny-error.h: Added
TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED,
TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE and
TNY_ACCOUNT_ERROR_TRY_CONNECT_AUTHENTICATION_NOT_SUPPORTED so
that the TnyAccountStore::alert_func() callback can sometimes get
more specific information, so that it doesn't need to just blindly show
the camel internal error message.
* libtinymail/tny-error.c: Updated tny_error_get_type(), though this should be
generated code as in GTK+.

* libtinymail-camel/tny-camel-account-priv.h:
* libtinymail-camel/tny-camel-account.c:
Added _tny_camel_account_get_tny_error_code_for_camel_exception_id() for
choosing a suitable tinymail GError code.
(_tny_camel_account_try_connect), (_tny_camel_account_set_online):
Use a specific error code for the GErrors.

* libtinymail-camel/tny-session-camel.c:
(tny_session_camel_alert_user): Add a TODO noting that this is where we
lose some specific error codes, and where we do a dodgy string comparison
on the message text.

* camel/camel-exception-list.def: Added a
CAMEL_EXCEPTION_SYSTEM_HOST_LOOKUP_FAILED error code enum value.
* camel/camel-net-utils.c: (camel_getaddrinfo):
Use the new error code when appropriate.

pmo-trunk-r2612

13 years agoApplied patch for NB#59107.
Dirk-Jan C. Binnema [Fri, 6 Jul 2007 13:39:12 +0000 (13:39 +0000)]
Applied patch for NB#59107.

pmo-trunk-r2611

13 years agoApplied patch for NB#57631
Dirk-Jan C. Binnema [Fri, 6 Jul 2007 13:38:43 +0000 (13:38 +0000)]
Applied patch for NB#57631

pmo-trunk-r2610

13 years agoApplied the patch sent for NB#59004. changes to en_GB.po and src/maemo/modest-msg...
Dirk-Jan C. Binnema [Fri, 6 Jul 2007 13:33:04 +0000 (13:33 +0000)]
Applied the patch sent for NB#59004. changes to en_GB.po and src/maemo/modest-msg-view-window.c

pmo-trunk-r2609

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Fri, 6 Jul 2007 13:22:09 +0000 (13:22 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Removed all insenstive handlers for menu actions, as we don't show
          insensitive information banners from menus, only from toolbar
* src/widgets/modest-attachments-view.c:
        * Lose selection when the window focus leaves (fixes NB#61455).

pmo-trunk-r2608

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Fri, 6 Jul 2007 11:02:04 +0000 (11:02 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * The base font scale of wpeditor is 1.5, and not one. Then, we multiply
          by 1.5 all the zooms set to the wptextbuffer. This way we get the proper
          font scale.

pmo-trunk-r2607

13 years ago * Fixes NB#57458, now the currently selected folder is refreshed when doing a send...
Sergio Villar Senin [Fri, 6 Jul 2007 10:05:32 +0000 (10:05 +0000)]
* Fixes NB#57458, now the currently selected folder is refreshed when doing a send&receive

pmo-trunk-r2606

13 years ago* Disable notifications for dimmed menu items.
Javier Fernandez Garcia-Boente [Fri, 6 Jul 2007 09:28:52 +0000 (09:28 +0000)]
* Disable notifications for dimmed menu items.
* Fixes: NB#62283, NB#62392, NB#62398, NB#61244, NB#61501

pmo-trunk-r2605

13 years ago* check the parameters for
Dirk-Jan C. Binnema [Fri, 6 Jul 2007 09:13:00 +0000 (09:13 +0000)]
* check the parameters for
   modest_tny_account_store_get_transport_account_for_open_connection
  this fixes the crasher when other applications where invoking email over dbus
  while there were no accounts yet (bug #61676)

pmo-trunk-r2604

13 years ago* unitialize modest-window-mgr before the other singletons, so
Dirk-Jan C. Binnema [Fri, 6 Jul 2007 07:10:51 +0000 (07:10 +0000)]
* unitialize modest-window-mgr before the other singletons, so
  it can still save it's settings etc. in its finalize
  (this was causing GLib-Criticals upon exit in some cases,
  as well as forgetting settings)
* before doing gtk_main_quit in modest-window-mgr, check that we
  haven't already done that (not sure if we actually *ever* should
  call gtk_main_quit there, but at least now this clears up
  another Glib-Critical upon exit in some cases

pmo-trunk-r2603

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Thu, 5 Jul 2007 20:32:12 +0000 (20:32 +0000)]
* src/maemo/modest-msg-view-window.c:
        * (..._find_toolbar_search): invalidate search if there are no
          matches, just as we do with search complete (fixes NB#62257).

pmo-trunk-r2602

13 years agoWork to improve drafts handling, mainly from the UI pov. This, with
Jose Dapena Paz [Thu, 5 Jul 2007 20:23:03 +0000 (20:23 +0000)]
Work to improve drafts handling, mainly from the UI pov. This, with
the last changes in tinymail, fixes NB#62652.
* src/widgets/modest-platform.h, src/maemo/modest-platform.c:
        * Added new function modest_platform_run_yes_no_dialog. It's
          required in some dialogs in specs.
* src/widgets/modest-msg-edit-window.h,
  src/maemo/modest-msg-edit-window.c:
        * New method to set the draft message from outside. This is used
          to properly update the draft message when it's a new one.
        * On setting a new draft message, it replaces the registered
          header in the window manager. This way we can open a drafts
          message more than one time.
* src/widgets/modest-window-mgr.c:
        * Now the save to drafts confirmation dialog shows Yes/no
          alternatives instead of Ok/Cancel.
* src/modest-ui-actions.c:
        * Now, when a draft is saved from the editor, we set the
          created draft as the new draft message of editor. This
          should make saving drafts more than one time work as
          expected.
* src/modest-mail-operation.[ch]:
        * Now ..._save_to_drafts returns the newly created message.

pmo-trunk-r2601

13 years ago* Set focus on next header after drag&drop operaiton.
Javier Fernandez Garcia-Boente [Thu, 5 Jul 2007 19:08:12 +0000 (19:08 +0000)]
* Set focus on next header after drag&drop operaiton.
* Fixes: NB#61502

pmo-trunk-r2600

13 years ago* Delete dimming rule about NON_WRITABLE folders.
Javier Fernandez Garcia-Boente [Thu, 5 Jul 2007 18:36:35 +0000 (18:36 +0000)]
* Delete dimming rule about NON_WRITABLE folders.
* Fixes: NB#62603

pmo-trunk-r2599

13 years ago* Add a new check of toolbar dimming rules
Javier Fernandez Garcia-Boente [Thu, 5 Jul 2007 18:03:53 +0000 (18:03 +0000)]
* Add a new check of toolbar dimming rules
on 'focus-in' event of both, folder view
and headers view windows.
* Fixes: NB#61029

pmo-trunk-r2598

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Thu, 5 Jul 2007 17:34:32 +0000 (17:34 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now constructor checks the folder of the msg parameter.
          Only if it's in a drafts folder, it asigns it to the
          drafts_msg parameter. SHould prevent a warning when
          you save a draft and the message does not come from
          another draft.

pmo-trunk-r2597

13 years ago2007-07-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 5 Jul 2007 16:09:44 +0000 (16:09 +0000)]
2007-07-05  Murray Cumming <murrayc@murrayc.com>

* src/maemo/modest-address-book.c:
        (select_email_addrs_for_contact): Specify a default window size for the
        select-email-address dialog, so that it is probably big enough for the
        title. This should fix projects.maemo.org bug NB#62277.

pmo-trunk-r2596

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Thu, 5 Jul 2007 15:43:06 +0000 (15:43 +0000)]
* src/modest-ui-actions.c:
        * Now we add set_can_store to copy actions, so that the buffer
          survives application end.
        * Removed a typo using a call to header view in clipboard
          handler of text view (removes a runtime warning).
* src/modest-msg-edit-window.c:
        * Register serialize and deserialize target for wp-text-buffer.
          This way we can cut/copy/paste rich text among buffers
          (fixes NB#62365).
        * Now the dimming detection for copy simply detects there's a
          selection available. This way we can properly copy a selection
          with only an image (fixes NB#62416).
* src/modest-main-window.c:
        * Remove rules hint of header view (this way it does not show
          alternate colors for rows, as stated in specs).

pmo-trunk-r2595

13 years ago2007-07-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 5 Jul 2007 14:19:35 +0000 (14:19 +0000)]
2007-07-05  Murray Cumming <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_complete_easysetup): Use
        gtk_widget_set_size() request to ensure that the text wraps
        even in osso 1.1.

pmo-trunk-r2594

13 years ago * Fixes a compilation warning in ARMEL
Sergio Villar Senin [Thu, 5 Jul 2007 14:15:30 +0000 (14:15 +0000)]
* Fixes a compilation warning in ARMEL

pmo-trunk-r2593

13 years ago2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Thu, 5 Jul 2007 14:05:32 +0000 (14:05 +0000)]
2007-07-05  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
(on_entry_invalid_character), (create_page_account_details),
(create_page_user_details):
Use new API of ModestValidatingEntry. But for some reason the banner is
not shown. I will have to investigate that further.

* src/widgets/modest-validating-entry.c: (on_insert_text),
(modest_validating_entry_set_func):
* src/widgets/modest-validating-entry.h:
Added a new callback function to be able to react to prevented
characters whitespaces to e.g show a banner.

pmo-trunk-r2592

13 years ago2007-07-05 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Thu, 5 Jul 2007 13:53:08 +0000 (13:53 +0000)]
2007-07-05  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-account-settings-dialog.c: Use the notify::value
notification of HildonNumberEditor instead of remembering the port
number. Thanks to Johannes for pointing this out.

pmo-trunk-r2591

13 years agoAdded the fixes made on w27, day 4.
Dirk-Jan C. Binnema [Thu, 5 Jul 2007 13:32:59 +0000 (13:32 +0000)]
Added the fixes made on w27, day 4.

pmo-trunk-r2590

13 years agofixed bug number...
Johannes Schmid [Thu, 5 Jul 2007 13:32:41 +0000 (13:32 +0000)]
fixed bug number...

pmo-trunk-r2589

13 years ago2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Thu, 5 Jul 2007 13:28:10 +0000 (13:28 +0000)]
2007-07-05  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
Check if there are any user changes before showing a confirmation
dialog (projects.maemo.org NB#59361)

pmo-trunk-r2588

13 years agoAdded an extra folder to be looked into to confirm with the changes made to osso...
Dirk-Jan C. Binnema [Thu, 5 Jul 2007 13:24:11 +0000 (13:24 +0000)]
Added an extra folder to be looked into to confirm with the changes made to osso-af-settings.

pmo-trunk-r2587

13 years ago2007-07-05 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Thu, 5 Jul 2007 12:58:00 +0000 (12:58 +0000)]
2007-07-05  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-account-settings-dialog.c: Remember custom port
number at the beginning of the dialog and set the modified flag at the
end if the port number has changed. This is necessary because
HildonNumberEditor does not support notification when the value has
changed.

pmo-trunk-r2586

13 years ago * Changed the signature of the refresh folder callback. This will allow us to know...
Sergio Villar Senin [Thu, 5 Jul 2007 11:16:27 +0000 (11:16 +0000)]
* Changed the signature of the refresh folder callback. This will allow us to know if the operation was a success or not

pmo-trunk-r2585

13 years ago* Change save_settings call of main and viewer windows to
Javier Fernandez Garcia-Boente [Thu, 5 Jul 2007 10:37:37 +0000 (10:37 +0000)]
* Change save_settings call of main and viewer windows to
'delete-event' signal handler at modest-window-mgr.
* Review Copy menu item dimming rules.
* Fixes: NB#62502, NB#62342

pmo-trunk-r2584

13 years agoRenamed a symbol that has changed in tinymail
Philip Van Hoof [Thu, 5 Jul 2007 10:05:34 +0000 (10:05 +0000)]
Renamed a symbol that has changed in tinymail

pmo-trunk-r2583

13 years ago2007-07-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 5 Jul 2007 09:56:15 +0000 (09:56 +0000)]
2007-07-05  Murray Cumming <murrayc@murrayc.com>

* src/modest-ui-actions.c:
(modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
a connection before asking anything else. Correct the check for the destination
folder so that it succeeds when online.
This fixed projects.maemo.org bug NB#61645.

pmo-trunk-r2582

13 years ago2007-07-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 5 Jul 2007 09:41:39 +0000 (09:41 +0000)]
2007-07-05  Murray Cumming <murrayc@murrayc.com>

* src/modest-ui-actions.c: (modest_ui_actions_on_send):
Call modest_platform_connect_and_wait() to ask for a connection if necessary,
to fix projects.maemo.org bug NB#62439.

pmo-trunk-r2581

13 years ago2007-07-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 5 Jul 2007 07:11:41 +0000 (07:11 +0000)]
2007-07-05  Murray Cumming <murrayc@murrayc.com>

* src/modest-tny-account.c: (on_connection_status_changed):
Really do not use tny_device_force_offline() here. See the previous comment.

pmo-trunk-r2580

13 years ago* show the size unit correctly for the local Total size
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 17:59:51 +0000 (17:59 +0000)]
* show the size unit correctly for the local Total size
  Fixes: NB#62594

(the bug is about MCC folders, but this issues applies to
   all local folders)

pmo-trunk-r2579

13 years ago2007-07-04 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 4 Jul 2007 17:37:38 +0000 (17:37 +0000)]
2007-07-04  Murray Cumming <murrayc@murrayc.com>

* src/modest-tny-account.c: (on_connection_status_changed):
        Do not use tny_device_force_offline() when tinymail says that something
        went wrong with the connection. It seems to report this unnecessarily.

pmo-trunk-r2578

13 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Wed, 4 Jul 2007 17:35:28 +0000 (17:35 +0000)]
* src/maemo/modest-main-window.c:
        * Now proper Contextual menus for header view
          are shown, depending on the type of folder (drafts, sent,
          outbox, inbox...) (fixes NB#60352, NB#60355, NB#60356).

pmo-trunk-r2577

13 years ago* closing ModestMsgEditWindows with attachments no longer crashes modest
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 17:28:27 +0000 (17:28 +0000)]
* closing ModestMsgEditWindows  with attachments no longer crashes modest
  there was some confusion when TnyMimeParts were treated as gchar*s....

Fixes: NB#62598

pmo-trunk-r2576

13 years ago* copy the list of attachments; this fixes the first
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 17:02:33 +0000 (17:02 +0000)]
* copy the list of attachments; this fixes the first
  crash when closing a edit window with a message with an attachment

pmo-trunk-r2575

13 years ago2007-07-04 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 4 Jul 2007 16:58:03 +0000 (16:58 +0000)]
2007-07-04  Murray Cumming <murrayc@murrayc.com>

* src/maemo/modest-connection-specific-smtp-window.c:
(modest_connection_specific_smtp_window_init):
Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
does not seem to have any effect in osso 1.1 (though it works in
Maemo Bora). This fixes bug projects.maemo.org NB#59212.

pmo-trunk-r2574

13 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Wed, 4 Jul 2007 16:15:36 +0000 (16:15 +0000)]
* src/widgets/modest-folder-view.c:
        * Now folders get proper expanded/collapsed emblems. This
          way we can know if a folder has children (fixes NB#60310).

pmo-trunk-r2573

13 years agoAdded new bugs, bulding package for w27-04-1830.
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 15:35:02 +0000 (15:35 +0000)]
Added new bugs, bulding package for w27-04-1830.

pmo-trunk-r2572

13 years ago2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 4 Jul 2007 15:31:24 +0000 (15:31 +0000)]
2007-07-04  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/modest-connection-specific-smtp-window.c:
Fix UI specification problems with projects.meamo.org NB#60479

pmo-trunk-r2571

13 years ago2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 4 Jul 2007 14:58:09 +0000 (14:58 +0000)]
2007-07-04  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/modest-connection-specific-smtp-window.c:
Fix UI specification problems with projects.meamo.org NB#60479

pmo-trunk-r2570

13 years ago2007-07-04 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 4 Jul 2007 14:23:38 +0000 (14:23 +0000)]
2007-07-04   Murray Cumming <murrayc@murrayc.com>

* src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
clue when this has failed, because the error dialog is not always shown
(at least in earlier version).

(modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
GError message, because the generic error dialog is not helpful.
I am getting
'This message is not currently available (can't let a new connection go online)'
when trying to open an IMAP message.

(_modest_ui_actions_open): Offer a connection when some messages would
have to be downloaded and we are offline.

pmo-trunk-r2569

13 years ago2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 4 Jul 2007 14:01:11 +0000 (14:01 +0000)]
2007-07-04  Johannes Schmid <johannes.schmid@openismus.com>

* src/widgets/modest-folder-view.c:
Don\'t check for MERGE type anymore as we use the correct type
now.
NOTE: For the last two changes you need to update your tinymail copy
because of API changes!

pmo-trunk-r2568

13 years ago2007-07-04 Johanens Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 4 Jul 2007 13:48:47 +0000 (13:48 +0000)]
2007-07-04  Johanens Schmid <johannes.schmid@openismus.com>

* src/modest-tny-local-folders-account.c:
Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
(see projects.maemo.org NB#61580)

pmo-trunk-r2567

13 years agoCorrected the versioning mistake.
Dirk-Jan C. Binnema [Wed, 4 Jul 2007 13:43:44 +0000 (13:43 +0000)]
Corrected the versioning mistake.

pmo-trunk-r2566