modest
13 years ago* src/modest-tny-msg.c:
Jose Dapena Paz [Wed, 19 Sep 2007 14:15:40 +0000 (14:15 +0000)]
* src/modest-tny-msg.c:
        * Prevent a crash when we didn't get a message in the body.
* src/modest-ui-dimming-rules.c:
        * In main window, if focus is on folder view, and no folder is
          selected, details should be dimmed (fixes NB#64991).

pmo-trunk-r3352

13 years ago* optimize the parsing of the provider data, particularly the
Dirk-Jan C. Binnema [Wed, 19 Sep 2007 11:49:20 +0000 (11:49 +0000)]
* optimize the parsing of the provider data, particularly the
  parsing of the countries list; that one showed up high in
  oprofile

basically, we take the (reasonable) assumptions that the
  lines have a fixed max len and are valid ascii. this allows
  us to get rid of all mem allocs. also, we just the
  clustered-by-mcc values (the provider data has been adapted
  for this), and with that we can get rid of a lot of strcmps

  this all should help with NB#64324

pmo-trunk-r3343

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Wed, 19 Sep 2007 09:12:06 +0000 (09:12 +0000)]
* src/modest-ui-actions.c:
        * (open_msg_for_purge_cb): fixed usage of iterators. We were
          resetting the iterator to the first position and this was not
          working properly. Also removed a code that wasn't working for
          freeing the referenced attachments.
* src/modest-ui-dimming-rules.c:
        * (modest_ui_dimming_rules_on_remove_attachments): fixed a typo
          that was making the dimming rule fail (fixes NB#65901).

pmo-trunk-r3337

13 years ago* use hildon_uri_get_actions_by_uri instead of just _get_actions, to
Dirk-Jan C. Binnema [Wed, 19 Sep 2007 08:11:22 +0000 (08:11 +0000)]
* use hildon_uri_get_actions_by_uri instead of just _get_actions, to
  make it a bit more intelligent if an URI is e.g. only for mediaplayer

pmo-trunk-r3334

13 years ago* src/widgets/modest-attachments-view.c:
Jose Dapena Paz [Tue, 18 Sep 2007 22:23:08 +0000 (22:23 +0000)]
* src/widgets/modest-attachments-view.c:
        * Now, if we delete a selected attachment, and selection is
          after this empty, then we select the next attachment
          (fixes NB#65447).

pmo-trunk-r3332

13 years ago* src/widgets/modest-recpt-editor.c:
Jose Dapena Paz [Tue, 18 Sep 2007 17:38:10 +0000 (17:38 +0000)]
* src/widgets/modest-recpt-editor.c:
        * (modest_recpt_editor_on_button_release_event): don't force
          the cursor movement to the end in case selection is not
          changed.
        * (modest_recpt_editor_on_key_press_event): for Return, choose
          insert or selection mark (the one with higher offset).
          (fixes NB#65960).

pmo-trunk-r3331

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 18 Sep 2007 16:57:13 +0000 (16:57 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Prevent a crash with the new clipboard text storing
  method.

pmo-trunk-r3330

13 years ago* src/widgets/modest-msg-edit-window.h:
Jose Dapena Paz [Tue, 18 Sep 2007 16:13:36 +0000 (16:13 +0000)]
* src/widgets/modest-msg-edit-window.h:
        * Added method *_get_clipboard_text to get the last clipboard
          text in selection clipboard.
* src/maemo/modest-msg-edit-window.c:
        * Added implementation of *_get_clipboard_text. We set this on
          clipboard change handler.
* src/maemo/modest-msg-edit-window-ui-dimming.h:
        * Now we set check the paste dimming rule in standard menu
          group, as now this rule does not use clipboard wait functions.
          This way we can check if paste should be dimmed.
* src/modest-ui-dimming-rules.[ch]:
        * Now paste dimming rule for editor also sets it dimmed when
          focus is on a toggle button (just as when you're focusing
          the from combobox (fixes NB#65204).

pmo-trunk-r3329

13 years ago * Fixed an invalid g_object_ref without g_object_unref
Sergio Villar Senin [Tue, 18 Sep 2007 15:27:08 +0000 (15:27 +0000)]
* Fixed an invalid g_object_ref without g_object_unref
* Some code clean ups
* Removed some unused debug code
* Fixed an issue with drag&drop, the unselect of the source folder is now done properly
* Exported a private function to the modest-tny-folder API
* Changed the name and the signature of the callback of xfer mail operations
* Refactored the xfer_folder method
* Fixes NB#66340, d&d an user created folder to a subfolder is no longer possible
* Fixes NB#67817, focus is not lost anymore when transfer operations fails
* The "Pasting" info note is removed when the transfer operation fails

pmo-trunk-r3328

13 years agoAdded bugs fixed till 18th sept, to changelog.
Vivek Sekar [Tue, 18 Sep 2007 11:55:20 +0000 (11:55 +0000)]
Added bugs fixed till 18th sept, to changelog.

pmo-trunk-r3326

13 years ago* src/modest-tny-msg.c:
Jose Dapena Paz [Mon, 17 Sep 2007 21:03:35 +0000 (21:03 +0000)]
* src/modest-tny-msg.c:
* Now we use modest_formatter_quote instead of
  modest_formatter_inline, as quote quotes attachments in the
  resulting output (fixes NB#68169).

pmo-trunk-r3324

13 years ago* src/widgets/modest-msg-edit-window-ui.h:
Jose Dapena Paz [Mon, 17 Sep 2007 16:34:13 +0000 (16:34 +0000)]
* src/widgets/modest-msg-edit-window-ui.h:
* Prevent a warning with a toolbar button without name on
  creating a editor.

pmo-trunk-r3323

13 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Mon, 17 Sep 2007 16:06:33 +0000 (16:06 +0000)]
* src/modest-ui-dimming-rules.c:
        * As now we support purging attachments also in local folders
          we don't dim now. This, with the proper cahnge in tinymail,
          enable attachment purging in local folders (fixes NB#63986).

pmo-trunk-r3322

13 years agoAdapted to latest Tinymail API
Philip Van Hoof [Mon, 17 Sep 2007 15:48:38 +0000 (15:48 +0000)]
Adapted to latest Tinymail API

pmo-trunk-r3321

13 years ago * Fixes NB#66217, do not move the selection to the inbox if the user presses cancel...
Sergio Villar Senin [Mon, 17 Sep 2007 15:06:36 +0000 (15:06 +0000)]
* Fixes NB#66217, do not move the selection to the inbox if the user presses cancel on the the delete dialog

pmo-trunk-r3319

13 years ago * Fixes NB#66167, now the "unable to delete N messages" shows the number of messages...
Sergio Villar Senin [Mon, 17 Sep 2007 14:49:02 +0000 (14:49 +0000)]
* Fixes NB#66167, now the "unable to delete N messages" shows the number of messages that can not be deleted instead of the total number of selected messages
* Some code cleanups

pmo-trunk-r3318

13 years agoAdapted Modest to latest Tinymail API
Philip Van Hoof [Mon, 17 Sep 2007 14:42:00 +0000 (14:42 +0000)]
Adapted Modest to latest Tinymail API

pmo-trunk-r3317

13 years ago* src/widgets/modest-header-view-render.c:
Jose Dapena Paz [Mon, 17 Sep 2007 14:12:53 +0000 (14:12 +0000)]
* src/widgets/modest-header-view-render.c:
        * Now we escape the subjects to be added to the header subject
          cell, to prevent some warnings.
* src/modest-ui-actions.c:
        * (modest_ui_actions_on_delete_message): now we check if
          selection is empty to unselect it. We got the selection in
          main window case, but in message window selection is
          always NULL. We prevent a warning this way.
        * (new_messages_arrived): if new_headers is NULL, we don't show
          a warning.
* src/maemo/modest-msg-view-window.c:
        * (modest_msg_view_window_get_header): if the row reference is
          not valid, we return NULL without warnings.
        * (message_reader): now it uses a row reference instead of a
          path. This way the reference is valid even after deleting
          messages. This way deletion does not break the row references.
          And this way after deleting a message in viewer, the next
          message shown and the one you would delete are the same
          (fixes NB#63937). We use now row reference for all things
          related to retrieval of messages.
* src/modest-mail-operation.c:
        * Minor change.
* src/modest-ui-dimming-rules.c:
        * (_define_msg_view_window_dimming_state): if the header of the
          message view is NULL, we don't show a warning (happens on
          loading a new message to view).

pmo-trunk-r3316

13 years ago * Added a check in a g_object_ref, now it could happen that the object is NULL in...
Sergio Villar Senin [Mon, 17 Sep 2007 11:22:26 +0000 (11:22 +0000)]
* Added a check in a g_object_ref, now it could happen that the object is NULL in error cases
* Added a check in the new messages received, it could happen that the list is NULL when something wrong happens

pmo-trunk-r3315

13 years ago * Fixes NB#63512, do not show the "Internal message error ...." just ignore it
Sergio Villar Senin [Mon, 17 Sep 2007 10:49:09 +0000 (10:49 +0000)]
* Fixes NB#63512, do not show the "Internal message error ...." just ignore it

pmo-trunk-r3314

13 years ago * The connection specific SMTP accounts are added only once, because they...
Sergio Villar Senin [Fri, 14 Sep 2007 17:01:55 +0000 (17:01 +0000)]
    * The connection specific SMTP accounts are added only once, because they're shared by all the account
s. Some clenanups
        * I'm also commenting the function that adds them to the list of transport accounts. I do it beause this stuff is not correctly implemented and could cause SIGSEVs. See the comment in the code for more details

pmo-trunk-r3312

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Fri, 14 Sep 2007 13:57:24 +0000 (13:57 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now successful search changes focus to view in order to remove
  the vkb (fixes NB#59519).

pmo-trunk-r3309

13 years agoReconnecting after setting account settings
Philip Van Hoof [Fri, 14 Sep 2007 13:39:04 +0000 (13:39 +0000)]
Reconnecting after setting account settings

pmo-trunk-r3308

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Fri, 14 Sep 2007 11:42:42 +0000 (11:42 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Reenabled image replacement.

pmo-trunk-r3306

13 years ago* src/modest-tny-send-queue.c:
Jose Dapena Paz [Fri, 14 Sep 2007 11:35:19 +0000 (11:35 +0000)]
* src/modest-tny-send-queue.c:
        * (modest_tny_send_queue_get_msg_id): Now the message id is
          generated using the subject and the date received field.
          This way, the id is the same in outbox and sentbox folder.
          Then we can remove the message from send queue.
        * (_on_msg_has_been_sent): now we set the message as seen, so
          that the message is added to sent box as already readed. We
          also avoid showing the information banner when the message is
          not in this send queue (fixes NB#66511).

pmo-trunk-r3304

13 years ago * Do not play a sound when new message arrives if the user does not want to
Sergio Villar Senin [Fri, 14 Sep 2007 11:06:00 +0000 (11:06 +0000)]
* Do not play a sound when new message arrives if the user does not want to

pmo-trunk-r3302

13 years ago * Removed a duplicated method
Sergio Villar Senin [Fri, 14 Sep 2007 10:01:46 +0000 (10:01 +0000)]
* Removed a duplicated method
* Fixed an error in my last commit 3298, we can not use maemo specific calls in the ui actions
* Fixes NB#67017, a dbus callback was storing a new message in the drafts even before editing it

pmo-trunk-r3299

13 years ago * Fixes NB#63001, now we get errors if the SMTP connection fails
Sergio Villar Senin [Thu, 13 Sep 2007 18:42:18 +0000 (18:42 +0000)]
* Fixes NB#63001, now we get errors if the SMTP connection fails
* Fixed a GLIB_CRITICAL in send_receive method
* Moved the send queue handlers to modest_ui_actions, makes sense because these are common for both GNOME and Maemo
* Removed some unused commented code
* Added a couple of missing calls to redraw widgets in the case that we're using a gtk version < 2.8
* Removed some wrong code, that was creating the send queues in the main window added in commit 3208

pmo-trunk-r3298

13 years ago* use explicit tny_folder calls to get the number of (unread) messages;
Dirk-Jan C. Binnema [Thu, 13 Sep 2007 16:21:24 +0000 (16:21 +0000)]
* use explicit tny_folder calls to get the number of (unread) messages;
  apparently, the tree model is not always up-to-date.

this fixes (at least) the issue where the outbox count behaved funny

pmo-trunk-r3297

13 years agoUpdated Modest to the latest Tinymail API
Philip Van Hoof [Thu, 13 Sep 2007 13:45:19 +0000 (13:45 +0000)]
Updated Modest to the latest Tinymail API

pmo-trunk-r3296

13 years ago* get rid of guess_mime_type_from_name, use gnome_vfs_get_mime_from_name instead
Dirk-Jan C. Binnema [Thu, 13 Sep 2007 12:13:15 +0000 (12:13 +0000)]
* get rid of guess_mime_type_from_name, use gnome_vfs_get_mime_from_name instead

pmo-trunk-r3295

13 years agoAdded fixes to changelog. week38 pre release.
Vivek Sekar [Thu, 13 Sep 2007 11:27:27 +0000 (11:27 +0000)]
Added fixes to changelog. week38 pre release.

pmo-trunk-r3294

13 years ago* updated modest_platform_on_new_header_received a bit:
Dirk-Jan C. Binnema [Thu, 13 Sep 2007 09:07:42 +0000 (09:07 +0000)]
* updated modest_platform_on_new_header_received a bit:
- use the icon 'qgn_list_messagin' for the notifications
- small cosmetic cleanup

* Fixes: NB#66798

pmo-trunk-r3292

13 years ago* src/widgets/modest-recpt-editor.c:
Jose Dapena Paz [Wed, 12 Sep 2007 16:45:28 +0000 (16:45 +0000)]
* src/widgets/modest-recpt-editor.c:
        * Now, if you click a resolved recipient that's already
          selected, selection is dropped and cursor moves to the end
          (fixes NB#64776).
* src/maemo/modest-address-book.c:
        * Now check names sets the valid addresses also as resolved
          addresses.

pmo-trunk-r3290

13 years ago * Fixes NB#64132, message count in Drafts folder is now correct
Sergio Villar Senin [Wed, 12 Sep 2007 15:07:14 +0000 (15:07 +0000)]
* Fixes NB#64132, message count in Drafts folder is now correct
* Removed some unused debug code
* Properly initialization of the variable that determines if a folder is empty or not, this was causing a "no messages to show" bug

pmo-trunk-r3289

13 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Wed, 12 Sep 2007 10:45:24 +0000 (10:45 +0000)]
* src/widgets/modest-folder-view.c:
        * Added reexpand private attribute. This is enabled when there
          are new folders in folder view. Then, all the available
          folders are expanded at least in the first depth level. This
          is instead of always expanding on map (fixes NB#65051).
        * (expand_root_items): modified the method to expand the items.
          Now we iterate on all the root folders until there's no next
          folder, instead of only expanding on folders with children.
          This way the local folders are expanded always, even when
          remote root folder does not have children.
        * Now we scroll to the selected cell to highlight it.
        * Now we mark as selectable any new inbox folder added to the
          view. This is ok as we'll be only showing one remote inbox
          folder at a time.

pmo-trunk-r3284

13 years ago* build with -fPIC for the launcher
Dirk-Jan C. Binnema [Wed, 12 Sep 2007 09:16:58 +0000 (09:16 +0000)]
* build with -fPIC for the launcher

pmo-trunk-r3283

13 years ago * Added some checks that prevent glib criticals in some cases
Sergio Villar Senin [Wed, 12 Sep 2007 08:54:03 +0000 (08:54 +0000)]
* Added some checks that prevent glib criticals in some cases

pmo-trunk-r3282

13 years ago * Removed a connect_and_wait from the mail_operations because UI code is not allowed...
Sergio Villar Senin [Tue, 11 Sep 2007 16:40:20 +0000 (16:40 +0000)]
* Removed a connect_and_wait from the mail_operations because UI code is not allowed in that part of the code. Moved it to the UI actions
* Fixed an infinite loop in on_cert_dialog_response caused by a recursive gtk_dialog_response in the handler
* Fixed a logical id
* Removed some unused debug code
* Fixes NB#62237, new notification for invalid certificates (using some previous code from djcb)
* Fixes NB#60517, the Send&Receive option in the main menu no longer freezes the progress bar

pmo-trunk-r3278

13 years agoReverted tny_folder_sync to tny_folder_sync_async to solve 66145
Philip Van Hoof [Tue, 11 Sep 2007 15:20:29 +0000 (15:20 +0000)]
Reverted tny_folder_sync to tny_folder_sync_async to solve 66145

pmo-trunk-r3276

13 years ago2007-09-11 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 11 Sep 2007 14:20:10 +0000 (14:20 +0000)]
2007-09-11  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_set_account_name): Set the incoming
secure-auth checkbox only when a secure auth method is really specified
in gconf. For some reason, it was set also if a secure connection was
chosen, but that does not make sense to me, and was not commented.
For instance, this stops the user from seeing an error about unsupported
secure authentication when editing a gmail account.

pmo-trunk-r3274

13 years ago* src/maemo/easysetup/modest-easysetup-country-combo-box.c:
Jose Dapena Paz [Tue, 11 Sep 2007 12:05:25 +0000 (12:05 +0000)]
* src/maemo/easysetup/modest-easysetup-country-combo-box.c:
        * Now countries ellipsize if required to prevent cutting
          caption labels.
* src/maemo/easysetup/modest-easysetup-wizard.c:
        * CHange all labels to expand and wrap correctly (fixes
          NB#63507).
        * Add scrolled window to incoming page.
        * Add all pages to notebook with expand and fill properties
          enabled.

pmo-trunk-r3269

13 years ago* src/modest-dimming-rules-group.[ch]:
Jose Dapena Paz [Tue, 11 Sep 2007 09:17:43 +0000 (09:17 +0000)]
* src/modest-dimming-rules-group.[ch]:
        * Added new method modest_dimming_rules_group_add_widget_rule.
          This method connects a dimming rule to a widget in the group,
          so that we can connect rules to widgets outside an ui manager.
        * Refactored some code to add rules to the dimming rules group
          from the methods add_rules and add_widget_rule.
* src/modest-dimming-rule.[ch]:
        * Now dimming rules can be connected to widgets, not only to
          ui manager action paths.
        * Added new methods for getting the action path and connected
          widget from outside.
* src/gnome/modest-main-window.c:
        * Adapted to change in in modest_main_window_get_child_widget
          type.
* src/widgets/modest-msg-edit-window.h:
        * Added method modest_msg_edit_window_get_child_widget to access
          editor widgets from external methods (in particular from
          ui dimming rules).
        * Added methods to get can-undo and can-redo status.
* src/widgets/modest-msg-edit-window-ui.h:
        * Added ui action handlers for menu parents, so that we can run
          dimming rules.
* src/widgets/modest-main-window.h:
        * Changed modest_main_window_get_child_widget types to have a
          proper namespace (instead of MODEST_WIDGET_TYPE_* now we have
          MODEST_MAIN_WINDOW_WIDGET_TYPE_*).
* src/modest-ui-actions.[ch]:
        * Adapted calls to modest_main_window_get_child_widget new api.
        * Added new method modest_ui_actions_on_format_menu_activated,
          to run the dimming rules on showing the format menu.
* src/dbus_api/modest-dbus-callback.c:
        * Adapted calls to modest_main_window_get_child_widget new api.
* src/maemo/modest-msg-edit-window.c:
        * Removed insensitive handlers, as now they're managed in
          dimming manager. In particular, we remove methods
          send_insensitive_press, style_insensitive_press,
          setup_insensitive_handlers.
        * Added "move-cursor" signal handler subject_field_move_cursor.
          This is required because moving cursor in a way that drops
          selection in a GtkEntry does not change primary clipboard
          selection.
        * Removed methods to update dimming status, as this is now
          managed in dimming manager. In particular we drop
          update_dimmed, update_paste_dimming,
          update_remove_attachment_dimming, update_copy_cut_dimming,
          update_select_all_dimming, update_zoom_dimming,
          update_send_dimming.
        * Also removed methods to handle menu activation, as this is now
          handled in the ui manager.
        * Added methods to get the can_undo and can_redo status. This is
          updated through signal handlers of wptextbuffer, as this does
          not provide a method to check this on real time.
        * Added signal handler for owner change in default clipboard
          (required to manage properly paste dimming).
        * Now we use dimming rules for toolbar, menus and clipboard
          based actions. We also use specific dimming rule binding for
          the widgets that we don't get from ui manager (font size and
          face selection, color selection).
        * Implementation of new method
          modest_msg_edit_window_get_child_widget, to access children
          from outside (in particular from dimming rules).
* src/maemo/modest-platform.c:
        * Adapted calls to modest_main_window_get_child_widget new api.
* src/maemo/modest-msg-view-window.c:
        * Adapted calls to modest_main_window_get_child_widget new api.
* src/maemo/modest-main-window.c:
        * Adapted calls to modest_main_window_get_child_widget new api.
* src/modest-ui-dimming-rules.[ch]:
        * Adapted calls to modest_main_window_get_child_widget new api.
        * (..._on_select_all): added implementation for editor widget.
        * (..._on_undo): added implementation for editor widget.
        * New dimming rule ..._on_redo.
        * New dimming rule ..._on_set_style, for style operations of
          message editor.
        * New dimming rule ..._on_zoom for editor (we can only zoom
          when focus is on body).
        * New dimming rule ..._on_editor_paste. This operation depends
          on clipboard, so it cannot be hooked in menu activation
          methods.
        * New dimming rule ..._on_editor_remove_attachment for editor.
        * New dimming rule ..._on_send for editor.
        * Added support in _invalid_clipboard_selected for editor.

pmo-trunk-r3264

13 years ago * Fixes NB#64889, the connection specific SMTP window is closed now in response...
Sergio Villar Senin [Mon, 10 Sep 2007 17:53:56 +0000 (17:53 +0000)]
* Fixes NB#64889, the connection specific SMTP window is closed now in response to a Escape key press

pmo-trunk-r3261

13 years ago * Now it really fixes NB#64908, the accounts window is now modal and allow another...
Sergio Villar Senin [Mon, 10 Sep 2007 17:28:01 +0000 (17:28 +0000)]
* Now it really fixes NB#64908, the accounts window is now modal and allow another dialogs to be shown

pmo-trunk-r3259

13 years ago * Reopening NB#64908 because setting this dialog modal does not enable the user...
Sergio Villar Senin [Mon, 10 Sep 2007 17:12:32 +0000 (17:12 +0000)]
* Reopening NB#64908 because setting this dialog modal does not enable the user to access to the other dialogs that could be launched with the edit or new buttons

pmo-trunk-r3258

13 years ago * Fixes NB#64908, the account list window is now modal
Sergio Villar Senin [Mon, 10 Sep 2007 16:48:07 +0000 (16:48 +0000)]
* Fixes NB#64908, the account list window is now modal
* removed some code from maemo utils

pmo-trunk-r3257

13 years ago * Fixes NB#66420, warn the user before editing online accounts, the previous check...
Sergio Villar Senin [Mon, 10 Sep 2007 10:35:58 +0000 (10:35 +0000)]
* Fixes NB#66420, warn the user before editing online accounts, the previous check was not right, it was checking only that the account was doing a send receive
* Fixes a leak reference

pmo-trunk-r3252

13 years agoClipboard dimming rules shouldn't be run in show menu callbacks
Jose Dapena Paz [Mon, 10 Sep 2007 09:42:36 +0000 (09:42 +0000)]
Clipboard dimming rules shouldn't be run in show menu callbacks
(fixes NB#65033).
* src/maemo/modest-msg-view-window.c:
        * Use new clipboard dimming rules in owner change handler,
          and in widget startup.
* src/maemo/modest-msg-view-window-ui-dimming.h:
        * Create new clipboard dimming rules group, and move clipboard
          status depending rules from menu to the new group.

pmo-trunk-r3250

13 years ago * Fixed a typo
Sergio Villar Senin [Mon, 10 Sep 2007 08:41:15 +0000 (08:41 +0000)]
* Fixed a typo
* Uncommented some code

pmo-trunk-r3247

13 years ago * Changed the update_account_thread it now refreshes the INBOX and pokes the other...
Sergio Villar Senin [Fri, 7 Sep 2007 16:11:32 +0000 (16:11 +0000)]
* Changed the update_account_thread it now refreshes the INBOX and pokes the other folders
* Changed the signature of the signal that notifies about new messages
* Added the proper dbus call when new messages arrive to the notification
* replaced the old new_msg method of modest-platform by new_header_arrived
* Fixes NB#59971 adds message notifications, NB#63779 adds LED pattern to the notifications

pmo-trunk-r3246

13 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Fri, 7 Sep 2007 16:05:02 +0000 (16:05 +0000)]
* src/maemo/modest-main-window.c:
* Convert the View addittions menu items for selecting the
  currently viewed account to radio items (fixes NB#65054).

pmo-trunk-r3245

13 years ago * Fixed a leak reference
Sergio Villar Senin [Fri, 7 Sep 2007 14:47:21 +0000 (14:47 +0000)]
* Fixed a leak reference
* Added a g_object_ref because otherwise we're unreferencing too much the transport accounts and this caused a SIGSEV when finalizing the account store

pmo-trunk-r3244

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Fri, 7 Sep 2007 13:20:44 +0000 (13:20 +0000)]
* src/maemo/modest-msg-edit-window.c:
* We were resetting the format to the configuration one in
  editor instead of preserving the one of the original message.
  Removed that code (fixes NB#64077).

pmo-trunk-r3243

13 years ago* fix compiler warning
Dirk-Jan C. Binnema [Fri, 7 Sep 2007 11:59:44 +0000 (11:59 +0000)]
* fix compiler warning

pmo-trunk-r3242

13 years agoAdded bugs for the week 37-1 pre-release. 7th Sept
Vivek Sekar [Fri, 7 Sep 2007 10:59:14 +0000 (10:59 +0000)]
Added bugs for the week 37-1 pre-release. 7th Sept

pmo-trunk-r3239

13 years agoWhen moving messages to a local folder don't try to connect if the
Alberto Garcia [Fri, 7 Sep 2007 10:33:36 +0000 (10:33 +0000)]
When moving messages to a local folder don't try to connect if the
remote folder is POP3 and all messages are already cached. It's not
necessary as in POP3 all messages are removed from the server when
they're opened.

Fixes NB#65235

pmo-trunk-r3238

13 years ago* moved the tny alert dialog stuff to modest-platform
Dirk-Jan C. Binnema [Fri, 7 Sep 2007 10:11:00 +0000 (10:11 +0000)]
* moved the tny alert dialog stuff to modest-platform
* cleaned up the tnyalert handling a bit modest-tny-account-store
* implemented the SSL certificate handling dialogs; not hooked up yet

pmo-trunk-r3237

13 years ago* move the instantiation of modest-tny-account-store to modest runtime;
Dirk-Jan C. Binnema [Fri, 7 Sep 2007 09:50:23 +0000 (09:50 +0000)]
* move the instantiation of modest-tny-account-store to modest runtime;
  (from singletons). before, we were seeing various chicken & egg problems,
  and Glib-Criticals at startup.

pmo-trunk-r3236

13 years agoDon't ask for confirmation on modest_ui_actions_xfer_messages_from_move_to(), it...
Alberto Garcia [Fri, 7 Sep 2007 09:01:53 +0000 (09:01 +0000)]
Don't ask for confirmation on modest_ui_actions_xfer_messages_from_move_to(), it's redundant

pmo-trunk-r3235

13 years ago * Removed a duplicated save_state call
Sergio Villar Senin [Fri, 7 Sep 2007 07:32:10 +0000 (07:32 +0000)]
* Removed a duplicated save_state call

pmo-trunk-r3233

13 years agoUpdated to Tinymail's recent API change
Philip Van Hoof [Thu, 6 Sep 2007 20:05:49 +0000 (20:05 +0000)]
Updated to Tinymail's recent API change

pmo-trunk-r3232

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Thu, 6 Sep 2007 17:35:21 +0000 (17:35 +0000)]
* src/maemo/modest-msg-view-window.c:
* Added a method that catches move-focus signal. In case the
  focus is on attachments view, it stops signal handler,
  preventing this way the focus (fixes NB#66802).

pmo-trunk-r3231

13 years ago* src/maemo/modest-maemo-global-settings-dialog.c:
Jose Dapena Paz [Thu, 6 Sep 2007 17:17:59 +0000 (17:17 +0000)]
* src/maemo/modest-maemo-global-settings-dialog.c:
* Added "notify" signal handler for the size limit
  editor. This way we track the value. If the value is 0
  we dim it (fixes NB#62647).

pmo-trunk-r3230

13 years ago* Select previous row if last rheader is deleted.
Javier Fernandez Garcia-Boente [Thu, 6 Sep 2007 13:58:20 +0000 (13:58 +0000)]
* Select previous row if last rheader is deleted.
* Fixes: NB#65265

pmo-trunk-r3228

13 years agoDon't pass the GtkWindow to header_list_count_uncached_msgs(), it's
Alberto Garcia [Thu, 6 Sep 2007 13:46:31 +0000 (13:46 +0000)]
Don't pass the GtkWindow to header_list_count_uncached_msgs(), it's
not necessary.

pmo-trunk-r3227

13 years ago* fix for NB#63690
Dirk-Jan C. Binnema [Thu, 6 Sep 2007 12:47:48 +0000 (12:47 +0000)]
* fix for NB#63690

pmo-trunk-r3226

13 years ago* src/modest-mail-operation.c:
Jose Dapena Paz [Thu, 6 Sep 2007 11:01:27 +0000 (11:01 +0000)]
* src/modest-mail-operation.c:
* (idle_create_msg_cb): do gdk_threads_leave to protect also
  the unref's, as they can cause locks (fixes NB#65540).

pmo-trunk-r3225

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Wed, 5 Sep 2007 21:25:58 +0000 (21:25 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now set zoom updates the radio menu option properly
  (fixes NB#65274).

pmo-trunk-r3222

13 years ago* src/modest-tny-folder.c:
Jose Dapena Paz [Wed, 5 Sep 2007 19:46:31 +0000 (19:46 +0000)]
* src/modest-tny-folder.c:
* (modest_tny_folder_guess_folder_type_from_name): fixed
  this function. We were downcasing the name, but not the
  strings we were comparing with (fixes NB#65059).

pmo-trunk-r3221

13 years ago* Check for opened edit-windows before close all windows.
Javier Fernandez Garcia-Boente [Wed, 5 Sep 2007 17:55:28 +0000 (17:55 +0000)]
* Check for opened edit-windows before close all windows.
* Fixes: NB#64364

pmo-trunk-r3220

13 years ago* src/maemo/modest-account-settings-dialog.c:
Jose Dapena Paz [Wed, 5 Sep 2007 16:07:39 +0000 (16:07 +0000)]
* src/maemo/modest-account-settings-dialog.c:
* Now the account details tab is also including a scroll to
  prevent some weird problems that hide the buttons sometimes
  (fixes NB#64537).

pmo-trunk-r3219

13 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Wed, 5 Sep 2007 13:49:44 +0000 (13:49 +0000)]
* src/maemo/modest-main-window.c:
* Pending change for disabling toggling cut/copy/paste CSM actions in main menu.

pmo-trunk-r3218

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Wed, 5 Sep 2007 12:50:35 +0000 (12:50 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Rework the cut/copy dimming in editor in order to be accurate
  (fixes NB#63877).

pmo-trunk-r3217

13 years ago* Add information banner (Opening) when user open
Javier Fernandez Garcia-Boente [Wed, 5 Sep 2007 12:01:59 +0000 (12:01 +0000)]
* Add information banner (Opening) when user open
messages from Draft or Outbox folders.
* Fixes: NB#64296

pmo-trunk-r3215

13 years agounified all the bugs into a single entry in the changelog, for week 36 - release...
Vivek Sekar [Wed, 5 Sep 2007 11:36:23 +0000 (11:36 +0000)]
unified all the bugs into a single entry in the changelog, for week 36 - release, 05th sept.

pmo-trunk-r3213

13 years ago* src/modest-mail-operation.c:
Jose Dapena Paz [Wed, 5 Sep 2007 09:35:04 +0000 (09:35 +0000)]
* src/modest-mail-operation.c:
* Now we only show the move folder error as copy is not
  present in translation.

pmo-trunk-r3212

13 years ago2007-09-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 5 Sep 2007 08:35:02 +0000 (08:35 +0000)]
2007-09-05  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-utils.c:
(on_camel_account_get_supported_secure_authentication),
(modest_maemo_utils_get_supported_secure_authentication_methods):
Adapted to the changed tinymail signature of the callback, and
printf a warning when there is an exception, as a clue.

pmo-trunk-r3211

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 4 Sep 2007 16:11:41 +0000 (16:11 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now we use the primary selection clipboard for checking
  cut/copy dimming (fixes NB#62432).

pmo-trunk-r3209

13 years ago* Fixed some strange behaviour on send-queues and
Javier Fernandez Garcia-Boente [Tue, 4 Sep 2007 16:05:40 +0000 (16:05 +0000)]
* Fixed some strange behaviour on send-queues and
sending status management.

pmo-trunk-r3208

13 years ago* src/widgets/modest-msg-view.c:
Jose Dapena Paz [Tue, 4 Sep 2007 15:47:13 +0000 (15:47 +0000)]
* src/widgets/modest-msg-view.c:
* Reenabled message view scroll on find in page (fixes
  NB#62258).

pmo-trunk-r3207

13 years ago* src/maemo/modest-retrieve-combo-box.c:
Jose Dapena Paz [Tue, 4 Sep 2007 15:43:00 +0000 (15:43 +0000)]
* src/maemo/modest-retrieve-combo-box.c:
* Finally disabled "messages" retrieval options. Now we only
  support "headers only" and "messages with attachments"
  options (fixes NB#58475).

pmo-trunk-r3206

13 years ago * Fixes NB#64093 the message count in folders is now recursive
Sergio Villar Senin [Tue, 4 Sep 2007 15:34:24 +0000 (15:34 +0000)]
* Fixes NB#64093 the message count in folders is now recursive

pmo-trunk-r3205

13 years ago* src/widgets/modest-recpt-view.c:
Jose Dapena Paz [Tue, 4 Sep 2007 15:33:54 +0000 (15:33 +0000)]
* src/widgets/modest-recpt-view.c:
* Grab focus on click, so that clipboard operations do what we
  expect them to do (fixes NB#64898).

pmo-trunk-r3204

13 years ago * Fixes NB#64415, now the show_toolbar options are per window type specific
Sergio Villar Senin [Tue, 4 Sep 2007 13:54:21 +0000 (13:54 +0000)]
* Fixes NB#64415, now the show_toolbar options are per window type specific
* Deleted some unused methods

pmo-trunk-r3202

13 years ago * Replaced the casting by a proper variable definition
Sergio Villar Senin [Tue, 4 Sep 2007 13:28:37 +0000 (13:28 +0000)]
* Replaced the casting by a proper variable definition

pmo-trunk-r3201

13 years agoCompilation warning
Philip Van Hoof [Tue, 4 Sep 2007 11:59:22 +0000 (11:59 +0000)]
Compilation warning

pmo-trunk-r3200

13 years ago* src/maemo/modest-main-window-ui-dimming.h:
Jose Dapena Paz [Tue, 4 Sep 2007 09:27:18 +0000 (09:27 +0000)]
* src/maemo/modest-main-window-ui-dimming.h:
* Removed the dimming rules for cut/copy/paste actions in main
  window.

pmo-trunk-r3199

13 years agoAdded fixed bugs. - week 36, 4th sept.
Vivek Sekar [Tue, 4 Sep 2007 09:24:52 +0000 (09:24 +0000)]
Added fixed bugs. -  week 36, 4th sept.

pmo-trunk-r3198

13 years ago* src/maemo/ui/modest-main-window-ui.xml:
Jose Dapena Paz [Tue, 4 Sep 2007 09:04:47 +0000 (09:04 +0000)]
* src/maemo/ui/modest-main-window-ui.xml:
* Removed cut/copy/paste actions from main window menus
  (fixes NB#67792).

pmo-trunk-r3197

13 years ago* src/widgets/modest-recpt-editor.c:
Jose Dapena Paz [Tue, 4 Sep 2007 09:03:02 +0000 (09:03 +0000)]
* src/widgets/modest-recpt-editor.c:
* Limited text insertion to 1024 characters. This should prevent
  getting too big input (fixes NB#64721).

pmo-trunk-r3196

13 years ago2007-09-03 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Mon, 3 Sep 2007 17:32:12 +0000 (17:32 +0000)]
2007-09-03  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-maemo-utils.c: Don't set the temporary account
online that checks for supported authentication methods. This fixes
projects.maemo.org bug NB#61369.

pmo-trunk-r3195

13 years agoChanged an idle to a non-idle because it's not needed anymore
Philip Van Hoof [Mon, 3 Sep 2007 16:58:43 +0000 (16:58 +0000)]
Changed an idle to a non-idle because it's not needed anymore

pmo-trunk-r3194

13 years agoAPI change
Philip Van Hoof [Mon, 3 Sep 2007 15:35:05 +0000 (15:35 +0000)]
API change

pmo-trunk-r3193

13 years ago2007-09-03 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 3 Sep 2007 14:20:07 +0000 (14:20 +0000)]
2007-09-03  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-folder-view.c: (strings_are_equal),
(on_model_foreach_set_name), (on_get_mmc_account_name),
(text_cell_data): Restored this code that was removed in
svn revision 3165 by jfernandez, because this late name-discovery
really is necessary sometimes. This is the correct fix to the endless
calling of this function:
* src/modest-tny-account.c: (on_modest_file_system_info):
Don't call tny_account_set_name() when the name is already correct,
to avoid unnecessary (endless) updates to the tree model.

pmo-trunk-r3192

13 years ago* fix for NB#67837, NB#63633
Dirk-Jan C. Binnema [Mon, 3 Sep 2007 13:33:42 +0000 (13:33 +0000)]
* fix for NB#67837, NB#63633
  - don't try to convert ' --> &apos; [ while technically correct,
    apparently, wpeditor does not like it
  - clean up writing of reply/forward msgs a bit. it could use more cleanup

pmo-trunk-r3191

13 years agoremoved 2 bugs to start integration. - week 36, 3rd sept.
Vivek Sekar [Mon, 3 Sep 2007 13:28:31 +0000 (13:28 +0000)]
removed 2 bugs to start integration. -  week 36, 3rd sept.

pmo-trunk-r3190

13 years agoAdded new fixes to changelog - week 36, 3rd sept.
Vivek Sekar [Mon, 3 Sep 2007 12:34:32 +0000 (12:34 +0000)]
Added new fixes to changelog -  week 36, 3rd sept.

pmo-trunk-r3188

13 years agoshow the correct icons for debian packages
Dirk-Jan C. Binnema [Mon, 3 Sep 2007 11:38:55 +0000 (11:38 +0000)]
show the correct icons for debian packages

pmo-trunk-r3187

13 years ago* Review dimming rules to detect when modest is sedning mails.
Javier Fernandez Garcia-Boente [Mon, 3 Sep 2007 11:30:20 +0000 (11:30 +0000)]
* Review dimming rules to detect when modest is sedning mails.
* Use the new tinymail API function to add mails to send queue
asynchronously.
* Fixes: NB#61607, NB#61952, NB#64146, NB#64924

pmo-trunk-r3186