modest
13 years ago2007-05-23 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 23 May 2007 14:05:45 +0000 (14:05 +0000)]
2007-05-23  Murray Cumming  <murrayc@murrayc.com>

Modest on-disk outbox directories are now here, for instance:
        /home/murrayc/.modest/outboxes/<account-id-1>/outbox
        /home/murrayc/.modest/outboxes/<account-id-2>/outbox
        instead of here:
        /home/murrayc/.modest/local-folders/outbox
        so we can have a separate outbox for each account.
        But they are shown as one outbox in the GtkTreeView, by using a
        TnyMergeFolder in a ModestTnySimpleFolderStore.

        * src/Makefile.am:
        * src/modest-tny-simple-folder-store.c:
        * src/modest-tny-simple-folder-store.h:
        Added ModestTnySimpleFolderStore, used to contain folders from
        other folder stores, such as other accounts.

        * src/modest-tny-outbox-account.h:
        * src/modest-tny-outbox-account.c:
        Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
        used for the per-account local outbox folders.

        * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
        MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
        only use this (internally) now for the non-outbox local folders.

        * src/modest-init.h:
        * src/modest-init.c: Added modest_init_one_local_folder(), for
        setting up the directory structure for each local folder.

        * src/modest-local-folder-info.c:
        (modest_per_account_local_outbox_folder_info_get_maildir_path),
        (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
        tbox_folder):
        * src/modest-local-folder-info.h:
        * src/modest-tny-account-store.c: (on_account_removed),
        (on_account_changed), (create_per_account_local_outbox_folders),
        (get_server_accounts), (modest_tny_account_store_get_accounts),
        (modest_tny_account_store_get_tny_account_by_account),
        (modest_tny_folder_store_is_virtual_local_folders):

        * src/modest-tny-account.h:
        * src/modest-tny-account.c:
        Added modest_tny_account_new_for_per_account_local_outbox_folder(),
        to create an on-disk per-account local outbox folder for each
        transport account.
        (create_per_account_local_outbox_folders): Create a local outbox folder
        for each transport account.
        (modest_tny_account_new_for_local_folders): Do not create an outbox folder
        for all local folders.

        Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
        instead of using g_object_get/set() directly. It is clearer.

        (modest_tny_folder_store_get_message_count),
        (modest_tny_folder_store_get_local_size
        (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
        because we now use these with non-acount folder stores.

        (modest_tny_account_get_special_folder),
        (modest_tny_account_new_from_server_account),
        (modest_tny_account_new_from_account):
        (recurse_folders): Adjust to the new outbox system.

        * src/modest-tny-folder.h:
        * src/modest-tny-folder.c:
        (modest_tny_folder_is_local_folder),
        (modest_tny_folder_get_local_folder_type),
        (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.

        * src/widgets/modest-main-window.h:
        * src/maemo/modest-main-window.c: (create_details_widget),
        (modest_main_window_set_contents_style): Show details for any folder store,
        not just accounts.

        (modest_tny_folder_get_rules):
        Remove the const. C does not support constness enough for this.

        * src/modest-ui-actions.c:
        update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
        make all outboxes appear as one, in the usual local-folders tree node.

        (set_active_account_from_tny_account),
        (modest_ui_actions_on_folder_selection_changed):
        * src/widgets/modest-folder-view.c: (text_cell_data),
        (icon_cell_data), (filter_row),
        (add_account_folders_to_merged_folder),
        (add_account_folders_to_simple_folder_store), (),
        (get_cmp_rows_type_pos), (cmp_rows),
        (modest_folder_view_set_account_id_of_visible_server_account):
        Adjust to the new outbox system, using generic folder stores and folder
        in the GtkTreeModel.

pmo-trunk-r1963

13 years ago2007-05-23 Christian Kellner <ckellner@openismus.com>
Christian Kellner [Wed, 23 May 2007 11:48:24 +0000 (11:48 +0000)]
2007-05-23  Christian Kellner  <ckellner@openismus.com>

* src/modest-mail-operation.c:
(modest_mail_operation_update_account):
Use info->max_size instead of unintialized local var [small
build fix]. (Added TODO to review that change since I don't
know the code)

pmo-trunk-r1962

13 years ago * First steps to apply global and per-account settings to send&receive
Sergio Villar Senin [Wed, 23 May 2007 08:20:29 +0000 (08:20 +0000)]
* First steps to apply global and per-account settings to send&receive

pmo-trunk-r1961

13 years ago * Fixes NB#57328
Sergio Villar Senin [Wed, 23 May 2007 07:30:54 +0000 (07:30 +0000)]
* Fixes NB#57328
* Fixed a memory leak

pmo-trunk-r1960

13 years ago2007-05-23 Marcus Bauer <marcusb@openismus.com>
Marcus Bauer [Wed, 23 May 2007 07:10:55 +0000 (07:10 +0000)]
2007-05-23  Marcus Bauer  <marcusb@openismus.com>

* libmodest-dbus-client/libmodest-dbus-client.c:
(libmodest_dbus_client_compose_mail): function added
* src/dbus_api/modest-dbus-api.h:
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
(on_compose_mail): Implementation of the SendAsMail functionality

pmo-trunk-r1959

13 years ago * Reverted the two new folder rules, both are NON_WRITABLE
Sergio Villar Senin [Tue, 22 May 2007 18:18:55 +0000 (18:18 +0000)]
* Reverted the two new folder rules, both are NON_WRITABLE

pmo-trunk-r1958

13 years ago * Added some missing rules to the xfer_folder and xfer_msgs operations
Sergio Villar Senin [Tue, 22 May 2007 17:54:40 +0000 (17:54 +0000)]
* Added some missing rules to the xfer_folder and xfer_msgs operations

pmo-trunk-r1956

13 years ago* move modest/scripts to modest-script (separate place)
Dirk-Jan C. Binnema [Tue, 22 May 2007 17:40:54 +0000 (17:40 +0000)]
* move modest/scripts to modest-script (separate place)

pmo-trunk-r1955

13 years ago* add some error error checking when trying to retrieve the device name
Dirk-Jan C. Binnema [Tue, 22 May 2007 17:39:18 +0000 (17:39 +0000)]
* add some error error checking when trying to retrieve the device name

pmo-trunk-r1954

13 years ago* remove wrong dep
Dirk-Jan C. Binnema [Tue, 22 May 2007 17:34:47 +0000 (17:34 +0000)]
* remove wrong dep

pmo-trunk-r1953

13 years ago* remove changelog2 in garage
Dirk-Jan C. Binnema [Tue, 22 May 2007 17:32:23 +0000 (17:32 +0000)]
* remove changelog2 in garage

pmo-trunk-r1952

13 years ago * Fixes: NB#57465
Sergio Villar Senin [Tue, 22 May 2007 16:56:16 +0000 (16:56 +0000)]
* Fixes: NB#57465
      * Fixed a bug in the account store
* Fixed several memory leaks
* Refactored the code that loads a list of messages from the headers
* Improved reference counting in msg view window
* Added modest_mail_operation_get_source
* Added the global account settings default values to modest init

pmo-trunk-r1950

13 years ago* updated debian/changelog
Dirk-Jan C. Binnema [Tue, 22 May 2007 12:30:58 +0000 (12:30 +0000)]
* updated debian/changelog

pmo-trunk-r1949

13 years ago* put shlib symlinks in the library package
Dirk-Jan C. Binnema [Tue, 22 May 2007 12:28:09 +0000 (12:28 +0000)]
* put shlib symlinks in the library package

pmo-trunk-r1948

13 years ago2007-05-22 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 22 May 2007 09:05:51 +0000 (09:05 +0000)]
2007-05-22 Murray Cumming  <murrayc@murrayc.com>

* src/modest-account-mgr.c:
        (modest_account_mgr_add_server_account): Set the secure-connection
        conf key for transport accounts as well as store accounts. I don't know
        why the if was there. For instance, this makes sure that we use SSL
        for the gmail preset from the easysetup wizard.

pmo-trunk-r1947

13 years ago * Fixes NB#57478
Sergio Villar Senin [Tue, 22 May 2007 08:49:46 +0000 (08:49 +0000)]
* Fixes NB#57478
* Fixes NB#57325

pmo-trunk-r1946

13 years ago2007-05-22 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 22 May 2007 08:21:20 +0000 (08:21 +0000)]
2007-05-22 Murray Cumming  <murrayc@murrayc.com>

* src/gnome/modest-main-window.c:
        (on_account_store_connecting_finished), (connect_signals):
        * src/maemo/modest-main-window.c:
        (on_account_store_connecting_finished), (connect_signals),
        (modest_main_window_new):
        Handle TnyAccountStore::connecting-finished instead of
        TnyDevice::connection-changed, because we cannot actually perform
        operations on accounts until TnyAccountStore has itself responded to
        the TnyDevice::connection-changed signal. This prevents a GError from
        tinymail.
        Do not try to update at startup, because we (at least on scratchbox)
        already do an update at startup when the device goes online.
        This prevents a GError from tinymail.
        * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
        Added TODO about stopping simultaneous operations.

pmo-trunk-r1945

13 years ago2007-05-22 Marcus Bauer <marcusb@openismus.com>
Marcus Bauer [Tue, 22 May 2007 06:39:06 +0000 (06:39 +0000)]
2007-05-22  Marcus Bauer  <marcusb@openismus.com>

* src/dbus_api/modest-dbus-api.h:
added MODEST_DBUS_METHOD_COMPOSE_MAIL
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
(on_compose_mail), (on_idle_open_message),
(modest_dbus_req_handler):
added on_compose_mail()

pmo-trunk-r1944

13 years ago* update the scripts
Dirk-Jan C. Binnema [Mon, 21 May 2007 18:48:31 +0000 (18:48 +0000)]
* update the scripts

pmo-trunk-r1943

13 years ago2007-05-21 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 21 May 2007 14:46:40 +0000 (14:46 +0000)]
2007-05-21  Murray Cumming  <murrayc@murrayc.com>

* src/modest-account-mgr.c: (modest_account_mgr_add_account):
        * src/modest-mail-operation-queue.c:
        (modest_mail_operation_queue_remove):
        * src/modest-tny-account-store.c: When GErrors happen, give more clues
        about where they happened.

pmo-trunk-r1942

13 years ago * Removed xfer_folder_async, all the xfer_folder operations are now async
Sergio Villar Senin [Mon, 21 May 2007 14:36:27 +0000 (14:36 +0000)]
* Removed xfer_folder_async, all the xfer_folder operations are now async
* Fixed a logical error when drag&drop

pmo-trunk-r1941

13 years ago2007-05-21 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 21 May 2007 13:35:22 +0000 (13:35 +0000)]
2007-05-21  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-actions.c:
        (modest_ui_actions_on_password_requested): Make sure that the remember
        output parameter is always TRUE.

pmo-trunk-r1940

13 years ago2007-05-21 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 21 May 2007 13:18:03 +0000 (13:18 +0000)]
2007-05-21  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
        Show a OK/Cancel dialog if the error is a question, though we still do not
        know anything more about what we are asking the user.
        * src/widgets/modest-folder-view.c: (on_drag_data_received):
        Fix an uninitialized variable (helper). This is a logic error, however.

pmo-trunk-r1939

13 years ago * Fixed drag&drop for folders
Sergio Villar Senin [Mon, 21 May 2007 12:53:48 +0000 (12:53 +0000)]
* Fixed drag&drop for folders
* Fixed drag&drop for headers
* Added progress-changed notification to all mail operations when they finish
* Fixed a bug when selecting folders in the UI actions
* Added some debug code to the mail operation queue, prints mail operation errors

pmo-trunk-r1938

13 years ago* Removed call to mail_operation_queue_remove from
Javier Fernandez Garcia-Boente [Mon, 21 May 2007 11:27:16 +0000 (11:27 +0000)]
* Removed call to mail_operation_queue_remove from
ui-actions, and put it into mail_operation.

pmo-trunk-r1937

13 years ago* modest-mail-operation.c: Set FAILED status if an exception is received.
Javier Fernandez Garcia-Boente [Mon, 21 May 2007 10:40:06 +0000 (10:40 +0000)]
* modest-mail-operation.c: Set FAILED status if an exception is received.
* modest-ui-actions.c: check if copy_folder_async failed to
remove mail operation from queue.

pmo-trunk-r1936

13 years ago2007-05-21 Christian Kellner <ckellner@openismus.com>
Christian Kellner [Mon, 21 May 2007 10:27:04 +0000 (10:27 +0000)]
2007-05-21  Christian Kellner  <ckellner@openismus.com>

* src/modest-search.h:
Correct bit shifting in the ModestSearchFlags enum.

pmo-trunk-r1935

13 years ago2007-05-21 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 21 May 2007 10:18:26 +0000 (10:18 +0000)]
2007-05-21  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account.c:
        (modest_tny_account_new_from_server_account): Do not use the lsub and
        check-all hard-coded IMAP options when using POP.

pmo-trunk-r1934

13 years ago2007-05-21 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 21 May 2007 10:02:53 +0000 (10:02 +0000)]
2007-05-21  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account.c:
        (modest_tny_account_new_from_server_account):
        Use NULL for the secure-auth method for POP when Password auth has been
        specified by the user, as we already do for IMAP. auth=Login causes
        an error from camel or the server.

pmo-trunk-r1933

13 years ago* update for tinymail API change
Dirk-Jan C. Binnema [Sun, 20 May 2007 16:19:13 +0000 (16:19 +0000)]
* update for tinymail API change

pmo-trunk-r1929

13 years ago* also allow pop-accounts to come without authentication options;
Dirk-Jan C. Binnema [Sun, 20 May 2007 13:51:02 +0000 (13:51 +0000)]
* also allow pop-accounts to come without authentication options;
  one step further in supporting pop.gmail.com

pmo-trunk-r1928

13 years ago* account options should *not* include spaces... according to
Dirk-Jan C. Binnema [Sun, 20 May 2007 13:10:46 +0000 (13:10 +0000)]
* account options should *not* include spaces... according to
  tny_account_get_url_string, the options would look like [...];use_ssl=%20always;[...]
  ie. with the %20... this broke pop.gmail.com, and probably all accounts which
  need options.

pmo-trunk-r1927

13 years ago* workaround for the slow gconf-notifications on maemo; now, (on maemo),
Dirk-Jan C. Binnema [Sun, 20 May 2007 11:04:12 +0000 (11:04 +0000)]
* workaround for the slow gconf-notifications on maemo; now, (on maemo),
  modest-conf will send the change notifications by itself, 100 ms after
  a change has been made, and ignores the notifications that come from gconf
  (much later)

this is not perfect - eg, it won't notice changes which did not go through
  modest-conf. but for the end user, it seems to work a bit smoother

pmo-trunk-r1926

13 years ago* add a missing 'break' in the switch statement in
Dirk-Jan C. Binnema [Sat, 19 May 2007 22:00:59 +0000 (22:00 +0000)]
* add a missing 'break' in the switch statement in
modest_tny_account_new_from_server_account
   this fixes some weird errors when CRAMMD5 is chosen
* igore stats value < 0, as we sometimes get with new accounts;
   this fixes the weird negative # of messages in the UI
     account view

pmo-trunk-r1925

13 years ago* only get the server_accounts that are used by enabled accounts
Dirk-Jan C. Binnema [Sat, 19 May 2007 21:46:40 +0000 (21:46 +0000)]
* only get the server_accounts that are used by enabled accounts
* refresh the caches for both transport / store account after change notifications have been received; this fixes the bug where the transport accounts were cleared but not recached after an update
 (ie. the dreaded 'cannot find transport account' error)

pmo-trunk-r1924

13 years ago* set the correct server options from the preset data,
Dirk-Jan C. Binnema [Sat, 19 May 2007 16:03:30 +0000 (16:03 +0000)]
* set the correct server options from the preset data,
  and set the right port number as well; i restructured the code a bit,
  the problem was that (apparently) the easy setup wizard did not set the
  port number; also, modest-presets confused && and & for bitwise-and
  somehow
* add explicit port number argument to modest_account_mgr_add_server_account

pmo-trunk-r1921

13 years ago* added 'update-garage', crude script to update modest in garage with the latest...
Dirk-Jan C. Binnema [Sat, 19 May 2007 10:05:50 +0000 (10:05 +0000)]
* added 'update-garage', crude script to update modest in garage with the latest changes in the internal repo

pmo-trunk-r1920

13 years ago* add dummy image for testing
Dirk-Jan C. Binnema [Sat, 19 May 2007 09:42:12 +0000 (09:42 +0000)]
* add dummy image for testing

pmo-trunk-r1919

13 years ago* AC_MSG_ERROR for Gnome build
Dirk-Jan C. Binnema [Sat, 19 May 2007 09:28:42 +0000 (09:28 +0000)]
* AC_MSG_ERROR for Gnome build

pmo-trunk-r1918

13 years ago* make control-maemo0 depend on maemo-providers-data instead of modest-providers...
Dirk-Jan C. Binnema [Fri, 18 May 2007 21:23:32 +0000 (21:23 +0000)]
* make control-maemo0 depend on maemo-providers-data instead of modest-providers-data

pmo-trunk-r1917

13 years ago* turn off the maemo-launcher for now, as it seems to break connectivity
Dirk-Jan C. Binnema [Fri, 18 May 2007 21:22:06 +0000 (21:22 +0000)]
* turn off the maemo-launcher for now, as it seems to break connectivity

pmo-trunk-r1916

13 years ago* add modest_platform_show_help helper function, to invoke the help browser
Dirk-Jan C. Binnema [Fri, 18 May 2007 15:54:45 +0000 (15:54 +0000)]
* add modest_platform_show_help helper function, to invoke the help browser

pmo-trunk-r1914

13 years ago* fix for bug NB#57325 ("Local folders on: %s")
Dirk-Jan C. Binnema [Fri, 18 May 2007 15:26:26 +0000 (15:26 +0000)]
* fix for bug NB#57325 ("Local folders on: %s")

pmo-trunk-r1913

13 years ago* maemo/modest-main-window.c:
Javier Fernandez Garcia-Boente [Fri, 18 May 2007 14:17:48 +0000 (14:17 +0000)]
* maemo/modest-main-window.c:
  - use mail_operation error handling capabilities when
   operation os removed from queue.
* modest-mail-operation.c:
  - folder_copy_async works fine now.
  - added a new private field, error_handler to perfomrs
    required operations during an error state.
* modest-ui-actions.c
  - use a mail operation with error handling capabilities
   to perform copy_async operation.
  - get message header from tree model, when message is
   deleted using toolitem of viewer view. (Fixes: #NB55370)

pmo-trunk-r1912

13 years ago * Added per-message size limit to get_msgs mail operation
Sergio Villar Senin [Fri, 18 May 2007 13:43:31 +0000 (13:43 +0000)]
* Added per-message size limit to get_msgs mail operation

pmo-trunk-r1911

13 years ago* some fixes to make lintian happy
Dirk-Jan C. Binnema [Fri, 18 May 2007 13:05:02 +0000 (13:05 +0000)]
* some fixes to make lintian happy

pmo-trunk-r1910

13 years agoA search API for Modest
Philip Van Hoof [Fri, 18 May 2007 12:15:42 +0000 (12:15 +0000)]
A search API for Modest

pmo-trunk-r1909

13 years ago* fix the (c) headers
Dirk-Jan C. Binnema [Fri, 18 May 2007 12:08:47 +0000 (12:08 +0000)]
* fix the (c) headers

pmo-trunk-r1908

13 years ago * Created a new get_full_msgs mail operation to asynchronously receive several full...
Sergio Villar Senin [Fri, 18 May 2007 10:01:23 +0000 (10:01 +0000)]
* Created a new get_full_msgs mail operation to asynchronously receive several full messages

pmo-trunk-r1905

13 years ago* update debian changelog for w21 prerelease
Dirk-Jan C. Binnema [Fri, 18 May 2007 09:02:11 +0000 (09:02 +0000)]
* update debian changelog for w21 prerelease

pmo-trunk-r1904

13 years agoBuild fix, updating API changes from Tinymail
Philip Van Hoof [Thu, 17 May 2007 12:28:18 +0000 (12:28 +0000)]
Build fix, updating API changes from Tinymail

pmo-trunk-r1903

13 years ago2007-05-17 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 17 May 2007 11:17:08 +0000 (11:17 +0000)]
2007-05-17  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-settings-dialog.c:
        (create_page_account_details),
        (modest_account_settings_dialog_set_account_name):
        * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
        for the leave-on-server checkbox, rathr than just the checkbox, when
        the protocol is not POP.

pmo-trunk-r1901

13 years ago2007-05-17 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 17 May 2007 11:09:12 +0000 (11:09 +0000)]
2007-05-17  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-account-view.c:
        * src/widgets/modest-account-view.h:
        Added modest_account_view_select_account() which will be useful later
        to asynchronously re-select the edited account.

pmo-trunk-r1900

13 years ago2007-05-17 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 17 May 2007 10:34:01 +0000 (10:34 +0000)]
2007-05-17  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-settings-dialog.c:
        (modest_account_settings_dialog_set_account_name):
        Automatically choose the port numbers based on the secure authentication
        methods, if they have not been chosen before.
        This fixes projects.maemo.org bug NB#56273 .

pmo-trunk-r1897

13 years ago2007-05-17 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 17 May 2007 09:56:12 +0000 (09:56 +0000)]
2007-05-17  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-main-window-ui.h:
        * src/modest-ui-actions.c:
        * src/modest-ui-actions.h:
        Connect the Tools/SMTP Servers menu item to
        modest_ui_actions_on_smtp_servers(), which shows the connection-specific
        SMTP servers dialog, as in the UI specification and saves changes when it
        is closed. This fixed  projects.maemo.org bug NB#56305 .

pmo-trunk-r1896

13 years ago2007-05-17 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 17 May 2007 09:06:59 +0000 (09:06 +0000)]
2007-05-17  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-connection-specific-smtp-window.c:
        (modest_connection_specific_smtp_window_init):
        Use gtk_window_set_default_size() to make this window big enough, so
        we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .

pmo-trunk-r1895

13 years ago2007-05-17 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 17 May 2007 08:56:53 +0000 (08:56 +0000)]
2007-05-17  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-connection-specific-smtp-edit-window.h:
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        (modest_connection_specific_smtp_edit_window_init),
        Do not try to connect to a combobox signal before the combobox exists.
        This fixes the cras in projects.maemo.org bug NB#56288 .
        (modest_connection_specific_smtp_edit_window_get_settings):
        Remove the server_account_name parameter which was being checked for NULL
        though it was not used.

        * src/maemo/modest-connection-specific-smtp-window.c:
        (modest_connection_specific_smtp_window_fill_with_connections),
        (on_button_edit), (modest_connection_specific_smtp_window_init):
        Correct the number of treemodel columns to prevent a warning.
        Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
        libconic does not work.

pmo-trunk-r1894

13 years ago2007-05-16 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 16 May 2007 17:33:07 +0000 (17:33 +0000)]
2007-05-16  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account.c:
        (modest_tny_account_new_from_server_account):
        Excplicitly use ANONYMOUS secure authentication, instead of PLAIN for
        SMTP when None was chosen by the user. However, with my SMTP server that
        does not support ANONYMOUS, the emails do not leave the Outbox and I see
        no error dialog.

pmo-trunk-r1893

13 years ago* maemo/modest-main-window-ui.h
Javier Fernandez Garcia-Boente [Wed, 16 May 2007 16:20:08 +0000 (16:20 +0000)]
* maemo/modest-main-window-ui.h
  - add handler for move_to toolbar button
* maemo/modest-progress-bar-widget.c
  - avoid to show done=1 and total=100 progress,
    because these values are inital values for all
    mail operations.
* modest-ui-actions.c
  - show confirmation dialog on delete message events
    from headers view
  - Add a user_callback function to xfer_msgs method in order
    to restore row_reference attribute on viewer window and
    set current message to first message of recenlty update
    treemodel.
* modest-folder-view.c
  - fix bug about an incorrect unref over header object after
    added it to a tiny list. this header object will be unreferenced
    when tiny list was destroyed.
* modest-mail-operation.c
  - call to recently created copy_folder_async tinymail operation.
  - define an user_callback for message transfer operations
  - fix bug on xfer_msgs operation, due an incorrect references management.

pmo-trunk-r1892

13 years ago * Some fixes
Sergio Villar Senin [Wed, 16 May 2007 14:34:31 +0000 (14:34 +0000)]
* Some fixes

pmo-trunk-r1891

13 years ago* fix for compile breakage
Dirk-Jan C. Binnema [Wed, 16 May 2007 13:42:50 +0000 (13:42 +0000)]
* fix for compile breakage

pmo-trunk-r1890

13 years ago* fix broken debian/changelog, as integration barfs on this
Dirk-Jan C. Binnema [Wed, 16 May 2007 13:09:09 +0000 (13:09 +0000)]
* fix broken debian/changelog, as integration barfs on this

pmo-trunk-r1889

13 years ago * Added support to send&receive async in that particular order
Sergio Villar Senin [Wed, 16 May 2007 12:58:58 +0000 (12:58 +0000)]
* Added support to send&receive async in that particular order

pmo-trunk-r1888

13 years ago2007-05-16 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 16 May 2007 12:30:07 +0000 (12:30 +0000)]
2007-05-16  Murray Cumming  <murrayc@murrayc.com>

* src/modest-pair.h: Improve the documentation for modest_combo_box_new()
        to explain the memory management issue with the ID in the ModestPair.

        * src/gnome/modest-account-assistant.c: (add_receiving_page),
        (add_sending_page), (modest_account_assistant_finalize):
        * src/gnome/modest-gnome-global-settings-dialog.c:
        (create_updating_page), (create_composing_page):
        * src/gnome/modest-msg-edit-window.c: (get_transports),
        (init_window), (modest_msg_edit_window_finalize),
        (modest_msg_edit_window_get_msg_data):
        * src/gnome/modest-store-widget.c: (imap_pop_configuration):
        * src/gnome/modest-transport-widget.c:
        (modest_transport_widget_finalize), (smtp_configuration):
        * src/maemo/modest-maemo-global-settings-dialog.c:
        (create_updating_page), (create_composing_page):
        * src/maemo/modest-msg-edit-window.c: (get_transports),
        (init_window), (modest_msg_edit_window_finalize),
        (modest_msg_edit_window_get_msg_data),
        (modest_msg_edit_window_free_msg_data):
        * src/maemo/modest-store-widget.c: (imap_pop_configuration),
        (modest_store_widget_finalize):
        * src/maemo/modest-transport-widget.c:
        (modest_transport_widget_finalize), (smtp_configuration):
        * src/modest-main.c: (send_mail):
        * src/widgets/modest-combo-box.h:
        * src/widgets/modest-global-settings-dialog-priv.h:
        * src/widgets/modest-global-settings-dialog.c:
        (modest_global_settings_dialog_finalize):
        * src/widgets/modest-msg-edit-window.h:
        Whenever using modest_combo_box_new(), keep the ModestPairList alive
        as long as the combo box, to prevent use of freed memory for the ID.

pmo-trunk-r1887

13 years ago * Better status information notification for account updates
Sergio Villar Senin [Wed, 16 May 2007 10:38:31 +0000 (10:38 +0000)]
* Better status information notification for account updates

pmo-trunk-r1886

13 years ago* added the prepare-integration script, which does the building work for integrating...
Dirk-Jan C. Binnema [Wed, 16 May 2007 09:02:27 +0000 (09:02 +0000)]
* added the prepare-integration script, which does the building work for integrating packages; only useful for pre-integrators

pmo-trunk-r1885

13 years ago* fix the changelog syntax
Dirk-Jan C. Binnema [Wed, 16 May 2007 08:58:47 +0000 (08:58 +0000)]
* fix the changelog syntax

pmo-trunk-r1884

13 years ago * Fixed a build error
Sergio Villar Senin [Wed, 16 May 2007 07:38:54 +0000 (07:38 +0000)]
* Fixed a build error

pmo-trunk-r1883

13 years agoPedantic grammar stuff in a comment.
Murray Cumming [Tue, 15 May 2007 18:06:30 +0000 (18:06 +0000)]
Pedantic grammar stuff in a comment.

pmo-trunk-r1882

13 years ago* prepare for new prerelease
Dirk-Jan C. Binnema [Tue, 15 May 2007 17:57:48 +0000 (17:57 +0000)]
* prepare for new prerelease

pmo-trunk-r1881

13 years ago2007-05-15 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 15 May 2007 15:36:57 +0000 (15:36 +0000)]
2007-05-15  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (get_server_accounts): Renamed from
        get_accounts(), to make this clearer. Do not check for the enabled gconf
        key, because we do not use this for server accounts (at least, not yet).
        This allows us to send email again.

pmo-trunk-r1880

13 years ago* number the columns (MODEST_HEADER_VIEW_COLUMN_*) explicitely, to make changes that...
Dirk-Jan C. Binnema [Tue, 15 May 2007 15:04:28 +0000 (15:04 +0000)]
* number the columns (MODEST_HEADER_VIEW_COLUMN_*) explicitely, to make changes that screw up our config settings less likely

pmo-trunk-r1879

13 years ago* added missing backup settings file
Dirk-Jan C. Binnema [Tue, 15 May 2007 14:54:25 +0000 (14:54 +0000)]
* added missing backup settings file

pmo-trunk-r1878

13 years ago2007-05-15 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 15 May 2007 14:39:42 +0000 (14:39 +0000)]
2007-05-15  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-platform.c:
        (on_modest_conf_update_interval_changed), (modest_platform_init):
        Only respond to this particular key change. All these strcmp()s cannot be
        efficient.

pmo-trunk-r1877

13 years ago2007-05-15 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 15 May 2007 14:28:00 +0000 (14:28 +0000)]
2007-05-15  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-global-settings-dialog.c:
        (current_connection): Prevent a crash in scratchbox when
        ny_maemo_conic_device_get_current_iap_id() returns NULL.
        * src/maemo/modest-platform.c:
        (on_modest_conf_update_interval_changed), (modest_platform_init):
        Get the update interval from gconf and reset it when the gconf key changes.

pmo-trunk-r1876

13 years ago* add the rather trivial backup support; this implements the "Backup" workitem.
Dirk-Jan C. Binnema [Tue, 15 May 2007 14:08:16 +0000 (14:08 +0000)]
* add the rather trivial backup support; this implements the "Backup" workitem.
* needs testing though, and possibly a conversion script for pre-modest email import

pmo-trunk-r1875

13 years ago2007-05-15 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 15 May 2007 13:55:43 +0000 (13:55 +0000)]
2007-05-15  Murray Cumming  <murrayc@murrayc.com>

* src/modest-protocol-info.c:
        * src/modest-protocol-info.h: Adde enum-specific get functions,
        instead of using a ModestProtocolType enum parameter.

        * src/gnome/modest-account-assistant.c:
        * src/gnome/modest-store-widget.c:
        * src/gnome/modest-store-widget.h:
        * src/gnome/modest-transport-widget.c:
        * src/gnome/modest-transport-widget.h:
        * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
        * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
        * src/maemo/easysetup/modest-easysetup-wizard.c:
        * src/maemo/modest-account-settings-dialog.c:
        * src/maemo/modest-account-settings-dialog.h:
        * src/maemo/modest-store-widget.c:
        * src/maemo/modest-store-widget.h:
        * src/maemo/modest-transport-widget.c:
        * src/maemo/modest-transport-widget.h:
        * src/modest-account-mgr-helpers.c:
        * src/modest-account-mgr-helpers.h:
        * src/modest-account-mgr.c:
        * src/modest-account-mgr.h:
        * src/modest-tny-account.c:
        * src/modest-tny-folder.c:
        * src/widgets/modest-account-view.c:
        * src/widgets/modest-retrieve-combo-box.c:
        * src/widgets/modest-retrieve-combo-box.h:
        * src/widgets/modest-secureauth-combo-box.c:
        * src/widgets/modest-serversecurity-combo-box.c:
        * src/widgets/modest-serversecurity-combo-box.h:
        * tests/check_account-mgr.c:
        Use the specific functions, and use the re-renamed enum values for GNOME too.

pmo-trunk-r1874

13 years ago * Modified the update_account signature to ensure that the account is a ModestTnyAccount
Sergio Villar Senin [Tue, 15 May 2007 12:28:19 +0000 (12:28 +0000)]
* Modified the update_account signature to ensure that the account is a ModestTnyAccount
* Added last_update feature

pmo-trunk-r1873

13 years ago2007-05-15 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 15 May 2007 11:53:41 +0000 (11:53 +0000)]
2007-05-15  Murray Cumming  <murrayc@murrayc.com>

* src/modest-pair.h:
        * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
        so we can get the second based on the first.

        * src/maemo/modest-account-settings-dialog.h:
        * src/maemo/modest-account-settings-dialog.c:
        Added get_supported_secure_authentication_methods(), though it is mostly
        commented-out for now until the necessary API is committed to tinymail.
        (modest_account_settings_dialog_set_account_name),
        (save_configuration): Request the supported authentication methods from the
        server, so we can choose a working method.

        * src/modest-tny-account-store.h:
        * src/modest-tny-account-store.c:
        (modest_tny_account_store_get_session): Rename from
        tny_account_store_get_session().

pmo-trunk-r1872

13 years ago* Dont use timeouts to change toolbar operation
Javier Fernandez Garcia-Boente [Tue, 15 May 2007 11:22:24 +0000 (11:22 +0000)]
* Dont use timeouts to change toolbar operation
mode.

pmo-trunk-r1871

13 years ago* update for the modest-protocol-info changes
Dirk-Jan C. Binnema [Tue, 15 May 2007 11:22:08 +0000 (11:22 +0000)]
* update for the modest-protocol-info changes

pmo-trunk-r1870

13 years ago* update for the modest-protocol-info changes
Dirk-Jan C. Binnema [Tue, 15 May 2007 11:21:35 +0000 (11:21 +0000)]
* update for the modest-protocol-info changes

pmo-trunk-r1869

13 years ago* update for the modest-protocol-info changes
Dirk-Jan C. Binnema [Tue, 15 May 2007 11:20:51 +0000 (11:20 +0000)]
* update for the modest-protocol-info changes

pmo-trunk-r1868

13 years ago* fix the modest-protocol-info for the split enums; note: a couple more commits will...
Dirk-Jan C. Binnema [Tue, 15 May 2007 11:20:18 +0000 (11:20 +0000)]
* fix the modest-protocol-info for the split enums; note: a couple more commits will follow

pmo-trunk-r1867

13 years ago* at least on bora, gconf crashes if you try to set a NULL string,
Dirk-Jan C. Binnema [Tue, 15 May 2007 09:14:25 +0000 (09:14 +0000)]
* at least on bora, gconf crashes if you try to set a NULL string,
  the NULL is a symptom of another bug (it causes the crash in bug
  #57045), but at least we should be safe against NULLs.

pmo-trunk-r1866

13 years ago * Added new msg received notification support
Sergio Villar Senin [Tue, 15 May 2007 08:22:11 +0000 (08:22 +0000)]
* Added new msg received notification support
* Fixed some translations

pmo-trunk-r1865

13 years ago* use guint for done/total
Dirk-Jan C. Binnema [Tue, 15 May 2007 08:13:27 +0000 (08:13 +0000)]
* use guint for done/total
* add parameter checks

pmo-trunk-r1864

13 years ago* Move mark_as_read call from on_header_activated
Javier Fernandez Garcia-Boente [Tue, 15 May 2007 08:02:50 +0000 (08:02 +0000)]
* Move mark_as_read call from on_header_activated
function to open_msg_cb callback method, in order
to manange headers only after message have been
downloaded.

pmo-trunk-r1863

13 years ago* small cosmetic cleanup of modest-conf.c
Dirk-Jan C. Binnema [Tue, 15 May 2007 07:27:07 +0000 (07:27 +0000)]
* small cosmetic cleanup of modest-conf.c

pmo-trunk-r1862

13 years ago* implement the "maemo-laucher" feature, which makes modest startup faster.
Dirk-Jan C. Binnema [Tue, 15 May 2007 07:23:02 +0000 (07:23 +0000)]
* implement the "maemo-laucher" feature, which makes modest startup faster.
  this completes workitem "Launcher"

for more information:
  https://stage.maemo.org/svn/maemo/projects/haf/trunk/maemo-launcher/README

pmo-trunk-r1861

13 years ago* turn off launcher stuff for now
Dirk-Jan C. Binnema [Mon, 14 May 2007 17:30:46 +0000 (17:30 +0000)]
* turn off launcher stuff for now

pmo-trunk-r1860

13 years ago * Added asynchronous account update
Sergio Villar Senin [Mon, 14 May 2007 16:47:41 +0000 (16:47 +0000)]
* Added asynchronous account update
* Replaced GtkTreeIter's by row references when the header is activated

pmo-trunk-r1859

13 years ago* fix debian/rules (launcher stuff)
Dirk-Jan C. Binnema [Mon, 14 May 2007 16:37:30 +0000 (16:37 +0000)]
* fix debian/rules (launcher stuff)
* add libtinymail-gnomevfs build dep to control-maemo(0|1)

pmo-trunk-r1858

13 years ago2007-05-14 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 14 May 2007 15:03:42 +0000 (15:03 +0000)]
2007-05-14  Murray Cumming  <murrayc@murrayc.com>

* src/modest-protocol-info.h: Split the ModestProtocol enum
        into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
        There was no need to have these unrelated values in one enum.

        * src/: many files: Adapted to changed enum. This makes the code a bit
        clearer, and the compiler could catch some errors.

pmo-trunk-r1857

13 years ago* Fix bug on progressbar timeout management.
Javier Fernandez Garcia-Boente [Mon, 14 May 2007 15:00:57 +0000 (15:00 +0000)]
* Fix bug on progressbar timeout management.
I added 2 seconds of interval to show transfer_mode
toolbar. After interval, remove source and sets
timeout to 0, in order to enable normal mode again.

pmo-trunk-r1856

13 years ago* fix build bug due to faulty Makefile.am CFLAGS/LDFLAGS
Dirk-Jan C. Binnema [Mon, 14 May 2007 14:28:05 +0000 (14:28 +0000)]
* fix build bug due to faulty Makefile.am CFLAGS/LDFLAGS

pmo-trunk-r1855

13 years ago* fix build bug due to faulty Makefile.am CFLAGS/LDFLAGSwq setting
Dirk-Jan C. Binnema [Mon, 14 May 2007 14:26:21 +0000 (14:26 +0000)]
* fix build bug due to faulty Makefile.am CFLAGS/LDFLAGSwq setting

pmo-trunk-r1854

13 years ago* Add new reference on dest_folder and header_list
Javier Fernandez Garcia-Boente [Mon, 14 May 2007 13:40:59 +0000 (13:40 +0000)]
* Add new reference on dest_folder and header_list
objects passed to asyn callback function.

pmo-trunk-r1853

13 years ago* debian/changelog update for packaging
Dirk-Jan C. Binnema [Mon, 14 May 2007 12:55:06 +0000 (12:55 +0000)]
* debian/changelog update for packaging
* support for the maemo-launcher (turned-off for now)

pmo-trunk-r1852

13 years ago2007-05-14 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 14 May 2007 12:35:29 +0000 (12:35 +0000)]
2007-05-14  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Show the detailed internal camel error message when an error happens
during the configuration, so that our testers can give us more clues.
For instance, in projects.maemo.org bug NB#56910 .

pmo-trunk-r1851