modest
13 years ago* Fix some detected memory leaks
Javier Fernandez Garcia-Boente [Mon, 7 May 2007 07:50:36 +0000 (07:50 +0000)]
* Fix some detected memory leaks
* New update_progress function for get_msg_async operation.
* Reply/Forward actions use now get_msg_asyc function
* Open a message in edit or view window using asynchronous operations: get_msg_asyc
* In optimized view, toolbar is hide/show based on current operation mode

pmo-trunk-r1766

13 years ago* debian packaging updates
Dirk-Jan C. Binnema [Sun, 6 May 2007 10:18:43 +0000 (10:18 +0000)]
* debian packaging updates

pmo-trunk-r1764

13 years ago * OSSO1.1 build fix
Sergio Villar Senin [Fri, 4 May 2007 16:41:25 +0000 (16:41 +0000)]
* OSSO1.1 build fix
* Rewritten the placeholders

pmo-trunk-r1763

13 years ago* debian packaging fixes
Dirk-Jan C. Binnema [Fri, 4 May 2007 16:39:20 +0000 (16:39 +0000)]
* debian packaging fixes

pmo-trunk-r1762

13 years ago2007-05-04 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 4 May 2007 16:08:41 +0000 (16:08 +0000)]
2007-05-04  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/Makefile.am:
        * src/maemo/modest-osso-state-saving.c:
        * src/maemo/modest-osso-state-saving.h: Added
        modest_osso_load_state() and modest_osso_save_state() though they do
        nothing now. They should iterate through all the open windows and load/save
        their state.
        * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
        save state when closing.

        * src/maemo/modest-main-window.c:
        (on_hildon_program_is_topmost_notify), (modest_main_window_new):
        Add a notification handler for the HildonProgram::is-topmost property,
        so we can allow hibernation when the application goes into the background.
        But we still need to detect when the accounts setup windows are open so
        we can stop hibernation when they are open.
        To do this, I also added the main window the HildonProgram. This might have
        other side-effects/benefits, and should maybe be done for other windows.

        * src/maemo/modest-osso-autosave-callbacks.h:
        * src/maemo/modest-osso-autosave-callbacks.c:
        (modest_on_osso_application_autosave): Add a libosso auto-save callback,
        though it does not do anything yet, and we might never need this to do
        anything. For instance, we already save drafts.

        * src/maemo/modest-platform.c: (modest_platform_init):
        Specify the libosso auto-save callback.

pmo-trunk-r1760

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Fri, 4 May 2007 14:03:14 +0000 (14:03 +0000)]
* src/modest-ui-actions.c:
        * Minor fix in get_msg_cb to be compatible with
          Tny API change.
* src/widgets/modest-attachment-view.c:
        * Now size label uses modest_text_utils_get_display_size.

pmo-trunk-r1759

13 years ago* fix bug about toolbar items drawing.
Javier Fernandez Garcia-Boente [Fri, 4 May 2007 11:25:38 +0000 (11:25 +0000)]
* fix bug about toolbar items drawing.

pmo-trunk-r1758

13 years ago* Fixes: NB#55446
Javier Fernandez Garcia-Boente [Fri, 4 May 2007 09:50:15 +0000 (09:50 +0000)]
* Fixes: NB#55446
   * Check folder type and open DRAFT headers into edit window
* Change MailOperation design to add a new relation 'source'
with object which creates the operation.
* Change in toolbar mode management of ModestMsgView window to
attend only their own operations progress.
* Fix bug on modest-tny-msg.c: unref body at incorrect place.

pmo-trunk-r1757

13 years ago * Fixed a bug when there was no header selected
Sergio Villar Senin [Fri, 4 May 2007 07:29:31 +0000 (07:29 +0000)]
* Fixed a bug when there was no header selected
* The toggle folder button is now really a toggle action

pmo-trunk-r1756

13 years ago * Temporary fix
Sergio Villar Senin [Fri, 4 May 2007 06:28:41 +0000 (06:28 +0000)]
* Temporary fix

pmo-trunk-r1755

13 years ago* build packages correctly
Dirk-Jan C. Binnema [Fri, 4 May 2007 06:04:40 +0000 (06:04 +0000)]
* build packages correctly
* put packages in user/extra

pmo-trunk-r1754

13 years ago* small tweaks
Dirk-Jan C. Binnema [Fri, 4 May 2007 05:32:51 +0000 (05:32 +0000)]
* small tweaks

pmo-trunk-r1753

13 years ago* remove debian/control; uses control-maemo0 or control-maemo1 instead
Dirk-Jan C. Binnema [Fri, 4 May 2007 05:32:19 +0000 (05:32 +0000)]
* remove debian/control; uses control-maemo0 or control-maemo1 instead

pmo-trunk-r1752

13 years ago* updated for maemo0
Dirk-Jan C. Binnema [Fri, 4 May 2007 05:31:16 +0000 (05:31 +0000)]
* updated for maemo0

pmo-trunk-r1751

13 years ago * Added handler for File->Open menu
Sergio Villar Senin [Thu, 3 May 2007 19:24:03 +0000 (19:24 +0000)]
* Added handler for File->Open menu

pmo-trunk-r1750

13 years ago * Removed debugging ;-) code
Sergio Villar Senin [Thu, 3 May 2007 19:13:22 +0000 (19:13 +0000)]
* Removed debugging ;-) code

pmo-trunk-r1749

13 years ago * Fixed some GNOME build problems
Sergio Villar Senin [Thu, 3 May 2007 19:03:00 +0000 (19:03 +0000)]
* Fixed some GNOME build problems
* Removed the code that updates the msg preview from the UI actions, it's only used by GNOME
* The Maemo version now, does not read the message when a header is clicked

pmo-trunk-r1748

13 years ago * Refactored some calls in the modest ui actions
Sergio Villar Senin [Thu, 3 May 2007 16:39:50 +0000 (16:39 +0000)]
* Refactored some calls in the modest ui actions
* Added handler to Email->Open menu option

pmo-trunk-r1747

13 years ago* debian packaging update
Dirk-Jan C. Binnema [Thu, 3 May 2007 14:30:29 +0000 (14:30 +0000)]
* debian packaging update

pmo-trunk-r1746

13 years ago* Fix bug: 55370
Javier Fernandez Garcia-Boente [Thu, 3 May 2007 14:11:19 +0000 (14:11 +0000)]
* Fix bug: 55370
* Call tny-send-queue_flush, but comment its implementation
because this tinymail operation is not implemented.

pmo-trunk-r1745

13 years ago* public method in modest_progress_object to get the
Javier Fernandez Garcia-Boente [Thu, 3 May 2007 12:14:29 +0000 (12:14 +0000)]
* public method in modest_progress_object to get the
number of pending operations to be observed.
* Fix bug in replay/forward when mulitple headers are
selected.
*  Reply/Forward functions are observed now by MainWindow
progress objects, to get all messages to reply/forward.
* Replay/Forward status_callback implemented.

pmo-trunk-r1744

13 years ago2007-05-03 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 3 May 2007 10:40:33 +0000 (10:40 +0000)]
2007-05-03  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-platform.c:
        (modest_platform_set_update_interval):
        * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
        aparently stays valid between application instances, so we can use this
        to remove and reset it later. According to a maemo-developers email from
        David Weinehall.

pmo-trunk-r1743

13 years ago2007-05-03 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 3 May 2007 09:58:39 +0000 (09:58 +0000)]
2007-05-03  Murray Cumming  <murrayc@murrayc.com>

* configure.ac: Depend on libalarm for Maemo.

        * src/dbus_api/modest-dbus-api.h:
        * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
        (on_send_receive), (modest_dbus_req_handler):
        Handle a SEND_RECEIVE D-Bus method.

        * libmodest-dbus-client/libmodest-dbus-client.c:
        (libmodest_dbus_client_send_and_receive):
        * libmodest-dbus-client/libmodest-dbus-client.h:
        Add C convenience functions for calling the new D-Bus method.

        * src/modest-platform.h:
        * src/gnome/modest-platform.c:
        * src/maemo/modest-platform.c:
        Added modest_platform_set_update_interval(), which uses the
        alarmd API on Maemo.
        (modest_platform_init),
        Call modest_platform_set_update_interval(), using a hard-coded
        interval for now (until the global settings dialog is implemented),
        though I am not sure that this makes sense yet.

pmo-trunk-r1742

13 years ago* updates to the debian build files
Dirk-Jan C. Binnema [Thu, 3 May 2007 09:48:01 +0000 (09:48 +0000)]
* updates to the debian build files

pmo-trunk-r1741

13 years ago* update the debian packaging instructions
Dirk-Jan C. Binnema [Thu, 3 May 2007 07:33:34 +0000 (07:33 +0000)]
* update the debian packaging instructions

pmo-trunk-r1740

13 years ago* Review ModestProgressBarWidge, adding a GtkAlignment and
Javier Fernandez Garcia-Boente [Thu, 3 May 2007 07:32:37 +0000 (07:32 +0000)]
* Review ModestProgressBarWidge, adding a GtkAlignment and
GtkAdjustment.
* Fix bug on GB potfile in "Sending %d/%d1" message.
* New operation mail_operation_process_msg, to get one or several
messages, applying them an user define function, using a
helper data structure to do this.
* Change tny_get_msg_async calls in modest-ui_actions
by a new mail_operation method called mail_operation_process_msg.
* Add a new method to ModestPropressObject to cancel current
mail operation in progress.
* Connect ModestMainWindow as observer of MailOperatinQueue, to
add and remove mail operations from their observer.
* Connect ModestMsgViewWindow as observer of MailOperatinQueue, to
add and remove mail operations from their observer.
* Manage toolbar of MsgViewWindow, dimming toolbar options
in transfer mode.

pmo-trunk-r1739

13 years ago* Review ModestProgressBarWidge, adding a GtkAlignment and
Javier Fernandez Garcia-Boente [Thu, 3 May 2007 07:32:06 +0000 (07:32 +0000)]
* Review ModestProgressBarWidge, adding a GtkAlignment and
GtkAdjustment.
* Fix bug on GB potfile in "Sending %d/%d1" message.
* New operation mail_operation_process_msg, to get one or several
messages, applying them an user define function, using a
helper data structure to do this.
* Change tny_get_msg_async calls in modest-ui_actions
by a new mail_operation method called mail_operation_process_msg.
* Add a new method to ModestPropressObject to cancel current
mail operation in progress.
* Connect ModestMainWindow as observer of MailOperatinQueue, to
add and remove mail operations from their observer.
* Connect ModestMsgViewWindow as observer of MailOperatinQueue, to
add and remove mail operations from their observer.
* Manage toolbar of MsgViewWindow, dimming toolbar options
in transfer mode.

pmo-trunk-r1738

13 years ago * Two build fixes due to major API changes in tinymail
Sergio Villar Senin [Thu, 3 May 2007 06:48:02 +0000 (06:48 +0000)]
* Two build fixes due to major API changes in tinymail

pmo-trunk-r1737

13 years ago* compile fixes for gnome
Dirk-Jan C. Binnema [Thu, 3 May 2007 05:40:25 +0000 (05:40 +0000)]
* compile fixes for gnome

pmo-trunk-r1736

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Wed, 2 May 2007 17:13:04 +0000 (17:13 +0000)]
* src/modest-ui-actions.c:
        * (..._on_header_activated): now it attaches again a reference
          to the header list tree model. This way, we can use again left
          and right arrows in message view. It also lets us show again
          priority information in messages view (fixes #NB55514).

pmo-trunk-r1735

13 years ago2007-05-02 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 2 May 2007 16:35:13 +0000 (16:35 +0000)]
2007-05-02  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c:
        (modest_osso_cb_hw_state_handler):
        * src/dbus_api/modest-dbus-callbacks.h:
        * src/maemo/modest-platform.c: (modest_platform_init):
        Registered (empty) callbacks for the osso hardware state D-Bus signals,
        in case this has some effect on the ability for Maemo to ping the
        application.

pmo-trunk-r1734

13 years agoFix bug on cmp_rows function assignment, due to elimination of
Javier Fernandez Garcia-Boente [Wed, 2 May 2007 15:12:27 +0000 (15:12 +0000)]
Fix bug on cmp_rows function assignment, due to elimination of
on_progress_changed signal handler.

pmo-trunk-r1733

13 years ago2007-05-02 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 2 May 2007 14:54:50 +0000 (14:54 +0000)]
2007-05-02  Murray Cumming  <murrayc@murrayc.com>

* src/modest-text-utils.c: (modest_text_utils_validate_recipient):
        Comment out an if() that checks a gchar for < 0, causing a build-breaking
        warning. It is probably a logic error, but I need to fix the build.

pmo-trunk-r1732

13 years ago* src/modest-ui-actions.[ch]:
Jose Dapena Paz [Wed, 2 May 2007 14:12:38 +0000 (14:12 +0000)]
* src/modest-ui-actions.[ch]:
        * Run check names before sending email from editor.
        * New check names action, used to validate and
          search addresses in addressbook.
* src/modest-address-book.h:
        * Added new check_names method.
* src/modest-text-utils.[ch]:
        * Added ..._get_addresses_indexes. It finds the offset ranges
          of the addresses in a string.
        * ..._split_addresses_list now takes ";" into account, not only
          ",".
        * ..._split_addresses_list fixed offset calculations. Now uses
         utf8 characters.
        * ..._validate_recipient: strips the string before processing.
        * ..._validate_recipient: now counts utf8 characters. Also
          accepts spaces in left part of the address, even when they're
          not between quotes.
* src/maemo/modest-address-book.c:
        * ..._add_address: now the dialog title uses the logical id.
        * (ui_get_formatted_email_id): Now it adds quotes to address
          strings with spaces.
        * New ..._check_names method. It validates all addresses in
          the recipient editor. If address is valid, ok, if not valid,
          it checks if this is an email address attempt (shows error)
          or a generic string (searches in addressbook and replaces
          with matches).
* src/maemo/modest-msg-edit-window.c:
        * New ..._check_names method. Checks all recipient fields using
          new check names implementation in addressbook module.
* src/maemo/ui/modest-msg-edit-window-ui.xml:
        * Added "Check names" menu option.
* src/gnome/modest-address-book.c:
        * Added stubs for new functions.
* src/gnome/modest-msg-edit-window.c:
        * Added stubs for new functions.
* src/widgets/modest-msg-edit-window.h:
        * New _check_names method.
* src/widgets/modest-recpt-editor.[ch]:
        * Now , and ; inside quotes do not insert a CR.
        * New ..._replace_with_resolved_recipient method, to replace
          a range of the editor with a resolved recipient. It's used
          on _check_names implementation.
* src/widgets/modest-msg-edit-window-ui.h:
        * Added action for check names.

pmo-trunk-r1730

13 years ago * Replaced two confusing function names
Sergio Villar Senin [Wed, 2 May 2007 12:00:37 +0000 (12:00 +0000)]
* Replaced two confusing function names
* Replaced all the widget names used by the memory by their correspondent defines

pmo-trunk-r1729

13 years ago * Fixes: #NB55377, #NB55441
Sergio Villar Senin [Wed, 2 May 2007 11:17:53 +0000 (11:17 +0000)]
* Fixes: #NB55377, #NB55441
* Added "visible_server_account_id" persistent configuration key to the folder view
* Removed the double treemodel creation in the header view when refreshing

pmo-trunk-r1728

13 years ago2007-05-02 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 2 May 2007 11:13:37 +0000 (11:13 +0000)]
2007-05-02  Murray Cumming  <murrayc@murrayc.com>

* src/modest-account-mgr.h:
        * src/modest-account-mgr.c:
        (modest_account_mgr_account_names): Add a gboolean enabled_only
        parameter, so we can get lists of onlt the enabled accounts.

        (modest_account_mgr_add_account),,
        (modest_account_mgr_account_with_display_name_exists):
        * src/maemo/modest-msg-edit-window.c: (get_transports):
        * src/modest-account-mgr-helpers.c:
        (modest_account_mgr_set_first_account_as_default):
        * src/modest-init.c: (init_default_account_maybe):
        * src/modest-tny-account-store.c: (get_accounts):
        * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
        (do_send_receive_auto), (modest_ui_actions_on_send_receive):
        * tests/check_account-mgr.c: (START_TEST):
        Provide the extra parameter, as appropriate.

        * src/widgets/modest-account-view.c: (update_account_view):
        Do not show disabled accounts (meaning that there is no way to
        enable/disable accounts in the UI (the feature is not in our UI
        specification), so we can use this internally only to mark unfinished
        or temporary account data.

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_account): Add boolean enable parameter, so we can specify FALSE
        to create the temporary account.
        (on_button_edit_advanced_settings): Create the temporary account as disabled.
        (on_before_next): When finishing, when there is a temporary account, just
        set it as enabled.
        Also, use a timeout to delay the showing of the dialog until gconf is likely
        to return correct information, due to a maemo gconf bug that is fixed in
        osso 1.1, but not yet in Bora.
        However, the dialog stays on screen after it is destroyed.

        * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
        for invalid data when cancelling. Use a hildon note instead of a dialog
        to complain about invalid data. Do not show the account-saved note if the
        account is disabled (a temporary account that will not really be saved for use
        until later.)

pmo-trunk-r1727

13 years ago * Modified the _get_display_size method to fit with the file management specs
Sergio Villar Senin [Wed, 2 May 2007 06:46:34 +0000 (06:46 +0000)]
* Modified the _get_display_size method to fit with the file management specs
* Replaced the old display size of the details dialog by the new call

pmo-trunk-r1726

13 years ago* update
Dirk-Jan C. Binnema [Tue, 1 May 2007 06:41:42 +0000 (06:41 +0000)]
* update

pmo-trunk-r1725

13 years ago2007-04-30 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 30 Apr 2007 14:44:29 +0000 (14:44 +0000)]
2007-04-30  Murray Cumming  <murrayc@murrayc.com>

* src/modest-account-mgr-helpers.h:
        * src/modest-account-mgr-helpers.c:
        Added modest_account_mgr_unset_default_account(),
        Added modest_account_mgr_set_first_account_as_default().

        * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
        If it was the default account, unset the default account name.

        * src/maemo/modest-account-view-window.c:
        (on_delete_button_clicked): If it was the default account,
        set the first remaining account as the default instead.

        * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
        a NULL account or a NULL default account, to prevent a crash. This should
        not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.

pmo-trunk-r1724

13 years ago* src/modest-text-utils.[ch]:
Jose Dapena Paz [Mon, 30 Apr 2007 14:19:27 +0000 (14:19 +0000)]
* src/modest-text-utils.[ch]:
        * Added modest_text_utils_validate_recipient. This validates
          addresses in a@b.c format, but also in "name" <a@b.c> and
          name <a@b.c> formats.
* src/maemo/modest-msg-view-window.c:
        * Now add to contacts menu option is dimmed if the clipboard
          does not contain a valid recipient.
* src/widgets/modest-recpt-editor.c:
        * Added an implementation of backspace valid for gtk < 2.10.

pmo-trunk-r1723

13 years ago2007-04-30 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 30 Apr 2007 13:22:50 +0000 (13:22 +0000)]
2007-04-30  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-recpt-editor.c:
        (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
        use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
        TODO comment for this. This fixes the build.

        * src/modest-ui-actions.c: Add do_send_receive(), though it might not
        be the best place for it. This will in future update all auto-update accounts,
        rather than just the current/default account, when that gconf key exists.
        (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
        if there are no accounts, before calling do_send_receive().
        * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.

        * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
        * src/maemo/modest-main-window-ui.h:
        * src/maemo/modest-main-window.c: (on_connection_changed),
        (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
        directly, becaue the signal handler does more.

pmo-trunk-r1722

13 years ago2007-04-30 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 30 Apr 2007 11:51:00 +0000 (11:51 +0000)]
2007-04-30  Murray Cumming  <murrayc@murrayc.com>

* src/modest-account-mgr-helpers.c:
        (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
        for the case that the account does not exist.

        * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
        (equivalent to the modest account name) rather than the tinymail account name
        (equivalent to the modest account title - human readable) to get the account data.
        Check for null account data to prevent the crash, and add a TODO comment saying that
        this needs fixing because it is using the server account name instead of the account name.

pmo-trunk-r1721

13 years ago* src/modest-ui-actions.[ch]:
Jose Dapena Paz [Mon, 30 Apr 2007 11:48:32 +0000 (11:48 +0000)]
* src/modest-ui-actions.[ch]:
        * (..._on_delete) action simply closes the edit window, emitting
          a delete-event signal.
        * (..._on_close_window) also sends a delete-event.
        * (..._on_new_msg) adds the signature if there's one configured
          in the account. Also removed the "save to drafts" part just on
          creating the new message (fixes #NB55341, #NB55391).
        * (reply_forward_func) now gets the signature of the account.
        * (..._on_save_to_drafts). New action that saves an edited
          message as a draft.
* src/modest-text-utils.[ch]:
        * (..._quote, ..._cite and ..._inline) now put the signature.
        * Added ..._convert_buffer_to_html. This way we can convert to
          html tags a subpart of a document (it does not add html
          headers). Also modified ..._convert_to_html to use this
          function.
        * Added ..._convert_to_html_body. It converts a string to
          an html that can be included inside a formatted html document.
* src/maemo/modest-address-book.c:
        * (..._select_addresses): after selecting an address of a
          recipient editor through the select contacts dialog, focus is
          asigned to the ModestRecptEditor.
        * (select_email_addrs_for_contact): when the dialog is loaded,
          first address is selected by default.
* src/maemo/modest-msg-edit-window.c:
        * Implemented dim rule: if focus is not in body or message
          format is plain text, font actions are dimmed. Also configured
          proper insensitive_press messages.
        * Implemented dim rule: if To: recipient field is empty, send
          action is dimmed. Also configured proper insensitive_press
          message.
        * Delete event handler. It shows a dialog for saving the mail
          as a draft if message is modified.
        * Fixed the html document parsing procedure, as it wasn't
          previously really parsed because the buffer length was not
          provided.
        * If the account setup specified that it should by default
          create plain text mails, it's used. Also radio menu option is
          updated properly.
        * Now we get correctly the focused widget. If "Select contacts"
          is selected, it adds contacts to the focused recipient list,
          or to To: field if no recipient list is focused.
        * If the To: field is empty on opening editor, focus goes to it.
        * Now the message stores a reference to the draft message used
          to create the mail.
        * Refactored the ..._select_contacts function to use the
          general "open_addressbook" function.
        * Added ..._is_modified and ..._reset_modified. It tells if the
          message was modified by the user.
* src/maemo/ui/modest-msg-edit-window-ui.xml:
        * Added email menu options Send, Save to drafts, new message,
          delete.
        * Added close window and close all windows menu actions.
* src/modest-formatter.[ch]:
        * Now the formatter adds the signature properly.
* src/modest-mail-operation.[ch]:
        * Added ..._save_to_drafts operation. It creates a mail from
          editor and saves it to the active account drafts folder.
* src/modest-defs.h:
        * Added configuration option for preferring formatted of plain
          text.
* src/widgets/modest-recpt-view.[ch]:
        * Now button release event is processed after the default
          handler.
* src/widgets/modest-recpt-editor.[ch]:
        * Completely new behavior for keyboard and mouse edition. Now
          only one address per line. Keyboard and mouse selection treat
          resolved addresses as a whole (you shouldn't be able to
          manipulate a part of resolved address).
        * Keyboard shortcut for adding addresses with the addressbook.
        * Better focus and cursor handling.
        * Now the widget does not use GTK_CAN_FOCUS.
        * (..._get_buffer): new API function to export the internal
          buffer.
        * (..._grab_focus): new function to make the textview grab the
          focus.
* src/widgets/modest-scroll-text.[ch]:
        * Small fixes to calculation of the number of lines. Now it also
          makes the cursor visible.
* src/widgets/modest-msg-edit-window-ui.h:
        * Added actions for "window close", "new message", "delete",
          "save to drafts", "all windows close"
* src/modest-tny-msg.[ch]:
        * Support plain text quoted texts as input of msg editor.
        * Now (create_reply_forward_mail) takes the "prefer formatted"
          option.
        * Now it uses the logical id's for "Re:" and "Fwd:" strings.
        * Added signature support.
* src/maemo/modest-main-window-ui.h:
        * Added a new action for new messages. It's used for showing a
          simple "New" menu option for creating new messages from the
          view (fixes #NB55368).

pmo-trunk-r1720

13 years ago * Now the ModestFolderView shows only the remote account that is declared as the...
Sergio Villar Senin [Mon, 30 Apr 2007 10:01:15 +0000 (10:01 +0000)]
* Now the ModestFolderView shows only the remote account that is declared as the default one

pmo-trunk-r1719

13 years ago* Changes in the mail_operation API
Javier Fernandez Garcia-Boente [Mon, 30 Apr 2007 08:14:19 +0000 (08:14 +0000)]
* Changes in the mail_operation API
   * new object instances require the operation id

pmo-trunk-r1718

13 years ago* add modest-hildon-includes.h also for 1.1 build (fixes build there)
Dirk-Jan C. Binnema [Mon, 30 Apr 2007 06:32:56 +0000 (06:32 +0000)]
*  add modest-hildon-includes.h also for 1.1 build (fixes build there)

pmo-trunk-r1717

13 years ago* update debian package building scripts
Dirk-Jan C. Binnema [Sun, 29 Apr 2007 15:04:23 +0000 (15:04 +0000)]
* update debian package building scripts

pmo-trunk-r1716

13 years ago2007-04-29 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Sun, 29 Apr 2007 11:30:19 +0000 (11:30 +0000)]
2007-04-29  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
        * src/maemo/modest-account-settings-dialog.c: (show_error),
        (show_ok):
        Use hildon_note_new_information() for informative and error messages,
        which seems to be expected for Maemo applications (no documentation that I know of
        says this). I am surprised that there is no distinction between info and error
        dialogs.

pmo-trunk-r1715

13 years ago2007-04-29 rray Cumming <murrayc@murrayc.com>
Murray Cumming [Sun, 29 Apr 2007 11:17:58 +0000 (11:17 +0000)]
2007-04-29  rray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
        it is easy to find where this is used.

        * src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_welcome), (create_page_account_details),
        (create_page_user_details), (create_page_complete_easysetup),
        (create_page_custom_incoming), (create_page_custom_outgoing),
        (create_page_complete_custom):
        * src/maemo/modest-account-settings-dialog.c:
        (create_page_account_details), (create_page_user_details),
        (create_page_incoming), (create_page_outgoing):
        * src/maemo/modest-account-view-window.c: (window_vbox_new):
        * src/maemo/modest-connection-specific-smtp-edit-window.c:
        (modest_connection_specific_smtp_edit_window_init):
        * src/maemo/modest-connection-specific-smtp-window.c:
        (modest_connection_specific_smtp_window_init):
        * src/maemo/modest-signature-editor-dialog.c:
        (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
        and scrolling policy as per the Email Application Layout Guide, if I have
        understood it.

pmo-trunk-r1714

13 years ago2007-04-27 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Sun, 29 Apr 2007 10:13:13 +0000 (10:13 +0000)]
2007-04-27  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (modest_tny_account_store_init):
        Remove the add_transport_account_func and add_store_account_func vfunc implementations,
        which were empty, because these vfuncs have been removed from TnyAccountStore.
        This fixes the build.

pmo-trunk-r1713

13 years ago* Change mail_operation_new calls tu use the new field 'id'.
Javier Fernandez Garcia-Boente [Sat, 28 Apr 2007 17:50:05 +0000 (17:50 +0000)]
* Change mail_operation_new calls tu use the new field 'id'.
* Implementation of updating refresh call for updating progress
values and emiting signal 'progress_changed'.
* Review ProgressBar widget layout.
   * Adding alignment and adjustment objects

pmo-trunk-r1712

13 years ago* Add a new dialog, Sort Dialog (WID-DIA021).
Javier Fernandez Garcia-Boente [Sat, 28 Apr 2007 17:47:21 +0000 (17:47 +0000)]
* Add a new dialog, Sort Dialog (WID-DIA021).
* Connect iUIManager actions to sort dialog.
* Store sort settings into gconf configuration parameters.

pmo-trunk-r1711

13 years ago* make two control files: one for "old" (N800) packaging, and one for
Dirk-Jan C. Binnema [Sat, 28 Apr 2007 11:01:25 +0000 (11:01 +0000)]
* make two control files: one for "old" (N800) packaging, and one for
  post-N800 packaging.

Difference is only in hildon-libs-dev ==> libhildon1-dev right now

pmo-trunk-r1709

13 years ago* updated
Dirk-Jan C. Binnema [Sat, 28 Apr 2007 10:53:20 +0000 (10:53 +0000)]
* updated

pmo-trunk-r1708

13 years ago * Added some missing includes
Sergio Villar Senin [Fri, 27 Apr 2007 17:24:35 +0000 (17:24 +0000)]
* Added some missing includes
* Added a "," that was causing a build problem
* Added MSG-NOT404 confirmation note when moving messages

pmo-trunk-r1707

13 years ago* use the newest hildon iff available
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 16:05:52 +0000 (16:05 +0000)]
* use the newest hildon iff available

pmo-trunk-r1706

13 years ago* fix for latest hildon version
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 16:05:00 +0000 (16:05 +0000)]
* fix for latest hildon version

pmo-trunk-r1705

13 years ago* fixes for latest hildon version
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 16:04:27 +0000 (16:04 +0000)]
* fixes for latest hildon version

pmo-trunk-r1704

13 years ago2007-04-27 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 27 Apr 2007 15:49:19 +0000 (15:49 +0000)]
2007-04-27  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-main-window.c:
        (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
        showing/hiding it. Added TODO because it probably should not be NULL.
        * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
        because unnecessary g_warnings() make degugging difficult.

pmo-trunk-r1703

13 years ago2007-04-27 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 27 Apr 2007 15:37:29 +0000 (15:37 +0000)]
2007-04-27  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-msg-edit-window.c:
        (modest_msg_edit_window_select_color),
        (modest_msg_edit_window_select_background_color): 2 const corrections and
        moving 2 #endifs before closing brackets, to fix the build.

pmo-trunk-r1702

13 years agohttps://projects.maemo.org
Murray Cumming [Fri, 27 Apr 2007 15:31:08 +0000 (15:31 +0000)]
https://projects.maemo.org

pmo-trunk-r1701

13 years ago* Sets ASCENDING sort byt sent/received date as default.
Javier Fernandez Garcia-Boente [Fri, 27 Apr 2007 15:29:41 +0000 (15:29 +0000)]
* Sets ASCENDING sort byt sent/received  date as default.
* Remove unused code

pmo-trunk-r1700

13 years ago* make maemo work even with the new libhildon (1.1)
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 15:23:09 +0000 (15:23 +0000)]
* make maemo work even with the new libhildon (1.1)

pmo-trunk-r1699

13 years agoFixed function prototype
Philip Van Hoof [Fri, 27 Apr 2007 15:15:26 +0000 (15:15 +0000)]
Fixed function prototype

pmo-trunk-r1698

13 years ago * Refactored "Move to" code in order to allow this call from the ModestMsgViewWindow
Sergio Villar Senin [Fri, 27 Apr 2007 14:39:31 +0000 (14:39 +0000)]
* Refactored "Move to" code in order to allow this call from the ModestMsgViewWindow

pmo-trunk-r1697

13 years ago2007-04-27 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 27 Apr 2007 14:34:10 +0000 (14:34 +0000)]
2007-04-27  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-msg-view-window.c:
        (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
        when opening a message window.

pmo-trunk-r1696

13 years ago2007-04-27 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 27 Apr 2007 13:17:31 +0000 (13:17 +0000)]
2007-04-27  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_custom_outgoing): Correct the position of the horizontal separator to
        match the UI spec.

        * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
        before showing/hiding them, to avoid a crash when clicking on folders when there are no
        gconf settings. I probably added more checks than necessary, but that is safer.

        * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
        variable to fix the build, but this seems to be used when it is still NULL.

pmo-trunk-r1695

13 years ago * Modified the xfer_msg API
Sergio Villar Senin [Fri, 27 Apr 2007 12:43:24 +0000 (12:43 +0000)]
* Modified the xfer_msg API
* Modified the run_confirmation_dialog API
* Added some more code to the "move to" dialog

pmo-trunk-r1694

13 years ago* don't use gobjects that might be dead
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 12:30:16 +0000 (12:30 +0000)]
* don't use gobjects that might be dead

pmo-trunk-r1693

13 years ago2007-04-27 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 27 Apr 2007 11:35:53 +0000 (11:35 +0000)]
2007-04-27  Murray Cumming  <murrayc@murrayc.com>

* src/modest-platform.h:
        * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
        * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
        * src/modest-main.c: Implement this function so we can avoid using
        maemo-specific API from cross-platform code.
        (main):
        * src/modest-tny-account-store.c:
        (get_smtp_specific_transport_account_for_open_connection):
        * src/modest-ui-actions.c: (check_for_connection),
        (modest_ui_actions_on_item_not_found):
        Use modest_platform_connect_and_wait() and put #idefs around other
        maemo-specific code, because only maemo currently has a way to
        identify connection names.

pmo-trunk-r1692

13 years ago2007-04-27 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 27 Apr 2007 11:12:36 +0000 (11:12 +0000)]
2007-04-27  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.h:
        * src/modest-tny-account-store.c:
        Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
        the connection-specific SMTP server settings in the configuration.

        * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
        (on_idle_mail_to):
        * src/maemo/modest-main-window.c: (on_connection_changed),
        (connect_signals):
        * src/modest-main.c: (main), (start_ui), (send_mail):
        Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
        that is what is intended.

        * src/modest-ui-actions.c: (action_send), (action_receive),
        (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
        Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
        modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
        SMTP server is used when it is specified.

        (modest_ui_actions_on_send_receive):
        Check that a connection is open before proceeding.
        Receive and then send, instead of vice-versa, as per the specification

pmo-trunk-r1691

13 years ago* remove the modest-debug stuff; it belong in modest-runtime
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 11:12:10 +0000 (11:12 +0000)]
* remove the modest-debug stuff; it belong in modest-runtime

pmo-trunk-r1690

13 years ago * Added "Move to" dialog
Sergio Villar Senin [Fri, 27 Apr 2007 10:20:35 +0000 (10:20 +0000)]
* Added "Move to" dialog
* "Move to" dialog can transfer folders right now
* Added some documentaion
* Replaced wrong ORs by ANDs when checking folder rules

pmo-trunk-r1689

13 years ago* add modest-providers-data to build deps
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 10:04:47 +0000 (10:04 +0000)]
* add modest-providers-data to build deps

pmo-trunk-r1688

13 years ago* more fixes for the debian build
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 07:34:32 +0000 (07:34 +0000)]
* more fixes for the debian build

pmo-trunk-r1687

13 years ago* unbreak configure.ac
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 07:10:34 +0000 (07:10 +0000)]
* unbreak configure.ac

pmo-trunk-r1686

13 years agoupdate control to depend on libconic
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 06:42:19 +0000 (06:42 +0000)]
update control to depend on libconic

pmo-trunk-r1685

13 years agoremove subcontractor name because integration won't work otherwise
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 06:28:43 +0000 (06:28 +0000)]
remove subcontractor name because integration won't work otherwise

pmo-trunk-r1684

13 years agocleanup control file for debian build
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 06:26:53 +0000 (06:26 +0000)]
cleanup control file for debian build

pmo-trunk-r1683

13 years ago* small cleanups for debian build
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 06:18:51 +0000 (06:18 +0000)]
* small cleanups for debian build

pmo-trunk-r1682

13 years ago* cleanup the translations
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 06:18:09 +0000 (06:18 +0000)]
* cleanup the translations

pmo-trunk-r1681

13 years ago* Implement Observer pattern using ModestProgressBarWidget.
Javier Fernandez Garcia-Boente [Thu, 26 Apr 2007 19:15:21 +0000 (19:15 +0000)]
* Implement Observer pattern using ModestProgressBarWidget.
* Adds an observer to mail operation queue into main window
to establish toolbar operation mode.

pmo-trunk-r1680

13 years ago2007-04-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 26 Apr 2007 13:45:08 +0000 (13:45 +0000)]
2007-04-26  Murray Cumming  <murrayc@murrayc.com>

* src/modest-mail-operation.c:
        (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
        though I guess it should be something other than NULL.

pmo-trunk-r1679

13 years ago* Fix bug on sorting headers list. The gtk_tree_model_sort
Javier Fernandez Garcia-Boente [Thu, 26 Apr 2007 12:43:14 +0000 (12:43 +0000)]
* Fix bug on sorting headers list. The gtk_tree_model_sort
was created on each folder refresh, and sorting column id
was not set again correctly.

pmo-trunk-r1678

13 years ago * Removed some unused errors
Sergio Villar Senin [Thu, 26 Apr 2007 11:18:28 +0000 (11:18 +0000)]
* Removed some unused errors
* Removed error handling code froms Queues
* Added ModestFolderRules to mail operations

pmo-trunk-r1677

13 years ago* Add a GSlist to store observers, allowing connect more
Javier Fernandez Garcia-Boente [Thu, 26 Apr 2007 10:20:58 +0000 (10:20 +0000)]
* Add a GSlist to store observers, allowing connect more
than one progress widgets.
* Change set_toolbar_function visibility; now it's a private function.

pmo-trunk-r1676

13 years ago2007-04-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 26 Apr 2007 09:47:08 +0000 (09:47 +0000)]
2007-04-26  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
        combo twice, to avoid an g_warning and to make it visible again.
        * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
        attached before detaching it, to avoid a g_warning, and add comment about the implicit
        (already intended) dereference when detaching, because we then recreate the menu.
        But I am not sure why the warning was happening, and it is possible that this is a memory
        leak.

pmo-trunk-r1675

13 years ago * Added some missing "== 0" comparisons
Sergio Villar Senin [Thu, 26 Apr 2007 09:31:28 +0000 (09:31 +0000)]
* Added some missing "== 0" comparisons

pmo-trunk-r1674

13 years ago* Add new header settings parameter (sort) to select
Javier Fernandez Garcia-Boente [Thu, 26 Apr 2007 08:54:09 +0000 (08:54 +0000)]
* Add new header settings parameter (sort) to select
columns which can be used to sort headers list.
* Review restore_settings_header to set TreeSortable
sort column id.

pmo-trunk-r1673

13 years ago* Add a new widget ModestProgressBarWidget to work as observer
Javier Fernandez Garcia-Boente [Thu, 26 Apr 2007 08:45:49 +0000 (08:45 +0000)]
* Add a new widget ModestProgressBarWidget to work as observer
of ModestMainWindow object.
* Add ui manager toolitems for this new widget and Cancel button.
* Sinchronize toolbar items dimming based on toolbar operation
mode (Normal/Transfer).

pmo-trunk-r1672

13 years ago* lintian update (Section:)
Dirk-Jan C. Binnema [Wed, 25 Apr 2007 20:08:28 +0000 (20:08 +0000)]
* lintian update (Section:)

pmo-trunk-r1670

13 years ago * Added ModestFolderViewStyle
Sergio Villar Senin [Wed, 25 Apr 2007 20:05:35 +0000 (20:05 +0000)]
* Added ModestFolderViewStyle
* Added "show one remote account at a time" feature
* Modest version shows only one remote account by default

pmo-trunk-r1669

13 years ago* lintian fixes
Dirk-Jan C. Binnema [Wed, 25 Apr 2007 19:56:34 +0000 (19:56 +0000)]
* lintian fixes

pmo-trunk-r1668

13 years ago * Deleted debug code
Sergio Villar Senin [Wed, 25 Apr 2007 17:20:41 +0000 (17:20 +0000)]
* Deleted debug code

pmo-trunk-r1667

13 years ago * Fixed accounts order in the folder view
Sergio Villar Senin [Wed, 25 Apr 2007 17:20:04 +0000 (17:20 +0000)]
* Fixed accounts order in the folder view

pmo-trunk-r1666

13 years agobetter rules
Dirk-Jan C. Binnema [Wed, 25 Apr 2007 10:11:53 +0000 (10:11 +0000)]
better rules

pmo-trunk-r1664

13 years ago2007-04-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 25 Apr 2007 09:54:58 +0000 (09:54 +0000)]
2007-04-25  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
        and uri_parse_mailto() utility functions.
        (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
        the mailto URI.
        * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.

pmo-trunk-r1663

13 years ago* put Packages.gz in $PACKAGE_PATH
Dirk-Jan C. Binnema [Wed, 25 Apr 2007 08:21:32 +0000 (08:21 +0000)]
* put Packages.gz in $PACKAGE_PATH

pmo-trunk-r1662

13 years ago* small update, to be smarter about already built packages
Dirk-Jan C. Binnema [Wed, 25 Apr 2007 08:16:34 +0000 (08:16 +0000)]
* small update, to be smarter about already built packages

pmo-trunk-r1661