modest
13 years ago* src/modest-defs.h:
Jose Dapena Paz [Thu, 20 Dec 2007 17:32:25 +0000 (17:32 +0000)]
* src/modest-defs.h:
        * Add (hidden) setting to enable fetching external images in
          html messages.
* src/widgets/modest-gtkhtml-mime-part-view.c:
        * Now it fetches external images from http servers, if allowed
          in a hidden setting. It does the fetch asynchronously so that
          it's retrieved after showing the message.
* src/modest-init.c:
        * Default value of fetching external images is false.

pmo-trunk-r3953

13 years ago* don't include Cc: with reply, only with replyall
Dirk-Jan C. Binnema [Thu, 20 Dec 2007 17:21:25 +0000 (17:21 +0000)]
* don't include Cc: with reply, only with replyall

pmo-trunk-r3952

13 years ago* berto is smarter than i am
Dirk-Jan C. Binnema [Thu, 20 Dec 2007 17:04:45 +0000 (17:04 +0000)]
* berto is smarter than i am

pmo-trunk-r3951

13 years ago* only remove ourselves from the To: if we do ReplyAll;
Dirk-Jan C. Binnema [Thu, 20 Dec 2007 16:54:06 +0000 (16:54 +0000)]
* only remove ourselves from the To: if we do ReplyAll;
  and when even then, only if there are multiple recipients.

Fixes: NB#78773

pmo-trunk-r3950

13 years ago * Fixes NB#63571, connection dialog is offered if we try to create a folder in...
Sergio Villar Senin [Thu, 20 Dec 2007 16:21:17 +0000 (16:21 +0000)]
 * Fixes NB#63571, connection dialog is offered if we try to create a folder in offline mode

pmo-trunk-r3949

13 years ago * Fixes NB#78699, there was a missing refilter before selecting the new folder
Sergio Villar Senin [Thu, 20 Dec 2007 13:10:32 +0000 (13:10 +0000)]
* Fixes NB#78699, there was a missing refilter before selecting the new folder
* Fixed a reference leak reported by pvanhoof

pmo-trunk-r3948

13 years ago* src/modest-tny-msg.c:
Jose Dapena Paz [Thu, 20 Dec 2007 11:33:12 +0000 (11:33 +0000)]
* src/modest-tny-msg.c:
* Preserve content id of mime parts in copy_mime_part and
  add_attachments methods, if any available. This should make
  mails with embedded images in modest be constructed properly
  again (fixes NB#78698).

pmo-trunk-r3947

13 years ago* add a libcurl-check (we'll need that when for downloading imgs)
Dirk-Jan C. Binnema [Thu, 20 Dec 2007 06:50:44 +0000 (06:50 +0000)]
* add a libcurl-check (we'll need that when for downloading imgs)

pmo-trunk-r3946

13 years agoShow "Copied" banner after copying a URL
Alberto Garcia [Wed, 19 Dec 2007 19:07:50 +0000 (19:07 +0000)]
Show "Copied" banner after copying a URL
Fixes NB#78751

pmo-trunk-r3945

13 years ago * Use the async function instead of the sync call
Sergio Villar Senin [Wed, 19 Dec 2007 15:19:44 +0000 (15:19 +0000)]
* Use the async function instead of the sync call

pmo-trunk-r3944

13 years ago * Added MCE ifdefs
Sergio Villar Senin [Wed, 19 Dec 2007 10:03:37 +0000 (10:03 +0000)]
* Added MCE ifdefs

pmo-trunk-r3943

13 years agoAdded the mce-dev dependency.
Vivek Sekar [Wed, 19 Dec 2007 09:32:10 +0000 (09:32 +0000)]
Added the mce-dev dependency.

pmo-trunk-r3942

13 years agoDon't fail if maemo-launcher-dev is not installed
Alberto Garcia [Tue, 18 Dec 2007 19:06:07 +0000 (19:06 +0000)]
Don't fail if maemo-launcher-dev is not installed

pmo-trunk-r3941

13 years agoUse dh_maemolauncher
Alberto Garcia [Tue, 18 Dec 2007 18:08:33 +0000 (18:08 +0000)]
Use dh_maemolauncher

pmo-trunk-r3940

13 years agoAdd LAUNCHER_DEPENDS to debian/rules
Alberto Garcia [Tue, 18 Dec 2007 17:41:54 +0000 (17:41 +0000)]
Add LAUNCHER_DEPENDS to debian/rules

pmo-trunk-r3939

13 years agoGet maemo-launcher flags using pkg-config from autoconf
Alberto Garcia [Tue, 18 Dec 2007 17:29:10 +0000 (17:29 +0000)]
Get maemo-launcher flags using pkg-config from autoconf

pmo-trunk-r3938

13 years ago* only change the window title if the new title is different from
Dirk-Jan C. Binnema [Tue, 18 Dec 2007 15:05:13 +0000 (15:05 +0000)]
* only change the window title if the new title is different from
  the old one; updating is apparently an expensive op, and the
  window mgr, gtk, etc. don't do this check themselves

pmo-trunk-r3937

13 years ago * Fixes NB#78357, new mail sound is played now with IMAP IDLE events
Sergio Villar Senin [Tue, 18 Dec 2007 15:00:28 +0000 (15:00 +0000)]
* Fixes NB#78357, new mail sound is played now with IMAP IDLE events

pmo-trunk-r3936

13 years agoFixes NB#78683
Felipe Erias Morandeira [Tue, 18 Dec 2007 14:29:08 +0000 (14:29 +0000)]
Fixes NB#78683
 * Adds checks for NULL values from modest_tny_send_queue_get_outbox() and modest_tny_account_get_special_folder()
 * Also, removes three dummy g_warning() in modest-msg-edit-window.c

pmo-trunk-r3935

13 years agoUse always the default account when creating a new message
Alberto Garcia [Tue, 18 Dec 2007 12:14:07 +0000 (12:14 +0000)]
Use always the default account when creating a new message
Fixes NB#65189

pmo-trunk-r3934

13 years ago * modest-msg-edit-window.c:
Felipe Erias Morandeira [Tue, 18 Dec 2007 10:02:50 +0000 (10:02 +0000)]
   * modest-msg-edit-window.c:
      (modest_msg_edit_window_set_format_state) : the menus are updated after we change the state of the editor
      (text_buffer_refresh_attributes) : the state of alignment menu items is updated when the cursor moves

pmo-trunk-r3933

13 years agoCheck for the existence of GErrors in modest_mail_operation_save_to_drafts_cb()
Alberto Garcia [Mon, 17 Dec 2007 15:28:42 +0000 (15:28 +0000)]
Check for the existence of GErrors in modest_mail_operation_save_to_drafts_cb()

pmo-trunk-r3932

13 years agoChanges to speed up opening messages in view and editor
Jose Dapena Paz [Mon, 17 Dec 2007 12:38:22 +0000 (12:38 +0000)]
Changes to speed up opening messages in view and editor
* src/maemo/modest-msg-edit-window.c:
        * Do the show all of edit window construction to make it
          feel a bit faster.
* src/maemo/modest-msg-view-window.c:
        * Show all early to feel faster.
        * Dimming rules should be evaluated after being visible, not
          before.
* src/modest-ui-dimming-rules.c:
        * Make clipboard checks for GtkHtml be avoided when the
          selection is empty.

pmo-trunk-r3931

13 years ago * Fixes NB#78639, modest does not perform an update if the auto-update is disabled
Sergio Villar Senin [Mon, 17 Dec 2007 11:27:28 +0000 (11:27 +0000)]
* Fixes NB#78639, modest does not perform an update if the auto-update is disabled

pmo-trunk-r3930

13 years ago * Reverted my previous commit, the problem was in tinymail camel
Sergio Villar Senin [Mon, 17 Dec 2007 10:42:16 +0000 (10:42 +0000)]
* Reverted my previous commit, the problem was in tinymail camel

pmo-trunk-r3929

13 years ago * Fixed the change to the new tinymail API
Sergio Villar Senin [Mon, 17 Dec 2007 10:39:06 +0000 (10:39 +0000)]
* Fixed the change to the new tinymail API

pmo-trunk-r3928

13 years ago* make modest handle mailing lists somewhat correcter (RFC2369):
Dirk-Jan C. Binnema [Sun, 16 Dec 2007 12:48:55 +0000 (12:48 +0000)]
* make modest handle mailing lists somewhat correcter (RFC2369):
- with-reply all, reply to both the old From: and the Reply-To: address
  (in non-mailinglist cases, we ignore From: if there's a Reply-To:)
- remove duplicate entries in the To: field
- added modest_text_utils_remove_duplicate_addresses (name says it all)
- rewrote modest_text_utils_split_addresses_list; the old version appended
          the ","-seperator in some cases; the old impl is still there but #ifdef'd-out
  jdapena: please check the new impl, I think you wrote the old one
- added modest_tny_msg_get_header to get some header; I think a version
          of this function should go to Tinymail instead;

should fix NB #78638

Note: the real bug there seems to be that tny_header_get_reply_to always(?)
returns NULL; I worked around it by using the abovementioned,
modest_tny_msg_get_header (msg, "Reply-To")
now it works.

pmo-trunk-r3927

13 years ago* compile for tinymail API change
Dirk-Jan C. Binnema [Sun, 16 Dec 2007 10:08:45 +0000 (10:08 +0000)]
* compile for tinymail API change

pmo-trunk-r3926

13 years agoUpdate Modest to latest API change in Tinymail - rev. 3141
Philip Van Hoof [Sat, 15 Dec 2007 19:24:30 +0000 (19:24 +0000)]
Update Modest to latest API change in Tinymail - rev. 3141

pmo-trunk-r3925

13 years ago* no need for maemo-providers-data
Dirk-Jan C. Binnema [Fri, 14 Dec 2007 20:52:50 +0000 (20:52 +0000)]
* no need for maemo-providers-data

pmo-trunk-r3924

13 years ago * Fixed a memory leak
Sergio Villar Senin [Fri, 14 Dec 2007 17:09:47 +0000 (17:09 +0000)]
* Fixed a memory leak
* Removed some notification stuff since it's no longer needed since Felipe's changes to progress bar

pmo-trunk-r3923

13 years agoFixes NB#78637
Felipe Erias Morandeira [Fri, 14 Dec 2007 15:53:38 +0000 (15:53 +0000)]
Fixes NB#78637

pmo-trunk-r3922

13 years agoWeek 51 bug fixes.
Vivek Sekar [Fri, 14 Dec 2007 14:04:06 +0000 (14:04 +0000)]
Week 51 bug fixes.

pmo-trunk-r3920

13 years agoCorrected two g_object_unref
Felipe Erias Morandeira [Fri, 14 Dec 2007 12:43:48 +0000 (12:43 +0000)]
Corrected two g_object_unref

pmo-trunk-r3919

13 years agoCorrected ref and unref of mail operations.
Felipe Erias Morandeira [Fri, 14 Dec 2007 12:30:42 +0000 (12:30 +0000)]
Corrected ref and unref of mail operations.

pmo-trunk-r3918

13 years agoFixes NB#78602
Felipe Erias Morandeira [Fri, 14 Dec 2007 12:05:20 +0000 (12:05 +0000)]
Fixes NB#78602
   * modest-mail-operation-queue.[hc]:
      (modest_mail_operation_queue_get_by_source): returns the mail operations
         in the queue associated with a given source
   * widgets/modest-window-mgr.c:
      (modest_window_mgr_unregister_window): if the window that is being
         closed is a ModestMsgViewWindow, it cancels "open" and "receive"
         operations that have it as their source
   * maemo/modest-main-window.c:
      (on_mail_operation_started): only goes to transfer mode if it is the
         source of the operation whose start has been notified
   * maemo/modest-msg-view-window.c:
      (on_mail_operation_started): only goes to transfer mode if it is the
         source of the operation whose start has been notified
      (view_msg_cb): added checks for cancelled operations and empty fields

pmo-trunk-r3917

13 years agomodest-tny-msg: fixed leak in add_images()
Alberto Garcia [Fri, 14 Dec 2007 11:16:56 +0000 (11:16 +0000)]
modest-tny-msg: fixed leak in add_images()

pmo-trunk-r3916

13 years ago * Speeds up the progress bar, makes things "feel" faster
Sergio Villar Senin [Thu, 13 Dec 2007 18:51:55 +0000 (18:51 +0000)]
* Speeds up the progress bar, makes things "feel" faster

pmo-trunk-r3915

13 years ago* Use the old To: to determine the new To:
Dirk-Jan C. Binnema [Thu, 13 Dec 2007 16:17:50 +0000 (16:17 +0000)]
* Use the old To: to determine the new To:
* Use the old Cc: to determine the new Cc:
* _don't_ add the Bcc:
* code-cleanup

* Together with Sergio's tny patch, fixes:
NB#78589
  and
https://bugs.maemo.org/show_bug.cgi?id=2539

pmo-trunk-r3914

13 years ago* sometimes, the text->html conversion screwed up, because
Dirk-Jan C. Binnema [Thu, 13 Dec 2007 16:01:18 +0000 (16:01 +0000)]
* sometimes, the text->html conversion screwed up, because
  the hyperlinkify happens *after* text->html, and it would
  mistakenly recognize some of the things as part of urls.

https://bugs.maemo.org/show_bug.cgi?id=2540

  Now, we put \007 instead of & when doing the text->html,
  then do the hyperlinkify, then replace \007 with &

pmo-trunk-r3913

13 years agoPartially fixes NB#78521
Felipe Erias Morandeira [Thu, 13 Dec 2007 15:30:38 +0000 (15:30 +0000)]
Partially fixes NB#78521
  * src/maemo/modest-progress-bar-widget.c:
    When the progress bar receives a "progress-changed" signal from its mail operation
    where state->done = 0 and state->total = 0, it begins to pulse periodically until
    the mail operation finishes or it receives a "progress-changed" signal with
    positive values.
    * (modest_progress_bar_widget_is_pulsating) :
    * (modest_progress_bar_widget_set_pulsating_mode) : manage this pulsating mode

* src/modest-mail-operation.c
    * (modest_mail_operation_update_account) :
    * (modest_mail_operation_get_msg) :
    * (modest_mail_operation_get_msgs_full) :
    * (modest_mail_operation_refresh_folder) : these functions send an initial "progress-changed"
        signal because it could happen that the first signal with "real" data takes a long time
        to happen, or in some cases doesn't happen at all, leaving the user with an empty
        progress bar for a while.

pmo-trunk-r3912

13 years ago * Expunge the messages of the local accounts when removing them to save disk space
Sergio Villar Senin [Thu, 13 Dec 2007 13:42:23 +0000 (13:42 +0000)]
* Expunge the messages of the local accounts when removing them to save disk space

pmo-trunk-r3911

13 years agoWork to fix glitches with progress toolbar (fixes NB#78458).
Jose Dapena Paz [Thu, 13 Dec 2007 12:18:52 +0000 (12:18 +0000)]
Work to fix glitches with progress toolbar (fixes NB#78458).
* src/maemo/modest-progress-bar-widget.c:
        * Now we make sure we never set a NULL string as label of the
          progress bar, and we get an initial " " string. This is for
          getting always the expected height. This should prevent some
          toolbar resizements.
* src/maemo/modest-msg-view-window.c,
  src/maemo/modest-main-window.c:
        * Rework the toolbar buttons size management. This way the
          progress toolbar does not cause a resize of the other buttons.
* src/maemo/ui/modest-msg-view-window-ui.xml,
  src/maemo/ui/modest-main-window-ui.xml:
        * Add position attributes to toolbar.

pmo-trunk-r3910

13 years ago * Fixes NB#78587, Modest no longer crashes when closing while s&r
Sergio Villar Senin [Thu, 13 Dec 2007 11:48:56 +0000 (11:48 +0000)]
* Fixes NB#78587, Modest no longer crashes when closing while s&r

pmo-trunk-r3909

13 years ago* src/maemo/modest-main-window-ui.h:
Jose Dapena Paz [Thu, 13 Dec 2007 09:03:25 +0000 (09:03 +0000)]
* src/maemo/modest-main-window-ui.h:
        * Add shortcut for "new email" in message view.
* src/maemo/modest-maemo-utils.[ch]:
        * New method ..._get_manager_menubar_as_menu. This converts
          a GtkMenuBar obtained from ui manager to a GtkMenu as
          expected in hildon_window_set_menu (). Using this instead
          of popup menus in ui manager fixes the shortcuts
          (fixes NB#75525).
* src/maemo/modest-msg-edit-window.c,
  src/maemo/modest-msg-view-window.c,
  src/maemo/modest-main-window.c:
        * Remove menubar_to_menu, as this is now a common method in
         modest_maemo_utils. Use the new method.
* src/maemo/ui/modest-main-window.xml,
  src/maemo/ui/modest-msg-edit-window.xml,
  src/maemo/ui/modest-msg-view-window.xml:
        * Use again menubars.

pmo-trunk-r3908

13 years ago* src/modest-tny-send-queue.c:
Jose Dapena Paz [Wed, 12 Dec 2007 20:41:57 +0000 (20:41 +0000)]
* src/modest-tny-send-queue.c:
* Now we remove the "current" sending message from the send
  queue also when the message sending fails (fixes NB#75510).

pmo-trunk-r3907

13 years ago* src/dbus_api/modest-dbus-callbacks.c:
Jose Dapena Paz [Wed, 12 Dec 2007 19:59:02 +0000 (19:59 +0000)]
* src/dbus_api/modest-dbus-callbacks.c:
        * If message is not found in folder, then we show an error
          dialog (fixes NB#77958).
        * Behave as if the message was not found if the message is
          deleted.
        * Mark the message as seen on opening from dbus callback
          (fixes NB#77847).
* src/maemo/modest-msg-view-window.c:
        * Now it works better without header model or row reference.
        * Update message priority on opening from search.

pmo-trunk-r3906

13 years agoAdd correctly the "Content-Disposition" header to attachments
Alberto Garcia [Wed, 12 Dec 2007 18:42:15 +0000 (18:42 +0000)]
Add correctly the "Content-Disposition" header to attachments
in modest-tny-msg

pmo-trunk-r3905

13 years agoFix memory leak in copy_mime_part()
Alberto Garcia [Wed, 12 Dec 2007 18:11:57 +0000 (18:11 +0000)]
Fix memory leak in copy_mime_part()

pmo-trunk-r3904

13 years agoFix leak in modest-tny-msg
Alberto Garcia [Wed, 12 Dec 2007 17:11:18 +0000 (17:11 +0000)]
Fix leak in modest-tny-msg

pmo-trunk-r3903

13 years agoFix memory leak in create_msg_thread()
Alberto Garcia [Wed, 12 Dec 2007 15:55:46 +0000 (15:55 +0000)]
Fix memory leak in create_msg_thread()

pmo-trunk-r3902

13 years agoFixes NB#78203
Felipe Erias Morandeira [Wed, 12 Dec 2007 12:14:35 +0000 (12:14 +0000)]
Fixes NB#78203
   * The modest_mail_operation_remove_msgs operation takes into account the "leave on server" setting.

pmo-trunk-r3901

13 years ago * Fixes NB#64997, Modest is now able to send an email after removing the trailing...
Sergio Villar Senin [Wed, 12 Dec 2007 11:11:19 +0000 (11:11 +0000)]
* Fixes NB#64997, Modest is now able to send an email after removing the trailing ";" from the recipient address

pmo-trunk-r3900

13 years ago * Fixed an error in the documentation
Sergio Villar Senin [Tue, 11 Dec 2007 16:01:33 +0000 (16:01 +0000)]
* Fixed an error in the documentation
* Replaced the call to tny_folder_store_create_folder by tny_folder_store_create_folder_async
* Fixes NB#78382, Modest UI is not blocked while creating a folder

pmo-trunk-r3899

13 years agoAdd checks for some callbacks that are used with connect_and_perform: on_rename_folde...
Felipe Erias Morandeira [Tue, 11 Dec 2007 14:18:24 +0000 (14:18 +0000)]
Add checks for some callbacks that are used with connect_and_perform: on_rename_folder_cb, on_delete_folder_cb, xfer_messages_from_move_to_cb and on_move_folder_cb.

pmo-trunk-r3898

13 years ago * Fixes NB#78470, the account name is now properly updated in the menus when changed
Sergio Villar Senin [Tue, 11 Dec 2007 12:51:43 +0000 (12:51 +0000)]
* Fixes NB#78470, the account name is now properly updated in the menus when changed

pmo-trunk-r3897

13 years agoFixes NB#77454
Felipe Erias Morandeira [Tue, 11 Dec 2007 12:33:55 +0000 (12:33 +0000)]
Fixes NB#77454
Adding support for connect_and_perform() in modest-ui-actions.c, for the public functions:
    * modest_ui_actions_on_move_to(..), both folder->folder and emails->folder
    * modest_ui_actions_on_delete_folder(..)
    * modest_ui_actions_on_move_folder_to_trash_folder(..)

pmo-trunk-r3896

13 years ago* some email programs (e.g. outlook in html mode) put 'normal'
Dirk-Jan C. Binnema [Mon, 10 Dec 2007 16:55:09 +0000 (16:55 +0000)]
* some email programs (e.g. outlook in html mode) put 'normal'
  http://foo.bar/image.jpg links in the html, and then attach
  the image, with Content-Location set to http://foo.bar/image.jpg,
  but the content embedded.

this fix makes sure we will find & show those images

pmo-trunk-r3895

13 years agoAdded the base64 encoded icon file into the chinook control file.
Vivek Sekar [Mon, 10 Dec 2007 15:51:15 +0000 (15:51 +0000)]
Added the base64 encoded icon file into the chinook control file.

pmo-trunk-r3894

13 years agoFix shortcut for Send in the message editor
Alberto Garcia [Mon, 10 Dec 2007 13:55:45 +0000 (13:55 +0000)]
Fix shortcut for Send in the message editor
Fixes NB#65668

pmo-trunk-r3893

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 10 Dec 2007 12:40:51 +0000 (12:40 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * We use lacy detection of mime types on adding files, so that
          it works equal to file manager (fixes NB#63391).

pmo-trunk-r3892

13 years ago* use the correctly sized icons for various things;
Dirk-Jan C. Binnema [Mon, 10 Dec 2007 12:29:21 +0000 (12:29 +0000)]
* use the correctly sized icons for various things;
added a parameter to modest_platform_get_icon
to do this.
  now, the window (editor/viewer) icons don't look
  blurry anymore. improved fix for NB#78393

pmo-trunk-r3891

13 years agoShow a generic error (instead of the one from Tinymail) when
Alberto Garcia [Mon, 10 Dec 2007 12:17:32 +0000 (12:17 +0000)]
Show a generic error (instead of the one from Tinymail) when
a move-to operation fails.
Fixes NB#78371

pmo-trunk-r3890

13 years ago* src/widgets/modest-attachments-view.c:
Jose Dapena Paz [Mon, 10 Dec 2007 10:28:54 +0000 (10:28 +0000)]
* src/widgets/modest-attachments-view.c:
        * Now purged attachments cannot be focused (fixes NB#78368).

pmo-trunk-r3889

13 years agoFix compilation problem
Alberto Garcia [Mon, 10 Dec 2007 09:15:32 +0000 (09:15 +0000)]
Fix compilation problem

pmo-trunk-r3888

13 years ago* some param checks (should prevent a crash )
Dirk-Jan C. Binnema [Mon, 10 Dec 2007 08:54:39 +0000 (08:54 +0000)]
* some param checks (should prevent a crash )

pmo-trunk-r3887

13 years agoremove needless g_warning
Dirk-Jan C. Binnema [Fri, 7 Dec 2007 13:12:28 +0000 (13:12 +0000)]
remove needless g_warning

pmo-trunk-r3886

13 years agoAdded bug fixes for week 50 release.
Vivek Sekar [Fri, 7 Dec 2007 13:00:57 +0000 (13:00 +0000)]
Added bug fixes for week 50 release.

pmo-trunk-r3884

13 years ago* show the specific icons for the edit-window and the viewer-window.
Dirk-Jan C. Binnema [Fri, 7 Dec 2007 11:51:44 +0000 (11:51 +0000)]
* show the specific icons for the edit-window and the viewer-window.
  problem was that hildon expect 64x54 icons (undocumented); so
  now we're scaling the icons a bit. unfortunately, the scaled icons
  look a bit blurry (GDK_INTERP_BILINEAR), so filing a bug against
  graphics to get better icons.

Fixes: NB#78366, NB#78367

pmo-trunk-r3883

13 years ago* it makes sense not to allow '&' and '#' in new folder names,
Dirk-Jan C. Binnema [Fri, 7 Dec 2007 11:17:04 +0000 (11:17 +0000)]
* it makes sense not to allow '&' and '#' in new folder names,
  as IMAP RFC says they should be 'avoided', and are troublesome
  anyway for cmdline users.

Fixes: NB#78380

pmo-trunk-r3882

13 years ago * Removed some weird const
Sergio Villar Senin [Wed, 5 Dec 2007 17:58:22 +0000 (17:58 +0000)]
* Removed some weird const

pmo-trunk-r3881

13 years agoNew function modest_platform_information_banner_with_timeout()
Alberto Garcia [Wed, 5 Dec 2007 15:26:45 +0000 (15:26 +0000)]
New function modest_platform_information_banner_with_timeout()
Set a short timeout to the "Opening" banner so it disappears earlier
Fixes NB#76842

pmo-trunk-r3880

13 years ago* src/maemo/modest-platform.c:
Jose Dapena Paz [Wed, 5 Dec 2007 13:51:57 +0000 (13:51 +0000)]
* src/maemo/modest-platform.c:
* Small fix for the sort type dialog. We were setting a limit of
  5 sort types when we have 6 (fixes NB#78350).

pmo-trunk-r3879

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Wed, 5 Dec 2007 13:36:46 +0000 (13:36 +0000)]
* src/modest-ui-actions.c:
        * Removed unused code.
* src/modest-ui-dimming-rules.c:
        * Add dimming rule to prevent removing attachments of messages
          we're sending (fixes NB#76634).

pmo-trunk-r3878

13 years agoFixes a GLIB WARNING by providing empty implementations to set_zoom() and get_zoom().
Felipe Erias Morandeira [Wed, 5 Dec 2007 12:15:51 +0000 (12:15 +0000)]
Fixes a GLIB WARNING by providing empty implementations to set_zoom() and get_zoom().

pmo-trunk-r3877

13 years ago * Fixes NB#78338, the summary.mmap files are deleted once the account is removed
Sergio Villar Senin [Wed, 5 Dec 2007 12:05:44 +0000 (12:05 +0000)]
* Fixes NB#78338, the summary.mmap files are deleted once the account is removed

pmo-trunk-r3876

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Wed, 5 Dec 2007 11:35:46 +0000 (11:35 +0000)]
* src/modest-ui-actions.c:
        * (modest_ui_actions_on_send_receive): we do not force a set
          folder here for currently focused folder. This prevents an
          unnecessary refresh of focused folder if it's not inbox.
        * (on_send_receive_finished): replaced the second set_folder
          with a mail operation to refresh the currently focused folder
          if it's not the inbox. THis way we finally don't lose focus on
          refresh (fixes NB#64670).

pmo-trunk-r3875

13 years agoFixes NB#78266
Felipe Erias Morandeira [Wed, 5 Dec 2007 11:15:08 +0000 (11:15 +0000)]
Fixes NB#78266

pmo-trunk-r3874

13 years ago * Fixes NB#77589, modest asks the user if they want to retrieve more mails than...
Sergio Villar Senin [Wed, 5 Dec 2007 11:07:47 +0000 (11:07 +0000)]
* Fixes NB#77589, modest asks the user if they want to retrieve more mails than the retrieve limit
* Fixes a very stupid bug by myself that was preventing opening messages in offline mode

pmo-trunk-r3873

13 years ago* Revert changes made in r3868. We have a better solution now
Alberto Garcia [Wed, 5 Dec 2007 10:59:51 +0000 (10:59 +0000)]
* Revert changes made in r3868. We have a better solution now
* New function easysetup_country_combo_box_load_data(), to actually
  fill the combo with the list of countries.
* Call it in an idle function so Modest startup time is even faster.

pmo-trunk-r3872

13 years ago* only output message/header registering/opening debug stuff
Dirk-Jan C. Binnema [Wed, 5 Dec 2007 10:21:44 +0000 (10:21 +0000)]
* only output message/header registering/opening debug stuff
  if MODEST_DEBUG contains "debug-code"

pmo-trunk-r3871

13 years agoPartially fixes NB#77528
Felipe Erias Morandeira [Wed, 5 Dec 2007 10:03:30 +0000 (10:03 +0000)]
Partially fixes NB#77528
Solves a memory problem when obtaining the size of an attachemnt
   * modest-count-stream.[ch] : implementation of TnyStream to get the size of a stream withou wasting extra memory
   * widgets/modest-attachment-view.c : uses the former to get the size of attachments
   * modest-mail-operation.c : removed two redundant lines
   * modest-tny-send-queue.c : check for NULL value before a strdup()

pmo-trunk-r3870

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Wed, 5 Dec 2007 09:18:32 +0000 (09:18 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * (modest_msg_edit_window_select_font): preserve old font size
          in case it's not set in font selector.

pmo-trunk-r3869

13 years agoDelay call to gtk_widget_show(self->combo_account_country)
Alberto Garcia [Wed, 5 Dec 2007 08:56:08 +0000 (08:56 +0000)]
Delay call to gtk_widget_show(self->combo_account_country)
This makes startup faster
Fixes NB#77425

pmo-trunk-r3868

13 years ago* src/widgets/modest-header-view-render.c,
Jose Dapena Paz [Tue, 4 Dec 2007 22:38:18 +0000 (22:38 +0000)]
* src/widgets/modest-header-view-render.c,
src/modest-tny-send-queue.[ch]:
        * Removed internal method get_status_of_uid, as it's now public
          in modest-tny-send-queue, with name
          modest_tny_all_send_queues_get_msg_status.
* src/maemo/modest-msg-view-window.c:
        * Now we skip failed messages in outbox for next/prev messages
          (fixes NB#78132).

pmo-trunk-r3867

13 years ago* src/maemo/modest-connection-specific-smtp-edit-window.c:
Jose Dapena Paz [Tue, 4 Dec 2007 18:24:35 +0000 (18:24 +0000)]
* src/maemo/modest-connection-specific-smtp-edit-window.c:
* Preserve the account name in connection specific smtp editor.
  This fixes modifying connection specific smtp accounts.

pmo-trunk-r3866

13 years agoCall gtk_combo_box_set_model() *after* loading countries from
Alberto Garcia [Tue, 4 Dec 2007 17:26:10 +0000 (17:26 +0000)]
Call gtk_combo_box_set_model() *after* loading countries from
file, it saves some 2-3 seconds

pmo-trunk-r3865

13 years ago * Partially fixes NB#78203, expunge messages in POP if leave message from server...
Sergio Villar Senin [Tue, 4 Dec 2007 16:49:51 +0000 (16:49 +0000)]
 * Partially fixes NB#78203, expunge messages in POP if leave message from server is unchecked

pmo-trunk-r3864

13 years ago * Do not check if the account is connected in the case of local accounts. Thx Dape...
Sergio Villar Senin [Tue, 4 Dec 2007 13:08:20 +0000 (13:08 +0000)]
* Do not check if the account is connected in the case of local accounts. Thx Dape for reporting this very bad mistake by myself

pmo-trunk-r3863

13 years ago* src/widgets/modest-mozembed-mime-part-view.c renamed as
Jose Dapena Paz [Tue, 4 Dec 2007 11:20:45 +0000 (11:20 +0000)]
* src/widgets/modest-mozembed-mime-part-view.c renamed as
  src/widgets/modest-mozembed-mime-part-view.cpp.
        * Added integration with mozembed glue.
        * Type castings to prevent warnings.
* src/widgets/Makefile.am:
        * Updated.
* configure.ac:
        * Check c++ compiler.

pmo-trunk-r3862

13 years ago* don't use ANONYMOUS@ for non-login SMTP accounts; discussed
Dirk-Jan C. Binnema [Tue, 4 Dec 2007 10:57:05 +0000 (10:57 +0000)]
* don't use ANONYMOUS@ for non-login SMTP accounts; discussed
  this with pvanhoof, and it was meaningless it seems.

this unbreaks support for at least MS Exchange SMTP servers
  without login

pmo-trunk-r3861

13 years agoCheck for NULL in tny_header_get_message_id()
Alberto Garcia [Tue, 4 Dec 2007 10:34:15 +0000 (10:34 +0000)]
Check for NULL in tny_header_get_message_id()

pmo-trunk-r3860

13 years agoFixes NB#66958
Felipe Erias Morandeira [Tue, 4 Dec 2007 10:14:32 +0000 (10:14 +0000)]
Fixes NB#66958
Added ellipsize to the details widget in the main window and to the account name column in the accounts dialog.

pmo-trunk-r3859

13 years agoUse msg id instead of msg url to compare e-mail in both
Alberto Garcia [Mon, 3 Dec 2007 18:44:40 +0000 (18:44 +0000)]
Use msg id instead of msg url to compare e-mail in both
send_mail_msg_sent_handler() and send_mail_error_happened_handler()
Fixes NB#77426

pmo-trunk-r3858

13 years ago* src/widget/Makefile.am, src/maemo/Makefile.am:
Jose Dapena Paz [Mon, 3 Dec 2007 17:36:28 +0000 (17:36 +0000)]
* src/widget/Makefile.am, src/maemo/Makefile.am:
        * Now modest-scroll-area is in widgets instead of maemo.
* Moved src/maemo/modest-scroll-area.[ch] to
  src/widgets/modest-scroll-area.[ch].

pmo-trunk-r3857

13 years ago* modest-detect-tap-and-hold:
Dirk-Jan C. Binnema [Mon, 3 Dec 2007 17:24:55 +0000 (17:24 +0000)]
* modest-detect-tap-and-hold:
- patch contributed by Loic Minier to check
            for the existence of tap-and-old instead
          of MAEMO_CHANGES

pmo-trunk-r3856

13 years ago * The notifications are now opened again after clicking on them
Sergio Villar Senin [Mon, 3 Dec 2007 17:21:50 +0000 (17:21 +0000)]
* The notifications are now opened again after clicking on them
* Fixes NB#77978, the messages from a search result can be opened again

pmo-trunk-r3855

13 years agoCorrection to the chinook control file- now replaces modest-l10n-engb, helps in insta...
Vivek Sekar [Mon, 3 Dec 2007 13:31:18 +0000 (13:31 +0000)]
Correction to the chinook control file- now replaces modest-l10n-engb, helps in installing in diablo.

pmo-trunk-r3854

13 years ago* src/maemo/modest-connection-specific-smtp-window.c:
Jose Dapena Paz [Mon, 3 Dec 2007 13:20:49 +0000 (13:20 +0000)]
* src/maemo/modest-connection-specific-smtp-window.c:
        * Now cancelling edit window does not show confirmation dialog.
* src/maemo/modest-connection-specific-smtp-edit-window.c:
        * Now the range error we show is not the standard number editor
          one. We show it in a timeout, to be able to cancel showing
          it if we press cancel in dialog (fixes NB#76854).

pmo-trunk-r3853

13 years agochinook control file conflicts with modest-l10n-engb, helps in installing in diablo.
Vivek Sekar [Mon, 3 Dec 2007 12:25:11 +0000 (12:25 +0000)]
chinook control file conflicts with modest-l10n-engb, helps in installing in diablo.

pmo-trunk-r3852