modest
13 years ago2007-06-06 Marcus Bauer <marcusb@openismus.com>
Marcus Bauer [Tue, 5 Jun 2007 23:56:44 +0000 (23:56 +0000)]
2007-06-06  Marcus Bauer  <marcusb@openismus.com>

* libmodest-dbus-client/libmodest-dbus-client.h:
added libmodest_dbus_client_compose_mail()
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
(on_compose_mail):
added functions needed for SendAsMail() functionality
* src/maemo/modest-msg-edit-window.c:
(modest_msg_edit_window_attach_file_noninteractive):
non interactively attaching files to message edit window
* src/widgets/modest-msg-edit-window.h:
* tests/dbus_api/Makefile.am:
added test_compose_mail.c
* tests/dbus_api/test_compose_mail.c: (main):

pmo-trunk-r2075

13 years ago2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Tue, 5 Jun 2007 18:59:34 +0000 (18:59 +0000)]
2007-06-05  Johannes Schmid <johannes.schmid@openismus.com>

* src/modest-account-view.c:
Fixed bug projects.maemo.org bug NB#59307

pmo-trunk-r2074

13 years agodirty ChangeLog
Johannes Schmid [Tue, 5 Jun 2007 18:42:54 +0000 (18:42 +0000)]
dirty ChangeLog

pmo-trunk-r2073

13 years ago2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Tue, 5 Jun 2007 18:41:59 +0000 (18:41 +0000)]
2007-06-05  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
(get_serverport_incoming), (on_before_next), (create_account):
* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_set_account_name):
* src/maemo/modest-maemo-utils.c:
(on_camel_account_get_supported_secure_authentication_status),
(on_camel_account_get_supported_secure_authentication),
(on_secure_auth_cancel),
(modest_maemo_utils_get_supported_secure_authentication_methods):

Implemented security authentication for settings and easysetup.

pmo-trunk-r2072

13 years agoImplement "search messages" action (fixes NB#57209).
Jose Dapena Paz [Tue, 5 Jun 2007 15:28:49 +0000 (15:28 +0000)]
Implement "search messages" action (fixes NB#57209).
* src/modest-platform.h:
        * New method to invoke the search messages dialog
* src/gnome/modest-platform.c:
        * Stub implementation for ...show_search_messages
* src/widgets/modest_msg_edit_window-ui.h:
        * Added callback for search messages action
* src/modest-ui-actions.[ch]:
        * Added new ui action to show the search messages dialog,
          relying on modest platform implementation.
* src/maemo/modest-main-window-ui.h:
        * Added callback for search messages action
* src/maemo/modest-platform.c:
        * New ..._show_search_messages method. Shows the osso
          global search dialog for searching emails.
* src/maemo/ui/modest-msg-view-window-ui.xml:
        * Fix and show search messages action.

Other issues:
* libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
        * Fixed -l declaration.

pmo-trunk-r2071

13 years ago2007-06-05 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 5 Jun 2007 14:45:33 +0000 (14:45 +0000)]
2007-06-05  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-main-window.c: (create_details_widget):
Show the total size for memory card accounts too, instead of showing
the name again. Fixes bug projects.maemo.org bug NB#59307.

pmo-trunk-r2070

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 5 Jun 2007 13:03:26 +0000 (13:03 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * (..._attach_file): uses TnyVfsStream (and then gnome vfs)
          instead of TnyFsStream to support attaching files from
          vfs sources (fixes NB#59701).

pmo-trunk-r2069

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 5 Jun 2007 10:47:35 +0000 (10:47 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * There was an infinite loop in the code to search image attachments
          on removal. I fixed it (fixes NB#59440).

pmo-trunk-r2068

13 years agoWork to improve mime type detection in attachment view
Jose Dapena Paz [Tue, 5 Jun 2007 10:14:07 +0000 (10:14 +0000)]
Work to improve mime type detection in attachment view
(fixes NB#57213, NB#57671, NB#57575).
* src/modest-platform.h:
        * (modest_platform_activate_file): now it gets a mime_type parameter,
          in case it was detected previously.
* src/gnome/modest-platform.c:
        * (modest_platform_activate_file): updated API to get mime type
* src/maemo/modest-platform.c:
        * (guess_mime_type_from_file): fixed a trivial bug, that broke the
          detection.
        * (modest_platform_activate_file): use mime type to open the file
          if available, or uses guess_mime_type if no type is provided.
* src/maemo/modest-msg-view-window.c:
        * (..._view_attachment). Preserve the extension on saving the
          attachments to temporary file to view it.
        * (..._view_attachment). Get the mime type of the mime part, and
          pass it to the activate_file call.
* src/maemo/modest-maemo-utils.c:
        * (..._create_temp_stream): now accepts a preferred extension for
          the temporary file.

pmo-trunk-r2067

13 years ago2007-06-05 Murray Cumming <murrayc@murrayc.com>modest/trunk] > more ChangeLog2
Murray Cumming [Tue, 5 Jun 2007 07:42:54 +0000 (07:42 +0000)]
2007-06-05  Murray Cumming  <murrayc@murrayc.com>modest/trunk] > more ChangeLog2

* src/Makefile.am:
        * src/modest-tny-simple-folder-store.c:
        * src/modest-tny-simple-folder-store.h: Removed.

        * src/modest-tny-local-folders-account.h
        * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
        for the local-folders maildir, with an extra TnyMergedFolder containing
        the folders of the per-account outbox store accounts.
        * src/modest-tny-account-store.c: (get_server_accounts):
        Add the outboxes to the special local folders account after creating it.

        * src/modest-tny-account.c:
        (modest_tny_account_new_for_local_folders): Create the derived
        account when creating the main local-folders account.

        * src/maemo/modest-main-window.c: (create_details_widget),
        (modest_main_window_set_contents_style):
        Adapted to the use of the derived account instead of the folder store.

        * src/modest-ui-actions.c:
        (modest_ui_actions_on_folder_selection_changed):
        * src/modest-ui-dimming-rules.c:
        (modest_ui_dimming_rules_on_new_folder):
        * src/widgets/modest-folder-view.c: (text_cell_data),
        (icon_cell_data), (filter_row), (update_model),
        (get_cmp_rows_type_pos):

        * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
        Do not get the priv struct, because no priv struct has been set,
        to avoid a runtime warning.

pmo-trunk-r2066

13 years ago2007-06-05 Christian Kellner <ckellner@openismus.com>
Christian Kellner [Mon, 4 Jun 2007 23:14:35 +0000 (23:14 +0000)]
2007-06-05  Christian Kellner  <ckellner@openismus.com>

* libmodest-dbus-client/libmodest-dbus-client.c:
Fix small typo in doc (why do you always see them
AFTER committing stuff?)

pmo-trunk-r2065

13 years ago2007-06-05 Christian Kellner <ckellner@openismus.com>
Christian Kellner [Mon, 4 Jun 2007 23:12:14 +0000 (23:12 +0000)]
2007-06-05  Christian Kellner  <ckellner@openismus.com>

* libmodest-dbus-client/libmodest-dbus-client.c:
(libmodest_dbus_client_search):
Initialize hit list with NULL. Also set folder list
to "" if NULL was supplied.
Add documentation.

pmo-trunk-r2064

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Mon, 4 Jun 2007 17:32:19 +0000 (17:32 +0000)]
* src/modest-ui-actions.c:
        * Now reply/forward actions do not save original message to
          drafts folder (fixes NB#56702).

pmo-trunk-r2063

13 years ago* src/widgets/modest-header-view.c:
Jose Dapena Paz [Mon, 4 Jun 2007 17:09:15 +0000 (17:09 +0000)]
* src/widgets/modest-header-view.c:
        * Instead of handling mouse clicks we handle row-activated
          signal from GtkTreeView. This way, we support correctly the
          double click in maemo and gnome (the standard ones) and get
          the standard SELECT key behavior too (fixes NB#56200).

pmo-trunk-r2062

13 years agoWork to improve drafts folder management (fixes NB#56483).
Jose Dapena Paz [Mon, 4 Jun 2007 16:37:38 +0000 (16:37 +0000)]
Work to improve drafts folder management (fixes NB#56483).
* src/widgets/modest-msg-edit-window.h:
        * Now the message data contains the draft message the editor was
          created from, if any, and the account name of the From: email
          address we'll use.
* src/modest-ui-actions.c:
        * Now it retrieves the account name from the editor to be able
          to send the message from local folders.
        * Now it retrieves the draft message on trying to send a mail,
          to be able to delete it on send.
        * Now it retrieves the draft message on trying to save to
          drafts, to delete it and replace it with the new edited
          version.
* src/maemo/modest-msg-edit-window.c:
        * Obtains the account name and adds a reference to the drafts
          message on getting message data, to be able to handle sending
          on local folders, and removing drafts that should be removed.
* src/modest-mail-operation.[ch]:
        * Now send new mail removes the draft message the mail is coming
          from, if any.
        * Now save to drafts removes previous draft message if any.
* src/modest-main.c:
        * API update on send_new_mail method.
* src/dbus_api/modest-dbus-callbacks.c:
        * API update on send_new_mail method.

Other fixes:
* src/widgets/modest-msg-edit-window-ui.h:
        * Added non implemented actions for global search and find in
          page.
* src/maemo/ui/modest-msg-edit-window-ui.xml:
        * Add ui manager actions for find in page and global search.
* src/maemo/modest-msg-edit-window.c:
        * Some changes on font size update code.

pmo-trunk-r2061

13 years ago* configure.ac:
Jose Dapena Paz [Mon, 4 Jun 2007 11:43:07 +0000 (11:43 +0000)]
* configure.ac:
        * Added dependecy on hildon-help for hildon-1
* src/maemo/modest-hildon-includes.h:
        * Now it includes hildon-help for hildon-1 platform.
* src/maemo/modest-platform.c:
        * Now it uses hildon-help instead of osso help in hildon-1
          platform.

pmo-trunk-r2060

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Mon, 4 Jun 2007 11:27:29 +0000 (11:27 +0000)]
* src/modest-ui-actions.c:
        * Now doing reply/forward makes the new window inherit the
          zoom level from view window (fixes NB#56475).

pmo-trunk-r2059

13 years ago2007-06-03 Christian Kellner <ckellner@openismus.com>
Christian Kellner [Sun, 3 Jun 2007 18:06:29 +0000 (18:06 +0000)]
2007-06-03  Christian Kellner  <ckellner@openismus.com>

* libmodest-dbus-client/libmodest-dbus-client.c:
(modest_search_hit_list_free):
Make it save to call it with NULL.

* src/dbus_api/modest-dbus-callbacks.c:
* src/modest-search.c:
Return full ModestSearchHits as the search result list not TnyHeader
since can't be around withouth the correspoding TnyFolder.

pmo-trunk-r2058

13 years ago2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Sun, 3 Jun 2007 14:20:52 +0000 (14:20 +0000)]
2007-06-03  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
Added currently commented code to check for secure auth

* src/maemo/modest-account-settings-dialog.c: (on_response),
(save_configuration), (show_ok):
Fixed projects.maemo.org bugs NB #59248 and #59251

* src/maemo/modest-maemo-utils.c:
(on_camel_account_get_supported_secure_authentication_status),
(on_camel_account_get_supported_secure_authentication),
(modest_maemo_utils_get_supported_secure_authentication_methods):
* src/maemo/modest-maemo-utils.h:
Moved get_supported_secure_authentication() method here to be able
to use it from easysetup wizard.

* src/modest-pair.c: (on_pair_compare_as_string):
Should compare string with first part of pair and not
strcmp pairs which will crash.

* src/modest-protocol-info.c:
(modest_protocol_info_protocol_is_store):
* src/modest-protocol-info.h:
Added modest_protocol_info_get_auth_protocol_name()

pmo-trunk-r2057

13 years ago2007-06-03 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Sun, 3 Jun 2007 14:07:12 +0000 (14:07 +0000)]
2007-06-03  Armin Burgmeier  <armin@openismus.com>

* src/modest-mail-operation.c:
(modest_mail_operation_get_msgs_full): Set priv->account also when
only retrieving a single message. This avoids a crash when canceling
the operation.

(modest_mail_operation_notify_end): Do not explicitely remove the
operation from the queue but only emit the progress_changed signal.
The queue itself listens to that signal to remove the operation when
it is finished. This reduces coupling and removes a potential deadlock
when modest_mail_operation_notify_end() is called from the queue
itself. If that is a problem performance-wise, I would suggest to
implement a status-changed signal or something.

* src/modest-mail-operation-queue.c: Make sure to never call a
function from another file while the queue is locked. This (hopefully)
fixes another deadlock when exiting the application while retrieving
mail.

pmo-trunk-r2056

13 years ago2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Sun, 3 Jun 2007 12:09:21 +0000 (12:09 +0000)]
2007-06-03  Johannes Schmid <johannes.schmid@openismus.com>

* src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
        Fixed build if libogs is not available

pmo-trunk-r2055

13 years ago2007-06-03 Christian Kellner <ckellner@openismus.com>
Christian Kellner [Sun, 3 Jun 2007 11:33:58 +0000 (11:33 +0000)]
2007-06-03  Christian Kellner  <ckellner@openismus.com>

* libmodest-dbus-client/libmodest-dbus-client.h:
* libmodest-dbus-client/libmodest-dbus-client.c:
(libmodest_dbus_client_delete_message):
Implement deletion of messages (Client side).

(modest_search_hit_free),
(modest_search_hit_list_free):
Utility functions to free the result hits.

* src/dbus_api/modest-dbus-api.h:
* src/dbus_api/modest-dbus-callbacks.c:
(on_delete_message),
(modest_dbus_req_handler):
Implement deletion of messages (Server side).

* tests/dbus_api/test_search.c: (main):
Free the hits.

* tests/dbus_api/Makefile.am:
* tests/dbus_api/test_delete_message:
Add little test for the message deletion logic

pmo-trunk-r2054

13 years ago2007-06-03 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Sun, 3 Jun 2007 11:20:35 +0000 (11:20 +0000)]
2007-06-03  Armin Burgmeier  <armin@openismus.com>

* src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
when the operation queue was not empty. projects.maemo.org bug
NB#58976.

pmo-trunk-r2052

13 years ago2007-06-03 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Sun, 3 Jun 2007 10:10:40 +0000 (10:10 +0000)]
2007-06-03  Armin Burgmeier  <armin@openismus.com>

* src/widgets/modest-account-view.c
(on_account_default_toggled): Toggle default account column
explicitely instead of waiting for gconf notification (which is
currently ignored). This should fix maemo.projects.org bug NB#56910
for now. It should probably be removed when gconf notifications are
re-enabled.

pmo-trunk-r2051

13 years ago2007-06-03 Christian Kellner <ckellner@openismus.com>
Christian Kellner [Sat, 2 Jun 2007 23:14:17 +0000 (23:14 +0000)]
2007-06-03  Christian Kellner  <ckellner@openismus.com>

* libmodest-dbus-client/libmodest-dbus-client.c:
Removed debugging spew.

* src/dbus_api/modest-dbus-callbacks.c:
Added debugging info.

* src/modest-search.c:
(modest_search_all_accounts):
Use tny_account_store_get_accounts () on the account store
to get all accounts which is the way to get all accounts.

* tests/dbus_api/test_search.c: (main):
Make it possible to supply the search term on the command line.

pmo-trunk-r2050

13 years ago2007-06-03 Christian Kellner <ckellner@openismus.com>
Christian Kellner [Sat, 2 Jun 2007 22:44:21 +0000 (22:44 +0000)]
2007-06-03  Christian Kellner  <ckellner@openismus.com>

* libmodest-dbus-client/libmodest-dbus-client.c:
* libmodest-dbus-client/libmodest-dbus-client.h:
Implement searching for mesages over raw dbus. (Client side)

* src/dbus_api/Makefile.am:
* src/dbus_api/modest-dbus-api.h:
* src/dbus_api/modest-dbus-callbacks.c:
* src/dbus_api/modest-dbus-callbacks.h:
Search framework (Server side). Also implement on_idle_open_message().

* src/maemo/modest-platform.c: (modest_platform_init):
Prepare for raw dbus/osso rpc interaction.

* src/modest-search.h:
Changed minsize from unspecific guint to guint32.

* src/modest-search.c:
(add_header):
Added strange hack which magically made tnymail work.

(modest_search_folder),
(modest_search_account),
(modest_search_all_accounts):
Implement helper functions to search all accounts, specific account
and folder.

* tests/dbus_api/Makefile.am:
* tests/dbus_api/test_open_message.c:
Read url to open from commandline.

* tests/dbus_api/test_search.c:
Implement small test for dbus search stuff

pmo-trunk-r2049

13 years ago2007-06-02 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Sat, 2 Jun 2007 19:34:33 +0000 (19:34 +0000)]
2007-06-02  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-account-settings-dialog.c: Changed window title to
include account type and account title. This fixes projects.maemo.org
bug NB#59000.

pmo-trunk-r2048

13 years ago2007-06-02 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Sat, 2 Jun 2007 18:18:35 +0000 (18:18 +0000)]
2007-06-02  Armin Burgmeier  <armin@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
incoming and outgoing server name based on email address and server
types as long as the names have not been edited manually. This fixes
projects.maemo.org bug NB#58671.

pmo-trunk-r2047

13 years ago2007-06-02 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Sat, 2 Jun 2007 16:00:55 +0000 (16:00 +0000)]
2007-06-02  Armin Burgmeier  <armin@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
server type cannot be changed in future to the incoming details page
when creating an account. This fixes projects.maemo.org bug NB#59029.

pmo-trunk-r2046

13 years ago2007-06-02 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Sat, 2 Jun 2007 15:33:54 +0000 (15:33 +0000)]
2007-06-02  Armin Burgmeier  <armin@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
and assigned max width chars so that they wrap instead of being
truncated. Fixes projects.maemo.org bug NB#56126.

pmo-trunk-r2045

13 years ago2007-06-02 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Sat, 2 Jun 2007 14:16:54 +0000 (14:16 +0000)]
2007-06-02  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-connection-specific-smtp-window.c: Add an
introductory note to the connection specific smtp servers dialog, as
section 8.12 of the email UI specification requires. This fixes
projects.maemo.org bug NB#59212.

pmo-trunk-r2044

13 years ago* Implement remain dimming rules (toolbar and context sensitive menus)
Javier Fernandez Garcia-Boente [Sat, 2 Jun 2007 11:00:31 +0000 (11:00 +0000)]
* Implement remain dimming rules (toolbar and context sensitive menus)
* Fixes: #NB57265, #NB57627, #NB57628, #NB57629, #NB57514, #NB58549, #NB58608, #NB59186, #NB59236

pmo-trunk-r2043

13 years ago2007-06-01 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 1 Jun 2007 18:10:45 +0000 (18:10 +0000)]
2007-06-01  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
Check for running mail operations, and offer to cancel them, as per the UI
spec. This fixes projects.maemo.org bug NB#59041 .
However, I suspect that tinymail may still use the network connection
in ways that we cannot detect or cancel. But it should at least adapt to
changes fairly well.

pmo-trunk-r2042

13 years ago2007-06-01 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 1 Jun 2007 17:49:48 +0000 (17:49 +0000)]
2007-06-01  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (recreate_all_accounts),
        (get_cached_accounts), (get_server_accounts): Do more sensible
        ref-counting of the temporarily-cached outbox accounts list. This seems
        to fix a crash when entering the password when the password was wrong.

pmo-trunk-r2041

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Fri, 1 Jun 2007 16:46:11 +0000 (16:46 +0000)]
* src/modest-ui-actions.c:
        * Fixed the cut/copy/paste clipboard actions. It was storing
          the information in GDK_SELECTION_PRIMARY for widgets that let
          you choose the clipboard to use. Now it uses
          GDK_SELECTION_CLIPBOARD, the expected one (fixes NB#56935).

pmo-trunk-r2040

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Fri, 1 Jun 2007 16:31:30 +0000 (16:31 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now the window title is updated on subject change and on
          message edition startup (fixes NB#56901).

pmo-trunk-r2039

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Fri, 1 Jun 2007 15:21:00 +0000 (15:21 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Fixed a tricky bug. As I runned update-dimmed on focus out,
          and focus out event was happening on clicking the color
          toolbar button, and the update_dimmed dimmed the button
          itself, it was never running the click action. After
          preventing the color toolbar button from getting focus, it
          works as expected (fixes NB#55874).

pmo-trunk-r2038

13 years ago * Added a unique identifier per header
Sergio Villar Senin [Fri, 1 Jun 2007 15:05:50 +0000 (15:05 +0000)]
* Added a unique identifier per header
* Fixes NB#58780

pmo-trunk-r2037

13 years ago2007-06-01 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 1 Jun 2007 15:05:50 +0000 (15:05 +0000)]
2007-06-01  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-retrieve-combo-box.c:
(modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
This fixes projects.maemo.org bug NB#58472 .

pmo-trunk-r2036

13 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Fri, 1 Jun 2007 13:54:25 +0000 (13:54 +0000)]
* src/modest-ui-actions.c:
        * If subject or body are empty on sending message, show
          dialogs to request confirmation (fixes NB#56696).

pmo-trunk-r2035

13 years agoAargh, really fix it.
Murray Cumming [Fri, 1 Jun 2007 10:37:34 +0000 (10:37 +0000)]
Aargh, really fix it.

pmo-trunk-r2033

13 years ago2007-06-01 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 1 Jun 2007 10:36:52 +0000 (10:36 +0000)]
2007-06-01  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_page_complete_easysetup):
        (create_page_complete_custom): Correct the last commit,
        putting the correct sentences in the correct pages.

pmo-trunk-r2032

13 years ago2007-06-01 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 1 Jun 2007 10:34:18 +0000 (10:34 +0000)]
2007-06-01  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_complete_custom): Show the second sentence of text
(mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
NB#59023 .

pmo-trunk-r2031

13 years ago2007-06-01 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 1 Jun 2007 10:22:54 +0000 (10:22 +0000)]
2007-06-01  Murray Cumming  <murrayc@murrayc.com>

* src/modest-account-mgr.c: (modest_account_mgr_add_account):
Set the leave-on-server conf key by default. This fixes
projects.maemo.org bug NB#59258 .

pmo-trunk-r2030

13 years agosbox-SDK_X86: ~/svn/modest-private/modest-email/modest/trunk] > more ChangeLog2
Murray Cumming [Fri, 1 Jun 2007 10:11:19 +0000 (10:11 +0000)]
sbox-SDK_X86: ~/svn/modest-private/modest-email/modest/trunk] > more ChangeLog2
2007-06-01  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-view-window.c:
        (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
        logical ID for the confirmation messages. Fixed projects.maemo.org bug
        NB#59037 .

pmo-trunk-r2029

13 years agoRemoved debug printf.
Murray Cumming [Fri, 1 Jun 2007 10:05:14 +0000 (10:05 +0000)]
Removed debug printf.

pmo-trunk-r2028

13 years ago2007-06-01 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 1 Jun 2007 09:57:26 +0000 (09:57 +0000)]
2007-06-01  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
        (create_caption_new_with_asterisk):
        * src/maemo/modest-account-settings-dialog.c:
        (create_caption_new_with_asterisk):
        Uncomment the code to add the asterisk, because they are no longer in the
        translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
        (update_incoming_server_title): Add an asterisk here too.

pmo-trunk-r2027

13 years ago* src/maemo/modest-msg-edit-window-ui.h:
Jose Dapena Paz [Fri, 1 Jun 2007 09:38:39 +0000 (09:38 +0000)]
* src/maemo/modest-msg-edit-window-ui.h:
        * Added escape accel ui action.
* src/maemo/ui/modest-msg-edit-window-ui.xml:
        * Added escape accel.

pmo-trunk-r2026

13 years ago2007-06-01 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 1 Jun 2007 09:10:15 +0000 (09:10 +0000)]
2007-06-01  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-global-settings-dialog.c:
        (current_connection): Check that we are even connected before trying to
        get the current connection name, to prevent a warning.

        * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
        Change the comments because tny_maemo_conic_device_connect() is now meant to
        block.
        * src/modest-mail-operation.c:
        (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
        make sure we have a connection and fail if we can't connect.

pmo-trunk-r2025

13 years ago* made release
Dirk-Jan C. Binnema [Fri, 1 Jun 2007 07:24:04 +0000 (07:24 +0000)]
* made release

pmo-trunk-r2024

13 years ago* src/maemo/modest-connection-specific-smtp-window.c:
Jose Dapena Paz [Thu, 31 May 2007 21:24:59 +0000 (21:24 +0000)]
* src/maemo/modest-connection-specific-smtp-window.c:
        * Add a default string "Not defined" for connections without an smtp
          server configured (fixes NB#59217).

pmo-trunk-r2023

13 years ago * Fixed a funny typo
Sergio Villar Senin [Thu, 31 May 2007 18:42:39 +0000 (18:42 +0000)]
* Fixed a funny typo

pmo-trunk-r2022

13 years ago2007-05-31 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 31 May 2007 17:58:57 +0000 (17:58 +0000)]
2007-05-31  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-main-window.c:
        (on_account_store_connecting_finished): Do not try to get the
        connection ID if we are not really connected. I am surprised that
        this signal handler is called when we are not connected.

pmo-trunk-r2021

13 years ago * Fixes NB#57580
Sergio Villar Senin [Thu, 31 May 2007 17:52:47 +0000 (17:52 +0000)]
* Fixes NB#57580
* Fixed some issues in a text conversion function
* Do not dimm Email->Details if the folder view has the focus

pmo-trunk-r2020

13 years ago2007-05-31 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 31 May 2007 17:44:48 +0000 (17:44 +0000)]
2007-05-31  Murray Cumming  <murrayc@murrayc.com>

* src/modest-error.h:
        * src/modest-ui-actions.c:
        (modest_ui_actions_get_msgs_full_error_handler):
        Renamed an enum, added comments, added an enum
        for retrieve-limit errors.

        * src/modest-mail-operation.c: (foreach_add_item),
        (internal_folder_observer_update), (update_account_thread),
        (modest_mail_operation_get_msgs_full):
        (modest_mail_operation_update_account),
        Added comments about how this works, and some code that should
        (but does not) check the retrieve-limit. See the TODO comment.

pmo-trunk-r2019

13 years ago* src/widgets/modest-attachments-view.c:
Jose Dapena Paz [Thu, 31 May 2007 16:48:55 +0000 (16:48 +0000)]
* src/widgets/modest-attachments-view.c:
        * Now set_message cleans the selected messages list. This way, setting
          a new message when there was a selection does not crash (fixes
          NB#58227).

pmo-trunk-r2018

13 years ago * Fixes NB#59208
Sergio Villar Senin [Thu, 31 May 2007 16:41:35 +0000 (16:41 +0000)]
* Fixes NB#59208

pmo-trunk-r2017

13 years ago * Fixes NB#57490
Sergio Villar Senin [Thu, 31 May 2007 16:29:30 +0000 (16:29 +0000)]
* Fixes NB#57490

pmo-trunk-r2016

13 years ago* new release
Dirk-Jan C. Binnema [Thu, 31 May 2007 15:53:34 +0000 (15:53 +0000)]
* new release

pmo-trunk-r2014

13 years ago* src/widgets/modest-header-view-render.c:
Jose Dapena Paz [Thu, 31 May 2007 15:10:54 +0000 (15:10 +0000)]
* src/widgets/modest-header-view-render.c:
        * When we want to fill the attach and priority icons with an empty value
          (and show them in blank) we don't need to retrieve a non existing icon,
          setting a NULL to the pixbuf cell renderer works. This fix removes
          a warning on runtime.
* src/maemo/modest-icon-names.h:
        * Updated the trash and junk icon names. This removes also warnings trying
          to get non existing icons in theme.

pmo-trunk-r2013

13 years ago2007-05-31 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 31 May 2007 15:00:42 +0000 (15:00 +0000)]
2007-05-31  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-actions.c: (modest_ui_actions_on_help):
        Initialize help_id to fix the build. Warnings are good.

pmo-trunk-r2012

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Thu, 31 May 2007 14:51:37 +0000 (14:51 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Select font dialog was not destroyed on cancel. This made the app unusable after
          cancelling the dialog. I moved the widget destroy code to make the dialog work
          on Ok and Cancel actions.

pmo-trunk-r2011

13 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Thu, 31 May 2007 14:09:48 +0000 (14:09 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Dims "Add to contacts" at startup of the widget, as clipboard
          should be empty. This prevents trying to add a non valid contact
          (fixes NB#57415).

pmo-trunk-r2010

13 years agoPartial bugfix for 57415
Philip Van Hoof [Thu, 31 May 2007 13:51:32 +0000 (13:51 +0000)]
Partial bugfix for 57415

pmo-trunk-r2009

13 years ago * Fixes NB#57592
Sergio Villar Senin [Thu, 31 May 2007 12:03:42 +0000 (12:03 +0000)]
* Fixes NB#57592
* Adds Help support to the windows, and folder and header CSMs

pmo-trunk-r2008

13 years ago * Fixed a compilation issue in OSSO1.1
Sergio Villar Senin [Thu, 31 May 2007 11:51:15 +0000 (11:51 +0000)]
* Fixed a compilation issue in OSSO1.1

pmo-trunk-r2007

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Thu, 31 May 2007 10:54:28 +0000 (10:54 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Removed the old text_buffer_mark_set handler as it's not required
          now to make cursor scroll update work, and it was causing a
          crash (fixes NB#56975).

pmo-trunk-r2006

13 years ago2007-05-31 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 31 May 2007 08:44:58 +0000 (08:44 +0000)]
2007-05-31  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-hbox-cell-renderer.c:
        (modest_hbox_cell_renderer_append):
        * src/widgets/modest-vbox-cell-renderer.c:
        (modest_vbox_cell_renderer_append):
        Fix the last commit by doing an extra ref.

pmo-trunk-r2005

13 years ago2007-05-31 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 31 May 2007 07:49:28 +0000 (07:49 +0000)]
2007-05-31  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-hbox-cell-renderer.c:
        (modest_hbox_cell_renderer_append):
        * src/widgets/modest-vbox-cell-renderer.c:
        (modest_vbox_cell_renderer_append):
        For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
        to fix the build with Maemo Bora.
        However, there seems to be a remaining crash, probably due to reference
        counting errors.

pmo-trunk-r2004

13 years ago * Fixes NB#56485
Sergio Villar Senin [Thu, 31 May 2007 07:38:05 +0000 (07:38 +0000)]
* Fixes NB#56485
* Now the paned separator is drawn in its correct place

pmo-trunk-r2003

13 years ago* update debian changelog
Dirk-Jan C. Binnema [Thu, 31 May 2007 05:58:13 +0000 (05:58 +0000)]
* update debian changelog

pmo-trunk-r2002

13 years ago* src/widgets/modest-header-view-render.c:
Jose Dapena Paz [Wed, 30 May 2007 16:55:50 +0000 (16:55 +0000)]
* src/widgets/modest-header-view-render.c:
        * (get_pixbuf_for_flag): now it also supports getting specific
          icons for high and low priorities.
        * Removed get_pixbuf_for_compact_flag,
          _modest_header_view_header_cell_data,
          _modest_header_view_compact_date_cell_data,  as it's not
          required in the new header view.
        * Modified the compact view for header view. Now it uses the
          new hbox and vbox cell renderers. Modified also to have
          specific cell renderers for the attachment and priority
          icons. Here we fill the new cell renderers using the model.
* Added src/widgets/modest-hbox-cell-renderer.c:
        * New cell renderer that let's developer embed cell renderers
          in an horizontal layout. Supports specific expanded cell
          renderers.
* Added src/widgets/modest-vbox-cell-renderer.c:
        * New cell renderer that let's developer embed cell renderers
          in an vertical layout. Supports specific expanded cell
          renderers.
* src/widgets/modest-header-view.c:
        * Now cmp_rows is only used for comparing flag columns.
        * Reworked all the sorting code, to use tree model column id's.
        * Modified the compact view for header view. Now it uses the
          new hbox and vbox cell renderers. Modified also to have
          specific cell renderers for the attachment and priority
          icons. Here we construct the cell renderers.
* src/modest-init.c:
        * Removed the old layout cells for compact view.
* src/maemo/modest-platform.c:
        * Reworked the sort dialog to fit with the new sort code
          in header view.

pmo-trunk-r2001

13 years ago2007-05-30 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 30 May 2007 16:35:53 +0000 (16:35 +0000)]
2007-05-30  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account.c:
        (modest_tny_account_new_for_local_folders):
        Use hildon_file_system_info_async_new() to get a better name for
        the memory card account, setting it as the account name.
        The timing seems to work, but this is probably
        not the best place to do this. See the TODO comment.
        * src/maemo/modest-main-window.c: (create_details_widget):
        * src/widgets/modest-folder-view.c: (text_cell_data):
        Use the tny account name instead of hardcoding a name.

pmo-trunk-r2000

13 years ago2007-05-30 Christian Kellner <ckellner@openismus.com>
Christian Kellner [Wed, 30 May 2007 13:31:45 +0000 (13:31 +0000)]
2007-05-30  Christian Kellner  <ckellner@openismus.com>

* src/modest-search.c: (modest_search):
Correctly set part_search_func even if we have already parsed
the query and thus a valid OgsTextSearcher object.

pmo-trunk-r1999

13 years ago2007-05-30 Christian Kellner <ckellner@openismus.com>
Christian Kellner [Wed, 30 May 2007 13:27:07 +0000 (13:27 +0000)]
2007-05-30  Christian Kellner  <ckellner@openismus.com>

* configure.ac:
Search and check for libogs.

* src/Makefile.am:
Incooparte the ogs build env.

* src/modest-mime-part-search-stream.c:
* src/modest-mime-part-search-stream.h:
Removed since we do the real searching now in modest-search.c.

* src/modest-search.c:
* src/modest-search.h:
Implement support for ogs. We use that if available and requested
and fall back to modest_text_utils_utf8_strcmp (). The search logic
should now handle the corner case when the search term is spread
across multiple reads.
Also the logic in modest_search () was corrected to search all
requested fields until one is found.

pmo-trunk-r1998

13 years ago * Removed an invalid g_object_unref in a mail operation
Sergio Villar Senin [Wed, 30 May 2007 12:50:39 +0000 (12:50 +0000)]
* Removed an invalid g_object_unref in a mail operation
* Rewritten the dimming rules for the "new folder" action
* Removed some invalid comments
* Fixed some errors in mail_operation_create_folder

pmo-trunk-r1997

13 years ago* Add the MsgView Window dimming rules file.
Javier Fernandez Garcia-Boente [Wed, 30 May 2007 12:29:41 +0000 (12:29 +0000)]
* Add the MsgView Window dimming rules file.
* Fix bug on mail-operation, cancel operation was commented.
* Fix bug on mail_operation_queue_remove, it did not take
into account mail op status may be CANCELED.
* Implemented some main and msg view windows dimming rules.

pmo-trunk-r1996

13 years ago2007-05-30 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 30 May 2007 12:27:26 +0000 (12:27 +0000)]
2007-05-30  Murray Cumming  <murrayc@murrayc.com>

* src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.

        * src/modest-init.h:
        * src/modest-init.c: Made modest_init_local_folders() take a
        path and be public so we can iniitialize maildir folders on
        arbitrary volumes.

        * src/modest-local-folder-info.h:
        * src/modest-local-folder-info.c:
        (modest_local_folder_info_get_maildir_path): Add a path parameter.

        * src/modest-tny-account.c:
        (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
        still means the standard local-folders path on the local volume.

        * src/modest-tny-account-store.c:
        (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
        signal so we can detect mount/unmount of the MMC1 card, and do an update of
        all accounts when that happens.
        (get_server_accounts): If the MMC1 card is mounted, create a store account for
        this too, so it shows up in the treeview.

pmo-trunk-r1995

13 years ago * Preppended a FIXME to the MMC provisional name until there is now way to get it
Sergio Villar Senin [Wed, 30 May 2007 09:24:32 +0000 (09:24 +0000)]
* Preppended a FIXME to the MMC provisional name until there is now way to get it
* The local account has its name properly set again

pmo-trunk-r1994

13 years ago * Just an aesthetic change to add two bugfixes commit comments
Sergio Villar Senin [Wed, 30 May 2007 07:55:24 +0000 (07:55 +0000)]
* Just an aesthetic change to add two bugfixes commit comments
* Fixes NB#56137, NB#56140

pmo-trunk-r1993

13 years ago * Added a sanity check in error handling code
Sergio Villar Senin [Wed, 30 May 2007 07:27:00 +0000 (07:27 +0000)]
* Added a sanity check in error handling code
* Added status information to get_msgs_full mail operation
* Replaced some GError variables by priv->error of mail operations
* Added a new error code

pmo-trunk-r1992

13 years ago* Implementation of 'email menu' dimming rules of main window.
Javier Fernandez Garcia-Boente [Tue, 29 May 2007 20:39:49 +0000 (20:39 +0000)]
* Implementation of 'email menu' dimming rules of main window.
* Implementation of 'edit menu' dimming rules of main window.
* Implementation of 'folder view CSM' dimming rules of main window.

pmo-trunk-r1991

13 years ago * Fixed NB#57522
Sergio Villar Senin [Tue, 29 May 2007 17:40:01 +0000 (17:40 +0000)]
* Fixed NB#57522
* Added delete_folder and move_folder error handling code
* Deleted some invalid error handling code

pmo-trunk-r1990

13 years ago * Fixes NB#57522
Sergio Villar Senin [Tue, 29 May 2007 17:12:03 +0000 (17:12 +0000)]
    * Fixes NB#57522
        * Slightly modified the mail operations error handler signature
        * Added the code that launches the mail operation error handlers
        * Added information note that is shown when the message size limit is exceeded

pmo-trunk-r1989

13 years ago* widgets/modest-window.c: Add a method to get action from its private
Javier Fernandez Garcia-Boente [Tue, 29 May 2007 15:39:23 +0000 (15:39 +0000)]
* widgets/modest-window.c: Add a method to get action from its private
ui_manager instance. A new UI Dimming Manager was added too, and methods
for calling this dimming manager to check dimming rules.

* modest-mail-operation.c: Add a new private field into mail operation
to set an user defined callback to perform actions when some error
is detected during mail operation execution.
Add support to cancel tinymail operations, aborting camel operaiton
in progress. To identify operaiton to cancel, a new private field was
added to private section of mail_operation: account.

* modest-ui-dimming-manager.c: A new dimming rules design apporach.
very similar to UI Manager pattern.

pmo-trunk-r1988

13 years ago * Fixes #NB57458
Sergio Villar Senin [Tue, 29 May 2007 15:15:06 +0000 (15:15 +0000)]
* Fixes #NB57458
* Fixes a bug when applying message count limits, we're trying to retrieve more msgs than the new available ones
* Removed an invalid comment

pmo-trunk-r1987

13 years ago * Fixes NB#56966, NB#57493
Sergio Villar Senin [Tue, 29 May 2007 13:27:05 +0000 (13:27 +0000)]
* Fixes NB#56966, NB#57493
* Now the folder view remembers its last selected folder and shows it when the application is launched
* Commented some debug code
* Removed an unneeded call to update_model

pmo-trunk-r1986

13 years ago * Do not emit account_changed when the value that has changed is last_updated. This...
Sergio Villar Senin [Tue, 29 May 2007 10:38:22 +0000 (10:38 +0000)]
* Do not emit account_changed when the value that has changed is last_updated. This saves us a call to update_model in the folder view

pmo-trunk-r1985

13 years ago* Fix bug on create_account wizard.
Javier Fernandez Garcia-Boente [Tue, 29 May 2007 10:04:41 +0000 (10:04 +0000)]
* Fix bug on create_account wizard.
retrieve_type was not set when a new account
is created. I set 'Headers only' type as
default value.

pmo-trunk-r1984

13 years ago * Added some comments
Sergio Villar Senin [Tue, 29 May 2007 06:51:16 +0000 (06:51 +0000)]
* Added some comments
* Deleted unneccessary async helper structure

pmo-trunk-r1983

13 years ago2007-05-28 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 28 May 2007 16:52:15 +0000 (16:52 +0000)]
2007-05-28  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-global-settings-dialog.c:
        (current_connection):
        * src/widgets/modest-global-settings-dialog.c:
        (current_connection_default):
        Use the enum values instead of 0, 1 and -1,
        to make the code clearer.

        * src/modest-account-mgr-helpers.c:
        (modest_account_mgr_get_connection_specific_smtp): Make this code
        more robust.

        * src/modest-runtime.h:
        * src/modest-runtime.c:
        Added modest_runtime_remove_all_send_queues().
        * src/maemo/modest-main-window.c:
        (on_account_store_connecting_finished): Recreate the send queues,
        using the appropriate transport accounts for this new connection.
        Some futher adapting might be needed if the old send queues are not
        automatically stopped at this point.

        * src/modest-tny-account-store.c: (get_server_accounts):
        Create the connection-specific transport accounts, so that they can
        be found later by their ID.

        * src/modest-tny-account.h:
        * src/modest-tny-account.c:
        Added modest_tny_account_new_from_server_account_name().
        modest_tny_account_new_from_server_account(): Do not create the
        send queues here, because they will be
        recreated anyway when the connection changes for the first time.

pmo-trunk-r1982

13 years ago * Fixes NB#57398
Sergio Villar Senin [Mon, 28 May 2007 16:38:11 +0000 (16:38 +0000)]
* Fixes NB#57398

pmo-trunk-r1981

13 years ago * Sort messages by date, before retrieving the last N ones
Sergio Villar Senin [Mon, 28 May 2007 10:27:19 +0000 (10:27 +0000)]
* Sort messages by date, before retrieving the last N ones

pmo-trunk-r1980

13 years ago2007-05-28 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 28 May 2007 09:48:34 +0000 (09:48 +0000)]
2007-05-28  Murray Cumming  <murrayc@murrayc.com>

* src/modest-local-folder-info.h:
        * src/modest-local-folder-info.c:
        (modest_per_account_local_outbox_folder_info_get_maildir_path),
        (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
        tbox_folder): Take a modest account name instead of a server TnyAccount,
        so we can have per-modest-account rather than per-transport-account
        outboxes.
        We must make sure that we change or recreate the exisitng send queues
        when the connection changes for connection-specific transport accounts.

        * src/modest-tny-account-store.c:
        (create_per_account_local_outbox_folders): Create outboxed per modest
        account, not per transport account.

        * src/modest-tny-account.h:
        * src/modest-tny-account.c:
        (modest_tny_account_get_special_folder): For outboxes, get the
        parent modest account name. The account is ignored for other folders.
        (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
        modest account name rather than a server TnyAccount.

pmo-trunk-r1979

13 years ago * Only return the local account if we're asking for store accounts
Sergio Villar Senin [Mon, 28 May 2007 08:18:45 +0000 (08:18 +0000)]
* Only return the local account if we're asking for store accounts

pmo-trunk-r1978

13 years agoAdded a TODO comment
Murray Cumming [Mon, 28 May 2007 08:16:02 +0000 (08:16 +0000)]
Added a TODO comment

pmo-trunk-r1977

13 years ago2007-05-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 25 May 2007 11:07:29 +0000 (11:07 +0000)]
2007-05-25  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account.c:
        (modest_tny_account_new_from_server_account):
        Call modest_runtime_get_send_queue() immediately after creating transport
        accounts, so that they start trying to send email from the outbox as soon
        as possible at startup. This is probably what we want.

        * src/modest-mail-operation.c: (update_account_thread):
        * src/modest-runtime.c: (modest_runtime_get_send_queue):
        * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
        * src/modest-tny-send-queue.h:
        * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
        (modest_ui_actions_on_send):
        Added comments about how sending works, though it needs some more work.

pmo-trunk-r1976

13 years agoMake the debug messages slightly more attractive.
Murray Cumming [Fri, 25 May 2007 09:19:25 +0000 (09:19 +0000)]
Make the debug messages slightly more attractive.

pmo-trunk-r1975

13 years ago2007-05-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 25 May 2007 09:08:15 +0000 (09:08 +0000)]
2007-05-25  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account.c:
        (modest_tny_account_get_special_folder): Add TODO because this fails when
        the network is busy.
        (modest_tny_folder_store_get_local_size):  Fix an incorrect type check.
        * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
        Do not try to show this window when there is no active account. The UI
        specs does not tell us what to do in this case.

pmo-trunk-r1974

13 years ago * Added mcen_nc_get_multi_msg_txt confirmation dialog when replying/forwarding a...
Sergio Villar Senin [Thu, 24 May 2007 16:48:44 +0000 (16:48 +0000)]
* Added mcen_nc_get_multi_msg_txt confirmation dialog when replying/forwarding a mail

pmo-trunk-r1973