modest
13 years ago* If a user edits a message from drafts, disable the header view
Alberto Garcia [Thu, 15 Nov 2007 16:38:18 +0000 (16:38 +0000)]
* If a user edits a message from drafts, disable the header view
  while the message is being saved as it could cause problems.

pmo-trunk-r3747

13 years ago * Fixes NB#70692 with tinymail commit 2956. The device won't try to connect if it...
Sergio Villar Senin [Thu, 15 Nov 2007 15:38:24 +0000 (15:38 +0000)]
* Fixes NB#70692 with tinymail commit 2956. The device won't try to connect if it's sleeping and send&received is issued by the alarmd daemon

pmo-trunk-r3746

13 years agoFixes NB#66410
Felipe Erias Morandeira [Thu, 15 Nov 2007 14:56:27 +0000 (14:56 +0000)]
Fixes NB#66410

pmo-trunk-r3745

13 years ago* fix attachment permissions:
Dirk-Jan C. Binnema [Thu, 15 Nov 2007 14:31:48 +0000 (14:31 +0000)]
* fix attachment permissions:
- when opening directly, set permissions to 0444 (read-only)
- when saving, set permissions to 0644 (read/write)

pmo-trunk-r3744

13 years ago* Add dimming rule to Menu->Email->Send on the message editor
Alberto Garcia [Thu, 15 Nov 2007 11:44:36 +0000 (11:44 +0000)]
* Add dimming rule to Menu->Email->Send on the message editor
Fixes NB#75954

pmo-trunk-r3743

13 years ago* In the message viewer, update window title after
Alberto Garcia [Thu, 15 Nov 2007 11:13:32 +0000 (11:13 +0000)]
* In the message viewer, update window title after
  setting the message
Fixes NB#75760
Fixes NB#75937

pmo-trunk-r3742

13 years ago* src/widgets/modest-attachments-view.[ch]:
Jose Dapena Paz [Thu, 15 Nov 2007 10:55:57 +0000 (10:55 +0000)]
* src/widgets/modest-attachments-view.[ch]:
        * Now clipboard requests don't support text targets, only
          attachment indexes. Fixes NB#75889.

pmo-trunk-r3741

13 years ago * Changed the order in which the singletons and the account store are finalized...
Sergio Villar Senin [Thu, 15 Nov 2007 10:04:24 +0000 (10:04 +0000)]
* Changed the order in which the singletons and the account store are finalized in order to prevent a SIGSEV

pmo-trunk-r3740

13 years ago * Refactored two error handlers
Sergio Villar Senin [Thu, 15 Nov 2007 09:03:23 +0000 (09:03 +0000)]
* Refactored two error handlers
* Migrated open_msg to use the new connect_and_perform instead of connect_and_wait

pmo-trunk-r3739

13 years ago* src/widgets/modest-combo-box.[ch]:
Jose Dapena Paz [Thu, 15 Nov 2007 08:51:33 +0000 (08:51 +0000)]
* src/widgets/modest-combo-box.[ch]:
        * Added (modest_combo_box_set_pair_list), to be able to set
          the pair list after constructing the widget.
* src/widgets/modest-window-mgr.[ch]:
        * Added a new cache for preconstructing message view and editor
          so that we can speed up opening messages. We provide methods
          ..._get_msg_view_window and ..._get_msg_edit_window. The
          cached instances are constructed in the idle loop. These
          methods are used internally in constructors of editor and
          view.
* src/maemo/modest-msg-edit-window.c:
        * Completely new structure of the widget construction. Now it
          happens in two stages. First stage is in init_window. Here it
          constructs as much as possible the widget without any specific
          running parameter. Then the ..._new constructor connects all
          signals, configures the widget with ModestConf and sets the
          message. This way, we can precreate the widget in the window
          manager cache.
        * Modified menubar_to_menu to ask for the popup menu in xml
          instead of the old hack of reparenting children of menubar.
* src/maemo/modest-msg-view-window.c:
        * Similar refactoring to the one in editor. Now init creates all
          the widgets, and they're finally set up in construction. We
          also use the window manager cache.
        * Similar change to menubar_to_menu.
* src/maemo/ui/modest-msg-view-window-ui.xml,
  src/maemo/ui/modest-msg-edit-window-ui.xml:
        * Instead of a <menubar> I changed it to be a <popup> to get
          a GtkMenu instead of a GtkMenubar
* src/modest-widget-memory.c:
        * Cleaned a small leak.

pmo-trunk-r3738

13 years ago* some cleanups for debugging:
Dirk-Jan C. Binnema [Wed, 14 Nov 2007 22:19:31 +0000 (22:19 +0000)]
* some cleanups for debugging:
- move debugging macro's to modest-debug.h (new file)
- capitalize/rename the macros to make it clearer they are macro's
- add the new MODEST_DEBUG_BLOCK; example:
MODEST_DEBUG_BLOCK(
g_debug ("DEBUG: modest: %s: prompt (not shown) = %s\n", __FUNCTION__, prompt_not_used);
);
         - this code will *only* run when the MODEST_DEBUG envir var contains "debug-code"
 - add something like this to your .emacs to make these blocks clear:
  (font-lock-add-keywords nil
                          '(("\\<\\(FIXME\\|TODO\\|XXX+\\|BUG\\|MODEST_DEBUG_BLOCK\\)"
                             1 font-lock-warning-face prepend))))
 - some coverity fixes in modest-tny-account.c (free stuff in error cases)
 - update the manpage

pmo-trunk-r3737

13 years ago* Dim the "Move to" icon and menu entry when a message is
Alberto Garcia [Wed, 14 Nov 2007 19:12:09 +0000 (19:12 +0000)]
* Dim the "Move to" icon and menu entry when a message is
  being sent
Fixes NB#75911

pmo-trunk-r3736

13 years agoDon't show mail_ib_attachment_already_purged, as this string
Alberto Garcia [Wed, 14 Nov 2007 18:46:43 +0000 (18:46 +0000)]
Don't show mail_ib_attachment_already_purged, as this string
doesn't exist anymore

pmo-trunk-r3735

13 years ago* Dim the delete icon and menu entry from the msg-view-window if the
Alberto Garcia [Wed, 14 Nov 2007 18:24:41 +0000 (18:24 +0000)]
* Dim the delete icon and menu entry from the msg-view-window if the
  message is being sent.
* In modest_mail_operation_remove_msgs() remove only those messages
  that are not being sent
Fixes NB#75836

pmo-trunk-r3734

13 years agoFixes NB#75672
Felipe Erias Morandeira [Wed, 14 Nov 2007 17:20:39 +0000 (17:20 +0000)]
Fixes NB#75672

pmo-trunk-r3733

13 years agoChanged the chinook control file to be compatible to work with the osso 1.1 image.
Vivek Sekar [Wed, 14 Nov 2007 16:28:28 +0000 (16:28 +0000)]
Changed the chinook control file to be compatible to work with the osso 1.1 image.

pmo-trunk-r3732

13 years agoSmall change to the hack for keeping the modest.mo file.
Vivek Sekar [Wed, 14 Nov 2007 16:24:13 +0000 (16:24 +0000)]
Small change to the hack for keeping the modest.mo file.

pmo-trunk-r3731

13 years ago * Refactored the code o modest_mail_operation_get_msg and modest_mail_operation_get_...
Sergio Villar Senin [Wed, 14 Nov 2007 16:08:50 +0000 (16:08 +0000)]
* Refactored the code o modest_mail_operation_get_msg and modest_mail_operation_get_msgs_full, now both of them use the same helpers and status callbacks
* Refactored the notification of mail operations that issue progress notifications in bytes (transfers and gets)
* modest_mail_operation_get_msgs_full now it's not implemented in a separate thread
* Fixes NB#75909, retrieve contents now asks for connection if not available
* Fixes NB#75801, Cancel sending, now really cancels the sending of messages

pmo-trunk-r3730

13 years agoFix memory leak in dimming rules
Alberto Garcia [Wed, 14 Nov 2007 15:36:50 +0000 (15:36 +0000)]
Fix memory leak in dimming rules

pmo-trunk-r3729

13 years ago * Fixes NB#75878, the account wizard dialog is no longer system-modal
Sergio Villar Senin [Wed, 14 Nov 2007 10:31:10 +0000 (10:31 +0000)]
 * Fixes NB#75878, the account wizard dialog is no longer system-modal

pmo-trunk-r3728

13 years ago * Fixes NB#75822, the local account is selected if the last server account is deleted
Sergio Villar Senin [Tue, 13 Nov 2007 18:28:52 +0000 (18:28 +0000)]
* Fixes NB#75822, the local account is selected if the last server account is deleted

pmo-trunk-r3727

13 years ago * Added two missing "debian", because CURDIR is the root folder
Sergio Villar Senin [Tue, 13 Nov 2007 17:52:10 +0000 (17:52 +0000)]
* Added two missing "debian", because CURDIR is the root folder

pmo-trunk-r3726

13 years ago * Optimization, do not emit the folder selection changed signal when there is nothin...
Sergio Villar Senin [Tue, 13 Nov 2007 16:46:46 +0000 (16:46 +0000)]
* Optimization, do not emit the folder selection changed signal when there is nothing selected
* The focus is changed to the first inbox if the removed account is the visible account (there is something still not working related to this)

pmo-trunk-r3725

13 years ago* minor coverity fixes
Dirk-Jan C. Binnema [Tue, 13 Nov 2007 16:26:22 +0000 (16:26 +0000)]
* minor coverity fixes

pmo-trunk-r3724

13 years ago* minor coverity fixes
Dirk-Jan C. Binnema [Tue, 13 Nov 2007 15:58:29 +0000 (15:58 +0000)]
* minor coverity fixes

pmo-trunk-r3723

13 years ago* hack; remove the en_GB translation before building packages
Dirk-Jan C. Binnema [Tue, 13 Nov 2007 13:42:03 +0000 (13:42 +0000)]
* hack; remove the en_GB translation before building packages
  to make us not conflict ith the official translation

pmo-trunk-r3722

13 years ago* fix issue with localization file
Dirk-Jan C. Binnema [Tue, 13 Nov 2007 12:24:36 +0000 (12:24 +0000)]
* fix issue with localization file

pmo-trunk-r3721

13 years ago* unref the singletons *after* unref'ing modest-tny-account-store;
Dirk-Jan C. Binnema [Tue, 13 Nov 2007 11:51:55 +0000 (11:51 +0000)]
* unref the singletons *after* unref'ing modest-tny-account-store;
  thus, our object-ref bookkeeping is correct at the end
  (no more warnings for >1 refcounts for device, conf, acc_mgr)

pmo-trunk-r3720

13 years ago * Migrated the Dnd of folders to use the new connect_and_perform
Sergio Villar Senin [Tue, 13 Nov 2007 11:31:55 +0000 (11:31 +0000)]
* Migrated the Dnd of folders to use the new connect_and_perform
* Show an error if move folder fails even if the mail operation has no source

pmo-trunk-r3719

13 years ago* add refcount checking for TnyAccounts
Dirk-Jan C. Binnema [Tue, 13 Nov 2007 11:26:47 +0000 (11:26 +0000)]
* add refcount checking for TnyAccounts

pmo-trunk-r3718

13 years ago* coverity fixes: remove unused params, dead code
Dirk-Jan C. Binnema [Tue, 13 Nov 2007 08:44:00 +0000 (08:44 +0000)]
* coverity fixes: remove unused params, dead code

pmo-trunk-r3717

13 years ago* coverity fixes: unused params, missing checks
Dirk-Jan C. Binnema [Tue, 13 Nov 2007 08:34:26 +0000 (08:34 +0000)]
* coverity fixes: unused params, missing checks

pmo-trunk-r3716

13 years agoCheck if a GError is NULL before copying it
Alberto Garcia [Mon, 12 Nov 2007 17:03:53 +0000 (17:03 +0000)]
Check if a GError is NULL before copying it

pmo-trunk-r3715

13 years ago* small fix for doc building
Dirk-Jan C. Binnema [Mon, 12 Nov 2007 16:13:18 +0000 (16:13 +0000)]
* small fix for doc building

pmo-trunk-r3714

13 years agoFixes NB#74612
Felipe Erias Morandeira [Mon, 12 Nov 2007 16:13:16 +0000 (16:13 +0000)]
Fixes NB#74612

pmo-trunk-r3713

13 years ago * Added several gdk_threads_enter/leave stuff in the callbacks of the timeouts becau...
Sergio Villar Senin [Mon, 12 Nov 2007 15:49:49 +0000 (15:49 +0000)]
* Added several gdk_threads_enter/leave stuff in the callbacks of the timeouts because they need them since the timeouts are executed outside the main lock

pmo-trunk-r3711

13 years ago* update for docs
Dirk-Jan C. Binnema [Mon, 12 Nov 2007 15:44:29 +0000 (15:44 +0000)]
* update for docs

pmo-trunk-r3710

13 years ago * Reverting changes of commit 3674 since the original behaviour is better than the...
Sergio Villar Senin [Mon, 12 Nov 2007 15:33:52 +0000 (15:33 +0000)]
* Reverting changes of commit 3674 since the original behaviour is better than the one after this patch

pmo-trunk-r3709

13 years ago* some fixes for the doc generation
Dirk-Jan C. Binnema [Mon, 12 Nov 2007 13:50:15 +0000 (13:50 +0000)]
* some fixes for the doc generation

pmo-trunk-r3708

13 years ago * Optimization, do not refresh the INBOX after a s&r because update_account mail...
Sergio Villar Senin [Mon, 12 Nov 2007 12:58:55 +0000 (12:58 +0000)]
* Optimization, do not refresh the INBOX after a s&r because update_account mail operation does it automatically for us
* Fixes NB#75176, modest no longer shows a never ending "Refreshing..." string in the status bar and a "Updating..." info banner when send&receive. The problem was that the signal that was issued when the operation ended was not issued inside the gtk lock

pmo-trunk-r3706

13 years ago * Now the current folder is only refreshed in the s&r if the update account operatio...
Sergio Villar Senin [Mon, 12 Nov 2007 12:20:55 +0000 (12:20 +0000)]
* Now the current folder is only refreshed in the s&r if the update account operation was succesfully finished
* Fixed NB75522, application no longer hangs when cancelling s&r

pmo-trunk-r3704

13 years agoUse tny_folder_add_msg_async() to save a message to Drafts
Alberto Garcia [Mon, 12 Nov 2007 11:14:13 +0000 (11:14 +0000)]
Use tny_folder_add_msg_async() to save a message to Drafts
Fixes NB#65125

pmo-trunk-r3702

13 years ago* update the en_GB.po file with the newest translations
Dirk-Jan C. Binnema [Mon, 12 Nov 2007 09:35:08 +0000 (09:35 +0000)]
* update the en_GB.po file with the newest translations
  (this po file is only used for the garage version of
   modest, and when you compile yourself)

pmo-trunk-r3701

13 years ago* add little trick to fallback to en_GB when the
Dirk-Jan C. Binnema [Mon, 12 Nov 2007 09:22:02 +0000 (09:22 +0000)]
* add little trick to fallback to en_GB when the
  chosen language is not available. This is for
  making modest useful for those who don't have
  the closed-source l10n package

pmo-trunk-r3700

13 years agorenamed with proper notations.
Vivek Sekar [Mon, 12 Nov 2007 08:37:41 +0000 (08:37 +0000)]
renamed with proper notations.

pmo-trunk-r3696

13 years agoRenamed the control files wrt new rootstraps.
Vivek Sekar [Mon, 12 Nov 2007 08:18:55 +0000 (08:18 +0000)]
Renamed the control files wrt new rootstraps.

pmo-trunk-r3695

13 years ago* more work on chinook / open packages:
Dirk-Jan C. Binnema [Sat, 10 Nov 2007 15:51:34 +0000 (15:51 +0000)]
* more work on chinook / open packages:
- remove hard dependency on modest-providers-data (checked at runtime now)
- install the en_GB .mo file
- install maemo-provider-data.keyfile
- update the man-page for the current situation
- create control.maemo-chinook with chinook-specific options (should work on the SDK)

pmo-trunk-r3694

13 years ago* changes to use either maemo-provider-data.keyfile or modest-provider-data.keyfile
Dirk-Jan C. Binnema [Sat, 10 Nov 2007 15:27:22 +0000 (15:27 +0000)]
* changes to use either maemo-provider-data.keyfile or modest-provider-data.keyfile
  (decide at runtime); this depends on the changes done in modest-providers-data
* include maemo-provider-data in modest, no more separate maemo-providers-data package
* check for DISPLAY to give a better error message at startup
* inform user if 'showui' is not provided

pmo-trunk-r3693

13 years ago* check different places for the mcc_mapping file; this
Dirk-Jan C. Binnema [Sat, 10 Nov 2007 13:30:52 +0000 (13:30 +0000)]
* check different places for the mcc_mapping file; this
  enables modest to run on chinook

pmo-trunk-r3689

13 years ago* src/widgets/modest-details-dialog.c:
Jose Dapena Paz [Fri, 9 Nov 2007 20:42:46 +0000 (20:42 +0000)]
* src/widgets/modest-details-dialog.c:
        * (modest_details_dialog_set_folder_default): now it reads
          correctly the size and message count of a folder even if
          it's not a TnyFolderStore (as it happens with outbox).
          Fixes NB#75655.
* src/maemo/modest-main-window.c:
        * Don't leak update banner.

pmo-trunk-r3688

13 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Fri, 9 Nov 2007 13:48:30 +0000 (13:48 +0000)]
* src/widgets/modest-folder-view.c:
* Fixed a leak caused by a typo in new pixbuf allocating code.

pmo-trunk-r3687

13 years agoAdding the modest-l10-mr0 localisation packages to control file.
Vivek Sekar [Fri, 9 Nov 2007 13:07:20 +0000 (13:07 +0000)]
Adding the modest-l10-mr0 localisation packages to control file.

pmo-trunk-r3686

13 years ago* fix tiny mem leak
Dirk-Jan C. Binnema [Fri, 9 Nov 2007 12:57:10 +0000 (12:57 +0000)]
* fix tiny mem leak

pmo-trunk-r3685

13 years agoAdded bug fixes for the week 46 release.
Vivek Sekar [Fri, 9 Nov 2007 12:42:30 +0000 (12:42 +0000)]
Added bug fixes for the week 46 release.

pmo-trunk-r3683

13 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Fri, 9 Nov 2007 12:06:26 +0000 (12:06 +0000)]
* src/modest-ui-dimming-rules.c:
* Make on_cancel_sending check same dimming rule of
  on_csm_cancel_sending. Fixes NB#75510.

pmo-trunk-r3682

13 years ago * Migrated the do_send_receive to use connect_and_perform instead of connect_and_wait
Sergio Villar Senin [Fri, 9 Nov 2007 11:34:46 +0000 (11:34 +0000)]
* Migrated the do_send_receive to use connect_and_perform instead of connect_and_wait

pmo-trunk-r3681

13 years ago* src/maemo/modest-msg-edit-window-ui-dimming.h:
Jose Dapena Paz [Fri, 9 Nov 2007 10:46:07 +0000 (10:46 +0000)]
* src/maemo/modest-msg-edit-window-ui-dimming.h:
* Now insert image dimming rules is the same of set style
  (and them we dim if focus is not on editor). Fixes NB#75592.

pmo-trunk-r3680

13 years ago* modest_text_utils_get_subject_prefix_len now also deals with
Dirk-Jan C. Binnema [Fri, 9 Nov 2007 10:10:39 +0000 (10:10 +0000)]
* modest_text_utils_get_subject_prefix_len now also deals with
  multiple prefixes, such as 'Fwd:Re[34]:Fw:Foo bar"
* added parameter checks to some functions

pmo-trunk-r3679

13 years ago* src/modest-tny-account-store.[ch]:
Jose Dapena Paz [Fri, 9 Nov 2007 10:00:27 +0000 (10:00 +0000)]
* src/modest-tny-account-store.[ch]:
        * Enable loading of connection specific smtp accounts on
          startup.
        * Make public the function to get a connection specific account.
          This function does not return the server one if specific ones
          do not exist.
* src/modest-tny-account.[ch]:
        * Now standard transport accounts are
          ModestTransportAccountDecorator instead of
          TnyCamelTransportAccount.
        * (modest_tny_account_new_from_server_name): now it's only used
          for creating connection specific accounts.
        * (modest_tny_account_new_from_server_account_name): now it gets
          the proper TnyGetPassFunc and TnyForgetPassFunc.
* Added src/modest-transport-account-decorator.[ch]:
        * This inherits from TnyCamelTransportAccount.
        * The only difference is send method, which is redefined. It
          sends through connection specific transports if required, or
          through itself (calling parent implementation) if not.
* src/Makefile.am:
        * Add the ModestTransportAccountDecorator to build.
* src/modest-account-mgr-helpers.[ch]:
        * (modest_account_mgr_set_connection_specific_smtp): fix a bug
          updating the list of accounts.
* src/modest-defs.h:
        * Fix the specific_smtp gconf key to be stored in modest
          namespace.
* src/modest-ui-actions.c:
        * (..._on_send): now we always use the standard server accounts,
          no reference to open connection account. As specific
          connection smtp is handled internally in those accounts.
* src/maemo/modest-connection-specific-smtp-window.c:
        * Fix handling to update and insert properly the new accounts.
* src/maemo/modest-account-settings-dialog.c:
        * Mark as modified each time we show the connection specific
          smtp dialog

pmo-trunk-r3678

13 years agoThis fixes NB#75543.
Jose Dapena Paz [Fri, 9 Nov 2007 08:45:35 +0000 (08:45 +0000)]
This fixes NB#75543.
* src/widgets/modest-window-mgr.c:
        * Now you can register a window more than one time, and it
          handles this without problems (simply exiting the function
          silently).
* src/maemo/modest-msg-edit-window.c:
        * Now we don't unregister the window on setting a new draft, as
          we can register it again without unregistering.

pmo-trunk-r3677

13 years agoMemleak fixes
Philip Van Hoof [Thu, 8 Nov 2007 16:03:36 +0000 (16:03 +0000)]
Memleak fixes

pmo-trunk-r3676

13 years agomerged the w45 and trunk changelog.
Vivek Sekar [Thu, 8 Nov 2007 15:23:26 +0000 (15:23 +0000)]
merged the w45 and trunk changelog.

pmo-trunk-r3675

13 years ago * Fixes NB#75550, after deleting a folder the focus is not set over the INBOX
Sergio Villar Senin [Thu, 8 Nov 2007 09:54:52 +0000 (09:54 +0000)]
* Fixes NB#75550, after deleting a folder the focus is not set over the INBOX

pmo-trunk-r3674

13 years ago * Fixed a problem when looking for names of subfolders
Sergio Villar Senin [Thu, 8 Nov 2007 09:48:20 +0000 (09:48 +0000)]
* Fixed a problem when looking for names of subfolders

pmo-trunk-r3673

13 years ago* fixes NB#75530
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 16:46:11 +0000 (16:46 +0000)]
* fixes NB#75530

pmo-trunk-r3670

13 years ago* forgot this one for previous fix
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 16:42:12 +0000 (16:42 +0000)]
* forgot this one for previous fix

pmo-trunk-r3669

13 years ago* fixes NB#75548
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 16:33:12 +0000 (16:33 +0000)]
* fixes NB#75548

pmo-trunk-r3668

13 years agofixes NB#75525
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 16:13:26 +0000 (16:13 +0000)]
fixes NB#75525

pmo-trunk-r3667

13 years ago* update to the new modest_tny_folder_has_subfolder_with_name
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 16:06:40 +0000 (16:06 +0000)]
* update to the new modest_tny_folder_has_subfolder_with_name

pmo-trunk-r3666

13 years ago* let modest_tny_folder_has_subfolder_with_name do non-strict
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 16:05:31 +0000 (16:05 +0000)]
* let modest_tny_folder_has_subfolder_with_name do non-strict
  checks if needed - ie. match folder names that are only
  different in case, or where the folder name is equal to
  a display name

pmo-trunk-r3665

13 years ago* improvement of modest_utils_utf8_strcmp; and optimize
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 16:01:02 +0000 (16:01 +0000)]
* improvement of modest_utils_utf8_strcmp; and optimize
  it a bit. Only use expensive g_utf8_collate if strings
  start with non-ascii

pmo-trunk-r3664

13 years ago * Do not notify new mails when modest is already running
Sergio Villar Senin [Wed, 7 Nov 2007 15:47:06 +0000 (15:47 +0000)]
* Do not notify new mails when modest is already running

pmo-trunk-r3663

13 years agoFixes NB#74689
Felipe Erias Morandeira [Wed, 7 Nov 2007 14:49:19 +0000 (14:49 +0000)]
Fixes NB#74689

pmo-trunk-r3662

13 years ago* optimization of modest_text_utils_get_display_date,
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 09:15:52 +0000 (09:15 +0000)]
* optimization of modest_text_utils_get_display_date,
  inspired by pvanhoof's idea.

pmo-trunk-r3658

13 years ago * Added some missing parts of my original "remove-main-window-dependency" patch
Sergio Villar Senin [Tue, 6 Nov 2007 16:54:27 +0000 (16:54 +0000)]
* Added some missing parts of my original "remove-main-window-dependency" patch
* Removed an invalid public method
* Fixes a crash when refreshing the default account through D-Bus

pmo-trunk-r3657

13 years agoWhen building the Details dialog, don't assume that
Alberto Garcia [Tue, 6 Nov 2007 16:03:50 +0000 (16:03 +0000)]
When building the Details dialog, don't assume that
the folder is not remote
Fixes NB#75407

pmo-trunk-r3656

13 years agoAlternate patch to the one applied in 3653, this one's better
Alberto Garcia [Tue, 6 Nov 2007 15:23:56 +0000 (15:23 +0000)]
Alternate patch to the one applied in 3653, this one's better

pmo-trunk-r3655

13 years ago* sort the providers (almost) correctly,
Dirk-Jan C. Binnema [Tue, 6 Nov 2007 15:16:39 +0000 (15:16 +0000)]
* sort the providers (almost) correctly,
  fixes NB#75213

pmo-trunk-r3654

13 years agoPut the subject of the message on the editor window
Alberto Garcia [Tue, 6 Nov 2007 15:13:26 +0000 (15:13 +0000)]
Put the subject of the message on the editor window
Fixes NB#75081

pmo-trunk-r3653

13 years ago * Added "queue-empty" signal to the mail operation queue
Sergio Villar Senin [Tue, 6 Nov 2007 10:16:38 +0000 (10:16 +0000)]
* Added "queue-empty" signal to the mail operation queue
* Added "window-list-empty" signal to the window manager
* Moved the code that closes modest to modest-main.c
* Now modest is closed when there are no more windows and there are no more pending mail operations
* Now Modest is properly finalized when a D-Bus action is performed, event if there is no main window
* Fixes NB#74402, Modest is now closed if compose mail is invoked through D-Bus

pmo-trunk-r3652

13 years agoAllow creation of folders under the MMC root folder
Alberto Garcia [Tue, 6 Nov 2007 08:49:33 +0000 (08:49 +0000)]
Allow creation of folders under the MMC root folder
from the "Move to" dialog.
Fixes NB#75279

pmo-trunk-r3651

13 years agoMove messages from the viewer if the source folder is local
Alberto Garcia [Mon, 5 Nov 2007 17:21:15 +0000 (17:21 +0000)]
Move messages from the viewer if the source folder is local
Fixes NB#74626

pmo-trunk-r3650

13 years ago* prevent possible NULL dereference, add parameter check
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 15:21:54 +0000 (15:21 +0000)]
* prevent possible NULL dereference, add parameter check

pmo-trunk-r3649

13 years ago* some extra error handling to prevent NULL dereferences
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 14:53:12 +0000 (14:53 +0000)]
* some extra error handling to prevent NULL dereferences

pmo-trunk-r3648

13 years agofix possible NULL dereference
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 14:37:17 +0000 (14:37 +0000)]
fix possible NULL dereference

pmo-trunk-r3647

13 years ago* fix the use of an local variable outside its scope in
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 14:27:09 +0000 (14:27 +0000)]
* fix the use of an local variable outside its scope in
modest_msg_edit_window_select_background_color
  + some cleanups

are we actually using the select_background_color still?

pmo-trunk-r3646

13 years ago* check to prevent NULL-dereference (headers)
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 13:25:29 +0000 (13:25 +0000)]
* check to prevent NULL-dereference (headers)

pmo-trunk-r3645

13 years ago * Always notify the queue that the operation finished, otherwise it won't be removed
Sergio Villar Senin [Mon, 5 Nov 2007 13:01:54 +0000 (13:01 +0000)]
* Always notify the queue that the operation finished, otherwise it won't be removed

pmo-trunk-r3644

13 years ago* fix some potential NULL-dereferences
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 12:45:42 +0000 (12:45 +0000)]
* fix some potential NULL-dereferences

pmo-trunk-r3643

13 years ago* Fix the condition that tests whether to use the dummy address book
Alberto Garcia [Mon, 5 Nov 2007 12:18:30 +0000 (12:18 +0000)]
* Fix the condition that tests whether to use the dummy address book
Fixes NB#75187

pmo-trunk-r3641

13 years ago * Added some code, that allows the folder view to unref its reference to the selecte...
Sergio Villar Senin [Mon, 5 Nov 2007 12:03:32 +0000 (12:03 +0000)]
* Added some code, that allows the folder view to unref its reference to the selected folder before trying to move it using the move to dialog. The problem was that the handler of unselect_all was not happening before the mail operation

pmo-trunk-r3639

13 years ago * Fixes NB#74764, NB#74260, NB#74639
Sergio Villar Senin [Mon, 5 Nov 2007 11:04:29 +0000 (11:04 +0000)]
* Fixes NB#74764, NB#74260, NB#74639
* Removed an invalid set_transient_for that was provoking weird behaviours, like menus not shown, dialogs shown in the background, etc

pmo-trunk-r3635

13 years ago* GETTEXT_PACKAGE: osso-email=>modest
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 10:52:38 +0000 (10:52 +0000)]
* GETTEXT_PACKAGE: osso-email=>modest

pmo-trunk-r3634

13 years agoPerformance improvement for icon_cell_data
Philip Van Hoof [Mon, 5 Nov 2007 10:33:55 +0000 (10:33 +0000)]
Performance improvement for icon_cell_data

pmo-trunk-r3632

13 years ago* modest-tny-msg.c:
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 10:32:42 +0000 (10:32 +0000)]
* modest-tny-msg.c:
- fix leak when searching through multipart/ messages
  (modest_tny_msg_find_body_part_from_mime_part)
* modest-account-mgr.c:
- fix possible NULL dereference
* modest-ui-actions.c:
- remove some dead code
- fix possible NULL dereference
* modest-platform.c:
- small cleanup

pmo-trunk-r3631

13 years ago* check return values of gtk_tree_selection_get_selected and
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 09:02:23 +0000 (09:02 +0000)]
* check return values of gtk_tree_selection_get_selected and
gtk_tree_model_get_iter_first

pmo-trunk-r3630

13 years ago* check return value of alarm_event_del
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 08:46:57 +0000 (08:46 +0000)]
* check return value of alarm_event_del

pmo-trunk-r3629

13 years ago* check return value of hildon_uri_open, small cleanups
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 08:31:53 +0000 (08:31 +0000)]
* check return value of hildon_uri_open, small cleanups

pmo-trunk-r3628

13 years ago* remove obsolete files
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 08:07:43 +0000 (08:07 +0000)]
* remove obsolete files

pmo-trunk-r3627

13 years ago* save attachments with 0444 instead of 0777.
Dirk-Jan C. Binnema [Fri, 2 Nov 2007 14:55:58 +0000 (14:55 +0000)]
* save attachments with 0444 instead of 0777.
This fixes: NB#75099

pmo-trunk-r3626