modest
13 years ago* small fix, this commit mainly for testing commit message delivery
Dirk-Jan C. Binnema [Mon, 27 Aug 2007 09:21:49 +0000 (09:21 +0000)]
* small fix, this commit mainly for testing commit message delivery

pmo-trunk-r3078

13 years agofixes NB#66161 (dimming on Edit>SelectAll)
Peter Csaszar [Mon, 27 Aug 2007 08:04:19 +0000 (08:04 +0000)]
fixes NB#66161 (dimming on Edit>SelectAll)

pmo-trunk-r3076

13 years ago* cleaner version of the patch to make sure no double account-setup-wizards are
Dirk-Jan C. Binnema [Mon, 27 Aug 2007 07:00:14 +0000 (07:00 +0000)]
* cleaner version of the patch to make sure no double account-setup-wizards are
  shown
* fixes a critical G-Warning in modest-window-mgr
* apparently also fixes: NB#66304

pmo-trunk-r3075

13 years ago * Fixed a double-leak in the last commit
Sergio Villar Senin [Sun, 26 Aug 2007 09:28:28 +0000 (09:28 +0000)]
* Fixed a double-leak in the last commit

pmo-trunk-r3074

13 years agofixes NB#63872
Peter Csaszar [Fri, 24 Aug 2007 19:12:13 +0000 (19:12 +0000)]
fixes NB#63872

pmo-trunk-r3073

13 years ago * Fixed a hang when moving folders using the "Move to" dialog
Sergio Villar Senin [Fri, 24 Aug 2007 17:42:32 +0000 (17:42 +0000)]
* Fixed a hang when moving folders using the "Move to" dialog
* The "Move to" dialog show now the proper account

pmo-trunk-r3072

13 years ago * Fixed a bug added with armin's commit 3066, the key need to be initialized
Sergio Villar Senin [Fri, 24 Aug 2007 16:58:16 +0000 (16:58 +0000)]
* Fixed a bug added with armin's commit 3066, the key need to be initialized

pmo-trunk-r3071

13 years ago* Always check how many rows are selected before open it
Javier Fernandez Garcia-Boente [Fri, 24 Aug 2007 14:09:39 +0000 (14:09 +0000)]
* Always check how many rows are selected before open it
using hardware select key.
* Fixes: NB#61649

pmo-trunk-r3068

13 years ago * Renamed a function
Sergio Villar Senin [Fri, 24 Aug 2007 14:01:18 +0000 (14:01 +0000)]
* Renamed a function
* Added a new define for hildon-libs domain translation
* Fixes NB#65969

pmo-trunk-r3067

13 years ago2007-08-24 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Fri, 24 Aug 2007 13:49:45 +0000 (13:49 +0000)]
2007-08-24  Armin Burgmeier  <armin@openismus.com>

* src/modest-widget-memory.c: Always show the default account when the
application is started, as stated in the UI spec. This fixes
projects.maemo.org bug NB#66630.

pmo-trunk-r3066

13 years ago2007-08-24 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Fri, 24 Aug 2007 12:44:29 +0000 (12:44 +0000)]
2007-08-24  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-platform.c:
(modest_platform_run_rename_folder_dialog): Use logical IDs instead of
english text for strings in the rename folder dialog, fixing
projects.maemo.org bug NB#66338.

pmo-trunk-r3065

13 years ago * src/widgets/modest-main-window.h
Alberto Garcia [Fri, 24 Aug 2007 11:54:11 +0000 (11:54 +0000)]
   * src/widgets/modest-main-window.h
   * src/widgets/modest-main-window.c
   (modest_main_window_transfer_mode_enabled):
   Checks whether the main window is in transfer mode.
   (set_toolbar_mode):
   Checks dimming rules when changing toolbar mode

* src/modest-ui-dimming-rules.c
   (modest_ui_dimming_rules_on_delete_folder):
   Dim "delete folder" if the main window is in transfer mode
   (_transfer_mode_enabled):
   Added support for the main window

   Fixes NB#64604

pmo-trunk-r3064

13 years ago * Fixes NB@63545
Sergio Villar Senin [Fri, 24 Aug 2007 11:50:01 +0000 (11:50 +0000)]
* Fixes NB@63545

pmo-trunk-r3063

13 years ago* Review filter_row function in header-view to define a enumeration
Javier Fernandez Garcia-Boente [Fri, 24 Aug 2007 10:56:29 +0000 (10:56 +0000)]
* Review filter_row function in header-view to define a enumeration
for status private field. This new approach allows to define an
initial value avoiding to show false 'empty views' at first
time some folder is selected.

pmo-trunk-r3062

13 years ago* automatically register the main window
Dirk-Jan C. Binnema [Fri, 24 Aug 2007 07:29:46 +0000 (07:29 +0000)]
* automatically register the main window
* make sure only one ModestEasySetupWizardDialog instance can be alive at any time,
  letting modest-easysetup-wizard.c keep track of that
* if the we're asked for a new instance, present the old one instead

Fixes: NB#66408, and all other cases where this could happen.

pmo-trunk-r3061

13 years ago * Fixes NB#63313
Sergio Villar Senin [Thu, 23 Aug 2007 18:47:24 +0000 (18:47 +0000)]
* Fixes NB#63313

pmo-trunk-r3060

13 years ago* Check subfolders name on move-to operations.
Javier Fernandez Garcia-Boente [Thu, 23 Aug 2007 16:23:40 +0000 (16:23 +0000)]
* Check subfolders name on move-to operations.
* Fixes: NB#66403

pmo-trunk-r3059

13 years ago * Reverting the last change because the specs allow to move a folder from a remote...
Sergio Villar Senin [Thu, 23 Aug 2007 15:22:59 +0000 (15:22 +0000)]
* Reverting the last change because the specs allow to move a folder from a remote server to a local folder

pmo-trunk-r3058

13 years agofixes NB#63563
Peter Csaszar [Thu, 23 Aug 2007 14:08:08 +0000 (14:08 +0000)]
fixes NB#63563

pmo-trunk-r3057

13 years ago* this fix should fix the crash mentioned int NB#65283, but the problem
Dirk-Jan C. Binnema [Thu, 23 Aug 2007 13:34:31 +0000 (13:34 +0000)]
* this fix should fix the crash mentioned int NB#65283, but the problem
  probably remains.

pmo-trunk-r3056

13 years ago * Fixes NB#66132
Sergio Villar Senin [Thu, 23 Aug 2007 13:28:17 +0000 (13:28 +0000)]
* Fixes NB#66132

pmo-trunk-r3055

13 years agofixes NB#62700, NB#62963
Peter Csaszar [Thu, 23 Aug 2007 13:14:29 +0000 (13:14 +0000)]
fixes NB#62700, NB#62963

pmo-trunk-r3054

13 years ago* add license headers where they were missings, fixes critical bug #64095
Dirk-Jan C. Binnema [Thu, 23 Aug 2007 12:52:38 +0000 (12:52 +0000)]
* add license headers where they were missings, fixes critical bug #64095

pmo-trunk-r3053

13 years ago* update to the latest UI spec; fixes critical bug NB#65536
Dirk-Jan C. Binnema [Thu, 23 Aug 2007 12:09:46 +0000 (12:09 +0000)]
* update to the latest UI spec; fixes critical bug NB#65536

pmo-trunk-r3052

13 years ago* update logical id, fixes critical NB#66450
Dirk-Jan C. Binnema [Thu, 23 Aug 2007 11:51:24 +0000 (11:51 +0000)]
* update logical id, fixes critical NB#66450

pmo-trunk-r3051

13 years ago* get rid of a critical warning when moving a message;
Dirk-Jan C. Binnema [Thu, 23 Aug 2007 11:42:51 +0000 (11:42 +0000)]
* get rid of a critical warning when moving a message;
  this might help with NB#66471

pmo-trunk-r3050

13 years ago* get rid of warnings for a missing icon
Dirk-Jan C. Binnema [Thu, 23 Aug 2007 11:41:49 +0000 (11:41 +0000)]
* get rid of warnings for a missing icon

pmo-trunk-r3049

13 years agoWeek 34 Release, added bug fixed in the week.
Vivek Sekar [Thu, 23 Aug 2007 08:35:05 +0000 (08:35 +0000)]
Week 34 Release, added bug fixed in the week.

pmo-trunk-r3048

13 years agohildon_banner_... changed to modest_platform_...
Peter Csaszar [Thu, 23 Aug 2007 06:27:53 +0000 (06:27 +0000)]
hildon_banner_... changed to modest_platform_...

pmo-trunk-r3047

13 years ago* Keep main-view window title as selected folder, avoiding
Javier Fernandez Garcia-Boente [Wed, 22 Aug 2007 17:10:10 +0000 (17:10 +0000)]
* Keep main-view window title as selected folder, avoiding
change it when each header is selected.
* Fixes: NB#61930

pmo-trunk-r3046

13 years agofixes NB#61800
Peter Csaszar [Wed, 22 Aug 2007 14:26:34 +0000 (14:26 +0000)]
fixes NB#61800

pmo-trunk-r3045

13 years ago2007-08-22 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Wed, 22 Aug 2007 14:07:16 +0000 (14:07 +0000)]
2007-08-22 Armin Burgmeier  <armin@openismus.com>

* src/widgets/modest-account-view.c: Fix for bora by using
MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
latter seems not be used anymore.

* src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
minor optimizations.

* src/maemo/modest-main-window.c: Update menu items when the default
account changes so that the current default account is always bolded.
This fixes projects.maemo.org bug NB#66173.

pmo-trunk-r3044

13 years ago* Commneted Bullet format menu option and its
Javier Fernandez Garcia-Boente [Wed, 22 Aug 2007 12:10:41 +0000 (12:10 +0000)]
* Commneted Bullet format menu option and its
associated code in msg-edit window.
* Fixes: NB#62316

pmo-trunk-r3042

13 years ago* Remove Undo option from main-vew window Edit menu.
Javier Fernandez Garcia-Boente [Wed, 22 Aug 2007 11:29:37 +0000 (11:29 +0000)]
* Remove Undo option from main-vew window Edit menu.
* Fixes: NB#62994

pmo-trunk-r3041

13 years ago* Add dimming rules to copy and paste operations.
Javier Fernandez Garcia-Boente [Wed, 22 Aug 2007 11:08:21 +0000 (11:08 +0000)]
* Add dimming rules to copy and paste operations.
Sepecial folders and root folders/accounts can not
be cut.
* Fixes: NB#66139

pmo-trunk-r3040

13 years agoWeek 34 pre release, added bug fixed in the week.
Vivek Sekar [Wed, 22 Aug 2007 09:29:27 +0000 (09:29 +0000)]
Week 34 pre release, added bug fixed in the week.

pmo-trunk-r3039

13 years agoavoid some critical warning on d&d
Peter Csaszar [Wed, 22 Aug 2007 07:36:31 +0000 (07:36 +0000)]
avoid some critical warning on d&d

pmo-trunk-r3038

13 years ago * src/modest-ui-actions.c
Alberto Garcia [Tue, 21 Aug 2007 13:37:48 +0000 (13:37 +0000)]
   * src/modest-ui-actions.c
   (modest_ui_actions_on_send):
   Don't ask confirmation if the body is empty as it can't be empty
   anymore

* src/maemo/modest-msg-edit-window.c
   (update_send_dimming):
   (send_insensitive_press):
   Check if the message body is empty too.
   (body_changed):
   New function called everytime the body is updated.
   (init_window):
   Register callback for "changed" event in the message body.

   Fixes: NB#66115

pmo-trunk-r3037

13 years agofixes NB#66301
Peter Csaszar [Tue, 21 Aug 2007 13:12:36 +0000 (13:12 +0000)]
fixes NB#66301

pmo-trunk-r3035

13 years ago * src/modest-ui-actions.c
Alberto Garcia [Tue, 21 Aug 2007 12:00:58 +0000 (12:00 +0000)]
   * src/modest-ui-actions.c
   (modest_ui_actions_on_send):
   Don't ask confirmation if the subject is empty as it can't be empty
   anymore

* src/maemo/modest-msg-edit-window.c
   (update_send_dimming):
   New function to update the dimming of the send button and menu
   entry, based on the old recpt_field_changed()
   (recpt_field_changed):
   (subject_field_changed):
   Call update_send_dimming()
   (send_insensitive_press):
   Check whether the subject is empty or not in order to show the proper
   notification

   Fixes: NB#66112

pmo-trunk-r3031

13 years ago * src/modest-ui-actions.c
Alberto Garcia [Tue, 21 Aug 2007 10:44:54 +0000 (10:44 +0000)]
   * src/modest-ui-actions.c
   (download_uncached_messages):
   Removed reply_fwd parameter (not needed anymore).
   When retrieving an e-mail, only ask for confirmation when the
   device is offline.
   (reply_forward):
   (modest_ui_actions_on_copy):
   Removed obsolete argument in call to download_uncached_messages()

Fixes NB#66066

pmo-trunk-r3030

13 years ago * src/widgets/modest-global-settings-dialog-priv.h
Alberto Garcia [Tue, 21 Aug 2007 09:06:13 +0000 (09:06 +0000)]
   * src/widgets/modest-global-settings-dialog-priv.h
   * src/maemo/modest-maemo-global-settings-dialog.c
   Removed include_reply variable and checkbox

* src/widgets/modest-global-settings-dialog.c
   (_modest_global_settings_dialog_load_conf):
   (get_current_settings):
   (_modest_global_settings_dialog_save_conf):
   (settings_changed):
   Removed include_reply from the settings dialog.

   Fixes NB#66193

pmo-trunk-r3029

13 years agoAdded bug fixes to changelog, week 34 aug 21st.
Vivek Sekar [Tue, 21 Aug 2007 07:59:07 +0000 (07:59 +0000)]
Added bug fixes to changelog, week 34 aug 21st.

pmo-trunk-r3028

13 years agoRemoved backup file
Alberto Garcia [Tue, 21 Aug 2007 07:47:35 +0000 (07:47 +0000)]
Removed backup file

pmo-trunk-r3027

13 years ago * src/maemo/modest-progress-bar-widget.c
Alberto Garcia [Mon, 20 Aug 2007 14:40:34 +0000 (14:40 +0000)]
   * src/maemo/modest-progress-bar-widget.c
   (modest_progress_bar_cancel_current_operation):
   (modest_progress_bar_cancel_all_operations):
   Don't show the "Session cancelled" info banner as it's deprecated.
   Fixes NB#66135

pmo-trunk-r3018

13 years ago * src/modest-tny-account-store.c
Alberto Garcia [Fri, 17 Aug 2007 17:09:05 +0000 (17:09 +0000)]
* src/modest-tny-account-store.c
    (get_smtp_specific_transport_account_for_open_connection):
    Don't try to use a connection-specific SMTP server if the option
    is disabled for that account

pmo-trunk-r3014

13 years ago2007-08-17 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 17 Aug 2007 16:15:39 +0000 (16:15 +0000)]
2007-08-17  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c:
        (on_dbus_method_get_folders): Avoid trying to get the account name
        when there are no accounts, to avoid critical g_warnings, fixing
        projects.maemo.org bug NB#65574.

pmo-trunk-r3013

13 years ago2007-08-17 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 17 Aug 2007 15:20:59 +0000 (15:20 +0000)]
2007-08-17  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
Check for NULLs to prevent a crash when opening an email that is
an attachment in another email, fixing projects.maemo.org bug
NB#66012.

pmo-trunk-r3012

13 years ago2007-08-17 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 17 Aug 2007 14:26:36 +0000 (14:26 +0000)]
2007-08-17  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_view_window_move_to):
Enable the Move To toolbar button for search results, fixing the
last part of projects.maemo.org bug NB#63807.

pmo-trunk-r3011

13 years agoThere was a bug 60714 which was partially fixed by me in revision
Peter Csaszar [Fri, 17 Aug 2007 14:14:19 +0000 (14:14 +0000)]
There was a bug 60714 which was partially fixed by me in revision
2959. However the real problem was that once there was an update (by
folder selection or msg retrieval) in header-view for a folder whose
msg was shown in msg-view, the model referenced by msg-view was not
the same with the model in header-view. Because of this the dimming
for prev/next buttons could had not be synchronous with header-view.

There is an observer now. The observed is the meader-view and the
observer is the msg-view-window. The target is to detect if the
model of header-view is replaced. Another essential part is the
callback for row-insertions on the model. This can be found in
modest-msg-view-window.c file.

pmo-trunk-r3010

13 years ago * src/modest-defs.h:
Alberto Garcia [Fri, 17 Aug 2007 12:51:13 +0000 (12:51 +0000)]
* src/modest-defs.h:
    New gconf key: "use_specific_smtp"

* src/modest-account-mgr-helpers.h
    * src/modest-account-mgr-helpers.c
    (modest_account_mgr_get_has_connection_specific_smtp): removed
    (modest_account_mgr_get_use_connection_specific_smtp):
    (modest_account_mgr_set_use_connection_specific_smtp): New
    functions to set and get the state of the use_specific_smtp
    gconf key

    * src/maemo/easysetup/modest-easysetup-wizard.c
    (create_account):
    Save the actual state of the "Use connection-specific SMTP
    servers" checkbox in gconf

    * src/maemo/modest-account-settings-dialog.c
    (modest_account_settings_dialog_set_account_name):
    (save_configuration):
    Save and restore the actual state of the "Use
    connection-specific SMTP server" checkbox in gconf

    Fixes NB#65993

pmo-trunk-r3009

13 years agoAdded fixes for week 33 post release, 17th august.
Dirk-Jan C. Binnema [Fri, 17 Aug 2007 12:09:00 +0000 (12:09 +0000)]
Added fixes for week 33 post release, 17th august.

pmo-trunk-r3008

13 years ago2007-08-17 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 17 Aug 2007 10:24:08 +0000 (10:24 +0000)]
2007-08-17  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c:
(check_and_offer_account_creation): Use gdk_thread_enter/leave(),
because this is called from idle handlers, to fix hangs afte the
wizard closes.
(find_message_by_url):  Added a TODO comment about a crash that
happens when tinymail was built with DBC checks.

pmo-trunk-r3007

13 years ago2007-08-16 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 16 Aug 2007 16:23:10 +0000 (16:23 +0000)]
2007-08-16  Murray Cumming  <murrayc@murrayc.com>

* src/modest-search.c: (modest_search_folder):
* src/modest-search.h: Rename ModestSearch::before to start_date
and after to end_date, using the same names as the libogs struct
fields.
* src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
The start_date and end_date were swapped in the check. This
fixes date range searches, fixing projects.maemo.org bug NB#63407.

pmo-trunk-r3006

13 years ago2007-08-16 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 16 Aug 2007 14:55:08 +0000 (14:55 +0000)]
2007-08-16  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-msg-view-window.h:
* src/gnome/modest-msg-view-window.c:
* src/maemo/modest-msg-view-window.c:
Added modest_msg_view_window_construct().
(modest_msg_view_window_new_with_header_model),
Added modest_msg_view_window_new_for_search_result),
Renamed modest_msg_view_window_new() to
modest_msg_view_window_new_for_attachment(),
and modest_msg_view_window_is_search_result(),
so we can explicitly know that the window is for an
attachment or a search result or a message from the list.

(modest_msg_view_window_view_attachment):
* src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
Use modest_msg_view_window_new_for_search_result().

* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_delete_msg): Dim the delete button
for search results, fixing projects.maemo.org bug NB#63811.

pmo-trunk-r3005

13 years ago2007-08-16 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Thu, 16 Aug 2007 14:26:12 +0000 (14:26 +0000)]
2007-08-16  Armin Burgmeier  <armin@openismus.com>

* src/modest-ui-actions.c: Show a banner instead of a dialog when
renaming a folder fails, to stay consistent with what happens when
creating a folder fails.

* src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
slightly country loading from the mmc_mappings file, fixed a memory
leak.

pmo-trunk-r3004

13 years ago2007-08-16 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 16 Aug 2007 11:45:58 +0000 (11:45 +0000)]
2007-08-16  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (volume_path_is_mounted):
Check the GnomeVFSVolume activation path instead of the device path,
so that the memory card is really really shown in the UI.

pmo-trunk-r3001

13 years ago2007-08-16 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 16 Aug 2007 10:20:56 +0000 (10:20 +0000)]
2007-08-16  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
(get_entered_account_title), (on_before_next), (entry_is_empty),
(create_account):
* src/maemo/modest-account-settings-dialog.c:
(get_entered_account_title), (on_button_signature), (check_data),
(save_configuration), (entry_is_empty):
Strip the account title of whitespace at the start and end before
using it or checking it. This means that an all-whitespace title
is not allowed, fixing projects.maemo.org bug NB#64977.

pmo-trunk-r3000

13 years agoAdded known issues and fixed bugs, week 33 pre release - 16th Aug.
Dirk-Jan C. Binnema [Thu, 16 Aug 2007 08:16:31 +0000 (08:16 +0000)]
Added known issues and fixed bugs, week 33 pre release - 16th Aug.

pmo-trunk-r2999

13 years ago2007-08-15 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 15 Aug 2007 16:15:13 +0000 (16:15 +0000)]
2007-08-15  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-actions.h:
* src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
to modest_run_account_setup_wizard() and made it public.
* src/dbus_api/modest-dbus-callbacks.c:
(check_and_offer_account_creation), (on_idle_mail_to),
(on_idle_compose_mail), (on_idle_open_default_inbox):
Offer account creation if necessary, fixing projects.maemo.org
bug NB#63713.

pmo-trunk-r2998

13 years ago2007-08-15 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 15 Aug 2007 15:06:41 +0000 (15:06 +0000)]
2007-08-15  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-recpt-editor.c:
(modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
to fix projects.maemo.org bug NB#63789.

pmo-trunk-r2997

13 years ago2007-08-15 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 15 Aug 2007 13:55:01 +0000 (13:55 +0000)]
2007-08-15  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: Added volume_path_is_mounted().
(modest_tny_account_store_new): Properly detect the memory card at
startup, and add an account for it.

pmo-trunk-r2996

13 years agoAdded known issues and fixed bugs, week 33 pre release - 15th Aug.
Dirk-Jan C. Binnema [Wed, 15 Aug 2007 12:52:04 +0000 (12:52 +0000)]
Added known issues and fixed bugs, week 33 pre release - 15th Aug.

pmo-trunk-r2995

13 years ago* Close sort dialog after select sorting keys.
Javier Fernandez Garcia-Boente [Tue, 14 Aug 2007 17:49:07 +0000 (17:49 +0000)]
* Close sort dialog after select sorting keys.
* Fixes NB#64682

pmo-trunk-r2994

13 years ago2007-08-14 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 14 Aug 2007 13:50:27 +0000 (13:50 +0000)]
2007-08-14  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (modest_tny_account_store_new):
Commented out the MMC code again because it mistakenly detects
the card even when it isn't inserted.

pmo-trunk-r2992

13 years agoAdded known issues and fixed bugs, week 33 pre release - 14th Aug.
Dirk-Jan C. Binnema [Tue, 14 Aug 2007 13:12:56 +0000 (13:12 +0000)]
Added known issues and fixed bugs, week 33 pre release - 14th Aug.

pmo-trunk-r2990

13 years ago2007-08-14 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 14 Aug 2007 12:23:17 +0000 (12:23 +0000)]
2007-08-14  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (modest_tny_account_store_new):
Renabled the call to add_mmc_account() because I do not believe
it could be the cause of the mentioned hang (in scratchbox, where
there is no memory card), and because I have tested that it works
on the device.

pmo-trunk-r2989

13 years ago2007-08-14 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 14 Aug 2007 10:59:57 +0000 (10:59 +0000)]
2007-08-14  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (modest_tny_account_store_new):
Comment out part of the last commit because it apparently causes
a hang.

pmo-trunk-r2983

13 years agoBugfix for 63283
Philip Van Hoof [Tue, 14 Aug 2007 10:59:28 +0000 (10:59 +0000)]
Bugfix for 63283

pmo-trunk-r2982

13 years ago* Fixed a bug related with filter_row function and
Javier Fernandez Garcia-Boente [Tue, 14 Aug 2007 10:22:33 +0000 (10:22 +0000)]
* Fixed a bug related with filter_row function and
recent new boolean field 'empty' added to header-view
priv structure.

pmo-trunk-r2981

13 years ago* Emission of progress-changed signal is not alowed, because hang on
Javier Fernandez Garcia-Boente [Tue, 14 Aug 2007 09:57:49 +0000 (09:57 +0000)]
* Emission of progress-changed signal is not alowed, because hang on
folder_copy_asunc was fixed.
* Set the correct path for mcc_mapping file (Fixes NB#61072)
* Fixed some bugs on dimming rules, to allow copy/cut/paste
of folders.

pmo-trunk-r2980

13 years ago2007-08-14 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 14 Aug 2007 09:53:22 +0000 (09:53 +0000)]
2007-08-14  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: Added the add_mmc_account()
function to save some copy/pasting.
(modest_tny_account_store_new): If the memory card is mounted,
create an account for it at the start, instead of waiting for the
user to unmount it and mount it.

pmo-trunk-r2979

13 years ago* Fixed some Gtk warnings at start.
Javier Fernandez Garcia-Boente [Mon, 13 Aug 2007 18:14:01 +0000 (18:14 +0000)]
* Fixed some Gtk warnings at start.

pmo-trunk-r2974

13 years ago* Fixed some bugs on dimming rules about copy/cur/paste folders.
Javier Fernandez Garcia-Boente [Mon, 13 Aug 2007 17:18:59 +0000 (17:18 +0000)]
* Fixed some bugs on dimming rules about copy/cur/paste folders.
* Check if folder is empty on POP accounts refreshing, due to
POP refresh operation does not emit notifications.
* Use filter_row function, called to hide marked as deleted
rows on header-view, to determine if folder is empty.

pmo-trunk-r2973

13 years agoJavier: if I remove this one, tny_folder_copy_async does not hang anymore
Philip Van Hoof [Mon, 13 Aug 2007 14:48:43 +0000 (14:48 +0000)]
Javier: if I remove this one, tny_folder_copy_async does not hang anymore
g_signal_emit (G_OBJECT (self), signals[PROGRESS_CHANGED_SIGNAL], 0, state, NULL);
https://projects.maemo.org/bugzilla/show_bug.cgi?id=63060

pmo-trunk-r2972

13 years ago2007-08-13 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 13 Aug 2007 14:36:41 +0000 (14:36 +0000)]
2007-08-13  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-account-view.c: (on_account_changed):
Do not try to use the human-readable TnyAccount name instead of the
ID of the modest account to get the transport account. And unref
the transport account. This prevents a g_warning(), and a possible
ref leak.

pmo-trunk-r2971

13 years agoremoved a g_debug
Murray Cumming [Mon, 13 Aug 2007 14:14:09 +0000 (14:14 +0000)]
removed a g_debug

pmo-trunk-r2970

13 years ago2007-08-13 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 13 Aug 2007 14:11:31 +0000 (14:11 +0000)]
2007-08-13  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-platform.c:
(modest_platform_set_update_interval): Handle the new
alarmd error to warn when alarmd is not running, as is the case in
scratchbox for me now because
Module /usr/lib/alarmd/libretu.so initialization failed

pmo-trunk-r2969

13 years ago2007-08-13 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 13 Aug 2007 13:46:55 +0000 (13:46 +0000)]
2007-08-13  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-header-view-render.c:
(_modest_header_view_compact_header_cell_data):
NULL some strings after freeing them, trying to deal with
the double deletion found in projects.maemo.org bug 64183,
probably having no effect.

pmo-trunk-r2968

13 years ago2007-08-13 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 13 Aug 2007 13:23:18 +0000 (13:23 +0000)]
2007-08-13  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-settings-dialog.c:
(create_page_incoming), (create_page_outgoing): Use a define
for the min and max port numbers.

(check_hildon_number_editor_and_warn_value_not_in_range),
(check_data): Do an extra check for an invalid port number, as needed
in projects.maemo.org bug #64275, when the number is cleared, but this
does not work due to bugs.maemo.org bug #1806.

pmo-trunk-r2967

13 years agoAdded known issues and fixed bugs, week 33 pre release - 13th Aug.
Dirk-Jan C. Binnema [Mon, 13 Aug 2007 12:29:29 +0000 (12:29 +0000)]
Added known issues and fixed bugs, week 33 pre release - 13th Aug.

pmo-trunk-r2966

13 years ago2007-08-13 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 13 Aug 2007 12:17:16 +0000 (12:17 +0000)]
2007-08-13  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
Comment out the debug warning about the unexpected D-Bus methods.
They are just annoying now.
* src/maemo/modest-platform.c:
(modest_platform_set_update_interval): Correct the D-Bus path, instead
of using a file path, though it did not seem to break things before.
It might be needed now:
Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
modest is not already running. This is the behaviour of the old client, and
Mox says it is what we should do for modest.
This closes projects.maemo.org bug NB#64327.

pmo-trunk-r2965

13 years agoAdded known issues and fixed bugs, week 33 pre release - 13th Aug.
Dirk-Jan C. Binnema [Mon, 13 Aug 2007 12:17:09 +0000 (12:17 +0000)]
Added known issues and fixed bugs, week 33 pre release - 13th Aug.

pmo-trunk-r2964

13 years ago* modest-header-view.c: Remove some commented and unsed code.
Javier Fernandez Garcia-Boente [Mon, 13 Aug 2007 11:35:43 +0000 (11:35 +0000)]
* modest-header-view.c: Remove some commented and unsed code.
* modest-ui-actios.c: implemented some changes on
new_messages_arrieved callback, executed afte send&receive has
been completed, to check if folder is empty and new message
have arrived; this imlpies a change in main-view window style.
* Fixes: NB#57458

pmo-trunk-r2963

13 years agoChanged the changelog to resolve some bugs issues, week 32 post release - 10th Aug.
Dirk-Jan C. Binnema [Fri, 10 Aug 2007 13:33:53 +0000 (13:33 +0000)]
Changed the changelog to resolve some bugs issues, week 32 post release - 10th Aug.

pmo-trunk-r2962

13 years agoChanged the changelog to resolve some bugs issues, week 32 post release - 10th Aug.
Dirk-Jan C. Binnema [Fri, 10 Aug 2007 13:18:52 +0000 (13:18 +0000)]
Changed the changelog to resolve some bugs issues, week 32 post release - 10th Aug.

pmo-trunk-r2961

13 years agoAdded a few fixed bugs and release notes to the changelog, week 32 post release ...
Dirk-Jan C. Binnema [Fri, 10 Aug 2007 12:13:22 +0000 (12:13 +0000)]
Added a few fixed bugs and release notes to the changelog, week 32 post release - 10th Aug.

pmo-trunk-r2960

13 years agomodest-ui-actions.c: some alignment in the code
Peter Csaszar [Thu, 9 Aug 2007 14:11:15 +0000 (14:11 +0000)]
modest-ui-actions.c: some alignment in the code
modest-ui-dimming-rules.c: some cleanup of unnecessary codes
modest-msg-view-window.c: partially fixes bug 60714, and have further
modifications. The concept is using signals of tree_model for any
change. If there is a change, dimming rules should be applied on
msg-view-window.

Not: There remains some bugs, which I do not know if registered on
bugzilla or not, but are near the same problems like 60714.
The tree_view (header_view) in main window might have new tree_model
due to some user actions and so 60714 bug become current again.

pmo-trunk-r2959

13 years ago* Review fucntion 'has_retrieved_msgs' implementation
Javier Fernandez Garcia-Boente [Thu, 9 Aug 2007 11:31:33 +0000 (11:31 +0000)]
* Review fucntion 'has_retrieved_msgs' implementation
in order to use CACHED flag to determine wether one message
has been downloaded or not.
* Fixes: NB#62450

pmo-trunk-r2958

13 years ago* Add a confirmation dialog to Paste operation.
Javier Fernandez Garcia-Boente [Wed, 8 Aug 2007 15:28:27 +0000 (15:28 +0000)]
* Add a confirmation dialog to Paste operation.
* Fixes: NB#63124

pmo-trunk-r2955

13 years ago* Fixed some warnings
Javier Fernandez Garcia-Boente [Wed, 8 Aug 2007 15:07:27 +0000 (15:07 +0000)]
* Fixed some warnings

pmo-trunk-r2954

13 years ago* Fixed some warnings.
Javier Fernandez Garcia-Boente [Wed, 8 Aug 2007 15:04:19 +0000 (15:04 +0000)]
* Fixed some warnings.

pmo-trunk-r2953

13 years ago* Fixed some bug in new dimming rules approach.
Javier Fernandez Garcia-Boente [Wed, 8 Aug 2007 14:30:35 +0000 (14:30 +0000)]
* Fixed some bug in new dimming rules approach.

pmo-trunk-r2950

13 years ago* Set focus on folder-view at startup to show correctly
Javier Fernandez Garcia-Boente [Wed, 8 Aug 2007 14:11:07 +0000 (14:11 +0000)]
* Set focus on folder-view at startup to show correctly
the main window title.
* Fixes: NB#61815

pmo-trunk-r2949

13 years agoAdded a few fixed bugs and release notes to the changelog, week 32 pre release -...
Dirk-Jan C. Binnema [Wed, 8 Aug 2007 12:11:35 +0000 (12:11 +0000)]
Added a few fixed bugs and release notes to the changelog, week 32 pre release - 8th Aug.

pmo-trunk-r2948

13 years ago* Implement optimizations on DimmingRules management.
Javier Fernandez Garcia-Boente [Wed, 8 Aug 2007 09:37:32 +0000 (09:37 +0000)]
* Implement optimizations on DimmingRules management.
* Copy/Cut/Paste dimming rules of Editor are not working fine;
it does not take into account if something was selected or not.
These changes on src/maemo/modest-msg-edit-window.c try to
solve these problems, with no success at this moment.
* Fixes: NB#64553

pmo-trunk-r2947

13 years agoAdded fixed bugs and release notes to the changelog, week 32 pre release - 8th Aug.
Dirk-Jan C. Binnema [Wed, 8 Aug 2007 07:29:48 +0000 (07:29 +0000)]
Added fixed bugs and release notes to the changelog, week 32 pre release - 8th Aug.

pmo-trunk-r2946

13 years ago* Check folder type in folder comparison.
Javier Fernandez Garcia-Boente [Tue, 7 Aug 2007 19:24:47 +0000 (19:24 +0000)]
* Check folder type in folder comparison.
* Fixes: NB#63055

pmo-trunk-r2945

13 years ago* Call send-queue-flush when account is edited and changed,
Javier Fernandez Garcia-Boente [Tue, 7 Aug 2007 18:05:24 +0000 (18:05 +0000)]
* Call send-queue-flush when account is edited and changed,
and also at startup.

pmo-trunk-r2944

13 years agoFixing API changes
Philip Van Hoof [Tue, 7 Aug 2007 10:13:53 +0000 (10:13 +0000)]
Fixing API changes

pmo-trunk-r2941