modest
13 years ago* more work on chinook / open packages:
Dirk-Jan C. Binnema [Sat, 10 Nov 2007 15:51:34 +0000 (15:51 +0000)]
* more work on chinook / open packages:
- remove hard dependency on modest-providers-data (checked at runtime now)
- install the en_GB .mo file
- install maemo-provider-data.keyfile
- update the man-page for the current situation
- create control.maemo-chinook with chinook-specific options (should work on the SDK)

pmo-trunk-r3694

13 years ago* changes to use either maemo-provider-data.keyfile or modest-provider-data.keyfile
Dirk-Jan C. Binnema [Sat, 10 Nov 2007 15:27:22 +0000 (15:27 +0000)]
* changes to use either maemo-provider-data.keyfile or modest-provider-data.keyfile
  (decide at runtime); this depends on the changes done in modest-providers-data
* include maemo-provider-data in modest, no more separate maemo-providers-data package
* check for DISPLAY to give a better error message at startup
* inform user if 'showui' is not provided

pmo-trunk-r3693

13 years ago* check different places for the mcc_mapping file; this
Dirk-Jan C. Binnema [Sat, 10 Nov 2007 13:30:52 +0000 (13:30 +0000)]
* check different places for the mcc_mapping file; this
  enables modest to run on chinook

pmo-trunk-r3689

13 years ago* src/widgets/modest-details-dialog.c:
Jose Dapena Paz [Fri, 9 Nov 2007 20:42:46 +0000 (20:42 +0000)]
* src/widgets/modest-details-dialog.c:
        * (modest_details_dialog_set_folder_default): now it reads
          correctly the size and message count of a folder even if
          it's not a TnyFolderStore (as it happens with outbox).
          Fixes NB#75655.
* src/maemo/modest-main-window.c:
        * Don't leak update banner.

pmo-trunk-r3688

13 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Fri, 9 Nov 2007 13:48:30 +0000 (13:48 +0000)]
* src/widgets/modest-folder-view.c:
* Fixed a leak caused by a typo in new pixbuf allocating code.

pmo-trunk-r3687

13 years agoAdding the modest-l10-mr0 localisation packages to control file.
Vivek Sekar [Fri, 9 Nov 2007 13:07:20 +0000 (13:07 +0000)]
Adding the modest-l10-mr0 localisation packages to control file.

pmo-trunk-r3686

13 years ago* fix tiny mem leak
Dirk-Jan C. Binnema [Fri, 9 Nov 2007 12:57:10 +0000 (12:57 +0000)]
* fix tiny mem leak

pmo-trunk-r3685

13 years agoAdded bug fixes for the week 46 release.
Vivek Sekar [Fri, 9 Nov 2007 12:42:30 +0000 (12:42 +0000)]
Added bug fixes for the week 46 release.

pmo-trunk-r3683

13 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Fri, 9 Nov 2007 12:06:26 +0000 (12:06 +0000)]
* src/modest-ui-dimming-rules.c:
* Make on_cancel_sending check same dimming rule of
  on_csm_cancel_sending. Fixes NB#75510.

pmo-trunk-r3682

13 years ago * Migrated the do_send_receive to use connect_and_perform instead of connect_and_wait
Sergio Villar Senin [Fri, 9 Nov 2007 11:34:46 +0000 (11:34 +0000)]
* Migrated the do_send_receive to use connect_and_perform instead of connect_and_wait

pmo-trunk-r3681

13 years ago* src/maemo/modest-msg-edit-window-ui-dimming.h:
Jose Dapena Paz [Fri, 9 Nov 2007 10:46:07 +0000 (10:46 +0000)]
* src/maemo/modest-msg-edit-window-ui-dimming.h:
* Now insert image dimming rules is the same of set style
  (and them we dim if focus is not on editor). Fixes NB#75592.

pmo-trunk-r3680

13 years ago* modest_text_utils_get_subject_prefix_len now also deals with
Dirk-Jan C. Binnema [Fri, 9 Nov 2007 10:10:39 +0000 (10:10 +0000)]
* modest_text_utils_get_subject_prefix_len now also deals with
  multiple prefixes, such as 'Fwd:Re[34]:Fw:Foo bar"
* added parameter checks to some functions

pmo-trunk-r3679

13 years ago* src/modest-tny-account-store.[ch]:
Jose Dapena Paz [Fri, 9 Nov 2007 10:00:27 +0000 (10:00 +0000)]
* src/modest-tny-account-store.[ch]:
        * Enable loading of connection specific smtp accounts on
          startup.
        * Make public the function to get a connection specific account.
          This function does not return the server one if specific ones
          do not exist.
* src/modest-tny-account.[ch]:
        * Now standard transport accounts are
          ModestTransportAccountDecorator instead of
          TnyCamelTransportAccount.
        * (modest_tny_account_new_from_server_name): now it's only used
          for creating connection specific accounts.
        * (modest_tny_account_new_from_server_account_name): now it gets
          the proper TnyGetPassFunc and TnyForgetPassFunc.
* Added src/modest-transport-account-decorator.[ch]:
        * This inherits from TnyCamelTransportAccount.
        * The only difference is send method, which is redefined. It
          sends through connection specific transports if required, or
          through itself (calling parent implementation) if not.
* src/Makefile.am:
        * Add the ModestTransportAccountDecorator to build.
* src/modest-account-mgr-helpers.[ch]:
        * (modest_account_mgr_set_connection_specific_smtp): fix a bug
          updating the list of accounts.
* src/modest-defs.h:
        * Fix the specific_smtp gconf key to be stored in modest
          namespace.
* src/modest-ui-actions.c:
        * (..._on_send): now we always use the standard server accounts,
          no reference to open connection account. As specific
          connection smtp is handled internally in those accounts.
* src/maemo/modest-connection-specific-smtp-window.c:
        * Fix handling to update and insert properly the new accounts.
* src/maemo/modest-account-settings-dialog.c:
        * Mark as modified each time we show the connection specific
          smtp dialog

pmo-trunk-r3678

13 years agoThis fixes NB#75543.
Jose Dapena Paz [Fri, 9 Nov 2007 08:45:35 +0000 (08:45 +0000)]
This fixes NB#75543.
* src/widgets/modest-window-mgr.c:
        * Now you can register a window more than one time, and it
          handles this without problems (simply exiting the function
          silently).
* src/maemo/modest-msg-edit-window.c:
        * Now we don't unregister the window on setting a new draft, as
          we can register it again without unregistering.

pmo-trunk-r3677

13 years agoMemleak fixes
Philip Van Hoof [Thu, 8 Nov 2007 16:03:36 +0000 (16:03 +0000)]
Memleak fixes

pmo-trunk-r3676

13 years agomerged the w45 and trunk changelog.
Vivek Sekar [Thu, 8 Nov 2007 15:23:26 +0000 (15:23 +0000)]
merged the w45 and trunk changelog.

pmo-trunk-r3675

13 years ago * Fixes NB#75550, after deleting a folder the focus is not set over the INBOX
Sergio Villar Senin [Thu, 8 Nov 2007 09:54:52 +0000 (09:54 +0000)]
* Fixes NB#75550, after deleting a folder the focus is not set over the INBOX

pmo-trunk-r3674

13 years ago * Fixed a problem when looking for names of subfolders
Sergio Villar Senin [Thu, 8 Nov 2007 09:48:20 +0000 (09:48 +0000)]
* Fixed a problem when looking for names of subfolders

pmo-trunk-r3673

13 years ago* fixes NB#75530
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 16:46:11 +0000 (16:46 +0000)]
* fixes NB#75530

pmo-trunk-r3670

13 years ago* forgot this one for previous fix
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 16:42:12 +0000 (16:42 +0000)]
* forgot this one for previous fix

pmo-trunk-r3669

13 years ago* fixes NB#75548
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 16:33:12 +0000 (16:33 +0000)]
* fixes NB#75548

pmo-trunk-r3668

13 years agofixes NB#75525
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 16:13:26 +0000 (16:13 +0000)]
fixes NB#75525

pmo-trunk-r3667

13 years ago* update to the new modest_tny_folder_has_subfolder_with_name
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 16:06:40 +0000 (16:06 +0000)]
* update to the new modest_tny_folder_has_subfolder_with_name

pmo-trunk-r3666

13 years ago* let modest_tny_folder_has_subfolder_with_name do non-strict
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 16:05:31 +0000 (16:05 +0000)]
* let modest_tny_folder_has_subfolder_with_name do non-strict
  checks if needed - ie. match folder names that are only
  different in case, or where the folder name is equal to
  a display name

pmo-trunk-r3665

13 years ago* improvement of modest_utils_utf8_strcmp; and optimize
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 16:01:02 +0000 (16:01 +0000)]
* improvement of modest_utils_utf8_strcmp; and optimize
  it a bit. Only use expensive g_utf8_collate if strings
  start with non-ascii

pmo-trunk-r3664

13 years ago * Do not notify new mails when modest is already running
Sergio Villar Senin [Wed, 7 Nov 2007 15:47:06 +0000 (15:47 +0000)]
* Do not notify new mails when modest is already running

pmo-trunk-r3663

13 years agoFixes NB#74689
Felipe Erias Morandeira [Wed, 7 Nov 2007 14:49:19 +0000 (14:49 +0000)]
Fixes NB#74689

pmo-trunk-r3662

13 years ago* optimization of modest_text_utils_get_display_date,
Dirk-Jan C. Binnema [Wed, 7 Nov 2007 09:15:52 +0000 (09:15 +0000)]
* optimization of modest_text_utils_get_display_date,
  inspired by pvanhoof's idea.

pmo-trunk-r3658

13 years ago * Added some missing parts of my original "remove-main-window-dependency" patch
Sergio Villar Senin [Tue, 6 Nov 2007 16:54:27 +0000 (16:54 +0000)]
* Added some missing parts of my original "remove-main-window-dependency" patch
* Removed an invalid public method
* Fixes a crash when refreshing the default account through D-Bus

pmo-trunk-r3657

13 years agoWhen building the Details dialog, don't assume that
Alberto Garcia [Tue, 6 Nov 2007 16:03:50 +0000 (16:03 +0000)]
When building the Details dialog, don't assume that
the folder is not remote
Fixes NB#75407

pmo-trunk-r3656

13 years agoAlternate patch to the one applied in 3653, this one's better
Alberto Garcia [Tue, 6 Nov 2007 15:23:56 +0000 (15:23 +0000)]
Alternate patch to the one applied in 3653, this one's better

pmo-trunk-r3655

13 years ago* sort the providers (almost) correctly,
Dirk-Jan C. Binnema [Tue, 6 Nov 2007 15:16:39 +0000 (15:16 +0000)]
* sort the providers (almost) correctly,
  fixes NB#75213

pmo-trunk-r3654

13 years agoPut the subject of the message on the editor window
Alberto Garcia [Tue, 6 Nov 2007 15:13:26 +0000 (15:13 +0000)]
Put the subject of the message on the editor window
Fixes NB#75081

pmo-trunk-r3653

13 years ago * Added "queue-empty" signal to the mail operation queue
Sergio Villar Senin [Tue, 6 Nov 2007 10:16:38 +0000 (10:16 +0000)]
* Added "queue-empty" signal to the mail operation queue
* Added "window-list-empty" signal to the window manager
* Moved the code that closes modest to modest-main.c
* Now modest is closed when there are no more windows and there are no more pending mail operations
* Now Modest is properly finalized when a D-Bus action is performed, event if there is no main window
* Fixes NB#74402, Modest is now closed if compose mail is invoked through D-Bus

pmo-trunk-r3652

13 years agoAllow creation of folders under the MMC root folder
Alberto Garcia [Tue, 6 Nov 2007 08:49:33 +0000 (08:49 +0000)]
Allow creation of folders under the MMC root folder
from the "Move to" dialog.
Fixes NB#75279

pmo-trunk-r3651

13 years agoMove messages from the viewer if the source folder is local
Alberto Garcia [Mon, 5 Nov 2007 17:21:15 +0000 (17:21 +0000)]
Move messages from the viewer if the source folder is local
Fixes NB#74626

pmo-trunk-r3650

13 years ago* prevent possible NULL dereference, add parameter check
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 15:21:54 +0000 (15:21 +0000)]
* prevent possible NULL dereference, add parameter check

pmo-trunk-r3649

13 years ago* some extra error handling to prevent NULL dereferences
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 14:53:12 +0000 (14:53 +0000)]
* some extra error handling to prevent NULL dereferences

pmo-trunk-r3648

13 years agofix possible NULL dereference
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 14:37:17 +0000 (14:37 +0000)]
fix possible NULL dereference

pmo-trunk-r3647

13 years ago* fix the use of an local variable outside its scope in
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 14:27:09 +0000 (14:27 +0000)]
* fix the use of an local variable outside its scope in
modest_msg_edit_window_select_background_color
  + some cleanups

are we actually using the select_background_color still?

pmo-trunk-r3646

13 years ago* check to prevent NULL-dereference (headers)
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 13:25:29 +0000 (13:25 +0000)]
* check to prevent NULL-dereference (headers)

pmo-trunk-r3645

13 years ago * Always notify the queue that the operation finished, otherwise it won't be removed
Sergio Villar Senin [Mon, 5 Nov 2007 13:01:54 +0000 (13:01 +0000)]
* Always notify the queue that the operation finished, otherwise it won't be removed

pmo-trunk-r3644

13 years ago* fix some potential NULL-dereferences
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 12:45:42 +0000 (12:45 +0000)]
* fix some potential NULL-dereferences

pmo-trunk-r3643

13 years ago* Fix the condition that tests whether to use the dummy address book
Alberto Garcia [Mon, 5 Nov 2007 12:18:30 +0000 (12:18 +0000)]
* Fix the condition that tests whether to use the dummy address book
Fixes NB#75187

pmo-trunk-r3641

13 years ago * Added some code, that allows the folder view to unref its reference to the selecte...
Sergio Villar Senin [Mon, 5 Nov 2007 12:03:32 +0000 (12:03 +0000)]
* Added some code, that allows the folder view to unref its reference to the selected folder before trying to move it using the move to dialog. The problem was that the handler of unselect_all was not happening before the mail operation

pmo-trunk-r3639

13 years ago * Fixes NB#74764, NB#74260, NB#74639
Sergio Villar Senin [Mon, 5 Nov 2007 11:04:29 +0000 (11:04 +0000)]
* Fixes NB#74764, NB#74260, NB#74639
* Removed an invalid set_transient_for that was provoking weird behaviours, like menus not shown, dialogs shown in the background, etc

pmo-trunk-r3635

13 years ago* GETTEXT_PACKAGE: osso-email=>modest
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 10:52:38 +0000 (10:52 +0000)]
* GETTEXT_PACKAGE: osso-email=>modest

pmo-trunk-r3634

13 years agoPerformance improvement for icon_cell_data
Philip Van Hoof [Mon, 5 Nov 2007 10:33:55 +0000 (10:33 +0000)]
Performance improvement for icon_cell_data

pmo-trunk-r3632

13 years ago* modest-tny-msg.c:
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 10:32:42 +0000 (10:32 +0000)]
* modest-tny-msg.c:
- fix leak when searching through multipart/ messages
  (modest_tny_msg_find_body_part_from_mime_part)
* modest-account-mgr.c:
- fix possible NULL dereference
* modest-ui-actions.c:
- remove some dead code
- fix possible NULL dereference
* modest-platform.c:
- small cleanup

pmo-trunk-r3631

13 years ago* check return values of gtk_tree_selection_get_selected and
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 09:02:23 +0000 (09:02 +0000)]
* check return values of gtk_tree_selection_get_selected and
gtk_tree_model_get_iter_first

pmo-trunk-r3630

13 years ago* check return value of alarm_event_del
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 08:46:57 +0000 (08:46 +0000)]
* check return value of alarm_event_del

pmo-trunk-r3629

13 years ago* check return value of hildon_uri_open, small cleanups
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 08:31:53 +0000 (08:31 +0000)]
* check return value of hildon_uri_open, small cleanups

pmo-trunk-r3628

13 years ago* remove obsolete files
Dirk-Jan C. Binnema [Mon, 5 Nov 2007 08:07:43 +0000 (08:07 +0000)]
* remove obsolete files

pmo-trunk-r3627

13 years ago* save attachments with 0444 instead of 0777.
Dirk-Jan C. Binnema [Fri, 2 Nov 2007 14:55:58 +0000 (14:55 +0000)]
* save attachments with 0444 instead of 0777.
This fixes: NB#75099

pmo-trunk-r3626

13 years agoreverted back to using microb-engine-nss
Vivek Sekar [Fri, 2 Nov 2007 14:53:17 +0000 (14:53 +0000)]
reverted back to using microb-engine-nss

pmo-trunk-r3625

13 years ago* add help context id's for all dialogs
Dirk-Jan C. Binnema [Fri, 2 Nov 2007 14:22:17 +0000 (14:22 +0000)]
* add help context id's for all dialogs
* turned content-specific-smtp-window into a GtkDialog
  (instead of a GtkWindow), otherwise the help won't work.

This fixes NB#74670 (but we're still missing the actual help contents)

pmo-trunk-r3624

13 years ago* maintain the osso_context_t ptr in modest_maemo_utils,
Dirk-Jan C. Binnema [Fri, 2 Nov 2007 14:19:32 +0000 (14:19 +0000)]
* maintain the osso_context_t ptr in modest_maemo_utils,
  a global + accessors
* do a proper osso_deinitialize before exiting modest
* some small fixes / cleanups

pmo-trunk-r3623

13 years agoremoved the maemo-launcher option.
Vivek Sekar [Fri, 2 Nov 2007 13:14:18 +0000 (13:14 +0000)]
removed the maemo-launcher option.

pmo-trunk-r3622

13 years agoadded bug fixes for week 45 pre release.
Vivek Sekar [Fri, 2 Nov 2007 12:21:27 +0000 (12:21 +0000)]
added bug fixes for week 45 pre release.

pmo-trunk-r3618

13 years ago* some further cleanups of the help system, added:
Dirk-Jan C. Binnema [Fri, 2 Nov 2007 11:28:26 +0000 (11:28 +0000)]
* some further cleanups of the help system, added:
modest_window_mgr_register_help_id, and
modest_window_mgr_get_help_id
  which will give you the right help_id for the
  current window; windows register the help id in their
  _init. For the main window, we check what the
  selected folder is, and use modest_tny_folder_get_help_id
  to get the help_id from there.

pmo-trunk-r3617

13 years agoremoved microb-engine-nss dependecy from configure.ac and debian/control file.
Vivek Sekar [Fri, 2 Nov 2007 11:13:54 +0000 (11:13 +0000)]
removed microb-engine-nss dependecy from configure.ac and debian/control file.

pmo-trunk-r3616

13 years ago* cleanup: added modest_tny_folder_get_help_id, and let modest-ui-actions use that
Dirk-Jan C. Binnema [Fri, 2 Nov 2007 10:35:55 +0000 (10:35 +0000)]
* cleanup: added modest_tny_folder_get_help_id, and let modest-ui-actions use that

pmo-trunk-r3615

13 years ago* make dragging of headers to folders work again
Dirk-Jan C. Binnema [Thu, 1 Nov 2007 17:32:37 +0000 (17:32 +0000)]
* make dragging of headers to folders work again

pmo-trunk-r3614

13 years ago* make libalarm an optional (no longer required) dependency for maemo
Dirk-Jan C. Binnema [Thu, 1 Nov 2007 16:52:16 +0000 (16:52 +0000)]
* make libalarm an optional (no longer required) dependency for maemo

pmo-trunk-r3613

13 years ago* warn when some weird folder rename error occurs that pvanhoof encountered
Dirk-Jan C. Binnema [Thu, 1 Nov 2007 15:59:32 +0000 (15:59 +0000)]
* warn when some weird folder rename error occurs that pvanhoof encountered

pmo-trunk-r3612

13 years ago* make modest_text_utils_get_display_date return a ptr to
Dirk-Jan C. Binnema [Thu, 1 Nov 2007 15:58:51 +0000 (15:58 +0000)]
* make modest_text_utils_get_display_date return a ptr to
  as static gchar[]; the saves us a g_strdup / free for
  each of the display_date (esp. in renderer this counts)

Note: it's *not* re-entrent/thread safe anymore, but that
  should not matter, as we're only using it in the UI

pmo-trunk-r3611

13 years agoremoved microb-engine-dev and added libnss3-dev
Vivek Sekar [Thu, 1 Nov 2007 08:18:15 +0000 (08:18 +0000)]
removed microb-engine-dev and added libnss3-dev

pmo-trunk-r3610

13 years agoAdded bug fixes, and microb-engine to control file.
Vivek Sekar [Thu, 1 Nov 2007 08:10:40 +0000 (08:10 +0000)]
Added bug fixes, and microb-engine to control file.

pmo-trunk-r3609

13 years agotny_header_{set,unset}_flags() renamed to tny_header_{set,unset}_flag()
Alberto Garcia [Wed, 31 Oct 2007 15:02:10 +0000 (15:02 +0000)]
tny_header_{set,unset}_flags() renamed to tny_header_{set,unset}_flag()

pmo-trunk-r3608

13 years agoFix for bug NB#74675. Now we limit the retrieval size for texts shown,
Jose Dapena Paz [Wed, 31 Oct 2007 13:11:38 +0000 (13:11 +0000)]
Fix for bug NB#74675. Now we limit the retrieval size for texts shown,
and make the load much more efficient.
* src/modest-text-utils.[ch]:
        * Now convert_to_html_body method accepts two new parameters,
          one to enable disable linkify and other for processing char
          buffers with a size limit.
        * Now we provide the methods modest_text_utils_linkify_begin
          and modest_text_utils_linkify_end, to cache the regex patterns
          in processing of a big set of strings.
* src/widgets/modest-gtkhtml-mime-part-view.c:
        * Now we use the new ModestStreamTextToHtml decorator for
          gtkhtml stream instead of a big hack we did before to
          convert the text to html and send it to the gtkhtml widget.
        * Now we set the maximum size of text with hyperlinkify (64KB)
          and a maximum size of the text document to show (640KB).
* src/modest-stream-text-to-html.[ch], src/Makefile.am:
        * New stream implementation that proxies a write stream. With
          this all text written to this stream is converted to html and
          sent to the decorated stream.

pmo-trunk-r3607

13 years ago* this is dirk's version of sergio's patch to only create
Dirk-Jan C. Binnema [Wed, 31 Oct 2007 10:50:09 +0000 (10:50 +0000)]
* this is dirk's version of sergio's patch to only create
  main-windows when we really need to.

it adds a boolean 'create' parameter to modest_window_mgr_get_main_window,
  and only if this parameter is TRUE will this function create a main_window
  if it was not yet existing.

  also, patch makes warning dialogs not show up if there is no main window,
  including password, cert verification dialogs. thus, the user will not be
  annoyed unexpectedly anymore.

pmo-trunk-r3606

13 years ago* don't accept certificate when user clicked cancel
Dirk-Jan C. Binnema [Tue, 30 Oct 2007 13:30:05 +0000 (13:30 +0000)]
* don't accept certificate when user clicked cancel

pmo-trunk-r3604

13 years agospelling: s/conformation/confirmation
Dirk-Jan C. Binnema [Tue, 30 Oct 2007 12:13:51 +0000 (12:13 +0000)]
spelling: s/conformation/confirmation

pmo-trunk-r3602

13 years ago* fix for the crash in NB#74605
Dirk-Jan C. Binnema [Tue, 30 Oct 2007 11:49:38 +0000 (11:49 +0000)]
* fix for the crash in NB#74605
* code cleanup

pmo-trunk-r3601

13 years ago* src/modest-account-mgr-helpers.c:
Jose Dapena Paz [Tue, 30 Oct 2007 11:10:49 +0000 (11:10 +0000)]
* src/modest-account-mgr-helpers.c:
        * On removing a smtp connection account, we shouldn't spoil
          the list of accounts.
* src/maemo/modest-connection-specific-smtp-window.c:
        * Now we can remove accounts simply removing the hostname of the
          server (fixes NB#65559).
* src/maemo/modest-connection-specific-smtp-edit-window.c:
        * Now we accept empty hostnames as valid, so that we can remove
          accounts.

pmo-trunk-r3600

13 years ago* do some parameter checks for is_busy / set_busy,
Dirk-Jan C. Binnema [Tue, 30 Oct 2007 10:56:04 +0000 (10:56 +0000)]
* do some parameter checks for is_busy / set_busy,
  and code style cleanup

pmo-trunk-r3599

13 years ago* check for invalid folders in many places
Dirk-Jan C. Binnema [Mon, 29 Oct 2007 14:06:11 +0000 (14:06 +0000)]
* check for invalid folders in many places
* add TNY_FOLDER_TYPE_INVALID (todo: move this to tinymail)
* add the check when moving messages to folders (this fixes
  a crasher)

Fixes: NB#74469

pmo-trunk-r3597

13 years agofixes NB#66958
Felipe Erias Morandeira [Mon, 29 Oct 2007 12:04:28 +0000 (12:04 +0000)]
fixes NB#66958

pmo-trunk-r3596

13 years agoPriority flags changes.
Jose Dapena Paz [Mon, 29 Oct 2007 10:27:50 +0000 (10:27 +0000)]
Priority flags changes.
* src/widgets/modest-gtkhtml-msg-view.c:
        * Remove all internal priority mask to delefate on headers view.
* src/widgets/modest-header-view.c:
        * Replace old priority comparison code to be proper for the
          priority flags after last changes in tinymail.
* src/widgets/modest-header-view-render.c:
        * If we try to get the pixbuf for 0, we get NULL pixbuf.
        * Update the priority flags management showing priority pixbufs.
* src/widgets/modest-mail-header-view.c:
        * Use new priority flags in tinymail.
* src/widgets/modest-mozembed-msg-view.c:
        * Use mail header view priorities instead of storing a local
          copy of priorities.
* src/maemo/modest-msg-edit-window.c:
        * Use new priority flags api from tinymail.
* src/maemo/modest-platform.c:
        * Use new priority flags api from tinymail.
* src/modest-tny-send-queue.c:
        * Use the new priority/suspended flags api. Now we don't unset
          the flags if message send failed.

Mozembed changes:
* src/widgets/modest-mozembed-msg-view.c:
        * Use scroll area (pending on changes in gtkmozembed to be
          scrollable).
* src/widgets/modest-mozembed-mime-part-view.c:
        * Implementation of ModestISearchView interface for incremental
          search.
* src/maemo/modest-msg-view-window.c:
        * More integration with mozembed (adaptation for future
          scrollable gtkmozembed widget).

pmo-trunk-r3595

13 years agoremove garbage in function comment
Dirk-Jan C. Binnema [Fri, 26 Oct 2007 15:19:22 +0000 (15:19 +0000)]
remove garbage in function comment

pmo-trunk-r3594

13 years ago* add support for special port numbers; this fixes the
Dirk-Jan C. Binnema [Fri, 26 Oct 2007 15:12:09 +0000 (15:12 +0000)]
* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts

pmo-trunk-r3593

13 years ago* forgot these (see r3591)
Dirk-Jan C. Binnema [Fri, 26 Oct 2007 14:11:25 +0000 (14:11 +0000)]
* forgot these (see r3591)

pmo-trunk-r3592

13 years ago* make osso-addressbook (libosso-abook-dev) optional; if it's
Dirk-Jan C. Binnema [Fri, 26 Oct 2007 14:06:34 +0000 (14:06 +0000)]
* make osso-addressbook (libosso-abook-dev) optional; if it's
  not there, we'll use modest-address-book-dummy.c

pmo-trunk-r3591

13 years agoweek 44 bugs added.
Vivek Sekar [Fri, 26 Oct 2007 12:42:35 +0000 (12:42 +0000)]
week 44 bugs added.

pmo-trunk-r3587

13 years ago * Some improvements for the connect_and_wait, there is no need to disconnect the...
Sergio Villar Senin [Fri, 26 Oct 2007 08:41:13 +0000 (08:41 +0000)]
* Some improvements for the connect_and_wait, there is no need to disconnect the signal when we've called tny_camel_account_set_online

pmo-trunk-r3582

13 years ago * Fixed a very stupid mistake by myself in the connect_and_wait function. It could...
Sergio Villar Senin [Thu, 25 Oct 2007 17:50:27 +0000 (17:50 +0000)]
* Fixed a very stupid mistake by myself in the connect_and_wait function. It could cause a SIGSEV and was not taking into account the case where the device was online and the account was not and was not reconnecting as well.

pmo-trunk-r3581

13 years agoFixed typo
Alberto Garcia [Thu, 25 Oct 2007 17:49:12 +0000 (17:49 +0000)]
Fixed typo

pmo-trunk-r3580

13 years ago* modest-tny-account-store:
Alberto Garcia [Thu, 25 Oct 2007 17:22:47 +0000 (17:22 +0000)]
* modest-tny-account-store:
  (modest_tny_account_store_get_transport_account_from_outbox_header)
  New function to obtain the transport account from a message in the
  outbox

* modest-ui-actions:
  (open_msg_cb)
  Open Failed messages in the outbox with the editor and not with the
  viewer.

Fixes NB#74147

pmo-trunk-r3579

13 years ago* only set auto-update alarms when there are accounts;
Dirk-Jan C. Binnema [Thu, 25 Oct 2007 15:42:12 +0000 (15:42 +0000)]
* only set auto-update alarms when there are accounts;
  also check with account addition/deletion.

Fixes: NB#64945

pmo-trunk-r3578

13 years ago * Removed a public method
Sergio Villar Senin [Thu, 25 Oct 2007 11:42:51 +0000 (11:42 +0000)]
* Removed a public method

pmo-trunk-r3577

13 years ago * Reimplementation of the connect_and_wait function
Sergio Villar Senin [Thu, 25 Oct 2007 10:22:14 +0000 (10:22 +0000)]
* Reimplementation of the connect_and_wait function
* Fixes NB#66769

pmo-trunk-r3576

13 years ago * Fixes NB#74180, the New folder, Rename and Delete options of the folder CSM are...
Sergio Villar Senin [Wed, 24 Oct 2007 17:03:06 +0000 (17:03 +0000)]
* Fixes NB#74180, the New folder, Rename and Delete options of the folder CSM are dimmed when in transfer mode

pmo-trunk-r3574

13 years agoUse the constant name (TNY_HEADER_FLAG_NORMAL_PRIORITY) and
Alberto Garcia [Wed, 24 Oct 2007 15:21:27 +0000 (15:21 +0000)]
Use the constant name (TNY_HEADER_FLAG_NORMAL_PRIORITY) and
not its value (0) to check the priority of a message.

pmo-trunk-r3573

13 years ago * Fixes NB#74182, the paste option is removed from the csm
Sergio Villar Senin [Wed, 24 Oct 2007 15:03:52 +0000 (15:03 +0000)]
* Fixes NB#74182, the paste option is removed from the csm

pmo-trunk-r3572

13 years ago* fix for NB#74144 (modest thinks foo/drafts is Drafts)
Dirk-Jan C. Binnema [Wed, 24 Oct 2007 12:01:50 +0000 (12:01 +0000)]
* fix for NB#74144 (modest thinks foo/drafts is Drafts)
  - made the check more precise, ie. compare the full path, not just the name
  - cleaned up the code and its callers

pmo-trunk-r3569

13 years agofixes NB#74061
Felipe Erias Morandeira [Wed, 24 Oct 2007 09:06:25 +0000 (09:06 +0000)]
fixes NB#74061

pmo-trunk-r3567

13 years ago * Fixed a typo
Sergio Villar Senin [Wed, 24 Oct 2007 08:03:02 +0000 (08:03 +0000)]
* Fixed a typo

pmo-trunk-r3566

13 years ago * Restored some code deleted by error
Sergio Villar Senin [Wed, 24 Oct 2007 07:58:36 +0000 (07:58 +0000)]
* Restored some code deleted by error

pmo-trunk-r3565

13 years ago* remove package dependency of libmodest-dbus-client on modest
Dirk-Jan C. Binnema [Wed, 24 Oct 2007 07:50:20 +0000 (07:50 +0000)]
* remove package dependency of libmodest-dbus-client on modest

pmo-trunk-r3564

13 years agopatch for NB#73896
Felipe Erias Morandeira [Tue, 23 Oct 2007 16:37:58 +0000 (16:37 +0000)]
patch for NB#73896

pmo-trunk-r3563