modest
13 years ago* don't try to open file:-uri's, and don't add them to CSMs
Dirk-Jan C. Binnema [Fri, 30 Nov 2007 14:44:53 +0000 (14:44 +0000)]
* don't try to open file:-uri's, and don't add them to CSMs

pmo-trunk-r3843

13 years agoAdded the week 49 bug fixes.
Vivek Sekar [Fri, 30 Nov 2007 09:36:52 +0000 (09:36 +0000)]
Added the week 49 bug fixes.

pmo-trunk-r3842

13 years ago* add some parameter checks to public functions
Dirk-Jan C. Binnema [Fri, 30 Nov 2007 07:49:41 +0000 (07:49 +0000)]
* add some parameter checks to public functions

pmo-trunk-r3841

13 years ago * Needed initialization
Sergio Villar Senin [Thu, 29 Nov 2007 09:40:40 +0000 (09:40 +0000)]
* Needed initialization

pmo-trunk-r3839

13 years ago * Add connection error handling to message opening
Sergio Villar Senin [Thu, 29 Nov 2007 08:43:58 +0000 (08:43 +0000)]
* Add connection error handling to message opening

pmo-trunk-r3838

13 years agoAfter a server has been modified in the in the connection-specific
Alberto Garcia [Wed, 28 Nov 2007 12:28:41 +0000 (12:28 +0000)]
After a server has been modified in the in the connection-specific
SMTP window, update the treeview using the new values rather than the
old values taken from the modest-account-mgr
Fixes NB#77361

pmo-trunk-r3837

13 years agoFixes NB#77388
Felipe Erias Morandeira [Wed, 28 Nov 2007 12:09:30 +0000 (12:09 +0000)]
Fixes NB#77388
In modest_mail_operation_send_new_mail(..), sets the initial status of the mail operation to MODEST_MAIL_OPERATION_STATUS_IN_PROGRESS.

pmo-trunk-r3836

13 years agoDon't set the username if it's empty in update_tny_account()
Alberto Garcia [Wed, 28 Nov 2007 11:39:48 +0000 (11:39 +0000)]
Don't set the username if it's empty in update_tny_account()
or it will cause an assertion in tinymail to fail

pmo-trunk-r3835

13 years agoChange resize-mode of ModestAttachmentsView so all attachments
Alberto Garcia [Wed, 28 Nov 2007 11:12:34 +0000 (11:12 +0000)]
Change resize-mode of ModestAttachmentsView so all attachments
are visible
Fixes NB#77277

pmo-trunk-r3834

13 years agoFixes NB#77038
Felipe Erias Morandeira [Wed, 28 Nov 2007 10:34:49 +0000 (10:34 +0000)]
Fixes NB#77038
* modest/src/modest-mail-operation.c: the "last_updated" field off an account is updated also when there aren't new headers to get
* modest/src/modest-account-mgr.[ch]: added a new signal, "account_updated"
* modest/src/widgets/modest-account-view.c: connected to the former signal to refresh the "last updated" column
* modest/src/maemo/modest-main-window.c: connected to the former signal to refresh the details widget

pmo-trunk-r3833

13 years agoUpdate all accounts after they have been modified,
Alberto Garcia [Wed, 28 Nov 2007 10:28:10 +0000 (10:28 +0000)]
Update all accounts after they have been modified,
no matter their status
Fixes NB#73627

pmo-trunk-r3832

13 years agoFix regular expression used to check domain names.
Alberto Garcia [Wed, 28 Nov 2007 10:01:54 +0000 (10:01 +0000)]
Fix regular expression used to check domain names.
This one allows things like '10.0.1.1'

pmo-trunk-r3831

13 years ago* add some parameter checks to public functions
Dirk-Jan C. Binnema [Tue, 27 Nov 2007 12:36:30 +0000 (12:36 +0000)]
* add some parameter checks to public functions

pmo-trunk-r3830

13 years ago * Removed some comments
Sergio Villar Senin [Tue, 27 Nov 2007 12:24:53 +0000 (12:24 +0000)]
* Removed some comments
* Removed a function that was only emitting a signal

pmo-trunk-r3829

13 years ago * Fixes NB#77103, the message is not sent if the user does not select any recipient...
Sergio Villar Senin [Tue, 27 Nov 2007 12:17:27 +0000 (12:17 +0000)]
* Fixes NB#77103, the message is not sent if the user does not select any recipient clicking cancel in the dialog

pmo-trunk-r3828

13 years ago* remove some g_asserts, add warnings instead
Dirk-Jan C. Binnema [Tue, 27 Nov 2007 11:21:58 +0000 (11:21 +0000)]
* remove some g_asserts, add warnings instead

pmo-trunk-r3827

13 years ago * The password request dialog was appearing bellow the accounts dialog and it's...
Sergio Villar Senin [Tue, 27 Nov 2007 10:22:25 +0000 (10:22 +0000)]
* The password request dialog was appearing bellow the accounts dialog and it's modal, so the user was unable to click on it or on the accounts dialog, so it seemed that modest is hanged

pmo-trunk-r3826

13 years agoFix platform detection in configure.ac
Alberto Garcia [Tue, 27 Nov 2007 10:00:08 +0000 (10:00 +0000)]
Fix platform detection in configure.ac

pmo-trunk-r3825

13 years ago* don't drink and code
Dirk-Jan C. Binnema [Mon, 26 Nov 2007 22:39:09 +0000 (22:39 +0000)]
* don't drink and code

pmo-trunk-r3824

13 years ago* unbreak dape's gnome-desktop port
Dirk-Jan C. Binnema [Mon, 26 Nov 2007 22:37:50 +0000 (22:37 +0000)]
* unbreak dape's gnome-desktop port

pmo-trunk-r3823

13 years ago* fix some of the fallout of the last commit
Dirk-Jan C. Binnema [Mon, 26 Nov 2007 21:02:51 +0000 (21:02 +0000)]
* fix some of the fallout of the last commit

pmo-trunk-r3822

13 years ago* modest-outside-scratchbox patch 3:
Dirk-Jan C. Binnema [Mon, 26 Nov 2007 19:23:08 +0000 (19:23 +0000)]
* modest-outside-scratchbox patch 3:
- make conic optional, even when building the maemo frontend

pmo-trunk-r3821

13 years ago* modest-outside-scratchbox patch 2:
Dirk-Jan C. Binnema [Mon, 26 Nov 2007 19:18:57 +0000 (19:18 +0000)]
* modest-outside-scratchbox patch 2:
- fix compiler warnings for 64 bit / gcc 4.2

pmo-trunk-r3820

13 years ago* modest-outside-sbox patch 1:
Dirk-Jan C. Binnema [Mon, 26 Nov 2007 19:15:15 +0000 (19:15 +0000)]
* modest-outside-sbox patch 1:
- remove dependency on scratchbox/hildon/maemo specific gtk+

pmo-trunk-r3819

13 years agoWhen creating each page in the account setup wizard don't check
Alberto Garcia [Mon, 26 Nov 2007 18:13:07 +0000 (18:13 +0000)]
When creating each page in the account setup wizard don't check
whether the widgets that they contain already exist: they can't.
Also, set them to NULL after destroying each page.

pmo-trunk-r3818

13 years ago * Fixes NB#76991, the send/receive refreshes the current folder as well
Sergio Villar Senin [Mon, 26 Nov 2007 16:30:48 +0000 (16:30 +0000)]
* Fixes NB#76991, the send/receive refreshes the current folder as well

pmo-trunk-r3817

13 years agoFixes NB#63571
Felipe Erias Morandeira [Mon, 26 Nov 2007 16:09:46 +0000 (16:09 +0000)]
Fixes NB#63571
Changed the name modest_platform_connect_and_perform_if_network_folderstore(..), that now is modest_platform_connect_if_remote_and_perform(..).
Removed modest_platform_connect_and_perform_if_network_account, because the above function performs the same task.
Changed modest_ui_actions_create_folder to use the asynchronous call modest_platform_connect_if_remote_and_perform(..).
Added a call to gtk_tree_model_filter_refilter(tree_model) by the end of on_row_inserted_maybe_select_folder(..) in modest-folder-view.c, so the folder with the new name is shown.

pmo-trunk-r3815

13 years ago* src/widgets/modest-gtkhtml-msg-view.c:
Jose Dapena Paz [Mon, 26 Nov 2007 14:07:39 +0000 (14:07 +0000)]
* src/widgets/modest-gtkhtml-msg-view.c:
* Now we set the html scroll upper to 0 on setting new messages,
  to force a proper recalculation of html buffer size (fixes
  NB#64099).

pmo-trunk-r3814

13 years ago* src/modest-init.c:
Jose Dapena Paz [Mon, 26 Nov 2007 13:00:43 +0000 (13:00 +0000)]
* src/modest-init.c:
* Remove platform maemo ifdefs in i18n trick. This way
  i18n fallbacks to en_GB in case no strings are available,
  also for gnome.

pmo-trunk-r3813

13 years ago * Fixes NB#76897, modest is shown in the language specified by the device language...
Sergio Villar Senin [Mon, 26 Nov 2007 12:45:01 +0000 (12:45 +0000)]
* Fixes NB#76897, modest is shown in the language specified by the device language and not by regional settings

pmo-trunk-r3812

13 years agoAdded new bug fixes for week 48 release.
Vivek Sekar [Mon, 26 Nov 2007 12:18:04 +0000 (12:18 +0000)]
Added new bug fixes for week 48 release.

pmo-trunk-r3811

13 years agoThese changes are for reenabling build of gnome port.
Jose Dapena Paz [Mon, 26 Nov 2007 11:31:11 +0000 (11:31 +0000)]
These changes are for reenabling build of gnome port.
* src/modest-tny-account.[ch]:
        * New method modest_tny_folder_store_is_remote, coming from a
          specific maemo modest_platform method. As this does not have
          any platform specific code, we moved it to a common place.
        * Use hildon calls only in maemo.
* src/modest-platform.h:
        * Removed method modest_platform_is_network_folderstore,
          replaced by modest_tny_folder_store_is_remote.
* src/modest-tny-platform-factory.c:
        * As the private area does not have fields, commented it and
          its initialisation.
* src/gnome/modest-main-window-ui.h:
        * Replaced modest_ui_actions_on_delete with
          modest_ui_actions_on_delete_message.
* src/gnome/modest-account-view-window.c:
        * Update calls to new api of modest_account_mgr_remove_account.
* src/gnome/modest-store-widget.[ch]:
        * Replaced ModestProtoList with ModestPairList.
        * Fixed a typo in return types.
* src/gnome/modest-address-book.c:
        * Updated api.
* src/gnome/modest-transport-widget.c:
        * Add auth_protos to the private struct.
* src/gnome/modest-msg-edit-window.c:
        * Use ModestProtoList instead of ModestPairList
        * Remove references to a msg id.
        * Update api call to check_names method.
        * Added implementation of ..._get_child_widget method.
        * Added stub implementations of reset_modified,
          toggle_find_toolbar, add_part, redo, offer_attach_file,
          attach_file_one, set_draft, is_modified, get_clipboard_text,
          can_redo, can_undo and get_message_uid.
* src/gnome/modest-platform.c:
        * Remove calls to non_implemented method (it does not exists
          now).
        * Now show_help method returns void.
        * Added new methods connect_and_perform, and
          connect_and_perform_if_network_account. These methods act
          as it's always connected.
        * Added stub implementation of remove_new_mail_notification,
          check_and_wait_for_account_is_online,
          run_certificate_confirmation_dialog, run_rename_folder_dialog,
          and show_addressboook.
* src/gnome/modest-main-window.c:
        * Use new TnyMsgView interface based access to msg view.
        * Prevent a crash as now we initialize the dimming manager.
        * Added stub implementation for notify_send_receive_initied,
          send_receive_completed, transfer_mode_enabled,
          and on_msg_view_window_msg_changed.
* src/gnome/modest-gnome-global-settings-dialog.c:
        * Update internal global settings dialog methods.
* src/gnome/modest-icon-names.h:
        * Add pending icons.
* src/gnome/modest-gnome-info-bar.c:
        * Update progress_change handler api.
* src/gnome/modest-msg-view-window.c:
        * Use modest_ui_actions_on_delete_message instead of
          ..._on_delete.
        * Use the TnyMsgView api for accessing the message.
        * Implementation of modest_msg_view_window_get_header,
          modest_msg_view_window_get_folder_type.
        * Stub implementation of last_message_selected,
          first_message_selected, transfer_mode_enabled,
          on_transfer_mode, get_attachments, is_search_result and
          has_headers_model.
* src/gnome/modest-account-assistant.c:
        * Update api calls.
* src/widgets/modest-recpt-editor.c:
        * Protect specific hildon calls with ifdefs.
* src/widgets/modest-window.c:
        * Add a pending include.
* src/modest-init.c:
        * Add a missing gnome vfs include.
        * Update the stock icons in the list.
* src/modest-ui-actions.c:
        * Remove common dependencies to connection specific smtp window
          dialog.
        * Remove all calls to hildon_banner.
        * Use the new modest_tny_folder_store_is_remote method.
* src/maemo/modest-platform.c:
        * Removed method modest_platform_is_network_folderstore.
* src/modest-search.[ch]:
        * Defined ModestFolderResult and ModestSearchHit here. We
          provide different structs for dbus.
* src/modest-tny-account-store.c:
        * Use the account settings hash only in maemo.
* src/Makefile.am:
        * Include dbus api only in maemo.
* configure.ac:
        * New conditional for compiling dbus api (which depends on osso,
          and then, it's maemo speficic).
* Makefile.am:
        * Only compile dbus client if enabled.

pmo-trunk-r3810

13 years ago * Modest is properly finalized after sending an email
Sergio Villar Senin [Mon, 26 Nov 2007 09:15:17 +0000 (09:15 +0000)]
* Modest is properly finalized after sending an email

pmo-trunk-r3809

13 years agoFixed crash in send_mail handlers
Alberto Garcia [Fri, 23 Nov 2007 17:26:02 +0000 (17:26 +0000)]
Fixed crash in send_mail handlers

pmo-trunk-r3808

13 years ago * Removed unused code
Sergio Villar Senin [Fri, 23 Nov 2007 17:16:49 +0000 (17:16 +0000)]
* Removed unused code

pmo-trunk-r3807

13 years ago * Fixes NB#74075, app hanging/crashing while creating new accounts
Sergio Villar Senin [Fri, 23 Nov 2007 17:06:53 +0000 (17:06 +0000)]
* Fixes NB#74075, app hanging/crashing while creating new accounts
* Added a new parameter to update_account in order not to poke all folders when the method was invoked through D-Bus
* Removed the update_account_thread, now everything happens in the main loop but using async functions

pmo-trunk-r3806

13 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Fri, 23 Nov 2007 15:02:13 +0000 (15:02 +0000)]
* src/modest-ui-dimming-rules.c:
        * Now details dialog is dimmed if the message is an attachment
          (fixes NB#76616).

pmo-trunk-r3805

13 years ago* src/maemo/modest-msg-view-window-ui.xml:
Jose Dapena Paz [Fri, 23 Nov 2007 13:20:35 +0000 (13:20 +0000)]
* src/maemo/modest-msg-view-window-ui.xml:
* Convert menubar to popup.

pmo-trunk-r3804

13 years agoAdded the week 48 bug fixes to the changelog
Vivek Sekar [Fri, 23 Nov 2007 12:58:03 +0000 (12:58 +0000)]
Added the week 48 bug fixes to the changelog

pmo-trunk-r3803

13 years agoRemoved the Modest-providers-data dependency for the chinook control file.
Vivek Sekar [Fri, 23 Nov 2007 11:53:25 +0000 (11:53 +0000)]
Removed the Modest-providers-data dependency for the chinook control file.

pmo-trunk-r3801

13 years ago * The toolbar buttons are expanded correctly in the viewer after clicking on Next...
Sergio Villar Senin [Fri, 23 Nov 2007 10:19:31 +0000 (10:19 +0000)]
* The toolbar buttons are expanded correctly in the viewer after clicking on Next or Prev

pmo-trunk-r3800

13 years ago * Fixed an small leak
Sergio Villar Senin [Thu, 22 Nov 2007 20:46:14 +0000 (20:46 +0000)]
* Fixed an small leak

pmo-trunk-r3799

13 years agoReplaced obsolete logical string
Alberto Garcia [Thu, 22 Nov 2007 17:16:26 +0000 (17:16 +0000)]
Replaced obsolete logical string

pmo-trunk-r3798

13 years agoFixes NB#76638
Felipe Erias Morandeira [Thu, 22 Nov 2007 16:56:14 +0000 (16:56 +0000)]
Fixes NB#76638
I had to remove the menu entry MessageEditWindow->menu->zoom and all of the associated code. I also changed the callback for the HW buttons, so now they show an "Unable to zoom" banner.
Changes:
   * modest/src/widgets/modest-msg-edit-window-ui.h: remove _"Zoom"_ action entries.
   * modest/src/maemo/modest-msg-edit-window.c: remove code associated with the "Zoom" menu entries, use a callback for the HW buttons that only shows a banner.
   * modest/src/maemo/modest-msg-edit-window-ui-dimming.h: remove dimming rules for "Zoom" menu entries.
   * modest/src/maemo/ui/modest-msg-edit-window-ui.xml: remove "Zoom" menu entries.

pmo-trunk-r3797

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Thu, 22 Nov 2007 15:32:58 +0000 (15:32 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now we initialize wp_text_buffer on first instantiation of
  the editor, and not before. This should speed up a bit
  modest startup on opening the main window.

pmo-trunk-r3796

13 years agoFix progress bar in the view message window:
Felipe Erias Morandeira [Thu, 22 Nov 2007 13:45:28 +0000 (13:45 +0000)]
Fix progress bar in the view message window:
   * A field sighandlers was added to ModestViewMsgWindow, to keep reference of the signal handlers using ModestSignalMgr.
   * The ModestViewMsgWindow is connected to the "queue-changed" signal from the operations queue. When an operation arrives, it attaches callbacks to its "operation-started" and "operation-finished" signals, and when it is removed the callbacks are disconnected.
   * Basically, the callback on_mail_operation_started() puts the toolbar in transfer mode, and on_mail_operation_finished() puts it back in normal mode if there aren't operations left.

pmo-trunk-r3795

13 years ago* src/modest-mail-operation.c:
Jose Dapena Paz [Thu, 22 Nov 2007 12:16:12 +0000 (12:16 +0000)]
* src/modest-mail-operation.c:
        * Removed the message sending information banner here.
        * Now we allocate the send queue handler only when we really
          send the message.
        * Removed notify end in send new mail cb, as this should be done
          in send mail handlers. Added also to send mail operation
          branch where we don't attach to the send queue.
* src/modest-ui-actions.c:
        * Added mail sending information banner.

pmo-trunk-r3794

13 years ago* src/modest-mail-operation.c:
Jose Dapena Paz [Thu, 22 Nov 2007 11:04:56 +0000 (11:04 +0000)]
* src/modest-mail-operation.c:
        * Now we wait for msg-sent or error-happened signals in
          (modest_mail_operation_send_mail). This way, we don't notify
          the end of the operation until we really finish it
          (fixes NB#76308).

pmo-trunk-r3793

13 years agoFixes #76572
Felipe Erias Morandeira [Wed, 21 Nov 2007 15:47:07 +0000 (15:47 +0000)]
Fixes #76572
Shows a "emev_nc_unabletomove_item" banner if the user clicks on a dimmed "Move to" button in a view window.

pmo-trunk-r3792

13 years ago* add support for Outlook-style inline-attachments.
Dirk-Jan C. Binnema [Wed, 21 Nov 2007 15:12:19 +0000 (15:12 +0000)]
* add support for Outlook-style inline-attachments.

pmo-trunk-r3791

13 years agoAdded the modest.postinst file for chinook, so that the end user can select the sub...
Vivek Sekar [Wed, 21 Nov 2007 13:06:14 +0000 (13:06 +0000)]
Added the modest.postinst file for chinook, so that the end user can select the sub menu to place modest.

pmo-trunk-r3790

13 years ago * Fixes NB#61910 IMAP/POP TCP connections no longer survive after account deletion
Sergio Villar Senin [Wed, 21 Nov 2007 11:25:10 +0000 (11:25 +0000)]
* Fixes NB#61910 IMAP/POP TCP connections no longer survive after account deletion
* The delete cache now really happens after the account disconnection
* The account is now removed from the list of accounts of the ModestTnyAccountStore when removed

pmo-trunk-r3789

13 years agoCreate the Outbox folder with a ui-locker
Alberto Garcia [Wed, 21 Nov 2007 10:54:37 +0000 (10:54 +0000)]
Create the Outbox folder with a ui-locker
Fixes NB#74760

pmo-trunk-r3788

13 years ago* src/widgets/modest-header-view-render.c:
Jose Dapena Paz [Wed, 21 Nov 2007 09:40:00 +0000 (09:40 +0000)]
* src/widgets/modest-header-view-render.c:
* Fix getting priority for render in incoming messages folders.

pmo-trunk-r3787

13 years agoDon't wait till the message is completely saved to show the 'Saved to drafts' banner
Alberto Garcia [Tue, 20 Nov 2007 18:10:09 +0000 (18:10 +0000)]
Don't wait till the message is completely saved to show the 'Saved to drafts' banner

pmo-trunk-r3786

13 years agoFixes NB76286
Felipe Erias Morandeira [Tue, 20 Nov 2007 17:35:25 +0000 (17:35 +0000)]
Fixes NB76286
If the attachment has already been downloaded, it uses the existing file and doesn't try to create it again. This prevents a problem that happened when the user tried to open an attachment for the second time, but the existing file was read-only and couldn't be overwritten.

pmo-trunk-r3785

13 years ago* add retval check (coverity)
Dirk-Jan C. Binnema [Tue, 20 Nov 2007 17:26:32 +0000 (17:26 +0000)]
* add retval check (coverity)

pmo-trunk-r3784

13 years ago* add retval checks for hildon_sort_dialog_(get|add)_sort_key;
Dirk-Jan C. Binnema [Tue, 20 Nov 2007 17:15:22 +0000 (17:15 +0000)]
* add retval checks for hildon_sort_dialog_(get|add)_sort_key;
  to make coverity happy

pmo-trunk-r3783

13 years ago* Call tny_header_set_flag() with just one flag in each call
Alberto Garcia [Tue, 20 Nov 2007 16:08:37 +0000 (16:08 +0000)]
* Call tny_header_set_flag() with just one flag in each call
Fixes NB#76490

pmo-trunk-r3782

13 years ago* src/maemo/modest-platform.c:
Jose Dapena Paz [Tue, 20 Nov 2007 15:13:50 +0000 (15:13 +0000)]
* src/maemo/modest-platform.c:
        * Now we check in on_response of new name for folder dialog
          also if we're setting a name of a special local folder
          (fixes NB#76506).

pmo-trunk-r3781

13 years ago * Clean up some code
Sergio Villar Senin [Tue, 20 Nov 2007 14:37:26 +0000 (14:37 +0000)]
* Clean up some code

pmo-trunk-r3780

13 years agoThese changes disable focus changing in message view (fixes NB#75858)
Jose Dapena Paz [Tue, 20 Nov 2007 12:03:00 +0000 (12:03 +0000)]
These changes disable focus changing in message view (fixes NB#75858)
and improve key handling of scroll.
* src/widgets/modest-mail-header-view.c:
        * Disable focus change with cursors or keys.
* src/maemo/modest-msg-view-window.c:
        * Improve keyboard scroll (now we handle properly keypad keys,
          and also page up/down, and home/end keys).
        * Block all move-focus events.

pmo-trunk-r3777

13 years ago* src/modest-email-clipboard.[ch]:
Jose Dapena Paz [Tue, 20 Nov 2007 09:53:59 +0000 (09:53 +0000)]
* src/modest-email-clipboard.[ch]:
        * Now we have a permanent reference to private structure in
          ModestEmailClipboard instance. This is for retrieving this
          faster (we need this to improve speed of a frequent operation
          as modest_email_clipboard_cleared is).

pmo-trunk-r3776

13 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Tue, 20 Nov 2007 09:52:06 +0000 (09:52 +0000)]
* src/modest-ui-dimming-rules.c:
        * (..._on_add_to_contacts): now we use
          gtk_clipboard_wait_for_text only when we don't know how to
          get the selection of the widget we're showing.
        * (_invalid_clipboard_selected): again, we try to avoid
          using gtk_clipboard_wait_for_text when we can get the
          selection from the focused widget.

pmo-trunk-r3775

13 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 20 Nov 2007 09:48:10 +0000 (09:48 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now we setup the menu bar in construct (in new method).
* src/maemo/modest-msg-view-window.c:
        * Move the toolbar menu options setting up to restore_settings.
          We were setting this in init stage and this was forcing
          the load of all items.
        * Now we get the menubar as a GtkMenu, instead of reparenting
          its children.

pmo-trunk-r3774

13 years ago* src/widgets/modest-header-view.c:
Jose Dapena Paz [Tue, 20 Nov 2007 09:36:03 +0000 (09:36 +0000)]
* src/widgets/modest-header-view.c:
        * (filter_row). Minor optimisation to use
          gtk_tree_model_get_value instead of gtk_tree_model_get. This
          makes this faster (30% or so).
        * (filter_row). Move the g_strdup of the id to the if branch
          where it's used.

pmo-trunk-r3773

13 years agoRemove GLIB CRITICAL
Alberto Garcia [Mon, 19 Nov 2007 18:22:08 +0000 (18:22 +0000)]
Remove GLIB CRITICAL

pmo-trunk-r3772

13 years ago * Gathered the argument checking code to one single function in the D-Bus methods
Sergio Villar Senin [Mon, 19 Nov 2007 18:13:58 +0000 (18:13 +0000)]
* Gathered the argument checking code to one single function in the D-Bus methods
* Added a new noop mail operation that will be used by the D-Bus callbacks to notify modest that the operation had an error and that the program should quit
* Removed some unused code, and cleaned up some comments

pmo-trunk-r3771

13 years agoAdd missing g_object_ref() when attaching files
Alberto Garcia [Mon, 19 Nov 2007 18:00:58 +0000 (18:00 +0000)]
Add missing g_object_ref() when attaching files

pmo-trunk-r3770

13 years agoFix several important leaks in the msg edit window
Alberto Garcia [Mon, 19 Nov 2007 17:11:42 +0000 (17:11 +0000)]
Fix several important leaks in the msg edit window
Fixes NB#75751

pmo-trunk-r3769

13 years agoFixes NB#76174
Felipe Erias Morandeira [Mon, 19 Nov 2007 16:52:12 +0000 (16:52 +0000)]
Fixes NB#76174

pmo-trunk-r3768

13 years ago* add param checks to all public functions
Dirk-Jan C. Binnema [Mon, 19 Nov 2007 12:40:28 +0000 (12:40 +0000)]
* add param checks to all public functions

pmo-trunk-r3766

13 years ago* gtk_widget_show for the progress_toolbar now comes before the
Dirk-Jan C. Binnema [Mon, 19 Nov 2007 12:31:52 +0000 (12:31 +0000)]
* gtk_widget_show for the progress_toolbar now comes before the
  the one for progress_toolitem. this prevents the progressbar
  from getting the weird background color from the 'optimized-view'
  toggle button.

trivial fix, but this has annoyed me for a long time :)

pmo-trunk-r3764

13 years ago* src/widgets/modest-window-mgr.c:
Jose Dapena Paz [Mon, 19 Nov 2007 12:23:46 +0000 (12:23 +0000)]
* src/widgets/modest-window-mgr.c:
* (on_window_destroy): now we present the main window if we
  request to delete it and we need to show the confirmation
  dialog (fixes NB#74495).

pmo-trunk-r3763

13 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Mon, 19 Nov 2007 12:01:19 +0000 (12:01 +0000)]
* src/widgets/modest-folder-view.c:
* Now we show properly the collapsed normal folder view
  (fixes NB#76252).

pmo-trunk-r3762

13 years agoFixes NB#76204
Felipe Erias Morandeira [Mon, 19 Nov 2007 11:25:08 +0000 (11:25 +0000)]
Fixes NB#76204

pmo-trunk-r3761

13 years ago* modest-header-view.c:
Dirk-Jan C. Binnema [Mon, 19 Nov 2007 10:44:57 +0000 (10:44 +0000)]
* modest-header-view.c:
  - added g_return_(val_)if_fail guards to all public functions
  - removed asserts
* modest-folder-view.c:
  - small compile fix

pmo-trunk-r3760

13 years ago* change the example e-mail from first.last@provider.com => first.last@example.com
Dirk-Jan C. Binnema [Mon, 19 Nov 2007 10:13:49 +0000 (10:13 +0000)]
* change the example e-mail from first.last@provider.com => first.last@example.com
  (following Felipe's suggestion)
* put the #define for this is modest-defs.h

pmo-trunk-r3759

13 years agoFixed leak in modest-folder-view
Alberto Garcia [Fri, 16 Nov 2007 16:45:05 +0000 (16:45 +0000)]
Fixed leak in modest-folder-view

pmo-trunk-r3757

13 years agoFixed leak in modest msg view window
Alberto Garcia [Fri, 16 Nov 2007 16:10:35 +0000 (16:10 +0000)]
Fixed leak in modest msg view window

pmo-trunk-r3756

13 years ago* Fixed 3 memory leaks in modest-msg-view-window
Alberto Garcia [Fri, 16 Nov 2007 15:53:32 +0000 (15:53 +0000)]
* Fixed 3 memory leaks in modest-msg-view-window

pmo-trunk-r3755

13 years agoFixes NB#75897
Felipe Erias Morandeira [Fri, 16 Nov 2007 14:32:06 +0000 (14:32 +0000)]
Fixes NB#75897

pmo-trunk-r3754

13 years agoTageed for week 47.
Vivek Sekar [Fri, 16 Nov 2007 12:48:05 +0000 (12:48 +0000)]
Tageed for week 47.

pmo-trunk-r3752

13 years ago* speed up modest_account_mgr_has_accounts by caching the status
Dirk-Jan C. Binnema [Fri, 16 Nov 2007 11:16:46 +0000 (11:16 +0000)]
* speed up modest_account_mgr_has_accounts by caching the status
  instead of querying modest_conf (gconf) all the time

pmo-trunk-r3751

13 years ago* disconnecting the account before removing the cache, because
Dirk-Jan C. Binnema [Fri, 16 Nov 2007 10:56:21 +0000 (10:56 +0000)]
* disconnecting the account before removing the cache, because
  disconnecting *after* it would write the cache once more..

pmo-trunk-r3750

13 years ago * Removed maemo code from account store
Sergio Villar Senin [Thu, 15 Nov 2007 19:16:48 +0000 (19:16 +0000)]
* Removed maemo code from account store

pmo-trunk-r3749

13 years ago * Replaced invalid calls to hildon from common code
Sergio Villar Senin [Thu, 15 Nov 2007 19:09:43 +0000 (19:09 +0000)]
* Replaced invalid calls to hildon from common code

pmo-trunk-r3748

13 years ago* If a user edits a message from drafts, disable the header view
Alberto Garcia [Thu, 15 Nov 2007 16:38:18 +0000 (16:38 +0000)]
* If a user edits a message from drafts, disable the header view
  while the message is being saved as it could cause problems.

pmo-trunk-r3747

13 years ago * Fixes NB#70692 with tinymail commit 2956. The device won't try to connect if it...
Sergio Villar Senin [Thu, 15 Nov 2007 15:38:24 +0000 (15:38 +0000)]
* Fixes NB#70692 with tinymail commit 2956. The device won't try to connect if it's sleeping and send&received is issued by the alarmd daemon

pmo-trunk-r3746

13 years agoFixes NB#66410
Felipe Erias Morandeira [Thu, 15 Nov 2007 14:56:27 +0000 (14:56 +0000)]
Fixes NB#66410

pmo-trunk-r3745

13 years ago* fix attachment permissions:
Dirk-Jan C. Binnema [Thu, 15 Nov 2007 14:31:48 +0000 (14:31 +0000)]
* fix attachment permissions:
- when opening directly, set permissions to 0444 (read-only)
- when saving, set permissions to 0644 (read/write)

pmo-trunk-r3744

13 years ago* Add dimming rule to Menu->Email->Send on the message editor
Alberto Garcia [Thu, 15 Nov 2007 11:44:36 +0000 (11:44 +0000)]
* Add dimming rule to Menu->Email->Send on the message editor
Fixes NB#75954

pmo-trunk-r3743

13 years ago* In the message viewer, update window title after
Alberto Garcia [Thu, 15 Nov 2007 11:13:32 +0000 (11:13 +0000)]
* In the message viewer, update window title after
  setting the message
Fixes NB#75760
Fixes NB#75937

pmo-trunk-r3742

13 years ago* src/widgets/modest-attachments-view.[ch]:
Jose Dapena Paz [Thu, 15 Nov 2007 10:55:57 +0000 (10:55 +0000)]
* src/widgets/modest-attachments-view.[ch]:
        * Now clipboard requests don't support text targets, only
          attachment indexes. Fixes NB#75889.

pmo-trunk-r3741

13 years ago * Changed the order in which the singletons and the account store are finalized...
Sergio Villar Senin [Thu, 15 Nov 2007 10:04:24 +0000 (10:04 +0000)]
* Changed the order in which the singletons and the account store are finalized in order to prevent a SIGSEV

pmo-trunk-r3740

13 years ago * Refactored two error handlers
Sergio Villar Senin [Thu, 15 Nov 2007 09:03:23 +0000 (09:03 +0000)]
* Refactored two error handlers
* Migrated open_msg to use the new connect_and_perform instead of connect_and_wait

pmo-trunk-r3739

13 years ago* src/widgets/modest-combo-box.[ch]:
Jose Dapena Paz [Thu, 15 Nov 2007 08:51:33 +0000 (08:51 +0000)]
* src/widgets/modest-combo-box.[ch]:
        * Added (modest_combo_box_set_pair_list), to be able to set
          the pair list after constructing the widget.
* src/widgets/modest-window-mgr.[ch]:
        * Added a new cache for preconstructing message view and editor
          so that we can speed up opening messages. We provide methods
          ..._get_msg_view_window and ..._get_msg_edit_window. The
          cached instances are constructed in the idle loop. These
          methods are used internally in constructors of editor and
          view.
* src/maemo/modest-msg-edit-window.c:
        * Completely new structure of the widget construction. Now it
          happens in two stages. First stage is in init_window. Here it
          constructs as much as possible the widget without any specific
          running parameter. Then the ..._new constructor connects all
          signals, configures the widget with ModestConf and sets the
          message. This way, we can precreate the widget in the window
          manager cache.
        * Modified menubar_to_menu to ask for the popup menu in xml
          instead of the old hack of reparenting children of menubar.
* src/maemo/modest-msg-view-window.c:
        * Similar refactoring to the one in editor. Now init creates all
          the widgets, and they're finally set up in construction. We
          also use the window manager cache.
        * Similar change to menubar_to_menu.
* src/maemo/ui/modest-msg-view-window-ui.xml,
  src/maemo/ui/modest-msg-edit-window-ui.xml:
        * Instead of a <menubar> I changed it to be a <popup> to get
          a GtkMenu instead of a GtkMenubar
* src/modest-widget-memory.c:
        * Cleaned a small leak.

pmo-trunk-r3738

13 years ago* some cleanups for debugging:
Dirk-Jan C. Binnema [Wed, 14 Nov 2007 22:19:31 +0000 (22:19 +0000)]
* some cleanups for debugging:
- move debugging macro's to modest-debug.h (new file)
- capitalize/rename the macros to make it clearer they are macro's
- add the new MODEST_DEBUG_BLOCK; example:
MODEST_DEBUG_BLOCK(
g_debug ("DEBUG: modest: %s: prompt (not shown) = %s\n", __FUNCTION__, prompt_not_used);
);
         - this code will *only* run when the MODEST_DEBUG envir var contains "debug-code"
 - add something like this to your .emacs to make these blocks clear:
  (font-lock-add-keywords nil
                          '(("\\<\\(FIXME\\|TODO\\|XXX+\\|BUG\\|MODEST_DEBUG_BLOCK\\)"
                             1 font-lock-warning-face prepend))))
 - some coverity fixes in modest-tny-account.c (free stuff in error cases)
 - update the manpage

pmo-trunk-r3737

13 years ago* Dim the "Move to" icon and menu entry when a message is
Alberto Garcia [Wed, 14 Nov 2007 19:12:09 +0000 (19:12 +0000)]
* Dim the "Move to" icon and menu entry when a message is
  being sent
Fixes NB#75911

pmo-trunk-r3736

13 years agoDon't show mail_ib_attachment_already_purged, as this string
Alberto Garcia [Wed, 14 Nov 2007 18:46:43 +0000 (18:46 +0000)]
Don't show mail_ib_attachment_already_purged, as this string
doesn't exist anymore

pmo-trunk-r3735