modest
13 years ago* add some parameter checks
Dirk-Jan C. Binnema [Wed, 9 Jan 2008 09:06:31 +0000 (09:06 +0000)]
* add some parameter checks

pmo-trunk-r3997

13 years agoFixed some reference leaks of attachments. I also moved from using
Jose Dapena Paz [Tue, 8 Jan 2008 18:54:31 +0000 (18:54 +0000)]
Fixed some reference leaks of attachments. I also moved from using
GList* of TnyMimeParts to use TnyLists to maintain a more intuitive list
of references.
* src/widget/modest-gtkhtml-msg-view.[ch]:
        * Use TnyList of attachments
* src/widgets/modest-msg-edit-window.h:
        * Use TnyList instead of GList for attachments.
* src/widgets/modest-msg-view.[ch]:
        * Use TnyList instead of GList for attachments.
* src/widgets/modest-attachment-view.c:
        * Now the ModestAttachmentView always keep a reference
          to the mime part with g_object_ref.
* src/widgets/modest-msg-view-window.h:
        * Use TnyList instead of GList for attachments.
* src/widgets/modest-attachments-view.[ch]:
        * Missing unreferencing on iteration.
        * Use TnyList instead of GList for attachmetns.
* src/modest-tny-msg.c:
        * Use TnyList and unrefernce an attachment list properly.
* src/modest-ui-actions.c:
        * Mail operations for saving to drafts or sending mails from
          edit window shouldn't keep a reference to the edit window.
        * Fixed minor bug assigning a g_strdup.
        * Some frees in error cases in modest_ui_actions_on_send.
* src/maemo/modest-msg-edit-window.c:
        * Fixed some leaked references.
        * Use TnyList instead of GList for lists of attachments.
* src/maemo/modest-msg-view-window.c:
        * Use TnyList instead of GList for lists of attachments.
        * Fixed some counting leaks.
* src/modest-utils.[ch]:
        * New method modest_list_index (), that finds the ordinal index
          of an item in a list.
* src/modest-ui-dimming-rules.c:
        * Use TnyList instead of GList for lists of attachments.

pmo-trunk-r3996

13 years ago* check if current_folder != NULL;
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 18:11:19 +0000 (18:11 +0000)]
* check if current_folder != NULL;
  this caused a Glib-Critical when folder moving failed

pmo-trunk-r3995

13 years ago* add online status to debug output
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 18:08:04 +0000 (18:08 +0000)]
* add online status to debug output

pmo-trunk-r3994

13 years ago* after removing the last attachment, move focus to subject field
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 15:10:53 +0000 (15:10 +0000)]
* after removing the last attachment, move focus to subject field
  Fixes NB#79088

pmo-trunk-r3993

13 years agoRename ModestToolbarDimmingRules to ModestWindowDimmingRules and
Alberto Garcia [Tue, 8 Jan 2008 14:47:57 +0000 (14:47 +0000)]
Rename ModestToolbarDimmingRules to ModestWindowDimmingRules and
include all the rules in ModestMenuDimmingRules. Remove this last
group and all of its references because it's no longer necessary.

Now menu entries are dimmed/undimmed at the same time as toolbar
buttons.
Fixes NB#78844

pmo-trunk-r3992

13 years ago* enable getting debug information over dbus; for now
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 14:46:53 +0000 (14:46 +0000)]
* enable getting debug information over dbus; for now
  we can get the operation-queue contents; other things can be added later.

it can be retrieved (from cmdline):

run-standalone.sh dbus-send --print-reply --dest='com.nokia.modest' /com/nokia/modest com.nokia.modest.Dump

this will print it to stderr wherever that is for modest, and also return it as a string
over dbus. if you're lucky, you get something like:

modest debug dump
=================
mail operation queue (01)
-------------------------
0x82e7c00 "NokiaID_store" (RECEIVE) [IN-PROGRESS] {1/100} ''

pmo-trunk-r3991

13 years ago* add some param checks
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 14:43:01 +0000 (14:43 +0000)]
* add some param checks

pmo-trunk-r3990

13 years ago * Fixed NB#79057, delete confirmation note is now shown over the proper window
Sergio Villar Senin [Tue, 8 Jan 2008 10:55:57 +0000 (10:55 +0000)]
* Fixed NB#79057, delete confirmation note is now shown over the proper window

pmo-trunk-r3989

13 years ago* improve the debug output a bit
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 09:17:25 +0000 (09:17 +0000)]
* improve the debug output a bit

pmo-trunk-r3988

13 years ago* fix some runtime warning
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 09:07:43 +0000 (09:07 +0000)]
* fix some runtime warning

pmo-trunk-r3987

13 years ago* add debugging code to the send-queue and the operations-queue;
Dirk-Jan C. Binnema [Tue, 8 Jan 2008 08:58:49 +0000 (08:58 +0000)]
* add debugging code to the send-queue and the operations-queue;
  lots of interesting info when your run modest with
"MODEST_DEBUG="debug-code"

pmo-trunk-r3986

13 years ago * Fixes NB#78732, messages now appear in the Outbox after the first sent message
Sergio Villar Senin [Mon, 7 Jan 2008 11:16:32 +0000 (11:16 +0000)]
* Fixes NB#78732, messages now appear in the Outbox after the first sent message

pmo-trunk-r3985

13 years ago* now fix NB#78955:
Dirk-Jan C. Binnema [Sun, 6 Jan 2008 10:49:25 +0000 (10:49 +0000)]
* now fix NB#78955:
- choose the right MIME-part for the body, with breaking
          messages which worked before
- display 'inline' mime parts as attachments, if we don't
  display them otherwise
- create modest-tny-mime-part.[ch] as our TnyMimePart decorator

- do we need to use the new
modest_tny_mime_part_is_attachment_for_modest
  in other places too?

pmo-trunk-r3984

13 years ago* support all the URI-types in maemo (see /usr/share/applications/)
Dirk-Jan C. Binnema [Fri, 4 Jan 2008 17:27:41 +0000 (17:27 +0000)]
* support all the URI-types in maemo (see /usr/share/applications/)
  and vagalume

pmo-trunk-r3983

13 years ago* fix precondition, which could cause a crash
Dirk-Jan C. Binnema [Fri, 4 Jan 2008 16:14:09 +0000 (16:14 +0000)]
* fix precondition, which could cause a crash

pmo-trunk-r3982

13 years ago* revert of patches r3978 and r3979
Dirk-Jan C. Binnema [Fri, 4 Jan 2008 16:11:05 +0000 (16:11 +0000)]
* revert of patches r3978 and r3979

pmo-trunk-r3981

13 years ago* correctly determine what are attachments from modest's perspective;
Dirk-Jan C. Binnema [Fri, 4 Jan 2008 15:01:18 +0000 (15:01 +0000)]
* correctly determine what are attachments from modest's perspective;
  ie. non-image/ parts, even with "content-disposition: inline" are
  considered attachments from modest's pov.

note; added modest_tny_mime_part_is_attachment_for_modest; it works
  and improves upon the current situation; anyway, it's important to
  keep an eye for any mails which fail our heuristics

pmo-trunk-r3980

13 years ago* show the right body part for the message (this partly fixes NB#78955)
Dirk-Jan C. Binnema [Fri, 4 Jan 2008 13:53:21 +0000 (13:53 +0000)]
* show the right body part for the message (this partly fixes NB#78955)
  by excluding any parts with some Content-Disposition to be 'body-candidates'
* rename modest_tny_msg_get_header into the better modest_tny_mime_part_get_header_value

pmo-trunk-r3979

13 years agoAdded the week02 pre-release bug fixes.
Vivek Sekar [Fri, 4 Jan 2008 13:20:10 +0000 (13:20 +0000)]
Added the week02 pre-release bug fixes.

pmo-trunk-r3977

13 years ago* applied two syntax patches from steve.kowalik@canonical.com for Ubuntu Mobile
Dirk-Jan C. Binnema [Fri, 4 Jan 2008 10:51:39 +0000 (10:51 +0000)]
* applied two syntax patches from steve.kowalik@canonical.com for Ubuntu Mobile
  (apparently, -Wall/-Werror broke compilations with newer gcc's)
* remove the now unused curl echo from configure.ac

pmo-trunk-r3976

13 years agoAdded a small hack to make the modest packages depend on a particular version of...
Vivek Sekar [Thu, 3 Jan 2008 16:00:09 +0000 (16:00 +0000)]
Added a small hack to make the modest packages depend on a particular version of tinymail against which modest is built.

pmo-trunk-r3975

13 years ago * Fixes NB#78843, menus and CSM are working again after opening an editor window
Sergio Villar Senin [Thu, 3 Jan 2008 10:03:27 +0000 (10:03 +0000)]
* Fixes NB#78843, menus and CSM are working again after opening an editor window

pmo-trunk-r3974

13 years ago * Partially fixes NB#78857, wait for the selected folder synchronization when closin...
Sergio Villar Senin [Wed, 2 Jan 2008 18:18:20 +0000 (18:18 +0000)]
* Partially fixes NB#78857, wait for the selected folder synchronization when closing modest

pmo-trunk-r3973

13 years ago * Added some useful debug code
Sergio Villar Senin [Wed, 2 Jan 2008 18:17:13 +0000 (18:17 +0000)]
* Added some useful debug code
* Fixed a mistake in the refiltering code

pmo-trunk-r3972

13 years ago * Fixes NB#78835, copy option is now properly dimmed
Sergio Villar Senin [Wed, 2 Jan 2008 17:42:09 +0000 (17:42 +0000)]
* Fixes NB#78835, copy option is now properly dimmed

pmo-trunk-r3971

13 years ago* handle 'other' TNY_TRANSPORT_ACCOUNT_ERRORs as well, instead
Dirk-Jan C. Binnema [Wed, 2 Jan 2008 10:53:34 +0000 (10:53 +0000)]
* handle 'other' TNY_TRANSPORT_ACCOUNT_ERRORs as well, instead
  of asserting it cannot happen.
  in:
...

pmo-trunk-r3970

13 years ago* ok, fixed some more corner cases. it's getting rather hairy
Dirk-Jan C. Binnema [Mon, 31 Dec 2007 14:31:54 +0000 (14:31 +0000)]
* ok, fixed some more corner cases. it's getting rather hairy

pmo-trunk-r3969

13 years ago* fix the url handling of '&'; it's a bit hairy because of the
Dirk-Jan C. Binnema [Mon, 31 Dec 2007 14:08:59 +0000 (14:08 +0000)]
* fix the url handling of '&'; it's a bit hairy because of the
  text->html and then hyperlinkify after that. also, cleaned up
  the regexps a bit.

Fixed: Maemo bug #2683

pmo-trunk-r3968

13 years ago* we were assuming that the source of a 'new folder' thing always
Dirk-Jan C. Binnema [Mon, 31 Dec 2007 10:03:32 +0000 (10:03 +0000)]
* we were assuming that the source of a 'new folder' thing always
  was the main-window; however, it can also be the Move-To-Folder.
  if that was the case, we were crashing (even in sbox).

fixed this by checking for the source of the new-folder thing,
  and added a ptr to the internal ModestFolderView in the
  Move-To-Dialog as  a gobject parameter, so we can retrieve it
  later and set the focus correctly.

  One question remains: are there any other places where we show
  ModestFolderViews?

  Fixes: NB#78807

pmo-trunk-r3967

13 years ago* src/widgets/modest-hbox-cell-renderer.c,
Jose Dapena Paz [Fri, 21 Dec 2007 19:29:19 +0000 (19:29 +0000)]
* src/widgets/modest-hbox-cell-renderer.c,
  src/widgets/modest-vbox-cell-renderer.c:
        * Only get the children full requested size if we have any
          expanded item.

pmo-trunk-r3966

13 years agoWhen changing account settings, get the transport account correctly
Alberto Garcia [Fri, 21 Dec 2007 17:12:50 +0000 (17:12 +0000)]
When changing account settings, get the transport account correctly
Fixes NB#78788

pmo-trunk-r3965

13 years ago* update
Dirk-Jan C. Binnema [Fri, 21 Dec 2007 15:01:20 +0000 (15:01 +0000)]
* update

pmo-trunk-r3964

13 years ago* prepare public release
Dirk-Jan C. Binnema [Fri, 21 Dec 2007 14:22:24 +0000 (14:22 +0000)]
* prepare public release

pmo-trunk-r3963

13 years agoPartially fixes NB#77528
Felipe Erias Morandeira [Fri, 21 Dec 2007 13:49:32 +0000 (13:49 +0000)]
Partially fixes NB#77528
Notifies the user when "save to draft", "open attachment" or "send msg" operations fail
because the disk is full. It also improves general error notification in more general scenarios.

pmo-trunk-r3962

13 years agoRemoved GLIB CRITICAL
Alberto Garcia [Fri, 21 Dec 2007 12:33:27 +0000 (12:33 +0000)]
Removed GLIB CRITICAL

pmo-trunk-r3960

13 years agocorrected a wrong formatting in debian/changelog
Vivek Sekar [Fri, 21 Dec 2007 08:58:15 +0000 (08:58 +0000)]
corrected a wrong formatting in debian/changelog

pmo-trunk-r3958

13 years agoAdded the week 52 bug fixes.
Vivek Sekar [Fri, 21 Dec 2007 08:45:15 +0000 (08:45 +0000)]
Added the week 52 bug fixes.

pmo-trunk-r3956

13 years ago* don't need curl
Dirk-Jan C. Binnema [Fri, 21 Dec 2007 08:40:44 +0000 (08:40 +0000)]
* don't need curl

pmo-trunk-r3955

13 years ago* src/widgets/modest-gtkhtml-msg-view.c:
Jose Dapena Paz [Thu, 20 Dec 2007 18:13:08 +0000 (18:13 +0000)]
* src/widgets/modest-gtkhtml-msg-view.c:
* Removed non required include

pmo-trunk-r3954

13 years ago* src/modest-defs.h:
Jose Dapena Paz [Thu, 20 Dec 2007 17:32:25 +0000 (17:32 +0000)]
* src/modest-defs.h:
        * Add (hidden) setting to enable fetching external images in
          html messages.
* src/widgets/modest-gtkhtml-mime-part-view.c:
        * Now it fetches external images from http servers, if allowed
          in a hidden setting. It does the fetch asynchronously so that
          it's retrieved after showing the message.
* src/modest-init.c:
        * Default value of fetching external images is false.

pmo-trunk-r3953

13 years ago* don't include Cc: with reply, only with replyall
Dirk-Jan C. Binnema [Thu, 20 Dec 2007 17:21:25 +0000 (17:21 +0000)]
* don't include Cc: with reply, only with replyall

pmo-trunk-r3952

13 years ago* berto is smarter than i am
Dirk-Jan C. Binnema [Thu, 20 Dec 2007 17:04:45 +0000 (17:04 +0000)]
* berto is smarter than i am

pmo-trunk-r3951

13 years ago* only remove ourselves from the To: if we do ReplyAll;
Dirk-Jan C. Binnema [Thu, 20 Dec 2007 16:54:06 +0000 (16:54 +0000)]
* only remove ourselves from the To: if we do ReplyAll;
  and when even then, only if there are multiple recipients.

Fixes: NB#78773

pmo-trunk-r3950

13 years ago * Fixes NB#63571, connection dialog is offered if we try to create a folder in...
Sergio Villar Senin [Thu, 20 Dec 2007 16:21:17 +0000 (16:21 +0000)]
 * Fixes NB#63571, connection dialog is offered if we try to create a folder in offline mode

pmo-trunk-r3949

13 years ago * Fixes NB#78699, there was a missing refilter before selecting the new folder
Sergio Villar Senin [Thu, 20 Dec 2007 13:10:32 +0000 (13:10 +0000)]
* Fixes NB#78699, there was a missing refilter before selecting the new folder
* Fixed a reference leak reported by pvanhoof

pmo-trunk-r3948

13 years ago* src/modest-tny-msg.c:
Jose Dapena Paz [Thu, 20 Dec 2007 11:33:12 +0000 (11:33 +0000)]
* src/modest-tny-msg.c:
* Preserve content id of mime parts in copy_mime_part and
  add_attachments methods, if any available. This should make
  mails with embedded images in modest be constructed properly
  again (fixes NB#78698).

pmo-trunk-r3947

13 years ago* add a libcurl-check (we'll need that when for downloading imgs)
Dirk-Jan C. Binnema [Thu, 20 Dec 2007 06:50:44 +0000 (06:50 +0000)]
* add a libcurl-check (we'll need that when for downloading imgs)

pmo-trunk-r3946

13 years agoShow "Copied" banner after copying a URL
Alberto Garcia [Wed, 19 Dec 2007 19:07:50 +0000 (19:07 +0000)]
Show "Copied" banner after copying a URL
Fixes NB#78751

pmo-trunk-r3945

13 years ago * Use the async function instead of the sync call
Sergio Villar Senin [Wed, 19 Dec 2007 15:19:44 +0000 (15:19 +0000)]
* Use the async function instead of the sync call

pmo-trunk-r3944

13 years ago * Added MCE ifdefs
Sergio Villar Senin [Wed, 19 Dec 2007 10:03:37 +0000 (10:03 +0000)]
* Added MCE ifdefs

pmo-trunk-r3943

13 years agoAdded the mce-dev dependency.
Vivek Sekar [Wed, 19 Dec 2007 09:32:10 +0000 (09:32 +0000)]
Added the mce-dev dependency.

pmo-trunk-r3942

13 years agoDon't fail if maemo-launcher-dev is not installed
Alberto Garcia [Tue, 18 Dec 2007 19:06:07 +0000 (19:06 +0000)]
Don't fail if maemo-launcher-dev is not installed

pmo-trunk-r3941

13 years agoUse dh_maemolauncher
Alberto Garcia [Tue, 18 Dec 2007 18:08:33 +0000 (18:08 +0000)]
Use dh_maemolauncher

pmo-trunk-r3940

13 years agoAdd LAUNCHER_DEPENDS to debian/rules
Alberto Garcia [Tue, 18 Dec 2007 17:41:54 +0000 (17:41 +0000)]
Add LAUNCHER_DEPENDS to debian/rules

pmo-trunk-r3939

13 years agoGet maemo-launcher flags using pkg-config from autoconf
Alberto Garcia [Tue, 18 Dec 2007 17:29:10 +0000 (17:29 +0000)]
Get maemo-launcher flags using pkg-config from autoconf

pmo-trunk-r3938

13 years ago* only change the window title if the new title is different from
Dirk-Jan C. Binnema [Tue, 18 Dec 2007 15:05:13 +0000 (15:05 +0000)]
* only change the window title if the new title is different from
  the old one; updating is apparently an expensive op, and the
  window mgr, gtk, etc. don't do this check themselves

pmo-trunk-r3937

13 years ago * Fixes NB#78357, new mail sound is played now with IMAP IDLE events
Sergio Villar Senin [Tue, 18 Dec 2007 15:00:28 +0000 (15:00 +0000)]
* Fixes NB#78357, new mail sound is played now with IMAP IDLE events

pmo-trunk-r3936

13 years agoFixes NB#78683
Felipe Erias Morandeira [Tue, 18 Dec 2007 14:29:08 +0000 (14:29 +0000)]
Fixes NB#78683
 * Adds checks for NULL values from modest_tny_send_queue_get_outbox() and modest_tny_account_get_special_folder()
 * Also, removes three dummy g_warning() in modest-msg-edit-window.c

pmo-trunk-r3935

13 years agoUse always the default account when creating a new message
Alberto Garcia [Tue, 18 Dec 2007 12:14:07 +0000 (12:14 +0000)]
Use always the default account when creating a new message
Fixes NB#65189

pmo-trunk-r3934

13 years ago * modest-msg-edit-window.c:
Felipe Erias Morandeira [Tue, 18 Dec 2007 10:02:50 +0000 (10:02 +0000)]
   * modest-msg-edit-window.c:
      (modest_msg_edit_window_set_format_state) : the menus are updated after we change the state of the editor
      (text_buffer_refresh_attributes) : the state of alignment menu items is updated when the cursor moves

pmo-trunk-r3933

13 years agoCheck for the existence of GErrors in modest_mail_operation_save_to_drafts_cb()
Alberto Garcia [Mon, 17 Dec 2007 15:28:42 +0000 (15:28 +0000)]
Check for the existence of GErrors in modest_mail_operation_save_to_drafts_cb()

pmo-trunk-r3932

13 years agoChanges to speed up opening messages in view and editor
Jose Dapena Paz [Mon, 17 Dec 2007 12:38:22 +0000 (12:38 +0000)]
Changes to speed up opening messages in view and editor
* src/maemo/modest-msg-edit-window.c:
        * Do the show all of edit window construction to make it
          feel a bit faster.
* src/maemo/modest-msg-view-window.c:
        * Show all early to feel faster.
        * Dimming rules should be evaluated after being visible, not
          before.
* src/modest-ui-dimming-rules.c:
        * Make clipboard checks for GtkHtml be avoided when the
          selection is empty.

pmo-trunk-r3931

13 years ago * Fixes NB#78639, modest does not perform an update if the auto-update is disabled
Sergio Villar Senin [Mon, 17 Dec 2007 11:27:28 +0000 (11:27 +0000)]
* Fixes NB#78639, modest does not perform an update if the auto-update is disabled

pmo-trunk-r3930

13 years ago * Reverted my previous commit, the problem was in tinymail camel
Sergio Villar Senin [Mon, 17 Dec 2007 10:42:16 +0000 (10:42 +0000)]
* Reverted my previous commit, the problem was in tinymail camel

pmo-trunk-r3929

13 years ago * Fixed the change to the new tinymail API
Sergio Villar Senin [Mon, 17 Dec 2007 10:39:06 +0000 (10:39 +0000)]
* Fixed the change to the new tinymail API

pmo-trunk-r3928

13 years ago* make modest handle mailing lists somewhat correcter (RFC2369):
Dirk-Jan C. Binnema [Sun, 16 Dec 2007 12:48:55 +0000 (12:48 +0000)]
* make modest handle mailing lists somewhat correcter (RFC2369):
- with-reply all, reply to both the old From: and the Reply-To: address
  (in non-mailinglist cases, we ignore From: if there's a Reply-To:)
- remove duplicate entries in the To: field
- added modest_text_utils_remove_duplicate_addresses (name says it all)
- rewrote modest_text_utils_split_addresses_list; the old version appended
          the ","-seperator in some cases; the old impl is still there but #ifdef'd-out
  jdapena: please check the new impl, I think you wrote the old one
- added modest_tny_msg_get_header to get some header; I think a version
          of this function should go to Tinymail instead;

should fix NB #78638

Note: the real bug there seems to be that tny_header_get_reply_to always(?)
returns NULL; I worked around it by using the abovementioned,
modest_tny_msg_get_header (msg, "Reply-To")
now it works.

pmo-trunk-r3927

13 years ago* compile for tinymail API change
Dirk-Jan C. Binnema [Sun, 16 Dec 2007 10:08:45 +0000 (10:08 +0000)]
* compile for tinymail API change

pmo-trunk-r3926

13 years agoUpdate Modest to latest API change in Tinymail - rev. 3141
Philip Van Hoof [Sat, 15 Dec 2007 19:24:30 +0000 (19:24 +0000)]
Update Modest to latest API change in Tinymail - rev. 3141

pmo-trunk-r3925

13 years ago* no need for maemo-providers-data
Dirk-Jan C. Binnema [Fri, 14 Dec 2007 20:52:50 +0000 (20:52 +0000)]
* no need for maemo-providers-data

pmo-trunk-r3924

13 years ago * Fixed a memory leak
Sergio Villar Senin [Fri, 14 Dec 2007 17:09:47 +0000 (17:09 +0000)]
* Fixed a memory leak
* Removed some notification stuff since it's no longer needed since Felipe's changes to progress bar

pmo-trunk-r3923

13 years agoFixes NB#78637
Felipe Erias Morandeira [Fri, 14 Dec 2007 15:53:38 +0000 (15:53 +0000)]
Fixes NB#78637

pmo-trunk-r3922

13 years agoWeek 51 bug fixes.
Vivek Sekar [Fri, 14 Dec 2007 14:04:06 +0000 (14:04 +0000)]
Week 51 bug fixes.

pmo-trunk-r3920

13 years agoCorrected two g_object_unref
Felipe Erias Morandeira [Fri, 14 Dec 2007 12:43:48 +0000 (12:43 +0000)]
Corrected two g_object_unref

pmo-trunk-r3919

13 years agoCorrected ref and unref of mail operations.
Felipe Erias Morandeira [Fri, 14 Dec 2007 12:30:42 +0000 (12:30 +0000)]
Corrected ref and unref of mail operations.

pmo-trunk-r3918

13 years agoFixes NB#78602
Felipe Erias Morandeira [Fri, 14 Dec 2007 12:05:20 +0000 (12:05 +0000)]
Fixes NB#78602
   * modest-mail-operation-queue.[hc]:
      (modest_mail_operation_queue_get_by_source): returns the mail operations
         in the queue associated with a given source
   * widgets/modest-window-mgr.c:
      (modest_window_mgr_unregister_window): if the window that is being
         closed is a ModestMsgViewWindow, it cancels "open" and "receive"
         operations that have it as their source
   * maemo/modest-main-window.c:
      (on_mail_operation_started): only goes to transfer mode if it is the
         source of the operation whose start has been notified
   * maemo/modest-msg-view-window.c:
      (on_mail_operation_started): only goes to transfer mode if it is the
         source of the operation whose start has been notified
      (view_msg_cb): added checks for cancelled operations and empty fields

pmo-trunk-r3917

13 years agomodest-tny-msg: fixed leak in add_images()
Alberto Garcia [Fri, 14 Dec 2007 11:16:56 +0000 (11:16 +0000)]
modest-tny-msg: fixed leak in add_images()

pmo-trunk-r3916

13 years ago * Speeds up the progress bar, makes things "feel" faster
Sergio Villar Senin [Thu, 13 Dec 2007 18:51:55 +0000 (18:51 +0000)]
* Speeds up the progress bar, makes things "feel" faster

pmo-trunk-r3915

13 years ago* Use the old To: to determine the new To:
Dirk-Jan C. Binnema [Thu, 13 Dec 2007 16:17:50 +0000 (16:17 +0000)]
* Use the old To: to determine the new To:
* Use the old Cc: to determine the new Cc:
* _don't_ add the Bcc:
* code-cleanup

* Together with Sergio's tny patch, fixes:
NB#78589
  and
https://bugs.maemo.org/show_bug.cgi?id=2539

pmo-trunk-r3914

13 years ago* sometimes, the text->html conversion screwed up, because
Dirk-Jan C. Binnema [Thu, 13 Dec 2007 16:01:18 +0000 (16:01 +0000)]
* sometimes, the text->html conversion screwed up, because
  the hyperlinkify happens *after* text->html, and it would
  mistakenly recognize some of the things as part of urls.

https://bugs.maemo.org/show_bug.cgi?id=2540

  Now, we put \007 instead of & when doing the text->html,
  then do the hyperlinkify, then replace \007 with &

pmo-trunk-r3913

13 years agoPartially fixes NB#78521
Felipe Erias Morandeira [Thu, 13 Dec 2007 15:30:38 +0000 (15:30 +0000)]
Partially fixes NB#78521
  * src/maemo/modest-progress-bar-widget.c:
    When the progress bar receives a "progress-changed" signal from its mail operation
    where state->done = 0 and state->total = 0, it begins to pulse periodically until
    the mail operation finishes or it receives a "progress-changed" signal with
    positive values.
    * (modest_progress_bar_widget_is_pulsating) :
    * (modest_progress_bar_widget_set_pulsating_mode) : manage this pulsating mode

* src/modest-mail-operation.c
    * (modest_mail_operation_update_account) :
    * (modest_mail_operation_get_msg) :
    * (modest_mail_operation_get_msgs_full) :
    * (modest_mail_operation_refresh_folder) : these functions send an initial "progress-changed"
        signal because it could happen that the first signal with "real" data takes a long time
        to happen, or in some cases doesn't happen at all, leaving the user with an empty
        progress bar for a while.

pmo-trunk-r3912

13 years ago * Expunge the messages of the local accounts when removing them to save disk space
Sergio Villar Senin [Thu, 13 Dec 2007 13:42:23 +0000 (13:42 +0000)]
* Expunge the messages of the local accounts when removing them to save disk space

pmo-trunk-r3911

13 years agoWork to fix glitches with progress toolbar (fixes NB#78458).
Jose Dapena Paz [Thu, 13 Dec 2007 12:18:52 +0000 (12:18 +0000)]
Work to fix glitches with progress toolbar (fixes NB#78458).
* src/maemo/modest-progress-bar-widget.c:
        * Now we make sure we never set a NULL string as label of the
          progress bar, and we get an initial " " string. This is for
          getting always the expected height. This should prevent some
          toolbar resizements.
* src/maemo/modest-msg-view-window.c,
  src/maemo/modest-main-window.c:
        * Rework the toolbar buttons size management. This way the
          progress toolbar does not cause a resize of the other buttons.
* src/maemo/ui/modest-msg-view-window-ui.xml,
  src/maemo/ui/modest-main-window-ui.xml:
        * Add position attributes to toolbar.

pmo-trunk-r3910

13 years ago * Fixes NB#78587, Modest no longer crashes when closing while s&r
Sergio Villar Senin [Thu, 13 Dec 2007 11:48:56 +0000 (11:48 +0000)]
* Fixes NB#78587, Modest no longer crashes when closing while s&r

pmo-trunk-r3909

13 years ago* src/maemo/modest-main-window-ui.h:
Jose Dapena Paz [Thu, 13 Dec 2007 09:03:25 +0000 (09:03 +0000)]
* src/maemo/modest-main-window-ui.h:
        * Add shortcut for "new email" in message view.
* src/maemo/modest-maemo-utils.[ch]:
        * New method ..._get_manager_menubar_as_menu. This converts
          a GtkMenuBar obtained from ui manager to a GtkMenu as
          expected in hildon_window_set_menu (). Using this instead
          of popup menus in ui manager fixes the shortcuts
          (fixes NB#75525).
* src/maemo/modest-msg-edit-window.c,
  src/maemo/modest-msg-view-window.c,
  src/maemo/modest-main-window.c:
        * Remove menubar_to_menu, as this is now a common method in
         modest_maemo_utils. Use the new method.
* src/maemo/ui/modest-main-window.xml,
  src/maemo/ui/modest-msg-edit-window.xml,
  src/maemo/ui/modest-msg-view-window.xml:
        * Use again menubars.

pmo-trunk-r3908

13 years ago* src/modest-tny-send-queue.c:
Jose Dapena Paz [Wed, 12 Dec 2007 20:41:57 +0000 (20:41 +0000)]
* src/modest-tny-send-queue.c:
* Now we remove the "current" sending message from the send
  queue also when the message sending fails (fixes NB#75510).

pmo-trunk-r3907

13 years ago* src/dbus_api/modest-dbus-callbacks.c:
Jose Dapena Paz [Wed, 12 Dec 2007 19:59:02 +0000 (19:59 +0000)]
* src/dbus_api/modest-dbus-callbacks.c:
        * If message is not found in folder, then we show an error
          dialog (fixes NB#77958).
        * Behave as if the message was not found if the message is
          deleted.
        * Mark the message as seen on opening from dbus callback
          (fixes NB#77847).
* src/maemo/modest-msg-view-window.c:
        * Now it works better without header model or row reference.
        * Update message priority on opening from search.

pmo-trunk-r3906

13 years agoAdd correctly the "Content-Disposition" header to attachments
Alberto Garcia [Wed, 12 Dec 2007 18:42:15 +0000 (18:42 +0000)]
Add correctly the "Content-Disposition" header to attachments
in modest-tny-msg

pmo-trunk-r3905

13 years agoFix memory leak in copy_mime_part()
Alberto Garcia [Wed, 12 Dec 2007 18:11:57 +0000 (18:11 +0000)]
Fix memory leak in copy_mime_part()

pmo-trunk-r3904

13 years agoFix leak in modest-tny-msg
Alberto Garcia [Wed, 12 Dec 2007 17:11:18 +0000 (17:11 +0000)]
Fix leak in modest-tny-msg

pmo-trunk-r3903

13 years agoFix memory leak in create_msg_thread()
Alberto Garcia [Wed, 12 Dec 2007 15:55:46 +0000 (15:55 +0000)]
Fix memory leak in create_msg_thread()

pmo-trunk-r3902

13 years agoFixes NB#78203
Felipe Erias Morandeira [Wed, 12 Dec 2007 12:14:35 +0000 (12:14 +0000)]
Fixes NB#78203
   * The modest_mail_operation_remove_msgs operation takes into account the "leave on server" setting.

pmo-trunk-r3901

13 years ago * Fixes NB#64997, Modest is now able to send an email after removing the trailing...
Sergio Villar Senin [Wed, 12 Dec 2007 11:11:19 +0000 (11:11 +0000)]
* Fixes NB#64997, Modest is now able to send an email after removing the trailing ";" from the recipient address

pmo-trunk-r3900

13 years ago * Fixed an error in the documentation
Sergio Villar Senin [Tue, 11 Dec 2007 16:01:33 +0000 (16:01 +0000)]
* Fixed an error in the documentation
* Replaced the call to tny_folder_store_create_folder by tny_folder_store_create_folder_async
* Fixes NB#78382, Modest UI is not blocked while creating a folder

pmo-trunk-r3899

13 years agoAdd checks for some callbacks that are used with connect_and_perform: on_rename_folde...
Felipe Erias Morandeira [Tue, 11 Dec 2007 14:18:24 +0000 (14:18 +0000)]
Add checks for some callbacks that are used with connect_and_perform: on_rename_folder_cb, on_delete_folder_cb, xfer_messages_from_move_to_cb and on_move_folder_cb.

pmo-trunk-r3898

13 years ago * Fixes NB#78470, the account name is now properly updated in the menus when changed
Sergio Villar Senin [Tue, 11 Dec 2007 12:51:43 +0000 (12:51 +0000)]
* Fixes NB#78470, the account name is now properly updated in the menus when changed

pmo-trunk-r3897

13 years agoFixes NB#77454
Felipe Erias Morandeira [Tue, 11 Dec 2007 12:33:55 +0000 (12:33 +0000)]
Fixes NB#77454
Adding support for connect_and_perform() in modest-ui-actions.c, for the public functions:
    * modest_ui_actions_on_move_to(..), both folder->folder and emails->folder
    * modest_ui_actions_on_delete_folder(..)
    * modest_ui_actions_on_move_folder_to_trash_folder(..)

pmo-trunk-r3896

13 years ago* some email programs (e.g. outlook in html mode) put 'normal'
Dirk-Jan C. Binnema [Mon, 10 Dec 2007 16:55:09 +0000 (16:55 +0000)]
* some email programs (e.g. outlook in html mode) put 'normal'
  http://foo.bar/image.jpg links in the html, and then attach
  the image, with Content-Location set to http://foo.bar/image.jpg,
  but the content embedded.

this fix makes sure we will find & show those images

pmo-trunk-r3895

13 years agoAdded the base64 encoded icon file into the chinook control file.
Vivek Sekar [Mon, 10 Dec 2007 15:51:15 +0000 (15:51 +0000)]
Added the base64 encoded icon file into the chinook control file.

pmo-trunk-r3894

13 years agoFix shortcut for Send in the message editor
Alberto Garcia [Mon, 10 Dec 2007 13:55:45 +0000 (13:55 +0000)]
Fix shortcut for Send in the message editor
Fixes NB#65668

pmo-trunk-r3893