1 2007-07-04 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-msg-view-window.c:
4 (modest_msg_view_window_select_next_message):
6 * src/modest-platform.h:
7 * src/maemo/modest-platform.c:
8 Added modest_platform_connect_and_wait(), which calls
9 tny_maemo_conic_device_connect() always in the main thread, by calling it
10 in an idle handler and waiting for the idle handler to run. It should be
11 in the main thread because it uses GTK+ UI code. It just returns TRUE
12 if the device is already online.
14 There is some nasty code to ensure that subsequent calls to
15 modest_platform_connect_and_wait() just wait for the first one to finish,
16 by checking repeatedly in another idle handler. This is necessary,
17 because other threads (or even the main thread, via another idle handler)
18 can call modest_platform_connect_and_wait() while
19 modest_platform_connect_and_wait() is running.
21 (modest_platform_connect_and_wait_if_network_account),
22 (modest_platform_connect_and_wait_if_network_folderstore):
23 Convenience functions that calls modest_platform_connect_and_wait() if
24 the account or folder might want network access.
26 * src/modest-mail-operation.c:
27 (modest_mail_operation_update_account):
28 * src/modest-ui-actions.c: (download_uncached_messages),
29 (modest_ui_actions_on_rename_folder), (delete_folder),
30 (modest_ui_actions_on_main_window_move_to),
31 (modest_ui_actions_on_msg_view_window_move_to):
32 * src/widgets/modest-folder-view.c:
33 (drag_and_drop_from_folder_view):
34 Offer a connection if we are offline.
36 * src/modest-tny-account.c: (on_connection_status_changed):
37 Document this as only handling errors during network operations in progress,
38 and replace the idle code with a simple call to
39 modest_platform_connect_and_wait(), which does this instead.
41 2007-07-03 Murray Cumming <murrayc@murrayc.com>
43 * src/modest-tny-account.c:
44 (modest_tny_account_get_special_folder): (util_on_idle),
45 Handle the GError so we can see when tny_folder_store_get_folders()
46 fails, as it currently does while something else is connecting.
48 Added util_run_in_main_thread_and_wait()
49 which uses an idlen handler and mainloop to ensure that the function
50 is called in the main thread.
51 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
52 to make sure that we call attempt the connection in the mainloop only,
53 which might solve some hangs.
55 2007-07-03 Murray Cumming <murrayc@murrayc.com>
57 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
58 be found by their display name. This is never useful.
59 * src/modest-tny-account-store.c: (on_account_removed): Find the account
60 by its ID, instead of trying to use its ID as its display name.
62 * src/modest-tny-account-store.h:
63 * src/modest-tny-account.c:
64 (modest_tny_account_get_special_folder): Add a g_warning() when
65 tny_folder_store_get_folders() returns an empty list for the maildir.
67 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
68 Add a g_warning() when this returns NULL, because that it not allowed
71 2007-07-02 Armin Burgmeier <armin@openismus.com>
73 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
74 note when trying to cancel the wizard. This fixes projects.maemo.org
77 2007-07-02 Murray Cumming <murrayc@murrayc.com>
79 * src/modest-tny-account.h:
80 * src/modest-tny-account.c:
81 (modest_tny_account_new_from_server_account),
82 (modest_tny_account_new_from_server_account_name),
83 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
84 because this must now be set before setting the proto. This is usd in
85 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
86 warning in camel_session_get_service() caused by
87 tny_camel_transport_account_prepare().
89 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
92 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
94 * src/maemo/modest-connection-specific-smtp-edit-window.c:
96 (modest_connection_specific_smtp_edit_window_init):
98 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
101 2007-06-29 Murray Cumming <murrayc@murrayc.com>
103 * src/modest-tny-account.c:
104 (modest_tny_account_new_from_server_account):
105 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
106 now uses to request a connection when it needs one, and which it uses
107 to tell us that something is wrong with the connection, so we can force
108 the accounts offline to prevent further problems.
111 * src/modest-init.c: (init_default_settings):
112 * src/modest-mail-operation.c:
113 (modest_mail_operation_update_account):
114 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
115 This should not be necessary anymore. Do not set the conf key that
116 determined this (it was always TRUE and not set anywhere else).
118 * src/modest-ui-actions.h: Remove unused and unimplemented
119 modest_ui_actions_on_online_toggle_toggled().
121 2007-06-29 Murray Cumming <murrayc@murrayc.com
123 * src/maemo/modest-main-window.c: (connect_signals):
124 Don't connect to delete_event twice. Maybe this was harmless.
126 2007-06-29 Murray Cumming <murrayc@murrayc.com
128 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
129 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
130 Debug output to give some more clue when a folder move is not allowed.
132 2007-06-28 Murray Cumming <murrayc@murrayc.com
134 * src/modest-tny-account.c: (on_modest_file_system_info),
135 (modest_tny_account_get_mmc_account_name):
136 Always call the callback, without checking whether the name has changed.
137 * src/widgets/modest-folder-view.c: (strings_are_equal),
138 (on_model_foreach_set_name), (on_get_mmc_account_name),
139 (text_cell_data): Compare the name here, and use the name from
140 the account rather than from the
141 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
142 if the name was changed after the account was added to the model.
143 That's a tinymail bug but not one that I want to fix now.
145 This finally fixes projects.maemo.org bug NB#59301.
147 2007-06-27 Armin Burgmeier <armin@openismus.com>
149 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
152 2007-06-27 Murray Cumming <murrayc@murrayc.com
154 * src/modest-tny-account.h:
155 * src/modest-tny-account.c:
156 Added modest_tny_account_get_mmc_account_name(), to set the memory
157 card name asynchronously for the given account and then notify.
158 (modest_tny_account_new_for_local_folders): Use this new function instead
159 of using hildon_file_system_info_async_new() directly.
161 * src/widgets/modest-folder-view.c: (text_cell_data):
162 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
163 gtk_tree_model_row_changed() when it is available.
165 This should fix projects.maemo.org bug NB#59301.
167 2007-06-27 Murray Cumming <murrayc@murrayc.com
169 * src/modest-mail-operation.c: (update_account_thread),
170 (get_msgs_full_thread): Fix typo failures in the revert
173 2007-06-27 Murray Cumming <murrayc@murrayc.com
175 * src/maemo/modest-maemo-global-settings-dialog.c:
176 (idle_select_default_focus):
177 * src/modest-mail-operation.c: (idle_notify_progress),
178 (idle_notify_progress_once), (set_last_updated_idle),
179 (update_account_thread), (get_msgs_full_thread):
180 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
181 * src/widgets/modest-header-view.c:
182 (idle_notify_headers_count_changed_destroy),
183 (idle_notify_headers_count_changed):
184 Reverted the additions of gdk_threads_enter/leave(), in case this
185 helps with a startup hang on the device.
187 2007-06-26 Armin Burgmeier <armin@openismus.com>
189 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
190 for supported secure authentication methods from server by
191 gtk_dialog_run(), saving CPU time and a potential race condition.
193 2007-06-26 Armin Burgmeier <armin@openismus.com>
195 * src/maemo/modest-maemo-utils.h:
196 * src/maemo/modest-maemo-utils.c: Added a
197 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
198 only error code to tell the calling code when the user canceled the
201 * src/maemo/modest-account-settings-dialog.h:
202 * src/maemo/modest-account-settings-dialog.c:
203 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
204 message if the retrieval of secure authentication methods was canceled
205 by the user. Perform the check before saving anything to configuration
206 to not end up with half-committed configuration changes, do not show
207 a "Saving to configuration failed" note when authentication methods
208 could not be retrieved.
210 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
213 2007-06-26 Murray Cumming <murrayc@murrayc.com>
215 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
216 Only return the first level of folders under accounts, because the
217 osso-global-search UI spec doesn't want the rest.
218 This fixed projects.maemo.org bug NB#61811.
220 2007-06-26 Murray Cumming <murrayc@murrayc.com>
222 * src/modest-tny-account-store.c:
223 * src/modest-tny-account-store.h:
224 Added modest_tny_account_is_memory_card_account().
225 * src/maemo/modest-main-window.c: (create_details_widget):
226 Show the same information items for the memory card as we show for the
227 local-folders, to fix projects.maemo.org bug NB#59307.
229 2007-06-26 Murray Cumming <murrayc@murrayc.com>
231 * src/modest-tny-account-store.c: (get_password):
232 Added some checks for NULL to maybe prevent crashes, though I think
233 it was Philip's last commit that actually prevented the crash here
234 when creating a first new account.
235 But the new account is still not usable (no messages are shown)
236 until a restart of the application.
238 2007-06-26 Murray Cumming <murrayc@murrayc.com>
240 * src/maemo/modest-maemo-global-settings-dialog.c:
241 (idle_select_default_focus):
242 * src/modest-mail-operation.c: (idle_notify_progress),
243 (idle_notify_progress_once), (idle_notify_update_account_queue),
244 (set_last_updated_idle), (update_account_thread),
245 (notify_get_msgs_full), (get_msgs_full_destroyer),
246 (get_msgs_full_thread):
247 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
248 * src/widgets/modest-header-view.c:
249 (idle_notify_headers_count_changed_destroy),
250 (idle_notify_headers_count_changed):
251 Use gdk_threads_enter() and gdk_threads_enter_leave() in
252 all idle handlers, because some other thread could be blocking
253 the GDK lock, so that it can do GUI stuff.
255 2007-06-26 Murray Cumming <murrayc@murrayc.com>
257 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
258 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
259 (on_idle_send_receive), (on_idle_open_default_inbox):
260 * src/maemo/modest-msg-edit-window.c:
261 (modest_msg_edit_window_attach_file_noninteractive):
262 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
263 to prevent a hang. I don't quite understand why these are necessary,
264 beause we should already be in the main loop. I guess something outside
265 of the main loop is taking the lock.
267 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
268 we are really using URIs, and use files that are more likely to exist.
270 2007-06-26 Murray Cumming <murrayc@murrayc.com>
272 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
273 necessary because configure.ac now defines different variables.
275 2007-06-26 Murray Cumming <murrayc@murrayc.com>
277 * libmodest-dbus-client/libmodest-dbus-client.c:
278 * libmodest-dbus-client/libmodest-dbus-client.h:
279 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
280 libmodest_dbus_client_compose_mail() is what things actually use.
282 * src/dbus_api/modest-dbus-api.h:
283 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
284 * tests/dbus_api/Makefile.am:
285 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
288 2007-06-26 Murray Cumming <murrayc@murrayc.com>
290 * src/modest-init.c: (modest_init_local_folders):
291 For memory-card (or other non local-folders) maildir accounts,
292 always create an Archive folder, so that there is somewhere to put
293 messages. This should be less confusing, because the user does not need
294 to guess that the need to create a folder.
296 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
298 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
299 Fixed icon size by using (50, 50) which is the same as defined by
302 2007-06-25 Armin Burgmeier <armin@openismus.com>
304 * src/widgets/modest-window-mgr.c:
306 * configure.ac: Correctly recognize hildon-notify presence and fixed
307 the build without it being installed.
309 2007-06-25 Murray Cumming <murrayc@murrayc.com>
311 * libmodest-dbus-client/libmodest-dbus-client.c:
312 (libmodest_dbus_client_search): Fix the build. Sorry.
313 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
314 (reply_forward_cb): Initialize variables to fix the build.
316 * src/modest-tny-account-store.c:
317 (modest_tny_account_store_get_tny_account_by): Fix the account URI
318 comparison (a silly typo) so that email search results can be opened
319 when there are more than one account.
321 2007-06-25 Murray Cumming <murrayc@murrayc.com>
323 * libmodest-dbus-client/libmodest-dbus-client.c:
324 (libmodest_dbus_client_search),
325 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
326 instead of 1 second, because the search gets folders and messages from
327 the server, which can take a long time. When it times out,
328 osso-global-search will report no results.
330 We need to specify whether we should search only cached information
331 (maybe with a user preference), and the osso-email-search-plugin
332 API should really be improved to allow that option, and to allow results
333 to be delivered asynchronously in batches.
335 2007-06-25 Murray Cumming <murrayc@murrayc.com>
337 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
338 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
339 GTK_ICON_SIZE_DIALOG is probably the wrong size.
341 2007-06-25 Murray Cumming <murrayc@murrayc.com>
343 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
344 that is an empty string. D-Bus seems to give us these instead of NULL.
346 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
348 * src/dbus_api/modest-dbus-callbacks.c:
349 * src/maemo/easysetup/modest-easysetup-wizard.h:
350 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
351 * src/maemo/modest-connection-specific-smtp-edit-window.c:
352 (modest_connection_specific_smtp_edit_window_init):
353 * src/maemo/modest-maemo-global-settings-dialog.c:
355 * src/maemo/modest-maemo-utils.c:
356 (modest_maemo_utils_setup_images_filechooser):
357 * src/maemo/modest-main-window.c: (create_details_widget):
358 * src/maemo/modest-msg-edit-window.c:
359 (modest_msg_edit_window_attach_file_noninteractive),
360 (modest_msg_edit_window_color_button_change),
361 (modest_msg_edit_window_set_zoom):
362 * src/modest-mail-operation.c: (update_account_thread):
363 * src/modest-tny-account-store.c:
364 * src/modest-tny-account.c:
365 * src/widgets/modest-global-settings-dialog.c:
366 * src/widgets/modest-window.h:
370 2007-06-25 Murray Cumming <murrayc@murrayc.com>
372 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
373 * src/modest-search.c: (modest_search_folder),
374 (modest_search_all_accounts): Actually search only in the specified folder,
375 doing a simple match on the folder ID.
376 * src/modest-search.h: Added a folder field to the ModestSearch struct,
377 and added some documentation.
379 2007-06-22 Armin Burgmeier <armin@openismus.com>
381 * src/maemo/modest-maemo-utils.h:
382 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
383 modest_maemo_utils_get_supported_secure_authentication_methods.
385 * src/maemo/easysetup/modest-easysetup-wizard.c:
386 * src/maemo/modest-account-settings-dialog.c: Show correct error if
387 one occured, not just "Server does not support secure authentication".
389 2007-06-22 Murray Cumming <murrayc@murrayc.com>
391 * src/modest-tny-account-store.c: (get_password):
392 Restored the call to tny_account_set_user() because Philip seems to have
393 stopped this from crashing (by not using the freed string). It still does
394 not work, but now we can test it.
396 2007-06-22 Murray Cumming <murrayc@murrayc.com>
398 * src/maemo/modest-msg-edit-window.c: (init_window):
399 Comment out use of an uninitialzed GtkScrolledWindow variable,
400 to fix the build and stop a crash. Yet again.
402 2007-06-22 Murray Cumming <murrayc@murrayc.com>
404 * src/modest-tny-account-store.c: (get_password):
405 Remove the call to tny_account_set_user() because this actually crashes.
406 As mentioned in the last commit, it is known to not work anyway.
408 2007-06-22 Murray Cumming <murrayc@murrayc.com>
410 * src/modest-tny-account-store.c: (get_password):
411 Use tny_account_set_username() to tell tinymail that the username might
412 have changed too. But tinymail ignores this: see projects.maemo.org
414 * src/modest-ui-actions.c:
415 (modest_ui_actions_on_password_requested): Remove the useless attempt to
416 reset the connection when changing the username, and improve the comments.
417 Save the changed username to gconf at least, so it is used when Modest is
420 2007-06-21 Murray Cumming <murrayc@murrayc.com>
422 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
423 Do not use a query, so that we get all folders, including for POP and
424 local-folders. They work as search criteria too.
425 This fixes projects.maemo.org bug NB#57740.
427 2007-06-21 Murray Cumming <murrayc@murrayc.com>
429 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
430 Comment out the use of hildon_notification_set_sound() because it is
431 not declared, to fix the build. Warnings are serious, people.
433 2007-06-21 Armin Burgmeier <armin@openismus.com>
435 * src/maemo/modest-maemo-utils.h:
436 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
437 modest_maemo_utils_get_supported_secure_authentication_methods()
438 to query authentication methods for a specific user. This should fix
439 projects.maemo.org bug NB#61369.
441 * src/maemo/easysetup/modest-easysetup-wizard.c:
442 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
445 2007-06-21 Murray Cumming <murrayc@murrayc.com>
447 * libmodest-dbus-client/libmodest-dbus-client.h:
448 * libmodest-dbus-client/libmodest-dbus-client.c:
449 (modest_dbus_message_iter_get_search_hit),
450 (libmodest_dbus_client_search):
451 Reorganised and commented this.
452 Removed modest_search_hit_free() from the public API because it
455 Added libmodest_dbus_client_get_folders() and
456 modest_folder_result_list_free().
458 * src/dbus_api/modest-dbus-api.h:
459 * src/dbus_api/modest-dbus-callbacks.c:
460 (modest_dbus_req_filter): Commented. Moved most code to
461 on_dbus_method_search() and added on_dbus_method_get_folders().
463 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
464 of the extra D-Bus handler.
466 * tests/dbus_api/Makefile.am:
467 * tests/dbus_api/test_get_folders.c: New test for
468 libmodest_dbus_client_get_folders(). This seems to return an empty list
469 at the moment. That could be the same error that causes the message list
470 to be empty sometimes.
471 This should help with projects.maemo.org bug NB#57740.
473 2007-06-21 Armin Burgmeier <armin@openismus.com>
475 * src/modest-mail-operation.c: Do not call
476 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
477 notify the operation's end after having set the status to CANCELED for
478 the operation queue to listen on. This fixes a deadlock when there
479 were mail operations in the queue during its finalization.
481 * src/modest-singletons.c: Reordered uninitialization of the account
482 manager to happen after the mail operation queue was uninitialized
483 because the mail operation's in the queue might still try to access
484 the account manager (see modest_mail_operation_notify_end()). This
485 fixes a potential crash when terminating the application.
487 2007-06-21 Murray Cumming <murrayc@murrayc.com>
489 * src/modest-search.c:
490 (search_mime_part_and_child_parts): Moved some code here so we
491 can search recursively in child folders.
492 (modest_search_folder): Search in the message as a mime part, instead
493 of just its child mime parts.
494 (read_chunk), (search_mime_part_ogs):
495 Check how many bytes were read, to prevent an endless loop.
496 Searching in message bodies now works. This finishes the fix for
497 projects.maemo.org bug NB#61007.
499 2007-06-20 Murray Cumming <murrayc@murrayc.com>
501 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
502 Add a g_warning when the item is not a folder.
504 * src/modest-ui-dimming-rules.c:
505 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
506 when selected item is not a folder (for instance, an account), because
507 the UI spec only talks about folders.
508 I am not sure what the UI spec wants, so this might not totally fix
509 projects.maemo.org bug NB#60794.
511 2007-06-20 Murray Cumming <murrayc@murrayc.com>
513 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
514 (load_from_file): Sort the list. The unsorted list would be more noticeable
515 in non-English locales.
517 * src/maemo/modest-msg-edit-window.c:
518 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
519 warning and fix the build.
521 * src/maemo/modest-progress-bar-widget.c:
522 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
523 avoid a g_warning, and probably to avoid a crash.
525 2007-06-20 Murray Cumming <murrayc@murrayc.com>
527 * src/modest-search.c: (modest_search_folder): Check for a GError
528 when calling tny_folder_get_headers(), to show that this is not the cause
531 2007-06-20 Murray Cumming <murrayc@murrayc.com>
533 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
534 Actually set the body query instead of the subject query.
536 * src/modest-search.c: (search_mime_part_ogs),
537 (search_mime_part_strcmp): Remove extra space from the text/* regex,
538 which would probably cause it to fail if we got this far.
540 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
541 to simplify the code.
542 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
543 be causing search-in-body to fail.
545 2007-06-20 Murray Cumming <murrayc@murrayc.com>
547 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
549 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
550 Better debug message when the folder cannot be found.
551 This should help with fixing projects.maemo.org bug #61287.
552 * src/modest-search.c: (add_hit): Do not leak the furl string.
554 2007-06-20 Murray Cumming <murrayc@murrayc.com>
556 * src/modest-ui-actions.c:
557 (modest_ui_actions_on_folder_selection_changed):
558 Do not special-case TNY_MERGE_FOLDER here, because
559 modest_tny_folder_get_account() already does that. This fixes
560 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
561 shown when the Outbox was selected).
563 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
565 * libmodest-dbus-client/libmodest-dbus-client.c:
566 (_dbus_iter_get_string_or_null): Initialize the string variable in
567 case this helps with Dirk's crash.
569 2007-06-19 Murray Cumming <murrayc@murrayc.com>
571 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
572 though it is not implemented yet (this function is maybe not even used),
573 to avoid breaking ABI in future.
574 * libmodest-dbus-client/libmodest-dbus-client.c:
575 (get_attachments_string): Moved some code into this generic function.
576 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
577 sends email. It is maybe not used.
578 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
579 (on_send_mail): Use attachments.
581 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
582 * src/maemo/modest-msg-edit-window.c:
583 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
584 a filename before using it, to fix projects.maemo.org bug NB#58233.
586 2007-06-19 Murray Cumming <murrayc@murrayc.com>
588 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
589 Initialize the continue_download variable to fix the build, and probably
590 to fix randome behaviour.
592 2007-06-18 Armin Burgmeier <armin@openismus.com>
594 * src/modest-tny-send-queue.h:
595 * src/modest-tny-send-queue.c: Keep track of the status of messages in
596 the queue so we can later show it in the UI. Replaced
597 modest_tny_send_queue_msg_is_being_sent() by
598 modest_tny_send_queue_get_msg_status().
600 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
602 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
603 gpointer. This probably was not harmful, but just to be sure.
605 2007-06-18 Murray Cumming <murrayc@murrayc.com>
607 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
608 Fix the build, but leave the function broken on Bora, because
609 hildon_uri_action_get_service() does not exist.
610 osso_uri_action_get_service() does not exist either, it seems.
612 2007-06-18 Murray Cumming <murrayc@murrayc.com>
614 * src/modest-tny-account.c:
615 (modest_tny_account_new_from_server_account):
616 Uncommented the url debug output again, because it is useful for
617 debugging, as I said in the comment.
619 2007-06-18 Murray Cumming <murrayc@murrayc.com>
621 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
623 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
624 for Mameo Bora, to fix the build.
626 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
629 Fixed build with hildon < 0.99
631 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
632 Check if the selected account is busy instead of checking all accounts
634 * src/modest-account-mgr-priv.h:
635 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
636 (modest_account_mgr_init), (compare_account_name),
637 (modest_account_mgr_set_account_busy),
638 (modest_account_mgr_account_is_busy):
639 * src/modest-account-mgr.h:
640 Added busy information to the account manager. It possible to
641 set an account to busy or not busy now.
643 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
644 (modest_mail_operation_update_account),
645 (modest_mail_operation_notify_end):
646 Set the account to busy/not busy depending on the operation state.
648 * src/widgets/modest-account-view.c:
649 (modest_account_view_finalize), (get_last_updated_string),
650 (update_account_view), (on_account_busy_changed), (init_view):
651 Show string "Refreshing..." if the account is currently busy.
653 All this fixes projects.maemo.org bug NB#59711
655 2007-06-14 Armin Burgmeier <armin@openismus.com>
657 * src/widgets/modest-attachments-view.h:
658 * src/widgets/modest-attachments-view.c: Added
659 modest_attachments_view_has_attachments() and fixed coordinate
660 transformation in get_att_view_at_coords(). This fixes attachment
663 * src/widgets/modest-msg-view.c: Make use of
664 modest_attachments_view_has_attachments() to decide whether to show
665 attachments in the header.
667 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
669 * src/maemo/modest-connection-specific-smtp-edit-window.c:
670 (on_change), (on_combo_security_changed),
671 (modest_connection_specific_smtp_edit_window_init),
672 (modest_connection_specific_smtp_edit_window_set_connection),
673 (modest_connection_specific_smtp_edit_window_is_dirty):
674 * src/maemo/modest-connection-specific-smtp-edit-window.h:
675 * src/maemo/modest-connection-specific-smtp-window.c:
678 Show an comfirmation dialog for the smpt-edit-window if there are
679 unsaved changes and the user hits cancel.
680 (projects.maemo.org bug NB#60479)
682 2007-06-14 Armin Burgmeier <armin@openismus.com>
684 * src/maemo/easysetup/modest-easysetup-wizard.c:
685 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
686 address" info in banner instead of node, and select all the text as
687 per UI spec. This fixes projects.maemo.org bug NB#60550.
689 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
691 reviewed by: <delete if not using a buddy>
693 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
694 * src/modest-ui-actions.c: (folder_refreshed_cb):
696 2007-06-14 Murray Cumming <murrayc@murrayc.com>
698 * src/widgets/modest-folder-view.c: (filter_row):
699 Explictly filter out the per-account outbox accounts. I don't know why
700 these only sometimes show up, but now they should never show up in the UI.
701 This should fix projects.maemo.org bug NB#60160.
703 2007-06-14 Murray Cumming <murrayc@murrayc.com>
705 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
706 when the toolbar does not exist yet.
707 * src/modest-widget-memory.c: (save_settings_header_view):
708 Added g_warnings() to help us to discover when we are trying to set
709 an empty columns list in gconf.
711 2007-06-14 Murray Cumming <murrayc@murrayc.com>
715 Added modest_init_get_default_header_view_column_ids().
717 * src/modest-widget-memory.c: (restore_settings_header_view):
718 Use the new function to get defaults, if the gconf key is empty,
719 instead of not creating any columns. This seems to fix the
720 empty right-hand pane problems.
722 * src/widgets/modest-header-view.h: Improved documentation.
724 2007-06-13 Murray Cumming <murrayc@murrayc.com>
726 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
727 Revert the use of the display name as the account name, because this
728 is generally wrong and would break the code that follows.
730 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
732 * src/maemo/easysetup/modest-easysetup-wizard.c:
733 (check_for_supported_auth_methods), (on_before_next),
736 More correct fix for projects.maemo.org bug NB# 58991
737 Do not longer accept AUTH_PASSWORD as secure method and choose
738 correct method when creating the account.
740 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
742 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
743 Fixed projects.maemo.org bug NB# 58991
745 2007-06-13 Murray Cumming <murrayc@murrayc.com>
747 * src/modest-init.c: (modest_init_init_core),
748 (modest_init_local_folders): Fixed compilation errors.
750 2007-06-13 Murray Cumming <murrayc@murrayc.com>
752 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
753 Remove unnecessary lib/include, though it is good in principle when needed.
755 * src/modest-init.c: (modest_init_one_local_folder),
756 (modest_init_local_folders):
757 * src/modest-init.h: Initialize the .modest library for memory cards,
758 instead of just doing nothing for them. This should allow us to create
759 folders there, fixing projects.maemo.org bug NB#59297.
761 2007-06-13 Murray Cumming <murrayc@murrayc.com>
763 * libmodest-dbus-client/libmodest-dbus-client.c:
764 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
765 (libmodest_dbus_client_compose_mail),
766 (libmodest_dbus_client_open_message),
767 (libmodest_dbus_client_send_and_receive),
768 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
770 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
771 (on_idle_open_message), (modest_dbus_req_handler),
772 (search_result_to_message), (modest_dbus_req_filter):
773 * src/modest-search.c: (add_hit), (modest_search_folder),
774 (modest_search_all_accounts): Improved debug messages.
776 * tests/dbus_api/test_open_message.c: (main): Improved comments.
778 * src/modest-tny-account-store.c:
779 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
782 2007-06-13 Murray Cumming <murrayc@murrayc.com>
785 2007-06-12 Murray Cumming <murrayc@murrayc.com>
787 * src/modest-tny-account-store.c: (get_server_accounts):
788 Call modest_tny_local_folders_account_add_merged_outbox_folders()
789 even when there are no accounts, so that the Outbox folder is always
790 visible. This fixes projects.maemo.org bug NB#60158.
792 2007-06-12 Murray Cumming <murrayc@murrayc.com>
794 * src/maemo/modest-main-window.c: (create_details_widget):
795 Use the mcen_va_never logical ID.
797 2007-06-12 Murray Cumming <murrayc@murrayc.com>
799 * src/dbus_api/modest-dbus-api.h:
800 * src/dbus_api/modest-dbus-callbacks.c:
801 (on_idle_open_default_inbox), (on_open_default_inbox),
802 (modest_dbus_req_handler):
803 Added a new OpenDefaultInbox method.
805 * libmodest-dbus-client/libmodest-dbus-client.h:
806 * libmodest-dbus-client/libmodest-dbus-client.c:
807 Added libmodest_dbus_client_open_default_inbox() to call the new
808 dbus method. This should be useful to projects.maemo.org bug NB#57214,
809 though it should maybe be used by a new osso-email-interface function.
811 * tests/dbus_api/Makefile.am:
812 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
815 2007-06-12 Murray Cumming <murrayc@murrayc.com>
817 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
818 NULL, so that the signals get all the keys. This should not actually
819 change any behaviour because we currently update everything when anything
822 2007-06-12 Murray Cumming <murrayc@murrayc.com>
824 * src/widgets/modest-folder-view.c: (text_cell_data),
825 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
826 (find_inbox_iter): If tinymail tells us that the folder is
827 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
828 This causes the inbox to be selected at startup, fixing part of
829 projects.maemo.org bug NB#56305.
831 * src/modest-ui-dimming-rules.c:
832 (modest_ui_dimming_rules_on_tools_smtp_servers):
833 * src/modest-ui-dimming-rules.h: Added a callback function to dim
834 the SMTP servers menu item.
835 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
836 that the SMTP Servers menu item is dimmed when there are no accounts,
837 as a future version of the UI spec will require. This fixes
838 projects.maemo.org bug NB#56305.
840 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
842 * src/maemo/modest-maemo-utils.c:
843 (modest_maemo_utils_get_supported_secure_authentication_methods):
844 Added label to dialog instead of unreadable title
846 * src/maemo/modest-main-window.c: (sync_accounts_cb),
847 (modest_main_window_new):
848 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
851 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
852 * src/modest-account-mgr.h:
853 Added method to avoid code duplication
855 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
856 (modest_ui_actions_on_send_receive):
857 Use modest_account_mgr_has_accounts
859 2007-06-11 Murray Cumming <murrayc@murrayc.com>
861 * src/maemo/easysetup/modest-presets.c:
862 (modest_presets_get_info_server_security): Do not report secure auth
864 * src/modest-protocol-info.c: Use the defines for the gconf key names
865 for secure authentication. This was not working because we were writing
866 Password and reading password, and the check was case sensitive.
867 With this, gmail now works for receiving and sending when created via
870 2007-06-11 Murray Cumming <murrayc@murrayc.com>
872 * src/maemo/easysetup/modest-presets.c:
873 (modest_presets_get_info_server_security): Correct the key name for
874 SecureSmtp, because it seems to be case-sensitive.
875 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
876 Do not try to get the 0th notebook page if there are 0 pages, to
879 2007-06-11 Murray Cumming <murrayc@murrayc.com>
881 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
882 Prevent use of the new notification feature for now, because it currently
883 shows one dialog for each new email, which is annoying.
885 2007-06-11 Murray Cumming <murrayc@murrayc.com>
887 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
888 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
889 when no country was selected, so that we show the global ones.
890 * src/maemo/easysetup/modest-presets.c:
891 (modest_presets_get_providers): Return only the global providers, not
892 all providers when mmc=0 was requested.
894 2007-06-11 Murray Cumming <murrayc@murrayc.com>
896 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
897 (easysetup_provider_combo_box_fill): Remove debug code that showed the
898 provider ID in the combo.
900 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
901 Do not show the page numbers, because it would be confusing when we add
902 the 2 extra pages for the custom setup, when the user chooses the "Other"
903 provider. This fixes projects.maemo.org bug NB#59028
905 * src/modest-init.c: (modest_init_init_core),
906 (modest_init_local_folders):
908 * src/modest-tny-account.c:
909 (modest_tny_account_new_for_local_folders): Do not create default folders
910 for the memory card. This should fix projects.maemo.org bug NB#59328.
912 2007-06-11 Murray Cumming <murrayc@murrayc.com>
914 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
915 Free the changed_conf_keys string items. They are already freed in the
916 idle handler if that runs first.
918 2007-06-11 Murray Cumming <murrayc@murrayc.com>
920 * src/modest-ui-actions.c:
921 (modest_ui_actions_on_password_requested): Check that the server name
922 is not NULL, because I just saw a password dialog with (null) as the
925 * src/modest-tny-folder.[h|c]: Added
926 modest_tny_folder_is_memory_card_folder().
927 * src/modest-ui-dimming-rules.c:
928 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
929 menu item for memory cards, as per the UI spec (section 7.4). This should
930 fix projects.maemo.org bug NB#59297.
932 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
934 * src/maemo/modest-main-window.c: (sync_accounts_cb):
935 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
936 is another problem with the code, see Murray's comment at line 772)
938 2007-06-08 Murray Cumming <murrayc@murrayc.com>
940 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
941 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
942 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
943 (load_from_file), (easysetup_country_combo_box_init),
944 (easysetup_country_combo_box_get_active_country_ids),
945 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
946 instead of just one ID, to avoid duplicate country names in the UI.
948 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
949 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
950 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
951 a single ID, avoiding duplicate providers.
952 * src/maemo/easysetup/modest-easysetup-wizard.c:
953 (on_combo_account_country): Adapt to use a list.
955 2007-06-08 Murray Cumming <murrayc@murrayc.com>
957 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
958 keys changed in the last X seconds.
960 * src/modest-account-mgr.h:
961 * src/modest-account-mgr.c: (on_timeout_notify_changes),
962 (on_key_change), (modest_account_mgr_class_init),
963 (modest_account_mgr_init), (modest_account_mgr_finalize):
964 As the keys are changed, save them in a GSList* and signal that GSList*
965 further every X seconds, to batch changes, to allow us to do just one
966 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
967 bug NB#56941 and other (UI-blocking) delays when changing account settings.
969 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
970 changed signal signature.
972 * src/modest-conf.c: (modest_conf_set_list),
973 (modest_conf_on_change): Reenable notification.
975 (modest_conf_maemo_fake_on_change): Comment out the hack that
976 notified immediately instead of asynchronously.
978 * src/widgets/modest-account-view.h:
979 * src/widgets/modest-account-view.c:
980 (update_account_view): Select the previously-selected account ID,
981 if possible. This fixes projects.maemo.org bug NB#56933.
983 (on_account_changed), (on_account_removed),
984 (modest_account_view_select_account):
986 Remove the block/unblock functions
987 because they were not useful.
989 * src/maemo/modest-account-view-window.c:
990 (on_delete_button_clicked), (on_edit_button_clicked),
991 (on_new_button_clicked): Remove the use of the non-working block/unblock.
993 2007-06-08 Murray Cumming <murrayc@murrayc.com>
995 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
996 Improve the error dialog to show Incorrect Account Settings, which seems
997 clearer, and say that the internal error message (to be removed from the
998 dialog later) is often misleading.
999 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1001 * src/modest-tny-account.c:
1002 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1003 URL because this is so useful for debugging on the device.
1005 * src/widgets/modest-serversecurity-combo-box.c:
1006 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1008 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1010 * src/modest-mail-operation.c:
1011 (modest_mail_operation_send_new_mail):
1012 Added a comment about a nasty but apparently harmless message. Details
1013 added to the wiki g_warnings() page.
1015 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1017 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1018 (modest_tny_send_queue_class_init):
1019 Do not use the priv struct because it is empty, to avoid g_warnings
1020 about a non-existant priv struct.
1022 * src/modest-tny-account-store.c:
1023 (modest_tny_account_store_get_server_account),
1024 (modest_tny_account_store_get_transport_account_for_open_connection
1025 ): Do not try to get transport server accounts for local folders,
1026 because they don't have any. This avoids a g_warning().
1028 * src/maemo/modest-main-window.c:
1029 (modest_main_window_notify_send_receive_initied),
1030 (on_configuration_key_changed):
1031 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1032 * src/modest-defs.h:
1033 * src/modest-mail-operation.c:
1034 (modest_mail_operation_update_account):
1035 * src/modest-tny-account-store.h:
1036 * src/modest-tny-account.c:
1037 (modest_tny_account_get_special_folder),
1038 (modest_tny_account_new_for_local_folders),
1039 (modest_tny_account_new_for_per_account_local_outbox_folder):
1040 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1041 * src/modest-tny-local-folders-account.c:
1042 (add_account_folders_to_merged_folder):
1043 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1044 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1045 (modest_ui_actions_on_send):
1046 * src/widgets/modest-folder-view.c: (update_model):
1047 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1048 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1049 modest_tny_account_store_get_tny_account_by_account() to
1050 modest_tny_account_store_get_server_account() to make the code clearer.
1052 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1054 * src/dbus_api/modest-dbus-api.h:
1055 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1056 * src/maemo/modest-msg-edit-window.c:
1057 (modest_msg_edit_window_attach_file_noninteractive):
1058 added g_warning in case the file to be attached does not exist
1059 * tests/dbus_api/test_compose_mail.c: (main):
1060 removed obsolete comment, added generic files as test case
1062 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1064 * src/modest-tny-account-store.c: (get_server_accounts):
1065 Create the local folders account only once, not once for each outbox, and
1066 not only when there are some outboxes.
1068 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1070 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1071 code that is causing a crash at startup. Sergio says that he is fixing this.
1073 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1075 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1076 * src/maemo/modest-account-settings-dialog.c:
1077 (create_page_outgoing),
1078 (modest_account_settings_dialog_set_account_name),
1079 (save_configuration):
1080 - Fixed handling of the "Use secure authentication" toggle to comply with
1081 the ui specification. See also projects.maemo.org bug NB#58400
1083 - Restore the Secure connection setting combo correctly when loading
1086 * src/maemo/modest-maemo-utils.c:
1087 (on_camel_account_get_supported_secure_authentication),
1088 (modest_maemo_utils_get_supported_secure_authentication_methods):
1089 Fixed a crasher if operation is canceled
1091 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1092 (modest_protocol_info_auth_is_secure):
1093 * src/modest-protocol-info.h:
1095 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1096 the sense of the "Use secure authentication" toggle.
1098 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1100 * src/modest-tny-account-store.h:
1101 * src/modest-tny-account-store.c:
1102 Added modest_tny_account_store_get_local_folders_account().
1104 * src/modest-tny-folder.h:
1105 * src/modest-tny-folder.c:
1106 (modest_tny_folder_get_account):
1107 Added this replacement for tny_folder_get_account() which returns
1108 the local-folders account for TnyMergeFolders, to avoid the
1109 warning about the unimplemented get_account_func() vfunc().
1111 (modest_tny_folder_get_rules),
1112 * src/modest-ui-actions.c:
1113 (modest_ui_actions_on_folder_selection_changed):
1114 * src/modest-mail-operation.c:
1115 (modest_mail_operation_remove_folder),
1116 (modest_mail_operation_xfer_folder),
1117 (modest_mail_operation_rename_folder),
1118 (modest_mail_operation_get_msg),
1119 (modest_mail_operation_get_msgs_full),
1120 (modest_mail_operation_remove_msg),
1121 (modest_mail_operation_xfer_msgs),
1122 (modest_mail_operation_refresh_folder):
1123 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1125 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1127 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1128 (modest_server_account_set_security):
1129 * src/modest-defs.h: Add comments explaining that our
1130 UI spec means TLS when it says Normal, so these do not look like errors.
1132 * src/modest-tny-account.c:
1133 (modest_tny_account_new_from_server_account): Use the new tinymail
1134 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1135 for TLS. This should fix projects.maemo.org bug NB#58460.
1137 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1139 * src/maemo/easysetup/modest-easysetup-wizard.c:
1140 (create_account): Correct the position of the gconf sanity check warning.
1141 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1142 of using the g_idle_add() hack, because this does not seem to be necessary
1143 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1144 caused by something other than maemo's gconf.
1145 This fixes projects.maemo.org bug #59022.
1147 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1149 * src/modest-account-mgr-helpers.c:
1150 (modest_account_mgr_get_default_account): Do not check that the account
1151 exists if there is no default account (NULL), to fix a runtime warning.
1153 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1155 * src/widgets/modest-folder-view.c: (update_model):
1156 Do not unref the treemodel before we have finished with it.
1157 This prevents a valgrind warning and an occasional crash at startup.
1159 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1161 * libmodest-dbus-client/libmodest-dbus-client.h:
1162 added libmodest_dbus_client_compose_mail()
1163 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1165 added functions needed for SendAsMail() functionality
1166 * src/maemo/modest-msg-edit-window.c:
1167 (modest_msg_edit_window_attach_file_noninteractive):
1168 non interactively attaching files to message edit window
1169 * src/widgets/modest-msg-edit-window.h:
1170 * tests/dbus_api/Makefile.am:
1171 added test_compose_mail.c
1172 * tests/dbus_api/test_compose_mail.c: (main):
1174 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1176 * src/modest-account-view.c:
1177 Fixed bug projects.maemo.org bug NB#59307
1179 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1181 * src/maemo/easysetup/modest-easysetup-wizard.c:
1182 (get_serverport_incoming), (on_before_next), (create_account):
1183 * src/maemo/modest-account-settings-dialog.c:
1184 (modest_account_settings_dialog_set_account_name):
1185 * src/maemo/modest-maemo-utils.c:
1186 (on_camel_account_get_supported_secure_authentication_status),
1187 (on_camel_account_get_supported_secure_authentication),
1188 (on_secure_auth_cancel),
1189 (modest_maemo_utils_get_supported_secure_authentication_methods):
1191 Implemented security authentication for settings and easysetup.
1193 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1195 * src/maemo/modest-main-window.c: (create_details_widget):
1196 Show the total size for memory card accounts too, instead of showing
1197 the name again. Fixes bug projects.maemo.org bug NB#59307.
1199 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1202 * src/modest-tny-simple-folder-store.c:
1203 * src/modest-tny-simple-folder-store.h: Removed.
1205 * src/modest-tny-local-folders-account.h
1206 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1207 for the local-folders maildir, with an extra TnyMergedFolder containing
1208 the folders of the per-account outbox store accounts.
1209 * src/modest-tny-account-store.c: (get_server_accounts):
1210 Add the outboxes to the special local folders account after creating it.
1212 * src/modest-tny-account.c:
1213 (modest_tny_account_new_for_local_folders): Create the derived
1214 account when creating the main local-folders account.
1216 * src/maemo/modest-main-window.c: (create_details_widget),
1217 (modest_main_window_set_contents_style):
1218 Adapted to the use of the derived account instead of the folder store.
1220 * src/modest-ui-actions.c:
1221 (modest_ui_actions_on_folder_selection_changed):
1222 * src/modest-ui-dimming-rules.c:
1223 (modest_ui_dimming_rules_on_new_folder):
1224 * src/widgets/modest-folder-view.c: (text_cell_data),
1225 (icon_cell_data), (filter_row), (update_model),
1226 (get_cmp_rows_type_pos):
1229 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1230 Do not get the priv struct, because no priv struct has been set,
1231 to avoid a runtime warning.
1233 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1234 #ifelse with #else, to fix a warning, to fix the build.
1237 2007-06-05 Christian Kellner <ckellner@openismus.com>
1239 * libmodest-dbus-client/libmodest-dbus-client.c:
1240 Fix small typo in doc (why do you always see them
1241 AFTER committing stuff?)
1244 2007-06-05 Christian Kellner <ckellner@openismus.com>
1246 * libmodest-dbus-client/libmodest-dbus-client.c:
1247 (libmodest_dbus_client_search):
1248 Initialize hit list with NULL. Also set folder list
1249 to "" if NULL was supplied.
1252 2007-06-03 Christian Kellner <ckellner@openismus.com>
1254 * libmodest-dbus-client/libmodest-dbus-client.c:
1255 (modest_search_hit_list_free):
1256 Make it save to call it with NULL.
1258 * src/dbus_api/modest-dbus-callbacks.c:
1259 * src/modest-search.c:
1260 Return full ModestSearchHits as the search result list not TnyHeader
1261 since can't be around withouth the correspoding TnyFolder.
1263 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1265 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1266 Added currently commented code to check for secure auth
1268 * src/maemo/modest-account-settings-dialog.c: (on_response),
1269 (save_configuration), (show_ok):
1270 Fixed projects.maemo.org bugs NB #59248 and #59251
1272 * src/maemo/modest-maemo-utils.c:
1273 (on_camel_account_get_supported_secure_authentication_status),
1274 (on_camel_account_get_supported_secure_authentication),
1275 (modest_maemo_utils_get_supported_secure_authentication_methods):
1276 * src/maemo/modest-maemo-utils.h:
1277 Moved get_supported_secure_authentication() method here to be able
1278 to use it from easysetup wizard.
1280 * src/modest-pair.c: (on_pair_compare_as_string):
1281 Should compare string with first part of pair and not
1282 strcmp pairs which will crash.
1284 * src/modest-protocol-info.c:
1285 (modest_protocol_info_protocol_is_store):
1286 * src/modest-protocol-info.h:
1287 Added modest_protocol_info_get_auth_protocol_name()
1289 2007-06-03 Armin Burgmeier <armin@openismus.com>
1291 * src/modest-mail-operation.c:
1292 (modest_mail_operation_get_msgs_full): Set priv->account also when
1293 only retrieving a single message. This avoids a crash when canceling
1296 (modest_mail_operation_notify_end): Do not explicitely remove the
1297 operation from the queue but only emit the progress_changed signal.
1298 The queue itself listens to that signal to remove the operation when
1299 it is finished. This reduces coupling and removes a potential deadlock
1300 when modest_mail_operation_notify_end() is called from the queue
1301 itself. If that is a problem performance-wise, I would suggest to
1302 implement a status-changed signal or something.
1304 * src/modest-mail-operation-queue.c: Make sure to never call a
1305 function from another file while the queue is locked. This (hopefully)
1306 fixes another deadlock when exiting the application while retrieving
1309 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1311 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1312 Fixed build if libogs is not available
1314 2007-06-03 Christian Kellner <ckellner@openismus.com>
1316 * libmodest-dbus-client/libmodest-dbus-client.h:
1317 * libmodest-dbus-client/libmodest-dbus-client.c:
1318 (libmodest_dbus_client_delete_message):
1319 Implement deletion of messages (Client side).
1321 (modest_search_hit_free),
1322 (modest_search_hit_list_free):
1323 Utility functions to free the result hits.
1325 * src/dbus_api/modest-dbus-api.h:
1326 * src/dbus_api/modest-dbus-callbacks.c:
1327 (on_delete_message),
1328 (modest_dbus_req_handler):
1329 Implement deletion of messages (Server side).
1331 * tests/dbus_api/test_search.c: (main):
1334 * tests/dbus_api/Makefile.am:
1335 * tests/dbus_api/test_delete_message:
1336 Add little test for the message deletion logic
1338 2007-06-03 Armin Burgmeier <armin@openismus.com>
1340 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1341 when the operation queue was not empty. projects.maemo.org bug
1344 2007-06-03 Armin Burgmeier <armin@openismus.com>
1346 * src/widgets/modest-account-view.c
1347 (on_account_default_toggled): Toggle default account column
1348 explicitely instead of waiting for gconf notification (which is
1349 currently ignored). This should fix projects.maemo.org bug NB#56910
1350 for now. It should probably be removed when gconf notifications are
1353 2007-06-03 Christian Kellner <ckellner@openismus.com>
1355 * libmodest-dbus-client/libmodest-dbus-client.c:
1356 Removed debugging spew.
1358 * src/dbus_api/modest-dbus-callbacks.c:
1359 Added debugging info.
1361 * src/modest-search.c:
1362 (modest_search_all_accounts):
1363 Use tny_account_store_get_accounts () on the account store
1364 to get all accounts which is the way to get all accounts.
1366 * tests/dbus_api/test_search.c: (main):
1367 Make it possible to supply the search term on the command line.
1369 2007-06-03 Christian Kellner <ckellner@openismus.com>
1371 * libmodest-dbus-client/libmodest-dbus-client.c:
1372 * libmodest-dbus-client/libmodest-dbus-client.h:
1373 Implement searching for mesages over raw dbus. (Client side)
1375 * src/dbus_api/Makefile.am:
1376 * src/dbus_api/modest-dbus-api.h:
1377 * src/dbus_api/modest-dbus-callbacks.c:
1378 * src/dbus_api/modest-dbus-callbacks.h:
1379 Search framework (Server side). Also implement on_idle_open_message().
1381 * src/maemo/modest-platform.c: (modest_platform_init):
1382 Prepare for raw dbus/osso rpc interaction.
1384 * src/modest-search.h:
1385 Changed minsize from unspecific guint to guint32.
1387 * src/modest-search.c:
1389 Added strange hack which magically made tnymail work.
1391 (modest_search_folder),
1392 (modest_search_account),
1393 (modest_search_all_accounts):
1394 Implement helper functions to search all accounts, specific account
1397 * tests/dbus_api/Makefile.am:
1398 * tests/dbus_api/test_open_message.c:
1399 Read url to open from commandline.
1401 * tests/dbus_api/test_search.c:
1402 Implement small test for dbus search stuff
1404 2007-06-02 Armin Burgmeier <armin@openismus.com>
1406 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1407 include account type and account title. This fixes projects.maemo.org
1410 * src/maemo/modest-account-view-window.c: Set a title for the window.
1412 2007-06-02 Armin Burgmeier <armin@openismus.com>
1414 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1415 incoming and outgoing server name based on email address and server
1416 types as long as the names have not been edited manually. This fixes
1417 projects.maemo.org bug NB#58671.
1419 2007-06-02 Armin Burgmeier <armin@openismus.com>
1421 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1422 server type cannot be changed in future to the incoming details page
1423 when creating an account. This fixes projects.maemo.org bug NB#59029.
1425 2007-06-02 Armin Burgmeier <armin@openismus.com>
1427 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1428 and assigned max width chars so that they wrap instead of being
1429 truncated. Fixes projects.maemo.org bug NB#56126.
1431 2007-06-02 Armin Burgmeier <armin@openismus.com>
1433 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1434 introductory note to the connection specific smtp servers dialog, as
1435 section 8.12 of the email UI specification requires. This fixes
1436 projects.maemo.org bug NB#59212.
1438 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1440 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1441 Check for running mail operations, and offer to cancel them, as per the UI
1442 spec. This fixes projects.maemo.org bug NB#59041 .
1443 However, I suspect that tinymail may still use the network connection
1444 in ways that we cannot detect or cancel. But it should at least adapt to
1445 changes fairly well.
1447 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1449 * src/modest-tny-account-store.c: (recreate_all_accounts),
1450 (get_cached_accounts), (get_server_accounts): Do more sensible
1451 ref-counting of the temporarily-cached outbox accounts list. This seems
1452 to fix a crash when entering the password when the password was wrong.
1454 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1456 * src/gnome/modest-main-window.c: (connect_signals):
1457 * src/modest-tny-account-store.c: (get_password),
1458 (modest_tny_account_store_alert): Added comments and clues and
1459 commented-out code about how we currently fail to deal with connection
1460 errors and wrong passwords, and how we should.
1462 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1464 * src/widgets/modest-retrieve-combo-box.c:
1465 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1466 This fixes projects.maemo.org bug NB#58472 .
1468 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1470 * src/maemo/easysetup/modest-easysetup-wizard.c:
1471 (create_page_complete_easysetup):
1472 (create_page_complete_custom): Correct the last commit,
1473 putting the correct sentences in the correct pages.
1475 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1477 * src/maemo/easysetup/modest-easysetup-wizard.c:
1478 (create_page_complete_custom): Show the second sentence of text
1479 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1482 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1484 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1485 Set the leave-on-server conf key by default. This fixes
1486 projects.maemo.org bug NB#59258 .
1488 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1490 * src/maemo/modest-account-view-window.c:
1491 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1492 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1495 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1497 * src/maemo/easysetup/modest-easysetup-wizard.c:
1498 (create_caption_new_with_asterisk):
1499 * src/maemo/modest-account-settings-dialog.c:
1500 (create_caption_new_with_asterisk):
1501 Uncomment the code to add the asterisk, because they are no longer in the
1502 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1503 (update_incoming_server_title): Add an asterisk here too.
1505 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1507 * src/maemo/modest-maemo-global-settings-dialog.c:
1508 (current_connection): Check that we are even connected before trying to
1509 get the current connection name, to prevent a warning.
1511 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1512 Change the comments because tny_maemo_conic_device_connect() is now meant to
1514 * src/modest-mail-operation.c:
1515 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1516 make sure we have a connection and fail if we can't connect.
1518 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1520 * src/maemo/modest-main-window.c:
1521 (on_account_store_connecting_finished): Do not try to get the
1522 connection ID if we are not really connected. I am surprised that
1523 this signal handler is called when we are not connected.
1525 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1527 * src/modest-error.h:
1528 * src/modest-ui-actions.c:
1529 (modest_ui_actions_get_msgs_full_error_handler):
1530 Renamed an enum, added comments, added an enum
1531 for retrieve-limit errors.
1533 * src/modest-mail-operation.c: (foreach_add_item),
1534 (internal_folder_observer_update), (update_account_thread),
1535 (modest_mail_operation_get_msgs_full):
1536 (modest_mail_operation_update_account),
1537 Added comments about how this works, and some code that should
1538 (but does not) check the retrieve-limit. See the TODO comment.
1540 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1542 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1543 Initialize help_id to fix the build. Warnings are good.
1545 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1547 * src/widgets/modest-hbox-cell-renderer.c:
1548 (modest_hbox_cell_renderer_append):
1549 * src/widgets/modest-vbox-cell-renderer.c:
1550 (modest_vbox_cell_renderer_append):
1551 Fix the last commit by doing an extra ref.
1553 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1555 * src/widgets/modest-hbox-cell-renderer.c:
1556 (modest_hbox_cell_renderer_append):
1557 * src/widgets/modest-vbox-cell-renderer.c:
1558 (modest_vbox_cell_renderer_append):
1559 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1560 to fix the build with Maemo Bora.
1561 However, there seems to be a remaining crash, probably due to reference
1564 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1566 * src/modest-tny-account.c:
1567 (modest_tny_account_new_for_local_folders):
1568 Use hildon_file_system_info_async_new() to get a better name for
1569 the memory card account, setting it as the account name.
1570 The timing seems to work, but this is probably
1571 not the best place to do this. See the TODO comment.
1572 * src/maemo/modest-main-window.c: (create_details_widget):
1573 * src/widgets/modest-folder-view.c: (text_cell_data):
1574 Use the tny account name instead of hardcoding a name.
1576 2007-05-30 Christian Kellner <ckellner@openismus.com>
1578 * src/modest-search.c: (modest_search):
1579 Correctly set part_search_func even if we have already parsed
1580 the query and thus a valid OgsTextSearcher object.
1582 2007-05-30 Christian Kellner <ckellner@openismus.com>
1585 Search and check for libogs.
1588 Incooparte the ogs build env.
1590 * src/modest-mime-part-search-stream.c:
1591 * src/modest-mime-part-search-stream.h:
1592 Removed since we do the real searching now in modest-search.c.
1594 * src/modest-search.c:
1595 * src/modest-search.h:
1596 Implement support for ogs. We use that if available and requested
1597 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1598 should now handle the corner case when the search term is spread
1599 across multiple reads.
1600 Also the logic in modest_search () was corrected to search all
1601 requested fields until one is found.
1603 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1605 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1607 * src/modest-init.h:
1608 * src/modest-init.c: Made modest_init_local_folders() take a
1609 path and be public so we can iniitialize maildir folders on
1612 * src/modest-local-folder-info.h:
1613 * src/modest-local-folder-info.c:
1614 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1616 * src/modest-tny-account.c:
1617 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1618 still means the standard local-folders path on the local volume.
1620 * src/modest-tny-account-store.c:
1621 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1622 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1623 all accounts when that happens.
1624 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1625 this too, so it shows up in the treeview.
1627 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1629 * src/maemo/modest-maemo-global-settings-dialog.c:
1630 (current_connection):
1631 * src/widgets/modest-global-settings-dialog.c:
1632 (current_connection_default):
1633 Use the enum values instead of 0, 1 and -1,
1634 to make the code clearer.
1636 * src/modest-account-mgr-helpers.c:
1637 (modest_account_mgr_get_connection_specific_smtp): Make this code
1640 * src/modest-runtime.h:
1641 * src/modest-runtime.c:
1642 Added modest_runtime_remove_all_send_queues().
1643 * src/maemo/modest-main-window.c:
1644 (on_account_store_connecting_finished): Recreate the send queues,
1645 using the appropriate transport accounts for this new connection.
1646 Some futher adapting might be needed if the old send queues are not
1647 automatically stopped at this point.
1649 * src/modest-tny-account-store.c: (get_server_accounts):
1650 Create the connection-specific transport accounts, so that they can
1651 be found later by their ID.
1653 * src/modest-tny-account.h:
1654 * src/modest-tny-account.c:
1655 Added modest_tny_account_new_from_server_account_name().
1656 modest_tny_account_new_from_server_account(): Do not create the
1657 send queues here, because they will be
1658 recreated anyway when the connection changes for the first time.
1660 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1662 * src/modest-local-folder-info.h:
1663 * src/modest-local-folder-info.c:
1664 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1665 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1666 tbox_folder): Take a modest account name instead of a server TnyAccount,
1667 so we can have per-modest-account rather than per-transport-account
1669 We must make sure that we change or recreate the exisitng send queues
1670 when the connection changes for connection-specific transport accounts.
1672 * src/modest-tny-account-store.c:
1673 (create_per_account_local_outbox_folders): Create outboxed per modest
1674 account, not per transport account.
1676 * src/modest-tny-account.h:
1677 * src/modest-tny-account.c:
1678 (modest_tny_account_get_special_folder): For outboxes, get the
1679 parent modest account name. The account is ignored for other folders.
1680 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1681 modest account name rather than a server TnyAccount.
1683 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1685 * src/modest-tny-account.c:
1686 (modest_tny_account_new_from_server_account):
1687 Call modest_runtime_get_send_queue() immediately after creating transport
1688 accounts, so that they start trying to send email from the outbox as soon
1689 as possible at startup. This is probably what we want.
1691 * src/modest-mail-operation.c: (update_account_thread):
1692 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1693 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1694 * src/modest-tny-send-queue.h:
1695 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1696 (modest_ui_actions_on_send):
1697 Added comments about how sending works, though it needs some more work.
1699 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1701 * src/modest-tny-account.c:
1702 (modest_tny_account_get_special_folder): Add TODO because this fails when
1703 the network is busy.
1704 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1705 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1706 Do not try to show this window when there is no active account. The UI
1707 specs does not tell us what to do in this case.
1709 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1713 * src/maemo/Makefile.am:
1714 * src/widgets/Makefile.am: Some dist fixes.
1716 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1718 * src/maemo/modest-connection-specific-smtp-window.c:
1719 (on_button_edit): Make the code clearer, to prevent a double free.
1721 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1723 * src/maemo/modest-account-settings-dialog.c:
1724 (modest_account_settings_dialog_set_account_name),
1725 Check the connection-specific smtp servers checkbox if there are any.
1727 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1728 (modest_connection_specific_smtp_edit_window_init):
1729 Start with a suitable port number.
1731 * src/modest-account-mgr-helpers.h:
1732 * src/modest-account-mgr-helpers.c: Added
1733 modest_account_mgr_get_has_connection_specific_smtp().
1735 (modest_account_mgr_set_connection_specific_smtp),
1736 (modest_account_mgr_remove_connection_specific_smtp),
1737 (modest_account_mgr_get_has_connection_specific_smtp),
1738 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1739 connection-specific smtp server accounts in the account, rather than
1740 the server account conf dir.
1742 This fixes bug projects.maemo.org bug NB#58263 .
1744 * src/modest-tny-account-store.c:
1745 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1746 if there are no server accounts yet, to prevent an infinite loop when there
1747 are no accounts. Document that one must be called before the other.
1749 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1751 * src/modest-account-mgr-helpers.c:
1752 (modest_account_mgr_get_default_account): Make sure that at least
1753 one account is always the default, if there are any enabled accounts.
1754 This is just a sanity check that shouldn't be necessary.
1756 * src/modest-account-mgr-priv.c:
1757 (_modest_account_mgr_account_from_key): Unescape the conf key to
1758 get the real account name. For instance, this is an issue if a space
1759 was in the account name, which can happen because the account name
1760 is generated from the display name.
1761 (_modest_account_mgr_get_account_keyname): Always escape the
1763 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1764 Unescape the conf keys to get the real account names.
1766 For instance, previously the is-default radio button in the accounts
1767 list was not checked for any accounts at first. This fixes that,
1768 and might fix several similar bugs.
1770 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1772 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1773 Removed some debug printfs.
1775 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1777 Modest on-disk outbox directories are now here, for instance:
1778 $HOME/.modest/outboxes/<account-id-1>/outbox
1779 $HOME/.modest/outboxes/<account-id-2>/outbox
1781 $HOME/.modest/local-folders/outbox
1782 so we can have a separate outbox for each account.
1783 But they are shown as one outbox in the GtkTreeView, by using a
1784 TnyMergeFolder in a ModestTnySimpleFolderStore.
1787 * src/modest-tny-simple-folder-store.c:
1788 * src/modest-tny-simple-folder-store.h:
1789 Added ModestTnySimpleFolderStore, used to contain folders from
1790 other folder stores, such as other accounts.
1792 * src/modest-tny-outbox-account.h:
1793 * src/modest-tny-outbox-account.c:
1794 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1795 used for the per-account local outbox folders.
1797 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1798 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1799 only use this (internally) now for the non-outbox local folders.
1801 * src/modest-init.h:
1802 * src/modest-init.c: Added modest_init_one_local_folder(), for
1803 setting up the directory structure for each local folder.
1805 * src/modest-local-folder-info.c:
1806 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1807 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1809 * src/modest-local-folder-info.h:
1810 * src/modest-tny-account-store.c: (on_account_removed),
1811 (on_account_changed), (create_per_account_local_outbox_folders),
1812 (get_server_accounts), (modest_tny_account_store_get_accounts),
1813 (modest_tny_account_store_get_tny_account_by_account),
1814 (modest_tny_folder_store_is_virtual_local_folders):
1816 * src/modest-tny-account.h:
1817 * src/modest-tny-account.c:
1818 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1819 to create an on-disk per-account local outbox folder for each
1821 (create_per_account_local_outbox_folders): Create a local outbox folder
1822 for each transport account.
1823 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1824 for all local folders.
1826 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1827 instead of using g_object_get/set() directly. It is clearer.
1829 (modest_tny_folder_store_get_message_count),
1830 (modest_tny_folder_store_get_local_size
1831 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1832 because we now use these with non-acount folder stores.
1834 (modest_tny_account_get_special_folder),
1835 (modest_tny_account_new_from_server_account),
1836 (modest_tny_account_new_from_account):
1837 (recurse_folders): Adjust to the new outbox system.
1839 * src/modest-tny-folder.h:
1840 * src/modest-tny-folder.c:
1841 (modest_tny_folder_is_local_folder),
1842 (modest_tny_folder_get_local_folder_type),
1843 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1845 * src/widgets/modest-main-window.h:
1846 * src/maemo/modest-main-window.c: (create_details_widget),
1847 (modest_main_window_set_contents_style): Show details for any folder store,
1850 (modest_tny_folder_get_rules):
1851 Remove the const. C does not support constness enough for this.
1853 * src/modest-ui-actions.c:
1854 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1855 make all outboxes appear as one, in the usual local-folders tree node.
1857 (set_active_account_from_tny_account),
1858 (modest_ui_actions_on_folder_selection_changed):
1859 * src/widgets/modest-folder-view.c: (text_cell_data),
1860 (icon_cell_data), (filter_row),
1861 (add_account_folders_to_merged_folder),
1862 (add_account_folders_to_simple_folder_store), (),
1863 (get_cmp_rows_type_pos), (cmp_rows),
1864 (modest_folder_view_set_account_id_of_visible_server_account):
1865 Adjust to the new outbox system, using generic folder stores and folders
1866 in the GtkTreeModel.
1868 2007-05-23 Christian Kellner <ckellner@openismus.com>
1870 * src/modest-mail-operation.c:
1871 (modest_mail_operation_update_account):
1872 Use info->max_size instead of unintialized local var [small
1873 build fix]. (Added TODO to review that change since I don't
1876 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1878 * libmodest-dbus-client/libmodest-dbus-client.c:
1879 (libmodest_dbus_client_compose_mail): function added
1880 * src/dbus_api/modest-dbus-api.h:
1881 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1882 (on_compose_mail): Implementation of the SendAsMail functionality
1884 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1886 * src/modest-account-mgr.c:
1887 (modest_account_mgr_add_server_account): Set the secure-connection
1888 conf key for transport accounts as well as store accounts. I don't know
1889 why the if was there. For instance, this makes sure that we use SSL
1890 for the gmail preset from the easysetup wizard.
1892 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1894 * src/gnome/modest-main-window.c:
1895 (on_account_store_connecting_finished), (connect_signals):
1896 * src/maemo/modest-main-window.c:
1897 (on_account_store_connecting_finished), (connect_signals),
1898 (modest_main_window_new):
1899 Handle TnyAccountStore::connecting-finished instead of
1900 TnyDevice::connection-changed, because we cannot actually perform
1901 operations on accounts until TnyAccountStore has itself responded to
1902 the TnyDevice::connection-changed signal. This prevents a GError from
1904 Do not try to update at startup, because we (at least on scratchbox)
1905 already do an update at startup when the device goes online.
1906 This prevents a GError from tinymail.
1907 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1908 Added TODO about stopping simultaneous operations.
1910 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1912 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1913 * src/modest-mail-operation-queue.c:
1914 (modest_mail_operation_queue_remove):
1915 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1916 about where they happened.
1918 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1920 * src/modest-ui-actions.c:
1921 (modest_ui_actions_on_password_requested): Make sure that the remember
1922 output parameter is always TRUE.
1924 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1926 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1927 Show a OK/Cancel dialog if the error is a question, though we still do not
1928 know anything more about what we are asking the user.
1929 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1930 Fix an uninitialized variable (helper). This is a logic error, however.
1932 2007-05-21 Christian Kellner <ckellner@openismus.com>
1934 * src/modest-search.h:
1935 Correct bit shifting in the ModestSearchFlags enum.
1937 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1939 * src/modest-tny-account.c:
1940 (modest_tny_account_new_from_server_account): Do not use the lsub and
1941 check-all hard-coded IMAP options when using POP.
1943 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1945 * src/modest-tny-account.c:
1946 (modest_tny_account_new_from_server_account):
1947 Use NULL for the secure-auth method for POP when Password auth has been
1948 specified by the user, as we already do for IMAP. "auth=Login" causes
1949 an error from camel or the server.
1951 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1953 * src/maemo/modest-account-settings-dialog.c:
1954 (create_page_account_details),
1955 (modest_account_settings_dialog_set_account_name):
1956 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1957 for the leave-on-server checkbox, rathr than just the checkbox, when
1958 the protocol is not POP.
1960 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1962 * src/widgets/modest-account-view.c:
1963 * src/widgets/modest-account-view.h:
1964 Added modest_account_view_select_account() which will be useful later
1965 to asynchronously re-select the edited account.
1967 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1969 * src/maemo/modest-account-settings-dialog.c:
1970 (modest_account_settings_dialog_set_account_name):
1971 Automatically choose the port numbers based on the secure authentication
1972 methods, if they have not been chosen before.
1973 This fixes projects.maemo.org bug NB#56273 .
1975 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1977 * src/maemo/modest-main-window-ui.h:
1978 * src/modest-ui-actions.c:
1979 * src/modest-ui-actions.h:
1980 Connect the Tools/SMTP Servers menu item to
1981 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1982 SMTP servers dialog, as in the UI specification and saves changes when it
1983 is closed. This fixed projects.maemo.org bug NB#56305 .
1985 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1987 * src/maemo/modest-connection-specific-smtp-window.c:
1988 (modest_connection_specific_smtp_window_init):
1989 Use gtk_window_set_default_size() to make this window big enough, so
1990 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1992 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1994 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1995 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1996 (modest_connection_specific_smtp_edit_window_init),
1997 Do not try to connect to a combobox signal before the combobox exists.
1998 This fixes the cras in projects.maemo.org bug NB#56288 .
1999 (modest_connection_specific_smtp_edit_window_get_settings):
2000 Remove the server_account_name parameter which was being checked for NULL
2001 though it was not used.
2003 * src/maemo/modest-connection-specific-smtp-window.c:
2004 (modest_connection_specific_smtp_window_fill_with_connections),
2005 (on_button_edit), (modest_connection_specific_smtp_window_init):
2006 Correct the number of treemodel columns to prevent a warning.
2007 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2008 libconic does not work.
2010 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2012 * src/modest-tny-account.c:
2013 (modest_tny_account_new_from_server_account):
2014 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2015 SMTP when "None" was chosen by the user. However, with my SMTP server that
2016 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2019 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2021 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2022 to explain the memory management issue with the ID in the ModestPair.
2024 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2025 (add_sending_page), (modest_account_assistant_finalize):
2026 * src/gnome/modest-gnome-global-settings-dialog.c:
2027 (create_updating_page), (create_composing_page):
2028 * src/gnome/modest-msg-edit-window.c: (get_transports),
2029 (init_window), (modest_msg_edit_window_finalize),
2030 (modest_msg_edit_window_get_msg_data):
2031 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2032 * src/gnome/modest-transport-widget.c:
2033 (modest_transport_widget_finalize), (smtp_configuration):
2034 * src/maemo/modest-maemo-global-settings-dialog.c:
2035 (create_updating_page), (create_composing_page):
2036 * src/maemo/modest-msg-edit-window.c: (get_transports),
2037 (init_window), (modest_msg_edit_window_finalize),
2038 (modest_msg_edit_window_get_msg_data),
2039 (modest_msg_edit_window_free_msg_data):
2040 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2041 (modest_store_widget_finalize):
2042 * src/maemo/modest-transport-widget.c:
2043 (modest_transport_widget_finalize), (smtp_configuration):
2044 * src/modest-main.c: (send_mail):
2045 * src/widgets/modest-combo-box.h:
2046 * src/widgets/modest-global-settings-dialog-priv.h:
2047 * src/widgets/modest-global-settings-dialog.c:
2048 (modest_global_settings_dialog_finalize):
2049 * src/widgets/modest-msg-edit-window.h:
2050 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2051 as long as the combo box, to prevent use of freed memory for the ID.
2053 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2055 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2056 get_accounts(), to make this clearer. Do not check for the enabled gconf
2057 key, because we do not use this for server accounts (at least, not yet).
2058 This allows us to send email again.
2060 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2062 * src/maemo/modest-platform.c:
2063 (on_modest_conf_update_interval_changed), (modest_platform_init):
2064 Only respond to this particular key change. All these strcmp()s cannot be
2067 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2069 * src/maemo/modest-maemo-global-settings-dialog.c:
2070 (current_connection): Prevent a crash in scratchbox when
2071 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2072 * src/maemo/modest-platform.c:
2073 (on_modest_conf_update_interval_changed), (modest_platform_init):
2074 Get the update interval from gconf and reset it when the gconf key changes.
2076 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2078 * src/modest-protocol-info.c:
2079 * src/modest-protocol-info.h: Adde enum-specific get functions,
2080 instead of using a ModestProtocolType enum parameter.
2082 * src/gnome/modest-account-assistant.c:
2083 * src/gnome/modest-store-widget.c:
2084 * src/gnome/modest-store-widget.h:
2085 * src/gnome/modest-transport-widget.c:
2086 * src/gnome/modest-transport-widget.h:
2087 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2088 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2089 * src/maemo/easysetup/modest-easysetup-wizard.c:
2090 * src/maemo/modest-account-settings-dialog.c:
2091 * src/maemo/modest-account-settings-dialog.h:
2092 * src/maemo/modest-store-widget.c:
2093 * src/maemo/modest-store-widget.h:
2094 * src/maemo/modest-transport-widget.c:
2095 * src/maemo/modest-transport-widget.h:
2096 * src/modest-account-mgr-helpers.c:
2097 * src/modest-account-mgr-helpers.h:
2098 * src/modest-account-mgr.c:
2099 * src/modest-account-mgr.h:
2100 * src/modest-tny-account.c:
2101 * src/modest-tny-folder.c:
2102 * src/widgets/modest-account-view.c:
2103 * src/widgets/modest-retrieve-combo-box.c:
2104 * src/widgets/modest-retrieve-combo-box.h:
2105 * src/widgets/modest-secureauth-combo-box.c:
2106 * src/widgets/modest-serversecurity-combo-box.c:
2107 * src/widgets/modest-serversecurity-combo-box.h:
2108 * tests/check_account-mgr.c:
2109 Use the specific functions, and use the re-renamed enum values for GNOME too.
2111 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2113 * src/modest-pair.h:
2114 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2115 so we can get the second based on the first.
2117 * src/maemo/modest-account-settings-dialog.h:
2118 * src/maemo/modest-account-settings-dialog.c:
2119 Added get_supported_secure_authentication_methods(), though it is mostly
2120 commented-out for now until the necessary API is committed to tinymail.
2121 (modest_account_settings_dialog_set_account_name),
2122 (save_configuration): Request the supported authentication methods from the
2123 server, so we can choose a working method.
2125 * src/modest-tny-account-store.h:
2126 * src/modest-tny-account-store.c:
2127 (modest_tny_account_store_get_session): Rename from
2128 tny_account_store_get_session().
2130 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2132 * src/modest-protocol-info.h: Split the ModestProtocol enum
2133 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2134 There was no need to have these unrelated values in one enum.
2136 * src/: many files: Adapted to changed enum. This makes the code a bit
2137 clearer, and the compiler could catch some errors.
2139 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2141 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2142 Show the detailed internal camel error message when an error happens
2143 during the configuration, so that our testers can give us more clues.
2144 For instance, in projects.maemo.org bug NB#56910 .
2146 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2148 * src/modest-tny-account.c:
2149 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2150 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2152 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2154 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2155 * src/maemo/modest-account-settings-dialog.c:
2156 (modest_account_settings_dialog_set_account_name),
2157 (save_configuration): For the incoming secure authentication checkbox,
2158 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2159 the UI specification. PLAIN does not seem to be supported for most IMAP
2160 servers anyway, and I am not sure what it would mean.
2161 However, we probably need to discover which of the secure-authentication
2162 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2163 * src/modest-account-mgr-helpers.c:
2164 (modest_account_mgr_get_server_account_data):
2166 * src/modest-tny-account.c:
2167 (modest_tny_account_new_from_server_account):
2168 Use tny_account_set_mech() to set secure-authentication methods,
2169 with some special-casing for IMAP, based on my observations of how
2172 * src/modest-account-mgr-helpers.h:
2173 * src/modest-account-mgr.c:
2174 * src/modest-defs.h: Comment that the URI is only used for local folders.
2176 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2178 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2179 parameter const, just to be neat.
2180 * src/modest-text-utils.c: (modest_text_utils_inline):
2181 End g_strconcat() with NULL, as its documentation says. This is almost
2182 certainly the cause of my crash at startup on the device. Interestingly,
2183 valgrind doesn't tell us about these errors.
2185 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2187 * scripts/build-packages: Added more precise comments about how to use
2188 this script, though I still get this error:
2189 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2190 error building tinymail
2192 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2194 * src/maemo/modest-main-window.c: (on_account_update):
2195 Very slight cleanup, hoping to make it simpler to discover what causes
2196 a crash here sometimes.
2198 * src/modest-tny-account.c:
2199 (modest_tny_account_new_from_server_account): Set the port. Added
2200 comments about the options and a TODO comment because I need to find out
2201 how to specify the secure authentication method.
2203 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2205 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2206 changed CFlags paths form modest to libmodest
2208 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2210 * src/modest-account-mgr-helpers.c:
2211 (modest_account_mgr_get_server_account_data),
2212 (modest_account_mgr_free_server_account_data):
2213 * src/modest-account-mgr-helpers.h:
2214 * src/modest-account-mgr.c:
2215 (modest_account_mgr_add_server_account):
2216 * src/modest-defs.h:
2217 * src/modest-tny-account.c:
2218 (modest_tny_account_new_from_server_account):
2219 Determine the options for tny_camel_account_add_option() here,
2220 based on the settings, rather than storing them directly in gconf.
2222 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2224 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2225 Show a more friendly error dialog now that we expect (from the tinymail
2226 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2228 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2230 * src/maemo/modest-main-window.c: (on_account_update): Check that
2231 account_name is not NULL, to prevent a crash at startup that I am
2232 seeing on the N800. I do wonder why it is NULL.
2234 * src/maemo/easysetup/modest-easysetup-wizard.c:
2235 (create_page_user_details):
2236 * src/maemo/modest-account-settings-dialog.c:
2237 (create_page_user_details), (create_page_outgoing):
2238 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2239 (modest_connection_specific_smtp_edit_window_init):
2240 * src/modest-ui-actions.c:
2241 (modest_ui_actions_on_password_requested):
2242 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2243 might do something useful with the on-screen keyboard.
2245 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2247 * src/maemo/modest-main-window.c: (on_account_update):
2248 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2249 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2251 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2253 * src/modest-tny-account-store.c: (on_account_changed):
2254 Correct the signature of this signal handler.
2256 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2258 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2259 Show a HildonNote instead of a GtkDialog for Maemo.
2261 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2263 * src/widgets/modest-account-view.h:
2264 * src/widgets/modest-account-view.c: (on_account_changed),
2265 (on_account_removed). Added a boolean flag, set/unset by
2266 modest_account_view_block_conf_updates(),
2267 modest_account_view_unblock_conf_updates() to prevent unnecessary
2268 updates, but this is not very useful because the gconf notifications are
2269 so delays (maybe only on Maemo Bora).
2270 So auto-updating is turned off, and these functions do an explicit
2271 update when necessary.
2272 However, something else is still doing too much work when adding/removing
2273 accounts, probably in another part of the application.
2275 * src/maemo/modest-account-view-window.c:
2276 (on_delete_button_clicked), (on_edit_button_clicked),
2277 (on_new_button_clicked): Use the new functions.
2279 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2281 * src/modest-account-mgr-helpers.c:
2282 (modest_account_mgr_set_first_account_as_default):
2283 Sort the list of names alphabetically-by-title, so we choose the first one
2285 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2286 alphabetically by the title.
2288 This fixes projects.maemo.org bug NB#56418 .
2290 * src/modest-account-mgr-priv.c:
2291 (_modest_account_mgr_account_from_key):
2292 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2293 avoid a valgrind error, and possible random behaviour.
2295 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2297 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2298 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2299 tinymail documentation to say that this can be expected.
2300 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2301 pretty, and should not happen, but I would prefer to know when it does.
2303 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2305 * configure.ac: When using the older hildon version, probably on Bora,
2306 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2308 * src/widgets/modest-attachment-view.c:
2309 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2312 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2314 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2315 Implemented the prototype. Can be tested with
2316 tests/dbus_api/test_open_message:
2318 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2320 * src/modest-tny-account-store.c:
2321 (modest_tny_account_store_instance_init), (get_password):
2322 * src/modest-ui-actions.c:
2323 (modest_ui_actions_on_password_requested):
2324 Do not store the password in gconf, because this function is called
2325 for non-remembered passwords. Actually use the cached (in the hash map)
2326 password instead of releasing it.
2327 The password will now not be remembered if it is asked via the protected
2328 password dialog, as per the UI spec.
2330 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2332 * src/modest-defs.h:
2333 * src/modest-account-mgr-helpers.h:
2334 * src/modest-account-mgr-helpers.c:
2335 Added modest_server_account_get_username_has_succeeded(),
2336 modest_server_account_set_username_has_succeeded().
2337 (modest_server_account_set_username),
2338 Reset the has-succeeded flag if the username changes.
2340 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2341 * src/maemo/modest-connection-specific-smtp-window.c:
2342 (modest_connection_specific_smtp_window_save_server_accounts):
2343 Use modest_server_account_set_username() instead of using
2344 modest_conf_set_string() directly, so that the has-succeeded flag is always
2347 * src/modest-ui-actions.c:
2348 (modest_ui_actions_on_password_requested): Dim the username entry if
2349 the username has ever worked, as per the UI spec.
2351 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2353 * src/modest-tny-account-store.c: (get_password):
2354 * src/modest-ui-actions.c:
2355 (modest_ui_actions_on_password_requested):
2356 Allow the username to be changed too, though there is more work to
2357 be done on exactly how this behaves.
2359 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2361 * src/modest-account-mgr-helpers.h:
2362 * src/modest-account-mgr-helpers.c:
2363 Added modest_account_mgr_get_display_name(),
2364 modest_server_account_get_username(),
2365 modest_server_account_set_username(),
2366 modest_server_account_set_password(),
2367 modest_server_account_get_hostname() functions so we do not need to
2368 use the conf API directly.
2370 * src/maemo/modest-main-window.c: (connect_signals):
2371 Actually connect ot the ModestAccountStore::request-password signal,
2372 so that we show the dialog when the password is requested by Tinymail,
2373 for isntance if it is empty.
2375 * src/modest-marshal.list:
2376 * src/modest-tny-account-store.c:
2377 (modest_tny_account_store_class_init), (get_password),
2378 (modest_tny_account_store_alert):
2379 * src/modest-tny-account-store.h:
2380 * src/modest-ui-actions.h:
2381 * src/modest-ui-actions.c:
2382 (modest_ui_actions_on_password_requested):
2383 Change the signal parameters, so it is obvious that we are providing
2384 the non human-readable server name, and receiving both the username
2385 and password, though changing of the username is not yet implemented.
2386 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2387 for the GNOME version.
2389 This should fix the projects.maemo.org bug NB#56209, though it does not
2390 work on Bora, because the gconf_client_get() for the password fails
2391 immediately after we save it with gconf_client_set().
2393 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2396 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2397 caused an undefined symbol error:
2398 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2400 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2402 * src/modest-tny-account-store.c:
2403 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2404 using a GError instead of a string message, so we can translate it in
2407 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2409 * src/maemo/modest-address-book.c:
2410 (modest_address_book_check_names):
2411 * src/maemo/modest-msg-view-window.c:
2412 (modest_msg_view_window_clipboard_owner_change):
2413 * src/modest-init.c: (modest_init_init_ui):
2414 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2415 (update_folders_cb), (modest_mail_operation_update_account):
2416 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2417 (modest_ui_actions_on_msg_attachment_clicked),
2418 (modest_ui_actions_on_msg_recpt_activated):
2419 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2420 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2421 (modest_msg_view_search_next):
2422 * src/widgets/modest-recpt-editor.c:
2423 (modest_recpt_editor_on_button_release_event),
2424 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2425 g_message(). At this point we should only be seeing interesting errors on
2426 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2428 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2430 (modest_wizard_dialog_force_title_update):
2431 * src/maemo/easysetup/modest-wizard-dialog.h:
2432 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2433 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2434 can update the title when appropriate. Otherwise the title is wrong if the
2435 pages are added after adding the notebook to the dialog.
2436 This must be a problem in HildonWizardDialog too.
2437 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2439 * src/maemo/easysetup/modest-easysetup-wizard.c:
2440 (create_subsequent_customsetup_pages),
2441 (create_subsequent_easysetup_pages):
2442 Call modest_wizard_dialog_force_title_update() so that the title is
2443 correct even with GTK+ < 2.10.
2444 This fixes projects.maemo.org bug NB#56145 .
2446 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2448 * src/maemo/modest-platform.c:
2449 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2450 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2453 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2455 * src/widgets/modest-window.h:
2456 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2457 and modest_window_save_state(), which invokes it.
2459 * src/widgets/modest-window-mgr.h:
2460 * src/widgets/modest-window-mgr.c:
2461 Added modest_window_mgr_save_state_for_all_windows(), which calls
2462 the save_state vfunc on all registered windows, if implemented.
2464 * src/gnome/modest-msg-edit-window.c:
2465 * src/gnome/modest-msg-view-window.c:
2466 * src/maemo/modest-msg-edit-window.c:
2467 * src/maemo/modest-msg-view-window.c:
2468 * src/maemo/modest-main-window.c:
2469 Specify the existing save_settings functions as implementations of
2470 ModestWindow::save_state_func().
2472 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2473 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2474 enabling hibernation, for instance.
2476 We may need to do the same thing for restoring settings.
2479 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2481 * src/widgets/modest-window-mgr.c:
2482 * src/widgets/modest-window-mgr.h:
2483 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2484 modest_window_mgr_get_hibernation_is_prevented().
2486 * src/maemo/modest-main-window.c:
2487 (on_hildon_program_is_topmost_notify): Prevent hibernation
2488 (possible when the application goes to the background in the WM),
2489 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2491 * src/maemo/easysetup/modest-easysetup-wizard.c:
2492 (modest_easysetup_wizard_dialog_init):
2493 * src/maemo/modest-account-settings-dialog.c:
2494 (modest_account_settings_dialog_init):
2495 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2496 (modest_connection_specific_smtp_edit_window_init):
2497 * src/maemo/modest-connection-specific-smtp-window.c:
2498 (modest_connection_specific_smtp_window_init):
2499 * src/maemo/modest-signature-editor-dialog.c:
2500 (modest_signature_editor_dialog_init):
2501 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2502 prevent hibernation while any of these account settings dialogs are open.
2504 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2506 * src/maemo/Makefile.am:
2507 * src/maemo/modest-osso-state-saving.c:
2508 * src/maemo/modest-osso-state-saving.h: Added
2509 modest_osso_load_state() and modest_osso_save_state() though they do
2510 nothing now. They should iterate through all the open windows and load/save
2512 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2513 save state when closing.
2515 * src/maemo/modest-main-window.c:
2516 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2517 Add a notification handler for the HildonProgram::is-topmost property,
2518 so we can allow hibernation when the application goes into the background.
2519 But we still need to detect when the accounts setup windows are open so
2520 we can stop hibernation when they are open.
2521 To do this, I also added the main window the HildonProgram. This might have
2522 other side-effects/benefits, and should maybe be done for other windows.
2524 * src/maemo/modest-osso-autosave-callbacks.h:
2525 * src/maemo/modest-osso-autosave-callbacks.c:
2526 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2527 though it does not do anything yet, and we might never need this to do
2528 anything. For instance, we already save drafts.
2530 * src/maemo/modest-platform.c: (modest_platform_init):
2531 Specify the libosso auto-save callback.
2533 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2535 * src/maemo/modest-platform.c:
2536 (modest_platform_set_update_interval):
2537 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2538 aparently stays valid between application instances, so we can use this
2539 to remove and reset it later. According to a maemo-developers email from
2542 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2544 * configure.ac: Depend on libalarm for Maemo.
2546 * src/dbus_api/modest-dbus-api.h:
2547 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2548 (on_send_receive), (modest_dbus_req_handler):
2549 Handle a SEND_RECEIVE D-Bus method.
2551 * libmodest-dbus-client/libmodest-dbus-client.c:
2552 (libmodest_dbus_client_send_and_receive):
2553 * libmodest-dbus-client/libmodest-dbus-client.h:
2554 Add C convenience functions for calling the new D-Bus method.
2556 * src/modest-platform.h:
2557 * src/gnome/modest-platform.c:
2558 * src/maemo/modest-platform.c:
2559 Added modest_platform_set_update_interval(), which uses the
2560 alarmd API on Maemo.
2561 (modest_platform_init),
2562 Call modest_platform_set_update_interval(), using a hard-coded
2563 interval for now (until the global settings dialog is implemented),
2564 though I am not sure that this makes sense yet.
2566 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2568 * src/dbus_api/modest-dbus-callbacks.c:
2569 (modest_osso_cb_hw_state_handler):
2570 * src/dbus_api/modest-dbus-callbacks.h:
2571 * src/maemo/modest-platform.c: (modest_platform_init):
2572 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2573 in case this has some effect on the ability for Maemo to ping the
2576 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2578 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2579 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2580 warning. It is probably a logic error, but I need to fix the build.
2582 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2584 * src/modest-account-mgr.h:
2585 * src/modest-account-mgr.c:
2586 (modest_account_mgr_account_names): Add a gboolean enabled_only
2587 parameter, so we can get lists of onlt the enabled accounts.
2589 (modest_account_mgr_add_account),,
2590 (modest_account_mgr_account_with_display_name_exists):
2591 * src/maemo/modest-msg-edit-window.c: (get_transports):
2592 * src/modest-account-mgr-helpers.c:
2593 (modest_account_mgr_set_first_account_as_default):
2594 * src/modest-init.c: (init_default_account_maybe):
2595 * src/modest-tny-account-store.c: (get_accounts):
2596 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2597 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2598 * tests/check_account-mgr.c: (START_TEST):
2599 Provide the extra parameter, as appropriate.
2601 * src/widgets/modest-account-view.c: (update_account_view):
2602 Do not show disabled accounts (meaning that there is no way to
2603 enable/disable accounts in the UI (the feature is not in our UI
2604 specification), so we can use this internally only to mark unfinished
2605 or temporary account data.
2607 * src/maemo/easysetup/modest-easysetup-wizard.c:
2608 (create_account): Add boolean enable parameter, so we can specify FALSE
2609 to create the temporary account.
2610 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2611 (on_before_next): When finishing, when there is a temporary account, just
2613 Also, use a timeout to delay the showing of the dialog until gconf is likely
2614 to return correct information, due to a maemo gconf bug that is fixed in
2615 osso 1.1, but not yet in Bora.
2616 However, the dialog stays on screen after it is destroyed.
2618 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2619 for invalid data when cancelling. Use a hildon note instead of a dialog
2620 to complain about invalid data. Do not show the account-saved note if the
2621 account is disabled (a temporary account that will not really be saved for use
2624 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2626 * src/modest-account-mgr-helpers.h:
2627 * src/modest-account-mgr-helpers.c:
2628 Added modest_account_mgr_unset_default_account(),
2629 Added modest_account_mgr_set_first_account_as_default().
2631 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2632 If it was the default account, unset the default account name.
2634 * src/maemo/modest-account-view-window.c:
2635 (on_delete_button_clicked): If it was the default account,
2636 set the first remaining account as the default instead.
2638 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2639 a NULL account or a NULL default account, to prevent a crash. This should
2640 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2643 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2645 * src/widgets/modest-recpt-editor.c:
2646 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2647 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2648 TODO comment for this. This fixes the build.
2650 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2651 be the best place for it. This will in future update all auto-update accounts,
2652 rather than just the current/default account, when that gconf key exists.
2653 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2654 if there are no accounts, before calling do_send_receive().
2655 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2657 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2658 * src/maemo/modest-main-window-ui.h:
2659 * src/maemo/modest-main-window.c: (on_connection_changed),
2660 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2661 directly, becaue the signal handler does more.
2663 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2665 * src/modest-account-mgr-helpers.c:
2666 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2667 for the case that the account does not exist.
2669 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2670 (equivalent to the modest account name) rather than the tinymail account name
2671 (equivalent to the modest account title - human readable) to get the account data.
2672 Check for null account data to prevent the crash, and add a TODO comment saying that
2673 this needs fixing because it is using the server account name instead of the account name.
2675 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2677 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2678 * src/maemo/modest-account-settings-dialog.c: (show_error),
2680 Use hildon_note_new_information() for informative and error messages,
2681 which seems to be expected for Maemo applications (no documentation that I know of
2682 says this). I am surprised that there is no distinction between info and error
2685 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2687 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2688 it is easy to find where this is used.
2690 * src/maemo/easysetup/modest-easysetup-wizard.c:
2691 (create_page_welcome), (create_page_account_details),
2692 (create_page_user_details), (create_page_complete_easysetup),
2693 (create_page_custom_incoming), (create_page_custom_outgoing),
2694 (create_page_complete_custom):
2695 * src/maemo/modest-account-settings-dialog.c:
2696 (create_page_account_details), (create_page_user_details),
2697 (create_page_incoming), (create_page_outgoing):
2698 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2699 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2700 (modest_connection_specific_smtp_edit_window_init):
2701 * src/maemo/modest-connection-specific-smtp-window.c:
2702 (modest_connection_specific_smtp_window_init):
2703 * src/maemo/modest-signature-editor-dialog.c:
2704 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2705 and scrolling policy as per the Email Application Layout Guide, if I have
2708 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2710 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2711 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2712 which were empty, because these vfuncs have been removed from TnyAccountStore.
2713 This fixes the build.
2715 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2717 * src/maemo/modest-main-window.c:
2718 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2719 showing/hiding it. Added TODO because it probably should not be NULL.
2720 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2721 because unnecessary g_warnings() make degugging difficult.
2723 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2725 * src/maemo/modest-msg-edit-window.c:
2726 (modest_msg_edit_window_select_color),
2727 (modest_msg_edit_window_select_background_color): 2 const corrections and
2728 moving 2 #endifs before closing brackets, to fix the build.
2730 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2732 * src/maemo/easysetup/modest-easysetup-wizard.h:
2733 * src/maemo/easysetup/modest-easysetup-wizard.c:
2734 (modest_easysetup_wizard_dialog_finalize),
2735 (on_button_edit_advanced_settings), (create_page_complete_custom),
2736 (on_response), (create_account):
2737 Implement the Advanced Settings edit button, by saving the account information,
2738 for the Advanded Settings dialog to use directly from gconf, and removing it
2739 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2740 Bug #5533 in the projects.maemo.org bugzilla.
2742 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2744 * src/maemo/modest-msg-view-window.c:
2745 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2746 when opening a message window.
2748 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2750 * src/maemo/easysetup/modest-easysetup-wizard.c:
2751 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2754 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2755 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2756 gconf settings. I probably added more checks than necessary, but that is safer.
2758 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2759 variable to fix the build, but this seems to be used when it is still NULL.
2761 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2763 * src/modest-platform.h:
2764 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2765 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2766 * src/modest-main.c: Implement this function so we can avoid using
2767 maemo-specific API from cross-platform code.
2769 * src/modest-tny-account-store.c:
2770 (get_smtp_specific_transport_account_for_open_connection):
2771 * src/modest-ui-actions.c: (check_for_connection),
2772 (modest_ui_actions_on_item_not_found):
2773 Use modest_platform_connect_and_wait() and put #idefs around other
2774 maemo-specific code, because only maemo currently has a way to
2775 identify connection names.
2777 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2779 * src/modest-tny-account-store.h:
2780 * src/modest-tny-account-store.c:
2781 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2782 the connection-specific SMTP server settings in the configuration.
2784 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2786 * src/maemo/modest-main-window.c: (on_connection_changed),
2788 * src/modest-main.c: (main), (start_ui), (send_mail):
2789 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2790 that is what is intended.
2792 * src/modest-ui-actions.c: (action_send), (action_receive),
2793 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2794 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2795 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2796 SMTP server is used when it is specified.
2798 (modest_ui_actions_on_send_receive):
2799 Check that a connection is open before proceeding.
2800 Receive and then send, instead of vice-versa, as per the specification.
2802 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2804 * src/modest-mail-operation.c:
2805 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2806 though I guess it should be something other than NULL.
2808 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2810 * src/maemo/easysetup/modest-easysetup-wizard.c:
2811 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2812 combo twice, to avoid an g_warning and to make it visible again.
2813 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2814 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2815 (already intended) dereference when detaching, because we then recreate the menu.
2816 But I am not sure why the warning was happening, and it is possible that this is a memory
2819 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2821 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2822 and uri_parse_mailto() utility functions.
2823 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2825 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2827 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2829 * src/dbus_api/modest-dbus-api.h:
2830 * src/dbus_api/modest-dbus-callbacks.c:
2831 Use an idle callback to execute the modest code in the application's own thread.
2832 Remove the helloworld example method.
2833 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2834 parsed, and the open-message method is not implemented because this is not yet implemented in
2836 * libmodest-dbus-client/libmodest-dbus-client.c:
2837 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2838 (libmodest_dbus_client_open_message):
2839 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2841 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2842 body without crashing.
2844 * tests/dbus_api/Makefile.am:
2845 * tests/dbus_api/test_mail_to.c:
2846 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2848 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2850 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2851 Added file to fix the build. Sorry.
2853 * src/dbus_api/Makefile.am:
2854 * src/dbus_api/modest-dbus-api.h:
2855 * src/dbus_api/modest-dbus-callbacks.h:
2856 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2857 (modest_dbus_req_handler):
2858 Put constants in a separate header so it can be reused by the
2859 client library, without duplication
2861 * libmodest-dbus-client/Makefile.am:
2862 * libmodest-dbus-client/libmodest-dbus-client.c:
2863 (libmodest_dbus_client_call_helloworld),
2864 (libmodfest_dbus_client_send_mail),
2865 (libmodfest_dbus_client_mailto),
2866 (libmodfest_dbus_client_open_message):
2867 * libmodest-dbus-client/libmodest-dbus-client.h:
2868 (Partly) Implement a send_mail D-Bus method.
2870 * tests/dbus_api/Makefile.am:
2871 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2872 the send_email D-Bus method.
2874 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2878 * libmodest-dbus-client/Makefile.am:
2879 * libmodest-dbus-client/libmodest-dbus-client.c:
2880 * libmodest-dbus-client/libmodest-dbus-client.h:
2881 * tests/dbus_api/Makefile.am:
2882 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2883 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2885 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2887 * src/maemo/easysetup/modest-easysetup-wizard.c:
2888 (create_page_account_details):
2889 * src/maemo/modest-account-settings-dialog.c:
2890 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2891 widgets, because this might not be the default in future versions of the Maemo GTK+.
2892 However, I can not not get capitalization to work even in a simple test case.
2894 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2896 * src/maemo/easysetup/modest-easysetup-wizard.c:
2897 (create_page_custom_incoming), (create_page_custom_outgoing):
2898 * src/maemo/modest-account-settings-dialog.c:
2899 (create_page_account_details), (create_page_incoming),
2900 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2901 instead of using gtk_check_button_with_label(), so they are aligned like the other
2902 widgets, as per the UI spec.
2904 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2906 * src/maemo/easysetup/modest-easysetup-wizard.c:
2907 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2908 * src/widgets/modest-validating-entry.c:
2909 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2910 Modest prefix instead of an EasySetup prefix.
2912 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2914 * src/widgets/modest-validating-entry.h:
2915 * src/widgets/modest-validating-entry.c: (on_insert_text),
2916 Added easysetup_validating_entry_set_max_func(), used to set a callback
2917 to call when the max number of characters is reached. GtkEntry has a max-length
2918 already but is silent about it.
2920 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2921 (create_page_account_details), (create_page_user_details),
2923 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2924 (create_page_account_details), (create_page_user_details),
2925 (create_page_outgoing):
2926 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2927 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2928 the UI spec, when the user tries to enter more than the max number of characters.
2930 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2932 * src/maemo/easysetup/modest-easysetup-wizard.c:
2933 (create_page_user_details), (create_page_custom_incoming),
2934 (create_page_custom_outgoing):
2935 * src/maemo/modest-account-settings-dialog.c:
2936 (create_page_user_details), (create_page_incoming),
2937 (create_page_outgoing):
2938 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2939 (modest_connection_specific_smtp_edit_window_init):
2940 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2941 not appropriate. Bad Maemo-specific defaults!.
2943 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2945 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2946 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2947 (modest_signature_editor_dialog_set_settings):
2948 Disable the label and textview when the checkbox is disabled, and use the
2949 specified (UI spec) default signature text.
2951 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2953 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2954 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2956 * src/modest-defs.h:
2957 * src/modest-account-mgr-helpers.h:
2958 * src/modest-account-mgr-helpers.c:
2959 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2961 * src/maemo/Makefile.am:
2962 * src/maemo/modest-signature-editor-dialog.c:
2963 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2966 * src/maemo/modest-account-settings-dialog.h:
2967 * src/maemo/modest-account-settings-dialog.c:
2968 (modest_account_settings_dialog_finalize), (on_button_signature),
2969 (save_configuration): Use the new dialog when the Edit button is pressed, and
2970 save the changes if necessary, as per the UI spec.
2972 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2974 * src/maemo/Makefile.am:
2975 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2976 based on maemo-develoers email from Dirk.
2978 * src/maemo/easysetup/modest-easysetup-wizard.c:
2979 (create_page_welcome), (create_page_account_details),
2980 (create_page_user_details), (create_page_complete_easysetup),
2981 (create_page_custom_incoming), (create_page_custom_outgoing),
2982 (create_page_complete_custom),
2983 (modest_easysetup_wizard_dialog_init):
2984 * src/maemo/modest-account-settings-dialog.c:
2985 (create_page_account_details), (create_page_user_details),
2986 (create_page_incoming), (create_page_outgoing),
2987 (modest_account_settings_dialog_init):
2988 * src/maemo/modest-connection-specific-smtp-window.c:
2989 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2991 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2993 * src/maemo/easysetup/modest-easysetup-wizard.c:
2994 (create_page_account_details), (create_page_custom_outgoing),
2995 (create_page_complete_custom):
2996 * src/maemo/modest-account-settings-dialog.c:
2997 (create_page_user_details), (create_page_incoming),
2998 (create_page_outgoing):
2999 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3000 (modest_connection_specific_smtp_edit_window_init):
3001 Use the correct (UI spec) port min/max, and use horizontal separators,
3004 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3006 * src/maemo/easysetup/modest-easysetup-wizard.c:
3007 (set_default_custom_servernames):
3008 * src/maemo/modest-account-settings-dialog.c:
3009 (create_page_incoming), (on_combo_outgoing_security_changed),
3010 (on_combo_incoming_security_changed), (create_page_outgoing),
3011 (modest_account_settings_dialog_set_account_name),
3012 (save_configuration):
3013 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3014 (on_combo_security_changed),
3015 (modest_connection_specific_smtp_edit_window_init),
3016 (modest_connection_specific_smtp_edit_window_set_connection),
3017 (modest_connection_specific_smtp_edit_window_get_settings):
3018 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3021 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3024 * src/maemo/easysetup/modest-easysetup-wizard.c:
3025 (create_page_custom_outgoing), (create_page_complete_custom):
3026 * src/maemo/modest-account-settings-dialog.c:
3027 (create_page_user_details), (create_page_outgoing):
3028 * src/maemo/modest-account-view-window.c: (button_box_new):
3029 Use changed logical IDs as per the most recent UI spec:
3030 mcen_bd_emailsetup_edit -> mcen_bd_edit
3031 mcen_bd_emailsetup_delete -> mcen_bd_delete
3032 mcen_bd_emailsetup_close -> mcen_bd_close
3034 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3038 * src/dbus_api/Makefile.am:
3039 * src/dbus_api/modest-dbus-callbacks.c:
3040 * src/dbus_api/modest-dbus-callbacks.h:
3041 * src/maemo/modest-platform.c: (modest_platform_init):
3042 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3044 * tests/Makefile.am:
3045 * tests/dbus_api/Makefile.am:
3046 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3048 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3050 * src/maemo/modest-account-settings-dialog.c:
3051 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3052 Removed unnecessary includes.
3054 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3056 * src/maemo/easysetup/modest-easysetup-wizard.c:
3057 * src/maemo/modest-account-settings-dialog.c:
3058 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3059 * src/widgets/Makefile.am:
3060 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3061 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3062 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3063 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3064 * src/widgets/modest-secureauth-combo-box.c:
3065 * src/widgets/modest-secureauth-combo-box.h:
3066 * src/widgets/modest-serversecurity-combo-box.c:
3067 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3068 made the GObject names more consistent with the rest of the Modest code.
3070 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3072 * src/maemo/easysetup/Makefile.am:
3073 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3074 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3075 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3076 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3077 * src/maemo/easysetup/modest-easysetup-wizard.c:
3078 * src/maemo/easysetup/modest-validating-entry.c:
3079 * src/maemo/easysetup/modest-validating-entry.h:
3080 * src/maemo/modest-account-settings-dialog.c:
3081 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3082 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3083 widgets/ because they are used outside of easysetup too. After checking in,
3084 svn will allow me to rename them too.
3086 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3088 * src/gnome/modest-msg-edit-window.c:
3089 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3090 linker error, to fix the build on the GNOME platform.
3091 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3092 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3093 ifdefed out to avoid a warning.
3095 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3097 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3098 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3099 some alternative for GTK+ 2.6.
3101 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3103 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3105 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3106 specified for EmailAccountsDialog in UI spec.
3108 * src/maemo/easysetup/modest-easysetup-wizard.c:
3109 * src/maemo/easysetup/modest-easysetup-wizard.h:
3110 * src/maemo/modest-account-settings-dialog.c:
3111 * src/maemo/modest-account-settings-dialog.h:
3112 Reuse a member window widget for the connection-specific SMTP server accounts,
3113 so we can tell it to create/save the accounts only if we actually save changes.
3115 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3116 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3117 (modest_connection_specific_smtp_edit_window_get_settings):
3118 Return a struct instance for temporarily remembering the entered data.
3120 * src/maemo/modest-connection-specific-smtp-window.h:
3121 * src/maemo/modest-connection-specific-smtp-window.c:
3122 (modest_connection_specific_smtp_window_finalize),
3123 (modest_connection_specific_smtp_window_fill_with_connections),
3125 (modest_connection_specific_smtp_window_save_server_accounts),
3126 (update_model_server_names): Do not actually save data until asked,
3127 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3129 (on_selection_changed),
3130 (modest_connection_specific_smtp_window_init): Disable the edit
3131 button when nothing is selected.
3133 * src/modest-account-mgr-helpers.c:
3134 * src/modest-account-mgr-helpers.h:
3135 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3138 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3140 * src/modest-account-mgr-helpers.h:
3141 * src/modest-account-mgr-helpers.c:
3142 (modest_account_mgr_get_unused_account_name),
3143 (modest_account_mgr_get_unused_account_display_name): Added these
3144 utility functions, to avoid code duplication.
3146 * src/maemo/easysetup/modest-easysetup-wizard.c:
3147 (create_page_account_details), (create_account):
3148 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3149 (on_combo_security_changed),
3150 (modest_connection_specific_smtp_edit_window_init),
3151 (modest_connection_specific_smtp_edit_window_save_settings):
3152 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3153 * src/maemo/modest-connection-specific-smtp-window.c:
3154 (modest_connection_specific_smtp_window_finalize),
3155 (modest_connection_specific_smtp_window_fill_with_connections),
3156 (on_button_edit), (modest_connection_specific_smtp_window_init):
3157 * src/maemo/modest-connection-specific-smtp-window.h:
3158 Implementing saving of connection-specific server accounts.
3160 But I need to refactor this so we can save the data for each
3161 possible connection-specific account and only actually create the server accounts
3162 when the easysetup finished, or the OK button is pressed on the account settings
3165 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3167 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3168 (on_combo_security_changed):
3169 (modest_connection_specific_smtp_edit_window_init):
3170 Auto-fill the port number as in the account settings.
3172 (modest_connection_specific_smtp_edit_window_set_connection):
3173 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3174 * src/maemo/modest-connection-specific-smtp-window.c:
3175 (fill_with_connections), (on_button_edit),
3176 (modest_connection_specific_smtp_window_init):
3177 Turn the edit window into a dialog to simplify the code, and
3178 set a WM hint as in a GtkDialog, because only a popup can be on top of
3179 another window in Maemo, and popups usually have no WM decoration.
3181 * src/modest-defs.h:
3182 * src/modest-account-mgr-helpers.c:
3183 (modest_account_mgr_set_connection_specific_smtp),
3184 (modest_account_mgr_remove_connection_specific_smtp),
3185 (modest_account_mgr_get_connection_specific_smtp):
3186 * src/modest-account-mgr-helpers.h: Some functions to write the
3187 connection-specific SMTP server information. Not yet used.
3190 * src/widgets/modest-folder-view.c: (text_cell_data):
3191 Fix a warning about an uninitialized variable.
3192 (on_configuration_key_changed): Put an #ifdef around the use
3193 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3195 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3197 * src/maemo/modest-account-settings-dialog.h:
3198 * src/maemo/modest-account-settings-dialog.c:
3199 Added connect_for_modified() utility function to mark the new modified boolean.
3201 (create_page_account_details), (create_page_user_details),
3202 (create_page_incoming), (create_page_outgoing), (on_response),
3203 (modest_account_settings_dialog_init),
3204 (modest_account_settings_dialog_set_account_name):
3205 Only warn about unsaved changes when there are actually unsaved changes.
3207 * src/modest-account-mgr-helpers.c:
3208 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3209 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3210 to get the data from there in future.
3212 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3214 * src/modest-defs.h:
3216 * src/modest-account-mgr-helpers.h:
3217 * src/modest-account-mgr-helpers.c:
3218 Store the security account setting in a single conf key instead of using
3219 the options list, so that the list is left for just the to-be-removed camel hack,
3220 and because gconf_client_set_list() is failing for some reason.
3222 * src/modest-account-mgr.c:
3223 (modest_account_mgr_add_server_account):
3224 * src/maemo/modest-account-settings-dialog.c:
3225 (modest_account_settings_dialog_set_account_name),
3226 (save_configuration): Use the renamed functions.
3229 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3231 * src/widgets/Makefile.am:
3232 * src/widgets/modest-limit-retrieve-combo-box.c:
3233 * src/widgets/modest-limit-retrieve-combo-box.h:
3234 * src/widgets/modest-retrieve-combo-box.c:
3235 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3236 the account settings dialog.
3238 * src/modest-defs.h:
3239 * src/modest-account-mgr-helpers.h:
3240 * src/modest-account-mgr-helpers.c:
3241 (modest_server_account_get_option_secure_auth),
3242 (modest_server_account_set_option_secure_auth):
3243 * src/modest-account-mgr.c:
3244 (modest_account_mgr_add_server_account):
3245 Use the existing AUTH_MECH conf key for the secure-auth setting,
3246 instead of putting it in the list options, because this was actually used already.
3248 * src/maemo/modest-account-settings-dialog.c:
3249 (create_page_account_details),
3250 (modest_account_settings_dialog_set_account_name),
3251 (save_configuration):
3252 * src/maemo/modest-account-settings-dialog.h:
3253 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3254 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3256 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3258 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3259 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3260 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3262 * src/modest-defs.h:
3263 * src/maemo/modest-account-settings-dialog.c:
3264 (create_page_incoming), (on_combo_outgoing_security_changed),
3265 (on_combo_incoming_security_changed), (create_page_outgoing),
3266 (modest_account_settings_dialog_set_account_name),
3267 (save_configuration): Load/Save the port number, and change it when the
3268 security combo changes, to suitable defaults.
3270 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3272 * src/modest-account-mgr.c:
3273 (modest_account_mgr_add_server_account): Set the security and secure-auth
3274 options, and add a comment saying that the other camel-specific options should be
3277 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3279 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3281 * src/modest-tny-account-store.c: (account_list_free),
3282 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3283 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3286 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3288 * src/modest-protocol-info.c:
3289 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3290 is required by our UI spec. Maybe something in our implementation will use this eventually.
3291 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3292 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3293 instead of the previous 0 placeholder.
3295 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3296 secure-auth settings.
3297 * src/modest-account-mgr-helpers.h:
3298 * src/modest-account-mgr-helpers.c:
3299 (modest_server_account_data_get_option_secure_auth),
3300 (modest_server_account_set_option_secure_auth),
3301 (modest_server_account_data_get_option_security),
3302 (modest_server_account_set_option_security): Added this API for getting and setting the security
3303 and secure-auth settings.
3305 * src/maemo/modest-account-settings-dialog.h:
3306 * src/maemo/modest-account-settings-dialog.c:
3307 (modest_account_settings_dialog_finalize), (check_data),
3308 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3309 about changing titles.
3310 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3311 (save_configuration): Save the security and secure-auth settings.
3313 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3314 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3316 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3318 * src/modest-defs.h:
3319 * src/modest-account-mgr.c:
3320 (modest_account_mgr_add_server_account):
3321 Added and used defines for the options key and value pair strings,
3322 that are used so far, though they do not seem to correspond to anything in our
3323 UI specs or ModestProtocol enum.
3325 * src/modest-account-mgr-helpers.h:
3326 * src/modest-account-mgr-helpers.c:
3327 (compare_option_strings_for_name),
3328 (modest_server_account_data_get_option_value),
3329 (modest_server_account_data_get_option_bool),
3330 (modest_account_mgr_get_server_account_option):
3331 Added helper functions for parsing the options GSList.
3333 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3335 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3336 display name is based on the supplied account name.
3337 * src/modest-account-mgr.c:
3338 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3339 with an inefficient, but good-enough, implementation.
3341 * src/maemo/easysetup/modest-easysetup-wizard.c:
3342 (create_page_account_details), (on_before_next), (create_account):
3343 Check for existing display names rather than (non-user-visible) account names, and just
3344 create and set a unique account name at the end.
3346 * src/maemo/modest-account-settings-dialog.c:
3347 (modest_account_settings_dialog_init),
3348 (modest_account_settings_dialog_set_account_name),
3349 (create_page_incoming): Show the display name, instead of the account name.
3350 (on_response): Do some (not all) extra checks, as in the UI spec.
3351 (save_configuration): Save the display name if it was changed.
3353 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3355 * po/en_GB.po: Added needed logical ID and translation.
3356 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3357 (init_view): Made the is-default column clicking work.
3359 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3362 * src/maemo/easysetup/Makefile.am:
3363 * src/maemo/easysetup/modest-easysetup-wizard.c:
3364 (modest_easysetup_wizard_dialog_init):
3365 * src/maemo/easysetup/provider-data-test.keyfile:
3366 * src/maemo/easysetup/provider-data.keyfile:
3367 Moved the provider data file to the new modest-providers-data package and used it from there.
3369 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3371 * src/modest-local-folder-info.c:
3372 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3373 N_() was already used on the static strings, but this just marks it for translation without
3374 using the translation.
3376 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3378 * src/maemo/modest-account-settings-dialog.c:
3379 (create_page_incoming),
3380 (modest_account_settings_dialog_set_account_name):
3381 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3382 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3383 I will do this if nobody else gets there first.
3385 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3387 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3388 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3389 save the security stuff.
3391 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3393 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3394 Set the email address and user fullname, which I now see must be
3397 * src/maemo/modest-account-settings-dialog.h:
3398 * src/maemo/modest-account-settings-dialog.c:
3400 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3401 leave-on-server and authentication.
3402 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3405 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3408 * src/maemo/modest-account-settings-dialog.c:
3409 * src/maemo/modest-account-settings-dialog.h:
3410 Most (but not all) of the widgets are now present as specified by the UI spec.
3411 No changes are yet saved, and some details are not properly shown yet.
3413 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3415 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3417 * src/maemo/Makefile.am:
3418 * src/maemo/modest-account-settings-dialog.c:
3419 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3420 an existing account. Doesn't do much yet.
3422 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3423 Open the accounts settings dialog when Edit is clicked.
3425 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3427 * src/maemo/easysetup/Makefile.am:
3428 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3430 * src/maemo/easysetup/modest-easysetup-wizard.c:
3431 (modest_easysetup_wizard_dialog_init):
3432 Try to get the source directory from the build system,
3433 instead of hard-coding "./" into the source code, when opening our local
3434 copies of the configuration files.
3435 But this still fails when opening the wizard from the Accounts window,
3436 maybe because the working directory seems to change at runtime.
3437 So the wizard will fail the second time unless you copy the files into their
3438 proper locations - see the stdout warnings for the paths.
3440 (create_page_account_details),(on_before_next):
3441 Check for existing non-server accounts instead of server accounts,
3442 so the default account name is useful again, and to prevent trying to
3445 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3446 Show the wizard when New is clicked.
3448 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3449 (init_view): Show the column headers, and show the columns that are
3450 specified in the UI specs. However, something in Maemo's GTK+ prevents
3451 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3452 change the default account. This is despite unsetting the special properties.
3454 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3456 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3457 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3458 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3459 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3460 to make that clearer.
3461 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3463 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3465 * src/maemo/modest-account-view-window.c:
3466 (modest_account_view_window_init),
3467 (modest_account_view_window_new):
3468 Use the same buttons as specified in the
3469 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3470 the existing widgets, which never had a chance of working.
3471 Put the ModestAccountView treeview in a scrolled window.
3472 Do not repeat the initialization in both _init() and _new().
3474 * src/widgets/modest-account-view.c: (update_account_view):
3475 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3476 this widget and window shows no accounts.
3478 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3480 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3482 * src/maemo/easysetup/modest-easysetup-wizard.c:
3483 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3484 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3485 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3488 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3489 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3490 accounts exist yet, as in the UI spec.
3492 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3494 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3496 * src/maemo/Makefile.am:
3497 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3498 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3499 New window for editing connection-specific smtp details.
3500 Not fully implemented.
3502 * src/maemo/modest-connection-specific-smtp-window.c:
3503 (modest_connection_specific_smtp_window_finalize) :
3504 unref the tree model.
3505 (on_button_edit): Show the edit window.
3507 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3509 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3512 * src/maemo/Makefile.am:
3513 * src/maemo/modest-connection-specific-smtp-window.c:
3514 * src/maemo/modest-connection-specific-smtp-window.h:
3515 New window for showing the list of connections, for connection-specific
3516 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3517 * src/maemo/easysetup/modest-easysetup-wizard.c:
3518 (create_page_custom_outgoing): Show the new window when the button is clicked.
3520 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3522 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3523 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3524 * src/maemo/modest-msg-edit-window.c:
3525 (modest_msg_edit_window_insert_image):
3526 * src/modest-conf.c: (modest_conf_key_escape):
3527 * src/modest-mail-operation.c:
3528 (modest_mail_operation_send_new_mail):
3529 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3530 (modest_ui_actions_on_new_account):
3531 * src/widgets/modest-attachment-view.c: (update_filename_request):
3532 * src/widgets/modest-mail-header-view.c:
3533 Corrected warnings that were breaking the build, by commenting out unused variables,
3534 and a function, and by including a header.
3536 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3538 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3539 so we can #ifdef around platform-specific code when necessary.
3540 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3541 to allow this to build for the GNOME platform too.
3543 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3545 * src/maemo/easysetup/modest-easysetup-wizard.c:
3546 Added util_increment_name() and used it in create_page_account_details()
3547 to make sure that the default account name is always a new name.
3549 (modest_easysetup_wizard_dialog_init),
3550 (set_default_custom_servernames): Some minor memory management fixes.
3552 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3556 * src/modest-runtime.c: (init_i18n): Restored the translation
3557 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3558 are defined in config.h, and the translations are installed.
3560 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3561 is defined for translation.
3563 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3565 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3567 * src/maemo/easysetup/modest-easysetup-wizard.c:
3568 (modest_easysetup_wizard_dialog_init):
3569 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3570 Use realistic paths (though they should use $prefix generically) to the
3571 mcc_mapping and provider-data.keyfile files which might work when they
3572 are installed by the future version of the operator-wizard package,
3573 and then fallback to paths in our source code, with an explanatory
3576 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3580 * src/maemo/Makefile.am:
3581 * src/maemo/easysetup/: Added files from the previously-exernal
3582 osso-modest-easysetup.
3583 * src/maemo/modest-main-window-ui.h:
3584 * src/modest-ui-actions.c:
3585 * src/modest-ui-actions.h:
3586 Added modest_ui_actions_on_new_account() as a signal handler for the
3587 New Account menu item. It shows the easysetup wizard.
3588 * po/en_GB.po: Added additional needed logical IDs and translations.