1 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
4 Implemented the prototype. Can be tested with
5 tests/dbus_api/test_open_message:
8 2007-05-08 Murray Cumming <murrayc@murrayc.com>
10 * src/modest-tny-account-store.c:
11 (modest_tny_account_store_instance_init), (get_password):
12 * src/modest-ui-actions.c:
13 (modest_ui_actions_on_password_requested):
14 Do not store the password in gconf, because this function is called
15 for non-remembered passwords. Actually use the cached (in the hash map)
16 password instead of releasing it.
17 The password will now not be remembered if it is asked via the protected
18 password dialog, as per the UI spec.
20 2007-05-08 Murray Cumming <murrayc@murrayc.com>
23 * src/modest-account-mgr-helpers.h:
24 * src/modest-account-mgr-helpers.c:
25 Added modest_server_account_get_username_has_succeeded(),
26 modest_server_account_set_username_has_succeeded().
27 (modest_server_account_set_username),
28 Reset the has-succeeded flag if the username changes.
30 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
31 * src/maemo/modest-connection-specific-smtp-window.c:
32 (modest_connection_specific_smtp_window_save_server_accounts):
33 Use modest_server_account_set_username() instead of using
34 modest_conf_set_string() directly, so that the has-succeeded flag is always
37 * src/modest-ui-actions.c:
38 (modest_ui_actions_on_password_requested): Dim the username entry if
39 the username has ever worked, as per the UI spec.
41 2007-05-08 Murray Cumming <murrayc@murrayc.com>
43 * src/modest-tny-account-store.c: (get_password):
44 * src/modest-ui-actions.c:
45 (modest_ui_actions_on_password_requested):
46 Allow the username to be changed too, though there is more work to
47 be done on exactly how this behaves.
49 2007-05-08 Murray Cumming <murrayc@murrayc.com>
51 * src/modest-account-mgr-helpers.h:
52 * src/modest-account-mgr-helpers.c:
53 Added modest_account_mgr_get_display_name(),
54 modest_server_account_get_username(),
55 modest_server_account_set_username(),
56 modest_server_account_set_password(),
57 modest_server_account_get_hostname() functions so we do not need to
58 use the conf API directly.
60 * src/maemo/modest-main-window.c: (connect_signals):
61 Actually connect ot the ModestAccountStore::request-password signal,
62 so that we show the dialog when the password is requested by Tinymail,
63 for isntance if it is empty.
65 * src/modest-marshal.list:
66 * src/modest-tny-account-store.c:
67 (modest_tny_account_store_class_init), (get_password),
68 (modest_tny_account_store_alert):
69 * src/modest-tny-account-store.h:
70 * src/modest-ui-actions.h:
71 * src/modest-ui-actions.c:
72 (modest_ui_actions_on_password_requested):
73 Change the signal parameters, so it is obvious that we are providing
74 the non human-readable server name, and receiving both the username
75 and password, though changing of the username is not yet implemented.
76 Change the dialog UI to match the Maemo UI specifications, with #idfefing
77 for the GNOME version.
79 This should fix the projects.maemo.org bug NB#56209, though it does not
80 work on Bora, because the gconf_client_get() for the password fails
81 immediately after we save it with gconf_client_set().
83 2007-05-08 Murray Cumming <murrayc@murrayc.com>
86 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
87 caused an undefined symbol error:
88 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
90 2007-05-08 Murray Cumming <murrayc@murrayc.com>
92 * src/modest-tny-account-store.c:
93 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
94 using a GError instead of a string message, so we can translate it in
97 2007-05-08 Murray Cumming <murrayc@murrayc.com>
99 * src/maemo/modest-address-book.c:
100 (modest_address_book_check_names):
101 * src/maemo/modest-msg-view-window.c:
102 (modest_msg_view_window_clipboard_owner_change):
103 * src/modest-init.c: (modest_init_init_ui):
104 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
105 (update_folders_cb), (modest_mail_operation_update_account):
106 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
107 (modest_ui_actions_on_msg_attachment_clicked),
108 (modest_ui_actions_on_msg_recpt_activated):
109 * src/widgets/modest-header-view.c: (drag_data_get_cb):
110 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
111 (modest_msg_view_search_next):
112 * src/widgets/modest-recpt-editor.c:
113 (modest_recpt_editor_on_button_release_event),
114 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
115 g_message(). At this point we should only be seeing interesting errors on
116 stdout. Debugging messages could be #ifdefed-out if they are still useful.
118 2007-05-07 Murray Cumming <murrayc@murrayc.com>
120 (modest_wizard_dialog_force_title_update):
121 * src/maemo/easysetup/modest-wizard-dialog.h:
122 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
123 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
124 can update the title when appropriate. Otherwise the title is wrong if the
125 pages are added after adding the notebook to the dialog.
126 This must be a problem in HildonWizardDialog too.
127 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
129 * src/maemo/easysetup/modest-easysetup-wizard.c:
130 (create_subsequent_customsetup_pages),
131 (create_subsequent_easysetup_pages):
132 Call modest_wizard_dialog_force_title_update() so that the title is
133 correct even with GTK+ < 2.10.
134 This fixes projects.maemo.org bug NB#56145 .
136 2007-05-07 Murray Cumming <murrayc@murrayc.com>
138 * src/maemo/modest-platform.c:
139 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
140 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
143 2007-05-07 Murray Cumming <murrayc@murrayc.com>
145 * src/widgets/modest-window.h:
146 * src/widgets/modest-window.c: Added a save_state_func vfunc,
147 and modest_window_save_state(), which invokes it.
149 * src/widgets/modest-window-mgr.h:
150 * src/widgets/modest-window-mgr.c:
151 Added modest_window_mgr_save_state_for_all_windows(), which calls
152 the save_state vfunc on all registered windows, if implemented.
154 * src/gnome/modest-msg-edit-window.c:
155 * src/gnome/modest-msg-view-window.c:
156 * src/maemo/modest-msg-edit-window.c:
157 * src/maemo/modest-msg-view-window.c:
158 * src/maemo/modest-main-window.c:
159 Specify the existing save_settings functions as implementations of
160 ModestWindow::save_state_func().
162 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
163 Call modest_window_mgr_save_state_for_all_windows(). This happens before
164 enabling hibernation, for instance.
166 We may need to do the same thing for restoring settings.
169 2007-05-07 Murray Cumming <murrayc@murrayc.com>
171 * src/widgets/modest-window-mgr.c:
172 * src/widgets/modest-window-mgr.h:
173 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
174 modest_window_mgr_get_hibernation_is_prevented().
176 * src/maemo/modest-main-window.c:
177 (on_hildon_program_is_topmost_notify): Prevent hibernation
178 (possible when the application goes to the background in the WM),
179 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
181 * src/maemo/easysetup/modest-easysetup-wizard.c:
182 (modest_easysetup_wizard_dialog_init):
183 * src/maemo/modest-account-settings-dialog.c:
184 (modest_account_settings_dialog_init):
185 * src/maemo/modest-connection-specific-smtp-edit-window.c:
186 (modest_connection_specific_smtp_edit_window_init):
187 * src/maemo/modest-connection-specific-smtp-window.c:
188 (modest_connection_specific_smtp_window_init):
189 * src/maemo/modest-signature-editor-dialog.c:
190 (modest_signature_editor_dialog_init):
191 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
192 prevent hibernation while any of these account settings dialogs are open.
194 2007-05-04 Murray Cumming <murrayc@murrayc.com>
196 * src/maemo/Makefile.am:
197 * src/maemo/modest-osso-state-saving.c:
198 * src/maemo/modest-osso-state-saving.h: Added
199 modest_osso_load_state() and modest_osso_save_state() though they do
200 nothing now. They should iterate through all the open windows and load/save
202 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
203 save state when closing.
205 * src/maemo/modest-main-window.c:
206 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
207 Add a notification handler for the HildonProgram::is-topmost property,
208 so we can allow hibernation when the application goes into the background.
209 But we still need to detect when the accounts setup windows are open so
210 we can stop hibernation when they are open.
211 To do this, I also added the main window the HildonProgram. This might have
212 other side-effects/benefits, and should maybe be done for other windows.
214 * src/maemo/modest-osso-autosave-callbacks.h:
215 * src/maemo/modest-osso-autosave-callbacks.c:
216 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
217 though it does not do anything yet, and we might never need this to do
218 anything. For instance, we already save drafts.
220 * src/maemo/modest-platform.c: (modest_platform_init):
221 Specify the libosso auto-save callback.
223 2007-05-03 Murray Cumming <murrayc@murrayc.com>
225 * src/maemo/modest-platform.c:
226 (modest_platform_set_update_interval):
227 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
228 aparently stays valid between application instances, so we can use this
229 to remove and reset it later. According to a maemo-developers email from
232 2007-05-03 Murray Cumming <murrayc@murrayc.com>
234 * configure.ac: Depend on libalarm for Maemo.
236 * src/dbus_api/modest-dbus-api.h:
237 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
238 (on_send_receive), (modest_dbus_req_handler):
239 Handle a SEND_RECEIVE D-Bus method.
241 * libmodest-dbus-client/libmodest-dbus-client.c:
242 (libmodest_dbus_client_send_and_receive):
243 * libmodest-dbus-client/libmodest-dbus-client.h:
244 Add C convenience functions for calling the new D-Bus method.
246 * src/modest-platform.h:
247 * src/gnome/modest-platform.c:
248 * src/maemo/modest-platform.c:
249 Added modest_platform_set_update_interval(), which uses the
251 (modest_platform_init),
252 Call modest_platform_set_update_interval(), using a hard-coded
253 interval for now (until the global settings dialog is implemented),
254 though I am not sure that this makes sense yet.
256 2007-05-02 Murray Cumming <murrayc@murrayc.com>
258 * src/dbus_api/modest-dbus-callbacks.c:
259 (modest_osso_cb_hw_state_handler):
260 * src/dbus_api/modest-dbus-callbacks.h:
261 * src/maemo/modest-platform.c: (modest_platform_init):
262 Registered (empty) callbacks for the osso hardware state D-Bus signals,
263 in case this has some effect on the ability for Maemo to ping the
266 2007-05-02 Murray Cumming <murrayc@murrayc.com>
268 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
269 Comment out an if() that checks a gchar for < 0, causing a build-breaking
270 warning. It is probably a logic error, but I need to fix the build.
272 2007-05-02 Murray Cumming <murrayc@murrayc.com>
274 * src/modest-account-mgr.h:
275 * src/modest-account-mgr.c:
276 (modest_account_mgr_account_names): Add a gboolean enabled_only
277 parameter, so we can get lists of onlt the enabled accounts.
279 (modest_account_mgr_add_account),,
280 (modest_account_mgr_account_with_display_name_exists):
281 * src/maemo/modest-msg-edit-window.c: (get_transports):
282 * src/modest-account-mgr-helpers.c:
283 (modest_account_mgr_set_first_account_as_default):
284 * src/modest-init.c: (init_default_account_maybe):
285 * src/modest-tny-account-store.c: (get_accounts):
286 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
287 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
288 * tests/check_account-mgr.c: (START_TEST):
289 Provide the extra parameter, as appropriate.
291 * src/widgets/modest-account-view.c: (update_account_view):
292 Do not show disabled accounts (meaning that there is no way to
293 enable/disable accounts in the UI (the feature is not in our UI
294 specification), so we can use this internally only to mark unfinished
295 or temporary account data.
297 * src/maemo/easysetup/modest-easysetup-wizard.c:
298 (create_account): Add boolean enable parameter, so we can specify FALSE
299 to create the temporary account.
300 (on_button_edit_advanced_settings): Create the temporary account as disabled.
301 (on_before_next): When finishing, when there is a temporary account, just
303 Also, use a timeout to delay the showing of the dialog until gconf is likely
304 to return correct information, due to a maemo gconf bug that is fixed in
305 osso 1.1, but not yet in Bora.
306 However, the dialog stays on screen after it is destroyed.
308 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
309 for invalid data when cancelling. Use a hildon note instead of a dialog
310 to complain about invalid data. Do not show the account-saved note if the
311 account is disabled (a temporary account that will not really be saved for use
314 2007-04-30 Murray Cumming <murrayc@murrayc.com>
316 * src/modest-account-mgr-helpers.h:
317 * src/modest-account-mgr-helpers.c:
318 Added modest_account_mgr_unset_default_account(),
319 Added modest_account_mgr_set_first_account_as_default().
321 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
322 If it was the default account, unset the default account name.
324 * src/maemo/modest-account-view-window.c:
325 (on_delete_button_clicked): If it was the default account,
326 set the first remaining account as the default instead.
328 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
329 a NULL account or a NULL default account, to prevent a crash. This should
330 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
333 2007-04-30 Murray Cumming <murrayc@murrayc.com>
335 * src/widgets/modest-recpt-editor.c:
336 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
337 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
338 TODO comment for this. This fixes the build.
340 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
341 be the best place for it. This will in future update all auto-update accounts,
342 rather than just the current/default account, when that gconf key exists.
343 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
344 if there are no accounts, before calling do_send_receive().
345 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
347 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
348 * src/maemo/modest-main-window-ui.h:
349 * src/maemo/modest-main-window.c: (on_connection_changed),
350 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
351 directly, becaue the signal handler does more.
353 2007-04-30 Murray Cumming <murrayc@murrayc.com>
355 * src/modest-account-mgr-helpers.c:
356 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
357 for the case that the account does not exist.
359 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
360 (equivalent to the modest account name) rather than the tinymail account name
361 (equivalent to the modest account title - human readable) to get the account data.
362 Check for null account data to prevent the crash, and add a TODO comment saying that
363 this needs fixing because it is using the server account name instead of the account name.
365 2007-04-29 Murray Cumming <murrayc@murrayc.com>
367 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
368 * src/maemo/modest-account-settings-dialog.c: (show_error),
370 Use hildon_note_new_information() for informative and error messages,
371 which seems to be expected for Maemo applications (no documentation that I know of
372 says this). I am surprised that there is no distinction between info and error
375 2007-04-29 Murray Cumming <murrayc@murrayc.com>
377 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
378 it is easy to find where this is used.
380 * src/maemo/easysetup/modest-easysetup-wizard.c:
381 (create_page_welcome), (create_page_account_details),
382 (create_page_user_details), (create_page_complete_easysetup),
383 (create_page_custom_incoming), (create_page_custom_outgoing),
384 (create_page_complete_custom):
385 * src/maemo/modest-account-settings-dialog.c:
386 (create_page_account_details), (create_page_user_details),
387 (create_page_incoming), (create_page_outgoing):
388 * src/maemo/modest-account-view-window.c: (window_vbox_new):
389 * src/maemo/modest-connection-specific-smtp-edit-window.c:
390 (modest_connection_specific_smtp_edit_window_init):
391 * src/maemo/modest-connection-specific-smtp-window.c:
392 (modest_connection_specific_smtp_window_init):
393 * src/maemo/modest-signature-editor-dialog.c:
394 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
395 and scrolling policy as per the Email Application Layout Guide, if I have
398 2007-04-27 Murray Cumming <murrayc@murrayc.com>
400 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
401 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
402 which were empty, because these vfuncs have been removed from TnyAccountStore.
403 This fixes the build.
405 2007-04-27 Murray Cumming <murrayc@murrayc.com>
407 * src/maemo/modest-main-window.c:
408 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
409 showing/hiding it. Added TODO because it probably should not be NULL.
410 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
411 because unnecessary g_warnings() make degugging difficult.
413 2007-04-27 Murray Cumming <murrayc@murrayc.com>
415 * src/maemo/modest-msg-edit-window.c:
416 (modest_msg_edit_window_select_color),
417 (modest_msg_edit_window_select_background_color): 2 const corrections and
418 moving 2 #endifs before closing brackets, to fix the build.
420 2007-04-27 Murray Cumming <murrayc@murrayc.com>
422 * src/maemo/easysetup/modest-easysetup-wizard.h:
423 * src/maemo/easysetup/modest-easysetup-wizard.c:
424 (modest_easysetup_wizard_dialog_finalize),
425 (on_button_edit_advanced_settings), (create_page_complete_custom),
426 (on_response), (create_account):
427 Implement the Advanced Settings edit button, by saving the account information,
428 for the Advanded Settings dialog to use directly from gconf, and removing it
429 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
430 Bug #5533 in the projects.maemo.org bugzilla.
432 2007-04-27 Murray Cumming <murrayc@murrayc.com>
434 * src/maemo/modest-msg-view-window.c:
435 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
436 when opening a message window.
438 2007-04-27 Murray Cumming <murrayc@murrayc.com>
440 * src/maemo/easysetup/modest-easysetup-wizard.c:
441 (create_page_custom_outgoing): Correct the position of the horizontal separator to
444 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
445 before showing/hiding them, to avoid a crash when clicking on folders when there are no
446 gconf settings. I probably added more checks than necessary, but that is safer.
448 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
449 variable to fix the build, but this seems to be used when it is still NULL.
451 2007-04-27 Murray Cumming <murrayc@murrayc.com>
453 * src/modest-platform.h:
454 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
455 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
456 * src/modest-main.c: Implement this function so we can avoid using
457 maemo-specific API from cross-platform code.
459 * src/modest-tny-account-store.c:
460 (get_smtp_specific_transport_account_for_open_connection):
461 * src/modest-ui-actions.c: (check_for_connection),
462 (modest_ui_actions_on_item_not_found):
463 Use modest_platform_connect_and_wait() and put #idefs around other
464 maemo-specific code, because only maemo currently has a way to
465 identify connection names.
467 2007-04-27 Murray Cumming <murrayc@murrayc.com>
469 * src/modest-tny-account-store.h:
470 * src/modest-tny-account-store.c:
471 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
472 the connection-specific SMTP server settings in the configuration.
474 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
476 * src/maemo/modest-main-window.c: (on_connection_changed),
478 * src/modest-main.c: (main), (start_ui), (send_mail):
479 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
480 that is what is intended.
482 * src/modest-ui-actions.c: (action_send), (action_receive),
483 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
484 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
485 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
486 SMTP server is used when it is specified.
488 (modest_ui_actions_on_send_receive):
489 Check that a connection is open before proceeding.
490 Receive and then send, instead of vice-versa, as per the specification.
492 2007-04-26 Murray Cumming <murrayc@murrayc.com>
494 * src/modest-mail-operation.c:
495 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
496 though I guess it should be something other than NULL.
498 2007-04-26 Murray Cumming <murrayc@murrayc.com>
500 * src/maemo/easysetup/modest-easysetup-wizard.c:
501 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
502 combo twice, to avoid an g_warning and to make it visible again.
503 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
504 attached before detaching it, to avoid a g_warning, and add comment about the implicit
505 (already intended) dereference when detaching, because we then recreate the menu.
506 But I am not sure why the warning was happening, and it is possible that this is a memory
509 2007-04-25 Murray Cumming <murrayc@murrayc.com>
511 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
512 and uri_parse_mailto() utility functions.
513 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
515 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
517 2007-04-24 Murray Cumming <murrayc@murrayc.com>
519 * src/dbus_api/modest-dbus-api.h:
520 * src/dbus_api/modest-dbus-callbacks.c:
521 Use an idle callback to execute the modest code in the application's own thread.
522 Remove the helloworld example method.
523 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
524 parsed, and the open-message method is not implemented because this is not yet implemented in
526 * libmodest-dbus-client/libmodest-dbus-client.c:
527 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
528 (libmodest_dbus_client_open_message):
529 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
531 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
532 body without crashing.
534 * tests/dbus_api/Makefile.am:
535 * tests/dbus_api/test_mail_to.c:
536 * tests/dbus_api/test_open_message.c: New tests for the new methods.
538 2007-04-24 Murray Cumming <murrayc@murrayc.com>
540 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
541 Added file to fix the build. Sorry.
543 * src/dbus_api/Makefile.am:
544 * src/dbus_api/modest-dbus-api.h:
545 * src/dbus_api/modest-dbus-callbacks.h:
546 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
547 (modest_dbus_req_handler):
548 Put constants in a separate header so it can be reused by the
549 client library, without duplication
551 * libmodest-dbus-client/Makefile.am:
552 * libmodest-dbus-client/libmodest-dbus-client.c:
553 (libmodest_dbus_client_call_helloworld),
554 (libmodfest_dbus_client_send_mail),
555 (libmodfest_dbus_client_mailto),
556 (libmodfest_dbus_client_open_message):
557 * libmodest-dbus-client/libmodest-dbus-client.h:
558 (Partly) Implement a send_mail D-Bus method.
560 * tests/dbus_api/Makefile.am:
561 * tests/dbus_api/test_send_mail.c: (main): Added a test for
562 the send_email D-Bus method.
564 2007-04-24 Murray Cumming <murrayc@murrayc.com>
568 * libmodest-dbus-client/Makefile.am:
569 * libmodest-dbus-client/libmodest-dbus-client.c:
570 * libmodest-dbus-client/libmodest-dbus-client.h:
571 * tests/dbus_api/Makefile.am:
572 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
573 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
575 2007-04-24 Murray Cumming <murrayc@murrayc.com>
577 * src/maemo/easysetup/modest-easysetup-wizard.c:
578 (create_page_account_details):
579 * src/maemo/modest-account-settings-dialog.c:
580 (create_page_account_details): Explicitly set auto-capitalization mode for the title
581 widgets, because this might not be the default in future versions of the Maemo GTK+.
582 However, I can not not get capitalization to work even in a simple test case.
584 2007-04-24 Murray Cumming <murrayc@murrayc.com>
586 * src/maemo/easysetup/modest-easysetup-wizard.c:
587 (create_page_custom_incoming), (create_page_custom_outgoing):
588 * src/maemo/modest-account-settings-dialog.c:
589 (create_page_account_details), (create_page_incoming),
590 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
591 instead of using gtk_check_button_with_label(), so they are aligned like the other
592 widgets, as per the UI spec.
594 2007-04-24 Murray Cumming <murrayc@murrayc.com>
596 * src/maemo/easysetup/modest-easysetup-wizard.c:
597 * src/maemo/modest-connection-specific-smtp-edit-window.c:
598 * src/widgets/modest-validating-entry.c:
599 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
600 Modest prefix instead of an EasySetup prefix.
602 2007-04-23 Murray Cumming <murrayc@murrayc.com>
604 * src/widgets/modest-validating-entry.h:
605 * src/widgets/modest-validating-entry.c: (on_insert_text),
606 Added easysetup_validating_entry_set_max_func(), used to set a callback
607 to call when the max number of characters is reached. GtkEntry has a max-length
608 already but is silent about it.
610 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
611 (create_page_account_details), (create_page_user_details),
613 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
614 (create_page_account_details), (create_page_user_details),
615 (create_page_outgoing):
616 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
617 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
618 the UI spec, when the user tries to enter more than the max number of characters.
620 2007-04-23 Murray Cumming <murrayc@murrayc.com>
622 * src/maemo/easysetup/modest-easysetup-wizard.c:
623 (create_page_user_details), (create_page_custom_incoming),
624 (create_page_custom_outgoing):
625 * src/maemo/modest-account-settings-dialog.c:
626 (create_page_user_details), (create_page_incoming),
627 (create_page_outgoing):
628 * src/maemo/modest-connection-specific-smtp-edit-window.c:
629 (modest_connection_specific_smtp_edit_window_init):
630 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
631 not appropriate. Bad Maemo-specific defaults!.
633 2007-04-23 Murray Cumming <murrayc@murrayc.com>
635 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
636 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
637 (modest_signature_editor_dialog_set_settings):
638 Disable the label and textview when the checkbox is disabled, and use the
639 specified (UI spec) default signature text.
641 2007-04-23 Murray Cumming <murrayc@murrayc.com>
643 * src/maemo/modest-connection-specific-smtp-edit-window.c:
644 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
647 * src/modest-account-mgr-helpers.h:
648 * src/modest-account-mgr-helpers.c:
649 Added modest_account_mgr_get/set_signature(), using new gconf keys.
651 * src/maemo/Makefile.am:
652 * src/maemo/modest-signature-editor-dialog.c:
653 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
656 * src/maemo/modest-account-settings-dialog.h:
657 * src/maemo/modest-account-settings-dialog.c:
658 (modest_account_settings_dialog_finalize), (on_button_signature),
659 (save_configuration): Use the new dialog when the Edit button is pressed, and
660 save the changes if necessary, as per the UI spec.
662 2007-04-23 Murray Cumming <murrayc@murrayc.com>
664 * src/maemo/Makefile.am:
665 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
666 based on maemo-develoers email from Dirk.
668 * src/maemo/easysetup/modest-easysetup-wizard.c:
669 (create_page_welcome), (create_page_account_details),
670 (create_page_user_details), (create_page_complete_easysetup),
671 (create_page_custom_incoming), (create_page_custom_outgoing),
672 (create_page_complete_custom),
673 (modest_easysetup_wizard_dialog_init):
674 * src/maemo/modest-account-settings-dialog.c:
675 (create_page_account_details), (create_page_user_details),
676 (create_page_incoming), (create_page_outgoing),
677 (modest_account_settings_dialog_init):
678 * src/maemo/modest-connection-specific-smtp-window.c:
679 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
681 2007-04-23 Murray Cumming <murrayc@murrayc.com>
683 * src/maemo/easysetup/modest-easysetup-wizard.c:
684 (create_page_account_details), (create_page_custom_outgoing),
685 (create_page_complete_custom):
686 * src/maemo/modest-account-settings-dialog.c:
687 (create_page_user_details), (create_page_incoming),
688 (create_page_outgoing):
689 * src/maemo/modest-connection-specific-smtp-edit-window.c:
690 (modest_connection_specific_smtp_edit_window_init):
691 Use the correct (UI spec) port min/max, and use horizontal separators,
694 2007-04-23 Murray Cumming <murrayc@murrayc.com>
696 * src/maemo/easysetup/modest-easysetup-wizard.c:
697 (set_default_custom_servernames):
698 * src/maemo/modest-account-settings-dialog.c:
699 (create_page_incoming), (on_combo_outgoing_security_changed),
700 (on_combo_incoming_security_changed), (create_page_outgoing),
701 (modest_account_settings_dialog_set_account_name),
702 (save_configuration):
703 * src/maemo/modest-connection-specific-smtp-edit-window.c:
704 (on_combo_security_changed),
705 (modest_connection_specific_smtp_edit_window_init),
706 (modest_connection_specific_smtp_edit_window_set_connection),
707 (modest_connection_specific_smtp_edit_window_get_settings):
708 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
711 2007-04-20 Murray Cumming <murrayc@murrayc.com>
714 * src/maemo/easysetup/modest-easysetup-wizard.c:
715 (create_page_custom_outgoing), (create_page_complete_custom):
716 * src/maemo/modest-account-settings-dialog.c:
717 (create_page_user_details), (create_page_outgoing):
718 * src/maemo/modest-account-view-window.c: (button_box_new):
719 Use changed logical IDs as per the most recent UI spec:
720 mcen_bd_emailsetup_edit -> mcen_bd_edit
721 mcen_bd_emailsetup_delete -> mcen_bd_delete
722 mcen_bd_emailsetup_close -> mcen_bd_close
724 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
728 * src/dbus_api/Makefile.am:
729 * src/dbus_api/modest-dbus-callbacks.c:
730 * src/dbus_api/modest-dbus-callbacks.h:
731 * src/maemo/modest-platform.c: (modest_platform_init):
732 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
735 * tests/dbus_api/Makefile.am:
736 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
738 2007-04-20 Murray Cumming <murrayc@murrayc.com>
740 * src/maemo/modest-account-settings-dialog.c:
741 * src/maemo/modest-connection-specific-smtp-edit-window.c:
742 Removed unnecessary includes.
744 2007-04-20 Murray Cumming <murrayc@murrayc.com>
746 * src/maemo/easysetup/modest-easysetup-wizard.c:
747 * src/maemo/modest-account-settings-dialog.c:
748 * src/maemo/modest-connection-specific-smtp-edit-window.c:
749 * src/widgets/Makefile.am:
750 * src/widgets/modest-easysetup-secureauth-combo-box.c:
751 * src/widgets/modest-easysetup-secureauth-combo-box.h:
752 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
753 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
754 * src/widgets/modest-secureauth-combo-box.c:
755 * src/widgets/modest-secureauth-combo-box.h:
756 * src/widgets/modest-serversecurity-combo-box.c:
757 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
758 made the GObject names more consistent with the rest of the Modest code.
760 2007-04-20 Murray Cumming <murrayc@murrayc.com>
762 * src/maemo/easysetup/Makefile.am:
763 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
764 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
765 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
766 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
767 * src/maemo/easysetup/modest-easysetup-wizard.c:
768 * src/maemo/easysetup/modest-validating-entry.c:
769 * src/maemo/easysetup/modest-validating-entry.h:
770 * src/maemo/modest-account-settings-dialog.c:
771 * src/maemo/modest-connection-specific-smtp-edit-window.c:
772 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
773 widgets/ because they are used outside of easysetup too. After checking in,
774 svn will allow me to rename them too.
776 2007-04-20 Murray Cumming <murrayc@murrayc.com>
778 * src/gnome/modest-msg-edit-window.c:
779 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
780 linker error, to fix the build on the GNOME platform.
781 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
782 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
783 ifdefed out to avoid a warning.
785 2007-04-20 Murray Cumming <murrayc@murrayc.com>
787 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
788 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
789 some alternative for GTK+ 2.6.
791 2007-04-19 Murray Cumming <murrayc@murrayc.com>
793 * src/maemo/modest-address-book.c: Added include to avoid a warning.
795 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
796 specified for EmailAccountsDialog in UI spec.
798 * src/maemo/easysetup/modest-easysetup-wizard.c:
799 * src/maemo/easysetup/modest-easysetup-wizard.h:
800 * src/maemo/modest-account-settings-dialog.c:
801 * src/maemo/modest-account-settings-dialog.h:
802 Reuse a member window widget for the connection-specific SMTP server accounts,
803 so we can tell it to create/save the accounts only if we actually save changes.
805 * src/maemo/modest-connection-specific-smtp-edit-window.h:
806 * src/maemo/modest-connection-specific-smtp-edit-window.c:
807 (modest_connection_specific_smtp_edit_window_get_settings):
808 Return a struct instance for temporarily remembering the entered data.
810 * src/maemo/modest-connection-specific-smtp-window.h:
811 * src/maemo/modest-connection-specific-smtp-window.c:
812 (modest_connection_specific_smtp_window_finalize),
813 (modest_connection_specific_smtp_window_fill_with_connections),
815 (modest_connection_specific_smtp_window_save_server_accounts),
816 (update_model_server_names): Do not actually save data until asked,
817 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
819 (on_selection_changed),
820 (modest_connection_specific_smtp_window_init): Disable the edit
821 button when nothing is selected.
823 * src/modest-account-mgr-helpers.c:
824 * src/modest-account-mgr-helpers.h:
825 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
828 2007-04-19 Murray Cumming <murrayc@murrayc.com>
830 * src/modest-account-mgr-helpers.h:
831 * src/modest-account-mgr-helpers.c:
832 (modest_account_mgr_get_unused_account_name),
833 (modest_account_mgr_get_unused_account_display_name): Added these
834 utility functions, to avoid code duplication.
836 * src/maemo/easysetup/modest-easysetup-wizard.c:
837 (create_page_account_details), (create_account):
838 * src/maemo/modest-connection-specific-smtp-edit-window.c:
839 (on_combo_security_changed),
840 (modest_connection_specific_smtp_edit_window_init),
841 (modest_connection_specific_smtp_edit_window_save_settings):
842 * src/maemo/modest-connection-specific-smtp-edit-window.h:
843 * src/maemo/modest-connection-specific-smtp-window.c:
844 (modest_connection_specific_smtp_window_finalize),
845 (modest_connection_specific_smtp_window_fill_with_connections),
846 (on_button_edit), (modest_connection_specific_smtp_window_init):
847 * src/maemo/modest-connection-specific-smtp-window.h:
848 Implementing saving of connection-specific server accounts.
850 But I need to refactor this so we can save the data for each
851 possible connection-specific account and only actually create the server accounts
852 when the easysetup finished, or the OK button is pressed on the account settings
855 2007-04-18 Murray Cumming <murrayc@murrayc.com>
857 * src/maemo/modest-connection-specific-smtp-edit-window.c:
858 (on_combo_security_changed):
859 (modest_connection_specific_smtp_edit_window_init):
860 Auto-fill the port number as in the account settings.
862 (modest_connection_specific_smtp_edit_window_set_connection):
863 * src/maemo/modest-connection-specific-smtp-edit-window.h:
864 * src/maemo/modest-connection-specific-smtp-window.c:
865 (fill_with_connections), (on_button_edit),
866 (modest_connection_specific_smtp_window_init):
867 Turn the edit window into a dialog to simplify the code, and
868 set a WM hint as in a GtkDialog, because only a popup can be on top of
869 another window in Maemo, and popups usually have no WM decoration.
872 * src/modest-account-mgr-helpers.c:
873 (modest_account_mgr_set_connection_specific_smtp),
874 (modest_account_mgr_remove_connection_specific_smtp),
875 (modest_account_mgr_get_connection_specific_smtp):
876 * src/modest-account-mgr-helpers.h: Some functions to write the
877 connection-specific SMTP server information. Not yet used.
880 * src/widgets/modest-folder-view.c: (text_cell_data):
881 Fix a warning about an uninitialized variable.
882 (on_configuration_key_changed): Put an #ifdef around the use
883 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
885 2007-04-18 Murray Cumming <murrayc@murrayc.com>
887 * src/maemo/modest-account-settings-dialog.h:
888 * src/maemo/modest-account-settings-dialog.c:
889 Added connect_for_modified() utility function to mark the new modified boolean.
891 (create_page_account_details), (create_page_user_details),
892 (create_page_incoming), (create_page_outgoing), (on_response),
893 (modest_account_settings_dialog_init),
894 (modest_account_settings_dialog_set_account_name):
895 Only warn about unsaved changes when there are actually unsaved changes.
897 * src/modest-account-mgr-helpers.c:
898 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
899 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
900 to get the data from there in future.
902 2007-04-18 Murray Cumming <murrayc@murrayc.com>
906 * src/modest-account-mgr-helpers.h:
907 * src/modest-account-mgr-helpers.c:
908 Store the security account setting in a single conf key instead of using
909 the options list, so that the list is left for just the to-be-removed camel hack,
910 and because gconf_client_set_list() is failing for some reason.
912 * src/modest-account-mgr.c:
913 (modest_account_mgr_add_server_account):
914 * src/maemo/modest-account-settings-dialog.c:
915 (modest_account_settings_dialog_set_account_name),
916 (save_configuration): Use the renamed functions.
919 2007-04-18 Murray Cumming <murrayc@murrayc.com>
921 * src/widgets/Makefile.am:
922 * src/widgets/modest-limit-retrieve-combo-box.c:
923 * src/widgets/modest-limit-retrieve-combo-box.h:
924 * src/widgets/modest-retrieve-combo-box.c:
925 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
926 the account settings dialog.
929 * src/modest-account-mgr-helpers.h:
930 * src/modest-account-mgr-helpers.c:
931 (modest_server_account_get_option_secure_auth),
932 (modest_server_account_set_option_secure_auth):
933 * src/modest-account-mgr.c:
934 (modest_account_mgr_add_server_account):
935 Use the existing AUTH_MECH conf key for the secure-auth setting,
936 instead of putting it in the list options, because this was actually used already.
938 * src/maemo/modest-account-settings-dialog.c:
939 (create_page_account_details),
940 (modest_account_settings_dialog_set_account_name),
941 (save_configuration):
942 * src/maemo/modest-account-settings-dialog.h:
943 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
944 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
946 2007-04-18 Murray Cumming <murrayc@murrayc.com>
948 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
949 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
950 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
953 * src/maemo/modest-account-settings-dialog.c:
954 (create_page_incoming), (on_combo_outgoing_security_changed),
955 (on_combo_incoming_security_changed), (create_page_outgoing),
956 (modest_account_settings_dialog_set_account_name),
957 (save_configuration): Load/Save the port number, and change it when the
958 security combo changes, to suitable defaults.
960 2007-04-17 Murray Cumming <murrayc@murrayc.com>
962 * src/modest-account-mgr.c:
963 (modest_account_mgr_add_server_account): Set the security and secure-auth
964 options, and add a comment saying that the other camel-specific options should be
967 2007-04-17 Murray Cumming <murrayc@murrayc.com>
969 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
971 * src/modest-tny-account-store.c: (account_list_free),
972 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
973 cursor->data after unreffing it. But there is some strange stuff there so it might not be
976 2007-04-17 Murray Cumming <murrayc@murrayc.com>
978 * src/modest-protocol-info.c:
979 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
980 is required by our UI spec. Maybe something in our implementation will use this eventually.
981 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
982 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
983 instead of the previous 0 placeholder.
985 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
986 secure-auth settings.
987 * src/modest-account-mgr-helpers.h:
988 * src/modest-account-mgr-helpers.c:
989 (modest_server_account_data_get_option_secure_auth),
990 (modest_server_account_set_option_secure_auth),
991 (modest_server_account_data_get_option_security),
992 (modest_server_account_set_option_security): Added this API for getting and setting the security
993 and secure-auth settings.
995 * src/maemo/modest-account-settings-dialog.h:
996 * src/maemo/modest-account-settings-dialog.c:
997 (modest_account_settings_dialog_finalize), (check_data),
998 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
999 about changing titles.
1000 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1001 (save_configuration): Save the security and secure-auth settings.
1003 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1004 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1006 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1008 * src/modest-defs.h:
1009 * src/modest-account-mgr.c:
1010 (modest_account_mgr_add_server_account):
1011 Added and used defines for the options key and value pair strings,
1012 that are used so far, though they do not seem to correspond to anything in our
1013 UI specs or ModestProtocol enum.
1015 * src/modest-account-mgr-helpers.h:
1016 * src/modest-account-mgr-helpers.c:
1017 (compare_option_strings_for_name),
1018 (modest_server_account_data_get_option_value),
1019 (modest_server_account_data_get_option_bool),
1020 (modest_account_mgr_get_server_account_option):
1021 Added helper functions for parsing the options GSList.
1023 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1025 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1026 display name is based on the supplied account name.
1027 * src/modest-account-mgr.c:
1028 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1029 with an inefficient, but good-enough, implementation.
1031 * src/maemo/easysetup/modest-easysetup-wizard.c:
1032 (create_page_account_details), (on_before_next), (create_account):
1033 Check for existing display names rather than (non-user-visible) account names, and just
1034 create and set a unique account name at the end.
1036 * src/maemo/modest-account-settings-dialog.c:
1037 (modest_account_settings_dialog_init),
1038 (modest_account_settings_dialog_set_account_name),
1039 (create_page_incoming): Show the display name, instead of the account name.
1040 (on_response): Do some (not all) extra checks, as in the UI spec.
1041 (save_configuration): Save the display name if it was changed.
1043 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1045 * po/en_GB.po: Added needed logical ID and translation.
1046 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1047 (init_view): Made the is-default column clicking work.
1049 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1052 * src/maemo/easysetup/Makefile.am:
1053 * src/maemo/easysetup/modest-easysetup-wizard.c:
1054 (modest_easysetup_wizard_dialog_init):
1055 * src/maemo/easysetup/provider-data-test.keyfile:
1056 * src/maemo/easysetup/provider-data.keyfile:
1057 Moved the provider data file to the new modest-providers-data package and used it from there.
1059 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1061 * src/modest-local-folder-info.c:
1062 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1063 N_() was already used on the static strings, but this just marks it for translation without
1064 using the translation.
1066 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1068 * src/maemo/modest-account-settings-dialog.c:
1069 (create_page_incoming),
1070 (modest_account_settings_dialog_set_account_name):
1071 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1072 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1073 I will do this if nobody else gets there first.
1075 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1077 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1078 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1079 save the security stuff.
1081 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1083 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1084 Set the email address and user fullname, which I now see must be
1087 * src/maemo/modest-account-settings-dialog.h:
1088 * src/maemo/modest-account-settings-dialog.c:
1090 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1091 leave-on-server and authentication.
1092 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1095 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1098 * src/maemo/modest-account-settings-dialog.c:
1099 * src/maemo/modest-account-settings-dialog.h:
1100 Most (but not all) of the widgets are now present as specified by the UI spec.
1101 No changes are yet saved, and some details are not properly shown yet.
1103 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1105 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1107 * src/maemo/Makefile.am:
1108 * src/maemo/modest-account-settings-dialog.c:
1109 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1110 an existing account. Doesn't do much yet.
1112 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1113 Open the accounts settings dialog when Edit is clicked.
1115 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1117 * src/maemo/easysetup/Makefile.am:
1118 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1120 * src/maemo/easysetup/modest-easysetup-wizard.c:
1121 (modest_easysetup_wizard_dialog_init):
1122 Try to get the source directory from the build system,
1123 instead of hard-coding "./" into the source code, when opening our local
1124 copies of the configuration files.
1125 But this still fails when opening the wizard from the Accounts window,
1126 maybe because the working directory seems to change at runtime.
1127 So the wizard will fail the second time unless you copy the files into their
1128 proper locations - see the stdout warnings for the paths.
1130 (create_page_account_details),(on_before_next):
1131 Check for existing non-server accounts instead of server accounts,
1132 so the default account name is useful again, and to prevent trying to
1135 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1136 Show the wizard when New is clicked.
1138 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1139 (init_view): Show the column headers, and show the columns that are
1140 specified in the UI specs. However, something in Maemo's GTK+ prevents
1141 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1142 change the default account. This is despite unsetting the special properties.
1144 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1146 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1147 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1148 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1149 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1150 to make that clearer.
1151 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1153 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1155 * src/maemo/modest-account-view-window.c:
1156 (modest_account_view_window_init),
1157 (modest_account_view_window_new):
1158 Use the same buttons as specified in the
1159 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1160 the existing widgets, which never had a chance of working.
1161 Put the ModestAccountView treeview in a scrolled window.
1162 Do not repeat the initialization in both _init() and _new().
1164 * src/widgets/modest-account-view.c: (update_account_view):
1165 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1166 this widget and window shows no accounts.
1168 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1170 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1172 * src/maemo/easysetup/modest-easysetup-wizard.c:
1173 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1174 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1175 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1178 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1179 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1180 accounts exist yet, as in the UI spec.
1182 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1184 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1186 * src/maemo/Makefile.am:
1187 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1188 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1189 New window for editing connection-specific smtp details.
1190 Not fully implemented.
1192 * src/maemo/modest-connection-specific-smtp-window.c:
1193 (modest_connection_specific_smtp_window_finalize) :
1194 unref the tree model.
1195 (on_button_edit): Show the edit window.
1197 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1199 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1202 * src/maemo/Makefile.am:
1203 * src/maemo/modest-connection-specific-smtp-window.c:
1204 * src/maemo/modest-connection-specific-smtp-window.h:
1205 New window for showing the list of connections, for connection-specific
1206 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1207 * src/maemo/easysetup/modest-easysetup-wizard.c:
1208 (create_page_custom_outgoing): Show the new window when the button is clicked.
1210 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1212 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1213 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1214 * src/maemo/modest-msg-edit-window.c:
1215 (modest_msg_edit_window_insert_image):
1216 * src/modest-conf.c: (modest_conf_key_escape):
1217 * src/modest-mail-operation.c:
1218 (modest_mail_operation_send_new_mail):
1219 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1220 (modest_ui_actions_on_new_account):
1221 * src/widgets/modest-attachment-view.c: (update_filename_request):
1222 * src/widgets/modest-mail-header-view.c:
1223 Corrected warnings that were breaking the build, by commenting out unused variables,
1224 and a function, and by including a header.
1226 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1228 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1229 so we can #ifdef around platform-specific code when necessary.
1230 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1231 to allow this to build for the GNOME platform too.
1233 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1235 * src/maemo/easysetup/modest-easysetup-wizard.c:
1236 Added util_increment_name() and used it in create_page_account_details()
1237 to make sure that the default account name is always a new name.
1239 (modest_easysetup_wizard_dialog_init),
1240 (set_default_custom_servernames): Some minor memory management fixes.
1242 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1246 * src/modest-runtime.c: (init_i18n): Restored the translation
1247 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1248 are defined in config.h, and the translations are installed.
1250 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1251 is defined for translation.
1253 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1255 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1257 * src/maemo/easysetup/modest-easysetup-wizard.c:
1258 (modest_easysetup_wizard_dialog_init):
1259 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1260 Use realistic paths (though they should use $prefix generically) to the
1261 mcc_mapping and provider-data.keyfile files which might work when they
1262 are installed by the future version of the operator-wizard package,
1263 and then fallback to paths in our source code, with an explanatory
1266 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1270 * src/maemo/Makefile.am:
1271 * src/maemo/easysetup/: Added files from the previously-exernal
1272 osso-modest-easysetup.
1273 * src/maemo/modest-main-window-ui.h:
1274 * src/modest-ui-actions.c:
1275 * src/modest-ui-actions.h:
1276 Added modest_ui_actions_on_new_account() as a signal handler for the
1277 New Account menu item. It shows the easysetup wizard.
1278 * po/en_GB.po: Added additional needed logical IDs and translations.
1280 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1281 Apparently ChangeLog is not used for some vague Nokia legal reasons.