1 2007-05-08 Murray Cumming <murrayc@murrayc.com>
4 * src/modest-account-mgr-helpers.h:
5 * src/modest-account-mgr-helpers.c:
6 Added modest_server_account_get_username_has_succeeded(),
7 modest_server_account_set_username_has_succeeded().
8 (modest_server_account_set_username),
9 Reset the has-succeeded flag if the username changes.
11 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
12 * src/maemo/modest-connection-specific-smtp-window.c:
13 (modest_connection_specific_smtp_window_save_server_accounts):
14 Use modest_server_account_set_username() instead of using
15 modest_conf_set_string() directly, so that the has-succeeded flag is always
18 * src/modest-ui-actions.c:
19 (modest_ui_actions_on_password_requested): Dim the username entry if
20 the username has ever worked, as per the UI spec.
22 2007-05-08 Murray Cumming <murrayc@murrayc.com>
24 * src/modest-tny-account-store.c: (get_password):
25 * src/modest-ui-actions.c:
26 (modest_ui_actions_on_password_requested):
27 Allow the username to be changed too, though there is more work to
28 be done on exactly how this behaves.
30 2007-05-08 Murray Cumming <murrayc@murrayc.com>
32 * src/modest-account-mgr-helpers.h:
33 * src/modest-account-mgr-helpers.c:
34 Added modest_account_mgr_get_display_name(),
35 modest_server_account_get_username(),
36 modest_server_account_set_username(),
37 modest_server_account_set_password(),
38 modest_server_account_get_hostname() functions so we do not need to
39 use the conf API directly.
41 * src/maemo/modest-main-window.c: (connect_signals):
42 Actually connect ot the ModestAccountStore::request-password signal,
43 so that we show the dialog when the password is requested by Tinymail,
44 for isntance if it is empty.
46 * src/modest-marshal.list:
47 * src/modest-tny-account-store.c:
48 (modest_tny_account_store_class_init), (get_password),
49 (modest_tny_account_store_alert):
50 * src/modest-tny-account-store.h:
51 * src/modest-ui-actions.h:
52 * src/modest-ui-actions.c:
53 (modest_ui_actions_on_password_requested):
54 Change the signal parameters, so it is obvious that we are providing
55 the non human-readable server name, and receiving both the username
56 and password, though changing of the username is not yet implemented.
57 Change the dialog UI to match the Maemo UI specifications, with #idfefing
58 for the GNOME version.
60 This should fix the projects.maemo.org bug NB#56209, though it does not
61 work on Bora, because the gconf_client_get() for the password fails
62 immediately after we save it with gconf_client_set().
64 2007-05-08 Murray Cumming <murrayc@murrayc.com>
67 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
68 caused an undefined symbol error:
69 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
71 2007-05-08 Murray Cumming <murrayc@murrayc.com>
73 * src/modest-tny-account-store.c:
74 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
75 using a GError instead of a string message, so we can translate it in
78 2007-05-08 Murray Cumming <murrayc@murrayc.com>
80 * src/maemo/modest-address-book.c:
81 (modest_address_book_check_names):
82 * src/maemo/modest-msg-view-window.c:
83 (modest_msg_view_window_clipboard_owner_change):
84 * src/modest-init.c: (modest_init_init_ui):
85 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
86 (update_folders_cb), (modest_mail_operation_update_account):
87 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
88 (modest_ui_actions_on_msg_attachment_clicked),
89 (modest_ui_actions_on_msg_recpt_activated):
90 * src/widgets/modest-header-view.c: (drag_data_get_cb):
91 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
92 (modest_msg_view_search_next):
93 * src/widgets/modest-recpt-editor.c:
94 (modest_recpt_editor_on_button_release_event),
95 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
96 g_message(). At this point we should only be seeing interesting errors on
97 stdout. Debugging messages could be #ifdefed-out if they are still useful.
99 2007-05-07 Murray Cumming <murrayc@murrayc.com>
101 (modest_wizard_dialog_force_title_update):
102 * src/maemo/easysetup/modest-wizard-dialog.h:
103 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
104 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
105 can update the title when appropriate. Otherwise the title is wrong if the
106 pages are added after adding the notebook to the dialog.
107 This must be a problem in HildonWizardDialog too.
108 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
110 * src/maemo/easysetup/modest-easysetup-wizard.c:
111 (create_subsequent_customsetup_pages),
112 (create_subsequent_easysetup_pages):
113 Call modest_wizard_dialog_force_title_update() so that the title is
114 correct even with GTK+ < 2.10.
115 This fixes projects.maemo.org bug NB#56145 .
117 2007-05-07 Murray Cumming <murrayc@murrayc.com>
119 * src/maemo/modest-platform.c:
120 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
121 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
124 2007-05-07 Murray Cumming <murrayc@murrayc.com>
126 * src/widgets/modest-window.h:
127 * src/widgets/modest-window.c: Added a save_state_func vfunc,
128 and modest_window_save_state(), which invokes it.
130 * src/widgets/modest-window-mgr.h:
131 * src/widgets/modest-window-mgr.c:
132 Added modest_window_mgr_save_state_for_all_windows(), which calls
133 the save_state vfunc on all registered windows, if implemented.
135 * src/gnome/modest-msg-edit-window.c:
136 * src/gnome/modest-msg-view-window.c:
137 * src/maemo/modest-msg-edit-window.c:
138 * src/maemo/modest-msg-view-window.c:
139 * src/maemo/modest-main-window.c:
140 Specify the existing save_settings functions as implementations of
141 ModestWindow::save_state_func().
143 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
144 Call modest_window_mgr_save_state_for_all_windows(). This happens before
145 enabling hibernation, for instance.
147 We may need to do the same thing for restoring settings.
150 2007-05-07 Murray Cumming <murrayc@murrayc.com>
152 * src/widgets/modest-window-mgr.c:
153 * src/widgets/modest-window-mgr.h:
154 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
155 modest_window_mgr_get_hibernation_is_prevented().
157 * src/maemo/modest-main-window.c:
158 (on_hildon_program_is_topmost_notify): Prevent hibernation
159 (possible when the application goes to the background in the WM),
160 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
162 * src/maemo/easysetup/modest-easysetup-wizard.c:
163 (modest_easysetup_wizard_dialog_init):
164 * src/maemo/modest-account-settings-dialog.c:
165 (modest_account_settings_dialog_init):
166 * src/maemo/modest-connection-specific-smtp-edit-window.c:
167 (modest_connection_specific_smtp_edit_window_init):
168 * src/maemo/modest-connection-specific-smtp-window.c:
169 (modest_connection_specific_smtp_window_init):
170 * src/maemo/modest-signature-editor-dialog.c:
171 (modest_signature_editor_dialog_init):
172 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
173 prevent hibernation while any of these account settings dialogs are open.
175 2007-05-04 Murray Cumming <murrayc@murrayc.com>
177 * src/maemo/Makefile.am:
178 * src/maemo/modest-osso-state-saving.c:
179 * src/maemo/modest-osso-state-saving.h: Added
180 modest_osso_load_state() and modest_osso_save_state() though they do
181 nothing now. They should iterate through all the open windows and load/save
183 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
184 save state when closing.
186 * src/maemo/modest-main-window.c:
187 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
188 Add a notification handler for the HildonProgram::is-topmost property,
189 so we can allow hibernation when the application goes into the background.
190 But we still need to detect when the accounts setup windows are open so
191 we can stop hibernation when they are open.
192 To do this, I also added the main window the HildonProgram. This might have
193 other side-effects/benefits, and should maybe be done for other windows.
195 * src/maemo/modest-osso-autosave-callbacks.h:
196 * src/maemo/modest-osso-autosave-callbacks.c:
197 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
198 though it does not do anything yet, and we might never need this to do
199 anything. For instance, we already save drafts.
201 * src/maemo/modest-platform.c: (modest_platform_init):
202 Specify the libosso auto-save callback.
204 2007-05-03 Murray Cumming <murrayc@murrayc.com>
206 * src/maemo/modest-platform.c:
207 (modest_platform_set_update_interval):
208 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
209 aparently stays valid between application instances, so we can use this
210 to remove and reset it later. According to a maemo-developers email from
213 2007-05-03 Murray Cumming <murrayc@murrayc.com>
215 * configure.ac: Depend on libalarm for Maemo.
217 * src/dbus_api/modest-dbus-api.h:
218 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
219 (on_send_receive), (modest_dbus_req_handler):
220 Handle a SEND_RECEIVE D-Bus method.
222 * libmodest-dbus-client/libmodest-dbus-client.c:
223 (libmodest_dbus_client_send_and_receive):
224 * libmodest-dbus-client/libmodest-dbus-client.h:
225 Add C convenience functions for calling the new D-Bus method.
227 * src/modest-platform.h:
228 * src/gnome/modest-platform.c:
229 * src/maemo/modest-platform.c:
230 Added modest_platform_set_update_interval(), which uses the
232 (modest_platform_init),
233 Call modest_platform_set_update_interval(), using a hard-coded
234 interval for now (until the global settings dialog is implemented),
235 though I am not sure that this makes sense yet.
237 2007-05-02 Murray Cumming <murrayc@murrayc.com>
239 * src/dbus_api/modest-dbus-callbacks.c:
240 (modest_osso_cb_hw_state_handler):
241 * src/dbus_api/modest-dbus-callbacks.h:
242 * src/maemo/modest-platform.c: (modest_platform_init):
243 Registered (empty) callbacks for the osso hardware state D-Bus signals,
244 in case this has some effect on the ability for Maemo to ping the
247 2007-05-02 Murray Cumming <murrayc@murrayc.com>
249 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
250 Comment out an if() that checks a gchar for < 0, causing a build-breaking
251 warning. It is probably a logic error, but I need to fix the build.
253 2007-05-02 Murray Cumming <murrayc@murrayc.com>
255 * src/modest-account-mgr.h:
256 * src/modest-account-mgr.c:
257 (modest_account_mgr_account_names): Add a gboolean enabled_only
258 parameter, so we can get lists of onlt the enabled accounts.
260 (modest_account_mgr_add_account),,
261 (modest_account_mgr_account_with_display_name_exists):
262 * src/maemo/modest-msg-edit-window.c: (get_transports):
263 * src/modest-account-mgr-helpers.c:
264 (modest_account_mgr_set_first_account_as_default):
265 * src/modest-init.c: (init_default_account_maybe):
266 * src/modest-tny-account-store.c: (get_accounts):
267 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
268 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
269 * tests/check_account-mgr.c: (START_TEST):
270 Provide the extra parameter, as appropriate.
272 * src/widgets/modest-account-view.c: (update_account_view):
273 Do not show disabled accounts (meaning that there is no way to
274 enable/disable accounts in the UI (the feature is not in our UI
275 specification), so we can use this internally only to mark unfinished
276 or temporary account data.
278 * src/maemo/easysetup/modest-easysetup-wizard.c:
279 (create_account): Add boolean enable parameter, so we can specify FALSE
280 to create the temporary account.
281 (on_button_edit_advanced_settings): Create the temporary account as disabled.
282 (on_before_next): When finishing, when there is a temporary account, just
284 Also, use a timeout to delay the showing of the dialog until gconf is likely
285 to return correct information, due to a maemo gconf bug that is fixed in
286 osso 1.1, but not yet in Bora.
287 However, the dialog stays on screen after it is destroyed.
289 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
290 for invalid data when cancelling. Use a hildon note instead of a dialog
291 to complain about invalid data. Do not show the account-saved note if the
292 account is disabled (a temporary account that will not really be saved for use
295 2007-04-30 Murray Cumming <murrayc@murrayc.com>
297 * src/modest-account-mgr-helpers.h:
298 * src/modest-account-mgr-helpers.c:
299 Added modest_account_mgr_unset_default_account(),
300 Added modest_account_mgr_set_first_account_as_default().
302 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
303 If it was the default account, unset the default account name.
305 * src/maemo/modest-account-view-window.c:
306 (on_delete_button_clicked): If it was the default account,
307 set the first remaining account as the default instead.
309 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
310 a NULL account or a NULL default account, to prevent a crash. This should
311 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
314 2007-04-30 Murray Cumming <murrayc@murrayc.com>
316 * src/widgets/modest-recpt-editor.c:
317 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
318 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
319 TODO comment for this. This fixes the build.
321 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
322 be the best place for it. This will in future update all auto-update accounts,
323 rather than just the current/default account, when that gconf key exists.
324 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
325 if there are no accounts, before calling do_send_receive().
326 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
328 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
329 * src/maemo/modest-main-window-ui.h:
330 * src/maemo/modest-main-window.c: (on_connection_changed),
331 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
332 directly, becaue the signal handler does more.
334 2007-04-30 Murray Cumming <murrayc@murrayc.com>
336 * src/modest-account-mgr-helpers.c:
337 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
338 for the case that the account does not exist.
340 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
341 (equivalent to the modest account name) rather than the tinymail account name
342 (equivalent to the modest account title - human readable) to get the account data.
343 Check for null account data to prevent the crash, and add a TODO comment saying that
344 this needs fixing because it is using the server account name instead of the account name.
346 2007-04-29 Murray Cumming <murrayc@murrayc.com>
348 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
349 * src/maemo/modest-account-settings-dialog.c: (show_error),
351 Use hildon_note_new_information() for informative and error messages,
352 which seems to be expected for Maemo applications (no documentation that I know of
353 says this). I am surprised that there is no distinction between info and error
356 2007-04-29 Murray Cumming <murrayc@murrayc.com>
358 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
359 it is easy to find where this is used.
361 * src/maemo/easysetup/modest-easysetup-wizard.c:
362 (create_page_welcome), (create_page_account_details),
363 (create_page_user_details), (create_page_complete_easysetup),
364 (create_page_custom_incoming), (create_page_custom_outgoing),
365 (create_page_complete_custom):
366 * src/maemo/modest-account-settings-dialog.c:
367 (create_page_account_details), (create_page_user_details),
368 (create_page_incoming), (create_page_outgoing):
369 * src/maemo/modest-account-view-window.c: (window_vbox_new):
370 * src/maemo/modest-connection-specific-smtp-edit-window.c:
371 (modest_connection_specific_smtp_edit_window_init):
372 * src/maemo/modest-connection-specific-smtp-window.c:
373 (modest_connection_specific_smtp_window_init):
374 * src/maemo/modest-signature-editor-dialog.c:
375 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
376 and scrolling policy as per the Email Application Layout Guide, if I have
379 2007-04-27 Murray Cumming <murrayc@murrayc.com>
381 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
382 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
383 which were empty, because these vfuncs have been removed from TnyAccountStore.
384 This fixes the build.
386 2007-04-27 Murray Cumming <murrayc@murrayc.com>
388 * src/maemo/modest-main-window.c:
389 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
390 showing/hiding it. Added TODO because it probably should not be NULL.
391 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
392 because unnecessary g_warnings() make degugging difficult.
394 2007-04-27 Murray Cumming <murrayc@murrayc.com>
396 * src/maemo/modest-msg-edit-window.c:
397 (modest_msg_edit_window_select_color),
398 (modest_msg_edit_window_select_background_color): 2 const corrections and
399 moving 2 #endifs before closing brackets, to fix the build.
401 2007-04-27 Murray Cumming <murrayc@murrayc.com>
403 * src/maemo/easysetup/modest-easysetup-wizard.h:
404 * src/maemo/easysetup/modest-easysetup-wizard.c:
405 (modest_easysetup_wizard_dialog_finalize),
406 (on_button_edit_advanced_settings), (create_page_complete_custom),
407 (on_response), (create_account):
408 Implement the Advanced Settings edit button, by saving the account information,
409 for the Advanded Settings dialog to use directly from gconf, and removing it
410 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
411 Bug #5533 in the projects.maemo.org bugzilla.
413 2007-04-27 Murray Cumming <murrayc@murrayc.com>
415 * src/maemo/modest-msg-view-window.c:
416 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
417 when opening a message window.
419 2007-04-27 Murray Cumming <murrayc@murrayc.com>
421 * src/maemo/easysetup/modest-easysetup-wizard.c:
422 (create_page_custom_outgoing): Correct the position of the horizontal separator to
425 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
426 before showing/hiding them, to avoid a crash when clicking on folders when there are no
427 gconf settings. I probably added more checks than necessary, but that is safer.
429 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
430 variable to fix the build, but this seems to be used when it is still NULL.
432 2007-04-27 Murray Cumming <murrayc@murrayc.com>
434 * src/modest-platform.h:
435 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
436 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
437 * src/modest-main.c: Implement this function so we can avoid using
438 maemo-specific API from cross-platform code.
440 * src/modest-tny-account-store.c:
441 (get_smtp_specific_transport_account_for_open_connection):
442 * src/modest-ui-actions.c: (check_for_connection),
443 (modest_ui_actions_on_item_not_found):
444 Use modest_platform_connect_and_wait() and put #idefs around other
445 maemo-specific code, because only maemo currently has a way to
446 identify connection names.
448 2007-04-27 Murray Cumming <murrayc@murrayc.com>
450 * src/modest-tny-account-store.h:
451 * src/modest-tny-account-store.c:
452 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
453 the connection-specific SMTP server settings in the configuration.
455 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
457 * src/maemo/modest-main-window.c: (on_connection_changed),
459 * src/modest-main.c: (main), (start_ui), (send_mail):
460 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
461 that is what is intended.
463 * src/modest-ui-actions.c: (action_send), (action_receive),
464 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
465 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
466 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
467 SMTP server is used when it is specified.
469 (modest_ui_actions_on_send_receive):
470 Check that a connection is open before proceeding.
471 Receive and then send, instead of vice-versa, as per the specification.
473 2007-04-26 Murray Cumming <murrayc@murrayc.com>
475 * src/modest-mail-operation.c:
476 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
477 though I guess it should be something other than NULL.
479 2007-04-26 Murray Cumming <murrayc@murrayc.com>
481 * src/maemo/easysetup/modest-easysetup-wizard.c:
482 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
483 combo twice, to avoid an g_warning and to make it visible again.
484 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
485 attached before detaching it, to avoid a g_warning, and add comment about the implicit
486 (already intended) dereference when detaching, because we then recreate the menu.
487 But I am not sure why the warning was happening, and it is possible that this is a memory
490 2007-04-25 Murray Cumming <murrayc@murrayc.com>
492 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
493 and uri_parse_mailto() utility functions.
494 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
496 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
498 2007-04-24 Murray Cumming <murrayc@murrayc.com>
500 * src/dbus_api/modest-dbus-api.h:
501 * src/dbus_api/modest-dbus-callbacks.c:
502 Use an idle callback to execute the modest code in the application's own thread.
503 Remove the helloworld example method.
504 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
505 parsed, and the open-message method is not implemented because this is not yet implemented in
507 * libmodest-dbus-client/libmodest-dbus-client.c:
508 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
509 (libmodest_dbus_client_open_message):
510 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
512 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
513 body without crashing.
515 * tests/dbus_api/Makefile.am:
516 * tests/dbus_api/test_mail_to.c:
517 * tests/dbus_api/test_open_message.c: New tests for the new methods.
519 2007-04-24 Murray Cumming <murrayc@murrayc.com>
521 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
522 Added file to fix the build. Sorry.
524 * src/dbus_api/Makefile.am:
525 * src/dbus_api/modest-dbus-api.h:
526 * src/dbus_api/modest-dbus-callbacks.h:
527 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
528 (modest_dbus_req_handler):
529 Put constants in a separate header so it can be reused by the
530 client library, without duplication
532 * libmodest-dbus-client/Makefile.am:
533 * libmodest-dbus-client/libmodest-dbus-client.c:
534 (libmodest_dbus_client_call_helloworld),
535 (libmodfest_dbus_client_send_mail),
536 (libmodfest_dbus_client_mailto),
537 (libmodfest_dbus_client_open_message):
538 * libmodest-dbus-client/libmodest-dbus-client.h:
539 (Partly) Implement a send_mail D-Bus method.
541 * tests/dbus_api/Makefile.am:
542 * tests/dbus_api/test_send_mail.c: (main): Added a test for
543 the send_email D-Bus method.
545 2007-04-24 Murray Cumming <murrayc@murrayc.com>
549 * libmodest-dbus-client/Makefile.am:
550 * libmodest-dbus-client/libmodest-dbus-client.c:
551 * libmodest-dbus-client/libmodest-dbus-client.h:
552 * tests/dbus_api/Makefile.am:
553 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
554 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
556 2007-04-24 Murray Cumming <murrayc@murrayc.com>
558 * src/maemo/easysetup/modest-easysetup-wizard.c:
559 (create_page_account_details):
560 * src/maemo/modest-account-settings-dialog.c:
561 (create_page_account_details): Explicitly set auto-capitalization mode for the title
562 widgets, because this might not be the default in future versions of the Maemo GTK+.
563 However, I can not not get capitalization to work even in a simple test case.
565 2007-04-24 Murray Cumming <murrayc@murrayc.com>
567 * src/maemo/easysetup/modest-easysetup-wizard.c:
568 (create_page_custom_incoming), (create_page_custom_outgoing):
569 * src/maemo/modest-account-settings-dialog.c:
570 (create_page_account_details), (create_page_incoming),
571 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
572 instead of using gtk_check_button_with_label(), so they are aligned like the other
573 widgets, as per the UI spec.
575 2007-04-24 Murray Cumming <murrayc@murrayc.com>
577 * src/maemo/easysetup/modest-easysetup-wizard.c:
578 * src/maemo/modest-connection-specific-smtp-edit-window.c:
579 * src/widgets/modest-validating-entry.c:
580 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
581 Modest prefix instead of an EasySetup prefix.
583 2007-04-23 Murray Cumming <murrayc@murrayc.com>
585 * src/widgets/modest-validating-entry.h:
586 * src/widgets/modest-validating-entry.c: (on_insert_text),
587 Added easysetup_validating_entry_set_max_func(), used to set a callback
588 to call when the max number of characters is reached. GtkEntry has a max-length
589 already but is silent about it.
591 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
592 (create_page_account_details), (create_page_user_details),
594 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
595 (create_page_account_details), (create_page_user_details),
596 (create_page_outgoing):
597 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
598 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
599 the UI spec, when the user tries to enter more than the max number of characters.
601 2007-04-23 Murray Cumming <murrayc@murrayc.com>
603 * src/maemo/easysetup/modest-easysetup-wizard.c:
604 (create_page_user_details), (create_page_custom_incoming),
605 (create_page_custom_outgoing):
606 * src/maemo/modest-account-settings-dialog.c:
607 (create_page_user_details), (create_page_incoming),
608 (create_page_outgoing):
609 * src/maemo/modest-connection-specific-smtp-edit-window.c:
610 (modest_connection_specific_smtp_edit_window_init):
611 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
612 not appropriate. Bad Maemo-specific defaults!.
614 2007-04-23 Murray Cumming <murrayc@murrayc.com>
616 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
617 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
618 (modest_signature_editor_dialog_set_settings):
619 Disable the label and textview when the checkbox is disabled, and use the
620 specified (UI spec) default signature text.
622 2007-04-23 Murray Cumming <murrayc@murrayc.com>
624 * src/maemo/modest-connection-specific-smtp-edit-window.c:
625 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
628 * src/modest-account-mgr-helpers.h:
629 * src/modest-account-mgr-helpers.c:
630 Added modest_account_mgr_get/set_signature(), using new gconf keys.
632 * src/maemo/Makefile.am:
633 * src/maemo/modest-signature-editor-dialog.c:
634 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
637 * src/maemo/modest-account-settings-dialog.h:
638 * src/maemo/modest-account-settings-dialog.c:
639 (modest_account_settings_dialog_finalize), (on_button_signature),
640 (save_configuration): Use the new dialog when the Edit button is pressed, and
641 save the changes if necessary, as per the UI spec.
643 2007-04-23 Murray Cumming <murrayc@murrayc.com>
645 * src/maemo/Makefile.am:
646 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
647 based on maemo-develoers email from Dirk.
649 * src/maemo/easysetup/modest-easysetup-wizard.c:
650 (create_page_welcome), (create_page_account_details),
651 (create_page_user_details), (create_page_complete_easysetup),
652 (create_page_custom_incoming), (create_page_custom_outgoing),
653 (create_page_complete_custom),
654 (modest_easysetup_wizard_dialog_init):
655 * src/maemo/modest-account-settings-dialog.c:
656 (create_page_account_details), (create_page_user_details),
657 (create_page_incoming), (create_page_outgoing),
658 (modest_account_settings_dialog_init):
659 * src/maemo/modest-connection-specific-smtp-window.c:
660 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
662 2007-04-23 Murray Cumming <murrayc@murrayc.com>
664 * src/maemo/easysetup/modest-easysetup-wizard.c:
665 (create_page_account_details), (create_page_custom_outgoing),
666 (create_page_complete_custom):
667 * src/maemo/modest-account-settings-dialog.c:
668 (create_page_user_details), (create_page_incoming),
669 (create_page_outgoing):
670 * src/maemo/modest-connection-specific-smtp-edit-window.c:
671 (modest_connection_specific_smtp_edit_window_init):
672 Use the correct (UI spec) port min/max, and use horizontal separators,
675 2007-04-23 Murray Cumming <murrayc@murrayc.com>
677 * src/maemo/easysetup/modest-easysetup-wizard.c:
678 (set_default_custom_servernames):
679 * src/maemo/modest-account-settings-dialog.c:
680 (create_page_incoming), (on_combo_outgoing_security_changed),
681 (on_combo_incoming_security_changed), (create_page_outgoing),
682 (modest_account_settings_dialog_set_account_name),
683 (save_configuration):
684 * src/maemo/modest-connection-specific-smtp-edit-window.c:
685 (on_combo_security_changed),
686 (modest_connection_specific_smtp_edit_window_init),
687 (modest_connection_specific_smtp_edit_window_set_connection),
688 (modest_connection_specific_smtp_edit_window_get_settings):
689 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
692 2007-04-20 Murray Cumming <murrayc@murrayc.com>
695 * src/maemo/easysetup/modest-easysetup-wizard.c:
696 (create_page_custom_outgoing), (create_page_complete_custom):
697 * src/maemo/modest-account-settings-dialog.c:
698 (create_page_user_details), (create_page_outgoing):
699 * src/maemo/modest-account-view-window.c: (button_box_new):
700 Use changed logical IDs as per the most recent UI spec:
701 mcen_bd_emailsetup_edit -> mcen_bd_edit
702 mcen_bd_emailsetup_delete -> mcen_bd_delete
703 mcen_bd_emailsetup_close -> mcen_bd_close
705 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
709 * src/dbus_api/Makefile.am:
710 * src/dbus_api/modest-dbus-callbacks.c:
711 * src/dbus_api/modest-dbus-callbacks.h:
712 * src/maemo/modest-platform.c: (modest_platform_init):
713 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
716 * tests/dbus_api/Makefile.am:
717 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
719 2007-04-20 Murray Cumming <murrayc@murrayc.com>
721 * src/maemo/modest-account-settings-dialog.c:
722 * src/maemo/modest-connection-specific-smtp-edit-window.c:
723 Removed unnecessary includes.
725 2007-04-20 Murray Cumming <murrayc@murrayc.com>
727 * src/maemo/easysetup/modest-easysetup-wizard.c:
728 * src/maemo/modest-account-settings-dialog.c:
729 * src/maemo/modest-connection-specific-smtp-edit-window.c:
730 * src/widgets/Makefile.am:
731 * src/widgets/modest-easysetup-secureauth-combo-box.c:
732 * src/widgets/modest-easysetup-secureauth-combo-box.h:
733 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
734 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
735 * src/widgets/modest-secureauth-combo-box.c:
736 * src/widgets/modest-secureauth-combo-box.h:
737 * src/widgets/modest-serversecurity-combo-box.c:
738 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
739 made the GObject names more consistent with the rest of the Modest code.
741 2007-04-20 Murray Cumming <murrayc@murrayc.com>
743 * src/maemo/easysetup/Makefile.am:
744 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
745 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
746 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
747 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
748 * src/maemo/easysetup/modest-easysetup-wizard.c:
749 * src/maemo/easysetup/modest-validating-entry.c:
750 * src/maemo/easysetup/modest-validating-entry.h:
751 * src/maemo/modest-account-settings-dialog.c:
752 * src/maemo/modest-connection-specific-smtp-edit-window.c:
753 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
754 widgets/ because they are used outside of easysetup too. After checking in,
755 svn will allow me to rename them too.
757 2007-04-20 Murray Cumming <murrayc@murrayc.com>
759 * src/gnome/modest-msg-edit-window.c:
760 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
761 linker error, to fix the build on the GNOME platform.
762 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
763 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
764 ifdefed out to avoid a warning.
766 2007-04-20 Murray Cumming <murrayc@murrayc.com>
768 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
769 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
770 some alternative for GTK+ 2.6.
772 2007-04-19 Murray Cumming <murrayc@murrayc.com>
774 * src/maemo/modest-address-book.c: Added include to avoid a warning.
776 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
777 specified for EmailAccountsDialog in UI spec.
779 * src/maemo/easysetup/modest-easysetup-wizard.c:
780 * src/maemo/easysetup/modest-easysetup-wizard.h:
781 * src/maemo/modest-account-settings-dialog.c:
782 * src/maemo/modest-account-settings-dialog.h:
783 Reuse a member window widget for the connection-specific SMTP server accounts,
784 so we can tell it to create/save the accounts only if we actually save changes.
786 * src/maemo/modest-connection-specific-smtp-edit-window.h:
787 * src/maemo/modest-connection-specific-smtp-edit-window.c:
788 (modest_connection_specific_smtp_edit_window_get_settings):
789 Return a struct instance for temporarily remembering the entered data.
791 * src/maemo/modest-connection-specific-smtp-window.h:
792 * src/maemo/modest-connection-specific-smtp-window.c:
793 (modest_connection_specific_smtp_window_finalize),
794 (modest_connection_specific_smtp_window_fill_with_connections),
796 (modest_connection_specific_smtp_window_save_server_accounts),
797 (update_model_server_names): Do not actually save data until asked,
798 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
800 (on_selection_changed),
801 (modest_connection_specific_smtp_window_init): Disable the edit
802 button when nothing is selected.
804 * src/modest-account-mgr-helpers.c:
805 * src/modest-account-mgr-helpers.h:
806 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
809 2007-04-19 Murray Cumming <murrayc@murrayc.com>
811 * src/modest-account-mgr-helpers.h:
812 * src/modest-account-mgr-helpers.c:
813 (modest_account_mgr_get_unused_account_name),
814 (modest_account_mgr_get_unused_account_display_name): Added these
815 utility functions, to avoid code duplication.
817 * src/maemo/easysetup/modest-easysetup-wizard.c:
818 (create_page_account_details), (create_account):
819 * src/maemo/modest-connection-specific-smtp-edit-window.c:
820 (on_combo_security_changed),
821 (modest_connection_specific_smtp_edit_window_init),
822 (modest_connection_specific_smtp_edit_window_save_settings):
823 * src/maemo/modest-connection-specific-smtp-edit-window.h:
824 * src/maemo/modest-connection-specific-smtp-window.c:
825 (modest_connection_specific_smtp_window_finalize),
826 (modest_connection_specific_smtp_window_fill_with_connections),
827 (on_button_edit), (modest_connection_specific_smtp_window_init):
828 * src/maemo/modest-connection-specific-smtp-window.h:
829 Implementing saving of connection-specific server accounts.
831 But I need to refactor this so we can save the data for each
832 possible connection-specific account and only actually create the server accounts
833 when the easysetup finished, or the OK button is pressed on the account settings
836 2007-04-18 Murray Cumming <murrayc@murrayc.com>
838 * src/maemo/modest-connection-specific-smtp-edit-window.c:
839 (on_combo_security_changed):
840 (modest_connection_specific_smtp_edit_window_init):
841 Auto-fill the port number as in the account settings.
843 (modest_connection_specific_smtp_edit_window_set_connection):
844 * src/maemo/modest-connection-specific-smtp-edit-window.h:
845 * src/maemo/modest-connection-specific-smtp-window.c:
846 (fill_with_connections), (on_button_edit),
847 (modest_connection_specific_smtp_window_init):
848 Turn the edit window into a dialog to simplify the code, and
849 set a WM hint as in a GtkDialog, because only a popup can be on top of
850 another window in Maemo, and popups usually have no WM decoration.
853 * src/modest-account-mgr-helpers.c:
854 (modest_account_mgr_set_connection_specific_smtp),
855 (modest_account_mgr_remove_connection_specific_smtp),
856 (modest_account_mgr_get_connection_specific_smtp):
857 * src/modest-account-mgr-helpers.h: Some functions to write the
858 connection-specific SMTP server information. Not yet used.
861 * src/widgets/modest-folder-view.c: (text_cell_data):
862 Fix a warning about an uninitialized variable.
863 (on_configuration_key_changed): Put an #ifdef around the use
864 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
866 2007-04-18 Murray Cumming <murrayc@murrayc.com>
868 * src/maemo/modest-account-settings-dialog.h:
869 * src/maemo/modest-account-settings-dialog.c:
870 Added connect_for_modified() utility function to mark the new modified boolean.
872 (create_page_account_details), (create_page_user_details),
873 (create_page_incoming), (create_page_outgoing), (on_response),
874 (modest_account_settings_dialog_init),
875 (modest_account_settings_dialog_set_account_name):
876 Only warn about unsaved changes when there are actually unsaved changes.
878 * src/modest-account-mgr-helpers.c:
879 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
880 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
881 to get the data from there in future.
883 2007-04-18 Murray Cumming <murrayc@murrayc.com>
887 * src/modest-account-mgr-helpers.h:
888 * src/modest-account-mgr-helpers.c:
889 Store the security account setting in a single conf key instead of using
890 the options list, so that the list is left for just the to-be-removed camel hack,
891 and because gconf_client_set_list() is failing for some reason.
893 * src/modest-account-mgr.c:
894 (modest_account_mgr_add_server_account):
895 * src/maemo/modest-account-settings-dialog.c:
896 (modest_account_settings_dialog_set_account_name),
897 (save_configuration): Use the renamed functions.
900 2007-04-18 Murray Cumming <murrayc@murrayc.com>
902 * src/widgets/Makefile.am:
903 * src/widgets/modest-limit-retrieve-combo-box.c:
904 * src/widgets/modest-limit-retrieve-combo-box.h:
905 * src/widgets/modest-retrieve-combo-box.c:
906 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
907 the account settings dialog.
910 * src/modest-account-mgr-helpers.h:
911 * src/modest-account-mgr-helpers.c:
912 (modest_server_account_get_option_secure_auth),
913 (modest_server_account_set_option_secure_auth):
914 * src/modest-account-mgr.c:
915 (modest_account_mgr_add_server_account):
916 Use the existing AUTH_MECH conf key for the secure-auth setting,
917 instead of putting it in the list options, because this was actually used already.
919 * src/maemo/modest-account-settings-dialog.c:
920 (create_page_account_details),
921 (modest_account_settings_dialog_set_account_name),
922 (save_configuration):
923 * src/maemo/modest-account-settings-dialog.h:
924 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
925 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
927 2007-04-18 Murray Cumming <murrayc@murrayc.com>
929 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
930 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
931 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
934 * src/maemo/modest-account-settings-dialog.c:
935 (create_page_incoming), (on_combo_outgoing_security_changed),
936 (on_combo_incoming_security_changed), (create_page_outgoing),
937 (modest_account_settings_dialog_set_account_name),
938 (save_configuration): Load/Save the port number, and change it when the
939 security combo changes, to suitable defaults.
941 2007-04-17 Murray Cumming <murrayc@murrayc.com>
943 * src/modest-account-mgr.c:
944 (modest_account_mgr_add_server_account): Set the security and secure-auth
945 options, and add a comment saying that the other camel-specific options should be
948 2007-04-17 Murray Cumming <murrayc@murrayc.com>
950 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
952 * src/modest-tny-account-store.c: (account_list_free),
953 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
954 cursor->data after unreffing it. But there is some strange stuff there so it might not be
957 2007-04-17 Murray Cumming <murrayc@murrayc.com>
959 * src/modest-protocol-info.c:
960 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
961 is required by our UI spec. Maybe something in our implementation will use this eventually.
962 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
963 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
964 instead of the previous 0 placeholder.
966 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
967 secure-auth settings.
968 * src/modest-account-mgr-helpers.h:
969 * src/modest-account-mgr-helpers.c:
970 (modest_server_account_data_get_option_secure_auth),
971 (modest_server_account_set_option_secure_auth),
972 (modest_server_account_data_get_option_security),
973 (modest_server_account_set_option_security): Added this API for getting and setting the security
974 and secure-auth settings.
976 * src/maemo/modest-account-settings-dialog.h:
977 * src/maemo/modest-account-settings-dialog.c:
978 (modest_account_settings_dialog_finalize), (check_data),
979 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
980 about changing titles.
981 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
982 (save_configuration): Save the security and secure-auth settings.
984 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
985 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
987 2007-04-17 Murray Cumming <murrayc@murrayc.com>
990 * src/modest-account-mgr.c:
991 (modest_account_mgr_add_server_account):
992 Added and used defines for the options key and value pair strings,
993 that are used so far, though they do not seem to correspond to anything in our
994 UI specs or ModestProtocol enum.
996 * src/modest-account-mgr-helpers.h:
997 * src/modest-account-mgr-helpers.c:
998 (compare_option_strings_for_name),
999 (modest_server_account_data_get_option_value),
1000 (modest_server_account_data_get_option_bool),
1001 (modest_account_mgr_get_server_account_option):
1002 Added helper functions for parsing the options GSList.
1004 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1006 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1007 display name is based on the supplied account name.
1008 * src/modest-account-mgr.c:
1009 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1010 with an inefficient, but good-enough, implementation.
1012 * src/maemo/easysetup/modest-easysetup-wizard.c:
1013 (create_page_account_details), (on_before_next), (create_account):
1014 Check for existing display names rather than (non-user-visible) account names, and just
1015 create and set a unique account name at the end.
1017 * src/maemo/modest-account-settings-dialog.c:
1018 (modest_account_settings_dialog_init),
1019 (modest_account_settings_dialog_set_account_name),
1020 (create_page_incoming): Show the display name, instead of the account name.
1021 (on_response): Do some (not all) extra checks, as in the UI spec.
1022 (save_configuration): Save the display name if it was changed.
1024 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1026 * po/en_GB.po: Added needed logical ID and translation.
1027 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1028 (init_view): Made the is-default column clicking work.
1030 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1033 * src/maemo/easysetup/Makefile.am:
1034 * src/maemo/easysetup/modest-easysetup-wizard.c:
1035 (modest_easysetup_wizard_dialog_init):
1036 * src/maemo/easysetup/provider-data-test.keyfile:
1037 * src/maemo/easysetup/provider-data.keyfile:
1038 Moved the provider data file to the new modest-providers-data package and used it from there.
1040 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1042 * src/modest-local-folder-info.c:
1043 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1044 N_() was already used on the static strings, but this just marks it for translation without
1045 using the translation.
1047 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1049 * src/maemo/modest-account-settings-dialog.c:
1050 (create_page_incoming),
1051 (modest_account_settings_dialog_set_account_name):
1052 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1053 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1054 I will do this if nobody else gets there first.
1056 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1058 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1059 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1060 save the security stuff.
1062 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1064 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1065 Set the email address and user fullname, which I now see must be
1068 * src/maemo/modest-account-settings-dialog.h:
1069 * src/maemo/modest-account-settings-dialog.c:
1071 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1072 leave-on-server and authentication.
1073 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1076 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1079 * src/maemo/modest-account-settings-dialog.c:
1080 * src/maemo/modest-account-settings-dialog.h:
1081 Most (but not all) of the widgets are now present as specified by the UI spec.
1082 No changes are yet saved, and some details are not properly shown yet.
1084 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1086 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1088 * src/maemo/Makefile.am:
1089 * src/maemo/modest-account-settings-dialog.c:
1090 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1091 an existing account. Doesn't do much yet.
1093 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1094 Open the accounts settings dialog when Edit is clicked.
1096 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1098 * src/maemo/easysetup/Makefile.am:
1099 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1101 * src/maemo/easysetup/modest-easysetup-wizard.c:
1102 (modest_easysetup_wizard_dialog_init):
1103 Try to get the source directory from the build system,
1104 instead of hard-coding "./" into the source code, when opening our local
1105 copies of the configuration files.
1106 But this still fails when opening the wizard from the Accounts window,
1107 maybe because the working directory seems to change at runtime.
1108 So the wizard will fail the second time unless you copy the files into their
1109 proper locations - see the stdout warnings for the paths.
1111 (create_page_account_details),(on_before_next):
1112 Check for existing non-server accounts instead of server accounts,
1113 so the default account name is useful again, and to prevent trying to
1116 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1117 Show the wizard when New is clicked.
1119 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1120 (init_view): Show the column headers, and show the columns that are
1121 specified in the UI specs. However, something in Maemo's GTK+ prevents
1122 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1123 change the default account. This is despite unsetting the special properties.
1125 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1127 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1128 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1129 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1130 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1131 to make that clearer.
1132 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1134 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1136 * src/maemo/modest-account-view-window.c:
1137 (modest_account_view_window_init),
1138 (modest_account_view_window_new):
1139 Use the same buttons as specified in the
1140 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1141 the existing widgets, which never had a chance of working.
1142 Put the ModestAccountView treeview in a scrolled window.
1143 Do not repeat the initialization in both _init() and _new().
1145 * src/widgets/modest-account-view.c: (update_account_view):
1146 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1147 this widget and window shows no accounts.
1149 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1151 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1153 * src/maemo/easysetup/modest-easysetup-wizard.c:
1154 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1155 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1156 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1159 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1160 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1161 accounts exist yet, as in the UI spec.
1163 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1165 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1167 * src/maemo/Makefile.am:
1168 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1169 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1170 New window for editing connection-specific smtp details.
1171 Not fully implemented.
1173 * src/maemo/modest-connection-specific-smtp-window.c:
1174 (modest_connection_specific_smtp_window_finalize) :
1175 unref the tree model.
1176 (on_button_edit): Show the edit window.
1178 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1180 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1183 * src/maemo/Makefile.am:
1184 * src/maemo/modest-connection-specific-smtp-window.c:
1185 * src/maemo/modest-connection-specific-smtp-window.h:
1186 New window for showing the list of connections, for connection-specific
1187 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1188 * src/maemo/easysetup/modest-easysetup-wizard.c:
1189 (create_page_custom_outgoing): Show the new window when the button is clicked.
1191 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1193 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1194 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1195 * src/maemo/modest-msg-edit-window.c:
1196 (modest_msg_edit_window_insert_image):
1197 * src/modest-conf.c: (modest_conf_key_escape):
1198 * src/modest-mail-operation.c:
1199 (modest_mail_operation_send_new_mail):
1200 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1201 (modest_ui_actions_on_new_account):
1202 * src/widgets/modest-attachment-view.c: (update_filename_request):
1203 * src/widgets/modest-mail-header-view.c:
1204 Corrected warnings that were breaking the build, by commenting out unused variables,
1205 and a function, and by including a header.
1207 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1209 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1210 so we can #ifdef around platform-specific code when necessary.
1211 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1212 to allow this to build for the GNOME platform too.
1214 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1216 * src/maemo/easysetup/modest-easysetup-wizard.c:
1217 Added util_increment_name() and used it in create_page_account_details()
1218 to make sure that the default account name is always a new name.
1220 (modest_easysetup_wizard_dialog_init),
1221 (set_default_custom_servernames): Some minor memory management fixes.
1223 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1227 * src/modest-runtime.c: (init_i18n): Restored the translation
1228 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1229 are defined in config.h, and the translations are installed.
1231 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1232 is defined for translation.
1234 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1236 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1238 * src/maemo/easysetup/modest-easysetup-wizard.c:
1239 (modest_easysetup_wizard_dialog_init):
1240 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1241 Use realistic paths (though they should use $prefix generically) to the
1242 mcc_mapping and provider-data.keyfile files which might work when they
1243 are installed by the future version of the operator-wizard package,
1244 and then fallback to paths in our source code, with an explanatory
1247 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1251 * src/maemo/Makefile.am:
1252 * src/maemo/easysetup/: Added files from the previously-exernal
1253 osso-modest-easysetup.
1254 * src/maemo/modest-main-window-ui.h:
1255 * src/modest-ui-actions.c:
1256 * src/modest-ui-actions.h:
1257 Added modest_ui_actions_on_new_account() as a signal handler for the
1258 New Account menu item. It shows the easysetup wizard.
1259 * po/en_GB.po: Added additional needed logical IDs and translations.
1261 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1262 Apparently ChangeLog is not used for some vague Nokia legal reasons.