1 2007-06-27 Armin Burgmeier <armin@openismus.com>
3 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
6 2007-06-27 Murray Cumming <murrayc@murrayc.com
8 * src/modest-tny-account.h:
9 * src/modest-tny-account.c:
10 Added modest_tny_account_get_mmc_account_name(), to set the memory
11 card name asynchronously for the given account and then notify.
12 (modest_tny_account_new_for_local_folders): Use this new function instead
13 of using hildon_file_system_info_async_new() directly.
15 * src/widgets/modest-folder-view.c: (text_cell_data):
16 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
17 gtk_tree_model_row_changed() when it is available.
19 This should fix projects.maemo.org bug NB#59301.
21 2007-06-27 Murray Cumming <murrayc@murrayc.com
23 * src/modest-mail-operation.c: (update_account_thread),
24 (get_msgs_full_thread): Fix typo failures in the revert
27 2007-06-27 Murray Cumming <murrayc@murrayc.com
29 * src/maemo/modest-maemo-global-settings-dialog.c:
30 (idle_select_default_focus):
31 * src/modest-mail-operation.c: (idle_notify_progress),
32 (idle_notify_progress_once), (set_last_updated_idle),
33 (update_account_thread), (get_msgs_full_thread):
34 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
35 * src/widgets/modest-header-view.c:
36 (idle_notify_headers_count_changed_destroy),
37 (idle_notify_headers_count_changed):
38 Reverted the additions of gdk_threads_enter/leave(), in case this
39 helps with a startup hang on the device.
41 2007-06-26 Armin Burgmeier <armin@openismus.com>
43 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
44 for supported secure authentication methods from server by
45 gtk_dialog_run(), saving CPU time and a potential race condition.
47 2007-06-26 Armin Burgmeier <armin@openismus.com>
49 * src/maemo/modest-maemo-utils.h:
50 * src/maemo/modest-maemo-utils.c: Added a
51 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
52 only error code to tell the calling code when the user canceled the
55 * src/maemo/modest-account-settings-dialog.h:
56 * src/maemo/modest-account-settings-dialog.c:
57 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
58 message if the retrieval of secure authentication methods was canceled
59 by the user. Perform the check before saving anything to configuration
60 to not end up with half-committed configuration changes, do not show
61 a "Saving to configuration failed" note when authentication methods
62 could not be retrieved.
64 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
67 2007-06-26 Murray Cumming <murrayc@murrayc.com>
69 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
70 Only return the first level of folders under accounts, because the
71 osso-global-search UI spec doesn't want the rest.
72 This fixed projects.maemo.org bug NB#61811.
74 2007-06-26 Murray Cumming <murrayc@murrayc.com>
76 * src/modest-tny-account-store.c:
77 * src/modest-tny-account-store.h:
78 Added modest_tny_account_is_memory_card_account().
79 * src/maemo/modest-main-window.c: (create_details_widget):
80 Show the same information items for the memory card as we show for the
81 local-folders, to fix projects.maemo.org bug NB#59307.
83 2007-06-26 Murray Cumming <murrayc@murrayc.com>
85 * src/modest-tny-account-store.c: (get_password):
86 Added some checks for NULL to maybe prevent crashes, though I think
87 it was Philip's last commit that actually prevented the crash here
88 when creating a first new account.
89 But the new account is still not usable (no messages are shown)
90 until a restart of the application.
92 2007-06-26 Murray Cumming <murrayc@murrayc.com>
94 * src/maemo/modest-maemo-global-settings-dialog.c:
95 (idle_select_default_focus):
96 * src/modest-mail-operation.c: (idle_notify_progress),
97 (idle_notify_progress_once), (idle_notify_update_account_queue),
98 (set_last_updated_idle), (update_account_thread),
99 (notify_get_msgs_full), (get_msgs_full_destroyer),
100 (get_msgs_full_thread):
101 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
102 * src/widgets/modest-header-view.c:
103 (idle_notify_headers_count_changed_destroy),
104 (idle_notify_headers_count_changed):
105 Use gdk_threads_enter() and gdk_threads_enter_leave() in
106 all idle handlers, because some other thread could be blocking
107 the GDK lock, so that it can do GUI stuff.
109 2007-06-26 Murray Cumming <murrayc@murrayc.com>
111 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
112 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
113 (on_idle_send_receive), (on_idle_open_default_inbox):
114 * src/maemo/modest-msg-edit-window.c:
115 (modest_msg_edit_window_attach_file_noninteractive):
116 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
117 to prevent a hang. I don't quite understand why these are necessary,
118 beause we should already be in the main loop. I guess something outside
119 of the main loop is taking the lock.
121 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
122 we are really using URIs, and use files that are more likely to exist.
124 2007-06-26 Murray Cumming <murrayc@murrayc.com>
126 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
127 necessary because configure.ac now defines different variables.
129 2007-06-26 Murray Cumming <murrayc@murrayc.com>
131 * libmodest-dbus-client/libmodest-dbus-client.c:
132 * libmodest-dbus-client/libmodest-dbus-client.h:
133 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
134 libmodest_dbus_client_compose_mail() is what things actually use.
136 * src/dbus_api/modest-dbus-api.h:
137 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
138 * tests/dbus_api/Makefile.am:
139 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
142 2007-06-26 Murray Cumming <murrayc@murrayc.com>
144 * src/modest-init.c: (modest_init_local_folders):
145 For memory-card (or other non local-folders) maildir accounts,
146 always create an Archive folder, so that there is somewhere to put
147 messages. This should be less confusing, because the user does not need
148 to guess that the need to create a folder.
150 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
152 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
153 Fixed icon size by using (50, 50) which is the same as defined by
156 2007-06-25 Armin Burgmeier <armin@openismus.com>
158 * src/widgets/modest-window-mgr.c:
160 * configure.ac: Correctly recognize hildon-notify presence and fixed
161 the build without it being installed.
163 2007-06-25 Murray Cumming <murrayc@murrayc.com>
165 * libmodest-dbus-client/libmodest-dbus-client.c:
166 (libmodest_dbus_client_search): Fix the build. Sorry.
167 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
168 (reply_forward_cb): Initialize variables to fix the build.
170 * src/modest-tny-account-store.c:
171 (modest_tny_account_store_get_tny_account_by): Fix the account URI
172 comparison (a silly typo) so that email search results can be opened
173 when there are more than one account.
175 2007-06-25 Murray Cumming <murrayc@murrayc.com>
177 * libmodest-dbus-client/libmodest-dbus-client.c:
178 (libmodest_dbus_client_search),
179 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
180 instead of 1 second, because the search gets folders and messages from
181 the server, which can take a long time. When it times out,
182 osso-global-search will report no results.
184 We need to specify whether we should search only cached information
185 (maybe with a user preference), and the osso-email-search-plugin
186 API should really be improved to allow that option, and to allow results
187 to be delivered asynchronously in batches.
189 2007-06-25 Murray Cumming <murrayc@murrayc.com>
191 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
192 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
193 GTK_ICON_SIZE_DIALOG is probably the wrong size.
195 2007-06-25 Murray Cumming <murrayc@murrayc.com>
197 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
198 that is an empty string. D-Bus seems to give us these instead of NULL.
200 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
202 * src/dbus_api/modest-dbus-callbacks.c:
203 * src/maemo/easysetup/modest-easysetup-wizard.h:
204 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
205 * src/maemo/modest-connection-specific-smtp-edit-window.c:
206 (modest_connection_specific_smtp_edit_window_init):
207 * src/maemo/modest-maemo-global-settings-dialog.c:
209 * src/maemo/modest-maemo-utils.c:
210 (modest_maemo_utils_setup_images_filechooser):
211 * src/maemo/modest-main-window.c: (create_details_widget):
212 * src/maemo/modest-msg-edit-window.c:
213 (modest_msg_edit_window_attach_file_noninteractive),
214 (modest_msg_edit_window_color_button_change),
215 (modest_msg_edit_window_set_zoom):
216 * src/modest-mail-operation.c: (update_account_thread):
217 * src/modest-tny-account-store.c:
218 * src/modest-tny-account.c:
219 * src/widgets/modest-global-settings-dialog.c:
220 * src/widgets/modest-window.h:
224 2007-06-25 Murray Cumming <murrayc@murrayc.com>
226 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
227 * src/modest-search.c: (modest_search_folder),
228 (modest_search_all_accounts): Actually search only in the specified folder,
229 doing a simple match on the folder ID.
230 * src/modest-search.h: Added a folder field to the ModestSearch struct,
231 and added some documentation.
233 2007-06-22 Armin Burgmeier <armin@openismus.com>
235 * src/maemo/modest-maemo-utils.h:
236 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
237 modest_maemo_utils_get_supported_secure_authentication_methods.
239 * src/maemo/easysetup/modest-easysetup-wizard.c:
240 * src/maemo/modest-account-settings-dialog.c: Show correct error if
241 one occured, not just "Server does not support secure authentication".
243 2007-06-22 Murray Cumming <murrayc@murrayc.com>
245 * src/modest-tny-account-store.c: (get_password):
246 Restored the call to tny_account_set_user() because Philip seems to have
247 stopped this from crashing (by not using the freed string). It still does
248 not work, but now we can test it.
250 2007-06-22 Murray Cumming <murrayc@murrayc.com>
252 * src/maemo/modest-msg-edit-window.c: (init_window):
253 Comment out use of an uninitialzed GtkScrolledWindow variable,
254 to fix the build and stop a crash. Yet again.
256 2007-06-22 Murray Cumming <murrayc@murrayc.com>
258 * src/modest-tny-account-store.c: (get_password):
259 Remove the call to tny_account_set_user() because this actually crashes.
260 As mentioned in the last commit, it is known to not work anyway.
262 2007-06-22 Murray Cumming <murrayc@murrayc.com>
264 * src/modest-tny-account-store.c: (get_password):
265 Use tny_account_set_username() to tell tinymail that the username might
266 have changed too. But tinymail ignores this: see projects.maemo.org
268 * src/modest-ui-actions.c:
269 (modest_ui_actions_on_password_requested): Remove the useless attempt to
270 reset the connection when changing the username, and improve the comments.
271 Save the changed username to gconf at least, so it is used when Modest is
274 2007-06-21 Murray Cumming <murrayc@murrayc.com>
276 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
277 Do not use a query, so that we get all folders, including for POP and
278 local-folders. They work as search criteria too.
279 This fixes projects.maemo.org bug NB#57740.
281 2007-06-21 Murray Cumming <murrayc@murrayc.com>
283 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
284 Comment out the use of hildon_notification_set_sound() because it is
285 not declared, to fix the build. Warnings are serious, people.
287 2007-06-21 Armin Burgmeier <armin@openismus.com>
289 * src/maemo/modest-maemo-utils.h:
290 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
291 modest_maemo_utils_get_supported_secure_authentication_methods()
292 to query authentication methods for a specific user. This should fix
293 projects.maemo.org bug NB#61369.
295 * src/maemo/easysetup/modest-easysetup-wizard.c:
296 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
299 2007-06-21 Murray Cumming <murrayc@murrayc.com>
301 * libmodest-dbus-client/libmodest-dbus-client.h:
302 * libmodest-dbus-client/libmodest-dbus-client.c:
303 (modest_dbus_message_iter_get_search_hit),
304 (libmodest_dbus_client_search):
305 Reorganised and commented this.
306 Removed modest_search_hit_free() from the public API because it
309 Added libmodest_dbus_client_get_folders() and
310 modest_folder_result_list_free().
312 * src/dbus_api/modest-dbus-api.h:
313 * src/dbus_api/modest-dbus-callbacks.c:
314 (modest_dbus_req_filter): Commented. Moved most code to
315 on_dbus_method_search() and added on_dbus_method_get_folders().
317 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
318 of the extra D-Bus handler.
320 * tests/dbus_api/Makefile.am:
321 * tests/dbus_api/test_get_folders.c: New test for
322 libmodest_dbus_client_get_folders(). This seems to return an empty list
323 at the moment. That could be the same error that causes the message list
324 to be empty sometimes.
325 This should help with projects.maemo.org bug NB#57740.
327 2007-06-21 Armin Burgmeier <armin@openismus.com>
329 * src/modest-mail-operation.c: Do not call
330 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
331 notify the operation's end after having set the status to CANCELED for
332 the operation queue to listen on. This fixes a deadlock when there
333 were mail operations in the queue during its finalization.
335 * src/modest-singletons.c: Reordered uninitialization of the account
336 manager to happen after the mail operation queue was uninitialized
337 because the mail operation's in the queue might still try to access
338 the account manager (see modest_mail_operation_notify_end()). This
339 fixes a potential crash when terminating the application.
341 2007-06-21 Murray Cumming <murrayc@murrayc.com>
343 * src/modest-search.c:
344 (search_mime_part_and_child_parts): Moved some code here so we
345 can search recursively in child folders.
346 (modest_search_folder): Search in the message as a mime part, instead
347 of just its child mime parts.
348 (read_chunk), (search_mime_part_ogs):
349 Check how many bytes were read, to prevent an endless loop.
350 Searching in message bodies now works. This finishes the fix for
351 projects.maemo.org bug NB#61007.
353 2007-06-20 Murray Cumming <murrayc@murrayc.com>
355 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
356 Add a g_warning when the item is not a folder.
358 * src/modest-ui-dimming-rules.c:
359 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
360 when selected item is not a folder (for instance, an account), because
361 the UI spec only talks about folders.
362 I am not sure what the UI spec wants, so this might not totally fix
363 projects.maemo.org bug NB#60794.
365 2007-06-20 Murray Cumming <murrayc@murrayc.com>
367 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
368 (load_from_file): Sort the list. The unsorted list would be more noticeable
369 in non-English locales.
371 * src/maemo/modest-msg-edit-window.c:
372 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
373 warning and fix the build.
375 * src/maemo/modest-progress-bar-widget.c:
376 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
377 avoid a g_warning, and probably to avoid a crash.
379 2007-06-20 Murray Cumming <murrayc@murrayc.com>
381 * src/modest-search.c: (modest_search_folder): Check for a GError
382 when calling tny_folder_get_headers(), to show that this is not the cause
385 2007-06-20 Murray Cumming <murrayc@murrayc.com>
387 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
388 Actually set the body query instead of the subject query.
390 * src/modest-search.c: (search_mime_part_ogs),
391 (search_mime_part_strcmp): Remove extra space from the text/* regex,
392 which would probably cause it to fail if we got this far.
394 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
395 to simplify the code.
396 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
397 be causing search-in-body to fail.
399 2007-06-20 Murray Cumming <murrayc@murrayc.com>
401 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
403 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
404 Better debug message when the folder cannot be found.
405 This should help with fixing projects.maemo.org bug #61287.
406 * src/modest-search.c: (add_hit): Do not leak the furl string.
408 2007-06-20 Murray Cumming <murrayc@murrayc.com>
410 * src/modest-ui-actions.c:
411 (modest_ui_actions_on_folder_selection_changed):
412 Do not special-case TNY_MERGE_FOLDER here, because
413 modest_tny_folder_get_account() already does that. This fixes
414 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
415 shown when the Outbox was selected).
417 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
419 * libmodest-dbus-client/libmodest-dbus-client.c:
420 (_dbus_iter_get_string_or_null): Initialize the string variable in
421 case this helps with Dirk's crash.
423 2007-06-19 Murray Cumming <murrayc@murrayc.com>
425 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
426 though it is not implemented yet (this function is maybe not even used),
427 to avoid breaking ABI in future.
428 * libmodest-dbus-client/libmodest-dbus-client.c:
429 (get_attachments_string): Moved some code into this generic function.
430 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
431 sends email. It is maybe not used.
432 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
433 (on_send_mail): Use attachments.
435 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
436 * src/maemo/modest-msg-edit-window.c:
437 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
438 a filename before using it, to fix projects.maemo.org bug NB#58233.
440 2007-06-19 Murray Cumming <murrayc@murrayc.com>
442 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
443 Initialize the continue_download variable to fix the build, and probably
444 to fix randome behaviour.
446 2007-06-18 Armin Burgmeier <armin@openismus.com>
448 * src/modest-tny-send-queue.h:
449 * src/modest-tny-send-queue.c: Keep track of the status of messages in
450 the queue so we can later show it in the UI. Replaced
451 modest_tny_send_queue_msg_is_being_sent() by
452 modest_tny_send_queue_get_msg_status().
454 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
456 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
457 gpointer. This probably was not harmful, but just to be sure.
459 2007-06-18 Murray Cumming <murrayc@murrayc.com>
461 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
462 Fix the build, but leave the function broken on Bora, because
463 hildon_uri_action_get_service() does not exist.
464 osso_uri_action_get_service() does not exist either, it seems.
466 2007-06-18 Murray Cumming <murrayc@murrayc.com>
468 * src/modest-tny-account.c:
469 (modest_tny_account_new_from_server_account):
470 Uncommented the url debug output again, because it is useful for
471 debugging, as I said in the comment.
473 2007-06-18 Murray Cumming <murrayc@murrayc.com>
475 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
477 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
478 for Mameo Bora, to fix the build.
480 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
483 Fixed build with hildon < 0.99
485 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
486 Check if the selected account is busy instead of checking all accounts
488 * src/modest-account-mgr-priv.h:
489 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
490 (modest_account_mgr_init), (compare_account_name),
491 (modest_account_mgr_set_account_busy),
492 (modest_account_mgr_account_is_busy):
493 * src/modest-account-mgr.h:
494 Added busy information to the account manager. It possible to
495 set an account to busy or not busy now.
497 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
498 (modest_mail_operation_update_account),
499 (modest_mail_operation_notify_end):
500 Set the account to busy/not busy depending on the operation state.
502 * src/widgets/modest-account-view.c:
503 (modest_account_view_finalize), (get_last_updated_string),
504 (update_account_view), (on_account_busy_changed), (init_view):
505 Show string "Refreshing..." if the account is currently busy.
507 All this fixes projects.maemo.org bug NB#59711
509 2007-06-14 Armin Burgmeier <armin@openismus.com>
511 * src/widgets/modest-attachments-view.h:
512 * src/widgets/modest-attachments-view.c: Added
513 modest_attachments_view_has_attachments() and fixed coordinate
514 transformation in get_att_view_at_coords(). This fixes attachment
517 * src/widgets/modest-msg-view.c: Make use of
518 modest_attachments_view_has_attachments() to decide whether to show
519 attachments in the header.
521 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
523 * src/maemo/modest-connection-specific-smtp-edit-window.c:
524 (on_change), (on_combo_security_changed),
525 (modest_connection_specific_smtp_edit_window_init),
526 (modest_connection_specific_smtp_edit_window_set_connection),
527 (modest_connection_specific_smtp_edit_window_is_dirty):
528 * src/maemo/modest-connection-specific-smtp-edit-window.h:
529 * src/maemo/modest-connection-specific-smtp-window.c:
532 Show an comfirmation dialog for the smpt-edit-window if there are
533 unsaved changes and the user hits cancel.
534 (projects.maemo.org bug NB#60479)
536 2007-06-14 Armin Burgmeier <armin@openismus.com>
538 * src/maemo/easysetup/modest-easysetup-wizard.c:
539 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
540 address" info in banner instead of node, and select all the text as
541 per UI spec. This fixes projects.maemo.org bug NB#60550.
543 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
545 reviewed by: <delete if not using a buddy>
547 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
548 * src/modest-ui-actions.c: (folder_refreshed_cb):
550 2007-06-14 Murray Cumming <murrayc@murrayc.com>
552 * src/widgets/modest-folder-view.c: (filter_row):
553 Explictly filter out the per-account outbox accounts. I don't know why
554 these only sometimes show up, but now they should never show up in the UI.
555 This should fix projects.maemo.org bug NB#60160.
557 2007-06-14 Murray Cumming <murrayc@murrayc.com>
559 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
560 when the toolbar does not exist yet.
561 * src/modest-widget-memory.c: (save_settings_header_view):
562 Added g_warnings() to help us to discover when we are trying to set
563 an empty columns list in gconf.
565 2007-06-14 Murray Cumming <murrayc@murrayc.com>
569 Added modest_init_get_default_header_view_column_ids().
571 * src/modest-widget-memory.c: (restore_settings_header_view):
572 Use the new function to get defaults, if the gconf key is empty,
573 instead of not creating any columns. This seems to fix the
574 empty right-hand pane problems.
576 * src/widgets/modest-header-view.h: Improved documentation.
578 2007-06-13 Murray Cumming <murrayc@murrayc.com>
580 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
581 Revert the use of the display name as the account name, because this
582 is generally wrong and would break the code that follows.
584 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
586 * src/maemo/easysetup/modest-easysetup-wizard.c:
587 (check_for_supported_auth_methods), (on_before_next),
590 More correct fix for projects.maemo.org bug NB# 58991
591 Do not longer accept AUTH_PASSWORD as secure method and choose
592 correct method when creating the account.
594 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
596 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
597 Fixed projects.maemo.org bug NB# 58991
599 2007-06-13 Murray Cumming <murrayc@murrayc.com>
601 * src/modest-init.c: (modest_init_init_core),
602 (modest_init_local_folders): Fixed compilation errors.
604 2007-06-13 Murray Cumming <murrayc@murrayc.com>
606 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
607 Remove unnecessary lib/include, though it is good in principle when needed.
609 * src/modest-init.c: (modest_init_one_local_folder),
610 (modest_init_local_folders):
611 * src/modest-init.h: Initialize the .modest library for memory cards,
612 instead of just doing nothing for them. This should allow us to create
613 folders there, fixing projects.maemo.org bug NB#59297.
615 2007-06-13 Murray Cumming <murrayc@murrayc.com>
617 * libmodest-dbus-client/libmodest-dbus-client.c:
618 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
619 (libmodest_dbus_client_compose_mail),
620 (libmodest_dbus_client_open_message),
621 (libmodest_dbus_client_send_and_receive),
622 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
624 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
625 (on_idle_open_message), (modest_dbus_req_handler),
626 (search_result_to_message), (modest_dbus_req_filter):
627 * src/modest-search.c: (add_hit), (modest_search_folder),
628 (modest_search_all_accounts): Improved debug messages.
630 * tests/dbus_api/test_open_message.c: (main): Improved comments.
632 * src/modest-tny-account-store.c:
633 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
636 2007-06-13 Murray Cumming <murrayc@murrayc.com>
639 2007-06-12 Murray Cumming <murrayc@murrayc.com>
641 * src/modest-tny-account-store.c: (get_server_accounts):
642 Call modest_tny_local_folders_account_add_merged_outbox_folders()
643 even when there are no accounts, so that the Outbox folder is always
644 visible. This fixes projects.maemo.org bug NB#60158.
646 2007-06-12 Murray Cumming <murrayc@murrayc.com>
648 * src/maemo/modest-main-window.c: (create_details_widget):
649 Use the mcen_va_never logical ID.
651 2007-06-12 Murray Cumming <murrayc@murrayc.com>
653 * src/dbus_api/modest-dbus-api.h:
654 * src/dbus_api/modest-dbus-callbacks.c:
655 (on_idle_open_default_inbox), (on_open_default_inbox),
656 (modest_dbus_req_handler):
657 Added a new OpenDefaultInbox method.
659 * libmodest-dbus-client/libmodest-dbus-client.h:
660 * libmodest-dbus-client/libmodest-dbus-client.c:
661 Added libmodest_dbus_client_open_default_inbox() to call the new
662 dbus method. This should be useful to projects.maemo.org bug NB#57214,
663 though it should maybe be used by a new osso-email-interface function.
665 * tests/dbus_api/Makefile.am:
666 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
669 2007-06-12 Murray Cumming <murrayc@murrayc.com>
671 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
672 NULL, so that the signals get all the keys. This should not actually
673 change any behaviour because we currently update everything when anything
676 2007-06-12 Murray Cumming <murrayc@murrayc.com>
678 * src/widgets/modest-folder-view.c: (text_cell_data),
679 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
680 (find_inbox_iter): If tinymail tells us that the folder is
681 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
682 This causes the inbox to be selected at startup, fixing part of
683 projects.maemo.org bug NB#56305.
685 * src/modest-ui-dimming-rules.c:
686 (modest_ui_dimming_rules_on_tools_smtp_servers):
687 * src/modest-ui-dimming-rules.h: Added a callback function to dim
688 the SMTP servers menu item.
689 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
690 that the SMTP Servers menu item is dimmed when there are no accounts,
691 as a future version of the UI spec will require. This fixes
692 projects.maemo.org bug NB#56305.
694 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
696 * src/maemo/modest-maemo-utils.c:
697 (modest_maemo_utils_get_supported_secure_authentication_methods):
698 Added label to dialog instead of unreadable title
700 * src/maemo/modest-main-window.c: (sync_accounts_cb),
701 (modest_main_window_new):
702 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
705 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
706 * src/modest-account-mgr.h:
707 Added method to avoid code duplication
709 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
710 (modest_ui_actions_on_send_receive):
711 Use modest_account_mgr_has_accounts
713 2007-06-11 Murray Cumming <murrayc@murrayc.com>
715 * src/maemo/easysetup/modest-presets.c:
716 (modest_presets_get_info_server_security): Do not report secure auth
718 * src/modest-protocol-info.c: Use the defines for the gconf key names
719 for secure authentication. This was not working because we were writing
720 Password and reading password, and the check was case sensitive.
721 With this, gmail now works for receiving and sending when created via
724 2007-06-11 Murray Cumming <murrayc@murrayc.com>
726 * src/maemo/easysetup/modest-presets.c:
727 (modest_presets_get_info_server_security): Correct the key name for
728 SecureSmtp, because it seems to be case-sensitive.
729 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
730 Do not try to get the 0th notebook page if there are 0 pages, to
733 2007-06-11 Murray Cumming <murrayc@murrayc.com>
735 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
736 Prevent use of the new notification feature for now, because it currently
737 shows one dialog for each new email, which is annoying.
739 2007-06-11 Murray Cumming <murrayc@murrayc.com>
741 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
742 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
743 when no country was selected, so that we show the global ones.
744 * src/maemo/easysetup/modest-presets.c:
745 (modest_presets_get_providers): Return only the global providers, not
746 all providers when mmc=0 was requested.
748 2007-06-11 Murray Cumming <murrayc@murrayc.com>
750 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
751 (easysetup_provider_combo_box_fill): Remove debug code that showed the
752 provider ID in the combo.
754 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
755 Do not show the page numbers, because it would be confusing when we add
756 the 2 extra pages for the custom setup, when the user chooses the "Other"
757 provider. This fixes projects.maemo.org bug NB#59028
759 * src/modest-init.c: (modest_init_init_core),
760 (modest_init_local_folders):
762 * src/modest-tny-account.c:
763 (modest_tny_account_new_for_local_folders): Do not create default folders
764 for the memory card. This should fix projects.maemo.org bug NB#59328.
766 2007-06-11 Murray Cumming <murrayc@murrayc.com>
768 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
769 Free the changed_conf_keys string items. They are already freed in the
770 idle handler if that runs first.
772 2007-06-11 Murray Cumming <murrayc@murrayc.com>
774 * src/modest-ui-actions.c:
775 (modest_ui_actions_on_password_requested): Check that the server name
776 is not NULL, because I just saw a password dialog with (null) as the
779 * src/modest-tny-folder.[h|c]: Added
780 modest_tny_folder_is_memory_card_folder().
781 * src/modest-ui-dimming-rules.c:
782 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
783 menu item for memory cards, as per the UI spec (section 7.4). This should
784 fix projects.maemo.org bug NB#59297.
786 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
788 * src/maemo/modest-main-window.c: (sync_accounts_cb):
789 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
790 is another problem with the code, see Murray's comment at line 772)
792 2007-06-08 Murray Cumming <murrayc@murrayc.com>
794 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
795 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
796 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
797 (load_from_file), (easysetup_country_combo_box_init),
798 (easysetup_country_combo_box_get_active_country_ids),
799 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
800 instead of just one ID, to avoid duplicate country names in the UI.
802 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
803 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
804 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
805 a single ID, avoiding duplicate providers.
806 * src/maemo/easysetup/modest-easysetup-wizard.c:
807 (on_combo_account_country): Adapt to use a list.
809 2007-06-08 Murray Cumming <murrayc@murrayc.com>
811 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
812 keys changed in the last X seconds.
814 * src/modest-account-mgr.h:
815 * src/modest-account-mgr.c: (on_timeout_notify_changes),
816 (on_key_change), (modest_account_mgr_class_init),
817 (modest_account_mgr_init), (modest_account_mgr_finalize):
818 As the keys are changed, save them in a GSList* and signal that GSList*
819 further every X seconds, to batch changes, to allow us to do just one
820 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
821 bug NB#56941 and other (UI-blocking) delays when changing account settings.
823 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
824 changed signal signature.
826 * src/modest-conf.c: (modest_conf_set_list),
827 (modest_conf_on_change): Reenable notification.
829 (modest_conf_maemo_fake_on_change): Comment out the hack that
830 notified immediately instead of asynchronously.
832 * src/widgets/modest-account-view.h:
833 * src/widgets/modest-account-view.c:
834 (update_account_view): Select the previously-selected account ID,
835 if possible. This fixes projects.maemo.org bug NB#56933.
837 (on_account_changed), (on_account_removed),
838 (modest_account_view_select_account):
840 Remove the block/unblock functions
841 because they were not useful.
843 * src/maemo/modest-account-view-window.c:
844 (on_delete_button_clicked), (on_edit_button_clicked),
845 (on_new_button_clicked): Remove the use of the non-working block/unblock.
847 2007-06-08 Murray Cumming <murrayc@murrayc.com>
849 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
850 Improve the error dialog to show Incorrect Account Settings, which seems
851 clearer, and say that the internal error message (to be removed from the
852 dialog later) is often misleading.
853 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
855 * src/modest-tny-account.c:
856 (modest_tny_account_new_from_server_account): Uncomment the printf of the
857 URL because this is so useful for debugging on the device.
859 * src/widgets/modest-serversecurity-combo-box.c:
860 (modest_serversecurity_combo_box_fill): Correct a logical ID.
862 2007-06-08 Murray Cumming <murrayc@murrayc.com>
864 * src/modest-mail-operation.c:
865 (modest_mail_operation_send_new_mail):
866 Added a comment about a nasty but apparently harmless message. Details
867 added to the wiki g_warnings() page.
869 2007-06-08 Murray Cumming <murrayc@murrayc.com>
871 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
872 (modest_tny_send_queue_class_init):
873 Do not use the priv struct because it is empty, to avoid g_warnings
874 about a non-existant priv struct.
876 * src/modest-tny-account-store.c:
877 (modest_tny_account_store_get_server_account),
878 (modest_tny_account_store_get_transport_account_for_open_connection
879 ): Do not try to get transport server accounts for local folders,
880 because they don't have any. This avoids a g_warning().
882 * src/maemo/modest-main-window.c:
883 (modest_main_window_notify_send_receive_initied),
884 (on_configuration_key_changed):
885 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
887 * src/modest-mail-operation.c:
888 (modest_mail_operation_update_account):
889 * src/modest-tny-account-store.h:
890 * src/modest-tny-account.c:
891 (modest_tny_account_get_special_folder),
892 (modest_tny_account_new_for_local_folders),
893 (modest_tny_account_new_for_per_account_local_outbox_folder):
894 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
895 * src/modest-tny-local-folders-account.c:
896 (add_account_folders_to_merged_folder):
897 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
898 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
899 (modest_ui_actions_on_send):
900 * src/widgets/modest-folder-view.c: (update_model):
901 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
902 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
903 modest_tny_account_store_get_tny_account_by_account() to
904 modest_tny_account_store_get_server_account() to make the code clearer.
906 2007-06-07 Marcus Bauer <marcusb@openismus.com>
908 * src/dbus_api/modest-dbus-api.h:
909 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
910 * src/maemo/modest-msg-edit-window.c:
911 (modest_msg_edit_window_attach_file_noninteractive):
912 added g_warning in case the file to be attached does not exist
913 * tests/dbus_api/test_compose_mail.c: (main):
914 removed obsolete comment, added generic files as test case
916 2007-06-07 Murray Cumming <murrayc@murrayc.com>
918 * src/modest-tny-account-store.c: (get_server_accounts):
919 Create the local folders account only once, not once for each outbox, and
920 not only when there are some outboxes.
922 2007-06-07 Murray Cumming <murrayc@murrayc.com>
924 * src/widgets/modest-folder-view.c: (update_model): Comment out some
925 code that is causing a crash at startup. Sergio says that he is fixing this.
927 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
929 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
930 * src/maemo/modest-account-settings-dialog.c:
931 (create_page_outgoing),
932 (modest_account_settings_dialog_set_account_name),
933 (save_configuration):
934 - Fixed handling of the "Use secure authentication" toggle to comply with
935 the ui specification. See also projects.maemo.org bug NB#58400
937 - Restore the Secure connection setting combo correctly when loading
940 * src/maemo/modest-maemo-utils.c:
941 (on_camel_account_get_supported_secure_authentication),
942 (modest_maemo_utils_get_supported_secure_authentication_methods):
943 Fixed a crasher if operation is canceled
945 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
946 (modest_protocol_info_auth_is_secure):
947 * src/modest-protocol-info.h:
949 Added two new methods to determine if a protocol/auth method is secure/encrypted in
950 the sense of the "Use secure authentication" toggle.
952 2007-06-07 Murray Cumming <murrayc@murrayc.com>
954 * src/modest-tny-account-store.h:
955 * src/modest-tny-account-store.c:
956 Added modest_tny_account_store_get_local_folders_account().
958 * src/modest-tny-folder.h:
959 * src/modest-tny-folder.c:
960 (modest_tny_folder_get_account):
961 Added this replacement for tny_folder_get_account() which returns
962 the local-folders account for TnyMergeFolders, to avoid the
963 warning about the unimplemented get_account_func() vfunc().
965 (modest_tny_folder_get_rules),
966 * src/modest-ui-actions.c:
967 (modest_ui_actions_on_folder_selection_changed):
968 * src/modest-mail-operation.c:
969 (modest_mail_operation_remove_folder),
970 (modest_mail_operation_xfer_folder),
971 (modest_mail_operation_rename_folder),
972 (modest_mail_operation_get_msg),
973 (modest_mail_operation_get_msgs_full),
974 (modest_mail_operation_remove_msg),
975 (modest_mail_operation_xfer_msgs),
976 (modest_mail_operation_refresh_folder):
977 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
979 2007-06-07 Murray Cumming <murrayc@murrayc.com>
981 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
982 (modest_server_account_set_security):
983 * src/modest-defs.h: Add comments explaining that our
984 UI spec means TLS when it says Normal, so these do not look like errors.
986 * src/modest-tny-account.c:
987 (modest_tny_account_new_from_server_account): Use the new tinymail
988 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
989 for TLS. This should fix projects.maemo.org bug NB#58460.
991 2007-06-06 Murray Cumming <murrayc@murrayc.com>
993 * src/maemo/easysetup/modest-easysetup-wizard.c:
994 (create_account): Correct the position of the gconf sanity check warning.
995 (on_button_edit_advanced_settings): Show the dialog immediately, instead
996 of using the g_idle_add() hack, because this does not seem to be necessary
997 on osso 1.1. It might even work on Maemo Bora if the problems were actually
998 caused by something other than maemo's gconf.
999 This fixes projects.maemo.org bug #59022.
1001 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1003 * src/modest-account-mgr-helpers.c:
1004 (modest_account_mgr_get_default_account): Do not check that the account
1005 exists if there is no default account (NULL), to fix a runtime warning.
1007 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1009 * src/widgets/modest-folder-view.c: (update_model):
1010 Do not unref the treemodel before we have finished with it.
1011 This prevents a valgrind warning and an occasional crash at startup.
1013 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1015 * libmodest-dbus-client/libmodest-dbus-client.h:
1016 added libmodest_dbus_client_compose_mail()
1017 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1019 added functions needed for SendAsMail() functionality
1020 * src/maemo/modest-msg-edit-window.c:
1021 (modest_msg_edit_window_attach_file_noninteractive):
1022 non interactively attaching files to message edit window
1023 * src/widgets/modest-msg-edit-window.h:
1024 * tests/dbus_api/Makefile.am:
1025 added test_compose_mail.c
1026 * tests/dbus_api/test_compose_mail.c: (main):
1028 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1030 * src/modest-account-view.c:
1031 Fixed bug projects.maemo.org bug NB#59307
1033 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1035 * src/maemo/easysetup/modest-easysetup-wizard.c:
1036 (get_serverport_incoming), (on_before_next), (create_account):
1037 * src/maemo/modest-account-settings-dialog.c:
1038 (modest_account_settings_dialog_set_account_name):
1039 * src/maemo/modest-maemo-utils.c:
1040 (on_camel_account_get_supported_secure_authentication_status),
1041 (on_camel_account_get_supported_secure_authentication),
1042 (on_secure_auth_cancel),
1043 (modest_maemo_utils_get_supported_secure_authentication_methods):
1045 Implemented security authentication for settings and easysetup.
1047 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1049 * src/maemo/modest-main-window.c: (create_details_widget):
1050 Show the total size for memory card accounts too, instead of showing
1051 the name again. Fixes bug projects.maemo.org bug NB#59307.
1053 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1056 * src/modest-tny-simple-folder-store.c:
1057 * src/modest-tny-simple-folder-store.h: Removed.
1059 * src/modest-tny-local-folders-account.h
1060 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1061 for the local-folders maildir, with an extra TnyMergedFolder containing
1062 the folders of the per-account outbox store accounts.
1063 * src/modest-tny-account-store.c: (get_server_accounts):
1064 Add the outboxes to the special local folders account after creating it.
1066 * src/modest-tny-account.c:
1067 (modest_tny_account_new_for_local_folders): Create the derived
1068 account when creating the main local-folders account.
1070 * src/maemo/modest-main-window.c: (create_details_widget),
1071 (modest_main_window_set_contents_style):
1072 Adapted to the use of the derived account instead of the folder store.
1074 * src/modest-ui-actions.c:
1075 (modest_ui_actions_on_folder_selection_changed):
1076 * src/modest-ui-dimming-rules.c:
1077 (modest_ui_dimming_rules_on_new_folder):
1078 * src/widgets/modest-folder-view.c: (text_cell_data),
1079 (icon_cell_data), (filter_row), (update_model),
1080 (get_cmp_rows_type_pos):
1083 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1084 Do not get the priv struct, because no priv struct has been set,
1085 to avoid a runtime warning.
1087 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1088 #ifelse with #else, to fix a warning, to fix the build.
1091 2007-06-05 Christian Kellner <ckellner@openismus.com>
1093 * libmodest-dbus-client/libmodest-dbus-client.c:
1094 Fix small typo in doc (why do you always see them
1095 AFTER committing stuff?)
1098 2007-06-05 Christian Kellner <ckellner@openismus.com>
1100 * libmodest-dbus-client/libmodest-dbus-client.c:
1101 (libmodest_dbus_client_search):
1102 Initialize hit list with NULL. Also set folder list
1103 to "" if NULL was supplied.
1106 2007-06-03 Christian Kellner <ckellner@openismus.com>
1108 * libmodest-dbus-client/libmodest-dbus-client.c:
1109 (modest_search_hit_list_free):
1110 Make it save to call it with NULL.
1112 * src/dbus_api/modest-dbus-callbacks.c:
1113 * src/modest-search.c:
1114 Return full ModestSearchHits as the search result list not TnyHeader
1115 since can't be around withouth the correspoding TnyFolder.
1117 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1119 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1120 Added currently commented code to check for secure auth
1122 * src/maemo/modest-account-settings-dialog.c: (on_response),
1123 (save_configuration), (show_ok):
1124 Fixed projects.maemo.org bugs NB #59248 and #59251
1126 * src/maemo/modest-maemo-utils.c:
1127 (on_camel_account_get_supported_secure_authentication_status),
1128 (on_camel_account_get_supported_secure_authentication),
1129 (modest_maemo_utils_get_supported_secure_authentication_methods):
1130 * src/maemo/modest-maemo-utils.h:
1131 Moved get_supported_secure_authentication() method here to be able
1132 to use it from easysetup wizard.
1134 * src/modest-pair.c: (on_pair_compare_as_string):
1135 Should compare string with first part of pair and not
1136 strcmp pairs which will crash.
1138 * src/modest-protocol-info.c:
1139 (modest_protocol_info_protocol_is_store):
1140 * src/modest-protocol-info.h:
1141 Added modest_protocol_info_get_auth_protocol_name()
1143 2007-06-03 Armin Burgmeier <armin@openismus.com>
1145 * src/modest-mail-operation.c:
1146 (modest_mail_operation_get_msgs_full): Set priv->account also when
1147 only retrieving a single message. This avoids a crash when canceling
1150 (modest_mail_operation_notify_end): Do not explicitely remove the
1151 operation from the queue but only emit the progress_changed signal.
1152 The queue itself listens to that signal to remove the operation when
1153 it is finished. This reduces coupling and removes a potential deadlock
1154 when modest_mail_operation_notify_end() is called from the queue
1155 itself. If that is a problem performance-wise, I would suggest to
1156 implement a status-changed signal or something.
1158 * src/modest-mail-operation-queue.c: Make sure to never call a
1159 function from another file while the queue is locked. This (hopefully)
1160 fixes another deadlock when exiting the application while retrieving
1163 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1165 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1166 Fixed build if libogs is not available
1168 2007-06-03 Christian Kellner <ckellner@openismus.com>
1170 * libmodest-dbus-client/libmodest-dbus-client.h:
1171 * libmodest-dbus-client/libmodest-dbus-client.c:
1172 (libmodest_dbus_client_delete_message):
1173 Implement deletion of messages (Client side).
1175 (modest_search_hit_free),
1176 (modest_search_hit_list_free):
1177 Utility functions to free the result hits.
1179 * src/dbus_api/modest-dbus-api.h:
1180 * src/dbus_api/modest-dbus-callbacks.c:
1181 (on_delete_message),
1182 (modest_dbus_req_handler):
1183 Implement deletion of messages (Server side).
1185 * tests/dbus_api/test_search.c: (main):
1188 * tests/dbus_api/Makefile.am:
1189 * tests/dbus_api/test_delete_message:
1190 Add little test for the message deletion logic
1192 2007-06-03 Armin Burgmeier <armin@openismus.com>
1194 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1195 when the operation queue was not empty. projects.maemo.org bug
1198 2007-06-03 Armin Burgmeier <armin@openismus.com>
1200 * src/widgets/modest-account-view.c
1201 (on_account_default_toggled): Toggle default account column
1202 explicitely instead of waiting for gconf notification (which is
1203 currently ignored). This should fix projects.maemo.org bug NB#56910
1204 for now. It should probably be removed when gconf notifications are
1207 2007-06-03 Christian Kellner <ckellner@openismus.com>
1209 * libmodest-dbus-client/libmodest-dbus-client.c:
1210 Removed debugging spew.
1212 * src/dbus_api/modest-dbus-callbacks.c:
1213 Added debugging info.
1215 * src/modest-search.c:
1216 (modest_search_all_accounts):
1217 Use tny_account_store_get_accounts () on the account store
1218 to get all accounts which is the way to get all accounts.
1220 * tests/dbus_api/test_search.c: (main):
1221 Make it possible to supply the search term on the command line.
1223 2007-06-03 Christian Kellner <ckellner@openismus.com>
1225 * libmodest-dbus-client/libmodest-dbus-client.c:
1226 * libmodest-dbus-client/libmodest-dbus-client.h:
1227 Implement searching for mesages over raw dbus. (Client side)
1229 * src/dbus_api/Makefile.am:
1230 * src/dbus_api/modest-dbus-api.h:
1231 * src/dbus_api/modest-dbus-callbacks.c:
1232 * src/dbus_api/modest-dbus-callbacks.h:
1233 Search framework (Server side). Also implement on_idle_open_message().
1235 * src/maemo/modest-platform.c: (modest_platform_init):
1236 Prepare for raw dbus/osso rpc interaction.
1238 * src/modest-search.h:
1239 Changed minsize from unspecific guint to guint32.
1241 * src/modest-search.c:
1243 Added strange hack which magically made tnymail work.
1245 (modest_search_folder),
1246 (modest_search_account),
1247 (modest_search_all_accounts):
1248 Implement helper functions to search all accounts, specific account
1251 * tests/dbus_api/Makefile.am:
1252 * tests/dbus_api/test_open_message.c:
1253 Read url to open from commandline.
1255 * tests/dbus_api/test_search.c:
1256 Implement small test for dbus search stuff
1258 2007-06-02 Armin Burgmeier <armin@openismus.com>
1260 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1261 include account type and account title. This fixes projects.maemo.org
1264 * src/maemo/modest-account-view-window.c: Set a title for the window.
1266 2007-06-02 Armin Burgmeier <armin@openismus.com>
1268 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1269 incoming and outgoing server name based on email address and server
1270 types as long as the names have not been edited manually. This fixes
1271 projects.maemo.org bug NB#58671.
1273 2007-06-02 Armin Burgmeier <armin@openismus.com>
1275 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1276 server type cannot be changed in future to the incoming details page
1277 when creating an account. This fixes projects.maemo.org bug NB#59029.
1279 2007-06-02 Armin Burgmeier <armin@openismus.com>
1281 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1282 and assigned max width chars so that they wrap instead of being
1283 truncated. Fixes projects.maemo.org bug NB#56126.
1285 2007-06-02 Armin Burgmeier <armin@openismus.com>
1287 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1288 introductory note to the connection specific smtp servers dialog, as
1289 section 8.12 of the email UI specification requires. This fixes
1290 projects.maemo.org bug NB#59212.
1292 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1294 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1295 Check for running mail operations, and offer to cancel them, as per the UI
1296 spec. This fixes projects.maemo.org bug NB#59041 .
1297 However, I suspect that tinymail may still use the network connection
1298 in ways that we cannot detect or cancel. But it should at least adapt to
1299 changes fairly well.
1301 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1303 * src/modest-tny-account-store.c: (recreate_all_accounts),
1304 (get_cached_accounts), (get_server_accounts): Do more sensible
1305 ref-counting of the temporarily-cached outbox accounts list. This seems
1306 to fix a crash when entering the password when the password was wrong.
1308 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1310 * src/gnome/modest-main-window.c: (connect_signals):
1311 * src/modest-tny-account-store.c: (get_password),
1312 (modest_tny_account_store_alert): Added comments and clues and
1313 commented-out code about how we currently fail to deal with connection
1314 errors and wrong passwords, and how we should.
1316 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1318 * src/widgets/modest-retrieve-combo-box.c:
1319 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1320 This fixes projects.maemo.org bug NB#58472 .
1322 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1324 * src/maemo/easysetup/modest-easysetup-wizard.c:
1325 (create_page_complete_easysetup):
1326 (create_page_complete_custom): Correct the last commit,
1327 putting the correct sentences in the correct pages.
1329 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1331 * src/maemo/easysetup/modest-easysetup-wizard.c:
1332 (create_page_complete_custom): Show the second sentence of text
1333 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1336 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1338 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1339 Set the leave-on-server conf key by default. This fixes
1340 projects.maemo.org bug NB#59258 .
1342 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1344 * src/maemo/modest-account-view-window.c:
1345 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1346 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1349 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1351 * src/maemo/easysetup/modest-easysetup-wizard.c:
1352 (create_caption_new_with_asterisk):
1353 * src/maemo/modest-account-settings-dialog.c:
1354 (create_caption_new_with_asterisk):
1355 Uncomment the code to add the asterisk, because they are no longer in the
1356 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1357 (update_incoming_server_title): Add an asterisk here too.
1359 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1361 * src/maemo/modest-maemo-global-settings-dialog.c:
1362 (current_connection): Check that we are even connected before trying to
1363 get the current connection name, to prevent a warning.
1365 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1366 Change the comments because tny_maemo_conic_device_connect() is now meant to
1368 * src/modest-mail-operation.c:
1369 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1370 make sure we have a connection and fail if we can't connect.
1372 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1374 * src/maemo/modest-main-window.c:
1375 (on_account_store_connecting_finished): Do not try to get the
1376 connection ID if we are not really connected. I am surprised that
1377 this signal handler is called when we are not connected.
1379 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1381 * src/modest-error.h:
1382 * src/modest-ui-actions.c:
1383 (modest_ui_actions_get_msgs_full_error_handler):
1384 Renamed an enum, added comments, added an enum
1385 for retrieve-limit errors.
1387 * src/modest-mail-operation.c: (foreach_add_item),
1388 (internal_folder_observer_update), (update_account_thread),
1389 (modest_mail_operation_get_msgs_full):
1390 (modest_mail_operation_update_account),
1391 Added comments about how this works, and some code that should
1392 (but does not) check the retrieve-limit. See the TODO comment.
1394 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1396 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1397 Initialize help_id to fix the build. Warnings are good.
1399 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1401 * src/widgets/modest-hbox-cell-renderer.c:
1402 (modest_hbox_cell_renderer_append):
1403 * src/widgets/modest-vbox-cell-renderer.c:
1404 (modest_vbox_cell_renderer_append):
1405 Fix the last commit by doing an extra ref.
1407 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1409 * src/widgets/modest-hbox-cell-renderer.c:
1410 (modest_hbox_cell_renderer_append):
1411 * src/widgets/modest-vbox-cell-renderer.c:
1412 (modest_vbox_cell_renderer_append):
1413 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1414 to fix the build with Maemo Bora.
1415 However, there seems to be a remaining crash, probably due to reference
1418 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1420 * src/modest-tny-account.c:
1421 (modest_tny_account_new_for_local_folders):
1422 Use hildon_file_system_info_async_new() to get a better name for
1423 the memory card account, setting it as the account name.
1424 The timing seems to work, but this is probably
1425 not the best place to do this. See the TODO comment.
1426 * src/maemo/modest-main-window.c: (create_details_widget):
1427 * src/widgets/modest-folder-view.c: (text_cell_data):
1428 Use the tny account name instead of hardcoding a name.
1430 2007-05-30 Christian Kellner <ckellner@openismus.com>
1432 * src/modest-search.c: (modest_search):
1433 Correctly set part_search_func even if we have already parsed
1434 the query and thus a valid OgsTextSearcher object.
1436 2007-05-30 Christian Kellner <ckellner@openismus.com>
1439 Search and check for libogs.
1442 Incooparte the ogs build env.
1444 * src/modest-mime-part-search-stream.c:
1445 * src/modest-mime-part-search-stream.h:
1446 Removed since we do the real searching now in modest-search.c.
1448 * src/modest-search.c:
1449 * src/modest-search.h:
1450 Implement support for ogs. We use that if available and requested
1451 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1452 should now handle the corner case when the search term is spread
1453 across multiple reads.
1454 Also the logic in modest_search () was corrected to search all
1455 requested fields until one is found.
1457 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1459 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1461 * src/modest-init.h:
1462 * src/modest-init.c: Made modest_init_local_folders() take a
1463 path and be public so we can iniitialize maildir folders on
1466 * src/modest-local-folder-info.h:
1467 * src/modest-local-folder-info.c:
1468 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1470 * src/modest-tny-account.c:
1471 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1472 still means the standard local-folders path on the local volume.
1474 * src/modest-tny-account-store.c:
1475 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1476 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1477 all accounts when that happens.
1478 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1479 this too, so it shows up in the treeview.
1481 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1483 * src/maemo/modest-maemo-global-settings-dialog.c:
1484 (current_connection):
1485 * src/widgets/modest-global-settings-dialog.c:
1486 (current_connection_default):
1487 Use the enum values instead of 0, 1 and -1,
1488 to make the code clearer.
1490 * src/modest-account-mgr-helpers.c:
1491 (modest_account_mgr_get_connection_specific_smtp): Make this code
1494 * src/modest-runtime.h:
1495 * src/modest-runtime.c:
1496 Added modest_runtime_remove_all_send_queues().
1497 * src/maemo/modest-main-window.c:
1498 (on_account_store_connecting_finished): Recreate the send queues,
1499 using the appropriate transport accounts for this new connection.
1500 Some futher adapting might be needed if the old send queues are not
1501 automatically stopped at this point.
1503 * src/modest-tny-account-store.c: (get_server_accounts):
1504 Create the connection-specific transport accounts, so that they can
1505 be found later by their ID.
1507 * src/modest-tny-account.h:
1508 * src/modest-tny-account.c:
1509 Added modest_tny_account_new_from_server_account_name().
1510 modest_tny_account_new_from_server_account(): Do not create the
1511 send queues here, because they will be
1512 recreated anyway when the connection changes for the first time.
1514 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1516 * src/modest-local-folder-info.h:
1517 * src/modest-local-folder-info.c:
1518 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1519 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1520 tbox_folder): Take a modest account name instead of a server TnyAccount,
1521 so we can have per-modest-account rather than per-transport-account
1523 We must make sure that we change or recreate the exisitng send queues
1524 when the connection changes for connection-specific transport accounts.
1526 * src/modest-tny-account-store.c:
1527 (create_per_account_local_outbox_folders): Create outboxed per modest
1528 account, not per transport account.
1530 * src/modest-tny-account.h:
1531 * src/modest-tny-account.c:
1532 (modest_tny_account_get_special_folder): For outboxes, get the
1533 parent modest account name. The account is ignored for other folders.
1534 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1535 modest account name rather than a server TnyAccount.
1537 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1539 * src/modest-tny-account.c:
1540 (modest_tny_account_new_from_server_account):
1541 Call modest_runtime_get_send_queue() immediately after creating transport
1542 accounts, so that they start trying to send email from the outbox as soon
1543 as possible at startup. This is probably what we want.
1545 * src/modest-mail-operation.c: (update_account_thread):
1546 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1547 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1548 * src/modest-tny-send-queue.h:
1549 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1550 (modest_ui_actions_on_send):
1551 Added comments about how sending works, though it needs some more work.
1553 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1555 * src/modest-tny-account.c:
1556 (modest_tny_account_get_special_folder): Add TODO because this fails when
1557 the network is busy.
1558 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1559 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1560 Do not try to show this window when there is no active account. The UI
1561 specs does not tell us what to do in this case.
1563 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1567 * src/maemo/Makefile.am:
1568 * src/widgets/Makefile.am: Some dist fixes.
1570 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1572 * src/maemo/modest-connection-specific-smtp-window.c:
1573 (on_button_edit): Make the code clearer, to prevent a double free.
1575 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1577 * src/maemo/modest-account-settings-dialog.c:
1578 (modest_account_settings_dialog_set_account_name),
1579 Check the connection-specific smtp servers checkbox if there are any.
1581 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1582 (modest_connection_specific_smtp_edit_window_init):
1583 Start with a suitable port number.
1585 * src/modest-account-mgr-helpers.h:
1586 * src/modest-account-mgr-helpers.c: Added
1587 modest_account_mgr_get_has_connection_specific_smtp().
1589 (modest_account_mgr_set_connection_specific_smtp),
1590 (modest_account_mgr_remove_connection_specific_smtp),
1591 (modest_account_mgr_get_has_connection_specific_smtp),
1592 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1593 connection-specific smtp server accounts in the account, rather than
1594 the server account conf dir.
1596 This fixes bug projects.maemo.org bug NB#58263 .
1598 * src/modest-tny-account-store.c:
1599 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1600 if there are no server accounts yet, to prevent an infinite loop when there
1601 are no accounts. Document that one must be called before the other.
1603 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1605 * src/modest-account-mgr-helpers.c:
1606 (modest_account_mgr_get_default_account): Make sure that at least
1607 one account is always the default, if there are any enabled accounts.
1608 This is just a sanity check that shouldn't be necessary.
1610 * src/modest-account-mgr-priv.c:
1611 (_modest_account_mgr_account_from_key): Unescape the conf key to
1612 get the real account name. For instance, this is an issue if a space
1613 was in the account name, which can happen because the account name
1614 is generated from the display name.
1615 (_modest_account_mgr_get_account_keyname): Always escape the
1617 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1618 Unescape the conf keys to get the real account names.
1620 For instance, previously the is-default radio button in the accounts
1621 list was not checked for any accounts at first. This fixes that,
1622 and might fix several similar bugs.
1624 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1626 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1627 Removed some debug printfs.
1629 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1631 Modest on-disk outbox directories are now here, for instance:
1632 $HOME/.modest/outboxes/<account-id-1>/outbox
1633 $HOME/.modest/outboxes/<account-id-2>/outbox
1635 $HOME/.modest/local-folders/outbox
1636 so we can have a separate outbox for each account.
1637 But they are shown as one outbox in the GtkTreeView, by using a
1638 TnyMergeFolder in a ModestTnySimpleFolderStore.
1641 * src/modest-tny-simple-folder-store.c:
1642 * src/modest-tny-simple-folder-store.h:
1643 Added ModestTnySimpleFolderStore, used to contain folders from
1644 other folder stores, such as other accounts.
1646 * src/modest-tny-outbox-account.h:
1647 * src/modest-tny-outbox-account.c:
1648 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1649 used for the per-account local outbox folders.
1651 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1652 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1653 only use this (internally) now for the non-outbox local folders.
1655 * src/modest-init.h:
1656 * src/modest-init.c: Added modest_init_one_local_folder(), for
1657 setting up the directory structure for each local folder.
1659 * src/modest-local-folder-info.c:
1660 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1661 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1663 * src/modest-local-folder-info.h:
1664 * src/modest-tny-account-store.c: (on_account_removed),
1665 (on_account_changed), (create_per_account_local_outbox_folders),
1666 (get_server_accounts), (modest_tny_account_store_get_accounts),
1667 (modest_tny_account_store_get_tny_account_by_account),
1668 (modest_tny_folder_store_is_virtual_local_folders):
1670 * src/modest-tny-account.h:
1671 * src/modest-tny-account.c:
1672 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1673 to create an on-disk per-account local outbox folder for each
1675 (create_per_account_local_outbox_folders): Create a local outbox folder
1676 for each transport account.
1677 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1678 for all local folders.
1680 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1681 instead of using g_object_get/set() directly. It is clearer.
1683 (modest_tny_folder_store_get_message_count),
1684 (modest_tny_folder_store_get_local_size
1685 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1686 because we now use these with non-acount folder stores.
1688 (modest_tny_account_get_special_folder),
1689 (modest_tny_account_new_from_server_account),
1690 (modest_tny_account_new_from_account):
1691 (recurse_folders): Adjust to the new outbox system.
1693 * src/modest-tny-folder.h:
1694 * src/modest-tny-folder.c:
1695 (modest_tny_folder_is_local_folder),
1696 (modest_tny_folder_get_local_folder_type),
1697 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1699 * src/widgets/modest-main-window.h:
1700 * src/maemo/modest-main-window.c: (create_details_widget),
1701 (modest_main_window_set_contents_style): Show details for any folder store,
1704 (modest_tny_folder_get_rules):
1705 Remove the const. C does not support constness enough for this.
1707 * src/modest-ui-actions.c:
1708 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1709 make all outboxes appear as one, in the usual local-folders tree node.
1711 (set_active_account_from_tny_account),
1712 (modest_ui_actions_on_folder_selection_changed):
1713 * src/widgets/modest-folder-view.c: (text_cell_data),
1714 (icon_cell_data), (filter_row),
1715 (add_account_folders_to_merged_folder),
1716 (add_account_folders_to_simple_folder_store), (),
1717 (get_cmp_rows_type_pos), (cmp_rows),
1718 (modest_folder_view_set_account_id_of_visible_server_account):
1719 Adjust to the new outbox system, using generic folder stores and folders
1720 in the GtkTreeModel.
1722 2007-05-23 Christian Kellner <ckellner@openismus.com>
1724 * src/modest-mail-operation.c:
1725 (modest_mail_operation_update_account):
1726 Use info->max_size instead of unintialized local var [small
1727 build fix]. (Added TODO to review that change since I don't
1730 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1732 * libmodest-dbus-client/libmodest-dbus-client.c:
1733 (libmodest_dbus_client_compose_mail): function added
1734 * src/dbus_api/modest-dbus-api.h:
1735 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1736 (on_compose_mail): Implementation of the SendAsMail functionality
1738 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1740 * src/modest-account-mgr.c:
1741 (modest_account_mgr_add_server_account): Set the secure-connection
1742 conf key for transport accounts as well as store accounts. I don't know
1743 why the if was there. For instance, this makes sure that we use SSL
1744 for the gmail preset from the easysetup wizard.
1746 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1748 * src/gnome/modest-main-window.c:
1749 (on_account_store_connecting_finished), (connect_signals):
1750 * src/maemo/modest-main-window.c:
1751 (on_account_store_connecting_finished), (connect_signals),
1752 (modest_main_window_new):
1753 Handle TnyAccountStore::connecting-finished instead of
1754 TnyDevice::connection-changed, because we cannot actually perform
1755 operations on accounts until TnyAccountStore has itself responded to
1756 the TnyDevice::connection-changed signal. This prevents a GError from
1758 Do not try to update at startup, because we (at least on scratchbox)
1759 already do an update at startup when the device goes online.
1760 This prevents a GError from tinymail.
1761 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1762 Added TODO about stopping simultaneous operations.
1764 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1766 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1767 * src/modest-mail-operation-queue.c:
1768 (modest_mail_operation_queue_remove):
1769 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1770 about where they happened.
1772 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1774 * src/modest-ui-actions.c:
1775 (modest_ui_actions_on_password_requested): Make sure that the remember
1776 output parameter is always TRUE.
1778 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1780 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1781 Show a OK/Cancel dialog if the error is a question, though we still do not
1782 know anything more about what we are asking the user.
1783 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1784 Fix an uninitialized variable (helper). This is a logic error, however.
1786 2007-05-21 Christian Kellner <ckellner@openismus.com>
1788 * src/modest-search.h:
1789 Correct bit shifting in the ModestSearchFlags enum.
1791 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1793 * src/modest-tny-account.c:
1794 (modest_tny_account_new_from_server_account): Do not use the lsub and
1795 check-all hard-coded IMAP options when using POP.
1797 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1799 * src/modest-tny-account.c:
1800 (modest_tny_account_new_from_server_account):
1801 Use NULL for the secure-auth method for POP when Password auth has been
1802 specified by the user, as we already do for IMAP. "auth=Login" causes
1803 an error from camel or the server.
1805 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1807 * src/maemo/modest-account-settings-dialog.c:
1808 (create_page_account_details),
1809 (modest_account_settings_dialog_set_account_name):
1810 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1811 for the leave-on-server checkbox, rathr than just the checkbox, when
1812 the protocol is not POP.
1814 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1816 * src/widgets/modest-account-view.c:
1817 * src/widgets/modest-account-view.h:
1818 Added modest_account_view_select_account() which will be useful later
1819 to asynchronously re-select the edited account.
1821 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1823 * src/maemo/modest-account-settings-dialog.c:
1824 (modest_account_settings_dialog_set_account_name):
1825 Automatically choose the port numbers based on the secure authentication
1826 methods, if they have not been chosen before.
1827 This fixes projects.maemo.org bug NB#56273 .
1829 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1831 * src/maemo/modest-main-window-ui.h:
1832 * src/modest-ui-actions.c:
1833 * src/modest-ui-actions.h:
1834 Connect the Tools/SMTP Servers menu item to
1835 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1836 SMTP servers dialog, as in the UI specification and saves changes when it
1837 is closed. This fixed projects.maemo.org bug NB#56305 .
1839 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1841 * src/maemo/modest-connection-specific-smtp-window.c:
1842 (modest_connection_specific_smtp_window_init):
1843 Use gtk_window_set_default_size() to make this window big enough, so
1844 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1846 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1848 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1849 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1850 (modest_connection_specific_smtp_edit_window_init),
1851 Do not try to connect to a combobox signal before the combobox exists.
1852 This fixes the cras in projects.maemo.org bug NB#56288 .
1853 (modest_connection_specific_smtp_edit_window_get_settings):
1854 Remove the server_account_name parameter which was being checked for NULL
1855 though it was not used.
1857 * src/maemo/modest-connection-specific-smtp-window.c:
1858 (modest_connection_specific_smtp_window_fill_with_connections),
1859 (on_button_edit), (modest_connection_specific_smtp_window_init):
1860 Correct the number of treemodel columns to prevent a warning.
1861 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1862 libconic does not work.
1864 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1866 * src/modest-tny-account.c:
1867 (modest_tny_account_new_from_server_account):
1868 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1869 SMTP when "None" was chosen by the user. However, with my SMTP server that
1870 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1873 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1875 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1876 to explain the memory management issue with the ID in the ModestPair.
1878 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1879 (add_sending_page), (modest_account_assistant_finalize):
1880 * src/gnome/modest-gnome-global-settings-dialog.c:
1881 (create_updating_page), (create_composing_page):
1882 * src/gnome/modest-msg-edit-window.c: (get_transports),
1883 (init_window), (modest_msg_edit_window_finalize),
1884 (modest_msg_edit_window_get_msg_data):
1885 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1886 * src/gnome/modest-transport-widget.c:
1887 (modest_transport_widget_finalize), (smtp_configuration):
1888 * src/maemo/modest-maemo-global-settings-dialog.c:
1889 (create_updating_page), (create_composing_page):
1890 * src/maemo/modest-msg-edit-window.c: (get_transports),
1891 (init_window), (modest_msg_edit_window_finalize),
1892 (modest_msg_edit_window_get_msg_data),
1893 (modest_msg_edit_window_free_msg_data):
1894 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1895 (modest_store_widget_finalize):
1896 * src/maemo/modest-transport-widget.c:
1897 (modest_transport_widget_finalize), (smtp_configuration):
1898 * src/modest-main.c: (send_mail):
1899 * src/widgets/modest-combo-box.h:
1900 * src/widgets/modest-global-settings-dialog-priv.h:
1901 * src/widgets/modest-global-settings-dialog.c:
1902 (modest_global_settings_dialog_finalize):
1903 * src/widgets/modest-msg-edit-window.h:
1904 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1905 as long as the combo box, to prevent use of freed memory for the ID.
1907 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1909 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1910 get_accounts(), to make this clearer. Do not check for the enabled gconf
1911 key, because we do not use this for server accounts (at least, not yet).
1912 This allows us to send email again.
1914 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1916 * src/maemo/modest-platform.c:
1917 (on_modest_conf_update_interval_changed), (modest_platform_init):
1918 Only respond to this particular key change. All these strcmp()s cannot be
1921 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1923 * src/maemo/modest-maemo-global-settings-dialog.c:
1924 (current_connection): Prevent a crash in scratchbox when
1925 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1926 * src/maemo/modest-platform.c:
1927 (on_modest_conf_update_interval_changed), (modest_platform_init):
1928 Get the update interval from gconf and reset it when the gconf key changes.
1930 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1932 * src/modest-protocol-info.c:
1933 * src/modest-protocol-info.h: Adde enum-specific get functions,
1934 instead of using a ModestProtocolType enum parameter.
1936 * src/gnome/modest-account-assistant.c:
1937 * src/gnome/modest-store-widget.c:
1938 * src/gnome/modest-store-widget.h:
1939 * src/gnome/modest-transport-widget.c:
1940 * src/gnome/modest-transport-widget.h:
1941 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1942 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1943 * src/maemo/easysetup/modest-easysetup-wizard.c:
1944 * src/maemo/modest-account-settings-dialog.c:
1945 * src/maemo/modest-account-settings-dialog.h:
1946 * src/maemo/modest-store-widget.c:
1947 * src/maemo/modest-store-widget.h:
1948 * src/maemo/modest-transport-widget.c:
1949 * src/maemo/modest-transport-widget.h:
1950 * src/modest-account-mgr-helpers.c:
1951 * src/modest-account-mgr-helpers.h:
1952 * src/modest-account-mgr.c:
1953 * src/modest-account-mgr.h:
1954 * src/modest-tny-account.c:
1955 * src/modest-tny-folder.c:
1956 * src/widgets/modest-account-view.c:
1957 * src/widgets/modest-retrieve-combo-box.c:
1958 * src/widgets/modest-retrieve-combo-box.h:
1959 * src/widgets/modest-secureauth-combo-box.c:
1960 * src/widgets/modest-serversecurity-combo-box.c:
1961 * src/widgets/modest-serversecurity-combo-box.h:
1962 * tests/check_account-mgr.c:
1963 Use the specific functions, and use the re-renamed enum values for GNOME too.
1965 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1967 * src/modest-pair.h:
1968 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1969 so we can get the second based on the first.
1971 * src/maemo/modest-account-settings-dialog.h:
1972 * src/maemo/modest-account-settings-dialog.c:
1973 Added get_supported_secure_authentication_methods(), though it is mostly
1974 commented-out for now until the necessary API is committed to tinymail.
1975 (modest_account_settings_dialog_set_account_name),
1976 (save_configuration): Request the supported authentication methods from the
1977 server, so we can choose a working method.
1979 * src/modest-tny-account-store.h:
1980 * src/modest-tny-account-store.c:
1981 (modest_tny_account_store_get_session): Rename from
1982 tny_account_store_get_session().
1984 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1986 * src/modest-protocol-info.h: Split the ModestProtocol enum
1987 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1988 There was no need to have these unrelated values in one enum.
1990 * src/: many files: Adapted to changed enum. This makes the code a bit
1991 clearer, and the compiler could catch some errors.
1993 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1995 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1996 Show the detailed internal camel error message when an error happens
1997 during the configuration, so that our testers can give us more clues.
1998 For instance, in projects.maemo.org bug NB#56910 .
2000 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2002 * src/modest-tny-account.c:
2003 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2004 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2006 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2008 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2009 * src/maemo/modest-account-settings-dialog.c:
2010 (modest_account_settings_dialog_set_account_name),
2011 (save_configuration): For the incoming secure authentication checkbox,
2012 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2013 the UI specification. PLAIN does not seem to be supported for most IMAP
2014 servers anyway, and I am not sure what it would mean.
2015 However, we probably need to discover which of the secure-authentication
2016 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2017 * src/modest-account-mgr-helpers.c:
2018 (modest_account_mgr_get_server_account_data):
2020 * src/modest-tny-account.c:
2021 (modest_tny_account_new_from_server_account):
2022 Use tny_account_set_mech() to set secure-authentication methods,
2023 with some special-casing for IMAP, based on my observations of how
2026 * src/modest-account-mgr-helpers.h:
2027 * src/modest-account-mgr.c:
2028 * src/modest-defs.h: Comment that the URI is only used for local folders.
2030 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2032 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2033 parameter const, just to be neat.
2034 * src/modest-text-utils.c: (modest_text_utils_inline):
2035 End g_strconcat() with NULL, as its documentation says. This is almost
2036 certainly the cause of my crash at startup on the device. Interestingly,
2037 valgrind doesn't tell us about these errors.
2039 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2041 * scripts/build-packages: Added more precise comments about how to use
2042 this script, though I still get this error:
2043 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2044 error building tinymail
2046 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2048 * src/maemo/modest-main-window.c: (on_account_update):
2049 Very slight cleanup, hoping to make it simpler to discover what causes
2050 a crash here sometimes.
2052 * src/modest-tny-account.c:
2053 (modest_tny_account_new_from_server_account): Set the port. Added
2054 comments about the options and a TODO comment because I need to find out
2055 how to specify the secure authentication method.
2057 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2059 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2060 changed CFlags paths form modest to libmodest
2062 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2064 * src/modest-account-mgr-helpers.c:
2065 (modest_account_mgr_get_server_account_data),
2066 (modest_account_mgr_free_server_account_data):
2067 * src/modest-account-mgr-helpers.h:
2068 * src/modest-account-mgr.c:
2069 (modest_account_mgr_add_server_account):
2070 * src/modest-defs.h:
2071 * src/modest-tny-account.c:
2072 (modest_tny_account_new_from_server_account):
2073 Determine the options for tny_camel_account_add_option() here,
2074 based on the settings, rather than storing them directly in gconf.
2076 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2078 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2079 Show a more friendly error dialog now that we expect (from the tinymail
2080 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2082 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2084 * src/maemo/modest-main-window.c: (on_account_update): Check that
2085 account_name is not NULL, to prevent a crash at startup that I am
2086 seeing on the N800. I do wonder why it is NULL.
2088 * src/maemo/easysetup/modest-easysetup-wizard.c:
2089 (create_page_user_details):
2090 * src/maemo/modest-account-settings-dialog.c:
2091 (create_page_user_details), (create_page_outgoing):
2092 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2093 (modest_connection_specific_smtp_edit_window_init):
2094 * src/modest-ui-actions.c:
2095 (modest_ui_actions_on_password_requested):
2096 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2097 might do something useful with the on-screen keyboard.
2099 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2101 * src/maemo/modest-main-window.c: (on_account_update):
2102 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2103 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2105 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2107 * src/modest-tny-account-store.c: (on_account_changed):
2108 Correct the signature of this signal handler.
2110 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2112 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2113 Show a HildonNote instead of a GtkDialog for Maemo.
2115 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2117 * src/widgets/modest-account-view.h:
2118 * src/widgets/modest-account-view.c: (on_account_changed),
2119 (on_account_removed). Added a boolean flag, set/unset by
2120 modest_account_view_block_conf_updates(),
2121 modest_account_view_unblock_conf_updates() to prevent unnecessary
2122 updates, but this is not very useful because the gconf notifications are
2123 so delays (maybe only on Maemo Bora).
2124 So auto-updating is turned off, and these functions do an explicit
2125 update when necessary.
2126 However, something else is still doing too much work when adding/removing
2127 accounts, probably in another part of the application.
2129 * src/maemo/modest-account-view-window.c:
2130 (on_delete_button_clicked), (on_edit_button_clicked),
2131 (on_new_button_clicked): Use the new functions.
2133 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2135 * src/modest-account-mgr-helpers.c:
2136 (modest_account_mgr_set_first_account_as_default):
2137 Sort the list of names alphabetically-by-title, so we choose the first one
2139 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2140 alphabetically by the title.
2142 This fixes projects.maemo.org bug NB#56418 .
2144 * src/modest-account-mgr-priv.c:
2145 (_modest_account_mgr_account_from_key):
2146 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2147 avoid a valgrind error, and possible random behaviour.
2149 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2151 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2152 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2153 tinymail documentation to say that this can be expected.
2154 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2155 pretty, and should not happen, but I would prefer to know when it does.
2157 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2159 * configure.ac: When using the older hildon version, probably on Bora,
2160 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2162 * src/widgets/modest-attachment-view.c:
2163 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2166 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2168 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2169 Implemented the prototype. Can be tested with
2170 tests/dbus_api/test_open_message:
2172 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2174 * src/modest-tny-account-store.c:
2175 (modest_tny_account_store_instance_init), (get_password):
2176 * src/modest-ui-actions.c:
2177 (modest_ui_actions_on_password_requested):
2178 Do not store the password in gconf, because this function is called
2179 for non-remembered passwords. Actually use the cached (in the hash map)
2180 password instead of releasing it.
2181 The password will now not be remembered if it is asked via the protected
2182 password dialog, as per the UI spec.
2184 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2186 * src/modest-defs.h:
2187 * src/modest-account-mgr-helpers.h:
2188 * src/modest-account-mgr-helpers.c:
2189 Added modest_server_account_get_username_has_succeeded(),
2190 modest_server_account_set_username_has_succeeded().
2191 (modest_server_account_set_username),
2192 Reset the has-succeeded flag if the username changes.
2194 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2195 * src/maemo/modest-connection-specific-smtp-window.c:
2196 (modest_connection_specific_smtp_window_save_server_accounts):
2197 Use modest_server_account_set_username() instead of using
2198 modest_conf_set_string() directly, so that the has-succeeded flag is always
2201 * src/modest-ui-actions.c:
2202 (modest_ui_actions_on_password_requested): Dim the username entry if
2203 the username has ever worked, as per the UI spec.
2205 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2207 * src/modest-tny-account-store.c: (get_password):
2208 * src/modest-ui-actions.c:
2209 (modest_ui_actions_on_password_requested):
2210 Allow the username to be changed too, though there is more work to
2211 be done on exactly how this behaves.
2213 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2215 * src/modest-account-mgr-helpers.h:
2216 * src/modest-account-mgr-helpers.c:
2217 Added modest_account_mgr_get_display_name(),
2218 modest_server_account_get_username(),
2219 modest_server_account_set_username(),
2220 modest_server_account_set_password(),
2221 modest_server_account_get_hostname() functions so we do not need to
2222 use the conf API directly.
2224 * src/maemo/modest-main-window.c: (connect_signals):
2225 Actually connect ot the ModestAccountStore::request-password signal,
2226 so that we show the dialog when the password is requested by Tinymail,
2227 for isntance if it is empty.
2229 * src/modest-marshal.list:
2230 * src/modest-tny-account-store.c:
2231 (modest_tny_account_store_class_init), (get_password),
2232 (modest_tny_account_store_alert):
2233 * src/modest-tny-account-store.h:
2234 * src/modest-ui-actions.h:
2235 * src/modest-ui-actions.c:
2236 (modest_ui_actions_on_password_requested):
2237 Change the signal parameters, so it is obvious that we are providing
2238 the non human-readable server name, and receiving both the username
2239 and password, though changing of the username is not yet implemented.
2240 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2241 for the GNOME version.
2243 This should fix the projects.maemo.org bug NB#56209, though it does not
2244 work on Bora, because the gconf_client_get() for the password fails
2245 immediately after we save it with gconf_client_set().
2247 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2250 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2251 caused an undefined symbol error:
2252 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2254 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2256 * src/modest-tny-account-store.c:
2257 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2258 using a GError instead of a string message, so we can translate it in
2261 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2263 * src/maemo/modest-address-book.c:
2264 (modest_address_book_check_names):
2265 * src/maemo/modest-msg-view-window.c:
2266 (modest_msg_view_window_clipboard_owner_change):
2267 * src/modest-init.c: (modest_init_init_ui):
2268 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2269 (update_folders_cb), (modest_mail_operation_update_account):
2270 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2271 (modest_ui_actions_on_msg_attachment_clicked),
2272 (modest_ui_actions_on_msg_recpt_activated):
2273 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2274 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2275 (modest_msg_view_search_next):
2276 * src/widgets/modest-recpt-editor.c:
2277 (modest_recpt_editor_on_button_release_event),
2278 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2279 g_message(). At this point we should only be seeing interesting errors on
2280 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2282 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2284 (modest_wizard_dialog_force_title_update):
2285 * src/maemo/easysetup/modest-wizard-dialog.h:
2286 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2287 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2288 can update the title when appropriate. Otherwise the title is wrong if the
2289 pages are added after adding the notebook to the dialog.
2290 This must be a problem in HildonWizardDialog too.
2291 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2293 * src/maemo/easysetup/modest-easysetup-wizard.c:
2294 (create_subsequent_customsetup_pages),
2295 (create_subsequent_easysetup_pages):
2296 Call modest_wizard_dialog_force_title_update() so that the title is
2297 correct even with GTK+ < 2.10.
2298 This fixes projects.maemo.org bug NB#56145 .
2300 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2302 * src/maemo/modest-platform.c:
2303 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2304 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2307 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2309 * src/widgets/modest-window.h:
2310 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2311 and modest_window_save_state(), which invokes it.
2313 * src/widgets/modest-window-mgr.h:
2314 * src/widgets/modest-window-mgr.c:
2315 Added modest_window_mgr_save_state_for_all_windows(), which calls
2316 the save_state vfunc on all registered windows, if implemented.
2318 * src/gnome/modest-msg-edit-window.c:
2319 * src/gnome/modest-msg-view-window.c:
2320 * src/maemo/modest-msg-edit-window.c:
2321 * src/maemo/modest-msg-view-window.c:
2322 * src/maemo/modest-main-window.c:
2323 Specify the existing save_settings functions as implementations of
2324 ModestWindow::save_state_func().
2326 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2327 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2328 enabling hibernation, for instance.
2330 We may need to do the same thing for restoring settings.
2333 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2335 * src/widgets/modest-window-mgr.c:
2336 * src/widgets/modest-window-mgr.h:
2337 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2338 modest_window_mgr_get_hibernation_is_prevented().
2340 * src/maemo/modest-main-window.c:
2341 (on_hildon_program_is_topmost_notify): Prevent hibernation
2342 (possible when the application goes to the background in the WM),
2343 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2345 * src/maemo/easysetup/modest-easysetup-wizard.c:
2346 (modest_easysetup_wizard_dialog_init):
2347 * src/maemo/modest-account-settings-dialog.c:
2348 (modest_account_settings_dialog_init):
2349 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2350 (modest_connection_specific_smtp_edit_window_init):
2351 * src/maemo/modest-connection-specific-smtp-window.c:
2352 (modest_connection_specific_smtp_window_init):
2353 * src/maemo/modest-signature-editor-dialog.c:
2354 (modest_signature_editor_dialog_init):
2355 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2356 prevent hibernation while any of these account settings dialogs are open.
2358 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2360 * src/maemo/Makefile.am:
2361 * src/maemo/modest-osso-state-saving.c:
2362 * src/maemo/modest-osso-state-saving.h: Added
2363 modest_osso_load_state() and modest_osso_save_state() though they do
2364 nothing now. They should iterate through all the open windows and load/save
2366 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2367 save state when closing.
2369 * src/maemo/modest-main-window.c:
2370 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2371 Add a notification handler for the HildonProgram::is-topmost property,
2372 so we can allow hibernation when the application goes into the background.
2373 But we still need to detect when the accounts setup windows are open so
2374 we can stop hibernation when they are open.
2375 To do this, I also added the main window the HildonProgram. This might have
2376 other side-effects/benefits, and should maybe be done for other windows.
2378 * src/maemo/modest-osso-autosave-callbacks.h:
2379 * src/maemo/modest-osso-autosave-callbacks.c:
2380 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2381 though it does not do anything yet, and we might never need this to do
2382 anything. For instance, we already save drafts.
2384 * src/maemo/modest-platform.c: (modest_platform_init):
2385 Specify the libosso auto-save callback.
2387 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2389 * src/maemo/modest-platform.c:
2390 (modest_platform_set_update_interval):
2391 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2392 aparently stays valid between application instances, so we can use this
2393 to remove and reset it later. According to a maemo-developers email from
2396 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2398 * configure.ac: Depend on libalarm for Maemo.
2400 * src/dbus_api/modest-dbus-api.h:
2401 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2402 (on_send_receive), (modest_dbus_req_handler):
2403 Handle a SEND_RECEIVE D-Bus method.
2405 * libmodest-dbus-client/libmodest-dbus-client.c:
2406 (libmodest_dbus_client_send_and_receive):
2407 * libmodest-dbus-client/libmodest-dbus-client.h:
2408 Add C convenience functions for calling the new D-Bus method.
2410 * src/modest-platform.h:
2411 * src/gnome/modest-platform.c:
2412 * src/maemo/modest-platform.c:
2413 Added modest_platform_set_update_interval(), which uses the
2414 alarmd API on Maemo.
2415 (modest_platform_init),
2416 Call modest_platform_set_update_interval(), using a hard-coded
2417 interval for now (until the global settings dialog is implemented),
2418 though I am not sure that this makes sense yet.
2420 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2422 * src/dbus_api/modest-dbus-callbacks.c:
2423 (modest_osso_cb_hw_state_handler):
2424 * src/dbus_api/modest-dbus-callbacks.h:
2425 * src/maemo/modest-platform.c: (modest_platform_init):
2426 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2427 in case this has some effect on the ability for Maemo to ping the
2430 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2432 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2433 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2434 warning. It is probably a logic error, but I need to fix the build.
2436 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2438 * src/modest-account-mgr.h:
2439 * src/modest-account-mgr.c:
2440 (modest_account_mgr_account_names): Add a gboolean enabled_only
2441 parameter, so we can get lists of onlt the enabled accounts.
2443 (modest_account_mgr_add_account),,
2444 (modest_account_mgr_account_with_display_name_exists):
2445 * src/maemo/modest-msg-edit-window.c: (get_transports):
2446 * src/modest-account-mgr-helpers.c:
2447 (modest_account_mgr_set_first_account_as_default):
2448 * src/modest-init.c: (init_default_account_maybe):
2449 * src/modest-tny-account-store.c: (get_accounts):
2450 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2451 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2452 * tests/check_account-mgr.c: (START_TEST):
2453 Provide the extra parameter, as appropriate.
2455 * src/widgets/modest-account-view.c: (update_account_view):
2456 Do not show disabled accounts (meaning that there is no way to
2457 enable/disable accounts in the UI (the feature is not in our UI
2458 specification), so we can use this internally only to mark unfinished
2459 or temporary account data.
2461 * src/maemo/easysetup/modest-easysetup-wizard.c:
2462 (create_account): Add boolean enable parameter, so we can specify FALSE
2463 to create the temporary account.
2464 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2465 (on_before_next): When finishing, when there is a temporary account, just
2467 Also, use a timeout to delay the showing of the dialog until gconf is likely
2468 to return correct information, due to a maemo gconf bug that is fixed in
2469 osso 1.1, but not yet in Bora.
2470 However, the dialog stays on screen after it is destroyed.
2472 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2473 for invalid data when cancelling. Use a hildon note instead of a dialog
2474 to complain about invalid data. Do not show the account-saved note if the
2475 account is disabled (a temporary account that will not really be saved for use
2478 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2480 * src/modest-account-mgr-helpers.h:
2481 * src/modest-account-mgr-helpers.c:
2482 Added modest_account_mgr_unset_default_account(),
2483 Added modest_account_mgr_set_first_account_as_default().
2485 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2486 If it was the default account, unset the default account name.
2488 * src/maemo/modest-account-view-window.c:
2489 (on_delete_button_clicked): If it was the default account,
2490 set the first remaining account as the default instead.
2492 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2493 a NULL account or a NULL default account, to prevent a crash. This should
2494 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2497 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2499 * src/widgets/modest-recpt-editor.c:
2500 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2501 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2502 TODO comment for this. This fixes the build.
2504 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2505 be the best place for it. This will in future update all auto-update accounts,
2506 rather than just the current/default account, when that gconf key exists.
2507 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2508 if there are no accounts, before calling do_send_receive().
2509 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2511 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2512 * src/maemo/modest-main-window-ui.h:
2513 * src/maemo/modest-main-window.c: (on_connection_changed),
2514 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2515 directly, becaue the signal handler does more.
2517 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2519 * src/modest-account-mgr-helpers.c:
2520 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2521 for the case that the account does not exist.
2523 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2524 (equivalent to the modest account name) rather than the tinymail account name
2525 (equivalent to the modest account title - human readable) to get the account data.
2526 Check for null account data to prevent the crash, and add a TODO comment saying that
2527 this needs fixing because it is using the server account name instead of the account name.
2529 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2531 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2532 * src/maemo/modest-account-settings-dialog.c: (show_error),
2534 Use hildon_note_new_information() for informative and error messages,
2535 which seems to be expected for Maemo applications (no documentation that I know of
2536 says this). I am surprised that there is no distinction between info and error
2539 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2541 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2542 it is easy to find where this is used.
2544 * src/maemo/easysetup/modest-easysetup-wizard.c:
2545 (create_page_welcome), (create_page_account_details),
2546 (create_page_user_details), (create_page_complete_easysetup),
2547 (create_page_custom_incoming), (create_page_custom_outgoing),
2548 (create_page_complete_custom):
2549 * src/maemo/modest-account-settings-dialog.c:
2550 (create_page_account_details), (create_page_user_details),
2551 (create_page_incoming), (create_page_outgoing):
2552 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2553 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2554 (modest_connection_specific_smtp_edit_window_init):
2555 * src/maemo/modest-connection-specific-smtp-window.c:
2556 (modest_connection_specific_smtp_window_init):
2557 * src/maemo/modest-signature-editor-dialog.c:
2558 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2559 and scrolling policy as per the Email Application Layout Guide, if I have
2562 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2564 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2565 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2566 which were empty, because these vfuncs have been removed from TnyAccountStore.
2567 This fixes the build.
2569 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2571 * src/maemo/modest-main-window.c:
2572 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2573 showing/hiding it. Added TODO because it probably should not be NULL.
2574 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2575 because unnecessary g_warnings() make degugging difficult.
2577 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2579 * src/maemo/modest-msg-edit-window.c:
2580 (modest_msg_edit_window_select_color),
2581 (modest_msg_edit_window_select_background_color): 2 const corrections and
2582 moving 2 #endifs before closing brackets, to fix the build.
2584 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2586 * src/maemo/easysetup/modest-easysetup-wizard.h:
2587 * src/maemo/easysetup/modest-easysetup-wizard.c:
2588 (modest_easysetup_wizard_dialog_finalize),
2589 (on_button_edit_advanced_settings), (create_page_complete_custom),
2590 (on_response), (create_account):
2591 Implement the Advanced Settings edit button, by saving the account information,
2592 for the Advanded Settings dialog to use directly from gconf, and removing it
2593 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2594 Bug #5533 in the projects.maemo.org bugzilla.
2596 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2598 * src/maemo/modest-msg-view-window.c:
2599 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2600 when opening a message window.
2602 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2604 * src/maemo/easysetup/modest-easysetup-wizard.c:
2605 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2608 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2609 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2610 gconf settings. I probably added more checks than necessary, but that is safer.
2612 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2613 variable to fix the build, but this seems to be used when it is still NULL.
2615 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2617 * src/modest-platform.h:
2618 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2619 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2620 * src/modest-main.c: Implement this function so we can avoid using
2621 maemo-specific API from cross-platform code.
2623 * src/modest-tny-account-store.c:
2624 (get_smtp_specific_transport_account_for_open_connection):
2625 * src/modest-ui-actions.c: (check_for_connection),
2626 (modest_ui_actions_on_item_not_found):
2627 Use modest_platform_connect_and_wait() and put #idefs around other
2628 maemo-specific code, because only maemo currently has a way to
2629 identify connection names.
2631 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2633 * src/modest-tny-account-store.h:
2634 * src/modest-tny-account-store.c:
2635 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2636 the connection-specific SMTP server settings in the configuration.
2638 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2640 * src/maemo/modest-main-window.c: (on_connection_changed),
2642 * src/modest-main.c: (main), (start_ui), (send_mail):
2643 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2644 that is what is intended.
2646 * src/modest-ui-actions.c: (action_send), (action_receive),
2647 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2648 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2649 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2650 SMTP server is used when it is specified.
2652 (modest_ui_actions_on_send_receive):
2653 Check that a connection is open before proceeding.
2654 Receive and then send, instead of vice-versa, as per the specification.
2656 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2658 * src/modest-mail-operation.c:
2659 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2660 though I guess it should be something other than NULL.
2662 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2664 * src/maemo/easysetup/modest-easysetup-wizard.c:
2665 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2666 combo twice, to avoid an g_warning and to make it visible again.
2667 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2668 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2669 (already intended) dereference when detaching, because we then recreate the menu.
2670 But I am not sure why the warning was happening, and it is possible that this is a memory
2673 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2675 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2676 and uri_parse_mailto() utility functions.
2677 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2679 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2681 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2683 * src/dbus_api/modest-dbus-api.h:
2684 * src/dbus_api/modest-dbus-callbacks.c:
2685 Use an idle callback to execute the modest code in the application's own thread.
2686 Remove the helloworld example method.
2687 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2688 parsed, and the open-message method is not implemented because this is not yet implemented in
2690 * libmodest-dbus-client/libmodest-dbus-client.c:
2691 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2692 (libmodest_dbus_client_open_message):
2693 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2695 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2696 body without crashing.
2698 * tests/dbus_api/Makefile.am:
2699 * tests/dbus_api/test_mail_to.c:
2700 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2702 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2704 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2705 Added file to fix the build. Sorry.
2707 * src/dbus_api/Makefile.am:
2708 * src/dbus_api/modest-dbus-api.h:
2709 * src/dbus_api/modest-dbus-callbacks.h:
2710 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2711 (modest_dbus_req_handler):
2712 Put constants in a separate header so it can be reused by the
2713 client library, without duplication
2715 * libmodest-dbus-client/Makefile.am:
2716 * libmodest-dbus-client/libmodest-dbus-client.c:
2717 (libmodest_dbus_client_call_helloworld),
2718 (libmodfest_dbus_client_send_mail),
2719 (libmodfest_dbus_client_mailto),
2720 (libmodfest_dbus_client_open_message):
2721 * libmodest-dbus-client/libmodest-dbus-client.h:
2722 (Partly) Implement a send_mail D-Bus method.
2724 * tests/dbus_api/Makefile.am:
2725 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2726 the send_email D-Bus method.
2728 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2732 * libmodest-dbus-client/Makefile.am:
2733 * libmodest-dbus-client/libmodest-dbus-client.c:
2734 * libmodest-dbus-client/libmodest-dbus-client.h:
2735 * tests/dbus_api/Makefile.am:
2736 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2737 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2739 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2741 * src/maemo/easysetup/modest-easysetup-wizard.c:
2742 (create_page_account_details):
2743 * src/maemo/modest-account-settings-dialog.c:
2744 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2745 widgets, because this might not be the default in future versions of the Maemo GTK+.
2746 However, I can not not get capitalization to work even in a simple test case.
2748 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2750 * src/maemo/easysetup/modest-easysetup-wizard.c:
2751 (create_page_custom_incoming), (create_page_custom_outgoing):
2752 * src/maemo/modest-account-settings-dialog.c:
2753 (create_page_account_details), (create_page_incoming),
2754 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2755 instead of using gtk_check_button_with_label(), so they are aligned like the other
2756 widgets, as per the UI spec.
2758 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2760 * src/maemo/easysetup/modest-easysetup-wizard.c:
2761 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2762 * src/widgets/modest-validating-entry.c:
2763 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2764 Modest prefix instead of an EasySetup prefix.
2766 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2768 * src/widgets/modest-validating-entry.h:
2769 * src/widgets/modest-validating-entry.c: (on_insert_text),
2770 Added easysetup_validating_entry_set_max_func(), used to set a callback
2771 to call when the max number of characters is reached. GtkEntry has a max-length
2772 already but is silent about it.
2774 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2775 (create_page_account_details), (create_page_user_details),
2777 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2778 (create_page_account_details), (create_page_user_details),
2779 (create_page_outgoing):
2780 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2781 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2782 the UI spec, when the user tries to enter more than the max number of characters.
2784 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2786 * src/maemo/easysetup/modest-easysetup-wizard.c:
2787 (create_page_user_details), (create_page_custom_incoming),
2788 (create_page_custom_outgoing):
2789 * src/maemo/modest-account-settings-dialog.c:
2790 (create_page_user_details), (create_page_incoming),
2791 (create_page_outgoing):
2792 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2793 (modest_connection_specific_smtp_edit_window_init):
2794 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2795 not appropriate. Bad Maemo-specific defaults!.
2797 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2799 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2800 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2801 (modest_signature_editor_dialog_set_settings):
2802 Disable the label and textview when the checkbox is disabled, and use the
2803 specified (UI spec) default signature text.
2805 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2807 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2808 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2810 * src/modest-defs.h:
2811 * src/modest-account-mgr-helpers.h:
2812 * src/modest-account-mgr-helpers.c:
2813 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2815 * src/maemo/Makefile.am:
2816 * src/maemo/modest-signature-editor-dialog.c:
2817 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2820 * src/maemo/modest-account-settings-dialog.h:
2821 * src/maemo/modest-account-settings-dialog.c:
2822 (modest_account_settings_dialog_finalize), (on_button_signature),
2823 (save_configuration): Use the new dialog when the Edit button is pressed, and
2824 save the changes if necessary, as per the UI spec.
2826 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2828 * src/maemo/Makefile.am:
2829 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2830 based on maemo-develoers email from Dirk.
2832 * src/maemo/easysetup/modest-easysetup-wizard.c:
2833 (create_page_welcome), (create_page_account_details),
2834 (create_page_user_details), (create_page_complete_easysetup),
2835 (create_page_custom_incoming), (create_page_custom_outgoing),
2836 (create_page_complete_custom),
2837 (modest_easysetup_wizard_dialog_init):
2838 * src/maemo/modest-account-settings-dialog.c:
2839 (create_page_account_details), (create_page_user_details),
2840 (create_page_incoming), (create_page_outgoing),
2841 (modest_account_settings_dialog_init):
2842 * src/maemo/modest-connection-specific-smtp-window.c:
2843 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2845 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2847 * src/maemo/easysetup/modest-easysetup-wizard.c:
2848 (create_page_account_details), (create_page_custom_outgoing),
2849 (create_page_complete_custom):
2850 * src/maemo/modest-account-settings-dialog.c:
2851 (create_page_user_details), (create_page_incoming),
2852 (create_page_outgoing):
2853 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2854 (modest_connection_specific_smtp_edit_window_init):
2855 Use the correct (UI spec) port min/max, and use horizontal separators,
2858 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2860 * src/maemo/easysetup/modest-easysetup-wizard.c:
2861 (set_default_custom_servernames):
2862 * src/maemo/modest-account-settings-dialog.c:
2863 (create_page_incoming), (on_combo_outgoing_security_changed),
2864 (on_combo_incoming_security_changed), (create_page_outgoing),
2865 (modest_account_settings_dialog_set_account_name),
2866 (save_configuration):
2867 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2868 (on_combo_security_changed),
2869 (modest_connection_specific_smtp_edit_window_init),
2870 (modest_connection_specific_smtp_edit_window_set_connection),
2871 (modest_connection_specific_smtp_edit_window_get_settings):
2872 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2875 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2878 * src/maemo/easysetup/modest-easysetup-wizard.c:
2879 (create_page_custom_outgoing), (create_page_complete_custom):
2880 * src/maemo/modest-account-settings-dialog.c:
2881 (create_page_user_details), (create_page_outgoing):
2882 * src/maemo/modest-account-view-window.c: (button_box_new):
2883 Use changed logical IDs as per the most recent UI spec:
2884 mcen_bd_emailsetup_edit -> mcen_bd_edit
2885 mcen_bd_emailsetup_delete -> mcen_bd_delete
2886 mcen_bd_emailsetup_close -> mcen_bd_close
2888 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2892 * src/dbus_api/Makefile.am:
2893 * src/dbus_api/modest-dbus-callbacks.c:
2894 * src/dbus_api/modest-dbus-callbacks.h:
2895 * src/maemo/modest-platform.c: (modest_platform_init):
2896 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2898 * tests/Makefile.am:
2899 * tests/dbus_api/Makefile.am:
2900 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2902 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2904 * src/maemo/modest-account-settings-dialog.c:
2905 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2906 Removed unnecessary includes.
2908 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2910 * src/maemo/easysetup/modest-easysetup-wizard.c:
2911 * src/maemo/modest-account-settings-dialog.c:
2912 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2913 * src/widgets/Makefile.am:
2914 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2915 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2916 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2917 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2918 * src/widgets/modest-secureauth-combo-box.c:
2919 * src/widgets/modest-secureauth-combo-box.h:
2920 * src/widgets/modest-serversecurity-combo-box.c:
2921 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2922 made the GObject names more consistent with the rest of the Modest code.
2924 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2926 * src/maemo/easysetup/Makefile.am:
2927 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2928 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2929 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2930 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2931 * src/maemo/easysetup/modest-easysetup-wizard.c:
2932 * src/maemo/easysetup/modest-validating-entry.c:
2933 * src/maemo/easysetup/modest-validating-entry.h:
2934 * src/maemo/modest-account-settings-dialog.c:
2935 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2936 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2937 widgets/ because they are used outside of easysetup too. After checking in,
2938 svn will allow me to rename them too.
2940 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2942 * src/gnome/modest-msg-edit-window.c:
2943 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2944 linker error, to fix the build on the GNOME platform.
2945 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2946 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2947 ifdefed out to avoid a warning.
2949 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2951 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2952 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2953 some alternative for GTK+ 2.6.
2955 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2957 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2959 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2960 specified for EmailAccountsDialog in UI spec.
2962 * src/maemo/easysetup/modest-easysetup-wizard.c:
2963 * src/maemo/easysetup/modest-easysetup-wizard.h:
2964 * src/maemo/modest-account-settings-dialog.c:
2965 * src/maemo/modest-account-settings-dialog.h:
2966 Reuse a member window widget for the connection-specific SMTP server accounts,
2967 so we can tell it to create/save the accounts only if we actually save changes.
2969 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2970 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2971 (modest_connection_specific_smtp_edit_window_get_settings):
2972 Return a struct instance for temporarily remembering the entered data.
2974 * src/maemo/modest-connection-specific-smtp-window.h:
2975 * src/maemo/modest-connection-specific-smtp-window.c:
2976 (modest_connection_specific_smtp_window_finalize),
2977 (modest_connection_specific_smtp_window_fill_with_connections),
2979 (modest_connection_specific_smtp_window_save_server_accounts),
2980 (update_model_server_names): Do not actually save data until asked,
2981 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2983 (on_selection_changed),
2984 (modest_connection_specific_smtp_window_init): Disable the edit
2985 button when nothing is selected.
2987 * src/modest-account-mgr-helpers.c:
2988 * src/modest-account-mgr-helpers.h:
2989 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2992 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2994 * src/modest-account-mgr-helpers.h:
2995 * src/modest-account-mgr-helpers.c:
2996 (modest_account_mgr_get_unused_account_name),
2997 (modest_account_mgr_get_unused_account_display_name): Added these
2998 utility functions, to avoid code duplication.
3000 * src/maemo/easysetup/modest-easysetup-wizard.c:
3001 (create_page_account_details), (create_account):
3002 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3003 (on_combo_security_changed),
3004 (modest_connection_specific_smtp_edit_window_init),
3005 (modest_connection_specific_smtp_edit_window_save_settings):
3006 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3007 * src/maemo/modest-connection-specific-smtp-window.c:
3008 (modest_connection_specific_smtp_window_finalize),
3009 (modest_connection_specific_smtp_window_fill_with_connections),
3010 (on_button_edit), (modest_connection_specific_smtp_window_init):
3011 * src/maemo/modest-connection-specific-smtp-window.h:
3012 Implementing saving of connection-specific server accounts.
3014 But I need to refactor this so we can save the data for each
3015 possible connection-specific account and only actually create the server accounts
3016 when the easysetup finished, or the OK button is pressed on the account settings
3019 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3021 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3022 (on_combo_security_changed):
3023 (modest_connection_specific_smtp_edit_window_init):
3024 Auto-fill the port number as in the account settings.
3026 (modest_connection_specific_smtp_edit_window_set_connection):
3027 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3028 * src/maemo/modest-connection-specific-smtp-window.c:
3029 (fill_with_connections), (on_button_edit),
3030 (modest_connection_specific_smtp_window_init):
3031 Turn the edit window into a dialog to simplify the code, and
3032 set a WM hint as in a GtkDialog, because only a popup can be on top of
3033 another window in Maemo, and popups usually have no WM decoration.
3035 * src/modest-defs.h:
3036 * src/modest-account-mgr-helpers.c:
3037 (modest_account_mgr_set_connection_specific_smtp),
3038 (modest_account_mgr_remove_connection_specific_smtp),
3039 (modest_account_mgr_get_connection_specific_smtp):
3040 * src/modest-account-mgr-helpers.h: Some functions to write the
3041 connection-specific SMTP server information. Not yet used.
3044 * src/widgets/modest-folder-view.c: (text_cell_data):
3045 Fix a warning about an uninitialized variable.
3046 (on_configuration_key_changed): Put an #ifdef around the use
3047 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3049 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3051 * src/maemo/modest-account-settings-dialog.h:
3052 * src/maemo/modest-account-settings-dialog.c:
3053 Added connect_for_modified() utility function to mark the new modified boolean.
3055 (create_page_account_details), (create_page_user_details),
3056 (create_page_incoming), (create_page_outgoing), (on_response),
3057 (modest_account_settings_dialog_init),
3058 (modest_account_settings_dialog_set_account_name):
3059 Only warn about unsaved changes when there are actually unsaved changes.
3061 * src/modest-account-mgr-helpers.c:
3062 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3063 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3064 to get the data from there in future.
3066 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3068 * src/modest-defs.h:
3070 * src/modest-account-mgr-helpers.h:
3071 * src/modest-account-mgr-helpers.c:
3072 Store the security account setting in a single conf key instead of using
3073 the options list, so that the list is left for just the to-be-removed camel hack,
3074 and because gconf_client_set_list() is failing for some reason.
3076 * src/modest-account-mgr.c:
3077 (modest_account_mgr_add_server_account):
3078 * src/maemo/modest-account-settings-dialog.c:
3079 (modest_account_settings_dialog_set_account_name),
3080 (save_configuration): Use the renamed functions.
3083 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3085 * src/widgets/Makefile.am:
3086 * src/widgets/modest-limit-retrieve-combo-box.c:
3087 * src/widgets/modest-limit-retrieve-combo-box.h:
3088 * src/widgets/modest-retrieve-combo-box.c:
3089 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3090 the account settings dialog.
3092 * src/modest-defs.h:
3093 * src/modest-account-mgr-helpers.h:
3094 * src/modest-account-mgr-helpers.c:
3095 (modest_server_account_get_option_secure_auth),
3096 (modest_server_account_set_option_secure_auth):
3097 * src/modest-account-mgr.c:
3098 (modest_account_mgr_add_server_account):
3099 Use the existing AUTH_MECH conf key for the secure-auth setting,
3100 instead of putting it in the list options, because this was actually used already.
3102 * src/maemo/modest-account-settings-dialog.c:
3103 (create_page_account_details),
3104 (modest_account_settings_dialog_set_account_name),
3105 (save_configuration):
3106 * src/maemo/modest-account-settings-dialog.h:
3107 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3108 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3110 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3112 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3113 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3114 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3116 * src/modest-defs.h:
3117 * src/maemo/modest-account-settings-dialog.c:
3118 (create_page_incoming), (on_combo_outgoing_security_changed),
3119 (on_combo_incoming_security_changed), (create_page_outgoing),
3120 (modest_account_settings_dialog_set_account_name),
3121 (save_configuration): Load/Save the port number, and change it when the
3122 security combo changes, to suitable defaults.
3124 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3126 * src/modest-account-mgr.c:
3127 (modest_account_mgr_add_server_account): Set the security and secure-auth
3128 options, and add a comment saying that the other camel-specific options should be
3131 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3133 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3135 * src/modest-tny-account-store.c: (account_list_free),
3136 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3137 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3140 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3142 * src/modest-protocol-info.c:
3143 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3144 is required by our UI spec. Maybe something in our implementation will use this eventually.
3145 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3146 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3147 instead of the previous 0 placeholder.
3149 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3150 secure-auth settings.
3151 * src/modest-account-mgr-helpers.h:
3152 * src/modest-account-mgr-helpers.c:
3153 (modest_server_account_data_get_option_secure_auth),
3154 (modest_server_account_set_option_secure_auth),
3155 (modest_server_account_data_get_option_security),
3156 (modest_server_account_set_option_security): Added this API for getting and setting the security
3157 and secure-auth settings.
3159 * src/maemo/modest-account-settings-dialog.h:
3160 * src/maemo/modest-account-settings-dialog.c:
3161 (modest_account_settings_dialog_finalize), (check_data),
3162 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3163 about changing titles.
3164 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3165 (save_configuration): Save the security and secure-auth settings.
3167 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3168 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3170 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3172 * src/modest-defs.h:
3173 * src/modest-account-mgr.c:
3174 (modest_account_mgr_add_server_account):
3175 Added and used defines for the options key and value pair strings,
3176 that are used so far, though they do not seem to correspond to anything in our
3177 UI specs or ModestProtocol enum.
3179 * src/modest-account-mgr-helpers.h:
3180 * src/modest-account-mgr-helpers.c:
3181 (compare_option_strings_for_name),
3182 (modest_server_account_data_get_option_value),
3183 (modest_server_account_data_get_option_bool),
3184 (modest_account_mgr_get_server_account_option):
3185 Added helper functions for parsing the options GSList.
3187 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3189 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3190 display name is based on the supplied account name.
3191 * src/modest-account-mgr.c:
3192 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3193 with an inefficient, but good-enough, implementation.
3195 * src/maemo/easysetup/modest-easysetup-wizard.c:
3196 (create_page_account_details), (on_before_next), (create_account):
3197 Check for existing display names rather than (non-user-visible) account names, and just
3198 create and set a unique account name at the end.
3200 * src/maemo/modest-account-settings-dialog.c:
3201 (modest_account_settings_dialog_init),
3202 (modest_account_settings_dialog_set_account_name),
3203 (create_page_incoming): Show the display name, instead of the account name.
3204 (on_response): Do some (not all) extra checks, as in the UI spec.
3205 (save_configuration): Save the display name if it was changed.
3207 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3209 * po/en_GB.po: Added needed logical ID and translation.
3210 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3211 (init_view): Made the is-default column clicking work.
3213 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3216 * src/maemo/easysetup/Makefile.am:
3217 * src/maemo/easysetup/modest-easysetup-wizard.c:
3218 (modest_easysetup_wizard_dialog_init):
3219 * src/maemo/easysetup/provider-data-test.keyfile:
3220 * src/maemo/easysetup/provider-data.keyfile:
3221 Moved the provider data file to the new modest-providers-data package and used it from there.
3223 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3225 * src/modest-local-folder-info.c:
3226 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3227 N_() was already used on the static strings, but this just marks it for translation without
3228 using the translation.
3230 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3232 * src/maemo/modest-account-settings-dialog.c:
3233 (create_page_incoming),
3234 (modest_account_settings_dialog_set_account_name):
3235 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3236 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3237 I will do this if nobody else gets there first.
3239 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3241 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3242 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3243 save the security stuff.
3245 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3247 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3248 Set the email address and user fullname, which I now see must be
3251 * src/maemo/modest-account-settings-dialog.h:
3252 * src/maemo/modest-account-settings-dialog.c:
3254 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3255 leave-on-server and authentication.
3256 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3259 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3262 * src/maemo/modest-account-settings-dialog.c:
3263 * src/maemo/modest-account-settings-dialog.h:
3264 Most (but not all) of the widgets are now present as specified by the UI spec.
3265 No changes are yet saved, and some details are not properly shown yet.
3267 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3269 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3271 * src/maemo/Makefile.am:
3272 * src/maemo/modest-account-settings-dialog.c:
3273 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3274 an existing account. Doesn't do much yet.
3276 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3277 Open the accounts settings dialog when Edit is clicked.
3279 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3281 * src/maemo/easysetup/Makefile.am:
3282 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3284 * src/maemo/easysetup/modest-easysetup-wizard.c:
3285 (modest_easysetup_wizard_dialog_init):
3286 Try to get the source directory from the build system,
3287 instead of hard-coding "./" into the source code, when opening our local
3288 copies of the configuration files.
3289 But this still fails when opening the wizard from the Accounts window,
3290 maybe because the working directory seems to change at runtime.
3291 So the wizard will fail the second time unless you copy the files into their
3292 proper locations - see the stdout warnings for the paths.
3294 (create_page_account_details),(on_before_next):
3295 Check for existing non-server accounts instead of server accounts,
3296 so the default account name is useful again, and to prevent trying to
3299 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3300 Show the wizard when New is clicked.
3302 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3303 (init_view): Show the column headers, and show the columns that are
3304 specified in the UI specs. However, something in Maemo's GTK+ prevents
3305 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3306 change the default account. This is despite unsetting the special properties.
3308 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3310 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3311 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3312 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3313 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3314 to make that clearer.
3315 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3317 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3319 * src/maemo/modest-account-view-window.c:
3320 (modest_account_view_window_init),
3321 (modest_account_view_window_new):
3322 Use the same buttons as specified in the
3323 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3324 the existing widgets, which never had a chance of working.
3325 Put the ModestAccountView treeview in a scrolled window.
3326 Do not repeat the initialization in both _init() and _new().
3328 * src/widgets/modest-account-view.c: (update_account_view):
3329 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3330 this widget and window shows no accounts.
3332 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3334 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3336 * src/maemo/easysetup/modest-easysetup-wizard.c:
3337 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3338 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3339 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3342 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3343 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3344 accounts exist yet, as in the UI spec.
3346 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3348 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3350 * src/maemo/Makefile.am:
3351 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3352 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3353 New window for editing connection-specific smtp details.
3354 Not fully implemented.
3356 * src/maemo/modest-connection-specific-smtp-window.c:
3357 (modest_connection_specific_smtp_window_finalize) :
3358 unref the tree model.
3359 (on_button_edit): Show the edit window.
3361 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3363 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3366 * src/maemo/Makefile.am:
3367 * src/maemo/modest-connection-specific-smtp-window.c:
3368 * src/maemo/modest-connection-specific-smtp-window.h:
3369 New window for showing the list of connections, for connection-specific
3370 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3371 * src/maemo/easysetup/modest-easysetup-wizard.c:
3372 (create_page_custom_outgoing): Show the new window when the button is clicked.
3374 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3376 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3377 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3378 * src/maemo/modest-msg-edit-window.c:
3379 (modest_msg_edit_window_insert_image):
3380 * src/modest-conf.c: (modest_conf_key_escape):
3381 * src/modest-mail-operation.c:
3382 (modest_mail_operation_send_new_mail):
3383 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3384 (modest_ui_actions_on_new_account):
3385 * src/widgets/modest-attachment-view.c: (update_filename_request):
3386 * src/widgets/modest-mail-header-view.c:
3387 Corrected warnings that were breaking the build, by commenting out unused variables,
3388 and a function, and by including a header.
3390 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3392 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3393 so we can #ifdef around platform-specific code when necessary.
3394 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3395 to allow this to build for the GNOME platform too.
3397 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3399 * src/maemo/easysetup/modest-easysetup-wizard.c:
3400 Added util_increment_name() and used it in create_page_account_details()
3401 to make sure that the default account name is always a new name.
3403 (modest_easysetup_wizard_dialog_init),
3404 (set_default_custom_servernames): Some minor memory management fixes.
3406 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3410 * src/modest-runtime.c: (init_i18n): Restored the translation
3411 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3412 are defined in config.h, and the translations are installed.
3414 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3415 is defined for translation.
3417 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3419 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3421 * src/maemo/easysetup/modest-easysetup-wizard.c:
3422 (modest_easysetup_wizard_dialog_init):
3423 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3424 Use realistic paths (though they should use $prefix generically) to the
3425 mcc_mapping and provider-data.keyfile files which might work when they
3426 are installed by the future version of the operator-wizard package,
3427 and then fallback to paths in our source code, with an explanatory
3430 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3434 * src/maemo/Makefile.am:
3435 * src/maemo/easysetup/: Added files from the previously-exernal
3436 osso-modest-easysetup.
3437 * src/maemo/modest-main-window-ui.h:
3438 * src/modest-ui-actions.c:
3439 * src/modest-ui-actions.h:
3440 Added modest_ui_actions_on_new_account() as a signal handler for the
3441 New Account menu item. It shows the easysetup wizard.
3442 * po/en_GB.po: Added additional needed logical IDs and translations.