1 2007-06-25 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
4 * src/modest-search.c: (modest_search_folder),
5 (modest_search_all_accounts): Actually search only in the specified folder,
6 doing a simple match on the folder ID.
7 * src/modest-search.h: Added a folder field to the ModestSearch struct,
8 and added some documentation.
10 2007-06-22 Armin Burgmeier <armin@openismus.com>
12 * src/maemo/modest-maemo-utils.h:
13 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
14 modest_maemo_utils_get_supported_secure_authentication_methods.
16 * src/maemo/easysetup/modest-easysetup-wizard.c:
17 * src/maemo/modest-account-settings-dialog.c: Show correct error if
18 one occured, not just "Server does not support secure authentication".
20 2007-06-22 Murray Cumming <murrayc@murrayc.com>
22 * src/modest-tny-account-store.c: (get_password):
23 Restored the call to tny_account_set_user() because Philip seems to have
24 stopped this from crashing (by not using the freed string). It still does
25 not work, but now we can test it.
27 2007-06-22 Murray Cumming <murrayc@murrayc.com>
29 * src/maemo/modest-msg-edit-window.c: (init_window):
30 Comment out use of an uninitialzed GtkScrolledWindow variable,
31 to fix the build and stop a crash. Yet again.
33 2007-06-22 Murray Cumming <murrayc@murrayc.com>
35 * src/modest-tny-account-store.c: (get_password):
36 Remove the call to tny_account_set_user() because this actually crashes.
37 As mentioned in the last commit, it is known to not work anyway.
39 2007-06-22 Murray Cumming <murrayc@murrayc.com>
41 * src/modest-tny-account-store.c: (get_password):
42 Use tny_account_set_username() to tell tinymail that the username might
43 have changed too. But tinymail ignores this: see projects.maemo.org
45 * src/modest-ui-actions.c:
46 (modest_ui_actions_on_password_requested): Remove the useless attempt to
47 reset the connection when changing the username, and improve the comments.
48 Save the changed username to gconf at least, so it is used when Modest is
51 2007-06-21 Murray Cumming <murrayc@murrayc.com>
53 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
54 Do not use a query, so that we get all folders, including for POP and
55 local-folders. They work as search criteria too.
56 This fixes projects.maemo.org bug NB#57740.
58 2007-06-21 Murray Cumming <murrayc@murrayc.com>
60 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
61 Comment out the use of hildon_notification_set_sound() because it is
62 not declared, to fix the build. Warnings are serious, people.
64 2007-06-21 Armin Burgmeier <armin@openismus.com>
66 * src/maemo/modest-maemo-utils.h:
67 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
68 modest_maemo_utils_get_supported_secure_authentication_methods()
69 to query authentication methods for a specific user. This should fix
70 projects.maemo.org bug NB#61369.
72 * src/maemo/easysetup/modest-easysetup-wizard.c:
73 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
76 2007-06-21 Murray Cumming <murrayc@murrayc.com>
78 * libmodest-dbus-client/libmodest-dbus-client.h:
79 * libmodest-dbus-client/libmodest-dbus-client.c:
80 (modest_dbus_message_iter_get_search_hit),
81 (libmodest_dbus_client_search):
82 Reorganised and commented this.
83 Removed modest_search_hit_free() from the public API because it
86 Added libmodest_dbus_client_get_folders() and
87 modest_folder_result_list_free().
89 * src/dbus_api/modest-dbus-api.h:
90 * src/dbus_api/modest-dbus-callbacks.c:
91 (modest_dbus_req_filter): Commented. Moved most code to
92 on_dbus_method_search() and added on_dbus_method_get_folders().
94 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
95 of the extra D-Bus handler.
97 * tests/dbus_api/Makefile.am:
98 * tests/dbus_api/test_get_folders.c: New test for
99 libmodest_dbus_client_get_folders(). This seems to return an empty list
100 at the moment. That could be the same error that causes the message list
101 to be empty sometimes.
102 This should help with projects.maemo.org bug NB#57740.
104 2007-06-21 Armin Burgmeier <armin@openismus.com>
106 * src/modest-mail-operation.c: Do not call
107 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
108 notify the operation's end after having set the status to CANCELED for
109 the operation queue to listen on. This fixes a deadlock when there
110 were mail operations in the queue during its finalization.
112 * src/modest-singletons.c: Reordered uninitialization of the account
113 manager to happen after the mail operation queue was uninitialized
114 because the mail operation's in the queue might still try to access
115 the account manager (see modest_mail_operation_notify_end()). This
116 fixes a potential crash when terminating the application.
118 2007-06-21 Murray Cumming <murrayc@murrayc.com>
120 * src/modest-search.c:
121 (search_mime_part_and_child_parts): Moved some code here so we
122 can search recursively in child folders.
123 (modest_search_folder): Search in the message as a mime part, instead
124 of just its child mime parts.
125 (read_chunk), (search_mime_part_ogs):
126 Check how many bytes were read, to prevent an endless loop.
127 Searching in message bodies now works. This finishes the fix for
128 projects.maemo.org bug NB#61007.
130 2007-06-20 Murray Cumming <murrayc@murrayc.com>
132 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
133 Add a g_warning when the item is not a folder.
135 * src/modest-ui-dimming-rules.c:
136 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
137 when selected item is not a folder (for instance, an account), because
138 the UI spec only talks about folders.
139 I am not sure what the UI spec wants, so this might not totally fix
140 projects.maemo.org bug NB#60794.
142 2007-06-20 Murray Cumming <murrayc@murrayc.com>
144 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
145 (load_from_file): Sort the list. The unsorted list would be more noticeable
146 in non-English locales.
148 * src/maemo/modest-msg-edit-window.c:
149 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
150 warning and fix the build.
152 * src/maemo/modest-progress-bar-widget.c:
153 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
154 avoid a g_warning, and probably to avoid a crash.
156 2007-06-20 Murray Cumming <murrayc@murrayc.com>
158 * src/modest-search.c: (modest_search_folder): Check for a GError
159 when calling tny_folder_get_headers(), to show that this is not the cause
162 2007-06-20 Murray Cumming <murrayc@murrayc.com>
164 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
165 Actually set the body query instead of the subject query.
167 * src/modest-search.c: (search_mime_part_ogs),
168 (search_mime_part_strcmp): Remove extra space from the text/* regex,
169 which would probably cause it to fail if we got this far.
171 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
172 to simplify the code.
173 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
174 be causing search-in-body to fail.
176 2007-06-20 Murray Cumming <murrayc@murrayc.com>
178 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
180 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
181 Better debug message when the folder cannot be found.
182 This should help with fixing projects.maemo.org bug #61287.
183 * src/modest-search.c: (add_hit): Do not leak the furl string.
185 2007-06-20 Murray Cumming <murrayc@murrayc.com>
187 * src/modest-ui-actions.c:
188 (modest_ui_actions_on_folder_selection_changed):
189 Do not special-case TNY_MERGE_FOLDER here, because
190 modest_tny_folder_get_account() already does that. This fixes
191 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
192 shown when the Outbox was selected).
194 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
196 * libmodest-dbus-client/libmodest-dbus-client.c:
197 (_dbus_iter_get_string_or_null): Initialize the string variable in
198 case this helps with Dirk's crash.
200 2007-06-19 Murray Cumming <murrayc@murrayc.com>
202 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
203 though it is not implemented yet (this function is maybe not even used),
204 to avoid breaking ABI in future.
205 * libmodest-dbus-client/libmodest-dbus-client.c:
206 (get_attachments_string): Moved some code into this generic function.
207 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
208 sends email. It is maybe not used.
209 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
210 (on_send_mail): Use attachments.
212 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
213 * src/maemo/modest-msg-edit-window.c:
214 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
215 a filename before using it, to fix projects.maemo.org bug NB#58233.
217 2007-06-19 Murray Cumming <murrayc@murrayc.com>
219 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
220 Initialize the continue_download variable to fix the build, and probably
221 to fix randome behaviour.
223 2007-06-18 Armin Burgmeier <armin@openismus.com>
225 * src/modest-tny-send-queue.h:
226 * src/modest-tny-send-queue.c: Keep track of the status of messages in
227 the queue so we can later show it in the UI. Replaced
228 modest_tny_send_queue_msg_is_being_sent() by
229 modest_tny_send_queue_get_msg_status().
231 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
233 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
234 gpointer. This probably was not harmful, but just to be sure.
236 2007-06-18 Murray Cumming <murrayc@murrayc.com>
238 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
239 Fix the build, but leave the function broken on Bora, because
240 hildon_uri_action_get_service() does not exist.
241 osso_uri_action_get_service() does not exist either, it seems.
243 2007-06-18 Murray Cumming <murrayc@murrayc.com>
245 * src/modest-tny-account.c:
246 (modest_tny_account_new_from_server_account):
247 Uncommented the url debug output again, because it is useful for
248 debugging, as I said in the comment.
250 2007-06-18 Murray Cumming <murrayc@murrayc.com>
252 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
254 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
255 for Mameo Bora, to fix the build.
257 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
260 Fixed build with hildon < 0.99
262 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
263 Check if the selected account is busy instead of checking all accounts
265 * src/modest-account-mgr-priv.h:
266 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
267 (modest_account_mgr_init), (compare_account_name),
268 (modest_account_mgr_set_account_busy),
269 (modest_account_mgr_account_is_busy):
270 * src/modest-account-mgr.h:
271 Added busy information to the account manager. It possible to
272 set an account to busy or not busy now.
274 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
275 (modest_mail_operation_update_account),
276 (modest_mail_operation_notify_end):
277 Set the account to busy/not busy depending on the operation state.
279 * src/widgets/modest-account-view.c:
280 (modest_account_view_finalize), (get_last_updated_string),
281 (update_account_view), (on_account_busy_changed), (init_view):
282 Show string "Refreshing..." if the account is currently busy.
284 All this fixes projects.maemo.org bug NB#59711
286 2007-06-14 Armin Burgmeier <armin@openismus.com>
288 * src/widgets/modest-attachments-view.h:
289 * src/widgets/modest-attachments-view.c: Added
290 modest_attachments_view_has_attachments() and fixed coordinate
291 transformation in get_att_view_at_coords(). This fixes attachment
294 * src/widgets/modest-msg-view.c: Make use of
295 modest_attachments_view_has_attachments() to decide whether to show
296 attachments in the header.
298 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
300 * src/maemo/modest-connection-specific-smtp-edit-window.c:
301 (on_change), (on_combo_security_changed),
302 (modest_connection_specific_smtp_edit_window_init),
303 (modest_connection_specific_smtp_edit_window_set_connection),
304 (modest_connection_specific_smtp_edit_window_is_dirty):
305 * src/maemo/modest-connection-specific-smtp-edit-window.h:
306 * src/maemo/modest-connection-specific-smtp-window.c:
309 Show an comfirmation dialog for the smpt-edit-window if there are
310 unsaved changes and the user hits cancel.
311 (projects.maemo.org bug NB#60479)
313 2007-06-14 Armin Burgmeier <armin@openismus.com>
315 * src/maemo/easysetup/modest-easysetup-wizard.c:
316 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
317 address" info in banner instead of node, and select all the text as
318 per UI spec. This fixes projects.maemo.org bug NB#60550.
320 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
322 reviewed by: <delete if not using a buddy>
324 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
325 * src/modest-ui-actions.c: (folder_refreshed_cb):
327 2007-06-14 Murray Cumming <murrayc@murrayc.com>
329 * src/widgets/modest-folder-view.c: (filter_row):
330 Explictly filter out the per-account outbox accounts. I don't know why
331 these only sometimes show up, but now they should never show up in the UI.
332 This should fix projects.maemo.org bug NB#60160.
334 2007-06-14 Murray Cumming <murrayc@murrayc.com>
336 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
337 when the toolbar does not exist yet.
338 * src/modest-widget-memory.c: (save_settings_header_view):
339 Added g_warnings() to help us to discover when we are trying to set
340 an empty columns list in gconf.
342 2007-06-14 Murray Cumming <murrayc@murrayc.com>
346 Added modest_init_get_default_header_view_column_ids().
348 * src/modest-widget-memory.c: (restore_settings_header_view):
349 Use the new function to get defaults, if the gconf key is empty,
350 instead of not creating any columns. This seems to fix the
351 empty right-hand pane problems.
353 * src/widgets/modest-header-view.h: Improved documentation.
355 2007-06-13 Murray Cumming <murrayc@murrayc.com>
357 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
358 Revert the use of the display name as the account name, because this
359 is generally wrong and would break the code that follows.
361 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
363 * src/maemo/easysetup/modest-easysetup-wizard.c:
364 (check_for_supported_auth_methods), (on_before_next),
367 More correct fix for projects.maemo.org bug NB# 58991
368 Do not longer accept AUTH_PASSWORD as secure method and choose
369 correct method when creating the account.
371 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
373 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
374 Fixed projects.maemo.org bug NB# 58991
376 2007-06-13 Murray Cumming <murrayc@murrayc.com>
378 * src/modest-init.c: (modest_init_init_core),
379 (modest_init_local_folders): Fixed compilation errors.
381 2007-06-13 Murray Cumming <murrayc@murrayc.com>
383 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
384 Remove unnecessary lib/include, though it is good in principle when needed.
386 * src/modest-init.c: (modest_init_one_local_folder),
387 (modest_init_local_folders):
388 * src/modest-init.h: Initialize the .modest library for memory cards,
389 instead of just doing nothing for them. This should allow us to create
390 folders there, fixing projects.maemo.org bug NB#59297.
392 2007-06-13 Murray Cumming <murrayc@murrayc.com>
394 * libmodest-dbus-client/libmodest-dbus-client.c:
395 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
396 (libmodest_dbus_client_compose_mail),
397 (libmodest_dbus_client_open_message),
398 (libmodest_dbus_client_send_and_receive),
399 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
401 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
402 (on_idle_open_message), (modest_dbus_req_handler),
403 (search_result_to_message), (modest_dbus_req_filter):
404 * src/modest-search.c: (add_hit), (modest_search_folder),
405 (modest_search_all_accounts): Improved debug messages.
407 * tests/dbus_api/test_open_message.c: (main): Improved comments.
409 * src/modest-tny-account-store.c:
410 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
413 2007-06-13 Murray Cumming <murrayc@murrayc.com>
416 2007-06-12 Murray Cumming <murrayc@murrayc.com>
418 * src/modest-tny-account-store.c: (get_server_accounts):
419 Call modest_tny_local_folders_account_add_merged_outbox_folders()
420 even when there are no accounts, so that the Outbox folder is always
421 visible. This fixes projects.maemo.org bug NB#60158.
423 2007-06-12 Murray Cumming <murrayc@murrayc.com>
425 * src/maemo/modest-main-window.c: (create_details_widget):
426 Use the mcen_va_never logical ID.
428 2007-06-12 Murray Cumming <murrayc@murrayc.com>
430 * src/dbus_api/modest-dbus-api.h:
431 * src/dbus_api/modest-dbus-callbacks.c:
432 (on_idle_open_default_inbox), (on_open_default_inbox),
433 (modest_dbus_req_handler):
434 Added a new OpenDefaultInbox method.
436 * libmodest-dbus-client/libmodest-dbus-client.h:
437 * libmodest-dbus-client/libmodest-dbus-client.c:
438 Added libmodest_dbus_client_open_default_inbox() to call the new
439 dbus method. This should be useful to projects.maemo.org bug NB#57214,
440 though it should maybe be used by a new osso-email-interface function.
442 * tests/dbus_api/Makefile.am:
443 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
446 2007-06-12 Murray Cumming <murrayc@murrayc.com>
448 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
449 NULL, so that the signals get all the keys. This should not actually
450 change any behaviour because we currently update everything when anything
453 2007-06-12 Murray Cumming <murrayc@murrayc.com>
455 * src/widgets/modest-folder-view.c: (text_cell_data),
456 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
457 (find_inbox_iter): If tinymail tells us that the folder is
458 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
459 This causes the inbox to be selected at startup, fixing part of
460 projects.maemo.org bug NB#56305.
462 * src/modest-ui-dimming-rules.c:
463 (modest_ui_dimming_rules_on_tools_smtp_servers):
464 * src/modest-ui-dimming-rules.h: Added a callback function to dim
465 the SMTP servers menu item.
466 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
467 that the SMTP Servers menu item is dimmed when there are no accounts,
468 as a future version of the UI spec will require. This fixes
469 projects.maemo.org bug NB#56305.
471 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
473 * src/maemo/modest-maemo-utils.c:
474 (modest_maemo_utils_get_supported_secure_authentication_methods):
475 Added label to dialog instead of unreadable title
477 * src/maemo/modest-main-window.c: (sync_accounts_cb),
478 (modest_main_window_new):
479 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
482 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
483 * src/modest-account-mgr.h:
484 Added method to avoid code duplication
486 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
487 (modest_ui_actions_on_send_receive):
488 Use modest_account_mgr_has_accounts
490 2007-06-11 Murray Cumming <murrayc@murrayc.com>
492 * src/maemo/easysetup/modest-presets.c:
493 (modest_presets_get_info_server_security): Do not report secure auth
495 * src/modest-protocol-info.c: Use the defines for the gconf key names
496 for secure authentication. This was not working because we were writing
497 Password and reading password, and the check was case sensitive.
498 With this, gmail now works for receiving and sending when created via
501 2007-06-11 Murray Cumming <murrayc@murrayc.com>
503 * src/maemo/easysetup/modest-presets.c:
504 (modest_presets_get_info_server_security): Correct the key name for
505 SecureSmtp, because it seems to be case-sensitive.
506 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
507 Do not try to get the 0th notebook page if there are 0 pages, to
510 2007-06-11 Murray Cumming <murrayc@murrayc.com>
512 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
513 Prevent use of the new notification feature for now, because it currently
514 shows one dialog for each new email, which is annoying.
516 2007-06-11 Murray Cumming <murrayc@murrayc.com>
518 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
519 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
520 when no country was selected, so that we show the global ones.
521 * src/maemo/easysetup/modest-presets.c:
522 (modest_presets_get_providers): Return only the global providers, not
523 all providers when mmc=0 was requested.
525 2007-06-11 Murray Cumming <murrayc@murrayc.com>
527 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
528 (easysetup_provider_combo_box_fill): Remove debug code that showed the
529 provider ID in the combo.
531 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
532 Do not show the page numbers, because it would be confusing when we add
533 the 2 extra pages for the custom setup, when the user chooses the "Other"
534 provider. This fixes projects.maemo.org bug NB#59028
536 * src/modest-init.c: (modest_init_init_core),
537 (modest_init_local_folders):
539 * src/modest-tny-account.c:
540 (modest_tny_account_new_for_local_folders): Do not create default folders
541 for the memory card. This should fix projects.maemo.org bug NB#59328.
543 2007-06-11 Murray Cumming <murrayc@murrayc.com>
545 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
546 Free the changed_conf_keys string items. They are already freed in the
547 idle handler if that runs first.
549 2007-06-11 Murray Cumming <murrayc@murrayc.com>
551 * src/modest-ui-actions.c:
552 (modest_ui_actions_on_password_requested): Check that the server name
553 is not NULL, because I just saw a password dialog with (null) as the
556 * src/modest-tny-folder.[h|c]: Added
557 modest_tny_folder_is_memory_card_folder().
558 * src/modest-ui-dimming-rules.c:
559 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
560 menu item for memory cards, as per the UI spec (section 7.4). This should
561 fix projects.maemo.org bug NB#59297.
563 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
565 * src/maemo/modest-main-window.c: (sync_accounts_cb):
566 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
567 is another problem with the code, see Murray's comment at line 772)
569 2007-06-08 Murray Cumming <murrayc@murrayc.com>
571 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
572 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
573 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
574 (load_from_file), (easysetup_country_combo_box_init),
575 (easysetup_country_combo_box_get_active_country_ids),
576 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
577 instead of just one ID, to avoid duplicate country names in the UI.
579 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
580 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
581 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
582 a single ID, avoiding duplicate providers.
583 * src/maemo/easysetup/modest-easysetup-wizard.c:
584 (on_combo_account_country): Adapt to use a list.
586 2007-06-08 Murray Cumming <murrayc@murrayc.com>
588 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
589 keys changed in the last X seconds.
591 * src/modest-account-mgr.h:
592 * src/modest-account-mgr.c: (on_timeout_notify_changes),
593 (on_key_change), (modest_account_mgr_class_init),
594 (modest_account_mgr_init), (modest_account_mgr_finalize):
595 As the keys are changed, save them in a GSList* and signal that GSList*
596 further every X seconds, to batch changes, to allow us to do just one
597 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
598 bug NB#56941 and other (UI-blocking) delays when changing account settings.
600 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
601 changed signal signature.
603 * src/modest-conf.c: (modest_conf_set_list),
604 (modest_conf_on_change): Reenable notification.
606 (modest_conf_maemo_fake_on_change): Comment out the hack that
607 notified immediately instead of asynchronously.
609 * src/widgets/modest-account-view.h:
610 * src/widgets/modest-account-view.c:
611 (update_account_view): Select the previously-selected account ID,
612 if possible. This fixes projects.maemo.org bug NB#56933.
614 (on_account_changed), (on_account_removed),
615 (modest_account_view_select_account):
617 Remove the block/unblock functions
618 because they were not useful.
620 * src/maemo/modest-account-view-window.c:
621 (on_delete_button_clicked), (on_edit_button_clicked),
622 (on_new_button_clicked): Remove the use of the non-working block/unblock.
624 2007-06-08 Murray Cumming <murrayc@murrayc.com>
626 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
627 Improve the error dialog to show Incorrect Account Settings, which seems
628 clearer, and say that the internal error message (to be removed from the
629 dialog later) is often misleading.
630 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
632 * src/modest-tny-account.c:
633 (modest_tny_account_new_from_server_account): Uncomment the printf of the
634 URL because this is so useful for debugging on the device.
636 * src/widgets/modest-serversecurity-combo-box.c:
637 (modest_serversecurity_combo_box_fill): Correct a logical ID.
639 2007-06-08 Murray Cumming <murrayc@murrayc.com>
641 * src/modest-mail-operation.c:
642 (modest_mail_operation_send_new_mail):
643 Added a comment about a nasty but apparently harmless message. Details
644 added to the wiki g_warnings() page.
646 2007-06-08 Murray Cumming <murrayc@murrayc.com>
648 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
649 (modest_tny_send_queue_class_init):
650 Do not use the priv struct because it is empty, to avoid g_warnings
651 about a non-existant priv struct.
653 * src/modest-tny-account-store.c:
654 (modest_tny_account_store_get_server_account),
655 (modest_tny_account_store_get_transport_account_for_open_connection
656 ): Do not try to get transport server accounts for local folders,
657 because they don't have any. This avoids a g_warning().
659 * src/maemo/modest-main-window.c:
660 (modest_main_window_notify_send_receive_initied),
661 (on_configuration_key_changed):
662 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
664 * src/modest-mail-operation.c:
665 (modest_mail_operation_update_account):
666 * src/modest-tny-account-store.h:
667 * src/modest-tny-account.c:
668 (modest_tny_account_get_special_folder),
669 (modest_tny_account_new_for_local_folders),
670 (modest_tny_account_new_for_per_account_local_outbox_folder):
671 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
672 * src/modest-tny-local-folders-account.c:
673 (add_account_folders_to_merged_folder):
674 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
675 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
676 (modest_ui_actions_on_send):
677 * src/widgets/modest-folder-view.c: (update_model):
678 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
679 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
680 modest_tny_account_store_get_tny_account_by_account() to
681 modest_tny_account_store_get_server_account() to make the code clearer.
683 2007-06-07 Marcus Bauer <marcusb@openismus.com>
685 * src/dbus_api/modest-dbus-api.h:
686 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
687 * src/maemo/modest-msg-edit-window.c:
688 (modest_msg_edit_window_attach_file_noninteractive):
689 added g_warning in case the file to be attached does not exist
690 * tests/dbus_api/test_compose_mail.c: (main):
691 removed obsolete comment, added generic files as test case
693 2007-06-07 Murray Cumming <murrayc@murrayc.com>
695 * src/modest-tny-account-store.c: (get_server_accounts):
696 Create the local folders account only once, not once for each outbox, and
697 not only when there are some outboxes.
699 2007-06-07 Murray Cumming <murrayc@murrayc.com>
701 * src/widgets/modest-folder-view.c: (update_model): Comment out some
702 code that is causing a crash at startup. Sergio says that he is fixing this.
704 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
706 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
707 * src/maemo/modest-account-settings-dialog.c:
708 (create_page_outgoing),
709 (modest_account_settings_dialog_set_account_name),
710 (save_configuration):
711 - Fixed handling of the "Use secure authentication" toggle to comply with
712 the ui specification. See also projects.maemo.org bug NB#58400
714 - Restore the Secure connection setting combo correctly when loading
717 * src/maemo/modest-maemo-utils.c:
718 (on_camel_account_get_supported_secure_authentication),
719 (modest_maemo_utils_get_supported_secure_authentication_methods):
720 Fixed a crasher if operation is canceled
722 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
723 (modest_protocol_info_auth_is_secure):
724 * src/modest-protocol-info.h:
726 Added two new methods to determine if a protocol/auth method is secure/encrypted in
727 the sense of the "Use secure authentication" toggle.
729 2007-06-07 Murray Cumming <murrayc@murrayc.com>
731 * src/modest-tny-account-store.h:
732 * src/modest-tny-account-store.c:
733 Added modest_tny_account_store_get_local_folders_account().
735 * src/modest-tny-folder.h:
736 * src/modest-tny-folder.c:
737 (modest_tny_folder_get_account):
738 Added this replacement for tny_folder_get_account() which returns
739 the local-folders account for TnyMergeFolders, to avoid the
740 warning about the unimplemented get_account_func() vfunc().
742 (modest_tny_folder_get_rules),
743 * src/modest-ui-actions.c:
744 (modest_ui_actions_on_folder_selection_changed):
745 * src/modest-mail-operation.c:
746 (modest_mail_operation_remove_folder),
747 (modest_mail_operation_xfer_folder),
748 (modest_mail_operation_rename_folder),
749 (modest_mail_operation_get_msg),
750 (modest_mail_operation_get_msgs_full),
751 (modest_mail_operation_remove_msg),
752 (modest_mail_operation_xfer_msgs),
753 (modest_mail_operation_refresh_folder):
754 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
756 2007-06-07 Murray Cumming <murrayc@murrayc.com>
758 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
759 (modest_server_account_set_security):
760 * src/modest-defs.h: Add comments explaining that our
761 UI spec means TLS when it says Normal, so these do not look like errors.
763 * src/modest-tny-account.c:
764 (modest_tny_account_new_from_server_account): Use the new tinymail
765 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
766 for TLS. This should fix projects.maemo.org bug NB#58460.
768 2007-06-06 Murray Cumming <murrayc@murrayc.com>
770 * src/maemo/easysetup/modest-easysetup-wizard.c:
771 (create_account): Correct the position of the gconf sanity check warning.
772 (on_button_edit_advanced_settings): Show the dialog immediately, instead
773 of using the g_idle_add() hack, because this does not seem to be necessary
774 on osso 1.1. It might even work on Maemo Bora if the problems were actually
775 caused by something other than maemo's gconf.
776 This fixes projects.maemo.org bug #59022.
778 2007-06-06 Murray Cumming <murrayc@murrayc.com>
780 * src/modest-account-mgr-helpers.c:
781 (modest_account_mgr_get_default_account): Do not check that the account
782 exists if there is no default account (NULL), to fix a runtime warning.
784 2007-06-06 Murray Cumming <murrayc@murrayc.com>
786 * src/widgets/modest-folder-view.c: (update_model):
787 Do not unref the treemodel before we have finished with it.
788 This prevents a valgrind warning and an occasional crash at startup.
790 2007-06-06 Marcus Bauer <marcusb@openismus.com>
792 * libmodest-dbus-client/libmodest-dbus-client.h:
793 added libmodest_dbus_client_compose_mail()
794 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
796 added functions needed for SendAsMail() functionality
797 * src/maemo/modest-msg-edit-window.c:
798 (modest_msg_edit_window_attach_file_noninteractive):
799 non interactively attaching files to message edit window
800 * src/widgets/modest-msg-edit-window.h:
801 * tests/dbus_api/Makefile.am:
802 added test_compose_mail.c
803 * tests/dbus_api/test_compose_mail.c: (main):
805 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
807 * src/modest-account-view.c:
808 Fixed bug projects.maemo.org bug NB#59307
810 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
812 * src/maemo/easysetup/modest-easysetup-wizard.c:
813 (get_serverport_incoming), (on_before_next), (create_account):
814 * src/maemo/modest-account-settings-dialog.c:
815 (modest_account_settings_dialog_set_account_name):
816 * src/maemo/modest-maemo-utils.c:
817 (on_camel_account_get_supported_secure_authentication_status),
818 (on_camel_account_get_supported_secure_authentication),
819 (on_secure_auth_cancel),
820 (modest_maemo_utils_get_supported_secure_authentication_methods):
822 Implemented security authentication for settings and easysetup.
824 2007-06-05 Murray Cumming <murrayc@murrayc.com>
826 * src/maemo/modest-main-window.c: (create_details_widget):
827 Show the total size for memory card accounts too, instead of showing
828 the name again. Fixes bug projects.maemo.org bug NB#59307.
830 2007-06-05 Murray Cumming <murrayc@murrayc.com>
833 * src/modest-tny-simple-folder-store.c:
834 * src/modest-tny-simple-folder-store.h: Removed.
836 * src/modest-tny-local-folders-account.h
837 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
838 for the local-folders maildir, with an extra TnyMergedFolder containing
839 the folders of the per-account outbox store accounts.
840 * src/modest-tny-account-store.c: (get_server_accounts):
841 Add the outboxes to the special local folders account after creating it.
843 * src/modest-tny-account.c:
844 (modest_tny_account_new_for_local_folders): Create the derived
845 account when creating the main local-folders account.
847 * src/maemo/modest-main-window.c: (create_details_widget),
848 (modest_main_window_set_contents_style):
849 Adapted to the use of the derived account instead of the folder store.
851 * src/modest-ui-actions.c:
852 (modest_ui_actions_on_folder_selection_changed):
853 * src/modest-ui-dimming-rules.c:
854 (modest_ui_dimming_rules_on_new_folder):
855 * src/widgets/modest-folder-view.c: (text_cell_data),
856 (icon_cell_data), (filter_row), (update_model),
857 (get_cmp_rows_type_pos):
860 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
861 Do not get the priv struct, because no priv struct has been set,
862 to avoid a runtime warning.
864 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
865 #ifelse with #else, to fix a warning, to fix the build.
868 2007-06-05 Christian Kellner <ckellner@openismus.com>
870 * libmodest-dbus-client/libmodest-dbus-client.c:
871 Fix small typo in doc (why do you always see them
872 AFTER committing stuff?)
875 2007-06-05 Christian Kellner <ckellner@openismus.com>
877 * libmodest-dbus-client/libmodest-dbus-client.c:
878 (libmodest_dbus_client_search):
879 Initialize hit list with NULL. Also set folder list
880 to "" if NULL was supplied.
883 2007-06-03 Christian Kellner <ckellner@openismus.com>
885 * libmodest-dbus-client/libmodest-dbus-client.c:
886 (modest_search_hit_list_free):
887 Make it save to call it with NULL.
889 * src/dbus_api/modest-dbus-callbacks.c:
890 * src/modest-search.c:
891 Return full ModestSearchHits as the search result list not TnyHeader
892 since can't be around withouth the correspoding TnyFolder.
894 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
896 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
897 Added currently commented code to check for secure auth
899 * src/maemo/modest-account-settings-dialog.c: (on_response),
900 (save_configuration), (show_ok):
901 Fixed projects.maemo.org bugs NB #59248 and #59251
903 * src/maemo/modest-maemo-utils.c:
904 (on_camel_account_get_supported_secure_authentication_status),
905 (on_camel_account_get_supported_secure_authentication),
906 (modest_maemo_utils_get_supported_secure_authentication_methods):
907 * src/maemo/modest-maemo-utils.h:
908 Moved get_supported_secure_authentication() method here to be able
909 to use it from easysetup wizard.
911 * src/modest-pair.c: (on_pair_compare_as_string):
912 Should compare string with first part of pair and not
913 strcmp pairs which will crash.
915 * src/modest-protocol-info.c:
916 (modest_protocol_info_protocol_is_store):
917 * src/modest-protocol-info.h:
918 Added modest_protocol_info_get_auth_protocol_name()
920 2007-06-03 Armin Burgmeier <armin@openismus.com>
922 * src/modest-mail-operation.c:
923 (modest_mail_operation_get_msgs_full): Set priv->account also when
924 only retrieving a single message. This avoids a crash when canceling
927 (modest_mail_operation_notify_end): Do not explicitely remove the
928 operation from the queue but only emit the progress_changed signal.
929 The queue itself listens to that signal to remove the operation when
930 it is finished. This reduces coupling and removes a potential deadlock
931 when modest_mail_operation_notify_end() is called from the queue
932 itself. If that is a problem performance-wise, I would suggest to
933 implement a status-changed signal or something.
935 * src/modest-mail-operation-queue.c: Make sure to never call a
936 function from another file while the queue is locked. This (hopefully)
937 fixes another deadlock when exiting the application while retrieving
940 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
942 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
943 Fixed build if libogs is not available
945 2007-06-03 Christian Kellner <ckellner@openismus.com>
947 * libmodest-dbus-client/libmodest-dbus-client.h:
948 * libmodest-dbus-client/libmodest-dbus-client.c:
949 (libmodest_dbus_client_delete_message):
950 Implement deletion of messages (Client side).
952 (modest_search_hit_free),
953 (modest_search_hit_list_free):
954 Utility functions to free the result hits.
956 * src/dbus_api/modest-dbus-api.h:
957 * src/dbus_api/modest-dbus-callbacks.c:
959 (modest_dbus_req_handler):
960 Implement deletion of messages (Server side).
962 * tests/dbus_api/test_search.c: (main):
965 * tests/dbus_api/Makefile.am:
966 * tests/dbus_api/test_delete_message:
967 Add little test for the message deletion logic
969 2007-06-03 Armin Burgmeier <armin@openismus.com>
971 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
972 when the operation queue was not empty. projects.maemo.org bug
975 2007-06-03 Armin Burgmeier <armin@openismus.com>
977 * src/widgets/modest-account-view.c
978 (on_account_default_toggled): Toggle default account column
979 explicitely instead of waiting for gconf notification (which is
980 currently ignored). This should fix projects.maemo.org bug NB#56910
981 for now. It should probably be removed when gconf notifications are
984 2007-06-03 Christian Kellner <ckellner@openismus.com>
986 * libmodest-dbus-client/libmodest-dbus-client.c:
987 Removed debugging spew.
989 * src/dbus_api/modest-dbus-callbacks.c:
990 Added debugging info.
992 * src/modest-search.c:
993 (modest_search_all_accounts):
994 Use tny_account_store_get_accounts () on the account store
995 to get all accounts which is the way to get all accounts.
997 * tests/dbus_api/test_search.c: (main):
998 Make it possible to supply the search term on the command line.
1000 2007-06-03 Christian Kellner <ckellner@openismus.com>
1002 * libmodest-dbus-client/libmodest-dbus-client.c:
1003 * libmodest-dbus-client/libmodest-dbus-client.h:
1004 Implement searching for mesages over raw dbus. (Client side)
1006 * src/dbus_api/Makefile.am:
1007 * src/dbus_api/modest-dbus-api.h:
1008 * src/dbus_api/modest-dbus-callbacks.c:
1009 * src/dbus_api/modest-dbus-callbacks.h:
1010 Search framework (Server side). Also implement on_idle_open_message().
1012 * src/maemo/modest-platform.c: (modest_platform_init):
1013 Prepare for raw dbus/osso rpc interaction.
1015 * src/modest-search.h:
1016 Changed minsize from unspecific guint to guint32.
1018 * src/modest-search.c:
1020 Added strange hack which magically made tnymail work.
1022 (modest_search_folder),
1023 (modest_search_account),
1024 (modest_search_all_accounts):
1025 Implement helper functions to search all accounts, specific account
1028 * tests/dbus_api/Makefile.am:
1029 * tests/dbus_api/test_open_message.c:
1030 Read url to open from commandline.
1032 * tests/dbus_api/test_search.c:
1033 Implement small test for dbus search stuff
1035 2007-06-02 Armin Burgmeier <armin@openismus.com>
1037 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1038 include account type and account title. This fixes projects.maemo.org
1041 * src/maemo/modest-account-view-window.c: Set a title for the window.
1043 2007-06-02 Armin Burgmeier <armin@openismus.com>
1045 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1046 incoming and outgoing server name based on email address and server
1047 types as long as the names have not been edited manually. This fixes
1048 projects.maemo.org bug NB#58671.
1050 2007-06-02 Armin Burgmeier <armin@openismus.com>
1052 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1053 server type cannot be changed in future to the incoming details page
1054 when creating an account. This fixes projects.maemo.org bug NB#59029.
1056 2007-06-02 Armin Burgmeier <armin@openismus.com>
1058 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1059 and assigned max width chars so that they wrap instead of being
1060 truncated. Fixes projects.maemo.org bug NB#56126.
1062 2007-06-02 Armin Burgmeier <armin@openismus.com>
1064 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1065 introductory note to the connection specific smtp servers dialog, as
1066 section 8.12 of the email UI specification requires. This fixes
1067 projects.maemo.org bug NB#59212.
1069 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1071 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1072 Check for running mail operations, and offer to cancel them, as per the UI
1073 spec. This fixes projects.maemo.org bug NB#59041 .
1074 However, I suspect that tinymail may still use the network connection
1075 in ways that we cannot detect or cancel. But it should at least adapt to
1076 changes fairly well.
1078 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1080 * src/modest-tny-account-store.c: (recreate_all_accounts),
1081 (get_cached_accounts), (get_server_accounts): Do more sensible
1082 ref-counting of the temporarily-cached outbox accounts list. This seems
1083 to fix a crash when entering the password when the password was wrong.
1085 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1087 * src/gnome/modest-main-window.c: (connect_signals):
1088 * src/modest-tny-account-store.c: (get_password),
1089 (modest_tny_account_store_alert): Added comments and clues and
1090 commented-out code about how we currently fail to deal with connection
1091 errors and wrong passwords, and how we should.
1093 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1095 * src/widgets/modest-retrieve-combo-box.c:
1096 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1097 This fixes projects.maemo.org bug NB#58472 .
1099 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1101 * src/maemo/easysetup/modest-easysetup-wizard.c:
1102 (create_page_complete_easysetup):
1103 (create_page_complete_custom): Correct the last commit,
1104 putting the correct sentences in the correct pages.
1106 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1108 * src/maemo/easysetup/modest-easysetup-wizard.c:
1109 (create_page_complete_custom): Show the second sentence of text
1110 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1113 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1115 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1116 Set the leave-on-server conf key by default. This fixes
1117 projects.maemo.org bug NB#59258 .
1119 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1121 * src/maemo/modest-account-view-window.c:
1122 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1123 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1126 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1128 * src/maemo/easysetup/modest-easysetup-wizard.c:
1129 (create_caption_new_with_asterisk):
1130 * src/maemo/modest-account-settings-dialog.c:
1131 (create_caption_new_with_asterisk):
1132 Uncomment the code to add the asterisk, because they are no longer in the
1133 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1134 (update_incoming_server_title): Add an asterisk here too.
1136 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1138 * src/maemo/modest-maemo-global-settings-dialog.c:
1139 (current_connection): Check that we are even connected before trying to
1140 get the current connection name, to prevent a warning.
1142 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1143 Change the comments because tny_maemo_conic_device_connect() is now meant to
1145 * src/modest-mail-operation.c:
1146 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1147 make sure we have a connection and fail if we can't connect.
1149 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1151 * src/maemo/modest-main-window.c:
1152 (on_account_store_connecting_finished): Do not try to get the
1153 connection ID if we are not really connected. I am surprised that
1154 this signal handler is called when we are not connected.
1156 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1158 * src/modest-error.h:
1159 * src/modest-ui-actions.c:
1160 (modest_ui_actions_get_msgs_full_error_handler):
1161 Renamed an enum, added comments, added an enum
1162 for retrieve-limit errors.
1164 * src/modest-mail-operation.c: (foreach_add_item),
1165 (internal_folder_observer_update), (update_account_thread),
1166 (modest_mail_operation_get_msgs_full):
1167 (modest_mail_operation_update_account),
1168 Added comments about how this works, and some code that should
1169 (but does not) check the retrieve-limit. See the TODO comment.
1171 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1173 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1174 Initialize help_id to fix the build. Warnings are good.
1176 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1178 * src/widgets/modest-hbox-cell-renderer.c:
1179 (modest_hbox_cell_renderer_append):
1180 * src/widgets/modest-vbox-cell-renderer.c:
1181 (modest_vbox_cell_renderer_append):
1182 Fix the last commit by doing an extra ref.
1184 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1186 * src/widgets/modest-hbox-cell-renderer.c:
1187 (modest_hbox_cell_renderer_append):
1188 * src/widgets/modest-vbox-cell-renderer.c:
1189 (modest_vbox_cell_renderer_append):
1190 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1191 to fix the build with Maemo Bora.
1192 However, there seems to be a remaining crash, probably due to reference
1195 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1197 * src/modest-tny-account.c:
1198 (modest_tny_account_new_for_local_folders):
1199 Use hildon_file_system_info_async_new() to get a better name for
1200 the memory card account, setting it as the account name.
1201 The timing seems to work, but this is probably
1202 not the best place to do this. See the TODO comment.
1203 * src/maemo/modest-main-window.c: (create_details_widget):
1204 * src/widgets/modest-folder-view.c: (text_cell_data):
1205 Use the tny account name instead of hardcoding a name.
1207 2007-05-30 Christian Kellner <ckellner@openismus.com>
1209 * src/modest-search.c: (modest_search):
1210 Correctly set part_search_func even if we have already parsed
1211 the query and thus a valid OgsTextSearcher object.
1213 2007-05-30 Christian Kellner <ckellner@openismus.com>
1216 Search and check for libogs.
1219 Incooparte the ogs build env.
1221 * src/modest-mime-part-search-stream.c:
1222 * src/modest-mime-part-search-stream.h:
1223 Removed since we do the real searching now in modest-search.c.
1225 * src/modest-search.c:
1226 * src/modest-search.h:
1227 Implement support for ogs. We use that if available and requested
1228 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1229 should now handle the corner case when the search term is spread
1230 across multiple reads.
1231 Also the logic in modest_search () was corrected to search all
1232 requested fields until one is found.
1234 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1236 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1238 * src/modest-init.h:
1239 * src/modest-init.c: Made modest_init_local_folders() take a
1240 path and be public so we can iniitialize maildir folders on
1243 * src/modest-local-folder-info.h:
1244 * src/modest-local-folder-info.c:
1245 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1247 * src/modest-tny-account.c:
1248 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1249 still means the standard local-folders path on the local volume.
1251 * src/modest-tny-account-store.c:
1252 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1253 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1254 all accounts when that happens.
1255 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1256 this too, so it shows up in the treeview.
1258 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1260 * src/maemo/modest-maemo-global-settings-dialog.c:
1261 (current_connection):
1262 * src/widgets/modest-global-settings-dialog.c:
1263 (current_connection_default):
1264 Use the enum values instead of 0, 1 and -1,
1265 to make the code clearer.
1267 * src/modest-account-mgr-helpers.c:
1268 (modest_account_mgr_get_connection_specific_smtp): Make this code
1271 * src/modest-runtime.h:
1272 * src/modest-runtime.c:
1273 Added modest_runtime_remove_all_send_queues().
1274 * src/maemo/modest-main-window.c:
1275 (on_account_store_connecting_finished): Recreate the send queues,
1276 using the appropriate transport accounts for this new connection.
1277 Some futher adapting might be needed if the old send queues are not
1278 automatically stopped at this point.
1280 * src/modest-tny-account-store.c: (get_server_accounts):
1281 Create the connection-specific transport accounts, so that they can
1282 be found later by their ID.
1284 * src/modest-tny-account.h:
1285 * src/modest-tny-account.c:
1286 Added modest_tny_account_new_from_server_account_name().
1287 modest_tny_account_new_from_server_account(): Do not create the
1288 send queues here, because they will be
1289 recreated anyway when the connection changes for the first time.
1291 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1293 * src/modest-local-folder-info.h:
1294 * src/modest-local-folder-info.c:
1295 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1296 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1297 tbox_folder): Take a modest account name instead of a server TnyAccount,
1298 so we can have per-modest-account rather than per-transport-account
1300 We must make sure that we change or recreate the exisitng send queues
1301 when the connection changes for connection-specific transport accounts.
1303 * src/modest-tny-account-store.c:
1304 (create_per_account_local_outbox_folders): Create outboxed per modest
1305 account, not per transport account.
1307 * src/modest-tny-account.h:
1308 * src/modest-tny-account.c:
1309 (modest_tny_account_get_special_folder): For outboxes, get the
1310 parent modest account name. The account is ignored for other folders.
1311 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1312 modest account name rather than a server TnyAccount.
1314 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1316 * src/modest-tny-account.c:
1317 (modest_tny_account_new_from_server_account):
1318 Call modest_runtime_get_send_queue() immediately after creating transport
1319 accounts, so that they start trying to send email from the outbox as soon
1320 as possible at startup. This is probably what we want.
1322 * src/modest-mail-operation.c: (update_account_thread):
1323 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1324 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1325 * src/modest-tny-send-queue.h:
1326 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1327 (modest_ui_actions_on_send):
1328 Added comments about how sending works, though it needs some more work.
1330 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1332 * src/modest-tny-account.c:
1333 (modest_tny_account_get_special_folder): Add TODO because this fails when
1334 the network is busy.
1335 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1336 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1337 Do not try to show this window when there is no active account. The UI
1338 specs does not tell us what to do in this case.
1340 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1344 * src/maemo/Makefile.am:
1345 * src/widgets/Makefile.am: Some dist fixes.
1347 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1349 * src/maemo/modest-connection-specific-smtp-window.c:
1350 (on_button_edit): Make the code clearer, to prevent a double free.
1352 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1354 * src/maemo/modest-account-settings-dialog.c:
1355 (modest_account_settings_dialog_set_account_name),
1356 Check the connection-specific smtp servers checkbox if there are any.
1358 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1359 (modest_connection_specific_smtp_edit_window_init):
1360 Start with a suitable port number.
1362 * src/modest-account-mgr-helpers.h:
1363 * src/modest-account-mgr-helpers.c: Added
1364 modest_account_mgr_get_has_connection_specific_smtp().
1366 (modest_account_mgr_set_connection_specific_smtp),
1367 (modest_account_mgr_remove_connection_specific_smtp),
1368 (modest_account_mgr_get_has_connection_specific_smtp),
1369 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1370 connection-specific smtp server accounts in the account, rather than
1371 the server account conf dir.
1373 This fixes bug projects.maemo.org bug NB#58263 .
1375 * src/modest-tny-account-store.c:
1376 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1377 if there are no server accounts yet, to prevent an infinite loop when there
1378 are no accounts. Document that one must be called before the other.
1380 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1382 * src/modest-account-mgr-helpers.c:
1383 (modest_account_mgr_get_default_account): Make sure that at least
1384 one account is always the default, if there are any enabled accounts.
1385 This is just a sanity check that shouldn't be necessary.
1387 * src/modest-account-mgr-priv.c:
1388 (_modest_account_mgr_account_from_key): Unescape the conf key to
1389 get the real account name. For instance, this is an issue if a space
1390 was in the account name, which can happen because the account name
1391 is generated from the display name.
1392 (_modest_account_mgr_get_account_keyname): Always escape the
1394 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1395 Unescape the conf keys to get the real account names.
1397 For instance, previously the is-default radio button in the accounts
1398 list was not checked for any accounts at first. This fixes that,
1399 and might fix several similar bugs.
1401 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1403 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1404 Removed some debug printfs.
1406 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1408 Modest on-disk outbox directories are now here, for instance:
1409 $HOME/.modest/outboxes/<account-id-1>/outbox
1410 $HOME/.modest/outboxes/<account-id-2>/outbox
1412 $HOME/.modest/local-folders/outbox
1413 so we can have a separate outbox for each account.
1414 But they are shown as one outbox in the GtkTreeView, by using a
1415 TnyMergeFolder in a ModestTnySimpleFolderStore.
1418 * src/modest-tny-simple-folder-store.c:
1419 * src/modest-tny-simple-folder-store.h:
1420 Added ModestTnySimpleFolderStore, used to contain folders from
1421 other folder stores, such as other accounts.
1423 * src/modest-tny-outbox-account.h:
1424 * src/modest-tny-outbox-account.c:
1425 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1426 used for the per-account local outbox folders.
1428 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1429 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1430 only use this (internally) now for the non-outbox local folders.
1432 * src/modest-init.h:
1433 * src/modest-init.c: Added modest_init_one_local_folder(), for
1434 setting up the directory structure for each local folder.
1436 * src/modest-local-folder-info.c:
1437 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1438 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1440 * src/modest-local-folder-info.h:
1441 * src/modest-tny-account-store.c: (on_account_removed),
1442 (on_account_changed), (create_per_account_local_outbox_folders),
1443 (get_server_accounts), (modest_tny_account_store_get_accounts),
1444 (modest_tny_account_store_get_tny_account_by_account),
1445 (modest_tny_folder_store_is_virtual_local_folders):
1447 * src/modest-tny-account.h:
1448 * src/modest-tny-account.c:
1449 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1450 to create an on-disk per-account local outbox folder for each
1452 (create_per_account_local_outbox_folders): Create a local outbox folder
1453 for each transport account.
1454 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1455 for all local folders.
1457 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1458 instead of using g_object_get/set() directly. It is clearer.
1460 (modest_tny_folder_store_get_message_count),
1461 (modest_tny_folder_store_get_local_size
1462 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1463 because we now use these with non-acount folder stores.
1465 (modest_tny_account_get_special_folder),
1466 (modest_tny_account_new_from_server_account),
1467 (modest_tny_account_new_from_account):
1468 (recurse_folders): Adjust to the new outbox system.
1470 * src/modest-tny-folder.h:
1471 * src/modest-tny-folder.c:
1472 (modest_tny_folder_is_local_folder),
1473 (modest_tny_folder_get_local_folder_type),
1474 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1476 * src/widgets/modest-main-window.h:
1477 * src/maemo/modest-main-window.c: (create_details_widget),
1478 (modest_main_window_set_contents_style): Show details for any folder store,
1481 (modest_tny_folder_get_rules):
1482 Remove the const. C does not support constness enough for this.
1484 * src/modest-ui-actions.c:
1485 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1486 make all outboxes appear as one, in the usual local-folders tree node.
1488 (set_active_account_from_tny_account),
1489 (modest_ui_actions_on_folder_selection_changed):
1490 * src/widgets/modest-folder-view.c: (text_cell_data),
1491 (icon_cell_data), (filter_row),
1492 (add_account_folders_to_merged_folder),
1493 (add_account_folders_to_simple_folder_store), (),
1494 (get_cmp_rows_type_pos), (cmp_rows),
1495 (modest_folder_view_set_account_id_of_visible_server_account):
1496 Adjust to the new outbox system, using generic folder stores and folders
1497 in the GtkTreeModel.
1499 2007-05-23 Christian Kellner <ckellner@openismus.com>
1501 * src/modest-mail-operation.c:
1502 (modest_mail_operation_update_account):
1503 Use info->max_size instead of unintialized local var [small
1504 build fix]. (Added TODO to review that change since I don't
1507 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1509 * libmodest-dbus-client/libmodest-dbus-client.c:
1510 (libmodest_dbus_client_compose_mail): function added
1511 * src/dbus_api/modest-dbus-api.h:
1512 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1513 (on_compose_mail): Implementation of the SendAsMail functionality
1515 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1517 * src/modest-account-mgr.c:
1518 (modest_account_mgr_add_server_account): Set the secure-connection
1519 conf key for transport accounts as well as store accounts. I don't know
1520 why the if was there. For instance, this makes sure that we use SSL
1521 for the gmail preset from the easysetup wizard.
1523 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1525 * src/gnome/modest-main-window.c:
1526 (on_account_store_connecting_finished), (connect_signals):
1527 * src/maemo/modest-main-window.c:
1528 (on_account_store_connecting_finished), (connect_signals),
1529 (modest_main_window_new):
1530 Handle TnyAccountStore::connecting-finished instead of
1531 TnyDevice::connection-changed, because we cannot actually perform
1532 operations on accounts until TnyAccountStore has itself responded to
1533 the TnyDevice::connection-changed signal. This prevents a GError from
1535 Do not try to update at startup, because we (at least on scratchbox)
1536 already do an update at startup when the device goes online.
1537 This prevents a GError from tinymail.
1538 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1539 Added TODO about stopping simultaneous operations.
1541 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1543 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1544 * src/modest-mail-operation-queue.c:
1545 (modest_mail_operation_queue_remove):
1546 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1547 about where they happened.
1549 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1551 * src/modest-ui-actions.c:
1552 (modest_ui_actions_on_password_requested): Make sure that the remember
1553 output parameter is always TRUE.
1555 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1557 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1558 Show a OK/Cancel dialog if the error is a question, though we still do not
1559 know anything more about what we are asking the user.
1560 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1561 Fix an uninitialized variable (helper). This is a logic error, however.
1563 2007-05-21 Christian Kellner <ckellner@openismus.com>
1565 * src/modest-search.h:
1566 Correct bit shifting in the ModestSearchFlags enum.
1568 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1570 * src/modest-tny-account.c:
1571 (modest_tny_account_new_from_server_account): Do not use the lsub and
1572 check-all hard-coded IMAP options when using POP.
1574 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1576 * src/modest-tny-account.c:
1577 (modest_tny_account_new_from_server_account):
1578 Use NULL for the secure-auth method for POP when Password auth has been
1579 specified by the user, as we already do for IMAP. "auth=Login" causes
1580 an error from camel or the server.
1582 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1584 * src/maemo/modest-account-settings-dialog.c:
1585 (create_page_account_details),
1586 (modest_account_settings_dialog_set_account_name):
1587 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1588 for the leave-on-server checkbox, rathr than just the checkbox, when
1589 the protocol is not POP.
1591 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1593 * src/widgets/modest-account-view.c:
1594 * src/widgets/modest-account-view.h:
1595 Added modest_account_view_select_account() which will be useful later
1596 to asynchronously re-select the edited account.
1598 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1600 * src/maemo/modest-account-settings-dialog.c:
1601 (modest_account_settings_dialog_set_account_name):
1602 Automatically choose the port numbers based on the secure authentication
1603 methods, if they have not been chosen before.
1604 This fixes projects.maemo.org bug NB#56273 .
1606 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1608 * src/maemo/modest-main-window-ui.h:
1609 * src/modest-ui-actions.c:
1610 * src/modest-ui-actions.h:
1611 Connect the Tools/SMTP Servers menu item to
1612 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1613 SMTP servers dialog, as in the UI specification and saves changes when it
1614 is closed. This fixed projects.maemo.org bug NB#56305 .
1616 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1618 * src/maemo/modest-connection-specific-smtp-window.c:
1619 (modest_connection_specific_smtp_window_init):
1620 Use gtk_window_set_default_size() to make this window big enough, so
1621 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1623 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1625 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1626 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1627 (modest_connection_specific_smtp_edit_window_init),
1628 Do not try to connect to a combobox signal before the combobox exists.
1629 This fixes the cras in projects.maemo.org bug NB#56288 .
1630 (modest_connection_specific_smtp_edit_window_get_settings):
1631 Remove the server_account_name parameter which was being checked for NULL
1632 though it was not used.
1634 * src/maemo/modest-connection-specific-smtp-window.c:
1635 (modest_connection_specific_smtp_window_fill_with_connections),
1636 (on_button_edit), (modest_connection_specific_smtp_window_init):
1637 Correct the number of treemodel columns to prevent a warning.
1638 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1639 libconic does not work.
1641 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1643 * src/modest-tny-account.c:
1644 (modest_tny_account_new_from_server_account):
1645 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1646 SMTP when "None" was chosen by the user. However, with my SMTP server that
1647 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1650 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1652 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1653 to explain the memory management issue with the ID in the ModestPair.
1655 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1656 (add_sending_page), (modest_account_assistant_finalize):
1657 * src/gnome/modest-gnome-global-settings-dialog.c:
1658 (create_updating_page), (create_composing_page):
1659 * src/gnome/modest-msg-edit-window.c: (get_transports),
1660 (init_window), (modest_msg_edit_window_finalize),
1661 (modest_msg_edit_window_get_msg_data):
1662 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1663 * src/gnome/modest-transport-widget.c:
1664 (modest_transport_widget_finalize), (smtp_configuration):
1665 * src/maemo/modest-maemo-global-settings-dialog.c:
1666 (create_updating_page), (create_composing_page):
1667 * src/maemo/modest-msg-edit-window.c: (get_transports),
1668 (init_window), (modest_msg_edit_window_finalize),
1669 (modest_msg_edit_window_get_msg_data),
1670 (modest_msg_edit_window_free_msg_data):
1671 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1672 (modest_store_widget_finalize):
1673 * src/maemo/modest-transport-widget.c:
1674 (modest_transport_widget_finalize), (smtp_configuration):
1675 * src/modest-main.c: (send_mail):
1676 * src/widgets/modest-combo-box.h:
1677 * src/widgets/modest-global-settings-dialog-priv.h:
1678 * src/widgets/modest-global-settings-dialog.c:
1679 (modest_global_settings_dialog_finalize):
1680 * src/widgets/modest-msg-edit-window.h:
1681 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1682 as long as the combo box, to prevent use of freed memory for the ID.
1684 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1686 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1687 get_accounts(), to make this clearer. Do not check for the enabled gconf
1688 key, because we do not use this for server accounts (at least, not yet).
1689 This allows us to send email again.
1691 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1693 * src/maemo/modest-platform.c:
1694 (on_modest_conf_update_interval_changed), (modest_platform_init):
1695 Only respond to this particular key change. All these strcmp()s cannot be
1698 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1700 * src/maemo/modest-maemo-global-settings-dialog.c:
1701 (current_connection): Prevent a crash in scratchbox when
1702 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1703 * src/maemo/modest-platform.c:
1704 (on_modest_conf_update_interval_changed), (modest_platform_init):
1705 Get the update interval from gconf and reset it when the gconf key changes.
1707 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1709 * src/modest-protocol-info.c:
1710 * src/modest-protocol-info.h: Adde enum-specific get functions,
1711 instead of using a ModestProtocolType enum parameter.
1713 * src/gnome/modest-account-assistant.c:
1714 * src/gnome/modest-store-widget.c:
1715 * src/gnome/modest-store-widget.h:
1716 * src/gnome/modest-transport-widget.c:
1717 * src/gnome/modest-transport-widget.h:
1718 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1719 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1720 * src/maemo/easysetup/modest-easysetup-wizard.c:
1721 * src/maemo/modest-account-settings-dialog.c:
1722 * src/maemo/modest-account-settings-dialog.h:
1723 * src/maemo/modest-store-widget.c:
1724 * src/maemo/modest-store-widget.h:
1725 * src/maemo/modest-transport-widget.c:
1726 * src/maemo/modest-transport-widget.h:
1727 * src/modest-account-mgr-helpers.c:
1728 * src/modest-account-mgr-helpers.h:
1729 * src/modest-account-mgr.c:
1730 * src/modest-account-mgr.h:
1731 * src/modest-tny-account.c:
1732 * src/modest-tny-folder.c:
1733 * src/widgets/modest-account-view.c:
1734 * src/widgets/modest-retrieve-combo-box.c:
1735 * src/widgets/modest-retrieve-combo-box.h:
1736 * src/widgets/modest-secureauth-combo-box.c:
1737 * src/widgets/modest-serversecurity-combo-box.c:
1738 * src/widgets/modest-serversecurity-combo-box.h:
1739 * tests/check_account-mgr.c:
1740 Use the specific functions, and use the re-renamed enum values for GNOME too.
1742 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1744 * src/modest-pair.h:
1745 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1746 so we can get the second based on the first.
1748 * src/maemo/modest-account-settings-dialog.h:
1749 * src/maemo/modest-account-settings-dialog.c:
1750 Added get_supported_secure_authentication_methods(), though it is mostly
1751 commented-out for now until the necessary API is committed to tinymail.
1752 (modest_account_settings_dialog_set_account_name),
1753 (save_configuration): Request the supported authentication methods from the
1754 server, so we can choose a working method.
1756 * src/modest-tny-account-store.h:
1757 * src/modest-tny-account-store.c:
1758 (modest_tny_account_store_get_session): Rename from
1759 tny_account_store_get_session().
1761 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1763 * src/modest-protocol-info.h: Split the ModestProtocol enum
1764 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1765 There was no need to have these unrelated values in one enum.
1767 * src/: many files: Adapted to changed enum. This makes the code a bit
1768 clearer, and the compiler could catch some errors.
1770 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1772 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1773 Show the detailed internal camel error message when an error happens
1774 during the configuration, so that our testers can give us more clues.
1775 For instance, in projects.maemo.org bug NB#56910 .
1777 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1779 * src/modest-tny-account.c:
1780 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1781 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1783 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1785 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1786 * src/maemo/modest-account-settings-dialog.c:
1787 (modest_account_settings_dialog_set_account_name),
1788 (save_configuration): For the incoming secure authentication checkbox,
1789 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1790 the UI specification. PLAIN does not seem to be supported for most IMAP
1791 servers anyway, and I am not sure what it would mean.
1792 However, we probably need to discover which of the secure-authentication
1793 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1794 * src/modest-account-mgr-helpers.c:
1795 (modest_account_mgr_get_server_account_data):
1797 * src/modest-tny-account.c:
1798 (modest_tny_account_new_from_server_account):
1799 Use tny_account_set_mech() to set secure-authentication methods,
1800 with some special-casing for IMAP, based on my observations of how
1803 * src/modest-account-mgr-helpers.h:
1804 * src/modest-account-mgr.c:
1805 * src/modest-defs.h: Comment that the URI is only used for local folders.
1807 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1809 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1810 parameter const, just to be neat.
1811 * src/modest-text-utils.c: (modest_text_utils_inline):
1812 End g_strconcat() with NULL, as its documentation says. This is almost
1813 certainly the cause of my crash at startup on the device. Interestingly,
1814 valgrind doesn't tell us about these errors.
1816 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1818 * scripts/build-packages: Added more precise comments about how to use
1819 this script, though I still get this error:
1820 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1821 error building tinymail
1823 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1825 * src/maemo/modest-main-window.c: (on_account_update):
1826 Very slight cleanup, hoping to make it simpler to discover what causes
1827 a crash here sometimes.
1829 * src/modest-tny-account.c:
1830 (modest_tny_account_new_from_server_account): Set the port. Added
1831 comments about the options and a TODO comment because I need to find out
1832 how to specify the secure authentication method.
1834 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1836 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1837 changed CFlags paths form modest to libmodest
1839 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1841 * src/modest-account-mgr-helpers.c:
1842 (modest_account_mgr_get_server_account_data),
1843 (modest_account_mgr_free_server_account_data):
1844 * src/modest-account-mgr-helpers.h:
1845 * src/modest-account-mgr.c:
1846 (modest_account_mgr_add_server_account):
1847 * src/modest-defs.h:
1848 * src/modest-tny-account.c:
1849 (modest_tny_account_new_from_server_account):
1850 Determine the options for tny_camel_account_add_option() here,
1851 based on the settings, rather than storing them directly in gconf.
1853 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1855 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1856 Show a more friendly error dialog now that we expect (from the tinymail
1857 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1859 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1861 * src/maemo/modest-main-window.c: (on_account_update): Check that
1862 account_name is not NULL, to prevent a crash at startup that I am
1863 seeing on the N800. I do wonder why it is NULL.
1865 * src/maemo/easysetup/modest-easysetup-wizard.c:
1866 (create_page_user_details):
1867 * src/maemo/modest-account-settings-dialog.c:
1868 (create_page_user_details), (create_page_outgoing):
1869 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1870 (modest_connection_specific_smtp_edit_window_init):
1871 * src/modest-ui-actions.c:
1872 (modest_ui_actions_on_password_requested):
1873 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1874 might do something useful with the on-screen keyboard.
1876 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1878 * src/maemo/modest-main-window.c: (on_account_update):
1879 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1880 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1882 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1884 * src/modest-tny-account-store.c: (on_account_changed):
1885 Correct the signature of this signal handler.
1887 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1889 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1890 Show a HildonNote instead of a GtkDialog for Maemo.
1892 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1894 * src/widgets/modest-account-view.h:
1895 * src/widgets/modest-account-view.c: (on_account_changed),
1896 (on_account_removed). Added a boolean flag, set/unset by
1897 modest_account_view_block_conf_updates(),
1898 modest_account_view_unblock_conf_updates() to prevent unnecessary
1899 updates, but this is not very useful because the gconf notifications are
1900 so delays (maybe only on Maemo Bora).
1901 So auto-updating is turned off, and these functions do an explicit
1902 update when necessary.
1903 However, something else is still doing too much work when adding/removing
1904 accounts, probably in another part of the application.
1906 * src/maemo/modest-account-view-window.c:
1907 (on_delete_button_clicked), (on_edit_button_clicked),
1908 (on_new_button_clicked): Use the new functions.
1910 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1912 * src/modest-account-mgr-helpers.c:
1913 (modest_account_mgr_set_first_account_as_default):
1914 Sort the list of names alphabetically-by-title, so we choose the first one
1916 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1917 alphabetically by the title.
1919 This fixes projects.maemo.org bug NB#56418 .
1921 * src/modest-account-mgr-priv.c:
1922 (_modest_account_mgr_account_from_key):
1923 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1924 avoid a valgrind error, and possible random behaviour.
1926 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1928 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1929 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1930 tinymail documentation to say that this can be expected.
1931 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1932 pretty, and should not happen, but I would prefer to know when it does.
1934 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1936 * configure.ac: When using the older hildon version, probably on Bora,
1937 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1939 * src/widgets/modest-attachment-view.c:
1940 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1943 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1945 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1946 Implemented the prototype. Can be tested with
1947 tests/dbus_api/test_open_message:
1949 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1951 * src/modest-tny-account-store.c:
1952 (modest_tny_account_store_instance_init), (get_password):
1953 * src/modest-ui-actions.c:
1954 (modest_ui_actions_on_password_requested):
1955 Do not store the password in gconf, because this function is called
1956 for non-remembered passwords. Actually use the cached (in the hash map)
1957 password instead of releasing it.
1958 The password will now not be remembered if it is asked via the protected
1959 password dialog, as per the UI spec.
1961 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1963 * src/modest-defs.h:
1964 * src/modest-account-mgr-helpers.h:
1965 * src/modest-account-mgr-helpers.c:
1966 Added modest_server_account_get_username_has_succeeded(),
1967 modest_server_account_set_username_has_succeeded().
1968 (modest_server_account_set_username),
1969 Reset the has-succeeded flag if the username changes.
1971 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1972 * src/maemo/modest-connection-specific-smtp-window.c:
1973 (modest_connection_specific_smtp_window_save_server_accounts):
1974 Use modest_server_account_set_username() instead of using
1975 modest_conf_set_string() directly, so that the has-succeeded flag is always
1978 * src/modest-ui-actions.c:
1979 (modest_ui_actions_on_password_requested): Dim the username entry if
1980 the username has ever worked, as per the UI spec.
1982 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1984 * src/modest-tny-account-store.c: (get_password):
1985 * src/modest-ui-actions.c:
1986 (modest_ui_actions_on_password_requested):
1987 Allow the username to be changed too, though there is more work to
1988 be done on exactly how this behaves.
1990 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1992 * src/modest-account-mgr-helpers.h:
1993 * src/modest-account-mgr-helpers.c:
1994 Added modest_account_mgr_get_display_name(),
1995 modest_server_account_get_username(),
1996 modest_server_account_set_username(),
1997 modest_server_account_set_password(),
1998 modest_server_account_get_hostname() functions so we do not need to
1999 use the conf API directly.
2001 * src/maemo/modest-main-window.c: (connect_signals):
2002 Actually connect ot the ModestAccountStore::request-password signal,
2003 so that we show the dialog when the password is requested by Tinymail,
2004 for isntance if it is empty.
2006 * src/modest-marshal.list:
2007 * src/modest-tny-account-store.c:
2008 (modest_tny_account_store_class_init), (get_password),
2009 (modest_tny_account_store_alert):
2010 * src/modest-tny-account-store.h:
2011 * src/modest-ui-actions.h:
2012 * src/modest-ui-actions.c:
2013 (modest_ui_actions_on_password_requested):
2014 Change the signal parameters, so it is obvious that we are providing
2015 the non human-readable server name, and receiving both the username
2016 and password, though changing of the username is not yet implemented.
2017 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2018 for the GNOME version.
2020 This should fix the projects.maemo.org bug NB#56209, though it does not
2021 work on Bora, because the gconf_client_get() for the password fails
2022 immediately after we save it with gconf_client_set().
2024 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2027 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2028 caused an undefined symbol error:
2029 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2031 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2033 * src/modest-tny-account-store.c:
2034 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2035 using a GError instead of a string message, so we can translate it in
2038 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2040 * src/maemo/modest-address-book.c:
2041 (modest_address_book_check_names):
2042 * src/maemo/modest-msg-view-window.c:
2043 (modest_msg_view_window_clipboard_owner_change):
2044 * src/modest-init.c: (modest_init_init_ui):
2045 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2046 (update_folders_cb), (modest_mail_operation_update_account):
2047 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2048 (modest_ui_actions_on_msg_attachment_clicked),
2049 (modest_ui_actions_on_msg_recpt_activated):
2050 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2051 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2052 (modest_msg_view_search_next):
2053 * src/widgets/modest-recpt-editor.c:
2054 (modest_recpt_editor_on_button_release_event),
2055 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2056 g_message(). At this point we should only be seeing interesting errors on
2057 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2059 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2061 (modest_wizard_dialog_force_title_update):
2062 * src/maemo/easysetup/modest-wizard-dialog.h:
2063 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2064 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2065 can update the title when appropriate. Otherwise the title is wrong if the
2066 pages are added after adding the notebook to the dialog.
2067 This must be a problem in HildonWizardDialog too.
2068 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2070 * src/maemo/easysetup/modest-easysetup-wizard.c:
2071 (create_subsequent_customsetup_pages),
2072 (create_subsequent_easysetup_pages):
2073 Call modest_wizard_dialog_force_title_update() so that the title is
2074 correct even with GTK+ < 2.10.
2075 This fixes projects.maemo.org bug NB#56145 .
2077 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2079 * src/maemo/modest-platform.c:
2080 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2081 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2084 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2086 * src/widgets/modest-window.h:
2087 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2088 and modest_window_save_state(), which invokes it.
2090 * src/widgets/modest-window-mgr.h:
2091 * src/widgets/modest-window-mgr.c:
2092 Added modest_window_mgr_save_state_for_all_windows(), which calls
2093 the save_state vfunc on all registered windows, if implemented.
2095 * src/gnome/modest-msg-edit-window.c:
2096 * src/gnome/modest-msg-view-window.c:
2097 * src/maemo/modest-msg-edit-window.c:
2098 * src/maemo/modest-msg-view-window.c:
2099 * src/maemo/modest-main-window.c:
2100 Specify the existing save_settings functions as implementations of
2101 ModestWindow::save_state_func().
2103 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2104 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2105 enabling hibernation, for instance.
2107 We may need to do the same thing for restoring settings.
2110 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2112 * src/widgets/modest-window-mgr.c:
2113 * src/widgets/modest-window-mgr.h:
2114 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2115 modest_window_mgr_get_hibernation_is_prevented().
2117 * src/maemo/modest-main-window.c:
2118 (on_hildon_program_is_topmost_notify): Prevent hibernation
2119 (possible when the application goes to the background in the WM),
2120 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2122 * src/maemo/easysetup/modest-easysetup-wizard.c:
2123 (modest_easysetup_wizard_dialog_init):
2124 * src/maemo/modest-account-settings-dialog.c:
2125 (modest_account_settings_dialog_init):
2126 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2127 (modest_connection_specific_smtp_edit_window_init):
2128 * src/maemo/modest-connection-specific-smtp-window.c:
2129 (modest_connection_specific_smtp_window_init):
2130 * src/maemo/modest-signature-editor-dialog.c:
2131 (modest_signature_editor_dialog_init):
2132 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2133 prevent hibernation while any of these account settings dialogs are open.
2135 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2137 * src/maemo/Makefile.am:
2138 * src/maemo/modest-osso-state-saving.c:
2139 * src/maemo/modest-osso-state-saving.h: Added
2140 modest_osso_load_state() and modest_osso_save_state() though they do
2141 nothing now. They should iterate through all the open windows and load/save
2143 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2144 save state when closing.
2146 * src/maemo/modest-main-window.c:
2147 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2148 Add a notification handler for the HildonProgram::is-topmost property,
2149 so we can allow hibernation when the application goes into the background.
2150 But we still need to detect when the accounts setup windows are open so
2151 we can stop hibernation when they are open.
2152 To do this, I also added the main window the HildonProgram. This might have
2153 other side-effects/benefits, and should maybe be done for other windows.
2155 * src/maemo/modest-osso-autosave-callbacks.h:
2156 * src/maemo/modest-osso-autosave-callbacks.c:
2157 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2158 though it does not do anything yet, and we might never need this to do
2159 anything. For instance, we already save drafts.
2161 * src/maemo/modest-platform.c: (modest_platform_init):
2162 Specify the libosso auto-save callback.
2164 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2166 * src/maemo/modest-platform.c:
2167 (modest_platform_set_update_interval):
2168 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2169 aparently stays valid between application instances, so we can use this
2170 to remove and reset it later. According to a maemo-developers email from
2173 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2175 * configure.ac: Depend on libalarm for Maemo.
2177 * src/dbus_api/modest-dbus-api.h:
2178 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2179 (on_send_receive), (modest_dbus_req_handler):
2180 Handle a SEND_RECEIVE D-Bus method.
2182 * libmodest-dbus-client/libmodest-dbus-client.c:
2183 (libmodest_dbus_client_send_and_receive):
2184 * libmodest-dbus-client/libmodest-dbus-client.h:
2185 Add C convenience functions for calling the new D-Bus method.
2187 * src/modest-platform.h:
2188 * src/gnome/modest-platform.c:
2189 * src/maemo/modest-platform.c:
2190 Added modest_platform_set_update_interval(), which uses the
2191 alarmd API on Maemo.
2192 (modest_platform_init),
2193 Call modest_platform_set_update_interval(), using a hard-coded
2194 interval for now (until the global settings dialog is implemented),
2195 though I am not sure that this makes sense yet.
2197 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2199 * src/dbus_api/modest-dbus-callbacks.c:
2200 (modest_osso_cb_hw_state_handler):
2201 * src/dbus_api/modest-dbus-callbacks.h:
2202 * src/maemo/modest-platform.c: (modest_platform_init):
2203 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2204 in case this has some effect on the ability for Maemo to ping the
2207 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2209 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2210 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2211 warning. It is probably a logic error, but I need to fix the build.
2213 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2215 * src/modest-account-mgr.h:
2216 * src/modest-account-mgr.c:
2217 (modest_account_mgr_account_names): Add a gboolean enabled_only
2218 parameter, so we can get lists of onlt the enabled accounts.
2220 (modest_account_mgr_add_account),,
2221 (modest_account_mgr_account_with_display_name_exists):
2222 * src/maemo/modest-msg-edit-window.c: (get_transports):
2223 * src/modest-account-mgr-helpers.c:
2224 (modest_account_mgr_set_first_account_as_default):
2225 * src/modest-init.c: (init_default_account_maybe):
2226 * src/modest-tny-account-store.c: (get_accounts):
2227 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2228 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2229 * tests/check_account-mgr.c: (START_TEST):
2230 Provide the extra parameter, as appropriate.
2232 * src/widgets/modest-account-view.c: (update_account_view):
2233 Do not show disabled accounts (meaning that there is no way to
2234 enable/disable accounts in the UI (the feature is not in our UI
2235 specification), so we can use this internally only to mark unfinished
2236 or temporary account data.
2238 * src/maemo/easysetup/modest-easysetup-wizard.c:
2239 (create_account): Add boolean enable parameter, so we can specify FALSE
2240 to create the temporary account.
2241 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2242 (on_before_next): When finishing, when there is a temporary account, just
2244 Also, use a timeout to delay the showing of the dialog until gconf is likely
2245 to return correct information, due to a maemo gconf bug that is fixed in
2246 osso 1.1, but not yet in Bora.
2247 However, the dialog stays on screen after it is destroyed.
2249 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2250 for invalid data when cancelling. Use a hildon note instead of a dialog
2251 to complain about invalid data. Do not show the account-saved note if the
2252 account is disabled (a temporary account that will not really be saved for use
2255 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2257 * src/modest-account-mgr-helpers.h:
2258 * src/modest-account-mgr-helpers.c:
2259 Added modest_account_mgr_unset_default_account(),
2260 Added modest_account_mgr_set_first_account_as_default().
2262 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2263 If it was the default account, unset the default account name.
2265 * src/maemo/modest-account-view-window.c:
2266 (on_delete_button_clicked): If it was the default account,
2267 set the first remaining account as the default instead.
2269 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2270 a NULL account or a NULL default account, to prevent a crash. This should
2271 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2274 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2276 * src/widgets/modest-recpt-editor.c:
2277 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2278 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2279 TODO comment for this. This fixes the build.
2281 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2282 be the best place for it. This will in future update all auto-update accounts,
2283 rather than just the current/default account, when that gconf key exists.
2284 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2285 if there are no accounts, before calling do_send_receive().
2286 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2288 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2289 * src/maemo/modest-main-window-ui.h:
2290 * src/maemo/modest-main-window.c: (on_connection_changed),
2291 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2292 directly, becaue the signal handler does more.
2294 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2296 * src/modest-account-mgr-helpers.c:
2297 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2298 for the case that the account does not exist.
2300 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2301 (equivalent to the modest account name) rather than the tinymail account name
2302 (equivalent to the modest account title - human readable) to get the account data.
2303 Check for null account data to prevent the crash, and add a TODO comment saying that
2304 this needs fixing because it is using the server account name instead of the account name.
2306 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2308 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2309 * src/maemo/modest-account-settings-dialog.c: (show_error),
2311 Use hildon_note_new_information() for informative and error messages,
2312 which seems to be expected for Maemo applications (no documentation that I know of
2313 says this). I am surprised that there is no distinction between info and error
2316 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2318 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2319 it is easy to find where this is used.
2321 * src/maemo/easysetup/modest-easysetup-wizard.c:
2322 (create_page_welcome), (create_page_account_details),
2323 (create_page_user_details), (create_page_complete_easysetup),
2324 (create_page_custom_incoming), (create_page_custom_outgoing),
2325 (create_page_complete_custom):
2326 * src/maemo/modest-account-settings-dialog.c:
2327 (create_page_account_details), (create_page_user_details),
2328 (create_page_incoming), (create_page_outgoing):
2329 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2330 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2331 (modest_connection_specific_smtp_edit_window_init):
2332 * src/maemo/modest-connection-specific-smtp-window.c:
2333 (modest_connection_specific_smtp_window_init):
2334 * src/maemo/modest-signature-editor-dialog.c:
2335 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2336 and scrolling policy as per the Email Application Layout Guide, if I have
2339 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2341 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2342 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2343 which were empty, because these vfuncs have been removed from TnyAccountStore.
2344 This fixes the build.
2346 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2348 * src/maemo/modest-main-window.c:
2349 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2350 showing/hiding it. Added TODO because it probably should not be NULL.
2351 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2352 because unnecessary g_warnings() make degugging difficult.
2354 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2356 * src/maemo/modest-msg-edit-window.c:
2357 (modest_msg_edit_window_select_color),
2358 (modest_msg_edit_window_select_background_color): 2 const corrections and
2359 moving 2 #endifs before closing brackets, to fix the build.
2361 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2363 * src/maemo/easysetup/modest-easysetup-wizard.h:
2364 * src/maemo/easysetup/modest-easysetup-wizard.c:
2365 (modest_easysetup_wizard_dialog_finalize),
2366 (on_button_edit_advanced_settings), (create_page_complete_custom),
2367 (on_response), (create_account):
2368 Implement the Advanced Settings edit button, by saving the account information,
2369 for the Advanded Settings dialog to use directly from gconf, and removing it
2370 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2371 Bug #5533 in the projects.maemo.org bugzilla.
2373 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2375 * src/maemo/modest-msg-view-window.c:
2376 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2377 when opening a message window.
2379 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2381 * src/maemo/easysetup/modest-easysetup-wizard.c:
2382 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2385 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2386 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2387 gconf settings. I probably added more checks than necessary, but that is safer.
2389 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2390 variable to fix the build, but this seems to be used when it is still NULL.
2392 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2394 * src/modest-platform.h:
2395 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2396 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2397 * src/modest-main.c: Implement this function so we can avoid using
2398 maemo-specific API from cross-platform code.
2400 * src/modest-tny-account-store.c:
2401 (get_smtp_specific_transport_account_for_open_connection):
2402 * src/modest-ui-actions.c: (check_for_connection),
2403 (modest_ui_actions_on_item_not_found):
2404 Use modest_platform_connect_and_wait() and put #idefs around other
2405 maemo-specific code, because only maemo currently has a way to
2406 identify connection names.
2408 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2410 * src/modest-tny-account-store.h:
2411 * src/modest-tny-account-store.c:
2412 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2413 the connection-specific SMTP server settings in the configuration.
2415 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2417 * src/maemo/modest-main-window.c: (on_connection_changed),
2419 * src/modest-main.c: (main), (start_ui), (send_mail):
2420 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2421 that is what is intended.
2423 * src/modest-ui-actions.c: (action_send), (action_receive),
2424 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2425 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2426 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2427 SMTP server is used when it is specified.
2429 (modest_ui_actions_on_send_receive):
2430 Check that a connection is open before proceeding.
2431 Receive and then send, instead of vice-versa, as per the specification.
2433 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2435 * src/modest-mail-operation.c:
2436 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2437 though I guess it should be something other than NULL.
2439 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2441 * src/maemo/easysetup/modest-easysetup-wizard.c:
2442 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2443 combo twice, to avoid an g_warning and to make it visible again.
2444 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2445 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2446 (already intended) dereference when detaching, because we then recreate the menu.
2447 But I am not sure why the warning was happening, and it is possible that this is a memory
2450 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2452 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2453 and uri_parse_mailto() utility functions.
2454 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2456 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2458 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2460 * src/dbus_api/modest-dbus-api.h:
2461 * src/dbus_api/modest-dbus-callbacks.c:
2462 Use an idle callback to execute the modest code in the application's own thread.
2463 Remove the helloworld example method.
2464 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2465 parsed, and the open-message method is not implemented because this is not yet implemented in
2467 * libmodest-dbus-client/libmodest-dbus-client.c:
2468 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2469 (libmodest_dbus_client_open_message):
2470 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2472 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2473 body without crashing.
2475 * tests/dbus_api/Makefile.am:
2476 * tests/dbus_api/test_mail_to.c:
2477 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2479 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2481 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2482 Added file to fix the build. Sorry.
2484 * src/dbus_api/Makefile.am:
2485 * src/dbus_api/modest-dbus-api.h:
2486 * src/dbus_api/modest-dbus-callbacks.h:
2487 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2488 (modest_dbus_req_handler):
2489 Put constants in a separate header so it can be reused by the
2490 client library, without duplication
2492 * libmodest-dbus-client/Makefile.am:
2493 * libmodest-dbus-client/libmodest-dbus-client.c:
2494 (libmodest_dbus_client_call_helloworld),
2495 (libmodfest_dbus_client_send_mail),
2496 (libmodfest_dbus_client_mailto),
2497 (libmodfest_dbus_client_open_message):
2498 * libmodest-dbus-client/libmodest-dbus-client.h:
2499 (Partly) Implement a send_mail D-Bus method.
2501 * tests/dbus_api/Makefile.am:
2502 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2503 the send_email D-Bus method.
2505 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2509 * libmodest-dbus-client/Makefile.am:
2510 * libmodest-dbus-client/libmodest-dbus-client.c:
2511 * libmodest-dbus-client/libmodest-dbus-client.h:
2512 * tests/dbus_api/Makefile.am:
2513 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2514 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2516 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2518 * src/maemo/easysetup/modest-easysetup-wizard.c:
2519 (create_page_account_details):
2520 * src/maemo/modest-account-settings-dialog.c:
2521 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2522 widgets, because this might not be the default in future versions of the Maemo GTK+.
2523 However, I can not not get capitalization to work even in a simple test case.
2525 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2527 * src/maemo/easysetup/modest-easysetup-wizard.c:
2528 (create_page_custom_incoming), (create_page_custom_outgoing):
2529 * src/maemo/modest-account-settings-dialog.c:
2530 (create_page_account_details), (create_page_incoming),
2531 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2532 instead of using gtk_check_button_with_label(), so they are aligned like the other
2533 widgets, as per the UI spec.
2535 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2537 * src/maemo/easysetup/modest-easysetup-wizard.c:
2538 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2539 * src/widgets/modest-validating-entry.c:
2540 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2541 Modest prefix instead of an EasySetup prefix.
2543 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2545 * src/widgets/modest-validating-entry.h:
2546 * src/widgets/modest-validating-entry.c: (on_insert_text),
2547 Added easysetup_validating_entry_set_max_func(), used to set a callback
2548 to call when the max number of characters is reached. GtkEntry has a max-length
2549 already but is silent about it.
2551 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2552 (create_page_account_details), (create_page_user_details),
2554 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2555 (create_page_account_details), (create_page_user_details),
2556 (create_page_outgoing):
2557 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2558 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2559 the UI spec, when the user tries to enter more than the max number of characters.
2561 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2563 * src/maemo/easysetup/modest-easysetup-wizard.c:
2564 (create_page_user_details), (create_page_custom_incoming),
2565 (create_page_custom_outgoing):
2566 * src/maemo/modest-account-settings-dialog.c:
2567 (create_page_user_details), (create_page_incoming),
2568 (create_page_outgoing):
2569 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2570 (modest_connection_specific_smtp_edit_window_init):
2571 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2572 not appropriate. Bad Maemo-specific defaults!.
2574 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2576 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2577 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2578 (modest_signature_editor_dialog_set_settings):
2579 Disable the label and textview when the checkbox is disabled, and use the
2580 specified (UI spec) default signature text.
2582 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2584 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2585 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2587 * src/modest-defs.h:
2588 * src/modest-account-mgr-helpers.h:
2589 * src/modest-account-mgr-helpers.c:
2590 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2592 * src/maemo/Makefile.am:
2593 * src/maemo/modest-signature-editor-dialog.c:
2594 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2597 * src/maemo/modest-account-settings-dialog.h:
2598 * src/maemo/modest-account-settings-dialog.c:
2599 (modest_account_settings_dialog_finalize), (on_button_signature),
2600 (save_configuration): Use the new dialog when the Edit button is pressed, and
2601 save the changes if necessary, as per the UI spec.
2603 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2605 * src/maemo/Makefile.am:
2606 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2607 based on maemo-develoers email from Dirk.
2609 * src/maemo/easysetup/modest-easysetup-wizard.c:
2610 (create_page_welcome), (create_page_account_details),
2611 (create_page_user_details), (create_page_complete_easysetup),
2612 (create_page_custom_incoming), (create_page_custom_outgoing),
2613 (create_page_complete_custom),
2614 (modest_easysetup_wizard_dialog_init):
2615 * src/maemo/modest-account-settings-dialog.c:
2616 (create_page_account_details), (create_page_user_details),
2617 (create_page_incoming), (create_page_outgoing),
2618 (modest_account_settings_dialog_init):
2619 * src/maemo/modest-connection-specific-smtp-window.c:
2620 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2622 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2624 * src/maemo/easysetup/modest-easysetup-wizard.c:
2625 (create_page_account_details), (create_page_custom_outgoing),
2626 (create_page_complete_custom):
2627 * src/maemo/modest-account-settings-dialog.c:
2628 (create_page_user_details), (create_page_incoming),
2629 (create_page_outgoing):
2630 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2631 (modest_connection_specific_smtp_edit_window_init):
2632 Use the correct (UI spec) port min/max, and use horizontal separators,
2635 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2637 * src/maemo/easysetup/modest-easysetup-wizard.c:
2638 (set_default_custom_servernames):
2639 * src/maemo/modest-account-settings-dialog.c:
2640 (create_page_incoming), (on_combo_outgoing_security_changed),
2641 (on_combo_incoming_security_changed), (create_page_outgoing),
2642 (modest_account_settings_dialog_set_account_name),
2643 (save_configuration):
2644 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2645 (on_combo_security_changed),
2646 (modest_connection_specific_smtp_edit_window_init),
2647 (modest_connection_specific_smtp_edit_window_set_connection),
2648 (modest_connection_specific_smtp_edit_window_get_settings):
2649 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2652 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2655 * src/maemo/easysetup/modest-easysetup-wizard.c:
2656 (create_page_custom_outgoing), (create_page_complete_custom):
2657 * src/maemo/modest-account-settings-dialog.c:
2658 (create_page_user_details), (create_page_outgoing):
2659 * src/maemo/modest-account-view-window.c: (button_box_new):
2660 Use changed logical IDs as per the most recent UI spec:
2661 mcen_bd_emailsetup_edit -> mcen_bd_edit
2662 mcen_bd_emailsetup_delete -> mcen_bd_delete
2663 mcen_bd_emailsetup_close -> mcen_bd_close
2665 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2669 * src/dbus_api/Makefile.am:
2670 * src/dbus_api/modest-dbus-callbacks.c:
2671 * src/dbus_api/modest-dbus-callbacks.h:
2672 * src/maemo/modest-platform.c: (modest_platform_init):
2673 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2675 * tests/Makefile.am:
2676 * tests/dbus_api/Makefile.am:
2677 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2679 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2681 * src/maemo/modest-account-settings-dialog.c:
2682 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2683 Removed unnecessary includes.
2685 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2687 * src/maemo/easysetup/modest-easysetup-wizard.c:
2688 * src/maemo/modest-account-settings-dialog.c:
2689 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2690 * src/widgets/Makefile.am:
2691 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2692 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2693 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2694 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2695 * src/widgets/modest-secureauth-combo-box.c:
2696 * src/widgets/modest-secureauth-combo-box.h:
2697 * src/widgets/modest-serversecurity-combo-box.c:
2698 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2699 made the GObject names more consistent with the rest of the Modest code.
2701 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2703 * src/maemo/easysetup/Makefile.am:
2704 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2705 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2706 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2707 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2708 * src/maemo/easysetup/modest-easysetup-wizard.c:
2709 * src/maemo/easysetup/modest-validating-entry.c:
2710 * src/maemo/easysetup/modest-validating-entry.h:
2711 * src/maemo/modest-account-settings-dialog.c:
2712 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2713 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2714 widgets/ because they are used outside of easysetup too. After checking in,
2715 svn will allow me to rename them too.
2717 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2719 * src/gnome/modest-msg-edit-window.c:
2720 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2721 linker error, to fix the build on the GNOME platform.
2722 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2723 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2724 ifdefed out to avoid a warning.
2726 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2728 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2729 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2730 some alternative for GTK+ 2.6.
2732 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2734 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2736 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2737 specified for EmailAccountsDialog in UI spec.
2739 * src/maemo/easysetup/modest-easysetup-wizard.c:
2740 * src/maemo/easysetup/modest-easysetup-wizard.h:
2741 * src/maemo/modest-account-settings-dialog.c:
2742 * src/maemo/modest-account-settings-dialog.h:
2743 Reuse a member window widget for the connection-specific SMTP server accounts,
2744 so we can tell it to create/save the accounts only if we actually save changes.
2746 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2747 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2748 (modest_connection_specific_smtp_edit_window_get_settings):
2749 Return a struct instance for temporarily remembering the entered data.
2751 * src/maemo/modest-connection-specific-smtp-window.h:
2752 * src/maemo/modest-connection-specific-smtp-window.c:
2753 (modest_connection_specific_smtp_window_finalize),
2754 (modest_connection_specific_smtp_window_fill_with_connections),
2756 (modest_connection_specific_smtp_window_save_server_accounts),
2757 (update_model_server_names): Do not actually save data until asked,
2758 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2760 (on_selection_changed),
2761 (modest_connection_specific_smtp_window_init): Disable the edit
2762 button when nothing is selected.
2764 * src/modest-account-mgr-helpers.c:
2765 * src/modest-account-mgr-helpers.h:
2766 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2769 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2771 * src/modest-account-mgr-helpers.h:
2772 * src/modest-account-mgr-helpers.c:
2773 (modest_account_mgr_get_unused_account_name),
2774 (modest_account_mgr_get_unused_account_display_name): Added these
2775 utility functions, to avoid code duplication.
2777 * src/maemo/easysetup/modest-easysetup-wizard.c:
2778 (create_page_account_details), (create_account):
2779 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2780 (on_combo_security_changed),
2781 (modest_connection_specific_smtp_edit_window_init),
2782 (modest_connection_specific_smtp_edit_window_save_settings):
2783 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2784 * src/maemo/modest-connection-specific-smtp-window.c:
2785 (modest_connection_specific_smtp_window_finalize),
2786 (modest_connection_specific_smtp_window_fill_with_connections),
2787 (on_button_edit), (modest_connection_specific_smtp_window_init):
2788 * src/maemo/modest-connection-specific-smtp-window.h:
2789 Implementing saving of connection-specific server accounts.
2791 But I need to refactor this so we can save the data for each
2792 possible connection-specific account and only actually create the server accounts
2793 when the easysetup finished, or the OK button is pressed on the account settings
2796 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2798 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2799 (on_combo_security_changed):
2800 (modest_connection_specific_smtp_edit_window_init):
2801 Auto-fill the port number as in the account settings.
2803 (modest_connection_specific_smtp_edit_window_set_connection):
2804 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2805 * src/maemo/modest-connection-specific-smtp-window.c:
2806 (fill_with_connections), (on_button_edit),
2807 (modest_connection_specific_smtp_window_init):
2808 Turn the edit window into a dialog to simplify the code, and
2809 set a WM hint as in a GtkDialog, because only a popup can be on top of
2810 another window in Maemo, and popups usually have no WM decoration.
2812 * src/modest-defs.h:
2813 * src/modest-account-mgr-helpers.c:
2814 (modest_account_mgr_set_connection_specific_smtp),
2815 (modest_account_mgr_remove_connection_specific_smtp),
2816 (modest_account_mgr_get_connection_specific_smtp):
2817 * src/modest-account-mgr-helpers.h: Some functions to write the
2818 connection-specific SMTP server information. Not yet used.
2821 * src/widgets/modest-folder-view.c: (text_cell_data):
2822 Fix a warning about an uninitialized variable.
2823 (on_configuration_key_changed): Put an #ifdef around the use
2824 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2826 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2828 * src/maemo/modest-account-settings-dialog.h:
2829 * src/maemo/modest-account-settings-dialog.c:
2830 Added connect_for_modified() utility function to mark the new modified boolean.
2832 (create_page_account_details), (create_page_user_details),
2833 (create_page_incoming), (create_page_outgoing), (on_response),
2834 (modest_account_settings_dialog_init),
2835 (modest_account_settings_dialog_set_account_name):
2836 Only warn about unsaved changes when there are actually unsaved changes.
2838 * src/modest-account-mgr-helpers.c:
2839 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2840 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2841 to get the data from there in future.
2843 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2845 * src/modest-defs.h:
2847 * src/modest-account-mgr-helpers.h:
2848 * src/modest-account-mgr-helpers.c:
2849 Store the security account setting in a single conf key instead of using
2850 the options list, so that the list is left for just the to-be-removed camel hack,
2851 and because gconf_client_set_list() is failing for some reason.
2853 * src/modest-account-mgr.c:
2854 (modest_account_mgr_add_server_account):
2855 * src/maemo/modest-account-settings-dialog.c:
2856 (modest_account_settings_dialog_set_account_name),
2857 (save_configuration): Use the renamed functions.
2860 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2862 * src/widgets/Makefile.am:
2863 * src/widgets/modest-limit-retrieve-combo-box.c:
2864 * src/widgets/modest-limit-retrieve-combo-box.h:
2865 * src/widgets/modest-retrieve-combo-box.c:
2866 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2867 the account settings dialog.
2869 * src/modest-defs.h:
2870 * src/modest-account-mgr-helpers.h:
2871 * src/modest-account-mgr-helpers.c:
2872 (modest_server_account_get_option_secure_auth),
2873 (modest_server_account_set_option_secure_auth):
2874 * src/modest-account-mgr.c:
2875 (modest_account_mgr_add_server_account):
2876 Use the existing AUTH_MECH conf key for the secure-auth setting,
2877 instead of putting it in the list options, because this was actually used already.
2879 * src/maemo/modest-account-settings-dialog.c:
2880 (create_page_account_details),
2881 (modest_account_settings_dialog_set_account_name),
2882 (save_configuration):
2883 * src/maemo/modest-account-settings-dialog.h:
2884 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2885 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2887 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2889 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2890 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2891 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2893 * src/modest-defs.h:
2894 * src/maemo/modest-account-settings-dialog.c:
2895 (create_page_incoming), (on_combo_outgoing_security_changed),
2896 (on_combo_incoming_security_changed), (create_page_outgoing),
2897 (modest_account_settings_dialog_set_account_name),
2898 (save_configuration): Load/Save the port number, and change it when the
2899 security combo changes, to suitable defaults.
2901 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2903 * src/modest-account-mgr.c:
2904 (modest_account_mgr_add_server_account): Set the security and secure-auth
2905 options, and add a comment saying that the other camel-specific options should be
2908 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2910 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2912 * src/modest-tny-account-store.c: (account_list_free),
2913 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2914 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2917 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2919 * src/modest-protocol-info.c:
2920 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2921 is required by our UI spec. Maybe something in our implementation will use this eventually.
2922 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2923 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2924 instead of the previous 0 placeholder.
2926 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2927 secure-auth settings.
2928 * src/modest-account-mgr-helpers.h:
2929 * src/modest-account-mgr-helpers.c:
2930 (modest_server_account_data_get_option_secure_auth),
2931 (modest_server_account_set_option_secure_auth),
2932 (modest_server_account_data_get_option_security),
2933 (modest_server_account_set_option_security): Added this API for getting and setting the security
2934 and secure-auth settings.
2936 * src/maemo/modest-account-settings-dialog.h:
2937 * src/maemo/modest-account-settings-dialog.c:
2938 (modest_account_settings_dialog_finalize), (check_data),
2939 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2940 about changing titles.
2941 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2942 (save_configuration): Save the security and secure-auth settings.
2944 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2945 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2947 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2949 * src/modest-defs.h:
2950 * src/modest-account-mgr.c:
2951 (modest_account_mgr_add_server_account):
2952 Added and used defines for the options key and value pair strings,
2953 that are used so far, though they do not seem to correspond to anything in our
2954 UI specs or ModestProtocol enum.
2956 * src/modest-account-mgr-helpers.h:
2957 * src/modest-account-mgr-helpers.c:
2958 (compare_option_strings_for_name),
2959 (modest_server_account_data_get_option_value),
2960 (modest_server_account_data_get_option_bool),
2961 (modest_account_mgr_get_server_account_option):
2962 Added helper functions for parsing the options GSList.
2964 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2966 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2967 display name is based on the supplied account name.
2968 * src/modest-account-mgr.c:
2969 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2970 with an inefficient, but good-enough, implementation.
2972 * src/maemo/easysetup/modest-easysetup-wizard.c:
2973 (create_page_account_details), (on_before_next), (create_account):
2974 Check for existing display names rather than (non-user-visible) account names, and just
2975 create and set a unique account name at the end.
2977 * src/maemo/modest-account-settings-dialog.c:
2978 (modest_account_settings_dialog_init),
2979 (modest_account_settings_dialog_set_account_name),
2980 (create_page_incoming): Show the display name, instead of the account name.
2981 (on_response): Do some (not all) extra checks, as in the UI spec.
2982 (save_configuration): Save the display name if it was changed.
2984 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2986 * po/en_GB.po: Added needed logical ID and translation.
2987 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2988 (init_view): Made the is-default column clicking work.
2990 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2993 * src/maemo/easysetup/Makefile.am:
2994 * src/maemo/easysetup/modest-easysetup-wizard.c:
2995 (modest_easysetup_wizard_dialog_init):
2996 * src/maemo/easysetup/provider-data-test.keyfile:
2997 * src/maemo/easysetup/provider-data.keyfile:
2998 Moved the provider data file to the new modest-providers-data package and used it from there.
3000 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3002 * src/modest-local-folder-info.c:
3003 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3004 N_() was already used on the static strings, but this just marks it for translation without
3005 using the translation.
3007 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3009 * src/maemo/modest-account-settings-dialog.c:
3010 (create_page_incoming),
3011 (modest_account_settings_dialog_set_account_name):
3012 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3013 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3014 I will do this if nobody else gets there first.
3016 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3018 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3019 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3020 save the security stuff.
3022 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3024 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3025 Set the email address and user fullname, which I now see must be
3028 * src/maemo/modest-account-settings-dialog.h:
3029 * src/maemo/modest-account-settings-dialog.c:
3031 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3032 leave-on-server and authentication.
3033 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3036 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3039 * src/maemo/modest-account-settings-dialog.c:
3040 * src/maemo/modest-account-settings-dialog.h:
3041 Most (but not all) of the widgets are now present as specified by the UI spec.
3042 No changes are yet saved, and some details are not properly shown yet.
3044 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3046 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3048 * src/maemo/Makefile.am:
3049 * src/maemo/modest-account-settings-dialog.c:
3050 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3051 an existing account. Doesn't do much yet.
3053 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3054 Open the accounts settings dialog when Edit is clicked.
3056 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3058 * src/maemo/easysetup/Makefile.am:
3059 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3061 * src/maemo/easysetup/modest-easysetup-wizard.c:
3062 (modest_easysetup_wizard_dialog_init):
3063 Try to get the source directory from the build system,
3064 instead of hard-coding "./" into the source code, when opening our local
3065 copies of the configuration files.
3066 But this still fails when opening the wizard from the Accounts window,
3067 maybe because the working directory seems to change at runtime.
3068 So the wizard will fail the second time unless you copy the files into their
3069 proper locations - see the stdout warnings for the paths.
3071 (create_page_account_details),(on_before_next):
3072 Check for existing non-server accounts instead of server accounts,
3073 so the default account name is useful again, and to prevent trying to
3076 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3077 Show the wizard when New is clicked.
3079 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3080 (init_view): Show the column headers, and show the columns that are
3081 specified in the UI specs. However, something in Maemo's GTK+ prevents
3082 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3083 change the default account. This is despite unsetting the special properties.
3085 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3087 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3088 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3089 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3090 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3091 to make that clearer.
3092 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3094 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3096 * src/maemo/modest-account-view-window.c:
3097 (modest_account_view_window_init),
3098 (modest_account_view_window_new):
3099 Use the same buttons as specified in the
3100 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3101 the existing widgets, which never had a chance of working.
3102 Put the ModestAccountView treeview in a scrolled window.
3103 Do not repeat the initialization in both _init() and _new().
3105 * src/widgets/modest-account-view.c: (update_account_view):
3106 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3107 this widget and window shows no accounts.
3109 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3111 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3113 * src/maemo/easysetup/modest-easysetup-wizard.c:
3114 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3115 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3116 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3119 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3120 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3121 accounts exist yet, as in the UI spec.
3123 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3125 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3127 * src/maemo/Makefile.am:
3128 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3129 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3130 New window for editing connection-specific smtp details.
3131 Not fully implemented.
3133 * src/maemo/modest-connection-specific-smtp-window.c:
3134 (modest_connection_specific_smtp_window_finalize) :
3135 unref the tree model.
3136 (on_button_edit): Show the edit window.
3138 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3140 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3143 * src/maemo/Makefile.am:
3144 * src/maemo/modest-connection-specific-smtp-window.c:
3145 * src/maemo/modest-connection-specific-smtp-window.h:
3146 New window for showing the list of connections, for connection-specific
3147 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3148 * src/maemo/easysetup/modest-easysetup-wizard.c:
3149 (create_page_custom_outgoing): Show the new window when the button is clicked.
3151 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3153 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3154 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3155 * src/maemo/modest-msg-edit-window.c:
3156 (modest_msg_edit_window_insert_image):
3157 * src/modest-conf.c: (modest_conf_key_escape):
3158 * src/modest-mail-operation.c:
3159 (modest_mail_operation_send_new_mail):
3160 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3161 (modest_ui_actions_on_new_account):
3162 * src/widgets/modest-attachment-view.c: (update_filename_request):
3163 * src/widgets/modest-mail-header-view.c:
3164 Corrected warnings that were breaking the build, by commenting out unused variables,
3165 and a function, and by including a header.
3167 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3169 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3170 so we can #ifdef around platform-specific code when necessary.
3171 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3172 to allow this to build for the GNOME platform too.
3174 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3176 * src/maemo/easysetup/modest-easysetup-wizard.c:
3177 Added util_increment_name() and used it in create_page_account_details()
3178 to make sure that the default account name is always a new name.
3180 (modest_easysetup_wizard_dialog_init),
3181 (set_default_custom_servernames): Some minor memory management fixes.
3183 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3187 * src/modest-runtime.c: (init_i18n): Restored the translation
3188 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3189 are defined in config.h, and the translations are installed.
3191 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3192 is defined for translation.
3194 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3196 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3198 * src/maemo/easysetup/modest-easysetup-wizard.c:
3199 (modest_easysetup_wizard_dialog_init):
3200 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3201 Use realistic paths (though they should use $prefix generically) to the
3202 mcc_mapping and provider-data.keyfile files which might work when they
3203 are installed by the future version of the operator-wizard package,
3204 and then fallback to paths in our source code, with an explanatory
3207 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3211 * src/maemo/Makefile.am:
3212 * src/maemo/easysetup/: Added files from the previously-exernal
3213 osso-modest-easysetup.
3214 * src/maemo/modest-main-window-ui.h:
3215 * src/modest-ui-actions.c:
3216 * src/modest-ui-actions.h:
3217 Added modest_ui_actions_on_new_account() as a signal handler for the
3218 New Account menu item. It shows the easysetup wizard.
3219 * po/en_GB.po: Added additional needed logical IDs and translations.