1 2007-09-03 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/modest-maemo-utils.c: Don't set the temporary account
4 online that checks for supported authentication methods. This fixes
5 projects.maemo.org bug NB#61369.
7 2007-09-03 Murray Cumming <murrayc@murrayc.com>
9 * src/widgets/modest-folder-view.c: (strings_are_equal),
10 (on_model_foreach_set_name), (on_get_mmc_account_name),
11 (text_cell_data): Restored this code that was removed in
12 svn revision 3165 by jfernandez, because this late name-discovery
13 really is necessary sometimes. This is the correct fix to the endless
14 calling of this function:
15 * src/modest-tny-account.c: (on_modest_file_system_info):
16 Don't call tny_account_set_name() when the name is already correct,
17 to avoid unnecessary (endless) updates to the tree model.
19 2007-08-31 Murray Cumming <murrayc@murrayc.com>
21 * src/modest-defs.h: Rename MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST to
22 MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST and make it a global list
23 for use by all accounts that enable the MODEST_ACCOUNT_USE_CONNECTION_SPECIFIC_SMTP
24 boolean, because this is the specified behaviour in the UI spec.
25 * src/modest-account-mgr-helpers.h:
26 * src/modest-account-mgr-helpers.c:
27 (modest_account_mgr_set_connection_specific_smtp),
28 (modest_account_mgr_remove_connection_specific_smtp),
29 (modest_account_mgr_get_connection_specific_smtp): Remove the account_name
31 * src/maemo/modest-connection-specific-smtp-window.h:
32 * src/maemo/modest-connection-specific-smtp-window.c:
33 (modest_connection_specific_smtp_window_finalize),
34 (modest_connection_specific_smtp_window_fill_with_connections),
35 (modest_connection_specific_smtp_window_save_server_accounts):
36 Remove the account_name parameters and member variable.
37 * src/maemo/easysetup/modest-easysetup-wizard.c:
38 (on_button_outgoing_smtp_servers), (create_account):
39 * src/maemo/modest-account-settings-dialog.c:
40 (on_button_outgoing_smtp_servers), (check_data),
41 (modest_account_settings_dialog_set_account_name),
43 * src/maemo/modest-maemo-utils.c: (on_account_online),
44 (modest_maemo_utils_get_supported_secure_authentication_methods):
45 * src/modest-tny-account-store.c:
46 (get_smtp_specific_transport_account_for_open_connection),
47 (insert_account), (add_connection_specific_transport_accounts):
48 * src/modest-ui-actions.c: (on_smtp_servers_window_hide),
49 (modest_ui_actions_on_smtp_servers):
50 Adapt to the changed API.
52 2007-08-29 Armin Burgmeier <armin@openismus.com>
54 * src/modest-protocol-info.h:
55 * src/modest-protocol-info.c: Added
56 modest_protocol_info_get_auth_protocol() to translate an
57 authentication protocol name to the corresponding enum value.
59 * src/maemo/modest-maemo-utils.c: Fixed supported auth protocol list
60 generation using the newly added function.
62 * src/maemo/modest-account-settings-dialog.c: Use the current element
63 when traversing through the list of supported authentication methods,
66 2007-08-29 Murray Cumming <murrayc@murrayc.com>
68 * src/maemo/easysetup/modest-easysetup-wizard.c:
69 (check_first_supported_auth_method), (on_before_next),
71 * src/maemo/modest-account-settings-dialog.c: (check_data):
72 Some cleanup, to make the code clearer.
74 2007-08-29 Murray Cumming <murrayc@murrayc.com>
76 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
77 Use the mail_ni_ssl_certificate_error ("Secure connection failed")
78 logical ID when the secure authentication method is not supported by
79 the server, as requested by Mox on the wiki, though I hate not
80 giving the user the clue.
82 2007-08-29 Murray Cumming <murrayc@murrayc.com>
84 * src/modest-search.c: (modest_search_all_accounts):
85 * src/modest-platform.h:
86 * src/maemo/modest-platform.c: Moved and renamed
87 check_and_wait_for_account_is_online() to
88 modest_platform_check_and_wait_for_account_is_online() so it
89 can be used in more places.
91 2007-08-29 Murray Cumming <murrayc@murrayc.com>
93 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
94 Removed the sleep(1) experiment because it does not seem to help,
95 and I should not have checked the experiment in anyway.
96 The problem is maybe in the TnyAccount connected state - I will
97 investigate that instead.
99 2007-08-28 Murray Cumming <murrayc@murrayc.com>
101 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
102 Added a sleep(1) in case it helps with bug #66769.
104 2007-08-28 Murray Cumming <murrayc@murrayc.com>
106 * src/modest-search.c: (on_timeout_check_account_is_online),
107 (check_and_wait_for_account_is_online):
108 It is OK for local-folder and mmc accounts to be used when they
109 are in the _INIT folder, instead of waiting for them to change
111 For POP and IMAP, wait from them to stop being _INIT, rather than
112 waiting from them to be _CONNECTED, because that seems to be
113 the status that causes the problems.
115 2007-08-28 Murray Cumming <murrayc@murrayc.com>
117 * src/modest-search.c: (check_and_wait_for_account_is_online):
118 Actually pass the account to the timeout callback.
120 2007-08-28 Murray Cumming <murrayc@murrayc.com>
122 * src/modest-search.c: (on_timeout_check_account_is_online):
123 Added some debug output to help me debug a problem on the N800.
124 (check_and_wait_for_account_is_online): Fail immediately if the
126 modest_search_all_accounts(): Try the search even if the account does
127 not seem to be online, because this can work sometimes, and should work
128 with the cache if there is no active libconic connection.
130 2007-08-27 Armin Burgmeier <armin@openismus.com>
132 * src/modest-tny-send-queue.c: Implement TnyFolderObserver and
133 observe outbox for added messages to assign them a status. Previously,
134 this was done in modest_tny_send_queue_add(), but the message id might
135 not yet be known at that point. This reduces warnings when sending
136 mail, though I am not sure how this even worked before.
138 2007-08-27 Murray Cumming <murrayc@murrayc.com>
140 * src/maemo/modest-account-settings-dialog.c:
141 (modest_account_settings_dialog_init):
142 * src/maemo/modest-connection-specific-smtp-edit-window.c:
143 (modest_connection_specific_smtp_edit_window_init):
144 * src/maemo/modest-connection-specific-smtp-window.c:
145 (modest_connection_specific_smtp_window_init):
146 * src/maemo/modest-maemo-utils.c:
147 (modest_maemo_utils_get_supported_secure_authentication_methods):
148 * src/maemo/modest-platform.c:
149 (modest_platform_run_folder_name_dialog):
150 * src/maemo/modest-signature-editor-dialog.c:
151 (modest_signature_editor_dialog_init):
152 * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
153 (modest_ui_actions_on_password_requested), (create_move_to_dialog):
154 * src/widgets/modest-global-settings-dialog.c:
155 (modest_global_settings_dialog_init):
156 Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
158 GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
159 GTK_STOCK_EDIT with mcen_bd_edit, and
160 GTK_STOCK_CLOSE with mcen_bd_close,
161 to fix projects.maemo.org bug NB#64995.
162 I strongly believe that Maemo's GTK+ should have the wanted translations
163 instead of duplicating this in each application and complicating the code.
165 2007-08-27 Armin Burgmeier <armin@openismus.com>
167 * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
168 recursion when entering text in the subject field.
170 2007-08-27 Murray Cumming <murrayc@murrayc.com>
172 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
173 which checks every second, 10 times, to wait until the account is online
174 so that we can use it, if the account is in the process of going online.
175 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
176 so that searching works even when the application was not yet started before.
177 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
179 2007-08-24 Armin Burgmeier <armin@openismus.com>
181 * src/modest-widget-memory.c: Always show the default account when the
182 application is started, as stated in the UI spec. This fixes
183 projects.maemo.org bug NB#66630.
185 2007-08-24 Armin Burgmeier <armin@openismus.com>
187 * src/maemo/modest-platform.c:
188 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
189 english text for strings in the rename folder dialog, fixing
190 projects.maemo.org bug NB#66338.
192 2007-08-22 Armin Burgmeier <armin@openismus.com>
194 * src/widgets/modest-account-view.c: Fix for bora by using
195 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
196 latter seems not be used anymore.
198 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
201 * src/maemo/modest-main-window.c: Update menu items when the default
202 account changes so that the current default account is always bolded.
203 This fixes maemo.projects.org bug NB#66173.
205 2007-08-17 Murray Cumming <murrayc@murrayc.com>
207 * src/dbus_api/modest-dbus-callbacks.c:
208 (on_dbus_method_get_folders): Avoid trying to get the account name
209 when there are no accounts, to avoid critical g_warnings, fixing
210 projects.maemo.org bug NB#65574.
212 2007-08-17 Murray Cumming <murrayc@murrayc.com>
214 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
215 Use modest_account_mgr_get_signature() instead of accessing gconf
216 directly, to slightly simplify the code.
217 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
218 Append the signature also when opening via other applications,
219 fixing projects.maemo.org bug NB#65828.
221 2007-08-17 Murray Cumming <murrayc@murrayc.com>
223 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
224 Check for NULLs to prevent a crash when opening an email that is
225 an attachment in another email, fixing projects.maemo.org bug
228 2007-08-17 Murray Cumming <murrayc@murrayc.com>
230 * src/modest-ui-dimming-rules.c:
231 (modest_ui_dimming_rules_on_view_window_move_to):
232 Enable the Move To toolbar button for search results, fixing the
233 last part of projects.maemo.org bug NB#63807.
235 2007-08-17 Murray Cumming <murrayc@murrayc.com>
237 * src/dbus_api/modest-dbus-callbacks.c:
238 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
239 because this is called from idle handlers, to fix hangs afte the
241 (find_message_by_url): Added a TODO comment about a crash that
242 happens when tinymail was built with DBC checks.
244 2007-08-16 Murray Cumming <murrayc@murrayc.com>
246 * src/modest-search.c: (modest_search_folder):
247 * src/modest-search.h: Rename ModestSearch::before to start_date
248 and after to end_date, using the same names as the libogs struct
250 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
251 The start_date and end_date were swapped in the check. This
252 fixes date range searches, fixing projects.maemo.org bug NB#63407.
254 2007-08-16 Murray Cumming <murrayc@murrayc.com>
256 * src/maemo/modest-account-view-window.c:
257 Added (check_for_active_acount).
258 (on_delete_button_clicked), (on_edit_button_clicked):
259 When an account is doing something (such as refreshing),
260 show the same warning for account deletion as for account
261 editing, to fix projects.maemo.org bug NB#64588.
263 2007-08-16 Murray Cumming <murrayc@murrayc.com>
265 * src/widgets/modest-msg-view-window.h:
266 * src/gnome/modest-msg-view-window.c:
267 * src/maemo/modest-msg-view-window.c:
268 Added modest_msg_view_window_construct().
269 (modest_msg_view_window_new_with_header_model),
270 Added modest_msg_view_window_new_for_search_result),
271 Renamed modest_msg_view_window_new() to
272 modest_msg_view_window_new_for_attachment(),
273 and modest_msg_view_window_is_search_result(),
274 so we can explicitly know that the window is for an
275 attachment or a search result or a message from the list.
277 (modest_msg_view_window_view_attachment):
278 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
279 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
280 Use modest_msg_view_window_new_for_search_result().
282 * src/modest-ui-dimming-rules.c:
283 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
284 for search results, fixing projects.maemo.org bug NB#63811.
286 2007-08-16 Armin Burgmeier <armin@openismus.com>
288 * src/modest-ui-actions.c: Show a banner instead of a dialog when
289 renaming a folder fails, to stay consistent with what happens when
290 creating a folder fails.
292 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
293 slightly country loading from the mmc_mappings file, fixed a memory
296 2007-08-16 Murray Cumming <murrayc@murrayc.com>
298 * src/modest-tny-account-store.c: (volume_path_is_mounted):
299 Check the GnomeVFSVolume activation path instead of the device path,
300 so that the memory card is really really shown in the UI.
302 2007-08-16 Murray Cumming <murrayc@murrayc.com>
304 * src/maemo/easysetup/modest-easysetup-wizard.c:
305 (get_entered_account_title), (on_before_next), (entry_is_empty),
307 * src/maemo/modest-account-settings-dialog.c:
308 (get_entered_account_title), (on_button_signature), (check_data),
309 (save_configuration), (entry_is_empty):
310 Strip the account title of whitespace at the start and end before
311 using it or checking it. This means that an all-whitespace title
312 is not allowed, fixing projects.maemo.org bug NB#64977.
314 2007-08-15 Murray Cumming <murrayc@murrayc.com>
316 * src/modest-ui-actions.h:
317 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
318 to modest_run_account_setup_wizard() and made it public.
319 * src/dbus_api/modest-dbus-callbacks.c:
320 (check_and_offer_account_creation), (on_idle_mail_to),
321 (on_idle_compose_mail), (on_idle_open_default_inbox):
322 Offer account creation if necessary, fixing projects.maemo.org
325 2007-08-15 Murray Cumming <murrayc@murrayc.com>
327 * src/modest-ui-actions.c: (run_account_setup_wizard):
328 Return a gboolean to indicate success.
329 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
330 (modest_ui_actions_on_send): When offering account creation, only
331 give up (return) if account creation failed. Otherwise continue
332 with the original request. This fixed projects.maemo.org bug
335 2007-08-15 Murray Cumming <murrayc@murrayc.com>
337 * src/widgets/modest-recpt-editor.c:
338 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
339 to fix projects.maemo.org bug NB#63789.
341 2007-08-15 Murray Cumming <murrayc@murrayc.com>
343 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
344 (modest_tny_account_store_new): Properly detect the memory card at
345 startup, and add an account for it.
347 2007-08-14 Murray Cumming <murrayc@murrayc.com>
349 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
350 Commented out the MMC code again because it mistakenly detects
351 the card even when it isn't inserted.
353 2007-08-14 Murray Cumming <murrayc@murrayc.com>
355 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
356 Renabled the call to add_mmc_account() because I do not believe
357 it could be the cause of the mentioned hang (in scratchbox, where
358 there is no memory card), and because I have tested that it works
361 2007-08-14 Murray Cumming <murrayc@murrayc.com>
363 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
364 Comment out part of the last commit because it apparently causes
367 2007-08-14 Murray Cumming <murrayc@murrayc.com>
369 * src/modest-tny-account-store.c: Added the add_mmc_account()
370 function to save some copy/pasting.
371 (modest_tny_account_store_new): If the memory card is mounted,
372 create an account for it at the start, instead of waiting for the
373 user to unmount it and mount it.
375 2007-08-13 Murray Cumming <murrayc@murrayc.com>
377 * src/widgets/modest-account-view.c: (on_account_changed):
378 Do not try to use the human-readable TnyAccount name instead of the
379 ID of the modest account to get the transport account. And unref
380 the transport account. This prevents a g_warning(), and a possible
383 2007-08-13 Murray Cumming <murrayc@murrayc.com>
385 * src/maemo/modest-platform.c:
386 (modest_platform_set_update_interval): Handle the new
387 alarmd error to warn when alarmd is not running, as is the case in
388 scratchbox for me now because
389 "Module /usr/lib/alarmd/libretu.so initialization failed"
391 2007-08-13 Murray Cumming <murrayc@murrayc.com>
393 * src/widgets/modest-header-view-render.c:
394 (_modest_header_view_compact_header_cell_data):
395 NULL some strings after freeing them, trying to deal with
396 the double deletion found in projects.maemo.org bug 64183,
397 probably having no effect.
399 2007-08-13 Murray Cumming <murrayc@murrayc.com>
401 * src/maemo/modest-account-settings-dialog.c:
402 (create_page_incoming), (create_page_outgoing): Use a define
403 for the min and max port numbers.
405 (check_hildon_number_editor_and_warn_value_not_in_range),
406 (check_data): Do an extra check for an invalid port number, as needed
407 in projects.maemo.org bug #64275, when the number is cleared, but this
408 does not work due to bugs.maemo.org bug #1806.
410 2007-08-13 Murray Cumming <murrayc@murrayc.com>
412 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
413 Comment out the debug warning about the unexpected D-Bus methods.
414 They are just annoying now.
415 * src/maemo/modest-platform.c:
416 (modest_platform_set_update_interval): Correct the D-Bus path, instead
417 of using a file path, though it did not seem to break things before.
418 It might be needed now:
419 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
420 modest is not already running. This is the behaviour of the old client, and
421 Mox says it is what we should do for modest.
422 This closes projects.maemo.org bug NB#64327.
424 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
426 * src/modest-text-utils.c:
427 Fixed invalid jump due to incorrect string/pointer
429 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
432 2007-08-01 Murray Cumming <murrayc@murrayc.com>
434 * src/modest-account-mgr-helpers.h:
435 * src/modest-account-mgr-helpers.c:
436 Added modest_account_mgr_get_first_account_name(),
437 using code from modest_account_mgr_set_first_account_as_default().
439 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
440 (account_number_changed): Call set_at_least_one_account_visible() so that
441 the first account is visible when first added, without the user having to
443 I do wonder how this worked before.
445 2007-08-01 Murray Cumming <murrayc@murrayc.com>
447 * src/modest-tny-account-store.c: (show_password_warning_only),
448 (show_wrong_password), (request_password_and_wait), (get_password),
449 (modest_tny_account_store_alert): Remove the (incomplete anyway)
450 attempts to show UI only in the main context, which used g_idle_add()
451 and mainloops, because tinymail now guarantees that it only calls these
452 callbacks in the mainloop with the gdk lock. This makes everything much
455 2007-08-01 Murray Cumming <murrayc@murrayc.com>
457 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
458 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
459 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
460 error dialog, instead of ignoring it.
462 2007-08-01 Murray Cumming <murrayc@murrayc.com>
464 * src/maemo/modest-msg-view-window.c:
465 (modest_msg_view_window_get_header),
466 (modest_msg_view_window_last_message_selected):
467 Added comments to explain the use of priv->header_model.
468 * src/modest-ui-dimming-rules.c:
469 (modest_ui_dimming_rules_on_open_msg),
470 (modest_ui_dimming_rules_on_mark_as_read_msg),
471 (modest_ui_dimming_rules_on_mark_as_unread_msg),
472 (modest_ui_dimming_rules_on_remove_attachments),
473 (_invalid_attach_selected), (_selected_msg_marked_as):
474 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
475 and changed the parameter to a ModestMainWindow to make it clearer that
476 it never uses any other kind of window.
477 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
478 instead of the selected message.
479 I notice that much of the dimming code and the ModestMsgViewWindow code
480 hard-codes the assumption that the viewed message is always selected in
481 the header view. This does not seem wise or simple.
483 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
484 examine the actual message instead of whatever might be selected
485 in the header view. This stops the delete toolbar button and menu item
486 from being dimmed when opening a message view the search UI,
487 partially fixing projects.maemo.org bug NB#63811.
489 However, when actually deleting, I now get this warning:
490 "tny_header_set_flags: This is a header instance for a new message.
491 Only priority and attachment flags are supported"
493 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
495 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
497 Show account wizard if no accounts are defined while sending
498 (automatic sending after the account wizard finished does not
499 work because it takes some time until the account manager
500 synchronizes everything. (projects.maemo.org NB#62792)
502 2007-07-30 Murray Cumming <murrayc@murrayc.com>
504 * src/modest-tny-account-store.c: (on_account_removed),
505 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
506 account is removed from the View menu. We have TnyAccountStore
507 and ModestTnyAccountStore signals that seem very similar, but this
508 seems to work for now.
510 * src/maemo/modest-main-window.c:
511 (on_show_account_action_activated): Prevent dereference
512 of a NULL if the accoutn does not really exist, though that
513 should not happen anymore.
515 This fixes projects.maemo.org bug NB#64606.
517 2007-07-30 Murray Cumming <murrayc@murrayc.com>
519 * src/modest-ui-actions.c: (run_account_setup_wizard),
520 (modest_ui_actions_on_accounts): Revert a change that set these
521 to modal dialogs, freezing the UI when they show secondary dialogs.
522 This fixed projects.maemo.org bug NB#64519.
524 2007-07-27 Murray Cumming <murrayc@murrayc.com>
526 * src/widgets/modest-header-view-render.c:
527 (_modest_header_view_compact_header_cell_data):
528 Some checks and initialization to try to deal with a crash,
529 probably ineffective.
531 2007-07-27 Murray Cumming <murrayc@murrayc.com>
533 * src/maemo/modest-maemo-utils.c:
534 (modest_maemo_utils_get_supported_secure_authentication_methods):
535 Make sure that we have a connection, asking the user for one
537 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
538 Check for a connection before showing the wizard, because
539 the wizard needs a connection to check for server capabilities.
541 2007-07-27 Murray Cumming <murrayc@murrayc.com>
543 * src/maemo/modest-account-view-window.c:
544 (on_new_button_clicked): Remember the wizard dialog instance,
545 so we can just present it again if necessary. This prevents
546 multiple windows from appearing if you click again quickly on the
547 New button before the dialog appears, fixing projects.maemo.org
550 2007-07-27 Murray Cumming <murrayc@murrayc.com>
552 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
553 Offer a connection dialog if there is no connection when
554 starting modest. This should fix projects.maemo.org bug NB#61134.
556 2007-07-27 Murray Cumming <murrayc@murrayc.com>
558 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
559 Reverted my last commit. I was able to fix the build by doing
560 apt-get install wpeditor0 (replacing other wpeditor packages) and
561 an explicit apt-get install wpeditor-dev to upgrade the -dev
564 2007-07-27 Murray Cumming <murrayc@murrayc.com>
566 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
567 Commented out the use of wp_text_buffer_replace_image()
568 because it does not exist, to break the build. Added a TODO for it.
570 2007-07-26 Murray Cumming <murrayc@murrayc.com>
572 * src/modest-tny-account-store.c: (recreate_all_accounts):
573 Recreate them even if they were NULL before. I guess something
574 else was already creating them before, or this would never
576 (modest_tny_account_store_get_server_account): Make sure that
577 the tny accounts have been created before trying to find one.
578 This allows libmodest_dbus_client_compose_mail() to work
579 when the UI is not yet visible.
580 This is probably useful in other cases too.
582 (get_password): When the password is wrong after it is entered
583 in the protected password dialog, show an info banner (in an
584 idle handler) before showing the protected password dialog
587 2007-07-26 Murray Cumming <murrayc@murrayc.com>
589 * src/modest-ui-actions.h:
590 * src/modest-ui-actions.c: Added
591 modest_do_refresh_current_folder() containing some code from
592 modest_ui_actions_on_send_receive().
593 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
594 Call modest_do_refresh_current_folder() before refreshing the
595 requested account, as in modest_ui_actions_on_send_receive().
596 This is strange, but seems to be necessary to show new mails.
597 Now new emails are finally visible in the UI when downloaded
598 via the automatic update interval, fixing bug NB#57458.
599 This also works because bug NB#57458 has been fixed somehow.
601 2007-07-26 Murray Cumming <murrayc@murrayc.com>
603 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
604 printf more details when we get unhandled D-Bus methods, because
607 * src/modest-mail-operation.c: (update_account_thread):
608 Comment out the tny_camel_pop_store_account_reconnect(), because this
609 is apparently no longer needed, and it did not work before anyway.
610 See the comment in the code.
612 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
613 by checking the header flags. This fixes projects.maemo.org bug
616 2007-07-25 Murray Cumming <murrayc@murrayc.com>
618 * src/maemo/modest-maemo-utils.h:
619 * src/maemo/modest-maemo-utils.c: Added
620 modest_maemo_show_information_note_in_main_context_and_forget().
621 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
622 Use the new function to show simple error dialogs in the main
623 context, though question dialogs are still in the current context,
624 which is unfortunately usually not the main context. This should
627 2007-07-25 Murray Cumming <murrayc@murrayc.com>
629 * src/modest-tny-account-store.c: (get_password):
630 Never save the entered username and password in gconf,
631 because the UI spec says we should not. This helps
632 slightly with projects.maemo.org bug NB#63671.
634 2007-07-25 Murray Cumming <murrayc@murrayc.com>
636 * src/widgets/modest-msg-edit-window.h:
637 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
638 Moved some code here to make it simpler.
639 (modest_msg_edit_window_attach_file_one): Renamed from
640 modest_msg_edit_window_attach_file_interactive().
641 (modest_msg_edit_window_offer_attach_file): Renamed from
642 modest_msg_edit_window_attach_file() and used
643 modest_msg_edit_window_attach_file_one() instead of
644 copy/pasting the code. The old code for one was not using
645 GnomeVFS. This allows use of smb:// URLs when using send-as
646 from external applications, fixing bug NB#63741.
648 (modest_msg_edit_window_insert_image),
649 (modest_msg_edit_window_add_attachment_clicked):
650 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
651 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
652 Adapted to the new function names.
654 2007-07-25 Murray Cumming <murrayc@murrayc.com>
656 (modest_platform_set_update_interval): Set the alarm recurrence
657 fields so that auto-update does not just happen the first time.
658 This should have fixed projects.maemo.org bug NB#63938.
660 When this happens you can see a printf when the D-Bus method is
662 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
664 However, I do not actually seem to get new POP messages even when
665 clicking the refresh button manually. A restart gets them.
666 This might be a problem in today's tinymail only.
668 2007-07-24 Murray Cumming <murrayc@murrayc.com>
670 * src/maemo/modest-maemo-global-settings-dialog.c:
671 (current_connection):
672 Avoid a crash (probably only in scratchbox) when strcmp()ing a
673 NULL when closing the dialog.
675 2007-07-24 Murray Cumming <murrayc@murrayc.com>
677 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
678 Remove the hacky send/receive that didn't work, and instead
679 refilter the treemodel to make the deleted email really vanish from
680 the UI (though the delete-from-menu code does has commented out
681 the code that does that). This fixes projects.maemo.org bug
684 2007-07-24 Murray Cumming <murrayc@murrayc.com>
686 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
687 Try a couple of tricks to force the treeview to update (
688 poke the folder, and do a send/receive refresh), but the deleted
689 email still appears with a strike-through instead of really being
692 2007-07-23 Murray Cumming <murrayc@murrayc.com>
694 * src/dbus_api/modest-dbus-callbacks.c:
695 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
696 because their ID is not human-readable (see the comment about
697 improvements needed to the osso-email-interface API) and
698 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
700 2007-07-23 Murray Cumming <murrayc@murrayc.com>
702 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
703 (add_folders_to_list), (on_dbus_method_get_folders),
704 (modest_dbus_req_filter):
705 * src/maemo/modest-maemo-utils.c:
706 (on_camel_account_get_supported_secure_authentication):
707 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
708 (on_header_view_focus_in):
709 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
710 * src/modest-formatter.c: (modest_formatter_create_body_part):
711 * src/modest-mail-operation.c: (recurse_folders),
712 (update_account_thread), (get_msgs_full_thread),
713 (modest_mail_operation_get_msgs_full),
714 (modest_mail_operation_xfer_msgs):
715 * src/modest-search.c: (search_mime_part_and_child_parts),
716 (modest_search_account), (modest_search_all_accounts):
717 * src/modest-tny-account.c:
718 (modest_tny_account_get_special_folder), (recurse_folders):
719 * src/modest-tny-local-folders-account.c:
720 (modest_tny_local_folders_account_query_passes):
721 * src/modest-tny-msg.c: (copy_mime_part),
722 (modest_tny_msg_find_body_part_from_mime_part):
723 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
724 (modest_tny_send_queue_try_to_send):
725 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
726 (_modest_ui_actions_open), (download_uncached_messages),
727 (reply_forward), (modest_ui_actions_on_copy),
728 (modest_ui_actions_on_details), (has_retrieved_msgs),
729 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
731 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
732 (_selected_msg_marked_as), (_msg_download_completed),
733 (_selected_msg_sent_in_progress):
734 * src/widgets/modest-attachments-view.c:
735 (modest_attachments_view_set_message):
736 * src/widgets/modest-msg-view.c: (find_cid_image):
737 * tests/check_folder-transfer.c: (find_folders):
738 * tests/check_update-account.c: (func):
739 * tests/dbus_api/test_get_folders.c: (main):
740 Checked all uses of tny_iterator_get_current(), making sure
741 that the object is unreferenced (3 or 4 places did not),
742 and adding checks for NULL.
744 2007-07-23 Murray Cumming <murrayc@murrayc.com>
746 * src/dbus_api/modest-dbus-callbacks.c:
747 (on_idle_open_default_inbox): Make sure that the application UI is
749 * src/maemo/easysetup/modest-easysetup-wizard.c:
750 (on_entry_invalid_character): Show the word whitespace instead
751 of (null) in the banner when whitespace was entered.
752 (show_error): Add a comment that this does not work in
753 Maemo Bora, though we do not know why.
755 2007-07-23 Murray Cumming <murrayc@murrayc.com>
757 * src/modest-tny-account.c:
758 (modest_tny_account_get_special_folder): Use an if instead of
759 an assert for when the parent account name is NULL, because this
760 might be causing a crash in projects.maemo.org bug 63192.
761 * src/modest-mail-operation.c:
762 (modest_mail_operation_send_new_mail_cb),
763 (modest_mail_operation_remove_folder): unref the folder that is
764 returned from modest_tny_account_get_special_folder().
766 2007-07-23 Murray Cumming <murrayc@murrayc.com>
768 * src/modest-ui-actions.c:
769 (modest_ui_actions_on_password_requested):
770 Show mail_ib_login_cancelled info banner when the user cancels
771 the protected password dialog, to fix projects.maemo.org
774 2007-07-23 Murray Cumming <murrayc@murrayc.com>
776 * src/maemo/modest-account-settings-dialog.c:
777 (create_page_outgoing): Put this page in a GtkScrolledWindow,
778 matching the UI mock-up in the UI spec, and allowing access
779 to all widgets even when the on-screen keyboard is active.
781 2007-07-23 Murray Cumming <murrayc@murrayc.com>
783 Reverted this previous commit from Johannes,
784 because the scrollbars are always visible and because
785 I think we only need it on onepage of the account
786 settings, not the account wizard.
787 (I wrote the wrong instructions in the bug.)
789 * src/maemo/easysetup/modest-easysetup-wizard.c:
790 Added scrollbars to account wizard dialog.
791 Fixed projects.maemo.org NB #62744
793 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
795 * src/maemo/easysetup/modest-easysetup-wizard.c:
796 (create_page_user_details):
797 Use auto-cap for name (projects.maemo.org NB#63716)
798 * src/widgets/modest-account-view.c: (on_account_busy_changed):
800 2007-07-22 Armin Burgmeier <armin@openismus.com>
802 * src/maemo/modest-ui-actions.c: Use current account instead of
803 default account for creating viewer windows, so that the viewer
804 window knows to which account the viewed message belongs.
806 * src/maemo/modest-msg-view-window.c: Destroy the window when the
807 corresponding account is deleted. This fixes projects.maemo.org bug
810 2007-07-18 Armin Burgmeier <armin@openismus.com>
812 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
813 the dialog close after entering an invalid port number and clicking
814 OK. This fixes projects.maemo.org bug NB#63602.
816 2007-07-18 Armin Burgmeier <armin@openismus.com>
818 * src/modest-tny-account-store.c:
819 (get_server_accounts): Set parent modest account name for each
820 connection-specific transport account so that special folders of such
821 an account can be looked up. This fixes a crash when changing account
822 settings. This might also be related to projects.maemo.org bug
825 2007-07-16 Armin Burgmeier <armin@openismus.com>
827 * src/modest-ui-actions.c: Added a button to create a folder to the
828 move-to dialog. This fixes projects.maemo.org bug NB#59863.
830 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
832 * src/maemo/easysetup/modest-easysetup-wizard.c:
833 Added scrollbars to account wizard dialog.
834 Fixed projects.maemo.org NB #62744
836 2007-07-16 Murray Cumming <murrayc@murrayc.com>
838 * src/widgets/modest-msg-view.h:
839 * src/widgets/modest-msg-view.c:
840 Added modest_msg_view_get_message_is_empty() but this needs
842 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
843 Check if there is any text in the message yet.
844 But this needs to be implemented properly.
845 (modest_msg_edit_window_toggle_find_toolbar):
846 * src/maemo/modest-msg-view-window.c:
847 (modest_msg_view_window_toggle_find_toolbar):
848 Show a banner warning if there is no text to search, when
849 trying to start a search. This partially fixes
850 projects.maemo.org bug NB#62350.
852 2007-07-13 Murray Cumming <murrayc@murrayc.com>
854 * src/modest-mail-operation.c: (update_account_thread):
855 Initialized num_new_headers to fix the build.
857 2007-07-13 Murray Cumming <murrayc@murrayc.com>
859 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
860 Ignore modest accounts whose server accounts don't exist in gconf.
861 This prevents us trying to create TnyAccount instances for those
862 server accounts when the server account has been removed from gconf,
863 but the parent modest account has not yet been removed from modest.
864 I don't know why this is only noticeable now. It was probably just
865 a harmeless g_warning() anyway.
867 2007-07-13 Murray Cumming <murrayc@murrayc.com>
869 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
870 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
872 2007-07-12 Armin Burgmeier <armin@openismus.com>
874 * src/maemo/modest-main-window.c: Make default account appear bold
875 in view, tools/send & receive and toolbar/send & receive SCM menus.
876 This fixes projects.maemo.org bug NB#59010.
878 2007-07-12 Murray Cumming <murrayc@murrayc.com>
880 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
881 Add a short-cut, by checking if the folder store is an account.
882 This ensures that the Sort menu item and toolbar is dimmed for
883 the local-folders account root item, fixing
884 projects.maemo.org bug NB#62545.
886 2007-07-12 Murray Cumming <murrayc@murrayc.com>
888 * src/modest-tny-account-store.c: (get_password):
889 Show the password dialog (via the signal) only in the mainloop, via
890 an idle handler that we wait for. This could theoretically prevent
891 hangs, though I worry that it could introduce some too.
893 2007-07-12 Murray Cumming <murrayc@murrayc.com>
895 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
896 * src/maemo/modest-platform.c:
897 (modest_platform_connect_and_wait):
898 Take a TnyAccount* parameter and try to set it to online
899 (a TnyCamel-only API), because tinymail sets accounts to offline
900 when the user cancels a password dialog, and doesn't ask again until
901 it has been set to online.
902 However, this is commented out because it causes a hang now.
904 (modest_platform_connect_and_wait_if_network_account):
905 * src/modest-mail-operation.c:
906 (modest_mail_operation_update_account):
907 * src/modest-platform.h:
908 * src/modest-ui-actions.c: (_modest_ui_actions_open),
909 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
911 2007-07-12 Armin Burgmeier <armin@openismus.com>
913 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
915 * src/modest-mail-operation.c:
916 * src/modest-ui-actions.c: Check for already existing folder before
917 querying the server, show error message from camel if the request
918 still fails. This fixes projects.maemo.org bug NB#58701.
920 2007-07-12 Murray Cumming <murrayc@murrayc.com>
922 * src/modest-tny-account-store.h:
923 * src/modest-tny-account-store.c:
924 Added modest_tny_account_store_forget_password_in_memory(),
925 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
926 when creating a new account, so that new passwords will be used, instead of
927 us thinking that it's a second request as a result of a failed password again.
929 2007-07-12 Murray Cumming <murrayc@murrayc.com>
931 * src/dbus_api/modest-dbus-callbacks.c:
932 (on_idle_open_message): If the message is in drafts then open it
933 in an edit window instead of a view window. This fixes
934 projects.maemo.org bug NB#63005.
936 2007-07-12 Murray Cumming <murrayc@murrayc.com>
938 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
939 Avoided a harmless g_warning().
941 2007-07-12 Murray Cumming <murrayc@murrayc.com>
943 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
944 Pass the modest account name, not the TnyAccount display name to
945 modest_msg_view_window_new() so that the reply feature works,
946 fixing projects.maemo.org bug NB#62892.
948 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
949 (modest_msg_view_window_new_with_header_model):
950 * src/maemo/modest-msg-view-window.c:
951 (modest_msg_view_window_new_with_header_model),
952 (modest_msg_view_window_new):
953 * src/modest-ui-actions.c: (reply_forward):
954 * src/widgets/modest-msg-view-window.h:
955 * src/widgets/modest-window.c: (modest_window_set_active_account):
956 Rename an account parameter to modest_account_name to make this clearer.
958 2007-07-11 Murray Cumming <murrayc@murrayc.com>
960 * src/modest-ui-actions.h:
961 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
962 modest_do_message_delete().
963 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
964 Call modest_do_message_delete(), hoping that this would cause messages
965 to be really deleted from search instead of just marked with strike through.
966 Does not seem to help.
968 2007-07-11 Armin Burgmeier <armin@openismus.com>
970 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
971 priv->reselect to FALSE prior to calling
972 modest_folder_view_select_first_inbox_or_local() to prevent endless
973 recursion and thus a crash on startup.
975 2007-07-11 Armin Burgmeier <armin@openismus.com>
977 * src/maemo/modest-account-settings-dialog.h: Include
978 <gtk/gtknotebook.h> to fix the build (at least for me).
980 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
981 Use "New FolderN" as default suggested name if "New folder" already
982 exists, with N being the first free number, though never exceed "New
983 folder99" in which case we just fall back to "New Folder" even though
984 it already exists. This fixes projects.maemo.org bug NB#58663.
986 2007-07-11 Murray Cumming <murrayc@murrayc.com>
988 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
989 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
990 projects.maemo.org bug NB#62778.
992 2007-07-11 Murray Cumming <murrayc@murrayc.com>
994 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
995 Ignore the wrong (for now) secure-smtp setting in the presets -
996 just default to requiring secure authentication for SMTP, because
999 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
1001 * src/widgets/modest-folder-view.c: (filter_row)
1002 Do not show drafts folder (see UI specs)
1004 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
1006 * src/modest-ui-actions.c:
1007 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
1008 place and also not necessary.
1010 * src/widgets/modest-folder-view.c: (filter_row)
1011 Guess folder type and hide Sent & Outbox if necessary.
1012 Fixed project.maemo.org NB#57328
1014 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1016 * src/modest-ui-actions.h:
1017 * src/modest-ui-actions.c:
1018 (modest_ui_actions_on_delete_message):
1019 Move some code into a new
1020 modest_ui_actions_refresh_message_window_after_delete()
1021 function so we can use it from elsewhere.
1023 * src/dbus_api/modest-dbus-callbacks.c:
1024 (on_idle_delete_message), (on_delete_message): Used an idle
1025 handler, as we do for the other D-Bus method handlers.
1026 Call modest_ui_actions_refresh_message_window_after_delete()
1027 if the deleted message was open in a window. This fixed
1028 projects.maemo.org bug NB#62862.
1030 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1032 * src/modest-main.c: (main): Only show the UI at the start if
1033 the showui command line option was given. For instance,
1034 run-standalone src/modest showui
1035 Otherwise, we wait for the top_application D-Bus method to
1036 be sent by hildon-desktop when the application is selected
1038 This allows us to run without a UI when osso-global-search
1039 uses our D-Bus methods.
1041 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1043 * src/dbus_api/modest-dbus-api.h: Added a define for a
1044 top-application D-Bus method.
1045 * src/dbus_api/modest-dbus-callbacks.c:
1046 (on_top_application),
1047 (modest_dbus_req_handler): Handle the top-application D-Bus
1048 method, which might be an undocumented D-Bus signal sent by
1049 hildon-desktop when it starts the application from the menu.
1050 But I am not sure and I need to test it on the device, because
1051 my scratchbox does not have the application in the menu now.
1052 This method shows the main window, so that it can be invisible
1053 when started, for instance, just for email searching from
1056 * src/maemo/modest-main-window.c: (restore_settings),
1057 (modest_main_window_new): Do not show the window immediately
1058 upon creation. We show it later.
1059 * src/modest-widget-memory.c: (save_settings_paned):
1060 Try (unsuccessfully) to avoid saving the paned position when
1061 it is not even visible.
1062 (restore_settings_paned): Do not allow a silly paned position.
1063 This seems necessary when not showing the window at first.
1065 * tests/dbus_api/Makefile.am:
1066 * tests/dbus_api/test_top_application.c: (main): Test for the
1069 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1071 * src/modest-ui-dimming-rules.c:
1072 (modest_ui_dimming_rules_on_new_msg),
1073 (modest_ui_dimming_rules_on_reply_msg),
1074 (modest_ui_dimming_rules_on_delete_msg),
1075 (modest_ui_dimming_rules_on_details),
1076 (modest_ui_dimming_rules_on_view_window_move_to),
1077 (modest_ui_dimming_rules_on_view_previous),
1078 (modest_ui_dimming_rules_on_view_next),
1079 (_invalid_folder_for_purge): Added checks before
1080 casting the window. This looks like an actual
1081 logic error in _invalid_folder_for_purge(), because it
1082 tries to use a ModestMainWindow as a message window.
1084 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1086 * src/maemo/modest-account-settings-dialog.c:
1087 (show_error): Use the same implementation as in
1088 modest-easysetup-wizard.c:
1089 (on_entry_invalid_character): The logical ID contains a %s.
1090 Guessed what it should be.
1091 (on_entry_max), (check_data), (on_response): Adapt to
1092 changed show_error().
1093 (create_page_account_details): Really call
1094 modest_validating_entry_set_func() on the correct widgets.
1095 * src/maemo/easysetup/modest-easysetup-wizard.c:
1096 (on_entry_invalid_character): Fix the logical ID here too.
1097 (create_page_account_details),
1098 (create_page_user_details):
1100 modest_validating_entry_set_func() on the correct widgets.
1102 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1103 Do not try to use the account if it is NULL.
1105 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1107 * src/modest-ui-actions.c: (create_move_to_dialog),
1108 (modest_ui_actions_on_main_window_move_to),
1109 (modest_ui_actions_on_msg_view_window_move_to):
1110 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
1111 (filter_row), (modest_folder_view_show_non_move_folders):
1112 * src/widgets/modest-folder-view.h:
1114 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
1115 the Sent folder yet as it does not report the correct folder type.
1117 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1119 * src/maemo/modest-msg-edit-window.c: (init_window):
1122 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1124 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1125 Take a parent widget instead of a parent window, and
1126 implement this with hildon_banner_show_information() instead.
1127 Non-Maemo builds can just ifdef that there.
1128 This fixed projects.maemo.org bug NB#62766.
1130 (on_entry_invalid_character): Use show_error() again instead
1131 of using hildon directly, and use the _CS() macro to use the correct
1133 (create_account), (check_for_supported_auth_methods), (on_entry_max):
1134 Pass a widget instead od a window to show_error().
1136 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1138 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1139 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
1140 This allows us to show the server name in the error message, fixing
1141 projects.maemo.org bug NB#62904.
1142 Also, use the appropriate logical ID message for the account protocol.
1144 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1146 * src/modest-tny-account-store.c: (on_idle_wrong_password):
1147 A compilation fix, though the build wasn't broken for me.
1149 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1151 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
1152 Do not try to unref a NULL folder store, to avoid a runtime warning.
1153 This seems to happen sometimes when changing accounts settings.
1155 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1157 * src/modest-tny-account-store.c:
1158 (modest_tny_account_store_instance_init),
1159 (modest_tny_account_store_finalize),
1160 (on_account_settings_hide), (on_idle_wrong_password):
1161 Use a GHashTable to ensure that we only show one account settings
1162 dialog per modest account. This avoids us having a dialog open for
1163 both the store and transport accounts, or due to repeated get_password()
1164 calls that shouldn't happen anyway.
1166 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1168 * src/maemo/modest-maemo-utils.c: (on_hide),
1169 (modest_maemo_show_dialog_and_forget): Handle the response, because
1170 the window is not even hidden by default.
1172 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1173 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1174 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1175 which seems to prevent some modality problems.
1177 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1178 Ignore user cancellation errors.
1180 * src/modest-account-mgr-helpers.h:
1181 * src/modest-account-mgr-helpers.c:
1182 Added modest_server_account_get_password() and
1183 modest_server_account_get_has_password() to avoid direct use of
1186 * src/maemo/modest-account-settings-dialog.h:
1187 * src/maemo/modest-account-settings-dialog.c:
1188 (modest_account_settings_dialog_init): Store the notebook so we can
1190 Added modest_account_settings_dialog_switch_to_user_info().
1192 * src/modest-tny-account-store.c:
1193 (get_password): When the password in the account settings is wrong (we think),
1194 show the relevant page of the account settings dialog, in the mainloop.
1195 However, we currently get many of these at once because cancel does not
1197 (forget_password): Do not forget the password
1198 from the account settings, because this causes side-effects when
1199 tinymail seems to call it at strange time, maybe because of how we
1200 are cancelling get_password().
1201 (modest_tny_account_store_alert): Ignore user cancellations.
1203 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1205 * src/maemo/modest-maemo-utils.h:
1206 * src/maemo/modest-maemo-utils.c:
1207 Added modest_maemo_show_information_note_and_forget() for use instead of
1208 gtk_dialog_run() when the response is not needed, to avoid an extra
1209 mainloop which could cause a hang.
1211 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1212 Use the logical IDs for the error message, though they are not
1213 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1214 because gtk_dialog_run() caused a hang here (the window did not close).
1215 This fixes projects.maemo.org bug NB#62646.
1217 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1219 * src/modest-account-mgr-helpers.h:
1220 * src/modest-account-mgr-helpers.c:
1221 Added modest_account_mgr_get_store_protocol().
1223 * src/maemo/modest-account-view-window.c:
1224 (on_delete_button_clicked): Show different warning text depending on
1225 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1226 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1229 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1231 * src/maemo/modest-msg-edit-window.c:
1232 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1233 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1235 2007-07-07 Armin Burgmeier <armin@openismus.com>
1237 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1238 ckdg_ib_maximum_characters_reached from correct package.
1240 * src/modest-ui-actions.c: Show an error message when a folder could
1241 not be created. Tinymail does not give us specific error codes about
1242 what has gone wrong, so we assume that a folder with that name
1243 already exists, though there might be other reasons.
1245 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1247 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1248 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1249 give a more exact error message that can be partly translated.
1251 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1253 * src/maemo/modest-address-book.c:
1254 (select_email_addrs_for_contact): Specify a default window size for the
1255 select-email-address dialog, so that it is probably big enough for the
1256 title. This should fix projects.maemo.org bug NB#62277.
1258 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1260 * src/maemo/easysetup/modest-easysetup-wizard.c:
1261 (create_page_complete_easysetup): Use
1262 gtk_widget_set_size() request to ensure that the text wraps
1265 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1267 * src/maemo/easysetup/modest-easysetup-wizard.c:
1268 (on_entry_invalid_character), (create_page_account_details),
1269 (create_page_user_details):
1270 Use new API of ModestValidatingEntry. But for some reason the banner is
1271 not shown. I will have to investigate that further.
1273 * src/widgets/modest-validating-entry.c: (on_insert_text),
1274 (modest_validating_entry_set_func):
1275 * src/widgets/modest-validating-entry.h:
1276 Added a new callback function to be able to react to prevented
1277 characters whitespaces to e.g show a banner.
1279 2007-07-05 Armin Burgmeier <armin@openismus.com>
1281 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1282 notification of HildonNumberEditor instead of remembering the port
1283 number. Thanks to Johannes for pointing this out.
1285 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1287 * src/maemo/easysetup/modest-easysetup-wizard.c:
1288 Check if there are any user changes before showing a confirmation
1289 dialog (projects.maemo.org NB#60946)
1291 2007-07-05 Armin Burgmeier <armin@openismus.com>
1293 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1294 number at the beginning of the dialog and set the modified flag at the
1295 end if the port number has changed. This is necessary because
1296 HildonNumberEditor does not support notification when the value has
1299 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1301 * src/modest-ui-actions.c:
1302 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1303 a connection before asking anything else. Correct the check for the destination
1304 folder so that it succeeds when online.
1305 This fixed projects.maemo.org bug NB#61645.
1307 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1309 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1310 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1311 to fix projects.maemo.org bug NB#62439.
1313 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1315 * src/modest-tny-account.c: (on_connection_status_changed):
1316 Really do not use tny_device_force_offline() here. See the previous comment.
1318 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1320 * src/modest-tny-account.c: (on_connection_status_changed):
1321 Do not use tny_device_force_offline() when tinymail says that something
1322 went wrong with the connection. It seems to report this unnecessarily.
1324 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1326 * src/maemo/modest-connection-specific-smtp-window.c:
1327 (modest_connection_specific_smtp_window_init):
1328 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1329 does not seem to have any effect in osso 1.1 (though it works in
1330 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1332 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1334 * src/maemo/modest-connection-specific-smtp-window.c:
1335 Fix UI specification problems with projects.meamo.org NB#60479
1337 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1339 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1340 clue when this has failed, because the error dialog is not always shown
1341 (at least in earlier version).
1343 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1344 GError message, because the generic error dialog is not helpful.
1346 'This message is not currently available (can't let a new connection go online)'
1347 when trying to open an IMAP message.
1349 (_modest_ui_actions_open): Offer a connection when some messages would
1350 have to be downloaded and we are offline.
1352 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1354 * src/widgets/modest-folder-view.c:
1355 Don't check for MERGE type anymore as we use the correct type
1357 NOTE: For the last two changes you need to update your tinymail copy
1358 because of API changes!
1360 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1362 * src/modest-tny-local-folders-account.c:
1363 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1364 (see projects.maemo.org NB#61580)
1366 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1368 * src/modest-tny-account.c: (on_connection_status_changed):
1369 Commented out the call to modest_platform_connect_and_wait() because this
1370 seems to always hang, and I would like to know if this is the only thing
1371 that causes a hang when showing the connection dialog.
1372 It is not very useful anyway.
1374 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1376 * src/maemo/modest-msg-view-window.c:
1377 (modest_msg_view_window_select_next_message):
1379 * src/modest-platform.h:
1380 * src/maemo/modest-platform.c:
1381 Added modest_platform_connect_and_wait(), which calls
1382 tny_maemo_conic_device_connect() always in the main thread, by calling it
1383 in an idle handler and waiting for the idle handler to run. It should be
1384 in the main thread because it uses GTK+ UI code. It just returns TRUE
1385 if the device is already online.
1387 There is some nasty code to ensure that subsequent calls to
1388 modest_platform_connect_and_wait() just wait for the first one to finish,
1389 by checking repeatedly in another idle handler. This is necessary,
1390 because other threads (or even the main thread, via another idle handler)
1391 can call modest_platform_connect_and_wait() while
1392 modest_platform_connect_and_wait() is running.
1394 (modest_platform_connect_and_wait_if_network_account),
1395 (modest_platform_connect_and_wait_if_network_folderstore):
1396 Convenience functions that calls modest_platform_connect_and_wait() if
1397 the account or folder might want network access.
1399 * src/modest-mail-operation.c:
1400 (modest_mail_operation_update_account):
1401 * src/modest-ui-actions.c: (download_uncached_messages),
1402 (modest_ui_actions_on_rename_folder), (delete_folder),
1403 (modest_ui_actions_on_main_window_move_to),
1404 (modest_ui_actions_on_msg_view_window_move_to):
1405 * src/widgets/modest-folder-view.c:
1406 (drag_and_drop_from_folder_view):
1407 Offer a connection if we are offline.
1409 * src/modest-tny-account.c: (on_connection_status_changed):
1410 Document this as only handling errors during network operations in progress,
1411 and replace the idle code with a simple call to
1412 modest_platform_connect_and_wait(), which does this instead.
1414 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1416 * src/modest-tny-account.c:
1417 (modest_tny_account_get_special_folder): (util_on_idle),
1418 Handle the GError so we can see when tny_folder_store_get_folders()
1419 fails, as it currently does while something else is connecting.
1421 Added util_run_in_main_thread_and_wait()
1422 which uses an idlen handler and mainloop to ensure that the function
1423 is called in the main thread.
1424 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1425 to make sure that we call attempt the connection in the mainloop only,
1426 which might solve some hangs.
1428 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1430 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1431 be found by their display name. This is never useful.
1432 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1433 by its ID, instead of trying to use its ID as its display name.
1435 * src/modest-tny-account-store.h:
1436 * src/modest-tny-account.c:
1437 (modest_tny_account_get_special_folder): Add a g_warning() when
1438 tny_folder_store_get_folders() returns an empty list for the maildir.
1440 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1441 Add a g_warning() when this returns NULL, because that it not allowed
1444 2007-07-02 Armin Burgmeier <armin@openismus.com>
1446 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1447 note when trying to cancel the wizard. This fixes projects.maemo.org
1450 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1452 * src/modest-tny-account.h:
1453 * src/modest-tny-account.c:
1454 (modest_tny_account_new_from_server_account),
1455 (modest_tny_account_new_from_server_account_name),
1456 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1457 because this must now be set before setting the proto. This is usd in
1458 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1459 warning in camel_session_get_service() caused by
1460 tny_camel_transport_account_prepare().
1462 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1465 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1467 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1469 (modest_connection_specific_smtp_edit_window_init):
1471 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1472 of "changed" for now
1474 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1476 * src/modest-tny-account.c:
1477 (modest_tny_account_new_from_server_account):
1478 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1479 now uses to request a connection when it needs one, and which it uses
1480 to tell us that something is wrong with the connection, so we can force
1481 the accounts offline to prevent further problems.
1483 * src/modest-defs.h:
1484 * src/modest-init.c: (init_default_settings):
1485 * src/modest-mail-operation.c:
1486 (modest_mail_operation_update_account):
1487 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1488 This should not be necessary anymore. Do not set the conf key that
1489 determined this (it was always TRUE and not set anywhere else).
1491 * src/modest-ui-actions.h: Remove unused and unimplemented
1492 modest_ui_actions_on_online_toggle_toggled().
1494 2007-06-29 Murray Cumming <murrayc@murrayc.com
1496 * src/maemo/modest-main-window.c: (connect_signals):
1497 Don't connect to delete_event twice. Maybe this was harmless.
1499 2007-06-29 Murray Cumming <murrayc@murrayc.com
1501 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1502 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1503 Debug output to give some more clue when a folder move is not allowed.
1505 2007-06-28 Murray Cumming <murrayc@murrayc.com
1507 * src/modest-tny-account.c: (on_modest_file_system_info),
1508 (modest_tny_account_get_mmc_account_name):
1509 Always call the callback, without checking whether the name has changed.
1510 * src/widgets/modest-folder-view.c: (strings_are_equal),
1511 (on_model_foreach_set_name), (on_get_mmc_account_name),
1512 (text_cell_data): Compare the name here, and use the name from
1513 the account rather than from the
1514 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1515 if the name was changed after the account was added to the model.
1516 That's a tinymail bug but not one that I want to fix now.
1518 This finally fixes projects.maemo.org bug NB#59301.
1520 2007-06-27 Armin Burgmeier <armin@openismus.com>
1522 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1525 2007-06-27 Murray Cumming <murrayc@murrayc.com
1527 * src/modest-tny-account.h:
1528 * src/modest-tny-account.c:
1529 Added modest_tny_account_get_mmc_account_name(), to set the memory
1530 card name asynchronously for the given account and then notify.
1531 (modest_tny_account_new_for_local_folders): Use this new function instead
1532 of using hildon_file_system_info_async_new() directly.
1534 * src/widgets/modest-folder-view.c: (text_cell_data):
1535 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1536 gtk_tree_model_row_changed() when it is available.
1538 This should fix projects.maemo.org bug NB#59301.
1540 2007-06-27 Murray Cumming <murrayc@murrayc.com
1542 * src/modest-mail-operation.c: (update_account_thread),
1543 (get_msgs_full_thread): Fix typo failures in the revert
1546 2007-06-27 Murray Cumming <murrayc@murrayc.com
1548 * src/maemo/modest-maemo-global-settings-dialog.c:
1549 (idle_select_default_focus):
1550 * src/modest-mail-operation.c: (idle_notify_progress),
1551 (idle_notify_progress_once), (set_last_updated_idle),
1552 (update_account_thread), (get_msgs_full_thread):
1553 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1554 * src/widgets/modest-header-view.c:
1555 (idle_notify_headers_count_changed_destroy),
1556 (idle_notify_headers_count_changed):
1557 Reverted the additions of gdk_threads_enter/leave(), in case this
1558 helps with a startup hang on the device.
1560 2007-06-26 Armin Burgmeier <armin@openismus.com>
1562 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1563 for supported secure authentication methods from server by
1564 gtk_dialog_run(), saving CPU time and a potential race condition.
1566 2007-06-26 Armin Burgmeier <armin@openismus.com>
1568 * src/maemo/modest-maemo-utils.h:
1569 * src/maemo/modest-maemo-utils.c: Added a
1570 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1571 only error code to tell the calling code when the user canceled the
1574 * src/maemo/modest-account-settings-dialog.h:
1575 * src/maemo/modest-account-settings-dialog.c:
1576 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1577 message if the retrieval of secure authentication methods was canceled
1578 by the user. Perform the check before saving anything to configuration
1579 to not end up with half-committed configuration changes, do not show
1580 a "Saving to configuration failed" note when authentication methods
1581 could not be retrieved.
1583 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1586 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1588 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1589 Only return the first level of folders under accounts, because the
1590 osso-global-search UI spec doesn't want the rest.
1591 This fixed projects.maemo.org bug NB#61811.
1593 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1595 * src/modest-tny-account-store.c:
1596 * src/modest-tny-account-store.h:
1597 Added modest_tny_account_is_memory_card_account().
1598 * src/maemo/modest-main-window.c: (create_details_widget):
1599 Show the same information items for the memory card as we show for the
1600 local-folders, to fix projects.maemo.org bug NB#59307.
1602 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1604 * src/modest-tny-account-store.c: (get_password):
1605 Added some checks for NULL to maybe prevent crashes, though I think
1606 it was Philip's last commit that actually prevented the crash here
1607 when creating a first new account.
1608 But the new account is still not usable (no messages are shown)
1609 until a restart of the application.
1611 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1613 * src/maemo/modest-maemo-global-settings-dialog.c:
1614 (idle_select_default_focus):
1615 * src/modest-mail-operation.c: (idle_notify_progress),
1616 (idle_notify_progress_once), (idle_notify_update_account_queue),
1617 (set_last_updated_idle), (update_account_thread),
1618 (notify_get_msgs_full), (get_msgs_full_destroyer),
1619 (get_msgs_full_thread):
1620 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1621 * src/widgets/modest-header-view.c:
1622 (idle_notify_headers_count_changed_destroy),
1623 (idle_notify_headers_count_changed):
1624 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1625 all idle handlers, because some other thread could be blocking
1626 the GDK lock, so that it can do GUI stuff.
1628 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1630 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1631 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1632 (on_idle_send_receive), (on_idle_open_default_inbox):
1633 * src/maemo/modest-msg-edit-window.c:
1634 (modest_msg_edit_window_attach_file_noninteractive):
1635 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1636 to prevent a hang. I don't quite understand why these are necessary,
1637 beause we should already be in the main loop. I guess something outside
1638 of the main loop is taking the lock.
1640 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1641 we are really using URIs, and use files that are more likely to exist.
1643 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1645 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1646 necessary because configure.ac now defines different variables.
1648 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1650 * libmodest-dbus-client/libmodest-dbus-client.c:
1651 * libmodest-dbus-client/libmodest-dbus-client.h:
1652 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1653 libmodest_dbus_client_compose_mail() is what things actually use.
1655 * src/dbus_api/modest-dbus-api.h:
1656 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1657 * tests/dbus_api/Makefile.am:
1658 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1661 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1663 * src/modest-init.c: (modest_init_local_folders):
1664 For memory-card (or other non local-folders) maildir accounts,
1665 always create an Archive folder, so that there is somewhere to put
1666 messages. This should be less confusing, because the user does not need
1667 to guess that the need to create a folder.
1669 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1671 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1672 Fixed icon size by using (50, 50) which is the same as defined by
1675 2007-06-25 Armin Burgmeier <armin@openismus.com>
1677 * src/widgets/modest-window-mgr.c:
1678 * src/modest-init.c:
1679 * configure.ac: Correctly recognize hildon-notify presence and fixed
1680 the build without it being installed.
1682 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1684 * libmodest-dbus-client/libmodest-dbus-client.c:
1685 (libmodest_dbus_client_search): Fix the build. Sorry.
1686 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1687 (reply_forward_cb): Initialize variables to fix the build.
1689 * src/modest-tny-account-store.c:
1690 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1691 comparison (a silly typo) so that email search results can be opened
1692 when there are more than one account.
1694 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1696 * libmodest-dbus-client/libmodest-dbus-client.c:
1697 (libmodest_dbus_client_search),
1698 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1699 instead of 1 second, because the search gets folders and messages from
1700 the server, which can take a long time. When it times out,
1701 osso-global-search will report no results.
1703 We need to specify whether we should search only cached information
1704 (maybe with a user preference), and the osso-email-search-plugin
1705 API should really be improved to allow that option, and to allow results
1706 to be delivered asynchronously in batches.
1708 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1710 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1711 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1712 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1714 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1716 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1717 that is an empty string. D-Bus seems to give us these instead of NULL.
1719 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1721 * src/dbus_api/modest-dbus-callbacks.c:
1722 * src/maemo/easysetup/modest-easysetup-wizard.h:
1723 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1724 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1725 (modest_connection_specific_smtp_edit_window_init):
1726 * src/maemo/modest-maemo-global-settings-dialog.c:
1728 * src/maemo/modest-maemo-utils.c:
1729 (modest_maemo_utils_setup_images_filechooser):
1730 * src/maemo/modest-main-window.c: (create_details_widget):
1731 * src/maemo/modest-msg-edit-window.c:
1732 (modest_msg_edit_window_attach_file_noninteractive),
1733 (modest_msg_edit_window_color_button_change),
1734 (modest_msg_edit_window_set_zoom):
1735 * src/modest-mail-operation.c: (update_account_thread):
1736 * src/modest-tny-account-store.c:
1737 * src/modest-tny-account.c:
1738 * src/widgets/modest-global-settings-dialog.c:
1739 * src/widgets/modest-window.h:
1741 Fixed build on bora!
1743 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1745 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1746 * src/modest-search.c: (modest_search_folder),
1747 (modest_search_all_accounts): Actually search only in the specified folder,
1748 doing a simple match on the folder ID.
1749 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1750 and added some documentation.
1752 2007-06-22 Armin Burgmeier <armin@openismus.com>
1754 * src/maemo/modest-maemo-utils.h:
1755 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1756 modest_maemo_utils_get_supported_secure_authentication_methods.
1758 * src/maemo/easysetup/modest-easysetup-wizard.c:
1759 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1760 one occured, not just "Server does not support secure authentication".
1762 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1764 * src/modest-tny-account-store.c: (get_password):
1765 Restored the call to tny_account_set_user() because Philip seems to have
1766 stopped this from crashing (by not using the freed string). It still does
1767 not work, but now we can test it.
1769 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1771 * src/maemo/modest-msg-edit-window.c: (init_window):
1772 Comment out use of an uninitialzed GtkScrolledWindow variable,
1773 to fix the build and stop a crash. Yet again.
1775 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1777 * src/modest-tny-account-store.c: (get_password):
1778 Remove the call to tny_account_set_user() because this actually crashes.
1779 As mentioned in the last commit, it is known to not work anyway.
1781 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1783 * src/modest-tny-account-store.c: (get_password):
1784 Use tny_account_set_username() to tell tinymail that the username might
1785 have changed too. But tinymail ignores this: see projects.maemo.org
1787 * src/modest-ui-actions.c:
1788 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1789 reset the connection when changing the username, and improve the comments.
1790 Save the changed username to gconf at least, so it is used when Modest is
1793 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1795 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1796 Do not use a query, so that we get all folders, including for POP and
1797 local-folders. They work as search criteria too.
1798 This fixes projects.maemo.org bug NB#57740.
1800 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1802 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1803 Comment out the use of hildon_notification_set_sound() because it is
1804 not declared, to fix the build. Warnings are serious, people.
1806 2007-06-21 Armin Burgmeier <armin@openismus.com>
1808 * src/maemo/modest-maemo-utils.h:
1809 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1810 modest_maemo_utils_get_supported_secure_authentication_methods()
1811 to query authentication methods for a specific user. This should fix
1812 projects.maemo.org bug NB#61369.
1814 * src/maemo/easysetup/modest-easysetup-wizard.c:
1815 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1818 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1820 * libmodest-dbus-client/libmodest-dbus-client.h:
1821 * libmodest-dbus-client/libmodest-dbus-client.c:
1822 (modest_dbus_message_iter_get_search_hit),
1823 (libmodest_dbus_client_search):
1824 Reorganised and commented this.
1825 Removed modest_search_hit_free() from the public API because it
1828 Added libmodest_dbus_client_get_folders() and
1829 modest_folder_result_list_free().
1831 * src/dbus_api/modest-dbus-api.h:
1832 * src/dbus_api/modest-dbus-callbacks.c:
1833 (modest_dbus_req_filter): Commented. Moved most code to
1834 on_dbus_method_search() and added on_dbus_method_get_folders().
1836 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1837 of the extra D-Bus handler.
1839 * tests/dbus_api/Makefile.am:
1840 * tests/dbus_api/test_get_folders.c: New test for
1841 libmodest_dbus_client_get_folders(). This seems to return an empty list
1842 at the moment. That could be the same error that causes the message list
1843 to be empty sometimes.
1844 This should help with projects.maemo.org bug NB#57740.
1846 2007-06-21 Armin Burgmeier <armin@openismus.com>
1848 * src/modest-mail-operation.c: Do not call
1849 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1850 notify the operation's end after having set the status to CANCELED for
1851 the operation queue to listen on. This fixes a deadlock when there
1852 were mail operations in the queue during its finalization.
1854 * src/modest-singletons.c: Reordered uninitialization of the account
1855 manager to happen after the mail operation queue was uninitialized
1856 because the mail operation's in the queue might still try to access
1857 the account manager (see modest_mail_operation_notify_end()). This
1858 fixes a potential crash when terminating the application.
1860 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1862 * src/modest-search.c:
1863 (search_mime_part_and_child_parts): Moved some code here so we
1864 can search recursively in child folders.
1865 (modest_search_folder): Search in the message as a mime part, instead
1866 of just its child mime parts.
1867 (read_chunk), (search_mime_part_ogs):
1868 Check how many bytes were read, to prevent an endless loop.
1869 Searching in message bodies now works. This finishes the fix for
1870 projects.maemo.org bug NB#61007.
1872 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1874 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1875 Add a g_warning when the item is not a folder.
1877 * src/modest-ui-dimming-rules.c:
1878 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1879 when selected item is not a folder (for instance, an account), because
1880 the UI spec only talks about folders.
1881 I am not sure what the UI spec wants, so this might not totally fix
1882 projects.maemo.org bug NB#60794.
1884 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1886 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1887 (load_from_file): Sort the list. The unsorted list would be more noticeable
1888 in non-English locales.
1890 * src/maemo/modest-msg-edit-window.c:
1891 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1892 warning and fix the build.
1894 * src/maemo/modest-progress-bar-widget.c:
1895 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1896 avoid a g_warning, and probably to avoid a crash.
1898 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1900 * src/modest-search.c: (modest_search_folder): Check for a GError
1901 when calling tny_folder_get_headers(), to show that this is not the cause
1904 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1906 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1907 Actually set the body query instead of the subject query.
1909 * src/modest-search.c: (search_mime_part_ogs),
1910 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1911 which would probably cause it to fail if we got this far.
1913 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1914 to simplify the code.
1915 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1916 be causing search-in-body to fail.
1918 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1920 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1922 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1923 Better debug message when the folder cannot be found.
1924 This should help with fixing projects.maemo.org bug #61287.
1925 * src/modest-search.c: (add_hit): Do not leak the furl string.
1927 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1929 * src/modest-ui-actions.c:
1930 (modest_ui_actions_on_folder_selection_changed):
1931 Do not special-case TNY_MERGE_FOLDER here, because
1932 modest_tny_folder_get_account() already does that. This fixes
1933 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1934 shown when the Outbox was selected).
1936 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1938 * libmodest-dbus-client/libmodest-dbus-client.c:
1939 (_dbus_iter_get_string_or_null): Initialize the string variable in
1940 case this helps with Dirk's crash.
1942 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1944 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1945 though it is not implemented yet (this function is maybe not even used),
1946 to avoid breaking ABI in future.
1947 * libmodest-dbus-client/libmodest-dbus-client.c:
1948 (get_attachments_string): Moved some code into this generic function.
1949 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1950 sends email. It is maybe not used.
1951 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1952 (on_send_mail): Use attachments.
1954 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1955 * src/maemo/modest-msg-edit-window.c:
1956 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1957 a filename before using it, to fix projects.maemo.org bug NB#58233.
1959 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1961 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1962 Initialize the continue_download variable to fix the build, and probably
1963 to fix randome behaviour.
1965 2007-06-18 Armin Burgmeier <armin@openismus.com>
1967 * src/modest-tny-send-queue.h:
1968 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1969 the queue so we can later show it in the UI. Replaced
1970 modest_tny_send_queue_msg_is_being_sent() by
1971 modest_tny_send_queue_get_msg_status().
1973 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1975 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1976 gpointer. This probably was not harmful, but just to be sure.
1978 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1980 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1981 Fix the build, but leave the function broken on Bora, because
1982 hildon_uri_action_get_service() does not exist.
1983 osso_uri_action_get_service() does not exist either, it seems.
1985 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1987 * src/modest-tny-account.c:
1988 (modest_tny_account_new_from_server_account):
1989 Uncommented the url debug output again, because it is useful for
1990 debugging, as I said in the comment.
1992 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1994 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1996 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1997 for Mameo Bora, to fix the build.
1999 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
2002 Fixed build with hildon < 0.99
2004 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2005 Check if the selected account is busy instead of checking all accounts
2007 * src/modest-account-mgr-priv.h:
2008 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
2009 (modest_account_mgr_init), (compare_account_name),
2010 (modest_account_mgr_set_account_busy),
2011 (modest_account_mgr_account_is_busy):
2012 * src/modest-account-mgr.h:
2013 Added busy information to the account manager. It possible to
2014 set an account to busy or not busy now.
2016 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
2017 (modest_mail_operation_update_account),
2018 (modest_mail_operation_notify_end):
2019 Set the account to busy/not busy depending on the operation state.
2021 * src/widgets/modest-account-view.c:
2022 (modest_account_view_finalize), (get_last_updated_string),
2023 (update_account_view), (on_account_busy_changed), (init_view):
2024 Show string "Refreshing..." if the account is currently busy.
2026 All this fixes projects.maemo.org bug NB#59711
2028 2007-06-14 Armin Burgmeier <armin@openismus.com>
2030 * src/widgets/modest-attachments-view.h:
2031 * src/widgets/modest-attachments-view.c: Added
2032 modest_attachments_view_has_attachments() and fixed coordinate
2033 transformation in get_att_view_at_coords(). This fixes attachment
2036 * src/widgets/modest-msg-view.c: Make use of
2037 modest_attachments_view_has_attachments() to decide whether to show
2038 attachments in the header.
2040 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
2042 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2043 (on_change), (on_combo_security_changed),
2044 (modest_connection_specific_smtp_edit_window_init),
2045 (modest_connection_specific_smtp_edit_window_set_connection),
2046 (modest_connection_specific_smtp_edit_window_is_dirty):
2047 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2048 * src/maemo/modest-connection-specific-smtp-window.c:
2051 Show an comfirmation dialog for the smpt-edit-window if there are
2052 unsaved changes and the user hits cancel.
2053 (projects.maemo.org bug NB#60479)
2055 2007-06-14 Armin Burgmeier <armin@openismus.com>
2057 * src/maemo/easysetup/modest-easysetup-wizard.c:
2058 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
2059 address" info in banner instead of node, and select all the text as
2060 per UI spec. This fixes projects.maemo.org bug NB#60550.
2062 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
2064 reviewed by: <delete if not using a buddy>
2066 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
2067 * src/modest-ui-actions.c: (folder_refreshed_cb):
2069 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2071 * src/widgets/modest-folder-view.c: (filter_row):
2072 Explictly filter out the per-account outbox accounts. I don't know why
2073 these only sometimes show up, but now they should never show up in the UI.
2074 This should fix projects.maemo.org bug NB#60160.
2076 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2078 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
2079 when the toolbar does not exist yet.
2080 * src/modest-widget-memory.c: (save_settings_header_view):
2081 Added g_warnings() to help us to discover when we are trying to set
2082 an empty columns list in gconf.
2084 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2086 * src/modest-init.h:
2087 * src/modest-init.c:
2088 Added modest_init_get_default_header_view_column_ids().
2090 * src/modest-widget-memory.c: (restore_settings_header_view):
2091 Use the new function to get defaults, if the gconf key is empty,
2092 instead of not creating any columns. This seems to fix the
2093 empty right-hand pane problems.
2095 * src/widgets/modest-header-view.h: Improved documentation.
2097 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2099 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2100 Revert the use of the display name as the account name, because this
2101 is generally wrong and would break the code that follows.
2103 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2105 * src/maemo/easysetup/modest-easysetup-wizard.c:
2106 (check_for_supported_auth_methods), (on_before_next),
2109 More correct fix for projects.maemo.org bug NB# 58991
2110 Do not longer accept AUTH_PASSWORD as secure method and choose
2111 correct method when creating the account.
2113 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2115 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2116 Fixed projects.maemo.org bug NB# 58991
2118 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2120 * src/modest-init.c: (modest_init_init_core),
2121 (modest_init_local_folders): Fixed compilation errors.
2123 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2125 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2126 Remove unnecessary lib/include, though it is good in principle when needed.
2128 * src/modest-init.c: (modest_init_one_local_folder),
2129 (modest_init_local_folders):
2130 * src/modest-init.h: Initialize the .modest library for memory cards,
2131 instead of just doing nothing for them. This should allow us to create
2132 folders there, fixing projects.maemo.org bug NB#59297.
2134 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2136 * libmodest-dbus-client/libmodest-dbus-client.c:
2137 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2138 (libmodest_dbus_client_compose_mail),
2139 (libmodest_dbus_client_open_message),
2140 (libmodest_dbus_client_send_and_receive),
2141 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
2143 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
2144 (on_idle_open_message), (modest_dbus_req_handler),
2145 (search_result_to_message), (modest_dbus_req_filter):
2146 * src/modest-search.c: (add_hit), (modest_search_folder),
2147 (modest_search_all_accounts): Improved debug messages.
2149 * tests/dbus_api/test_open_message.c: (main): Improved comments.
2151 * src/modest-tny-account-store.c:
2152 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
2155 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2158 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2160 * src/modest-tny-account-store.c: (get_server_accounts):
2161 Call modest_tny_local_folders_account_add_merged_outbox_folders()
2162 even when there are no accounts, so that the Outbox folder is always
2163 visible. This fixes projects.maemo.org bug NB#60158.
2165 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2167 * src/maemo/modest-main-window.c: (create_details_widget):
2168 Use the mcen_va_never logical ID.
2170 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2172 * src/dbus_api/modest-dbus-api.h:
2173 * src/dbus_api/modest-dbus-callbacks.c:
2174 (on_idle_open_default_inbox), (on_open_default_inbox),
2175 (modest_dbus_req_handler):
2176 Added a new OpenDefaultInbox method.
2178 * libmodest-dbus-client/libmodest-dbus-client.h:
2179 * libmodest-dbus-client/libmodest-dbus-client.c:
2180 Added libmodest_dbus_client_open_default_inbox() to call the new
2181 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2182 though it should maybe be used by a new osso-email-interface function.
2184 * tests/dbus_api/Makefile.am:
2185 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2188 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2190 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2191 NULL, so that the signals get all the keys. This should not actually
2192 change any behaviour because we currently update everything when anything
2195 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2197 * src/widgets/modest-folder-view.c: (text_cell_data),
2198 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2199 (find_inbox_iter): If tinymail tells us that the folder is
2200 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2201 This causes the inbox to be selected at startup, fixing part of
2202 projects.maemo.org bug NB#56305.
2204 * src/modest-ui-dimming-rules.c:
2205 (modest_ui_dimming_rules_on_tools_smtp_servers):
2206 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2207 the SMTP servers menu item.
2208 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2209 that the SMTP Servers menu item is dimmed when there are no accounts,
2210 as a future version of the UI spec will require. This fixes
2211 projects.maemo.org bug NB#56305.
2213 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2215 * src/maemo/modest-maemo-utils.c:
2216 (modest_maemo_utils_get_supported_secure_authentication_methods):
2217 Added label to dialog instead of unreadable title
2219 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2220 (modest_main_window_new):
2221 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2224 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2225 * src/modest-account-mgr.h:
2226 Added method to avoid code duplication
2228 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2229 (modest_ui_actions_on_send_receive):
2230 Use modest_account_mgr_has_accounts
2232 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2234 * src/maemo/easysetup/modest-presets.c:
2235 (modest_presets_get_info_server_security): Do not report secure auth
2237 * src/modest-protocol-info.c: Use the defines for the gconf key names
2238 for secure authentication. This was not working because we were writing
2239 Password and reading password, and the check was case sensitive.
2240 With this, gmail now works for receiving and sending when created via
2243 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2245 * src/maemo/easysetup/modest-presets.c:
2246 (modest_presets_get_info_server_security): Correct the key name for
2247 SecureSmtp, because it seems to be case-sensitive.
2248 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2249 Do not try to get the 0th notebook page if there are 0 pages, to
2250 avoid a g_warning().
2252 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2254 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2255 Prevent use of the new notification feature for now, because it currently
2256 shows one dialog for each new email, which is annoying.
2258 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2260 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2261 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2262 when no country was selected, so that we show the global ones.
2263 * src/maemo/easysetup/modest-presets.c:
2264 (modest_presets_get_providers): Return only the global providers, not
2265 all providers when mmc=0 was requested.
2267 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2269 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2270 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2271 provider ID in the combo.
2273 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2274 Do not show the page numbers, because it would be confusing when we add
2275 the 2 extra pages for the custom setup, when the user chooses the "Other"
2276 provider. This fixes projects.maemo.org bug NB#59028
2278 * src/modest-init.c: (modest_init_init_core),
2279 (modest_init_local_folders):
2280 * src/modest-init.h:
2281 * src/modest-tny-account.c:
2282 (modest_tny_account_new_for_local_folders): Do not create default folders
2283 for the memory card. This should fix projects.maemo.org bug NB#59328.
2285 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2287 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2288 Free the changed_conf_keys string items. They are already freed in the
2289 idle handler if that runs first.
2291 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2293 * src/modest-ui-actions.c:
2294 (modest_ui_actions_on_password_requested): Check that the server name
2295 is not NULL, because I just saw a password dialog with (null) as the
2298 * src/modest-tny-folder.[h|c]: Added
2299 modest_tny_folder_is_memory_card_folder().
2300 * src/modest-ui-dimming-rules.c:
2301 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2302 menu item for memory cards, as per the UI spec (section 7.4). This should
2303 fix projects.maemo.org bug NB#59297.
2305 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2307 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2308 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2309 is another problem with the code, see Murray's comment at line 772)
2311 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2313 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2314 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2315 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2316 (load_from_file), (easysetup_country_combo_box_init),
2317 (easysetup_country_combo_box_get_active_country_ids),
2318 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2319 instead of just one ID, to avoid duplicate country names in the UI.
2321 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2322 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2323 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2324 a single ID, avoiding duplicate providers.
2325 * src/maemo/easysetup/modest-easysetup-wizard.c:
2326 (on_combo_account_country): Adapt to use a list.
2328 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2330 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2331 keys changed in the last X seconds.
2333 * src/modest-account-mgr.h:
2334 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2335 (on_key_change), (modest_account_mgr_class_init),
2336 (modest_account_mgr_init), (modest_account_mgr_finalize):
2337 As the keys are changed, save them in a GSList* and signal that GSList*
2338 further every X seconds, to batch changes, to allow us to do just one
2339 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2340 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2342 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2343 changed signal signature.
2345 * src/modest-conf.c: (modest_conf_set_list),
2346 (modest_conf_on_change): Reenable notification.
2348 (modest_conf_maemo_fake_on_change): Comment out the hack that
2349 notified immediately instead of asynchronously.
2351 * src/widgets/modest-account-view.h:
2352 * src/widgets/modest-account-view.c:
2353 (update_account_view): Select the previously-selected account ID,
2354 if possible. This fixes projects.maemo.org bug NB#56933.
2356 (on_account_changed), (on_account_removed),
2357 (modest_account_view_select_account):
2359 Remove the block/unblock functions
2360 because they were not useful.
2362 * src/maemo/modest-account-view-window.c:
2363 (on_delete_button_clicked), (on_edit_button_clicked),
2364 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2366 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2368 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2369 Improve the error dialog to show Incorrect Account Settings, which seems
2370 clearer, and say that the internal error message (to be removed from the
2371 dialog later) is often misleading.
2372 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2374 * src/modest-tny-account.c:
2375 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2376 URL because this is so useful for debugging on the device.
2378 * src/widgets/modest-serversecurity-combo-box.c:
2379 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2381 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2383 * src/modest-mail-operation.c:
2384 (modest_mail_operation_send_new_mail):
2385 Added a comment about a nasty but apparently harmless message. Details
2386 added to the wiki g_warnings() page.
2388 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2390 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2391 (modest_tny_send_queue_class_init):
2392 Do not use the priv struct because it is empty, to avoid g_warnings
2393 about a non-existant priv struct.
2395 * src/modest-tny-account-store.c:
2396 (modest_tny_account_store_get_server_account),
2397 (modest_tny_account_store_get_transport_account_for_open_connection
2398 ): Do not try to get transport server accounts for local folders,
2399 because they don't have any. This avoids a g_warning().
2401 * src/maemo/modest-main-window.c:
2402 (modest_main_window_notify_send_receive_initied),
2403 (on_configuration_key_changed):
2404 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2405 * src/modest-defs.h:
2406 * src/modest-mail-operation.c:
2407 (modest_mail_operation_update_account):
2408 * src/modest-tny-account-store.h:
2409 * src/modest-tny-account.c:
2410 (modest_tny_account_get_special_folder),
2411 (modest_tny_account_new_for_local_folders),
2412 (modest_tny_account_new_for_per_account_local_outbox_folder):
2413 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2414 * src/modest-tny-local-folders-account.c:
2415 (add_account_folders_to_merged_folder):
2416 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2417 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2418 (modest_ui_actions_on_send):
2419 * src/widgets/modest-folder-view.c: (update_model):
2420 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2421 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2422 modest_tny_account_store_get_tny_account_by_account() to
2423 modest_tny_account_store_get_server_account() to make the code clearer.
2425 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2427 * src/dbus_api/modest-dbus-api.h:
2428 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2429 * src/maemo/modest-msg-edit-window.c:
2430 (modest_msg_edit_window_attach_file_noninteractive):
2431 added g_warning in case the file to be attached does not exist
2432 * tests/dbus_api/test_compose_mail.c: (main):
2433 removed obsolete comment, added generic files as test case
2435 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2437 * src/modest-tny-account-store.c: (get_server_accounts):
2438 Create the local folders account only once, not once for each outbox, and
2439 not only when there are some outboxes.
2441 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2443 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2444 code that is causing a crash at startup. Sergio says that he is fixing this.
2446 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2448 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2449 * src/maemo/modest-account-settings-dialog.c:
2450 (create_page_outgoing),
2451 (modest_account_settings_dialog_set_account_name),
2452 (save_configuration):
2453 - Fixed handling of the "Use secure authentication" toggle to comply with
2454 the ui specification. See also projects.maemo.org bug NB#58400
2456 - Restore the Secure connection setting combo correctly when loading
2459 * src/maemo/modest-maemo-utils.c:
2460 (on_camel_account_get_supported_secure_authentication),
2461 (modest_maemo_utils_get_supported_secure_authentication_methods):
2462 Fixed a crasher if operation is canceled
2464 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2465 (modest_protocol_info_auth_is_secure):
2466 * src/modest-protocol-info.h:
2468 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2469 the sense of the "Use secure authentication" toggle.
2471 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2473 * src/modest-tny-account-store.h:
2474 * src/modest-tny-account-store.c:
2475 Added modest_tny_account_store_get_local_folders_account().
2477 * src/modest-tny-folder.h:
2478 * src/modest-tny-folder.c:
2479 (modest_tny_folder_get_account):
2480 Added this replacement for tny_folder_get_account() which returns
2481 the local-folders account for TnyMergeFolders, to avoid the
2482 warning about the unimplemented get_account_func() vfunc().
2484 (modest_tny_folder_get_rules),
2485 * src/modest-ui-actions.c:
2486 (modest_ui_actions_on_folder_selection_changed):
2487 * src/modest-mail-operation.c:
2488 (modest_mail_operation_remove_folder),
2489 (modest_mail_operation_xfer_folder),
2490 (modest_mail_operation_rename_folder),
2491 (modest_mail_operation_get_msg),
2492 (modest_mail_operation_get_msgs_full),
2493 (modest_mail_operation_remove_msg),
2494 (modest_mail_operation_xfer_msgs),
2495 (modest_mail_operation_refresh_folder):
2496 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2498 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2500 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2501 (modest_server_account_set_security):
2502 * src/modest-defs.h: Add comments explaining that our
2503 UI spec means TLS when it says Normal, so these do not look like errors.
2505 * src/modest-tny-account.c:
2506 (modest_tny_account_new_from_server_account): Use the new tinymail
2507 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2508 for TLS. This should fix projects.maemo.org bug NB#58460.
2510 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2512 * src/maemo/easysetup/modest-easysetup-wizard.c:
2513 (create_account): Correct the position of the gconf sanity check warning.
2514 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2515 of using the g_idle_add() hack, because this does not seem to be necessary
2516 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2517 caused by something other than maemo's gconf.
2518 This fixes projects.maemo.org bug #59022.
2520 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2522 * src/modest-account-mgr-helpers.c:
2523 (modest_account_mgr_get_default_account): Do not check that the account
2524 exists if there is no default account (NULL), to fix a runtime warning.
2526 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2528 * src/widgets/modest-folder-view.c: (update_model):
2529 Do not unref the treemodel before we have finished with it.
2530 This prevents a valgrind warning and an occasional crash at startup.
2532 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2534 * libmodest-dbus-client/libmodest-dbus-client.h:
2535 added libmodest_dbus_client_compose_mail()
2536 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2538 added functions needed for SendAsMail() functionality
2539 * src/maemo/modest-msg-edit-window.c:
2540 (modest_msg_edit_window_attach_file_noninteractive):
2541 non interactively attaching files to message edit window
2542 * src/widgets/modest-msg-edit-window.h:
2543 * tests/dbus_api/Makefile.am:
2544 added test_compose_mail.c
2545 * tests/dbus_api/test_compose_mail.c: (main):
2547 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2549 * src/modest-account-view.c:
2550 Fixed bug projects.maemo.org bug NB#59307
2552 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2554 * src/maemo/easysetup/modest-easysetup-wizard.c:
2555 (get_serverport_incoming), (on_before_next), (create_account):
2556 * src/maemo/modest-account-settings-dialog.c:
2557 (modest_account_settings_dialog_set_account_name):
2558 * src/maemo/modest-maemo-utils.c:
2559 (on_camel_account_get_supported_secure_authentication_status),
2560 (on_camel_account_get_supported_secure_authentication),
2561 (on_secure_auth_cancel),
2562 (modest_maemo_utils_get_supported_secure_authentication_methods):
2564 Implemented security authentication for settings and easysetup.
2566 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2568 * src/maemo/modest-main-window.c: (create_details_widget):
2569 Show the total size for memory card accounts too, instead of showing
2570 the name again. Fixes bug projects.maemo.org bug NB#59307.
2572 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2575 * src/modest-tny-simple-folder-store.c:
2576 * src/modest-tny-simple-folder-store.h: Removed.
2578 * src/modest-tny-local-folders-account.h
2579 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2580 for the local-folders maildir, with an extra TnyMergedFolder containing
2581 the folders of the per-account outbox store accounts.
2582 * src/modest-tny-account-store.c: (get_server_accounts):
2583 Add the outboxes to the special local folders account after creating it.
2585 * src/modest-tny-account.c:
2586 (modest_tny_account_new_for_local_folders): Create the derived
2587 account when creating the main local-folders account.
2589 * src/maemo/modest-main-window.c: (create_details_widget),
2590 (modest_main_window_set_contents_style):
2591 Adapted to the use of the derived account instead of the folder store.
2593 * src/modest-ui-actions.c:
2594 (modest_ui_actions_on_folder_selection_changed):
2595 * src/modest-ui-dimming-rules.c:
2596 (modest_ui_dimming_rules_on_new_folder):
2597 * src/widgets/modest-folder-view.c: (text_cell_data),
2598 (icon_cell_data), (filter_row), (update_model),
2599 (get_cmp_rows_type_pos):
2602 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2603 Do not get the priv struct, because no priv struct has been set,
2604 to avoid a runtime warning.
2606 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2607 #ifelse with #else, to fix a warning, to fix the build.
2610 2007-06-05 Christian Kellner <ckellner@openismus.com>
2612 * libmodest-dbus-client/libmodest-dbus-client.c:
2613 Fix small typo in doc (why do you always see them
2614 AFTER committing stuff?)
2617 2007-06-05 Christian Kellner <ckellner@openismus.com>
2619 * libmodest-dbus-client/libmodest-dbus-client.c:
2620 (libmodest_dbus_client_search):
2621 Initialize hit list with NULL. Also set folder list
2622 to "" if NULL was supplied.
2625 2007-06-03 Christian Kellner <ckellner@openismus.com>
2627 * libmodest-dbus-client/libmodest-dbus-client.c:
2628 (modest_search_hit_list_free):
2629 Make it save to call it with NULL.
2631 * src/dbus_api/modest-dbus-callbacks.c:
2632 * src/modest-search.c:
2633 Return full ModestSearchHits as the search result list not TnyHeader
2634 since can't be around withouth the correspoding TnyFolder.
2636 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2638 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2639 Added currently commented code to check for secure auth
2641 * src/maemo/modest-account-settings-dialog.c: (on_response),
2642 (save_configuration), (show_ok):
2643 Fixed projects.maemo.org bugs NB #59248 and #59251
2645 * src/maemo/modest-maemo-utils.c:
2646 (on_camel_account_get_supported_secure_authentication_status),
2647 (on_camel_account_get_supported_secure_authentication),
2648 (modest_maemo_utils_get_supported_secure_authentication_methods):
2649 * src/maemo/modest-maemo-utils.h:
2650 Moved get_supported_secure_authentication() method here to be able
2651 to use it from easysetup wizard.
2653 * src/modest-pair.c: (on_pair_compare_as_string):
2654 Should compare string with first part of pair and not
2655 strcmp pairs which will crash.
2657 * src/modest-protocol-info.c:
2658 (modest_protocol_info_protocol_is_store):
2659 * src/modest-protocol-info.h:
2660 Added modest_protocol_info_get_auth_protocol_name()
2662 2007-06-03 Armin Burgmeier <armin@openismus.com>
2664 * src/modest-mail-operation.c:
2665 (modest_mail_operation_get_msgs_full): Set priv->account also when
2666 only retrieving a single message. This avoids a crash when canceling
2669 (modest_mail_operation_notify_end): Do not explicitely remove the
2670 operation from the queue but only emit the progress_changed signal.
2671 The queue itself listens to that signal to remove the operation when
2672 it is finished. This reduces coupling and removes a potential deadlock
2673 when modest_mail_operation_notify_end() is called from the queue
2674 itself. If that is a problem performance-wise, I would suggest to
2675 implement a status-changed signal or something.
2677 * src/modest-mail-operation-queue.c: Make sure to never call a
2678 function from another file while the queue is locked. This (hopefully)
2679 fixes another deadlock when exiting the application while retrieving
2682 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2684 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2685 Fixed build if libogs is not available
2687 2007-06-03 Christian Kellner <ckellner@openismus.com>
2689 * libmodest-dbus-client/libmodest-dbus-client.h:
2690 * libmodest-dbus-client/libmodest-dbus-client.c:
2691 (libmodest_dbus_client_delete_message):
2692 Implement deletion of messages (Client side).
2694 (modest_search_hit_free),
2695 (modest_search_hit_list_free):
2696 Utility functions to free the result hits.
2698 * src/dbus_api/modest-dbus-api.h:
2699 * src/dbus_api/modest-dbus-callbacks.c:
2700 (on_delete_message),
2701 (modest_dbus_req_handler):
2702 Implement deletion of messages (Server side).
2704 * tests/dbus_api/test_search.c: (main):
2707 * tests/dbus_api/Makefile.am:
2708 * tests/dbus_api/test_delete_message:
2709 Add little test for the message deletion logic
2711 2007-06-03 Armin Burgmeier <armin@openismus.com>
2713 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2714 when the operation queue was not empty. projects.maemo.org bug
2717 2007-06-03 Armin Burgmeier <armin@openismus.com>
2719 * src/widgets/modest-account-view.c
2720 (on_account_default_toggled): Toggle default account column
2721 explicitely instead of waiting for gconf notification (which is
2722 currently ignored). This should fix projects.maemo.org bug NB#56910
2723 for now. It should probably be removed when gconf notifications are
2726 2007-06-03 Christian Kellner <ckellner@openismus.com>
2728 * libmodest-dbus-client/libmodest-dbus-client.c:
2729 Removed debugging spew.
2731 * src/dbus_api/modest-dbus-callbacks.c:
2732 Added debugging info.
2734 * src/modest-search.c:
2735 (modest_search_all_accounts):
2736 Use tny_account_store_get_accounts () on the account store
2737 to get all accounts which is the way to get all accounts.
2739 * tests/dbus_api/test_search.c: (main):
2740 Make it possible to supply the search term on the command line.
2742 2007-06-03 Christian Kellner <ckellner@openismus.com>
2744 * libmodest-dbus-client/libmodest-dbus-client.c:
2745 * libmodest-dbus-client/libmodest-dbus-client.h:
2746 Implement searching for mesages over raw dbus. (Client side)
2748 * src/dbus_api/Makefile.am:
2749 * src/dbus_api/modest-dbus-api.h:
2750 * src/dbus_api/modest-dbus-callbacks.c:
2751 * src/dbus_api/modest-dbus-callbacks.h:
2752 Search framework (Server side). Also implement on_idle_open_message().
2754 * src/maemo/modest-platform.c: (modest_platform_init):
2755 Prepare for raw dbus/osso rpc interaction.
2757 * src/modest-search.h:
2758 Changed minsize from unspecific guint to guint32.
2760 * src/modest-search.c:
2762 Added strange hack which magically made tnymail work.
2764 (modest_search_folder),
2765 (modest_search_account),
2766 (modest_search_all_accounts):
2767 Implement helper functions to search all accounts, specific account
2770 * tests/dbus_api/Makefile.am:
2771 * tests/dbus_api/test_open_message.c:
2772 Read url to open from commandline.
2774 * tests/dbus_api/test_search.c:
2775 Implement small test for dbus search stuff
2777 2007-06-02 Armin Burgmeier <armin@openismus.com>
2779 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2780 include account type and account title. This fixes projects.maemo.org
2783 * src/maemo/modest-account-view-window.c: Set a title for the window.
2785 2007-06-02 Armin Burgmeier <armin@openismus.com>
2787 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2788 incoming and outgoing server name based on email address and server
2789 types as long as the names have not been edited manually. This fixes
2790 projects.maemo.org bug NB#58671.
2792 2007-06-02 Armin Burgmeier <armin@openismus.com>
2794 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2795 server type cannot be changed in future to the incoming details page
2796 when creating an account. This fixes projects.maemo.org bug NB#59029.
2798 2007-06-02 Armin Burgmeier <armin@openismus.com>
2800 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2801 and assigned max width chars so that they wrap instead of being
2802 truncated. Fixes projects.maemo.org bug NB#56126.
2804 2007-06-02 Armin Burgmeier <armin@openismus.com>
2806 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2807 introductory note to the connection specific smtp servers dialog, as
2808 section 8.12 of the email UI specification requires. This fixes
2809 projects.maemo.org bug NB#59212.
2811 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2813 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2814 Check for running mail operations, and offer to cancel them, as per the UI
2815 spec. This fixes projects.maemo.org bug NB#59041 .
2816 However, I suspect that tinymail may still use the network connection
2817 in ways that we cannot detect or cancel. But it should at least adapt to
2818 changes fairly well.
2820 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2822 * src/modest-tny-account-store.c: (recreate_all_accounts),
2823 (get_cached_accounts), (get_server_accounts): Do more sensible
2824 ref-counting of the temporarily-cached outbox accounts list. This seems
2825 to fix a crash when entering the password when the password was wrong.
2827 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2829 * src/gnome/modest-main-window.c: (connect_signals):
2830 * src/modest-tny-account-store.c: (get_password),
2831 (modest_tny_account_store_alert): Added comments and clues and
2832 commented-out code about how we currently fail to deal with connection
2833 errors and wrong passwords, and how we should.
2835 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2837 * src/widgets/modest-retrieve-combo-box.c:
2838 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2839 This fixes projects.maemo.org bug NB#58472 .
2841 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2843 * src/maemo/easysetup/modest-easysetup-wizard.c:
2844 (create_page_complete_easysetup):
2845 (create_page_complete_custom): Correct the last commit,
2846 putting the correct sentences in the correct pages.
2848 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2850 * src/maemo/easysetup/modest-easysetup-wizard.c:
2851 (create_page_complete_custom): Show the second sentence of text
2852 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2855 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2857 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2858 Set the leave-on-server conf key by default. This fixes
2859 projects.maemo.org bug NB#59258 .
2861 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2863 * src/maemo/modest-account-view-window.c:
2864 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2865 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2868 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2870 * src/maemo/easysetup/modest-easysetup-wizard.c:
2871 (create_caption_new_with_asterisk):
2872 * src/maemo/modest-account-settings-dialog.c:
2873 (create_caption_new_with_asterisk):
2874 Uncomment the code to add the asterisk, because they are no longer in the
2875 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2876 (update_incoming_server_title): Add an asterisk here too.
2878 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2880 * src/maemo/modest-maemo-global-settings-dialog.c:
2881 (current_connection): Check that we are even connected before trying to
2882 get the current connection name, to prevent a warning.
2884 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2885 Change the comments because tny_maemo_conic_device_connect() is now meant to
2887 * src/modest-mail-operation.c:
2888 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2889 make sure we have a connection and fail if we can't connect.
2891 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2893 * src/maemo/modest-main-window.c:
2894 (on_account_store_connecting_finished): Do not try to get the
2895 connection ID if we are not really connected. I am surprised that
2896 this signal handler is called when we are not connected.
2898 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2900 * src/modest-error.h:
2901 * src/modest-ui-actions.c:
2902 (modest_ui_actions_get_msgs_full_error_handler):
2903 Renamed an enum, added comments, added an enum
2904 for retrieve-limit errors.
2906 * src/modest-mail-operation.c: (foreach_add_item),
2907 (internal_folder_observer_update), (update_account_thread),
2908 (modest_mail_operation_get_msgs_full):
2909 (modest_mail_operation_update_account),
2910 Added comments about how this works, and some code that should
2911 (but does not) check the retrieve-limit. See the TODO comment.
2913 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2915 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2916 Initialize help_id to fix the build. Warnings are good.
2918 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2920 * src/widgets/modest-hbox-cell-renderer.c:
2921 (modest_hbox_cell_renderer_append):
2922 * src/widgets/modest-vbox-cell-renderer.c:
2923 (modest_vbox_cell_renderer_append):
2924 Fix the last commit by doing an extra ref.
2926 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2928 * src/widgets/modest-hbox-cell-renderer.c:
2929 (modest_hbox_cell_renderer_append):
2930 * src/widgets/modest-vbox-cell-renderer.c:
2931 (modest_vbox_cell_renderer_append):
2932 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2933 to fix the build with Maemo Bora.
2934 However, there seems to be a remaining crash, probably due to reference
2937 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2939 * src/modest-tny-account.c:
2940 (modest_tny_account_new_for_local_folders):
2941 Use hildon_file_system_info_async_new() to get a better name for
2942 the memory card account, setting it as the account name.
2943 The timing seems to work, but this is probably
2944 not the best place to do this. See the TODO comment.
2945 * src/maemo/modest-main-window.c: (create_details_widget):
2946 * src/widgets/modest-folder-view.c: (text_cell_data):
2947 Use the tny account name instead of hardcoding a name.
2949 2007-05-30 Christian Kellner <ckellner@openismus.com>
2951 * src/modest-search.c: (modest_search):
2952 Correctly set part_search_func even if we have already parsed
2953 the query and thus a valid OgsTextSearcher object.
2955 2007-05-30 Christian Kellner <ckellner@openismus.com>
2958 Search and check for libogs.
2961 Incooparte the ogs build env.
2963 * src/modest-mime-part-search-stream.c:
2964 * src/modest-mime-part-search-stream.h:
2965 Removed since we do the real searching now in modest-search.c.
2967 * src/modest-search.c:
2968 * src/modest-search.h:
2969 Implement support for ogs. We use that if available and requested
2970 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2971 should now handle the corner case when the search term is spread
2972 across multiple reads.
2973 Also the logic in modest_search () was corrected to search all
2974 requested fields until one is found.
2976 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2978 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2980 * src/modest-init.h:
2981 * src/modest-init.c: Made modest_init_local_folders() take a
2982 path and be public so we can iniitialize maildir folders on
2985 * src/modest-local-folder-info.h:
2986 * src/modest-local-folder-info.c:
2987 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2989 * src/modest-tny-account.c:
2990 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2991 still means the standard local-folders path on the local volume.
2993 * src/modest-tny-account-store.c:
2994 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2995 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2996 all accounts when that happens.
2997 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2998 this too, so it shows up in the treeview.
3000 2007-05-28 Murray Cumming <murrayc@murrayc.com>
3002 * src/maemo/modest-maemo-global-settings-dialog.c:
3003 (current_connection):
3004 * src/widgets/modest-global-settings-dialog.c:
3005 (current_connection_default):
3006 Use the enum values instead of 0, 1 and -1,
3007 to make the code clearer.
3009 * src/modest-account-mgr-helpers.c:
3010 (modest_account_mgr_get_connection_specific_smtp): Make this code
3013 * src/modest-runtime.h:
3014 * src/modest-runtime.c:
3015 Added modest_runtime_remove_all_send_queues().
3016 * src/maemo/modest-main-window.c:
3017 (on_account_store_connecting_finished): Recreate the send queues,
3018 using the appropriate transport accounts for this new connection.
3019 Some futher adapting might be needed if the old send queues are not
3020 automatically stopped at this point.
3022 * src/modest-tny-account-store.c: (get_server_accounts):
3023 Create the connection-specific transport accounts, so that they can
3024 be found later by their ID.
3026 * src/modest-tny-account.h:
3027 * src/modest-tny-account.c:
3028 Added modest_tny_account_new_from_server_account_name().
3029 modest_tny_account_new_from_server_account(): Do not create the
3030 send queues here, because they will be
3031 recreated anyway when the connection changes for the first time.
3033 2007-05-28 Murray Cumming <murrayc@murrayc.com>
3035 * src/modest-local-folder-info.h:
3036 * src/modest-local-folder-info.c:
3037 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3038 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3039 tbox_folder): Take a modest account name instead of a server TnyAccount,
3040 so we can have per-modest-account rather than per-transport-account
3042 We must make sure that we change or recreate the exisitng send queues
3043 when the connection changes for connection-specific transport accounts.
3045 * src/modest-tny-account-store.c:
3046 (create_per_account_local_outbox_folders): Create outboxed per modest
3047 account, not per transport account.
3049 * src/modest-tny-account.h:
3050 * src/modest-tny-account.c:
3051 (modest_tny_account_get_special_folder): For outboxes, get the
3052 parent modest account name. The account is ignored for other folders.
3053 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
3054 modest account name rather than a server TnyAccount.
3056 2007-05-25 Murray Cumming <murrayc@murrayc.com>
3058 * src/modest-tny-account.c:
3059 (modest_tny_account_new_from_server_account):
3060 Call modest_runtime_get_send_queue() immediately after creating transport
3061 accounts, so that they start trying to send email from the outbox as soon
3062 as possible at startup. This is probably what we want.
3064 * src/modest-mail-operation.c: (update_account_thread):
3065 * src/modest-runtime.c: (modest_runtime_get_send_queue):
3066 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
3067 * src/modest-tny-send-queue.h:
3068 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
3069 (modest_ui_actions_on_send):
3070 Added comments about how sending works, though it needs some more work.
3072 2007-05-25 Murray Cumming <murrayc@murrayc.com>
3074 * src/modest-tny-account.c:
3075 (modest_tny_account_get_special_folder): Add TODO because this fails when
3076 the network is busy.
3077 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
3078 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
3079 Do not try to show this window when there is no active account. The UI
3080 specs does not tell us what to do in this case.
3082 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3086 * src/maemo/Makefile.am:
3087 * src/widgets/Makefile.am: Some dist fixes.
3089 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3091 * src/maemo/modest-connection-specific-smtp-window.c:
3092 (on_button_edit): Make the code clearer, to prevent a double free.
3094 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3096 * src/maemo/modest-account-settings-dialog.c:
3097 (modest_account_settings_dialog_set_account_name),
3098 Check the connection-specific smtp servers checkbox if there are any.
3100 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3101 (modest_connection_specific_smtp_edit_window_init):
3102 Start with a suitable port number.
3104 * src/modest-account-mgr-helpers.h:
3105 * src/modest-account-mgr-helpers.c: Added
3106 modest_account_mgr_get_has_connection_specific_smtp().
3108 (modest_account_mgr_set_connection_specific_smtp),
3109 (modest_account_mgr_remove_connection_specific_smtp),
3110 (modest_account_mgr_get_has_connection_specific_smtp),
3111 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
3112 connection-specific smtp server accounts in the account, rather than
3113 the server account conf dir.
3115 This fixes bug projects.maemo.org bug NB#58263 .
3117 * src/modest-tny-account-store.c:
3118 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
3119 if there are no server accounts yet, to prevent an infinite loop when there
3120 are no accounts. Document that one must be called before the other.
3122 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3124 * src/modest-account-mgr-helpers.c:
3125 (modest_account_mgr_get_default_account): Make sure that at least
3126 one account is always the default, if there are any enabled accounts.
3127 This is just a sanity check that shouldn't be necessary.
3129 * src/modest-account-mgr-priv.c:
3130 (_modest_account_mgr_account_from_key): Unescape the conf key to
3131 get the real account name. For instance, this is an issue if a space
3132 was in the account name, which can happen because the account name
3133 is generated from the display name.
3134 (_modest_account_mgr_get_account_keyname): Always escape the
3136 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
3137 Unescape the conf keys to get the real account names.
3139 For instance, previously the is-default radio button in the accounts
3140 list was not checked for any accounts at first. This fixes that,
3141 and might fix several similar bugs.
3143 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3145 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
3146 Removed some debug printfs.
3148 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3150 Modest on-disk outbox directories are now here, for instance:
3151 $HOME/.modest/outboxes/<account-id-1>/outbox
3152 $HOME/.modest/outboxes/<account-id-2>/outbox
3154 $HOME/.modest/local-folders/outbox
3155 so we can have a separate outbox for each account.
3156 But they are shown as one outbox in the GtkTreeView, by using a
3157 TnyMergeFolder in a ModestTnySimpleFolderStore.
3160 * src/modest-tny-simple-folder-store.c:
3161 * src/modest-tny-simple-folder-store.h:
3162 Added ModestTnySimpleFolderStore, used to contain folders from
3163 other folder stores, such as other accounts.
3165 * src/modest-tny-outbox-account.h:
3166 * src/modest-tny-outbox-account.c:
3167 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
3168 used for the per-account local outbox folders.
3170 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3171 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3172 only use this (internally) now for the non-outbox local folders.
3174 * src/modest-init.h:
3175 * src/modest-init.c: Added modest_init_one_local_folder(), for
3176 setting up the directory structure for each local folder.
3178 * src/modest-local-folder-info.c:
3179 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3180 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3182 * src/modest-local-folder-info.h:
3183 * src/modest-tny-account-store.c: (on_account_removed),
3184 (on_account_changed), (create_per_account_local_outbox_folders),
3185 (get_server_accounts), (modest_tny_account_store_get_accounts),
3186 (modest_tny_account_store_get_tny_account_by_account),
3187 (modest_tny_folder_store_is_virtual_local_folders):
3189 * src/modest-tny-account.h:
3190 * src/modest-tny-account.c:
3191 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3192 to create an on-disk per-account local outbox folder for each
3194 (create_per_account_local_outbox_folders): Create a local outbox folder
3195 for each transport account.
3196 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3197 for all local folders.
3199 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3200 instead of using g_object_get/set() directly. It is clearer.
3202 (modest_tny_folder_store_get_message_count),
3203 (modest_tny_folder_store_get_local_size
3204 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3205 because we now use these with non-acount folder stores.
3207 (modest_tny_account_get_special_folder),
3208 (modest_tny_account_new_from_server_account),
3209 (modest_tny_account_new_from_account):
3210 (recurse_folders): Adjust to the new outbox system.
3212 * src/modest-tny-folder.h:
3213 * src/modest-tny-folder.c:
3214 (modest_tny_folder_is_local_folder),
3215 (modest_tny_folder_get_local_folder_type),
3216 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3218 * src/widgets/modest-main-window.h:
3219 * src/maemo/modest-main-window.c: (create_details_widget),
3220 (modest_main_window_set_contents_style): Show details for any folder store,
3223 (modest_tny_folder_get_rules):
3224 Remove the const. C does not support constness enough for this.
3226 * src/modest-ui-actions.c:
3227 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3228 make all outboxes appear as one, in the usual local-folders tree node.
3230 (set_active_account_from_tny_account),
3231 (modest_ui_actions_on_folder_selection_changed):
3232 * src/widgets/modest-folder-view.c: (text_cell_data),
3233 (icon_cell_data), (filter_row),
3234 (add_account_folders_to_merged_folder),
3235 (add_account_folders_to_simple_folder_store), (),
3236 (get_cmp_rows_type_pos), (cmp_rows),
3237 (modest_folder_view_set_account_id_of_visible_server_account):
3238 Adjust to the new outbox system, using generic folder stores and folders
3239 in the GtkTreeModel.
3241 2007-05-23 Christian Kellner <ckellner@openismus.com>
3243 * src/modest-mail-operation.c:
3244 (modest_mail_operation_update_account):
3245 Use info->max_size instead of unintialized local var [small
3246 build fix]. (Added TODO to review that change since I don't
3249 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3251 * libmodest-dbus-client/libmodest-dbus-client.c:
3252 (libmodest_dbus_client_compose_mail): function added
3253 * src/dbus_api/modest-dbus-api.h:
3254 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3255 (on_compose_mail): Implementation of the SendAsMail functionality
3257 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3259 * src/modest-account-mgr.c:
3260 (modest_account_mgr_add_server_account): Set the secure-connection
3261 conf key for transport accounts as well as store accounts. I don't know
3262 why the if was there. For instance, this makes sure that we use SSL
3263 for the gmail preset from the easysetup wizard.
3265 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3267 * src/gnome/modest-main-window.c:
3268 (on_account_store_connecting_finished), (connect_signals):
3269 * src/maemo/modest-main-window.c:
3270 (on_account_store_connecting_finished), (connect_signals),
3271 (modest_main_window_new):
3272 Handle TnyAccountStore::connecting-finished instead of
3273 TnyDevice::connection-changed, because we cannot actually perform
3274 operations on accounts until TnyAccountStore has itself responded to
3275 the TnyDevice::connection-changed signal. This prevents a GError from
3277 Do not try to update at startup, because we (at least on scratchbox)
3278 already do an update at startup when the device goes online.
3279 This prevents a GError from tinymail.
3280 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3281 Added TODO about stopping simultaneous operations.
3283 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3285 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3286 * src/modest-mail-operation-queue.c:
3287 (modest_mail_operation_queue_remove):
3288 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3289 about where they happened.
3291 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3293 * src/modest-ui-actions.c:
3294 (modest_ui_actions_on_password_requested): Make sure that the remember
3295 output parameter is always TRUE.
3297 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3299 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3300 Show a OK/Cancel dialog if the error is a question, though we still do not
3301 know anything more about what we are asking the user.
3302 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3303 Fix an uninitialized variable (helper). This is a logic error, however.
3305 2007-05-21 Christian Kellner <ckellner@openismus.com>
3307 * src/modest-search.h:
3308 Correct bit shifting in the ModestSearchFlags enum.
3310 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3312 * src/modest-tny-account.c:
3313 (modest_tny_account_new_from_server_account): Do not use the lsub and
3314 check-all hard-coded IMAP options when using POP.
3316 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3318 * src/modest-tny-account.c:
3319 (modest_tny_account_new_from_server_account):
3320 Use NULL for the secure-auth method for POP when Password auth has been
3321 specified by the user, as we already do for IMAP. "auth=Login" causes
3322 an error from camel or the server.
3324 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3326 * src/maemo/modest-account-settings-dialog.c:
3327 (create_page_account_details),
3328 (modest_account_settings_dialog_set_account_name):
3329 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3330 for the leave-on-server checkbox, rathr than just the checkbox, when
3331 the protocol is not POP.
3333 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3335 * src/widgets/modest-account-view.c:
3336 * src/widgets/modest-account-view.h:
3337 Added modest_account_view_select_account() which will be useful later
3338 to asynchronously re-select the edited account.
3340 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3342 * src/maemo/modest-account-settings-dialog.c:
3343 (modest_account_settings_dialog_set_account_name):
3344 Automatically choose the port numbers based on the secure authentication
3345 methods, if they have not been chosen before.
3346 This fixes projects.maemo.org bug NB#56273 .
3348 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3350 * src/maemo/modest-main-window-ui.h:
3351 * src/modest-ui-actions.c:
3352 * src/modest-ui-actions.h:
3353 Connect the Tools/SMTP Servers menu item to
3354 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3355 SMTP servers dialog, as in the UI specification and saves changes when it
3356 is closed. This fixed projects.maemo.org bug NB#56305 .
3358 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3360 * src/maemo/modest-connection-specific-smtp-window.c:
3361 (modest_connection_specific_smtp_window_init):
3362 Use gtk_window_set_default_size() to make this window big enough, so
3363 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3365 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3367 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3368 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3369 (modest_connection_specific_smtp_edit_window_init),
3370 Do not try to connect to a combobox signal before the combobox exists.
3371 This fixes the cras in projects.maemo.org bug NB#56288 .
3372 (modest_connection_specific_smtp_edit_window_get_settings):
3373 Remove the server_account_name parameter which was being checked for NULL
3374 though it was not used.
3376 * src/maemo/modest-connection-specific-smtp-window.c:
3377 (modest_connection_specific_smtp_window_fill_with_connections),
3378 (on_button_edit), (modest_connection_specific_smtp_window_init):
3379 Correct the number of treemodel columns to prevent a warning.
3380 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3381 libconic does not work.
3383 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3385 * src/modest-tny-account.c:
3386 (modest_tny_account_new_from_server_account):
3387 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3388 SMTP when "None" was chosen by the user. However, with my SMTP server that
3389 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3392 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3394 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3395 to explain the memory management issue with the ID in the ModestPair.
3397 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3398 (add_sending_page), (modest_account_assistant_finalize):
3399 * src/gnome/modest-gnome-global-settings-dialog.c:
3400 (create_updating_page), (create_composing_page):
3401 * src/gnome/modest-msg-edit-window.c: (get_transports),
3402 (init_window), (modest_msg_edit_window_finalize),
3403 (modest_msg_edit_window_get_msg_data):
3404 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3405 * src/gnome/modest-transport-widget.c:
3406 (modest_transport_widget_finalize), (smtp_configuration):
3407 * src/maemo/modest-maemo-global-settings-dialog.c:
3408 (create_updating_page), (create_composing_page):
3409 * src/maemo/modest-msg-edit-window.c: (get_transports),
3410 (init_window), (modest_msg_edit_window_finalize),
3411 (modest_msg_edit_window_get_msg_data),
3412 (modest_msg_edit_window_free_msg_data):
3413 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3414 (modest_store_widget_finalize):
3415 * src/maemo/modest-transport-widget.c:
3416 (modest_transport_widget_finalize), (smtp_configuration):
3417 * src/modest-main.c: (send_mail):
3418 * src/widgets/modest-combo-box.h:
3419 * src/widgets/modest-global-settings-dialog-priv.h:
3420 * src/widgets/modest-global-settings-dialog.c:
3421 (modest_global_settings_dialog_finalize):
3422 * src/widgets/modest-msg-edit-window.h:
3423 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3424 as long as the combo box, to prevent use of freed memory for the ID.
3426 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3428 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3429 get_accounts(), to make this clearer. Do not check for the enabled gconf
3430 key, because we do not use this for server accounts (at least, not yet).
3431 This allows us to send email again.
3433 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3435 * src/maemo/modest-platform.c:
3436 (on_modest_conf_update_interval_changed), (modest_platform_init):
3437 Only respond to this particular key change. All these strcmp()s cannot be
3440 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3442 * src/maemo/modest-maemo-global-settings-dialog.c:
3443 (current_connection): Prevent a crash in scratchbox when
3444 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3445 * src/maemo/modest-platform.c:
3446 (on_modest_conf_update_interval_changed), (modest_platform_init):
3447 Get the update interval from gconf and reset it when the gconf key changes.
3449 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3451 * src/modest-protocol-info.c:
3452 * src/modest-protocol-info.h: Adde enum-specific get functions,
3453 instead of using a ModestProtocolType enum parameter.
3455 * src/gnome/modest-account-assistant.c:
3456 * src/gnome/modest-store-widget.c:
3457 * src/gnome/modest-store-widget.h:
3458 * src/gnome/modest-transport-widget.c:
3459 * src/gnome/modest-transport-widget.h:
3460 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3461 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3462 * src/maemo/easysetup/modest-easysetup-wizard.c:
3463 * src/maemo/modest-account-settings-dialog.c:
3464 * src/maemo/modest-account-settings-dialog.h:
3465 * src/maemo/modest-store-widget.c:
3466 * src/maemo/modest-store-widget.h:
3467 * src/maemo/modest-transport-widget.c:
3468 * src/maemo/modest-transport-widget.h:
3469 * src/modest-account-mgr-helpers.c:
3470 * src/modest-account-mgr-helpers.h:
3471 * src/modest-account-mgr.c:
3472 * src/modest-account-mgr.h:
3473 * src/modest-tny-account.c:
3474 * src/modest-tny-folder.c:
3475 * src/widgets/modest-account-view.c:
3476 * src/widgets/modest-retrieve-combo-box.c:
3477 * src/widgets/modest-retrieve-combo-box.h:
3478 * src/widgets/modest-secureauth-combo-box.c:
3479 * src/widgets/modest-serversecurity-combo-box.c:
3480 * src/widgets/modest-serversecurity-combo-box.h:
3481 * tests/check_account-mgr.c:
3482 Use the specific functions, and use the re-renamed enum values for GNOME too.
3484 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3486 * src/modest-pair.h:
3487 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3488 so we can get the second based on the first.
3490 * src/maemo/modest-account-settings-dialog.h:
3491 * src/maemo/modest-account-settings-dialog.c:
3492 Added get_supported_secure_authentication_methods(), though it is mostly
3493 commented-out for now until the necessary API is committed to tinymail.
3494 (modest_account_settings_dialog_set_account_name),
3495 (save_configuration): Request the supported authentication methods from the
3496 server, so we can choose a working method.
3498 * src/modest-tny-account-store.h:
3499 * src/modest-tny-account-store.c:
3500 (modest_tny_account_store_get_session): Rename from
3501 tny_account_store_get_session().
3503 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3505 * src/modest-protocol-info.h: Split the ModestProtocol enum
3506 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3507 There was no need to have these unrelated values in one enum.
3509 * src/: many files: Adapted to changed enum. This makes the code a bit
3510 clearer, and the compiler could catch some errors.
3512 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3514 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3515 Show the detailed internal camel error message when an error happens
3516 during the configuration, so that our testers can give us more clues.
3517 For instance, in projects.maemo.org bug NB#56910 .
3519 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3521 * src/modest-tny-account.c:
3522 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3523 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3525 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3527 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3528 * src/maemo/modest-account-settings-dialog.c:
3529 (modest_account_settings_dialog_set_account_name),
3530 (save_configuration): For the incoming secure authentication checkbox,
3531 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3532 the UI specification. PLAIN does not seem to be supported for most IMAP
3533 servers anyway, and I am not sure what it would mean.
3534 However, we probably need to discover which of the secure-authentication
3535 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3536 * src/modest-account-mgr-helpers.c:
3537 (modest_account_mgr_get_server_account_data):
3539 * src/modest-tny-account.c:
3540 (modest_tny_account_new_from_server_account):
3541 Use tny_account_set_mech() to set secure-authentication methods,
3542 with some special-casing for IMAP, based on my observations of how
3545 * src/modest-account-mgr-helpers.h:
3546 * src/modest-account-mgr.c:
3547 * src/modest-defs.h: Comment that the URI is only used for local folders.
3549 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3551 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3552 parameter const, just to be neat.
3553 * src/modest-text-utils.c: (modest_text_utils_inline):
3554 End g_strconcat() with NULL, as its documentation says. This is almost
3555 certainly the cause of my crash at startup on the device. Interestingly,
3556 valgrind doesn't tell us about these errors.
3558 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3560 * scripts/build-packages: Added more precise comments about how to use
3561 this script, though I still get this error:
3562 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3563 error building tinymail
3565 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3567 * src/maemo/modest-main-window.c: (on_account_update):
3568 Very slight cleanup, hoping to make it simpler to discover what causes
3569 a crash here sometimes.
3571 * src/modest-tny-account.c:
3572 (modest_tny_account_new_from_server_account): Set the port. Added
3573 comments about the options and a TODO comment because I need to find out
3574 how to specify the secure authentication method.
3576 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3578 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3579 changed CFlags paths form modest to libmodest
3581 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3583 * src/modest-account-mgr-helpers.c:
3584 (modest_account_mgr_get_server_account_data),
3585 (modest_account_mgr_free_server_account_data):
3586 * src/modest-account-mgr-helpers.h:
3587 * src/modest-account-mgr.c:
3588 (modest_account_mgr_add_server_account):
3589 * src/modest-defs.h:
3590 * src/modest-tny-account.c:
3591 (modest_tny_account_new_from_server_account):
3592 Determine the options for tny_camel_account_add_option() here,
3593 based on the settings, rather than storing them directly in gconf.
3595 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3597 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3598 Show a more friendly error dialog now that we expect (from the tinymail
3599 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3601 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3603 * src/maemo/modest-main-window.c: (on_account_update): Check that
3604 account_name is not NULL, to prevent a crash at startup that I am
3605 seeing on the N800. I do wonder why it is NULL.
3607 * src/maemo/easysetup/modest-easysetup-wizard.c:
3608 (create_page_user_details):
3609 * src/maemo/modest-account-settings-dialog.c:
3610 (create_page_user_details), (create_page_outgoing):
3611 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3612 (modest_connection_specific_smtp_edit_window_init):
3613 * src/modest-ui-actions.c:
3614 (modest_ui_actions_on_password_requested):
3615 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3616 might do something useful with the on-screen keyboard.
3618 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3620 * src/maemo/modest-main-window.c: (on_account_update):
3621 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3622 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3624 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3626 * src/modest-tny-account-store.c: (on_account_changed):
3627 Correct the signature of this signal handler.
3629 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3631 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3632 Show a HildonNote instead of a GtkDialog for Maemo.
3634 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3636 * src/widgets/modest-account-view.h:
3637 * src/widgets/modest-account-view.c: (on_account_changed),
3638 (on_account_removed). Added a boolean flag, set/unset by
3639 modest_account_view_block_conf_updates(),
3640 modest_account_view_unblock_conf_updates() to prevent unnecessary
3641 updates, but this is not very useful because the gconf notifications are
3642 so delays (maybe only on Maemo Bora).
3643 So auto-updating is turned off, and these functions do an explicit
3644 update when necessary.
3645 However, something else is still doing too much work when adding/removing
3646 accounts, probably in another part of the application.
3648 * src/maemo/modest-account-view-window.c:
3649 (on_delete_button_clicked), (on_edit_button_clicked),
3650 (on_new_button_clicked): Use the new functions.
3652 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3654 * src/modest-account-mgr-helpers.c:
3655 (modest_account_mgr_set_first_account_as_default):
3656 Sort the list of names alphabetically-by-title, so we choose the first one
3658 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3659 alphabetically by the title.
3661 This fixes projects.maemo.org bug NB#56418 .
3663 * src/modest-account-mgr-priv.c:
3664 (_modest_account_mgr_account_from_key):
3665 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3666 avoid a valgrind error, and possible random behaviour.
3668 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3670 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3671 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3672 tinymail documentation to say that this can be expected.
3673 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3674 pretty, and should not happen, but I would prefer to know when it does.
3676 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3678 * configure.ac: When using the older hildon version, probably on Bora,
3679 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3681 * src/widgets/modest-attachment-view.c:
3682 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3685 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3687 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3688 Implemented the prototype. Can be tested with
3689 tests/dbus_api/test_open_message:
3691 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3693 * src/modest-tny-account-store.c:
3694 (modest_tny_account_store_instance_init), (get_password):
3695 * src/modest-ui-actions.c:
3696 (modest_ui_actions_on_password_requested):
3697 Do not store the password in gconf, because this function is called
3698 for non-remembered passwords. Actually use the cached (in the hash map)
3699 password instead of releasing it.
3700 The password will now not be remembered if it is asked via the protected
3701 password dialog, as per the UI spec.
3703 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3705 * src/modest-defs.h:
3706 * src/modest-account-mgr-helpers.h:
3707 * src/modest-account-mgr-helpers.c:
3708 Added modest_server_account_get_username_has_succeeded(),
3709 modest_server_account_set_username_has_succeeded().
3710 (modest_server_account_set_username),
3711 Reset the has-succeeded flag if the username changes.
3713 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3714 * src/maemo/modest-connection-specific-smtp-window.c:
3715 (modest_connection_specific_smtp_window_save_server_accounts):
3716 Use modest_server_account_set_username() instead of using
3717 modest_conf_set_string() directly, so that the has-succeeded flag is always
3720 * src/modest-ui-actions.c:
3721 (modest_ui_actions_on_password_requested): Dim the username entry if
3722 the username has ever worked, as per the UI spec.
3724 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3726 * src/modest-tny-account-store.c: (get_password):
3727 * src/modest-ui-actions.c:
3728 (modest_ui_actions_on_password_requested):
3729 Allow the username to be changed too, though there is more work to
3730 be done on exactly how this behaves.
3732 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3734 * src/modest-account-mgr-helpers.h:
3735 * src/modest-account-mgr-helpers.c:
3736 Added modest_account_mgr_get_display_name(),
3737 modest_server_account_get_username(),
3738 modest_server_account_set_username(),
3739 modest_server_account_set_password(),
3740 modest_server_account_get_hostname() functions so we do not need to
3741 use the conf API directly.
3743 * src/maemo/modest-main-window.c: (connect_signals):
3744 Actually connect ot the ModestAccountStore::request-password signal,
3745 so that we show the dialog when the password is requested by Tinymail,
3746 for isntance if it is empty.
3748 * src/modest-marshal.list:
3749 * src/modest-tny-account-store.c:
3750 (modest_tny_account_store_class_init), (get_password),
3751 (modest_tny_account_store_alert):
3752 * src/modest-tny-account-store.h:
3753 * src/modest-ui-actions.h:
3754 * src/modest-ui-actions.c:
3755 (modest_ui_actions_on_password_requested):
3756 Change the signal parameters, so it is obvious that we are providing
3757 the non human-readable server name, and receiving both the username
3758 and password, though changing of the username is not yet implemented.
3759 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3760 for the GNOME version.
3762 This should fix the projects.maemo.org bug NB#56209, though it does not
3763 work on Bora, because the gconf_client_get() for the password fails
3764 immediately after we save it with gconf_client_set().
3766 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3769 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3770 caused an undefined symbol error:
3771 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3773 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3775 * src/modest-tny-account-store.c:
3776 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3777 using a GError instead of a string message, so we can translate it in
3780 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3782 * src/maemo/modest-address-book.c:
3783 (modest_address_book_check_names):
3784 * src/maemo/modest-msg-view-window.c:
3785 (modest_msg_view_window_clipboard_owner_change):
3786 * src/modest-init.c: (modest_init_init_ui):
3787 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3788 (update_folders_cb), (modest_mail_operation_update_account):
3789 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3790 (modest_ui_actions_on_msg_attachment_clicked),
3791 (modest_ui_actions_on_msg_recpt_activated):
3792 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3793 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3794 (modest_msg_view_search_next):
3795 * src/widgets/modest-recpt-editor.c:
3796 (modest_recpt_editor_on_button_release_event),
3797 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3798 g_message(). At this point we should only be seeing interesting errors on
3799 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3801 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3803 (modest_wizard_dialog_force_title_update):
3804 * src/maemo/easysetup/modest-wizard-dialog.h:
3805 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3806 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3807 can update the title when appropriate. Otherwise the title is wrong if the
3808 pages are added after adding the notebook to the dialog.
3809 This must be a problem in HildonWizardDialog too.
3810 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3812 * src/maemo/easysetup/modest-easysetup-wizard.c:
3813 (create_subsequent_customsetup_pages),
3814 (create_subsequent_easysetup_pages):
3815 Call modest_wizard_dialog_force_title_update() so that the title is
3816 correct even with GTK+ < 2.10.
3817 This fixes projects.maemo.org bug NB#56145 .
3819 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3821 * src/maemo/modest-platform.c:
3822 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3823 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3826 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3828 * src/widgets/modest-window.h:
3829 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3830 and modest_window_save_state(), which invokes it.
3832 * src/widgets/modest-window-mgr.h:
3833 * src/widgets/modest-window-mgr.c:
3834 Added modest_window_mgr_save_state_for_all_windows(), which calls
3835 the save_state vfunc on all registered windows, if implemented.
3837 * src/gnome/modest-msg-edit-window.c:
3838 * src/gnome/modest-msg-view-window.c:
3839 * src/maemo/modest-msg-edit-window.c:
3840 * src/maemo/modest-msg-view-window.c:
3841 * src/maemo/modest-main-window.c:
3842 Specify the existing save_settings functions as implementations of
3843 ModestWindow::save_state_func().
3845 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3846 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3847 enabling hibernation, for instance.
3849 We may need to do the same thing for restoring settings.
3852 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3854 * src/widgets/modest-window-mgr.c:
3855 * src/widgets/modest-window-mgr.h:
3856 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3857 modest_window_mgr_get_hibernation_is_prevented().
3859 * src/maemo/modest-main-window.c:
3860 (on_hildon_program_is_topmost_notify): Prevent hibernation
3861 (possible when the application goes to the background in the WM),
3862 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3864 * src/maemo/easysetup/modest-easysetup-wizard.c:
3865 (modest_easysetup_wizard_dialog_init):
3866 * src/maemo/modest-account-settings-dialog.c:
3867 (modest_account_settings_dialog_init):
3868 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3869 (modest_connection_specific_smtp_edit_window_init):
3870 * src/maemo/modest-connection-specific-smtp-window.c:
3871 (modest_connection_specific_smtp_window_init):
3872 * src/maemo/modest-signature-editor-dialog.c:
3873 (modest_signature_editor_dialog_init):
3874 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3875 prevent hibernation while any of these account settings dialogs are open.
3877 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3879 * src/maemo/Makefile.am:
3880 * src/maemo/modest-osso-state-saving.c:
3881 * src/maemo/modest-osso-state-saving.h: Added
3882 modest_osso_load_state() and modest_osso_save_state() though they do
3883 nothing now. They should iterate through all the open windows and load/save
3885 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3886 save state when closing.
3888 * src/maemo/modest-main-window.c:
3889 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3890 Add a notification handler for the HildonProgram::is-topmost property,
3891 so we can allow hibernation when the application goes into the background.
3892 But we still need to detect when the accounts setup windows are open so
3893 we can stop hibernation when they are open.
3894 To do this, I also added the main window the HildonProgram. This might have
3895 other side-effects/benefits, and should maybe be done for other windows.
3897 * src/maemo/modest-osso-autosave-callbacks.h:
3898 * src/maemo/modest-osso-autosave-callbacks.c:
3899 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3900 though it does not do anything yet, and we might never need this to do
3901 anything. For instance, we already save drafts.
3903 * src/maemo/modest-platform.c: (modest_platform_init):
3904 Specify the libosso auto-save callback.
3906 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3908 * src/maemo/modest-platform.c:
3909 (modest_platform_set_update_interval):
3910 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3911 aparently stays valid between application instances, so we can use this
3912 to remove and reset it later. According to a maemo-developers email from
3915 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3917 * configure.ac: Depend on libalarm for Maemo.
3919 * src/dbus_api/modest-dbus-api.h:
3920 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3921 (on_send_receive), (modest_dbus_req_handler):
3922 Handle a SEND_RECEIVE D-Bus method.
3924 * libmodest-dbus-client/libmodest-dbus-client.c:
3925 (libmodest_dbus_client_send_and_receive):
3926 * libmodest-dbus-client/libmodest-dbus-client.h:
3927 Add C convenience functions for calling the new D-Bus method.
3929 * src/modest-platform.h:
3930 * src/gnome/modest-platform.c:
3931 * src/maemo/modest-platform.c:
3932 Added modest_platform_set_update_interval(), which uses the
3933 alarmd API on Maemo.
3934 (modest_platform_init),
3935 Call modest_platform_set_update_interval(), using a hard-coded
3936 interval for now (until the global settings dialog is implemented),
3937 though I am not sure that this makes sense yet.
3939 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3941 * src/dbus_api/modest-dbus-callbacks.c:
3942 (modest_osso_cb_hw_state_handler):
3943 * src/dbus_api/modest-dbus-callbacks.h:
3944 * src/maemo/modest-platform.c: (modest_platform_init):
3945 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3946 in case this has some effect on the ability for Maemo to ping the
3949 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3951 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3952 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3953 warning. It is probably a logic error, but I need to fix the build.
3955 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3957 * src/modest-account-mgr.h:
3958 * src/modest-account-mgr.c:
3959 (modest_account_mgr_account_names): Add a gboolean enabled_only
3960 parameter, so we can get lists of onlt the enabled accounts.
3962 (modest_account_mgr_add_account),,
3963 (modest_account_mgr_account_with_display_name_exists):
3964 * src/maemo/modest-msg-edit-window.c: (get_transports):
3965 * src/modest-account-mgr-helpers.c:
3966 (modest_account_mgr_set_first_account_as_default):
3967 * src/modest-init.c: (init_default_account_maybe):
3968 * src/modest-tny-account-store.c: (get_accounts):
3969 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3970 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3971 * tests/check_account-mgr.c: (START_TEST):
3972 Provide the extra parameter, as appropriate.
3974 * src/widgets/modest-account-view.c: (update_account_view):
3975 Do not show disabled accounts (meaning that there is no way to
3976 enable/disable accounts in the UI (the feature is not in our UI
3977 specification), so we can use this internally only to mark unfinished
3978 or temporary account data.
3980 * src/maemo/easysetup/modest-easysetup-wizard.c:
3981 (create_account): Add boolean enable parameter, so we can specify FALSE
3982 to create the temporary account.
3983 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3984 (on_before_next): When finishing, when there is a temporary account, just
3986 Also, use a timeout to delay the showing of the dialog until gconf is likely
3987 to return correct information, due to a maemo gconf bug that is fixed in
3988 osso 1.1, but not yet in Bora.
3989 However, the dialog stays on screen after it is destroyed.
3991 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3992 for invalid data when cancelling. Use a hildon note instead of a dialog
3993 to complain about invalid data. Do not show the account-saved note if the
3994 account is disabled (a temporary account that will not really be saved for use
3997 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3999 * src/modest-account-mgr-helpers.h:
4000 * src/modest-account-mgr-helpers.c:
4001 Added modest_account_mgr_unset_default_account(),
4002 Added modest_account_mgr_set_first_account_as_default().
4004 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
4005 If it was the default account, unset the default account name.
4007 * src/maemo/modest-account-view-window.c:
4008 (on_delete_button_clicked): If it was the default account,
4009 set the first remaining account as the default instead.
4011 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
4012 a NULL account or a NULL default account, to prevent a crash. This should
4013 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
4016 2007-04-30 Murray Cumming <murrayc@murrayc.com>
4018 * src/widgets/modest-recpt-editor.c:
4019 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
4020 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
4021 TODO comment for this. This fixes the build.
4023 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
4024 be the best place for it. This will in future update all auto-update accounts,
4025 rather than just the current/default account, when that gconf key exists.
4026 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
4027 if there are no accounts, before calling do_send_receive().
4028 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
4030 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
4031 * src/maemo/modest-main-window-ui.h:
4032 * src/maemo/modest-main-window.c: (on_connection_changed),
4033 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
4034 directly, becaue the signal handler does more.
4036 2007-04-30 Murray Cumming <murrayc@murrayc.com>
4038 * src/modest-account-mgr-helpers.c:
4039 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
4040 for the case that the account does not exist.
4042 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
4043 (equivalent to the modest account name) rather than the tinymail account name
4044 (equivalent to the modest account title - human readable) to get the account data.
4045 Check for null account data to prevent the crash, and add a TODO comment saying that
4046 this needs fixing because it is using the server account name instead of the account name.
4048 2007-04-29 Murray Cumming <murrayc@murrayc.com>
4050 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
4051 * src/maemo/modest-account-settings-dialog.c: (show_error),
4053 Use hildon_note_new_information() for informative and error messages,
4054 which seems to be expected for Maemo applications (no documentation that I know of
4055 says this). I am surprised that there is no distinction between info and error
4058 2007-04-29 Murray Cumming <murrayc@murrayc.com>
4060 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
4061 it is easy to find where this is used.
4063 * src/maemo/easysetup/modest-easysetup-wizard.c:
4064 (create_page_welcome), (create_page_account_details),
4065 (create_page_user_details), (create_page_complete_easysetup),
4066 (create_page_custom_incoming), (create_page_custom_outgoing),
4067 (create_page_complete_custom):
4068 * src/maemo/modest-account-settings-dialog.c:
4069 (create_page_account_details), (create_page_user_details),
4070 (create_page_incoming), (create_page_outgoing):
4071 * src/maemo/modest-account-view-window.c: (window_vbox_new):
4072 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4073 (modest_connection_specific_smtp_edit_window_init):
4074 * src/maemo/modest-connection-specific-smtp-window.c:
4075 (modest_connection_specific_smtp_window_init):
4076 * src/maemo/modest-signature-editor-dialog.c:
4077 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
4078 and scrolling policy as per the Email Application Layout Guide, if I have
4081 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4083 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
4084 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
4085 which were empty, because these vfuncs have been removed from TnyAccountStore.
4086 This fixes the build.
4088 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4090 * src/maemo/modest-main-window.c:
4091 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
4092 showing/hiding it. Added TODO because it probably should not be NULL.
4093 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
4094 because unnecessary g_warnings() make degugging difficult.
4096 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4098 * src/maemo/modest-msg-edit-window.c:
4099 (modest_msg_edit_window_select_color),
4100 (modest_msg_edit_window_select_background_color): 2 const corrections and
4101 moving 2 #endifs before closing brackets, to fix the build.
4103 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4105 * src/maemo/easysetup/modest-easysetup-wizard.h:
4106 * src/maemo/easysetup/modest-easysetup-wizard.c:
4107 (modest_easysetup_wizard_dialog_finalize),
4108 (on_button_edit_advanced_settings), (create_page_complete_custom),
4109 (on_response), (create_account):
4110 Implement the Advanced Settings edit button, by saving the account information,
4111 for the Advanded Settings dialog to use directly from gconf, and removing it
4112 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
4113 Bug #5533 in the projects.maemo.org bugzilla.
4115 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4117 * src/maemo/modest-msg-view-window.c:
4118 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
4119 when opening a message window.
4121 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4123 * src/maemo/easysetup/modest-easysetup-wizard.c:
4124 (create_page_custom_outgoing): Correct the position of the horizontal separator to
4127 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
4128 before showing/hiding them, to avoid a crash when clicking on folders when there are no
4129 gconf settings. I probably added more checks than necessary, but that is safer.
4131 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
4132 variable to fix the build, but this seems to be used when it is still NULL.
4134 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4136 * src/modest-platform.h:
4137 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
4138 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
4139 * src/modest-main.c: Implement this function so we can avoid using
4140 maemo-specific API from cross-platform code.
4142 * src/modest-tny-account-store.c:
4143 (get_smtp_specific_transport_account_for_open_connection):
4144 * src/modest-ui-actions.c: (check_for_connection),
4145 (modest_ui_actions_on_item_not_found):
4146 Use modest_platform_connect_and_wait() and put #idefs around other
4147 maemo-specific code, because only maemo currently has a way to
4148 identify connection names.
4150 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4152 * src/modest-tny-account-store.h:
4153 * src/modest-tny-account-store.c:
4154 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
4155 the connection-specific SMTP server settings in the configuration.
4157 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
4159 * src/maemo/modest-main-window.c: (on_connection_changed),
4161 * src/modest-main.c: (main), (start_ui), (send_mail):
4162 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
4163 that is what is intended.
4165 * src/modest-ui-actions.c: (action_send), (action_receive),
4166 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
4167 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
4168 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4169 SMTP server is used when it is specified.
4171 (modest_ui_actions_on_send_receive):
4172 Check that a connection is open before proceeding.
4173 Receive and then send, instead of vice-versa, as per the specification.
4175 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4177 * src/modest-mail-operation.c:
4178 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4179 though I guess it should be something other than NULL.
4181 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4183 * src/maemo/easysetup/modest-easysetup-wizard.c:
4184 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4185 combo twice, to avoid an g_warning and to make it visible again.
4186 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4187 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4188 (already intended) dereference when detaching, because we then recreate the menu.
4189 But I am not sure why the warning was happening, and it is possible that this is a memory
4192 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4194 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4195 and uri_parse_mailto() utility functions.
4196 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4198 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4200 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4202 * src/dbus_api/modest-dbus-api.h:
4203 * src/dbus_api/modest-dbus-callbacks.c:
4204 Use an idle callback to execute the modest code in the application's own thread.
4205 Remove the helloworld example method.
4206 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4207 parsed, and the open-message method is not implemented because this is not yet implemented in
4209 * libmodest-dbus-client/libmodest-dbus-client.c:
4210 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4211 (libmodest_dbus_client_open_message):
4212 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4214 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4215 body without crashing.
4217 * tests/dbus_api/Makefile.am:
4218 * tests/dbus_api/test_mail_to.c:
4219 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4221 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4223 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4224 Added file to fix the build. Sorry.
4226 * src/dbus_api/Makefile.am:
4227 * src/dbus_api/modest-dbus-api.h:
4228 * src/dbus_api/modest-dbus-callbacks.h:
4229 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4230 (modest_dbus_req_handler):
4231 Put constants in a separate header so it can be reused by the
4232 client library, without duplication
4234 * libmodest-dbus-client/Makefile.am:
4235 * libmodest-dbus-client/libmodest-dbus-client.c:
4236 (libmodest_dbus_client_call_helloworld),
4237 (libmodfest_dbus_client_send_mail),
4238 (libmodfest_dbus_client_mailto),
4239 (libmodfest_dbus_client_open_message):
4240 * libmodest-dbus-client/libmodest-dbus-client.h:
4241 (Partly) Implement a send_mail D-Bus method.
4243 * tests/dbus_api/Makefile.am:
4244 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4245 the send_email D-Bus method.
4247 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4251 * libmodest-dbus-client/Makefile.am:
4252 * libmodest-dbus-client/libmodest-dbus-client.c:
4253 * libmodest-dbus-client/libmodest-dbus-client.h:
4254 * tests/dbus_api/Makefile.am:
4255 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4256 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4258 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4260 * src/maemo/easysetup/modest-easysetup-wizard.c:
4261 (create_page_account_details):
4262 * src/maemo/modest-account-settings-dialog.c:
4263 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4264 widgets, because this might not be the default in future versions of the Maemo GTK+.
4265 However, I can not not get capitalization to work even in a simple test case.
4267 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4269 * src/maemo/easysetup/modest-easysetup-wizard.c:
4270 (create_page_custom_incoming), (create_page_custom_outgoing):
4271 * src/maemo/modest-account-settings-dialog.c:
4272 (create_page_account_details), (create_page_incoming),
4273 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4274 instead of using gtk_check_button_with_label(), so they are aligned like the other
4275 widgets, as per the UI spec.
4277 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4279 * src/maemo/easysetup/modest-easysetup-wizard.c:
4280 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4281 * src/widgets/modest-validating-entry.c:
4282 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4283 Modest prefix instead of an EasySetup prefix.
4285 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4287 * src/widgets/modest-validating-entry.h:
4288 * src/widgets/modest-validating-entry.c: (on_insert_text),
4289 Added easysetup_validating_entry_set_max_func(), used to set a callback
4290 to call when the max number of characters is reached. GtkEntry has a max-length
4291 already but is silent about it.
4293 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4294 (create_page_account_details), (create_page_user_details),
4296 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4297 (create_page_account_details), (create_page_user_details),
4298 (create_page_outgoing):
4299 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4300 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4301 the UI spec, when the user tries to enter more than the max number of characters.
4303 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4305 * src/maemo/easysetup/modest-easysetup-wizard.c:
4306 (create_page_user_details), (create_page_custom_incoming),
4307 (create_page_custom_outgoing):
4308 * src/maemo/modest-account-settings-dialog.c:
4309 (create_page_user_details), (create_page_incoming),
4310 (create_page_outgoing):
4311 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4312 (modest_connection_specific_smtp_edit_window_init):
4313 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4314 not appropriate. Bad Maemo-specific defaults!.
4316 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4318 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4319 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4320 (modest_signature_editor_dialog_set_settings):
4321 Disable the label and textview when the checkbox is disabled, and use the
4322 specified (UI spec) default signature text.
4324 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4326 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4327 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4329 * src/modest-defs.h:
4330 * src/modest-account-mgr-helpers.h:
4331 * src/modest-account-mgr-helpers.c:
4332 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4334 * src/maemo/Makefile.am:
4335 * src/maemo/modest-signature-editor-dialog.c:
4336 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4339 * src/maemo/modest-account-settings-dialog.h:
4340 * src/maemo/modest-account-settings-dialog.c:
4341 (modest_account_settings_dialog_finalize), (on_button_signature),
4342 (save_configuration): Use the new dialog when the Edit button is pressed, and
4343 save the changes if necessary, as per the UI spec.
4345 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4347 * src/maemo/Makefile.am:
4348 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4349 based on maemo-develoers email from Dirk.
4351 * src/maemo/easysetup/modest-easysetup-wizard.c:
4352 (create_page_welcome), (create_page_account_details),
4353 (create_page_user_details), (create_page_complete_easysetup),
4354 (create_page_custom_incoming), (create_page_custom_outgoing),
4355 (create_page_complete_custom),
4356 (modest_easysetup_wizard_dialog_init):
4357 * src/maemo/modest-account-settings-dialog.c:
4358 (create_page_account_details), (create_page_user_details),
4359 (create_page_incoming), (create_page_outgoing),
4360 (modest_account_settings_dialog_init):
4361 * src/maemo/modest-connection-specific-smtp-window.c:
4362 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4364 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4366 * src/maemo/easysetup/modest-easysetup-wizard.c:
4367 (create_page_account_details), (create_page_custom_outgoing),
4368 (create_page_complete_custom):
4369 * src/maemo/modest-account-settings-dialog.c:
4370 (create_page_user_details), (create_page_incoming),
4371 (create_page_outgoing):
4372 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4373 (modest_connection_specific_smtp_edit_window_init):
4374 Use the correct (UI spec) port min/max, and use horizontal separators,
4377 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4379 * src/maemo/easysetup/modest-easysetup-wizard.c:
4380 (set_default_custom_servernames):
4381 * src/maemo/modest-account-settings-dialog.c:
4382 (create_page_incoming), (on_combo_outgoing_security_changed),
4383 (on_combo_incoming_security_changed), (create_page_outgoing),
4384 (modest_account_settings_dialog_set_account_name),
4385 (save_configuration):
4386 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4387 (on_combo_security_changed),
4388 (modest_connection_specific_smtp_edit_window_init),
4389 (modest_connection_specific_smtp_edit_window_set_connection),
4390 (modest_connection_specific_smtp_edit_window_get_settings):
4391 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4394 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4397 * src/maemo/easysetup/modest-easysetup-wizard.c:
4398 (create_page_custom_outgoing), (create_page_complete_custom):
4399 * src/maemo/modest-account-settings-dialog.c:
4400 (create_page_user_details), (create_page_outgoing):
4401 * src/maemo/modest-account-view-window.c: (button_box_new):
4402 Use changed logical IDs as per the most recent UI spec:
4403 mcen_bd_emailsetup_edit -> mcen_bd_edit
4404 mcen_bd_emailsetup_delete -> mcen_bd_delete
4405 mcen_bd_emailsetup_close -> mcen_bd_close
4407 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4411 * src/dbus_api/Makefile.am:
4412 * src/dbus_api/modest-dbus-callbacks.c:
4413 * src/dbus_api/modest-dbus-callbacks.h:
4414 * src/maemo/modest-platform.c: (modest_platform_init):
4415 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4417 * tests/Makefile.am:
4418 * tests/dbus_api/Makefile.am:
4419 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4421 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4423 * src/maemo/modest-account-settings-dialog.c:
4424 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4425 Removed unnecessary includes.
4427 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4429 * src/maemo/easysetup/modest-easysetup-wizard.c:
4430 * src/maemo/modest-account-settings-dialog.c:
4431 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4432 * src/widgets/Makefile.am:
4433 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4434 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4435 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4436 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4437 * src/widgets/modest-secureauth-combo-box.c:
4438 * src/widgets/modest-secureauth-combo-box.h:
4439 * src/widgets/modest-serversecurity-combo-box.c:
4440 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4441 made the GObject names more consistent with the rest of the Modest code.
4443 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4445 * src/maemo/easysetup/Makefile.am:
4446 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4447 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4448 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4449 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4450 * src/maemo/easysetup/modest-easysetup-wizard.c:
4451 * src/maemo/easysetup/modest-validating-entry.c:
4452 * src/maemo/easysetup/modest-validating-entry.h:
4453 * src/maemo/modest-account-settings-dialog.c:
4454 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4455 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4456 widgets/ because they are used outside of easysetup too. After checking in,
4457 svn will allow me to rename them too.
4459 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4461 * src/gnome/modest-msg-edit-window.c:
4462 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4463 linker error, to fix the build on the GNOME platform.
4464 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4465 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4466 ifdefed out to avoid a warning.
4468 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4470 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4471 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4472 some alternative for GTK+ 2.6.
4474 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4476 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4478 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4479 specified for EmailAccountsDialog in UI spec.
4481 * src/maemo/easysetup/modest-easysetup-wizard.c:
4482 * src/maemo/easysetup/modest-easysetup-wizard.h:
4483 * src/maemo/modest-account-settings-dialog.c:
4484 * src/maemo/modest-account-settings-dialog.h:
4485 Reuse a member window widget for the connection-specific SMTP server accounts,
4486 so we can tell it to create/save the accounts only if we actually save changes.
4488 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4489 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4490 (modest_connection_specific_smtp_edit_window_get_settings):
4491 Return a struct instance for temporarily remembering the entered data.
4493 * src/maemo/modest-connection-specific-smtp-window.h:
4494 * src/maemo/modest-connection-specific-smtp-window.c:
4495 (modest_connection_specific_smtp_window_finalize),
4496 (modest_connection_specific_smtp_window_fill_with_connections),
4498 (modest_connection_specific_smtp_window_save_server_accounts),
4499 (update_model_server_names): Do not actually save data until asked,
4500 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4502 (on_selection_changed),
4503 (modest_connection_specific_smtp_window_init): Disable the edit
4504 button when nothing is selected.
4506 * src/modest-account-mgr-helpers.c:
4507 * src/modest-account-mgr-helpers.h:
4508 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4511 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4513 * src/modest-account-mgr-helpers.h:
4514 * src/modest-account-mgr-helpers.c:
4515 (modest_account_mgr_get_unused_account_name),
4516 (modest_account_mgr_get_unused_account_display_name): Added these
4517 utility functions, to avoid code duplication.
4519 * src/maemo/easysetup/modest-easysetup-wizard.c:
4520 (create_page_account_details), (create_account):
4521 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4522 (on_combo_security_changed),
4523 (modest_connection_specific_smtp_edit_window_init),
4524 (modest_connection_specific_smtp_edit_window_save_settings):
4525 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4526 * src/maemo/modest-connection-specific-smtp-window.c:
4527 (modest_connection_specific_smtp_window_finalize),
4528 (modest_connection_specific_smtp_window_fill_with_connections),
4529 (on_button_edit), (modest_connection_specific_smtp_window_init):
4530 * src/maemo/modest-connection-specific-smtp-window.h:
4531 Implementing saving of connection-specific server accounts.
4533 But I need to refactor this so we can save the data for each
4534 possible connection-specific account and only actually create the server accounts
4535 when the easysetup finished, or the OK button is pressed on the account settings
4538 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4540 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4541 (on_combo_security_changed):
4542 (modest_connection_specific_smtp_edit_window_init):
4543 Auto-fill the port number as in the account settings.
4545 (modest_connection_specific_smtp_edit_window_set_connection):
4546 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4547 * src/maemo/modest-connection-specific-smtp-window.c:
4548 (fill_with_connections), (on_button_edit),
4549 (modest_connection_specific_smtp_window_init):
4550 Turn the edit window into a dialog to simplify the code, and
4551 set a WM hint as in a GtkDialog, because only a popup can be on top of
4552 another window in Maemo, and popups usually have no WM decoration.
4554 * src/modest-defs.h:
4555 * src/modest-account-mgr-helpers.c:
4556 (modest_account_mgr_set_connection_specific_smtp),
4557 (modest_account_mgr_remove_connection_specific_smtp),
4558 (modest_account_mgr_get_connection_specific_smtp):
4559 * src/modest-account-mgr-helpers.h: Some functions to write the
4560 connection-specific SMTP server information. Not yet used.
4563 * src/widgets/modest-folder-view.c: (text_cell_data):
4564 Fix a warning about an uninitialized variable.
4565 (on_configuration_key_changed): Put an #ifdef around the use
4566 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4568 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4570 * src/maemo/modest-account-settings-dialog.h:
4571 * src/maemo/modest-account-settings-dialog.c:
4572 Added connect_for_modified() utility function to mark the new modified boolean.
4574 (create_page_account_details), (create_page_user_details),
4575 (create_page_incoming), (create_page_outgoing), (on_response),
4576 (modest_account_settings_dialog_init),
4577 (modest_account_settings_dialog_set_account_name):
4578 Only warn about unsaved changes when there are actually unsaved changes.
4580 * src/modest-account-mgr-helpers.c:
4581 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4582 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4583 to get the data from there in future.
4585 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4587 * src/modest-defs.h:
4589 * src/modest-account-mgr-helpers.h:
4590 * src/modest-account-mgr-helpers.c:
4591 Store the security account setting in a single conf key instead of using
4592 the options list, so that the list is left for just the to-be-removed camel hack,
4593 and because gconf_client_set_list() is failing for some reason.
4595 * src/modest-account-mgr.c:
4596 (modest_account_mgr_add_server_account):
4597 * src/maemo/modest-account-settings-dialog.c:
4598 (modest_account_settings_dialog_set_account_name),
4599 (save_configuration): Use the renamed functions.
4602 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4604 * src/widgets/Makefile.am:
4605 * src/widgets/modest-limit-retrieve-combo-box.c:
4606 * src/widgets/modest-limit-retrieve-combo-box.h:
4607 * src/widgets/modest-retrieve-combo-box.c:
4608 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4609 the account settings dialog.
4611 * src/modest-defs.h:
4612 * src/modest-account-mgr-helpers.h:
4613 * src/modest-account-mgr-helpers.c:
4614 (modest_server_account_get_option_secure_auth),
4615 (modest_server_account_set_option_secure_auth):
4616 * src/modest-account-mgr.c:
4617 (modest_account_mgr_add_server_account):
4618 Use the existing AUTH_MECH conf key for the secure-auth setting,
4619 instead of putting it in the list options, because this was actually used already.
4621 * src/maemo/modest-account-settings-dialog.c:
4622 (create_page_account_details),
4623 (modest_account_settings_dialog_set_account_name),
4624 (save_configuration):
4625 * src/maemo/modest-account-settings-dialog.h:
4626 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4627 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4629 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4631 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4632 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4633 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4635 * src/modest-defs.h:
4636 * src/maemo/modest-account-settings-dialog.c:
4637 (create_page_incoming), (on_combo_outgoing_security_changed),
4638 (on_combo_incoming_security_changed), (create_page_outgoing),
4639 (modest_account_settings_dialog_set_account_name),
4640 (save_configuration): Load/Save the port number, and change it when the
4641 security combo changes, to suitable defaults.
4643 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4645 * src/modest-account-mgr.c:
4646 (modest_account_mgr_add_server_account): Set the security and secure-auth
4647 options, and add a comment saying that the other camel-specific options should be
4650 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4652 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4654 * src/modest-tny-account-store.c: (account_list_free),
4655 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4656 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4659 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4661 * src/modest-protocol-info.c:
4662 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4663 is required by our UI spec. Maybe something in our implementation will use this eventually.
4664 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4665 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4666 instead of the previous 0 placeholder.
4668 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4669 secure-auth settings.
4670 * src/modest-account-mgr-helpers.h:
4671 * src/modest-account-mgr-helpers.c:
4672 (modest_server_account_data_get_option_secure_auth),
4673 (modest_server_account_set_option_secure_auth),
4674 (modest_server_account_data_get_option_security),
4675 (modest_server_account_set_option_security): Added this API for getting and setting the security
4676 and secure-auth settings.
4678 * src/maemo/modest-account-settings-dialog.h:
4679 * src/maemo/modest-account-settings-dialog.c:
4680 (modest_account_settings_dialog_finalize), (check_data),
4681 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4682 about changing titles.
4683 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4684 (save_configuration): Save the security and secure-auth settings.
4686 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4687 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4689 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4691 * src/modest-defs.h:
4692 * src/modest-account-mgr.c:
4693 (modest_account_mgr_add_server_account):
4694 Added and used defines for the options key and value pair strings,
4695 that are used so far, though they do not seem to correspond to anything in our
4696 UI specs or ModestProtocol enum.
4698 * src/modest-account-mgr-helpers.h:
4699 * src/modest-account-mgr-helpers.c:
4700 (compare_option_strings_for_name),
4701 (modest_server_account_data_get_option_value),
4702 (modest_server_account_data_get_option_bool),
4703 (modest_account_mgr_get_server_account_option):
4704 Added helper functions for parsing the options GSList.
4706 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4708 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4709 display name is based on the supplied account name.
4710 * src/modest-account-mgr.c:
4711 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4712 with an inefficient, but good-enough, implementation.
4714 * src/maemo/easysetup/modest-easysetup-wizard.c:
4715 (create_page_account_details), (on_before_next), (create_account):
4716 Check for existing display names rather than (non-user-visible) account names, and just
4717 create and set a unique account name at the end.
4719 * src/maemo/modest-account-settings-dialog.c:
4720 (modest_account_settings_dialog_init),
4721 (modest_account_settings_dialog_set_account_name),
4722 (create_page_incoming): Show the display name, instead of the account name.
4723 (on_response): Do some (not all) extra checks, as in the UI spec.
4724 (save_configuration): Save the display name if it was changed.
4726 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4728 * po/en_GB.po: Added needed logical ID and translation.
4729 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4730 (init_view): Made the is-default column clicking work.
4732 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4735 * src/maemo/easysetup/Makefile.am:
4736 * src/maemo/easysetup/modest-easysetup-wizard.c:
4737 (modest_easysetup_wizard_dialog_init):
4738 * src/maemo/easysetup/provider-data-test.keyfile:
4739 * src/maemo/easysetup/provider-data.keyfile:
4740 Moved the provider data file to the new modest-providers-data package and used it from there.
4742 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4744 * src/modest-local-folder-info.c:
4745 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4746 N_() was already used on the static strings, but this just marks it for translation without
4747 using the translation.
4749 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4751 * src/maemo/modest-account-settings-dialog.c:
4752 (create_page_incoming),
4753 (modest_account_settings_dialog_set_account_name):
4754 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4755 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4756 I will do this if nobody else gets there first.
4758 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4760 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4761 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4762 save the security stuff.
4764 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4766 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4767 Set the email address and user fullname, which I now see must be
4770 * src/maemo/modest-account-settings-dialog.h:
4771 * src/maemo/modest-account-settings-dialog.c:
4773 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4774 leave-on-server and authentication.
4775 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4778 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4781 * src/maemo/modest-account-settings-dialog.c:
4782 * src/maemo/modest-account-settings-dialog.h:
4783 Most (but not all) of the widgets are now present as specified by the UI spec.
4784 No changes are yet saved, and some details are not properly shown yet.
4786 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4788 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4790 * src/maemo/Makefile.am:
4791 * src/maemo/modest-account-settings-dialog.c:
4792 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4793 an existing account. Doesn't do much yet.
4795 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4796 Open the accounts settings dialog when Edit is clicked.
4798 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4800 * src/maemo/easysetup/Makefile.am:
4801 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4803 * src/maemo/easysetup/modest-easysetup-wizard.c:
4804 (modest_easysetup_wizard_dialog_init):
4805 Try to get the source directory from the build system,
4806 instead of hard-coding "./" into the source code, when opening our local
4807 copies of the configuration files.
4808 But this still fails when opening the wizard from the Accounts window,
4809 maybe because the working directory seems to change at runtime.
4810 So the wizard will fail the second time unless you copy the files into their
4811 proper locations - see the stdout warnings for the paths.
4813 (create_page_account_details),(on_before_next):
4814 Check for existing non-server accounts instead of server accounts,
4815 so the default account name is useful again, and to prevent trying to
4818 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4819 Show the wizard when New is clicked.
4821 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4822 (init_view): Show the column headers, and show the columns that are
4823 specified in the UI specs. However, something in Maemo's GTK+ prevents
4824 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4825 change the default account. This is despite unsetting the special properties.
4827 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4829 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4830 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4831 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4832 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4833 to make that clearer.
4834 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4836 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4838 * src/maemo/modest-account-view-window.c:
4839 (modest_account_view_window_init),
4840 (modest_account_view_window_new):
4841 Use the same buttons as specified in the
4842 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4843 the existing widgets, which never had a chance of working.
4844 Put the ModestAccountView treeview in a scrolled window.
4845 Do not repeat the initialization in both _init() and _new().
4847 * src/widgets/modest-account-view.c: (update_account_view):
4848 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4849 this widget and window shows no accounts.
4851 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4853 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4855 * src/maemo/easysetup/modest-easysetup-wizard.c:
4856 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4857 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4858 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4861 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4862 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4863 accounts exist yet, as in the UI spec.
4865 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4867 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4869 * src/maemo/Makefile.am:
4870 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4871 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4872 New window for editing connection-specific smtp details.
4873 Not fully implemented.
4875 * src/maemo/modest-connection-specific-smtp-window.c:
4876 (modest_connection_specific_smtp_window_finalize) :
4877 unref the tree model.
4878 (on_button_edit): Show the edit window.
4880 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4882 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4885 * src/maemo/Makefile.am:
4886 * src/maemo/modest-connection-specific-smtp-window.c:
4887 * src/maemo/modest-connection-specific-smtp-window.h:
4888 New window for showing the list of connections, for connection-specific
4889 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4890 * src/maemo/easysetup/modest-easysetup-wizard.c:
4891 (create_page_custom_outgoing): Show the new window when the button is clicked.
4893 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4895 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4896 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4897 * src/maemo/modest-msg-edit-window.c:
4898 (modest_msg_edit_window_insert_image):
4899 * src/modest-conf.c: (modest_conf_key_escape):
4900 * src/modest-mail-operation.c:
4901 (modest_mail_operation_send_new_mail):
4902 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4903 (modest_ui_actions_on_new_account):
4904 * src/widgets/modest-attachment-view.c: (update_filename_request):
4905 * src/widgets/modest-mail-header-view.c:
4906 Corrected warnings that were breaking the build, by commenting out unused variables,
4907 and a function, and by including a header.
4909 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4911 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4912 so we can #ifdef around platform-specific code when necessary.
4913 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4914 to allow this to build for the GNOME platform too.
4916 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4918 * src/maemo/easysetup/modest-easysetup-wizard.c:
4919 Added util_increment_name() and used it in create_page_account_details()
4920 to make sure that the default account name is always a new name.
4922 (modest_easysetup_wizard_dialog_init),
4923 (set_default_custom_servernames): Some minor memory management fixes.
4925 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4929 * src/modest-runtime.c: (init_i18n): Restored the translation
4930 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4931 are defined in config.h, and the translations are installed.
4933 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4934 is defined for translation.
4936 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4938 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4940 * src/maemo/easysetup/modest-easysetup-wizard.c:
4941 (modest_easysetup_wizard_dialog_init):
4942 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4943 Use realistic paths (though they should use $prefix generically) to the
4944 mcc_mapping and provider-data.keyfile files which might work when they
4945 are installed by the future version of the operator-wizard package,
4946 and then fallback to paths in our source code, with an explanatory
4949 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4953 * src/maemo/Makefile.am:
4954 * src/maemo/easysetup/: Added files from the previously-exernal
4955 osso-modest-easysetup.
4956 * src/maemo/modest-main-window-ui.h:
4957 * src/modest-ui-actions.c:
4958 * src/modest-ui-actions.h:
4959 Added modest_ui_actions_on_new_account() as a signal handler for the
4960 New Account menu item. It shows the easysetup wizard.
4961 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob