1 2007-06-03 Armin Burgmeier <armin@openismus.com>
3 * src/modest-mail-operation.c:
4 (modest_mail_operation_get_msgs_full): Set priv->account also when
5 only retrieving a single message. This avoids a crash when canceling
8 (modest_mail_operation_notify_end): Do not explicitely remove the
9 operation from the queue but only emit the progress_changed signal.
10 The queue itself listens to that signal to remove the operation when
11 it is finished. This reduces coupling and removes a potential deadlock
12 when modest_mail_operation_notify_end() is called from the queue
13 itself. If that is a problem performance-wise, I would suggest to
14 implement a status-changed signal or something.
16 * src/modest-mail-operation-queue.c: Make sure to never call a
17 function from another file while the queue is locked. This (hopefully)
18 fixes another deadlock when exiting the application while retrieving
21 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
23 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
24 Fixed build if libogs is not available
26 2007-06-03 Christian Kellner <ckellner@openismus.com>
28 * libmodest-dbus-client/libmodest-dbus-client.h:
29 * libmodest-dbus-client/libmodest-dbus-client.c:
30 (libmodest_dbus_client_delete_message):
31 Implement deletion of messages (Client side).
33 (modest_search_hit_free),
34 (modest_search_hit_list_free):
35 Utility functions to free the result hits.
37 * src/dbus_api/modest-dbus-api.h:
38 * src/dbus_api/modest-dbus-callbacks.c:
40 (modest_dbus_req_handler):
41 Implement deletion of messages (Server side).
43 * tests/dbus_api/test_search.c: (main):
46 * tests/dbus_api/Makefile.am:
47 * tests/dbus_api/test_delete_message:
48 Add little test for the message deletion logic
50 2007-06-03 Armin Burgmeier <armin@openismus.com>
52 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
53 when the operation queue was not empty. projects.maemo.org bug
56 2007-06-03 Armin Burgmeier <armin@openismus.com>
58 * src/widgets/modest-account-view.c
59 (on_account_default_toggled): Toggle default account column
60 explicitely instead of waiting for gconf notification (which is
61 currently ignored). This should fix projects.maemo.org bug NB#56910
62 for now. It should probably be removed when gconf notifications are
65 2007-06-03 Christian Kellner <ckellner@openismus.com>
67 * libmodest-dbus-client/libmodest-dbus-client.c:
68 Removed debugging spew.
70 * src/dbus_api/modest-dbus-callbacks.c:
73 * src/modest-search.c:
74 (modest_search_all_accounts):
75 Use tny_account_store_get_accounts () on the account store
76 to get all accounts which is the way to get all accounts.
78 * tests/dbus_api/test_search.c: (main):
79 Make it possible to supply the search term on the command line.
81 2007-06-03 Christian Kellner <ckellner@openismus.com>
83 * libmodest-dbus-client/libmodest-dbus-client.c:
84 * libmodest-dbus-client/libmodest-dbus-client.h:
85 Implement searching for mesages over raw dbus. (Client side)
87 * src/dbus_api/Makefile.am:
88 * src/dbus_api/modest-dbus-api.h:
89 * src/dbus_api/modest-dbus-callbacks.c:
90 * src/dbus_api/modest-dbus-callbacks.h:
91 Search framework (Server side). Also implement on_idle_open_message().
93 * src/maemo/modest-platform.c: (modest_platform_init):
94 Prepare for raw dbus/osso rpc interaction.
96 * src/modest-search.h:
97 Changed minsize from unspecific guint to guint32.
99 * src/modest-search.c:
101 Added strange hack which magically made tnymail work.
103 (modest_search_folder),
104 (modest_search_account),
105 (modest_search_all_accounts):
106 Implement helper functions to search all accounts, specific account
109 * tests/dbus_api/Makefile.am:
110 * tests/dbus_api/test_open_message.c:
111 Read url to open from commandline.
113 * tests/dbus_api/test_search.c:
114 Implement small test for dbus search stuff
116 2007-06-02 Armin Burgmeier <armin@openismus.com>
118 * src/maemo/modest-account-settings-dialog.c: Changed window title to
119 include account type and account title. This fixes projects.maemo.org
122 * src/maemo/modest-account-view-window.c: Set a title for the window.
124 2007-06-02 Armin Burgmeier <armin@openismus.com>
126 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
127 incoming and outgoing server name based on email address and server
128 types as long as the names have not been edited manually. This fixes
129 projects.maemo.org bug NB#58671.
131 2007-06-02 Armin Burgmeier <armin@openismus.com>
133 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
134 server type cannot be changed in future to the incoming details page
135 when creating an account. This fixes projects.maemo.org bug NB#59029.
137 2007-06-02 Armin Burgmeier <armin@openismus.com>
139 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
140 and assigned max width chars so that they wrap instead of being
141 truncated. Fixes projects.maemo.org bug NB#56126.
143 2007-06-02 Armin Burgmeier <armin@openismus.com>
145 * src/maemo/modest-connection-specific-smtp-window.c: Add an
146 introductory note to the connection specific smtp servers dialog, as
147 section 8.12 of the email UI specification requires. This fixes
148 projects.maemo.org bug NB#59212.
150 2007-06-01 Murray Cumming <murrayc@murrayc.com>
152 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
153 Check for running mail operations, and offer to cancel them, as per the UI
154 spec. This fixes projects.maemo.org bug NB#59041 .
155 However, I suspect that tinymail may still use the network connection
156 in ways that we cannot detect or cancel. But it should at least adapt to
159 2007-06-01 Murray Cumming <murrayc@murrayc.com>
161 * src/modest-tny-account-store.c: (recreate_all_accounts),
162 (get_cached_accounts), (get_server_accounts): Do more sensible
163 ref-counting of the temporarily-cached outbox accounts list. This seems
164 to fix a crash when entering the password when the password was wrong.
166 2007-06-01 Murray Cumming <murrayc@murrayc.com>
168 * src/gnome/modest-main-window.c: (connect_signals):
169 * src/modest-tny-account-store.c: (get_password),
170 (modest_tny_account_store_alert): Added comments and clues and
171 commented-out code about how we currently fail to deal with connection
172 errors and wrong passwords, and how we should.
174 2007-06-01 Murray Cumming <murrayc@murrayc.com>
176 * src/widgets/modest-retrieve-combo-box.c:
177 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
178 This fixes projects.maemo.org bug NB#58472 .
180 2007-06-01 Murray Cumming <murrayc@murrayc.com>
182 * src/maemo/easysetup/modest-easysetup-wizard.c:
183 (create_page_complete_easysetup):
184 (create_page_complete_custom): Correct the last commit,
185 putting the correct sentences in the correct pages.
187 2007-06-01 Murray Cumming <murrayc@murrayc.com>
189 * src/maemo/easysetup/modest-easysetup-wizard.c:
190 (create_page_complete_custom): Show the second sentence of text
191 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
194 2007-06-01 Murray Cumming <murrayc@murrayc.com>
196 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
197 Set the leave-on-server conf key by default. This fixes
198 projects.maemo.org bug NB#59258 .
200 2007-06-01 Murray Cumming <murrayc@murrayc.com>
202 * src/maemo/modest-account-view-window.c:
203 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
204 logical ID for the confirmation messages. Fixed projects.maemo.org bug
207 2007-06-01 Murray Cumming <murrayc@murrayc.com>
209 * src/maemo/easysetup/modest-easysetup-wizard.c:
210 (create_caption_new_with_asterisk):
211 * src/maemo/modest-account-settings-dialog.c:
212 (create_caption_new_with_asterisk):
213 Uncomment the code to add the asterisk, because they are no longer in the
214 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
215 (update_incoming_server_title): Add an asterisk here too.
217 2007-06-01 Murray Cumming <murrayc@murrayc.com>
219 * src/maemo/modest-maemo-global-settings-dialog.c:
220 (current_connection): Check that we are even connected before trying to
221 get the current connection name, to prevent a warning.
223 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
224 Change the comments because tny_maemo_conic_device_connect() is now meant to
226 * src/modest-mail-operation.c:
227 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
228 make sure we have a connection and fail if we can't connect.
230 2007-05-31 Murray Cumming <murrayc@murrayc.com>
232 * src/maemo/modest-main-window.c:
233 (on_account_store_connecting_finished): Do not try to get the
234 connection ID if we are not really connected. I am surprised that
235 this signal handler is called when we are not connected.
237 2007-05-31 Murray Cumming <murrayc@murrayc.com>
239 * src/modest-error.h:
240 * src/modest-ui-actions.c:
241 (modest_ui_actions_get_msgs_full_error_handler):
242 Renamed an enum, added comments, added an enum
243 for retrieve-limit errors.
245 * src/modest-mail-operation.c: (foreach_add_item),
246 (internal_folder_observer_update), (update_account_thread),
247 (modest_mail_operation_get_msgs_full):
248 (modest_mail_operation_update_account),
249 Added comments about how this works, and some code that should
250 (but does not) check the retrieve-limit. See the TODO comment.
252 2007-05-31 Murray Cumming <murrayc@murrayc.com>
254 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
255 Initialize help_id to fix the build. Warnings are good.
257 2007-05-31 Murray Cumming <murrayc@murrayc.com>
259 * src/widgets/modest-hbox-cell-renderer.c:
260 (modest_hbox_cell_renderer_append):
261 * src/widgets/modest-vbox-cell-renderer.c:
262 (modest_vbox_cell_renderer_append):
263 Fix the last commit by doing an extra ref.
265 2007-05-31 Murray Cumming <murrayc@murrayc.com>
267 * src/widgets/modest-hbox-cell-renderer.c:
268 (modest_hbox_cell_renderer_append):
269 * src/widgets/modest-vbox-cell-renderer.c:
270 (modest_vbox_cell_renderer_append):
271 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
272 to fix the build with Maemo Bora.
273 However, there seems to be a remaining crash, probably due to reference
276 2007-05-30 Murray Cumming <murrayc@murrayc.com>
278 * src/modest-tny-account.c:
279 (modest_tny_account_new_for_local_folders):
280 Use hildon_file_system_info_async_new() to get a better name for
281 the memory card account, setting it as the account name.
282 The timing seems to work, but this is probably
283 not the best place to do this. See the TODO comment.
284 * src/maemo/modest-main-window.c: (create_details_widget):
285 * src/widgets/modest-folder-view.c: (text_cell_data):
286 Use the tny account name instead of hardcoding a name.
288 2007-05-30 Christian Kellner <ckellner@openismus.com>
290 * src/modest-search.c: (modest_search):
291 Correctly set part_search_func even if we have already parsed
292 the query and thus a valid OgsTextSearcher object.
294 2007-05-30 Christian Kellner <ckellner@openismus.com>
297 Search and check for libogs.
300 Incooparte the ogs build env.
302 * src/modest-mime-part-search-stream.c:
303 * src/modest-mime-part-search-stream.h:
304 Removed since we do the real searching now in modest-search.c.
306 * src/modest-search.c:
307 * src/modest-search.h:
308 Implement support for ogs. We use that if available and requested
309 and fall back to modest_text_utils_utf8_strcmp (). The search logic
310 should now handle the corner case when the search term is spread
311 across multiple reads.
312 Also the logic in modest_search () was corrected to search all
313 requested fields until one is found.
315 2007-05-30 Murray Cumming <murrayc@murrayc.com>
317 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
320 * src/modest-init.c: Made modest_init_local_folders() take a
321 path and be public so we can iniitialize maildir folders on
324 * src/modest-local-folder-info.h:
325 * src/modest-local-folder-info.c:
326 (modest_local_folder_info_get_maildir_path): Add a path parameter.
328 * src/modest-tny-account.c:
329 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
330 still means the standard local-folders path on the local volume.
332 * src/modest-tny-account-store.c:
333 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
334 signal so we can detect mount/unmount of the MMC1 card, and do an update of
335 all accounts when that happens.
336 (get_server_accounts): If the MMC1 card is mounted, create a store account for
337 this too, so it shows up in the treeview.
339 2007-05-28 Murray Cumming <murrayc@murrayc.com>
341 * src/maemo/modest-maemo-global-settings-dialog.c:
342 (current_connection):
343 * src/widgets/modest-global-settings-dialog.c:
344 (current_connection_default):
345 Use the enum values instead of 0, 1 and -1,
346 to make the code clearer.
348 * src/modest-account-mgr-helpers.c:
349 (modest_account_mgr_get_connection_specific_smtp): Make this code
352 * src/modest-runtime.h:
353 * src/modest-runtime.c:
354 Added modest_runtime_remove_all_send_queues().
355 * src/maemo/modest-main-window.c:
356 (on_account_store_connecting_finished): Recreate the send queues,
357 using the appropriate transport accounts for this new connection.
358 Some futher adapting might be needed if the old send queues are not
359 automatically stopped at this point.
361 * src/modest-tny-account-store.c: (get_server_accounts):
362 Create the connection-specific transport accounts, so that they can
363 be found later by their ID.
365 * src/modest-tny-account.h:
366 * src/modest-tny-account.c:
367 Added modest_tny_account_new_from_server_account_name().
368 modest_tny_account_new_from_server_account(): Do not create the
369 send queues here, because they will be
370 recreated anyway when the connection changes for the first time.
372 2007-05-28 Murray Cumming <murrayc@murrayc.com>
374 * src/modest-local-folder-info.h:
375 * src/modest-local-folder-info.c:
376 (modest_per_account_local_outbox_folder_info_get_maildir_path),
377 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
378 tbox_folder): Take a modest account name instead of a server TnyAccount,
379 so we can have per-modest-account rather than per-transport-account
381 We must make sure that we change or recreate the exisitng send queues
382 when the connection changes for connection-specific transport accounts.
384 * src/modest-tny-account-store.c:
385 (create_per_account_local_outbox_folders): Create outboxed per modest
386 account, not per transport account.
388 * src/modest-tny-account.h:
389 * src/modest-tny-account.c:
390 (modest_tny_account_get_special_folder): For outboxes, get the
391 parent modest account name. The account is ignored for other folders.
392 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
393 modest account name rather than a server TnyAccount.
395 2007-05-25 Murray Cumming <murrayc@murrayc.com>
397 * src/modest-tny-account.c:
398 (modest_tny_account_new_from_server_account):
399 Call modest_runtime_get_send_queue() immediately after creating transport
400 accounts, so that they start trying to send email from the outbox as soon
401 as possible at startup. This is probably what we want.
403 * src/modest-mail-operation.c: (update_account_thread):
404 * src/modest-runtime.c: (modest_runtime_get_send_queue):
405 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
406 * src/modest-tny-send-queue.h:
407 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
408 (modest_ui_actions_on_send):
409 Added comments about how sending works, though it needs some more work.
411 2007-05-25 Murray Cumming <murrayc@murrayc.com>
413 * src/modest-tny-account.c:
414 (modest_tny_account_get_special_folder): Add TODO because this fails when
416 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
417 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
418 Do not try to show this window when there is no active account. The UI
419 specs does not tell us what to do in this case.
421 2007-05-24 Murray Cumming <murrayc@murrayc.com>
425 * src/maemo/Makefile.am:
426 * src/widgets/Makefile.am: Some dist fixes.
428 2007-05-24 Murray Cumming <murrayc@murrayc.com>
430 * src/maemo/modest-connection-specific-smtp-window.c:
431 (on_button_edit): Make the code clearer, to prevent a double free.
433 2007-05-24 Murray Cumming <murrayc@murrayc.com>
435 * src/maemo/modest-account-settings-dialog.c:
436 (modest_account_settings_dialog_set_account_name),
437 Check the connection-specific smtp servers checkbox if there are any.
439 * src/maemo/modest-connection-specific-smtp-edit-window.c:
440 (modest_connection_specific_smtp_edit_window_init):
441 Start with a suitable port number.
443 * src/modest-account-mgr-helpers.h:
444 * src/modest-account-mgr-helpers.c: Added
445 modest_account_mgr_get_has_connection_specific_smtp().
447 (modest_account_mgr_set_connection_specific_smtp),
448 (modest_account_mgr_remove_connection_specific_smtp),
449 (modest_account_mgr_get_has_connection_specific_smtp),
450 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
451 connection-specific smtp server accounts in the account, rather than
452 the server account conf dir.
454 This fixes bug projects.maemo.org bug NB#58263 .
456 * src/modest-tny-account-store.c:
457 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
458 if there are no server accounts yet, to prevent an infinite loop when there
459 are no accounts. Document that one must be called before the other.
461 2007-05-24 Murray Cumming <murrayc@murrayc.com>
463 * src/modest-account-mgr-helpers.c:
464 (modest_account_mgr_get_default_account): Make sure that at least
465 one account is always the default, if there are any enabled accounts.
466 This is just a sanity check that shouldn't be necessary.
468 * src/modest-account-mgr-priv.c:
469 (_modest_account_mgr_account_from_key): Unescape the conf key to
470 get the real account name. For instance, this is an issue if a space
471 was in the account name, which can happen because the account name
472 is generated from the display name.
473 (_modest_account_mgr_get_account_keyname): Always escape the
475 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
476 Unescape the conf keys to get the real account names.
478 For instance, previously the is-default radio button in the accounts
479 list was not checked for any accounts at first. This fixes that,
480 and might fix several similar bugs.
482 2007-05-23 Murray Cumming <murrayc@murrayc.com>
484 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
485 Removed some debug printfs.
487 2007-05-23 Murray Cumming <murrayc@murrayc.com>
489 Modest on-disk outbox directories are now here, for instance:
490 $HOME/.modest/outboxes/<account-id-1>/outbox
491 $HOME/.modest/outboxes/<account-id-2>/outbox
493 $HOME/.modest/local-folders/outbox
494 so we can have a separate outbox for each account.
495 But they are shown as one outbox in the GtkTreeView, by using a
496 TnyMergeFolder in a ModestTnySimpleFolderStore.
499 * src/modest-tny-simple-folder-store.c:
500 * src/modest-tny-simple-folder-store.h:
501 Added ModestTnySimpleFolderStore, used to contain folders from
502 other folder stores, such as other accounts.
504 * src/modest-tny-outbox-account.h:
505 * src/modest-tny-outbox-account.c:
506 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
507 used for the per-account local outbox folders.
509 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
510 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
511 only use this (internally) now for the non-outbox local folders.
514 * src/modest-init.c: Added modest_init_one_local_folder(), for
515 setting up the directory structure for each local folder.
517 * src/modest-local-folder-info.c:
518 (modest_per_account_local_outbox_folder_info_get_maildir_path),
519 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
521 * src/modest-local-folder-info.h:
522 * src/modest-tny-account-store.c: (on_account_removed),
523 (on_account_changed), (create_per_account_local_outbox_folders),
524 (get_server_accounts), (modest_tny_account_store_get_accounts),
525 (modest_tny_account_store_get_tny_account_by_account),
526 (modest_tny_folder_store_is_virtual_local_folders):
528 * src/modest-tny-account.h:
529 * src/modest-tny-account.c:
530 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
531 to create an on-disk per-account local outbox folder for each
533 (create_per_account_local_outbox_folders): Create a local outbox folder
534 for each transport account.
535 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
536 for all local folders.
538 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
539 instead of using g_object_get/set() directly. It is clearer.
541 (modest_tny_folder_store_get_message_count),
542 (modest_tny_folder_store_get_local_size
543 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
544 because we now use these with non-acount folder stores.
546 (modest_tny_account_get_special_folder),
547 (modest_tny_account_new_from_server_account),
548 (modest_tny_account_new_from_account):
549 (recurse_folders): Adjust to the new outbox system.
551 * src/modest-tny-folder.h:
552 * src/modest-tny-folder.c:
553 (modest_tny_folder_is_local_folder),
554 (modest_tny_folder_get_local_folder_type),
555 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
557 * src/widgets/modest-main-window.h:
558 * src/maemo/modest-main-window.c: (create_details_widget),
559 (modest_main_window_set_contents_style): Show details for any folder store,
562 (modest_tny_folder_get_rules):
563 Remove the const. C does not support constness enough for this.
565 * src/modest-ui-actions.c:
566 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
567 make all outboxes appear as one, in the usual local-folders tree node.
569 (set_active_account_from_tny_account),
570 (modest_ui_actions_on_folder_selection_changed):
571 * src/widgets/modest-folder-view.c: (text_cell_data),
572 (icon_cell_data), (filter_row),
573 (add_account_folders_to_merged_folder),
574 (add_account_folders_to_simple_folder_store), (),
575 (get_cmp_rows_type_pos), (cmp_rows),
576 (modest_folder_view_set_account_id_of_visible_server_account):
577 Adjust to the new outbox system, using generic folder stores and folders
580 2007-05-23 Christian Kellner <ckellner@openismus.com>
582 * src/modest-mail-operation.c:
583 (modest_mail_operation_update_account):
584 Use info->max_size instead of unintialized local var [small
585 build fix]. (Added TODO to review that change since I don't
588 2007-05-23 Marcus Bauer <marcusb@openismus.com>
590 * libmodest-dbus-client/libmodest-dbus-client.c:
591 (libmodest_dbus_client_compose_mail): function added
592 * src/dbus_api/modest-dbus-api.h:
593 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
594 (on_compose_mail): Implementation of the SendAsMail functionality
596 2007-05-22 Murray Cumming <murrayc@murrayc.com>
598 * src/modest-account-mgr.c:
599 (modest_account_mgr_add_server_account): Set the secure-connection
600 conf key for transport accounts as well as store accounts. I don't know
601 why the if was there. For instance, this makes sure that we use SSL
602 for the gmail preset from the easysetup wizard.
604 2007-05-22 Murray Cumming <murrayc@murrayc.com>
606 * src/gnome/modest-main-window.c:
607 (on_account_store_connecting_finished), (connect_signals):
608 * src/maemo/modest-main-window.c:
609 (on_account_store_connecting_finished), (connect_signals),
610 (modest_main_window_new):
611 Handle TnyAccountStore::connecting-finished instead of
612 TnyDevice::connection-changed, because we cannot actually perform
613 operations on accounts until TnyAccountStore has itself responded to
614 the TnyDevice::connection-changed signal. This prevents a GError from
616 Do not try to update at startup, because we (at least on scratchbox)
617 already do an update at startup when the device goes online.
618 This prevents a GError from tinymail.
619 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
620 Added TODO about stopping simultaneous operations.
622 2007-05-21 Murray Cumming <murrayc@murrayc.com>
624 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
625 * src/modest-mail-operation-queue.c:
626 (modest_mail_operation_queue_remove):
627 * src/modest-tny-account-store.c: When GErrors happen, give more clues
628 about where they happened.
630 2007-05-21 Murray Cumming <murrayc@murrayc.com>
632 * src/modest-ui-actions.c:
633 (modest_ui_actions_on_password_requested): Make sure that the remember
634 output parameter is always TRUE.
636 2007-05-21 Murray Cumming <murrayc@murrayc.com>
638 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
639 Show a OK/Cancel dialog if the error is a question, though we still do not
640 know anything more about what we are asking the user.
641 * src/widgets/modest-folder-view.c: (on_drag_data_received):
642 Fix an uninitialized variable (helper). This is a logic error, however.
644 2007-05-21 Christian Kellner <ckellner@openismus.com>
646 * src/modest-search.h:
647 Correct bit shifting in the ModestSearchFlags enum.
649 2007-05-21 Murray Cumming <murrayc@murrayc.com>
651 * src/modest-tny-account.c:
652 (modest_tny_account_new_from_server_account): Do not use the lsub and
653 check-all hard-coded IMAP options when using POP.
655 2007-05-21 Murray Cumming <murrayc@murrayc.com>
657 * src/modest-tny-account.c:
658 (modest_tny_account_new_from_server_account):
659 Use NULL for the secure-auth method for POP when Password auth has been
660 specified by the user, as we already do for IMAP. "auth=Login" causes
661 an error from camel or the server.
663 2007-05-17 Murray Cumming <murrayc@murrayc.com>
665 * src/maemo/modest-account-settings-dialog.c:
666 (create_page_account_details),
667 (modest_account_settings_dialog_set_account_name):
668 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
669 for the leave-on-server checkbox, rathr than just the checkbox, when
670 the protocol is not POP.
672 2007-05-17 Murray Cumming <murrayc@murrayc.com>
674 * src/widgets/modest-account-view.c:
675 * src/widgets/modest-account-view.h:
676 Added modest_account_view_select_account() which will be useful later
677 to asynchronously re-select the edited account.
679 2007-05-17 Murray Cumming <murrayc@murrayc.com>
681 * src/maemo/modest-account-settings-dialog.c:
682 (modest_account_settings_dialog_set_account_name):
683 Automatically choose the port numbers based on the secure authentication
684 methods, if they have not been chosen before.
685 This fixes projects.maemo.org bug NB#56273 .
687 2007-05-17 Murray Cumming <murrayc@murrayc.com>
689 * src/maemo/modest-main-window-ui.h:
690 * src/modest-ui-actions.c:
691 * src/modest-ui-actions.h:
692 Connect the Tools/SMTP Servers menu item to
693 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
694 SMTP servers dialog, as in the UI specification and saves changes when it
695 is closed. This fixed projects.maemo.org bug NB#56305 .
697 2007-05-17 Murray Cumming <murrayc@murrayc.com>
699 * src/maemo/modest-connection-specific-smtp-window.c:
700 (modest_connection_specific_smtp_window_init):
701 Use gtk_window_set_default_size() to make this window big enough, so
702 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
704 2007-05-17 Murray Cumming <murrayc@murrayc.com>
706 * src/maemo/modest-connection-specific-smtp-edit-window.h:
707 * src/maemo/modest-connection-specific-smtp-edit-window.c:
708 (modest_connection_specific_smtp_edit_window_init),
709 Do not try to connect to a combobox signal before the combobox exists.
710 This fixes the cras in projects.maemo.org bug NB#56288 .
711 (modest_connection_specific_smtp_edit_window_get_settings):
712 Remove the server_account_name parameter which was being checked for NULL
713 though it was not used.
715 * src/maemo/modest-connection-specific-smtp-window.c:
716 (modest_connection_specific_smtp_window_fill_with_connections),
717 (on_button_edit), (modest_connection_specific_smtp_window_init):
718 Correct the number of treemodel columns to prevent a warning.
719 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
720 libconic does not work.
722 2007-05-16 Murray Cumming <murrayc@murrayc.com>
724 * src/modest-tny-account.c:
725 (modest_tny_account_new_from_server_account):
726 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
727 SMTP when "None" was chosen by the user. However, with my SMTP server that
728 does not support ANONYMOUS, the emails do not leave the Outbox and I see
731 2007-05-16 Murray Cumming <murrayc@murrayc.com>
733 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
734 to explain the memory management issue with the ID in the ModestPair.
736 * src/gnome/modest-account-assistant.c: (add_receiving_page),
737 (add_sending_page), (modest_account_assistant_finalize):
738 * src/gnome/modest-gnome-global-settings-dialog.c:
739 (create_updating_page), (create_composing_page):
740 * src/gnome/modest-msg-edit-window.c: (get_transports),
741 (init_window), (modest_msg_edit_window_finalize),
742 (modest_msg_edit_window_get_msg_data):
743 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
744 * src/gnome/modest-transport-widget.c:
745 (modest_transport_widget_finalize), (smtp_configuration):
746 * src/maemo/modest-maemo-global-settings-dialog.c:
747 (create_updating_page), (create_composing_page):
748 * src/maemo/modest-msg-edit-window.c: (get_transports),
749 (init_window), (modest_msg_edit_window_finalize),
750 (modest_msg_edit_window_get_msg_data),
751 (modest_msg_edit_window_free_msg_data):
752 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
753 (modest_store_widget_finalize):
754 * src/maemo/modest-transport-widget.c:
755 (modest_transport_widget_finalize), (smtp_configuration):
756 * src/modest-main.c: (send_mail):
757 * src/widgets/modest-combo-box.h:
758 * src/widgets/modest-global-settings-dialog-priv.h:
759 * src/widgets/modest-global-settings-dialog.c:
760 (modest_global_settings_dialog_finalize):
761 * src/widgets/modest-msg-edit-window.h:
762 Whenever using modest_combo_box_new(), keep the ModestPairList alive
763 as long as the combo box, to prevent use of freed memory for the ID.
765 2007-05-15 Murray Cumming <murrayc@murrayc.com>
767 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
768 get_accounts(), to make this clearer. Do not check for the enabled gconf
769 key, because we do not use this for server accounts (at least, not yet).
770 This allows us to send email again.
772 2007-05-15 Murray Cumming <murrayc@murrayc.com>
774 * src/maemo/modest-platform.c:
775 (on_modest_conf_update_interval_changed), (modest_platform_init):
776 Only respond to this particular key change. All these strcmp()s cannot be
779 2007-05-15 Murray Cumming <murrayc@murrayc.com>
781 * src/maemo/modest-maemo-global-settings-dialog.c:
782 (current_connection): Prevent a crash in scratchbox when
783 ny_maemo_conic_device_get_current_iap_id() returns NULL.
784 * src/maemo/modest-platform.c:
785 (on_modest_conf_update_interval_changed), (modest_platform_init):
786 Get the update interval from gconf and reset it when the gconf key changes.
788 2007-05-15 Murray Cumming <murrayc@murrayc.com>
790 * src/modest-protocol-info.c:
791 * src/modest-protocol-info.h: Adde enum-specific get functions,
792 instead of using a ModestProtocolType enum parameter.
794 * src/gnome/modest-account-assistant.c:
795 * src/gnome/modest-store-widget.c:
796 * src/gnome/modest-store-widget.h:
797 * src/gnome/modest-transport-widget.c:
798 * src/gnome/modest-transport-widget.h:
799 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
800 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
801 * src/maemo/easysetup/modest-easysetup-wizard.c:
802 * src/maemo/modest-account-settings-dialog.c:
803 * src/maemo/modest-account-settings-dialog.h:
804 * src/maemo/modest-store-widget.c:
805 * src/maemo/modest-store-widget.h:
806 * src/maemo/modest-transport-widget.c:
807 * src/maemo/modest-transport-widget.h:
808 * src/modest-account-mgr-helpers.c:
809 * src/modest-account-mgr-helpers.h:
810 * src/modest-account-mgr.c:
811 * src/modest-account-mgr.h:
812 * src/modest-tny-account.c:
813 * src/modest-tny-folder.c:
814 * src/widgets/modest-account-view.c:
815 * src/widgets/modest-retrieve-combo-box.c:
816 * src/widgets/modest-retrieve-combo-box.h:
817 * src/widgets/modest-secureauth-combo-box.c:
818 * src/widgets/modest-serversecurity-combo-box.c:
819 * src/widgets/modest-serversecurity-combo-box.h:
820 * tests/check_account-mgr.c:
821 Use the specific functions, and use the re-renamed enum values for GNOME too.
823 2007-05-15 Murray Cumming <murrayc@murrayc.com>
826 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
827 so we can get the second based on the first.
829 * src/maemo/modest-account-settings-dialog.h:
830 * src/maemo/modest-account-settings-dialog.c:
831 Added get_supported_secure_authentication_methods(), though it is mostly
832 commented-out for now until the necessary API is committed to tinymail.
833 (modest_account_settings_dialog_set_account_name),
834 (save_configuration): Request the supported authentication methods from the
835 server, so we can choose a working method.
837 * src/modest-tny-account-store.h:
838 * src/modest-tny-account-store.c:
839 (modest_tny_account_store_get_session): Rename from
840 tny_account_store_get_session().
842 2007-05-14 Murray Cumming <murrayc@murrayc.com>
844 * src/modest-protocol-info.h: Split the ModestProtocol enum
845 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
846 There was no need to have these unrelated values in one enum.
848 * src/: many files: Adapted to changed enum. This makes the code a bit
849 clearer, and the compiler could catch some errors.
851 2007-05-14 Murray Cumming <murrayc@murrayc.com>
853 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
854 Show the detailed internal camel error message when an error happens
855 during the configuration, so that our testers can give us more clues.
856 For instance, in projects.maemo.org bug NB#56910 .
858 2007-05-14 Murray Cumming <murrayc@murrayc.com>
860 * src/modest-tny-account.c:
861 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
862 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
864 2007-05-14 Murray Cumming <murrayc@murrayc.com>
866 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
867 * src/maemo/modest-account-settings-dialog.c:
868 (modest_account_settings_dialog_set_account_name),
869 (save_configuration): For the incoming secure authentication checkbox,
870 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
871 the UI specification. PLAIN does not seem to be supported for most IMAP
872 servers anyway, and I am not sure what it would mean.
873 However, we probably need to discover which of the secure-authentication
874 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
875 * src/modest-account-mgr-helpers.c:
876 (modest_account_mgr_get_server_account_data):
878 * src/modest-tny-account.c:
879 (modest_tny_account_new_from_server_account):
880 Use tny_account_set_mech() to set secure-authentication methods,
881 with some special-casing for IMAP, based on my observations of how
884 * src/modest-account-mgr-helpers.h:
885 * src/modest-account-mgr.c:
886 * src/modest-defs.h: Comment that the URI is only used for local folders.
888 2007-05-11 Murray Cumming <murrayc@murrayc.com>
890 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
891 parameter const, just to be neat.
892 * src/modest-text-utils.c: (modest_text_utils_inline):
893 End g_strconcat() with NULL, as its documentation says. This is almost
894 certainly the cause of my crash at startup on the device. Interestingly,
895 valgrind doesn't tell us about these errors.
897 2007-05-11 Murray Cumming <murrayc@murrayc.com>
899 * scripts/build-packages: Added more precise comments about how to use
900 this script, though I still get this error:
901 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
902 error building tinymail
904 2007-05-11 Murray Cumming <murrayc@murrayc.com>
906 * src/maemo/modest-main-window.c: (on_account_update):
907 Very slight cleanup, hoping to make it simpler to discover what causes
908 a crash here sometimes.
910 * src/modest-tny-account.c:
911 (modest_tny_account_new_from_server_account): Set the port. Added
912 comments about the options and a TODO comment because I need to find out
913 how to specify the secure authentication method.
915 2007-05-11 Marcus Bauer <marcusb@openismus.com>
917 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
918 changed CFlags paths form modest to libmodest
920 2007-05-10 Murray Cumming <murrayc@murrayc.com>
922 * src/modest-account-mgr-helpers.c:
923 (modest_account_mgr_get_server_account_data),
924 (modest_account_mgr_free_server_account_data):
925 * src/modest-account-mgr-helpers.h:
926 * src/modest-account-mgr.c:
927 (modest_account_mgr_add_server_account):
929 * src/modest-tny-account.c:
930 (modest_tny_account_new_from_server_account):
931 Determine the options for tny_camel_account_add_option() here,
932 based on the settings, rather than storing them directly in gconf.
934 2007-05-10 Murray Cumming <murrayc@murrayc.com>
936 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
937 Show a more friendly error dialog now that we expect (from the tinymail
938 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
940 2007-05-10 Murray Cumming <murrayc@murrayc.com>
942 * src/maemo/modest-main-window.c: (on_account_update): Check that
943 account_name is not NULL, to prevent a crash at startup that I am
944 seeing on the N800. I do wonder why it is NULL.
946 * src/maemo/easysetup/modest-easysetup-wizard.c:
947 (create_page_user_details):
948 * src/maemo/modest-account-settings-dialog.c:
949 (create_page_user_details), (create_page_outgoing):
950 * src/maemo/modest-connection-specific-smtp-edit-window.c:
951 (modest_connection_specific_smtp_edit_window_init):
952 * src/modest-ui-actions.c:
953 (modest_ui_actions_on_password_requested):
954 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
955 might do something useful with the on-screen keyboard.
957 2007-05-10 Murray Cumming <murrayc@murrayc.com>
959 * src/maemo/modest-main-window.c: (on_account_update):
960 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
961 NULL, to avoid lots of warnings. However, it probably should not be NULL.
963 2007-05-09 Murray Cumming <murrayc@murrayc.com>
965 * src/modest-tny-account-store.c: (on_account_changed):
966 Correct the signature of this signal handler.
968 2007-05-09 Murray Cumming <murrayc@murrayc.com>
970 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
971 Show a HildonNote instead of a GtkDialog for Maemo.
973 2007-05-09 Murray Cumming <murrayc@murrayc.com>
975 * src/widgets/modest-account-view.h:
976 * src/widgets/modest-account-view.c: (on_account_changed),
977 (on_account_removed). Added a boolean flag, set/unset by
978 modest_account_view_block_conf_updates(),
979 modest_account_view_unblock_conf_updates() to prevent unnecessary
980 updates, but this is not very useful because the gconf notifications are
981 so delays (maybe only on Maemo Bora).
982 So auto-updating is turned off, and these functions do an explicit
983 update when necessary.
984 However, something else is still doing too much work when adding/removing
985 accounts, probably in another part of the application.
987 * src/maemo/modest-account-view-window.c:
988 (on_delete_button_clicked), (on_edit_button_clicked),
989 (on_new_button_clicked): Use the new functions.
991 2007-05-09 Murray Cumming <murrayc@murrayc.com>
993 * src/modest-account-mgr-helpers.c:
994 (modest_account_mgr_set_first_account_as_default):
995 Sort the list of names alphabetically-by-title, so we choose the first one
997 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
998 alphabetically by the title.
1000 This fixes projects.maemo.org bug NB#56418 .
1002 * src/modest-account-mgr-priv.c:
1003 (_modest_account_mgr_account_from_key):
1004 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1005 avoid a valgrind error, and possible random behaviour.
1007 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1009 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1010 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1011 tinymail documentation to say that this can be expected.
1012 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1013 pretty, and should not happen, but I would prefer to know when it does.
1015 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1017 * configure.ac: When using the older hildon version, probably on Bora,
1018 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1020 * src/widgets/modest-attachment-view.c:
1021 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1024 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1026 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1027 Implemented the prototype. Can be tested with
1028 tests/dbus_api/test_open_message:
1030 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1032 * src/modest-tny-account-store.c:
1033 (modest_tny_account_store_instance_init), (get_password):
1034 * src/modest-ui-actions.c:
1035 (modest_ui_actions_on_password_requested):
1036 Do not store the password in gconf, because this function is called
1037 for non-remembered passwords. Actually use the cached (in the hash map)
1038 password instead of releasing it.
1039 The password will now not be remembered if it is asked via the protected
1040 password dialog, as per the UI spec.
1042 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1044 * src/modest-defs.h:
1045 * src/modest-account-mgr-helpers.h:
1046 * src/modest-account-mgr-helpers.c:
1047 Added modest_server_account_get_username_has_succeeded(),
1048 modest_server_account_set_username_has_succeeded().
1049 (modest_server_account_set_username),
1050 Reset the has-succeeded flag if the username changes.
1052 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1053 * src/maemo/modest-connection-specific-smtp-window.c:
1054 (modest_connection_specific_smtp_window_save_server_accounts):
1055 Use modest_server_account_set_username() instead of using
1056 modest_conf_set_string() directly, so that the has-succeeded flag is always
1059 * src/modest-ui-actions.c:
1060 (modest_ui_actions_on_password_requested): Dim the username entry if
1061 the username has ever worked, as per the UI spec.
1063 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1065 * src/modest-tny-account-store.c: (get_password):
1066 * src/modest-ui-actions.c:
1067 (modest_ui_actions_on_password_requested):
1068 Allow the username to be changed too, though there is more work to
1069 be done on exactly how this behaves.
1071 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1073 * src/modest-account-mgr-helpers.h:
1074 * src/modest-account-mgr-helpers.c:
1075 Added modest_account_mgr_get_display_name(),
1076 modest_server_account_get_username(),
1077 modest_server_account_set_username(),
1078 modest_server_account_set_password(),
1079 modest_server_account_get_hostname() functions so we do not need to
1080 use the conf API directly.
1082 * src/maemo/modest-main-window.c: (connect_signals):
1083 Actually connect ot the ModestAccountStore::request-password signal,
1084 so that we show the dialog when the password is requested by Tinymail,
1085 for isntance if it is empty.
1087 * src/modest-marshal.list:
1088 * src/modest-tny-account-store.c:
1089 (modest_tny_account_store_class_init), (get_password),
1090 (modest_tny_account_store_alert):
1091 * src/modest-tny-account-store.h:
1092 * src/modest-ui-actions.h:
1093 * src/modest-ui-actions.c:
1094 (modest_ui_actions_on_password_requested):
1095 Change the signal parameters, so it is obvious that we are providing
1096 the non human-readable server name, and receiving both the username
1097 and password, though changing of the username is not yet implemented.
1098 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1099 for the GNOME version.
1101 This should fix the projects.maemo.org bug NB#56209, though it does not
1102 work on Bora, because the gconf_client_get() for the password fails
1103 immediately after we save it with gconf_client_set().
1105 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1108 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1109 caused an undefined symbol error:
1110 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1112 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1114 * src/modest-tny-account-store.c:
1115 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1116 using a GError instead of a string message, so we can translate it in
1119 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1121 * src/maemo/modest-address-book.c:
1122 (modest_address_book_check_names):
1123 * src/maemo/modest-msg-view-window.c:
1124 (modest_msg_view_window_clipboard_owner_change):
1125 * src/modest-init.c: (modest_init_init_ui):
1126 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1127 (update_folders_cb), (modest_mail_operation_update_account):
1128 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1129 (modest_ui_actions_on_msg_attachment_clicked),
1130 (modest_ui_actions_on_msg_recpt_activated):
1131 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1132 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1133 (modest_msg_view_search_next):
1134 * src/widgets/modest-recpt-editor.c:
1135 (modest_recpt_editor_on_button_release_event),
1136 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1137 g_message(). At this point we should only be seeing interesting errors on
1138 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1140 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1142 (modest_wizard_dialog_force_title_update):
1143 * src/maemo/easysetup/modest-wizard-dialog.h:
1144 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1145 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1146 can update the title when appropriate. Otherwise the title is wrong if the
1147 pages are added after adding the notebook to the dialog.
1148 This must be a problem in HildonWizardDialog too.
1149 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1151 * src/maemo/easysetup/modest-easysetup-wizard.c:
1152 (create_subsequent_customsetup_pages),
1153 (create_subsequent_easysetup_pages):
1154 Call modest_wizard_dialog_force_title_update() so that the title is
1155 correct even with GTK+ < 2.10.
1156 This fixes projects.maemo.org bug NB#56145 .
1158 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1160 * src/maemo/modest-platform.c:
1161 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1162 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1165 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1167 * src/widgets/modest-window.h:
1168 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1169 and modest_window_save_state(), which invokes it.
1171 * src/widgets/modest-window-mgr.h:
1172 * src/widgets/modest-window-mgr.c:
1173 Added modest_window_mgr_save_state_for_all_windows(), which calls
1174 the save_state vfunc on all registered windows, if implemented.
1176 * src/gnome/modest-msg-edit-window.c:
1177 * src/gnome/modest-msg-view-window.c:
1178 * src/maemo/modest-msg-edit-window.c:
1179 * src/maemo/modest-msg-view-window.c:
1180 * src/maemo/modest-main-window.c:
1181 Specify the existing save_settings functions as implementations of
1182 ModestWindow::save_state_func().
1184 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1185 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1186 enabling hibernation, for instance.
1188 We may need to do the same thing for restoring settings.
1191 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1193 * src/widgets/modest-window-mgr.c:
1194 * src/widgets/modest-window-mgr.h:
1195 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1196 modest_window_mgr_get_hibernation_is_prevented().
1198 * src/maemo/modest-main-window.c:
1199 (on_hildon_program_is_topmost_notify): Prevent hibernation
1200 (possible when the application goes to the background in the WM),
1201 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1203 * src/maemo/easysetup/modest-easysetup-wizard.c:
1204 (modest_easysetup_wizard_dialog_init):
1205 * src/maemo/modest-account-settings-dialog.c:
1206 (modest_account_settings_dialog_init):
1207 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1208 (modest_connection_specific_smtp_edit_window_init):
1209 * src/maemo/modest-connection-specific-smtp-window.c:
1210 (modest_connection_specific_smtp_window_init):
1211 * src/maemo/modest-signature-editor-dialog.c:
1212 (modest_signature_editor_dialog_init):
1213 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1214 prevent hibernation while any of these account settings dialogs are open.
1216 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1218 * src/maemo/Makefile.am:
1219 * src/maemo/modest-osso-state-saving.c:
1220 * src/maemo/modest-osso-state-saving.h: Added
1221 modest_osso_load_state() and modest_osso_save_state() though they do
1222 nothing now. They should iterate through all the open windows and load/save
1224 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1225 save state when closing.
1227 * src/maemo/modest-main-window.c:
1228 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1229 Add a notification handler for the HildonProgram::is-topmost property,
1230 so we can allow hibernation when the application goes into the background.
1231 But we still need to detect when the accounts setup windows are open so
1232 we can stop hibernation when they are open.
1233 To do this, I also added the main window the HildonProgram. This might have
1234 other side-effects/benefits, and should maybe be done for other windows.
1236 * src/maemo/modest-osso-autosave-callbacks.h:
1237 * src/maemo/modest-osso-autosave-callbacks.c:
1238 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1239 though it does not do anything yet, and we might never need this to do
1240 anything. For instance, we already save drafts.
1242 * src/maemo/modest-platform.c: (modest_platform_init):
1243 Specify the libosso auto-save callback.
1245 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1247 * src/maemo/modest-platform.c:
1248 (modest_platform_set_update_interval):
1249 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1250 aparently stays valid between application instances, so we can use this
1251 to remove and reset it later. According to a maemo-developers email from
1254 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1256 * configure.ac: Depend on libalarm for Maemo.
1258 * src/dbus_api/modest-dbus-api.h:
1259 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1260 (on_send_receive), (modest_dbus_req_handler):
1261 Handle a SEND_RECEIVE D-Bus method.
1263 * libmodest-dbus-client/libmodest-dbus-client.c:
1264 (libmodest_dbus_client_send_and_receive):
1265 * libmodest-dbus-client/libmodest-dbus-client.h:
1266 Add C convenience functions for calling the new D-Bus method.
1268 * src/modest-platform.h:
1269 * src/gnome/modest-platform.c:
1270 * src/maemo/modest-platform.c:
1271 Added modest_platform_set_update_interval(), which uses the
1272 alarmd API on Maemo.
1273 (modest_platform_init),
1274 Call modest_platform_set_update_interval(), using a hard-coded
1275 interval for now (until the global settings dialog is implemented),
1276 though I am not sure that this makes sense yet.
1278 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1280 * src/dbus_api/modest-dbus-callbacks.c:
1281 (modest_osso_cb_hw_state_handler):
1282 * src/dbus_api/modest-dbus-callbacks.h:
1283 * src/maemo/modest-platform.c: (modest_platform_init):
1284 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1285 in case this has some effect on the ability for Maemo to ping the
1288 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1290 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1291 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1292 warning. It is probably a logic error, but I need to fix the build.
1294 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1296 * src/modest-account-mgr.h:
1297 * src/modest-account-mgr.c:
1298 (modest_account_mgr_account_names): Add a gboolean enabled_only
1299 parameter, so we can get lists of onlt the enabled accounts.
1301 (modest_account_mgr_add_account),,
1302 (modest_account_mgr_account_with_display_name_exists):
1303 * src/maemo/modest-msg-edit-window.c: (get_transports):
1304 * src/modest-account-mgr-helpers.c:
1305 (modest_account_mgr_set_first_account_as_default):
1306 * src/modest-init.c: (init_default_account_maybe):
1307 * src/modest-tny-account-store.c: (get_accounts):
1308 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1309 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1310 * tests/check_account-mgr.c: (START_TEST):
1311 Provide the extra parameter, as appropriate.
1313 * src/widgets/modest-account-view.c: (update_account_view):
1314 Do not show disabled accounts (meaning that there is no way to
1315 enable/disable accounts in the UI (the feature is not in our UI
1316 specification), so we can use this internally only to mark unfinished
1317 or temporary account data.
1319 * src/maemo/easysetup/modest-easysetup-wizard.c:
1320 (create_account): Add boolean enable parameter, so we can specify FALSE
1321 to create the temporary account.
1322 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1323 (on_before_next): When finishing, when there is a temporary account, just
1325 Also, use a timeout to delay the showing of the dialog until gconf is likely
1326 to return correct information, due to a maemo gconf bug that is fixed in
1327 osso 1.1, but not yet in Bora.
1328 However, the dialog stays on screen after it is destroyed.
1330 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1331 for invalid data when cancelling. Use a hildon note instead of a dialog
1332 to complain about invalid data. Do not show the account-saved note if the
1333 account is disabled (a temporary account that will not really be saved for use
1336 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1338 * src/modest-account-mgr-helpers.h:
1339 * src/modest-account-mgr-helpers.c:
1340 Added modest_account_mgr_unset_default_account(),
1341 Added modest_account_mgr_set_first_account_as_default().
1343 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1344 If it was the default account, unset the default account name.
1346 * src/maemo/modest-account-view-window.c:
1347 (on_delete_button_clicked): If it was the default account,
1348 set the first remaining account as the default instead.
1350 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1351 a NULL account or a NULL default account, to prevent a crash. This should
1352 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1355 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1357 * src/widgets/modest-recpt-editor.c:
1358 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1359 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1360 TODO comment for this. This fixes the build.
1362 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1363 be the best place for it. This will in future update all auto-update accounts,
1364 rather than just the current/default account, when that gconf key exists.
1365 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1366 if there are no accounts, before calling do_send_receive().
1367 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1369 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1370 * src/maemo/modest-main-window-ui.h:
1371 * src/maemo/modest-main-window.c: (on_connection_changed),
1372 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1373 directly, becaue the signal handler does more.
1375 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1377 * src/modest-account-mgr-helpers.c:
1378 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1379 for the case that the account does not exist.
1381 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1382 (equivalent to the modest account name) rather than the tinymail account name
1383 (equivalent to the modest account title - human readable) to get the account data.
1384 Check for null account data to prevent the crash, and add a TODO comment saying that
1385 this needs fixing because it is using the server account name instead of the account name.
1387 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1389 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1390 * src/maemo/modest-account-settings-dialog.c: (show_error),
1392 Use hildon_note_new_information() for informative and error messages,
1393 which seems to be expected for Maemo applications (no documentation that I know of
1394 says this). I am surprised that there is no distinction between info and error
1397 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1399 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1400 it is easy to find where this is used.
1402 * src/maemo/easysetup/modest-easysetup-wizard.c:
1403 (create_page_welcome), (create_page_account_details),
1404 (create_page_user_details), (create_page_complete_easysetup),
1405 (create_page_custom_incoming), (create_page_custom_outgoing),
1406 (create_page_complete_custom):
1407 * src/maemo/modest-account-settings-dialog.c:
1408 (create_page_account_details), (create_page_user_details),
1409 (create_page_incoming), (create_page_outgoing):
1410 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1411 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1412 (modest_connection_specific_smtp_edit_window_init):
1413 * src/maemo/modest-connection-specific-smtp-window.c:
1414 (modest_connection_specific_smtp_window_init):
1415 * src/maemo/modest-signature-editor-dialog.c:
1416 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1417 and scrolling policy as per the Email Application Layout Guide, if I have
1420 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1422 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1423 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1424 which were empty, because these vfuncs have been removed from TnyAccountStore.
1425 This fixes the build.
1427 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1429 * src/maemo/modest-main-window.c:
1430 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1431 showing/hiding it. Added TODO because it probably should not be NULL.
1432 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1433 because unnecessary g_warnings() make degugging difficult.
1435 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1437 * src/maemo/modest-msg-edit-window.c:
1438 (modest_msg_edit_window_select_color),
1439 (modest_msg_edit_window_select_background_color): 2 const corrections and
1440 moving 2 #endifs before closing brackets, to fix the build.
1442 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1444 * src/maemo/easysetup/modest-easysetup-wizard.h:
1445 * src/maemo/easysetup/modest-easysetup-wizard.c:
1446 (modest_easysetup_wizard_dialog_finalize),
1447 (on_button_edit_advanced_settings), (create_page_complete_custom),
1448 (on_response), (create_account):
1449 Implement the Advanced Settings edit button, by saving the account information,
1450 for the Advanded Settings dialog to use directly from gconf, and removing it
1451 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1452 Bug #5533 in the projects.maemo.org bugzilla.
1454 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1456 * src/maemo/modest-msg-view-window.c:
1457 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1458 when opening a message window.
1460 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1462 * src/maemo/easysetup/modest-easysetup-wizard.c:
1463 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1466 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1467 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1468 gconf settings. I probably added more checks than necessary, but that is safer.
1470 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1471 variable to fix the build, but this seems to be used when it is still NULL.
1473 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1475 * src/modest-platform.h:
1476 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1477 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1478 * src/modest-main.c: Implement this function so we can avoid using
1479 maemo-specific API from cross-platform code.
1481 * src/modest-tny-account-store.c:
1482 (get_smtp_specific_transport_account_for_open_connection):
1483 * src/modest-ui-actions.c: (check_for_connection),
1484 (modest_ui_actions_on_item_not_found):
1485 Use modest_platform_connect_and_wait() and put #idefs around other
1486 maemo-specific code, because only maemo currently has a way to
1487 identify connection names.
1489 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1491 * src/modest-tny-account-store.h:
1492 * src/modest-tny-account-store.c:
1493 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1494 the connection-specific SMTP server settings in the configuration.
1496 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1498 * src/maemo/modest-main-window.c: (on_connection_changed),
1500 * src/modest-main.c: (main), (start_ui), (send_mail):
1501 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1502 that is what is intended.
1504 * src/modest-ui-actions.c: (action_send), (action_receive),
1505 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1506 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1507 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1508 SMTP server is used when it is specified.
1510 (modest_ui_actions_on_send_receive):
1511 Check that a connection is open before proceeding.
1512 Receive and then send, instead of vice-versa, as per the specification.
1514 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1516 * src/modest-mail-operation.c:
1517 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1518 though I guess it should be something other than NULL.
1520 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1522 * src/maemo/easysetup/modest-easysetup-wizard.c:
1523 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1524 combo twice, to avoid an g_warning and to make it visible again.
1525 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1526 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1527 (already intended) dereference when detaching, because we then recreate the menu.
1528 But I am not sure why the warning was happening, and it is possible that this is a memory
1531 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1533 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1534 and uri_parse_mailto() utility functions.
1535 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1537 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1539 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1541 * src/dbus_api/modest-dbus-api.h:
1542 * src/dbus_api/modest-dbus-callbacks.c:
1543 Use an idle callback to execute the modest code in the application's own thread.
1544 Remove the helloworld example method.
1545 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1546 parsed, and the open-message method is not implemented because this is not yet implemented in
1548 * libmodest-dbus-client/libmodest-dbus-client.c:
1549 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1550 (libmodest_dbus_client_open_message):
1551 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1553 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1554 body without crashing.
1556 * tests/dbus_api/Makefile.am:
1557 * tests/dbus_api/test_mail_to.c:
1558 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1560 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1562 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1563 Added file to fix the build. Sorry.
1565 * src/dbus_api/Makefile.am:
1566 * src/dbus_api/modest-dbus-api.h:
1567 * src/dbus_api/modest-dbus-callbacks.h:
1568 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1569 (modest_dbus_req_handler):
1570 Put constants in a separate header so it can be reused by the
1571 client library, without duplication
1573 * libmodest-dbus-client/Makefile.am:
1574 * libmodest-dbus-client/libmodest-dbus-client.c:
1575 (libmodest_dbus_client_call_helloworld),
1576 (libmodfest_dbus_client_send_mail),
1577 (libmodfest_dbus_client_mailto),
1578 (libmodfest_dbus_client_open_message):
1579 * libmodest-dbus-client/libmodest-dbus-client.h:
1580 (Partly) Implement a send_mail D-Bus method.
1582 * tests/dbus_api/Makefile.am:
1583 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1584 the send_email D-Bus method.
1586 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1590 * libmodest-dbus-client/Makefile.am:
1591 * libmodest-dbus-client/libmodest-dbus-client.c:
1592 * libmodest-dbus-client/libmodest-dbus-client.h:
1593 * tests/dbus_api/Makefile.am:
1594 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1595 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1597 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1599 * src/maemo/easysetup/modest-easysetup-wizard.c:
1600 (create_page_account_details):
1601 * src/maemo/modest-account-settings-dialog.c:
1602 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1603 widgets, because this might not be the default in future versions of the Maemo GTK+.
1604 However, I can not not get capitalization to work even in a simple test case.
1606 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1608 * src/maemo/easysetup/modest-easysetup-wizard.c:
1609 (create_page_custom_incoming), (create_page_custom_outgoing):
1610 * src/maemo/modest-account-settings-dialog.c:
1611 (create_page_account_details), (create_page_incoming),
1612 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1613 instead of using gtk_check_button_with_label(), so they are aligned like the other
1614 widgets, as per the UI spec.
1616 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1618 * src/maemo/easysetup/modest-easysetup-wizard.c:
1619 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1620 * src/widgets/modest-validating-entry.c:
1621 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1622 Modest prefix instead of an EasySetup prefix.
1624 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1626 * src/widgets/modest-validating-entry.h:
1627 * src/widgets/modest-validating-entry.c: (on_insert_text),
1628 Added easysetup_validating_entry_set_max_func(), used to set a callback
1629 to call when the max number of characters is reached. GtkEntry has a max-length
1630 already but is silent about it.
1632 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1633 (create_page_account_details), (create_page_user_details),
1635 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1636 (create_page_account_details), (create_page_user_details),
1637 (create_page_outgoing):
1638 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1639 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1640 the UI spec, when the user tries to enter more than the max number of characters.
1642 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1644 * src/maemo/easysetup/modest-easysetup-wizard.c:
1645 (create_page_user_details), (create_page_custom_incoming),
1646 (create_page_custom_outgoing):
1647 * src/maemo/modest-account-settings-dialog.c:
1648 (create_page_user_details), (create_page_incoming),
1649 (create_page_outgoing):
1650 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1651 (modest_connection_specific_smtp_edit_window_init):
1652 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1653 not appropriate. Bad Maemo-specific defaults!.
1655 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1657 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1658 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1659 (modest_signature_editor_dialog_set_settings):
1660 Disable the label and textview when the checkbox is disabled, and use the
1661 specified (UI spec) default signature text.
1663 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1665 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1666 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1668 * src/modest-defs.h:
1669 * src/modest-account-mgr-helpers.h:
1670 * src/modest-account-mgr-helpers.c:
1671 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1673 * src/maemo/Makefile.am:
1674 * src/maemo/modest-signature-editor-dialog.c:
1675 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1678 * src/maemo/modest-account-settings-dialog.h:
1679 * src/maemo/modest-account-settings-dialog.c:
1680 (modest_account_settings_dialog_finalize), (on_button_signature),
1681 (save_configuration): Use the new dialog when the Edit button is pressed, and
1682 save the changes if necessary, as per the UI spec.
1684 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1686 * src/maemo/Makefile.am:
1687 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1688 based on maemo-develoers email from Dirk.
1690 * src/maemo/easysetup/modest-easysetup-wizard.c:
1691 (create_page_welcome), (create_page_account_details),
1692 (create_page_user_details), (create_page_complete_easysetup),
1693 (create_page_custom_incoming), (create_page_custom_outgoing),
1694 (create_page_complete_custom),
1695 (modest_easysetup_wizard_dialog_init):
1696 * src/maemo/modest-account-settings-dialog.c:
1697 (create_page_account_details), (create_page_user_details),
1698 (create_page_incoming), (create_page_outgoing),
1699 (modest_account_settings_dialog_init):
1700 * src/maemo/modest-connection-specific-smtp-window.c:
1701 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1703 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1705 * src/maemo/easysetup/modest-easysetup-wizard.c:
1706 (create_page_account_details), (create_page_custom_outgoing),
1707 (create_page_complete_custom):
1708 * src/maemo/modest-account-settings-dialog.c:
1709 (create_page_user_details), (create_page_incoming),
1710 (create_page_outgoing):
1711 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1712 (modest_connection_specific_smtp_edit_window_init):
1713 Use the correct (UI spec) port min/max, and use horizontal separators,
1716 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1718 * src/maemo/easysetup/modest-easysetup-wizard.c:
1719 (set_default_custom_servernames):
1720 * src/maemo/modest-account-settings-dialog.c:
1721 (create_page_incoming), (on_combo_outgoing_security_changed),
1722 (on_combo_incoming_security_changed), (create_page_outgoing),
1723 (modest_account_settings_dialog_set_account_name),
1724 (save_configuration):
1725 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1726 (on_combo_security_changed),
1727 (modest_connection_specific_smtp_edit_window_init),
1728 (modest_connection_specific_smtp_edit_window_set_connection),
1729 (modest_connection_specific_smtp_edit_window_get_settings):
1730 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1733 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1736 * src/maemo/easysetup/modest-easysetup-wizard.c:
1737 (create_page_custom_outgoing), (create_page_complete_custom):
1738 * src/maemo/modest-account-settings-dialog.c:
1739 (create_page_user_details), (create_page_outgoing):
1740 * src/maemo/modest-account-view-window.c: (button_box_new):
1741 Use changed logical IDs as per the most recent UI spec:
1742 mcen_bd_emailsetup_edit -> mcen_bd_edit
1743 mcen_bd_emailsetup_delete -> mcen_bd_delete
1744 mcen_bd_emailsetup_close -> mcen_bd_close
1746 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1750 * src/dbus_api/Makefile.am:
1751 * src/dbus_api/modest-dbus-callbacks.c:
1752 * src/dbus_api/modest-dbus-callbacks.h:
1753 * src/maemo/modest-platform.c: (modest_platform_init):
1754 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1756 * tests/Makefile.am:
1757 * tests/dbus_api/Makefile.am:
1758 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1760 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1762 * src/maemo/modest-account-settings-dialog.c:
1763 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1764 Removed unnecessary includes.
1766 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1768 * src/maemo/easysetup/modest-easysetup-wizard.c:
1769 * src/maemo/modest-account-settings-dialog.c:
1770 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1771 * src/widgets/Makefile.am:
1772 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1773 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1774 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1775 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1776 * src/widgets/modest-secureauth-combo-box.c:
1777 * src/widgets/modest-secureauth-combo-box.h:
1778 * src/widgets/modest-serversecurity-combo-box.c:
1779 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1780 made the GObject names more consistent with the rest of the Modest code.
1782 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1784 * src/maemo/easysetup/Makefile.am:
1785 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1786 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1787 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1788 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1789 * src/maemo/easysetup/modest-easysetup-wizard.c:
1790 * src/maemo/easysetup/modest-validating-entry.c:
1791 * src/maemo/easysetup/modest-validating-entry.h:
1792 * src/maemo/modest-account-settings-dialog.c:
1793 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1794 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1795 widgets/ because they are used outside of easysetup too. After checking in,
1796 svn will allow me to rename them too.
1798 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1800 * src/gnome/modest-msg-edit-window.c:
1801 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1802 linker error, to fix the build on the GNOME platform.
1803 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1804 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1805 ifdefed out to avoid a warning.
1807 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1809 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1810 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1811 some alternative for GTK+ 2.6.
1813 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1815 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1817 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1818 specified for EmailAccountsDialog in UI spec.
1820 * src/maemo/easysetup/modest-easysetup-wizard.c:
1821 * src/maemo/easysetup/modest-easysetup-wizard.h:
1822 * src/maemo/modest-account-settings-dialog.c:
1823 * src/maemo/modest-account-settings-dialog.h:
1824 Reuse a member window widget for the connection-specific SMTP server accounts,
1825 so we can tell it to create/save the accounts only if we actually save changes.
1827 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1828 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1829 (modest_connection_specific_smtp_edit_window_get_settings):
1830 Return a struct instance for temporarily remembering the entered data.
1832 * src/maemo/modest-connection-specific-smtp-window.h:
1833 * src/maemo/modest-connection-specific-smtp-window.c:
1834 (modest_connection_specific_smtp_window_finalize),
1835 (modest_connection_specific_smtp_window_fill_with_connections),
1837 (modest_connection_specific_smtp_window_save_server_accounts),
1838 (update_model_server_names): Do not actually save data until asked,
1839 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1841 (on_selection_changed),
1842 (modest_connection_specific_smtp_window_init): Disable the edit
1843 button when nothing is selected.
1845 * src/modest-account-mgr-helpers.c:
1846 * src/modest-account-mgr-helpers.h:
1847 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1850 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1852 * src/modest-account-mgr-helpers.h:
1853 * src/modest-account-mgr-helpers.c:
1854 (modest_account_mgr_get_unused_account_name),
1855 (modest_account_mgr_get_unused_account_display_name): Added these
1856 utility functions, to avoid code duplication.
1858 * src/maemo/easysetup/modest-easysetup-wizard.c:
1859 (create_page_account_details), (create_account):
1860 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1861 (on_combo_security_changed),
1862 (modest_connection_specific_smtp_edit_window_init),
1863 (modest_connection_specific_smtp_edit_window_save_settings):
1864 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1865 * src/maemo/modest-connection-specific-smtp-window.c:
1866 (modest_connection_specific_smtp_window_finalize),
1867 (modest_connection_specific_smtp_window_fill_with_connections),
1868 (on_button_edit), (modest_connection_specific_smtp_window_init):
1869 * src/maemo/modest-connection-specific-smtp-window.h:
1870 Implementing saving of connection-specific server accounts.
1872 But I need to refactor this so we can save the data for each
1873 possible connection-specific account and only actually create the server accounts
1874 when the easysetup finished, or the OK button is pressed on the account settings
1877 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1879 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1880 (on_combo_security_changed):
1881 (modest_connection_specific_smtp_edit_window_init):
1882 Auto-fill the port number as in the account settings.
1884 (modest_connection_specific_smtp_edit_window_set_connection):
1885 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1886 * src/maemo/modest-connection-specific-smtp-window.c:
1887 (fill_with_connections), (on_button_edit),
1888 (modest_connection_specific_smtp_window_init):
1889 Turn the edit window into a dialog to simplify the code, and
1890 set a WM hint as in a GtkDialog, because only a popup can be on top of
1891 another window in Maemo, and popups usually have no WM decoration.
1893 * src/modest-defs.h:
1894 * src/modest-account-mgr-helpers.c:
1895 (modest_account_mgr_set_connection_specific_smtp),
1896 (modest_account_mgr_remove_connection_specific_smtp),
1897 (modest_account_mgr_get_connection_specific_smtp):
1898 * src/modest-account-mgr-helpers.h: Some functions to write the
1899 connection-specific SMTP server information. Not yet used.
1902 * src/widgets/modest-folder-view.c: (text_cell_data):
1903 Fix a warning about an uninitialized variable.
1904 (on_configuration_key_changed): Put an #ifdef around the use
1905 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1907 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1909 * src/maemo/modest-account-settings-dialog.h:
1910 * src/maemo/modest-account-settings-dialog.c:
1911 Added connect_for_modified() utility function to mark the new modified boolean.
1913 (create_page_account_details), (create_page_user_details),
1914 (create_page_incoming), (create_page_outgoing), (on_response),
1915 (modest_account_settings_dialog_init),
1916 (modest_account_settings_dialog_set_account_name):
1917 Only warn about unsaved changes when there are actually unsaved changes.
1919 * src/modest-account-mgr-helpers.c:
1920 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1921 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1922 to get the data from there in future.
1924 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1926 * src/modest-defs.h:
1928 * src/modest-account-mgr-helpers.h:
1929 * src/modest-account-mgr-helpers.c:
1930 Store the security account setting in a single conf key instead of using
1931 the options list, so that the list is left for just the to-be-removed camel hack,
1932 and because gconf_client_set_list() is failing for some reason.
1934 * src/modest-account-mgr.c:
1935 (modest_account_mgr_add_server_account):
1936 * src/maemo/modest-account-settings-dialog.c:
1937 (modest_account_settings_dialog_set_account_name),
1938 (save_configuration): Use the renamed functions.
1941 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1943 * src/widgets/Makefile.am:
1944 * src/widgets/modest-limit-retrieve-combo-box.c:
1945 * src/widgets/modest-limit-retrieve-combo-box.h:
1946 * src/widgets/modest-retrieve-combo-box.c:
1947 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1948 the account settings dialog.
1950 * src/modest-defs.h:
1951 * src/modest-account-mgr-helpers.h:
1952 * src/modest-account-mgr-helpers.c:
1953 (modest_server_account_get_option_secure_auth),
1954 (modest_server_account_set_option_secure_auth):
1955 * src/modest-account-mgr.c:
1956 (modest_account_mgr_add_server_account):
1957 Use the existing AUTH_MECH conf key for the secure-auth setting,
1958 instead of putting it in the list options, because this was actually used already.
1960 * src/maemo/modest-account-settings-dialog.c:
1961 (create_page_account_details),
1962 (modest_account_settings_dialog_set_account_name),
1963 (save_configuration):
1964 * src/maemo/modest-account-settings-dialog.h:
1965 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1966 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1968 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1970 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1971 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1972 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1974 * src/modest-defs.h:
1975 * src/maemo/modest-account-settings-dialog.c:
1976 (create_page_incoming), (on_combo_outgoing_security_changed),
1977 (on_combo_incoming_security_changed), (create_page_outgoing),
1978 (modest_account_settings_dialog_set_account_name),
1979 (save_configuration): Load/Save the port number, and change it when the
1980 security combo changes, to suitable defaults.
1982 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1984 * src/modest-account-mgr.c:
1985 (modest_account_mgr_add_server_account): Set the security and secure-auth
1986 options, and add a comment saying that the other camel-specific options should be
1989 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1991 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1993 * src/modest-tny-account-store.c: (account_list_free),
1994 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1995 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1998 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2000 * src/modest-protocol-info.c:
2001 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2002 is required by our UI spec. Maybe something in our implementation will use this eventually.
2003 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2004 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2005 instead of the previous 0 placeholder.
2007 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2008 secure-auth settings.
2009 * src/modest-account-mgr-helpers.h:
2010 * src/modest-account-mgr-helpers.c:
2011 (modest_server_account_data_get_option_secure_auth),
2012 (modest_server_account_set_option_secure_auth),
2013 (modest_server_account_data_get_option_security),
2014 (modest_server_account_set_option_security): Added this API for getting and setting the security
2015 and secure-auth settings.
2017 * src/maemo/modest-account-settings-dialog.h:
2018 * src/maemo/modest-account-settings-dialog.c:
2019 (modest_account_settings_dialog_finalize), (check_data),
2020 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2021 about changing titles.
2022 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2023 (save_configuration): Save the security and secure-auth settings.
2025 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2026 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2028 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2030 * src/modest-defs.h:
2031 * src/modest-account-mgr.c:
2032 (modest_account_mgr_add_server_account):
2033 Added and used defines for the options key and value pair strings,
2034 that are used so far, though they do not seem to correspond to anything in our
2035 UI specs or ModestProtocol enum.
2037 * src/modest-account-mgr-helpers.h:
2038 * src/modest-account-mgr-helpers.c:
2039 (compare_option_strings_for_name),
2040 (modest_server_account_data_get_option_value),
2041 (modest_server_account_data_get_option_bool),
2042 (modest_account_mgr_get_server_account_option):
2043 Added helper functions for parsing the options GSList.
2045 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2047 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2048 display name is based on the supplied account name.
2049 * src/modest-account-mgr.c:
2050 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2051 with an inefficient, but good-enough, implementation.
2053 * src/maemo/easysetup/modest-easysetup-wizard.c:
2054 (create_page_account_details), (on_before_next), (create_account):
2055 Check for existing display names rather than (non-user-visible) account names, and just
2056 create and set a unique account name at the end.
2058 * src/maemo/modest-account-settings-dialog.c:
2059 (modest_account_settings_dialog_init),
2060 (modest_account_settings_dialog_set_account_name),
2061 (create_page_incoming): Show the display name, instead of the account name.
2062 (on_response): Do some (not all) extra checks, as in the UI spec.
2063 (save_configuration): Save the display name if it was changed.
2065 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2067 * po/en_GB.po: Added needed logical ID and translation.
2068 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2069 (init_view): Made the is-default column clicking work.
2071 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2074 * src/maemo/easysetup/Makefile.am:
2075 * src/maemo/easysetup/modest-easysetup-wizard.c:
2076 (modest_easysetup_wizard_dialog_init):
2077 * src/maemo/easysetup/provider-data-test.keyfile:
2078 * src/maemo/easysetup/provider-data.keyfile:
2079 Moved the provider data file to the new modest-providers-data package and used it from there.
2081 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2083 * src/modest-local-folder-info.c:
2084 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2085 N_() was already used on the static strings, but this just marks it for translation without
2086 using the translation.
2088 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2090 * src/maemo/modest-account-settings-dialog.c:
2091 (create_page_incoming),
2092 (modest_account_settings_dialog_set_account_name):
2093 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2094 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2095 I will do this if nobody else gets there first.
2097 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2099 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2100 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2101 save the security stuff.
2103 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2105 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2106 Set the email address and user fullname, which I now see must be
2109 * src/maemo/modest-account-settings-dialog.h:
2110 * src/maemo/modest-account-settings-dialog.c:
2112 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2113 leave-on-server and authentication.
2114 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2117 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2120 * src/maemo/modest-account-settings-dialog.c:
2121 * src/maemo/modest-account-settings-dialog.h:
2122 Most (but not all) of the widgets are now present as specified by the UI spec.
2123 No changes are yet saved, and some details are not properly shown yet.
2125 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2127 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2129 * src/maemo/Makefile.am:
2130 * src/maemo/modest-account-settings-dialog.c:
2131 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2132 an existing account. Doesn't do much yet.
2134 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2135 Open the accounts settings dialog when Edit is clicked.
2137 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2139 * src/maemo/easysetup/Makefile.am:
2140 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2142 * src/maemo/easysetup/modest-easysetup-wizard.c:
2143 (modest_easysetup_wizard_dialog_init):
2144 Try to get the source directory from the build system,
2145 instead of hard-coding "./" into the source code, when opening our local
2146 copies of the configuration files.
2147 But this still fails when opening the wizard from the Accounts window,
2148 maybe because the working directory seems to change at runtime.
2149 So the wizard will fail the second time unless you copy the files into their
2150 proper locations - see the stdout warnings for the paths.
2152 (create_page_account_details),(on_before_next):
2153 Check for existing non-server accounts instead of server accounts,
2154 so the default account name is useful again, and to prevent trying to
2157 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2158 Show the wizard when New is clicked.
2160 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2161 (init_view): Show the column headers, and show the columns that are
2162 specified in the UI specs. However, something in Maemo's GTK+ prevents
2163 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2164 change the default account. This is despite unsetting the special properties.
2166 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2168 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2169 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2170 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2171 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2172 to make that clearer.
2173 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2175 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2177 * src/maemo/modest-account-view-window.c:
2178 (modest_account_view_window_init),
2179 (modest_account_view_window_new):
2180 Use the same buttons as specified in the
2181 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2182 the existing widgets, which never had a chance of working.
2183 Put the ModestAccountView treeview in a scrolled window.
2184 Do not repeat the initialization in both _init() and _new().
2186 * src/widgets/modest-account-view.c: (update_account_view):
2187 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2188 this widget and window shows no accounts.
2190 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2192 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2194 * src/maemo/easysetup/modest-easysetup-wizard.c:
2195 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2196 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2197 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2200 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2201 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2202 accounts exist yet, as in the UI spec.
2204 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2206 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2208 * src/maemo/Makefile.am:
2209 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2210 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2211 New window for editing connection-specific smtp details.
2212 Not fully implemented.
2214 * src/maemo/modest-connection-specific-smtp-window.c:
2215 (modest_connection_specific_smtp_window_finalize) :
2216 unref the tree model.
2217 (on_button_edit): Show the edit window.
2219 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2221 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2224 * src/maemo/Makefile.am:
2225 * src/maemo/modest-connection-specific-smtp-window.c:
2226 * src/maemo/modest-connection-specific-smtp-window.h:
2227 New window for showing the list of connections, for connection-specific
2228 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2229 * src/maemo/easysetup/modest-easysetup-wizard.c:
2230 (create_page_custom_outgoing): Show the new window when the button is clicked.
2232 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2234 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2235 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2236 * src/maemo/modest-msg-edit-window.c:
2237 (modest_msg_edit_window_insert_image):
2238 * src/modest-conf.c: (modest_conf_key_escape):
2239 * src/modest-mail-operation.c:
2240 (modest_mail_operation_send_new_mail):
2241 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2242 (modest_ui_actions_on_new_account):
2243 * src/widgets/modest-attachment-view.c: (update_filename_request):
2244 * src/widgets/modest-mail-header-view.c:
2245 Corrected warnings that were breaking the build, by commenting out unused variables,
2246 and a function, and by including a header.
2248 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2250 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2251 so we can #ifdef around platform-specific code when necessary.
2252 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2253 to allow this to build for the GNOME platform too.
2255 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2257 * src/maemo/easysetup/modest-easysetup-wizard.c:
2258 Added util_increment_name() and used it in create_page_account_details()
2259 to make sure that the default account name is always a new name.
2261 (modest_easysetup_wizard_dialog_init),
2262 (set_default_custom_servernames): Some minor memory management fixes.
2264 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2268 * src/modest-runtime.c: (init_i18n): Restored the translation
2269 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2270 are defined in config.h, and the translations are installed.
2272 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2273 is defined for translation.
2275 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2277 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2279 * src/maemo/easysetup/modest-easysetup-wizard.c:
2280 (modest_easysetup_wizard_dialog_init):
2281 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2282 Use realistic paths (though they should use $prefix generically) to the
2283 mcc_mapping and provider-data.keyfile files which might work when they
2284 are installed by the future version of the operator-wizard package,
2285 and then fallback to paths in our source code, with an explanatory
2288 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2292 * src/maemo/Makefile.am:
2293 * src/maemo/easysetup/: Added files from the previously-exernal
2294 osso-modest-easysetup.
2295 * src/maemo/modest-main-window-ui.h:
2296 * src/modest-ui-actions.c:
2297 * src/modest-ui-actions.h:
2298 Added modest_ui_actions_on_new_account() as a signal handler for the
2299 New Account menu item. It shows the easysetup wizard.
2300 * po/en_GB.po: Added additional needed logical IDs and translations.
2302 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2303 Apparently ChangeLog is not used for some vague Nokia legal reasons.