1 2007-07-25 Murray Cumming <murrayc@murrayc.com>
3 * src/widgets/modest-msg-edit-window.h:
4 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
5 Moved some code here to make it simpler.
6 (modest_msg_edit_window_attach_file_one): Renamed from
7 modest_msg_edit_window_attach_file_interactive().
8 (modest_msg_edit_window_offer_attach_file): Renamed from
9 modest_msg_edit_window_attach_file() and used
10 modest_msg_edit_window_attach_file_one() instead of
11 copy/pasting the code. The old code for one was not using
12 GnomeVFS. This allows use of smb:// URLs when using send-as
13 from external applications, fixing bug NB#63741.
15 (modest_msg_edit_window_insert_image),
16 (modest_msg_edit_window_add_attachment_clicked):
17 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
18 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
19 Adapted to the new function names.
21 2007-07-25 Murray Cumming <murrayc@murrayc.com>
23 (modest_platform_set_update_interval): Set the alarm recurrence
24 fields so that auto-update does not just happen the first time.
25 This should have fixed projects.maemo.org bug NB#63938.
27 When this happens you can see a printf when the D-Bus method is
29 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
31 However, I do not actually seem to get new POP messages even when
32 clicking the refresh button manually. A restart gets them.
33 This might be a problem in today's tinymail only.
35 2007-07-24 Murray Cumming <murrayc@murrayc.com>
37 * src/maemo/modest-maemo-global-settings-dialog.c:
39 Avoid a crash (probably only in scratchbox) when strcmp()ing a
40 NULL when closing the dialog.
42 2007-07-24 Murray Cumming <murrayc@murrayc.com>
44 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
45 Remove the hacky send/receive that didn't work, and instead
46 refilter the treemodel to make the deleted email really vanish from
47 the UI (though the delete-from-menu code does has commented out
48 the code that does that). This fixes projects.maemo.org bug
51 2007-07-24 Murray Cumming <murrayc@murrayc.com>
53 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
54 Try a couple of tricks to force the treeview to update (
55 poke the folder, and do a send/receive refresh), but the deleted
56 email still appears with a strike-through instead of really being
59 2007-07-23 Murray Cumming <murrayc@murrayc.com>
61 * src/dbus_api/modest-dbus-callbacks.c:
62 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
63 because their ID is not human-readable (see the comment about
64 improvements needed to the osso-email-interface API) and
65 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
67 2007-07-23 Murray Cumming <murrayc@murrayc.com>
69 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
70 (add_folders_to_list), (on_dbus_method_get_folders),
71 (modest_dbus_req_filter):
72 * src/maemo/modest-maemo-utils.c:
73 (on_camel_account_get_supported_secure_authentication):
74 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
75 (on_header_view_focus_in):
76 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
77 * src/modest-formatter.c: (modest_formatter_create_body_part):
78 * src/modest-mail-operation.c: (recurse_folders),
79 (update_account_thread), (get_msgs_full_thread),
80 (modest_mail_operation_get_msgs_full),
81 (modest_mail_operation_xfer_msgs):
82 * src/modest-search.c: (search_mime_part_and_child_parts),
83 (modest_search_account), (modest_search_all_accounts):
84 * src/modest-tny-account.c:
85 (modest_tny_account_get_special_folder), (recurse_folders):
86 * src/modest-tny-local-folders-account.c:
87 (modest_tny_local_folders_account_query_passes):
88 * src/modest-tny-msg.c: (copy_mime_part),
89 (modest_tny_msg_find_body_part_from_mime_part):
90 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
91 (modest_tny_send_queue_try_to_send):
92 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
93 (_modest_ui_actions_open), (download_uncached_messages),
94 (reply_forward), (modest_ui_actions_on_copy),
95 (modest_ui_actions_on_details), (has_retrieved_msgs),
96 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
98 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
99 (_selected_msg_marked_as), (_msg_download_completed),
100 (_selected_msg_sent_in_progress):
101 * src/widgets/modest-attachments-view.c:
102 (modest_attachments_view_set_message):
103 * src/widgets/modest-msg-view.c: (find_cid_image):
104 * tests/check_folder-transfer.c: (find_folders):
105 * tests/check_update-account.c: (func):
106 * tests/dbus_api/test_get_folders.c: (main):
107 Checked all uses of tny_iterator_get_current(), making sure
108 that the object is unreferenced (3 or 4 places did not),
109 and adding checks for NULL.
111 2007-07-23 Murray Cumming <murrayc@murrayc.com>
113 * src/dbus_api/modest-dbus-callbacks.c:
114 (on_idle_open_default_inbox): Make sure that the application UI is
116 * src/maemo/easysetup/modest-easysetup-wizard.c:
117 (on_entry_invalid_character): Show the word whitespace instead
118 of (null) in the banner when whitespace was entered.
119 (show_error): Add a comment that this does not work in
120 Maemo Bora, though we do not know why.
122 2007-07-23 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-tny-account.c:
125 (modest_tny_account_get_special_folder): Use an if instead of
126 an assert for when the parent account name is NULL, because this
127 might be causing a crash in projects.maemo.org bug 63192.
128 * src/modest-mail-operation.c:
129 (modest_mail_operation_send_new_mail_cb),
130 (modest_mail_operation_remove_folder): unref the folder that is
131 returned from modest_tny_account_get_special_folder().
133 2007-07-23 Murray Cumming <murrayc@murrayc.com>
135 * src/modest-ui-actions.c:
136 (modest_ui_actions_on_password_requested):
137 Show mail_ib_login_cancelled info banner when the user cancels
138 the protected password dialog, to fix projects.maemo.org
141 2007-07-23 Murray Cumming <murrayc@murrayc.com>
143 * src/maemo/modest-account-settings-dialog.c:
144 (create_page_outgoing): Put this page in a GtkScrolledWindow,
145 matching the UI mock-up in the UI spec, and allowing access
146 to all widgets even when the on-screen keyboard is active.
148 2007-07-23 Murray Cumming <murrayc@murrayc.com>
150 Reverted this previous commit from Johannes,
151 because the scrollbars are always visible and because
152 I think we only need it on onepage of the account
153 settings, not the account wizard.
154 (I wrote the wrong instructions in the bug.)
156 * src/maemo/easysetup/modest-easysetup-wizard.c:
157 Added scrollbars to account wizard dialog.
158 Fixed projects.maemo.org NB #62744
160 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
162 * src/maemo/easysetup/modest-easysetup-wizard.c:
163 (create_page_user_details):
164 Use auto-cap for name (projects.maemo.org NB#63716)
165 * src/widgets/modest-account-view.c: (on_account_busy_changed):
167 2007-07-22 Armin Burgmeier <armin@openismus.com>
169 * src/maemo/modest-ui-actions.c: Use current account instead of
170 default account for creating viewer windows, so that the viewer
171 window knows to which account the viewed message belongs.
173 * src/maemo/modest-msg-view-window.c: Destroy the window when the
174 corresponding account is deleted. This fixes projects.maemo.org bug
177 2007-07-18 Armin Burgmeier <armin@openismus.com>
179 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
180 the dialog close after entering an invalid port number and clicking
181 OK. This fixes projects.maemo.org bug NB#63602.
183 2007-07-18 Armin Burgmeier <armin@openismus.com>
185 * src/modest-tny-account-store.c:
186 (get_server_accounts): Set parent modest account name for each
187 connection-specific transport account so that special folders of such
188 an account can be looked up. This fixes a crash when changing account
189 settings. This might also be related to projects.maemo.org bug
192 2007-07-16 Armin Burgmeier <armin@openismus.com>
194 * src/modest-ui-actions.c: Added a button to create a folder to the
195 move-to dialog. This fixes projects.maemo.org bug NB#.
197 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
199 * src/maemo/easysetup/modest-easysetup-wizard.c:
200 Added scrollbars to account wizard dialog.
201 Fixed projects.maemo.org NB #62744
203 2007-07-16 Murray Cumming <murrayc@murrayc.com>
205 * src/widgets/modest-msg-view.h:
206 * src/widgets/modest-msg-view.c:
207 Added modest_msg_view_get_message_is_empty() but this needs
209 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
210 Check if there is any text in the message yet.
211 But this needs to be implemented properly.
212 (modest_msg_edit_window_toggle_find_toolbar):
213 * src/maemo/modest-msg-view-window.c:
214 (modest_msg_view_window_toggle_find_toolbar):
215 Show a banner warning if there is no text to search, when
216 trying to start a search. This partially fixes
217 projects.maemo.org bug NB#62350.
219 2007-07-13 Murray Cumming <murrayc@murrayc.com>
221 * src/modest-mail-operation.c: (update_account_thread):
222 Initialized num_new_headers to fix the build.
224 2007-07-13 Murray Cumming <murrayc@murrayc.com>
226 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
227 Ignore modest accounts whose server accounts don't exist in gconf.
228 This prevents us trying to create TnyAccount instances for those
229 server accounts when the server account has been removed from gconf,
230 but the parent modest account has not yet been removed from modest.
231 I don't know why this is only noticeable now. It was probably just
232 a harmeless g_warning() anyway.
234 2007-07-13 Murray Cumming <murrayc@murrayc.com>
236 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
237 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
239 2007-07-12 Armin Burgmeier <armin@openismus.com>
241 * src/maemo/modest-main-window.c: Make default account appear bold
242 in view, tools/send & receive and toolbar/send & receive SCM menus.
243 This fixes projects.maemo.org bug NB#59010.
245 2007-07-12 Murray Cumming <murrayc@murrayc.com>
247 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
248 Add a short-cut, by checking if the folder store is an account.
249 This ensures that the Sort menu item and toolbar is dimmed for
250 the local-folders account root item, fixing
251 projects.maemo.org bug NB#62545.
253 2007-07-12 Murray Cumming <murrayc@murrayc.com>
255 * src/modest-tny-account-store.c: (get_password):
256 Show the password dialog (via the signal) only in the mainloop, via
257 an idle handler that we wait for. This could theoretically prevent
258 hangs, though I worry that it could introduce some too.
260 2007-07-12 Murray Cumming <murrayc@murrayc.com>
262 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
263 * src/maemo/modest-platform.c:
264 (modest_platform_connect_and_wait):
265 Take a TnyAccount* parameter and try to set it to online
266 (a TnyCamel-only API), because tinymail sets accounts to offline
267 when the user cancels a password dialog, and doesn't ask again until
268 it has been set to online.
269 However, this is commented out because it causes a hang now.
271 (modest_platform_connect_and_wait_if_network_account):
272 * src/modest-mail-operation.c:
273 (modest_mail_operation_update_account):
274 * src/modest-platform.h:
275 * src/modest-ui-actions.c: (_modest_ui_actions_open),
276 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
278 2007-07-12 Armin Burgmeier <armin@openismus.com>
280 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
282 * src/modest-mail-operation.c:
283 * src/modest-ui-actions.c: Check for already existing folder before
284 querying the server, show error message from camel if the request
285 still fails. This fixes projects.maemo.org bug NB#58701.
287 2007-07-12 Murray Cumming <murrayc@murrayc.com>
289 * src/modest-tny-account-store.h:
290 * src/modest-tny-account-store.c:
291 Added modest_tny_account_store_forget_password_in_memory(),
292 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
293 when creating a new account, so that new passwords will be used, instead of
294 us thinking that it's a second request as a result of a failed password again.
296 2007-07-12 Murray Cumming <murrayc@murrayc.com>
298 * src/dbus_api/modest-dbus-callbacks.c:
299 (on_idle_open_message): If the message is in drafts then open it
300 in an edit window instead of a view window. This fixes
301 projects.maemo.org bug NB#63005.
303 2007-07-12 Murray Cumming <murrayc@murrayc.com>
305 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
306 Avoided a harmless g_warning().
308 2007-07-12 Murray Cumming <murrayc@murrayc.com>
310 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
311 Pass the modest account name, not the TnyAccount display name to
312 modest_msg_view_window_new() so that the reply feature works,
313 fixing projects.maemo.org bug NB#62892.
315 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
316 (modest_msg_view_window_new_with_header_model):
317 * src/maemo/modest-msg-view-window.c:
318 (modest_msg_view_window_new_with_header_model),
319 (modest_msg_view_window_new):
320 * src/modest-ui-actions.c: (reply_forward):
321 * src/widgets/modest-msg-view-window.h:
322 * src/widgets/modest-window.c: (modest_window_set_active_account):
323 Rename an account parameter to modest_account_name to make this clearer.
325 2007-07-11 Murray Cumming <murrayc@murrayc.com>
327 * src/modest-ui-actions.h:
328 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
329 modest_do_message_delete().
330 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
331 Call modest_do_message_delete(), hoping that this would cause messages
332 to be really deleted from search instead of just marked with strike through.
333 Does not seem to help.
335 2007-07-11 Armin Burgmeier <armin@openismus.com>
337 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
338 priv->reselect to FALSE prior to calling
339 modest_folder_view_select_first_inbox_or_local() to prevent endless
340 recursion and thus a crash on startup.
342 2007-07-11 Armin Burgmeier <armin@openismus.com>
344 * src/maemo/modest-account-settings-dialog.h: Include
345 <gtk/gtknotebook.h> to fix the build (at least for me).
347 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
348 Use "New FolderN" as default suggested name if "New folder" already
349 exists, with N being the first free number, though never exceed "New
350 folder99" in which case we just fall back to "New Folder" even though
351 it already exists. This fixes projects.maemo.org bug NB#58663.
353 2007-07-11 Murray Cumming <murrayc@murrayc.com>
355 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
356 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
357 projects.maemo.org bug NB#62778.
359 2007-07-11 Murray Cumming <murrayc@murrayc.com>
361 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
362 Ignore the wrong (for now) secure-smtp setting in the presets -
363 just default to requiring secure authentication for SMTP, because
366 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
368 * src/widgets/modest-folder-view.c: (filter_row)
369 Do not show drafts folder (see UI specs)
371 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
373 * src/modest-ui-actions.c:
374 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
375 place and also not necessary.
377 * src/widgets/modest-folder-view.c: (filter_row)
378 Guess folder type and hide Sent & Outbox if necessary.
379 Fixed project.maemo.org NB#57328
381 2007-07-11 Murray Cumming <murrayc@murrayc.com>
383 * src/modest-ui-actions.h:
384 * src/modest-ui-actions.c:
385 (modest_ui_actions_on_delete_message):
386 Move some code into a new
387 modest_ui_actions_refresh_message_window_after_delete()
388 function so we can use it from elsewhere.
390 * src/dbus_api/modest-dbus-callbacks.c:
391 (on_idle_delete_message), (on_delete_message): Used an idle
392 handler, as we do for the other D-Bus method handlers.
393 Call modest_ui_actions_refresh_message_window_after_delete()
394 if the deleted message was open in a window. This fixed
395 projects.maemo.org bug NB#62862.
397 2007-07-11 Murray Cumming <murrayc@murrayc.com>
399 * src/modest-main.c: (main): Only show the UI at the start if
400 the showui command line option was given. For instance,
401 run-standalone src/modest showui
402 Otherwise, we wait for the top_application D-Bus method to
403 be sent by hildon-desktop when the application is selected
405 This allows us to run without a UI when osso-global-search
406 uses our D-Bus methods.
408 2007-07-11 Murray Cumming <murrayc@murrayc.com>
410 * src/dbus_api/modest-dbus-api.h: Added a define for a
411 top-application D-Bus method.
412 * src/dbus_api/modest-dbus-callbacks.c:
413 (on_top_application),
414 (modest_dbus_req_handler): Handle the top-application D-Bus
415 method, which might be an undocumented D-Bus signal sent by
416 hildon-desktop when it starts the application from the menu.
417 But I am not sure and I need to test it on the device, because
418 my scratchbox does not have the application in the menu now.
419 This method shows the main window, so that it can be invisible
420 when started, for instance, just for email searching from
423 * src/maemo/modest-main-window.c: (restore_settings),
424 (modest_main_window_new): Do not show the window immediately
425 upon creation. We show it later.
426 * src/modest-widget-memory.c: (save_settings_paned):
427 Try (unsuccessfully) to avoid saving the paned position when
428 it is not even visible.
429 (restore_settings_paned): Do not allow a silly paned position.
430 This seems necessary when not showing the window at first.
432 * tests/dbus_api/Makefile.am:
433 * tests/dbus_api/test_top_application.c: (main): Test for the
436 2007-07-10 Murray Cumming <murrayc@murrayc.com>
438 * src/modest-ui-dimming-rules.c:
439 (modest_ui_dimming_rules_on_new_msg),
440 (modest_ui_dimming_rules_on_reply_msg),
441 (modest_ui_dimming_rules_on_delete_msg),
442 (modest_ui_dimming_rules_on_details),
443 (modest_ui_dimming_rules_on_view_window_move_to),
444 (modest_ui_dimming_rules_on_view_previous),
445 (modest_ui_dimming_rules_on_view_next),
446 (_invalid_folder_for_purge): Added checks before
447 casting the window. This looks like an actual
448 logic error in _invalid_folder_for_purge(), because it
449 tries to use a ModestMainWindow as a message window.
451 2007-07-10 Murray Cumming <murrayc@murrayc.com>
453 * src/maemo/modest-account-settings-dialog.c:
454 (show_error): Use the same implementation as in
455 modest-easysetup-wizard.c:
456 (on_entry_invalid_character): The logical ID contains a %s.
457 Guessed what it should be.
458 (on_entry_max), (check_data), (on_response): Adapt to
459 changed show_error().
460 (create_page_account_details): Really call
461 modest_validating_entry_set_func() on the correct widgets.
462 * src/maemo/easysetup/modest-easysetup-wizard.c:
463 (on_entry_invalid_character): Fix the logical ID here too.
464 (create_page_account_details),
465 (create_page_user_details):
467 modest_validating_entry_set_func() on the correct widgets.
469 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
470 Do not try to use the account if it is NULL.
472 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
474 * src/modest-ui-actions.c: (create_move_to_dialog),
475 (modest_ui_actions_on_main_window_move_to),
476 (modest_ui_actions_on_msg_view_window_move_to):
477 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
478 (filter_row), (modest_folder_view_show_non_move_folders):
479 * src/widgets/modest-folder-view.h:
481 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
482 the Sent folder yet as it does not report the correct folder type.
484 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
486 * src/maemo/modest-msg-edit-window.c: (init_window):
489 2007-07-10 Murray Cumming <murrayc@murrayc.com>
491 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
492 Take a parent widget instead of a parent window, and
493 implement this with hildon_banner_show_information() instead.
494 Non-Maemo builds can just ifdef that there.
495 This fixed projects.maemo.org bug NB#62766.
497 (on_entry_invalid_character): Use show_error() again instead
498 of using hildon directly, and use the _CS() macro to use the correct
500 (create_account), (check_for_supported_auth_methods), (on_entry_max):
501 Pass a widget instead od a window to show_error().
503 2007-07-10 Murray Cumming <murrayc@murrayc.com>
505 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
506 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
507 This allows us to show the server name in the error message, fixing
508 projects.maemo.org bug NB#62904.
509 Also, use the appropriate logical ID message for the account protocol.
511 2007-07-10 Murray Cumming <murrayc@murrayc.com>
513 * src/modest-tny-account-store.c: (on_idle_wrong_password):
514 A compilation fix, though the build wasn't broken for me.
516 2007-07-09 Murray Cumming <murrayc@murrayc.com>
518 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
519 Do not try to unref a NULL folder store, to avoid a runtime warning.
520 This seems to happen sometimes when changing accounts settings.
522 2007-07-09 Murray Cumming <murrayc@murrayc.com>
524 * src/modest-tny-account-store.c:
525 (modest_tny_account_store_instance_init),
526 (modest_tny_account_store_finalize),
527 (on_account_settings_hide), (on_idle_wrong_password):
528 Use a GHashTable to ensure that we only show one account settings
529 dialog per modest account. This avoids us having a dialog open for
530 both the store and transport accounts, or due to repeated get_password()
531 calls that shouldn't happen anyway.
533 2007-07-09 Murray Cumming <murrayc@murrayc.com>
535 * src/maemo/modest-maemo-utils.c: (on_hide),
536 (modest_maemo_show_dialog_and_forget): Handle the response, because
537 the window is not even hidden by default.
539 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
540 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
541 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
542 which seems to prevent some modality problems.
544 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
545 Ignore user cancellation errors.
547 * src/modest-account-mgr-helpers.h:
548 * src/modest-account-mgr-helpers.c:
549 Added modest_server_account_get_password() and
550 modest_server_account_get_has_password() to avoid direct use of
553 * src/maemo/modest-account-settings-dialog.h:
554 * src/maemo/modest-account-settings-dialog.c:
555 (modest_account_settings_dialog_init): Store the notebook so we can
557 Added modest_account_settings_dialog_switch_to_user_info().
559 * src/modest-tny-account-store.c:
560 (get_password): When the password in the account settings is wrong (we think),
561 show the relevant page of the account settings dialog, in the mainloop.
562 However, we currently get many of these at once because cancel does not
564 (forget_password): Do not forget the password
565 from the account settings, because this causes side-effects when
566 tinymail seems to call it at strange time, maybe because of how we
567 are cancelling get_password().
568 (modest_tny_account_store_alert): Ignore user cancellations.
570 2007-07-09 Murray Cumming <murrayc@murrayc.com>
572 * src/maemo/modest-maemo-utils.h:
573 * src/maemo/modest-maemo-utils.c:
574 Added modest_maemo_show_information_note_and_forget() for use instead of
575 gtk_dialog_run() when the response is not needed, to avoid an extra
576 mainloop which could cause a hang.
578 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
579 Use the logical IDs for the error message, though they are not
580 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
581 because gtk_dialog_run() caused a hang here (the window did not close).
582 This fixes projects.maemo.org bug NB#62646.
584 2007-07-09 Murray Cumming <murrayc@murrayc.com>
586 * src/modest-account-mgr-helpers.h:
587 * src/modest-account-mgr-helpers.c:
588 Added modest_account_mgr_get_store_protocol().
590 * src/maemo/modest-account-view-window.c:
591 (on_delete_button_clicked): Show different warning text depending on
592 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
593 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
596 2007-07-09 Murray Cumming <murrayc@murrayc.com>
598 * src/maemo/modest-msg-edit-window.c:
599 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
600 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
602 2007-07-07 Armin Burgmeier <armin@openismus.com>
604 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
605 ckdg_ib_maximum_characters_reached from correct package.
607 * src/modest-ui-actions.c: Show an error message when a folder could
608 not be created. Tinymail does not give us specific error codes about
609 what has gone wrong, so we assume that a folder with that name
610 already exists, though there might be other reasons.
612 2007-07-06 Murray Cumming <murrayc@murrayc.com>
614 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
615 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
616 give a more exact error message that can be partly translated.
618 2007-07-05 Murray Cumming <murrayc@murrayc.com>
620 * src/maemo/modest-address-book.c:
621 (select_email_addrs_for_contact): Specify a default window size for the
622 select-email-address dialog, so that it is probably big enough for the
623 title. This should fix projects.maemo.org bug NB#62277.
625 2007-07-05 Murray Cumming <murrayc@murrayc.com>
627 * src/maemo/easysetup/modest-easysetup-wizard.c:
628 (create_page_complete_easysetup): Use
629 gtk_widget_set_size() request to ensure that the text wraps
632 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
634 * src/maemo/easysetup/modest-easysetup-wizard.c:
635 (on_entry_invalid_character), (create_page_account_details),
636 (create_page_user_details):
637 Use new API of ModestValidatingEntry. But for some reason the banner is
638 not shown. I will have to investigate that further.
640 * src/widgets/modest-validating-entry.c: (on_insert_text),
641 (modest_validating_entry_set_func):
642 * src/widgets/modest-validating-entry.h:
643 Added a new callback function to be able to react to prevented
644 characters whitespaces to e.g show a banner.
646 2007-07-05 Armin Burgmeier <armin@openismus.com>
648 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
649 notification of HildonNumberEditor instead of remembering the port
650 number. Thanks to Johannes for pointing this out.
652 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
654 * src/maemo/easysetup/modest-easysetup-wizard.c:
655 Check if there are any user changes before showing a confirmation
656 dialog (projects.maemo.org NB#60946)
658 2007-07-05 Armin Burgmeier <armin@openismus.com>
660 * src/maemo/modest-account-settings-dialog.c: Remember custom port
661 number at the beginning of the dialog and set the modified flag at the
662 end if the port number has changed. This is necessary because
663 HildonNumberEditor does not support notification when the value has
666 2007-07-05 Murray Cumming <murrayc@murrayc.com>
668 * src/modest-ui-actions.c:
669 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
670 a connection before asking anything else. Correct the check for the destination
671 folder so that it succeeds when online.
672 This fixed projects.maemo.org bug NB#61645.
674 2007-07-05 Murray Cumming <murrayc@murrayc.com>
676 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
677 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
678 to fix projects.maemo.org bug NB#62439.
680 2007-07-05 Murray Cumming <murrayc@murrayc.com>
682 * src/modest-tny-account.c: (on_connection_status_changed):
683 Really do not use tny_device_force_offline() here. See the previous comment.
685 2007-07-04 Murray Cumming <murrayc@murrayc.com>
687 * src/modest-tny-account.c: (on_connection_status_changed):
688 Do not use tny_device_force_offline() when tinymail says that something
689 went wrong with the connection. It seems to report this unnecessarily.
691 2007-07-04 Murray Cumming <murrayc@murrayc.com>
693 * src/maemo/modest-connection-specific-smtp-window.c:
694 (modest_connection_specific_smtp_window_init):
695 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
696 does not seem to have any effect in osso 1.1 (though it works in
697 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
699 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
701 * src/maemo/modest-connection-specific-smtp-window.c:
702 Fix UI specification problems with projects.meamo.org NB#60479
704 2007-07-04 Murray Cumming <murrayc@murrayc.com>
706 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
707 clue when this has failed, because the error dialog is not always shown
708 (at least in earlier version).
710 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
711 GError message, because the generic error dialog is not helpful.
713 'This message is not currently available (can't let a new connection go online)'
714 when trying to open an IMAP message.
716 (_modest_ui_actions_open): Offer a connection when some messages would
717 have to be downloaded and we are offline.
719 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
721 * src/widgets/modest-folder-view.c:
722 Don't check for MERGE type anymore as we use the correct type
724 NOTE: For the last two changes you need to update your tinymail copy
725 because of API changes!
727 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
729 * src/modest-tny-local-folders-account.c:
730 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
731 (see projects.maemo.org NB#61580)
733 2007-07-04 Murray Cumming <murrayc@murrayc.com>
735 * src/modest-tny-account.c: (on_connection_status_changed):
736 Commented out the call to modest_platform_connect_and_wait() because this
737 seems to always hang, and I would like to know if this is the only thing
738 that causes a hang when showing the connection dialog.
739 It is not very useful anyway.
741 2007-07-04 Murray Cumming <murrayc@murrayc.com>
743 * src/maemo/modest-msg-view-window.c:
744 (modest_msg_view_window_select_next_message):
746 * src/modest-platform.h:
747 * src/maemo/modest-platform.c:
748 Added modest_platform_connect_and_wait(), which calls
749 tny_maemo_conic_device_connect() always in the main thread, by calling it
750 in an idle handler and waiting for the idle handler to run. It should be
751 in the main thread because it uses GTK+ UI code. It just returns TRUE
752 if the device is already online.
754 There is some nasty code to ensure that subsequent calls to
755 modest_platform_connect_and_wait() just wait for the first one to finish,
756 by checking repeatedly in another idle handler. This is necessary,
757 because other threads (or even the main thread, via another idle handler)
758 can call modest_platform_connect_and_wait() while
759 modest_platform_connect_and_wait() is running.
761 (modest_platform_connect_and_wait_if_network_account),
762 (modest_platform_connect_and_wait_if_network_folderstore):
763 Convenience functions that calls modest_platform_connect_and_wait() if
764 the account or folder might want network access.
766 * src/modest-mail-operation.c:
767 (modest_mail_operation_update_account):
768 * src/modest-ui-actions.c: (download_uncached_messages),
769 (modest_ui_actions_on_rename_folder), (delete_folder),
770 (modest_ui_actions_on_main_window_move_to),
771 (modest_ui_actions_on_msg_view_window_move_to):
772 * src/widgets/modest-folder-view.c:
773 (drag_and_drop_from_folder_view):
774 Offer a connection if we are offline.
776 * src/modest-tny-account.c: (on_connection_status_changed):
777 Document this as only handling errors during network operations in progress,
778 and replace the idle code with a simple call to
779 modest_platform_connect_and_wait(), which does this instead.
781 2007-07-03 Murray Cumming <murrayc@murrayc.com>
783 * src/modest-tny-account.c:
784 (modest_tny_account_get_special_folder): (util_on_idle),
785 Handle the GError so we can see when tny_folder_store_get_folders()
786 fails, as it currently does while something else is connecting.
788 Added util_run_in_main_thread_and_wait()
789 which uses an idlen handler and mainloop to ensure that the function
790 is called in the main thread.
791 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
792 to make sure that we call attempt the connection in the mainloop only,
793 which might solve some hangs.
795 2007-07-03 Murray Cumming <murrayc@murrayc.com>
797 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
798 be found by their display name. This is never useful.
799 * src/modest-tny-account-store.c: (on_account_removed): Find the account
800 by its ID, instead of trying to use its ID as its display name.
802 * src/modest-tny-account-store.h:
803 * src/modest-tny-account.c:
804 (modest_tny_account_get_special_folder): Add a g_warning() when
805 tny_folder_store_get_folders() returns an empty list for the maildir.
807 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
808 Add a g_warning() when this returns NULL, because that it not allowed
811 2007-07-02 Armin Burgmeier <armin@openismus.com>
813 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
814 note when trying to cancel the wizard. This fixes projects.maemo.org
817 2007-07-02 Murray Cumming <murrayc@murrayc.com>
819 * src/modest-tny-account.h:
820 * src/modest-tny-account.c:
821 (modest_tny_account_new_from_server_account),
822 (modest_tny_account_new_from_server_account_name),
823 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
824 because this must now be set before setting the proto. This is usd in
825 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
826 warning in camel_session_get_service() caused by
827 tny_camel_transport_account_prepare().
829 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
832 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
834 * src/maemo/modest-connection-specific-smtp-edit-window.c:
836 (modest_connection_specific_smtp_edit_window_init):
838 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
841 2007-06-29 Murray Cumming <murrayc@murrayc.com>
843 * src/modest-tny-account.c:
844 (modest_tny_account_new_from_server_account):
845 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
846 now uses to request a connection when it needs one, and which it uses
847 to tell us that something is wrong with the connection, so we can force
848 the accounts offline to prevent further problems.
851 * src/modest-init.c: (init_default_settings):
852 * src/modest-mail-operation.c:
853 (modest_mail_operation_update_account):
854 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
855 This should not be necessary anymore. Do not set the conf key that
856 determined this (it was always TRUE and not set anywhere else).
858 * src/modest-ui-actions.h: Remove unused and unimplemented
859 modest_ui_actions_on_online_toggle_toggled().
861 2007-06-29 Murray Cumming <murrayc@murrayc.com
863 * src/maemo/modest-main-window.c: (connect_signals):
864 Don't connect to delete_event twice. Maybe this was harmless.
866 2007-06-29 Murray Cumming <murrayc@murrayc.com
868 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
869 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
870 Debug output to give some more clue when a folder move is not allowed.
872 2007-06-28 Murray Cumming <murrayc@murrayc.com
874 * src/modest-tny-account.c: (on_modest_file_system_info),
875 (modest_tny_account_get_mmc_account_name):
876 Always call the callback, without checking whether the name has changed.
877 * src/widgets/modest-folder-view.c: (strings_are_equal),
878 (on_model_foreach_set_name), (on_get_mmc_account_name),
879 (text_cell_data): Compare the name here, and use the name from
880 the account rather than from the
881 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
882 if the name was changed after the account was added to the model.
883 That's a tinymail bug but not one that I want to fix now.
885 This finally fixes projects.maemo.org bug NB#59301.
887 2007-06-27 Armin Burgmeier <armin@openismus.com>
889 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
892 2007-06-27 Murray Cumming <murrayc@murrayc.com
894 * src/modest-tny-account.h:
895 * src/modest-tny-account.c:
896 Added modest_tny_account_get_mmc_account_name(), to set the memory
897 card name asynchronously for the given account and then notify.
898 (modest_tny_account_new_for_local_folders): Use this new function instead
899 of using hildon_file_system_info_async_new() directly.
901 * src/widgets/modest-folder-view.c: (text_cell_data):
902 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
903 gtk_tree_model_row_changed() when it is available.
905 This should fix projects.maemo.org bug NB#59301.
907 2007-06-27 Murray Cumming <murrayc@murrayc.com
909 * src/modest-mail-operation.c: (update_account_thread),
910 (get_msgs_full_thread): Fix typo failures in the revert
913 2007-06-27 Murray Cumming <murrayc@murrayc.com
915 * src/maemo/modest-maemo-global-settings-dialog.c:
916 (idle_select_default_focus):
917 * src/modest-mail-operation.c: (idle_notify_progress),
918 (idle_notify_progress_once), (set_last_updated_idle),
919 (update_account_thread), (get_msgs_full_thread):
920 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
921 * src/widgets/modest-header-view.c:
922 (idle_notify_headers_count_changed_destroy),
923 (idle_notify_headers_count_changed):
924 Reverted the additions of gdk_threads_enter/leave(), in case this
925 helps with a startup hang on the device.
927 2007-06-26 Armin Burgmeier <armin@openismus.com>
929 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
930 for supported secure authentication methods from server by
931 gtk_dialog_run(), saving CPU time and a potential race condition.
933 2007-06-26 Armin Burgmeier <armin@openismus.com>
935 * src/maemo/modest-maemo-utils.h:
936 * src/maemo/modest-maemo-utils.c: Added a
937 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
938 only error code to tell the calling code when the user canceled the
941 * src/maemo/modest-account-settings-dialog.h:
942 * src/maemo/modest-account-settings-dialog.c:
943 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
944 message if the retrieval of secure authentication methods was canceled
945 by the user. Perform the check before saving anything to configuration
946 to not end up with half-committed configuration changes, do not show
947 a "Saving to configuration failed" note when authentication methods
948 could not be retrieved.
950 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
953 2007-06-26 Murray Cumming <murrayc@murrayc.com>
955 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
956 Only return the first level of folders under accounts, because the
957 osso-global-search UI spec doesn't want the rest.
958 This fixed projects.maemo.org bug NB#61811.
960 2007-06-26 Murray Cumming <murrayc@murrayc.com>
962 * src/modest-tny-account-store.c:
963 * src/modest-tny-account-store.h:
964 Added modest_tny_account_is_memory_card_account().
965 * src/maemo/modest-main-window.c: (create_details_widget):
966 Show the same information items for the memory card as we show for the
967 local-folders, to fix projects.maemo.org bug NB#59307.
969 2007-06-26 Murray Cumming <murrayc@murrayc.com>
971 * src/modest-tny-account-store.c: (get_password):
972 Added some checks for NULL to maybe prevent crashes, though I think
973 it was Philip's last commit that actually prevented the crash here
974 when creating a first new account.
975 But the new account is still not usable (no messages are shown)
976 until a restart of the application.
978 2007-06-26 Murray Cumming <murrayc@murrayc.com>
980 * src/maemo/modest-maemo-global-settings-dialog.c:
981 (idle_select_default_focus):
982 * src/modest-mail-operation.c: (idle_notify_progress),
983 (idle_notify_progress_once), (idle_notify_update_account_queue),
984 (set_last_updated_idle), (update_account_thread),
985 (notify_get_msgs_full), (get_msgs_full_destroyer),
986 (get_msgs_full_thread):
987 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
988 * src/widgets/modest-header-view.c:
989 (idle_notify_headers_count_changed_destroy),
990 (idle_notify_headers_count_changed):
991 Use gdk_threads_enter() and gdk_threads_enter_leave() in
992 all idle handlers, because some other thread could be blocking
993 the GDK lock, so that it can do GUI stuff.
995 2007-06-26 Murray Cumming <murrayc@murrayc.com>
997 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
998 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
999 (on_idle_send_receive), (on_idle_open_default_inbox):
1000 * src/maemo/modest-msg-edit-window.c:
1001 (modest_msg_edit_window_attach_file_noninteractive):
1002 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1003 to prevent a hang. I don't quite understand why these are necessary,
1004 beause we should already be in the main loop. I guess something outside
1005 of the main loop is taking the lock.
1007 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1008 we are really using URIs, and use files that are more likely to exist.
1010 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1012 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1013 necessary because configure.ac now defines different variables.
1015 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1017 * libmodest-dbus-client/libmodest-dbus-client.c:
1018 * libmodest-dbus-client/libmodest-dbus-client.h:
1019 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1020 libmodest_dbus_client_compose_mail() is what things actually use.
1022 * src/dbus_api/modest-dbus-api.h:
1023 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1024 * tests/dbus_api/Makefile.am:
1025 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1028 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1030 * src/modest-init.c: (modest_init_local_folders):
1031 For memory-card (or other non local-folders) maildir accounts,
1032 always create an Archive folder, so that there is somewhere to put
1033 messages. This should be less confusing, because the user does not need
1034 to guess that the need to create a folder.
1036 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1038 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1039 Fixed icon size by using (50, 50) which is the same as defined by
1042 2007-06-25 Armin Burgmeier <armin@openismus.com>
1044 * src/widgets/modest-window-mgr.c:
1045 * src/modest-init.c:
1046 * configure.ac: Correctly recognize hildon-notify presence and fixed
1047 the build without it being installed.
1049 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1051 * libmodest-dbus-client/libmodest-dbus-client.c:
1052 (libmodest_dbus_client_search): Fix the build. Sorry.
1053 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1054 (reply_forward_cb): Initialize variables to fix the build.
1056 * src/modest-tny-account-store.c:
1057 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1058 comparison (a silly typo) so that email search results can be opened
1059 when there are more than one account.
1061 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1063 * libmodest-dbus-client/libmodest-dbus-client.c:
1064 (libmodest_dbus_client_search),
1065 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1066 instead of 1 second, because the search gets folders and messages from
1067 the server, which can take a long time. When it times out,
1068 osso-global-search will report no results.
1070 We need to specify whether we should search only cached information
1071 (maybe with a user preference), and the osso-email-search-plugin
1072 API should really be improved to allow that option, and to allow results
1073 to be delivered asynchronously in batches.
1075 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1077 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1078 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1079 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1081 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1083 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1084 that is an empty string. D-Bus seems to give us these instead of NULL.
1086 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1088 * src/dbus_api/modest-dbus-callbacks.c:
1089 * src/maemo/easysetup/modest-easysetup-wizard.h:
1090 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1091 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1092 (modest_connection_specific_smtp_edit_window_init):
1093 * src/maemo/modest-maemo-global-settings-dialog.c:
1095 * src/maemo/modest-maemo-utils.c:
1096 (modest_maemo_utils_setup_images_filechooser):
1097 * src/maemo/modest-main-window.c: (create_details_widget):
1098 * src/maemo/modest-msg-edit-window.c:
1099 (modest_msg_edit_window_attach_file_noninteractive),
1100 (modest_msg_edit_window_color_button_change),
1101 (modest_msg_edit_window_set_zoom):
1102 * src/modest-mail-operation.c: (update_account_thread):
1103 * src/modest-tny-account-store.c:
1104 * src/modest-tny-account.c:
1105 * src/widgets/modest-global-settings-dialog.c:
1106 * src/widgets/modest-window.h:
1108 Fixed build on bora!
1110 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1112 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1113 * src/modest-search.c: (modest_search_folder),
1114 (modest_search_all_accounts): Actually search only in the specified folder,
1115 doing a simple match on the folder ID.
1116 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1117 and added some documentation.
1119 2007-06-22 Armin Burgmeier <armin@openismus.com>
1121 * src/maemo/modest-maemo-utils.h:
1122 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1123 modest_maemo_utils_get_supported_secure_authentication_methods.
1125 * src/maemo/easysetup/modest-easysetup-wizard.c:
1126 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1127 one occured, not just "Server does not support secure authentication".
1129 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1131 * src/modest-tny-account-store.c: (get_password):
1132 Restored the call to tny_account_set_user() because Philip seems to have
1133 stopped this from crashing (by not using the freed string). It still does
1134 not work, but now we can test it.
1136 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1138 * src/maemo/modest-msg-edit-window.c: (init_window):
1139 Comment out use of an uninitialzed GtkScrolledWindow variable,
1140 to fix the build and stop a crash. Yet again.
1142 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1144 * src/modest-tny-account-store.c: (get_password):
1145 Remove the call to tny_account_set_user() because this actually crashes.
1146 As mentioned in the last commit, it is known to not work anyway.
1148 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1150 * src/modest-tny-account-store.c: (get_password):
1151 Use tny_account_set_username() to tell tinymail that the username might
1152 have changed too. But tinymail ignores this: see projects.maemo.org
1154 * src/modest-ui-actions.c:
1155 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1156 reset the connection when changing the username, and improve the comments.
1157 Save the changed username to gconf at least, so it is used when Modest is
1160 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1162 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1163 Do not use a query, so that we get all folders, including for POP and
1164 local-folders. They work as search criteria too.
1165 This fixes projects.maemo.org bug NB#57740.
1167 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1169 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1170 Comment out the use of hildon_notification_set_sound() because it is
1171 not declared, to fix the build. Warnings are serious, people.
1173 2007-06-21 Armin Burgmeier <armin@openismus.com>
1175 * src/maemo/modest-maemo-utils.h:
1176 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1177 modest_maemo_utils_get_supported_secure_authentication_methods()
1178 to query authentication methods for a specific user. This should fix
1179 projects.maemo.org bug NB#61369.
1181 * src/maemo/easysetup/modest-easysetup-wizard.c:
1182 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1185 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1187 * libmodest-dbus-client/libmodest-dbus-client.h:
1188 * libmodest-dbus-client/libmodest-dbus-client.c:
1189 (modest_dbus_message_iter_get_search_hit),
1190 (libmodest_dbus_client_search):
1191 Reorganised and commented this.
1192 Removed modest_search_hit_free() from the public API because it
1195 Added libmodest_dbus_client_get_folders() and
1196 modest_folder_result_list_free().
1198 * src/dbus_api/modest-dbus-api.h:
1199 * src/dbus_api/modest-dbus-callbacks.c:
1200 (modest_dbus_req_filter): Commented. Moved most code to
1201 on_dbus_method_search() and added on_dbus_method_get_folders().
1203 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1204 of the extra D-Bus handler.
1206 * tests/dbus_api/Makefile.am:
1207 * tests/dbus_api/test_get_folders.c: New test for
1208 libmodest_dbus_client_get_folders(). This seems to return an empty list
1209 at the moment. That could be the same error that causes the message list
1210 to be empty sometimes.
1211 This should help with projects.maemo.org bug NB#57740.
1213 2007-06-21 Armin Burgmeier <armin@openismus.com>
1215 * src/modest-mail-operation.c: Do not call
1216 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1217 notify the operation's end after having set the status to CANCELED for
1218 the operation queue to listen on. This fixes a deadlock when there
1219 were mail operations in the queue during its finalization.
1221 * src/modest-singletons.c: Reordered uninitialization of the account
1222 manager to happen after the mail operation queue was uninitialized
1223 because the mail operation's in the queue might still try to access
1224 the account manager (see modest_mail_operation_notify_end()). This
1225 fixes a potential crash when terminating the application.
1227 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1229 * src/modest-search.c:
1230 (search_mime_part_and_child_parts): Moved some code here so we
1231 can search recursively in child folders.
1232 (modest_search_folder): Search in the message as a mime part, instead
1233 of just its child mime parts.
1234 (read_chunk), (search_mime_part_ogs):
1235 Check how many bytes were read, to prevent an endless loop.
1236 Searching in message bodies now works. This finishes the fix for
1237 projects.maemo.org bug NB#61007.
1239 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1241 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1242 Add a g_warning when the item is not a folder.
1244 * src/modest-ui-dimming-rules.c:
1245 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1246 when selected item is not a folder (for instance, an account), because
1247 the UI spec only talks about folders.
1248 I am not sure what the UI spec wants, so this might not totally fix
1249 projects.maemo.org bug NB#60794.
1251 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1253 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1254 (load_from_file): Sort the list. The unsorted list would be more noticeable
1255 in non-English locales.
1257 * src/maemo/modest-msg-edit-window.c:
1258 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1259 warning and fix the build.
1261 * src/maemo/modest-progress-bar-widget.c:
1262 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1263 avoid a g_warning, and probably to avoid a crash.
1265 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1267 * src/modest-search.c: (modest_search_folder): Check for a GError
1268 when calling tny_folder_get_headers(), to show that this is not the cause
1271 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1273 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1274 Actually set the body query instead of the subject query.
1276 * src/modest-search.c: (search_mime_part_ogs),
1277 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1278 which would probably cause it to fail if we got this far.
1280 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1281 to simplify the code.
1282 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1283 be causing search-in-body to fail.
1285 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1287 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1289 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1290 Better debug message when the folder cannot be found.
1291 This should help with fixing projects.maemo.org bug #61287.
1292 * src/modest-search.c: (add_hit): Do not leak the furl string.
1294 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1296 * src/modest-ui-actions.c:
1297 (modest_ui_actions_on_folder_selection_changed):
1298 Do not special-case TNY_MERGE_FOLDER here, because
1299 modest_tny_folder_get_account() already does that. This fixes
1300 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1301 shown when the Outbox was selected).
1303 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1305 * libmodest-dbus-client/libmodest-dbus-client.c:
1306 (_dbus_iter_get_string_or_null): Initialize the string variable in
1307 case this helps with Dirk's crash.
1309 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1311 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1312 though it is not implemented yet (this function is maybe not even used),
1313 to avoid breaking ABI in future.
1314 * libmodest-dbus-client/libmodest-dbus-client.c:
1315 (get_attachments_string): Moved some code into this generic function.
1316 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1317 sends email. It is maybe not used.
1318 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1319 (on_send_mail): Use attachments.
1321 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1322 * src/maemo/modest-msg-edit-window.c:
1323 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1324 a filename before using it, to fix projects.maemo.org bug NB#58233.
1326 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1328 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1329 Initialize the continue_download variable to fix the build, and probably
1330 to fix randome behaviour.
1332 2007-06-18 Armin Burgmeier <armin@openismus.com>
1334 * src/modest-tny-send-queue.h:
1335 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1336 the queue so we can later show it in the UI. Replaced
1337 modest_tny_send_queue_msg_is_being_sent() by
1338 modest_tny_send_queue_get_msg_status().
1340 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1342 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1343 gpointer. This probably was not harmful, but just to be sure.
1345 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1347 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1348 Fix the build, but leave the function broken on Bora, because
1349 hildon_uri_action_get_service() does not exist.
1350 osso_uri_action_get_service() does not exist either, it seems.
1352 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1354 * src/modest-tny-account.c:
1355 (modest_tny_account_new_from_server_account):
1356 Uncommented the url debug output again, because it is useful for
1357 debugging, as I said in the comment.
1359 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1361 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1363 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1364 for Mameo Bora, to fix the build.
1366 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1369 Fixed build with hildon < 0.99
1371 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1372 Check if the selected account is busy instead of checking all accounts
1374 * src/modest-account-mgr-priv.h:
1375 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1376 (modest_account_mgr_init), (compare_account_name),
1377 (modest_account_mgr_set_account_busy),
1378 (modest_account_mgr_account_is_busy):
1379 * src/modest-account-mgr.h:
1380 Added busy information to the account manager. It possible to
1381 set an account to busy or not busy now.
1383 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1384 (modest_mail_operation_update_account),
1385 (modest_mail_operation_notify_end):
1386 Set the account to busy/not busy depending on the operation state.
1388 * src/widgets/modest-account-view.c:
1389 (modest_account_view_finalize), (get_last_updated_string),
1390 (update_account_view), (on_account_busy_changed), (init_view):
1391 Show string "Refreshing..." if the account is currently busy.
1393 All this fixes projects.maemo.org bug NB#59711
1395 2007-06-14 Armin Burgmeier <armin@openismus.com>
1397 * src/widgets/modest-attachments-view.h:
1398 * src/widgets/modest-attachments-view.c: Added
1399 modest_attachments_view_has_attachments() and fixed coordinate
1400 transformation in get_att_view_at_coords(). This fixes attachment
1403 * src/widgets/modest-msg-view.c: Make use of
1404 modest_attachments_view_has_attachments() to decide whether to show
1405 attachments in the header.
1407 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1409 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1410 (on_change), (on_combo_security_changed),
1411 (modest_connection_specific_smtp_edit_window_init),
1412 (modest_connection_specific_smtp_edit_window_set_connection),
1413 (modest_connection_specific_smtp_edit_window_is_dirty):
1414 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1415 * src/maemo/modest-connection-specific-smtp-window.c:
1418 Show an comfirmation dialog for the smpt-edit-window if there are
1419 unsaved changes and the user hits cancel.
1420 (projects.maemo.org bug NB#60479)
1422 2007-06-14 Armin Burgmeier <armin@openismus.com>
1424 * src/maemo/easysetup/modest-easysetup-wizard.c:
1425 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1426 address" info in banner instead of node, and select all the text as
1427 per UI spec. This fixes projects.maemo.org bug NB#60550.
1429 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1431 reviewed by: <delete if not using a buddy>
1433 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1434 * src/modest-ui-actions.c: (folder_refreshed_cb):
1436 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1438 * src/widgets/modest-folder-view.c: (filter_row):
1439 Explictly filter out the per-account outbox accounts. I don't know why
1440 these only sometimes show up, but now they should never show up in the UI.
1441 This should fix projects.maemo.org bug NB#60160.
1443 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1445 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1446 when the toolbar does not exist yet.
1447 * src/modest-widget-memory.c: (save_settings_header_view):
1448 Added g_warnings() to help us to discover when we are trying to set
1449 an empty columns list in gconf.
1451 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1453 * src/modest-init.h:
1454 * src/modest-init.c:
1455 Added modest_init_get_default_header_view_column_ids().
1457 * src/modest-widget-memory.c: (restore_settings_header_view):
1458 Use the new function to get defaults, if the gconf key is empty,
1459 instead of not creating any columns. This seems to fix the
1460 empty right-hand pane problems.
1462 * src/widgets/modest-header-view.h: Improved documentation.
1464 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1466 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1467 Revert the use of the display name as the account name, because this
1468 is generally wrong and would break the code that follows.
1470 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1472 * src/maemo/easysetup/modest-easysetup-wizard.c:
1473 (check_for_supported_auth_methods), (on_before_next),
1476 More correct fix for projects.maemo.org bug NB# 58991
1477 Do not longer accept AUTH_PASSWORD as secure method and choose
1478 correct method when creating the account.
1480 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1482 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1483 Fixed projects.maemo.org bug NB# 58991
1485 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1487 * src/modest-init.c: (modest_init_init_core),
1488 (modest_init_local_folders): Fixed compilation errors.
1490 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1492 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1493 Remove unnecessary lib/include, though it is good in principle when needed.
1495 * src/modest-init.c: (modest_init_one_local_folder),
1496 (modest_init_local_folders):
1497 * src/modest-init.h: Initialize the .modest library for memory cards,
1498 instead of just doing nothing for them. This should allow us to create
1499 folders there, fixing projects.maemo.org bug NB#59297.
1501 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1503 * libmodest-dbus-client/libmodest-dbus-client.c:
1504 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1505 (libmodest_dbus_client_compose_mail),
1506 (libmodest_dbus_client_open_message),
1507 (libmodest_dbus_client_send_and_receive),
1508 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1510 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1511 (on_idle_open_message), (modest_dbus_req_handler),
1512 (search_result_to_message), (modest_dbus_req_filter):
1513 * src/modest-search.c: (add_hit), (modest_search_folder),
1514 (modest_search_all_accounts): Improved debug messages.
1516 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1518 * src/modest-tny-account-store.c:
1519 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1522 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1525 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1527 * src/modest-tny-account-store.c: (get_server_accounts):
1528 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1529 even when there are no accounts, so that the Outbox folder is always
1530 visible. This fixes projects.maemo.org bug NB#60158.
1532 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1534 * src/maemo/modest-main-window.c: (create_details_widget):
1535 Use the mcen_va_never logical ID.
1537 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1539 * src/dbus_api/modest-dbus-api.h:
1540 * src/dbus_api/modest-dbus-callbacks.c:
1541 (on_idle_open_default_inbox), (on_open_default_inbox),
1542 (modest_dbus_req_handler):
1543 Added a new OpenDefaultInbox method.
1545 * libmodest-dbus-client/libmodest-dbus-client.h:
1546 * libmodest-dbus-client/libmodest-dbus-client.c:
1547 Added libmodest_dbus_client_open_default_inbox() to call the new
1548 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1549 though it should maybe be used by a new osso-email-interface function.
1551 * tests/dbus_api/Makefile.am:
1552 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1555 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1557 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1558 NULL, so that the signals get all the keys. This should not actually
1559 change any behaviour because we currently update everything when anything
1562 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1564 * src/widgets/modest-folder-view.c: (text_cell_data),
1565 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1566 (find_inbox_iter): If tinymail tells us that the folder is
1567 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1568 This causes the inbox to be selected at startup, fixing part of
1569 projects.maemo.org bug NB#56305.
1571 * src/modest-ui-dimming-rules.c:
1572 (modest_ui_dimming_rules_on_tools_smtp_servers):
1573 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1574 the SMTP servers menu item.
1575 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1576 that the SMTP Servers menu item is dimmed when there are no accounts,
1577 as a future version of the UI spec will require. This fixes
1578 projects.maemo.org bug NB#56305.
1580 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1582 * src/maemo/modest-maemo-utils.c:
1583 (modest_maemo_utils_get_supported_secure_authentication_methods):
1584 Added label to dialog instead of unreadable title
1586 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1587 (modest_main_window_new):
1588 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1591 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1592 * src/modest-account-mgr.h:
1593 Added method to avoid code duplication
1595 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1596 (modest_ui_actions_on_send_receive):
1597 Use modest_account_mgr_has_accounts
1599 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1601 * src/maemo/easysetup/modest-presets.c:
1602 (modest_presets_get_info_server_security): Do not report secure auth
1604 * src/modest-protocol-info.c: Use the defines for the gconf key names
1605 for secure authentication. This was not working because we were writing
1606 Password and reading password, and the check was case sensitive.
1607 With this, gmail now works for receiving and sending when created via
1610 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1612 * src/maemo/easysetup/modest-presets.c:
1613 (modest_presets_get_info_server_security): Correct the key name for
1614 SecureSmtp, because it seems to be case-sensitive.
1615 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1616 Do not try to get the 0th notebook page if there are 0 pages, to
1617 avoid a g_warning().
1619 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1621 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1622 Prevent use of the new notification feature for now, because it currently
1623 shows one dialog for each new email, which is annoying.
1625 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1627 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1628 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1629 when no country was selected, so that we show the global ones.
1630 * src/maemo/easysetup/modest-presets.c:
1631 (modest_presets_get_providers): Return only the global providers, not
1632 all providers when mmc=0 was requested.
1634 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1636 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1637 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1638 provider ID in the combo.
1640 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1641 Do not show the page numbers, because it would be confusing when we add
1642 the 2 extra pages for the custom setup, when the user chooses the "Other"
1643 provider. This fixes projects.maemo.org bug NB#59028
1645 * src/modest-init.c: (modest_init_init_core),
1646 (modest_init_local_folders):
1647 * src/modest-init.h:
1648 * src/modest-tny-account.c:
1649 (modest_tny_account_new_for_local_folders): Do not create default folders
1650 for the memory card. This should fix projects.maemo.org bug NB#59328.
1652 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1654 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1655 Free the changed_conf_keys string items. They are already freed in the
1656 idle handler if that runs first.
1658 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1660 * src/modest-ui-actions.c:
1661 (modest_ui_actions_on_password_requested): Check that the server name
1662 is not NULL, because I just saw a password dialog with (null) as the
1665 * src/modest-tny-folder.[h|c]: Added
1666 modest_tny_folder_is_memory_card_folder().
1667 * src/modest-ui-dimming-rules.c:
1668 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1669 menu item for memory cards, as per the UI spec (section 7.4). This should
1670 fix projects.maemo.org bug NB#59297.
1672 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1674 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1675 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1676 is another problem with the code, see Murray's comment at line 772)
1678 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1680 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1681 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1682 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1683 (load_from_file), (easysetup_country_combo_box_init),
1684 (easysetup_country_combo_box_get_active_country_ids),
1685 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1686 instead of just one ID, to avoid duplicate country names in the UI.
1688 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1689 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1690 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1691 a single ID, avoiding duplicate providers.
1692 * src/maemo/easysetup/modest-easysetup-wizard.c:
1693 (on_combo_account_country): Adapt to use a list.
1695 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1697 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1698 keys changed in the last X seconds.
1700 * src/modest-account-mgr.h:
1701 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1702 (on_key_change), (modest_account_mgr_class_init),
1703 (modest_account_mgr_init), (modest_account_mgr_finalize):
1704 As the keys are changed, save them in a GSList* and signal that GSList*
1705 further every X seconds, to batch changes, to allow us to do just one
1706 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1707 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1709 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1710 changed signal signature.
1712 * src/modest-conf.c: (modest_conf_set_list),
1713 (modest_conf_on_change): Reenable notification.
1715 (modest_conf_maemo_fake_on_change): Comment out the hack that
1716 notified immediately instead of asynchronously.
1718 * src/widgets/modest-account-view.h:
1719 * src/widgets/modest-account-view.c:
1720 (update_account_view): Select the previously-selected account ID,
1721 if possible. This fixes projects.maemo.org bug NB#56933.
1723 (on_account_changed), (on_account_removed),
1724 (modest_account_view_select_account):
1726 Remove the block/unblock functions
1727 because they were not useful.
1729 * src/maemo/modest-account-view-window.c:
1730 (on_delete_button_clicked), (on_edit_button_clicked),
1731 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1733 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1735 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1736 Improve the error dialog to show Incorrect Account Settings, which seems
1737 clearer, and say that the internal error message (to be removed from the
1738 dialog later) is often misleading.
1739 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1741 * src/modest-tny-account.c:
1742 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1743 URL because this is so useful for debugging on the device.
1745 * src/widgets/modest-serversecurity-combo-box.c:
1746 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1748 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1750 * src/modest-mail-operation.c:
1751 (modest_mail_operation_send_new_mail):
1752 Added a comment about a nasty but apparently harmless message. Details
1753 added to the wiki g_warnings() page.
1755 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1757 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1758 (modest_tny_send_queue_class_init):
1759 Do not use the priv struct because it is empty, to avoid g_warnings
1760 about a non-existant priv struct.
1762 * src/modest-tny-account-store.c:
1763 (modest_tny_account_store_get_server_account),
1764 (modest_tny_account_store_get_transport_account_for_open_connection
1765 ): Do not try to get transport server accounts for local folders,
1766 because they don't have any. This avoids a g_warning().
1768 * src/maemo/modest-main-window.c:
1769 (modest_main_window_notify_send_receive_initied),
1770 (on_configuration_key_changed):
1771 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1772 * src/modest-defs.h:
1773 * src/modest-mail-operation.c:
1774 (modest_mail_operation_update_account):
1775 * src/modest-tny-account-store.h:
1776 * src/modest-tny-account.c:
1777 (modest_tny_account_get_special_folder),
1778 (modest_tny_account_new_for_local_folders),
1779 (modest_tny_account_new_for_per_account_local_outbox_folder):
1780 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1781 * src/modest-tny-local-folders-account.c:
1782 (add_account_folders_to_merged_folder):
1783 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1784 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1785 (modest_ui_actions_on_send):
1786 * src/widgets/modest-folder-view.c: (update_model):
1787 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1788 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1789 modest_tny_account_store_get_tny_account_by_account() to
1790 modest_tny_account_store_get_server_account() to make the code clearer.
1792 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1794 * src/dbus_api/modest-dbus-api.h:
1795 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1796 * src/maemo/modest-msg-edit-window.c:
1797 (modest_msg_edit_window_attach_file_noninteractive):
1798 added g_warning in case the file to be attached does not exist
1799 * tests/dbus_api/test_compose_mail.c: (main):
1800 removed obsolete comment, added generic files as test case
1802 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1804 * src/modest-tny-account-store.c: (get_server_accounts):
1805 Create the local folders account only once, not once for each outbox, and
1806 not only when there are some outboxes.
1808 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1810 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1811 code that is causing a crash at startup. Sergio says that he is fixing this.
1813 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1815 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1816 * src/maemo/modest-account-settings-dialog.c:
1817 (create_page_outgoing),
1818 (modest_account_settings_dialog_set_account_name),
1819 (save_configuration):
1820 - Fixed handling of the "Use secure authentication" toggle to comply with
1821 the ui specification. See also projects.maemo.org bug NB#58400
1823 - Restore the Secure connection setting combo correctly when loading
1826 * src/maemo/modest-maemo-utils.c:
1827 (on_camel_account_get_supported_secure_authentication),
1828 (modest_maemo_utils_get_supported_secure_authentication_methods):
1829 Fixed a crasher if operation is canceled
1831 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1832 (modest_protocol_info_auth_is_secure):
1833 * src/modest-protocol-info.h:
1835 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1836 the sense of the "Use secure authentication" toggle.
1838 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1840 * src/modest-tny-account-store.h:
1841 * src/modest-tny-account-store.c:
1842 Added modest_tny_account_store_get_local_folders_account().
1844 * src/modest-tny-folder.h:
1845 * src/modest-tny-folder.c:
1846 (modest_tny_folder_get_account):
1847 Added this replacement for tny_folder_get_account() which returns
1848 the local-folders account for TnyMergeFolders, to avoid the
1849 warning about the unimplemented get_account_func() vfunc().
1851 (modest_tny_folder_get_rules),
1852 * src/modest-ui-actions.c:
1853 (modest_ui_actions_on_folder_selection_changed):
1854 * src/modest-mail-operation.c:
1855 (modest_mail_operation_remove_folder),
1856 (modest_mail_operation_xfer_folder),
1857 (modest_mail_operation_rename_folder),
1858 (modest_mail_operation_get_msg),
1859 (modest_mail_operation_get_msgs_full),
1860 (modest_mail_operation_remove_msg),
1861 (modest_mail_operation_xfer_msgs),
1862 (modest_mail_operation_refresh_folder):
1863 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1865 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1867 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1868 (modest_server_account_set_security):
1869 * src/modest-defs.h: Add comments explaining that our
1870 UI spec means TLS when it says Normal, so these do not look like errors.
1872 * src/modest-tny-account.c:
1873 (modest_tny_account_new_from_server_account): Use the new tinymail
1874 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1875 for TLS. This should fix projects.maemo.org bug NB#58460.
1877 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1879 * src/maemo/easysetup/modest-easysetup-wizard.c:
1880 (create_account): Correct the position of the gconf sanity check warning.
1881 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1882 of using the g_idle_add() hack, because this does not seem to be necessary
1883 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1884 caused by something other than maemo's gconf.
1885 This fixes projects.maemo.org bug #59022.
1887 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1889 * src/modest-account-mgr-helpers.c:
1890 (modest_account_mgr_get_default_account): Do not check that the account
1891 exists if there is no default account (NULL), to fix a runtime warning.
1893 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1895 * src/widgets/modest-folder-view.c: (update_model):
1896 Do not unref the treemodel before we have finished with it.
1897 This prevents a valgrind warning and an occasional crash at startup.
1899 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1901 * libmodest-dbus-client/libmodest-dbus-client.h:
1902 added libmodest_dbus_client_compose_mail()
1903 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1905 added functions needed for SendAsMail() functionality
1906 * src/maemo/modest-msg-edit-window.c:
1907 (modest_msg_edit_window_attach_file_noninteractive):
1908 non interactively attaching files to message edit window
1909 * src/widgets/modest-msg-edit-window.h:
1910 * tests/dbus_api/Makefile.am:
1911 added test_compose_mail.c
1912 * tests/dbus_api/test_compose_mail.c: (main):
1914 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1916 * src/modest-account-view.c:
1917 Fixed bug projects.maemo.org bug NB#59307
1919 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1921 * src/maemo/easysetup/modest-easysetup-wizard.c:
1922 (get_serverport_incoming), (on_before_next), (create_account):
1923 * src/maemo/modest-account-settings-dialog.c:
1924 (modest_account_settings_dialog_set_account_name):
1925 * src/maemo/modest-maemo-utils.c:
1926 (on_camel_account_get_supported_secure_authentication_status),
1927 (on_camel_account_get_supported_secure_authentication),
1928 (on_secure_auth_cancel),
1929 (modest_maemo_utils_get_supported_secure_authentication_methods):
1931 Implemented security authentication for settings and easysetup.
1933 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1935 * src/maemo/modest-main-window.c: (create_details_widget):
1936 Show the total size for memory card accounts too, instead of showing
1937 the name again. Fixes bug projects.maemo.org bug NB#59307.
1939 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1942 * src/modest-tny-simple-folder-store.c:
1943 * src/modest-tny-simple-folder-store.h: Removed.
1945 * src/modest-tny-local-folders-account.h
1946 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1947 for the local-folders maildir, with an extra TnyMergedFolder containing
1948 the folders of the per-account outbox store accounts.
1949 * src/modest-tny-account-store.c: (get_server_accounts):
1950 Add the outboxes to the special local folders account after creating it.
1952 * src/modest-tny-account.c:
1953 (modest_tny_account_new_for_local_folders): Create the derived
1954 account when creating the main local-folders account.
1956 * src/maemo/modest-main-window.c: (create_details_widget),
1957 (modest_main_window_set_contents_style):
1958 Adapted to the use of the derived account instead of the folder store.
1960 * src/modest-ui-actions.c:
1961 (modest_ui_actions_on_folder_selection_changed):
1962 * src/modest-ui-dimming-rules.c:
1963 (modest_ui_dimming_rules_on_new_folder):
1964 * src/widgets/modest-folder-view.c: (text_cell_data),
1965 (icon_cell_data), (filter_row), (update_model),
1966 (get_cmp_rows_type_pos):
1969 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1970 Do not get the priv struct, because no priv struct has been set,
1971 to avoid a runtime warning.
1973 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1974 #ifelse with #else, to fix a warning, to fix the build.
1977 2007-06-05 Christian Kellner <ckellner@openismus.com>
1979 * libmodest-dbus-client/libmodest-dbus-client.c:
1980 Fix small typo in doc (why do you always see them
1981 AFTER committing stuff?)
1984 2007-06-05 Christian Kellner <ckellner@openismus.com>
1986 * libmodest-dbus-client/libmodest-dbus-client.c:
1987 (libmodest_dbus_client_search):
1988 Initialize hit list with NULL. Also set folder list
1989 to "" if NULL was supplied.
1992 2007-06-03 Christian Kellner <ckellner@openismus.com>
1994 * libmodest-dbus-client/libmodest-dbus-client.c:
1995 (modest_search_hit_list_free):
1996 Make it save to call it with NULL.
1998 * src/dbus_api/modest-dbus-callbacks.c:
1999 * src/modest-search.c:
2000 Return full ModestSearchHits as the search result list not TnyHeader
2001 since can't be around withouth the correspoding TnyFolder.
2003 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2005 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2006 Added currently commented code to check for secure auth
2008 * src/maemo/modest-account-settings-dialog.c: (on_response),
2009 (save_configuration), (show_ok):
2010 Fixed projects.maemo.org bugs NB #59248 and #59251
2012 * src/maemo/modest-maemo-utils.c:
2013 (on_camel_account_get_supported_secure_authentication_status),
2014 (on_camel_account_get_supported_secure_authentication),
2015 (modest_maemo_utils_get_supported_secure_authentication_methods):
2016 * src/maemo/modest-maemo-utils.h:
2017 Moved get_supported_secure_authentication() method here to be able
2018 to use it from easysetup wizard.
2020 * src/modest-pair.c: (on_pair_compare_as_string):
2021 Should compare string with first part of pair and not
2022 strcmp pairs which will crash.
2024 * src/modest-protocol-info.c:
2025 (modest_protocol_info_protocol_is_store):
2026 * src/modest-protocol-info.h:
2027 Added modest_protocol_info_get_auth_protocol_name()
2029 2007-06-03 Armin Burgmeier <armin@openismus.com>
2031 * src/modest-mail-operation.c:
2032 (modest_mail_operation_get_msgs_full): Set priv->account also when
2033 only retrieving a single message. This avoids a crash when canceling
2036 (modest_mail_operation_notify_end): Do not explicitely remove the
2037 operation from the queue but only emit the progress_changed signal.
2038 The queue itself listens to that signal to remove the operation when
2039 it is finished. This reduces coupling and removes a potential deadlock
2040 when modest_mail_operation_notify_end() is called from the queue
2041 itself. If that is a problem performance-wise, I would suggest to
2042 implement a status-changed signal or something.
2044 * src/modest-mail-operation-queue.c: Make sure to never call a
2045 function from another file while the queue is locked. This (hopefully)
2046 fixes another deadlock when exiting the application while retrieving
2049 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2051 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2052 Fixed build if libogs is not available
2054 2007-06-03 Christian Kellner <ckellner@openismus.com>
2056 * libmodest-dbus-client/libmodest-dbus-client.h:
2057 * libmodest-dbus-client/libmodest-dbus-client.c:
2058 (libmodest_dbus_client_delete_message):
2059 Implement deletion of messages (Client side).
2061 (modest_search_hit_free),
2062 (modest_search_hit_list_free):
2063 Utility functions to free the result hits.
2065 * src/dbus_api/modest-dbus-api.h:
2066 * src/dbus_api/modest-dbus-callbacks.c:
2067 (on_delete_message),
2068 (modest_dbus_req_handler):
2069 Implement deletion of messages (Server side).
2071 * tests/dbus_api/test_search.c: (main):
2074 * tests/dbus_api/Makefile.am:
2075 * tests/dbus_api/test_delete_message:
2076 Add little test for the message deletion logic
2078 2007-06-03 Armin Burgmeier <armin@openismus.com>
2080 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2081 when the operation queue was not empty. projects.maemo.org bug
2084 2007-06-03 Armin Burgmeier <armin@openismus.com>
2086 * src/widgets/modest-account-view.c
2087 (on_account_default_toggled): Toggle default account column
2088 explicitely instead of waiting for gconf notification (which is
2089 currently ignored). This should fix projects.maemo.org bug NB#56910
2090 for now. It should probably be removed when gconf notifications are
2093 2007-06-03 Christian Kellner <ckellner@openismus.com>
2095 * libmodest-dbus-client/libmodest-dbus-client.c:
2096 Removed debugging spew.
2098 * src/dbus_api/modest-dbus-callbacks.c:
2099 Added debugging info.
2101 * src/modest-search.c:
2102 (modest_search_all_accounts):
2103 Use tny_account_store_get_accounts () on the account store
2104 to get all accounts which is the way to get all accounts.
2106 * tests/dbus_api/test_search.c: (main):
2107 Make it possible to supply the search term on the command line.
2109 2007-06-03 Christian Kellner <ckellner@openismus.com>
2111 * libmodest-dbus-client/libmodest-dbus-client.c:
2112 * libmodest-dbus-client/libmodest-dbus-client.h:
2113 Implement searching for mesages over raw dbus. (Client side)
2115 * src/dbus_api/Makefile.am:
2116 * src/dbus_api/modest-dbus-api.h:
2117 * src/dbus_api/modest-dbus-callbacks.c:
2118 * src/dbus_api/modest-dbus-callbacks.h:
2119 Search framework (Server side). Also implement on_idle_open_message().
2121 * src/maemo/modest-platform.c: (modest_platform_init):
2122 Prepare for raw dbus/osso rpc interaction.
2124 * src/modest-search.h:
2125 Changed minsize from unspecific guint to guint32.
2127 * src/modest-search.c:
2129 Added strange hack which magically made tnymail work.
2131 (modest_search_folder),
2132 (modest_search_account),
2133 (modest_search_all_accounts):
2134 Implement helper functions to search all accounts, specific account
2137 * tests/dbus_api/Makefile.am:
2138 * tests/dbus_api/test_open_message.c:
2139 Read url to open from commandline.
2141 * tests/dbus_api/test_search.c:
2142 Implement small test for dbus search stuff
2144 2007-06-02 Armin Burgmeier <armin@openismus.com>
2146 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2147 include account type and account title. This fixes projects.maemo.org
2150 * src/maemo/modest-account-view-window.c: Set a title for the window.
2152 2007-06-02 Armin Burgmeier <armin@openismus.com>
2154 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2155 incoming and outgoing server name based on email address and server
2156 types as long as the names have not been edited manually. This fixes
2157 projects.maemo.org bug NB#58671.
2159 2007-06-02 Armin Burgmeier <armin@openismus.com>
2161 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2162 server type cannot be changed in future to the incoming details page
2163 when creating an account. This fixes projects.maemo.org bug NB#59029.
2165 2007-06-02 Armin Burgmeier <armin@openismus.com>
2167 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2168 and assigned max width chars so that they wrap instead of being
2169 truncated. Fixes projects.maemo.org bug NB#56126.
2171 2007-06-02 Armin Burgmeier <armin@openismus.com>
2173 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2174 introductory note to the connection specific smtp servers dialog, as
2175 section 8.12 of the email UI specification requires. This fixes
2176 projects.maemo.org bug NB#59212.
2178 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2180 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2181 Check for running mail operations, and offer to cancel them, as per the UI
2182 spec. This fixes projects.maemo.org bug NB#59041 .
2183 However, I suspect that tinymail may still use the network connection
2184 in ways that we cannot detect or cancel. But it should at least adapt to
2185 changes fairly well.
2187 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2189 * src/modest-tny-account-store.c: (recreate_all_accounts),
2190 (get_cached_accounts), (get_server_accounts): Do more sensible
2191 ref-counting of the temporarily-cached outbox accounts list. This seems
2192 to fix a crash when entering the password when the password was wrong.
2194 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2196 * src/gnome/modest-main-window.c: (connect_signals):
2197 * src/modest-tny-account-store.c: (get_password),
2198 (modest_tny_account_store_alert): Added comments and clues and
2199 commented-out code about how we currently fail to deal with connection
2200 errors and wrong passwords, and how we should.
2202 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2204 * src/widgets/modest-retrieve-combo-box.c:
2205 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2206 This fixes projects.maemo.org bug NB#58472 .
2208 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2210 * src/maemo/easysetup/modest-easysetup-wizard.c:
2211 (create_page_complete_easysetup):
2212 (create_page_complete_custom): Correct the last commit,
2213 putting the correct sentences in the correct pages.
2215 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2217 * src/maemo/easysetup/modest-easysetup-wizard.c:
2218 (create_page_complete_custom): Show the second sentence of text
2219 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2222 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2224 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2225 Set the leave-on-server conf key by default. This fixes
2226 projects.maemo.org bug NB#59258 .
2228 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2230 * src/maemo/modest-account-view-window.c:
2231 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2232 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2235 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2237 * src/maemo/easysetup/modest-easysetup-wizard.c:
2238 (create_caption_new_with_asterisk):
2239 * src/maemo/modest-account-settings-dialog.c:
2240 (create_caption_new_with_asterisk):
2241 Uncomment the code to add the asterisk, because they are no longer in the
2242 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2243 (update_incoming_server_title): Add an asterisk here too.
2245 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2247 * src/maemo/modest-maemo-global-settings-dialog.c:
2248 (current_connection): Check that we are even connected before trying to
2249 get the current connection name, to prevent a warning.
2251 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2252 Change the comments because tny_maemo_conic_device_connect() is now meant to
2254 * src/modest-mail-operation.c:
2255 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2256 make sure we have a connection and fail if we can't connect.
2258 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2260 * src/maemo/modest-main-window.c:
2261 (on_account_store_connecting_finished): Do not try to get the
2262 connection ID if we are not really connected. I am surprised that
2263 this signal handler is called when we are not connected.
2265 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2267 * src/modest-error.h:
2268 * src/modest-ui-actions.c:
2269 (modest_ui_actions_get_msgs_full_error_handler):
2270 Renamed an enum, added comments, added an enum
2271 for retrieve-limit errors.
2273 * src/modest-mail-operation.c: (foreach_add_item),
2274 (internal_folder_observer_update), (update_account_thread),
2275 (modest_mail_operation_get_msgs_full):
2276 (modest_mail_operation_update_account),
2277 Added comments about how this works, and some code that should
2278 (but does not) check the retrieve-limit. See the TODO comment.
2280 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2282 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2283 Initialize help_id to fix the build. Warnings are good.
2285 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2287 * src/widgets/modest-hbox-cell-renderer.c:
2288 (modest_hbox_cell_renderer_append):
2289 * src/widgets/modest-vbox-cell-renderer.c:
2290 (modest_vbox_cell_renderer_append):
2291 Fix the last commit by doing an extra ref.
2293 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2295 * src/widgets/modest-hbox-cell-renderer.c:
2296 (modest_hbox_cell_renderer_append):
2297 * src/widgets/modest-vbox-cell-renderer.c:
2298 (modest_vbox_cell_renderer_append):
2299 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2300 to fix the build with Maemo Bora.
2301 However, there seems to be a remaining crash, probably due to reference
2304 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2306 * src/modest-tny-account.c:
2307 (modest_tny_account_new_for_local_folders):
2308 Use hildon_file_system_info_async_new() to get a better name for
2309 the memory card account, setting it as the account name.
2310 The timing seems to work, but this is probably
2311 not the best place to do this. See the TODO comment.
2312 * src/maemo/modest-main-window.c: (create_details_widget):
2313 * src/widgets/modest-folder-view.c: (text_cell_data):
2314 Use the tny account name instead of hardcoding a name.
2316 2007-05-30 Christian Kellner <ckellner@openismus.com>
2318 * src/modest-search.c: (modest_search):
2319 Correctly set part_search_func even if we have already parsed
2320 the query and thus a valid OgsTextSearcher object.
2322 2007-05-30 Christian Kellner <ckellner@openismus.com>
2325 Search and check for libogs.
2328 Incooparte the ogs build env.
2330 * src/modest-mime-part-search-stream.c:
2331 * src/modest-mime-part-search-stream.h:
2332 Removed since we do the real searching now in modest-search.c.
2334 * src/modest-search.c:
2335 * src/modest-search.h:
2336 Implement support for ogs. We use that if available and requested
2337 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2338 should now handle the corner case when the search term is spread
2339 across multiple reads.
2340 Also the logic in modest_search () was corrected to search all
2341 requested fields until one is found.
2343 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2345 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2347 * src/modest-init.h:
2348 * src/modest-init.c: Made modest_init_local_folders() take a
2349 path and be public so we can iniitialize maildir folders on
2352 * src/modest-local-folder-info.h:
2353 * src/modest-local-folder-info.c:
2354 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2356 * src/modest-tny-account.c:
2357 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2358 still means the standard local-folders path on the local volume.
2360 * src/modest-tny-account-store.c:
2361 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2362 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2363 all accounts when that happens.
2364 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2365 this too, so it shows up in the treeview.
2367 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2369 * src/maemo/modest-maemo-global-settings-dialog.c:
2370 (current_connection):
2371 * src/widgets/modest-global-settings-dialog.c:
2372 (current_connection_default):
2373 Use the enum values instead of 0, 1 and -1,
2374 to make the code clearer.
2376 * src/modest-account-mgr-helpers.c:
2377 (modest_account_mgr_get_connection_specific_smtp): Make this code
2380 * src/modest-runtime.h:
2381 * src/modest-runtime.c:
2382 Added modest_runtime_remove_all_send_queues().
2383 * src/maemo/modest-main-window.c:
2384 (on_account_store_connecting_finished): Recreate the send queues,
2385 using the appropriate transport accounts for this new connection.
2386 Some futher adapting might be needed if the old send queues are not
2387 automatically stopped at this point.
2389 * src/modest-tny-account-store.c: (get_server_accounts):
2390 Create the connection-specific transport accounts, so that they can
2391 be found later by their ID.
2393 * src/modest-tny-account.h:
2394 * src/modest-tny-account.c:
2395 Added modest_tny_account_new_from_server_account_name().
2396 modest_tny_account_new_from_server_account(): Do not create the
2397 send queues here, because they will be
2398 recreated anyway when the connection changes for the first time.
2400 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2402 * src/modest-local-folder-info.h:
2403 * src/modest-local-folder-info.c:
2404 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2405 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2406 tbox_folder): Take a modest account name instead of a server TnyAccount,
2407 so we can have per-modest-account rather than per-transport-account
2409 We must make sure that we change or recreate the exisitng send queues
2410 when the connection changes for connection-specific transport accounts.
2412 * src/modest-tny-account-store.c:
2413 (create_per_account_local_outbox_folders): Create outboxed per modest
2414 account, not per transport account.
2416 * src/modest-tny-account.h:
2417 * src/modest-tny-account.c:
2418 (modest_tny_account_get_special_folder): For outboxes, get the
2419 parent modest account name. The account is ignored for other folders.
2420 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2421 modest account name rather than a server TnyAccount.
2423 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2425 * src/modest-tny-account.c:
2426 (modest_tny_account_new_from_server_account):
2427 Call modest_runtime_get_send_queue() immediately after creating transport
2428 accounts, so that they start trying to send email from the outbox as soon
2429 as possible at startup. This is probably what we want.
2431 * src/modest-mail-operation.c: (update_account_thread):
2432 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2433 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2434 * src/modest-tny-send-queue.h:
2435 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2436 (modest_ui_actions_on_send):
2437 Added comments about how sending works, though it needs some more work.
2439 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2441 * src/modest-tny-account.c:
2442 (modest_tny_account_get_special_folder): Add TODO because this fails when
2443 the network is busy.
2444 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2445 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2446 Do not try to show this window when there is no active account. The UI
2447 specs does not tell us what to do in this case.
2449 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2453 * src/maemo/Makefile.am:
2454 * src/widgets/Makefile.am: Some dist fixes.
2456 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2458 * src/maemo/modest-connection-specific-smtp-window.c:
2459 (on_button_edit): Make the code clearer, to prevent a double free.
2461 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2463 * src/maemo/modest-account-settings-dialog.c:
2464 (modest_account_settings_dialog_set_account_name),
2465 Check the connection-specific smtp servers checkbox if there are any.
2467 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2468 (modest_connection_specific_smtp_edit_window_init):
2469 Start with a suitable port number.
2471 * src/modest-account-mgr-helpers.h:
2472 * src/modest-account-mgr-helpers.c: Added
2473 modest_account_mgr_get_has_connection_specific_smtp().
2475 (modest_account_mgr_set_connection_specific_smtp),
2476 (modest_account_mgr_remove_connection_specific_smtp),
2477 (modest_account_mgr_get_has_connection_specific_smtp),
2478 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2479 connection-specific smtp server accounts in the account, rather than
2480 the server account conf dir.
2482 This fixes bug projects.maemo.org bug NB#58263 .
2484 * src/modest-tny-account-store.c:
2485 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2486 if there are no server accounts yet, to prevent an infinite loop when there
2487 are no accounts. Document that one must be called before the other.
2489 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2491 * src/modest-account-mgr-helpers.c:
2492 (modest_account_mgr_get_default_account): Make sure that at least
2493 one account is always the default, if there are any enabled accounts.
2494 This is just a sanity check that shouldn't be necessary.
2496 * src/modest-account-mgr-priv.c:
2497 (_modest_account_mgr_account_from_key): Unescape the conf key to
2498 get the real account name. For instance, this is an issue if a space
2499 was in the account name, which can happen because the account name
2500 is generated from the display name.
2501 (_modest_account_mgr_get_account_keyname): Always escape the
2503 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2504 Unescape the conf keys to get the real account names.
2506 For instance, previously the is-default radio button in the accounts
2507 list was not checked for any accounts at first. This fixes that,
2508 and might fix several similar bugs.
2510 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2512 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2513 Removed some debug printfs.
2515 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2517 Modest on-disk outbox directories are now here, for instance:
2518 $HOME/.modest/outboxes/<account-id-1>/outbox
2519 $HOME/.modest/outboxes/<account-id-2>/outbox
2521 $HOME/.modest/local-folders/outbox
2522 so we can have a separate outbox for each account.
2523 But they are shown as one outbox in the GtkTreeView, by using a
2524 TnyMergeFolder in a ModestTnySimpleFolderStore.
2527 * src/modest-tny-simple-folder-store.c:
2528 * src/modest-tny-simple-folder-store.h:
2529 Added ModestTnySimpleFolderStore, used to contain folders from
2530 other folder stores, such as other accounts.
2532 * src/modest-tny-outbox-account.h:
2533 * src/modest-tny-outbox-account.c:
2534 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2535 used for the per-account local outbox folders.
2537 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2538 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2539 only use this (internally) now for the non-outbox local folders.
2541 * src/modest-init.h:
2542 * src/modest-init.c: Added modest_init_one_local_folder(), for
2543 setting up the directory structure for each local folder.
2545 * src/modest-local-folder-info.c:
2546 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2547 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2549 * src/modest-local-folder-info.h:
2550 * src/modest-tny-account-store.c: (on_account_removed),
2551 (on_account_changed), (create_per_account_local_outbox_folders),
2552 (get_server_accounts), (modest_tny_account_store_get_accounts),
2553 (modest_tny_account_store_get_tny_account_by_account),
2554 (modest_tny_folder_store_is_virtual_local_folders):
2556 * src/modest-tny-account.h:
2557 * src/modest-tny-account.c:
2558 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2559 to create an on-disk per-account local outbox folder for each
2561 (create_per_account_local_outbox_folders): Create a local outbox folder
2562 for each transport account.
2563 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2564 for all local folders.
2566 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2567 instead of using g_object_get/set() directly. It is clearer.
2569 (modest_tny_folder_store_get_message_count),
2570 (modest_tny_folder_store_get_local_size
2571 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2572 because we now use these with non-acount folder stores.
2574 (modest_tny_account_get_special_folder),
2575 (modest_tny_account_new_from_server_account),
2576 (modest_tny_account_new_from_account):
2577 (recurse_folders): Adjust to the new outbox system.
2579 * src/modest-tny-folder.h:
2580 * src/modest-tny-folder.c:
2581 (modest_tny_folder_is_local_folder),
2582 (modest_tny_folder_get_local_folder_type),
2583 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2585 * src/widgets/modest-main-window.h:
2586 * src/maemo/modest-main-window.c: (create_details_widget),
2587 (modest_main_window_set_contents_style): Show details for any folder store,
2590 (modest_tny_folder_get_rules):
2591 Remove the const. C does not support constness enough for this.
2593 * src/modest-ui-actions.c:
2594 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2595 make all outboxes appear as one, in the usual local-folders tree node.
2597 (set_active_account_from_tny_account),
2598 (modest_ui_actions_on_folder_selection_changed):
2599 * src/widgets/modest-folder-view.c: (text_cell_data),
2600 (icon_cell_data), (filter_row),
2601 (add_account_folders_to_merged_folder),
2602 (add_account_folders_to_simple_folder_store), (),
2603 (get_cmp_rows_type_pos), (cmp_rows),
2604 (modest_folder_view_set_account_id_of_visible_server_account):
2605 Adjust to the new outbox system, using generic folder stores and folders
2606 in the GtkTreeModel.
2608 2007-05-23 Christian Kellner <ckellner@openismus.com>
2610 * src/modest-mail-operation.c:
2611 (modest_mail_operation_update_account):
2612 Use info->max_size instead of unintialized local var [small
2613 build fix]. (Added TODO to review that change since I don't
2616 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2618 * libmodest-dbus-client/libmodest-dbus-client.c:
2619 (libmodest_dbus_client_compose_mail): function added
2620 * src/dbus_api/modest-dbus-api.h:
2621 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2622 (on_compose_mail): Implementation of the SendAsMail functionality
2624 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2626 * src/modest-account-mgr.c:
2627 (modest_account_mgr_add_server_account): Set the secure-connection
2628 conf key for transport accounts as well as store accounts. I don't know
2629 why the if was there. For instance, this makes sure that we use SSL
2630 for the gmail preset from the easysetup wizard.
2632 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2634 * src/gnome/modest-main-window.c:
2635 (on_account_store_connecting_finished), (connect_signals):
2636 * src/maemo/modest-main-window.c:
2637 (on_account_store_connecting_finished), (connect_signals),
2638 (modest_main_window_new):
2639 Handle TnyAccountStore::connecting-finished instead of
2640 TnyDevice::connection-changed, because we cannot actually perform
2641 operations on accounts until TnyAccountStore has itself responded to
2642 the TnyDevice::connection-changed signal. This prevents a GError from
2644 Do not try to update at startup, because we (at least on scratchbox)
2645 already do an update at startup when the device goes online.
2646 This prevents a GError from tinymail.
2647 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2648 Added TODO about stopping simultaneous operations.
2650 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2652 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2653 * src/modest-mail-operation-queue.c:
2654 (modest_mail_operation_queue_remove):
2655 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2656 about where they happened.
2658 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2660 * src/modest-ui-actions.c:
2661 (modest_ui_actions_on_password_requested): Make sure that the remember
2662 output parameter is always TRUE.
2664 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2666 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2667 Show a OK/Cancel dialog if the error is a question, though we still do not
2668 know anything more about what we are asking the user.
2669 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2670 Fix an uninitialized variable (helper). This is a logic error, however.
2672 2007-05-21 Christian Kellner <ckellner@openismus.com>
2674 * src/modest-search.h:
2675 Correct bit shifting in the ModestSearchFlags enum.
2677 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2679 * src/modest-tny-account.c:
2680 (modest_tny_account_new_from_server_account): Do not use the lsub and
2681 check-all hard-coded IMAP options when using POP.
2683 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2685 * src/modest-tny-account.c:
2686 (modest_tny_account_new_from_server_account):
2687 Use NULL for the secure-auth method for POP when Password auth has been
2688 specified by the user, as we already do for IMAP. "auth=Login" causes
2689 an error from camel or the server.
2691 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2693 * src/maemo/modest-account-settings-dialog.c:
2694 (create_page_account_details),
2695 (modest_account_settings_dialog_set_account_name):
2696 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2697 for the leave-on-server checkbox, rathr than just the checkbox, when
2698 the protocol is not POP.
2700 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2702 * src/widgets/modest-account-view.c:
2703 * src/widgets/modest-account-view.h:
2704 Added modest_account_view_select_account() which will be useful later
2705 to asynchronously re-select the edited account.
2707 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2709 * src/maemo/modest-account-settings-dialog.c:
2710 (modest_account_settings_dialog_set_account_name):
2711 Automatically choose the port numbers based on the secure authentication
2712 methods, if they have not been chosen before.
2713 This fixes projects.maemo.org bug NB#56273 .
2715 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2717 * src/maemo/modest-main-window-ui.h:
2718 * src/modest-ui-actions.c:
2719 * src/modest-ui-actions.h:
2720 Connect the Tools/SMTP Servers menu item to
2721 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2722 SMTP servers dialog, as in the UI specification and saves changes when it
2723 is closed. This fixed projects.maemo.org bug NB#56305 .
2725 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2727 * src/maemo/modest-connection-specific-smtp-window.c:
2728 (modest_connection_specific_smtp_window_init):
2729 Use gtk_window_set_default_size() to make this window big enough, so
2730 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2732 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2734 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2735 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2736 (modest_connection_specific_smtp_edit_window_init),
2737 Do not try to connect to a combobox signal before the combobox exists.
2738 This fixes the cras in projects.maemo.org bug NB#56288 .
2739 (modest_connection_specific_smtp_edit_window_get_settings):
2740 Remove the server_account_name parameter which was being checked for NULL
2741 though it was not used.
2743 * src/maemo/modest-connection-specific-smtp-window.c:
2744 (modest_connection_specific_smtp_window_fill_with_connections),
2745 (on_button_edit), (modest_connection_specific_smtp_window_init):
2746 Correct the number of treemodel columns to prevent a warning.
2747 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2748 libconic does not work.
2750 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2752 * src/modest-tny-account.c:
2753 (modest_tny_account_new_from_server_account):
2754 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2755 SMTP when "None" was chosen by the user. However, with my SMTP server that
2756 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2759 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2761 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2762 to explain the memory management issue with the ID in the ModestPair.
2764 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2765 (add_sending_page), (modest_account_assistant_finalize):
2766 * src/gnome/modest-gnome-global-settings-dialog.c:
2767 (create_updating_page), (create_composing_page):
2768 * src/gnome/modest-msg-edit-window.c: (get_transports),
2769 (init_window), (modest_msg_edit_window_finalize),
2770 (modest_msg_edit_window_get_msg_data):
2771 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2772 * src/gnome/modest-transport-widget.c:
2773 (modest_transport_widget_finalize), (smtp_configuration):
2774 * src/maemo/modest-maemo-global-settings-dialog.c:
2775 (create_updating_page), (create_composing_page):
2776 * src/maemo/modest-msg-edit-window.c: (get_transports),
2777 (init_window), (modest_msg_edit_window_finalize),
2778 (modest_msg_edit_window_get_msg_data),
2779 (modest_msg_edit_window_free_msg_data):
2780 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2781 (modest_store_widget_finalize):
2782 * src/maemo/modest-transport-widget.c:
2783 (modest_transport_widget_finalize), (smtp_configuration):
2784 * src/modest-main.c: (send_mail):
2785 * src/widgets/modest-combo-box.h:
2786 * src/widgets/modest-global-settings-dialog-priv.h:
2787 * src/widgets/modest-global-settings-dialog.c:
2788 (modest_global_settings_dialog_finalize):
2789 * src/widgets/modest-msg-edit-window.h:
2790 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2791 as long as the combo box, to prevent use of freed memory for the ID.
2793 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2795 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2796 get_accounts(), to make this clearer. Do not check for the enabled gconf
2797 key, because we do not use this for server accounts (at least, not yet).
2798 This allows us to send email again.
2800 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2802 * src/maemo/modest-platform.c:
2803 (on_modest_conf_update_interval_changed), (modest_platform_init):
2804 Only respond to this particular key change. All these strcmp()s cannot be
2807 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2809 * src/maemo/modest-maemo-global-settings-dialog.c:
2810 (current_connection): Prevent a crash in scratchbox when
2811 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2812 * src/maemo/modest-platform.c:
2813 (on_modest_conf_update_interval_changed), (modest_platform_init):
2814 Get the update interval from gconf and reset it when the gconf key changes.
2816 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2818 * src/modest-protocol-info.c:
2819 * src/modest-protocol-info.h: Adde enum-specific get functions,
2820 instead of using a ModestProtocolType enum parameter.
2822 * src/gnome/modest-account-assistant.c:
2823 * src/gnome/modest-store-widget.c:
2824 * src/gnome/modest-store-widget.h:
2825 * src/gnome/modest-transport-widget.c:
2826 * src/gnome/modest-transport-widget.h:
2827 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2828 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2829 * src/maemo/easysetup/modest-easysetup-wizard.c:
2830 * src/maemo/modest-account-settings-dialog.c:
2831 * src/maemo/modest-account-settings-dialog.h:
2832 * src/maemo/modest-store-widget.c:
2833 * src/maemo/modest-store-widget.h:
2834 * src/maemo/modest-transport-widget.c:
2835 * src/maemo/modest-transport-widget.h:
2836 * src/modest-account-mgr-helpers.c:
2837 * src/modest-account-mgr-helpers.h:
2838 * src/modest-account-mgr.c:
2839 * src/modest-account-mgr.h:
2840 * src/modest-tny-account.c:
2841 * src/modest-tny-folder.c:
2842 * src/widgets/modest-account-view.c:
2843 * src/widgets/modest-retrieve-combo-box.c:
2844 * src/widgets/modest-retrieve-combo-box.h:
2845 * src/widgets/modest-secureauth-combo-box.c:
2846 * src/widgets/modest-serversecurity-combo-box.c:
2847 * src/widgets/modest-serversecurity-combo-box.h:
2848 * tests/check_account-mgr.c:
2849 Use the specific functions, and use the re-renamed enum values for GNOME too.
2851 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2853 * src/modest-pair.h:
2854 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2855 so we can get the second based on the first.
2857 * src/maemo/modest-account-settings-dialog.h:
2858 * src/maemo/modest-account-settings-dialog.c:
2859 Added get_supported_secure_authentication_methods(), though it is mostly
2860 commented-out for now until the necessary API is committed to tinymail.
2861 (modest_account_settings_dialog_set_account_name),
2862 (save_configuration): Request the supported authentication methods from the
2863 server, so we can choose a working method.
2865 * src/modest-tny-account-store.h:
2866 * src/modest-tny-account-store.c:
2867 (modest_tny_account_store_get_session): Rename from
2868 tny_account_store_get_session().
2870 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2872 * src/modest-protocol-info.h: Split the ModestProtocol enum
2873 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2874 There was no need to have these unrelated values in one enum.
2876 * src/: many files: Adapted to changed enum. This makes the code a bit
2877 clearer, and the compiler could catch some errors.
2879 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2881 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2882 Show the detailed internal camel error message when an error happens
2883 during the configuration, so that our testers can give us more clues.
2884 For instance, in projects.maemo.org bug NB#56910 .
2886 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2888 * src/modest-tny-account.c:
2889 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2890 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2892 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2894 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2895 * src/maemo/modest-account-settings-dialog.c:
2896 (modest_account_settings_dialog_set_account_name),
2897 (save_configuration): For the incoming secure authentication checkbox,
2898 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2899 the UI specification. PLAIN does not seem to be supported for most IMAP
2900 servers anyway, and I am not sure what it would mean.
2901 However, we probably need to discover which of the secure-authentication
2902 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2903 * src/modest-account-mgr-helpers.c:
2904 (modest_account_mgr_get_server_account_data):
2906 * src/modest-tny-account.c:
2907 (modest_tny_account_new_from_server_account):
2908 Use tny_account_set_mech() to set secure-authentication methods,
2909 with some special-casing for IMAP, based on my observations of how
2912 * src/modest-account-mgr-helpers.h:
2913 * src/modest-account-mgr.c:
2914 * src/modest-defs.h: Comment that the URI is only used for local folders.
2916 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2918 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2919 parameter const, just to be neat.
2920 * src/modest-text-utils.c: (modest_text_utils_inline):
2921 End g_strconcat() with NULL, as its documentation says. This is almost
2922 certainly the cause of my crash at startup on the device. Interestingly,
2923 valgrind doesn't tell us about these errors.
2925 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2927 * scripts/build-packages: Added more precise comments about how to use
2928 this script, though I still get this error:
2929 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2930 error building tinymail
2932 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2934 * src/maemo/modest-main-window.c: (on_account_update):
2935 Very slight cleanup, hoping to make it simpler to discover what causes
2936 a crash here sometimes.
2938 * src/modest-tny-account.c:
2939 (modest_tny_account_new_from_server_account): Set the port. Added
2940 comments about the options and a TODO comment because I need to find out
2941 how to specify the secure authentication method.
2943 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2945 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2946 changed CFlags paths form modest to libmodest
2948 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2950 * src/modest-account-mgr-helpers.c:
2951 (modest_account_mgr_get_server_account_data),
2952 (modest_account_mgr_free_server_account_data):
2953 * src/modest-account-mgr-helpers.h:
2954 * src/modest-account-mgr.c:
2955 (modest_account_mgr_add_server_account):
2956 * src/modest-defs.h:
2957 * src/modest-tny-account.c:
2958 (modest_tny_account_new_from_server_account):
2959 Determine the options for tny_camel_account_add_option() here,
2960 based on the settings, rather than storing them directly in gconf.
2962 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2964 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2965 Show a more friendly error dialog now that we expect (from the tinymail
2966 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2968 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2970 * src/maemo/modest-main-window.c: (on_account_update): Check that
2971 account_name is not NULL, to prevent a crash at startup that I am
2972 seeing on the N800. I do wonder why it is NULL.
2974 * src/maemo/easysetup/modest-easysetup-wizard.c:
2975 (create_page_user_details):
2976 * src/maemo/modest-account-settings-dialog.c:
2977 (create_page_user_details), (create_page_outgoing):
2978 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2979 (modest_connection_specific_smtp_edit_window_init):
2980 * src/modest-ui-actions.c:
2981 (modest_ui_actions_on_password_requested):
2982 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2983 might do something useful with the on-screen keyboard.
2985 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2987 * src/maemo/modest-main-window.c: (on_account_update):
2988 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2989 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2991 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2993 * src/modest-tny-account-store.c: (on_account_changed):
2994 Correct the signature of this signal handler.
2996 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2998 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2999 Show a HildonNote instead of a GtkDialog for Maemo.
3001 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3003 * src/widgets/modest-account-view.h:
3004 * src/widgets/modest-account-view.c: (on_account_changed),
3005 (on_account_removed). Added a boolean flag, set/unset by
3006 modest_account_view_block_conf_updates(),
3007 modest_account_view_unblock_conf_updates() to prevent unnecessary
3008 updates, but this is not very useful because the gconf notifications are
3009 so delays (maybe only on Maemo Bora).
3010 So auto-updating is turned off, and these functions do an explicit
3011 update when necessary.
3012 However, something else is still doing too much work when adding/removing
3013 accounts, probably in another part of the application.
3015 * src/maemo/modest-account-view-window.c:
3016 (on_delete_button_clicked), (on_edit_button_clicked),
3017 (on_new_button_clicked): Use the new functions.
3019 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3021 * src/modest-account-mgr-helpers.c:
3022 (modest_account_mgr_set_first_account_as_default):
3023 Sort the list of names alphabetically-by-title, so we choose the first one
3025 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3026 alphabetically by the title.
3028 This fixes projects.maemo.org bug NB#56418 .
3030 * src/modest-account-mgr-priv.c:
3031 (_modest_account_mgr_account_from_key):
3032 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3033 avoid a valgrind error, and possible random behaviour.
3035 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3037 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3038 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3039 tinymail documentation to say that this can be expected.
3040 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3041 pretty, and should not happen, but I would prefer to know when it does.
3043 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3045 * configure.ac: When using the older hildon version, probably on Bora,
3046 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3048 * src/widgets/modest-attachment-view.c:
3049 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3052 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3054 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3055 Implemented the prototype. Can be tested with
3056 tests/dbus_api/test_open_message:
3058 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3060 * src/modest-tny-account-store.c:
3061 (modest_tny_account_store_instance_init), (get_password):
3062 * src/modest-ui-actions.c:
3063 (modest_ui_actions_on_password_requested):
3064 Do not store the password in gconf, because this function is called
3065 for non-remembered passwords. Actually use the cached (in the hash map)
3066 password instead of releasing it.
3067 The password will now not be remembered if it is asked via the protected
3068 password dialog, as per the UI spec.
3070 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3072 * src/modest-defs.h:
3073 * src/modest-account-mgr-helpers.h:
3074 * src/modest-account-mgr-helpers.c:
3075 Added modest_server_account_get_username_has_succeeded(),
3076 modest_server_account_set_username_has_succeeded().
3077 (modest_server_account_set_username),
3078 Reset the has-succeeded flag if the username changes.
3080 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3081 * src/maemo/modest-connection-specific-smtp-window.c:
3082 (modest_connection_specific_smtp_window_save_server_accounts):
3083 Use modest_server_account_set_username() instead of using
3084 modest_conf_set_string() directly, so that the has-succeeded flag is always
3087 * src/modest-ui-actions.c:
3088 (modest_ui_actions_on_password_requested): Dim the username entry if
3089 the username has ever worked, as per the UI spec.
3091 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3093 * src/modest-tny-account-store.c: (get_password):
3094 * src/modest-ui-actions.c:
3095 (modest_ui_actions_on_password_requested):
3096 Allow the username to be changed too, though there is more work to
3097 be done on exactly how this behaves.
3099 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3101 * src/modest-account-mgr-helpers.h:
3102 * src/modest-account-mgr-helpers.c:
3103 Added modest_account_mgr_get_display_name(),
3104 modest_server_account_get_username(),
3105 modest_server_account_set_username(),
3106 modest_server_account_set_password(),
3107 modest_server_account_get_hostname() functions so we do not need to
3108 use the conf API directly.
3110 * src/maemo/modest-main-window.c: (connect_signals):
3111 Actually connect ot the ModestAccountStore::request-password signal,
3112 so that we show the dialog when the password is requested by Tinymail,
3113 for isntance if it is empty.
3115 * src/modest-marshal.list:
3116 * src/modest-tny-account-store.c:
3117 (modest_tny_account_store_class_init), (get_password),
3118 (modest_tny_account_store_alert):
3119 * src/modest-tny-account-store.h:
3120 * src/modest-ui-actions.h:
3121 * src/modest-ui-actions.c:
3122 (modest_ui_actions_on_password_requested):
3123 Change the signal parameters, so it is obvious that we are providing
3124 the non human-readable server name, and receiving both the username
3125 and password, though changing of the username is not yet implemented.
3126 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3127 for the GNOME version.
3129 This should fix the projects.maemo.org bug NB#56209, though it does not
3130 work on Bora, because the gconf_client_get() for the password fails
3131 immediately after we save it with gconf_client_set().
3133 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3136 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3137 caused an undefined symbol error:
3138 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3140 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3142 * src/modest-tny-account-store.c:
3143 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3144 using a GError instead of a string message, so we can translate it in
3147 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3149 * src/maemo/modest-address-book.c:
3150 (modest_address_book_check_names):
3151 * src/maemo/modest-msg-view-window.c:
3152 (modest_msg_view_window_clipboard_owner_change):
3153 * src/modest-init.c: (modest_init_init_ui):
3154 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3155 (update_folders_cb), (modest_mail_operation_update_account):
3156 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3157 (modest_ui_actions_on_msg_attachment_clicked),
3158 (modest_ui_actions_on_msg_recpt_activated):
3159 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3160 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3161 (modest_msg_view_search_next):
3162 * src/widgets/modest-recpt-editor.c:
3163 (modest_recpt_editor_on_button_release_event),
3164 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3165 g_message(). At this point we should only be seeing interesting errors on
3166 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3168 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3170 (modest_wizard_dialog_force_title_update):
3171 * src/maemo/easysetup/modest-wizard-dialog.h:
3172 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3173 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3174 can update the title when appropriate. Otherwise the title is wrong if the
3175 pages are added after adding the notebook to the dialog.
3176 This must be a problem in HildonWizardDialog too.
3177 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3179 * src/maemo/easysetup/modest-easysetup-wizard.c:
3180 (create_subsequent_customsetup_pages),
3181 (create_subsequent_easysetup_pages):
3182 Call modest_wizard_dialog_force_title_update() so that the title is
3183 correct even with GTK+ < 2.10.
3184 This fixes projects.maemo.org bug NB#56145 .
3186 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3188 * src/maemo/modest-platform.c:
3189 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3190 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3193 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3195 * src/widgets/modest-window.h:
3196 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3197 and modest_window_save_state(), which invokes it.
3199 * src/widgets/modest-window-mgr.h:
3200 * src/widgets/modest-window-mgr.c:
3201 Added modest_window_mgr_save_state_for_all_windows(), which calls
3202 the save_state vfunc on all registered windows, if implemented.
3204 * src/gnome/modest-msg-edit-window.c:
3205 * src/gnome/modest-msg-view-window.c:
3206 * src/maemo/modest-msg-edit-window.c:
3207 * src/maemo/modest-msg-view-window.c:
3208 * src/maemo/modest-main-window.c:
3209 Specify the existing save_settings functions as implementations of
3210 ModestWindow::save_state_func().
3212 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3213 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3214 enabling hibernation, for instance.
3216 We may need to do the same thing for restoring settings.
3219 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3221 * src/widgets/modest-window-mgr.c:
3222 * src/widgets/modest-window-mgr.h:
3223 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3224 modest_window_mgr_get_hibernation_is_prevented().
3226 * src/maemo/modest-main-window.c:
3227 (on_hildon_program_is_topmost_notify): Prevent hibernation
3228 (possible when the application goes to the background in the WM),
3229 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3231 * src/maemo/easysetup/modest-easysetup-wizard.c:
3232 (modest_easysetup_wizard_dialog_init):
3233 * src/maemo/modest-account-settings-dialog.c:
3234 (modest_account_settings_dialog_init):
3235 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3236 (modest_connection_specific_smtp_edit_window_init):
3237 * src/maemo/modest-connection-specific-smtp-window.c:
3238 (modest_connection_specific_smtp_window_init):
3239 * src/maemo/modest-signature-editor-dialog.c:
3240 (modest_signature_editor_dialog_init):
3241 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3242 prevent hibernation while any of these account settings dialogs are open.
3244 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3246 * src/maemo/Makefile.am:
3247 * src/maemo/modest-osso-state-saving.c:
3248 * src/maemo/modest-osso-state-saving.h: Added
3249 modest_osso_load_state() and modest_osso_save_state() though they do
3250 nothing now. They should iterate through all the open windows and load/save
3252 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3253 save state when closing.
3255 * src/maemo/modest-main-window.c:
3256 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3257 Add a notification handler for the HildonProgram::is-topmost property,
3258 so we can allow hibernation when the application goes into the background.
3259 But we still need to detect when the accounts setup windows are open so
3260 we can stop hibernation when they are open.
3261 To do this, I also added the main window the HildonProgram. This might have
3262 other side-effects/benefits, and should maybe be done for other windows.
3264 * src/maemo/modest-osso-autosave-callbacks.h:
3265 * src/maemo/modest-osso-autosave-callbacks.c:
3266 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3267 though it does not do anything yet, and we might never need this to do
3268 anything. For instance, we already save drafts.
3270 * src/maemo/modest-platform.c: (modest_platform_init):
3271 Specify the libosso auto-save callback.
3273 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3275 * src/maemo/modest-platform.c:
3276 (modest_platform_set_update_interval):
3277 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3278 aparently stays valid between application instances, so we can use this
3279 to remove and reset it later. According to a maemo-developers email from
3282 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3284 * configure.ac: Depend on libalarm for Maemo.
3286 * src/dbus_api/modest-dbus-api.h:
3287 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3288 (on_send_receive), (modest_dbus_req_handler):
3289 Handle a SEND_RECEIVE D-Bus method.
3291 * libmodest-dbus-client/libmodest-dbus-client.c:
3292 (libmodest_dbus_client_send_and_receive):
3293 * libmodest-dbus-client/libmodest-dbus-client.h:
3294 Add C convenience functions for calling the new D-Bus method.
3296 * src/modest-platform.h:
3297 * src/gnome/modest-platform.c:
3298 * src/maemo/modest-platform.c:
3299 Added modest_platform_set_update_interval(), which uses the
3300 alarmd API on Maemo.
3301 (modest_platform_init),
3302 Call modest_platform_set_update_interval(), using a hard-coded
3303 interval for now (until the global settings dialog is implemented),
3304 though I am not sure that this makes sense yet.
3306 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3308 * src/dbus_api/modest-dbus-callbacks.c:
3309 (modest_osso_cb_hw_state_handler):
3310 * src/dbus_api/modest-dbus-callbacks.h:
3311 * src/maemo/modest-platform.c: (modest_platform_init):
3312 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3313 in case this has some effect on the ability for Maemo to ping the
3316 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3318 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3319 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3320 warning. It is probably a logic error, but I need to fix the build.
3322 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3324 * src/modest-account-mgr.h:
3325 * src/modest-account-mgr.c:
3326 (modest_account_mgr_account_names): Add a gboolean enabled_only
3327 parameter, so we can get lists of onlt the enabled accounts.
3329 (modest_account_mgr_add_account),,
3330 (modest_account_mgr_account_with_display_name_exists):
3331 * src/maemo/modest-msg-edit-window.c: (get_transports):
3332 * src/modest-account-mgr-helpers.c:
3333 (modest_account_mgr_set_first_account_as_default):
3334 * src/modest-init.c: (init_default_account_maybe):
3335 * src/modest-tny-account-store.c: (get_accounts):
3336 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3337 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3338 * tests/check_account-mgr.c: (START_TEST):
3339 Provide the extra parameter, as appropriate.
3341 * src/widgets/modest-account-view.c: (update_account_view):
3342 Do not show disabled accounts (meaning that there is no way to
3343 enable/disable accounts in the UI (the feature is not in our UI
3344 specification), so we can use this internally only to mark unfinished
3345 or temporary account data.
3347 * src/maemo/easysetup/modest-easysetup-wizard.c:
3348 (create_account): Add boolean enable parameter, so we can specify FALSE
3349 to create the temporary account.
3350 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3351 (on_before_next): When finishing, when there is a temporary account, just
3353 Also, use a timeout to delay the showing of the dialog until gconf is likely
3354 to return correct information, due to a maemo gconf bug that is fixed in
3355 osso 1.1, but not yet in Bora.
3356 However, the dialog stays on screen after it is destroyed.
3358 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3359 for invalid data when cancelling. Use a hildon note instead of a dialog
3360 to complain about invalid data. Do not show the account-saved note if the
3361 account is disabled (a temporary account that will not really be saved for use
3364 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3366 * src/modest-account-mgr-helpers.h:
3367 * src/modest-account-mgr-helpers.c:
3368 Added modest_account_mgr_unset_default_account(),
3369 Added modest_account_mgr_set_first_account_as_default().
3371 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3372 If it was the default account, unset the default account name.
3374 * src/maemo/modest-account-view-window.c:
3375 (on_delete_button_clicked): If it was the default account,
3376 set the first remaining account as the default instead.
3378 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3379 a NULL account or a NULL default account, to prevent a crash. This should
3380 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3383 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3385 * src/widgets/modest-recpt-editor.c:
3386 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3387 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3388 TODO comment for this. This fixes the build.
3390 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3391 be the best place for it. This will in future update all auto-update accounts,
3392 rather than just the current/default account, when that gconf key exists.
3393 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3394 if there are no accounts, before calling do_send_receive().
3395 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3397 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3398 * src/maemo/modest-main-window-ui.h:
3399 * src/maemo/modest-main-window.c: (on_connection_changed),
3400 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3401 directly, becaue the signal handler does more.
3403 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3405 * src/modest-account-mgr-helpers.c:
3406 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3407 for the case that the account does not exist.
3409 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3410 (equivalent to the modest account name) rather than the tinymail account name
3411 (equivalent to the modest account title - human readable) to get the account data.
3412 Check for null account data to prevent the crash, and add a TODO comment saying that
3413 this needs fixing because it is using the server account name instead of the account name.
3415 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3417 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3418 * src/maemo/modest-account-settings-dialog.c: (show_error),
3420 Use hildon_note_new_information() for informative and error messages,
3421 which seems to be expected for Maemo applications (no documentation that I know of
3422 says this). I am surprised that there is no distinction between info and error
3425 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3427 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3428 it is easy to find where this is used.
3430 * src/maemo/easysetup/modest-easysetup-wizard.c:
3431 (create_page_welcome), (create_page_account_details),
3432 (create_page_user_details), (create_page_complete_easysetup),
3433 (create_page_custom_incoming), (create_page_custom_outgoing),
3434 (create_page_complete_custom):
3435 * src/maemo/modest-account-settings-dialog.c:
3436 (create_page_account_details), (create_page_user_details),
3437 (create_page_incoming), (create_page_outgoing):
3438 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3439 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3440 (modest_connection_specific_smtp_edit_window_init):
3441 * src/maemo/modest-connection-specific-smtp-window.c:
3442 (modest_connection_specific_smtp_window_init):
3443 * src/maemo/modest-signature-editor-dialog.c:
3444 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3445 and scrolling policy as per the Email Application Layout Guide, if I have
3448 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3450 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3451 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3452 which were empty, because these vfuncs have been removed from TnyAccountStore.
3453 This fixes the build.
3455 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3457 * src/maemo/modest-main-window.c:
3458 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3459 showing/hiding it. Added TODO because it probably should not be NULL.
3460 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3461 because unnecessary g_warnings() make degugging difficult.
3463 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3465 * src/maemo/modest-msg-edit-window.c:
3466 (modest_msg_edit_window_select_color),
3467 (modest_msg_edit_window_select_background_color): 2 const corrections and
3468 moving 2 #endifs before closing brackets, to fix the build.
3470 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3472 * src/maemo/easysetup/modest-easysetup-wizard.h:
3473 * src/maemo/easysetup/modest-easysetup-wizard.c:
3474 (modest_easysetup_wizard_dialog_finalize),
3475 (on_button_edit_advanced_settings), (create_page_complete_custom),
3476 (on_response), (create_account):
3477 Implement the Advanced Settings edit button, by saving the account information,
3478 for the Advanded Settings dialog to use directly from gconf, and removing it
3479 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3480 Bug #5533 in the projects.maemo.org bugzilla.
3482 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3484 * src/maemo/modest-msg-view-window.c:
3485 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3486 when opening a message window.
3488 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3490 * src/maemo/easysetup/modest-easysetup-wizard.c:
3491 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3494 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3495 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3496 gconf settings. I probably added more checks than necessary, but that is safer.
3498 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3499 variable to fix the build, but this seems to be used when it is still NULL.
3501 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3503 * src/modest-platform.h:
3504 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3505 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3506 * src/modest-main.c: Implement this function so we can avoid using
3507 maemo-specific API from cross-platform code.
3509 * src/modest-tny-account-store.c:
3510 (get_smtp_specific_transport_account_for_open_connection):
3511 * src/modest-ui-actions.c: (check_for_connection),
3512 (modest_ui_actions_on_item_not_found):
3513 Use modest_platform_connect_and_wait() and put #idefs around other
3514 maemo-specific code, because only maemo currently has a way to
3515 identify connection names.
3517 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3519 * src/modest-tny-account-store.h:
3520 * src/modest-tny-account-store.c:
3521 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3522 the connection-specific SMTP server settings in the configuration.
3524 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3526 * src/maemo/modest-main-window.c: (on_connection_changed),
3528 * src/modest-main.c: (main), (start_ui), (send_mail):
3529 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3530 that is what is intended.
3532 * src/modest-ui-actions.c: (action_send), (action_receive),
3533 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3534 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3535 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3536 SMTP server is used when it is specified.
3538 (modest_ui_actions_on_send_receive):
3539 Check that a connection is open before proceeding.
3540 Receive and then send, instead of vice-versa, as per the specification.
3542 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3544 * src/modest-mail-operation.c:
3545 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3546 though I guess it should be something other than NULL.
3548 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3550 * src/maemo/easysetup/modest-easysetup-wizard.c:
3551 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3552 combo twice, to avoid an g_warning and to make it visible again.
3553 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3554 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3555 (already intended) dereference when detaching, because we then recreate the menu.
3556 But I am not sure why the warning was happening, and it is possible that this is a memory
3559 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3561 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3562 and uri_parse_mailto() utility functions.
3563 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3565 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3567 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3569 * src/dbus_api/modest-dbus-api.h:
3570 * src/dbus_api/modest-dbus-callbacks.c:
3571 Use an idle callback to execute the modest code in the application's own thread.
3572 Remove the helloworld example method.
3573 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3574 parsed, and the open-message method is not implemented because this is not yet implemented in
3576 * libmodest-dbus-client/libmodest-dbus-client.c:
3577 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3578 (libmodest_dbus_client_open_message):
3579 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3581 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3582 body without crashing.
3584 * tests/dbus_api/Makefile.am:
3585 * tests/dbus_api/test_mail_to.c:
3586 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3588 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3590 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3591 Added file to fix the build. Sorry.
3593 * src/dbus_api/Makefile.am:
3594 * src/dbus_api/modest-dbus-api.h:
3595 * src/dbus_api/modest-dbus-callbacks.h:
3596 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3597 (modest_dbus_req_handler):
3598 Put constants in a separate header so it can be reused by the
3599 client library, without duplication
3601 * libmodest-dbus-client/Makefile.am:
3602 * libmodest-dbus-client/libmodest-dbus-client.c:
3603 (libmodest_dbus_client_call_helloworld),
3604 (libmodfest_dbus_client_send_mail),
3605 (libmodfest_dbus_client_mailto),
3606 (libmodfest_dbus_client_open_message):
3607 * libmodest-dbus-client/libmodest-dbus-client.h:
3608 (Partly) Implement a send_mail D-Bus method.
3610 * tests/dbus_api/Makefile.am:
3611 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3612 the send_email D-Bus method.
3614 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3618 * libmodest-dbus-client/Makefile.am:
3619 * libmodest-dbus-client/libmodest-dbus-client.c:
3620 * libmodest-dbus-client/libmodest-dbus-client.h:
3621 * tests/dbus_api/Makefile.am:
3622 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3623 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3625 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3627 * src/maemo/easysetup/modest-easysetup-wizard.c:
3628 (create_page_account_details):
3629 * src/maemo/modest-account-settings-dialog.c:
3630 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3631 widgets, because this might not be the default in future versions of the Maemo GTK+.
3632 However, I can not not get capitalization to work even in a simple test case.
3634 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3636 * src/maemo/easysetup/modest-easysetup-wizard.c:
3637 (create_page_custom_incoming), (create_page_custom_outgoing):
3638 * src/maemo/modest-account-settings-dialog.c:
3639 (create_page_account_details), (create_page_incoming),
3640 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3641 instead of using gtk_check_button_with_label(), so they are aligned like the other
3642 widgets, as per the UI spec.
3644 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3646 * src/maemo/easysetup/modest-easysetup-wizard.c:
3647 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3648 * src/widgets/modest-validating-entry.c:
3649 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3650 Modest prefix instead of an EasySetup prefix.
3652 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3654 * src/widgets/modest-validating-entry.h:
3655 * src/widgets/modest-validating-entry.c: (on_insert_text),
3656 Added easysetup_validating_entry_set_max_func(), used to set a callback
3657 to call when the max number of characters is reached. GtkEntry has a max-length
3658 already but is silent about it.
3660 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3661 (create_page_account_details), (create_page_user_details),
3663 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3664 (create_page_account_details), (create_page_user_details),
3665 (create_page_outgoing):
3666 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3667 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3668 the UI spec, when the user tries to enter more than the max number of characters.
3670 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3672 * src/maemo/easysetup/modest-easysetup-wizard.c:
3673 (create_page_user_details), (create_page_custom_incoming),
3674 (create_page_custom_outgoing):
3675 * src/maemo/modest-account-settings-dialog.c:
3676 (create_page_user_details), (create_page_incoming),
3677 (create_page_outgoing):
3678 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3679 (modest_connection_specific_smtp_edit_window_init):
3680 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3681 not appropriate. Bad Maemo-specific defaults!.
3683 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3685 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3686 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3687 (modest_signature_editor_dialog_set_settings):
3688 Disable the label and textview when the checkbox is disabled, and use the
3689 specified (UI spec) default signature text.
3691 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3693 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3694 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3696 * src/modest-defs.h:
3697 * src/modest-account-mgr-helpers.h:
3698 * src/modest-account-mgr-helpers.c:
3699 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3701 * src/maemo/Makefile.am:
3702 * src/maemo/modest-signature-editor-dialog.c:
3703 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3706 * src/maemo/modest-account-settings-dialog.h:
3707 * src/maemo/modest-account-settings-dialog.c:
3708 (modest_account_settings_dialog_finalize), (on_button_signature),
3709 (save_configuration): Use the new dialog when the Edit button is pressed, and
3710 save the changes if necessary, as per the UI spec.
3712 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3714 * src/maemo/Makefile.am:
3715 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3716 based on maemo-develoers email from Dirk.
3718 * src/maemo/easysetup/modest-easysetup-wizard.c:
3719 (create_page_welcome), (create_page_account_details),
3720 (create_page_user_details), (create_page_complete_easysetup),
3721 (create_page_custom_incoming), (create_page_custom_outgoing),
3722 (create_page_complete_custom),
3723 (modest_easysetup_wizard_dialog_init):
3724 * src/maemo/modest-account-settings-dialog.c:
3725 (create_page_account_details), (create_page_user_details),
3726 (create_page_incoming), (create_page_outgoing),
3727 (modest_account_settings_dialog_init):
3728 * src/maemo/modest-connection-specific-smtp-window.c:
3729 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3731 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3733 * src/maemo/easysetup/modest-easysetup-wizard.c:
3734 (create_page_account_details), (create_page_custom_outgoing),
3735 (create_page_complete_custom):
3736 * src/maemo/modest-account-settings-dialog.c:
3737 (create_page_user_details), (create_page_incoming),
3738 (create_page_outgoing):
3739 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3740 (modest_connection_specific_smtp_edit_window_init):
3741 Use the correct (UI spec) port min/max, and use horizontal separators,
3744 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3746 * src/maemo/easysetup/modest-easysetup-wizard.c:
3747 (set_default_custom_servernames):
3748 * src/maemo/modest-account-settings-dialog.c:
3749 (create_page_incoming), (on_combo_outgoing_security_changed),
3750 (on_combo_incoming_security_changed), (create_page_outgoing),
3751 (modest_account_settings_dialog_set_account_name),
3752 (save_configuration):
3753 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3754 (on_combo_security_changed),
3755 (modest_connection_specific_smtp_edit_window_init),
3756 (modest_connection_specific_smtp_edit_window_set_connection),
3757 (modest_connection_specific_smtp_edit_window_get_settings):
3758 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3761 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3764 * src/maemo/easysetup/modest-easysetup-wizard.c:
3765 (create_page_custom_outgoing), (create_page_complete_custom):
3766 * src/maemo/modest-account-settings-dialog.c:
3767 (create_page_user_details), (create_page_outgoing):
3768 * src/maemo/modest-account-view-window.c: (button_box_new):
3769 Use changed logical IDs as per the most recent UI spec:
3770 mcen_bd_emailsetup_edit -> mcen_bd_edit
3771 mcen_bd_emailsetup_delete -> mcen_bd_delete
3772 mcen_bd_emailsetup_close -> mcen_bd_close
3774 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3778 * src/dbus_api/Makefile.am:
3779 * src/dbus_api/modest-dbus-callbacks.c:
3780 * src/dbus_api/modest-dbus-callbacks.h:
3781 * src/maemo/modest-platform.c: (modest_platform_init):
3782 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3784 * tests/Makefile.am:
3785 * tests/dbus_api/Makefile.am:
3786 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3788 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3790 * src/maemo/modest-account-settings-dialog.c:
3791 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3792 Removed unnecessary includes.
3794 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3796 * src/maemo/easysetup/modest-easysetup-wizard.c:
3797 * src/maemo/modest-account-settings-dialog.c:
3798 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3799 * src/widgets/Makefile.am:
3800 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3801 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3802 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3803 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3804 * src/widgets/modest-secureauth-combo-box.c:
3805 * src/widgets/modest-secureauth-combo-box.h:
3806 * src/widgets/modest-serversecurity-combo-box.c:
3807 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3808 made the GObject names more consistent with the rest of the Modest code.
3810 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3812 * src/maemo/easysetup/Makefile.am:
3813 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3814 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3815 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3816 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3817 * src/maemo/easysetup/modest-easysetup-wizard.c:
3818 * src/maemo/easysetup/modest-validating-entry.c:
3819 * src/maemo/easysetup/modest-validating-entry.h:
3820 * src/maemo/modest-account-settings-dialog.c:
3821 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3822 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3823 widgets/ because they are used outside of easysetup too. After checking in,
3824 svn will allow me to rename them too.
3826 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3828 * src/gnome/modest-msg-edit-window.c:
3829 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3830 linker error, to fix the build on the GNOME platform.
3831 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3832 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3833 ifdefed out to avoid a warning.
3835 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3837 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3838 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3839 some alternative for GTK+ 2.6.
3841 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3843 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3845 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3846 specified for EmailAccountsDialog in UI spec.
3848 * src/maemo/easysetup/modest-easysetup-wizard.c:
3849 * src/maemo/easysetup/modest-easysetup-wizard.h:
3850 * src/maemo/modest-account-settings-dialog.c:
3851 * src/maemo/modest-account-settings-dialog.h:
3852 Reuse a member window widget for the connection-specific SMTP server accounts,
3853 so we can tell it to create/save the accounts only if we actually save changes.
3855 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3856 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3857 (modest_connection_specific_smtp_edit_window_get_settings):
3858 Return a struct instance for temporarily remembering the entered data.
3860 * src/maemo/modest-connection-specific-smtp-window.h:
3861 * src/maemo/modest-connection-specific-smtp-window.c:
3862 (modest_connection_specific_smtp_window_finalize),
3863 (modest_connection_specific_smtp_window_fill_with_connections),
3865 (modest_connection_specific_smtp_window_save_server_accounts),
3866 (update_model_server_names): Do not actually save data until asked,
3867 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3869 (on_selection_changed),
3870 (modest_connection_specific_smtp_window_init): Disable the edit
3871 button when nothing is selected.
3873 * src/modest-account-mgr-helpers.c:
3874 * src/modest-account-mgr-helpers.h:
3875 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3878 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3880 * src/modest-account-mgr-helpers.h:
3881 * src/modest-account-mgr-helpers.c:
3882 (modest_account_mgr_get_unused_account_name),
3883 (modest_account_mgr_get_unused_account_display_name): Added these
3884 utility functions, to avoid code duplication.
3886 * src/maemo/easysetup/modest-easysetup-wizard.c:
3887 (create_page_account_details), (create_account):
3888 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3889 (on_combo_security_changed),
3890 (modest_connection_specific_smtp_edit_window_init),
3891 (modest_connection_specific_smtp_edit_window_save_settings):
3892 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3893 * src/maemo/modest-connection-specific-smtp-window.c:
3894 (modest_connection_specific_smtp_window_finalize),
3895 (modest_connection_specific_smtp_window_fill_with_connections),
3896 (on_button_edit), (modest_connection_specific_smtp_window_init):
3897 * src/maemo/modest-connection-specific-smtp-window.h:
3898 Implementing saving of connection-specific server accounts.
3900 But I need to refactor this so we can save the data for each
3901 possible connection-specific account and only actually create the server accounts
3902 when the easysetup finished, or the OK button is pressed on the account settings
3905 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3907 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3908 (on_combo_security_changed):
3909 (modest_connection_specific_smtp_edit_window_init):
3910 Auto-fill the port number as in the account settings.
3912 (modest_connection_specific_smtp_edit_window_set_connection):
3913 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3914 * src/maemo/modest-connection-specific-smtp-window.c:
3915 (fill_with_connections), (on_button_edit),
3916 (modest_connection_specific_smtp_window_init):
3917 Turn the edit window into a dialog to simplify the code, and
3918 set a WM hint as in a GtkDialog, because only a popup can be on top of
3919 another window in Maemo, and popups usually have no WM decoration.
3921 * src/modest-defs.h:
3922 * src/modest-account-mgr-helpers.c:
3923 (modest_account_mgr_set_connection_specific_smtp),
3924 (modest_account_mgr_remove_connection_specific_smtp),
3925 (modest_account_mgr_get_connection_specific_smtp):
3926 * src/modest-account-mgr-helpers.h: Some functions to write the
3927 connection-specific SMTP server information. Not yet used.
3930 * src/widgets/modest-folder-view.c: (text_cell_data):
3931 Fix a warning about an uninitialized variable.
3932 (on_configuration_key_changed): Put an #ifdef around the use
3933 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3935 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3937 * src/maemo/modest-account-settings-dialog.h:
3938 * src/maemo/modest-account-settings-dialog.c:
3939 Added connect_for_modified() utility function to mark the new modified boolean.
3941 (create_page_account_details), (create_page_user_details),
3942 (create_page_incoming), (create_page_outgoing), (on_response),
3943 (modest_account_settings_dialog_init),
3944 (modest_account_settings_dialog_set_account_name):
3945 Only warn about unsaved changes when there are actually unsaved changes.
3947 * src/modest-account-mgr-helpers.c:
3948 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3949 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3950 to get the data from there in future.
3952 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3954 * src/modest-defs.h:
3956 * src/modest-account-mgr-helpers.h:
3957 * src/modest-account-mgr-helpers.c:
3958 Store the security account setting in a single conf key instead of using
3959 the options list, so that the list is left for just the to-be-removed camel hack,
3960 and because gconf_client_set_list() is failing for some reason.
3962 * src/modest-account-mgr.c:
3963 (modest_account_mgr_add_server_account):
3964 * src/maemo/modest-account-settings-dialog.c:
3965 (modest_account_settings_dialog_set_account_name),
3966 (save_configuration): Use the renamed functions.
3969 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3971 * src/widgets/Makefile.am:
3972 * src/widgets/modest-limit-retrieve-combo-box.c:
3973 * src/widgets/modest-limit-retrieve-combo-box.h:
3974 * src/widgets/modest-retrieve-combo-box.c:
3975 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3976 the account settings dialog.
3978 * src/modest-defs.h:
3979 * src/modest-account-mgr-helpers.h:
3980 * src/modest-account-mgr-helpers.c:
3981 (modest_server_account_get_option_secure_auth),
3982 (modest_server_account_set_option_secure_auth):
3983 * src/modest-account-mgr.c:
3984 (modest_account_mgr_add_server_account):
3985 Use the existing AUTH_MECH conf key for the secure-auth setting,
3986 instead of putting it in the list options, because this was actually used already.
3988 * src/maemo/modest-account-settings-dialog.c:
3989 (create_page_account_details),
3990 (modest_account_settings_dialog_set_account_name),
3991 (save_configuration):
3992 * src/maemo/modest-account-settings-dialog.h:
3993 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3994 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3996 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3998 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3999 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4000 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4002 * src/modest-defs.h:
4003 * src/maemo/modest-account-settings-dialog.c:
4004 (create_page_incoming), (on_combo_outgoing_security_changed),
4005 (on_combo_incoming_security_changed), (create_page_outgoing),
4006 (modest_account_settings_dialog_set_account_name),
4007 (save_configuration): Load/Save the port number, and change it when the
4008 security combo changes, to suitable defaults.
4010 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4012 * src/modest-account-mgr.c:
4013 (modest_account_mgr_add_server_account): Set the security and secure-auth
4014 options, and add a comment saying that the other camel-specific options should be
4017 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4019 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4021 * src/modest-tny-account-store.c: (account_list_free),
4022 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4023 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4026 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4028 * src/modest-protocol-info.c:
4029 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4030 is required by our UI spec. Maybe something in our implementation will use this eventually.
4031 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4032 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4033 instead of the previous 0 placeholder.
4035 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4036 secure-auth settings.
4037 * src/modest-account-mgr-helpers.h:
4038 * src/modest-account-mgr-helpers.c:
4039 (modest_server_account_data_get_option_secure_auth),
4040 (modest_server_account_set_option_secure_auth),
4041 (modest_server_account_data_get_option_security),
4042 (modest_server_account_set_option_security): Added this API for getting and setting the security
4043 and secure-auth settings.
4045 * src/maemo/modest-account-settings-dialog.h:
4046 * src/maemo/modest-account-settings-dialog.c:
4047 (modest_account_settings_dialog_finalize), (check_data),
4048 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4049 about changing titles.
4050 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4051 (save_configuration): Save the security and secure-auth settings.
4053 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4054 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4056 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4058 * src/modest-defs.h:
4059 * src/modest-account-mgr.c:
4060 (modest_account_mgr_add_server_account):
4061 Added and used defines for the options key and value pair strings,
4062 that are used so far, though they do not seem to correspond to anything in our
4063 UI specs or ModestProtocol enum.
4065 * src/modest-account-mgr-helpers.h:
4066 * src/modest-account-mgr-helpers.c:
4067 (compare_option_strings_for_name),
4068 (modest_server_account_data_get_option_value),
4069 (modest_server_account_data_get_option_bool),
4070 (modest_account_mgr_get_server_account_option):
4071 Added helper functions for parsing the options GSList.
4073 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4075 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4076 display name is based on the supplied account name.
4077 * src/modest-account-mgr.c:
4078 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4079 with an inefficient, but good-enough, implementation.
4081 * src/maemo/easysetup/modest-easysetup-wizard.c:
4082 (create_page_account_details), (on_before_next), (create_account):
4083 Check for existing display names rather than (non-user-visible) account names, and just
4084 create and set a unique account name at the end.
4086 * src/maemo/modest-account-settings-dialog.c:
4087 (modest_account_settings_dialog_init),
4088 (modest_account_settings_dialog_set_account_name),
4089 (create_page_incoming): Show the display name, instead of the account name.
4090 (on_response): Do some (not all) extra checks, as in the UI spec.
4091 (save_configuration): Save the display name if it was changed.
4093 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4095 * po/en_GB.po: Added needed logical ID and translation.
4096 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4097 (init_view): Made the is-default column clicking work.
4099 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4102 * src/maemo/easysetup/Makefile.am:
4103 * src/maemo/easysetup/modest-easysetup-wizard.c:
4104 (modest_easysetup_wizard_dialog_init):
4105 * src/maemo/easysetup/provider-data-test.keyfile:
4106 * src/maemo/easysetup/provider-data.keyfile:
4107 Moved the provider data file to the new modest-providers-data package and used it from there.
4109 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4111 * src/modest-local-folder-info.c:
4112 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4113 N_() was already used on the static strings, but this just marks it for translation without
4114 using the translation.
4116 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4118 * src/maemo/modest-account-settings-dialog.c:
4119 (create_page_incoming),
4120 (modest_account_settings_dialog_set_account_name):
4121 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4122 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4123 I will do this if nobody else gets there first.
4125 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4127 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4128 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4129 save the security stuff.
4131 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4133 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4134 Set the email address and user fullname, which I now see must be
4137 * src/maemo/modest-account-settings-dialog.h:
4138 * src/maemo/modest-account-settings-dialog.c:
4140 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4141 leave-on-server and authentication.
4142 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4145 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4148 * src/maemo/modest-account-settings-dialog.c:
4149 * src/maemo/modest-account-settings-dialog.h:
4150 Most (but not all) of the widgets are now present as specified by the UI spec.
4151 No changes are yet saved, and some details are not properly shown yet.
4153 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4155 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4157 * src/maemo/Makefile.am:
4158 * src/maemo/modest-account-settings-dialog.c:
4159 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4160 an existing account. Doesn't do much yet.
4162 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4163 Open the accounts settings dialog when Edit is clicked.
4165 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4167 * src/maemo/easysetup/Makefile.am:
4168 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4170 * src/maemo/easysetup/modest-easysetup-wizard.c:
4171 (modest_easysetup_wizard_dialog_init):
4172 Try to get the source directory from the build system,
4173 instead of hard-coding "./" into the source code, when opening our local
4174 copies of the configuration files.
4175 But this still fails when opening the wizard from the Accounts window,
4176 maybe because the working directory seems to change at runtime.
4177 So the wizard will fail the second time unless you copy the files into their
4178 proper locations - see the stdout warnings for the paths.
4180 (create_page_account_details),(on_before_next):
4181 Check for existing non-server accounts instead of server accounts,
4182 so the default account name is useful again, and to prevent trying to
4185 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4186 Show the wizard when New is clicked.
4188 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4189 (init_view): Show the column headers, and show the columns that are
4190 specified in the UI specs. However, something in Maemo's GTK+ prevents
4191 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4192 change the default account. This is despite unsetting the special properties.
4194 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4196 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4197 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4198 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4199 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4200 to make that clearer.
4201 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4203 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4205 * src/maemo/modest-account-view-window.c:
4206 (modest_account_view_window_init),
4207 (modest_account_view_window_new):
4208 Use the same buttons as specified in the
4209 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4210 the existing widgets, which never had a chance of working.
4211 Put the ModestAccountView treeview in a scrolled window.
4212 Do not repeat the initialization in both _init() and _new().
4214 * src/widgets/modest-account-view.c: (update_account_view):
4215 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4216 this widget and window shows no accounts.
4218 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4220 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4222 * src/maemo/easysetup/modest-easysetup-wizard.c:
4223 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4224 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4225 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4228 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4229 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4230 accounts exist yet, as in the UI spec.
4232 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4234 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4236 * src/maemo/Makefile.am:
4237 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4238 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4239 New window for editing connection-specific smtp details.
4240 Not fully implemented.
4242 * src/maemo/modest-connection-specific-smtp-window.c:
4243 (modest_connection_specific_smtp_window_finalize) :
4244 unref the tree model.
4245 (on_button_edit): Show the edit window.
4247 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4249 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4252 * src/maemo/Makefile.am:
4253 * src/maemo/modest-connection-specific-smtp-window.c:
4254 * src/maemo/modest-connection-specific-smtp-window.h:
4255 New window for showing the list of connections, for connection-specific
4256 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4257 * src/maemo/easysetup/modest-easysetup-wizard.c:
4258 (create_page_custom_outgoing): Show the new window when the button is clicked.
4260 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4262 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4263 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4264 * src/maemo/modest-msg-edit-window.c:
4265 (modest_msg_edit_window_insert_image):
4266 * src/modest-conf.c: (modest_conf_key_escape):
4267 * src/modest-mail-operation.c:
4268 (modest_mail_operation_send_new_mail):
4269 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4270 (modest_ui_actions_on_new_account):
4271 * src/widgets/modest-attachment-view.c: (update_filename_request):
4272 * src/widgets/modest-mail-header-view.c:
4273 Corrected warnings that were breaking the build, by commenting out unused variables,
4274 and a function, and by including a header.
4276 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4278 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4279 so we can #ifdef around platform-specific code when necessary.
4280 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4281 to allow this to build for the GNOME platform too.
4283 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4285 * src/maemo/easysetup/modest-easysetup-wizard.c:
4286 Added util_increment_name() and used it in create_page_account_details()
4287 to make sure that the default account name is always a new name.
4289 (modest_easysetup_wizard_dialog_init),
4290 (set_default_custom_servernames): Some minor memory management fixes.
4292 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4296 * src/modest-runtime.c: (init_i18n): Restored the translation
4297 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4298 are defined in config.h, and the translations are installed.
4300 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4301 is defined for translation.
4303 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4305 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4307 * src/maemo/easysetup/modest-easysetup-wizard.c:
4308 (modest_easysetup_wizard_dialog_init):
4309 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4310 Use realistic paths (though they should use $prefix generically) to the
4311 mcc_mapping and provider-data.keyfile files which might work when they
4312 are installed by the future version of the operator-wizard package,
4313 and then fallback to paths in our source code, with an explanatory
4316 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4320 * src/maemo/Makefile.am:
4321 * src/maemo/easysetup/: Added files from the previously-exernal
4322 osso-modest-easysetup.
4323 * src/maemo/modest-main-window-ui.h:
4324 * src/modest-ui-actions.c:
4325 * src/modest-ui-actions.h:
4326 Added modest_ui_actions_on_new_account() as a signal handler for the
4327 New Account menu item. It shows the easysetup wizard.
4328 * po/en_GB.po: Added additional needed logical IDs and translations.