1 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
4 get_accounts(), to make this clearer. Do not check for the enabled gconf
5 key, because we do not use this for server accounts (at least, not yet).
6 This allows us to send email again.
8 2007-05-15 Murray Cumming <murrayc@murrayc.com>
10 * src/maemo/modest-platform.c:
11 (on_modest_conf_update_interval_changed), (modest_platform_init):
12 Only respond to this particular key change. All these strcmp()s cannot be
15 2007-05-15 Murray Cumming <murrayc@murrayc.com>
17 * src/maemo/modest-maemo-global-settings-dialog.c:
18 (current_connection): Prevent a crash in scratchbox when
19 ny_maemo_conic_device_get_current_iap_id() returns NULL.
20 * src/maemo/modest-platform.c:
21 (on_modest_conf_update_interval_changed), (modest_platform_init):
22 Get the update interval from gconf and reset it when the gconf key changes.
24 2007-05-15 Murray Cumming <murrayc@murrayc.com>
26 * src/modest-protocol-info.c:
27 * src/modest-protocol-info.h: Adde enum-specific get functions,
28 instead of using a ModestProtocolType enum parameter.
30 * src/gnome/modest-account-assistant.c:
31 * src/gnome/modest-store-widget.c:
32 * src/gnome/modest-store-widget.h:
33 * src/gnome/modest-transport-widget.c:
34 * src/gnome/modest-transport-widget.h:
35 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
36 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
37 * src/maemo/easysetup/modest-easysetup-wizard.c:
38 * src/maemo/modest-account-settings-dialog.c:
39 * src/maemo/modest-account-settings-dialog.h:
40 * src/maemo/modest-store-widget.c:
41 * src/maemo/modest-store-widget.h:
42 * src/maemo/modest-transport-widget.c:
43 * src/maemo/modest-transport-widget.h:
44 * src/modest-account-mgr-helpers.c:
45 * src/modest-account-mgr-helpers.h:
46 * src/modest-account-mgr.c:
47 * src/modest-account-mgr.h:
48 * src/modest-tny-account.c:
49 * src/modest-tny-folder.c:
50 * src/widgets/modest-account-view.c:
51 * src/widgets/modest-retrieve-combo-box.c:
52 * src/widgets/modest-retrieve-combo-box.h:
53 * src/widgets/modest-secureauth-combo-box.c:
54 * src/widgets/modest-serversecurity-combo-box.c:
55 * src/widgets/modest-serversecurity-combo-box.h:
56 * tests/check_account-mgr.c:
57 Use the specific functions, and use the re-renamed enum values for GNOME too.
59 2007-05-15 Murray Cumming <murrayc@murrayc.com>
62 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
63 so we can get the second based on the first.
65 * src/maemo/modest-account-settings-dialog.h:
66 * src/maemo/modest-account-settings-dialog.c:
67 Added get_supported_secure_authentication_methods(), though it is mostly
68 commented-out for now until the necessary API is committed to tinymail.
69 (modest_account_settings_dialog_set_account_name),
70 (save_configuration): Request the supported authentication methods from the
71 server, so we can choose a working method.
73 * src/modest-tny-account-store.h:
74 * src/modest-tny-account-store.c:
75 (modest_tny_account_store_get_session): Rename from
76 tny_account_store_get_session().
78 2007-05-14 Murray Cumming <murrayc@murrayc.com>
80 * src/modest-protocol-info.h: Split the ModestProtocol enum
81 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
82 There was no need to have these unrelated values in one enum.
84 * src/: many files: Adapted to changed enum. This makes the code a bit
85 clearer, and the compiler could catch some errors.
87 2007-05-14 Murray Cumming <murrayc@murrayc.com>
89 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
90 Show the detailed internal camel error message when an error happens
91 during the configuration, so that our testers can give us more clues.
92 For instance, in projects.maemo.org bug NB#56910 .
94 2007-05-14 Murray Cumming <murrayc@murrayc.com>
96 * src/modest-tny-account.c:
97 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
98 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
100 2007-05-14 Murray Cumming <murrayc@murrayc.com>
102 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
103 * src/maemo/modest-account-settings-dialog.c:
104 (modest_account_settings_dialog_set_account_name),
105 (save_configuration): For the incoming secure authentication checkbox,
106 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
107 the UI specification. PLAIN does not seem to be supported for most IMAP
108 servers anyway, and I am not sure what it would mean.
109 However, we probably need to discover which of the secure-authentication
110 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
111 * src/modest-account-mgr-helpers.c:
112 (modest_account_mgr_get_server_account_data):
114 * src/modest-tny-account.c:
115 (modest_tny_account_new_from_server_account):
116 Use tny_account_set_mech() to set secure-authentication methods,
117 with some special-casing for IMAP, based on my observations of how
120 * src/modest-account-mgr-helpers.h:
121 * src/modest-account-mgr.c:
122 * src/modest-defs.h: Comment that the URI is only used for local folders.
124 2007-05-11 Murray Cumming <murrayc@murrayc.com>
126 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
127 parameter const, just to be neat.
128 * src/modest-text-utils.c: (modest_text_utils_inline):
129 End g_strconcat() with NULL, as its documentation says. This is almost
130 certainly the cause of my crash at startup on the device. Interestingly,
131 valgrind doesn't tell us about these errors.
133 2007-05-11 Murray Cumming <murrayc@murrayc.com>
135 * scripts/build-packages: Added more precise comments about how to use
136 this script, though I still get this error:
137 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
138 error building tinymail
140 2007-05-11 Murray Cumming <murrayc@murrayc.com>
142 * src/maemo/modest-main-window.c: (on_account_update):
143 Very slight cleanup, hoping to make it simpler to discover what causes
144 a crash here sometimes.
146 * src/modest-tny-account.c:
147 (modest_tny_account_new_from_server_account): Set the port. Added
148 comments about the options and a TODO comment because I need to find out
149 how to specify the secure authentication method.
151 2007-05-11 Marcus Bauer <marcusb@openismus.com>
153 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
154 changed CFlags paths form modest to libmodest
156 2007-05-10 Murray Cumming <murrayc@murrayc.com>
158 * src/modest-account-mgr-helpers.c:
159 (modest_account_mgr_get_server_account_data),
160 (modest_account_mgr_free_server_account_data):
161 * src/modest-account-mgr-helpers.h:
162 * src/modest-account-mgr.c:
163 (modest_account_mgr_add_server_account):
165 * src/modest-tny-account.c:
166 (modest_tny_account_new_from_server_account):
167 Determine the options for tny_camel_account_add_option() here,
168 based on the settings, rather than storing them directly in gconf.
170 2007-05-10 Murray Cumming <murrayc@murrayc.com>
172 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
173 Show a more friendly error dialog now that we expect (from the tinymail
174 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
176 2007-05-10 Murray Cumming <murrayc@murrayc.com>
178 * src/maemo/modest-main-window.c: (on_account_update): Check that
179 account_name is not NULL, to prevent a crash at startup that I am
180 seeing on the N800. I do wonder why it is NULL.
182 * src/maemo/easysetup/modest-easysetup-wizard.c:
183 (create_page_user_details):
184 * src/maemo/modest-account-settings-dialog.c:
185 (create_page_user_details), (create_page_outgoing):
186 * src/maemo/modest-connection-specific-smtp-edit-window.c:
187 (modest_connection_specific_smtp_edit_window_init):
188 * src/modest-ui-actions.c:
189 (modest_ui_actions_on_password_requested):
190 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
191 might do something useful with the on-screen keyboard.
193 2007-05-10 Murray Cumming <murrayc@murrayc.com>
195 * src/maemo/modest-main-window.c: (on_account_update):
196 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
197 NULL, to avoid lots of warnings. However, it probably should not be NULL.
199 2007-05-09 Murray Cumming <murrayc@murrayc.com>
201 * src/modest-tny-account-store.c: (on_account_changed):
202 Correct the signature of this signal handler.
204 2007-05-09 Murray Cumming <murrayc@murrayc.com>
206 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
207 Show a HildonNote instead of a GtkDialog for Maemo.
209 2007-05-09 Murray Cumming <murrayc@murrayc.com>
211 * src/widgets/modest-account-view.h:
212 * src/widgets/modest-account-view.c: (on_account_changed),
213 (on_account_removed). Added a boolean flag, set/unset by
214 modest_account_view_block_conf_updates(),
215 modest_account_view_unblock_conf_updates() to prevent unnecessary
216 updates, but this is not very useful because the gconf notifications are
217 so delays (maybe only on Maemo Bora).
218 So auto-updating is turned off, and these functions do an explicit
219 update when necessary.
220 However, something else is still doing too much work when adding/removing
221 accounts, probably in another part of the application.
223 * src/maemo/modest-account-view-window.c:
224 (on_delete_button_clicked), (on_edit_button_clicked),
225 (on_new_button_clicked): Use the new functions.
227 2007-05-09 Murray Cumming <murrayc@murrayc.com>
229 * src/modest-account-mgr-helpers.c:
230 (modest_account_mgr_set_first_account_as_default):
231 Sort the list of names alphabetically-by-title, so we choose the first one
233 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
234 alphabetically by the title.
236 This fixes projects.maemo.org bug NB#56418 .
238 * src/modest-account-mgr-priv.c:
239 (_modest_account_mgr_account_from_key):
240 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
241 avoid a valgrind error, and possible random behaviour.
243 2007-05-09 Murray Cumming <murrayc@murrayc.com>
245 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
246 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
247 tinymail documentation to say that this can be expected.
248 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
249 pretty, and should not happen, but I would prefer to know when it does.
251 2007-05-09 Murray Cumming <murrayc@murrayc.com>
253 * configure.ac: When using the older hildon version, probably on Bora,
254 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
256 * src/widgets/modest-attachment-view.c:
257 (modest_attachment_view_set_part_default): Initialize variables, to fix the
260 2007-05-09 Marcus Bauer <marcusb@openismus.com>
262 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
263 Implemented the prototype. Can be tested with
264 tests/dbus_api/test_open_message:
266 2007-05-08 Murray Cumming <murrayc@murrayc.com>
268 * src/modest-tny-account-store.c:
269 (modest_tny_account_store_instance_init), (get_password):
270 * src/modest-ui-actions.c:
271 (modest_ui_actions_on_password_requested):
272 Do not store the password in gconf, because this function is called
273 for non-remembered passwords. Actually use the cached (in the hash map)
274 password instead of releasing it.
275 The password will now not be remembered if it is asked via the protected
276 password dialog, as per the UI spec.
278 2007-05-08 Murray Cumming <murrayc@murrayc.com>
281 * src/modest-account-mgr-helpers.h:
282 * src/modest-account-mgr-helpers.c:
283 Added modest_server_account_get_username_has_succeeded(),
284 modest_server_account_set_username_has_succeeded().
285 (modest_server_account_set_username),
286 Reset the has-succeeded flag if the username changes.
288 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
289 * src/maemo/modest-connection-specific-smtp-window.c:
290 (modest_connection_specific_smtp_window_save_server_accounts):
291 Use modest_server_account_set_username() instead of using
292 modest_conf_set_string() directly, so that the has-succeeded flag is always
295 * src/modest-ui-actions.c:
296 (modest_ui_actions_on_password_requested): Dim the username entry if
297 the username has ever worked, as per the UI spec.
299 2007-05-08 Murray Cumming <murrayc@murrayc.com>
301 * src/modest-tny-account-store.c: (get_password):
302 * src/modest-ui-actions.c:
303 (modest_ui_actions_on_password_requested):
304 Allow the username to be changed too, though there is more work to
305 be done on exactly how this behaves.
307 2007-05-08 Murray Cumming <murrayc@murrayc.com>
309 * src/modest-account-mgr-helpers.h:
310 * src/modest-account-mgr-helpers.c:
311 Added modest_account_mgr_get_display_name(),
312 modest_server_account_get_username(),
313 modest_server_account_set_username(),
314 modest_server_account_set_password(),
315 modest_server_account_get_hostname() functions so we do not need to
316 use the conf API directly.
318 * src/maemo/modest-main-window.c: (connect_signals):
319 Actually connect ot the ModestAccountStore::request-password signal,
320 so that we show the dialog when the password is requested by Tinymail,
321 for isntance if it is empty.
323 * src/modest-marshal.list:
324 * src/modest-tny-account-store.c:
325 (modest_tny_account_store_class_init), (get_password),
326 (modest_tny_account_store_alert):
327 * src/modest-tny-account-store.h:
328 * src/modest-ui-actions.h:
329 * src/modest-ui-actions.c:
330 (modest_ui_actions_on_password_requested):
331 Change the signal parameters, so it is obvious that we are providing
332 the non human-readable server name, and receiving both the username
333 and password, though changing of the username is not yet implemented.
334 Change the dialog UI to match the Maemo UI specifications, with #idfefing
335 for the GNOME version.
337 This should fix the projects.maemo.org bug NB#56209, though it does not
338 work on Bora, because the gconf_client_get() for the password fails
339 immediately after we save it with gconf_client_set().
341 2007-05-08 Murray Cumming <murrayc@murrayc.com>
344 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
345 caused an undefined symbol error:
346 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
348 2007-05-08 Murray Cumming <murrayc@murrayc.com>
350 * src/modest-tny-account-store.c:
351 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
352 using a GError instead of a string message, so we can translate it in
355 2007-05-08 Murray Cumming <murrayc@murrayc.com>
357 * src/maemo/modest-address-book.c:
358 (modest_address_book_check_names):
359 * src/maemo/modest-msg-view-window.c:
360 (modest_msg_view_window_clipboard_owner_change):
361 * src/modest-init.c: (modest_init_init_ui):
362 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
363 (update_folders_cb), (modest_mail_operation_update_account):
364 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
365 (modest_ui_actions_on_msg_attachment_clicked),
366 (modest_ui_actions_on_msg_recpt_activated):
367 * src/widgets/modest-header-view.c: (drag_data_get_cb):
368 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
369 (modest_msg_view_search_next):
370 * src/widgets/modest-recpt-editor.c:
371 (modest_recpt_editor_on_button_release_event),
372 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
373 g_message(). At this point we should only be seeing interesting errors on
374 stdout. Debugging messages could be #ifdefed-out if they are still useful.
376 2007-05-07 Murray Cumming <murrayc@murrayc.com>
378 (modest_wizard_dialog_force_title_update):
379 * src/maemo/easysetup/modest-wizard-dialog.h:
380 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
381 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
382 can update the title when appropriate. Otherwise the title is wrong if the
383 pages are added after adding the notebook to the dialog.
384 This must be a problem in HildonWizardDialog too.
385 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
387 * src/maemo/easysetup/modest-easysetup-wizard.c:
388 (create_subsequent_customsetup_pages),
389 (create_subsequent_easysetup_pages):
390 Call modest_wizard_dialog_force_title_update() so that the title is
391 correct even with GTK+ < 2.10.
392 This fixes projects.maemo.org bug NB#56145 .
394 2007-05-07 Murray Cumming <murrayc@murrayc.com>
396 * src/maemo/modest-platform.c:
397 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
398 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
401 2007-05-07 Murray Cumming <murrayc@murrayc.com>
403 * src/widgets/modest-window.h:
404 * src/widgets/modest-window.c: Added a save_state_func vfunc,
405 and modest_window_save_state(), which invokes it.
407 * src/widgets/modest-window-mgr.h:
408 * src/widgets/modest-window-mgr.c:
409 Added modest_window_mgr_save_state_for_all_windows(), which calls
410 the save_state vfunc on all registered windows, if implemented.
412 * src/gnome/modest-msg-edit-window.c:
413 * src/gnome/modest-msg-view-window.c:
414 * src/maemo/modest-msg-edit-window.c:
415 * src/maemo/modest-msg-view-window.c:
416 * src/maemo/modest-main-window.c:
417 Specify the existing save_settings functions as implementations of
418 ModestWindow::save_state_func().
420 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
421 Call modest_window_mgr_save_state_for_all_windows(). This happens before
422 enabling hibernation, for instance.
424 We may need to do the same thing for restoring settings.
427 2007-05-07 Murray Cumming <murrayc@murrayc.com>
429 * src/widgets/modest-window-mgr.c:
430 * src/widgets/modest-window-mgr.h:
431 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
432 modest_window_mgr_get_hibernation_is_prevented().
434 * src/maemo/modest-main-window.c:
435 (on_hildon_program_is_topmost_notify): Prevent hibernation
436 (possible when the application goes to the background in the WM),
437 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
439 * src/maemo/easysetup/modest-easysetup-wizard.c:
440 (modest_easysetup_wizard_dialog_init):
441 * src/maemo/modest-account-settings-dialog.c:
442 (modest_account_settings_dialog_init):
443 * src/maemo/modest-connection-specific-smtp-edit-window.c:
444 (modest_connection_specific_smtp_edit_window_init):
445 * src/maemo/modest-connection-specific-smtp-window.c:
446 (modest_connection_specific_smtp_window_init):
447 * src/maemo/modest-signature-editor-dialog.c:
448 (modest_signature_editor_dialog_init):
449 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
450 prevent hibernation while any of these account settings dialogs are open.
452 2007-05-04 Murray Cumming <murrayc@murrayc.com>
454 * src/maemo/Makefile.am:
455 * src/maemo/modest-osso-state-saving.c:
456 * src/maemo/modest-osso-state-saving.h: Added
457 modest_osso_load_state() and modest_osso_save_state() though they do
458 nothing now. They should iterate through all the open windows and load/save
460 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
461 save state when closing.
463 * src/maemo/modest-main-window.c:
464 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
465 Add a notification handler for the HildonProgram::is-topmost property,
466 so we can allow hibernation when the application goes into the background.
467 But we still need to detect when the accounts setup windows are open so
468 we can stop hibernation when they are open.
469 To do this, I also added the main window the HildonProgram. This might have
470 other side-effects/benefits, and should maybe be done for other windows.
472 * src/maemo/modest-osso-autosave-callbacks.h:
473 * src/maemo/modest-osso-autosave-callbacks.c:
474 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
475 though it does not do anything yet, and we might never need this to do
476 anything. For instance, we already save drafts.
478 * src/maemo/modest-platform.c: (modest_platform_init):
479 Specify the libosso auto-save callback.
481 2007-05-03 Murray Cumming <murrayc@murrayc.com>
483 * src/maemo/modest-platform.c:
484 (modest_platform_set_update_interval):
485 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
486 aparently stays valid between application instances, so we can use this
487 to remove and reset it later. According to a maemo-developers email from
490 2007-05-03 Murray Cumming <murrayc@murrayc.com>
492 * configure.ac: Depend on libalarm for Maemo.
494 * src/dbus_api/modest-dbus-api.h:
495 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
496 (on_send_receive), (modest_dbus_req_handler):
497 Handle a SEND_RECEIVE D-Bus method.
499 * libmodest-dbus-client/libmodest-dbus-client.c:
500 (libmodest_dbus_client_send_and_receive):
501 * libmodest-dbus-client/libmodest-dbus-client.h:
502 Add C convenience functions for calling the new D-Bus method.
504 * src/modest-platform.h:
505 * src/gnome/modest-platform.c:
506 * src/maemo/modest-platform.c:
507 Added modest_platform_set_update_interval(), which uses the
509 (modest_platform_init),
510 Call modest_platform_set_update_interval(), using a hard-coded
511 interval for now (until the global settings dialog is implemented),
512 though I am not sure that this makes sense yet.
514 2007-05-02 Murray Cumming <murrayc@murrayc.com>
516 * src/dbus_api/modest-dbus-callbacks.c:
517 (modest_osso_cb_hw_state_handler):
518 * src/dbus_api/modest-dbus-callbacks.h:
519 * src/maemo/modest-platform.c: (modest_platform_init):
520 Registered (empty) callbacks for the osso hardware state D-Bus signals,
521 in case this has some effect on the ability for Maemo to ping the
524 2007-05-02 Murray Cumming <murrayc@murrayc.com>
526 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
527 Comment out an if() that checks a gchar for < 0, causing a build-breaking
528 warning. It is probably a logic error, but I need to fix the build.
530 2007-05-02 Murray Cumming <murrayc@murrayc.com>
532 * src/modest-account-mgr.h:
533 * src/modest-account-mgr.c:
534 (modest_account_mgr_account_names): Add a gboolean enabled_only
535 parameter, so we can get lists of onlt the enabled accounts.
537 (modest_account_mgr_add_account),,
538 (modest_account_mgr_account_with_display_name_exists):
539 * src/maemo/modest-msg-edit-window.c: (get_transports):
540 * src/modest-account-mgr-helpers.c:
541 (modest_account_mgr_set_first_account_as_default):
542 * src/modest-init.c: (init_default_account_maybe):
543 * src/modest-tny-account-store.c: (get_accounts):
544 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
545 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
546 * tests/check_account-mgr.c: (START_TEST):
547 Provide the extra parameter, as appropriate.
549 * src/widgets/modest-account-view.c: (update_account_view):
550 Do not show disabled accounts (meaning that there is no way to
551 enable/disable accounts in the UI (the feature is not in our UI
552 specification), so we can use this internally only to mark unfinished
553 or temporary account data.
555 * src/maemo/easysetup/modest-easysetup-wizard.c:
556 (create_account): Add boolean enable parameter, so we can specify FALSE
557 to create the temporary account.
558 (on_button_edit_advanced_settings): Create the temporary account as disabled.
559 (on_before_next): When finishing, when there is a temporary account, just
561 Also, use a timeout to delay the showing of the dialog until gconf is likely
562 to return correct information, due to a maemo gconf bug that is fixed in
563 osso 1.1, but not yet in Bora.
564 However, the dialog stays on screen after it is destroyed.
566 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
567 for invalid data when cancelling. Use a hildon note instead of a dialog
568 to complain about invalid data. Do not show the account-saved note if the
569 account is disabled (a temporary account that will not really be saved for use
572 2007-04-30 Murray Cumming <murrayc@murrayc.com>
574 * src/modest-account-mgr-helpers.h:
575 * src/modest-account-mgr-helpers.c:
576 Added modest_account_mgr_unset_default_account(),
577 Added modest_account_mgr_set_first_account_as_default().
579 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
580 If it was the default account, unset the default account name.
582 * src/maemo/modest-account-view-window.c:
583 (on_delete_button_clicked): If it was the default account,
584 set the first remaining account as the default instead.
586 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
587 a NULL account or a NULL default account, to prevent a crash. This should
588 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
591 2007-04-30 Murray Cumming <murrayc@murrayc.com>
593 * src/widgets/modest-recpt-editor.c:
594 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
595 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
596 TODO comment for this. This fixes the build.
598 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
599 be the best place for it. This will in future update all auto-update accounts,
600 rather than just the current/default account, when that gconf key exists.
601 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
602 if there are no accounts, before calling do_send_receive().
603 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
605 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
606 * src/maemo/modest-main-window-ui.h:
607 * src/maemo/modest-main-window.c: (on_connection_changed),
608 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
609 directly, becaue the signal handler does more.
611 2007-04-30 Murray Cumming <murrayc@murrayc.com>
613 * src/modest-account-mgr-helpers.c:
614 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
615 for the case that the account does not exist.
617 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
618 (equivalent to the modest account name) rather than the tinymail account name
619 (equivalent to the modest account title - human readable) to get the account data.
620 Check for null account data to prevent the crash, and add a TODO comment saying that
621 this needs fixing because it is using the server account name instead of the account name.
623 2007-04-29 Murray Cumming <murrayc@murrayc.com>
625 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
626 * src/maemo/modest-account-settings-dialog.c: (show_error),
628 Use hildon_note_new_information() for informative and error messages,
629 which seems to be expected for Maemo applications (no documentation that I know of
630 says this). I am surprised that there is no distinction between info and error
633 2007-04-29 Murray Cumming <murrayc@murrayc.com>
635 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
636 it is easy to find where this is used.
638 * src/maemo/easysetup/modest-easysetup-wizard.c:
639 (create_page_welcome), (create_page_account_details),
640 (create_page_user_details), (create_page_complete_easysetup),
641 (create_page_custom_incoming), (create_page_custom_outgoing),
642 (create_page_complete_custom):
643 * src/maemo/modest-account-settings-dialog.c:
644 (create_page_account_details), (create_page_user_details),
645 (create_page_incoming), (create_page_outgoing):
646 * src/maemo/modest-account-view-window.c: (window_vbox_new):
647 * src/maemo/modest-connection-specific-smtp-edit-window.c:
648 (modest_connection_specific_smtp_edit_window_init):
649 * src/maemo/modest-connection-specific-smtp-window.c:
650 (modest_connection_specific_smtp_window_init):
651 * src/maemo/modest-signature-editor-dialog.c:
652 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
653 and scrolling policy as per the Email Application Layout Guide, if I have
656 2007-04-27 Murray Cumming <murrayc@murrayc.com>
658 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
659 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
660 which were empty, because these vfuncs have been removed from TnyAccountStore.
661 This fixes the build.
663 2007-04-27 Murray Cumming <murrayc@murrayc.com>
665 * src/maemo/modest-main-window.c:
666 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
667 showing/hiding it. Added TODO because it probably should not be NULL.
668 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
669 because unnecessary g_warnings() make degugging difficult.
671 2007-04-27 Murray Cumming <murrayc@murrayc.com>
673 * src/maemo/modest-msg-edit-window.c:
674 (modest_msg_edit_window_select_color),
675 (modest_msg_edit_window_select_background_color): 2 const corrections and
676 moving 2 #endifs before closing brackets, to fix the build.
678 2007-04-27 Murray Cumming <murrayc@murrayc.com>
680 * src/maemo/easysetup/modest-easysetup-wizard.h:
681 * src/maemo/easysetup/modest-easysetup-wizard.c:
682 (modest_easysetup_wizard_dialog_finalize),
683 (on_button_edit_advanced_settings), (create_page_complete_custom),
684 (on_response), (create_account):
685 Implement the Advanced Settings edit button, by saving the account information,
686 for the Advanded Settings dialog to use directly from gconf, and removing it
687 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
688 Bug #5533 in the projects.maemo.org bugzilla.
690 2007-04-27 Murray Cumming <murrayc@murrayc.com>
692 * src/maemo/modest-msg-view-window.c:
693 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
694 when opening a message window.
696 2007-04-27 Murray Cumming <murrayc@murrayc.com>
698 * src/maemo/easysetup/modest-easysetup-wizard.c:
699 (create_page_custom_outgoing): Correct the position of the horizontal separator to
702 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
703 before showing/hiding them, to avoid a crash when clicking on folders when there are no
704 gconf settings. I probably added more checks than necessary, but that is safer.
706 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
707 variable to fix the build, but this seems to be used when it is still NULL.
709 2007-04-27 Murray Cumming <murrayc@murrayc.com>
711 * src/modest-platform.h:
712 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
713 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
714 * src/modest-main.c: Implement this function so we can avoid using
715 maemo-specific API from cross-platform code.
717 * src/modest-tny-account-store.c:
718 (get_smtp_specific_transport_account_for_open_connection):
719 * src/modest-ui-actions.c: (check_for_connection),
720 (modest_ui_actions_on_item_not_found):
721 Use modest_platform_connect_and_wait() and put #idefs around other
722 maemo-specific code, because only maemo currently has a way to
723 identify connection names.
725 2007-04-27 Murray Cumming <murrayc@murrayc.com>
727 * src/modest-tny-account-store.h:
728 * src/modest-tny-account-store.c:
729 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
730 the connection-specific SMTP server settings in the configuration.
732 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
734 * src/maemo/modest-main-window.c: (on_connection_changed),
736 * src/modest-main.c: (main), (start_ui), (send_mail):
737 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
738 that is what is intended.
740 * src/modest-ui-actions.c: (action_send), (action_receive),
741 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
742 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
743 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
744 SMTP server is used when it is specified.
746 (modest_ui_actions_on_send_receive):
747 Check that a connection is open before proceeding.
748 Receive and then send, instead of vice-versa, as per the specification.
750 2007-04-26 Murray Cumming <murrayc@murrayc.com>
752 * src/modest-mail-operation.c:
753 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
754 though I guess it should be something other than NULL.
756 2007-04-26 Murray Cumming <murrayc@murrayc.com>
758 * src/maemo/easysetup/modest-easysetup-wizard.c:
759 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
760 combo twice, to avoid an g_warning and to make it visible again.
761 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
762 attached before detaching it, to avoid a g_warning, and add comment about the implicit
763 (already intended) dereference when detaching, because we then recreate the menu.
764 But I am not sure why the warning was happening, and it is possible that this is a memory
767 2007-04-25 Murray Cumming <murrayc@murrayc.com>
769 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
770 and uri_parse_mailto() utility functions.
771 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
773 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
775 2007-04-24 Murray Cumming <murrayc@murrayc.com>
777 * src/dbus_api/modest-dbus-api.h:
778 * src/dbus_api/modest-dbus-callbacks.c:
779 Use an idle callback to execute the modest code in the application's own thread.
780 Remove the helloworld example method.
781 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
782 parsed, and the open-message method is not implemented because this is not yet implemented in
784 * libmodest-dbus-client/libmodest-dbus-client.c:
785 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
786 (libmodest_dbus_client_open_message):
787 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
789 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
790 body without crashing.
792 * tests/dbus_api/Makefile.am:
793 * tests/dbus_api/test_mail_to.c:
794 * tests/dbus_api/test_open_message.c: New tests for the new methods.
796 2007-04-24 Murray Cumming <murrayc@murrayc.com>
798 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
799 Added file to fix the build. Sorry.
801 * src/dbus_api/Makefile.am:
802 * src/dbus_api/modest-dbus-api.h:
803 * src/dbus_api/modest-dbus-callbacks.h:
804 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
805 (modest_dbus_req_handler):
806 Put constants in a separate header so it can be reused by the
807 client library, without duplication
809 * libmodest-dbus-client/Makefile.am:
810 * libmodest-dbus-client/libmodest-dbus-client.c:
811 (libmodest_dbus_client_call_helloworld),
812 (libmodfest_dbus_client_send_mail),
813 (libmodfest_dbus_client_mailto),
814 (libmodfest_dbus_client_open_message):
815 * libmodest-dbus-client/libmodest-dbus-client.h:
816 (Partly) Implement a send_mail D-Bus method.
818 * tests/dbus_api/Makefile.am:
819 * tests/dbus_api/test_send_mail.c: (main): Added a test for
820 the send_email D-Bus method.
822 2007-04-24 Murray Cumming <murrayc@murrayc.com>
826 * libmodest-dbus-client/Makefile.am:
827 * libmodest-dbus-client/libmodest-dbus-client.c:
828 * libmodest-dbus-client/libmodest-dbus-client.h:
829 * tests/dbus_api/Makefile.am:
830 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
831 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
833 2007-04-24 Murray Cumming <murrayc@murrayc.com>
835 * src/maemo/easysetup/modest-easysetup-wizard.c:
836 (create_page_account_details):
837 * src/maemo/modest-account-settings-dialog.c:
838 (create_page_account_details): Explicitly set auto-capitalization mode for the title
839 widgets, because this might not be the default in future versions of the Maemo GTK+.
840 However, I can not not get capitalization to work even in a simple test case.
842 2007-04-24 Murray Cumming <murrayc@murrayc.com>
844 * src/maemo/easysetup/modest-easysetup-wizard.c:
845 (create_page_custom_incoming), (create_page_custom_outgoing):
846 * src/maemo/modest-account-settings-dialog.c:
847 (create_page_account_details), (create_page_incoming),
848 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
849 instead of using gtk_check_button_with_label(), so they are aligned like the other
850 widgets, as per the UI spec.
852 2007-04-24 Murray Cumming <murrayc@murrayc.com>
854 * src/maemo/easysetup/modest-easysetup-wizard.c:
855 * src/maemo/modest-connection-specific-smtp-edit-window.c:
856 * src/widgets/modest-validating-entry.c:
857 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
858 Modest prefix instead of an EasySetup prefix.
860 2007-04-23 Murray Cumming <murrayc@murrayc.com>
862 * src/widgets/modest-validating-entry.h:
863 * src/widgets/modest-validating-entry.c: (on_insert_text),
864 Added easysetup_validating_entry_set_max_func(), used to set a callback
865 to call when the max number of characters is reached. GtkEntry has a max-length
866 already but is silent about it.
868 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
869 (create_page_account_details), (create_page_user_details),
871 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
872 (create_page_account_details), (create_page_user_details),
873 (create_page_outgoing):
874 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
875 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
876 the UI spec, when the user tries to enter more than the max number of characters.
878 2007-04-23 Murray Cumming <murrayc@murrayc.com>
880 * src/maemo/easysetup/modest-easysetup-wizard.c:
881 (create_page_user_details), (create_page_custom_incoming),
882 (create_page_custom_outgoing):
883 * src/maemo/modest-account-settings-dialog.c:
884 (create_page_user_details), (create_page_incoming),
885 (create_page_outgoing):
886 * src/maemo/modest-connection-specific-smtp-edit-window.c:
887 (modest_connection_specific_smtp_edit_window_init):
888 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
889 not appropriate. Bad Maemo-specific defaults!.
891 2007-04-23 Murray Cumming <murrayc@murrayc.com>
893 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
894 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
895 (modest_signature_editor_dialog_set_settings):
896 Disable the label and textview when the checkbox is disabled, and use the
897 specified (UI spec) default signature text.
899 2007-04-23 Murray Cumming <murrayc@murrayc.com>
901 * src/maemo/modest-connection-specific-smtp-edit-window.c:
902 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
905 * src/modest-account-mgr-helpers.h:
906 * src/modest-account-mgr-helpers.c:
907 Added modest_account_mgr_get/set_signature(), using new gconf keys.
909 * src/maemo/Makefile.am:
910 * src/maemo/modest-signature-editor-dialog.c:
911 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
914 * src/maemo/modest-account-settings-dialog.h:
915 * src/maemo/modest-account-settings-dialog.c:
916 (modest_account_settings_dialog_finalize), (on_button_signature),
917 (save_configuration): Use the new dialog when the Edit button is pressed, and
918 save the changes if necessary, as per the UI spec.
920 2007-04-23 Murray Cumming <murrayc@murrayc.com>
922 * src/maemo/Makefile.am:
923 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
924 based on maemo-develoers email from Dirk.
926 * src/maemo/easysetup/modest-easysetup-wizard.c:
927 (create_page_welcome), (create_page_account_details),
928 (create_page_user_details), (create_page_complete_easysetup),
929 (create_page_custom_incoming), (create_page_custom_outgoing),
930 (create_page_complete_custom),
931 (modest_easysetup_wizard_dialog_init):
932 * src/maemo/modest-account-settings-dialog.c:
933 (create_page_account_details), (create_page_user_details),
934 (create_page_incoming), (create_page_outgoing),
935 (modest_account_settings_dialog_init):
936 * src/maemo/modest-connection-specific-smtp-window.c:
937 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
939 2007-04-23 Murray Cumming <murrayc@murrayc.com>
941 * src/maemo/easysetup/modest-easysetup-wizard.c:
942 (create_page_account_details), (create_page_custom_outgoing),
943 (create_page_complete_custom):
944 * src/maemo/modest-account-settings-dialog.c:
945 (create_page_user_details), (create_page_incoming),
946 (create_page_outgoing):
947 * src/maemo/modest-connection-specific-smtp-edit-window.c:
948 (modest_connection_specific_smtp_edit_window_init):
949 Use the correct (UI spec) port min/max, and use horizontal separators,
952 2007-04-23 Murray Cumming <murrayc@murrayc.com>
954 * src/maemo/easysetup/modest-easysetup-wizard.c:
955 (set_default_custom_servernames):
956 * src/maemo/modest-account-settings-dialog.c:
957 (create_page_incoming), (on_combo_outgoing_security_changed),
958 (on_combo_incoming_security_changed), (create_page_outgoing),
959 (modest_account_settings_dialog_set_account_name),
960 (save_configuration):
961 * src/maemo/modest-connection-specific-smtp-edit-window.c:
962 (on_combo_security_changed),
963 (modest_connection_specific_smtp_edit_window_init),
964 (modest_connection_specific_smtp_edit_window_set_connection),
965 (modest_connection_specific_smtp_edit_window_get_settings):
966 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
969 2007-04-20 Murray Cumming <murrayc@murrayc.com>
972 * src/maemo/easysetup/modest-easysetup-wizard.c:
973 (create_page_custom_outgoing), (create_page_complete_custom):
974 * src/maemo/modest-account-settings-dialog.c:
975 (create_page_user_details), (create_page_outgoing):
976 * src/maemo/modest-account-view-window.c: (button_box_new):
977 Use changed logical IDs as per the most recent UI spec:
978 mcen_bd_emailsetup_edit -> mcen_bd_edit
979 mcen_bd_emailsetup_delete -> mcen_bd_delete
980 mcen_bd_emailsetup_close -> mcen_bd_close
982 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
986 * src/dbus_api/Makefile.am:
987 * src/dbus_api/modest-dbus-callbacks.c:
988 * src/dbus_api/modest-dbus-callbacks.h:
989 * src/maemo/modest-platform.c: (modest_platform_init):
990 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
993 * tests/dbus_api/Makefile.am:
994 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
996 2007-04-20 Murray Cumming <murrayc@murrayc.com>
998 * src/maemo/modest-account-settings-dialog.c:
999 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1000 Removed unnecessary includes.
1002 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1004 * src/maemo/easysetup/modest-easysetup-wizard.c:
1005 * src/maemo/modest-account-settings-dialog.c:
1006 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1007 * src/widgets/Makefile.am:
1008 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1009 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1010 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1011 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1012 * src/widgets/modest-secureauth-combo-box.c:
1013 * src/widgets/modest-secureauth-combo-box.h:
1014 * src/widgets/modest-serversecurity-combo-box.c:
1015 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1016 made the GObject names more consistent with the rest of the Modest code.
1018 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1020 * src/maemo/easysetup/Makefile.am:
1021 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1022 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1023 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1024 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1025 * src/maemo/easysetup/modest-easysetup-wizard.c:
1026 * src/maemo/easysetup/modest-validating-entry.c:
1027 * src/maemo/easysetup/modest-validating-entry.h:
1028 * src/maemo/modest-account-settings-dialog.c:
1029 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1030 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1031 widgets/ because they are used outside of easysetup too. After checking in,
1032 svn will allow me to rename them too.
1034 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1036 * src/gnome/modest-msg-edit-window.c:
1037 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1038 linker error, to fix the build on the GNOME platform.
1039 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1040 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1041 ifdefed out to avoid a warning.
1043 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1045 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1046 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1047 some alternative for GTK+ 2.6.
1049 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1051 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1053 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1054 specified for EmailAccountsDialog in UI spec.
1056 * src/maemo/easysetup/modest-easysetup-wizard.c:
1057 * src/maemo/easysetup/modest-easysetup-wizard.h:
1058 * src/maemo/modest-account-settings-dialog.c:
1059 * src/maemo/modest-account-settings-dialog.h:
1060 Reuse a member window widget for the connection-specific SMTP server accounts,
1061 so we can tell it to create/save the accounts only if we actually save changes.
1063 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1064 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1065 (modest_connection_specific_smtp_edit_window_get_settings):
1066 Return a struct instance for temporarily remembering the entered data.
1068 * src/maemo/modest-connection-specific-smtp-window.h:
1069 * src/maemo/modest-connection-specific-smtp-window.c:
1070 (modest_connection_specific_smtp_window_finalize),
1071 (modest_connection_specific_smtp_window_fill_with_connections),
1073 (modest_connection_specific_smtp_window_save_server_accounts),
1074 (update_model_server_names): Do not actually save data until asked,
1075 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1077 (on_selection_changed),
1078 (modest_connection_specific_smtp_window_init): Disable the edit
1079 button when nothing is selected.
1081 * src/modest-account-mgr-helpers.c:
1082 * src/modest-account-mgr-helpers.h:
1083 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1086 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1088 * src/modest-account-mgr-helpers.h:
1089 * src/modest-account-mgr-helpers.c:
1090 (modest_account_mgr_get_unused_account_name),
1091 (modest_account_mgr_get_unused_account_display_name): Added these
1092 utility functions, to avoid code duplication.
1094 * src/maemo/easysetup/modest-easysetup-wizard.c:
1095 (create_page_account_details), (create_account):
1096 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1097 (on_combo_security_changed),
1098 (modest_connection_specific_smtp_edit_window_init),
1099 (modest_connection_specific_smtp_edit_window_save_settings):
1100 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1101 * src/maemo/modest-connection-specific-smtp-window.c:
1102 (modest_connection_specific_smtp_window_finalize),
1103 (modest_connection_specific_smtp_window_fill_with_connections),
1104 (on_button_edit), (modest_connection_specific_smtp_window_init):
1105 * src/maemo/modest-connection-specific-smtp-window.h:
1106 Implementing saving of connection-specific server accounts.
1108 But I need to refactor this so we can save the data for each
1109 possible connection-specific account and only actually create the server accounts
1110 when the easysetup finished, or the OK button is pressed on the account settings
1113 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1115 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1116 (on_combo_security_changed):
1117 (modest_connection_specific_smtp_edit_window_init):
1118 Auto-fill the port number as in the account settings.
1120 (modest_connection_specific_smtp_edit_window_set_connection):
1121 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1122 * src/maemo/modest-connection-specific-smtp-window.c:
1123 (fill_with_connections), (on_button_edit),
1124 (modest_connection_specific_smtp_window_init):
1125 Turn the edit window into a dialog to simplify the code, and
1126 set a WM hint as in a GtkDialog, because only a popup can be on top of
1127 another window in Maemo, and popups usually have no WM decoration.
1129 * src/modest-defs.h:
1130 * src/modest-account-mgr-helpers.c:
1131 (modest_account_mgr_set_connection_specific_smtp),
1132 (modest_account_mgr_remove_connection_specific_smtp),
1133 (modest_account_mgr_get_connection_specific_smtp):
1134 * src/modest-account-mgr-helpers.h: Some functions to write the
1135 connection-specific SMTP server information. Not yet used.
1138 * src/widgets/modest-folder-view.c: (text_cell_data):
1139 Fix a warning about an uninitialized variable.
1140 (on_configuration_key_changed): Put an #ifdef around the use
1141 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1143 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1145 * src/maemo/modest-account-settings-dialog.h:
1146 * src/maemo/modest-account-settings-dialog.c:
1147 Added connect_for_modified() utility function to mark the new modified boolean.
1149 (create_page_account_details), (create_page_user_details),
1150 (create_page_incoming), (create_page_outgoing), (on_response),
1151 (modest_account_settings_dialog_init),
1152 (modest_account_settings_dialog_set_account_name):
1153 Only warn about unsaved changes when there are actually unsaved changes.
1155 * src/modest-account-mgr-helpers.c:
1156 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1157 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1158 to get the data from there in future.
1160 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1162 * src/modest-defs.h:
1164 * src/modest-account-mgr-helpers.h:
1165 * src/modest-account-mgr-helpers.c:
1166 Store the security account setting in a single conf key instead of using
1167 the options list, so that the list is left for just the to-be-removed camel hack,
1168 and because gconf_client_set_list() is failing for some reason.
1170 * src/modest-account-mgr.c:
1171 (modest_account_mgr_add_server_account):
1172 * src/maemo/modest-account-settings-dialog.c:
1173 (modest_account_settings_dialog_set_account_name),
1174 (save_configuration): Use the renamed functions.
1177 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1179 * src/widgets/Makefile.am:
1180 * src/widgets/modest-limit-retrieve-combo-box.c:
1181 * src/widgets/modest-limit-retrieve-combo-box.h:
1182 * src/widgets/modest-retrieve-combo-box.c:
1183 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1184 the account settings dialog.
1186 * src/modest-defs.h:
1187 * src/modest-account-mgr-helpers.h:
1188 * src/modest-account-mgr-helpers.c:
1189 (modest_server_account_get_option_secure_auth),
1190 (modest_server_account_set_option_secure_auth):
1191 * src/modest-account-mgr.c:
1192 (modest_account_mgr_add_server_account):
1193 Use the existing AUTH_MECH conf key for the secure-auth setting,
1194 instead of putting it in the list options, because this was actually used already.
1196 * src/maemo/modest-account-settings-dialog.c:
1197 (create_page_account_details),
1198 (modest_account_settings_dialog_set_account_name),
1199 (save_configuration):
1200 * src/maemo/modest-account-settings-dialog.h:
1201 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1202 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1204 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1206 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1207 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1208 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1210 * src/modest-defs.h:
1211 * src/maemo/modest-account-settings-dialog.c:
1212 (create_page_incoming), (on_combo_outgoing_security_changed),
1213 (on_combo_incoming_security_changed), (create_page_outgoing),
1214 (modest_account_settings_dialog_set_account_name),
1215 (save_configuration): Load/Save the port number, and change it when the
1216 security combo changes, to suitable defaults.
1218 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1220 * src/modest-account-mgr.c:
1221 (modest_account_mgr_add_server_account): Set the security and secure-auth
1222 options, and add a comment saying that the other camel-specific options should be
1225 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1227 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1229 * src/modest-tny-account-store.c: (account_list_free),
1230 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1231 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1234 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1236 * src/modest-protocol-info.c:
1237 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1238 is required by our UI spec. Maybe something in our implementation will use this eventually.
1239 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1240 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1241 instead of the previous 0 placeholder.
1243 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1244 secure-auth settings.
1245 * src/modest-account-mgr-helpers.h:
1246 * src/modest-account-mgr-helpers.c:
1247 (modest_server_account_data_get_option_secure_auth),
1248 (modest_server_account_set_option_secure_auth),
1249 (modest_server_account_data_get_option_security),
1250 (modest_server_account_set_option_security): Added this API for getting and setting the security
1251 and secure-auth settings.
1253 * src/maemo/modest-account-settings-dialog.h:
1254 * src/maemo/modest-account-settings-dialog.c:
1255 (modest_account_settings_dialog_finalize), (check_data),
1256 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1257 about changing titles.
1258 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1259 (save_configuration): Save the security and secure-auth settings.
1261 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1262 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1264 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1266 * src/modest-defs.h:
1267 * src/modest-account-mgr.c:
1268 (modest_account_mgr_add_server_account):
1269 Added and used defines for the options key and value pair strings,
1270 that are used so far, though they do not seem to correspond to anything in our
1271 UI specs or ModestProtocol enum.
1273 * src/modest-account-mgr-helpers.h:
1274 * src/modest-account-mgr-helpers.c:
1275 (compare_option_strings_for_name),
1276 (modest_server_account_data_get_option_value),
1277 (modest_server_account_data_get_option_bool),
1278 (modest_account_mgr_get_server_account_option):
1279 Added helper functions for parsing the options GSList.
1281 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1283 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1284 display name is based on the supplied account name.
1285 * src/modest-account-mgr.c:
1286 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1287 with an inefficient, but good-enough, implementation.
1289 * src/maemo/easysetup/modest-easysetup-wizard.c:
1290 (create_page_account_details), (on_before_next), (create_account):
1291 Check for existing display names rather than (non-user-visible) account names, and just
1292 create and set a unique account name at the end.
1294 * src/maemo/modest-account-settings-dialog.c:
1295 (modest_account_settings_dialog_init),
1296 (modest_account_settings_dialog_set_account_name),
1297 (create_page_incoming): Show the display name, instead of the account name.
1298 (on_response): Do some (not all) extra checks, as in the UI spec.
1299 (save_configuration): Save the display name if it was changed.
1301 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1303 * po/en_GB.po: Added needed logical ID and translation.
1304 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1305 (init_view): Made the is-default column clicking work.
1307 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1310 * src/maemo/easysetup/Makefile.am:
1311 * src/maemo/easysetup/modest-easysetup-wizard.c:
1312 (modest_easysetup_wizard_dialog_init):
1313 * src/maemo/easysetup/provider-data-test.keyfile:
1314 * src/maemo/easysetup/provider-data.keyfile:
1315 Moved the provider data file to the new modest-providers-data package and used it from there.
1317 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1319 * src/modest-local-folder-info.c:
1320 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1321 N_() was already used on the static strings, but this just marks it for translation without
1322 using the translation.
1324 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1326 * src/maemo/modest-account-settings-dialog.c:
1327 (create_page_incoming),
1328 (modest_account_settings_dialog_set_account_name):
1329 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1330 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1331 I will do this if nobody else gets there first.
1333 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1335 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1336 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1337 save the security stuff.
1339 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1341 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1342 Set the email address and user fullname, which I now see must be
1345 * src/maemo/modest-account-settings-dialog.h:
1346 * src/maemo/modest-account-settings-dialog.c:
1348 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1349 leave-on-server and authentication.
1350 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1353 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1356 * src/maemo/modest-account-settings-dialog.c:
1357 * src/maemo/modest-account-settings-dialog.h:
1358 Most (but not all) of the widgets are now present as specified by the UI spec.
1359 No changes are yet saved, and some details are not properly shown yet.
1361 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1363 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1365 * src/maemo/Makefile.am:
1366 * src/maemo/modest-account-settings-dialog.c:
1367 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1368 an existing account. Doesn't do much yet.
1370 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1371 Open the accounts settings dialog when Edit is clicked.
1373 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1375 * src/maemo/easysetup/Makefile.am:
1376 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1378 * src/maemo/easysetup/modest-easysetup-wizard.c:
1379 (modest_easysetup_wizard_dialog_init):
1380 Try to get the source directory from the build system,
1381 instead of hard-coding "./" into the source code, when opening our local
1382 copies of the configuration files.
1383 But this still fails when opening the wizard from the Accounts window,
1384 maybe because the working directory seems to change at runtime.
1385 So the wizard will fail the second time unless you copy the files into their
1386 proper locations - see the stdout warnings for the paths.
1388 (create_page_account_details),(on_before_next):
1389 Check for existing non-server accounts instead of server accounts,
1390 so the default account name is useful again, and to prevent trying to
1393 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1394 Show the wizard when New is clicked.
1396 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1397 (init_view): Show the column headers, and show the columns that are
1398 specified in the UI specs. However, something in Maemo's GTK+ prevents
1399 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1400 change the default account. This is despite unsetting the special properties.
1402 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1404 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1405 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1406 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1407 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1408 to make that clearer.
1409 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1411 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1413 * src/maemo/modest-account-view-window.c:
1414 (modest_account_view_window_init),
1415 (modest_account_view_window_new):
1416 Use the same buttons as specified in the
1417 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1418 the existing widgets, which never had a chance of working.
1419 Put the ModestAccountView treeview in a scrolled window.
1420 Do not repeat the initialization in both _init() and _new().
1422 * src/widgets/modest-account-view.c: (update_account_view):
1423 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1424 this widget and window shows no accounts.
1426 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1428 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1430 * src/maemo/easysetup/modest-easysetup-wizard.c:
1431 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1432 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1433 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1436 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1437 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1438 accounts exist yet, as in the UI spec.
1440 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1442 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1444 * src/maemo/Makefile.am:
1445 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1446 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1447 New window for editing connection-specific smtp details.
1448 Not fully implemented.
1450 * src/maemo/modest-connection-specific-smtp-window.c:
1451 (modest_connection_specific_smtp_window_finalize) :
1452 unref the tree model.
1453 (on_button_edit): Show the edit window.
1455 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1457 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1460 * src/maemo/Makefile.am:
1461 * src/maemo/modest-connection-specific-smtp-window.c:
1462 * src/maemo/modest-connection-specific-smtp-window.h:
1463 New window for showing the list of connections, for connection-specific
1464 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1465 * src/maemo/easysetup/modest-easysetup-wizard.c:
1466 (create_page_custom_outgoing): Show the new window when the button is clicked.
1468 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1470 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1471 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1472 * src/maemo/modest-msg-edit-window.c:
1473 (modest_msg_edit_window_insert_image):
1474 * src/modest-conf.c: (modest_conf_key_escape):
1475 * src/modest-mail-operation.c:
1476 (modest_mail_operation_send_new_mail):
1477 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1478 (modest_ui_actions_on_new_account):
1479 * src/widgets/modest-attachment-view.c: (update_filename_request):
1480 * src/widgets/modest-mail-header-view.c:
1481 Corrected warnings that were breaking the build, by commenting out unused variables,
1482 and a function, and by including a header.
1484 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1486 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1487 so we can #ifdef around platform-specific code when necessary.
1488 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1489 to allow this to build for the GNOME platform too.
1491 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1493 * src/maemo/easysetup/modest-easysetup-wizard.c:
1494 Added util_increment_name() and used it in create_page_account_details()
1495 to make sure that the default account name is always a new name.
1497 (modest_easysetup_wizard_dialog_init),
1498 (set_default_custom_servernames): Some minor memory management fixes.
1500 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1504 * src/modest-runtime.c: (init_i18n): Restored the translation
1505 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1506 are defined in config.h, and the translations are installed.
1508 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1509 is defined for translation.
1511 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1513 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1515 * src/maemo/easysetup/modest-easysetup-wizard.c:
1516 (modest_easysetup_wizard_dialog_init):
1517 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1518 Use realistic paths (though they should use $prefix generically) to the
1519 mcc_mapping and provider-data.keyfile files which might work when they
1520 are installed by the future version of the operator-wizard package,
1521 and then fallback to paths in our source code, with an explanatory
1524 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1528 * src/maemo/Makefile.am:
1529 * src/maemo/easysetup/: Added files from the previously-exernal
1530 osso-modest-easysetup.
1531 * src/maemo/modest-main-window-ui.h:
1532 * src/modest-ui-actions.c:
1533 * src/modest-ui-actions.h:
1534 Added modest_ui_actions_on_new_account() as a signal handler for the
1535 New Account menu item. It shows the easysetup wizard.
1536 * po/en_GB.po: Added additional needed logical IDs and translations.
1538 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1539 Apparently ChangeLog is not used for some vague Nokia legal reasons.