1 2007-06-22 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (get_password):
4 Use tny_account_set_username() to tell tinymail that the username might
5 have changed too. But tinymail ignores this: see projects.maemo.org
7 * src/modest-ui-actions.c:
8 (modest_ui_actions_on_password_requested): Remove the useless attempt to
9 reset the connection when changing the username, and improve the comments.
10 Save the changed username to gconf at least, so it is used when Modest is
13 2007-06-21 Murray Cumming <murrayc@murrayc.com>
15 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
16 Do not use a query, so that we get all folders, including for POP and
17 local-folders. They work as search criteria too.
18 This fixes projects.maemo.org bug NB#57740.
20 2007-06-21 Murray Cumming <murrayc@murrayc.com>
22 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
23 Comment out the use of hildon_notification_set_sound() because it is
24 not declared, to fix the build. Warnings are serious, people.
26 2007-06-21 Armin Burgmeier <armin@openismus.com>
28 * src/maemo/modest-maemo-utils.h:
29 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
30 modest_maemo_utils_get_supported_secure_authentication_methods()
31 to query authentication methods for a specific user. This should fix
32 projects.maemo.org bug NB#61369.
34 * src/maemo/easysetup/modest-easysetup-wizard.c:
35 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
38 2007-06-21 Murray Cumming <murrayc@murrayc.com>
40 * libmodest-dbus-client/libmodest-dbus-client.h:
41 * libmodest-dbus-client/libmodest-dbus-client.c:
42 (modest_dbus_message_iter_get_search_hit),
43 (libmodest_dbus_client_search):
44 Reorganised and commented this.
45 Removed modest_search_hit_free() from the public API because it
48 Added libmodest_dbus_client_get_folders() and
49 modest_folder_result_list_free().
51 * src/dbus_api/modest-dbus-api.h:
52 * src/dbus_api/modest-dbus-callbacks.c:
53 (modest_dbus_req_filter): Commented. Moved most code to
54 on_dbus_method_search() and added on_dbus_method_get_folders().
56 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
57 of the extra D-Bus handler.
59 * tests/dbus_api/Makefile.am:
60 * tests/dbus_api/test_get_folders.c: New test for
61 libmodest_dbus_client_get_folders(). This seems to return an empty list
62 at the moment. That could be the same error that causes the message list
63 to be empty sometimes.
64 This should help with projects.maemo.org bug NB#57740.
66 2007-06-21 Armin Burgmeier <armin@openismus.com>
68 * src/modest-mail-operation.c: Do not call
69 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
70 notify the operation's end after having set the status to CANCELED for
71 the operation queue to listen on. This fixes a deadlock when there
72 were mail operations in the queue during its finalization.
74 * src/modest-singletons.c: Reordered uninitialization of the account
75 manager to happen after the mail operation queue was uninitialized
76 because the mail operation's in the queue might still try to access
77 the account manager (see modest_mail_operation_notify_end()). This
78 fixes a potential crash when terminating the application.
80 2007-06-21 Murray Cumming <murrayc@murrayc.com>
82 * src/modest-search.c:
83 (search_mime_part_and_child_parts): Moved some code here so we
84 can search recursively in child folders.
85 (modest_search_folder): Search in the message as a mime part, instead
86 of just its child mime parts.
87 (read_chunk), (search_mime_part_ogs):
88 Check how many bytes were read, to prevent an endless loop.
89 Searching in message bodies now works. This finishes the fix for
90 projects.maemo.org bug NB#61007.
92 2007-06-20 Murray Cumming <murrayc@murrayc.com>
94 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
95 Add a g_warning when the item is not a folder.
97 * src/modest-ui-dimming-rules.c:
98 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
99 when selected item is not a folder (for instance, an account), because
100 the UI spec only talks about folders.
101 I am not sure what the UI spec wants, so this might not totally fix
102 projects.maemo.org bug NB#60794.
104 2007-06-20 Murray Cumming <murrayc@murrayc.com>
106 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
107 (load_from_file): Sort the list. The unsorted list would be more noticeable
108 in non-English locales.
110 * src/maemo/modest-msg-edit-window.c:
111 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
112 warning and fix the build.
114 * src/maemo/modest-progress-bar-widget.c:
115 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
116 avoid a g_warning, and probably to avoid a crash.
118 2007-06-20 Murray Cumming <murrayc@murrayc.com>
120 * src/modest-search.c: (modest_search_folder): Check for a GError
121 when calling tny_folder_get_headers(), to show that this is not the cause
124 2007-06-20 Murray Cumming <murrayc@murrayc.com>
126 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
127 Actually set the body query instead of the subject query.
129 * src/modest-search.c: (search_mime_part_ogs),
130 (search_mime_part_strcmp): Remove extra space from the text/* regex,
131 which would probably cause it to fail if we got this far.
133 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
134 to simplify the code.
135 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
136 be causing search-in-body to fail.
138 2007-06-20 Murray Cumming <murrayc@murrayc.com>
140 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
142 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
143 Better debug message when the folder cannot be found.
144 This should help with fixing projects.maemo.org bug #61287.
145 * src/modest-search.c: (add_hit): Do not leak the furl string.
147 2007-06-20 Murray Cumming <murrayc@murrayc.com>
149 * src/modest-ui-actions.c:
150 (modest_ui_actions_on_folder_selection_changed):
151 Do not special-case TNY_MERGE_FOLDER here, because
152 modest_tny_folder_get_account() already does that. This fixes
153 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
154 shown when the Outbox was selected).
156 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
158 * libmodest-dbus-client/libmodest-dbus-client.c:
159 (_dbus_iter_get_string_or_null): Initialize the string variable in
160 case this helps with Dirk's crash.
162 2007-06-19 Murray Cumming <murrayc@murrayc.com>
164 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
165 though it is not implemented yet (this function is maybe not even used),
166 to avoid breaking ABI in future.
167 * libmodest-dbus-client/libmodest-dbus-client.c:
168 (get_attachments_string): Moved some code into this generic function.
169 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
170 sends email. It is maybe not used.
171 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
172 (on_send_mail): Use attachments.
174 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
175 * src/maemo/modest-msg-edit-window.c:
176 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
177 a filename before using it, to fix projects.maemo.org bug NB#58233.
179 2007-06-19 Murray Cumming <murrayc@murrayc.com>
181 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
182 Initialize the continue_download variable to fix the build, and probably
183 to fix randome behaviour.
185 2007-06-18 Armin Burgmeier <armin@openismus.com>
187 * src/modest-tny-send-queue.h:
188 * src/modest-tny-send-queue.c: Keep track of the status of messages in
189 the queue so we can later show it in the UI. Replaced
190 modest_tny_send_queue_msg_is_being_sent() by
191 modest_tny_send_queue_get_msg_status().
193 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
195 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
196 gpointer. This probably was not harmful, but just to be sure.
198 2007-06-18 Murray Cumming <murrayc@murrayc.com>
200 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
201 Fix the build, but leave the function broken on Bora, because
202 hildon_uri_action_get_service() does not exist.
203 osso_uri_action_get_service() does not exist either, it seems.
205 2007-06-18 Murray Cumming <murrayc@murrayc.com>
207 * src/modest-tny-account.c:
208 (modest_tny_account_new_from_server_account):
209 Uncommented the url debug output again, because it is useful for
210 debugging, as I said in the comment.
212 2007-06-18 Murray Cumming <murrayc@murrayc.com>
214 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
216 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
217 for Mameo Bora, to fix the build.
219 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
222 Fixed build with hildon < 0.99
224 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
225 Check if the selected account is busy instead of checking all accounts
227 * src/modest-account-mgr-priv.h:
228 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
229 (modest_account_mgr_init), (compare_account_name),
230 (modest_account_mgr_set_account_busy),
231 (modest_account_mgr_account_is_busy):
232 * src/modest-account-mgr.h:
233 Added busy information to the account manager. It possible to
234 set an account to busy or not busy now.
236 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
237 (modest_mail_operation_update_account),
238 (modest_mail_operation_notify_end):
239 Set the account to busy/not busy depending on the operation state.
241 * src/widgets/modest-account-view.c:
242 (modest_account_view_finalize), (get_last_updated_string),
243 (update_account_view), (on_account_busy_changed), (init_view):
244 Show string "Refreshing..." if the account is currently busy.
246 All this fixes projects.maemo.org bug NB#59711
248 2007-06-14 Armin Burgmeier <armin@openismus.com>
250 * src/widgets/modest-attachments-view.h:
251 * src/widgets/modest-attachments-view.c: Added
252 modest_attachments_view_has_attachments() and fixed coordinate
253 transformation in get_att_view_at_coords(). This fixes attachment
256 * src/widgets/modest-msg-view.c: Make use of
257 modest_attachments_view_has_attachments() to decide whether to show
258 attachments in the header.
260 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
262 * src/maemo/modest-connection-specific-smtp-edit-window.c:
263 (on_change), (on_combo_security_changed),
264 (modest_connection_specific_smtp_edit_window_init),
265 (modest_connection_specific_smtp_edit_window_set_connection),
266 (modest_connection_specific_smtp_edit_window_is_dirty):
267 * src/maemo/modest-connection-specific-smtp-edit-window.h:
268 * src/maemo/modest-connection-specific-smtp-window.c:
271 Show an comfirmation dialog for the smpt-edit-window if there are
272 unsaved changes and the user hits cancel.
273 (projects.maemo.org bug NB#60479)
275 2007-06-14 Armin Burgmeier <armin@openismus.com>
277 * src/maemo/easysetup/modest-easysetup-wizard.c:
278 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
279 address" info in banner instead of node, and select all the text as
280 per UI spec. This fixes projects.maemo.org bug NB#60550.
282 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
284 reviewed by: <delete if not using a buddy>
286 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
287 * src/modest-ui-actions.c: (folder_refreshed_cb):
289 2007-06-14 Murray Cumming <murrayc@murrayc.com>
291 * src/widgets/modest-folder-view.c: (filter_row):
292 Explictly filter out the per-account outbox accounts. I don't know why
293 these only sometimes show up, but now they should never show up in the UI.
294 This should fix projects.maemo.org bug NB#60160.
296 2007-06-14 Murray Cumming <murrayc@murrayc.com>
298 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
299 when the toolbar does not exist yet.
300 * src/modest-widget-memory.c: (save_settings_header_view):
301 Added g_warnings() to help us to discover when we are trying to set
302 an empty columns list in gconf.
304 2007-06-14 Murray Cumming <murrayc@murrayc.com>
308 Added modest_init_get_default_header_view_column_ids().
310 * src/modest-widget-memory.c: (restore_settings_header_view):
311 Use the new function to get defaults, if the gconf key is empty,
312 instead of not creating any columns. This seems to fix the
313 empty right-hand pane problems.
315 * src/widgets/modest-header-view.h: Improved documentation.
317 2007-06-13 Murray Cumming <murrayc@murrayc.com>
319 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
320 Revert the use of the display name as the account name, because this
321 is generally wrong and would break the code that follows.
323 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
325 * src/maemo/easysetup/modest-easysetup-wizard.c:
326 (check_for_supported_auth_methods), (on_before_next),
329 More correct fix for projects.maemo.org bug NB# 58991
330 Do not longer accept AUTH_PASSWORD as secure method and choose
331 correct method when creating the account.
333 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
335 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
336 Fixed projects.maemo.org bug NB# 58991
338 2007-06-13 Murray Cumming <murrayc@murrayc.com>
340 * src/modest-init.c: (modest_init_init_core),
341 (modest_init_local_folders): Fixed compilation errors.
343 2007-06-13 Murray Cumming <murrayc@murrayc.com>
345 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
346 Remove unnecessary lib/include, though it is good in principle when needed.
348 * src/modest-init.c: (modest_init_one_local_folder),
349 (modest_init_local_folders):
350 * src/modest-init.h: Initialize the .modest library for memory cards,
351 instead of just doing nothing for them. This should allow us to create
352 folders there, fixing projects.maemo.org bug NB#59297.
354 2007-06-13 Murray Cumming <murrayc@murrayc.com>
356 * libmodest-dbus-client/libmodest-dbus-client.c:
357 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
358 (libmodest_dbus_client_compose_mail),
359 (libmodest_dbus_client_open_message),
360 (libmodest_dbus_client_send_and_receive),
361 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
363 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
364 (on_idle_open_message), (modest_dbus_req_handler),
365 (search_result_to_message), (modest_dbus_req_filter):
366 * src/modest-search.c: (add_hit), (modest_search_folder),
367 (modest_search_all_accounts): Improved debug messages.
369 * tests/dbus_api/test_open_message.c: (main): Improved comments.
371 * src/modest-tny-account-store.c:
372 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
375 2007-06-13 Murray Cumming <murrayc@murrayc.com>
378 2007-06-12 Murray Cumming <murrayc@murrayc.com>
380 * src/modest-tny-account-store.c: (get_server_accounts):
381 Call modest_tny_local_folders_account_add_merged_outbox_folders()
382 even when there are no accounts, so that the Outbox folder is always
383 visible. This fixes projects.maemo.org bug NB#60158.
385 2007-06-12 Murray Cumming <murrayc@murrayc.com>
387 * src/maemo/modest-main-window.c: (create_details_widget):
388 Use the mcen_va_never logical ID.
390 2007-06-12 Murray Cumming <murrayc@murrayc.com>
392 * src/dbus_api/modest-dbus-api.h:
393 * src/dbus_api/modest-dbus-callbacks.c:
394 (on_idle_open_default_inbox), (on_open_default_inbox),
395 (modest_dbus_req_handler):
396 Added a new OpenDefaultInbox method.
398 * libmodest-dbus-client/libmodest-dbus-client.h:
399 * libmodest-dbus-client/libmodest-dbus-client.c:
400 Added libmodest_dbus_client_open_default_inbox() to call the new
401 dbus method. This should be useful to projects.maemo.org bug NB#57214,
402 though it should maybe be used by a new osso-email-interface function.
404 * tests/dbus_api/Makefile.am:
405 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
408 2007-06-12 Murray Cumming <murrayc@murrayc.com>
410 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
411 NULL, so that the signals get all the keys. This should not actually
412 change any behaviour because we currently update everything when anything
415 2007-06-12 Murray Cumming <murrayc@murrayc.com>
417 * src/widgets/modest-folder-view.c: (text_cell_data),
418 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
419 (find_inbox_iter): If tinymail tells us that the folder is
420 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
421 This causes the inbox to be selected at startup, fixing part of
422 projects.maemo.org bug NB#56305.
424 * src/modest-ui-dimming-rules.c:
425 (modest_ui_dimming_rules_on_tools_smtp_servers):
426 * src/modest-ui-dimming-rules.h: Added a callback function to dim
427 the SMTP servers menu item.
428 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
429 that the SMTP Servers menu item is dimmed when there are no accounts,
430 as a future version of the UI spec will require. This fixes
431 projects.maemo.org bug NB#56305.
433 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
435 * src/maemo/modest-maemo-utils.c:
436 (modest_maemo_utils_get_supported_secure_authentication_methods):
437 Added label to dialog instead of unreadable title
439 * src/maemo/modest-main-window.c: (sync_accounts_cb),
440 (modest_main_window_new):
441 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
444 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
445 * src/modest-account-mgr.h:
446 Added method to avoid code duplication
448 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
449 (modest_ui_actions_on_send_receive):
450 Use modest_account_mgr_has_accounts
452 2007-06-11 Murray Cumming <murrayc@murrayc.com>
454 * src/maemo/easysetup/modest-presets.c:
455 (modest_presets_get_info_server_security): Do not report secure auth
457 * src/modest-protocol-info.c: Use the defines for the gconf key names
458 for secure authentication. This was not working because we were writing
459 Password and reading password, and the check was case sensitive.
460 With this, gmail now works for receiving and sending when created via
463 2007-06-11 Murray Cumming <murrayc@murrayc.com>
465 * src/maemo/easysetup/modest-presets.c:
466 (modest_presets_get_info_server_security): Correct the key name for
467 SecureSmtp, because it seems to be case-sensitive.
468 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
469 Do not try to get the 0th notebook page if there are 0 pages, to
472 2007-06-11 Murray Cumming <murrayc@murrayc.com>
474 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
475 Prevent use of the new notification feature for now, because it currently
476 shows one dialog for each new email, which is annoying.
478 2007-06-11 Murray Cumming <murrayc@murrayc.com>
480 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
481 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
482 when no country was selected, so that we show the global ones.
483 * src/maemo/easysetup/modest-presets.c:
484 (modest_presets_get_providers): Return only the global providers, not
485 all providers when mmc=0 was requested.
487 2007-06-11 Murray Cumming <murrayc@murrayc.com>
489 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
490 (easysetup_provider_combo_box_fill): Remove debug code that showed the
491 provider ID in the combo.
493 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
494 Do not show the page numbers, because it would be confusing when we add
495 the 2 extra pages for the custom setup, when the user chooses the "Other"
496 provider. This fixes projects.maemo.org bug NB#59028
498 * src/modest-init.c: (modest_init_init_core),
499 (modest_init_local_folders):
501 * src/modest-tny-account.c:
502 (modest_tny_account_new_for_local_folders): Do not create default folders
503 for the memory card. This should fix projects.maemo.org bug NB#59328.
505 2007-06-11 Murray Cumming <murrayc@murrayc.com>
507 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
508 Free the changed_conf_keys string items. They are already freed in the
509 idle handler if that runs first.
511 2007-06-11 Murray Cumming <murrayc@murrayc.com>
513 * src/modest-ui-actions.c:
514 (modest_ui_actions_on_password_requested): Check that the server name
515 is not NULL, because I just saw a password dialog with (null) as the
518 * src/modest-tny-folder.[h|c]: Added
519 modest_tny_folder_is_memory_card_folder().
520 * src/modest-ui-dimming-rules.c:
521 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
522 menu item for memory cards, as per the UI spec (section 7.4). This should
523 fix projects.maemo.org bug NB#59297.
525 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
527 * src/maemo/modest-main-window.c: (sync_accounts_cb):
528 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
529 is another problem with the code, see Murray's comment at line 772)
531 2007-06-08 Murray Cumming <murrayc@murrayc.com>
533 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
534 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
535 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
536 (load_from_file), (easysetup_country_combo_box_init),
537 (easysetup_country_combo_box_get_active_country_ids),
538 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
539 instead of just one ID, to avoid duplicate country names in the UI.
541 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
542 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
543 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
544 a single ID, avoiding duplicate providers.
545 * src/maemo/easysetup/modest-easysetup-wizard.c:
546 (on_combo_account_country): Adapt to use a list.
548 2007-06-08 Murray Cumming <murrayc@murrayc.com>
550 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
551 keys changed in the last X seconds.
553 * src/modest-account-mgr.h:
554 * src/modest-account-mgr.c: (on_timeout_notify_changes),
555 (on_key_change), (modest_account_mgr_class_init),
556 (modest_account_mgr_init), (modest_account_mgr_finalize):
557 As the keys are changed, save them in a GSList* and signal that GSList*
558 further every X seconds, to batch changes, to allow us to do just one
559 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
560 bug NB#56941 and other (UI-blocking) delays when changing account settings.
562 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
563 changed signal signature.
565 * src/modest-conf.c: (modest_conf_set_list),
566 (modest_conf_on_change): Reenable notification.
568 (modest_conf_maemo_fake_on_change): Comment out the hack that
569 notified immediately instead of asynchronously.
571 * src/widgets/modest-account-view.h:
572 * src/widgets/modest-account-view.c:
573 (update_account_view): Select the previously-selected account ID,
574 if possible. This fixes projects.maemo.org bug NB#56933.
576 (on_account_changed), (on_account_removed),
577 (modest_account_view_select_account):
579 Remove the block/unblock functions
580 because they were not useful.
582 * src/maemo/modest-account-view-window.c:
583 (on_delete_button_clicked), (on_edit_button_clicked),
584 (on_new_button_clicked): Remove the use of the non-working block/unblock.
586 2007-06-08 Murray Cumming <murrayc@murrayc.com>
588 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
589 Improve the error dialog to show Incorrect Account Settings, which seems
590 clearer, and say that the internal error message (to be removed from the
591 dialog later) is often misleading.
592 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
594 * src/modest-tny-account.c:
595 (modest_tny_account_new_from_server_account): Uncomment the printf of the
596 URL because this is so useful for debugging on the device.
598 * src/widgets/modest-serversecurity-combo-box.c:
599 (modest_serversecurity_combo_box_fill): Correct a logical ID.
601 2007-06-08 Murray Cumming <murrayc@murrayc.com>
603 * src/modest-mail-operation.c:
604 (modest_mail_operation_send_new_mail):
605 Added a comment about a nasty but apparently harmless message. Details
606 added to the wiki g_warnings() page.
608 2007-06-08 Murray Cumming <murrayc@murrayc.com>
610 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
611 (modest_tny_send_queue_class_init):
612 Do not use the priv struct because it is empty, to avoid g_warnings
613 about a non-existant priv struct.
615 * src/modest-tny-account-store.c:
616 (modest_tny_account_store_get_server_account),
617 (modest_tny_account_store_get_transport_account_for_open_connection
618 ): Do not try to get transport server accounts for local folders,
619 because they don't have any. This avoids a g_warning().
621 * src/maemo/modest-main-window.c:
622 (modest_main_window_notify_send_receive_initied),
623 (on_configuration_key_changed):
624 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
626 * src/modest-mail-operation.c:
627 (modest_mail_operation_update_account):
628 * src/modest-tny-account-store.h:
629 * src/modest-tny-account.c:
630 (modest_tny_account_get_special_folder),
631 (modest_tny_account_new_for_local_folders),
632 (modest_tny_account_new_for_per_account_local_outbox_folder):
633 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
634 * src/modest-tny-local-folders-account.c:
635 (add_account_folders_to_merged_folder):
636 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
637 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
638 (modest_ui_actions_on_send):
639 * src/widgets/modest-folder-view.c: (update_model):
640 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
641 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
642 modest_tny_account_store_get_tny_account_by_account() to
643 modest_tny_account_store_get_server_account() to make the code clearer.
645 2007-06-07 Marcus Bauer <marcusb@openismus.com>
647 * src/dbus_api/modest-dbus-api.h:
648 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
649 * src/maemo/modest-msg-edit-window.c:
650 (modest_msg_edit_window_attach_file_noninteractive):
651 added g_warning in case the file to be attached does not exist
652 * tests/dbus_api/test_compose_mail.c: (main):
653 removed obsolete comment, added generic files as test case
655 2007-06-07 Murray Cumming <murrayc@murrayc.com>
657 * src/modest-tny-account-store.c: (get_server_accounts):
658 Create the local folders account only once, not once for each outbox, and
659 not only when there are some outboxes.
661 2007-06-07 Murray Cumming <murrayc@murrayc.com>
663 * src/widgets/modest-folder-view.c: (update_model): Comment out some
664 code that is causing a crash at startup. Sergio says that he is fixing this.
666 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
668 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
669 * src/maemo/modest-account-settings-dialog.c:
670 (create_page_outgoing),
671 (modest_account_settings_dialog_set_account_name),
672 (save_configuration):
673 - Fixed handling of the "Use secure authentication" toggle to comply with
674 the ui specification. See also projects.maemo.org bug NB#58400
676 - Restore the Secure connection setting combo correctly when loading
679 * src/maemo/modest-maemo-utils.c:
680 (on_camel_account_get_supported_secure_authentication),
681 (modest_maemo_utils_get_supported_secure_authentication_methods):
682 Fixed a crasher if operation is canceled
684 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
685 (modest_protocol_info_auth_is_secure):
686 * src/modest-protocol-info.h:
688 Added two new methods to determine if a protocol/auth method is secure/encrypted in
689 the sense of the "Use secure authentication" toggle.
691 2007-06-07 Murray Cumming <murrayc@murrayc.com>
693 * src/modest-tny-account-store.h:
694 * src/modest-tny-account-store.c:
695 Added modest_tny_account_store_get_local_folders_account().
697 * src/modest-tny-folder.h:
698 * src/modest-tny-folder.c:
699 (modest_tny_folder_get_account):
700 Added this replacement for tny_folder_get_account() which returns
701 the local-folders account for TnyMergeFolders, to avoid the
702 warning about the unimplemented get_account_func() vfunc().
704 (modest_tny_folder_get_rules),
705 * src/modest-ui-actions.c:
706 (modest_ui_actions_on_folder_selection_changed):
707 * src/modest-mail-operation.c:
708 (modest_mail_operation_remove_folder),
709 (modest_mail_operation_xfer_folder),
710 (modest_mail_operation_rename_folder),
711 (modest_mail_operation_get_msg),
712 (modest_mail_operation_get_msgs_full),
713 (modest_mail_operation_remove_msg),
714 (modest_mail_operation_xfer_msgs),
715 (modest_mail_operation_refresh_folder):
716 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
718 2007-06-07 Murray Cumming <murrayc@murrayc.com>
720 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
721 (modest_server_account_set_security):
722 * src/modest-defs.h: Add comments explaining that our
723 UI spec means TLS when it says Normal, so these do not look like errors.
725 * src/modest-tny-account.c:
726 (modest_tny_account_new_from_server_account): Use the new tinymail
727 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
728 for TLS. This should fix projects.maemo.org bug NB#58460.
730 2007-06-06 Murray Cumming <murrayc@murrayc.com>
732 * src/maemo/easysetup/modest-easysetup-wizard.c:
733 (create_account): Correct the position of the gconf sanity check warning.
734 (on_button_edit_advanced_settings): Show the dialog immediately, instead
735 of using the g_idle_add() hack, because this does not seem to be necessary
736 on osso 1.1. It might even work on Maemo Bora if the problems were actually
737 caused by something other than maemo's gconf.
738 This fixes projects.maemo.org bug #59022.
740 2007-06-06 Murray Cumming <murrayc@murrayc.com>
742 * src/modest-account-mgr-helpers.c:
743 (modest_account_mgr_get_default_account): Do not check that the account
744 exists if there is no default account (NULL), to fix a runtime warning.
746 2007-06-06 Murray Cumming <murrayc@murrayc.com>
748 * src/widgets/modest-folder-view.c: (update_model):
749 Do not unref the treemodel before we have finished with it.
750 This prevents a valgrind warning and an occasional crash at startup.
752 2007-06-06 Marcus Bauer <marcusb@openismus.com>
754 * libmodest-dbus-client/libmodest-dbus-client.h:
755 added libmodest_dbus_client_compose_mail()
756 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
758 added functions needed for SendAsMail() functionality
759 * src/maemo/modest-msg-edit-window.c:
760 (modest_msg_edit_window_attach_file_noninteractive):
761 non interactively attaching files to message edit window
762 * src/widgets/modest-msg-edit-window.h:
763 * tests/dbus_api/Makefile.am:
764 added test_compose_mail.c
765 * tests/dbus_api/test_compose_mail.c: (main):
767 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
769 * src/modest-account-view.c:
770 Fixed bug projects.maemo.org bug NB#59307
772 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
774 * src/maemo/easysetup/modest-easysetup-wizard.c:
775 (get_serverport_incoming), (on_before_next), (create_account):
776 * src/maemo/modest-account-settings-dialog.c:
777 (modest_account_settings_dialog_set_account_name):
778 * src/maemo/modest-maemo-utils.c:
779 (on_camel_account_get_supported_secure_authentication_status),
780 (on_camel_account_get_supported_secure_authentication),
781 (on_secure_auth_cancel),
782 (modest_maemo_utils_get_supported_secure_authentication_methods):
784 Implemented security authentication for settings and easysetup.
786 2007-06-05 Murray Cumming <murrayc@murrayc.com>
788 * src/maemo/modest-main-window.c: (create_details_widget):
789 Show the total size for memory card accounts too, instead of showing
790 the name again. Fixes bug projects.maemo.org bug NB#59307.
792 2007-06-05 Murray Cumming <murrayc@murrayc.com>
795 * src/modest-tny-simple-folder-store.c:
796 * src/modest-tny-simple-folder-store.h: Removed.
798 * src/modest-tny-local-folders-account.h
799 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
800 for the local-folders maildir, with an extra TnyMergedFolder containing
801 the folders of the per-account outbox store accounts.
802 * src/modest-tny-account-store.c: (get_server_accounts):
803 Add the outboxes to the special local folders account after creating it.
805 * src/modest-tny-account.c:
806 (modest_tny_account_new_for_local_folders): Create the derived
807 account when creating the main local-folders account.
809 * src/maemo/modest-main-window.c: (create_details_widget),
810 (modest_main_window_set_contents_style):
811 Adapted to the use of the derived account instead of the folder store.
813 * src/modest-ui-actions.c:
814 (modest_ui_actions_on_folder_selection_changed):
815 * src/modest-ui-dimming-rules.c:
816 (modest_ui_dimming_rules_on_new_folder):
817 * src/widgets/modest-folder-view.c: (text_cell_data),
818 (icon_cell_data), (filter_row), (update_model),
819 (get_cmp_rows_type_pos):
822 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
823 Do not get the priv struct, because no priv struct has been set,
824 to avoid a runtime warning.
826 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
827 #ifelse with #else, to fix a warning, to fix the build.
830 2007-06-05 Christian Kellner <ckellner@openismus.com>
832 * libmodest-dbus-client/libmodest-dbus-client.c:
833 Fix small typo in doc (why do you always see them
834 AFTER committing stuff?)
837 2007-06-05 Christian Kellner <ckellner@openismus.com>
839 * libmodest-dbus-client/libmodest-dbus-client.c:
840 (libmodest_dbus_client_search):
841 Initialize hit list with NULL. Also set folder list
842 to "" if NULL was supplied.
845 2007-06-03 Christian Kellner <ckellner@openismus.com>
847 * libmodest-dbus-client/libmodest-dbus-client.c:
848 (modest_search_hit_list_free):
849 Make it save to call it with NULL.
851 * src/dbus_api/modest-dbus-callbacks.c:
852 * src/modest-search.c:
853 Return full ModestSearchHits as the search result list not TnyHeader
854 since can't be around withouth the correspoding TnyFolder.
856 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
858 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
859 Added currently commented code to check for secure auth
861 * src/maemo/modest-account-settings-dialog.c: (on_response),
862 (save_configuration), (show_ok):
863 Fixed projects.maemo.org bugs NB #59248 and #59251
865 * src/maemo/modest-maemo-utils.c:
866 (on_camel_account_get_supported_secure_authentication_status),
867 (on_camel_account_get_supported_secure_authentication),
868 (modest_maemo_utils_get_supported_secure_authentication_methods):
869 * src/maemo/modest-maemo-utils.h:
870 Moved get_supported_secure_authentication() method here to be able
871 to use it from easysetup wizard.
873 * src/modest-pair.c: (on_pair_compare_as_string):
874 Should compare string with first part of pair and not
875 strcmp pairs which will crash.
877 * src/modest-protocol-info.c:
878 (modest_protocol_info_protocol_is_store):
879 * src/modest-protocol-info.h:
880 Added modest_protocol_info_get_auth_protocol_name()
882 2007-06-03 Armin Burgmeier <armin@openismus.com>
884 * src/modest-mail-operation.c:
885 (modest_mail_operation_get_msgs_full): Set priv->account also when
886 only retrieving a single message. This avoids a crash when canceling
889 (modest_mail_operation_notify_end): Do not explicitely remove the
890 operation from the queue but only emit the progress_changed signal.
891 The queue itself listens to that signal to remove the operation when
892 it is finished. This reduces coupling and removes a potential deadlock
893 when modest_mail_operation_notify_end() is called from the queue
894 itself. If that is a problem performance-wise, I would suggest to
895 implement a status-changed signal or something.
897 * src/modest-mail-operation-queue.c: Make sure to never call a
898 function from another file while the queue is locked. This (hopefully)
899 fixes another deadlock when exiting the application while retrieving
902 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
904 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
905 Fixed build if libogs is not available
907 2007-06-03 Christian Kellner <ckellner@openismus.com>
909 * libmodest-dbus-client/libmodest-dbus-client.h:
910 * libmodest-dbus-client/libmodest-dbus-client.c:
911 (libmodest_dbus_client_delete_message):
912 Implement deletion of messages (Client side).
914 (modest_search_hit_free),
915 (modest_search_hit_list_free):
916 Utility functions to free the result hits.
918 * src/dbus_api/modest-dbus-api.h:
919 * src/dbus_api/modest-dbus-callbacks.c:
921 (modest_dbus_req_handler):
922 Implement deletion of messages (Server side).
924 * tests/dbus_api/test_search.c: (main):
927 * tests/dbus_api/Makefile.am:
928 * tests/dbus_api/test_delete_message:
929 Add little test for the message deletion logic
931 2007-06-03 Armin Burgmeier <armin@openismus.com>
933 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
934 when the operation queue was not empty. projects.maemo.org bug
937 2007-06-03 Armin Burgmeier <armin@openismus.com>
939 * src/widgets/modest-account-view.c
940 (on_account_default_toggled): Toggle default account column
941 explicitely instead of waiting for gconf notification (which is
942 currently ignored). This should fix projects.maemo.org bug NB#56910
943 for now. It should probably be removed when gconf notifications are
946 2007-06-03 Christian Kellner <ckellner@openismus.com>
948 * libmodest-dbus-client/libmodest-dbus-client.c:
949 Removed debugging spew.
951 * src/dbus_api/modest-dbus-callbacks.c:
952 Added debugging info.
954 * src/modest-search.c:
955 (modest_search_all_accounts):
956 Use tny_account_store_get_accounts () on the account store
957 to get all accounts which is the way to get all accounts.
959 * tests/dbus_api/test_search.c: (main):
960 Make it possible to supply the search term on the command line.
962 2007-06-03 Christian Kellner <ckellner@openismus.com>
964 * libmodest-dbus-client/libmodest-dbus-client.c:
965 * libmodest-dbus-client/libmodest-dbus-client.h:
966 Implement searching for mesages over raw dbus. (Client side)
968 * src/dbus_api/Makefile.am:
969 * src/dbus_api/modest-dbus-api.h:
970 * src/dbus_api/modest-dbus-callbacks.c:
971 * src/dbus_api/modest-dbus-callbacks.h:
972 Search framework (Server side). Also implement on_idle_open_message().
974 * src/maemo/modest-platform.c: (modest_platform_init):
975 Prepare for raw dbus/osso rpc interaction.
977 * src/modest-search.h:
978 Changed minsize from unspecific guint to guint32.
980 * src/modest-search.c:
982 Added strange hack which magically made tnymail work.
984 (modest_search_folder),
985 (modest_search_account),
986 (modest_search_all_accounts):
987 Implement helper functions to search all accounts, specific account
990 * tests/dbus_api/Makefile.am:
991 * tests/dbus_api/test_open_message.c:
992 Read url to open from commandline.
994 * tests/dbus_api/test_search.c:
995 Implement small test for dbus search stuff
997 2007-06-02 Armin Burgmeier <armin@openismus.com>
999 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1000 include account type and account title. This fixes projects.maemo.org
1003 * src/maemo/modest-account-view-window.c: Set a title for the window.
1005 2007-06-02 Armin Burgmeier <armin@openismus.com>
1007 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1008 incoming and outgoing server name based on email address and server
1009 types as long as the names have not been edited manually. This fixes
1010 projects.maemo.org bug NB#58671.
1012 2007-06-02 Armin Burgmeier <armin@openismus.com>
1014 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1015 server type cannot be changed in future to the incoming details page
1016 when creating an account. This fixes projects.maemo.org bug NB#59029.
1018 2007-06-02 Armin Burgmeier <armin@openismus.com>
1020 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1021 and assigned max width chars so that they wrap instead of being
1022 truncated. Fixes projects.maemo.org bug NB#56126.
1024 2007-06-02 Armin Burgmeier <armin@openismus.com>
1026 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1027 introductory note to the connection specific smtp servers dialog, as
1028 section 8.12 of the email UI specification requires. This fixes
1029 projects.maemo.org bug NB#59212.
1031 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1033 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1034 Check for running mail operations, and offer to cancel them, as per the UI
1035 spec. This fixes projects.maemo.org bug NB#59041 .
1036 However, I suspect that tinymail may still use the network connection
1037 in ways that we cannot detect or cancel. But it should at least adapt to
1038 changes fairly well.
1040 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1042 * src/modest-tny-account-store.c: (recreate_all_accounts),
1043 (get_cached_accounts), (get_server_accounts): Do more sensible
1044 ref-counting of the temporarily-cached outbox accounts list. This seems
1045 to fix a crash when entering the password when the password was wrong.
1047 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1049 * src/gnome/modest-main-window.c: (connect_signals):
1050 * src/modest-tny-account-store.c: (get_password),
1051 (modest_tny_account_store_alert): Added comments and clues and
1052 commented-out code about how we currently fail to deal with connection
1053 errors and wrong passwords, and how we should.
1055 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1057 * src/widgets/modest-retrieve-combo-box.c:
1058 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1059 This fixes projects.maemo.org bug NB#58472 .
1061 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1063 * src/maemo/easysetup/modest-easysetup-wizard.c:
1064 (create_page_complete_easysetup):
1065 (create_page_complete_custom): Correct the last commit,
1066 putting the correct sentences in the correct pages.
1068 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1070 * src/maemo/easysetup/modest-easysetup-wizard.c:
1071 (create_page_complete_custom): Show the second sentence of text
1072 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1075 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1077 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1078 Set the leave-on-server conf key by default. This fixes
1079 projects.maemo.org bug NB#59258 .
1081 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1083 * src/maemo/modest-account-view-window.c:
1084 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1085 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1088 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1090 * src/maemo/easysetup/modest-easysetup-wizard.c:
1091 (create_caption_new_with_asterisk):
1092 * src/maemo/modest-account-settings-dialog.c:
1093 (create_caption_new_with_asterisk):
1094 Uncomment the code to add the asterisk, because they are no longer in the
1095 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1096 (update_incoming_server_title): Add an asterisk here too.
1098 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1100 * src/maemo/modest-maemo-global-settings-dialog.c:
1101 (current_connection): Check that we are even connected before trying to
1102 get the current connection name, to prevent a warning.
1104 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1105 Change the comments because tny_maemo_conic_device_connect() is now meant to
1107 * src/modest-mail-operation.c:
1108 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1109 make sure we have a connection and fail if we can't connect.
1111 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1113 * src/maemo/modest-main-window.c:
1114 (on_account_store_connecting_finished): Do not try to get the
1115 connection ID if we are not really connected. I am surprised that
1116 this signal handler is called when we are not connected.
1118 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1120 * src/modest-error.h:
1121 * src/modest-ui-actions.c:
1122 (modest_ui_actions_get_msgs_full_error_handler):
1123 Renamed an enum, added comments, added an enum
1124 for retrieve-limit errors.
1126 * src/modest-mail-operation.c: (foreach_add_item),
1127 (internal_folder_observer_update), (update_account_thread),
1128 (modest_mail_operation_get_msgs_full):
1129 (modest_mail_operation_update_account),
1130 Added comments about how this works, and some code that should
1131 (but does not) check the retrieve-limit. See the TODO comment.
1133 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1135 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1136 Initialize help_id to fix the build. Warnings are good.
1138 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1140 * src/widgets/modest-hbox-cell-renderer.c:
1141 (modest_hbox_cell_renderer_append):
1142 * src/widgets/modest-vbox-cell-renderer.c:
1143 (modest_vbox_cell_renderer_append):
1144 Fix the last commit by doing an extra ref.
1146 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1148 * src/widgets/modest-hbox-cell-renderer.c:
1149 (modest_hbox_cell_renderer_append):
1150 * src/widgets/modest-vbox-cell-renderer.c:
1151 (modest_vbox_cell_renderer_append):
1152 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1153 to fix the build with Maemo Bora.
1154 However, there seems to be a remaining crash, probably due to reference
1157 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1159 * src/modest-tny-account.c:
1160 (modest_tny_account_new_for_local_folders):
1161 Use hildon_file_system_info_async_new() to get a better name for
1162 the memory card account, setting it as the account name.
1163 The timing seems to work, but this is probably
1164 not the best place to do this. See the TODO comment.
1165 * src/maemo/modest-main-window.c: (create_details_widget):
1166 * src/widgets/modest-folder-view.c: (text_cell_data):
1167 Use the tny account name instead of hardcoding a name.
1169 2007-05-30 Christian Kellner <ckellner@openismus.com>
1171 * src/modest-search.c: (modest_search):
1172 Correctly set part_search_func even if we have already parsed
1173 the query and thus a valid OgsTextSearcher object.
1175 2007-05-30 Christian Kellner <ckellner@openismus.com>
1178 Search and check for libogs.
1181 Incooparte the ogs build env.
1183 * src/modest-mime-part-search-stream.c:
1184 * src/modest-mime-part-search-stream.h:
1185 Removed since we do the real searching now in modest-search.c.
1187 * src/modest-search.c:
1188 * src/modest-search.h:
1189 Implement support for ogs. We use that if available and requested
1190 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1191 should now handle the corner case when the search term is spread
1192 across multiple reads.
1193 Also the logic in modest_search () was corrected to search all
1194 requested fields until one is found.
1196 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1198 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1200 * src/modest-init.h:
1201 * src/modest-init.c: Made modest_init_local_folders() take a
1202 path and be public so we can iniitialize maildir folders on
1205 * src/modest-local-folder-info.h:
1206 * src/modest-local-folder-info.c:
1207 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1209 * src/modest-tny-account.c:
1210 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1211 still means the standard local-folders path on the local volume.
1213 * src/modest-tny-account-store.c:
1214 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1215 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1216 all accounts when that happens.
1217 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1218 this too, so it shows up in the treeview.
1220 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1222 * src/maemo/modest-maemo-global-settings-dialog.c:
1223 (current_connection):
1224 * src/widgets/modest-global-settings-dialog.c:
1225 (current_connection_default):
1226 Use the enum values instead of 0, 1 and -1,
1227 to make the code clearer.
1229 * src/modest-account-mgr-helpers.c:
1230 (modest_account_mgr_get_connection_specific_smtp): Make this code
1233 * src/modest-runtime.h:
1234 * src/modest-runtime.c:
1235 Added modest_runtime_remove_all_send_queues().
1236 * src/maemo/modest-main-window.c:
1237 (on_account_store_connecting_finished): Recreate the send queues,
1238 using the appropriate transport accounts for this new connection.
1239 Some futher adapting might be needed if the old send queues are not
1240 automatically stopped at this point.
1242 * src/modest-tny-account-store.c: (get_server_accounts):
1243 Create the connection-specific transport accounts, so that they can
1244 be found later by their ID.
1246 * src/modest-tny-account.h:
1247 * src/modest-tny-account.c:
1248 Added modest_tny_account_new_from_server_account_name().
1249 modest_tny_account_new_from_server_account(): Do not create the
1250 send queues here, because they will be
1251 recreated anyway when the connection changes for the first time.
1253 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1255 * src/modest-local-folder-info.h:
1256 * src/modest-local-folder-info.c:
1257 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1258 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1259 tbox_folder): Take a modest account name instead of a server TnyAccount,
1260 so we can have per-modest-account rather than per-transport-account
1262 We must make sure that we change or recreate the exisitng send queues
1263 when the connection changes for connection-specific transport accounts.
1265 * src/modest-tny-account-store.c:
1266 (create_per_account_local_outbox_folders): Create outboxed per modest
1267 account, not per transport account.
1269 * src/modest-tny-account.h:
1270 * src/modest-tny-account.c:
1271 (modest_tny_account_get_special_folder): For outboxes, get the
1272 parent modest account name. The account is ignored for other folders.
1273 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1274 modest account name rather than a server TnyAccount.
1276 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1278 * src/modest-tny-account.c:
1279 (modest_tny_account_new_from_server_account):
1280 Call modest_runtime_get_send_queue() immediately after creating transport
1281 accounts, so that they start trying to send email from the outbox as soon
1282 as possible at startup. This is probably what we want.
1284 * src/modest-mail-operation.c: (update_account_thread):
1285 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1286 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1287 * src/modest-tny-send-queue.h:
1288 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1289 (modest_ui_actions_on_send):
1290 Added comments about how sending works, though it needs some more work.
1292 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1294 * src/modest-tny-account.c:
1295 (modest_tny_account_get_special_folder): Add TODO because this fails when
1296 the network is busy.
1297 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1298 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1299 Do not try to show this window when there is no active account. The UI
1300 specs does not tell us what to do in this case.
1302 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1306 * src/maemo/Makefile.am:
1307 * src/widgets/Makefile.am: Some dist fixes.
1309 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1311 * src/maemo/modest-connection-specific-smtp-window.c:
1312 (on_button_edit): Make the code clearer, to prevent a double free.
1314 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1316 * src/maemo/modest-account-settings-dialog.c:
1317 (modest_account_settings_dialog_set_account_name),
1318 Check the connection-specific smtp servers checkbox if there are any.
1320 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1321 (modest_connection_specific_smtp_edit_window_init):
1322 Start with a suitable port number.
1324 * src/modest-account-mgr-helpers.h:
1325 * src/modest-account-mgr-helpers.c: Added
1326 modest_account_mgr_get_has_connection_specific_smtp().
1328 (modest_account_mgr_set_connection_specific_smtp),
1329 (modest_account_mgr_remove_connection_specific_smtp),
1330 (modest_account_mgr_get_has_connection_specific_smtp),
1331 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1332 connection-specific smtp server accounts in the account, rather than
1333 the server account conf dir.
1335 This fixes bug projects.maemo.org bug NB#58263 .
1337 * src/modest-tny-account-store.c:
1338 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1339 if there are no server accounts yet, to prevent an infinite loop when there
1340 are no accounts. Document that one must be called before the other.
1342 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1344 * src/modest-account-mgr-helpers.c:
1345 (modest_account_mgr_get_default_account): Make sure that at least
1346 one account is always the default, if there are any enabled accounts.
1347 This is just a sanity check that shouldn't be necessary.
1349 * src/modest-account-mgr-priv.c:
1350 (_modest_account_mgr_account_from_key): Unescape the conf key to
1351 get the real account name. For instance, this is an issue if a space
1352 was in the account name, which can happen because the account name
1353 is generated from the display name.
1354 (_modest_account_mgr_get_account_keyname): Always escape the
1356 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1357 Unescape the conf keys to get the real account names.
1359 For instance, previously the is-default radio button in the accounts
1360 list was not checked for any accounts at first. This fixes that,
1361 and might fix several similar bugs.
1363 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1365 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1366 Removed some debug printfs.
1368 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1370 Modest on-disk outbox directories are now here, for instance:
1371 $HOME/.modest/outboxes/<account-id-1>/outbox
1372 $HOME/.modest/outboxes/<account-id-2>/outbox
1374 $HOME/.modest/local-folders/outbox
1375 so we can have a separate outbox for each account.
1376 But they are shown as one outbox in the GtkTreeView, by using a
1377 TnyMergeFolder in a ModestTnySimpleFolderStore.
1380 * src/modest-tny-simple-folder-store.c:
1381 * src/modest-tny-simple-folder-store.h:
1382 Added ModestTnySimpleFolderStore, used to contain folders from
1383 other folder stores, such as other accounts.
1385 * src/modest-tny-outbox-account.h:
1386 * src/modest-tny-outbox-account.c:
1387 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1388 used for the per-account local outbox folders.
1390 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1391 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1392 only use this (internally) now for the non-outbox local folders.
1394 * src/modest-init.h:
1395 * src/modest-init.c: Added modest_init_one_local_folder(), for
1396 setting up the directory structure for each local folder.
1398 * src/modest-local-folder-info.c:
1399 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1400 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1402 * src/modest-local-folder-info.h:
1403 * src/modest-tny-account-store.c: (on_account_removed),
1404 (on_account_changed), (create_per_account_local_outbox_folders),
1405 (get_server_accounts), (modest_tny_account_store_get_accounts),
1406 (modest_tny_account_store_get_tny_account_by_account),
1407 (modest_tny_folder_store_is_virtual_local_folders):
1409 * src/modest-tny-account.h:
1410 * src/modest-tny-account.c:
1411 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1412 to create an on-disk per-account local outbox folder for each
1414 (create_per_account_local_outbox_folders): Create a local outbox folder
1415 for each transport account.
1416 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1417 for all local folders.
1419 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1420 instead of using g_object_get/set() directly. It is clearer.
1422 (modest_tny_folder_store_get_message_count),
1423 (modest_tny_folder_store_get_local_size
1424 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1425 because we now use these with non-acount folder stores.
1427 (modest_tny_account_get_special_folder),
1428 (modest_tny_account_new_from_server_account),
1429 (modest_tny_account_new_from_account):
1430 (recurse_folders): Adjust to the new outbox system.
1432 * src/modest-tny-folder.h:
1433 * src/modest-tny-folder.c:
1434 (modest_tny_folder_is_local_folder),
1435 (modest_tny_folder_get_local_folder_type),
1436 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1438 * src/widgets/modest-main-window.h:
1439 * src/maemo/modest-main-window.c: (create_details_widget),
1440 (modest_main_window_set_contents_style): Show details for any folder store,
1443 (modest_tny_folder_get_rules):
1444 Remove the const. C does not support constness enough for this.
1446 * src/modest-ui-actions.c:
1447 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1448 make all outboxes appear as one, in the usual local-folders tree node.
1450 (set_active_account_from_tny_account),
1451 (modest_ui_actions_on_folder_selection_changed):
1452 * src/widgets/modest-folder-view.c: (text_cell_data),
1453 (icon_cell_data), (filter_row),
1454 (add_account_folders_to_merged_folder),
1455 (add_account_folders_to_simple_folder_store), (),
1456 (get_cmp_rows_type_pos), (cmp_rows),
1457 (modest_folder_view_set_account_id_of_visible_server_account):
1458 Adjust to the new outbox system, using generic folder stores and folders
1459 in the GtkTreeModel.
1461 2007-05-23 Christian Kellner <ckellner@openismus.com>
1463 * src/modest-mail-operation.c:
1464 (modest_mail_operation_update_account):
1465 Use info->max_size instead of unintialized local var [small
1466 build fix]. (Added TODO to review that change since I don't
1469 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1471 * libmodest-dbus-client/libmodest-dbus-client.c:
1472 (libmodest_dbus_client_compose_mail): function added
1473 * src/dbus_api/modest-dbus-api.h:
1474 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1475 (on_compose_mail): Implementation of the SendAsMail functionality
1477 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1479 * src/modest-account-mgr.c:
1480 (modest_account_mgr_add_server_account): Set the secure-connection
1481 conf key for transport accounts as well as store accounts. I don't know
1482 why the if was there. For instance, this makes sure that we use SSL
1483 for the gmail preset from the easysetup wizard.
1485 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1487 * src/gnome/modest-main-window.c:
1488 (on_account_store_connecting_finished), (connect_signals):
1489 * src/maemo/modest-main-window.c:
1490 (on_account_store_connecting_finished), (connect_signals),
1491 (modest_main_window_new):
1492 Handle TnyAccountStore::connecting-finished instead of
1493 TnyDevice::connection-changed, because we cannot actually perform
1494 operations on accounts until TnyAccountStore has itself responded to
1495 the TnyDevice::connection-changed signal. This prevents a GError from
1497 Do not try to update at startup, because we (at least on scratchbox)
1498 already do an update at startup when the device goes online.
1499 This prevents a GError from tinymail.
1500 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1501 Added TODO about stopping simultaneous operations.
1503 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1505 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1506 * src/modest-mail-operation-queue.c:
1507 (modest_mail_operation_queue_remove):
1508 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1509 about where they happened.
1511 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1513 * src/modest-ui-actions.c:
1514 (modest_ui_actions_on_password_requested): Make sure that the remember
1515 output parameter is always TRUE.
1517 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1519 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1520 Show a OK/Cancel dialog if the error is a question, though we still do not
1521 know anything more about what we are asking the user.
1522 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1523 Fix an uninitialized variable (helper). This is a logic error, however.
1525 2007-05-21 Christian Kellner <ckellner@openismus.com>
1527 * src/modest-search.h:
1528 Correct bit shifting in the ModestSearchFlags enum.
1530 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1532 * src/modest-tny-account.c:
1533 (modest_tny_account_new_from_server_account): Do not use the lsub and
1534 check-all hard-coded IMAP options when using POP.
1536 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1538 * src/modest-tny-account.c:
1539 (modest_tny_account_new_from_server_account):
1540 Use NULL for the secure-auth method for POP when Password auth has been
1541 specified by the user, as we already do for IMAP. "auth=Login" causes
1542 an error from camel or the server.
1544 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1546 * src/maemo/modest-account-settings-dialog.c:
1547 (create_page_account_details),
1548 (modest_account_settings_dialog_set_account_name):
1549 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1550 for the leave-on-server checkbox, rathr than just the checkbox, when
1551 the protocol is not POP.
1553 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1555 * src/widgets/modest-account-view.c:
1556 * src/widgets/modest-account-view.h:
1557 Added modest_account_view_select_account() which will be useful later
1558 to asynchronously re-select the edited account.
1560 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1562 * src/maemo/modest-account-settings-dialog.c:
1563 (modest_account_settings_dialog_set_account_name):
1564 Automatically choose the port numbers based on the secure authentication
1565 methods, if they have not been chosen before.
1566 This fixes projects.maemo.org bug NB#56273 .
1568 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1570 * src/maemo/modest-main-window-ui.h:
1571 * src/modest-ui-actions.c:
1572 * src/modest-ui-actions.h:
1573 Connect the Tools/SMTP Servers menu item to
1574 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1575 SMTP servers dialog, as in the UI specification and saves changes when it
1576 is closed. This fixed projects.maemo.org bug NB#56305 .
1578 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1580 * src/maemo/modest-connection-specific-smtp-window.c:
1581 (modest_connection_specific_smtp_window_init):
1582 Use gtk_window_set_default_size() to make this window big enough, so
1583 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1585 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1587 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1588 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1589 (modest_connection_specific_smtp_edit_window_init),
1590 Do not try to connect to a combobox signal before the combobox exists.
1591 This fixes the cras in projects.maemo.org bug NB#56288 .
1592 (modest_connection_specific_smtp_edit_window_get_settings):
1593 Remove the server_account_name parameter which was being checked for NULL
1594 though it was not used.
1596 * src/maemo/modest-connection-specific-smtp-window.c:
1597 (modest_connection_specific_smtp_window_fill_with_connections),
1598 (on_button_edit), (modest_connection_specific_smtp_window_init):
1599 Correct the number of treemodel columns to prevent a warning.
1600 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1601 libconic does not work.
1603 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1605 * src/modest-tny-account.c:
1606 (modest_tny_account_new_from_server_account):
1607 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1608 SMTP when "None" was chosen by the user. However, with my SMTP server that
1609 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1612 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1614 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1615 to explain the memory management issue with the ID in the ModestPair.
1617 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1618 (add_sending_page), (modest_account_assistant_finalize):
1619 * src/gnome/modest-gnome-global-settings-dialog.c:
1620 (create_updating_page), (create_composing_page):
1621 * src/gnome/modest-msg-edit-window.c: (get_transports),
1622 (init_window), (modest_msg_edit_window_finalize),
1623 (modest_msg_edit_window_get_msg_data):
1624 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1625 * src/gnome/modest-transport-widget.c:
1626 (modest_transport_widget_finalize), (smtp_configuration):
1627 * src/maemo/modest-maemo-global-settings-dialog.c:
1628 (create_updating_page), (create_composing_page):
1629 * src/maemo/modest-msg-edit-window.c: (get_transports),
1630 (init_window), (modest_msg_edit_window_finalize),
1631 (modest_msg_edit_window_get_msg_data),
1632 (modest_msg_edit_window_free_msg_data):
1633 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1634 (modest_store_widget_finalize):
1635 * src/maemo/modest-transport-widget.c:
1636 (modest_transport_widget_finalize), (smtp_configuration):
1637 * src/modest-main.c: (send_mail):
1638 * src/widgets/modest-combo-box.h:
1639 * src/widgets/modest-global-settings-dialog-priv.h:
1640 * src/widgets/modest-global-settings-dialog.c:
1641 (modest_global_settings_dialog_finalize):
1642 * src/widgets/modest-msg-edit-window.h:
1643 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1644 as long as the combo box, to prevent use of freed memory for the ID.
1646 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1648 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1649 get_accounts(), to make this clearer. Do not check for the enabled gconf
1650 key, because we do not use this for server accounts (at least, not yet).
1651 This allows us to send email again.
1653 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1655 * src/maemo/modest-platform.c:
1656 (on_modest_conf_update_interval_changed), (modest_platform_init):
1657 Only respond to this particular key change. All these strcmp()s cannot be
1660 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1662 * src/maemo/modest-maemo-global-settings-dialog.c:
1663 (current_connection): Prevent a crash in scratchbox when
1664 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1665 * src/maemo/modest-platform.c:
1666 (on_modest_conf_update_interval_changed), (modest_platform_init):
1667 Get the update interval from gconf and reset it when the gconf key changes.
1669 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1671 * src/modest-protocol-info.c:
1672 * src/modest-protocol-info.h: Adde enum-specific get functions,
1673 instead of using a ModestProtocolType enum parameter.
1675 * src/gnome/modest-account-assistant.c:
1676 * src/gnome/modest-store-widget.c:
1677 * src/gnome/modest-store-widget.h:
1678 * src/gnome/modest-transport-widget.c:
1679 * src/gnome/modest-transport-widget.h:
1680 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1681 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1682 * src/maemo/easysetup/modest-easysetup-wizard.c:
1683 * src/maemo/modest-account-settings-dialog.c:
1684 * src/maemo/modest-account-settings-dialog.h:
1685 * src/maemo/modest-store-widget.c:
1686 * src/maemo/modest-store-widget.h:
1687 * src/maemo/modest-transport-widget.c:
1688 * src/maemo/modest-transport-widget.h:
1689 * src/modest-account-mgr-helpers.c:
1690 * src/modest-account-mgr-helpers.h:
1691 * src/modest-account-mgr.c:
1692 * src/modest-account-mgr.h:
1693 * src/modest-tny-account.c:
1694 * src/modest-tny-folder.c:
1695 * src/widgets/modest-account-view.c:
1696 * src/widgets/modest-retrieve-combo-box.c:
1697 * src/widgets/modest-retrieve-combo-box.h:
1698 * src/widgets/modest-secureauth-combo-box.c:
1699 * src/widgets/modest-serversecurity-combo-box.c:
1700 * src/widgets/modest-serversecurity-combo-box.h:
1701 * tests/check_account-mgr.c:
1702 Use the specific functions, and use the re-renamed enum values for GNOME too.
1704 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1706 * src/modest-pair.h:
1707 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1708 so we can get the second based on the first.
1710 * src/maemo/modest-account-settings-dialog.h:
1711 * src/maemo/modest-account-settings-dialog.c:
1712 Added get_supported_secure_authentication_methods(), though it is mostly
1713 commented-out for now until the necessary API is committed to tinymail.
1714 (modest_account_settings_dialog_set_account_name),
1715 (save_configuration): Request the supported authentication methods from the
1716 server, so we can choose a working method.
1718 * src/modest-tny-account-store.h:
1719 * src/modest-tny-account-store.c:
1720 (modest_tny_account_store_get_session): Rename from
1721 tny_account_store_get_session().
1723 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1725 * src/modest-protocol-info.h: Split the ModestProtocol enum
1726 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1727 There was no need to have these unrelated values in one enum.
1729 * src/: many files: Adapted to changed enum. This makes the code a bit
1730 clearer, and the compiler could catch some errors.
1732 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1734 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1735 Show the detailed internal camel error message when an error happens
1736 during the configuration, so that our testers can give us more clues.
1737 For instance, in projects.maemo.org bug NB#56910 .
1739 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1741 * src/modest-tny-account.c:
1742 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1743 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1745 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1747 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1748 * src/maemo/modest-account-settings-dialog.c:
1749 (modest_account_settings_dialog_set_account_name),
1750 (save_configuration): For the incoming secure authentication checkbox,
1751 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1752 the UI specification. PLAIN does not seem to be supported for most IMAP
1753 servers anyway, and I am not sure what it would mean.
1754 However, we probably need to discover which of the secure-authentication
1755 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1756 * src/modest-account-mgr-helpers.c:
1757 (modest_account_mgr_get_server_account_data):
1759 * src/modest-tny-account.c:
1760 (modest_tny_account_new_from_server_account):
1761 Use tny_account_set_mech() to set secure-authentication methods,
1762 with some special-casing for IMAP, based on my observations of how
1765 * src/modest-account-mgr-helpers.h:
1766 * src/modest-account-mgr.c:
1767 * src/modest-defs.h: Comment that the URI is only used for local folders.
1769 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1771 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1772 parameter const, just to be neat.
1773 * src/modest-text-utils.c: (modest_text_utils_inline):
1774 End g_strconcat() with NULL, as its documentation says. This is almost
1775 certainly the cause of my crash at startup on the device. Interestingly,
1776 valgrind doesn't tell us about these errors.
1778 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1780 * scripts/build-packages: Added more precise comments about how to use
1781 this script, though I still get this error:
1782 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1783 error building tinymail
1785 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1787 * src/maemo/modest-main-window.c: (on_account_update):
1788 Very slight cleanup, hoping to make it simpler to discover what causes
1789 a crash here sometimes.
1791 * src/modest-tny-account.c:
1792 (modest_tny_account_new_from_server_account): Set the port. Added
1793 comments about the options and a TODO comment because I need to find out
1794 how to specify the secure authentication method.
1796 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1798 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1799 changed CFlags paths form modest to libmodest
1801 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1803 * src/modest-account-mgr-helpers.c:
1804 (modest_account_mgr_get_server_account_data),
1805 (modest_account_mgr_free_server_account_data):
1806 * src/modest-account-mgr-helpers.h:
1807 * src/modest-account-mgr.c:
1808 (modest_account_mgr_add_server_account):
1809 * src/modest-defs.h:
1810 * src/modest-tny-account.c:
1811 (modest_tny_account_new_from_server_account):
1812 Determine the options for tny_camel_account_add_option() here,
1813 based on the settings, rather than storing them directly in gconf.
1815 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1817 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1818 Show a more friendly error dialog now that we expect (from the tinymail
1819 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1821 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1823 * src/maemo/modest-main-window.c: (on_account_update): Check that
1824 account_name is not NULL, to prevent a crash at startup that I am
1825 seeing on the N800. I do wonder why it is NULL.
1827 * src/maemo/easysetup/modest-easysetup-wizard.c:
1828 (create_page_user_details):
1829 * src/maemo/modest-account-settings-dialog.c:
1830 (create_page_user_details), (create_page_outgoing):
1831 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1832 (modest_connection_specific_smtp_edit_window_init):
1833 * src/modest-ui-actions.c:
1834 (modest_ui_actions_on_password_requested):
1835 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1836 might do something useful with the on-screen keyboard.
1838 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1840 * src/maemo/modest-main-window.c: (on_account_update):
1841 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1842 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1844 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1846 * src/modest-tny-account-store.c: (on_account_changed):
1847 Correct the signature of this signal handler.
1849 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1851 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1852 Show a HildonNote instead of a GtkDialog for Maemo.
1854 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1856 * src/widgets/modest-account-view.h:
1857 * src/widgets/modest-account-view.c: (on_account_changed),
1858 (on_account_removed). Added a boolean flag, set/unset by
1859 modest_account_view_block_conf_updates(),
1860 modest_account_view_unblock_conf_updates() to prevent unnecessary
1861 updates, but this is not very useful because the gconf notifications are
1862 so delays (maybe only on Maemo Bora).
1863 So auto-updating is turned off, and these functions do an explicit
1864 update when necessary.
1865 However, something else is still doing too much work when adding/removing
1866 accounts, probably in another part of the application.
1868 * src/maemo/modest-account-view-window.c:
1869 (on_delete_button_clicked), (on_edit_button_clicked),
1870 (on_new_button_clicked): Use the new functions.
1872 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1874 * src/modest-account-mgr-helpers.c:
1875 (modest_account_mgr_set_first_account_as_default):
1876 Sort the list of names alphabetically-by-title, so we choose the first one
1878 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1879 alphabetically by the title.
1881 This fixes projects.maemo.org bug NB#56418 .
1883 * src/modest-account-mgr-priv.c:
1884 (_modest_account_mgr_account_from_key):
1885 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1886 avoid a valgrind error, and possible random behaviour.
1888 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1890 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1891 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1892 tinymail documentation to say that this can be expected.
1893 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1894 pretty, and should not happen, but I would prefer to know when it does.
1896 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1898 * configure.ac: When using the older hildon version, probably on Bora,
1899 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1901 * src/widgets/modest-attachment-view.c:
1902 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1905 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1907 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1908 Implemented the prototype. Can be tested with
1909 tests/dbus_api/test_open_message:
1911 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1913 * src/modest-tny-account-store.c:
1914 (modest_tny_account_store_instance_init), (get_password):
1915 * src/modest-ui-actions.c:
1916 (modest_ui_actions_on_password_requested):
1917 Do not store the password in gconf, because this function is called
1918 for non-remembered passwords. Actually use the cached (in the hash map)
1919 password instead of releasing it.
1920 The password will now not be remembered if it is asked via the protected
1921 password dialog, as per the UI spec.
1923 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1925 * src/modest-defs.h:
1926 * src/modest-account-mgr-helpers.h:
1927 * src/modest-account-mgr-helpers.c:
1928 Added modest_server_account_get_username_has_succeeded(),
1929 modest_server_account_set_username_has_succeeded().
1930 (modest_server_account_set_username),
1931 Reset the has-succeeded flag if the username changes.
1933 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1934 * src/maemo/modest-connection-specific-smtp-window.c:
1935 (modest_connection_specific_smtp_window_save_server_accounts):
1936 Use modest_server_account_set_username() instead of using
1937 modest_conf_set_string() directly, so that the has-succeeded flag is always
1940 * src/modest-ui-actions.c:
1941 (modest_ui_actions_on_password_requested): Dim the username entry if
1942 the username has ever worked, as per the UI spec.
1944 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1946 * src/modest-tny-account-store.c: (get_password):
1947 * src/modest-ui-actions.c:
1948 (modest_ui_actions_on_password_requested):
1949 Allow the username to be changed too, though there is more work to
1950 be done on exactly how this behaves.
1952 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1954 * src/modest-account-mgr-helpers.h:
1955 * src/modest-account-mgr-helpers.c:
1956 Added modest_account_mgr_get_display_name(),
1957 modest_server_account_get_username(),
1958 modest_server_account_set_username(),
1959 modest_server_account_set_password(),
1960 modest_server_account_get_hostname() functions so we do not need to
1961 use the conf API directly.
1963 * src/maemo/modest-main-window.c: (connect_signals):
1964 Actually connect ot the ModestAccountStore::request-password signal,
1965 so that we show the dialog when the password is requested by Tinymail,
1966 for isntance if it is empty.
1968 * src/modest-marshal.list:
1969 * src/modest-tny-account-store.c:
1970 (modest_tny_account_store_class_init), (get_password),
1971 (modest_tny_account_store_alert):
1972 * src/modest-tny-account-store.h:
1973 * src/modest-ui-actions.h:
1974 * src/modest-ui-actions.c:
1975 (modest_ui_actions_on_password_requested):
1976 Change the signal parameters, so it is obvious that we are providing
1977 the non human-readable server name, and receiving both the username
1978 and password, though changing of the username is not yet implemented.
1979 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1980 for the GNOME version.
1982 This should fix the projects.maemo.org bug NB#56209, though it does not
1983 work on Bora, because the gconf_client_get() for the password fails
1984 immediately after we save it with gconf_client_set().
1986 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1989 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1990 caused an undefined symbol error:
1991 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1993 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1995 * src/modest-tny-account-store.c:
1996 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1997 using a GError instead of a string message, so we can translate it in
2000 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2002 * src/maemo/modest-address-book.c:
2003 (modest_address_book_check_names):
2004 * src/maemo/modest-msg-view-window.c:
2005 (modest_msg_view_window_clipboard_owner_change):
2006 * src/modest-init.c: (modest_init_init_ui):
2007 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2008 (update_folders_cb), (modest_mail_operation_update_account):
2009 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2010 (modest_ui_actions_on_msg_attachment_clicked),
2011 (modest_ui_actions_on_msg_recpt_activated):
2012 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2013 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2014 (modest_msg_view_search_next):
2015 * src/widgets/modest-recpt-editor.c:
2016 (modest_recpt_editor_on_button_release_event),
2017 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2018 g_message(). At this point we should only be seeing interesting errors on
2019 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2021 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2023 (modest_wizard_dialog_force_title_update):
2024 * src/maemo/easysetup/modest-wizard-dialog.h:
2025 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2026 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2027 can update the title when appropriate. Otherwise the title is wrong if the
2028 pages are added after adding the notebook to the dialog.
2029 This must be a problem in HildonWizardDialog too.
2030 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2032 * src/maemo/easysetup/modest-easysetup-wizard.c:
2033 (create_subsequent_customsetup_pages),
2034 (create_subsequent_easysetup_pages):
2035 Call modest_wizard_dialog_force_title_update() so that the title is
2036 correct even with GTK+ < 2.10.
2037 This fixes projects.maemo.org bug NB#56145 .
2039 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2041 * src/maemo/modest-platform.c:
2042 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2043 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2046 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2048 * src/widgets/modest-window.h:
2049 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2050 and modest_window_save_state(), which invokes it.
2052 * src/widgets/modest-window-mgr.h:
2053 * src/widgets/modest-window-mgr.c:
2054 Added modest_window_mgr_save_state_for_all_windows(), which calls
2055 the save_state vfunc on all registered windows, if implemented.
2057 * src/gnome/modest-msg-edit-window.c:
2058 * src/gnome/modest-msg-view-window.c:
2059 * src/maemo/modest-msg-edit-window.c:
2060 * src/maemo/modest-msg-view-window.c:
2061 * src/maemo/modest-main-window.c:
2062 Specify the existing save_settings functions as implementations of
2063 ModestWindow::save_state_func().
2065 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2066 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2067 enabling hibernation, for instance.
2069 We may need to do the same thing for restoring settings.
2072 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2074 * src/widgets/modest-window-mgr.c:
2075 * src/widgets/modest-window-mgr.h:
2076 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2077 modest_window_mgr_get_hibernation_is_prevented().
2079 * src/maemo/modest-main-window.c:
2080 (on_hildon_program_is_topmost_notify): Prevent hibernation
2081 (possible when the application goes to the background in the WM),
2082 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2084 * src/maemo/easysetup/modest-easysetup-wizard.c:
2085 (modest_easysetup_wizard_dialog_init):
2086 * src/maemo/modest-account-settings-dialog.c:
2087 (modest_account_settings_dialog_init):
2088 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2089 (modest_connection_specific_smtp_edit_window_init):
2090 * src/maemo/modest-connection-specific-smtp-window.c:
2091 (modest_connection_specific_smtp_window_init):
2092 * src/maemo/modest-signature-editor-dialog.c:
2093 (modest_signature_editor_dialog_init):
2094 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2095 prevent hibernation while any of these account settings dialogs are open.
2097 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2099 * src/maemo/Makefile.am:
2100 * src/maemo/modest-osso-state-saving.c:
2101 * src/maemo/modest-osso-state-saving.h: Added
2102 modest_osso_load_state() and modest_osso_save_state() though they do
2103 nothing now. They should iterate through all the open windows and load/save
2105 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2106 save state when closing.
2108 * src/maemo/modest-main-window.c:
2109 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2110 Add a notification handler for the HildonProgram::is-topmost property,
2111 so we can allow hibernation when the application goes into the background.
2112 But we still need to detect when the accounts setup windows are open so
2113 we can stop hibernation when they are open.
2114 To do this, I also added the main window the HildonProgram. This might have
2115 other side-effects/benefits, and should maybe be done for other windows.
2117 * src/maemo/modest-osso-autosave-callbacks.h:
2118 * src/maemo/modest-osso-autosave-callbacks.c:
2119 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2120 though it does not do anything yet, and we might never need this to do
2121 anything. For instance, we already save drafts.
2123 * src/maemo/modest-platform.c: (modest_platform_init):
2124 Specify the libosso auto-save callback.
2126 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2128 * src/maemo/modest-platform.c:
2129 (modest_platform_set_update_interval):
2130 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2131 aparently stays valid between application instances, so we can use this
2132 to remove and reset it later. According to a maemo-developers email from
2135 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2137 * configure.ac: Depend on libalarm for Maemo.
2139 * src/dbus_api/modest-dbus-api.h:
2140 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2141 (on_send_receive), (modest_dbus_req_handler):
2142 Handle a SEND_RECEIVE D-Bus method.
2144 * libmodest-dbus-client/libmodest-dbus-client.c:
2145 (libmodest_dbus_client_send_and_receive):
2146 * libmodest-dbus-client/libmodest-dbus-client.h:
2147 Add C convenience functions for calling the new D-Bus method.
2149 * src/modest-platform.h:
2150 * src/gnome/modest-platform.c:
2151 * src/maemo/modest-platform.c:
2152 Added modest_platform_set_update_interval(), which uses the
2153 alarmd API on Maemo.
2154 (modest_platform_init),
2155 Call modest_platform_set_update_interval(), using a hard-coded
2156 interval for now (until the global settings dialog is implemented),
2157 though I am not sure that this makes sense yet.
2159 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2161 * src/dbus_api/modest-dbus-callbacks.c:
2162 (modest_osso_cb_hw_state_handler):
2163 * src/dbus_api/modest-dbus-callbacks.h:
2164 * src/maemo/modest-platform.c: (modest_platform_init):
2165 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2166 in case this has some effect on the ability for Maemo to ping the
2169 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2171 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2172 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2173 warning. It is probably a logic error, but I need to fix the build.
2175 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2177 * src/modest-account-mgr.h:
2178 * src/modest-account-mgr.c:
2179 (modest_account_mgr_account_names): Add a gboolean enabled_only
2180 parameter, so we can get lists of onlt the enabled accounts.
2182 (modest_account_mgr_add_account),,
2183 (modest_account_mgr_account_with_display_name_exists):
2184 * src/maemo/modest-msg-edit-window.c: (get_transports):
2185 * src/modest-account-mgr-helpers.c:
2186 (modest_account_mgr_set_first_account_as_default):
2187 * src/modest-init.c: (init_default_account_maybe):
2188 * src/modest-tny-account-store.c: (get_accounts):
2189 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2190 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2191 * tests/check_account-mgr.c: (START_TEST):
2192 Provide the extra parameter, as appropriate.
2194 * src/widgets/modest-account-view.c: (update_account_view):
2195 Do not show disabled accounts (meaning that there is no way to
2196 enable/disable accounts in the UI (the feature is not in our UI
2197 specification), so we can use this internally only to mark unfinished
2198 or temporary account data.
2200 * src/maemo/easysetup/modest-easysetup-wizard.c:
2201 (create_account): Add boolean enable parameter, so we can specify FALSE
2202 to create the temporary account.
2203 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2204 (on_before_next): When finishing, when there is a temporary account, just
2206 Also, use a timeout to delay the showing of the dialog until gconf is likely
2207 to return correct information, due to a maemo gconf bug that is fixed in
2208 osso 1.1, but not yet in Bora.
2209 However, the dialog stays on screen after it is destroyed.
2211 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2212 for invalid data when cancelling. Use a hildon note instead of a dialog
2213 to complain about invalid data. Do not show the account-saved note if the
2214 account is disabled (a temporary account that will not really be saved for use
2217 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2219 * src/modest-account-mgr-helpers.h:
2220 * src/modest-account-mgr-helpers.c:
2221 Added modest_account_mgr_unset_default_account(),
2222 Added modest_account_mgr_set_first_account_as_default().
2224 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2225 If it was the default account, unset the default account name.
2227 * src/maemo/modest-account-view-window.c:
2228 (on_delete_button_clicked): If it was the default account,
2229 set the first remaining account as the default instead.
2231 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2232 a NULL account or a NULL default account, to prevent a crash. This should
2233 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2236 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2238 * src/widgets/modest-recpt-editor.c:
2239 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2240 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2241 TODO comment for this. This fixes the build.
2243 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2244 be the best place for it. This will in future update all auto-update accounts,
2245 rather than just the current/default account, when that gconf key exists.
2246 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2247 if there are no accounts, before calling do_send_receive().
2248 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2250 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2251 * src/maemo/modest-main-window-ui.h:
2252 * src/maemo/modest-main-window.c: (on_connection_changed),
2253 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2254 directly, becaue the signal handler does more.
2256 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2258 * src/modest-account-mgr-helpers.c:
2259 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2260 for the case that the account does not exist.
2262 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2263 (equivalent to the modest account name) rather than the tinymail account name
2264 (equivalent to the modest account title - human readable) to get the account data.
2265 Check for null account data to prevent the crash, and add a TODO comment saying that
2266 this needs fixing because it is using the server account name instead of the account name.
2268 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2270 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2271 * src/maemo/modest-account-settings-dialog.c: (show_error),
2273 Use hildon_note_new_information() for informative and error messages,
2274 which seems to be expected for Maemo applications (no documentation that I know of
2275 says this). I am surprised that there is no distinction between info and error
2278 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2280 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2281 it is easy to find where this is used.
2283 * src/maemo/easysetup/modest-easysetup-wizard.c:
2284 (create_page_welcome), (create_page_account_details),
2285 (create_page_user_details), (create_page_complete_easysetup),
2286 (create_page_custom_incoming), (create_page_custom_outgoing),
2287 (create_page_complete_custom):
2288 * src/maemo/modest-account-settings-dialog.c:
2289 (create_page_account_details), (create_page_user_details),
2290 (create_page_incoming), (create_page_outgoing):
2291 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2292 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2293 (modest_connection_specific_smtp_edit_window_init):
2294 * src/maemo/modest-connection-specific-smtp-window.c:
2295 (modest_connection_specific_smtp_window_init):
2296 * src/maemo/modest-signature-editor-dialog.c:
2297 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2298 and scrolling policy as per the Email Application Layout Guide, if I have
2301 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2303 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2304 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2305 which were empty, because these vfuncs have been removed from TnyAccountStore.
2306 This fixes the build.
2308 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2310 * src/maemo/modest-main-window.c:
2311 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2312 showing/hiding it. Added TODO because it probably should not be NULL.
2313 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2314 because unnecessary g_warnings() make degugging difficult.
2316 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2318 * src/maemo/modest-msg-edit-window.c:
2319 (modest_msg_edit_window_select_color),
2320 (modest_msg_edit_window_select_background_color): 2 const corrections and
2321 moving 2 #endifs before closing brackets, to fix the build.
2323 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2325 * src/maemo/easysetup/modest-easysetup-wizard.h:
2326 * src/maemo/easysetup/modest-easysetup-wizard.c:
2327 (modest_easysetup_wizard_dialog_finalize),
2328 (on_button_edit_advanced_settings), (create_page_complete_custom),
2329 (on_response), (create_account):
2330 Implement the Advanced Settings edit button, by saving the account information,
2331 for the Advanded Settings dialog to use directly from gconf, and removing it
2332 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2333 Bug #5533 in the projects.maemo.org bugzilla.
2335 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2337 * src/maemo/modest-msg-view-window.c:
2338 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2339 when opening a message window.
2341 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2343 * src/maemo/easysetup/modest-easysetup-wizard.c:
2344 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2347 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2348 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2349 gconf settings. I probably added more checks than necessary, but that is safer.
2351 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2352 variable to fix the build, but this seems to be used when it is still NULL.
2354 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2356 * src/modest-platform.h:
2357 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2358 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2359 * src/modest-main.c: Implement this function so we can avoid using
2360 maemo-specific API from cross-platform code.
2362 * src/modest-tny-account-store.c:
2363 (get_smtp_specific_transport_account_for_open_connection):
2364 * src/modest-ui-actions.c: (check_for_connection),
2365 (modest_ui_actions_on_item_not_found):
2366 Use modest_platform_connect_and_wait() and put #idefs around other
2367 maemo-specific code, because only maemo currently has a way to
2368 identify connection names.
2370 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2372 * src/modest-tny-account-store.h:
2373 * src/modest-tny-account-store.c:
2374 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2375 the connection-specific SMTP server settings in the configuration.
2377 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2379 * src/maemo/modest-main-window.c: (on_connection_changed),
2381 * src/modest-main.c: (main), (start_ui), (send_mail):
2382 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2383 that is what is intended.
2385 * src/modest-ui-actions.c: (action_send), (action_receive),
2386 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2387 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2388 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2389 SMTP server is used when it is specified.
2391 (modest_ui_actions_on_send_receive):
2392 Check that a connection is open before proceeding.
2393 Receive and then send, instead of vice-versa, as per the specification.
2395 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2397 * src/modest-mail-operation.c:
2398 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2399 though I guess it should be something other than NULL.
2401 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2403 * src/maemo/easysetup/modest-easysetup-wizard.c:
2404 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2405 combo twice, to avoid an g_warning and to make it visible again.
2406 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2407 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2408 (already intended) dereference when detaching, because we then recreate the menu.
2409 But I am not sure why the warning was happening, and it is possible that this is a memory
2412 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2414 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2415 and uri_parse_mailto() utility functions.
2416 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2418 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2420 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2422 * src/dbus_api/modest-dbus-api.h:
2423 * src/dbus_api/modest-dbus-callbacks.c:
2424 Use an idle callback to execute the modest code in the application's own thread.
2425 Remove the helloworld example method.
2426 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2427 parsed, and the open-message method is not implemented because this is not yet implemented in
2429 * libmodest-dbus-client/libmodest-dbus-client.c:
2430 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2431 (libmodest_dbus_client_open_message):
2432 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2434 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2435 body without crashing.
2437 * tests/dbus_api/Makefile.am:
2438 * tests/dbus_api/test_mail_to.c:
2439 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2441 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2443 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2444 Added file to fix the build. Sorry.
2446 * src/dbus_api/Makefile.am:
2447 * src/dbus_api/modest-dbus-api.h:
2448 * src/dbus_api/modest-dbus-callbacks.h:
2449 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2450 (modest_dbus_req_handler):
2451 Put constants in a separate header so it can be reused by the
2452 client library, without duplication
2454 * libmodest-dbus-client/Makefile.am:
2455 * libmodest-dbus-client/libmodest-dbus-client.c:
2456 (libmodest_dbus_client_call_helloworld),
2457 (libmodfest_dbus_client_send_mail),
2458 (libmodfest_dbus_client_mailto),
2459 (libmodfest_dbus_client_open_message):
2460 * libmodest-dbus-client/libmodest-dbus-client.h:
2461 (Partly) Implement a send_mail D-Bus method.
2463 * tests/dbus_api/Makefile.am:
2464 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2465 the send_email D-Bus method.
2467 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2471 * libmodest-dbus-client/Makefile.am:
2472 * libmodest-dbus-client/libmodest-dbus-client.c:
2473 * libmodest-dbus-client/libmodest-dbus-client.h:
2474 * tests/dbus_api/Makefile.am:
2475 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2476 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2478 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2480 * src/maemo/easysetup/modest-easysetup-wizard.c:
2481 (create_page_account_details):
2482 * src/maemo/modest-account-settings-dialog.c:
2483 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2484 widgets, because this might not be the default in future versions of the Maemo GTK+.
2485 However, I can not not get capitalization to work even in a simple test case.
2487 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2489 * src/maemo/easysetup/modest-easysetup-wizard.c:
2490 (create_page_custom_incoming), (create_page_custom_outgoing):
2491 * src/maemo/modest-account-settings-dialog.c:
2492 (create_page_account_details), (create_page_incoming),
2493 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2494 instead of using gtk_check_button_with_label(), so they are aligned like the other
2495 widgets, as per the UI spec.
2497 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2499 * src/maemo/easysetup/modest-easysetup-wizard.c:
2500 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2501 * src/widgets/modest-validating-entry.c:
2502 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2503 Modest prefix instead of an EasySetup prefix.
2505 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2507 * src/widgets/modest-validating-entry.h:
2508 * src/widgets/modest-validating-entry.c: (on_insert_text),
2509 Added easysetup_validating_entry_set_max_func(), used to set a callback
2510 to call when the max number of characters is reached. GtkEntry has a max-length
2511 already but is silent about it.
2513 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2514 (create_page_account_details), (create_page_user_details),
2516 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2517 (create_page_account_details), (create_page_user_details),
2518 (create_page_outgoing):
2519 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2520 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2521 the UI spec, when the user tries to enter more than the max number of characters.
2523 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2525 * src/maemo/easysetup/modest-easysetup-wizard.c:
2526 (create_page_user_details), (create_page_custom_incoming),
2527 (create_page_custom_outgoing):
2528 * src/maemo/modest-account-settings-dialog.c:
2529 (create_page_user_details), (create_page_incoming),
2530 (create_page_outgoing):
2531 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2532 (modest_connection_specific_smtp_edit_window_init):
2533 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2534 not appropriate. Bad Maemo-specific defaults!.
2536 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2538 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2539 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2540 (modest_signature_editor_dialog_set_settings):
2541 Disable the label and textview when the checkbox is disabled, and use the
2542 specified (UI spec) default signature text.
2544 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2546 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2547 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2549 * src/modest-defs.h:
2550 * src/modest-account-mgr-helpers.h:
2551 * src/modest-account-mgr-helpers.c:
2552 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2554 * src/maemo/Makefile.am:
2555 * src/maemo/modest-signature-editor-dialog.c:
2556 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2559 * src/maemo/modest-account-settings-dialog.h:
2560 * src/maemo/modest-account-settings-dialog.c:
2561 (modest_account_settings_dialog_finalize), (on_button_signature),
2562 (save_configuration): Use the new dialog when the Edit button is pressed, and
2563 save the changes if necessary, as per the UI spec.
2565 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2567 * src/maemo/Makefile.am:
2568 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2569 based on maemo-develoers email from Dirk.
2571 * src/maemo/easysetup/modest-easysetup-wizard.c:
2572 (create_page_welcome), (create_page_account_details),
2573 (create_page_user_details), (create_page_complete_easysetup),
2574 (create_page_custom_incoming), (create_page_custom_outgoing),
2575 (create_page_complete_custom),
2576 (modest_easysetup_wizard_dialog_init):
2577 * src/maemo/modest-account-settings-dialog.c:
2578 (create_page_account_details), (create_page_user_details),
2579 (create_page_incoming), (create_page_outgoing),
2580 (modest_account_settings_dialog_init):
2581 * src/maemo/modest-connection-specific-smtp-window.c:
2582 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2584 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2586 * src/maemo/easysetup/modest-easysetup-wizard.c:
2587 (create_page_account_details), (create_page_custom_outgoing),
2588 (create_page_complete_custom):
2589 * src/maemo/modest-account-settings-dialog.c:
2590 (create_page_user_details), (create_page_incoming),
2591 (create_page_outgoing):
2592 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2593 (modest_connection_specific_smtp_edit_window_init):
2594 Use the correct (UI spec) port min/max, and use horizontal separators,
2597 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2599 * src/maemo/easysetup/modest-easysetup-wizard.c:
2600 (set_default_custom_servernames):
2601 * src/maemo/modest-account-settings-dialog.c:
2602 (create_page_incoming), (on_combo_outgoing_security_changed),
2603 (on_combo_incoming_security_changed), (create_page_outgoing),
2604 (modest_account_settings_dialog_set_account_name),
2605 (save_configuration):
2606 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2607 (on_combo_security_changed),
2608 (modest_connection_specific_smtp_edit_window_init),
2609 (modest_connection_specific_smtp_edit_window_set_connection),
2610 (modest_connection_specific_smtp_edit_window_get_settings):
2611 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2614 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2617 * src/maemo/easysetup/modest-easysetup-wizard.c:
2618 (create_page_custom_outgoing), (create_page_complete_custom):
2619 * src/maemo/modest-account-settings-dialog.c:
2620 (create_page_user_details), (create_page_outgoing):
2621 * src/maemo/modest-account-view-window.c: (button_box_new):
2622 Use changed logical IDs as per the most recent UI spec:
2623 mcen_bd_emailsetup_edit -> mcen_bd_edit
2624 mcen_bd_emailsetup_delete -> mcen_bd_delete
2625 mcen_bd_emailsetup_close -> mcen_bd_close
2627 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2631 * src/dbus_api/Makefile.am:
2632 * src/dbus_api/modest-dbus-callbacks.c:
2633 * src/dbus_api/modest-dbus-callbacks.h:
2634 * src/maemo/modest-platform.c: (modest_platform_init):
2635 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2637 * tests/Makefile.am:
2638 * tests/dbus_api/Makefile.am:
2639 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2641 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2643 * src/maemo/modest-account-settings-dialog.c:
2644 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2645 Removed unnecessary includes.
2647 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2649 * src/maemo/easysetup/modest-easysetup-wizard.c:
2650 * src/maemo/modest-account-settings-dialog.c:
2651 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2652 * src/widgets/Makefile.am:
2653 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2654 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2655 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2656 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2657 * src/widgets/modest-secureauth-combo-box.c:
2658 * src/widgets/modest-secureauth-combo-box.h:
2659 * src/widgets/modest-serversecurity-combo-box.c:
2660 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2661 made the GObject names more consistent with the rest of the Modest code.
2663 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2665 * src/maemo/easysetup/Makefile.am:
2666 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2667 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2668 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2669 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2670 * src/maemo/easysetup/modest-easysetup-wizard.c:
2671 * src/maemo/easysetup/modest-validating-entry.c:
2672 * src/maemo/easysetup/modest-validating-entry.h:
2673 * src/maemo/modest-account-settings-dialog.c:
2674 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2675 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2676 widgets/ because they are used outside of easysetup too. After checking in,
2677 svn will allow me to rename them too.
2679 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2681 * src/gnome/modest-msg-edit-window.c:
2682 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2683 linker error, to fix the build on the GNOME platform.
2684 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2685 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2686 ifdefed out to avoid a warning.
2688 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2690 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2691 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2692 some alternative for GTK+ 2.6.
2694 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2696 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2698 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2699 specified for EmailAccountsDialog in UI spec.
2701 * src/maemo/easysetup/modest-easysetup-wizard.c:
2702 * src/maemo/easysetup/modest-easysetup-wizard.h:
2703 * src/maemo/modest-account-settings-dialog.c:
2704 * src/maemo/modest-account-settings-dialog.h:
2705 Reuse a member window widget for the connection-specific SMTP server accounts,
2706 so we can tell it to create/save the accounts only if we actually save changes.
2708 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2709 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2710 (modest_connection_specific_smtp_edit_window_get_settings):
2711 Return a struct instance for temporarily remembering the entered data.
2713 * src/maemo/modest-connection-specific-smtp-window.h:
2714 * src/maemo/modest-connection-specific-smtp-window.c:
2715 (modest_connection_specific_smtp_window_finalize),
2716 (modest_connection_specific_smtp_window_fill_with_connections),
2718 (modest_connection_specific_smtp_window_save_server_accounts),
2719 (update_model_server_names): Do not actually save data until asked,
2720 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2722 (on_selection_changed),
2723 (modest_connection_specific_smtp_window_init): Disable the edit
2724 button when nothing is selected.
2726 * src/modest-account-mgr-helpers.c:
2727 * src/modest-account-mgr-helpers.h:
2728 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2731 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2733 * src/modest-account-mgr-helpers.h:
2734 * src/modest-account-mgr-helpers.c:
2735 (modest_account_mgr_get_unused_account_name),
2736 (modest_account_mgr_get_unused_account_display_name): Added these
2737 utility functions, to avoid code duplication.
2739 * src/maemo/easysetup/modest-easysetup-wizard.c:
2740 (create_page_account_details), (create_account):
2741 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2742 (on_combo_security_changed),
2743 (modest_connection_specific_smtp_edit_window_init),
2744 (modest_connection_specific_smtp_edit_window_save_settings):
2745 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2746 * src/maemo/modest-connection-specific-smtp-window.c:
2747 (modest_connection_specific_smtp_window_finalize),
2748 (modest_connection_specific_smtp_window_fill_with_connections),
2749 (on_button_edit), (modest_connection_specific_smtp_window_init):
2750 * src/maemo/modest-connection-specific-smtp-window.h:
2751 Implementing saving of connection-specific server accounts.
2753 But I need to refactor this so we can save the data for each
2754 possible connection-specific account and only actually create the server accounts
2755 when the easysetup finished, or the OK button is pressed on the account settings
2758 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2760 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2761 (on_combo_security_changed):
2762 (modest_connection_specific_smtp_edit_window_init):
2763 Auto-fill the port number as in the account settings.
2765 (modest_connection_specific_smtp_edit_window_set_connection):
2766 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2767 * src/maemo/modest-connection-specific-smtp-window.c:
2768 (fill_with_connections), (on_button_edit),
2769 (modest_connection_specific_smtp_window_init):
2770 Turn the edit window into a dialog to simplify the code, and
2771 set a WM hint as in a GtkDialog, because only a popup can be on top of
2772 another window in Maemo, and popups usually have no WM decoration.
2774 * src/modest-defs.h:
2775 * src/modest-account-mgr-helpers.c:
2776 (modest_account_mgr_set_connection_specific_smtp),
2777 (modest_account_mgr_remove_connection_specific_smtp),
2778 (modest_account_mgr_get_connection_specific_smtp):
2779 * src/modest-account-mgr-helpers.h: Some functions to write the
2780 connection-specific SMTP server information. Not yet used.
2783 * src/widgets/modest-folder-view.c: (text_cell_data):
2784 Fix a warning about an uninitialized variable.
2785 (on_configuration_key_changed): Put an #ifdef around the use
2786 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2788 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2790 * src/maemo/modest-account-settings-dialog.h:
2791 * src/maemo/modest-account-settings-dialog.c:
2792 Added connect_for_modified() utility function to mark the new modified boolean.
2794 (create_page_account_details), (create_page_user_details),
2795 (create_page_incoming), (create_page_outgoing), (on_response),
2796 (modest_account_settings_dialog_init),
2797 (modest_account_settings_dialog_set_account_name):
2798 Only warn about unsaved changes when there are actually unsaved changes.
2800 * src/modest-account-mgr-helpers.c:
2801 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2802 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2803 to get the data from there in future.
2805 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2807 * src/modest-defs.h:
2809 * src/modest-account-mgr-helpers.h:
2810 * src/modest-account-mgr-helpers.c:
2811 Store the security account setting in a single conf key instead of using
2812 the options list, so that the list is left for just the to-be-removed camel hack,
2813 and because gconf_client_set_list() is failing for some reason.
2815 * src/modest-account-mgr.c:
2816 (modest_account_mgr_add_server_account):
2817 * src/maemo/modest-account-settings-dialog.c:
2818 (modest_account_settings_dialog_set_account_name),
2819 (save_configuration): Use the renamed functions.
2822 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2824 * src/widgets/Makefile.am:
2825 * src/widgets/modest-limit-retrieve-combo-box.c:
2826 * src/widgets/modest-limit-retrieve-combo-box.h:
2827 * src/widgets/modest-retrieve-combo-box.c:
2828 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2829 the account settings dialog.
2831 * src/modest-defs.h:
2832 * src/modest-account-mgr-helpers.h:
2833 * src/modest-account-mgr-helpers.c:
2834 (modest_server_account_get_option_secure_auth),
2835 (modest_server_account_set_option_secure_auth):
2836 * src/modest-account-mgr.c:
2837 (modest_account_mgr_add_server_account):
2838 Use the existing AUTH_MECH conf key for the secure-auth setting,
2839 instead of putting it in the list options, because this was actually used already.
2841 * src/maemo/modest-account-settings-dialog.c:
2842 (create_page_account_details),
2843 (modest_account_settings_dialog_set_account_name),
2844 (save_configuration):
2845 * src/maemo/modest-account-settings-dialog.h:
2846 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2847 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2849 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2851 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2852 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2853 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2855 * src/modest-defs.h:
2856 * src/maemo/modest-account-settings-dialog.c:
2857 (create_page_incoming), (on_combo_outgoing_security_changed),
2858 (on_combo_incoming_security_changed), (create_page_outgoing),
2859 (modest_account_settings_dialog_set_account_name),
2860 (save_configuration): Load/Save the port number, and change it when the
2861 security combo changes, to suitable defaults.
2863 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2865 * src/modest-account-mgr.c:
2866 (modest_account_mgr_add_server_account): Set the security and secure-auth
2867 options, and add a comment saying that the other camel-specific options should be
2870 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2872 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2874 * src/modest-tny-account-store.c: (account_list_free),
2875 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2876 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2879 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2881 * src/modest-protocol-info.c:
2882 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2883 is required by our UI spec. Maybe something in our implementation will use this eventually.
2884 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2885 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2886 instead of the previous 0 placeholder.
2888 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2889 secure-auth settings.
2890 * src/modest-account-mgr-helpers.h:
2891 * src/modest-account-mgr-helpers.c:
2892 (modest_server_account_data_get_option_secure_auth),
2893 (modest_server_account_set_option_secure_auth),
2894 (modest_server_account_data_get_option_security),
2895 (modest_server_account_set_option_security): Added this API for getting and setting the security
2896 and secure-auth settings.
2898 * src/maemo/modest-account-settings-dialog.h:
2899 * src/maemo/modest-account-settings-dialog.c:
2900 (modest_account_settings_dialog_finalize), (check_data),
2901 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2902 about changing titles.
2903 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2904 (save_configuration): Save the security and secure-auth settings.
2906 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2907 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2909 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2911 * src/modest-defs.h:
2912 * src/modest-account-mgr.c:
2913 (modest_account_mgr_add_server_account):
2914 Added and used defines for the options key and value pair strings,
2915 that are used so far, though they do not seem to correspond to anything in our
2916 UI specs or ModestProtocol enum.
2918 * src/modest-account-mgr-helpers.h:
2919 * src/modest-account-mgr-helpers.c:
2920 (compare_option_strings_for_name),
2921 (modest_server_account_data_get_option_value),
2922 (modest_server_account_data_get_option_bool),
2923 (modest_account_mgr_get_server_account_option):
2924 Added helper functions for parsing the options GSList.
2926 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2928 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2929 display name is based on the supplied account name.
2930 * src/modest-account-mgr.c:
2931 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2932 with an inefficient, but good-enough, implementation.
2934 * src/maemo/easysetup/modest-easysetup-wizard.c:
2935 (create_page_account_details), (on_before_next), (create_account):
2936 Check for existing display names rather than (non-user-visible) account names, and just
2937 create and set a unique account name at the end.
2939 * src/maemo/modest-account-settings-dialog.c:
2940 (modest_account_settings_dialog_init),
2941 (modest_account_settings_dialog_set_account_name),
2942 (create_page_incoming): Show the display name, instead of the account name.
2943 (on_response): Do some (not all) extra checks, as in the UI spec.
2944 (save_configuration): Save the display name if it was changed.
2946 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2948 * po/en_GB.po: Added needed logical ID and translation.
2949 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2950 (init_view): Made the is-default column clicking work.
2952 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2955 * src/maemo/easysetup/Makefile.am:
2956 * src/maemo/easysetup/modest-easysetup-wizard.c:
2957 (modest_easysetup_wizard_dialog_init):
2958 * src/maemo/easysetup/provider-data-test.keyfile:
2959 * src/maemo/easysetup/provider-data.keyfile:
2960 Moved the provider data file to the new modest-providers-data package and used it from there.
2962 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2964 * src/modest-local-folder-info.c:
2965 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2966 N_() was already used on the static strings, but this just marks it for translation without
2967 using the translation.
2969 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2971 * src/maemo/modest-account-settings-dialog.c:
2972 (create_page_incoming),
2973 (modest_account_settings_dialog_set_account_name):
2974 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2975 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2976 I will do this if nobody else gets there first.
2978 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2980 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2981 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2982 save the security stuff.
2984 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2986 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2987 Set the email address and user fullname, which I now see must be
2990 * src/maemo/modest-account-settings-dialog.h:
2991 * src/maemo/modest-account-settings-dialog.c:
2993 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2994 leave-on-server and authentication.
2995 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2998 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3001 * src/maemo/modest-account-settings-dialog.c:
3002 * src/maemo/modest-account-settings-dialog.h:
3003 Most (but not all) of the widgets are now present as specified by the UI spec.
3004 No changes are yet saved, and some details are not properly shown yet.
3006 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3008 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3010 * src/maemo/Makefile.am:
3011 * src/maemo/modest-account-settings-dialog.c:
3012 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3013 an existing account. Doesn't do much yet.
3015 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3016 Open the accounts settings dialog when Edit is clicked.
3018 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3020 * src/maemo/easysetup/Makefile.am:
3021 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3023 * src/maemo/easysetup/modest-easysetup-wizard.c:
3024 (modest_easysetup_wizard_dialog_init):
3025 Try to get the source directory from the build system,
3026 instead of hard-coding "./" into the source code, when opening our local
3027 copies of the configuration files.
3028 But this still fails when opening the wizard from the Accounts window,
3029 maybe because the working directory seems to change at runtime.
3030 So the wizard will fail the second time unless you copy the files into their
3031 proper locations - see the stdout warnings for the paths.
3033 (create_page_account_details),(on_before_next):
3034 Check for existing non-server accounts instead of server accounts,
3035 so the default account name is useful again, and to prevent trying to
3038 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3039 Show the wizard when New is clicked.
3041 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3042 (init_view): Show the column headers, and show the columns that are
3043 specified in the UI specs. However, something in Maemo's GTK+ prevents
3044 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3045 change the default account. This is despite unsetting the special properties.
3047 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3049 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3050 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3051 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3052 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3053 to make that clearer.
3054 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3056 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3058 * src/maemo/modest-account-view-window.c:
3059 (modest_account_view_window_init),
3060 (modest_account_view_window_new):
3061 Use the same buttons as specified in the
3062 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3063 the existing widgets, which never had a chance of working.
3064 Put the ModestAccountView treeview in a scrolled window.
3065 Do not repeat the initialization in both _init() and _new().
3067 * src/widgets/modest-account-view.c: (update_account_view):
3068 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3069 this widget and window shows no accounts.
3071 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3073 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3075 * src/maemo/easysetup/modest-easysetup-wizard.c:
3076 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3077 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3078 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3081 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3082 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3083 accounts exist yet, as in the UI spec.
3085 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3087 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3089 * src/maemo/Makefile.am:
3090 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3091 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3092 New window for editing connection-specific smtp details.
3093 Not fully implemented.
3095 * src/maemo/modest-connection-specific-smtp-window.c:
3096 (modest_connection_specific_smtp_window_finalize) :
3097 unref the tree model.
3098 (on_button_edit): Show the edit window.
3100 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3102 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3105 * src/maemo/Makefile.am:
3106 * src/maemo/modest-connection-specific-smtp-window.c:
3107 * src/maemo/modest-connection-specific-smtp-window.h:
3108 New window for showing the list of connections, for connection-specific
3109 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3110 * src/maemo/easysetup/modest-easysetup-wizard.c:
3111 (create_page_custom_outgoing): Show the new window when the button is clicked.
3113 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3115 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3116 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3117 * src/maemo/modest-msg-edit-window.c:
3118 (modest_msg_edit_window_insert_image):
3119 * src/modest-conf.c: (modest_conf_key_escape):
3120 * src/modest-mail-operation.c:
3121 (modest_mail_operation_send_new_mail):
3122 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3123 (modest_ui_actions_on_new_account):
3124 * src/widgets/modest-attachment-view.c: (update_filename_request):
3125 * src/widgets/modest-mail-header-view.c:
3126 Corrected warnings that were breaking the build, by commenting out unused variables,
3127 and a function, and by including a header.
3129 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3131 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3132 so we can #ifdef around platform-specific code when necessary.
3133 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3134 to allow this to build for the GNOME platform too.
3136 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3138 * src/maemo/easysetup/modest-easysetup-wizard.c:
3139 Added util_increment_name() and used it in create_page_account_details()
3140 to make sure that the default account name is always a new name.
3142 (modest_easysetup_wizard_dialog_init),
3143 (set_default_custom_servernames): Some minor memory management fixes.
3145 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3149 * src/modest-runtime.c: (init_i18n): Restored the translation
3150 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3151 are defined in config.h, and the translations are installed.
3153 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3154 is defined for translation.
3156 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3158 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3160 * src/maemo/easysetup/modest-easysetup-wizard.c:
3161 (modest_easysetup_wizard_dialog_init):
3162 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3163 Use realistic paths (though they should use $prefix generically) to the
3164 mcc_mapping and provider-data.keyfile files which might work when they
3165 are installed by the future version of the operator-wizard package,
3166 and then fallback to paths in our source code, with an explanatory
3169 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3173 * src/maemo/Makefile.am:
3174 * src/maemo/easysetup/: Added files from the previously-exernal
3175 osso-modest-easysetup.
3176 * src/maemo/modest-main-window-ui.h:
3177 * src/modest-ui-actions.c:
3178 * src/modest-ui-actions.h:
3179 Added modest_ui_actions_on_new_account() as a signal handler for the
3180 New Account menu item. It shows the easysetup wizard.
3181 * po/en_GB.po: Added additional needed logical IDs and translations.