1 2007-07-04 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
4 clue when this has failed, because the error dialog is not always shown
5 (at least in earlier version).
7 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
8 GError message, because the generic error dialog is not helpful.
10 'This message is not currently available (can't let a new connection go online)'
11 when trying to open an IMAP message.
13 (_modest_ui_actions_open): Offer a connection when some messages would
14 have to be downloaded and we are offline.
16 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
18 * src/widgets/modest-folder-view.c:
19 Don't check for MERGE type anymore as we use the correct type
21 NOTE: For the last two changes you need to update your tinymail copy
22 because of API changes!
24 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
26 * src/modest-tny-local-folders-account.c:
27 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
28 (see projects.maemo.org NB#61580)
30 2007-07-04 Murray Cumming <murrayc@murrayc.com>
32 * src/modest-tny-account.c: (on_connection_status_changed):
33 Commented out the call to modest_platform_connect_and_wait() because this
34 seems to always hang, and I would like to know if this is the only thing
35 that causes a hang when showing the connection dialog.
36 It is not very useful anyway.
38 2007-07-04 Murray Cumming <murrayc@murrayc.com>
40 * src/maemo/modest-msg-view-window.c:
41 (modest_msg_view_window_select_next_message):
43 * src/modest-platform.h:
44 * src/maemo/modest-platform.c:
45 Added modest_platform_connect_and_wait(), which calls
46 tny_maemo_conic_device_connect() always in the main thread, by calling it
47 in an idle handler and waiting for the idle handler to run. It should be
48 in the main thread because it uses GTK+ UI code. It just returns TRUE
49 if the device is already online.
51 There is some nasty code to ensure that subsequent calls to
52 modest_platform_connect_and_wait() just wait for the first one to finish,
53 by checking repeatedly in another idle handler. This is necessary,
54 because other threads (or even the main thread, via another idle handler)
55 can call modest_platform_connect_and_wait() while
56 modest_platform_connect_and_wait() is running.
58 (modest_platform_connect_and_wait_if_network_account),
59 (modest_platform_connect_and_wait_if_network_folderstore):
60 Convenience functions that calls modest_platform_connect_and_wait() if
61 the account or folder might want network access.
63 * src/modest-mail-operation.c:
64 (modest_mail_operation_update_account):
65 * src/modest-ui-actions.c: (download_uncached_messages),
66 (modest_ui_actions_on_rename_folder), (delete_folder),
67 (modest_ui_actions_on_main_window_move_to),
68 (modest_ui_actions_on_msg_view_window_move_to):
69 * src/widgets/modest-folder-view.c:
70 (drag_and_drop_from_folder_view):
71 Offer a connection if we are offline.
73 * src/modest-tny-account.c: (on_connection_status_changed):
74 Document this as only handling errors during network operations in progress,
75 and replace the idle code with a simple call to
76 modest_platform_connect_and_wait(), which does this instead.
78 2007-07-03 Murray Cumming <murrayc@murrayc.com>
80 * src/modest-tny-account.c:
81 (modest_tny_account_get_special_folder): (util_on_idle),
82 Handle the GError so we can see when tny_folder_store_get_folders()
83 fails, as it currently does while something else is connecting.
85 Added util_run_in_main_thread_and_wait()
86 which uses an idlen handler and mainloop to ensure that the function
87 is called in the main thread.
88 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
89 to make sure that we call attempt the connection in the mainloop only,
90 which might solve some hangs.
92 2007-07-03 Murray Cumming <murrayc@murrayc.com>
94 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
95 be found by their display name. This is never useful.
96 * src/modest-tny-account-store.c: (on_account_removed): Find the account
97 by its ID, instead of trying to use its ID as its display name.
99 * src/modest-tny-account-store.h:
100 * src/modest-tny-account.c:
101 (modest_tny_account_get_special_folder): Add a g_warning() when
102 tny_folder_store_get_folders() returns an empty list for the maildir.
104 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
105 Add a g_warning() when this returns NULL, because that it not allowed
108 2007-07-02 Armin Burgmeier <armin@openismus.com>
110 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
111 note when trying to cancel the wizard. This fixes projects.maemo.org
114 2007-07-02 Murray Cumming <murrayc@murrayc.com>
116 * src/modest-tny-account.h:
117 * src/modest-tny-account.c:
118 (modest_tny_account_new_from_server_account),
119 (modest_tny_account_new_from_server_account_name),
120 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
121 because this must now be set before setting the proto. This is usd in
122 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
123 warning in camel_session_get_service() caused by
124 tny_camel_transport_account_prepare().
126 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
129 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
131 * src/maemo/modest-connection-specific-smtp-edit-window.c:
133 (modest_connection_specific_smtp_edit_window_init):
135 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
138 2007-06-29 Murray Cumming <murrayc@murrayc.com>
140 * src/modest-tny-account.c:
141 (modest_tny_account_new_from_server_account):
142 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
143 now uses to request a connection when it needs one, and which it uses
144 to tell us that something is wrong with the connection, so we can force
145 the accounts offline to prevent further problems.
148 * src/modest-init.c: (init_default_settings):
149 * src/modest-mail-operation.c:
150 (modest_mail_operation_update_account):
151 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
152 This should not be necessary anymore. Do not set the conf key that
153 determined this (it was always TRUE and not set anywhere else).
155 * src/modest-ui-actions.h: Remove unused and unimplemented
156 modest_ui_actions_on_online_toggle_toggled().
158 2007-06-29 Murray Cumming <murrayc@murrayc.com
160 * src/maemo/modest-main-window.c: (connect_signals):
161 Don't connect to delete_event twice. Maybe this was harmless.
163 2007-06-29 Murray Cumming <murrayc@murrayc.com
165 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
166 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
167 Debug output to give some more clue when a folder move is not allowed.
169 2007-06-28 Murray Cumming <murrayc@murrayc.com
171 * src/modest-tny-account.c: (on_modest_file_system_info),
172 (modest_tny_account_get_mmc_account_name):
173 Always call the callback, without checking whether the name has changed.
174 * src/widgets/modest-folder-view.c: (strings_are_equal),
175 (on_model_foreach_set_name), (on_get_mmc_account_name),
176 (text_cell_data): Compare the name here, and use the name from
177 the account rather than from the
178 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
179 if the name was changed after the account was added to the model.
180 That's a tinymail bug but not one that I want to fix now.
182 This finally fixes projects.maemo.org bug NB#59301.
184 2007-06-27 Armin Burgmeier <armin@openismus.com>
186 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
189 2007-06-27 Murray Cumming <murrayc@murrayc.com
191 * src/modest-tny-account.h:
192 * src/modest-tny-account.c:
193 Added modest_tny_account_get_mmc_account_name(), to set the memory
194 card name asynchronously for the given account and then notify.
195 (modest_tny_account_new_for_local_folders): Use this new function instead
196 of using hildon_file_system_info_async_new() directly.
198 * src/widgets/modest-folder-view.c: (text_cell_data):
199 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
200 gtk_tree_model_row_changed() when it is available.
202 This should fix projects.maemo.org bug NB#59301.
204 2007-06-27 Murray Cumming <murrayc@murrayc.com
206 * src/modest-mail-operation.c: (update_account_thread),
207 (get_msgs_full_thread): Fix typo failures in the revert
210 2007-06-27 Murray Cumming <murrayc@murrayc.com
212 * src/maemo/modest-maemo-global-settings-dialog.c:
213 (idle_select_default_focus):
214 * src/modest-mail-operation.c: (idle_notify_progress),
215 (idle_notify_progress_once), (set_last_updated_idle),
216 (update_account_thread), (get_msgs_full_thread):
217 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
218 * src/widgets/modest-header-view.c:
219 (idle_notify_headers_count_changed_destroy),
220 (idle_notify_headers_count_changed):
221 Reverted the additions of gdk_threads_enter/leave(), in case this
222 helps with a startup hang on the device.
224 2007-06-26 Armin Burgmeier <armin@openismus.com>
226 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
227 for supported secure authentication methods from server by
228 gtk_dialog_run(), saving CPU time and a potential race condition.
230 2007-06-26 Armin Burgmeier <armin@openismus.com>
232 * src/maemo/modest-maemo-utils.h:
233 * src/maemo/modest-maemo-utils.c: Added a
234 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
235 only error code to tell the calling code when the user canceled the
238 * src/maemo/modest-account-settings-dialog.h:
239 * src/maemo/modest-account-settings-dialog.c:
240 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
241 message if the retrieval of secure authentication methods was canceled
242 by the user. Perform the check before saving anything to configuration
243 to not end up with half-committed configuration changes, do not show
244 a "Saving to configuration failed" note when authentication methods
245 could not be retrieved.
247 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
250 2007-06-26 Murray Cumming <murrayc@murrayc.com>
252 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
253 Only return the first level of folders under accounts, because the
254 osso-global-search UI spec doesn't want the rest.
255 This fixed projects.maemo.org bug NB#61811.
257 2007-06-26 Murray Cumming <murrayc@murrayc.com>
259 * src/modest-tny-account-store.c:
260 * src/modest-tny-account-store.h:
261 Added modest_tny_account_is_memory_card_account().
262 * src/maemo/modest-main-window.c: (create_details_widget):
263 Show the same information items for the memory card as we show for the
264 local-folders, to fix projects.maemo.org bug NB#59307.
266 2007-06-26 Murray Cumming <murrayc@murrayc.com>
268 * src/modest-tny-account-store.c: (get_password):
269 Added some checks for NULL to maybe prevent crashes, though I think
270 it was Philip's last commit that actually prevented the crash here
271 when creating a first new account.
272 But the new account is still not usable (no messages are shown)
273 until a restart of the application.
275 2007-06-26 Murray Cumming <murrayc@murrayc.com>
277 * src/maemo/modest-maemo-global-settings-dialog.c:
278 (idle_select_default_focus):
279 * src/modest-mail-operation.c: (idle_notify_progress),
280 (idle_notify_progress_once), (idle_notify_update_account_queue),
281 (set_last_updated_idle), (update_account_thread),
282 (notify_get_msgs_full), (get_msgs_full_destroyer),
283 (get_msgs_full_thread):
284 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
285 * src/widgets/modest-header-view.c:
286 (idle_notify_headers_count_changed_destroy),
287 (idle_notify_headers_count_changed):
288 Use gdk_threads_enter() and gdk_threads_enter_leave() in
289 all idle handlers, because some other thread could be blocking
290 the GDK lock, so that it can do GUI stuff.
292 2007-06-26 Murray Cumming <murrayc@murrayc.com>
294 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
295 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
296 (on_idle_send_receive), (on_idle_open_default_inbox):
297 * src/maemo/modest-msg-edit-window.c:
298 (modest_msg_edit_window_attach_file_noninteractive):
299 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
300 to prevent a hang. I don't quite understand why these are necessary,
301 beause we should already be in the main loop. I guess something outside
302 of the main loop is taking the lock.
304 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
305 we are really using URIs, and use files that are more likely to exist.
307 2007-06-26 Murray Cumming <murrayc@murrayc.com>
309 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
310 necessary because configure.ac now defines different variables.
312 2007-06-26 Murray Cumming <murrayc@murrayc.com>
314 * libmodest-dbus-client/libmodest-dbus-client.c:
315 * libmodest-dbus-client/libmodest-dbus-client.h:
316 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
317 libmodest_dbus_client_compose_mail() is what things actually use.
319 * src/dbus_api/modest-dbus-api.h:
320 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
321 * tests/dbus_api/Makefile.am:
322 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
325 2007-06-26 Murray Cumming <murrayc@murrayc.com>
327 * src/modest-init.c: (modest_init_local_folders):
328 For memory-card (or other non local-folders) maildir accounts,
329 always create an Archive folder, so that there is somewhere to put
330 messages. This should be less confusing, because the user does not need
331 to guess that the need to create a folder.
333 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
335 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
336 Fixed icon size by using (50, 50) which is the same as defined by
339 2007-06-25 Armin Burgmeier <armin@openismus.com>
341 * src/widgets/modest-window-mgr.c:
343 * configure.ac: Correctly recognize hildon-notify presence and fixed
344 the build without it being installed.
346 2007-06-25 Murray Cumming <murrayc@murrayc.com>
348 * libmodest-dbus-client/libmodest-dbus-client.c:
349 (libmodest_dbus_client_search): Fix the build. Sorry.
350 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
351 (reply_forward_cb): Initialize variables to fix the build.
353 * src/modest-tny-account-store.c:
354 (modest_tny_account_store_get_tny_account_by): Fix the account URI
355 comparison (a silly typo) so that email search results can be opened
356 when there are more than one account.
358 2007-06-25 Murray Cumming <murrayc@murrayc.com>
360 * libmodest-dbus-client/libmodest-dbus-client.c:
361 (libmodest_dbus_client_search),
362 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
363 instead of 1 second, because the search gets folders and messages from
364 the server, which can take a long time. When it times out,
365 osso-global-search will report no results.
367 We need to specify whether we should search only cached information
368 (maybe with a user preference), and the osso-email-search-plugin
369 API should really be improved to allow that option, and to allow results
370 to be delivered asynchronously in batches.
372 2007-06-25 Murray Cumming <murrayc@murrayc.com>
374 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
375 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
376 GTK_ICON_SIZE_DIALOG is probably the wrong size.
378 2007-06-25 Murray Cumming <murrayc@murrayc.com>
380 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
381 that is an empty string. D-Bus seems to give us these instead of NULL.
383 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
385 * src/dbus_api/modest-dbus-callbacks.c:
386 * src/maemo/easysetup/modest-easysetup-wizard.h:
387 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
388 * src/maemo/modest-connection-specific-smtp-edit-window.c:
389 (modest_connection_specific_smtp_edit_window_init):
390 * src/maemo/modest-maemo-global-settings-dialog.c:
392 * src/maemo/modest-maemo-utils.c:
393 (modest_maemo_utils_setup_images_filechooser):
394 * src/maemo/modest-main-window.c: (create_details_widget):
395 * src/maemo/modest-msg-edit-window.c:
396 (modest_msg_edit_window_attach_file_noninteractive),
397 (modest_msg_edit_window_color_button_change),
398 (modest_msg_edit_window_set_zoom):
399 * src/modest-mail-operation.c: (update_account_thread):
400 * src/modest-tny-account-store.c:
401 * src/modest-tny-account.c:
402 * src/widgets/modest-global-settings-dialog.c:
403 * src/widgets/modest-window.h:
407 2007-06-25 Murray Cumming <murrayc@murrayc.com>
409 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
410 * src/modest-search.c: (modest_search_folder),
411 (modest_search_all_accounts): Actually search only in the specified folder,
412 doing a simple match on the folder ID.
413 * src/modest-search.h: Added a folder field to the ModestSearch struct,
414 and added some documentation.
416 2007-06-22 Armin Burgmeier <armin@openismus.com>
418 * src/maemo/modest-maemo-utils.h:
419 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
420 modest_maemo_utils_get_supported_secure_authentication_methods.
422 * src/maemo/easysetup/modest-easysetup-wizard.c:
423 * src/maemo/modest-account-settings-dialog.c: Show correct error if
424 one occured, not just "Server does not support secure authentication".
426 2007-06-22 Murray Cumming <murrayc@murrayc.com>
428 * src/modest-tny-account-store.c: (get_password):
429 Restored the call to tny_account_set_user() because Philip seems to have
430 stopped this from crashing (by not using the freed string). It still does
431 not work, but now we can test it.
433 2007-06-22 Murray Cumming <murrayc@murrayc.com>
435 * src/maemo/modest-msg-edit-window.c: (init_window):
436 Comment out use of an uninitialzed GtkScrolledWindow variable,
437 to fix the build and stop a crash. Yet again.
439 2007-06-22 Murray Cumming <murrayc@murrayc.com>
441 * src/modest-tny-account-store.c: (get_password):
442 Remove the call to tny_account_set_user() because this actually crashes.
443 As mentioned in the last commit, it is known to not work anyway.
445 2007-06-22 Murray Cumming <murrayc@murrayc.com>
447 * src/modest-tny-account-store.c: (get_password):
448 Use tny_account_set_username() to tell tinymail that the username might
449 have changed too. But tinymail ignores this: see projects.maemo.org
451 * src/modest-ui-actions.c:
452 (modest_ui_actions_on_password_requested): Remove the useless attempt to
453 reset the connection when changing the username, and improve the comments.
454 Save the changed username to gconf at least, so it is used when Modest is
457 2007-06-21 Murray Cumming <murrayc@murrayc.com>
459 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
460 Do not use a query, so that we get all folders, including for POP and
461 local-folders. They work as search criteria too.
462 This fixes projects.maemo.org bug NB#57740.
464 2007-06-21 Murray Cumming <murrayc@murrayc.com>
466 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
467 Comment out the use of hildon_notification_set_sound() because it is
468 not declared, to fix the build. Warnings are serious, people.
470 2007-06-21 Armin Burgmeier <armin@openismus.com>
472 * src/maemo/modest-maemo-utils.h:
473 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
474 modest_maemo_utils_get_supported_secure_authentication_methods()
475 to query authentication methods for a specific user. This should fix
476 projects.maemo.org bug NB#61369.
478 * src/maemo/easysetup/modest-easysetup-wizard.c:
479 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
482 2007-06-21 Murray Cumming <murrayc@murrayc.com>
484 * libmodest-dbus-client/libmodest-dbus-client.h:
485 * libmodest-dbus-client/libmodest-dbus-client.c:
486 (modest_dbus_message_iter_get_search_hit),
487 (libmodest_dbus_client_search):
488 Reorganised and commented this.
489 Removed modest_search_hit_free() from the public API because it
492 Added libmodest_dbus_client_get_folders() and
493 modest_folder_result_list_free().
495 * src/dbus_api/modest-dbus-api.h:
496 * src/dbus_api/modest-dbus-callbacks.c:
497 (modest_dbus_req_filter): Commented. Moved most code to
498 on_dbus_method_search() and added on_dbus_method_get_folders().
500 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
501 of the extra D-Bus handler.
503 * tests/dbus_api/Makefile.am:
504 * tests/dbus_api/test_get_folders.c: New test for
505 libmodest_dbus_client_get_folders(). This seems to return an empty list
506 at the moment. That could be the same error that causes the message list
507 to be empty sometimes.
508 This should help with projects.maemo.org bug NB#57740.
510 2007-06-21 Armin Burgmeier <armin@openismus.com>
512 * src/modest-mail-operation.c: Do not call
513 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
514 notify the operation's end after having set the status to CANCELED for
515 the operation queue to listen on. This fixes a deadlock when there
516 were mail operations in the queue during its finalization.
518 * src/modest-singletons.c: Reordered uninitialization of the account
519 manager to happen after the mail operation queue was uninitialized
520 because the mail operation's in the queue might still try to access
521 the account manager (see modest_mail_operation_notify_end()). This
522 fixes a potential crash when terminating the application.
524 2007-06-21 Murray Cumming <murrayc@murrayc.com>
526 * src/modest-search.c:
527 (search_mime_part_and_child_parts): Moved some code here so we
528 can search recursively in child folders.
529 (modest_search_folder): Search in the message as a mime part, instead
530 of just its child mime parts.
531 (read_chunk), (search_mime_part_ogs):
532 Check how many bytes were read, to prevent an endless loop.
533 Searching in message bodies now works. This finishes the fix for
534 projects.maemo.org bug NB#61007.
536 2007-06-20 Murray Cumming <murrayc@murrayc.com>
538 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
539 Add a g_warning when the item is not a folder.
541 * src/modest-ui-dimming-rules.c:
542 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
543 when selected item is not a folder (for instance, an account), because
544 the UI spec only talks about folders.
545 I am not sure what the UI spec wants, so this might not totally fix
546 projects.maemo.org bug NB#60794.
548 2007-06-20 Murray Cumming <murrayc@murrayc.com>
550 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
551 (load_from_file): Sort the list. The unsorted list would be more noticeable
552 in non-English locales.
554 * src/maemo/modest-msg-edit-window.c:
555 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
556 warning and fix the build.
558 * src/maemo/modest-progress-bar-widget.c:
559 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
560 avoid a g_warning, and probably to avoid a crash.
562 2007-06-20 Murray Cumming <murrayc@murrayc.com>
564 * src/modest-search.c: (modest_search_folder): Check for a GError
565 when calling tny_folder_get_headers(), to show that this is not the cause
568 2007-06-20 Murray Cumming <murrayc@murrayc.com>
570 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
571 Actually set the body query instead of the subject query.
573 * src/modest-search.c: (search_mime_part_ogs),
574 (search_mime_part_strcmp): Remove extra space from the text/* regex,
575 which would probably cause it to fail if we got this far.
577 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
578 to simplify the code.
579 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
580 be causing search-in-body to fail.
582 2007-06-20 Murray Cumming <murrayc@murrayc.com>
584 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
586 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
587 Better debug message when the folder cannot be found.
588 This should help with fixing projects.maemo.org bug #61287.
589 * src/modest-search.c: (add_hit): Do not leak the furl string.
591 2007-06-20 Murray Cumming <murrayc@murrayc.com>
593 * src/modest-ui-actions.c:
594 (modest_ui_actions_on_folder_selection_changed):
595 Do not special-case TNY_MERGE_FOLDER here, because
596 modest_tny_folder_get_account() already does that. This fixes
597 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
598 shown when the Outbox was selected).
600 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
602 * libmodest-dbus-client/libmodest-dbus-client.c:
603 (_dbus_iter_get_string_or_null): Initialize the string variable in
604 case this helps with Dirk's crash.
606 2007-06-19 Murray Cumming <murrayc@murrayc.com>
608 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
609 though it is not implemented yet (this function is maybe not even used),
610 to avoid breaking ABI in future.
611 * libmodest-dbus-client/libmodest-dbus-client.c:
612 (get_attachments_string): Moved some code into this generic function.
613 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
614 sends email. It is maybe not used.
615 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
616 (on_send_mail): Use attachments.
618 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
619 * src/maemo/modest-msg-edit-window.c:
620 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
621 a filename before using it, to fix projects.maemo.org bug NB#58233.
623 2007-06-19 Murray Cumming <murrayc@murrayc.com>
625 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
626 Initialize the continue_download variable to fix the build, and probably
627 to fix randome behaviour.
629 2007-06-18 Armin Burgmeier <armin@openismus.com>
631 * src/modest-tny-send-queue.h:
632 * src/modest-tny-send-queue.c: Keep track of the status of messages in
633 the queue so we can later show it in the UI. Replaced
634 modest_tny_send_queue_msg_is_being_sent() by
635 modest_tny_send_queue_get_msg_status().
637 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
639 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
640 gpointer. This probably was not harmful, but just to be sure.
642 2007-06-18 Murray Cumming <murrayc@murrayc.com>
644 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
645 Fix the build, but leave the function broken on Bora, because
646 hildon_uri_action_get_service() does not exist.
647 osso_uri_action_get_service() does not exist either, it seems.
649 2007-06-18 Murray Cumming <murrayc@murrayc.com>
651 * src/modest-tny-account.c:
652 (modest_tny_account_new_from_server_account):
653 Uncommented the url debug output again, because it is useful for
654 debugging, as I said in the comment.
656 2007-06-18 Murray Cumming <murrayc@murrayc.com>
658 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
660 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
661 for Mameo Bora, to fix the build.
663 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
666 Fixed build with hildon < 0.99
668 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
669 Check if the selected account is busy instead of checking all accounts
671 * src/modest-account-mgr-priv.h:
672 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
673 (modest_account_mgr_init), (compare_account_name),
674 (modest_account_mgr_set_account_busy),
675 (modest_account_mgr_account_is_busy):
676 * src/modest-account-mgr.h:
677 Added busy information to the account manager. It possible to
678 set an account to busy or not busy now.
680 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
681 (modest_mail_operation_update_account),
682 (modest_mail_operation_notify_end):
683 Set the account to busy/not busy depending on the operation state.
685 * src/widgets/modest-account-view.c:
686 (modest_account_view_finalize), (get_last_updated_string),
687 (update_account_view), (on_account_busy_changed), (init_view):
688 Show string "Refreshing..." if the account is currently busy.
690 All this fixes projects.maemo.org bug NB#59711
692 2007-06-14 Armin Burgmeier <armin@openismus.com>
694 * src/widgets/modest-attachments-view.h:
695 * src/widgets/modest-attachments-view.c: Added
696 modest_attachments_view_has_attachments() and fixed coordinate
697 transformation in get_att_view_at_coords(). This fixes attachment
700 * src/widgets/modest-msg-view.c: Make use of
701 modest_attachments_view_has_attachments() to decide whether to show
702 attachments in the header.
704 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
706 * src/maemo/modest-connection-specific-smtp-edit-window.c:
707 (on_change), (on_combo_security_changed),
708 (modest_connection_specific_smtp_edit_window_init),
709 (modest_connection_specific_smtp_edit_window_set_connection),
710 (modest_connection_specific_smtp_edit_window_is_dirty):
711 * src/maemo/modest-connection-specific-smtp-edit-window.h:
712 * src/maemo/modest-connection-specific-smtp-window.c:
715 Show an comfirmation dialog for the smpt-edit-window if there are
716 unsaved changes and the user hits cancel.
717 (projects.maemo.org bug NB#60479)
719 2007-06-14 Armin Burgmeier <armin@openismus.com>
721 * src/maemo/easysetup/modest-easysetup-wizard.c:
722 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
723 address" info in banner instead of node, and select all the text as
724 per UI spec. This fixes projects.maemo.org bug NB#60550.
726 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
728 reviewed by: <delete if not using a buddy>
730 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
731 * src/modest-ui-actions.c: (folder_refreshed_cb):
733 2007-06-14 Murray Cumming <murrayc@murrayc.com>
735 * src/widgets/modest-folder-view.c: (filter_row):
736 Explictly filter out the per-account outbox accounts. I don't know why
737 these only sometimes show up, but now they should never show up in the UI.
738 This should fix projects.maemo.org bug NB#60160.
740 2007-06-14 Murray Cumming <murrayc@murrayc.com>
742 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
743 when the toolbar does not exist yet.
744 * src/modest-widget-memory.c: (save_settings_header_view):
745 Added g_warnings() to help us to discover when we are trying to set
746 an empty columns list in gconf.
748 2007-06-14 Murray Cumming <murrayc@murrayc.com>
752 Added modest_init_get_default_header_view_column_ids().
754 * src/modest-widget-memory.c: (restore_settings_header_view):
755 Use the new function to get defaults, if the gconf key is empty,
756 instead of not creating any columns. This seems to fix the
757 empty right-hand pane problems.
759 * src/widgets/modest-header-view.h: Improved documentation.
761 2007-06-13 Murray Cumming <murrayc@murrayc.com>
763 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
764 Revert the use of the display name as the account name, because this
765 is generally wrong and would break the code that follows.
767 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
769 * src/maemo/easysetup/modest-easysetup-wizard.c:
770 (check_for_supported_auth_methods), (on_before_next),
773 More correct fix for projects.maemo.org bug NB# 58991
774 Do not longer accept AUTH_PASSWORD as secure method and choose
775 correct method when creating the account.
777 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
779 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
780 Fixed projects.maemo.org bug NB# 58991
782 2007-06-13 Murray Cumming <murrayc@murrayc.com>
784 * src/modest-init.c: (modest_init_init_core),
785 (modest_init_local_folders): Fixed compilation errors.
787 2007-06-13 Murray Cumming <murrayc@murrayc.com>
789 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
790 Remove unnecessary lib/include, though it is good in principle when needed.
792 * src/modest-init.c: (modest_init_one_local_folder),
793 (modest_init_local_folders):
794 * src/modest-init.h: Initialize the .modest library for memory cards,
795 instead of just doing nothing for them. This should allow us to create
796 folders there, fixing projects.maemo.org bug NB#59297.
798 2007-06-13 Murray Cumming <murrayc@murrayc.com>
800 * libmodest-dbus-client/libmodest-dbus-client.c:
801 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
802 (libmodest_dbus_client_compose_mail),
803 (libmodest_dbus_client_open_message),
804 (libmodest_dbus_client_send_and_receive),
805 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
807 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
808 (on_idle_open_message), (modest_dbus_req_handler),
809 (search_result_to_message), (modest_dbus_req_filter):
810 * src/modest-search.c: (add_hit), (modest_search_folder),
811 (modest_search_all_accounts): Improved debug messages.
813 * tests/dbus_api/test_open_message.c: (main): Improved comments.
815 * src/modest-tny-account-store.c:
816 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
819 2007-06-13 Murray Cumming <murrayc@murrayc.com>
822 2007-06-12 Murray Cumming <murrayc@murrayc.com>
824 * src/modest-tny-account-store.c: (get_server_accounts):
825 Call modest_tny_local_folders_account_add_merged_outbox_folders()
826 even when there are no accounts, so that the Outbox folder is always
827 visible. This fixes projects.maemo.org bug NB#60158.
829 2007-06-12 Murray Cumming <murrayc@murrayc.com>
831 * src/maemo/modest-main-window.c: (create_details_widget):
832 Use the mcen_va_never logical ID.
834 2007-06-12 Murray Cumming <murrayc@murrayc.com>
836 * src/dbus_api/modest-dbus-api.h:
837 * src/dbus_api/modest-dbus-callbacks.c:
838 (on_idle_open_default_inbox), (on_open_default_inbox),
839 (modest_dbus_req_handler):
840 Added a new OpenDefaultInbox method.
842 * libmodest-dbus-client/libmodest-dbus-client.h:
843 * libmodest-dbus-client/libmodest-dbus-client.c:
844 Added libmodest_dbus_client_open_default_inbox() to call the new
845 dbus method. This should be useful to projects.maemo.org bug NB#57214,
846 though it should maybe be used by a new osso-email-interface function.
848 * tests/dbus_api/Makefile.am:
849 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
852 2007-06-12 Murray Cumming <murrayc@murrayc.com>
854 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
855 NULL, so that the signals get all the keys. This should not actually
856 change any behaviour because we currently update everything when anything
859 2007-06-12 Murray Cumming <murrayc@murrayc.com>
861 * src/widgets/modest-folder-view.c: (text_cell_data),
862 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
863 (find_inbox_iter): If tinymail tells us that the folder is
864 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
865 This causes the inbox to be selected at startup, fixing part of
866 projects.maemo.org bug NB#56305.
868 * src/modest-ui-dimming-rules.c:
869 (modest_ui_dimming_rules_on_tools_smtp_servers):
870 * src/modest-ui-dimming-rules.h: Added a callback function to dim
871 the SMTP servers menu item.
872 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
873 that the SMTP Servers menu item is dimmed when there are no accounts,
874 as a future version of the UI spec will require. This fixes
875 projects.maemo.org bug NB#56305.
877 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
879 * src/maemo/modest-maemo-utils.c:
880 (modest_maemo_utils_get_supported_secure_authentication_methods):
881 Added label to dialog instead of unreadable title
883 * src/maemo/modest-main-window.c: (sync_accounts_cb),
884 (modest_main_window_new):
885 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
888 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
889 * src/modest-account-mgr.h:
890 Added method to avoid code duplication
892 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
893 (modest_ui_actions_on_send_receive):
894 Use modest_account_mgr_has_accounts
896 2007-06-11 Murray Cumming <murrayc@murrayc.com>
898 * src/maemo/easysetup/modest-presets.c:
899 (modest_presets_get_info_server_security): Do not report secure auth
901 * src/modest-protocol-info.c: Use the defines for the gconf key names
902 for secure authentication. This was not working because we were writing
903 Password and reading password, and the check was case sensitive.
904 With this, gmail now works for receiving and sending when created via
907 2007-06-11 Murray Cumming <murrayc@murrayc.com>
909 * src/maemo/easysetup/modest-presets.c:
910 (modest_presets_get_info_server_security): Correct the key name for
911 SecureSmtp, because it seems to be case-sensitive.
912 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
913 Do not try to get the 0th notebook page if there are 0 pages, to
916 2007-06-11 Murray Cumming <murrayc@murrayc.com>
918 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
919 Prevent use of the new notification feature for now, because it currently
920 shows one dialog for each new email, which is annoying.
922 2007-06-11 Murray Cumming <murrayc@murrayc.com>
924 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
925 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
926 when no country was selected, so that we show the global ones.
927 * src/maemo/easysetup/modest-presets.c:
928 (modest_presets_get_providers): Return only the global providers, not
929 all providers when mmc=0 was requested.
931 2007-06-11 Murray Cumming <murrayc@murrayc.com>
933 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
934 (easysetup_provider_combo_box_fill): Remove debug code that showed the
935 provider ID in the combo.
937 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
938 Do not show the page numbers, because it would be confusing when we add
939 the 2 extra pages for the custom setup, when the user chooses the "Other"
940 provider. This fixes projects.maemo.org bug NB#59028
942 * src/modest-init.c: (modest_init_init_core),
943 (modest_init_local_folders):
945 * src/modest-tny-account.c:
946 (modest_tny_account_new_for_local_folders): Do not create default folders
947 for the memory card. This should fix projects.maemo.org bug NB#59328.
949 2007-06-11 Murray Cumming <murrayc@murrayc.com>
951 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
952 Free the changed_conf_keys string items. They are already freed in the
953 idle handler if that runs first.
955 2007-06-11 Murray Cumming <murrayc@murrayc.com>
957 * src/modest-ui-actions.c:
958 (modest_ui_actions_on_password_requested): Check that the server name
959 is not NULL, because I just saw a password dialog with (null) as the
962 * src/modest-tny-folder.[h|c]: Added
963 modest_tny_folder_is_memory_card_folder().
964 * src/modest-ui-dimming-rules.c:
965 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
966 menu item for memory cards, as per the UI spec (section 7.4). This should
967 fix projects.maemo.org bug NB#59297.
969 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
971 * src/maemo/modest-main-window.c: (sync_accounts_cb):
972 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
973 is another problem with the code, see Murray's comment at line 772)
975 2007-06-08 Murray Cumming <murrayc@murrayc.com>
977 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
978 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
979 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
980 (load_from_file), (easysetup_country_combo_box_init),
981 (easysetup_country_combo_box_get_active_country_ids),
982 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
983 instead of just one ID, to avoid duplicate country names in the UI.
985 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
986 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
987 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
988 a single ID, avoiding duplicate providers.
989 * src/maemo/easysetup/modest-easysetup-wizard.c:
990 (on_combo_account_country): Adapt to use a list.
992 2007-06-08 Murray Cumming <murrayc@murrayc.com>
994 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
995 keys changed in the last X seconds.
997 * src/modest-account-mgr.h:
998 * src/modest-account-mgr.c: (on_timeout_notify_changes),
999 (on_key_change), (modest_account_mgr_class_init),
1000 (modest_account_mgr_init), (modest_account_mgr_finalize):
1001 As the keys are changed, save them in a GSList* and signal that GSList*
1002 further every X seconds, to batch changes, to allow us to do just one
1003 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1004 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1006 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1007 changed signal signature.
1009 * src/modest-conf.c: (modest_conf_set_list),
1010 (modest_conf_on_change): Reenable notification.
1012 (modest_conf_maemo_fake_on_change): Comment out the hack that
1013 notified immediately instead of asynchronously.
1015 * src/widgets/modest-account-view.h:
1016 * src/widgets/modest-account-view.c:
1017 (update_account_view): Select the previously-selected account ID,
1018 if possible. This fixes projects.maemo.org bug NB#56933.
1020 (on_account_changed), (on_account_removed),
1021 (modest_account_view_select_account):
1023 Remove the block/unblock functions
1024 because they were not useful.
1026 * src/maemo/modest-account-view-window.c:
1027 (on_delete_button_clicked), (on_edit_button_clicked),
1028 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1030 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1032 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1033 Improve the error dialog to show Incorrect Account Settings, which seems
1034 clearer, and say that the internal error message (to be removed from the
1035 dialog later) is often misleading.
1036 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1038 * src/modest-tny-account.c:
1039 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1040 URL because this is so useful for debugging on the device.
1042 * src/widgets/modest-serversecurity-combo-box.c:
1043 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1045 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1047 * src/modest-mail-operation.c:
1048 (modest_mail_operation_send_new_mail):
1049 Added a comment about a nasty but apparently harmless message. Details
1050 added to the wiki g_warnings() page.
1052 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1054 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1055 (modest_tny_send_queue_class_init):
1056 Do not use the priv struct because it is empty, to avoid g_warnings
1057 about a non-existant priv struct.
1059 * src/modest-tny-account-store.c:
1060 (modest_tny_account_store_get_server_account),
1061 (modest_tny_account_store_get_transport_account_for_open_connection
1062 ): Do not try to get transport server accounts for local folders,
1063 because they don't have any. This avoids a g_warning().
1065 * src/maemo/modest-main-window.c:
1066 (modest_main_window_notify_send_receive_initied),
1067 (on_configuration_key_changed):
1068 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1069 * src/modest-defs.h:
1070 * src/modest-mail-operation.c:
1071 (modest_mail_operation_update_account):
1072 * src/modest-tny-account-store.h:
1073 * src/modest-tny-account.c:
1074 (modest_tny_account_get_special_folder),
1075 (modest_tny_account_new_for_local_folders),
1076 (modest_tny_account_new_for_per_account_local_outbox_folder):
1077 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1078 * src/modest-tny-local-folders-account.c:
1079 (add_account_folders_to_merged_folder):
1080 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1081 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1082 (modest_ui_actions_on_send):
1083 * src/widgets/modest-folder-view.c: (update_model):
1084 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1085 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1086 modest_tny_account_store_get_tny_account_by_account() to
1087 modest_tny_account_store_get_server_account() to make the code clearer.
1089 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1091 * src/dbus_api/modest-dbus-api.h:
1092 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1093 * src/maemo/modest-msg-edit-window.c:
1094 (modest_msg_edit_window_attach_file_noninteractive):
1095 added g_warning in case the file to be attached does not exist
1096 * tests/dbus_api/test_compose_mail.c: (main):
1097 removed obsolete comment, added generic files as test case
1099 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1101 * src/modest-tny-account-store.c: (get_server_accounts):
1102 Create the local folders account only once, not once for each outbox, and
1103 not only when there are some outboxes.
1105 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1107 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1108 code that is causing a crash at startup. Sergio says that he is fixing this.
1110 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1112 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1113 * src/maemo/modest-account-settings-dialog.c:
1114 (create_page_outgoing),
1115 (modest_account_settings_dialog_set_account_name),
1116 (save_configuration):
1117 - Fixed handling of the "Use secure authentication" toggle to comply with
1118 the ui specification. See also projects.maemo.org bug NB#58400
1120 - Restore the Secure connection setting combo correctly when loading
1123 * src/maemo/modest-maemo-utils.c:
1124 (on_camel_account_get_supported_secure_authentication),
1125 (modest_maemo_utils_get_supported_secure_authentication_methods):
1126 Fixed a crasher if operation is canceled
1128 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1129 (modest_protocol_info_auth_is_secure):
1130 * src/modest-protocol-info.h:
1132 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1133 the sense of the "Use secure authentication" toggle.
1135 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1137 * src/modest-tny-account-store.h:
1138 * src/modest-tny-account-store.c:
1139 Added modest_tny_account_store_get_local_folders_account().
1141 * src/modest-tny-folder.h:
1142 * src/modest-tny-folder.c:
1143 (modest_tny_folder_get_account):
1144 Added this replacement for tny_folder_get_account() which returns
1145 the local-folders account for TnyMergeFolders, to avoid the
1146 warning about the unimplemented get_account_func() vfunc().
1148 (modest_tny_folder_get_rules),
1149 * src/modest-ui-actions.c:
1150 (modest_ui_actions_on_folder_selection_changed):
1151 * src/modest-mail-operation.c:
1152 (modest_mail_operation_remove_folder),
1153 (modest_mail_operation_xfer_folder),
1154 (modest_mail_operation_rename_folder),
1155 (modest_mail_operation_get_msg),
1156 (modest_mail_operation_get_msgs_full),
1157 (modest_mail_operation_remove_msg),
1158 (modest_mail_operation_xfer_msgs),
1159 (modest_mail_operation_refresh_folder):
1160 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1162 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1164 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1165 (modest_server_account_set_security):
1166 * src/modest-defs.h: Add comments explaining that our
1167 UI spec means TLS when it says Normal, so these do not look like errors.
1169 * src/modest-tny-account.c:
1170 (modest_tny_account_new_from_server_account): Use the new tinymail
1171 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1172 for TLS. This should fix projects.maemo.org bug NB#58460.
1174 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1176 * src/maemo/easysetup/modest-easysetup-wizard.c:
1177 (create_account): Correct the position of the gconf sanity check warning.
1178 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1179 of using the g_idle_add() hack, because this does not seem to be necessary
1180 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1181 caused by something other than maemo's gconf.
1182 This fixes projects.maemo.org bug #59022.
1184 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1186 * src/modest-account-mgr-helpers.c:
1187 (modest_account_mgr_get_default_account): Do not check that the account
1188 exists if there is no default account (NULL), to fix a runtime warning.
1190 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1192 * src/widgets/modest-folder-view.c: (update_model):
1193 Do not unref the treemodel before we have finished with it.
1194 This prevents a valgrind warning and an occasional crash at startup.
1196 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1198 * libmodest-dbus-client/libmodest-dbus-client.h:
1199 added libmodest_dbus_client_compose_mail()
1200 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1202 added functions needed for SendAsMail() functionality
1203 * src/maemo/modest-msg-edit-window.c:
1204 (modest_msg_edit_window_attach_file_noninteractive):
1205 non interactively attaching files to message edit window
1206 * src/widgets/modest-msg-edit-window.h:
1207 * tests/dbus_api/Makefile.am:
1208 added test_compose_mail.c
1209 * tests/dbus_api/test_compose_mail.c: (main):
1211 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1213 * src/modest-account-view.c:
1214 Fixed bug projects.maemo.org bug NB#59307
1216 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1218 * src/maemo/easysetup/modest-easysetup-wizard.c:
1219 (get_serverport_incoming), (on_before_next), (create_account):
1220 * src/maemo/modest-account-settings-dialog.c:
1221 (modest_account_settings_dialog_set_account_name):
1222 * src/maemo/modest-maemo-utils.c:
1223 (on_camel_account_get_supported_secure_authentication_status),
1224 (on_camel_account_get_supported_secure_authentication),
1225 (on_secure_auth_cancel),
1226 (modest_maemo_utils_get_supported_secure_authentication_methods):
1228 Implemented security authentication for settings and easysetup.
1230 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1232 * src/maemo/modest-main-window.c: (create_details_widget):
1233 Show the total size for memory card accounts too, instead of showing
1234 the name again. Fixes bug projects.maemo.org bug NB#59307.
1236 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1239 * src/modest-tny-simple-folder-store.c:
1240 * src/modest-tny-simple-folder-store.h: Removed.
1242 * src/modest-tny-local-folders-account.h
1243 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1244 for the local-folders maildir, with an extra TnyMergedFolder containing
1245 the folders of the per-account outbox store accounts.
1246 * src/modest-tny-account-store.c: (get_server_accounts):
1247 Add the outboxes to the special local folders account after creating it.
1249 * src/modest-tny-account.c:
1250 (modest_tny_account_new_for_local_folders): Create the derived
1251 account when creating the main local-folders account.
1253 * src/maemo/modest-main-window.c: (create_details_widget),
1254 (modest_main_window_set_contents_style):
1255 Adapted to the use of the derived account instead of the folder store.
1257 * src/modest-ui-actions.c:
1258 (modest_ui_actions_on_folder_selection_changed):
1259 * src/modest-ui-dimming-rules.c:
1260 (modest_ui_dimming_rules_on_new_folder):
1261 * src/widgets/modest-folder-view.c: (text_cell_data),
1262 (icon_cell_data), (filter_row), (update_model),
1263 (get_cmp_rows_type_pos):
1266 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1267 Do not get the priv struct, because no priv struct has been set,
1268 to avoid a runtime warning.
1270 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1271 #ifelse with #else, to fix a warning, to fix the build.
1274 2007-06-05 Christian Kellner <ckellner@openismus.com>
1276 * libmodest-dbus-client/libmodest-dbus-client.c:
1277 Fix small typo in doc (why do you always see them
1278 AFTER committing stuff?)
1281 2007-06-05 Christian Kellner <ckellner@openismus.com>
1283 * libmodest-dbus-client/libmodest-dbus-client.c:
1284 (libmodest_dbus_client_search):
1285 Initialize hit list with NULL. Also set folder list
1286 to "" if NULL was supplied.
1289 2007-06-03 Christian Kellner <ckellner@openismus.com>
1291 * libmodest-dbus-client/libmodest-dbus-client.c:
1292 (modest_search_hit_list_free):
1293 Make it save to call it with NULL.
1295 * src/dbus_api/modest-dbus-callbacks.c:
1296 * src/modest-search.c:
1297 Return full ModestSearchHits as the search result list not TnyHeader
1298 since can't be around withouth the correspoding TnyFolder.
1300 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1302 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1303 Added currently commented code to check for secure auth
1305 * src/maemo/modest-account-settings-dialog.c: (on_response),
1306 (save_configuration), (show_ok):
1307 Fixed projects.maemo.org bugs NB #59248 and #59251
1309 * src/maemo/modest-maemo-utils.c:
1310 (on_camel_account_get_supported_secure_authentication_status),
1311 (on_camel_account_get_supported_secure_authentication),
1312 (modest_maemo_utils_get_supported_secure_authentication_methods):
1313 * src/maemo/modest-maemo-utils.h:
1314 Moved get_supported_secure_authentication() method here to be able
1315 to use it from easysetup wizard.
1317 * src/modest-pair.c: (on_pair_compare_as_string):
1318 Should compare string with first part of pair and not
1319 strcmp pairs which will crash.
1321 * src/modest-protocol-info.c:
1322 (modest_protocol_info_protocol_is_store):
1323 * src/modest-protocol-info.h:
1324 Added modest_protocol_info_get_auth_protocol_name()
1326 2007-06-03 Armin Burgmeier <armin@openismus.com>
1328 * src/modest-mail-operation.c:
1329 (modest_mail_operation_get_msgs_full): Set priv->account also when
1330 only retrieving a single message. This avoids a crash when canceling
1333 (modest_mail_operation_notify_end): Do not explicitely remove the
1334 operation from the queue but only emit the progress_changed signal.
1335 The queue itself listens to that signal to remove the operation when
1336 it is finished. This reduces coupling and removes a potential deadlock
1337 when modest_mail_operation_notify_end() is called from the queue
1338 itself. If that is a problem performance-wise, I would suggest to
1339 implement a status-changed signal or something.
1341 * src/modest-mail-operation-queue.c: Make sure to never call a
1342 function from another file while the queue is locked. This (hopefully)
1343 fixes another deadlock when exiting the application while retrieving
1346 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1348 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1349 Fixed build if libogs is not available
1351 2007-06-03 Christian Kellner <ckellner@openismus.com>
1353 * libmodest-dbus-client/libmodest-dbus-client.h:
1354 * libmodest-dbus-client/libmodest-dbus-client.c:
1355 (libmodest_dbus_client_delete_message):
1356 Implement deletion of messages (Client side).
1358 (modest_search_hit_free),
1359 (modest_search_hit_list_free):
1360 Utility functions to free the result hits.
1362 * src/dbus_api/modest-dbus-api.h:
1363 * src/dbus_api/modest-dbus-callbacks.c:
1364 (on_delete_message),
1365 (modest_dbus_req_handler):
1366 Implement deletion of messages (Server side).
1368 * tests/dbus_api/test_search.c: (main):
1371 * tests/dbus_api/Makefile.am:
1372 * tests/dbus_api/test_delete_message:
1373 Add little test for the message deletion logic
1375 2007-06-03 Armin Burgmeier <armin@openismus.com>
1377 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1378 when the operation queue was not empty. projects.maemo.org bug
1381 2007-06-03 Armin Burgmeier <armin@openismus.com>
1383 * src/widgets/modest-account-view.c
1384 (on_account_default_toggled): Toggle default account column
1385 explicitely instead of waiting for gconf notification (which is
1386 currently ignored). This should fix projects.maemo.org bug NB#56910
1387 for now. It should probably be removed when gconf notifications are
1390 2007-06-03 Christian Kellner <ckellner@openismus.com>
1392 * libmodest-dbus-client/libmodest-dbus-client.c:
1393 Removed debugging spew.
1395 * src/dbus_api/modest-dbus-callbacks.c:
1396 Added debugging info.
1398 * src/modest-search.c:
1399 (modest_search_all_accounts):
1400 Use tny_account_store_get_accounts () on the account store
1401 to get all accounts which is the way to get all accounts.
1403 * tests/dbus_api/test_search.c: (main):
1404 Make it possible to supply the search term on the command line.
1406 2007-06-03 Christian Kellner <ckellner@openismus.com>
1408 * libmodest-dbus-client/libmodest-dbus-client.c:
1409 * libmodest-dbus-client/libmodest-dbus-client.h:
1410 Implement searching for mesages over raw dbus. (Client side)
1412 * src/dbus_api/Makefile.am:
1413 * src/dbus_api/modest-dbus-api.h:
1414 * src/dbus_api/modest-dbus-callbacks.c:
1415 * src/dbus_api/modest-dbus-callbacks.h:
1416 Search framework (Server side). Also implement on_idle_open_message().
1418 * src/maemo/modest-platform.c: (modest_platform_init):
1419 Prepare for raw dbus/osso rpc interaction.
1421 * src/modest-search.h:
1422 Changed minsize from unspecific guint to guint32.
1424 * src/modest-search.c:
1426 Added strange hack which magically made tnymail work.
1428 (modest_search_folder),
1429 (modest_search_account),
1430 (modest_search_all_accounts):
1431 Implement helper functions to search all accounts, specific account
1434 * tests/dbus_api/Makefile.am:
1435 * tests/dbus_api/test_open_message.c:
1436 Read url to open from commandline.
1438 * tests/dbus_api/test_search.c:
1439 Implement small test for dbus search stuff
1441 2007-06-02 Armin Burgmeier <armin@openismus.com>
1443 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1444 include account type and account title. This fixes projects.maemo.org
1447 * src/maemo/modest-account-view-window.c: Set a title for the window.
1449 2007-06-02 Armin Burgmeier <armin@openismus.com>
1451 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1452 incoming and outgoing server name based on email address and server
1453 types as long as the names have not been edited manually. This fixes
1454 projects.maemo.org bug NB#58671.
1456 2007-06-02 Armin Burgmeier <armin@openismus.com>
1458 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1459 server type cannot be changed in future to the incoming details page
1460 when creating an account. This fixes projects.maemo.org bug NB#59029.
1462 2007-06-02 Armin Burgmeier <armin@openismus.com>
1464 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1465 and assigned max width chars so that they wrap instead of being
1466 truncated. Fixes projects.maemo.org bug NB#56126.
1468 2007-06-02 Armin Burgmeier <armin@openismus.com>
1470 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1471 introductory note to the connection specific smtp servers dialog, as
1472 section 8.12 of the email UI specification requires. This fixes
1473 projects.maemo.org bug NB#59212.
1475 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1477 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1478 Check for running mail operations, and offer to cancel them, as per the UI
1479 spec. This fixes projects.maemo.org bug NB#59041 .
1480 However, I suspect that tinymail may still use the network connection
1481 in ways that we cannot detect or cancel. But it should at least adapt to
1482 changes fairly well.
1484 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1486 * src/modest-tny-account-store.c: (recreate_all_accounts),
1487 (get_cached_accounts), (get_server_accounts): Do more sensible
1488 ref-counting of the temporarily-cached outbox accounts list. This seems
1489 to fix a crash when entering the password when the password was wrong.
1491 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1493 * src/gnome/modest-main-window.c: (connect_signals):
1494 * src/modest-tny-account-store.c: (get_password),
1495 (modest_tny_account_store_alert): Added comments and clues and
1496 commented-out code about how we currently fail to deal with connection
1497 errors and wrong passwords, and how we should.
1499 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1501 * src/widgets/modest-retrieve-combo-box.c:
1502 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1503 This fixes projects.maemo.org bug NB#58472 .
1505 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1507 * src/maemo/easysetup/modest-easysetup-wizard.c:
1508 (create_page_complete_easysetup):
1509 (create_page_complete_custom): Correct the last commit,
1510 putting the correct sentences in the correct pages.
1512 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1514 * src/maemo/easysetup/modest-easysetup-wizard.c:
1515 (create_page_complete_custom): Show the second sentence of text
1516 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1519 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1521 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1522 Set the leave-on-server conf key by default. This fixes
1523 projects.maemo.org bug NB#59258 .
1525 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1527 * src/maemo/modest-account-view-window.c:
1528 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1529 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1532 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1534 * src/maemo/easysetup/modest-easysetup-wizard.c:
1535 (create_caption_new_with_asterisk):
1536 * src/maemo/modest-account-settings-dialog.c:
1537 (create_caption_new_with_asterisk):
1538 Uncomment the code to add the asterisk, because they are no longer in the
1539 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1540 (update_incoming_server_title): Add an asterisk here too.
1542 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1544 * src/maemo/modest-maemo-global-settings-dialog.c:
1545 (current_connection): Check that we are even connected before trying to
1546 get the current connection name, to prevent a warning.
1548 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1549 Change the comments because tny_maemo_conic_device_connect() is now meant to
1551 * src/modest-mail-operation.c:
1552 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1553 make sure we have a connection and fail if we can't connect.
1555 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1557 * src/maemo/modest-main-window.c:
1558 (on_account_store_connecting_finished): Do not try to get the
1559 connection ID if we are not really connected. I am surprised that
1560 this signal handler is called when we are not connected.
1562 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1564 * src/modest-error.h:
1565 * src/modest-ui-actions.c:
1566 (modest_ui_actions_get_msgs_full_error_handler):
1567 Renamed an enum, added comments, added an enum
1568 for retrieve-limit errors.
1570 * src/modest-mail-operation.c: (foreach_add_item),
1571 (internal_folder_observer_update), (update_account_thread),
1572 (modest_mail_operation_get_msgs_full):
1573 (modest_mail_operation_update_account),
1574 Added comments about how this works, and some code that should
1575 (but does not) check the retrieve-limit. See the TODO comment.
1577 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1579 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1580 Initialize help_id to fix the build. Warnings are good.
1582 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1584 * src/widgets/modest-hbox-cell-renderer.c:
1585 (modest_hbox_cell_renderer_append):
1586 * src/widgets/modest-vbox-cell-renderer.c:
1587 (modest_vbox_cell_renderer_append):
1588 Fix the last commit by doing an extra ref.
1590 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1592 * src/widgets/modest-hbox-cell-renderer.c:
1593 (modest_hbox_cell_renderer_append):
1594 * src/widgets/modest-vbox-cell-renderer.c:
1595 (modest_vbox_cell_renderer_append):
1596 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1597 to fix the build with Maemo Bora.
1598 However, there seems to be a remaining crash, probably due to reference
1601 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1603 * src/modest-tny-account.c:
1604 (modest_tny_account_new_for_local_folders):
1605 Use hildon_file_system_info_async_new() to get a better name for
1606 the memory card account, setting it as the account name.
1607 The timing seems to work, but this is probably
1608 not the best place to do this. See the TODO comment.
1609 * src/maemo/modest-main-window.c: (create_details_widget):
1610 * src/widgets/modest-folder-view.c: (text_cell_data):
1611 Use the tny account name instead of hardcoding a name.
1613 2007-05-30 Christian Kellner <ckellner@openismus.com>
1615 * src/modest-search.c: (modest_search):
1616 Correctly set part_search_func even if we have already parsed
1617 the query and thus a valid OgsTextSearcher object.
1619 2007-05-30 Christian Kellner <ckellner@openismus.com>
1622 Search and check for libogs.
1625 Incooparte the ogs build env.
1627 * src/modest-mime-part-search-stream.c:
1628 * src/modest-mime-part-search-stream.h:
1629 Removed since we do the real searching now in modest-search.c.
1631 * src/modest-search.c:
1632 * src/modest-search.h:
1633 Implement support for ogs. We use that if available and requested
1634 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1635 should now handle the corner case when the search term is spread
1636 across multiple reads.
1637 Also the logic in modest_search () was corrected to search all
1638 requested fields until one is found.
1640 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1642 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1644 * src/modest-init.h:
1645 * src/modest-init.c: Made modest_init_local_folders() take a
1646 path and be public so we can iniitialize maildir folders on
1649 * src/modest-local-folder-info.h:
1650 * src/modest-local-folder-info.c:
1651 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1653 * src/modest-tny-account.c:
1654 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1655 still means the standard local-folders path on the local volume.
1657 * src/modest-tny-account-store.c:
1658 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1659 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1660 all accounts when that happens.
1661 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1662 this too, so it shows up in the treeview.
1664 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1666 * src/maemo/modest-maemo-global-settings-dialog.c:
1667 (current_connection):
1668 * src/widgets/modest-global-settings-dialog.c:
1669 (current_connection_default):
1670 Use the enum values instead of 0, 1 and -1,
1671 to make the code clearer.
1673 * src/modest-account-mgr-helpers.c:
1674 (modest_account_mgr_get_connection_specific_smtp): Make this code
1677 * src/modest-runtime.h:
1678 * src/modest-runtime.c:
1679 Added modest_runtime_remove_all_send_queues().
1680 * src/maemo/modest-main-window.c:
1681 (on_account_store_connecting_finished): Recreate the send queues,
1682 using the appropriate transport accounts for this new connection.
1683 Some futher adapting might be needed if the old send queues are not
1684 automatically stopped at this point.
1686 * src/modest-tny-account-store.c: (get_server_accounts):
1687 Create the connection-specific transport accounts, so that they can
1688 be found later by their ID.
1690 * src/modest-tny-account.h:
1691 * src/modest-tny-account.c:
1692 Added modest_tny_account_new_from_server_account_name().
1693 modest_tny_account_new_from_server_account(): Do not create the
1694 send queues here, because they will be
1695 recreated anyway when the connection changes for the first time.
1697 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1699 * src/modest-local-folder-info.h:
1700 * src/modest-local-folder-info.c:
1701 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1702 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1703 tbox_folder): Take a modest account name instead of a server TnyAccount,
1704 so we can have per-modest-account rather than per-transport-account
1706 We must make sure that we change or recreate the exisitng send queues
1707 when the connection changes for connection-specific transport accounts.
1709 * src/modest-tny-account-store.c:
1710 (create_per_account_local_outbox_folders): Create outboxed per modest
1711 account, not per transport account.
1713 * src/modest-tny-account.h:
1714 * src/modest-tny-account.c:
1715 (modest_tny_account_get_special_folder): For outboxes, get the
1716 parent modest account name. The account is ignored for other folders.
1717 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1718 modest account name rather than a server TnyAccount.
1720 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1722 * src/modest-tny-account.c:
1723 (modest_tny_account_new_from_server_account):
1724 Call modest_runtime_get_send_queue() immediately after creating transport
1725 accounts, so that they start trying to send email from the outbox as soon
1726 as possible at startup. This is probably what we want.
1728 * src/modest-mail-operation.c: (update_account_thread):
1729 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1730 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1731 * src/modest-tny-send-queue.h:
1732 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1733 (modest_ui_actions_on_send):
1734 Added comments about how sending works, though it needs some more work.
1736 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1738 * src/modest-tny-account.c:
1739 (modest_tny_account_get_special_folder): Add TODO because this fails when
1740 the network is busy.
1741 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1742 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1743 Do not try to show this window when there is no active account. The UI
1744 specs does not tell us what to do in this case.
1746 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1750 * src/maemo/Makefile.am:
1751 * src/widgets/Makefile.am: Some dist fixes.
1753 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1755 * src/maemo/modest-connection-specific-smtp-window.c:
1756 (on_button_edit): Make the code clearer, to prevent a double free.
1758 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1760 * src/maemo/modest-account-settings-dialog.c:
1761 (modest_account_settings_dialog_set_account_name),
1762 Check the connection-specific smtp servers checkbox if there are any.
1764 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1765 (modest_connection_specific_smtp_edit_window_init):
1766 Start with a suitable port number.
1768 * src/modest-account-mgr-helpers.h:
1769 * src/modest-account-mgr-helpers.c: Added
1770 modest_account_mgr_get_has_connection_specific_smtp().
1772 (modest_account_mgr_set_connection_specific_smtp),
1773 (modest_account_mgr_remove_connection_specific_smtp),
1774 (modest_account_mgr_get_has_connection_specific_smtp),
1775 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1776 connection-specific smtp server accounts in the account, rather than
1777 the server account conf dir.
1779 This fixes bug projects.maemo.org bug NB#58263 .
1781 * src/modest-tny-account-store.c:
1782 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1783 if there are no server accounts yet, to prevent an infinite loop when there
1784 are no accounts. Document that one must be called before the other.
1786 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1788 * src/modest-account-mgr-helpers.c:
1789 (modest_account_mgr_get_default_account): Make sure that at least
1790 one account is always the default, if there are any enabled accounts.
1791 This is just a sanity check that shouldn't be necessary.
1793 * src/modest-account-mgr-priv.c:
1794 (_modest_account_mgr_account_from_key): Unescape the conf key to
1795 get the real account name. For instance, this is an issue if a space
1796 was in the account name, which can happen because the account name
1797 is generated from the display name.
1798 (_modest_account_mgr_get_account_keyname): Always escape the
1800 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1801 Unescape the conf keys to get the real account names.
1803 For instance, previously the is-default radio button in the accounts
1804 list was not checked for any accounts at first. This fixes that,
1805 and might fix several similar bugs.
1807 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1809 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1810 Removed some debug printfs.
1812 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1814 Modest on-disk outbox directories are now here, for instance:
1815 $HOME/.modest/outboxes/<account-id-1>/outbox
1816 $HOME/.modest/outboxes/<account-id-2>/outbox
1818 $HOME/.modest/local-folders/outbox
1819 so we can have a separate outbox for each account.
1820 But they are shown as one outbox in the GtkTreeView, by using a
1821 TnyMergeFolder in a ModestTnySimpleFolderStore.
1824 * src/modest-tny-simple-folder-store.c:
1825 * src/modest-tny-simple-folder-store.h:
1826 Added ModestTnySimpleFolderStore, used to contain folders from
1827 other folder stores, such as other accounts.
1829 * src/modest-tny-outbox-account.h:
1830 * src/modest-tny-outbox-account.c:
1831 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1832 used for the per-account local outbox folders.
1834 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1835 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1836 only use this (internally) now for the non-outbox local folders.
1838 * src/modest-init.h:
1839 * src/modest-init.c: Added modest_init_one_local_folder(), for
1840 setting up the directory structure for each local folder.
1842 * src/modest-local-folder-info.c:
1843 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1844 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1846 * src/modest-local-folder-info.h:
1847 * src/modest-tny-account-store.c: (on_account_removed),
1848 (on_account_changed), (create_per_account_local_outbox_folders),
1849 (get_server_accounts), (modest_tny_account_store_get_accounts),
1850 (modest_tny_account_store_get_tny_account_by_account),
1851 (modest_tny_folder_store_is_virtual_local_folders):
1853 * src/modest-tny-account.h:
1854 * src/modest-tny-account.c:
1855 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1856 to create an on-disk per-account local outbox folder for each
1858 (create_per_account_local_outbox_folders): Create a local outbox folder
1859 for each transport account.
1860 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1861 for all local folders.
1863 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1864 instead of using g_object_get/set() directly. It is clearer.
1866 (modest_tny_folder_store_get_message_count),
1867 (modest_tny_folder_store_get_local_size
1868 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1869 because we now use these with non-acount folder stores.
1871 (modest_tny_account_get_special_folder),
1872 (modest_tny_account_new_from_server_account),
1873 (modest_tny_account_new_from_account):
1874 (recurse_folders): Adjust to the new outbox system.
1876 * src/modest-tny-folder.h:
1877 * src/modest-tny-folder.c:
1878 (modest_tny_folder_is_local_folder),
1879 (modest_tny_folder_get_local_folder_type),
1880 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1882 * src/widgets/modest-main-window.h:
1883 * src/maemo/modest-main-window.c: (create_details_widget),
1884 (modest_main_window_set_contents_style): Show details for any folder store,
1887 (modest_tny_folder_get_rules):
1888 Remove the const. C does not support constness enough for this.
1890 * src/modest-ui-actions.c:
1891 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1892 make all outboxes appear as one, in the usual local-folders tree node.
1894 (set_active_account_from_tny_account),
1895 (modest_ui_actions_on_folder_selection_changed):
1896 * src/widgets/modest-folder-view.c: (text_cell_data),
1897 (icon_cell_data), (filter_row),
1898 (add_account_folders_to_merged_folder),
1899 (add_account_folders_to_simple_folder_store), (),
1900 (get_cmp_rows_type_pos), (cmp_rows),
1901 (modest_folder_view_set_account_id_of_visible_server_account):
1902 Adjust to the new outbox system, using generic folder stores and folders
1903 in the GtkTreeModel.
1905 2007-05-23 Christian Kellner <ckellner@openismus.com>
1907 * src/modest-mail-operation.c:
1908 (modest_mail_operation_update_account):
1909 Use info->max_size instead of unintialized local var [small
1910 build fix]. (Added TODO to review that change since I don't
1913 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1915 * libmodest-dbus-client/libmodest-dbus-client.c:
1916 (libmodest_dbus_client_compose_mail): function added
1917 * src/dbus_api/modest-dbus-api.h:
1918 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1919 (on_compose_mail): Implementation of the SendAsMail functionality
1921 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1923 * src/modest-account-mgr.c:
1924 (modest_account_mgr_add_server_account): Set the secure-connection
1925 conf key for transport accounts as well as store accounts. I don't know
1926 why the if was there. For instance, this makes sure that we use SSL
1927 for the gmail preset from the easysetup wizard.
1929 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1931 * src/gnome/modest-main-window.c:
1932 (on_account_store_connecting_finished), (connect_signals):
1933 * src/maemo/modest-main-window.c:
1934 (on_account_store_connecting_finished), (connect_signals),
1935 (modest_main_window_new):
1936 Handle TnyAccountStore::connecting-finished instead of
1937 TnyDevice::connection-changed, because we cannot actually perform
1938 operations on accounts until TnyAccountStore has itself responded to
1939 the TnyDevice::connection-changed signal. This prevents a GError from
1941 Do not try to update at startup, because we (at least on scratchbox)
1942 already do an update at startup when the device goes online.
1943 This prevents a GError from tinymail.
1944 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1945 Added TODO about stopping simultaneous operations.
1947 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1949 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1950 * src/modest-mail-operation-queue.c:
1951 (modest_mail_operation_queue_remove):
1952 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1953 about where they happened.
1955 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1957 * src/modest-ui-actions.c:
1958 (modest_ui_actions_on_password_requested): Make sure that the remember
1959 output parameter is always TRUE.
1961 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1963 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1964 Show a OK/Cancel dialog if the error is a question, though we still do not
1965 know anything more about what we are asking the user.
1966 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1967 Fix an uninitialized variable (helper). This is a logic error, however.
1969 2007-05-21 Christian Kellner <ckellner@openismus.com>
1971 * src/modest-search.h:
1972 Correct bit shifting in the ModestSearchFlags enum.
1974 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1976 * src/modest-tny-account.c:
1977 (modest_tny_account_new_from_server_account): Do not use the lsub and
1978 check-all hard-coded IMAP options when using POP.
1980 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1982 * src/modest-tny-account.c:
1983 (modest_tny_account_new_from_server_account):
1984 Use NULL for the secure-auth method for POP when Password auth has been
1985 specified by the user, as we already do for IMAP. "auth=Login" causes
1986 an error from camel or the server.
1988 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1990 * src/maemo/modest-account-settings-dialog.c:
1991 (create_page_account_details),
1992 (modest_account_settings_dialog_set_account_name):
1993 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1994 for the leave-on-server checkbox, rathr than just the checkbox, when
1995 the protocol is not POP.
1997 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1999 * src/widgets/modest-account-view.c:
2000 * src/widgets/modest-account-view.h:
2001 Added modest_account_view_select_account() which will be useful later
2002 to asynchronously re-select the edited account.
2004 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2006 * src/maemo/modest-account-settings-dialog.c:
2007 (modest_account_settings_dialog_set_account_name):
2008 Automatically choose the port numbers based on the secure authentication
2009 methods, if they have not been chosen before.
2010 This fixes projects.maemo.org bug NB#56273 .
2012 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2014 * src/maemo/modest-main-window-ui.h:
2015 * src/modest-ui-actions.c:
2016 * src/modest-ui-actions.h:
2017 Connect the Tools/SMTP Servers menu item to
2018 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2019 SMTP servers dialog, as in the UI specification and saves changes when it
2020 is closed. This fixed projects.maemo.org bug NB#56305 .
2022 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2024 * src/maemo/modest-connection-specific-smtp-window.c:
2025 (modest_connection_specific_smtp_window_init):
2026 Use gtk_window_set_default_size() to make this window big enough, so
2027 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2029 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2031 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2032 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2033 (modest_connection_specific_smtp_edit_window_init),
2034 Do not try to connect to a combobox signal before the combobox exists.
2035 This fixes the cras in projects.maemo.org bug NB#56288 .
2036 (modest_connection_specific_smtp_edit_window_get_settings):
2037 Remove the server_account_name parameter which was being checked for NULL
2038 though it was not used.
2040 * src/maemo/modest-connection-specific-smtp-window.c:
2041 (modest_connection_specific_smtp_window_fill_with_connections),
2042 (on_button_edit), (modest_connection_specific_smtp_window_init):
2043 Correct the number of treemodel columns to prevent a warning.
2044 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2045 libconic does not work.
2047 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2049 * src/modest-tny-account.c:
2050 (modest_tny_account_new_from_server_account):
2051 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2052 SMTP when "None" was chosen by the user. However, with my SMTP server that
2053 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2056 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2058 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2059 to explain the memory management issue with the ID in the ModestPair.
2061 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2062 (add_sending_page), (modest_account_assistant_finalize):
2063 * src/gnome/modest-gnome-global-settings-dialog.c:
2064 (create_updating_page), (create_composing_page):
2065 * src/gnome/modest-msg-edit-window.c: (get_transports),
2066 (init_window), (modest_msg_edit_window_finalize),
2067 (modest_msg_edit_window_get_msg_data):
2068 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2069 * src/gnome/modest-transport-widget.c:
2070 (modest_transport_widget_finalize), (smtp_configuration):
2071 * src/maemo/modest-maemo-global-settings-dialog.c:
2072 (create_updating_page), (create_composing_page):
2073 * src/maemo/modest-msg-edit-window.c: (get_transports),
2074 (init_window), (modest_msg_edit_window_finalize),
2075 (modest_msg_edit_window_get_msg_data),
2076 (modest_msg_edit_window_free_msg_data):
2077 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2078 (modest_store_widget_finalize):
2079 * src/maemo/modest-transport-widget.c:
2080 (modest_transport_widget_finalize), (smtp_configuration):
2081 * src/modest-main.c: (send_mail):
2082 * src/widgets/modest-combo-box.h:
2083 * src/widgets/modest-global-settings-dialog-priv.h:
2084 * src/widgets/modest-global-settings-dialog.c:
2085 (modest_global_settings_dialog_finalize):
2086 * src/widgets/modest-msg-edit-window.h:
2087 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2088 as long as the combo box, to prevent use of freed memory for the ID.
2090 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2092 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2093 get_accounts(), to make this clearer. Do not check for the enabled gconf
2094 key, because we do not use this for server accounts (at least, not yet).
2095 This allows us to send email again.
2097 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2099 * src/maemo/modest-platform.c:
2100 (on_modest_conf_update_interval_changed), (modest_platform_init):
2101 Only respond to this particular key change. All these strcmp()s cannot be
2104 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2106 * src/maemo/modest-maemo-global-settings-dialog.c:
2107 (current_connection): Prevent a crash in scratchbox when
2108 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2109 * src/maemo/modest-platform.c:
2110 (on_modest_conf_update_interval_changed), (modest_platform_init):
2111 Get the update interval from gconf and reset it when the gconf key changes.
2113 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2115 * src/modest-protocol-info.c:
2116 * src/modest-protocol-info.h: Adde enum-specific get functions,
2117 instead of using a ModestProtocolType enum parameter.
2119 * src/gnome/modest-account-assistant.c:
2120 * src/gnome/modest-store-widget.c:
2121 * src/gnome/modest-store-widget.h:
2122 * src/gnome/modest-transport-widget.c:
2123 * src/gnome/modest-transport-widget.h:
2124 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2125 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2126 * src/maemo/easysetup/modest-easysetup-wizard.c:
2127 * src/maemo/modest-account-settings-dialog.c:
2128 * src/maemo/modest-account-settings-dialog.h:
2129 * src/maemo/modest-store-widget.c:
2130 * src/maemo/modest-store-widget.h:
2131 * src/maemo/modest-transport-widget.c:
2132 * src/maemo/modest-transport-widget.h:
2133 * src/modest-account-mgr-helpers.c:
2134 * src/modest-account-mgr-helpers.h:
2135 * src/modest-account-mgr.c:
2136 * src/modest-account-mgr.h:
2137 * src/modest-tny-account.c:
2138 * src/modest-tny-folder.c:
2139 * src/widgets/modest-account-view.c:
2140 * src/widgets/modest-retrieve-combo-box.c:
2141 * src/widgets/modest-retrieve-combo-box.h:
2142 * src/widgets/modest-secureauth-combo-box.c:
2143 * src/widgets/modest-serversecurity-combo-box.c:
2144 * src/widgets/modest-serversecurity-combo-box.h:
2145 * tests/check_account-mgr.c:
2146 Use the specific functions, and use the re-renamed enum values for GNOME too.
2148 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2150 * src/modest-pair.h:
2151 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2152 so we can get the second based on the first.
2154 * src/maemo/modest-account-settings-dialog.h:
2155 * src/maemo/modest-account-settings-dialog.c:
2156 Added get_supported_secure_authentication_methods(), though it is mostly
2157 commented-out for now until the necessary API is committed to tinymail.
2158 (modest_account_settings_dialog_set_account_name),
2159 (save_configuration): Request the supported authentication methods from the
2160 server, so we can choose a working method.
2162 * src/modest-tny-account-store.h:
2163 * src/modest-tny-account-store.c:
2164 (modest_tny_account_store_get_session): Rename from
2165 tny_account_store_get_session().
2167 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2169 * src/modest-protocol-info.h: Split the ModestProtocol enum
2170 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2171 There was no need to have these unrelated values in one enum.
2173 * src/: many files: Adapted to changed enum. This makes the code a bit
2174 clearer, and the compiler could catch some errors.
2176 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2178 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2179 Show the detailed internal camel error message when an error happens
2180 during the configuration, so that our testers can give us more clues.
2181 For instance, in projects.maemo.org bug NB#56910 .
2183 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2185 * src/modest-tny-account.c:
2186 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2187 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2189 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2191 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2192 * src/maemo/modest-account-settings-dialog.c:
2193 (modest_account_settings_dialog_set_account_name),
2194 (save_configuration): For the incoming secure authentication checkbox,
2195 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2196 the UI specification. PLAIN does not seem to be supported for most IMAP
2197 servers anyway, and I am not sure what it would mean.
2198 However, we probably need to discover which of the secure-authentication
2199 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2200 * src/modest-account-mgr-helpers.c:
2201 (modest_account_mgr_get_server_account_data):
2203 * src/modest-tny-account.c:
2204 (modest_tny_account_new_from_server_account):
2205 Use tny_account_set_mech() to set secure-authentication methods,
2206 with some special-casing for IMAP, based on my observations of how
2209 * src/modest-account-mgr-helpers.h:
2210 * src/modest-account-mgr.c:
2211 * src/modest-defs.h: Comment that the URI is only used for local folders.
2213 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2215 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2216 parameter const, just to be neat.
2217 * src/modest-text-utils.c: (modest_text_utils_inline):
2218 End g_strconcat() with NULL, as its documentation says. This is almost
2219 certainly the cause of my crash at startup on the device. Interestingly,
2220 valgrind doesn't tell us about these errors.
2222 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2224 * scripts/build-packages: Added more precise comments about how to use
2225 this script, though I still get this error:
2226 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2227 error building tinymail
2229 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2231 * src/maemo/modest-main-window.c: (on_account_update):
2232 Very slight cleanup, hoping to make it simpler to discover what causes
2233 a crash here sometimes.
2235 * src/modest-tny-account.c:
2236 (modest_tny_account_new_from_server_account): Set the port. Added
2237 comments about the options and a TODO comment because I need to find out
2238 how to specify the secure authentication method.
2240 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2242 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2243 changed CFlags paths form modest to libmodest
2245 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2247 * src/modest-account-mgr-helpers.c:
2248 (modest_account_mgr_get_server_account_data),
2249 (modest_account_mgr_free_server_account_data):
2250 * src/modest-account-mgr-helpers.h:
2251 * src/modest-account-mgr.c:
2252 (modest_account_mgr_add_server_account):
2253 * src/modest-defs.h:
2254 * src/modest-tny-account.c:
2255 (modest_tny_account_new_from_server_account):
2256 Determine the options for tny_camel_account_add_option() here,
2257 based on the settings, rather than storing them directly in gconf.
2259 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2261 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2262 Show a more friendly error dialog now that we expect (from the tinymail
2263 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2265 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2267 * src/maemo/modest-main-window.c: (on_account_update): Check that
2268 account_name is not NULL, to prevent a crash at startup that I am
2269 seeing on the N800. I do wonder why it is NULL.
2271 * src/maemo/easysetup/modest-easysetup-wizard.c:
2272 (create_page_user_details):
2273 * src/maemo/modest-account-settings-dialog.c:
2274 (create_page_user_details), (create_page_outgoing):
2275 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2276 (modest_connection_specific_smtp_edit_window_init):
2277 * src/modest-ui-actions.c:
2278 (modest_ui_actions_on_password_requested):
2279 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2280 might do something useful with the on-screen keyboard.
2282 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2284 * src/maemo/modest-main-window.c: (on_account_update):
2285 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2286 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2288 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2290 * src/modest-tny-account-store.c: (on_account_changed):
2291 Correct the signature of this signal handler.
2293 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2295 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2296 Show a HildonNote instead of a GtkDialog for Maemo.
2298 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2300 * src/widgets/modest-account-view.h:
2301 * src/widgets/modest-account-view.c: (on_account_changed),
2302 (on_account_removed). Added a boolean flag, set/unset by
2303 modest_account_view_block_conf_updates(),
2304 modest_account_view_unblock_conf_updates() to prevent unnecessary
2305 updates, but this is not very useful because the gconf notifications are
2306 so delays (maybe only on Maemo Bora).
2307 So auto-updating is turned off, and these functions do an explicit
2308 update when necessary.
2309 However, something else is still doing too much work when adding/removing
2310 accounts, probably in another part of the application.
2312 * src/maemo/modest-account-view-window.c:
2313 (on_delete_button_clicked), (on_edit_button_clicked),
2314 (on_new_button_clicked): Use the new functions.
2316 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2318 * src/modest-account-mgr-helpers.c:
2319 (modest_account_mgr_set_first_account_as_default):
2320 Sort the list of names alphabetically-by-title, so we choose the first one
2322 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2323 alphabetically by the title.
2325 This fixes projects.maemo.org bug NB#56418 .
2327 * src/modest-account-mgr-priv.c:
2328 (_modest_account_mgr_account_from_key):
2329 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2330 avoid a valgrind error, and possible random behaviour.
2332 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2334 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2335 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2336 tinymail documentation to say that this can be expected.
2337 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2338 pretty, and should not happen, but I would prefer to know when it does.
2340 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2342 * configure.ac: When using the older hildon version, probably on Bora,
2343 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2345 * src/widgets/modest-attachment-view.c:
2346 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2349 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2351 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2352 Implemented the prototype. Can be tested with
2353 tests/dbus_api/test_open_message:
2355 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2357 * src/modest-tny-account-store.c:
2358 (modest_tny_account_store_instance_init), (get_password):
2359 * src/modest-ui-actions.c:
2360 (modest_ui_actions_on_password_requested):
2361 Do not store the password in gconf, because this function is called
2362 for non-remembered passwords. Actually use the cached (in the hash map)
2363 password instead of releasing it.
2364 The password will now not be remembered if it is asked via the protected
2365 password dialog, as per the UI spec.
2367 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2369 * src/modest-defs.h:
2370 * src/modest-account-mgr-helpers.h:
2371 * src/modest-account-mgr-helpers.c:
2372 Added modest_server_account_get_username_has_succeeded(),
2373 modest_server_account_set_username_has_succeeded().
2374 (modest_server_account_set_username),
2375 Reset the has-succeeded flag if the username changes.
2377 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2378 * src/maemo/modest-connection-specific-smtp-window.c:
2379 (modest_connection_specific_smtp_window_save_server_accounts):
2380 Use modest_server_account_set_username() instead of using
2381 modest_conf_set_string() directly, so that the has-succeeded flag is always
2384 * src/modest-ui-actions.c:
2385 (modest_ui_actions_on_password_requested): Dim the username entry if
2386 the username has ever worked, as per the UI spec.
2388 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2390 * src/modest-tny-account-store.c: (get_password):
2391 * src/modest-ui-actions.c:
2392 (modest_ui_actions_on_password_requested):
2393 Allow the username to be changed too, though there is more work to
2394 be done on exactly how this behaves.
2396 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2398 * src/modest-account-mgr-helpers.h:
2399 * src/modest-account-mgr-helpers.c:
2400 Added modest_account_mgr_get_display_name(),
2401 modest_server_account_get_username(),
2402 modest_server_account_set_username(),
2403 modest_server_account_set_password(),
2404 modest_server_account_get_hostname() functions so we do not need to
2405 use the conf API directly.
2407 * src/maemo/modest-main-window.c: (connect_signals):
2408 Actually connect ot the ModestAccountStore::request-password signal,
2409 so that we show the dialog when the password is requested by Tinymail,
2410 for isntance if it is empty.
2412 * src/modest-marshal.list:
2413 * src/modest-tny-account-store.c:
2414 (modest_tny_account_store_class_init), (get_password),
2415 (modest_tny_account_store_alert):
2416 * src/modest-tny-account-store.h:
2417 * src/modest-ui-actions.h:
2418 * src/modest-ui-actions.c:
2419 (modest_ui_actions_on_password_requested):
2420 Change the signal parameters, so it is obvious that we are providing
2421 the non human-readable server name, and receiving both the username
2422 and password, though changing of the username is not yet implemented.
2423 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2424 for the GNOME version.
2426 This should fix the projects.maemo.org bug NB#56209, though it does not
2427 work on Bora, because the gconf_client_get() for the password fails
2428 immediately after we save it with gconf_client_set().
2430 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2433 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2434 caused an undefined symbol error:
2435 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2437 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2439 * src/modest-tny-account-store.c:
2440 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2441 using a GError instead of a string message, so we can translate it in
2444 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2446 * src/maemo/modest-address-book.c:
2447 (modest_address_book_check_names):
2448 * src/maemo/modest-msg-view-window.c:
2449 (modest_msg_view_window_clipboard_owner_change):
2450 * src/modest-init.c: (modest_init_init_ui):
2451 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2452 (update_folders_cb), (modest_mail_operation_update_account):
2453 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2454 (modest_ui_actions_on_msg_attachment_clicked),
2455 (modest_ui_actions_on_msg_recpt_activated):
2456 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2457 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2458 (modest_msg_view_search_next):
2459 * src/widgets/modest-recpt-editor.c:
2460 (modest_recpt_editor_on_button_release_event),
2461 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2462 g_message(). At this point we should only be seeing interesting errors on
2463 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2465 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2467 (modest_wizard_dialog_force_title_update):
2468 * src/maemo/easysetup/modest-wizard-dialog.h:
2469 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2470 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2471 can update the title when appropriate. Otherwise the title is wrong if the
2472 pages are added after adding the notebook to the dialog.
2473 This must be a problem in HildonWizardDialog too.
2474 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2476 * src/maemo/easysetup/modest-easysetup-wizard.c:
2477 (create_subsequent_customsetup_pages),
2478 (create_subsequent_easysetup_pages):
2479 Call modest_wizard_dialog_force_title_update() so that the title is
2480 correct even with GTK+ < 2.10.
2481 This fixes projects.maemo.org bug NB#56145 .
2483 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2485 * src/maemo/modest-platform.c:
2486 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2487 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2490 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2492 * src/widgets/modest-window.h:
2493 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2494 and modest_window_save_state(), which invokes it.
2496 * src/widgets/modest-window-mgr.h:
2497 * src/widgets/modest-window-mgr.c:
2498 Added modest_window_mgr_save_state_for_all_windows(), which calls
2499 the save_state vfunc on all registered windows, if implemented.
2501 * src/gnome/modest-msg-edit-window.c:
2502 * src/gnome/modest-msg-view-window.c:
2503 * src/maemo/modest-msg-edit-window.c:
2504 * src/maemo/modest-msg-view-window.c:
2505 * src/maemo/modest-main-window.c:
2506 Specify the existing save_settings functions as implementations of
2507 ModestWindow::save_state_func().
2509 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2510 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2511 enabling hibernation, for instance.
2513 We may need to do the same thing for restoring settings.
2516 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2518 * src/widgets/modest-window-mgr.c:
2519 * src/widgets/modest-window-mgr.h:
2520 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2521 modest_window_mgr_get_hibernation_is_prevented().
2523 * src/maemo/modest-main-window.c:
2524 (on_hildon_program_is_topmost_notify): Prevent hibernation
2525 (possible when the application goes to the background in the WM),
2526 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2528 * src/maemo/easysetup/modest-easysetup-wizard.c:
2529 (modest_easysetup_wizard_dialog_init):
2530 * src/maemo/modest-account-settings-dialog.c:
2531 (modest_account_settings_dialog_init):
2532 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2533 (modest_connection_specific_smtp_edit_window_init):
2534 * src/maemo/modest-connection-specific-smtp-window.c:
2535 (modest_connection_specific_smtp_window_init):
2536 * src/maemo/modest-signature-editor-dialog.c:
2537 (modest_signature_editor_dialog_init):
2538 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2539 prevent hibernation while any of these account settings dialogs are open.
2541 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2543 * src/maemo/Makefile.am:
2544 * src/maemo/modest-osso-state-saving.c:
2545 * src/maemo/modest-osso-state-saving.h: Added
2546 modest_osso_load_state() and modest_osso_save_state() though they do
2547 nothing now. They should iterate through all the open windows and load/save
2549 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2550 save state when closing.
2552 * src/maemo/modest-main-window.c:
2553 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2554 Add a notification handler for the HildonProgram::is-topmost property,
2555 so we can allow hibernation when the application goes into the background.
2556 But we still need to detect when the accounts setup windows are open so
2557 we can stop hibernation when they are open.
2558 To do this, I also added the main window the HildonProgram. This might have
2559 other side-effects/benefits, and should maybe be done for other windows.
2561 * src/maemo/modest-osso-autosave-callbacks.h:
2562 * src/maemo/modest-osso-autosave-callbacks.c:
2563 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2564 though it does not do anything yet, and we might never need this to do
2565 anything. For instance, we already save drafts.
2567 * src/maemo/modest-platform.c: (modest_platform_init):
2568 Specify the libosso auto-save callback.
2570 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2572 * src/maemo/modest-platform.c:
2573 (modest_platform_set_update_interval):
2574 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2575 aparently stays valid between application instances, so we can use this
2576 to remove and reset it later. According to a maemo-developers email from
2579 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2581 * configure.ac: Depend on libalarm for Maemo.
2583 * src/dbus_api/modest-dbus-api.h:
2584 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2585 (on_send_receive), (modest_dbus_req_handler):
2586 Handle a SEND_RECEIVE D-Bus method.
2588 * libmodest-dbus-client/libmodest-dbus-client.c:
2589 (libmodest_dbus_client_send_and_receive):
2590 * libmodest-dbus-client/libmodest-dbus-client.h:
2591 Add C convenience functions for calling the new D-Bus method.
2593 * src/modest-platform.h:
2594 * src/gnome/modest-platform.c:
2595 * src/maemo/modest-platform.c:
2596 Added modest_platform_set_update_interval(), which uses the
2597 alarmd API on Maemo.
2598 (modest_platform_init),
2599 Call modest_platform_set_update_interval(), using a hard-coded
2600 interval for now (until the global settings dialog is implemented),
2601 though I am not sure that this makes sense yet.
2603 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2605 * src/dbus_api/modest-dbus-callbacks.c:
2606 (modest_osso_cb_hw_state_handler):
2607 * src/dbus_api/modest-dbus-callbacks.h:
2608 * src/maemo/modest-platform.c: (modest_platform_init):
2609 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2610 in case this has some effect on the ability for Maemo to ping the
2613 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2615 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2616 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2617 warning. It is probably a logic error, but I need to fix the build.
2619 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2621 * src/modest-account-mgr.h:
2622 * src/modest-account-mgr.c:
2623 (modest_account_mgr_account_names): Add a gboolean enabled_only
2624 parameter, so we can get lists of onlt the enabled accounts.
2626 (modest_account_mgr_add_account),,
2627 (modest_account_mgr_account_with_display_name_exists):
2628 * src/maemo/modest-msg-edit-window.c: (get_transports):
2629 * src/modest-account-mgr-helpers.c:
2630 (modest_account_mgr_set_first_account_as_default):
2631 * src/modest-init.c: (init_default_account_maybe):
2632 * src/modest-tny-account-store.c: (get_accounts):
2633 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2634 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2635 * tests/check_account-mgr.c: (START_TEST):
2636 Provide the extra parameter, as appropriate.
2638 * src/widgets/modest-account-view.c: (update_account_view):
2639 Do not show disabled accounts (meaning that there is no way to
2640 enable/disable accounts in the UI (the feature is not in our UI
2641 specification), so we can use this internally only to mark unfinished
2642 or temporary account data.
2644 * src/maemo/easysetup/modest-easysetup-wizard.c:
2645 (create_account): Add boolean enable parameter, so we can specify FALSE
2646 to create the temporary account.
2647 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2648 (on_before_next): When finishing, when there is a temporary account, just
2650 Also, use a timeout to delay the showing of the dialog until gconf is likely
2651 to return correct information, due to a maemo gconf bug that is fixed in
2652 osso 1.1, but not yet in Bora.
2653 However, the dialog stays on screen after it is destroyed.
2655 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2656 for invalid data when cancelling. Use a hildon note instead of a dialog
2657 to complain about invalid data. Do not show the account-saved note if the
2658 account is disabled (a temporary account that will not really be saved for use
2661 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2663 * src/modest-account-mgr-helpers.h:
2664 * src/modest-account-mgr-helpers.c:
2665 Added modest_account_mgr_unset_default_account(),
2666 Added modest_account_mgr_set_first_account_as_default().
2668 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2669 If it was the default account, unset the default account name.
2671 * src/maemo/modest-account-view-window.c:
2672 (on_delete_button_clicked): If it was the default account,
2673 set the first remaining account as the default instead.
2675 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2676 a NULL account or a NULL default account, to prevent a crash. This should
2677 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2680 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2682 * src/widgets/modest-recpt-editor.c:
2683 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2684 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2685 TODO comment for this. This fixes the build.
2687 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2688 be the best place for it. This will in future update all auto-update accounts,
2689 rather than just the current/default account, when that gconf key exists.
2690 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2691 if there are no accounts, before calling do_send_receive().
2692 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2694 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2695 * src/maemo/modest-main-window-ui.h:
2696 * src/maemo/modest-main-window.c: (on_connection_changed),
2697 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2698 directly, becaue the signal handler does more.
2700 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2702 * src/modest-account-mgr-helpers.c:
2703 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2704 for the case that the account does not exist.
2706 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2707 (equivalent to the modest account name) rather than the tinymail account name
2708 (equivalent to the modest account title - human readable) to get the account data.
2709 Check for null account data to prevent the crash, and add a TODO comment saying that
2710 this needs fixing because it is using the server account name instead of the account name.
2712 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2714 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2715 * src/maemo/modest-account-settings-dialog.c: (show_error),
2717 Use hildon_note_new_information() for informative and error messages,
2718 which seems to be expected for Maemo applications (no documentation that I know of
2719 says this). I am surprised that there is no distinction between info and error
2722 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2724 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2725 it is easy to find where this is used.
2727 * src/maemo/easysetup/modest-easysetup-wizard.c:
2728 (create_page_welcome), (create_page_account_details),
2729 (create_page_user_details), (create_page_complete_easysetup),
2730 (create_page_custom_incoming), (create_page_custom_outgoing),
2731 (create_page_complete_custom):
2732 * src/maemo/modest-account-settings-dialog.c:
2733 (create_page_account_details), (create_page_user_details),
2734 (create_page_incoming), (create_page_outgoing):
2735 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2736 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2737 (modest_connection_specific_smtp_edit_window_init):
2738 * src/maemo/modest-connection-specific-smtp-window.c:
2739 (modest_connection_specific_smtp_window_init):
2740 * src/maemo/modest-signature-editor-dialog.c:
2741 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2742 and scrolling policy as per the Email Application Layout Guide, if I have
2745 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2747 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2748 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2749 which were empty, because these vfuncs have been removed from TnyAccountStore.
2750 This fixes the build.
2752 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2754 * src/maemo/modest-main-window.c:
2755 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2756 showing/hiding it. Added TODO because it probably should not be NULL.
2757 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2758 because unnecessary g_warnings() make degugging difficult.
2760 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2762 * src/maemo/modest-msg-edit-window.c:
2763 (modest_msg_edit_window_select_color),
2764 (modest_msg_edit_window_select_background_color): 2 const corrections and
2765 moving 2 #endifs before closing brackets, to fix the build.
2767 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2769 * src/maemo/easysetup/modest-easysetup-wizard.h:
2770 * src/maemo/easysetup/modest-easysetup-wizard.c:
2771 (modest_easysetup_wizard_dialog_finalize),
2772 (on_button_edit_advanced_settings), (create_page_complete_custom),
2773 (on_response), (create_account):
2774 Implement the Advanced Settings edit button, by saving the account information,
2775 for the Advanded Settings dialog to use directly from gconf, and removing it
2776 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2777 Bug #5533 in the projects.maemo.org bugzilla.
2779 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2781 * src/maemo/modest-msg-view-window.c:
2782 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2783 when opening a message window.
2785 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2787 * src/maemo/easysetup/modest-easysetup-wizard.c:
2788 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2791 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2792 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2793 gconf settings. I probably added more checks than necessary, but that is safer.
2795 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2796 variable to fix the build, but this seems to be used when it is still NULL.
2798 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2800 * src/modest-platform.h:
2801 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2802 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2803 * src/modest-main.c: Implement this function so we can avoid using
2804 maemo-specific API from cross-platform code.
2806 * src/modest-tny-account-store.c:
2807 (get_smtp_specific_transport_account_for_open_connection):
2808 * src/modest-ui-actions.c: (check_for_connection),
2809 (modest_ui_actions_on_item_not_found):
2810 Use modest_platform_connect_and_wait() and put #idefs around other
2811 maemo-specific code, because only maemo currently has a way to
2812 identify connection names.
2814 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2816 * src/modest-tny-account-store.h:
2817 * src/modest-tny-account-store.c:
2818 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2819 the connection-specific SMTP server settings in the configuration.
2821 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2823 * src/maemo/modest-main-window.c: (on_connection_changed),
2825 * src/modest-main.c: (main), (start_ui), (send_mail):
2826 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2827 that is what is intended.
2829 * src/modest-ui-actions.c: (action_send), (action_receive),
2830 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2831 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2832 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2833 SMTP server is used when it is specified.
2835 (modest_ui_actions_on_send_receive):
2836 Check that a connection is open before proceeding.
2837 Receive and then send, instead of vice-versa, as per the specification.
2839 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2841 * src/modest-mail-operation.c:
2842 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2843 though I guess it should be something other than NULL.
2845 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2847 * src/maemo/easysetup/modest-easysetup-wizard.c:
2848 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2849 combo twice, to avoid an g_warning and to make it visible again.
2850 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2851 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2852 (already intended) dereference when detaching, because we then recreate the menu.
2853 But I am not sure why the warning was happening, and it is possible that this is a memory
2856 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2858 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2859 and uri_parse_mailto() utility functions.
2860 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2862 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2864 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2866 * src/dbus_api/modest-dbus-api.h:
2867 * src/dbus_api/modest-dbus-callbacks.c:
2868 Use an idle callback to execute the modest code in the application's own thread.
2869 Remove the helloworld example method.
2870 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2871 parsed, and the open-message method is not implemented because this is not yet implemented in
2873 * libmodest-dbus-client/libmodest-dbus-client.c:
2874 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2875 (libmodest_dbus_client_open_message):
2876 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2878 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2879 body without crashing.
2881 * tests/dbus_api/Makefile.am:
2882 * tests/dbus_api/test_mail_to.c:
2883 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2885 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2887 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2888 Added file to fix the build. Sorry.
2890 * src/dbus_api/Makefile.am:
2891 * src/dbus_api/modest-dbus-api.h:
2892 * src/dbus_api/modest-dbus-callbacks.h:
2893 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2894 (modest_dbus_req_handler):
2895 Put constants in a separate header so it can be reused by the
2896 client library, without duplication
2898 * libmodest-dbus-client/Makefile.am:
2899 * libmodest-dbus-client/libmodest-dbus-client.c:
2900 (libmodest_dbus_client_call_helloworld),
2901 (libmodfest_dbus_client_send_mail),
2902 (libmodfest_dbus_client_mailto),
2903 (libmodfest_dbus_client_open_message):
2904 * libmodest-dbus-client/libmodest-dbus-client.h:
2905 (Partly) Implement a send_mail D-Bus method.
2907 * tests/dbus_api/Makefile.am:
2908 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2909 the send_email D-Bus method.
2911 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2915 * libmodest-dbus-client/Makefile.am:
2916 * libmodest-dbus-client/libmodest-dbus-client.c:
2917 * libmodest-dbus-client/libmodest-dbus-client.h:
2918 * tests/dbus_api/Makefile.am:
2919 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2920 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2922 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2924 * src/maemo/easysetup/modest-easysetup-wizard.c:
2925 (create_page_account_details):
2926 * src/maemo/modest-account-settings-dialog.c:
2927 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2928 widgets, because this might not be the default in future versions of the Maemo GTK+.
2929 However, I can not not get capitalization to work even in a simple test case.
2931 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2933 * src/maemo/easysetup/modest-easysetup-wizard.c:
2934 (create_page_custom_incoming), (create_page_custom_outgoing):
2935 * src/maemo/modest-account-settings-dialog.c:
2936 (create_page_account_details), (create_page_incoming),
2937 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2938 instead of using gtk_check_button_with_label(), so they are aligned like the other
2939 widgets, as per the UI spec.
2941 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2943 * src/maemo/easysetup/modest-easysetup-wizard.c:
2944 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2945 * src/widgets/modest-validating-entry.c:
2946 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2947 Modest prefix instead of an EasySetup prefix.
2949 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2951 * src/widgets/modest-validating-entry.h:
2952 * src/widgets/modest-validating-entry.c: (on_insert_text),
2953 Added easysetup_validating_entry_set_max_func(), used to set a callback
2954 to call when the max number of characters is reached. GtkEntry has a max-length
2955 already but is silent about it.
2957 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2958 (create_page_account_details), (create_page_user_details),
2960 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2961 (create_page_account_details), (create_page_user_details),
2962 (create_page_outgoing):
2963 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2964 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2965 the UI spec, when the user tries to enter more than the max number of characters.
2967 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2969 * src/maemo/easysetup/modest-easysetup-wizard.c:
2970 (create_page_user_details), (create_page_custom_incoming),
2971 (create_page_custom_outgoing):
2972 * src/maemo/modest-account-settings-dialog.c:
2973 (create_page_user_details), (create_page_incoming),
2974 (create_page_outgoing):
2975 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2976 (modest_connection_specific_smtp_edit_window_init):
2977 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2978 not appropriate. Bad Maemo-specific defaults!.
2980 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2982 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2983 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2984 (modest_signature_editor_dialog_set_settings):
2985 Disable the label and textview when the checkbox is disabled, and use the
2986 specified (UI spec) default signature text.
2988 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2990 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2991 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2993 * src/modest-defs.h:
2994 * src/modest-account-mgr-helpers.h:
2995 * src/modest-account-mgr-helpers.c:
2996 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2998 * src/maemo/Makefile.am:
2999 * src/maemo/modest-signature-editor-dialog.c:
3000 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3003 * src/maemo/modest-account-settings-dialog.h:
3004 * src/maemo/modest-account-settings-dialog.c:
3005 (modest_account_settings_dialog_finalize), (on_button_signature),
3006 (save_configuration): Use the new dialog when the Edit button is pressed, and
3007 save the changes if necessary, as per the UI spec.
3009 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3011 * src/maemo/Makefile.am:
3012 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3013 based on maemo-develoers email from Dirk.
3015 * src/maemo/easysetup/modest-easysetup-wizard.c:
3016 (create_page_welcome), (create_page_account_details),
3017 (create_page_user_details), (create_page_complete_easysetup),
3018 (create_page_custom_incoming), (create_page_custom_outgoing),
3019 (create_page_complete_custom),
3020 (modest_easysetup_wizard_dialog_init):
3021 * src/maemo/modest-account-settings-dialog.c:
3022 (create_page_account_details), (create_page_user_details),
3023 (create_page_incoming), (create_page_outgoing),
3024 (modest_account_settings_dialog_init):
3025 * src/maemo/modest-connection-specific-smtp-window.c:
3026 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3028 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3030 * src/maemo/easysetup/modest-easysetup-wizard.c:
3031 (create_page_account_details), (create_page_custom_outgoing),
3032 (create_page_complete_custom):
3033 * src/maemo/modest-account-settings-dialog.c:
3034 (create_page_user_details), (create_page_incoming),
3035 (create_page_outgoing):
3036 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3037 (modest_connection_specific_smtp_edit_window_init):
3038 Use the correct (UI spec) port min/max, and use horizontal separators,
3041 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3043 * src/maemo/easysetup/modest-easysetup-wizard.c:
3044 (set_default_custom_servernames):
3045 * src/maemo/modest-account-settings-dialog.c:
3046 (create_page_incoming), (on_combo_outgoing_security_changed),
3047 (on_combo_incoming_security_changed), (create_page_outgoing),
3048 (modest_account_settings_dialog_set_account_name),
3049 (save_configuration):
3050 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3051 (on_combo_security_changed),
3052 (modest_connection_specific_smtp_edit_window_init),
3053 (modest_connection_specific_smtp_edit_window_set_connection),
3054 (modest_connection_specific_smtp_edit_window_get_settings):
3055 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3058 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3061 * src/maemo/easysetup/modest-easysetup-wizard.c:
3062 (create_page_custom_outgoing), (create_page_complete_custom):
3063 * src/maemo/modest-account-settings-dialog.c:
3064 (create_page_user_details), (create_page_outgoing):
3065 * src/maemo/modest-account-view-window.c: (button_box_new):
3066 Use changed logical IDs as per the most recent UI spec:
3067 mcen_bd_emailsetup_edit -> mcen_bd_edit
3068 mcen_bd_emailsetup_delete -> mcen_bd_delete
3069 mcen_bd_emailsetup_close -> mcen_bd_close
3071 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3075 * src/dbus_api/Makefile.am:
3076 * src/dbus_api/modest-dbus-callbacks.c:
3077 * src/dbus_api/modest-dbus-callbacks.h:
3078 * src/maemo/modest-platform.c: (modest_platform_init):
3079 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3081 * tests/Makefile.am:
3082 * tests/dbus_api/Makefile.am:
3083 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3085 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3087 * src/maemo/modest-account-settings-dialog.c:
3088 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3089 Removed unnecessary includes.
3091 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3093 * src/maemo/easysetup/modest-easysetup-wizard.c:
3094 * src/maemo/modest-account-settings-dialog.c:
3095 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3096 * src/widgets/Makefile.am:
3097 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3098 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3099 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3100 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3101 * src/widgets/modest-secureauth-combo-box.c:
3102 * src/widgets/modest-secureauth-combo-box.h:
3103 * src/widgets/modest-serversecurity-combo-box.c:
3104 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3105 made the GObject names more consistent with the rest of the Modest code.
3107 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3109 * src/maemo/easysetup/Makefile.am:
3110 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3111 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3112 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3113 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3114 * src/maemo/easysetup/modest-easysetup-wizard.c:
3115 * src/maemo/easysetup/modest-validating-entry.c:
3116 * src/maemo/easysetup/modest-validating-entry.h:
3117 * src/maemo/modest-account-settings-dialog.c:
3118 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3119 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3120 widgets/ because they are used outside of easysetup too. After checking in,
3121 svn will allow me to rename them too.
3123 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3125 * src/gnome/modest-msg-edit-window.c:
3126 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3127 linker error, to fix the build on the GNOME platform.
3128 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3129 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3130 ifdefed out to avoid a warning.
3132 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3134 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3135 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3136 some alternative for GTK+ 2.6.
3138 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3140 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3142 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3143 specified for EmailAccountsDialog in UI spec.
3145 * src/maemo/easysetup/modest-easysetup-wizard.c:
3146 * src/maemo/easysetup/modest-easysetup-wizard.h:
3147 * src/maemo/modest-account-settings-dialog.c:
3148 * src/maemo/modest-account-settings-dialog.h:
3149 Reuse a member window widget for the connection-specific SMTP server accounts,
3150 so we can tell it to create/save the accounts only if we actually save changes.
3152 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3153 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3154 (modest_connection_specific_smtp_edit_window_get_settings):
3155 Return a struct instance for temporarily remembering the entered data.
3157 * src/maemo/modest-connection-specific-smtp-window.h:
3158 * src/maemo/modest-connection-specific-smtp-window.c:
3159 (modest_connection_specific_smtp_window_finalize),
3160 (modest_connection_specific_smtp_window_fill_with_connections),
3162 (modest_connection_specific_smtp_window_save_server_accounts),
3163 (update_model_server_names): Do not actually save data until asked,
3164 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3166 (on_selection_changed),
3167 (modest_connection_specific_smtp_window_init): Disable the edit
3168 button when nothing is selected.
3170 * src/modest-account-mgr-helpers.c:
3171 * src/modest-account-mgr-helpers.h:
3172 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3175 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3177 * src/modest-account-mgr-helpers.h:
3178 * src/modest-account-mgr-helpers.c:
3179 (modest_account_mgr_get_unused_account_name),
3180 (modest_account_mgr_get_unused_account_display_name): Added these
3181 utility functions, to avoid code duplication.
3183 * src/maemo/easysetup/modest-easysetup-wizard.c:
3184 (create_page_account_details), (create_account):
3185 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3186 (on_combo_security_changed),
3187 (modest_connection_specific_smtp_edit_window_init),
3188 (modest_connection_specific_smtp_edit_window_save_settings):
3189 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3190 * src/maemo/modest-connection-specific-smtp-window.c:
3191 (modest_connection_specific_smtp_window_finalize),
3192 (modest_connection_specific_smtp_window_fill_with_connections),
3193 (on_button_edit), (modest_connection_specific_smtp_window_init):
3194 * src/maemo/modest-connection-specific-smtp-window.h:
3195 Implementing saving of connection-specific server accounts.
3197 But I need to refactor this so we can save the data for each
3198 possible connection-specific account and only actually create the server accounts
3199 when the easysetup finished, or the OK button is pressed on the account settings
3202 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3204 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3205 (on_combo_security_changed):
3206 (modest_connection_specific_smtp_edit_window_init):
3207 Auto-fill the port number as in the account settings.
3209 (modest_connection_specific_smtp_edit_window_set_connection):
3210 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3211 * src/maemo/modest-connection-specific-smtp-window.c:
3212 (fill_with_connections), (on_button_edit),
3213 (modest_connection_specific_smtp_window_init):
3214 Turn the edit window into a dialog to simplify the code, and
3215 set a WM hint as in a GtkDialog, because only a popup can be on top of
3216 another window in Maemo, and popups usually have no WM decoration.
3218 * src/modest-defs.h:
3219 * src/modest-account-mgr-helpers.c:
3220 (modest_account_mgr_set_connection_specific_smtp),
3221 (modest_account_mgr_remove_connection_specific_smtp),
3222 (modest_account_mgr_get_connection_specific_smtp):
3223 * src/modest-account-mgr-helpers.h: Some functions to write the
3224 connection-specific SMTP server information. Not yet used.
3227 * src/widgets/modest-folder-view.c: (text_cell_data):
3228 Fix a warning about an uninitialized variable.
3229 (on_configuration_key_changed): Put an #ifdef around the use
3230 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3232 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3234 * src/maemo/modest-account-settings-dialog.h:
3235 * src/maemo/modest-account-settings-dialog.c:
3236 Added connect_for_modified() utility function to mark the new modified boolean.
3238 (create_page_account_details), (create_page_user_details),
3239 (create_page_incoming), (create_page_outgoing), (on_response),
3240 (modest_account_settings_dialog_init),
3241 (modest_account_settings_dialog_set_account_name):
3242 Only warn about unsaved changes when there are actually unsaved changes.
3244 * src/modest-account-mgr-helpers.c:
3245 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3246 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3247 to get the data from there in future.
3249 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3251 * src/modest-defs.h:
3253 * src/modest-account-mgr-helpers.h:
3254 * src/modest-account-mgr-helpers.c:
3255 Store the security account setting in a single conf key instead of using
3256 the options list, so that the list is left for just the to-be-removed camel hack,
3257 and because gconf_client_set_list() is failing for some reason.
3259 * src/modest-account-mgr.c:
3260 (modest_account_mgr_add_server_account):
3261 * src/maemo/modest-account-settings-dialog.c:
3262 (modest_account_settings_dialog_set_account_name),
3263 (save_configuration): Use the renamed functions.
3266 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3268 * src/widgets/Makefile.am:
3269 * src/widgets/modest-limit-retrieve-combo-box.c:
3270 * src/widgets/modest-limit-retrieve-combo-box.h:
3271 * src/widgets/modest-retrieve-combo-box.c:
3272 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3273 the account settings dialog.
3275 * src/modest-defs.h:
3276 * src/modest-account-mgr-helpers.h:
3277 * src/modest-account-mgr-helpers.c:
3278 (modest_server_account_get_option_secure_auth),
3279 (modest_server_account_set_option_secure_auth):
3280 * src/modest-account-mgr.c:
3281 (modest_account_mgr_add_server_account):
3282 Use the existing AUTH_MECH conf key for the secure-auth setting,
3283 instead of putting it in the list options, because this was actually used already.
3285 * src/maemo/modest-account-settings-dialog.c:
3286 (create_page_account_details),
3287 (modest_account_settings_dialog_set_account_name),
3288 (save_configuration):
3289 * src/maemo/modest-account-settings-dialog.h:
3290 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3291 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3293 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3295 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3296 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3297 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3299 * src/modest-defs.h:
3300 * src/maemo/modest-account-settings-dialog.c:
3301 (create_page_incoming), (on_combo_outgoing_security_changed),
3302 (on_combo_incoming_security_changed), (create_page_outgoing),
3303 (modest_account_settings_dialog_set_account_name),
3304 (save_configuration): Load/Save the port number, and change it when the
3305 security combo changes, to suitable defaults.
3307 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3309 * src/modest-account-mgr.c:
3310 (modest_account_mgr_add_server_account): Set the security and secure-auth
3311 options, and add a comment saying that the other camel-specific options should be
3314 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3316 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3318 * src/modest-tny-account-store.c: (account_list_free),
3319 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3320 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3323 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3325 * src/modest-protocol-info.c:
3326 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3327 is required by our UI spec. Maybe something in our implementation will use this eventually.
3328 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3329 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3330 instead of the previous 0 placeholder.
3332 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3333 secure-auth settings.
3334 * src/modest-account-mgr-helpers.h:
3335 * src/modest-account-mgr-helpers.c:
3336 (modest_server_account_data_get_option_secure_auth),
3337 (modest_server_account_set_option_secure_auth),
3338 (modest_server_account_data_get_option_security),
3339 (modest_server_account_set_option_security): Added this API for getting and setting the security
3340 and secure-auth settings.
3342 * src/maemo/modest-account-settings-dialog.h:
3343 * src/maemo/modest-account-settings-dialog.c:
3344 (modest_account_settings_dialog_finalize), (check_data),
3345 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3346 about changing titles.
3347 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3348 (save_configuration): Save the security and secure-auth settings.
3350 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3351 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3353 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3355 * src/modest-defs.h:
3356 * src/modest-account-mgr.c:
3357 (modest_account_mgr_add_server_account):
3358 Added and used defines for the options key and value pair strings,
3359 that are used so far, though they do not seem to correspond to anything in our
3360 UI specs or ModestProtocol enum.
3362 * src/modest-account-mgr-helpers.h:
3363 * src/modest-account-mgr-helpers.c:
3364 (compare_option_strings_for_name),
3365 (modest_server_account_data_get_option_value),
3366 (modest_server_account_data_get_option_bool),
3367 (modest_account_mgr_get_server_account_option):
3368 Added helper functions for parsing the options GSList.
3370 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3372 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3373 display name is based on the supplied account name.
3374 * src/modest-account-mgr.c:
3375 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3376 with an inefficient, but good-enough, implementation.
3378 * src/maemo/easysetup/modest-easysetup-wizard.c:
3379 (create_page_account_details), (on_before_next), (create_account):
3380 Check for existing display names rather than (non-user-visible) account names, and just
3381 create and set a unique account name at the end.
3383 * src/maemo/modest-account-settings-dialog.c:
3384 (modest_account_settings_dialog_init),
3385 (modest_account_settings_dialog_set_account_name),
3386 (create_page_incoming): Show the display name, instead of the account name.
3387 (on_response): Do some (not all) extra checks, as in the UI spec.
3388 (save_configuration): Save the display name if it was changed.
3390 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3392 * po/en_GB.po: Added needed logical ID and translation.
3393 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3394 (init_view): Made the is-default column clicking work.
3396 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3399 * src/maemo/easysetup/Makefile.am:
3400 * src/maemo/easysetup/modest-easysetup-wizard.c:
3401 (modest_easysetup_wizard_dialog_init):
3402 * src/maemo/easysetup/provider-data-test.keyfile:
3403 * src/maemo/easysetup/provider-data.keyfile:
3404 Moved the provider data file to the new modest-providers-data package and used it from there.
3406 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3408 * src/modest-local-folder-info.c:
3409 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3410 N_() was already used on the static strings, but this just marks it for translation without
3411 using the translation.
3413 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3415 * src/maemo/modest-account-settings-dialog.c:
3416 (create_page_incoming),
3417 (modest_account_settings_dialog_set_account_name):
3418 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3419 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3420 I will do this if nobody else gets there first.
3422 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3424 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3425 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3426 save the security stuff.
3428 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3430 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3431 Set the email address and user fullname, which I now see must be
3434 * src/maemo/modest-account-settings-dialog.h:
3435 * src/maemo/modest-account-settings-dialog.c:
3437 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3438 leave-on-server and authentication.
3439 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3442 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3445 * src/maemo/modest-account-settings-dialog.c:
3446 * src/maemo/modest-account-settings-dialog.h:
3447 Most (but not all) of the widgets are now present as specified by the UI spec.
3448 No changes are yet saved, and some details are not properly shown yet.
3450 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3452 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3454 * src/maemo/Makefile.am:
3455 * src/maemo/modest-account-settings-dialog.c:
3456 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3457 an existing account. Doesn't do much yet.
3459 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3460 Open the accounts settings dialog when Edit is clicked.
3462 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3464 * src/maemo/easysetup/Makefile.am:
3465 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3467 * src/maemo/easysetup/modest-easysetup-wizard.c:
3468 (modest_easysetup_wizard_dialog_init):
3469 Try to get the source directory from the build system,
3470 instead of hard-coding "./" into the source code, when opening our local
3471 copies of the configuration files.
3472 But this still fails when opening the wizard from the Accounts window,
3473 maybe because the working directory seems to change at runtime.
3474 So the wizard will fail the second time unless you copy the files into their
3475 proper locations - see the stdout warnings for the paths.
3477 (create_page_account_details),(on_before_next):
3478 Check for existing non-server accounts instead of server accounts,
3479 so the default account name is useful again, and to prevent trying to
3482 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3483 Show the wizard when New is clicked.
3485 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3486 (init_view): Show the column headers, and show the columns that are
3487 specified in the UI specs. However, something in Maemo's GTK+ prevents
3488 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3489 change the default account. This is despite unsetting the special properties.
3491 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3493 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3494 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3495 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3496 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3497 to make that clearer.
3498 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3500 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3502 * src/maemo/modest-account-view-window.c:
3503 (modest_account_view_window_init),
3504 (modest_account_view_window_new):
3505 Use the same buttons as specified in the
3506 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3507 the existing widgets, which never had a chance of working.
3508 Put the ModestAccountView treeview in a scrolled window.
3509 Do not repeat the initialization in both _init() and _new().
3511 * src/widgets/modest-account-view.c: (update_account_view):
3512 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3513 this widget and window shows no accounts.
3515 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3517 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3519 * src/maemo/easysetup/modest-easysetup-wizard.c:
3520 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3521 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3522 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3525 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3526 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3527 accounts exist yet, as in the UI spec.
3529 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3531 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3533 * src/maemo/Makefile.am:
3534 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3535 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3536 New window for editing connection-specific smtp details.
3537 Not fully implemented.
3539 * src/maemo/modest-connection-specific-smtp-window.c:
3540 (modest_connection_specific_smtp_window_finalize) :
3541 unref the tree model.
3542 (on_button_edit): Show the edit window.
3544 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3546 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3549 * src/maemo/Makefile.am:
3550 * src/maemo/modest-connection-specific-smtp-window.c:
3551 * src/maemo/modest-connection-specific-smtp-window.h:
3552 New window for showing the list of connections, for connection-specific
3553 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3554 * src/maemo/easysetup/modest-easysetup-wizard.c:
3555 (create_page_custom_outgoing): Show the new window when the button is clicked.
3557 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3559 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3560 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3561 * src/maemo/modest-msg-edit-window.c:
3562 (modest_msg_edit_window_insert_image):
3563 * src/modest-conf.c: (modest_conf_key_escape):
3564 * src/modest-mail-operation.c:
3565 (modest_mail_operation_send_new_mail):
3566 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3567 (modest_ui_actions_on_new_account):
3568 * src/widgets/modest-attachment-view.c: (update_filename_request):
3569 * src/widgets/modest-mail-header-view.c:
3570 Corrected warnings that were breaking the build, by commenting out unused variables,
3571 and a function, and by including a header.
3573 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3575 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3576 so we can #ifdef around platform-specific code when necessary.
3577 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3578 to allow this to build for the GNOME platform too.
3580 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3582 * src/maemo/easysetup/modest-easysetup-wizard.c:
3583 Added util_increment_name() and used it in create_page_account_details()
3584 to make sure that the default account name is always a new name.
3586 (modest_easysetup_wizard_dialog_init),
3587 (set_default_custom_servernames): Some minor memory management fixes.
3589 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3593 * src/modest-runtime.c: (init_i18n): Restored the translation
3594 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3595 are defined in config.h, and the translations are installed.
3597 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3598 is defined for translation.
3600 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3602 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3604 * src/maemo/easysetup/modest-easysetup-wizard.c:
3605 (modest_easysetup_wizard_dialog_init):
3606 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3607 Use realistic paths (though they should use $prefix generically) to the
3608 mcc_mapping and provider-data.keyfile files which might work when they
3609 are installed by the future version of the operator-wizard package,
3610 and then fallback to paths in our source code, with an explanatory
3613 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3617 * src/maemo/Makefile.am:
3618 * src/maemo/easysetup/: Added files from the previously-exernal
3619 osso-modest-easysetup.
3620 * src/maemo/modest-main-window-ui.h:
3621 * src/modest-ui-actions.c:
3622 * src/modest-ui-actions.h:
3623 Added modest_ui_actions_on_new_account() as a signal handler for the
3624 New Account menu item. It shows the easysetup wizard.
3625 * po/en_GB.po: Added additional needed logical IDs and translations.