1 2007-06-25 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
4 that is an empty string. D-Bus seems to give us these instead of NULL.
6 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
8 * src/dbus_api/modest-dbus-callbacks.c:
9 * src/maemo/easysetup/modest-easysetup-wizard.h:
10 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
11 * src/maemo/modest-connection-specific-smtp-edit-window.c:
12 (modest_connection_specific_smtp_edit_window_init):
13 * src/maemo/modest-maemo-global-settings-dialog.c:
15 * src/maemo/modest-maemo-utils.c:
16 (modest_maemo_utils_setup_images_filechooser):
17 * src/maemo/modest-main-window.c: (create_details_widget):
18 * src/maemo/modest-msg-edit-window.c:
19 (modest_msg_edit_window_attach_file_noninteractive),
20 (modest_msg_edit_window_color_button_change),
21 (modest_msg_edit_window_set_zoom):
22 * src/modest-mail-operation.c: (update_account_thread):
23 * src/modest-tny-account-store.c:
24 * src/modest-tny-account.c:
25 * src/widgets/modest-global-settings-dialog.c:
26 * src/widgets/modest-window.h:
30 2007-06-25 Murray Cumming <murrayc@murrayc.com>
32 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
33 * src/modest-search.c: (modest_search_folder),
34 (modest_search_all_accounts): Actually search only in the specified folder,
35 doing a simple match on the folder ID.
36 * src/modest-search.h: Added a folder field to the ModestSearch struct,
37 and added some documentation.
39 2007-06-22 Armin Burgmeier <armin@openismus.com>
41 * src/maemo/modest-maemo-utils.h:
42 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
43 modest_maemo_utils_get_supported_secure_authentication_methods.
45 * src/maemo/easysetup/modest-easysetup-wizard.c:
46 * src/maemo/modest-account-settings-dialog.c: Show correct error if
47 one occured, not just "Server does not support secure authentication".
49 2007-06-22 Murray Cumming <murrayc@murrayc.com>
51 * src/modest-tny-account-store.c: (get_password):
52 Restored the call to tny_account_set_user() because Philip seems to have
53 stopped this from crashing (by not using the freed string). It still does
54 not work, but now we can test it.
56 2007-06-22 Murray Cumming <murrayc@murrayc.com>
58 * src/maemo/modest-msg-edit-window.c: (init_window):
59 Comment out use of an uninitialzed GtkScrolledWindow variable,
60 to fix the build and stop a crash. Yet again.
62 2007-06-22 Murray Cumming <murrayc@murrayc.com>
64 * src/modest-tny-account-store.c: (get_password):
65 Remove the call to tny_account_set_user() because this actually crashes.
66 As mentioned in the last commit, it is known to not work anyway.
68 2007-06-22 Murray Cumming <murrayc@murrayc.com>
70 * src/modest-tny-account-store.c: (get_password):
71 Use tny_account_set_username() to tell tinymail that the username might
72 have changed too. But tinymail ignores this: see projects.maemo.org
74 * src/modest-ui-actions.c:
75 (modest_ui_actions_on_password_requested): Remove the useless attempt to
76 reset the connection when changing the username, and improve the comments.
77 Save the changed username to gconf at least, so it is used when Modest is
80 2007-06-21 Murray Cumming <murrayc@murrayc.com>
82 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
83 Do not use a query, so that we get all folders, including for POP and
84 local-folders. They work as search criteria too.
85 This fixes projects.maemo.org bug NB#57740.
87 2007-06-21 Murray Cumming <murrayc@murrayc.com>
89 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
90 Comment out the use of hildon_notification_set_sound() because it is
91 not declared, to fix the build. Warnings are serious, people.
93 2007-06-21 Armin Burgmeier <armin@openismus.com>
95 * src/maemo/modest-maemo-utils.h:
96 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
97 modest_maemo_utils_get_supported_secure_authentication_methods()
98 to query authentication methods for a specific user. This should fix
99 projects.maemo.org bug NB#61369.
101 * src/maemo/easysetup/modest-easysetup-wizard.c:
102 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
105 2007-06-21 Murray Cumming <murrayc@murrayc.com>
107 * libmodest-dbus-client/libmodest-dbus-client.h:
108 * libmodest-dbus-client/libmodest-dbus-client.c:
109 (modest_dbus_message_iter_get_search_hit),
110 (libmodest_dbus_client_search):
111 Reorganised and commented this.
112 Removed modest_search_hit_free() from the public API because it
115 Added libmodest_dbus_client_get_folders() and
116 modest_folder_result_list_free().
118 * src/dbus_api/modest-dbus-api.h:
119 * src/dbus_api/modest-dbus-callbacks.c:
120 (modest_dbus_req_filter): Commented. Moved most code to
121 on_dbus_method_search() and added on_dbus_method_get_folders().
123 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
124 of the extra D-Bus handler.
126 * tests/dbus_api/Makefile.am:
127 * tests/dbus_api/test_get_folders.c: New test for
128 libmodest_dbus_client_get_folders(). This seems to return an empty list
129 at the moment. That could be the same error that causes the message list
130 to be empty sometimes.
131 This should help with projects.maemo.org bug NB#57740.
133 2007-06-21 Armin Burgmeier <armin@openismus.com>
135 * src/modest-mail-operation.c: Do not call
136 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
137 notify the operation's end after having set the status to CANCELED for
138 the operation queue to listen on. This fixes a deadlock when there
139 were mail operations in the queue during its finalization.
141 * src/modest-singletons.c: Reordered uninitialization of the account
142 manager to happen after the mail operation queue was uninitialized
143 because the mail operation's in the queue might still try to access
144 the account manager (see modest_mail_operation_notify_end()). This
145 fixes a potential crash when terminating the application.
147 2007-06-21 Murray Cumming <murrayc@murrayc.com>
149 * src/modest-search.c:
150 (search_mime_part_and_child_parts): Moved some code here so we
151 can search recursively in child folders.
152 (modest_search_folder): Search in the message as a mime part, instead
153 of just its child mime parts.
154 (read_chunk), (search_mime_part_ogs):
155 Check how many bytes were read, to prevent an endless loop.
156 Searching in message bodies now works. This finishes the fix for
157 projects.maemo.org bug NB#61007.
159 2007-06-20 Murray Cumming <murrayc@murrayc.com>
161 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
162 Add a g_warning when the item is not a folder.
164 * src/modest-ui-dimming-rules.c:
165 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
166 when selected item is not a folder (for instance, an account), because
167 the UI spec only talks about folders.
168 I am not sure what the UI spec wants, so this might not totally fix
169 projects.maemo.org bug NB#60794.
171 2007-06-20 Murray Cumming <murrayc@murrayc.com>
173 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
174 (load_from_file): Sort the list. The unsorted list would be more noticeable
175 in non-English locales.
177 * src/maemo/modest-msg-edit-window.c:
178 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
179 warning and fix the build.
181 * src/maemo/modest-progress-bar-widget.c:
182 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
183 avoid a g_warning, and probably to avoid a crash.
185 2007-06-20 Murray Cumming <murrayc@murrayc.com>
187 * src/modest-search.c: (modest_search_folder): Check for a GError
188 when calling tny_folder_get_headers(), to show that this is not the cause
191 2007-06-20 Murray Cumming <murrayc@murrayc.com>
193 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
194 Actually set the body query instead of the subject query.
196 * src/modest-search.c: (search_mime_part_ogs),
197 (search_mime_part_strcmp): Remove extra space from the text/* regex,
198 which would probably cause it to fail if we got this far.
200 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
201 to simplify the code.
202 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
203 be causing search-in-body to fail.
205 2007-06-20 Murray Cumming <murrayc@murrayc.com>
207 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
209 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
210 Better debug message when the folder cannot be found.
211 This should help with fixing projects.maemo.org bug #61287.
212 * src/modest-search.c: (add_hit): Do not leak the furl string.
214 2007-06-20 Murray Cumming <murrayc@murrayc.com>
216 * src/modest-ui-actions.c:
217 (modest_ui_actions_on_folder_selection_changed):
218 Do not special-case TNY_MERGE_FOLDER here, because
219 modest_tny_folder_get_account() already does that. This fixes
220 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
221 shown when the Outbox was selected).
223 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
225 * libmodest-dbus-client/libmodest-dbus-client.c:
226 (_dbus_iter_get_string_or_null): Initialize the string variable in
227 case this helps with Dirk's crash.
229 2007-06-19 Murray Cumming <murrayc@murrayc.com>
231 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
232 though it is not implemented yet (this function is maybe not even used),
233 to avoid breaking ABI in future.
234 * libmodest-dbus-client/libmodest-dbus-client.c:
235 (get_attachments_string): Moved some code into this generic function.
236 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
237 sends email. It is maybe not used.
238 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
239 (on_send_mail): Use attachments.
241 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
242 * src/maemo/modest-msg-edit-window.c:
243 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
244 a filename before using it, to fix projects.maemo.org bug NB#58233.
246 2007-06-19 Murray Cumming <murrayc@murrayc.com>
248 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
249 Initialize the continue_download variable to fix the build, and probably
250 to fix randome behaviour.
252 2007-06-18 Armin Burgmeier <armin@openismus.com>
254 * src/modest-tny-send-queue.h:
255 * src/modest-tny-send-queue.c: Keep track of the status of messages in
256 the queue so we can later show it in the UI. Replaced
257 modest_tny_send_queue_msg_is_being_sent() by
258 modest_tny_send_queue_get_msg_status().
260 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
262 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
263 gpointer. This probably was not harmful, but just to be sure.
265 2007-06-18 Murray Cumming <murrayc@murrayc.com>
267 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
268 Fix the build, but leave the function broken on Bora, because
269 hildon_uri_action_get_service() does not exist.
270 osso_uri_action_get_service() does not exist either, it seems.
272 2007-06-18 Murray Cumming <murrayc@murrayc.com>
274 * src/modest-tny-account.c:
275 (modest_tny_account_new_from_server_account):
276 Uncommented the url debug output again, because it is useful for
277 debugging, as I said in the comment.
279 2007-06-18 Murray Cumming <murrayc@murrayc.com>
281 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
283 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
284 for Mameo Bora, to fix the build.
286 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
289 Fixed build with hildon < 0.99
291 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
292 Check if the selected account is busy instead of checking all accounts
294 * src/modest-account-mgr-priv.h:
295 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
296 (modest_account_mgr_init), (compare_account_name),
297 (modest_account_mgr_set_account_busy),
298 (modest_account_mgr_account_is_busy):
299 * src/modest-account-mgr.h:
300 Added busy information to the account manager. It possible to
301 set an account to busy or not busy now.
303 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
304 (modest_mail_operation_update_account),
305 (modest_mail_operation_notify_end):
306 Set the account to busy/not busy depending on the operation state.
308 * src/widgets/modest-account-view.c:
309 (modest_account_view_finalize), (get_last_updated_string),
310 (update_account_view), (on_account_busy_changed), (init_view):
311 Show string "Refreshing..." if the account is currently busy.
313 All this fixes projects.maemo.org bug NB#59711
315 2007-06-14 Armin Burgmeier <armin@openismus.com>
317 * src/widgets/modest-attachments-view.h:
318 * src/widgets/modest-attachments-view.c: Added
319 modest_attachments_view_has_attachments() and fixed coordinate
320 transformation in get_att_view_at_coords(). This fixes attachment
323 * src/widgets/modest-msg-view.c: Make use of
324 modest_attachments_view_has_attachments() to decide whether to show
325 attachments in the header.
327 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
329 * src/maemo/modest-connection-specific-smtp-edit-window.c:
330 (on_change), (on_combo_security_changed),
331 (modest_connection_specific_smtp_edit_window_init),
332 (modest_connection_specific_smtp_edit_window_set_connection),
333 (modest_connection_specific_smtp_edit_window_is_dirty):
334 * src/maemo/modest-connection-specific-smtp-edit-window.h:
335 * src/maemo/modest-connection-specific-smtp-window.c:
338 Show an comfirmation dialog for the smpt-edit-window if there are
339 unsaved changes and the user hits cancel.
340 (projects.maemo.org bug NB#60479)
342 2007-06-14 Armin Burgmeier <armin@openismus.com>
344 * src/maemo/easysetup/modest-easysetup-wizard.c:
345 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
346 address" info in banner instead of node, and select all the text as
347 per UI spec. This fixes projects.maemo.org bug NB#60550.
349 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
351 reviewed by: <delete if not using a buddy>
353 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
354 * src/modest-ui-actions.c: (folder_refreshed_cb):
356 2007-06-14 Murray Cumming <murrayc@murrayc.com>
358 * src/widgets/modest-folder-view.c: (filter_row):
359 Explictly filter out the per-account outbox accounts. I don't know why
360 these only sometimes show up, but now they should never show up in the UI.
361 This should fix projects.maemo.org bug NB#60160.
363 2007-06-14 Murray Cumming <murrayc@murrayc.com>
365 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
366 when the toolbar does not exist yet.
367 * src/modest-widget-memory.c: (save_settings_header_view):
368 Added g_warnings() to help us to discover when we are trying to set
369 an empty columns list in gconf.
371 2007-06-14 Murray Cumming <murrayc@murrayc.com>
375 Added modest_init_get_default_header_view_column_ids().
377 * src/modest-widget-memory.c: (restore_settings_header_view):
378 Use the new function to get defaults, if the gconf key is empty,
379 instead of not creating any columns. This seems to fix the
380 empty right-hand pane problems.
382 * src/widgets/modest-header-view.h: Improved documentation.
384 2007-06-13 Murray Cumming <murrayc@murrayc.com>
386 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
387 Revert the use of the display name as the account name, because this
388 is generally wrong and would break the code that follows.
390 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
392 * src/maemo/easysetup/modest-easysetup-wizard.c:
393 (check_for_supported_auth_methods), (on_before_next),
396 More correct fix for projects.maemo.org bug NB# 58991
397 Do not longer accept AUTH_PASSWORD as secure method and choose
398 correct method when creating the account.
400 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
402 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
403 Fixed projects.maemo.org bug NB# 58991
405 2007-06-13 Murray Cumming <murrayc@murrayc.com>
407 * src/modest-init.c: (modest_init_init_core),
408 (modest_init_local_folders): Fixed compilation errors.
410 2007-06-13 Murray Cumming <murrayc@murrayc.com>
412 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
413 Remove unnecessary lib/include, though it is good in principle when needed.
415 * src/modest-init.c: (modest_init_one_local_folder),
416 (modest_init_local_folders):
417 * src/modest-init.h: Initialize the .modest library for memory cards,
418 instead of just doing nothing for them. This should allow us to create
419 folders there, fixing projects.maemo.org bug NB#59297.
421 2007-06-13 Murray Cumming <murrayc@murrayc.com>
423 * libmodest-dbus-client/libmodest-dbus-client.c:
424 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
425 (libmodest_dbus_client_compose_mail),
426 (libmodest_dbus_client_open_message),
427 (libmodest_dbus_client_send_and_receive),
428 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
430 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
431 (on_idle_open_message), (modest_dbus_req_handler),
432 (search_result_to_message), (modest_dbus_req_filter):
433 * src/modest-search.c: (add_hit), (modest_search_folder),
434 (modest_search_all_accounts): Improved debug messages.
436 * tests/dbus_api/test_open_message.c: (main): Improved comments.
438 * src/modest-tny-account-store.c:
439 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
442 2007-06-13 Murray Cumming <murrayc@murrayc.com>
445 2007-06-12 Murray Cumming <murrayc@murrayc.com>
447 * src/modest-tny-account-store.c: (get_server_accounts):
448 Call modest_tny_local_folders_account_add_merged_outbox_folders()
449 even when there are no accounts, so that the Outbox folder is always
450 visible. This fixes projects.maemo.org bug NB#60158.
452 2007-06-12 Murray Cumming <murrayc@murrayc.com>
454 * src/maemo/modest-main-window.c: (create_details_widget):
455 Use the mcen_va_never logical ID.
457 2007-06-12 Murray Cumming <murrayc@murrayc.com>
459 * src/dbus_api/modest-dbus-api.h:
460 * src/dbus_api/modest-dbus-callbacks.c:
461 (on_idle_open_default_inbox), (on_open_default_inbox),
462 (modest_dbus_req_handler):
463 Added a new OpenDefaultInbox method.
465 * libmodest-dbus-client/libmodest-dbus-client.h:
466 * libmodest-dbus-client/libmodest-dbus-client.c:
467 Added libmodest_dbus_client_open_default_inbox() to call the new
468 dbus method. This should be useful to projects.maemo.org bug NB#57214,
469 though it should maybe be used by a new osso-email-interface function.
471 * tests/dbus_api/Makefile.am:
472 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
475 2007-06-12 Murray Cumming <murrayc@murrayc.com>
477 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
478 NULL, so that the signals get all the keys. This should not actually
479 change any behaviour because we currently update everything when anything
482 2007-06-12 Murray Cumming <murrayc@murrayc.com>
484 * src/widgets/modest-folder-view.c: (text_cell_data),
485 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
486 (find_inbox_iter): If tinymail tells us that the folder is
487 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
488 This causes the inbox to be selected at startup, fixing part of
489 projects.maemo.org bug NB#56305.
491 * src/modest-ui-dimming-rules.c:
492 (modest_ui_dimming_rules_on_tools_smtp_servers):
493 * src/modest-ui-dimming-rules.h: Added a callback function to dim
494 the SMTP servers menu item.
495 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
496 that the SMTP Servers menu item is dimmed when there are no accounts,
497 as a future version of the UI spec will require. This fixes
498 projects.maemo.org bug NB#56305.
500 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
502 * src/maemo/modest-maemo-utils.c:
503 (modest_maemo_utils_get_supported_secure_authentication_methods):
504 Added label to dialog instead of unreadable title
506 * src/maemo/modest-main-window.c: (sync_accounts_cb),
507 (modest_main_window_new):
508 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
511 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
512 * src/modest-account-mgr.h:
513 Added method to avoid code duplication
515 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
516 (modest_ui_actions_on_send_receive):
517 Use modest_account_mgr_has_accounts
519 2007-06-11 Murray Cumming <murrayc@murrayc.com>
521 * src/maemo/easysetup/modest-presets.c:
522 (modest_presets_get_info_server_security): Do not report secure auth
524 * src/modest-protocol-info.c: Use the defines for the gconf key names
525 for secure authentication. This was not working because we were writing
526 Password and reading password, and the check was case sensitive.
527 With this, gmail now works for receiving and sending when created via
530 2007-06-11 Murray Cumming <murrayc@murrayc.com>
532 * src/maemo/easysetup/modest-presets.c:
533 (modest_presets_get_info_server_security): Correct the key name for
534 SecureSmtp, because it seems to be case-sensitive.
535 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
536 Do not try to get the 0th notebook page if there are 0 pages, to
539 2007-06-11 Murray Cumming <murrayc@murrayc.com>
541 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
542 Prevent use of the new notification feature for now, because it currently
543 shows one dialog for each new email, which is annoying.
545 2007-06-11 Murray Cumming <murrayc@murrayc.com>
547 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
548 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
549 when no country was selected, so that we show the global ones.
550 * src/maemo/easysetup/modest-presets.c:
551 (modest_presets_get_providers): Return only the global providers, not
552 all providers when mmc=0 was requested.
554 2007-06-11 Murray Cumming <murrayc@murrayc.com>
556 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
557 (easysetup_provider_combo_box_fill): Remove debug code that showed the
558 provider ID in the combo.
560 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
561 Do not show the page numbers, because it would be confusing when we add
562 the 2 extra pages for the custom setup, when the user chooses the "Other"
563 provider. This fixes projects.maemo.org bug NB#59028
565 * src/modest-init.c: (modest_init_init_core),
566 (modest_init_local_folders):
568 * src/modest-tny-account.c:
569 (modest_tny_account_new_for_local_folders): Do not create default folders
570 for the memory card. This should fix projects.maemo.org bug NB#59328.
572 2007-06-11 Murray Cumming <murrayc@murrayc.com>
574 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
575 Free the changed_conf_keys string items. They are already freed in the
576 idle handler if that runs first.
578 2007-06-11 Murray Cumming <murrayc@murrayc.com>
580 * src/modest-ui-actions.c:
581 (modest_ui_actions_on_password_requested): Check that the server name
582 is not NULL, because I just saw a password dialog with (null) as the
585 * src/modest-tny-folder.[h|c]: Added
586 modest_tny_folder_is_memory_card_folder().
587 * src/modest-ui-dimming-rules.c:
588 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
589 menu item for memory cards, as per the UI spec (section 7.4). This should
590 fix projects.maemo.org bug NB#59297.
592 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
594 * src/maemo/modest-main-window.c: (sync_accounts_cb):
595 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
596 is another problem with the code, see Murray's comment at line 772)
598 2007-06-08 Murray Cumming <murrayc@murrayc.com>
600 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
601 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
602 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
603 (load_from_file), (easysetup_country_combo_box_init),
604 (easysetup_country_combo_box_get_active_country_ids),
605 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
606 instead of just one ID, to avoid duplicate country names in the UI.
608 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
609 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
610 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
611 a single ID, avoiding duplicate providers.
612 * src/maemo/easysetup/modest-easysetup-wizard.c:
613 (on_combo_account_country): Adapt to use a list.
615 2007-06-08 Murray Cumming <murrayc@murrayc.com>
617 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
618 keys changed in the last X seconds.
620 * src/modest-account-mgr.h:
621 * src/modest-account-mgr.c: (on_timeout_notify_changes),
622 (on_key_change), (modest_account_mgr_class_init),
623 (modest_account_mgr_init), (modest_account_mgr_finalize):
624 As the keys are changed, save them in a GSList* and signal that GSList*
625 further every X seconds, to batch changes, to allow us to do just one
626 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
627 bug NB#56941 and other (UI-blocking) delays when changing account settings.
629 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
630 changed signal signature.
632 * src/modest-conf.c: (modest_conf_set_list),
633 (modest_conf_on_change): Reenable notification.
635 (modest_conf_maemo_fake_on_change): Comment out the hack that
636 notified immediately instead of asynchronously.
638 * src/widgets/modest-account-view.h:
639 * src/widgets/modest-account-view.c:
640 (update_account_view): Select the previously-selected account ID,
641 if possible. This fixes projects.maemo.org bug NB#56933.
643 (on_account_changed), (on_account_removed),
644 (modest_account_view_select_account):
646 Remove the block/unblock functions
647 because they were not useful.
649 * src/maemo/modest-account-view-window.c:
650 (on_delete_button_clicked), (on_edit_button_clicked),
651 (on_new_button_clicked): Remove the use of the non-working block/unblock.
653 2007-06-08 Murray Cumming <murrayc@murrayc.com>
655 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
656 Improve the error dialog to show Incorrect Account Settings, which seems
657 clearer, and say that the internal error message (to be removed from the
658 dialog later) is often misleading.
659 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
661 * src/modest-tny-account.c:
662 (modest_tny_account_new_from_server_account): Uncomment the printf of the
663 URL because this is so useful for debugging on the device.
665 * src/widgets/modest-serversecurity-combo-box.c:
666 (modest_serversecurity_combo_box_fill): Correct a logical ID.
668 2007-06-08 Murray Cumming <murrayc@murrayc.com>
670 * src/modest-mail-operation.c:
671 (modest_mail_operation_send_new_mail):
672 Added a comment about a nasty but apparently harmless message. Details
673 added to the wiki g_warnings() page.
675 2007-06-08 Murray Cumming <murrayc@murrayc.com>
677 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
678 (modest_tny_send_queue_class_init):
679 Do not use the priv struct because it is empty, to avoid g_warnings
680 about a non-existant priv struct.
682 * src/modest-tny-account-store.c:
683 (modest_tny_account_store_get_server_account),
684 (modest_tny_account_store_get_transport_account_for_open_connection
685 ): Do not try to get transport server accounts for local folders,
686 because they don't have any. This avoids a g_warning().
688 * src/maemo/modest-main-window.c:
689 (modest_main_window_notify_send_receive_initied),
690 (on_configuration_key_changed):
691 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
693 * src/modest-mail-operation.c:
694 (modest_mail_operation_update_account):
695 * src/modest-tny-account-store.h:
696 * src/modest-tny-account.c:
697 (modest_tny_account_get_special_folder),
698 (modest_tny_account_new_for_local_folders),
699 (modest_tny_account_new_for_per_account_local_outbox_folder):
700 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
701 * src/modest-tny-local-folders-account.c:
702 (add_account_folders_to_merged_folder):
703 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
704 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
705 (modest_ui_actions_on_send):
706 * src/widgets/modest-folder-view.c: (update_model):
707 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
708 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
709 modest_tny_account_store_get_tny_account_by_account() to
710 modest_tny_account_store_get_server_account() to make the code clearer.
712 2007-06-07 Marcus Bauer <marcusb@openismus.com>
714 * src/dbus_api/modest-dbus-api.h:
715 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
716 * src/maemo/modest-msg-edit-window.c:
717 (modest_msg_edit_window_attach_file_noninteractive):
718 added g_warning in case the file to be attached does not exist
719 * tests/dbus_api/test_compose_mail.c: (main):
720 removed obsolete comment, added generic files as test case
722 2007-06-07 Murray Cumming <murrayc@murrayc.com>
724 * src/modest-tny-account-store.c: (get_server_accounts):
725 Create the local folders account only once, not once for each outbox, and
726 not only when there are some outboxes.
728 2007-06-07 Murray Cumming <murrayc@murrayc.com>
730 * src/widgets/modest-folder-view.c: (update_model): Comment out some
731 code that is causing a crash at startup. Sergio says that he is fixing this.
733 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
735 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
736 * src/maemo/modest-account-settings-dialog.c:
737 (create_page_outgoing),
738 (modest_account_settings_dialog_set_account_name),
739 (save_configuration):
740 - Fixed handling of the "Use secure authentication" toggle to comply with
741 the ui specification. See also projects.maemo.org bug NB#58400
743 - Restore the Secure connection setting combo correctly when loading
746 * src/maemo/modest-maemo-utils.c:
747 (on_camel_account_get_supported_secure_authentication),
748 (modest_maemo_utils_get_supported_secure_authentication_methods):
749 Fixed a crasher if operation is canceled
751 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
752 (modest_protocol_info_auth_is_secure):
753 * src/modest-protocol-info.h:
755 Added two new methods to determine if a protocol/auth method is secure/encrypted in
756 the sense of the "Use secure authentication" toggle.
758 2007-06-07 Murray Cumming <murrayc@murrayc.com>
760 * src/modest-tny-account-store.h:
761 * src/modest-tny-account-store.c:
762 Added modest_tny_account_store_get_local_folders_account().
764 * src/modest-tny-folder.h:
765 * src/modest-tny-folder.c:
766 (modest_tny_folder_get_account):
767 Added this replacement for tny_folder_get_account() which returns
768 the local-folders account for TnyMergeFolders, to avoid the
769 warning about the unimplemented get_account_func() vfunc().
771 (modest_tny_folder_get_rules),
772 * src/modest-ui-actions.c:
773 (modest_ui_actions_on_folder_selection_changed):
774 * src/modest-mail-operation.c:
775 (modest_mail_operation_remove_folder),
776 (modest_mail_operation_xfer_folder),
777 (modest_mail_operation_rename_folder),
778 (modest_mail_operation_get_msg),
779 (modest_mail_operation_get_msgs_full),
780 (modest_mail_operation_remove_msg),
781 (modest_mail_operation_xfer_msgs),
782 (modest_mail_operation_refresh_folder):
783 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
785 2007-06-07 Murray Cumming <murrayc@murrayc.com>
787 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
788 (modest_server_account_set_security):
789 * src/modest-defs.h: Add comments explaining that our
790 UI spec means TLS when it says Normal, so these do not look like errors.
792 * src/modest-tny-account.c:
793 (modest_tny_account_new_from_server_account): Use the new tinymail
794 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
795 for TLS. This should fix projects.maemo.org bug NB#58460.
797 2007-06-06 Murray Cumming <murrayc@murrayc.com>
799 * src/maemo/easysetup/modest-easysetup-wizard.c:
800 (create_account): Correct the position of the gconf sanity check warning.
801 (on_button_edit_advanced_settings): Show the dialog immediately, instead
802 of using the g_idle_add() hack, because this does not seem to be necessary
803 on osso 1.1. It might even work on Maemo Bora if the problems were actually
804 caused by something other than maemo's gconf.
805 This fixes projects.maemo.org bug #59022.
807 2007-06-06 Murray Cumming <murrayc@murrayc.com>
809 * src/modest-account-mgr-helpers.c:
810 (modest_account_mgr_get_default_account): Do not check that the account
811 exists if there is no default account (NULL), to fix a runtime warning.
813 2007-06-06 Murray Cumming <murrayc@murrayc.com>
815 * src/widgets/modest-folder-view.c: (update_model):
816 Do not unref the treemodel before we have finished with it.
817 This prevents a valgrind warning and an occasional crash at startup.
819 2007-06-06 Marcus Bauer <marcusb@openismus.com>
821 * libmodest-dbus-client/libmodest-dbus-client.h:
822 added libmodest_dbus_client_compose_mail()
823 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
825 added functions needed for SendAsMail() functionality
826 * src/maemo/modest-msg-edit-window.c:
827 (modest_msg_edit_window_attach_file_noninteractive):
828 non interactively attaching files to message edit window
829 * src/widgets/modest-msg-edit-window.h:
830 * tests/dbus_api/Makefile.am:
831 added test_compose_mail.c
832 * tests/dbus_api/test_compose_mail.c: (main):
834 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
836 * src/modest-account-view.c:
837 Fixed bug projects.maemo.org bug NB#59307
839 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
841 * src/maemo/easysetup/modest-easysetup-wizard.c:
842 (get_serverport_incoming), (on_before_next), (create_account):
843 * src/maemo/modest-account-settings-dialog.c:
844 (modest_account_settings_dialog_set_account_name):
845 * src/maemo/modest-maemo-utils.c:
846 (on_camel_account_get_supported_secure_authentication_status),
847 (on_camel_account_get_supported_secure_authentication),
848 (on_secure_auth_cancel),
849 (modest_maemo_utils_get_supported_secure_authentication_methods):
851 Implemented security authentication for settings and easysetup.
853 2007-06-05 Murray Cumming <murrayc@murrayc.com>
855 * src/maemo/modest-main-window.c: (create_details_widget):
856 Show the total size for memory card accounts too, instead of showing
857 the name again. Fixes bug projects.maemo.org bug NB#59307.
859 2007-06-05 Murray Cumming <murrayc@murrayc.com>
862 * src/modest-tny-simple-folder-store.c:
863 * src/modest-tny-simple-folder-store.h: Removed.
865 * src/modest-tny-local-folders-account.h
866 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
867 for the local-folders maildir, with an extra TnyMergedFolder containing
868 the folders of the per-account outbox store accounts.
869 * src/modest-tny-account-store.c: (get_server_accounts):
870 Add the outboxes to the special local folders account after creating it.
872 * src/modest-tny-account.c:
873 (modest_tny_account_new_for_local_folders): Create the derived
874 account when creating the main local-folders account.
876 * src/maemo/modest-main-window.c: (create_details_widget),
877 (modest_main_window_set_contents_style):
878 Adapted to the use of the derived account instead of the folder store.
880 * src/modest-ui-actions.c:
881 (modest_ui_actions_on_folder_selection_changed):
882 * src/modest-ui-dimming-rules.c:
883 (modest_ui_dimming_rules_on_new_folder):
884 * src/widgets/modest-folder-view.c: (text_cell_data),
885 (icon_cell_data), (filter_row), (update_model),
886 (get_cmp_rows_type_pos):
889 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
890 Do not get the priv struct, because no priv struct has been set,
891 to avoid a runtime warning.
893 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
894 #ifelse with #else, to fix a warning, to fix the build.
897 2007-06-05 Christian Kellner <ckellner@openismus.com>
899 * libmodest-dbus-client/libmodest-dbus-client.c:
900 Fix small typo in doc (why do you always see them
901 AFTER committing stuff?)
904 2007-06-05 Christian Kellner <ckellner@openismus.com>
906 * libmodest-dbus-client/libmodest-dbus-client.c:
907 (libmodest_dbus_client_search):
908 Initialize hit list with NULL. Also set folder list
909 to "" if NULL was supplied.
912 2007-06-03 Christian Kellner <ckellner@openismus.com>
914 * libmodest-dbus-client/libmodest-dbus-client.c:
915 (modest_search_hit_list_free):
916 Make it save to call it with NULL.
918 * src/dbus_api/modest-dbus-callbacks.c:
919 * src/modest-search.c:
920 Return full ModestSearchHits as the search result list not TnyHeader
921 since can't be around withouth the correspoding TnyFolder.
923 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
925 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
926 Added currently commented code to check for secure auth
928 * src/maemo/modest-account-settings-dialog.c: (on_response),
929 (save_configuration), (show_ok):
930 Fixed projects.maemo.org bugs NB #59248 and #59251
932 * src/maemo/modest-maemo-utils.c:
933 (on_camel_account_get_supported_secure_authentication_status),
934 (on_camel_account_get_supported_secure_authentication),
935 (modest_maemo_utils_get_supported_secure_authentication_methods):
936 * src/maemo/modest-maemo-utils.h:
937 Moved get_supported_secure_authentication() method here to be able
938 to use it from easysetup wizard.
940 * src/modest-pair.c: (on_pair_compare_as_string):
941 Should compare string with first part of pair and not
942 strcmp pairs which will crash.
944 * src/modest-protocol-info.c:
945 (modest_protocol_info_protocol_is_store):
946 * src/modest-protocol-info.h:
947 Added modest_protocol_info_get_auth_protocol_name()
949 2007-06-03 Armin Burgmeier <armin@openismus.com>
951 * src/modest-mail-operation.c:
952 (modest_mail_operation_get_msgs_full): Set priv->account also when
953 only retrieving a single message. This avoids a crash when canceling
956 (modest_mail_operation_notify_end): Do not explicitely remove the
957 operation from the queue but only emit the progress_changed signal.
958 The queue itself listens to that signal to remove the operation when
959 it is finished. This reduces coupling and removes a potential deadlock
960 when modest_mail_operation_notify_end() is called from the queue
961 itself. If that is a problem performance-wise, I would suggest to
962 implement a status-changed signal or something.
964 * src/modest-mail-operation-queue.c: Make sure to never call a
965 function from another file while the queue is locked. This (hopefully)
966 fixes another deadlock when exiting the application while retrieving
969 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
971 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
972 Fixed build if libogs is not available
974 2007-06-03 Christian Kellner <ckellner@openismus.com>
976 * libmodest-dbus-client/libmodest-dbus-client.h:
977 * libmodest-dbus-client/libmodest-dbus-client.c:
978 (libmodest_dbus_client_delete_message):
979 Implement deletion of messages (Client side).
981 (modest_search_hit_free),
982 (modest_search_hit_list_free):
983 Utility functions to free the result hits.
985 * src/dbus_api/modest-dbus-api.h:
986 * src/dbus_api/modest-dbus-callbacks.c:
988 (modest_dbus_req_handler):
989 Implement deletion of messages (Server side).
991 * tests/dbus_api/test_search.c: (main):
994 * tests/dbus_api/Makefile.am:
995 * tests/dbus_api/test_delete_message:
996 Add little test for the message deletion logic
998 2007-06-03 Armin Burgmeier <armin@openismus.com>
1000 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1001 when the operation queue was not empty. projects.maemo.org bug
1004 2007-06-03 Armin Burgmeier <armin@openismus.com>
1006 * src/widgets/modest-account-view.c
1007 (on_account_default_toggled): Toggle default account column
1008 explicitely instead of waiting for gconf notification (which is
1009 currently ignored). This should fix projects.maemo.org bug NB#56910
1010 for now. It should probably be removed when gconf notifications are
1013 2007-06-03 Christian Kellner <ckellner@openismus.com>
1015 * libmodest-dbus-client/libmodest-dbus-client.c:
1016 Removed debugging spew.
1018 * src/dbus_api/modest-dbus-callbacks.c:
1019 Added debugging info.
1021 * src/modest-search.c:
1022 (modest_search_all_accounts):
1023 Use tny_account_store_get_accounts () on the account store
1024 to get all accounts which is the way to get all accounts.
1026 * tests/dbus_api/test_search.c: (main):
1027 Make it possible to supply the search term on the command line.
1029 2007-06-03 Christian Kellner <ckellner@openismus.com>
1031 * libmodest-dbus-client/libmodest-dbus-client.c:
1032 * libmodest-dbus-client/libmodest-dbus-client.h:
1033 Implement searching for mesages over raw dbus. (Client side)
1035 * src/dbus_api/Makefile.am:
1036 * src/dbus_api/modest-dbus-api.h:
1037 * src/dbus_api/modest-dbus-callbacks.c:
1038 * src/dbus_api/modest-dbus-callbacks.h:
1039 Search framework (Server side). Also implement on_idle_open_message().
1041 * src/maemo/modest-platform.c: (modest_platform_init):
1042 Prepare for raw dbus/osso rpc interaction.
1044 * src/modest-search.h:
1045 Changed minsize from unspecific guint to guint32.
1047 * src/modest-search.c:
1049 Added strange hack which magically made tnymail work.
1051 (modest_search_folder),
1052 (modest_search_account),
1053 (modest_search_all_accounts):
1054 Implement helper functions to search all accounts, specific account
1057 * tests/dbus_api/Makefile.am:
1058 * tests/dbus_api/test_open_message.c:
1059 Read url to open from commandline.
1061 * tests/dbus_api/test_search.c:
1062 Implement small test for dbus search stuff
1064 2007-06-02 Armin Burgmeier <armin@openismus.com>
1066 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1067 include account type and account title. This fixes projects.maemo.org
1070 * src/maemo/modest-account-view-window.c: Set a title for the window.
1072 2007-06-02 Armin Burgmeier <armin@openismus.com>
1074 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1075 incoming and outgoing server name based on email address and server
1076 types as long as the names have not been edited manually. This fixes
1077 projects.maemo.org bug NB#58671.
1079 2007-06-02 Armin Burgmeier <armin@openismus.com>
1081 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1082 server type cannot be changed in future to the incoming details page
1083 when creating an account. This fixes projects.maemo.org bug NB#59029.
1085 2007-06-02 Armin Burgmeier <armin@openismus.com>
1087 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1088 and assigned max width chars so that they wrap instead of being
1089 truncated. Fixes projects.maemo.org bug NB#56126.
1091 2007-06-02 Armin Burgmeier <armin@openismus.com>
1093 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1094 introductory note to the connection specific smtp servers dialog, as
1095 section 8.12 of the email UI specification requires. This fixes
1096 projects.maemo.org bug NB#59212.
1098 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1100 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1101 Check for running mail operations, and offer to cancel them, as per the UI
1102 spec. This fixes projects.maemo.org bug NB#59041 .
1103 However, I suspect that tinymail may still use the network connection
1104 in ways that we cannot detect or cancel. But it should at least adapt to
1105 changes fairly well.
1107 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1109 * src/modest-tny-account-store.c: (recreate_all_accounts),
1110 (get_cached_accounts), (get_server_accounts): Do more sensible
1111 ref-counting of the temporarily-cached outbox accounts list. This seems
1112 to fix a crash when entering the password when the password was wrong.
1114 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1116 * src/gnome/modest-main-window.c: (connect_signals):
1117 * src/modest-tny-account-store.c: (get_password),
1118 (modest_tny_account_store_alert): Added comments and clues and
1119 commented-out code about how we currently fail to deal with connection
1120 errors and wrong passwords, and how we should.
1122 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1124 * src/widgets/modest-retrieve-combo-box.c:
1125 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1126 This fixes projects.maemo.org bug NB#58472 .
1128 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1130 * src/maemo/easysetup/modest-easysetup-wizard.c:
1131 (create_page_complete_easysetup):
1132 (create_page_complete_custom): Correct the last commit,
1133 putting the correct sentences in the correct pages.
1135 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1137 * src/maemo/easysetup/modest-easysetup-wizard.c:
1138 (create_page_complete_custom): Show the second sentence of text
1139 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1142 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1144 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1145 Set the leave-on-server conf key by default. This fixes
1146 projects.maemo.org bug NB#59258 .
1148 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1150 * src/maemo/modest-account-view-window.c:
1151 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1152 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1155 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1157 * src/maemo/easysetup/modest-easysetup-wizard.c:
1158 (create_caption_new_with_asterisk):
1159 * src/maemo/modest-account-settings-dialog.c:
1160 (create_caption_new_with_asterisk):
1161 Uncomment the code to add the asterisk, because they are no longer in the
1162 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1163 (update_incoming_server_title): Add an asterisk here too.
1165 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1167 * src/maemo/modest-maemo-global-settings-dialog.c:
1168 (current_connection): Check that we are even connected before trying to
1169 get the current connection name, to prevent a warning.
1171 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1172 Change the comments because tny_maemo_conic_device_connect() is now meant to
1174 * src/modest-mail-operation.c:
1175 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1176 make sure we have a connection and fail if we can't connect.
1178 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1180 * src/maemo/modest-main-window.c:
1181 (on_account_store_connecting_finished): Do not try to get the
1182 connection ID if we are not really connected. I am surprised that
1183 this signal handler is called when we are not connected.
1185 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1187 * src/modest-error.h:
1188 * src/modest-ui-actions.c:
1189 (modest_ui_actions_get_msgs_full_error_handler):
1190 Renamed an enum, added comments, added an enum
1191 for retrieve-limit errors.
1193 * src/modest-mail-operation.c: (foreach_add_item),
1194 (internal_folder_observer_update), (update_account_thread),
1195 (modest_mail_operation_get_msgs_full):
1196 (modest_mail_operation_update_account),
1197 Added comments about how this works, and some code that should
1198 (but does not) check the retrieve-limit. See the TODO comment.
1200 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1202 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1203 Initialize help_id to fix the build. Warnings are good.
1205 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1207 * src/widgets/modest-hbox-cell-renderer.c:
1208 (modest_hbox_cell_renderer_append):
1209 * src/widgets/modest-vbox-cell-renderer.c:
1210 (modest_vbox_cell_renderer_append):
1211 Fix the last commit by doing an extra ref.
1213 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1215 * src/widgets/modest-hbox-cell-renderer.c:
1216 (modest_hbox_cell_renderer_append):
1217 * src/widgets/modest-vbox-cell-renderer.c:
1218 (modest_vbox_cell_renderer_append):
1219 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1220 to fix the build with Maemo Bora.
1221 However, there seems to be a remaining crash, probably due to reference
1224 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1226 * src/modest-tny-account.c:
1227 (modest_tny_account_new_for_local_folders):
1228 Use hildon_file_system_info_async_new() to get a better name for
1229 the memory card account, setting it as the account name.
1230 The timing seems to work, but this is probably
1231 not the best place to do this. See the TODO comment.
1232 * src/maemo/modest-main-window.c: (create_details_widget):
1233 * src/widgets/modest-folder-view.c: (text_cell_data):
1234 Use the tny account name instead of hardcoding a name.
1236 2007-05-30 Christian Kellner <ckellner@openismus.com>
1238 * src/modest-search.c: (modest_search):
1239 Correctly set part_search_func even if we have already parsed
1240 the query and thus a valid OgsTextSearcher object.
1242 2007-05-30 Christian Kellner <ckellner@openismus.com>
1245 Search and check for libogs.
1248 Incooparte the ogs build env.
1250 * src/modest-mime-part-search-stream.c:
1251 * src/modest-mime-part-search-stream.h:
1252 Removed since we do the real searching now in modest-search.c.
1254 * src/modest-search.c:
1255 * src/modest-search.h:
1256 Implement support for ogs. We use that if available and requested
1257 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1258 should now handle the corner case when the search term is spread
1259 across multiple reads.
1260 Also the logic in modest_search () was corrected to search all
1261 requested fields until one is found.
1263 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1265 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1267 * src/modest-init.h:
1268 * src/modest-init.c: Made modest_init_local_folders() take a
1269 path and be public so we can iniitialize maildir folders on
1272 * src/modest-local-folder-info.h:
1273 * src/modest-local-folder-info.c:
1274 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1276 * src/modest-tny-account.c:
1277 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1278 still means the standard local-folders path on the local volume.
1280 * src/modest-tny-account-store.c:
1281 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1282 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1283 all accounts when that happens.
1284 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1285 this too, so it shows up in the treeview.
1287 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1289 * src/maemo/modest-maemo-global-settings-dialog.c:
1290 (current_connection):
1291 * src/widgets/modest-global-settings-dialog.c:
1292 (current_connection_default):
1293 Use the enum values instead of 0, 1 and -1,
1294 to make the code clearer.
1296 * src/modest-account-mgr-helpers.c:
1297 (modest_account_mgr_get_connection_specific_smtp): Make this code
1300 * src/modest-runtime.h:
1301 * src/modest-runtime.c:
1302 Added modest_runtime_remove_all_send_queues().
1303 * src/maemo/modest-main-window.c:
1304 (on_account_store_connecting_finished): Recreate the send queues,
1305 using the appropriate transport accounts for this new connection.
1306 Some futher adapting might be needed if the old send queues are not
1307 automatically stopped at this point.
1309 * src/modest-tny-account-store.c: (get_server_accounts):
1310 Create the connection-specific transport accounts, so that they can
1311 be found later by their ID.
1313 * src/modest-tny-account.h:
1314 * src/modest-tny-account.c:
1315 Added modest_tny_account_new_from_server_account_name().
1316 modest_tny_account_new_from_server_account(): Do not create the
1317 send queues here, because they will be
1318 recreated anyway when the connection changes for the first time.
1320 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1322 * src/modest-local-folder-info.h:
1323 * src/modest-local-folder-info.c:
1324 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1325 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1326 tbox_folder): Take a modest account name instead of a server TnyAccount,
1327 so we can have per-modest-account rather than per-transport-account
1329 We must make sure that we change or recreate the exisitng send queues
1330 when the connection changes for connection-specific transport accounts.
1332 * src/modest-tny-account-store.c:
1333 (create_per_account_local_outbox_folders): Create outboxed per modest
1334 account, not per transport account.
1336 * src/modest-tny-account.h:
1337 * src/modest-tny-account.c:
1338 (modest_tny_account_get_special_folder): For outboxes, get the
1339 parent modest account name. The account is ignored for other folders.
1340 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1341 modest account name rather than a server TnyAccount.
1343 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1345 * src/modest-tny-account.c:
1346 (modest_tny_account_new_from_server_account):
1347 Call modest_runtime_get_send_queue() immediately after creating transport
1348 accounts, so that they start trying to send email from the outbox as soon
1349 as possible at startup. This is probably what we want.
1351 * src/modest-mail-operation.c: (update_account_thread):
1352 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1353 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1354 * src/modest-tny-send-queue.h:
1355 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1356 (modest_ui_actions_on_send):
1357 Added comments about how sending works, though it needs some more work.
1359 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1361 * src/modest-tny-account.c:
1362 (modest_tny_account_get_special_folder): Add TODO because this fails when
1363 the network is busy.
1364 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1365 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1366 Do not try to show this window when there is no active account. The UI
1367 specs does not tell us what to do in this case.
1369 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1373 * src/maemo/Makefile.am:
1374 * src/widgets/Makefile.am: Some dist fixes.
1376 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1378 * src/maemo/modest-connection-specific-smtp-window.c:
1379 (on_button_edit): Make the code clearer, to prevent a double free.
1381 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1383 * src/maemo/modest-account-settings-dialog.c:
1384 (modest_account_settings_dialog_set_account_name),
1385 Check the connection-specific smtp servers checkbox if there are any.
1387 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1388 (modest_connection_specific_smtp_edit_window_init):
1389 Start with a suitable port number.
1391 * src/modest-account-mgr-helpers.h:
1392 * src/modest-account-mgr-helpers.c: Added
1393 modest_account_mgr_get_has_connection_specific_smtp().
1395 (modest_account_mgr_set_connection_specific_smtp),
1396 (modest_account_mgr_remove_connection_specific_smtp),
1397 (modest_account_mgr_get_has_connection_specific_smtp),
1398 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1399 connection-specific smtp server accounts in the account, rather than
1400 the server account conf dir.
1402 This fixes bug projects.maemo.org bug NB#58263 .
1404 * src/modest-tny-account-store.c:
1405 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1406 if there are no server accounts yet, to prevent an infinite loop when there
1407 are no accounts. Document that one must be called before the other.
1409 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1411 * src/modest-account-mgr-helpers.c:
1412 (modest_account_mgr_get_default_account): Make sure that at least
1413 one account is always the default, if there are any enabled accounts.
1414 This is just a sanity check that shouldn't be necessary.
1416 * src/modest-account-mgr-priv.c:
1417 (_modest_account_mgr_account_from_key): Unescape the conf key to
1418 get the real account name. For instance, this is an issue if a space
1419 was in the account name, which can happen because the account name
1420 is generated from the display name.
1421 (_modest_account_mgr_get_account_keyname): Always escape the
1423 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1424 Unescape the conf keys to get the real account names.
1426 For instance, previously the is-default radio button in the accounts
1427 list was not checked for any accounts at first. This fixes that,
1428 and might fix several similar bugs.
1430 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1432 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1433 Removed some debug printfs.
1435 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1437 Modest on-disk outbox directories are now here, for instance:
1438 $HOME/.modest/outboxes/<account-id-1>/outbox
1439 $HOME/.modest/outboxes/<account-id-2>/outbox
1441 $HOME/.modest/local-folders/outbox
1442 so we can have a separate outbox for each account.
1443 But they are shown as one outbox in the GtkTreeView, by using a
1444 TnyMergeFolder in a ModestTnySimpleFolderStore.
1447 * src/modest-tny-simple-folder-store.c:
1448 * src/modest-tny-simple-folder-store.h:
1449 Added ModestTnySimpleFolderStore, used to contain folders from
1450 other folder stores, such as other accounts.
1452 * src/modest-tny-outbox-account.h:
1453 * src/modest-tny-outbox-account.c:
1454 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1455 used for the per-account local outbox folders.
1457 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1458 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1459 only use this (internally) now for the non-outbox local folders.
1461 * src/modest-init.h:
1462 * src/modest-init.c: Added modest_init_one_local_folder(), for
1463 setting up the directory structure for each local folder.
1465 * src/modest-local-folder-info.c:
1466 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1467 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1469 * src/modest-local-folder-info.h:
1470 * src/modest-tny-account-store.c: (on_account_removed),
1471 (on_account_changed), (create_per_account_local_outbox_folders),
1472 (get_server_accounts), (modest_tny_account_store_get_accounts),
1473 (modest_tny_account_store_get_tny_account_by_account),
1474 (modest_tny_folder_store_is_virtual_local_folders):
1476 * src/modest-tny-account.h:
1477 * src/modest-tny-account.c:
1478 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1479 to create an on-disk per-account local outbox folder for each
1481 (create_per_account_local_outbox_folders): Create a local outbox folder
1482 for each transport account.
1483 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1484 for all local folders.
1486 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1487 instead of using g_object_get/set() directly. It is clearer.
1489 (modest_tny_folder_store_get_message_count),
1490 (modest_tny_folder_store_get_local_size
1491 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1492 because we now use these with non-acount folder stores.
1494 (modest_tny_account_get_special_folder),
1495 (modest_tny_account_new_from_server_account),
1496 (modest_tny_account_new_from_account):
1497 (recurse_folders): Adjust to the new outbox system.
1499 * src/modest-tny-folder.h:
1500 * src/modest-tny-folder.c:
1501 (modest_tny_folder_is_local_folder),
1502 (modest_tny_folder_get_local_folder_type),
1503 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1505 * src/widgets/modest-main-window.h:
1506 * src/maemo/modest-main-window.c: (create_details_widget),
1507 (modest_main_window_set_contents_style): Show details for any folder store,
1510 (modest_tny_folder_get_rules):
1511 Remove the const. C does not support constness enough for this.
1513 * src/modest-ui-actions.c:
1514 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1515 make all outboxes appear as one, in the usual local-folders tree node.
1517 (set_active_account_from_tny_account),
1518 (modest_ui_actions_on_folder_selection_changed):
1519 * src/widgets/modest-folder-view.c: (text_cell_data),
1520 (icon_cell_data), (filter_row),
1521 (add_account_folders_to_merged_folder),
1522 (add_account_folders_to_simple_folder_store), (),
1523 (get_cmp_rows_type_pos), (cmp_rows),
1524 (modest_folder_view_set_account_id_of_visible_server_account):
1525 Adjust to the new outbox system, using generic folder stores and folders
1526 in the GtkTreeModel.
1528 2007-05-23 Christian Kellner <ckellner@openismus.com>
1530 * src/modest-mail-operation.c:
1531 (modest_mail_operation_update_account):
1532 Use info->max_size instead of unintialized local var [small
1533 build fix]. (Added TODO to review that change since I don't
1536 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1538 * libmodest-dbus-client/libmodest-dbus-client.c:
1539 (libmodest_dbus_client_compose_mail): function added
1540 * src/dbus_api/modest-dbus-api.h:
1541 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1542 (on_compose_mail): Implementation of the SendAsMail functionality
1544 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1546 * src/modest-account-mgr.c:
1547 (modest_account_mgr_add_server_account): Set the secure-connection
1548 conf key for transport accounts as well as store accounts. I don't know
1549 why the if was there. For instance, this makes sure that we use SSL
1550 for the gmail preset from the easysetup wizard.
1552 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1554 * src/gnome/modest-main-window.c:
1555 (on_account_store_connecting_finished), (connect_signals):
1556 * src/maemo/modest-main-window.c:
1557 (on_account_store_connecting_finished), (connect_signals),
1558 (modest_main_window_new):
1559 Handle TnyAccountStore::connecting-finished instead of
1560 TnyDevice::connection-changed, because we cannot actually perform
1561 operations on accounts until TnyAccountStore has itself responded to
1562 the TnyDevice::connection-changed signal. This prevents a GError from
1564 Do not try to update at startup, because we (at least on scratchbox)
1565 already do an update at startup when the device goes online.
1566 This prevents a GError from tinymail.
1567 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1568 Added TODO about stopping simultaneous operations.
1570 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1572 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1573 * src/modest-mail-operation-queue.c:
1574 (modest_mail_operation_queue_remove):
1575 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1576 about where they happened.
1578 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1580 * src/modest-ui-actions.c:
1581 (modest_ui_actions_on_password_requested): Make sure that the remember
1582 output parameter is always TRUE.
1584 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1586 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1587 Show a OK/Cancel dialog if the error is a question, though we still do not
1588 know anything more about what we are asking the user.
1589 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1590 Fix an uninitialized variable (helper). This is a logic error, however.
1592 2007-05-21 Christian Kellner <ckellner@openismus.com>
1594 * src/modest-search.h:
1595 Correct bit shifting in the ModestSearchFlags enum.
1597 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1599 * src/modest-tny-account.c:
1600 (modest_tny_account_new_from_server_account): Do not use the lsub and
1601 check-all hard-coded IMAP options when using POP.
1603 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1605 * src/modest-tny-account.c:
1606 (modest_tny_account_new_from_server_account):
1607 Use NULL for the secure-auth method for POP when Password auth has been
1608 specified by the user, as we already do for IMAP. "auth=Login" causes
1609 an error from camel or the server.
1611 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1613 * src/maemo/modest-account-settings-dialog.c:
1614 (create_page_account_details),
1615 (modest_account_settings_dialog_set_account_name):
1616 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1617 for the leave-on-server checkbox, rathr than just the checkbox, when
1618 the protocol is not POP.
1620 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1622 * src/widgets/modest-account-view.c:
1623 * src/widgets/modest-account-view.h:
1624 Added modest_account_view_select_account() which will be useful later
1625 to asynchronously re-select the edited account.
1627 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1629 * src/maemo/modest-account-settings-dialog.c:
1630 (modest_account_settings_dialog_set_account_name):
1631 Automatically choose the port numbers based on the secure authentication
1632 methods, if they have not been chosen before.
1633 This fixes projects.maemo.org bug NB#56273 .
1635 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1637 * src/maemo/modest-main-window-ui.h:
1638 * src/modest-ui-actions.c:
1639 * src/modest-ui-actions.h:
1640 Connect the Tools/SMTP Servers menu item to
1641 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1642 SMTP servers dialog, as in the UI specification and saves changes when it
1643 is closed. This fixed projects.maemo.org bug NB#56305 .
1645 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1647 * src/maemo/modest-connection-specific-smtp-window.c:
1648 (modest_connection_specific_smtp_window_init):
1649 Use gtk_window_set_default_size() to make this window big enough, so
1650 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1652 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1654 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1655 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1656 (modest_connection_specific_smtp_edit_window_init),
1657 Do not try to connect to a combobox signal before the combobox exists.
1658 This fixes the cras in projects.maemo.org bug NB#56288 .
1659 (modest_connection_specific_smtp_edit_window_get_settings):
1660 Remove the server_account_name parameter which was being checked for NULL
1661 though it was not used.
1663 * src/maemo/modest-connection-specific-smtp-window.c:
1664 (modest_connection_specific_smtp_window_fill_with_connections),
1665 (on_button_edit), (modest_connection_specific_smtp_window_init):
1666 Correct the number of treemodel columns to prevent a warning.
1667 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1668 libconic does not work.
1670 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1672 * src/modest-tny-account.c:
1673 (modest_tny_account_new_from_server_account):
1674 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1675 SMTP when "None" was chosen by the user. However, with my SMTP server that
1676 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1679 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1681 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1682 to explain the memory management issue with the ID in the ModestPair.
1684 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1685 (add_sending_page), (modest_account_assistant_finalize):
1686 * src/gnome/modest-gnome-global-settings-dialog.c:
1687 (create_updating_page), (create_composing_page):
1688 * src/gnome/modest-msg-edit-window.c: (get_transports),
1689 (init_window), (modest_msg_edit_window_finalize),
1690 (modest_msg_edit_window_get_msg_data):
1691 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1692 * src/gnome/modest-transport-widget.c:
1693 (modest_transport_widget_finalize), (smtp_configuration):
1694 * src/maemo/modest-maemo-global-settings-dialog.c:
1695 (create_updating_page), (create_composing_page):
1696 * src/maemo/modest-msg-edit-window.c: (get_transports),
1697 (init_window), (modest_msg_edit_window_finalize),
1698 (modest_msg_edit_window_get_msg_data),
1699 (modest_msg_edit_window_free_msg_data):
1700 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1701 (modest_store_widget_finalize):
1702 * src/maemo/modest-transport-widget.c:
1703 (modest_transport_widget_finalize), (smtp_configuration):
1704 * src/modest-main.c: (send_mail):
1705 * src/widgets/modest-combo-box.h:
1706 * src/widgets/modest-global-settings-dialog-priv.h:
1707 * src/widgets/modest-global-settings-dialog.c:
1708 (modest_global_settings_dialog_finalize):
1709 * src/widgets/modest-msg-edit-window.h:
1710 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1711 as long as the combo box, to prevent use of freed memory for the ID.
1713 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1715 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1716 get_accounts(), to make this clearer. Do not check for the enabled gconf
1717 key, because we do not use this for server accounts (at least, not yet).
1718 This allows us to send email again.
1720 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1722 * src/maemo/modest-platform.c:
1723 (on_modest_conf_update_interval_changed), (modest_platform_init):
1724 Only respond to this particular key change. All these strcmp()s cannot be
1727 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1729 * src/maemo/modest-maemo-global-settings-dialog.c:
1730 (current_connection): Prevent a crash in scratchbox when
1731 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1732 * src/maemo/modest-platform.c:
1733 (on_modest_conf_update_interval_changed), (modest_platform_init):
1734 Get the update interval from gconf and reset it when the gconf key changes.
1736 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1738 * src/modest-protocol-info.c:
1739 * src/modest-protocol-info.h: Adde enum-specific get functions,
1740 instead of using a ModestProtocolType enum parameter.
1742 * src/gnome/modest-account-assistant.c:
1743 * src/gnome/modest-store-widget.c:
1744 * src/gnome/modest-store-widget.h:
1745 * src/gnome/modest-transport-widget.c:
1746 * src/gnome/modest-transport-widget.h:
1747 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1748 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1749 * src/maemo/easysetup/modest-easysetup-wizard.c:
1750 * src/maemo/modest-account-settings-dialog.c:
1751 * src/maemo/modest-account-settings-dialog.h:
1752 * src/maemo/modest-store-widget.c:
1753 * src/maemo/modest-store-widget.h:
1754 * src/maemo/modest-transport-widget.c:
1755 * src/maemo/modest-transport-widget.h:
1756 * src/modest-account-mgr-helpers.c:
1757 * src/modest-account-mgr-helpers.h:
1758 * src/modest-account-mgr.c:
1759 * src/modest-account-mgr.h:
1760 * src/modest-tny-account.c:
1761 * src/modest-tny-folder.c:
1762 * src/widgets/modest-account-view.c:
1763 * src/widgets/modest-retrieve-combo-box.c:
1764 * src/widgets/modest-retrieve-combo-box.h:
1765 * src/widgets/modest-secureauth-combo-box.c:
1766 * src/widgets/modest-serversecurity-combo-box.c:
1767 * src/widgets/modest-serversecurity-combo-box.h:
1768 * tests/check_account-mgr.c:
1769 Use the specific functions, and use the re-renamed enum values for GNOME too.
1771 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1773 * src/modest-pair.h:
1774 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1775 so we can get the second based on the first.
1777 * src/maemo/modest-account-settings-dialog.h:
1778 * src/maemo/modest-account-settings-dialog.c:
1779 Added get_supported_secure_authentication_methods(), though it is mostly
1780 commented-out for now until the necessary API is committed to tinymail.
1781 (modest_account_settings_dialog_set_account_name),
1782 (save_configuration): Request the supported authentication methods from the
1783 server, so we can choose a working method.
1785 * src/modest-tny-account-store.h:
1786 * src/modest-tny-account-store.c:
1787 (modest_tny_account_store_get_session): Rename from
1788 tny_account_store_get_session().
1790 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1792 * src/modest-protocol-info.h: Split the ModestProtocol enum
1793 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1794 There was no need to have these unrelated values in one enum.
1796 * src/: many files: Adapted to changed enum. This makes the code a bit
1797 clearer, and the compiler could catch some errors.
1799 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1801 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1802 Show the detailed internal camel error message when an error happens
1803 during the configuration, so that our testers can give us more clues.
1804 For instance, in projects.maemo.org bug NB#56910 .
1806 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1808 * src/modest-tny-account.c:
1809 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1810 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1812 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1814 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1815 * src/maemo/modest-account-settings-dialog.c:
1816 (modest_account_settings_dialog_set_account_name),
1817 (save_configuration): For the incoming secure authentication checkbox,
1818 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1819 the UI specification. PLAIN does not seem to be supported for most IMAP
1820 servers anyway, and I am not sure what it would mean.
1821 However, we probably need to discover which of the secure-authentication
1822 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1823 * src/modest-account-mgr-helpers.c:
1824 (modest_account_mgr_get_server_account_data):
1826 * src/modest-tny-account.c:
1827 (modest_tny_account_new_from_server_account):
1828 Use tny_account_set_mech() to set secure-authentication methods,
1829 with some special-casing for IMAP, based on my observations of how
1832 * src/modest-account-mgr-helpers.h:
1833 * src/modest-account-mgr.c:
1834 * src/modest-defs.h: Comment that the URI is only used for local folders.
1836 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1838 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1839 parameter const, just to be neat.
1840 * src/modest-text-utils.c: (modest_text_utils_inline):
1841 End g_strconcat() with NULL, as its documentation says. This is almost
1842 certainly the cause of my crash at startup on the device. Interestingly,
1843 valgrind doesn't tell us about these errors.
1845 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1847 * scripts/build-packages: Added more precise comments about how to use
1848 this script, though I still get this error:
1849 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1850 error building tinymail
1852 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1854 * src/maemo/modest-main-window.c: (on_account_update):
1855 Very slight cleanup, hoping to make it simpler to discover what causes
1856 a crash here sometimes.
1858 * src/modest-tny-account.c:
1859 (modest_tny_account_new_from_server_account): Set the port. Added
1860 comments about the options and a TODO comment because I need to find out
1861 how to specify the secure authentication method.
1863 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1865 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1866 changed CFlags paths form modest to libmodest
1868 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1870 * src/modest-account-mgr-helpers.c:
1871 (modest_account_mgr_get_server_account_data),
1872 (modest_account_mgr_free_server_account_data):
1873 * src/modest-account-mgr-helpers.h:
1874 * src/modest-account-mgr.c:
1875 (modest_account_mgr_add_server_account):
1876 * src/modest-defs.h:
1877 * src/modest-tny-account.c:
1878 (modest_tny_account_new_from_server_account):
1879 Determine the options for tny_camel_account_add_option() here,
1880 based on the settings, rather than storing them directly in gconf.
1882 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1884 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1885 Show a more friendly error dialog now that we expect (from the tinymail
1886 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1888 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1890 * src/maemo/modest-main-window.c: (on_account_update): Check that
1891 account_name is not NULL, to prevent a crash at startup that I am
1892 seeing on the N800. I do wonder why it is NULL.
1894 * src/maemo/easysetup/modest-easysetup-wizard.c:
1895 (create_page_user_details):
1896 * src/maemo/modest-account-settings-dialog.c:
1897 (create_page_user_details), (create_page_outgoing):
1898 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1899 (modest_connection_specific_smtp_edit_window_init):
1900 * src/modest-ui-actions.c:
1901 (modest_ui_actions_on_password_requested):
1902 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1903 might do something useful with the on-screen keyboard.
1905 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1907 * src/maemo/modest-main-window.c: (on_account_update):
1908 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1909 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1911 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1913 * src/modest-tny-account-store.c: (on_account_changed):
1914 Correct the signature of this signal handler.
1916 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1918 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1919 Show a HildonNote instead of a GtkDialog for Maemo.
1921 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1923 * src/widgets/modest-account-view.h:
1924 * src/widgets/modest-account-view.c: (on_account_changed),
1925 (on_account_removed). Added a boolean flag, set/unset by
1926 modest_account_view_block_conf_updates(),
1927 modest_account_view_unblock_conf_updates() to prevent unnecessary
1928 updates, but this is not very useful because the gconf notifications are
1929 so delays (maybe only on Maemo Bora).
1930 So auto-updating is turned off, and these functions do an explicit
1931 update when necessary.
1932 However, something else is still doing too much work when adding/removing
1933 accounts, probably in another part of the application.
1935 * src/maemo/modest-account-view-window.c:
1936 (on_delete_button_clicked), (on_edit_button_clicked),
1937 (on_new_button_clicked): Use the new functions.
1939 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1941 * src/modest-account-mgr-helpers.c:
1942 (modest_account_mgr_set_first_account_as_default):
1943 Sort the list of names alphabetically-by-title, so we choose the first one
1945 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1946 alphabetically by the title.
1948 This fixes projects.maemo.org bug NB#56418 .
1950 * src/modest-account-mgr-priv.c:
1951 (_modest_account_mgr_account_from_key):
1952 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1953 avoid a valgrind error, and possible random behaviour.
1955 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1957 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1958 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1959 tinymail documentation to say that this can be expected.
1960 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1961 pretty, and should not happen, but I would prefer to know when it does.
1963 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1965 * configure.ac: When using the older hildon version, probably on Bora,
1966 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1968 * src/widgets/modest-attachment-view.c:
1969 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1972 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1974 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1975 Implemented the prototype. Can be tested with
1976 tests/dbus_api/test_open_message:
1978 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1980 * src/modest-tny-account-store.c:
1981 (modest_tny_account_store_instance_init), (get_password):
1982 * src/modest-ui-actions.c:
1983 (modest_ui_actions_on_password_requested):
1984 Do not store the password in gconf, because this function is called
1985 for non-remembered passwords. Actually use the cached (in the hash map)
1986 password instead of releasing it.
1987 The password will now not be remembered if it is asked via the protected
1988 password dialog, as per the UI spec.
1990 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1992 * src/modest-defs.h:
1993 * src/modest-account-mgr-helpers.h:
1994 * src/modest-account-mgr-helpers.c:
1995 Added modest_server_account_get_username_has_succeeded(),
1996 modest_server_account_set_username_has_succeeded().
1997 (modest_server_account_set_username),
1998 Reset the has-succeeded flag if the username changes.
2000 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2001 * src/maemo/modest-connection-specific-smtp-window.c:
2002 (modest_connection_specific_smtp_window_save_server_accounts):
2003 Use modest_server_account_set_username() instead of using
2004 modest_conf_set_string() directly, so that the has-succeeded flag is always
2007 * src/modest-ui-actions.c:
2008 (modest_ui_actions_on_password_requested): Dim the username entry if
2009 the username has ever worked, as per the UI spec.
2011 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2013 * src/modest-tny-account-store.c: (get_password):
2014 * src/modest-ui-actions.c:
2015 (modest_ui_actions_on_password_requested):
2016 Allow the username to be changed too, though there is more work to
2017 be done on exactly how this behaves.
2019 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2021 * src/modest-account-mgr-helpers.h:
2022 * src/modest-account-mgr-helpers.c:
2023 Added modest_account_mgr_get_display_name(),
2024 modest_server_account_get_username(),
2025 modest_server_account_set_username(),
2026 modest_server_account_set_password(),
2027 modest_server_account_get_hostname() functions so we do not need to
2028 use the conf API directly.
2030 * src/maemo/modest-main-window.c: (connect_signals):
2031 Actually connect ot the ModestAccountStore::request-password signal,
2032 so that we show the dialog when the password is requested by Tinymail,
2033 for isntance if it is empty.
2035 * src/modest-marshal.list:
2036 * src/modest-tny-account-store.c:
2037 (modest_tny_account_store_class_init), (get_password),
2038 (modest_tny_account_store_alert):
2039 * src/modest-tny-account-store.h:
2040 * src/modest-ui-actions.h:
2041 * src/modest-ui-actions.c:
2042 (modest_ui_actions_on_password_requested):
2043 Change the signal parameters, so it is obvious that we are providing
2044 the non human-readable server name, and receiving both the username
2045 and password, though changing of the username is not yet implemented.
2046 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2047 for the GNOME version.
2049 This should fix the projects.maemo.org bug NB#56209, though it does not
2050 work on Bora, because the gconf_client_get() for the password fails
2051 immediately after we save it with gconf_client_set().
2053 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2056 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2057 caused an undefined symbol error:
2058 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2060 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2062 * src/modest-tny-account-store.c:
2063 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2064 using a GError instead of a string message, so we can translate it in
2067 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2069 * src/maemo/modest-address-book.c:
2070 (modest_address_book_check_names):
2071 * src/maemo/modest-msg-view-window.c:
2072 (modest_msg_view_window_clipboard_owner_change):
2073 * src/modest-init.c: (modest_init_init_ui):
2074 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2075 (update_folders_cb), (modest_mail_operation_update_account):
2076 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2077 (modest_ui_actions_on_msg_attachment_clicked),
2078 (modest_ui_actions_on_msg_recpt_activated):
2079 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2080 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2081 (modest_msg_view_search_next):
2082 * src/widgets/modest-recpt-editor.c:
2083 (modest_recpt_editor_on_button_release_event),
2084 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2085 g_message(). At this point we should only be seeing interesting errors on
2086 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2088 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2090 (modest_wizard_dialog_force_title_update):
2091 * src/maemo/easysetup/modest-wizard-dialog.h:
2092 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2093 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2094 can update the title when appropriate. Otherwise the title is wrong if the
2095 pages are added after adding the notebook to the dialog.
2096 This must be a problem in HildonWizardDialog too.
2097 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2099 * src/maemo/easysetup/modest-easysetup-wizard.c:
2100 (create_subsequent_customsetup_pages),
2101 (create_subsequent_easysetup_pages):
2102 Call modest_wizard_dialog_force_title_update() so that the title is
2103 correct even with GTK+ < 2.10.
2104 This fixes projects.maemo.org bug NB#56145 .
2106 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2108 * src/maemo/modest-platform.c:
2109 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2110 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2113 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2115 * src/widgets/modest-window.h:
2116 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2117 and modest_window_save_state(), which invokes it.
2119 * src/widgets/modest-window-mgr.h:
2120 * src/widgets/modest-window-mgr.c:
2121 Added modest_window_mgr_save_state_for_all_windows(), which calls
2122 the save_state vfunc on all registered windows, if implemented.
2124 * src/gnome/modest-msg-edit-window.c:
2125 * src/gnome/modest-msg-view-window.c:
2126 * src/maemo/modest-msg-edit-window.c:
2127 * src/maemo/modest-msg-view-window.c:
2128 * src/maemo/modest-main-window.c:
2129 Specify the existing save_settings functions as implementations of
2130 ModestWindow::save_state_func().
2132 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2133 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2134 enabling hibernation, for instance.
2136 We may need to do the same thing for restoring settings.
2139 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2141 * src/widgets/modest-window-mgr.c:
2142 * src/widgets/modest-window-mgr.h:
2143 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2144 modest_window_mgr_get_hibernation_is_prevented().
2146 * src/maemo/modest-main-window.c:
2147 (on_hildon_program_is_topmost_notify): Prevent hibernation
2148 (possible when the application goes to the background in the WM),
2149 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2151 * src/maemo/easysetup/modest-easysetup-wizard.c:
2152 (modest_easysetup_wizard_dialog_init):
2153 * src/maemo/modest-account-settings-dialog.c:
2154 (modest_account_settings_dialog_init):
2155 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2156 (modest_connection_specific_smtp_edit_window_init):
2157 * src/maemo/modest-connection-specific-smtp-window.c:
2158 (modest_connection_specific_smtp_window_init):
2159 * src/maemo/modest-signature-editor-dialog.c:
2160 (modest_signature_editor_dialog_init):
2161 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2162 prevent hibernation while any of these account settings dialogs are open.
2164 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2166 * src/maemo/Makefile.am:
2167 * src/maemo/modest-osso-state-saving.c:
2168 * src/maemo/modest-osso-state-saving.h: Added
2169 modest_osso_load_state() and modest_osso_save_state() though they do
2170 nothing now. They should iterate through all the open windows and load/save
2172 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2173 save state when closing.
2175 * src/maemo/modest-main-window.c:
2176 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2177 Add a notification handler for the HildonProgram::is-topmost property,
2178 so we can allow hibernation when the application goes into the background.
2179 But we still need to detect when the accounts setup windows are open so
2180 we can stop hibernation when they are open.
2181 To do this, I also added the main window the HildonProgram. This might have
2182 other side-effects/benefits, and should maybe be done for other windows.
2184 * src/maemo/modest-osso-autosave-callbacks.h:
2185 * src/maemo/modest-osso-autosave-callbacks.c:
2186 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2187 though it does not do anything yet, and we might never need this to do
2188 anything. For instance, we already save drafts.
2190 * src/maemo/modest-platform.c: (modest_platform_init):
2191 Specify the libosso auto-save callback.
2193 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2195 * src/maemo/modest-platform.c:
2196 (modest_platform_set_update_interval):
2197 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2198 aparently stays valid between application instances, so we can use this
2199 to remove and reset it later. According to a maemo-developers email from
2202 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2204 * configure.ac: Depend on libalarm for Maemo.
2206 * src/dbus_api/modest-dbus-api.h:
2207 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2208 (on_send_receive), (modest_dbus_req_handler):
2209 Handle a SEND_RECEIVE D-Bus method.
2211 * libmodest-dbus-client/libmodest-dbus-client.c:
2212 (libmodest_dbus_client_send_and_receive):
2213 * libmodest-dbus-client/libmodest-dbus-client.h:
2214 Add C convenience functions for calling the new D-Bus method.
2216 * src/modest-platform.h:
2217 * src/gnome/modest-platform.c:
2218 * src/maemo/modest-platform.c:
2219 Added modest_platform_set_update_interval(), which uses the
2220 alarmd API on Maemo.
2221 (modest_platform_init),
2222 Call modest_platform_set_update_interval(), using a hard-coded
2223 interval for now (until the global settings dialog is implemented),
2224 though I am not sure that this makes sense yet.
2226 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2228 * src/dbus_api/modest-dbus-callbacks.c:
2229 (modest_osso_cb_hw_state_handler):
2230 * src/dbus_api/modest-dbus-callbacks.h:
2231 * src/maemo/modest-platform.c: (modest_platform_init):
2232 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2233 in case this has some effect on the ability for Maemo to ping the
2236 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2238 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2239 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2240 warning. It is probably a logic error, but I need to fix the build.
2242 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2244 * src/modest-account-mgr.h:
2245 * src/modest-account-mgr.c:
2246 (modest_account_mgr_account_names): Add a gboolean enabled_only
2247 parameter, so we can get lists of onlt the enabled accounts.
2249 (modest_account_mgr_add_account),,
2250 (modest_account_mgr_account_with_display_name_exists):
2251 * src/maemo/modest-msg-edit-window.c: (get_transports):
2252 * src/modest-account-mgr-helpers.c:
2253 (modest_account_mgr_set_first_account_as_default):
2254 * src/modest-init.c: (init_default_account_maybe):
2255 * src/modest-tny-account-store.c: (get_accounts):
2256 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2257 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2258 * tests/check_account-mgr.c: (START_TEST):
2259 Provide the extra parameter, as appropriate.
2261 * src/widgets/modest-account-view.c: (update_account_view):
2262 Do not show disabled accounts (meaning that there is no way to
2263 enable/disable accounts in the UI (the feature is not in our UI
2264 specification), so we can use this internally only to mark unfinished
2265 or temporary account data.
2267 * src/maemo/easysetup/modest-easysetup-wizard.c:
2268 (create_account): Add boolean enable parameter, so we can specify FALSE
2269 to create the temporary account.
2270 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2271 (on_before_next): When finishing, when there is a temporary account, just
2273 Also, use a timeout to delay the showing of the dialog until gconf is likely
2274 to return correct information, due to a maemo gconf bug that is fixed in
2275 osso 1.1, but not yet in Bora.
2276 However, the dialog stays on screen after it is destroyed.
2278 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2279 for invalid data when cancelling. Use a hildon note instead of a dialog
2280 to complain about invalid data. Do not show the account-saved note if the
2281 account is disabled (a temporary account that will not really be saved for use
2284 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2286 * src/modest-account-mgr-helpers.h:
2287 * src/modest-account-mgr-helpers.c:
2288 Added modest_account_mgr_unset_default_account(),
2289 Added modest_account_mgr_set_first_account_as_default().
2291 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2292 If it was the default account, unset the default account name.
2294 * src/maemo/modest-account-view-window.c:
2295 (on_delete_button_clicked): If it was the default account,
2296 set the first remaining account as the default instead.
2298 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2299 a NULL account or a NULL default account, to prevent a crash. This should
2300 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2303 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2305 * src/widgets/modest-recpt-editor.c:
2306 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2307 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2308 TODO comment for this. This fixes the build.
2310 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2311 be the best place for it. This will in future update all auto-update accounts,
2312 rather than just the current/default account, when that gconf key exists.
2313 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2314 if there are no accounts, before calling do_send_receive().
2315 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2317 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2318 * src/maemo/modest-main-window-ui.h:
2319 * src/maemo/modest-main-window.c: (on_connection_changed),
2320 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2321 directly, becaue the signal handler does more.
2323 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2325 * src/modest-account-mgr-helpers.c:
2326 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2327 for the case that the account does not exist.
2329 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2330 (equivalent to the modest account name) rather than the tinymail account name
2331 (equivalent to the modest account title - human readable) to get the account data.
2332 Check for null account data to prevent the crash, and add a TODO comment saying that
2333 this needs fixing because it is using the server account name instead of the account name.
2335 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2337 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2338 * src/maemo/modest-account-settings-dialog.c: (show_error),
2340 Use hildon_note_new_information() for informative and error messages,
2341 which seems to be expected for Maemo applications (no documentation that I know of
2342 says this). I am surprised that there is no distinction between info and error
2345 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2347 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2348 it is easy to find where this is used.
2350 * src/maemo/easysetup/modest-easysetup-wizard.c:
2351 (create_page_welcome), (create_page_account_details),
2352 (create_page_user_details), (create_page_complete_easysetup),
2353 (create_page_custom_incoming), (create_page_custom_outgoing),
2354 (create_page_complete_custom):
2355 * src/maemo/modest-account-settings-dialog.c:
2356 (create_page_account_details), (create_page_user_details),
2357 (create_page_incoming), (create_page_outgoing):
2358 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2359 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2360 (modest_connection_specific_smtp_edit_window_init):
2361 * src/maemo/modest-connection-specific-smtp-window.c:
2362 (modest_connection_specific_smtp_window_init):
2363 * src/maemo/modest-signature-editor-dialog.c:
2364 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2365 and scrolling policy as per the Email Application Layout Guide, if I have
2368 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2370 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2371 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2372 which were empty, because these vfuncs have been removed from TnyAccountStore.
2373 This fixes the build.
2375 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2377 * src/maemo/modest-main-window.c:
2378 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2379 showing/hiding it. Added TODO because it probably should not be NULL.
2380 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2381 because unnecessary g_warnings() make degugging difficult.
2383 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2385 * src/maemo/modest-msg-edit-window.c:
2386 (modest_msg_edit_window_select_color),
2387 (modest_msg_edit_window_select_background_color): 2 const corrections and
2388 moving 2 #endifs before closing brackets, to fix the build.
2390 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2392 * src/maemo/easysetup/modest-easysetup-wizard.h:
2393 * src/maemo/easysetup/modest-easysetup-wizard.c:
2394 (modest_easysetup_wizard_dialog_finalize),
2395 (on_button_edit_advanced_settings), (create_page_complete_custom),
2396 (on_response), (create_account):
2397 Implement the Advanced Settings edit button, by saving the account information,
2398 for the Advanded Settings dialog to use directly from gconf, and removing it
2399 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2400 Bug #5533 in the projects.maemo.org bugzilla.
2402 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2404 * src/maemo/modest-msg-view-window.c:
2405 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2406 when opening a message window.
2408 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2410 * src/maemo/easysetup/modest-easysetup-wizard.c:
2411 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2414 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2415 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2416 gconf settings. I probably added more checks than necessary, but that is safer.
2418 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2419 variable to fix the build, but this seems to be used when it is still NULL.
2421 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2423 * src/modest-platform.h:
2424 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2425 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2426 * src/modest-main.c: Implement this function so we can avoid using
2427 maemo-specific API from cross-platform code.
2429 * src/modest-tny-account-store.c:
2430 (get_smtp_specific_transport_account_for_open_connection):
2431 * src/modest-ui-actions.c: (check_for_connection),
2432 (modest_ui_actions_on_item_not_found):
2433 Use modest_platform_connect_and_wait() and put #idefs around other
2434 maemo-specific code, because only maemo currently has a way to
2435 identify connection names.
2437 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2439 * src/modest-tny-account-store.h:
2440 * src/modest-tny-account-store.c:
2441 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2442 the connection-specific SMTP server settings in the configuration.
2444 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2446 * src/maemo/modest-main-window.c: (on_connection_changed),
2448 * src/modest-main.c: (main), (start_ui), (send_mail):
2449 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2450 that is what is intended.
2452 * src/modest-ui-actions.c: (action_send), (action_receive),
2453 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2454 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2455 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2456 SMTP server is used when it is specified.
2458 (modest_ui_actions_on_send_receive):
2459 Check that a connection is open before proceeding.
2460 Receive and then send, instead of vice-versa, as per the specification.
2462 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2464 * src/modest-mail-operation.c:
2465 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2466 though I guess it should be something other than NULL.
2468 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2470 * src/maemo/easysetup/modest-easysetup-wizard.c:
2471 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2472 combo twice, to avoid an g_warning and to make it visible again.
2473 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2474 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2475 (already intended) dereference when detaching, because we then recreate the menu.
2476 But I am not sure why the warning was happening, and it is possible that this is a memory
2479 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2481 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2482 and uri_parse_mailto() utility functions.
2483 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2485 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2487 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2489 * src/dbus_api/modest-dbus-api.h:
2490 * src/dbus_api/modest-dbus-callbacks.c:
2491 Use an idle callback to execute the modest code in the application's own thread.
2492 Remove the helloworld example method.
2493 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2494 parsed, and the open-message method is not implemented because this is not yet implemented in
2496 * libmodest-dbus-client/libmodest-dbus-client.c:
2497 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2498 (libmodest_dbus_client_open_message):
2499 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2501 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2502 body without crashing.
2504 * tests/dbus_api/Makefile.am:
2505 * tests/dbus_api/test_mail_to.c:
2506 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2508 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2510 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2511 Added file to fix the build. Sorry.
2513 * src/dbus_api/Makefile.am:
2514 * src/dbus_api/modest-dbus-api.h:
2515 * src/dbus_api/modest-dbus-callbacks.h:
2516 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2517 (modest_dbus_req_handler):
2518 Put constants in a separate header so it can be reused by the
2519 client library, without duplication
2521 * libmodest-dbus-client/Makefile.am:
2522 * libmodest-dbus-client/libmodest-dbus-client.c:
2523 (libmodest_dbus_client_call_helloworld),
2524 (libmodfest_dbus_client_send_mail),
2525 (libmodfest_dbus_client_mailto),
2526 (libmodfest_dbus_client_open_message):
2527 * libmodest-dbus-client/libmodest-dbus-client.h:
2528 (Partly) Implement a send_mail D-Bus method.
2530 * tests/dbus_api/Makefile.am:
2531 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2532 the send_email D-Bus method.
2534 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2538 * libmodest-dbus-client/Makefile.am:
2539 * libmodest-dbus-client/libmodest-dbus-client.c:
2540 * libmodest-dbus-client/libmodest-dbus-client.h:
2541 * tests/dbus_api/Makefile.am:
2542 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2543 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2545 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2547 * src/maemo/easysetup/modest-easysetup-wizard.c:
2548 (create_page_account_details):
2549 * src/maemo/modest-account-settings-dialog.c:
2550 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2551 widgets, because this might not be the default in future versions of the Maemo GTK+.
2552 However, I can not not get capitalization to work even in a simple test case.
2554 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2556 * src/maemo/easysetup/modest-easysetup-wizard.c:
2557 (create_page_custom_incoming), (create_page_custom_outgoing):
2558 * src/maemo/modest-account-settings-dialog.c:
2559 (create_page_account_details), (create_page_incoming),
2560 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2561 instead of using gtk_check_button_with_label(), so they are aligned like the other
2562 widgets, as per the UI spec.
2564 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2566 * src/maemo/easysetup/modest-easysetup-wizard.c:
2567 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2568 * src/widgets/modest-validating-entry.c:
2569 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2570 Modest prefix instead of an EasySetup prefix.
2572 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2574 * src/widgets/modest-validating-entry.h:
2575 * src/widgets/modest-validating-entry.c: (on_insert_text),
2576 Added easysetup_validating_entry_set_max_func(), used to set a callback
2577 to call when the max number of characters is reached. GtkEntry has a max-length
2578 already but is silent about it.
2580 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2581 (create_page_account_details), (create_page_user_details),
2583 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2584 (create_page_account_details), (create_page_user_details),
2585 (create_page_outgoing):
2586 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2587 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2588 the UI spec, when the user tries to enter more than the max number of characters.
2590 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2592 * src/maemo/easysetup/modest-easysetup-wizard.c:
2593 (create_page_user_details), (create_page_custom_incoming),
2594 (create_page_custom_outgoing):
2595 * src/maemo/modest-account-settings-dialog.c:
2596 (create_page_user_details), (create_page_incoming),
2597 (create_page_outgoing):
2598 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2599 (modest_connection_specific_smtp_edit_window_init):
2600 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2601 not appropriate. Bad Maemo-specific defaults!.
2603 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2605 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2606 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2607 (modest_signature_editor_dialog_set_settings):
2608 Disable the label and textview when the checkbox is disabled, and use the
2609 specified (UI spec) default signature text.
2611 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2613 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2614 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2616 * src/modest-defs.h:
2617 * src/modest-account-mgr-helpers.h:
2618 * src/modest-account-mgr-helpers.c:
2619 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2621 * src/maemo/Makefile.am:
2622 * src/maemo/modest-signature-editor-dialog.c:
2623 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2626 * src/maemo/modest-account-settings-dialog.h:
2627 * src/maemo/modest-account-settings-dialog.c:
2628 (modest_account_settings_dialog_finalize), (on_button_signature),
2629 (save_configuration): Use the new dialog when the Edit button is pressed, and
2630 save the changes if necessary, as per the UI spec.
2632 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2634 * src/maemo/Makefile.am:
2635 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2636 based on maemo-develoers email from Dirk.
2638 * src/maemo/easysetup/modest-easysetup-wizard.c:
2639 (create_page_welcome), (create_page_account_details),
2640 (create_page_user_details), (create_page_complete_easysetup),
2641 (create_page_custom_incoming), (create_page_custom_outgoing),
2642 (create_page_complete_custom),
2643 (modest_easysetup_wizard_dialog_init):
2644 * src/maemo/modest-account-settings-dialog.c:
2645 (create_page_account_details), (create_page_user_details),
2646 (create_page_incoming), (create_page_outgoing),
2647 (modest_account_settings_dialog_init):
2648 * src/maemo/modest-connection-specific-smtp-window.c:
2649 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2651 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2653 * src/maemo/easysetup/modest-easysetup-wizard.c:
2654 (create_page_account_details), (create_page_custom_outgoing),
2655 (create_page_complete_custom):
2656 * src/maemo/modest-account-settings-dialog.c:
2657 (create_page_user_details), (create_page_incoming),
2658 (create_page_outgoing):
2659 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2660 (modest_connection_specific_smtp_edit_window_init):
2661 Use the correct (UI spec) port min/max, and use horizontal separators,
2664 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2666 * src/maemo/easysetup/modest-easysetup-wizard.c:
2667 (set_default_custom_servernames):
2668 * src/maemo/modest-account-settings-dialog.c:
2669 (create_page_incoming), (on_combo_outgoing_security_changed),
2670 (on_combo_incoming_security_changed), (create_page_outgoing),
2671 (modest_account_settings_dialog_set_account_name),
2672 (save_configuration):
2673 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2674 (on_combo_security_changed),
2675 (modest_connection_specific_smtp_edit_window_init),
2676 (modest_connection_specific_smtp_edit_window_set_connection),
2677 (modest_connection_specific_smtp_edit_window_get_settings):
2678 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2681 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2684 * src/maemo/easysetup/modest-easysetup-wizard.c:
2685 (create_page_custom_outgoing), (create_page_complete_custom):
2686 * src/maemo/modest-account-settings-dialog.c:
2687 (create_page_user_details), (create_page_outgoing):
2688 * src/maemo/modest-account-view-window.c: (button_box_new):
2689 Use changed logical IDs as per the most recent UI spec:
2690 mcen_bd_emailsetup_edit -> mcen_bd_edit
2691 mcen_bd_emailsetup_delete -> mcen_bd_delete
2692 mcen_bd_emailsetup_close -> mcen_bd_close
2694 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2698 * src/dbus_api/Makefile.am:
2699 * src/dbus_api/modest-dbus-callbacks.c:
2700 * src/dbus_api/modest-dbus-callbacks.h:
2701 * src/maemo/modest-platform.c: (modest_platform_init):
2702 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2704 * tests/Makefile.am:
2705 * tests/dbus_api/Makefile.am:
2706 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2708 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2710 * src/maemo/modest-account-settings-dialog.c:
2711 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2712 Removed unnecessary includes.
2714 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2716 * src/maemo/easysetup/modest-easysetup-wizard.c:
2717 * src/maemo/modest-account-settings-dialog.c:
2718 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2719 * src/widgets/Makefile.am:
2720 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2721 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2722 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2723 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2724 * src/widgets/modest-secureauth-combo-box.c:
2725 * src/widgets/modest-secureauth-combo-box.h:
2726 * src/widgets/modest-serversecurity-combo-box.c:
2727 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2728 made the GObject names more consistent with the rest of the Modest code.
2730 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2732 * src/maemo/easysetup/Makefile.am:
2733 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2734 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2735 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2736 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2737 * src/maemo/easysetup/modest-easysetup-wizard.c:
2738 * src/maemo/easysetup/modest-validating-entry.c:
2739 * src/maemo/easysetup/modest-validating-entry.h:
2740 * src/maemo/modest-account-settings-dialog.c:
2741 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2742 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2743 widgets/ because they are used outside of easysetup too. After checking in,
2744 svn will allow me to rename them too.
2746 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2748 * src/gnome/modest-msg-edit-window.c:
2749 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2750 linker error, to fix the build on the GNOME platform.
2751 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2752 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2753 ifdefed out to avoid a warning.
2755 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2757 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2758 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2759 some alternative for GTK+ 2.6.
2761 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2763 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2765 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2766 specified for EmailAccountsDialog in UI spec.
2768 * src/maemo/easysetup/modest-easysetup-wizard.c:
2769 * src/maemo/easysetup/modest-easysetup-wizard.h:
2770 * src/maemo/modest-account-settings-dialog.c:
2771 * src/maemo/modest-account-settings-dialog.h:
2772 Reuse a member window widget for the connection-specific SMTP server accounts,
2773 so we can tell it to create/save the accounts only if we actually save changes.
2775 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2776 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2777 (modest_connection_specific_smtp_edit_window_get_settings):
2778 Return a struct instance for temporarily remembering the entered data.
2780 * src/maemo/modest-connection-specific-smtp-window.h:
2781 * src/maemo/modest-connection-specific-smtp-window.c:
2782 (modest_connection_specific_smtp_window_finalize),
2783 (modest_connection_specific_smtp_window_fill_with_connections),
2785 (modest_connection_specific_smtp_window_save_server_accounts),
2786 (update_model_server_names): Do not actually save data until asked,
2787 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2789 (on_selection_changed),
2790 (modest_connection_specific_smtp_window_init): Disable the edit
2791 button when nothing is selected.
2793 * src/modest-account-mgr-helpers.c:
2794 * src/modest-account-mgr-helpers.h:
2795 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2798 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2800 * src/modest-account-mgr-helpers.h:
2801 * src/modest-account-mgr-helpers.c:
2802 (modest_account_mgr_get_unused_account_name),
2803 (modest_account_mgr_get_unused_account_display_name): Added these
2804 utility functions, to avoid code duplication.
2806 * src/maemo/easysetup/modest-easysetup-wizard.c:
2807 (create_page_account_details), (create_account):
2808 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2809 (on_combo_security_changed),
2810 (modest_connection_specific_smtp_edit_window_init),
2811 (modest_connection_specific_smtp_edit_window_save_settings):
2812 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2813 * src/maemo/modest-connection-specific-smtp-window.c:
2814 (modest_connection_specific_smtp_window_finalize),
2815 (modest_connection_specific_smtp_window_fill_with_connections),
2816 (on_button_edit), (modest_connection_specific_smtp_window_init):
2817 * src/maemo/modest-connection-specific-smtp-window.h:
2818 Implementing saving of connection-specific server accounts.
2820 But I need to refactor this so we can save the data for each
2821 possible connection-specific account and only actually create the server accounts
2822 when the easysetup finished, or the OK button is pressed on the account settings
2825 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2827 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2828 (on_combo_security_changed):
2829 (modest_connection_specific_smtp_edit_window_init):
2830 Auto-fill the port number as in the account settings.
2832 (modest_connection_specific_smtp_edit_window_set_connection):
2833 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2834 * src/maemo/modest-connection-specific-smtp-window.c:
2835 (fill_with_connections), (on_button_edit),
2836 (modest_connection_specific_smtp_window_init):
2837 Turn the edit window into a dialog to simplify the code, and
2838 set a WM hint as in a GtkDialog, because only a popup can be on top of
2839 another window in Maemo, and popups usually have no WM decoration.
2841 * src/modest-defs.h:
2842 * src/modest-account-mgr-helpers.c:
2843 (modest_account_mgr_set_connection_specific_smtp),
2844 (modest_account_mgr_remove_connection_specific_smtp),
2845 (modest_account_mgr_get_connection_specific_smtp):
2846 * src/modest-account-mgr-helpers.h: Some functions to write the
2847 connection-specific SMTP server information. Not yet used.
2850 * src/widgets/modest-folder-view.c: (text_cell_data):
2851 Fix a warning about an uninitialized variable.
2852 (on_configuration_key_changed): Put an #ifdef around the use
2853 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2855 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2857 * src/maemo/modest-account-settings-dialog.h:
2858 * src/maemo/modest-account-settings-dialog.c:
2859 Added connect_for_modified() utility function to mark the new modified boolean.
2861 (create_page_account_details), (create_page_user_details),
2862 (create_page_incoming), (create_page_outgoing), (on_response),
2863 (modest_account_settings_dialog_init),
2864 (modest_account_settings_dialog_set_account_name):
2865 Only warn about unsaved changes when there are actually unsaved changes.
2867 * src/modest-account-mgr-helpers.c:
2868 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2869 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2870 to get the data from there in future.
2872 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2874 * src/modest-defs.h:
2876 * src/modest-account-mgr-helpers.h:
2877 * src/modest-account-mgr-helpers.c:
2878 Store the security account setting in a single conf key instead of using
2879 the options list, so that the list is left for just the to-be-removed camel hack,
2880 and because gconf_client_set_list() is failing for some reason.
2882 * src/modest-account-mgr.c:
2883 (modest_account_mgr_add_server_account):
2884 * src/maemo/modest-account-settings-dialog.c:
2885 (modest_account_settings_dialog_set_account_name),
2886 (save_configuration): Use the renamed functions.
2889 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2891 * src/widgets/Makefile.am:
2892 * src/widgets/modest-limit-retrieve-combo-box.c:
2893 * src/widgets/modest-limit-retrieve-combo-box.h:
2894 * src/widgets/modest-retrieve-combo-box.c:
2895 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2896 the account settings dialog.
2898 * src/modest-defs.h:
2899 * src/modest-account-mgr-helpers.h:
2900 * src/modest-account-mgr-helpers.c:
2901 (modest_server_account_get_option_secure_auth),
2902 (modest_server_account_set_option_secure_auth):
2903 * src/modest-account-mgr.c:
2904 (modest_account_mgr_add_server_account):
2905 Use the existing AUTH_MECH conf key for the secure-auth setting,
2906 instead of putting it in the list options, because this was actually used already.
2908 * src/maemo/modest-account-settings-dialog.c:
2909 (create_page_account_details),
2910 (modest_account_settings_dialog_set_account_name),
2911 (save_configuration):
2912 * src/maemo/modest-account-settings-dialog.h:
2913 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2914 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2916 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2918 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2919 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2920 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2922 * src/modest-defs.h:
2923 * src/maemo/modest-account-settings-dialog.c:
2924 (create_page_incoming), (on_combo_outgoing_security_changed),
2925 (on_combo_incoming_security_changed), (create_page_outgoing),
2926 (modest_account_settings_dialog_set_account_name),
2927 (save_configuration): Load/Save the port number, and change it when the
2928 security combo changes, to suitable defaults.
2930 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2932 * src/modest-account-mgr.c:
2933 (modest_account_mgr_add_server_account): Set the security and secure-auth
2934 options, and add a comment saying that the other camel-specific options should be
2937 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2939 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2941 * src/modest-tny-account-store.c: (account_list_free),
2942 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2943 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2946 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2948 * src/modest-protocol-info.c:
2949 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2950 is required by our UI spec. Maybe something in our implementation will use this eventually.
2951 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2952 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2953 instead of the previous 0 placeholder.
2955 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2956 secure-auth settings.
2957 * src/modest-account-mgr-helpers.h:
2958 * src/modest-account-mgr-helpers.c:
2959 (modest_server_account_data_get_option_secure_auth),
2960 (modest_server_account_set_option_secure_auth),
2961 (modest_server_account_data_get_option_security),
2962 (modest_server_account_set_option_security): Added this API for getting and setting the security
2963 and secure-auth settings.
2965 * src/maemo/modest-account-settings-dialog.h:
2966 * src/maemo/modest-account-settings-dialog.c:
2967 (modest_account_settings_dialog_finalize), (check_data),
2968 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2969 about changing titles.
2970 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2971 (save_configuration): Save the security and secure-auth settings.
2973 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2974 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2976 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2978 * src/modest-defs.h:
2979 * src/modest-account-mgr.c:
2980 (modest_account_mgr_add_server_account):
2981 Added and used defines for the options key and value pair strings,
2982 that are used so far, though they do not seem to correspond to anything in our
2983 UI specs or ModestProtocol enum.
2985 * src/modest-account-mgr-helpers.h:
2986 * src/modest-account-mgr-helpers.c:
2987 (compare_option_strings_for_name),
2988 (modest_server_account_data_get_option_value),
2989 (modest_server_account_data_get_option_bool),
2990 (modest_account_mgr_get_server_account_option):
2991 Added helper functions for parsing the options GSList.
2993 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2995 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2996 display name is based on the supplied account name.
2997 * src/modest-account-mgr.c:
2998 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2999 with an inefficient, but good-enough, implementation.
3001 * src/maemo/easysetup/modest-easysetup-wizard.c:
3002 (create_page_account_details), (on_before_next), (create_account):
3003 Check for existing display names rather than (non-user-visible) account names, and just
3004 create and set a unique account name at the end.
3006 * src/maemo/modest-account-settings-dialog.c:
3007 (modest_account_settings_dialog_init),
3008 (modest_account_settings_dialog_set_account_name),
3009 (create_page_incoming): Show the display name, instead of the account name.
3010 (on_response): Do some (not all) extra checks, as in the UI spec.
3011 (save_configuration): Save the display name if it was changed.
3013 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3015 * po/en_GB.po: Added needed logical ID and translation.
3016 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3017 (init_view): Made the is-default column clicking work.
3019 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3022 * src/maemo/easysetup/Makefile.am:
3023 * src/maemo/easysetup/modest-easysetup-wizard.c:
3024 (modest_easysetup_wizard_dialog_init):
3025 * src/maemo/easysetup/provider-data-test.keyfile:
3026 * src/maemo/easysetup/provider-data.keyfile:
3027 Moved the provider data file to the new modest-providers-data package and used it from there.
3029 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3031 * src/modest-local-folder-info.c:
3032 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3033 N_() was already used on the static strings, but this just marks it for translation without
3034 using the translation.
3036 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3038 * src/maemo/modest-account-settings-dialog.c:
3039 (create_page_incoming),
3040 (modest_account_settings_dialog_set_account_name):
3041 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3042 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3043 I will do this if nobody else gets there first.
3045 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3047 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3048 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3049 save the security stuff.
3051 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3053 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3054 Set the email address and user fullname, which I now see must be
3057 * src/maemo/modest-account-settings-dialog.h:
3058 * src/maemo/modest-account-settings-dialog.c:
3060 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3061 leave-on-server and authentication.
3062 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3065 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3068 * src/maemo/modest-account-settings-dialog.c:
3069 * src/maemo/modest-account-settings-dialog.h:
3070 Most (but not all) of the widgets are now present as specified by the UI spec.
3071 No changes are yet saved, and some details are not properly shown yet.
3073 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3075 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3077 * src/maemo/Makefile.am:
3078 * src/maemo/modest-account-settings-dialog.c:
3079 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3080 an existing account. Doesn't do much yet.
3082 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3083 Open the accounts settings dialog when Edit is clicked.
3085 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3087 * src/maemo/easysetup/Makefile.am:
3088 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3090 * src/maemo/easysetup/modest-easysetup-wizard.c:
3091 (modest_easysetup_wizard_dialog_init):
3092 Try to get the source directory from the build system,
3093 instead of hard-coding "./" into the source code, when opening our local
3094 copies of the configuration files.
3095 But this still fails when opening the wizard from the Accounts window,
3096 maybe because the working directory seems to change at runtime.
3097 So the wizard will fail the second time unless you copy the files into their
3098 proper locations - see the stdout warnings for the paths.
3100 (create_page_account_details),(on_before_next):
3101 Check for existing non-server accounts instead of server accounts,
3102 so the default account name is useful again, and to prevent trying to
3105 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3106 Show the wizard when New is clicked.
3108 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3109 (init_view): Show the column headers, and show the columns that are
3110 specified in the UI specs. However, something in Maemo's GTK+ prevents
3111 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3112 change the default account. This is despite unsetting the special properties.
3114 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3116 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3117 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3118 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3119 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3120 to make that clearer.
3121 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3123 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3125 * src/maemo/modest-account-view-window.c:
3126 (modest_account_view_window_init),
3127 (modest_account_view_window_new):
3128 Use the same buttons as specified in the
3129 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3130 the existing widgets, which never had a chance of working.
3131 Put the ModestAccountView treeview in a scrolled window.
3132 Do not repeat the initialization in both _init() and _new().
3134 * src/widgets/modest-account-view.c: (update_account_view):
3135 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3136 this widget and window shows no accounts.
3138 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3140 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3142 * src/maemo/easysetup/modest-easysetup-wizard.c:
3143 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3144 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3145 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3148 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3149 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3150 accounts exist yet, as in the UI spec.
3152 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3154 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3156 * src/maemo/Makefile.am:
3157 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3158 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3159 New window for editing connection-specific smtp details.
3160 Not fully implemented.
3162 * src/maemo/modest-connection-specific-smtp-window.c:
3163 (modest_connection_specific_smtp_window_finalize) :
3164 unref the tree model.
3165 (on_button_edit): Show the edit window.
3167 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3169 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3172 * src/maemo/Makefile.am:
3173 * src/maemo/modest-connection-specific-smtp-window.c:
3174 * src/maemo/modest-connection-specific-smtp-window.h:
3175 New window for showing the list of connections, for connection-specific
3176 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3177 * src/maemo/easysetup/modest-easysetup-wizard.c:
3178 (create_page_custom_outgoing): Show the new window when the button is clicked.
3180 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3182 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3183 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3184 * src/maemo/modest-msg-edit-window.c:
3185 (modest_msg_edit_window_insert_image):
3186 * src/modest-conf.c: (modest_conf_key_escape):
3187 * src/modest-mail-operation.c:
3188 (modest_mail_operation_send_new_mail):
3189 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3190 (modest_ui_actions_on_new_account):
3191 * src/widgets/modest-attachment-view.c: (update_filename_request):
3192 * src/widgets/modest-mail-header-view.c:
3193 Corrected warnings that were breaking the build, by commenting out unused variables,
3194 and a function, and by including a header.
3196 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3198 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3199 so we can #ifdef around platform-specific code when necessary.
3200 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3201 to allow this to build for the GNOME platform too.
3203 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3205 * src/maemo/easysetup/modest-easysetup-wizard.c:
3206 Added util_increment_name() and used it in create_page_account_details()
3207 to make sure that the default account name is always a new name.
3209 (modest_easysetup_wizard_dialog_init),
3210 (set_default_custom_servernames): Some minor memory management fixes.
3212 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3216 * src/modest-runtime.c: (init_i18n): Restored the translation
3217 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3218 are defined in config.h, and the translations are installed.
3220 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3221 is defined for translation.
3223 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3225 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3227 * src/maemo/easysetup/modest-easysetup-wizard.c:
3228 (modest_easysetup_wizard_dialog_init):
3229 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3230 Use realistic paths (though they should use $prefix generically) to the
3231 mcc_mapping and provider-data.keyfile files which might work when they
3232 are installed by the future version of the operator-wizard package,
3233 and then fallback to paths in our source code, with an explanatory
3236 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3240 * src/maemo/Makefile.am:
3241 * src/maemo/easysetup/: Added files from the previously-exernal
3242 osso-modest-easysetup.
3243 * src/maemo/modest-main-window-ui.h:
3244 * src/modest-ui-actions.c:
3245 * src/modest-ui-actions.h:
3246 Added modest_ui_actions_on_new_account() as a signal handler for the
3247 New Account menu item. It shows the easysetup wizard.
3248 * po/en_GB.po: Added additional needed logical IDs and translations.