1 2007-09-03 Murray Cumming <murrayc@murrayc.com>
3 * src/widgets/modest-folder-view.c: (strings_are_equal),
4 (on_model_foreach_set_name), (on_get_mmc_account_name),
5 (text_cell_data): Restored this code that was removed in
6 svn revision 3165 by jfernandez, because this late name-discovery
7 really is necessary sometimes. This is the correct fix to the endless
8 calling of this function:
9 * src/modest-tny-account.c: (on_modest_file_system_info):
10 Don't call tny_account_set_name() when the name is already correct,
11 to avoid unnecessary (endless) updates to the tree model.
13 2007-08-31 Murray Cumming <murrayc@murrayc.com>
15 * src/modest-defs.h: Rename MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST to
16 MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST and make it a global list
17 for use by all accounts that enable the MODEST_ACCOUNT_USE_CONNECTION_SPECIFIC_SMTP
18 boolean, because this is the specified behaviour in the UI spec.
19 * src/modest-account-mgr-helpers.h:
20 * src/modest-account-mgr-helpers.c:
21 (modest_account_mgr_set_connection_specific_smtp),
22 (modest_account_mgr_remove_connection_specific_smtp),
23 (modest_account_mgr_get_connection_specific_smtp): Remove the account_name
25 * src/maemo/modest-connection-specific-smtp-window.h:
26 * src/maemo/modest-connection-specific-smtp-window.c:
27 (modest_connection_specific_smtp_window_finalize),
28 (modest_connection_specific_smtp_window_fill_with_connections),
29 (modest_connection_specific_smtp_window_save_server_accounts):
30 Remove the account_name parameters and member variable.
31 * src/maemo/easysetup/modest-easysetup-wizard.c:
32 (on_button_outgoing_smtp_servers), (create_account):
33 * src/maemo/modest-account-settings-dialog.c:
34 (on_button_outgoing_smtp_servers), (check_data),
35 (modest_account_settings_dialog_set_account_name),
37 * src/maemo/modest-maemo-utils.c: (on_account_online),
38 (modest_maemo_utils_get_supported_secure_authentication_methods):
39 * src/modest-tny-account-store.c:
40 (get_smtp_specific_transport_account_for_open_connection),
41 (insert_account), (add_connection_specific_transport_accounts):
42 * src/modest-ui-actions.c: (on_smtp_servers_window_hide),
43 (modest_ui_actions_on_smtp_servers):
44 Adapt to the changed API.
46 2007-08-29 Armin Burgmeier <armin@openismus.com>
48 * src/modest-protocol-info.h:
49 * src/modest-protocol-info.c: Added
50 modest_protocol_info_get_auth_protocol() to translate an
51 authentication protocol name to the corresponding enum value.
53 * src/maemo/modest-maemo-utils.c: Fixed supported auth protocol list
54 generation using the newly added function.
56 * src/maemo/modest-account-settings-dialog.c: Use the current element
57 when traversing through the list of supported authentication methods,
60 2007-08-29 Murray Cumming <murrayc@murrayc.com>
62 * src/maemo/easysetup/modest-easysetup-wizard.c:
63 (check_first_supported_auth_method), (on_before_next),
65 * src/maemo/modest-account-settings-dialog.c: (check_data):
66 Some cleanup, to make the code clearer.
68 2007-08-29 Murray Cumming <murrayc@murrayc.com>
70 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
71 Use the mail_ni_ssl_certificate_error ("Secure connection failed")
72 logical ID when the secure authentication method is not supported by
73 the server, as requested by Mox on the wiki, though I hate not
74 giving the user the clue.
76 2007-08-29 Murray Cumming <murrayc@murrayc.com>
78 * src/modest-search.c: (modest_search_all_accounts):
79 * src/modest-platform.h:
80 * src/maemo/modest-platform.c: Moved and renamed
81 check_and_wait_for_account_is_online() to
82 modest_platform_check_and_wait_for_account_is_online() so it
83 can be used in more places.
85 2007-08-29 Murray Cumming <murrayc@murrayc.com>
87 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
88 Removed the sleep(1) experiment because it does not seem to help,
89 and I should not have checked the experiment in anyway.
90 The problem is maybe in the TnyAccount connected state - I will
91 investigate that instead.
93 2007-08-28 Murray Cumming <murrayc@murrayc.com>
95 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
96 Added a sleep(1) in case it helps with bug #66769.
98 2007-08-28 Murray Cumming <murrayc@murrayc.com>
100 * src/modest-search.c: (on_timeout_check_account_is_online),
101 (check_and_wait_for_account_is_online):
102 It is OK for local-folder and mmc accounts to be used when they
103 are in the _INIT folder, instead of waiting for them to change
105 For POP and IMAP, wait from them to stop being _INIT, rather than
106 waiting from them to be _CONNECTED, because that seems to be
107 the status that causes the problems.
109 2007-08-28 Murray Cumming <murrayc@murrayc.com>
111 * src/modest-search.c: (check_and_wait_for_account_is_online):
112 Actually pass the account to the timeout callback.
114 2007-08-28 Murray Cumming <murrayc@murrayc.com>
116 * src/modest-search.c: (on_timeout_check_account_is_online):
117 Added some debug output to help me debug a problem on the N800.
118 (check_and_wait_for_account_is_online): Fail immediately if the
120 modest_search_all_accounts(): Try the search even if the account does
121 not seem to be online, because this can work sometimes, and should work
122 with the cache if there is no active libconic connection.
124 2007-08-27 Armin Burgmeier <armin@openismus.com>
126 * src/modest-tny-send-queue.c: Implement TnyFolderObserver and
127 observe outbox for added messages to assign them a status. Previously,
128 this was done in modest_tny_send_queue_add(), but the message id might
129 not yet be known at that point. This reduces warnings when sending
130 mail, though I am not sure how this even worked before.
132 2007-08-27 Murray Cumming <murrayc@murrayc.com>
134 * src/maemo/modest-account-settings-dialog.c:
135 (modest_account_settings_dialog_init):
136 * src/maemo/modest-connection-specific-smtp-edit-window.c:
137 (modest_connection_specific_smtp_edit_window_init):
138 * src/maemo/modest-connection-specific-smtp-window.c:
139 (modest_connection_specific_smtp_window_init):
140 * src/maemo/modest-maemo-utils.c:
141 (modest_maemo_utils_get_supported_secure_authentication_methods):
142 * src/maemo/modest-platform.c:
143 (modest_platform_run_folder_name_dialog):
144 * src/maemo/modest-signature-editor-dialog.c:
145 (modest_signature_editor_dialog_init):
146 * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
147 (modest_ui_actions_on_password_requested), (create_move_to_dialog):
148 * src/widgets/modest-global-settings-dialog.c:
149 (modest_global_settings_dialog_init):
150 Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
152 GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
153 GTK_STOCK_EDIT with mcen_bd_edit, and
154 GTK_STOCK_CLOSE with mcen_bd_close,
155 to fix projects.maemo.org bug NB#64995.
156 I strongly believe that Maemo's GTK+ should have the wanted translations
157 instead of duplicating this in each application and complicating the code.
159 2007-08-27 Armin Burgmeier <armin@openismus.com>
161 * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
162 recursion when entering text in the subject field.
164 2007-08-27 Murray Cumming <murrayc@murrayc.com>
166 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
167 which checks every second, 10 times, to wait until the account is online
168 so that we can use it, if the account is in the process of going online.
169 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
170 so that searching works even when the application was not yet started before.
171 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
173 2007-08-24 Armin Burgmeier <armin@openismus.com>
175 * src/modest-widget-memory.c: Always show the default account when the
176 application is started, as stated in the UI spec. This fixes
177 projects.maemo.org bug NB#66630.
179 2007-08-24 Armin Burgmeier <armin@openismus.com>
181 * src/maemo/modest-platform.c:
182 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
183 english text for strings in the rename folder dialog, fixing
184 projects.maemo.org bug NB#66338.
186 2007-08-22 Armin Burgmeier <armin@openismus.com>
188 * src/widgets/modest-account-view.c: Fix for bora by using
189 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
190 latter seems not be used anymore.
192 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
195 * src/maemo/modest-main-window.c: Update menu items when the default
196 account changes so that the current default account is always bolded.
197 This fixes maemo.projects.org bug NB#66173.
199 2007-08-17 Murray Cumming <murrayc@murrayc.com>
201 * src/dbus_api/modest-dbus-callbacks.c:
202 (on_dbus_method_get_folders): Avoid trying to get the account name
203 when there are no accounts, to avoid critical g_warnings, fixing
204 projects.maemo.org bug NB#65574.
206 2007-08-17 Murray Cumming <murrayc@murrayc.com>
208 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
209 Use modest_account_mgr_get_signature() instead of accessing gconf
210 directly, to slightly simplify the code.
211 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
212 Append the signature also when opening via other applications,
213 fixing projects.maemo.org bug NB#65828.
215 2007-08-17 Murray Cumming <murrayc@murrayc.com>
217 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
218 Check for NULLs to prevent a crash when opening an email that is
219 an attachment in another email, fixing projects.maemo.org bug
222 2007-08-17 Murray Cumming <murrayc@murrayc.com>
224 * src/modest-ui-dimming-rules.c:
225 (modest_ui_dimming_rules_on_view_window_move_to):
226 Enable the Move To toolbar button for search results, fixing the
227 last part of projects.maemo.org bug NB#63807.
229 2007-08-17 Murray Cumming <murrayc@murrayc.com>
231 * src/dbus_api/modest-dbus-callbacks.c:
232 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
233 because this is called from idle handlers, to fix hangs afte the
235 (find_message_by_url): Added a TODO comment about a crash that
236 happens when tinymail was built with DBC checks.
238 2007-08-16 Murray Cumming <murrayc@murrayc.com>
240 * src/modest-search.c: (modest_search_folder):
241 * src/modest-search.h: Rename ModestSearch::before to start_date
242 and after to end_date, using the same names as the libogs struct
244 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
245 The start_date and end_date were swapped in the check. This
246 fixes date range searches, fixing projects.maemo.org bug NB#63407.
248 2007-08-16 Murray Cumming <murrayc@murrayc.com>
250 * src/maemo/modest-account-view-window.c:
251 Added (check_for_active_acount).
252 (on_delete_button_clicked), (on_edit_button_clicked):
253 When an account is doing something (such as refreshing),
254 show the same warning for account deletion as for account
255 editing, to fix projects.maemo.org bug NB#64588.
257 2007-08-16 Murray Cumming <murrayc@murrayc.com>
259 * src/widgets/modest-msg-view-window.h:
260 * src/gnome/modest-msg-view-window.c:
261 * src/maemo/modest-msg-view-window.c:
262 Added modest_msg_view_window_construct().
263 (modest_msg_view_window_new_with_header_model),
264 Added modest_msg_view_window_new_for_search_result),
265 Renamed modest_msg_view_window_new() to
266 modest_msg_view_window_new_for_attachment(),
267 and modest_msg_view_window_is_search_result(),
268 so we can explicitly know that the window is for an
269 attachment or a search result or a message from the list.
271 (modest_msg_view_window_view_attachment):
272 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
273 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
274 Use modest_msg_view_window_new_for_search_result().
276 * src/modest-ui-dimming-rules.c:
277 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
278 for search results, fixing projects.maemo.org bug NB#63811.
280 2007-08-16 Armin Burgmeier <armin@openismus.com>
282 * src/modest-ui-actions.c: Show a banner instead of a dialog when
283 renaming a folder fails, to stay consistent with what happens when
284 creating a folder fails.
286 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
287 slightly country loading from the mmc_mappings file, fixed a memory
290 2007-08-16 Murray Cumming <murrayc@murrayc.com>
292 * src/modest-tny-account-store.c: (volume_path_is_mounted):
293 Check the GnomeVFSVolume activation path instead of the device path,
294 so that the memory card is really really shown in the UI.
296 2007-08-16 Murray Cumming <murrayc@murrayc.com>
298 * src/maemo/easysetup/modest-easysetup-wizard.c:
299 (get_entered_account_title), (on_before_next), (entry_is_empty),
301 * src/maemo/modest-account-settings-dialog.c:
302 (get_entered_account_title), (on_button_signature), (check_data),
303 (save_configuration), (entry_is_empty):
304 Strip the account title of whitespace at the start and end before
305 using it or checking it. This means that an all-whitespace title
306 is not allowed, fixing projects.maemo.org bug NB#64977.
308 2007-08-15 Murray Cumming <murrayc@murrayc.com>
310 * src/modest-ui-actions.h:
311 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
312 to modest_run_account_setup_wizard() and made it public.
313 * src/dbus_api/modest-dbus-callbacks.c:
314 (check_and_offer_account_creation), (on_idle_mail_to),
315 (on_idle_compose_mail), (on_idle_open_default_inbox):
316 Offer account creation if necessary, fixing projects.maemo.org
319 2007-08-15 Murray Cumming <murrayc@murrayc.com>
321 * src/modest-ui-actions.c: (run_account_setup_wizard):
322 Return a gboolean to indicate success.
323 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
324 (modest_ui_actions_on_send): When offering account creation, only
325 give up (return) if account creation failed. Otherwise continue
326 with the original request. This fixed projects.maemo.org bug
329 2007-08-15 Murray Cumming <murrayc@murrayc.com>
331 * src/widgets/modest-recpt-editor.c:
332 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
333 to fix projects.maemo.org bug NB#63789.
335 2007-08-15 Murray Cumming <murrayc@murrayc.com>
337 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
338 (modest_tny_account_store_new): Properly detect the memory card at
339 startup, and add an account for it.
341 2007-08-14 Murray Cumming <murrayc@murrayc.com>
343 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
344 Commented out the MMC code again because it mistakenly detects
345 the card even when it isn't inserted.
347 2007-08-14 Murray Cumming <murrayc@murrayc.com>
349 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
350 Renabled the call to add_mmc_account() because I do not believe
351 it could be the cause of the mentioned hang (in scratchbox, where
352 there is no memory card), and because I have tested that it works
355 2007-08-14 Murray Cumming <murrayc@murrayc.com>
357 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
358 Comment out part of the last commit because it apparently causes
361 2007-08-14 Murray Cumming <murrayc@murrayc.com>
363 * src/modest-tny-account-store.c: Added the add_mmc_account()
364 function to save some copy/pasting.
365 (modest_tny_account_store_new): If the memory card is mounted,
366 create an account for it at the start, instead of waiting for the
367 user to unmount it and mount it.
369 2007-08-13 Murray Cumming <murrayc@murrayc.com>
371 * src/widgets/modest-account-view.c: (on_account_changed):
372 Do not try to use the human-readable TnyAccount name instead of the
373 ID of the modest account to get the transport account. And unref
374 the transport account. This prevents a g_warning(), and a possible
377 2007-08-13 Murray Cumming <murrayc@murrayc.com>
379 * src/maemo/modest-platform.c:
380 (modest_platform_set_update_interval): Handle the new
381 alarmd error to warn when alarmd is not running, as is the case in
382 scratchbox for me now because
383 "Module /usr/lib/alarmd/libretu.so initialization failed"
385 2007-08-13 Murray Cumming <murrayc@murrayc.com>
387 * src/widgets/modest-header-view-render.c:
388 (_modest_header_view_compact_header_cell_data):
389 NULL some strings after freeing them, trying to deal with
390 the double deletion found in projects.maemo.org bug 64183,
391 probably having no effect.
393 2007-08-13 Murray Cumming <murrayc@murrayc.com>
395 * src/maemo/modest-account-settings-dialog.c:
396 (create_page_incoming), (create_page_outgoing): Use a define
397 for the min and max port numbers.
399 (check_hildon_number_editor_and_warn_value_not_in_range),
400 (check_data): Do an extra check for an invalid port number, as needed
401 in projects.maemo.org bug #64275, when the number is cleared, but this
402 does not work due to bugs.maemo.org bug #1806.
404 2007-08-13 Murray Cumming <murrayc@murrayc.com>
406 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
407 Comment out the debug warning about the unexpected D-Bus methods.
408 They are just annoying now.
409 * src/maemo/modest-platform.c:
410 (modest_platform_set_update_interval): Correct the D-Bus path, instead
411 of using a file path, though it did not seem to break things before.
412 It might be needed now:
413 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
414 modest is not already running. This is the behaviour of the old client, and
415 Mox says it is what we should do for modest.
416 This closes projects.maemo.org bug NB#64327.
418 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
420 * src/modest-text-utils.c:
421 Fixed invalid jump due to incorrect string/pointer
423 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
426 2007-08-01 Murray Cumming <murrayc@murrayc.com>
428 * src/modest-account-mgr-helpers.h:
429 * src/modest-account-mgr-helpers.c:
430 Added modest_account_mgr_get_first_account_name(),
431 using code from modest_account_mgr_set_first_account_as_default().
433 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
434 (account_number_changed): Call set_at_least_one_account_visible() so that
435 the first account is visible when first added, without the user having to
437 I do wonder how this worked before.
439 2007-08-01 Murray Cumming <murrayc@murrayc.com>
441 * src/modest-tny-account-store.c: (show_password_warning_only),
442 (show_wrong_password), (request_password_and_wait), (get_password),
443 (modest_tny_account_store_alert): Remove the (incomplete anyway)
444 attempts to show UI only in the main context, which used g_idle_add()
445 and mainloops, because tinymail now guarantees that it only calls these
446 callbacks in the mainloop with the gdk lock. This makes everything much
449 2007-08-01 Murray Cumming <murrayc@murrayc.com>
451 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
452 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
453 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
454 error dialog, instead of ignoring it.
456 2007-08-01 Murray Cumming <murrayc@murrayc.com>
458 * src/maemo/modest-msg-view-window.c:
459 (modest_msg_view_window_get_header),
460 (modest_msg_view_window_last_message_selected):
461 Added comments to explain the use of priv->header_model.
462 * src/modest-ui-dimming-rules.c:
463 (modest_ui_dimming_rules_on_open_msg),
464 (modest_ui_dimming_rules_on_mark_as_read_msg),
465 (modest_ui_dimming_rules_on_mark_as_unread_msg),
466 (modest_ui_dimming_rules_on_remove_attachments),
467 (_invalid_attach_selected), (_selected_msg_marked_as):
468 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
469 and changed the parameter to a ModestMainWindow to make it clearer that
470 it never uses any other kind of window.
471 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
472 instead of the selected message.
473 I notice that much of the dimming code and the ModestMsgViewWindow code
474 hard-codes the assumption that the viewed message is always selected in
475 the header view. This does not seem wise or simple.
477 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
478 examine the actual message instead of whatever might be selected
479 in the header view. This stops the delete toolbar button and menu item
480 from being dimmed when opening a message view the search UI,
481 partially fixing projects.maemo.org bug NB#63811.
483 However, when actually deleting, I now get this warning:
484 "tny_header_set_flags: This is a header instance for a new message.
485 Only priority and attachment flags are supported"
487 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
489 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
491 Show account wizard if no accounts are defined while sending
492 (automatic sending after the account wizard finished does not
493 work because it takes some time until the account manager
494 synchronizes everything. (projects.maemo.org NB#62792)
496 2007-07-30 Murray Cumming <murrayc@murrayc.com>
498 * src/modest-tny-account-store.c: (on_account_removed),
499 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
500 account is removed from the View menu. We have TnyAccountStore
501 and ModestTnyAccountStore signals that seem very similar, but this
502 seems to work for now.
504 * src/maemo/modest-main-window.c:
505 (on_show_account_action_activated): Prevent dereference
506 of a NULL if the accoutn does not really exist, though that
507 should not happen anymore.
509 This fixes projects.maemo.org bug NB#64606.
511 2007-07-30 Murray Cumming <murrayc@murrayc.com>
513 * src/modest-ui-actions.c: (run_account_setup_wizard),
514 (modest_ui_actions_on_accounts): Revert a change that set these
515 to modal dialogs, freezing the UI when they show secondary dialogs.
516 This fixed projects.maemo.org bug NB#64519.
518 2007-07-27 Murray Cumming <murrayc@murrayc.com>
520 * src/widgets/modest-header-view-render.c:
521 (_modest_header_view_compact_header_cell_data):
522 Some checks and initialization to try to deal with a crash,
523 probably ineffective.
525 2007-07-27 Murray Cumming <murrayc@murrayc.com>
527 * src/maemo/modest-maemo-utils.c:
528 (modest_maemo_utils_get_supported_secure_authentication_methods):
529 Make sure that we have a connection, asking the user for one
531 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
532 Check for a connection before showing the wizard, because
533 the wizard needs a connection to check for server capabilities.
535 2007-07-27 Murray Cumming <murrayc@murrayc.com>
537 * src/maemo/modest-account-view-window.c:
538 (on_new_button_clicked): Remember the wizard dialog instance,
539 so we can just present it again if necessary. This prevents
540 multiple windows from appearing if you click again quickly on the
541 New button before the dialog appears, fixing projects.maemo.org
544 2007-07-27 Murray Cumming <murrayc@murrayc.com>
546 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
547 Offer a connection dialog if there is no connection when
548 starting modest. This should fix projects.maemo.org bug NB#61134.
550 2007-07-27 Murray Cumming <murrayc@murrayc.com>
552 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
553 Reverted my last commit. I was able to fix the build by doing
554 apt-get install wpeditor0 (replacing other wpeditor packages) and
555 an explicit apt-get install wpeditor-dev to upgrade the -dev
558 2007-07-27 Murray Cumming <murrayc@murrayc.com>
560 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
561 Commented out the use of wp_text_buffer_replace_image()
562 because it does not exist, to break the build. Added a TODO for it.
564 2007-07-26 Murray Cumming <murrayc@murrayc.com>
566 * src/modest-tny-account-store.c: (recreate_all_accounts):
567 Recreate them even if they were NULL before. I guess something
568 else was already creating them before, or this would never
570 (modest_tny_account_store_get_server_account): Make sure that
571 the tny accounts have been created before trying to find one.
572 This allows libmodest_dbus_client_compose_mail() to work
573 when the UI is not yet visible.
574 This is probably useful in other cases too.
576 (get_password): When the password is wrong after it is entered
577 in the protected password dialog, show an info banner (in an
578 idle handler) before showing the protected password dialog
581 2007-07-26 Murray Cumming <murrayc@murrayc.com>
583 * src/modest-ui-actions.h:
584 * src/modest-ui-actions.c: Added
585 modest_do_refresh_current_folder() containing some code from
586 modest_ui_actions_on_send_receive().
587 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
588 Call modest_do_refresh_current_folder() before refreshing the
589 requested account, as in modest_ui_actions_on_send_receive().
590 This is strange, but seems to be necessary to show new mails.
591 Now new emails are finally visible in the UI when downloaded
592 via the automatic update interval, fixing bug NB#57458.
593 This also works because bug NB#57458 has been fixed somehow.
595 2007-07-26 Murray Cumming <murrayc@murrayc.com>
597 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
598 printf more details when we get unhandled D-Bus methods, because
601 * src/modest-mail-operation.c: (update_account_thread):
602 Comment out the tny_camel_pop_store_account_reconnect(), because this
603 is apparently no longer needed, and it did not work before anyway.
604 See the comment in the code.
606 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
607 by checking the header flags. This fixes projects.maemo.org bug
610 2007-07-25 Murray Cumming <murrayc@murrayc.com>
612 * src/maemo/modest-maemo-utils.h:
613 * src/maemo/modest-maemo-utils.c: Added
614 modest_maemo_show_information_note_in_main_context_and_forget().
615 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
616 Use the new function to show simple error dialogs in the main
617 context, though question dialogs are still in the current context,
618 which is unfortunately usually not the main context. This should
621 2007-07-25 Murray Cumming <murrayc@murrayc.com>
623 * src/modest-tny-account-store.c: (get_password):
624 Never save the entered username and password in gconf,
625 because the UI spec says we should not. This helps
626 slightly with projects.maemo.org bug NB#63671.
628 2007-07-25 Murray Cumming <murrayc@murrayc.com>
630 * src/widgets/modest-msg-edit-window.h:
631 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
632 Moved some code here to make it simpler.
633 (modest_msg_edit_window_attach_file_one): Renamed from
634 modest_msg_edit_window_attach_file_interactive().
635 (modest_msg_edit_window_offer_attach_file): Renamed from
636 modest_msg_edit_window_attach_file() and used
637 modest_msg_edit_window_attach_file_one() instead of
638 copy/pasting the code. The old code for one was not using
639 GnomeVFS. This allows use of smb:// URLs when using send-as
640 from external applications, fixing bug NB#63741.
642 (modest_msg_edit_window_insert_image),
643 (modest_msg_edit_window_add_attachment_clicked):
644 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
645 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
646 Adapted to the new function names.
648 2007-07-25 Murray Cumming <murrayc@murrayc.com>
650 (modest_platform_set_update_interval): Set the alarm recurrence
651 fields so that auto-update does not just happen the first time.
652 This should have fixed projects.maemo.org bug NB#63938.
654 When this happens you can see a printf when the D-Bus method is
656 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
658 However, I do not actually seem to get new POP messages even when
659 clicking the refresh button manually. A restart gets them.
660 This might be a problem in today's tinymail only.
662 2007-07-24 Murray Cumming <murrayc@murrayc.com>
664 * src/maemo/modest-maemo-global-settings-dialog.c:
665 (current_connection):
666 Avoid a crash (probably only in scratchbox) when strcmp()ing a
667 NULL when closing the dialog.
669 2007-07-24 Murray Cumming <murrayc@murrayc.com>
671 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
672 Remove the hacky send/receive that didn't work, and instead
673 refilter the treemodel to make the deleted email really vanish from
674 the UI (though the delete-from-menu code does has commented out
675 the code that does that). This fixes projects.maemo.org bug
678 2007-07-24 Murray Cumming <murrayc@murrayc.com>
680 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
681 Try a couple of tricks to force the treeview to update (
682 poke the folder, and do a send/receive refresh), but the deleted
683 email still appears with a strike-through instead of really being
686 2007-07-23 Murray Cumming <murrayc@murrayc.com>
688 * src/dbus_api/modest-dbus-callbacks.c:
689 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
690 because their ID is not human-readable (see the comment about
691 improvements needed to the osso-email-interface API) and
692 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
694 2007-07-23 Murray Cumming <murrayc@murrayc.com>
696 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
697 (add_folders_to_list), (on_dbus_method_get_folders),
698 (modest_dbus_req_filter):
699 * src/maemo/modest-maemo-utils.c:
700 (on_camel_account_get_supported_secure_authentication):
701 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
702 (on_header_view_focus_in):
703 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
704 * src/modest-formatter.c: (modest_formatter_create_body_part):
705 * src/modest-mail-operation.c: (recurse_folders),
706 (update_account_thread), (get_msgs_full_thread),
707 (modest_mail_operation_get_msgs_full),
708 (modest_mail_operation_xfer_msgs):
709 * src/modest-search.c: (search_mime_part_and_child_parts),
710 (modest_search_account), (modest_search_all_accounts):
711 * src/modest-tny-account.c:
712 (modest_tny_account_get_special_folder), (recurse_folders):
713 * src/modest-tny-local-folders-account.c:
714 (modest_tny_local_folders_account_query_passes):
715 * src/modest-tny-msg.c: (copy_mime_part),
716 (modest_tny_msg_find_body_part_from_mime_part):
717 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
718 (modest_tny_send_queue_try_to_send):
719 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
720 (_modest_ui_actions_open), (download_uncached_messages),
721 (reply_forward), (modest_ui_actions_on_copy),
722 (modest_ui_actions_on_details), (has_retrieved_msgs),
723 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
725 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
726 (_selected_msg_marked_as), (_msg_download_completed),
727 (_selected_msg_sent_in_progress):
728 * src/widgets/modest-attachments-view.c:
729 (modest_attachments_view_set_message):
730 * src/widgets/modest-msg-view.c: (find_cid_image):
731 * tests/check_folder-transfer.c: (find_folders):
732 * tests/check_update-account.c: (func):
733 * tests/dbus_api/test_get_folders.c: (main):
734 Checked all uses of tny_iterator_get_current(), making sure
735 that the object is unreferenced (3 or 4 places did not),
736 and adding checks for NULL.
738 2007-07-23 Murray Cumming <murrayc@murrayc.com>
740 * src/dbus_api/modest-dbus-callbacks.c:
741 (on_idle_open_default_inbox): Make sure that the application UI is
743 * src/maemo/easysetup/modest-easysetup-wizard.c:
744 (on_entry_invalid_character): Show the word whitespace instead
745 of (null) in the banner when whitespace was entered.
746 (show_error): Add a comment that this does not work in
747 Maemo Bora, though we do not know why.
749 2007-07-23 Murray Cumming <murrayc@murrayc.com>
751 * src/modest-tny-account.c:
752 (modest_tny_account_get_special_folder): Use an if instead of
753 an assert for when the parent account name is NULL, because this
754 might be causing a crash in projects.maemo.org bug 63192.
755 * src/modest-mail-operation.c:
756 (modest_mail_operation_send_new_mail_cb),
757 (modest_mail_operation_remove_folder): unref the folder that is
758 returned from modest_tny_account_get_special_folder().
760 2007-07-23 Murray Cumming <murrayc@murrayc.com>
762 * src/modest-ui-actions.c:
763 (modest_ui_actions_on_password_requested):
764 Show mail_ib_login_cancelled info banner when the user cancels
765 the protected password dialog, to fix projects.maemo.org
768 2007-07-23 Murray Cumming <murrayc@murrayc.com>
770 * src/maemo/modest-account-settings-dialog.c:
771 (create_page_outgoing): Put this page in a GtkScrolledWindow,
772 matching the UI mock-up in the UI spec, and allowing access
773 to all widgets even when the on-screen keyboard is active.
775 2007-07-23 Murray Cumming <murrayc@murrayc.com>
777 Reverted this previous commit from Johannes,
778 because the scrollbars are always visible and because
779 I think we only need it on onepage of the account
780 settings, not the account wizard.
781 (I wrote the wrong instructions in the bug.)
783 * src/maemo/easysetup/modest-easysetup-wizard.c:
784 Added scrollbars to account wizard dialog.
785 Fixed projects.maemo.org NB #62744
787 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
789 * src/maemo/easysetup/modest-easysetup-wizard.c:
790 (create_page_user_details):
791 Use auto-cap for name (projects.maemo.org NB#63716)
792 * src/widgets/modest-account-view.c: (on_account_busy_changed):
794 2007-07-22 Armin Burgmeier <armin@openismus.com>
796 * src/maemo/modest-ui-actions.c: Use current account instead of
797 default account for creating viewer windows, so that the viewer
798 window knows to which account the viewed message belongs.
800 * src/maemo/modest-msg-view-window.c: Destroy the window when the
801 corresponding account is deleted. This fixes projects.maemo.org bug
804 2007-07-18 Armin Burgmeier <armin@openismus.com>
806 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
807 the dialog close after entering an invalid port number and clicking
808 OK. This fixes projects.maemo.org bug NB#63602.
810 2007-07-18 Armin Burgmeier <armin@openismus.com>
812 * src/modest-tny-account-store.c:
813 (get_server_accounts): Set parent modest account name for each
814 connection-specific transport account so that special folders of such
815 an account can be looked up. This fixes a crash when changing account
816 settings. This might also be related to projects.maemo.org bug
819 2007-07-16 Armin Burgmeier <armin@openismus.com>
821 * src/modest-ui-actions.c: Added a button to create a folder to the
822 move-to dialog. This fixes projects.maemo.org bug NB#59863.
824 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
826 * src/maemo/easysetup/modest-easysetup-wizard.c:
827 Added scrollbars to account wizard dialog.
828 Fixed projects.maemo.org NB #62744
830 2007-07-16 Murray Cumming <murrayc@murrayc.com>
832 * src/widgets/modest-msg-view.h:
833 * src/widgets/modest-msg-view.c:
834 Added modest_msg_view_get_message_is_empty() but this needs
836 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
837 Check if there is any text in the message yet.
838 But this needs to be implemented properly.
839 (modest_msg_edit_window_toggle_find_toolbar):
840 * src/maemo/modest-msg-view-window.c:
841 (modest_msg_view_window_toggle_find_toolbar):
842 Show a banner warning if there is no text to search, when
843 trying to start a search. This partially fixes
844 projects.maemo.org bug NB#62350.
846 2007-07-13 Murray Cumming <murrayc@murrayc.com>
848 * src/modest-mail-operation.c: (update_account_thread):
849 Initialized num_new_headers to fix the build.
851 2007-07-13 Murray Cumming <murrayc@murrayc.com>
853 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
854 Ignore modest accounts whose server accounts don't exist in gconf.
855 This prevents us trying to create TnyAccount instances for those
856 server accounts when the server account has been removed from gconf,
857 but the parent modest account has not yet been removed from modest.
858 I don't know why this is only noticeable now. It was probably just
859 a harmeless g_warning() anyway.
861 2007-07-13 Murray Cumming <murrayc@murrayc.com>
863 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
864 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
866 2007-07-12 Armin Burgmeier <armin@openismus.com>
868 * src/maemo/modest-main-window.c: Make default account appear bold
869 in view, tools/send & receive and toolbar/send & receive SCM menus.
870 This fixes projects.maemo.org bug NB#59010.
872 2007-07-12 Murray Cumming <murrayc@murrayc.com>
874 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
875 Add a short-cut, by checking if the folder store is an account.
876 This ensures that the Sort menu item and toolbar is dimmed for
877 the local-folders account root item, fixing
878 projects.maemo.org bug NB#62545.
880 2007-07-12 Murray Cumming <murrayc@murrayc.com>
882 * src/modest-tny-account-store.c: (get_password):
883 Show the password dialog (via the signal) only in the mainloop, via
884 an idle handler that we wait for. This could theoretically prevent
885 hangs, though I worry that it could introduce some too.
887 2007-07-12 Murray Cumming <murrayc@murrayc.com>
889 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
890 * src/maemo/modest-platform.c:
891 (modest_platform_connect_and_wait):
892 Take a TnyAccount* parameter and try to set it to online
893 (a TnyCamel-only API), because tinymail sets accounts to offline
894 when the user cancels a password dialog, and doesn't ask again until
895 it has been set to online.
896 However, this is commented out because it causes a hang now.
898 (modest_platform_connect_and_wait_if_network_account):
899 * src/modest-mail-operation.c:
900 (modest_mail_operation_update_account):
901 * src/modest-platform.h:
902 * src/modest-ui-actions.c: (_modest_ui_actions_open),
903 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
905 2007-07-12 Armin Burgmeier <armin@openismus.com>
907 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
909 * src/modest-mail-operation.c:
910 * src/modest-ui-actions.c: Check for already existing folder before
911 querying the server, show error message from camel if the request
912 still fails. This fixes projects.maemo.org bug NB#58701.
914 2007-07-12 Murray Cumming <murrayc@murrayc.com>
916 * src/modest-tny-account-store.h:
917 * src/modest-tny-account-store.c:
918 Added modest_tny_account_store_forget_password_in_memory(),
919 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
920 when creating a new account, so that new passwords will be used, instead of
921 us thinking that it's a second request as a result of a failed password again.
923 2007-07-12 Murray Cumming <murrayc@murrayc.com>
925 * src/dbus_api/modest-dbus-callbacks.c:
926 (on_idle_open_message): If the message is in drafts then open it
927 in an edit window instead of a view window. This fixes
928 projects.maemo.org bug NB#63005.
930 2007-07-12 Murray Cumming <murrayc@murrayc.com>
932 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
933 Avoided a harmless g_warning().
935 2007-07-12 Murray Cumming <murrayc@murrayc.com>
937 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
938 Pass the modest account name, not the TnyAccount display name to
939 modest_msg_view_window_new() so that the reply feature works,
940 fixing projects.maemo.org bug NB#62892.
942 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
943 (modest_msg_view_window_new_with_header_model):
944 * src/maemo/modest-msg-view-window.c:
945 (modest_msg_view_window_new_with_header_model),
946 (modest_msg_view_window_new):
947 * src/modest-ui-actions.c: (reply_forward):
948 * src/widgets/modest-msg-view-window.h:
949 * src/widgets/modest-window.c: (modest_window_set_active_account):
950 Rename an account parameter to modest_account_name to make this clearer.
952 2007-07-11 Murray Cumming <murrayc@murrayc.com>
954 * src/modest-ui-actions.h:
955 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
956 modest_do_message_delete().
957 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
958 Call modest_do_message_delete(), hoping that this would cause messages
959 to be really deleted from search instead of just marked with strike through.
960 Does not seem to help.
962 2007-07-11 Armin Burgmeier <armin@openismus.com>
964 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
965 priv->reselect to FALSE prior to calling
966 modest_folder_view_select_first_inbox_or_local() to prevent endless
967 recursion and thus a crash on startup.
969 2007-07-11 Armin Burgmeier <armin@openismus.com>
971 * src/maemo/modest-account-settings-dialog.h: Include
972 <gtk/gtknotebook.h> to fix the build (at least for me).
974 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
975 Use "New FolderN" as default suggested name if "New folder" already
976 exists, with N being the first free number, though never exceed "New
977 folder99" in which case we just fall back to "New Folder" even though
978 it already exists. This fixes projects.maemo.org bug NB#58663.
980 2007-07-11 Murray Cumming <murrayc@murrayc.com>
982 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
983 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
984 projects.maemo.org bug NB#62778.
986 2007-07-11 Murray Cumming <murrayc@murrayc.com>
988 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
989 Ignore the wrong (for now) secure-smtp setting in the presets -
990 just default to requiring secure authentication for SMTP, because
993 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
995 * src/widgets/modest-folder-view.c: (filter_row)
996 Do not show drafts folder (see UI specs)
998 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
1000 * src/modest-ui-actions.c:
1001 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
1002 place and also not necessary.
1004 * src/widgets/modest-folder-view.c: (filter_row)
1005 Guess folder type and hide Sent & Outbox if necessary.
1006 Fixed project.maemo.org NB#57328
1008 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1010 * src/modest-ui-actions.h:
1011 * src/modest-ui-actions.c:
1012 (modest_ui_actions_on_delete_message):
1013 Move some code into a new
1014 modest_ui_actions_refresh_message_window_after_delete()
1015 function so we can use it from elsewhere.
1017 * src/dbus_api/modest-dbus-callbacks.c:
1018 (on_idle_delete_message), (on_delete_message): Used an idle
1019 handler, as we do for the other D-Bus method handlers.
1020 Call modest_ui_actions_refresh_message_window_after_delete()
1021 if the deleted message was open in a window. This fixed
1022 projects.maemo.org bug NB#62862.
1024 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1026 * src/modest-main.c: (main): Only show the UI at the start if
1027 the showui command line option was given. For instance,
1028 run-standalone src/modest showui
1029 Otherwise, we wait for the top_application D-Bus method to
1030 be sent by hildon-desktop when the application is selected
1032 This allows us to run without a UI when osso-global-search
1033 uses our D-Bus methods.
1035 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1037 * src/dbus_api/modest-dbus-api.h: Added a define for a
1038 top-application D-Bus method.
1039 * src/dbus_api/modest-dbus-callbacks.c:
1040 (on_top_application),
1041 (modest_dbus_req_handler): Handle the top-application D-Bus
1042 method, which might be an undocumented D-Bus signal sent by
1043 hildon-desktop when it starts the application from the menu.
1044 But I am not sure and I need to test it on the device, because
1045 my scratchbox does not have the application in the menu now.
1046 This method shows the main window, so that it can be invisible
1047 when started, for instance, just for email searching from
1050 * src/maemo/modest-main-window.c: (restore_settings),
1051 (modest_main_window_new): Do not show the window immediately
1052 upon creation. We show it later.
1053 * src/modest-widget-memory.c: (save_settings_paned):
1054 Try (unsuccessfully) to avoid saving the paned position when
1055 it is not even visible.
1056 (restore_settings_paned): Do not allow a silly paned position.
1057 This seems necessary when not showing the window at first.
1059 * tests/dbus_api/Makefile.am:
1060 * tests/dbus_api/test_top_application.c: (main): Test for the
1063 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1065 * src/modest-ui-dimming-rules.c:
1066 (modest_ui_dimming_rules_on_new_msg),
1067 (modest_ui_dimming_rules_on_reply_msg),
1068 (modest_ui_dimming_rules_on_delete_msg),
1069 (modest_ui_dimming_rules_on_details),
1070 (modest_ui_dimming_rules_on_view_window_move_to),
1071 (modest_ui_dimming_rules_on_view_previous),
1072 (modest_ui_dimming_rules_on_view_next),
1073 (_invalid_folder_for_purge): Added checks before
1074 casting the window. This looks like an actual
1075 logic error in _invalid_folder_for_purge(), because it
1076 tries to use a ModestMainWindow as a message window.
1078 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1080 * src/maemo/modest-account-settings-dialog.c:
1081 (show_error): Use the same implementation as in
1082 modest-easysetup-wizard.c:
1083 (on_entry_invalid_character): The logical ID contains a %s.
1084 Guessed what it should be.
1085 (on_entry_max), (check_data), (on_response): Adapt to
1086 changed show_error().
1087 (create_page_account_details): Really call
1088 modest_validating_entry_set_func() on the correct widgets.
1089 * src/maemo/easysetup/modest-easysetup-wizard.c:
1090 (on_entry_invalid_character): Fix the logical ID here too.
1091 (create_page_account_details),
1092 (create_page_user_details):
1094 modest_validating_entry_set_func() on the correct widgets.
1096 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1097 Do not try to use the account if it is NULL.
1099 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1101 * src/modest-ui-actions.c: (create_move_to_dialog),
1102 (modest_ui_actions_on_main_window_move_to),
1103 (modest_ui_actions_on_msg_view_window_move_to):
1104 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
1105 (filter_row), (modest_folder_view_show_non_move_folders):
1106 * src/widgets/modest-folder-view.h:
1108 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
1109 the Sent folder yet as it does not report the correct folder type.
1111 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1113 * src/maemo/modest-msg-edit-window.c: (init_window):
1116 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1118 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1119 Take a parent widget instead of a parent window, and
1120 implement this with hildon_banner_show_information() instead.
1121 Non-Maemo builds can just ifdef that there.
1122 This fixed projects.maemo.org bug NB#62766.
1124 (on_entry_invalid_character): Use show_error() again instead
1125 of using hildon directly, and use the _CS() macro to use the correct
1127 (create_account), (check_for_supported_auth_methods), (on_entry_max):
1128 Pass a widget instead od a window to show_error().
1130 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1132 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1133 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
1134 This allows us to show the server name in the error message, fixing
1135 projects.maemo.org bug NB#62904.
1136 Also, use the appropriate logical ID message for the account protocol.
1138 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1140 * src/modest-tny-account-store.c: (on_idle_wrong_password):
1141 A compilation fix, though the build wasn't broken for me.
1143 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1145 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
1146 Do not try to unref a NULL folder store, to avoid a runtime warning.
1147 This seems to happen sometimes when changing accounts settings.
1149 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1151 * src/modest-tny-account-store.c:
1152 (modest_tny_account_store_instance_init),
1153 (modest_tny_account_store_finalize),
1154 (on_account_settings_hide), (on_idle_wrong_password):
1155 Use a GHashTable to ensure that we only show one account settings
1156 dialog per modest account. This avoids us having a dialog open for
1157 both the store and transport accounts, or due to repeated get_password()
1158 calls that shouldn't happen anyway.
1160 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1162 * src/maemo/modest-maemo-utils.c: (on_hide),
1163 (modest_maemo_show_dialog_and_forget): Handle the response, because
1164 the window is not even hidden by default.
1166 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1167 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1168 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1169 which seems to prevent some modality problems.
1171 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1172 Ignore user cancellation errors.
1174 * src/modest-account-mgr-helpers.h:
1175 * src/modest-account-mgr-helpers.c:
1176 Added modest_server_account_get_password() and
1177 modest_server_account_get_has_password() to avoid direct use of
1180 * src/maemo/modest-account-settings-dialog.h:
1181 * src/maemo/modest-account-settings-dialog.c:
1182 (modest_account_settings_dialog_init): Store the notebook so we can
1184 Added modest_account_settings_dialog_switch_to_user_info().
1186 * src/modest-tny-account-store.c:
1187 (get_password): When the password in the account settings is wrong (we think),
1188 show the relevant page of the account settings dialog, in the mainloop.
1189 However, we currently get many of these at once because cancel does not
1191 (forget_password): Do not forget the password
1192 from the account settings, because this causes side-effects when
1193 tinymail seems to call it at strange time, maybe because of how we
1194 are cancelling get_password().
1195 (modest_tny_account_store_alert): Ignore user cancellations.
1197 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1199 * src/maemo/modest-maemo-utils.h:
1200 * src/maemo/modest-maemo-utils.c:
1201 Added modest_maemo_show_information_note_and_forget() for use instead of
1202 gtk_dialog_run() when the response is not needed, to avoid an extra
1203 mainloop which could cause a hang.
1205 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1206 Use the logical IDs for the error message, though they are not
1207 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1208 because gtk_dialog_run() caused a hang here (the window did not close).
1209 This fixes projects.maemo.org bug NB#62646.
1211 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1213 * src/modest-account-mgr-helpers.h:
1214 * src/modest-account-mgr-helpers.c:
1215 Added modest_account_mgr_get_store_protocol().
1217 * src/maemo/modest-account-view-window.c:
1218 (on_delete_button_clicked): Show different warning text depending on
1219 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1220 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1223 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1225 * src/maemo/modest-msg-edit-window.c:
1226 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1227 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1229 2007-07-07 Armin Burgmeier <armin@openismus.com>
1231 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1232 ckdg_ib_maximum_characters_reached from correct package.
1234 * src/modest-ui-actions.c: Show an error message when a folder could
1235 not be created. Tinymail does not give us specific error codes about
1236 what has gone wrong, so we assume that a folder with that name
1237 already exists, though there might be other reasons.
1239 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1241 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1242 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1243 give a more exact error message that can be partly translated.
1245 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1247 * src/maemo/modest-address-book.c:
1248 (select_email_addrs_for_contact): Specify a default window size for the
1249 select-email-address dialog, so that it is probably big enough for the
1250 title. This should fix projects.maemo.org bug NB#62277.
1252 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1254 * src/maemo/easysetup/modest-easysetup-wizard.c:
1255 (create_page_complete_easysetup): Use
1256 gtk_widget_set_size() request to ensure that the text wraps
1259 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1261 * src/maemo/easysetup/modest-easysetup-wizard.c:
1262 (on_entry_invalid_character), (create_page_account_details),
1263 (create_page_user_details):
1264 Use new API of ModestValidatingEntry. But for some reason the banner is
1265 not shown. I will have to investigate that further.
1267 * src/widgets/modest-validating-entry.c: (on_insert_text),
1268 (modest_validating_entry_set_func):
1269 * src/widgets/modest-validating-entry.h:
1270 Added a new callback function to be able to react to prevented
1271 characters whitespaces to e.g show a banner.
1273 2007-07-05 Armin Burgmeier <armin@openismus.com>
1275 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1276 notification of HildonNumberEditor instead of remembering the port
1277 number. Thanks to Johannes for pointing this out.
1279 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1281 * src/maemo/easysetup/modest-easysetup-wizard.c:
1282 Check if there are any user changes before showing a confirmation
1283 dialog (projects.maemo.org NB#60946)
1285 2007-07-05 Armin Burgmeier <armin@openismus.com>
1287 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1288 number at the beginning of the dialog and set the modified flag at the
1289 end if the port number has changed. This is necessary because
1290 HildonNumberEditor does not support notification when the value has
1293 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1295 * src/modest-ui-actions.c:
1296 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1297 a connection before asking anything else. Correct the check for the destination
1298 folder so that it succeeds when online.
1299 This fixed projects.maemo.org bug NB#61645.
1301 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1303 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1304 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1305 to fix projects.maemo.org bug NB#62439.
1307 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1309 * src/modest-tny-account.c: (on_connection_status_changed):
1310 Really do not use tny_device_force_offline() here. See the previous comment.
1312 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1314 * src/modest-tny-account.c: (on_connection_status_changed):
1315 Do not use tny_device_force_offline() when tinymail says that something
1316 went wrong with the connection. It seems to report this unnecessarily.
1318 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1320 * src/maemo/modest-connection-specific-smtp-window.c:
1321 (modest_connection_specific_smtp_window_init):
1322 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1323 does not seem to have any effect in osso 1.1 (though it works in
1324 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1326 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1328 * src/maemo/modest-connection-specific-smtp-window.c:
1329 Fix UI specification problems with projects.meamo.org NB#60479
1331 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1333 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1334 clue when this has failed, because the error dialog is not always shown
1335 (at least in earlier version).
1337 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1338 GError message, because the generic error dialog is not helpful.
1340 'This message is not currently available (can't let a new connection go online)'
1341 when trying to open an IMAP message.
1343 (_modest_ui_actions_open): Offer a connection when some messages would
1344 have to be downloaded and we are offline.
1346 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1348 * src/widgets/modest-folder-view.c:
1349 Don't check for MERGE type anymore as we use the correct type
1351 NOTE: For the last two changes you need to update your tinymail copy
1352 because of API changes!
1354 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1356 * src/modest-tny-local-folders-account.c:
1357 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1358 (see projects.maemo.org NB#61580)
1360 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1362 * src/modest-tny-account.c: (on_connection_status_changed):
1363 Commented out the call to modest_platform_connect_and_wait() because this
1364 seems to always hang, and I would like to know if this is the only thing
1365 that causes a hang when showing the connection dialog.
1366 It is not very useful anyway.
1368 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1370 * src/maemo/modest-msg-view-window.c:
1371 (modest_msg_view_window_select_next_message):
1373 * src/modest-platform.h:
1374 * src/maemo/modest-platform.c:
1375 Added modest_platform_connect_and_wait(), which calls
1376 tny_maemo_conic_device_connect() always in the main thread, by calling it
1377 in an idle handler and waiting for the idle handler to run. It should be
1378 in the main thread because it uses GTK+ UI code. It just returns TRUE
1379 if the device is already online.
1381 There is some nasty code to ensure that subsequent calls to
1382 modest_platform_connect_and_wait() just wait for the first one to finish,
1383 by checking repeatedly in another idle handler. This is necessary,
1384 because other threads (or even the main thread, via another idle handler)
1385 can call modest_platform_connect_and_wait() while
1386 modest_platform_connect_and_wait() is running.
1388 (modest_platform_connect_and_wait_if_network_account),
1389 (modest_platform_connect_and_wait_if_network_folderstore):
1390 Convenience functions that calls modest_platform_connect_and_wait() if
1391 the account or folder might want network access.
1393 * src/modest-mail-operation.c:
1394 (modest_mail_operation_update_account):
1395 * src/modest-ui-actions.c: (download_uncached_messages),
1396 (modest_ui_actions_on_rename_folder), (delete_folder),
1397 (modest_ui_actions_on_main_window_move_to),
1398 (modest_ui_actions_on_msg_view_window_move_to):
1399 * src/widgets/modest-folder-view.c:
1400 (drag_and_drop_from_folder_view):
1401 Offer a connection if we are offline.
1403 * src/modest-tny-account.c: (on_connection_status_changed):
1404 Document this as only handling errors during network operations in progress,
1405 and replace the idle code with a simple call to
1406 modest_platform_connect_and_wait(), which does this instead.
1408 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1410 * src/modest-tny-account.c:
1411 (modest_tny_account_get_special_folder): (util_on_idle),
1412 Handle the GError so we can see when tny_folder_store_get_folders()
1413 fails, as it currently does while something else is connecting.
1415 Added util_run_in_main_thread_and_wait()
1416 which uses an idlen handler and mainloop to ensure that the function
1417 is called in the main thread.
1418 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1419 to make sure that we call attempt the connection in the mainloop only,
1420 which might solve some hangs.
1422 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1424 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1425 be found by their display name. This is never useful.
1426 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1427 by its ID, instead of trying to use its ID as its display name.
1429 * src/modest-tny-account-store.h:
1430 * src/modest-tny-account.c:
1431 (modest_tny_account_get_special_folder): Add a g_warning() when
1432 tny_folder_store_get_folders() returns an empty list for the maildir.
1434 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1435 Add a g_warning() when this returns NULL, because that it not allowed
1438 2007-07-02 Armin Burgmeier <armin@openismus.com>
1440 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1441 note when trying to cancel the wizard. This fixes projects.maemo.org
1444 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1446 * src/modest-tny-account.h:
1447 * src/modest-tny-account.c:
1448 (modest_tny_account_new_from_server_account),
1449 (modest_tny_account_new_from_server_account_name),
1450 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1451 because this must now be set before setting the proto. This is usd in
1452 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1453 warning in camel_session_get_service() caused by
1454 tny_camel_transport_account_prepare().
1456 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1459 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1461 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1463 (modest_connection_specific_smtp_edit_window_init):
1465 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1466 of "changed" for now
1468 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1470 * src/modest-tny-account.c:
1471 (modest_tny_account_new_from_server_account):
1472 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1473 now uses to request a connection when it needs one, and which it uses
1474 to tell us that something is wrong with the connection, so we can force
1475 the accounts offline to prevent further problems.
1477 * src/modest-defs.h:
1478 * src/modest-init.c: (init_default_settings):
1479 * src/modest-mail-operation.c:
1480 (modest_mail_operation_update_account):
1481 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1482 This should not be necessary anymore. Do not set the conf key that
1483 determined this (it was always TRUE and not set anywhere else).
1485 * src/modest-ui-actions.h: Remove unused and unimplemented
1486 modest_ui_actions_on_online_toggle_toggled().
1488 2007-06-29 Murray Cumming <murrayc@murrayc.com
1490 * src/maemo/modest-main-window.c: (connect_signals):
1491 Don't connect to delete_event twice. Maybe this was harmless.
1493 2007-06-29 Murray Cumming <murrayc@murrayc.com
1495 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1496 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1497 Debug output to give some more clue when a folder move is not allowed.
1499 2007-06-28 Murray Cumming <murrayc@murrayc.com
1501 * src/modest-tny-account.c: (on_modest_file_system_info),
1502 (modest_tny_account_get_mmc_account_name):
1503 Always call the callback, without checking whether the name has changed.
1504 * src/widgets/modest-folder-view.c: (strings_are_equal),
1505 (on_model_foreach_set_name), (on_get_mmc_account_name),
1506 (text_cell_data): Compare the name here, and use the name from
1507 the account rather than from the
1508 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1509 if the name was changed after the account was added to the model.
1510 That's a tinymail bug but not one that I want to fix now.
1512 This finally fixes projects.maemo.org bug NB#59301.
1514 2007-06-27 Armin Burgmeier <armin@openismus.com>
1516 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1519 2007-06-27 Murray Cumming <murrayc@murrayc.com
1521 * src/modest-tny-account.h:
1522 * src/modest-tny-account.c:
1523 Added modest_tny_account_get_mmc_account_name(), to set the memory
1524 card name asynchronously for the given account and then notify.
1525 (modest_tny_account_new_for_local_folders): Use this new function instead
1526 of using hildon_file_system_info_async_new() directly.
1528 * src/widgets/modest-folder-view.c: (text_cell_data):
1529 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1530 gtk_tree_model_row_changed() when it is available.
1532 This should fix projects.maemo.org bug NB#59301.
1534 2007-06-27 Murray Cumming <murrayc@murrayc.com
1536 * src/modest-mail-operation.c: (update_account_thread),
1537 (get_msgs_full_thread): Fix typo failures in the revert
1540 2007-06-27 Murray Cumming <murrayc@murrayc.com
1542 * src/maemo/modest-maemo-global-settings-dialog.c:
1543 (idle_select_default_focus):
1544 * src/modest-mail-operation.c: (idle_notify_progress),
1545 (idle_notify_progress_once), (set_last_updated_idle),
1546 (update_account_thread), (get_msgs_full_thread):
1547 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1548 * src/widgets/modest-header-view.c:
1549 (idle_notify_headers_count_changed_destroy),
1550 (idle_notify_headers_count_changed):
1551 Reverted the additions of gdk_threads_enter/leave(), in case this
1552 helps with a startup hang on the device.
1554 2007-06-26 Armin Burgmeier <armin@openismus.com>
1556 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1557 for supported secure authentication methods from server by
1558 gtk_dialog_run(), saving CPU time and a potential race condition.
1560 2007-06-26 Armin Burgmeier <armin@openismus.com>
1562 * src/maemo/modest-maemo-utils.h:
1563 * src/maemo/modest-maemo-utils.c: Added a
1564 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1565 only error code to tell the calling code when the user canceled the
1568 * src/maemo/modest-account-settings-dialog.h:
1569 * src/maemo/modest-account-settings-dialog.c:
1570 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1571 message if the retrieval of secure authentication methods was canceled
1572 by the user. Perform the check before saving anything to configuration
1573 to not end up with half-committed configuration changes, do not show
1574 a "Saving to configuration failed" note when authentication methods
1575 could not be retrieved.
1577 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1580 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1582 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1583 Only return the first level of folders under accounts, because the
1584 osso-global-search UI spec doesn't want the rest.
1585 This fixed projects.maemo.org bug NB#61811.
1587 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1589 * src/modest-tny-account-store.c:
1590 * src/modest-tny-account-store.h:
1591 Added modest_tny_account_is_memory_card_account().
1592 * src/maemo/modest-main-window.c: (create_details_widget):
1593 Show the same information items for the memory card as we show for the
1594 local-folders, to fix projects.maemo.org bug NB#59307.
1596 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1598 * src/modest-tny-account-store.c: (get_password):
1599 Added some checks for NULL to maybe prevent crashes, though I think
1600 it was Philip's last commit that actually prevented the crash here
1601 when creating a first new account.
1602 But the new account is still not usable (no messages are shown)
1603 until a restart of the application.
1605 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1607 * src/maemo/modest-maemo-global-settings-dialog.c:
1608 (idle_select_default_focus):
1609 * src/modest-mail-operation.c: (idle_notify_progress),
1610 (idle_notify_progress_once), (idle_notify_update_account_queue),
1611 (set_last_updated_idle), (update_account_thread),
1612 (notify_get_msgs_full), (get_msgs_full_destroyer),
1613 (get_msgs_full_thread):
1614 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1615 * src/widgets/modest-header-view.c:
1616 (idle_notify_headers_count_changed_destroy),
1617 (idle_notify_headers_count_changed):
1618 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1619 all idle handlers, because some other thread could be blocking
1620 the GDK lock, so that it can do GUI stuff.
1622 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1624 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1625 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1626 (on_idle_send_receive), (on_idle_open_default_inbox):
1627 * src/maemo/modest-msg-edit-window.c:
1628 (modest_msg_edit_window_attach_file_noninteractive):
1629 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1630 to prevent a hang. I don't quite understand why these are necessary,
1631 beause we should already be in the main loop. I guess something outside
1632 of the main loop is taking the lock.
1634 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1635 we are really using URIs, and use files that are more likely to exist.
1637 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1639 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1640 necessary because configure.ac now defines different variables.
1642 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1644 * libmodest-dbus-client/libmodest-dbus-client.c:
1645 * libmodest-dbus-client/libmodest-dbus-client.h:
1646 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1647 libmodest_dbus_client_compose_mail() is what things actually use.
1649 * src/dbus_api/modest-dbus-api.h:
1650 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1651 * tests/dbus_api/Makefile.am:
1652 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1655 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1657 * src/modest-init.c: (modest_init_local_folders):
1658 For memory-card (or other non local-folders) maildir accounts,
1659 always create an Archive folder, so that there is somewhere to put
1660 messages. This should be less confusing, because the user does not need
1661 to guess that the need to create a folder.
1663 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1665 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1666 Fixed icon size by using (50, 50) which is the same as defined by
1669 2007-06-25 Armin Burgmeier <armin@openismus.com>
1671 * src/widgets/modest-window-mgr.c:
1672 * src/modest-init.c:
1673 * configure.ac: Correctly recognize hildon-notify presence and fixed
1674 the build without it being installed.
1676 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1678 * libmodest-dbus-client/libmodest-dbus-client.c:
1679 (libmodest_dbus_client_search): Fix the build. Sorry.
1680 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1681 (reply_forward_cb): Initialize variables to fix the build.
1683 * src/modest-tny-account-store.c:
1684 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1685 comparison (a silly typo) so that email search results can be opened
1686 when there are more than one account.
1688 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1690 * libmodest-dbus-client/libmodest-dbus-client.c:
1691 (libmodest_dbus_client_search),
1692 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1693 instead of 1 second, because the search gets folders and messages from
1694 the server, which can take a long time. When it times out,
1695 osso-global-search will report no results.
1697 We need to specify whether we should search only cached information
1698 (maybe with a user preference), and the osso-email-search-plugin
1699 API should really be improved to allow that option, and to allow results
1700 to be delivered asynchronously in batches.
1702 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1704 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1705 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1706 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1708 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1710 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1711 that is an empty string. D-Bus seems to give us these instead of NULL.
1713 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1715 * src/dbus_api/modest-dbus-callbacks.c:
1716 * src/maemo/easysetup/modest-easysetup-wizard.h:
1717 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1718 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1719 (modest_connection_specific_smtp_edit_window_init):
1720 * src/maemo/modest-maemo-global-settings-dialog.c:
1722 * src/maemo/modest-maemo-utils.c:
1723 (modest_maemo_utils_setup_images_filechooser):
1724 * src/maemo/modest-main-window.c: (create_details_widget):
1725 * src/maemo/modest-msg-edit-window.c:
1726 (modest_msg_edit_window_attach_file_noninteractive),
1727 (modest_msg_edit_window_color_button_change),
1728 (modest_msg_edit_window_set_zoom):
1729 * src/modest-mail-operation.c: (update_account_thread):
1730 * src/modest-tny-account-store.c:
1731 * src/modest-tny-account.c:
1732 * src/widgets/modest-global-settings-dialog.c:
1733 * src/widgets/modest-window.h:
1735 Fixed build on bora!
1737 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1739 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1740 * src/modest-search.c: (modest_search_folder),
1741 (modest_search_all_accounts): Actually search only in the specified folder,
1742 doing a simple match on the folder ID.
1743 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1744 and added some documentation.
1746 2007-06-22 Armin Burgmeier <armin@openismus.com>
1748 * src/maemo/modest-maemo-utils.h:
1749 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1750 modest_maemo_utils_get_supported_secure_authentication_methods.
1752 * src/maemo/easysetup/modest-easysetup-wizard.c:
1753 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1754 one occured, not just "Server does not support secure authentication".
1756 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1758 * src/modest-tny-account-store.c: (get_password):
1759 Restored the call to tny_account_set_user() because Philip seems to have
1760 stopped this from crashing (by not using the freed string). It still does
1761 not work, but now we can test it.
1763 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1765 * src/maemo/modest-msg-edit-window.c: (init_window):
1766 Comment out use of an uninitialzed GtkScrolledWindow variable,
1767 to fix the build and stop a crash. Yet again.
1769 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1771 * src/modest-tny-account-store.c: (get_password):
1772 Remove the call to tny_account_set_user() because this actually crashes.
1773 As mentioned in the last commit, it is known to not work anyway.
1775 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1777 * src/modest-tny-account-store.c: (get_password):
1778 Use tny_account_set_username() to tell tinymail that the username might
1779 have changed too. But tinymail ignores this: see projects.maemo.org
1781 * src/modest-ui-actions.c:
1782 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1783 reset the connection when changing the username, and improve the comments.
1784 Save the changed username to gconf at least, so it is used when Modest is
1787 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1789 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1790 Do not use a query, so that we get all folders, including for POP and
1791 local-folders. They work as search criteria too.
1792 This fixes projects.maemo.org bug NB#57740.
1794 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1796 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1797 Comment out the use of hildon_notification_set_sound() because it is
1798 not declared, to fix the build. Warnings are serious, people.
1800 2007-06-21 Armin Burgmeier <armin@openismus.com>
1802 * src/maemo/modest-maemo-utils.h:
1803 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1804 modest_maemo_utils_get_supported_secure_authentication_methods()
1805 to query authentication methods for a specific user. This should fix
1806 projects.maemo.org bug NB#61369.
1808 * src/maemo/easysetup/modest-easysetup-wizard.c:
1809 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1812 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1814 * libmodest-dbus-client/libmodest-dbus-client.h:
1815 * libmodest-dbus-client/libmodest-dbus-client.c:
1816 (modest_dbus_message_iter_get_search_hit),
1817 (libmodest_dbus_client_search):
1818 Reorganised and commented this.
1819 Removed modest_search_hit_free() from the public API because it
1822 Added libmodest_dbus_client_get_folders() and
1823 modest_folder_result_list_free().
1825 * src/dbus_api/modest-dbus-api.h:
1826 * src/dbus_api/modest-dbus-callbacks.c:
1827 (modest_dbus_req_filter): Commented. Moved most code to
1828 on_dbus_method_search() and added on_dbus_method_get_folders().
1830 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1831 of the extra D-Bus handler.
1833 * tests/dbus_api/Makefile.am:
1834 * tests/dbus_api/test_get_folders.c: New test for
1835 libmodest_dbus_client_get_folders(). This seems to return an empty list
1836 at the moment. That could be the same error that causes the message list
1837 to be empty sometimes.
1838 This should help with projects.maemo.org bug NB#57740.
1840 2007-06-21 Armin Burgmeier <armin@openismus.com>
1842 * src/modest-mail-operation.c: Do not call
1843 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1844 notify the operation's end after having set the status to CANCELED for
1845 the operation queue to listen on. This fixes a deadlock when there
1846 were mail operations in the queue during its finalization.
1848 * src/modest-singletons.c: Reordered uninitialization of the account
1849 manager to happen after the mail operation queue was uninitialized
1850 because the mail operation's in the queue might still try to access
1851 the account manager (see modest_mail_operation_notify_end()). This
1852 fixes a potential crash when terminating the application.
1854 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1856 * src/modest-search.c:
1857 (search_mime_part_and_child_parts): Moved some code here so we
1858 can search recursively in child folders.
1859 (modest_search_folder): Search in the message as a mime part, instead
1860 of just its child mime parts.
1861 (read_chunk), (search_mime_part_ogs):
1862 Check how many bytes were read, to prevent an endless loop.
1863 Searching in message bodies now works. This finishes the fix for
1864 projects.maemo.org bug NB#61007.
1866 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1868 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1869 Add a g_warning when the item is not a folder.
1871 * src/modest-ui-dimming-rules.c:
1872 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1873 when selected item is not a folder (for instance, an account), because
1874 the UI spec only talks about folders.
1875 I am not sure what the UI spec wants, so this might not totally fix
1876 projects.maemo.org bug NB#60794.
1878 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1880 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1881 (load_from_file): Sort the list. The unsorted list would be more noticeable
1882 in non-English locales.
1884 * src/maemo/modest-msg-edit-window.c:
1885 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1886 warning and fix the build.
1888 * src/maemo/modest-progress-bar-widget.c:
1889 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1890 avoid a g_warning, and probably to avoid a crash.
1892 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1894 * src/modest-search.c: (modest_search_folder): Check for a GError
1895 when calling tny_folder_get_headers(), to show that this is not the cause
1898 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1900 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1901 Actually set the body query instead of the subject query.
1903 * src/modest-search.c: (search_mime_part_ogs),
1904 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1905 which would probably cause it to fail if we got this far.
1907 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1908 to simplify the code.
1909 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1910 be causing search-in-body to fail.
1912 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1914 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1916 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1917 Better debug message when the folder cannot be found.
1918 This should help with fixing projects.maemo.org bug #61287.
1919 * src/modest-search.c: (add_hit): Do not leak the furl string.
1921 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1923 * src/modest-ui-actions.c:
1924 (modest_ui_actions_on_folder_selection_changed):
1925 Do not special-case TNY_MERGE_FOLDER here, because
1926 modest_tny_folder_get_account() already does that. This fixes
1927 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1928 shown when the Outbox was selected).
1930 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1932 * libmodest-dbus-client/libmodest-dbus-client.c:
1933 (_dbus_iter_get_string_or_null): Initialize the string variable in
1934 case this helps with Dirk's crash.
1936 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1938 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1939 though it is not implemented yet (this function is maybe not even used),
1940 to avoid breaking ABI in future.
1941 * libmodest-dbus-client/libmodest-dbus-client.c:
1942 (get_attachments_string): Moved some code into this generic function.
1943 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1944 sends email. It is maybe not used.
1945 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1946 (on_send_mail): Use attachments.
1948 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1949 * src/maemo/modest-msg-edit-window.c:
1950 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1951 a filename before using it, to fix projects.maemo.org bug NB#58233.
1953 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1955 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1956 Initialize the continue_download variable to fix the build, and probably
1957 to fix randome behaviour.
1959 2007-06-18 Armin Burgmeier <armin@openismus.com>
1961 * src/modest-tny-send-queue.h:
1962 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1963 the queue so we can later show it in the UI. Replaced
1964 modest_tny_send_queue_msg_is_being_sent() by
1965 modest_tny_send_queue_get_msg_status().
1967 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1969 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1970 gpointer. This probably was not harmful, but just to be sure.
1972 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1974 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1975 Fix the build, but leave the function broken on Bora, because
1976 hildon_uri_action_get_service() does not exist.
1977 osso_uri_action_get_service() does not exist either, it seems.
1979 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1981 * src/modest-tny-account.c:
1982 (modest_tny_account_new_from_server_account):
1983 Uncommented the url debug output again, because it is useful for
1984 debugging, as I said in the comment.
1986 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1988 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1990 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1991 for Mameo Bora, to fix the build.
1993 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1996 Fixed build with hildon < 0.99
1998 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1999 Check if the selected account is busy instead of checking all accounts
2001 * src/modest-account-mgr-priv.h:
2002 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
2003 (modest_account_mgr_init), (compare_account_name),
2004 (modest_account_mgr_set_account_busy),
2005 (modest_account_mgr_account_is_busy):
2006 * src/modest-account-mgr.h:
2007 Added busy information to the account manager. It possible to
2008 set an account to busy or not busy now.
2010 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
2011 (modest_mail_operation_update_account),
2012 (modest_mail_operation_notify_end):
2013 Set the account to busy/not busy depending on the operation state.
2015 * src/widgets/modest-account-view.c:
2016 (modest_account_view_finalize), (get_last_updated_string),
2017 (update_account_view), (on_account_busy_changed), (init_view):
2018 Show string "Refreshing..." if the account is currently busy.
2020 All this fixes projects.maemo.org bug NB#59711
2022 2007-06-14 Armin Burgmeier <armin@openismus.com>
2024 * src/widgets/modest-attachments-view.h:
2025 * src/widgets/modest-attachments-view.c: Added
2026 modest_attachments_view_has_attachments() and fixed coordinate
2027 transformation in get_att_view_at_coords(). This fixes attachment
2030 * src/widgets/modest-msg-view.c: Make use of
2031 modest_attachments_view_has_attachments() to decide whether to show
2032 attachments in the header.
2034 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
2036 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2037 (on_change), (on_combo_security_changed),
2038 (modest_connection_specific_smtp_edit_window_init),
2039 (modest_connection_specific_smtp_edit_window_set_connection),
2040 (modest_connection_specific_smtp_edit_window_is_dirty):
2041 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2042 * src/maemo/modest-connection-specific-smtp-window.c:
2045 Show an comfirmation dialog for the smpt-edit-window if there are
2046 unsaved changes and the user hits cancel.
2047 (projects.maemo.org bug NB#60479)
2049 2007-06-14 Armin Burgmeier <armin@openismus.com>
2051 * src/maemo/easysetup/modest-easysetup-wizard.c:
2052 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
2053 address" info in banner instead of node, and select all the text as
2054 per UI spec. This fixes projects.maemo.org bug NB#60550.
2056 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
2058 reviewed by: <delete if not using a buddy>
2060 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
2061 * src/modest-ui-actions.c: (folder_refreshed_cb):
2063 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2065 * src/widgets/modest-folder-view.c: (filter_row):
2066 Explictly filter out the per-account outbox accounts. I don't know why
2067 these only sometimes show up, but now they should never show up in the UI.
2068 This should fix projects.maemo.org bug NB#60160.
2070 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2072 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
2073 when the toolbar does not exist yet.
2074 * src/modest-widget-memory.c: (save_settings_header_view):
2075 Added g_warnings() to help us to discover when we are trying to set
2076 an empty columns list in gconf.
2078 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2080 * src/modest-init.h:
2081 * src/modest-init.c:
2082 Added modest_init_get_default_header_view_column_ids().
2084 * src/modest-widget-memory.c: (restore_settings_header_view):
2085 Use the new function to get defaults, if the gconf key is empty,
2086 instead of not creating any columns. This seems to fix the
2087 empty right-hand pane problems.
2089 * src/widgets/modest-header-view.h: Improved documentation.
2091 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2093 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2094 Revert the use of the display name as the account name, because this
2095 is generally wrong and would break the code that follows.
2097 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2099 * src/maemo/easysetup/modest-easysetup-wizard.c:
2100 (check_for_supported_auth_methods), (on_before_next),
2103 More correct fix for projects.maemo.org bug NB# 58991
2104 Do not longer accept AUTH_PASSWORD as secure method and choose
2105 correct method when creating the account.
2107 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2109 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2110 Fixed projects.maemo.org bug NB# 58991
2112 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2114 * src/modest-init.c: (modest_init_init_core),
2115 (modest_init_local_folders): Fixed compilation errors.
2117 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2119 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2120 Remove unnecessary lib/include, though it is good in principle when needed.
2122 * src/modest-init.c: (modest_init_one_local_folder),
2123 (modest_init_local_folders):
2124 * src/modest-init.h: Initialize the .modest library for memory cards,
2125 instead of just doing nothing for them. This should allow us to create
2126 folders there, fixing projects.maemo.org bug NB#59297.
2128 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2130 * libmodest-dbus-client/libmodest-dbus-client.c:
2131 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2132 (libmodest_dbus_client_compose_mail),
2133 (libmodest_dbus_client_open_message),
2134 (libmodest_dbus_client_send_and_receive),
2135 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
2137 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
2138 (on_idle_open_message), (modest_dbus_req_handler),
2139 (search_result_to_message), (modest_dbus_req_filter):
2140 * src/modest-search.c: (add_hit), (modest_search_folder),
2141 (modest_search_all_accounts): Improved debug messages.
2143 * tests/dbus_api/test_open_message.c: (main): Improved comments.
2145 * src/modest-tny-account-store.c:
2146 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
2149 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2152 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2154 * src/modest-tny-account-store.c: (get_server_accounts):
2155 Call modest_tny_local_folders_account_add_merged_outbox_folders()
2156 even when there are no accounts, so that the Outbox folder is always
2157 visible. This fixes projects.maemo.org bug NB#60158.
2159 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2161 * src/maemo/modest-main-window.c: (create_details_widget):
2162 Use the mcen_va_never logical ID.
2164 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2166 * src/dbus_api/modest-dbus-api.h:
2167 * src/dbus_api/modest-dbus-callbacks.c:
2168 (on_idle_open_default_inbox), (on_open_default_inbox),
2169 (modest_dbus_req_handler):
2170 Added a new OpenDefaultInbox method.
2172 * libmodest-dbus-client/libmodest-dbus-client.h:
2173 * libmodest-dbus-client/libmodest-dbus-client.c:
2174 Added libmodest_dbus_client_open_default_inbox() to call the new
2175 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2176 though it should maybe be used by a new osso-email-interface function.
2178 * tests/dbus_api/Makefile.am:
2179 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2182 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2184 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2185 NULL, so that the signals get all the keys. This should not actually
2186 change any behaviour because we currently update everything when anything
2189 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2191 * src/widgets/modest-folder-view.c: (text_cell_data),
2192 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2193 (find_inbox_iter): If tinymail tells us that the folder is
2194 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2195 This causes the inbox to be selected at startup, fixing part of
2196 projects.maemo.org bug NB#56305.
2198 * src/modest-ui-dimming-rules.c:
2199 (modest_ui_dimming_rules_on_tools_smtp_servers):
2200 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2201 the SMTP servers menu item.
2202 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2203 that the SMTP Servers menu item is dimmed when there are no accounts,
2204 as a future version of the UI spec will require. This fixes
2205 projects.maemo.org bug NB#56305.
2207 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2209 * src/maemo/modest-maemo-utils.c:
2210 (modest_maemo_utils_get_supported_secure_authentication_methods):
2211 Added label to dialog instead of unreadable title
2213 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2214 (modest_main_window_new):
2215 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2218 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2219 * src/modest-account-mgr.h:
2220 Added method to avoid code duplication
2222 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2223 (modest_ui_actions_on_send_receive):
2224 Use modest_account_mgr_has_accounts
2226 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2228 * src/maemo/easysetup/modest-presets.c:
2229 (modest_presets_get_info_server_security): Do not report secure auth
2231 * src/modest-protocol-info.c: Use the defines for the gconf key names
2232 for secure authentication. This was not working because we were writing
2233 Password and reading password, and the check was case sensitive.
2234 With this, gmail now works for receiving and sending when created via
2237 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2239 * src/maemo/easysetup/modest-presets.c:
2240 (modest_presets_get_info_server_security): Correct the key name for
2241 SecureSmtp, because it seems to be case-sensitive.
2242 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2243 Do not try to get the 0th notebook page if there are 0 pages, to
2244 avoid a g_warning().
2246 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2248 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2249 Prevent use of the new notification feature for now, because it currently
2250 shows one dialog for each new email, which is annoying.
2252 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2254 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2255 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2256 when no country was selected, so that we show the global ones.
2257 * src/maemo/easysetup/modest-presets.c:
2258 (modest_presets_get_providers): Return only the global providers, not
2259 all providers when mmc=0 was requested.
2261 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2263 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2264 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2265 provider ID in the combo.
2267 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2268 Do not show the page numbers, because it would be confusing when we add
2269 the 2 extra pages for the custom setup, when the user chooses the "Other"
2270 provider. This fixes projects.maemo.org bug NB#59028
2272 * src/modest-init.c: (modest_init_init_core),
2273 (modest_init_local_folders):
2274 * src/modest-init.h:
2275 * src/modest-tny-account.c:
2276 (modest_tny_account_new_for_local_folders): Do not create default folders
2277 for the memory card. This should fix projects.maemo.org bug NB#59328.
2279 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2281 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2282 Free the changed_conf_keys string items. They are already freed in the
2283 idle handler if that runs first.
2285 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2287 * src/modest-ui-actions.c:
2288 (modest_ui_actions_on_password_requested): Check that the server name
2289 is not NULL, because I just saw a password dialog with (null) as the
2292 * src/modest-tny-folder.[h|c]: Added
2293 modest_tny_folder_is_memory_card_folder().
2294 * src/modest-ui-dimming-rules.c:
2295 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2296 menu item for memory cards, as per the UI spec (section 7.4). This should
2297 fix projects.maemo.org bug NB#59297.
2299 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2301 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2302 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2303 is another problem with the code, see Murray's comment at line 772)
2305 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2307 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2308 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2309 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2310 (load_from_file), (easysetup_country_combo_box_init),
2311 (easysetup_country_combo_box_get_active_country_ids),
2312 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2313 instead of just one ID, to avoid duplicate country names in the UI.
2315 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2316 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2317 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2318 a single ID, avoiding duplicate providers.
2319 * src/maemo/easysetup/modest-easysetup-wizard.c:
2320 (on_combo_account_country): Adapt to use a list.
2322 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2324 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2325 keys changed in the last X seconds.
2327 * src/modest-account-mgr.h:
2328 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2329 (on_key_change), (modest_account_mgr_class_init),
2330 (modest_account_mgr_init), (modest_account_mgr_finalize):
2331 As the keys are changed, save them in a GSList* and signal that GSList*
2332 further every X seconds, to batch changes, to allow us to do just one
2333 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2334 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2336 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2337 changed signal signature.
2339 * src/modest-conf.c: (modest_conf_set_list),
2340 (modest_conf_on_change): Reenable notification.
2342 (modest_conf_maemo_fake_on_change): Comment out the hack that
2343 notified immediately instead of asynchronously.
2345 * src/widgets/modest-account-view.h:
2346 * src/widgets/modest-account-view.c:
2347 (update_account_view): Select the previously-selected account ID,
2348 if possible. This fixes projects.maemo.org bug NB#56933.
2350 (on_account_changed), (on_account_removed),
2351 (modest_account_view_select_account):
2353 Remove the block/unblock functions
2354 because they were not useful.
2356 * src/maemo/modest-account-view-window.c:
2357 (on_delete_button_clicked), (on_edit_button_clicked),
2358 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2360 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2362 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2363 Improve the error dialog to show Incorrect Account Settings, which seems
2364 clearer, and say that the internal error message (to be removed from the
2365 dialog later) is often misleading.
2366 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2368 * src/modest-tny-account.c:
2369 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2370 URL because this is so useful for debugging on the device.
2372 * src/widgets/modest-serversecurity-combo-box.c:
2373 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2375 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2377 * src/modest-mail-operation.c:
2378 (modest_mail_operation_send_new_mail):
2379 Added a comment about a nasty but apparently harmless message. Details
2380 added to the wiki g_warnings() page.
2382 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2384 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2385 (modest_tny_send_queue_class_init):
2386 Do not use the priv struct because it is empty, to avoid g_warnings
2387 about a non-existant priv struct.
2389 * src/modest-tny-account-store.c:
2390 (modest_tny_account_store_get_server_account),
2391 (modest_tny_account_store_get_transport_account_for_open_connection
2392 ): Do not try to get transport server accounts for local folders,
2393 because they don't have any. This avoids a g_warning().
2395 * src/maemo/modest-main-window.c:
2396 (modest_main_window_notify_send_receive_initied),
2397 (on_configuration_key_changed):
2398 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2399 * src/modest-defs.h:
2400 * src/modest-mail-operation.c:
2401 (modest_mail_operation_update_account):
2402 * src/modest-tny-account-store.h:
2403 * src/modest-tny-account.c:
2404 (modest_tny_account_get_special_folder),
2405 (modest_tny_account_new_for_local_folders),
2406 (modest_tny_account_new_for_per_account_local_outbox_folder):
2407 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2408 * src/modest-tny-local-folders-account.c:
2409 (add_account_folders_to_merged_folder):
2410 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2411 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2412 (modest_ui_actions_on_send):
2413 * src/widgets/modest-folder-view.c: (update_model):
2414 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2415 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2416 modest_tny_account_store_get_tny_account_by_account() to
2417 modest_tny_account_store_get_server_account() to make the code clearer.
2419 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2421 * src/dbus_api/modest-dbus-api.h:
2422 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2423 * src/maemo/modest-msg-edit-window.c:
2424 (modest_msg_edit_window_attach_file_noninteractive):
2425 added g_warning in case the file to be attached does not exist
2426 * tests/dbus_api/test_compose_mail.c: (main):
2427 removed obsolete comment, added generic files as test case
2429 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2431 * src/modest-tny-account-store.c: (get_server_accounts):
2432 Create the local folders account only once, not once for each outbox, and
2433 not only when there are some outboxes.
2435 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2437 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2438 code that is causing a crash at startup. Sergio says that he is fixing this.
2440 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2442 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2443 * src/maemo/modest-account-settings-dialog.c:
2444 (create_page_outgoing),
2445 (modest_account_settings_dialog_set_account_name),
2446 (save_configuration):
2447 - Fixed handling of the "Use secure authentication" toggle to comply with
2448 the ui specification. See also projects.maemo.org bug NB#58400
2450 - Restore the Secure connection setting combo correctly when loading
2453 * src/maemo/modest-maemo-utils.c:
2454 (on_camel_account_get_supported_secure_authentication),
2455 (modest_maemo_utils_get_supported_secure_authentication_methods):
2456 Fixed a crasher if operation is canceled
2458 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2459 (modest_protocol_info_auth_is_secure):
2460 * src/modest-protocol-info.h:
2462 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2463 the sense of the "Use secure authentication" toggle.
2465 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2467 * src/modest-tny-account-store.h:
2468 * src/modest-tny-account-store.c:
2469 Added modest_tny_account_store_get_local_folders_account().
2471 * src/modest-tny-folder.h:
2472 * src/modest-tny-folder.c:
2473 (modest_tny_folder_get_account):
2474 Added this replacement for tny_folder_get_account() which returns
2475 the local-folders account for TnyMergeFolders, to avoid the
2476 warning about the unimplemented get_account_func() vfunc().
2478 (modest_tny_folder_get_rules),
2479 * src/modest-ui-actions.c:
2480 (modest_ui_actions_on_folder_selection_changed):
2481 * src/modest-mail-operation.c:
2482 (modest_mail_operation_remove_folder),
2483 (modest_mail_operation_xfer_folder),
2484 (modest_mail_operation_rename_folder),
2485 (modest_mail_operation_get_msg),
2486 (modest_mail_operation_get_msgs_full),
2487 (modest_mail_operation_remove_msg),
2488 (modest_mail_operation_xfer_msgs),
2489 (modest_mail_operation_refresh_folder):
2490 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2492 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2494 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2495 (modest_server_account_set_security):
2496 * src/modest-defs.h: Add comments explaining that our
2497 UI spec means TLS when it says Normal, so these do not look like errors.
2499 * src/modest-tny-account.c:
2500 (modest_tny_account_new_from_server_account): Use the new tinymail
2501 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2502 for TLS. This should fix projects.maemo.org bug NB#58460.
2504 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2506 * src/maemo/easysetup/modest-easysetup-wizard.c:
2507 (create_account): Correct the position of the gconf sanity check warning.
2508 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2509 of using the g_idle_add() hack, because this does not seem to be necessary
2510 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2511 caused by something other than maemo's gconf.
2512 This fixes projects.maemo.org bug #59022.
2514 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2516 * src/modest-account-mgr-helpers.c:
2517 (modest_account_mgr_get_default_account): Do not check that the account
2518 exists if there is no default account (NULL), to fix a runtime warning.
2520 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2522 * src/widgets/modest-folder-view.c: (update_model):
2523 Do not unref the treemodel before we have finished with it.
2524 This prevents a valgrind warning and an occasional crash at startup.
2526 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2528 * libmodest-dbus-client/libmodest-dbus-client.h:
2529 added libmodest_dbus_client_compose_mail()
2530 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2532 added functions needed for SendAsMail() functionality
2533 * src/maemo/modest-msg-edit-window.c:
2534 (modest_msg_edit_window_attach_file_noninteractive):
2535 non interactively attaching files to message edit window
2536 * src/widgets/modest-msg-edit-window.h:
2537 * tests/dbus_api/Makefile.am:
2538 added test_compose_mail.c
2539 * tests/dbus_api/test_compose_mail.c: (main):
2541 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2543 * src/modest-account-view.c:
2544 Fixed bug projects.maemo.org bug NB#59307
2546 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2548 * src/maemo/easysetup/modest-easysetup-wizard.c:
2549 (get_serverport_incoming), (on_before_next), (create_account):
2550 * src/maemo/modest-account-settings-dialog.c:
2551 (modest_account_settings_dialog_set_account_name):
2552 * src/maemo/modest-maemo-utils.c:
2553 (on_camel_account_get_supported_secure_authentication_status),
2554 (on_camel_account_get_supported_secure_authentication),
2555 (on_secure_auth_cancel),
2556 (modest_maemo_utils_get_supported_secure_authentication_methods):
2558 Implemented security authentication for settings and easysetup.
2560 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2562 * src/maemo/modest-main-window.c: (create_details_widget):
2563 Show the total size for memory card accounts too, instead of showing
2564 the name again. Fixes bug projects.maemo.org bug NB#59307.
2566 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2569 * src/modest-tny-simple-folder-store.c:
2570 * src/modest-tny-simple-folder-store.h: Removed.
2572 * src/modest-tny-local-folders-account.h
2573 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2574 for the local-folders maildir, with an extra TnyMergedFolder containing
2575 the folders of the per-account outbox store accounts.
2576 * src/modest-tny-account-store.c: (get_server_accounts):
2577 Add the outboxes to the special local folders account after creating it.
2579 * src/modest-tny-account.c:
2580 (modest_tny_account_new_for_local_folders): Create the derived
2581 account when creating the main local-folders account.
2583 * src/maemo/modest-main-window.c: (create_details_widget),
2584 (modest_main_window_set_contents_style):
2585 Adapted to the use of the derived account instead of the folder store.
2587 * src/modest-ui-actions.c:
2588 (modest_ui_actions_on_folder_selection_changed):
2589 * src/modest-ui-dimming-rules.c:
2590 (modest_ui_dimming_rules_on_new_folder):
2591 * src/widgets/modest-folder-view.c: (text_cell_data),
2592 (icon_cell_data), (filter_row), (update_model),
2593 (get_cmp_rows_type_pos):
2596 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2597 Do not get the priv struct, because no priv struct has been set,
2598 to avoid a runtime warning.
2600 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2601 #ifelse with #else, to fix a warning, to fix the build.
2604 2007-06-05 Christian Kellner <ckellner@openismus.com>
2606 * libmodest-dbus-client/libmodest-dbus-client.c:
2607 Fix small typo in doc (why do you always see them
2608 AFTER committing stuff?)
2611 2007-06-05 Christian Kellner <ckellner@openismus.com>
2613 * libmodest-dbus-client/libmodest-dbus-client.c:
2614 (libmodest_dbus_client_search):
2615 Initialize hit list with NULL. Also set folder list
2616 to "" if NULL was supplied.
2619 2007-06-03 Christian Kellner <ckellner@openismus.com>
2621 * libmodest-dbus-client/libmodest-dbus-client.c:
2622 (modest_search_hit_list_free):
2623 Make it save to call it with NULL.
2625 * src/dbus_api/modest-dbus-callbacks.c:
2626 * src/modest-search.c:
2627 Return full ModestSearchHits as the search result list not TnyHeader
2628 since can't be around withouth the correspoding TnyFolder.
2630 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2632 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2633 Added currently commented code to check for secure auth
2635 * src/maemo/modest-account-settings-dialog.c: (on_response),
2636 (save_configuration), (show_ok):
2637 Fixed projects.maemo.org bugs NB #59248 and #59251
2639 * src/maemo/modest-maemo-utils.c:
2640 (on_camel_account_get_supported_secure_authentication_status),
2641 (on_camel_account_get_supported_secure_authentication),
2642 (modest_maemo_utils_get_supported_secure_authentication_methods):
2643 * src/maemo/modest-maemo-utils.h:
2644 Moved get_supported_secure_authentication() method here to be able
2645 to use it from easysetup wizard.
2647 * src/modest-pair.c: (on_pair_compare_as_string):
2648 Should compare string with first part of pair and not
2649 strcmp pairs which will crash.
2651 * src/modest-protocol-info.c:
2652 (modest_protocol_info_protocol_is_store):
2653 * src/modest-protocol-info.h:
2654 Added modest_protocol_info_get_auth_protocol_name()
2656 2007-06-03 Armin Burgmeier <armin@openismus.com>
2658 * src/modest-mail-operation.c:
2659 (modest_mail_operation_get_msgs_full): Set priv->account also when
2660 only retrieving a single message. This avoids a crash when canceling
2663 (modest_mail_operation_notify_end): Do not explicitely remove the
2664 operation from the queue but only emit the progress_changed signal.
2665 The queue itself listens to that signal to remove the operation when
2666 it is finished. This reduces coupling and removes a potential deadlock
2667 when modest_mail_operation_notify_end() is called from the queue
2668 itself. If that is a problem performance-wise, I would suggest to
2669 implement a status-changed signal or something.
2671 * src/modest-mail-operation-queue.c: Make sure to never call a
2672 function from another file while the queue is locked. This (hopefully)
2673 fixes another deadlock when exiting the application while retrieving
2676 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2678 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2679 Fixed build if libogs is not available
2681 2007-06-03 Christian Kellner <ckellner@openismus.com>
2683 * libmodest-dbus-client/libmodest-dbus-client.h:
2684 * libmodest-dbus-client/libmodest-dbus-client.c:
2685 (libmodest_dbus_client_delete_message):
2686 Implement deletion of messages (Client side).
2688 (modest_search_hit_free),
2689 (modest_search_hit_list_free):
2690 Utility functions to free the result hits.
2692 * src/dbus_api/modest-dbus-api.h:
2693 * src/dbus_api/modest-dbus-callbacks.c:
2694 (on_delete_message),
2695 (modest_dbus_req_handler):
2696 Implement deletion of messages (Server side).
2698 * tests/dbus_api/test_search.c: (main):
2701 * tests/dbus_api/Makefile.am:
2702 * tests/dbus_api/test_delete_message:
2703 Add little test for the message deletion logic
2705 2007-06-03 Armin Burgmeier <armin@openismus.com>
2707 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2708 when the operation queue was not empty. projects.maemo.org bug
2711 2007-06-03 Armin Burgmeier <armin@openismus.com>
2713 * src/widgets/modest-account-view.c
2714 (on_account_default_toggled): Toggle default account column
2715 explicitely instead of waiting for gconf notification (which is
2716 currently ignored). This should fix projects.maemo.org bug NB#56910
2717 for now. It should probably be removed when gconf notifications are
2720 2007-06-03 Christian Kellner <ckellner@openismus.com>
2722 * libmodest-dbus-client/libmodest-dbus-client.c:
2723 Removed debugging spew.
2725 * src/dbus_api/modest-dbus-callbacks.c:
2726 Added debugging info.
2728 * src/modest-search.c:
2729 (modest_search_all_accounts):
2730 Use tny_account_store_get_accounts () on the account store
2731 to get all accounts which is the way to get all accounts.
2733 * tests/dbus_api/test_search.c: (main):
2734 Make it possible to supply the search term on the command line.
2736 2007-06-03 Christian Kellner <ckellner@openismus.com>
2738 * libmodest-dbus-client/libmodest-dbus-client.c:
2739 * libmodest-dbus-client/libmodest-dbus-client.h:
2740 Implement searching for mesages over raw dbus. (Client side)
2742 * src/dbus_api/Makefile.am:
2743 * src/dbus_api/modest-dbus-api.h:
2744 * src/dbus_api/modest-dbus-callbacks.c:
2745 * src/dbus_api/modest-dbus-callbacks.h:
2746 Search framework (Server side). Also implement on_idle_open_message().
2748 * src/maemo/modest-platform.c: (modest_platform_init):
2749 Prepare for raw dbus/osso rpc interaction.
2751 * src/modest-search.h:
2752 Changed minsize from unspecific guint to guint32.
2754 * src/modest-search.c:
2756 Added strange hack which magically made tnymail work.
2758 (modest_search_folder),
2759 (modest_search_account),
2760 (modest_search_all_accounts):
2761 Implement helper functions to search all accounts, specific account
2764 * tests/dbus_api/Makefile.am:
2765 * tests/dbus_api/test_open_message.c:
2766 Read url to open from commandline.
2768 * tests/dbus_api/test_search.c:
2769 Implement small test for dbus search stuff
2771 2007-06-02 Armin Burgmeier <armin@openismus.com>
2773 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2774 include account type and account title. This fixes projects.maemo.org
2777 * src/maemo/modest-account-view-window.c: Set a title for the window.
2779 2007-06-02 Armin Burgmeier <armin@openismus.com>
2781 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2782 incoming and outgoing server name based on email address and server
2783 types as long as the names have not been edited manually. This fixes
2784 projects.maemo.org bug NB#58671.
2786 2007-06-02 Armin Burgmeier <armin@openismus.com>
2788 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2789 server type cannot be changed in future to the incoming details page
2790 when creating an account. This fixes projects.maemo.org bug NB#59029.
2792 2007-06-02 Armin Burgmeier <armin@openismus.com>
2794 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2795 and assigned max width chars so that they wrap instead of being
2796 truncated. Fixes projects.maemo.org bug NB#56126.
2798 2007-06-02 Armin Burgmeier <armin@openismus.com>
2800 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2801 introductory note to the connection specific smtp servers dialog, as
2802 section 8.12 of the email UI specification requires. This fixes
2803 projects.maemo.org bug NB#59212.
2805 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2807 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2808 Check for running mail operations, and offer to cancel them, as per the UI
2809 spec. This fixes projects.maemo.org bug NB#59041 .
2810 However, I suspect that tinymail may still use the network connection
2811 in ways that we cannot detect or cancel. But it should at least adapt to
2812 changes fairly well.
2814 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2816 * src/modest-tny-account-store.c: (recreate_all_accounts),
2817 (get_cached_accounts), (get_server_accounts): Do more sensible
2818 ref-counting of the temporarily-cached outbox accounts list. This seems
2819 to fix a crash when entering the password when the password was wrong.
2821 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2823 * src/gnome/modest-main-window.c: (connect_signals):
2824 * src/modest-tny-account-store.c: (get_password),
2825 (modest_tny_account_store_alert): Added comments and clues and
2826 commented-out code about how we currently fail to deal with connection
2827 errors and wrong passwords, and how we should.
2829 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2831 * src/widgets/modest-retrieve-combo-box.c:
2832 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2833 This fixes projects.maemo.org bug NB#58472 .
2835 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2837 * src/maemo/easysetup/modest-easysetup-wizard.c:
2838 (create_page_complete_easysetup):
2839 (create_page_complete_custom): Correct the last commit,
2840 putting the correct sentences in the correct pages.
2842 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2844 * src/maemo/easysetup/modest-easysetup-wizard.c:
2845 (create_page_complete_custom): Show the second sentence of text
2846 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2849 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2851 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2852 Set the leave-on-server conf key by default. This fixes
2853 projects.maemo.org bug NB#59258 .
2855 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2857 * src/maemo/modest-account-view-window.c:
2858 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2859 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2862 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2864 * src/maemo/easysetup/modest-easysetup-wizard.c:
2865 (create_caption_new_with_asterisk):
2866 * src/maemo/modest-account-settings-dialog.c:
2867 (create_caption_new_with_asterisk):
2868 Uncomment the code to add the asterisk, because they are no longer in the
2869 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2870 (update_incoming_server_title): Add an asterisk here too.
2872 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2874 * src/maemo/modest-maemo-global-settings-dialog.c:
2875 (current_connection): Check that we are even connected before trying to
2876 get the current connection name, to prevent a warning.
2878 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2879 Change the comments because tny_maemo_conic_device_connect() is now meant to
2881 * src/modest-mail-operation.c:
2882 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2883 make sure we have a connection and fail if we can't connect.
2885 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2887 * src/maemo/modest-main-window.c:
2888 (on_account_store_connecting_finished): Do not try to get the
2889 connection ID if we are not really connected. I am surprised that
2890 this signal handler is called when we are not connected.
2892 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2894 * src/modest-error.h:
2895 * src/modest-ui-actions.c:
2896 (modest_ui_actions_get_msgs_full_error_handler):
2897 Renamed an enum, added comments, added an enum
2898 for retrieve-limit errors.
2900 * src/modest-mail-operation.c: (foreach_add_item),
2901 (internal_folder_observer_update), (update_account_thread),
2902 (modest_mail_operation_get_msgs_full):
2903 (modest_mail_operation_update_account),
2904 Added comments about how this works, and some code that should
2905 (but does not) check the retrieve-limit. See the TODO comment.
2907 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2909 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2910 Initialize help_id to fix the build. Warnings are good.
2912 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2914 * src/widgets/modest-hbox-cell-renderer.c:
2915 (modest_hbox_cell_renderer_append):
2916 * src/widgets/modest-vbox-cell-renderer.c:
2917 (modest_vbox_cell_renderer_append):
2918 Fix the last commit by doing an extra ref.
2920 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2922 * src/widgets/modest-hbox-cell-renderer.c:
2923 (modest_hbox_cell_renderer_append):
2924 * src/widgets/modest-vbox-cell-renderer.c:
2925 (modest_vbox_cell_renderer_append):
2926 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2927 to fix the build with Maemo Bora.
2928 However, there seems to be a remaining crash, probably due to reference
2931 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2933 * src/modest-tny-account.c:
2934 (modest_tny_account_new_for_local_folders):
2935 Use hildon_file_system_info_async_new() to get a better name for
2936 the memory card account, setting it as the account name.
2937 The timing seems to work, but this is probably
2938 not the best place to do this. See the TODO comment.
2939 * src/maemo/modest-main-window.c: (create_details_widget):
2940 * src/widgets/modest-folder-view.c: (text_cell_data):
2941 Use the tny account name instead of hardcoding a name.
2943 2007-05-30 Christian Kellner <ckellner@openismus.com>
2945 * src/modest-search.c: (modest_search):
2946 Correctly set part_search_func even if we have already parsed
2947 the query and thus a valid OgsTextSearcher object.
2949 2007-05-30 Christian Kellner <ckellner@openismus.com>
2952 Search and check for libogs.
2955 Incooparte the ogs build env.
2957 * src/modest-mime-part-search-stream.c:
2958 * src/modest-mime-part-search-stream.h:
2959 Removed since we do the real searching now in modest-search.c.
2961 * src/modest-search.c:
2962 * src/modest-search.h:
2963 Implement support for ogs. We use that if available and requested
2964 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2965 should now handle the corner case when the search term is spread
2966 across multiple reads.
2967 Also the logic in modest_search () was corrected to search all
2968 requested fields until one is found.
2970 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2972 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2974 * src/modest-init.h:
2975 * src/modest-init.c: Made modest_init_local_folders() take a
2976 path and be public so we can iniitialize maildir folders on
2979 * src/modest-local-folder-info.h:
2980 * src/modest-local-folder-info.c:
2981 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2983 * src/modest-tny-account.c:
2984 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2985 still means the standard local-folders path on the local volume.
2987 * src/modest-tny-account-store.c:
2988 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2989 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2990 all accounts when that happens.
2991 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2992 this too, so it shows up in the treeview.
2994 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2996 * src/maemo/modest-maemo-global-settings-dialog.c:
2997 (current_connection):
2998 * src/widgets/modest-global-settings-dialog.c:
2999 (current_connection_default):
3000 Use the enum values instead of 0, 1 and -1,
3001 to make the code clearer.
3003 * src/modest-account-mgr-helpers.c:
3004 (modest_account_mgr_get_connection_specific_smtp): Make this code
3007 * src/modest-runtime.h:
3008 * src/modest-runtime.c:
3009 Added modest_runtime_remove_all_send_queues().
3010 * src/maemo/modest-main-window.c:
3011 (on_account_store_connecting_finished): Recreate the send queues,
3012 using the appropriate transport accounts for this new connection.
3013 Some futher adapting might be needed if the old send queues are not
3014 automatically stopped at this point.
3016 * src/modest-tny-account-store.c: (get_server_accounts):
3017 Create the connection-specific transport accounts, so that they can
3018 be found later by their ID.
3020 * src/modest-tny-account.h:
3021 * src/modest-tny-account.c:
3022 Added modest_tny_account_new_from_server_account_name().
3023 modest_tny_account_new_from_server_account(): Do not create the
3024 send queues here, because they will be
3025 recreated anyway when the connection changes for the first time.
3027 2007-05-28 Murray Cumming <murrayc@murrayc.com>
3029 * src/modest-local-folder-info.h:
3030 * src/modest-local-folder-info.c:
3031 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3032 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3033 tbox_folder): Take a modest account name instead of a server TnyAccount,
3034 so we can have per-modest-account rather than per-transport-account
3036 We must make sure that we change or recreate the exisitng send queues
3037 when the connection changes for connection-specific transport accounts.
3039 * src/modest-tny-account-store.c:
3040 (create_per_account_local_outbox_folders): Create outboxed per modest
3041 account, not per transport account.
3043 * src/modest-tny-account.h:
3044 * src/modest-tny-account.c:
3045 (modest_tny_account_get_special_folder): For outboxes, get the
3046 parent modest account name. The account is ignored for other folders.
3047 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
3048 modest account name rather than a server TnyAccount.
3050 2007-05-25 Murray Cumming <murrayc@murrayc.com>
3052 * src/modest-tny-account.c:
3053 (modest_tny_account_new_from_server_account):
3054 Call modest_runtime_get_send_queue() immediately after creating transport
3055 accounts, so that they start trying to send email from the outbox as soon
3056 as possible at startup. This is probably what we want.
3058 * src/modest-mail-operation.c: (update_account_thread):
3059 * src/modest-runtime.c: (modest_runtime_get_send_queue):
3060 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
3061 * src/modest-tny-send-queue.h:
3062 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
3063 (modest_ui_actions_on_send):
3064 Added comments about how sending works, though it needs some more work.
3066 2007-05-25 Murray Cumming <murrayc@murrayc.com>
3068 * src/modest-tny-account.c:
3069 (modest_tny_account_get_special_folder): Add TODO because this fails when
3070 the network is busy.
3071 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
3072 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
3073 Do not try to show this window when there is no active account. The UI
3074 specs does not tell us what to do in this case.
3076 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3080 * src/maemo/Makefile.am:
3081 * src/widgets/Makefile.am: Some dist fixes.
3083 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3085 * src/maemo/modest-connection-specific-smtp-window.c:
3086 (on_button_edit): Make the code clearer, to prevent a double free.
3088 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3090 * src/maemo/modest-account-settings-dialog.c:
3091 (modest_account_settings_dialog_set_account_name),
3092 Check the connection-specific smtp servers checkbox if there are any.
3094 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3095 (modest_connection_specific_smtp_edit_window_init):
3096 Start with a suitable port number.
3098 * src/modest-account-mgr-helpers.h:
3099 * src/modest-account-mgr-helpers.c: Added
3100 modest_account_mgr_get_has_connection_specific_smtp().
3102 (modest_account_mgr_set_connection_specific_smtp),
3103 (modest_account_mgr_remove_connection_specific_smtp),
3104 (modest_account_mgr_get_has_connection_specific_smtp),
3105 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
3106 connection-specific smtp server accounts in the account, rather than
3107 the server account conf dir.
3109 This fixes bug projects.maemo.org bug NB#58263 .
3111 * src/modest-tny-account-store.c:
3112 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
3113 if there are no server accounts yet, to prevent an infinite loop when there
3114 are no accounts. Document that one must be called before the other.
3116 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3118 * src/modest-account-mgr-helpers.c:
3119 (modest_account_mgr_get_default_account): Make sure that at least
3120 one account is always the default, if there are any enabled accounts.
3121 This is just a sanity check that shouldn't be necessary.
3123 * src/modest-account-mgr-priv.c:
3124 (_modest_account_mgr_account_from_key): Unescape the conf key to
3125 get the real account name. For instance, this is an issue if a space
3126 was in the account name, which can happen because the account name
3127 is generated from the display name.
3128 (_modest_account_mgr_get_account_keyname): Always escape the
3130 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
3131 Unescape the conf keys to get the real account names.
3133 For instance, previously the is-default radio button in the accounts
3134 list was not checked for any accounts at first. This fixes that,
3135 and might fix several similar bugs.
3137 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3139 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
3140 Removed some debug printfs.
3142 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3144 Modest on-disk outbox directories are now here, for instance:
3145 $HOME/.modest/outboxes/<account-id-1>/outbox
3146 $HOME/.modest/outboxes/<account-id-2>/outbox
3148 $HOME/.modest/local-folders/outbox
3149 so we can have a separate outbox for each account.
3150 But they are shown as one outbox in the GtkTreeView, by using a
3151 TnyMergeFolder in a ModestTnySimpleFolderStore.
3154 * src/modest-tny-simple-folder-store.c:
3155 * src/modest-tny-simple-folder-store.h:
3156 Added ModestTnySimpleFolderStore, used to contain folders from
3157 other folder stores, such as other accounts.
3159 * src/modest-tny-outbox-account.h:
3160 * src/modest-tny-outbox-account.c:
3161 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
3162 used for the per-account local outbox folders.
3164 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3165 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3166 only use this (internally) now for the non-outbox local folders.
3168 * src/modest-init.h:
3169 * src/modest-init.c: Added modest_init_one_local_folder(), for
3170 setting up the directory structure for each local folder.
3172 * src/modest-local-folder-info.c:
3173 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3174 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3176 * src/modest-local-folder-info.h:
3177 * src/modest-tny-account-store.c: (on_account_removed),
3178 (on_account_changed), (create_per_account_local_outbox_folders),
3179 (get_server_accounts), (modest_tny_account_store_get_accounts),
3180 (modest_tny_account_store_get_tny_account_by_account),
3181 (modest_tny_folder_store_is_virtual_local_folders):
3183 * src/modest-tny-account.h:
3184 * src/modest-tny-account.c:
3185 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3186 to create an on-disk per-account local outbox folder for each
3188 (create_per_account_local_outbox_folders): Create a local outbox folder
3189 for each transport account.
3190 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3191 for all local folders.
3193 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3194 instead of using g_object_get/set() directly. It is clearer.
3196 (modest_tny_folder_store_get_message_count),
3197 (modest_tny_folder_store_get_local_size
3198 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3199 because we now use these with non-acount folder stores.
3201 (modest_tny_account_get_special_folder),
3202 (modest_tny_account_new_from_server_account),
3203 (modest_tny_account_new_from_account):
3204 (recurse_folders): Adjust to the new outbox system.
3206 * src/modest-tny-folder.h:
3207 * src/modest-tny-folder.c:
3208 (modest_tny_folder_is_local_folder),
3209 (modest_tny_folder_get_local_folder_type),
3210 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3212 * src/widgets/modest-main-window.h:
3213 * src/maemo/modest-main-window.c: (create_details_widget),
3214 (modest_main_window_set_contents_style): Show details for any folder store,
3217 (modest_tny_folder_get_rules):
3218 Remove the const. C does not support constness enough for this.
3220 * src/modest-ui-actions.c:
3221 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3222 make all outboxes appear as one, in the usual local-folders tree node.
3224 (set_active_account_from_tny_account),
3225 (modest_ui_actions_on_folder_selection_changed):
3226 * src/widgets/modest-folder-view.c: (text_cell_data),
3227 (icon_cell_data), (filter_row),
3228 (add_account_folders_to_merged_folder),
3229 (add_account_folders_to_simple_folder_store), (),
3230 (get_cmp_rows_type_pos), (cmp_rows),
3231 (modest_folder_view_set_account_id_of_visible_server_account):
3232 Adjust to the new outbox system, using generic folder stores and folders
3233 in the GtkTreeModel.
3235 2007-05-23 Christian Kellner <ckellner@openismus.com>
3237 * src/modest-mail-operation.c:
3238 (modest_mail_operation_update_account):
3239 Use info->max_size instead of unintialized local var [small
3240 build fix]. (Added TODO to review that change since I don't
3243 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3245 * libmodest-dbus-client/libmodest-dbus-client.c:
3246 (libmodest_dbus_client_compose_mail): function added
3247 * src/dbus_api/modest-dbus-api.h:
3248 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3249 (on_compose_mail): Implementation of the SendAsMail functionality
3251 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3253 * src/modest-account-mgr.c:
3254 (modest_account_mgr_add_server_account): Set the secure-connection
3255 conf key for transport accounts as well as store accounts. I don't know
3256 why the if was there. For instance, this makes sure that we use SSL
3257 for the gmail preset from the easysetup wizard.
3259 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3261 * src/gnome/modest-main-window.c:
3262 (on_account_store_connecting_finished), (connect_signals):
3263 * src/maemo/modest-main-window.c:
3264 (on_account_store_connecting_finished), (connect_signals),
3265 (modest_main_window_new):
3266 Handle TnyAccountStore::connecting-finished instead of
3267 TnyDevice::connection-changed, because we cannot actually perform
3268 operations on accounts until TnyAccountStore has itself responded to
3269 the TnyDevice::connection-changed signal. This prevents a GError from
3271 Do not try to update at startup, because we (at least on scratchbox)
3272 already do an update at startup when the device goes online.
3273 This prevents a GError from tinymail.
3274 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3275 Added TODO about stopping simultaneous operations.
3277 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3279 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3280 * src/modest-mail-operation-queue.c:
3281 (modest_mail_operation_queue_remove):
3282 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3283 about where they happened.
3285 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3287 * src/modest-ui-actions.c:
3288 (modest_ui_actions_on_password_requested): Make sure that the remember
3289 output parameter is always TRUE.
3291 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3293 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3294 Show a OK/Cancel dialog if the error is a question, though we still do not
3295 know anything more about what we are asking the user.
3296 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3297 Fix an uninitialized variable (helper). This is a logic error, however.
3299 2007-05-21 Christian Kellner <ckellner@openismus.com>
3301 * src/modest-search.h:
3302 Correct bit shifting in the ModestSearchFlags enum.
3304 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3306 * src/modest-tny-account.c:
3307 (modest_tny_account_new_from_server_account): Do not use the lsub and
3308 check-all hard-coded IMAP options when using POP.
3310 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3312 * src/modest-tny-account.c:
3313 (modest_tny_account_new_from_server_account):
3314 Use NULL for the secure-auth method for POP when Password auth has been
3315 specified by the user, as we already do for IMAP. "auth=Login" causes
3316 an error from camel or the server.
3318 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3320 * src/maemo/modest-account-settings-dialog.c:
3321 (create_page_account_details),
3322 (modest_account_settings_dialog_set_account_name):
3323 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3324 for the leave-on-server checkbox, rathr than just the checkbox, when
3325 the protocol is not POP.
3327 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3329 * src/widgets/modest-account-view.c:
3330 * src/widgets/modest-account-view.h:
3331 Added modest_account_view_select_account() which will be useful later
3332 to asynchronously re-select the edited account.
3334 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3336 * src/maemo/modest-account-settings-dialog.c:
3337 (modest_account_settings_dialog_set_account_name):
3338 Automatically choose the port numbers based on the secure authentication
3339 methods, if they have not been chosen before.
3340 This fixes projects.maemo.org bug NB#56273 .
3342 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3344 * src/maemo/modest-main-window-ui.h:
3345 * src/modest-ui-actions.c:
3346 * src/modest-ui-actions.h:
3347 Connect the Tools/SMTP Servers menu item to
3348 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3349 SMTP servers dialog, as in the UI specification and saves changes when it
3350 is closed. This fixed projects.maemo.org bug NB#56305 .
3352 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3354 * src/maemo/modest-connection-specific-smtp-window.c:
3355 (modest_connection_specific_smtp_window_init):
3356 Use gtk_window_set_default_size() to make this window big enough, so
3357 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3359 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3361 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3362 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3363 (modest_connection_specific_smtp_edit_window_init),
3364 Do not try to connect to a combobox signal before the combobox exists.
3365 This fixes the cras in projects.maemo.org bug NB#56288 .
3366 (modest_connection_specific_smtp_edit_window_get_settings):
3367 Remove the server_account_name parameter which was being checked for NULL
3368 though it was not used.
3370 * src/maemo/modest-connection-specific-smtp-window.c:
3371 (modest_connection_specific_smtp_window_fill_with_connections),
3372 (on_button_edit), (modest_connection_specific_smtp_window_init):
3373 Correct the number of treemodel columns to prevent a warning.
3374 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3375 libconic does not work.
3377 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3379 * src/modest-tny-account.c:
3380 (modest_tny_account_new_from_server_account):
3381 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3382 SMTP when "None" was chosen by the user. However, with my SMTP server that
3383 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3386 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3388 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3389 to explain the memory management issue with the ID in the ModestPair.
3391 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3392 (add_sending_page), (modest_account_assistant_finalize):
3393 * src/gnome/modest-gnome-global-settings-dialog.c:
3394 (create_updating_page), (create_composing_page):
3395 * src/gnome/modest-msg-edit-window.c: (get_transports),
3396 (init_window), (modest_msg_edit_window_finalize),
3397 (modest_msg_edit_window_get_msg_data):
3398 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3399 * src/gnome/modest-transport-widget.c:
3400 (modest_transport_widget_finalize), (smtp_configuration):
3401 * src/maemo/modest-maemo-global-settings-dialog.c:
3402 (create_updating_page), (create_composing_page):
3403 * src/maemo/modest-msg-edit-window.c: (get_transports),
3404 (init_window), (modest_msg_edit_window_finalize),
3405 (modest_msg_edit_window_get_msg_data),
3406 (modest_msg_edit_window_free_msg_data):
3407 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3408 (modest_store_widget_finalize):
3409 * src/maemo/modest-transport-widget.c:
3410 (modest_transport_widget_finalize), (smtp_configuration):
3411 * src/modest-main.c: (send_mail):
3412 * src/widgets/modest-combo-box.h:
3413 * src/widgets/modest-global-settings-dialog-priv.h:
3414 * src/widgets/modest-global-settings-dialog.c:
3415 (modest_global_settings_dialog_finalize):
3416 * src/widgets/modest-msg-edit-window.h:
3417 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3418 as long as the combo box, to prevent use of freed memory for the ID.
3420 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3422 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3423 get_accounts(), to make this clearer. Do not check for the enabled gconf
3424 key, because we do not use this for server accounts (at least, not yet).
3425 This allows us to send email again.
3427 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3429 * src/maemo/modest-platform.c:
3430 (on_modest_conf_update_interval_changed), (modest_platform_init):
3431 Only respond to this particular key change. All these strcmp()s cannot be
3434 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3436 * src/maemo/modest-maemo-global-settings-dialog.c:
3437 (current_connection): Prevent a crash in scratchbox when
3438 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3439 * src/maemo/modest-platform.c:
3440 (on_modest_conf_update_interval_changed), (modest_platform_init):
3441 Get the update interval from gconf and reset it when the gconf key changes.
3443 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3445 * src/modest-protocol-info.c:
3446 * src/modest-protocol-info.h: Adde enum-specific get functions,
3447 instead of using a ModestProtocolType enum parameter.
3449 * src/gnome/modest-account-assistant.c:
3450 * src/gnome/modest-store-widget.c:
3451 * src/gnome/modest-store-widget.h:
3452 * src/gnome/modest-transport-widget.c:
3453 * src/gnome/modest-transport-widget.h:
3454 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3455 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3456 * src/maemo/easysetup/modest-easysetup-wizard.c:
3457 * src/maemo/modest-account-settings-dialog.c:
3458 * src/maemo/modest-account-settings-dialog.h:
3459 * src/maemo/modest-store-widget.c:
3460 * src/maemo/modest-store-widget.h:
3461 * src/maemo/modest-transport-widget.c:
3462 * src/maemo/modest-transport-widget.h:
3463 * src/modest-account-mgr-helpers.c:
3464 * src/modest-account-mgr-helpers.h:
3465 * src/modest-account-mgr.c:
3466 * src/modest-account-mgr.h:
3467 * src/modest-tny-account.c:
3468 * src/modest-tny-folder.c:
3469 * src/widgets/modest-account-view.c:
3470 * src/widgets/modest-retrieve-combo-box.c:
3471 * src/widgets/modest-retrieve-combo-box.h:
3472 * src/widgets/modest-secureauth-combo-box.c:
3473 * src/widgets/modest-serversecurity-combo-box.c:
3474 * src/widgets/modest-serversecurity-combo-box.h:
3475 * tests/check_account-mgr.c:
3476 Use the specific functions, and use the re-renamed enum values for GNOME too.
3478 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3480 * src/modest-pair.h:
3481 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3482 so we can get the second based on the first.
3484 * src/maemo/modest-account-settings-dialog.h:
3485 * src/maemo/modest-account-settings-dialog.c:
3486 Added get_supported_secure_authentication_methods(), though it is mostly
3487 commented-out for now until the necessary API is committed to tinymail.
3488 (modest_account_settings_dialog_set_account_name),
3489 (save_configuration): Request the supported authentication methods from the
3490 server, so we can choose a working method.
3492 * src/modest-tny-account-store.h:
3493 * src/modest-tny-account-store.c:
3494 (modest_tny_account_store_get_session): Rename from
3495 tny_account_store_get_session().
3497 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3499 * src/modest-protocol-info.h: Split the ModestProtocol enum
3500 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3501 There was no need to have these unrelated values in one enum.
3503 * src/: many files: Adapted to changed enum. This makes the code a bit
3504 clearer, and the compiler could catch some errors.
3506 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3508 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3509 Show the detailed internal camel error message when an error happens
3510 during the configuration, so that our testers can give us more clues.
3511 For instance, in projects.maemo.org bug NB#56910 .
3513 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3515 * src/modest-tny-account.c:
3516 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3517 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3519 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3521 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3522 * src/maemo/modest-account-settings-dialog.c:
3523 (modest_account_settings_dialog_set_account_name),
3524 (save_configuration): For the incoming secure authentication checkbox,
3525 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3526 the UI specification. PLAIN does not seem to be supported for most IMAP
3527 servers anyway, and I am not sure what it would mean.
3528 However, we probably need to discover which of the secure-authentication
3529 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3530 * src/modest-account-mgr-helpers.c:
3531 (modest_account_mgr_get_server_account_data):
3533 * src/modest-tny-account.c:
3534 (modest_tny_account_new_from_server_account):
3535 Use tny_account_set_mech() to set secure-authentication methods,
3536 with some special-casing for IMAP, based on my observations of how
3539 * src/modest-account-mgr-helpers.h:
3540 * src/modest-account-mgr.c:
3541 * src/modest-defs.h: Comment that the URI is only used for local folders.
3543 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3545 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3546 parameter const, just to be neat.
3547 * src/modest-text-utils.c: (modest_text_utils_inline):
3548 End g_strconcat() with NULL, as its documentation says. This is almost
3549 certainly the cause of my crash at startup on the device. Interestingly,
3550 valgrind doesn't tell us about these errors.
3552 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3554 * scripts/build-packages: Added more precise comments about how to use
3555 this script, though I still get this error:
3556 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3557 error building tinymail
3559 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3561 * src/maemo/modest-main-window.c: (on_account_update):
3562 Very slight cleanup, hoping to make it simpler to discover what causes
3563 a crash here sometimes.
3565 * src/modest-tny-account.c:
3566 (modest_tny_account_new_from_server_account): Set the port. Added
3567 comments about the options and a TODO comment because I need to find out
3568 how to specify the secure authentication method.
3570 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3572 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3573 changed CFlags paths form modest to libmodest
3575 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3577 * src/modest-account-mgr-helpers.c:
3578 (modest_account_mgr_get_server_account_data),
3579 (modest_account_mgr_free_server_account_data):
3580 * src/modest-account-mgr-helpers.h:
3581 * src/modest-account-mgr.c:
3582 (modest_account_mgr_add_server_account):
3583 * src/modest-defs.h:
3584 * src/modest-tny-account.c:
3585 (modest_tny_account_new_from_server_account):
3586 Determine the options for tny_camel_account_add_option() here,
3587 based on the settings, rather than storing them directly in gconf.
3589 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3591 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3592 Show a more friendly error dialog now that we expect (from the tinymail
3593 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3595 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3597 * src/maemo/modest-main-window.c: (on_account_update): Check that
3598 account_name is not NULL, to prevent a crash at startup that I am
3599 seeing on the N800. I do wonder why it is NULL.
3601 * src/maemo/easysetup/modest-easysetup-wizard.c:
3602 (create_page_user_details):
3603 * src/maemo/modest-account-settings-dialog.c:
3604 (create_page_user_details), (create_page_outgoing):
3605 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3606 (modest_connection_specific_smtp_edit_window_init):
3607 * src/modest-ui-actions.c:
3608 (modest_ui_actions_on_password_requested):
3609 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3610 might do something useful with the on-screen keyboard.
3612 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3614 * src/maemo/modest-main-window.c: (on_account_update):
3615 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3616 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3618 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3620 * src/modest-tny-account-store.c: (on_account_changed):
3621 Correct the signature of this signal handler.
3623 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3625 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3626 Show a HildonNote instead of a GtkDialog for Maemo.
3628 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3630 * src/widgets/modest-account-view.h:
3631 * src/widgets/modest-account-view.c: (on_account_changed),
3632 (on_account_removed). Added a boolean flag, set/unset by
3633 modest_account_view_block_conf_updates(),
3634 modest_account_view_unblock_conf_updates() to prevent unnecessary
3635 updates, but this is not very useful because the gconf notifications are
3636 so delays (maybe only on Maemo Bora).
3637 So auto-updating is turned off, and these functions do an explicit
3638 update when necessary.
3639 However, something else is still doing too much work when adding/removing
3640 accounts, probably in another part of the application.
3642 * src/maemo/modest-account-view-window.c:
3643 (on_delete_button_clicked), (on_edit_button_clicked),
3644 (on_new_button_clicked): Use the new functions.
3646 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3648 * src/modest-account-mgr-helpers.c:
3649 (modest_account_mgr_set_first_account_as_default):
3650 Sort the list of names alphabetically-by-title, so we choose the first one
3652 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3653 alphabetically by the title.
3655 This fixes projects.maemo.org bug NB#56418 .
3657 * src/modest-account-mgr-priv.c:
3658 (_modest_account_mgr_account_from_key):
3659 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3660 avoid a valgrind error, and possible random behaviour.
3662 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3664 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3665 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3666 tinymail documentation to say that this can be expected.
3667 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3668 pretty, and should not happen, but I would prefer to know when it does.
3670 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3672 * configure.ac: When using the older hildon version, probably on Bora,
3673 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3675 * src/widgets/modest-attachment-view.c:
3676 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3679 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3681 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3682 Implemented the prototype. Can be tested with
3683 tests/dbus_api/test_open_message:
3685 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3687 * src/modest-tny-account-store.c:
3688 (modest_tny_account_store_instance_init), (get_password):
3689 * src/modest-ui-actions.c:
3690 (modest_ui_actions_on_password_requested):
3691 Do not store the password in gconf, because this function is called
3692 for non-remembered passwords. Actually use the cached (in the hash map)
3693 password instead of releasing it.
3694 The password will now not be remembered if it is asked via the protected
3695 password dialog, as per the UI spec.
3697 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3699 * src/modest-defs.h:
3700 * src/modest-account-mgr-helpers.h:
3701 * src/modest-account-mgr-helpers.c:
3702 Added modest_server_account_get_username_has_succeeded(),
3703 modest_server_account_set_username_has_succeeded().
3704 (modest_server_account_set_username),
3705 Reset the has-succeeded flag if the username changes.
3707 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3708 * src/maemo/modest-connection-specific-smtp-window.c:
3709 (modest_connection_specific_smtp_window_save_server_accounts):
3710 Use modest_server_account_set_username() instead of using
3711 modest_conf_set_string() directly, so that the has-succeeded flag is always
3714 * src/modest-ui-actions.c:
3715 (modest_ui_actions_on_password_requested): Dim the username entry if
3716 the username has ever worked, as per the UI spec.
3718 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3720 * src/modest-tny-account-store.c: (get_password):
3721 * src/modest-ui-actions.c:
3722 (modest_ui_actions_on_password_requested):
3723 Allow the username to be changed too, though there is more work to
3724 be done on exactly how this behaves.
3726 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3728 * src/modest-account-mgr-helpers.h:
3729 * src/modest-account-mgr-helpers.c:
3730 Added modest_account_mgr_get_display_name(),
3731 modest_server_account_get_username(),
3732 modest_server_account_set_username(),
3733 modest_server_account_set_password(),
3734 modest_server_account_get_hostname() functions so we do not need to
3735 use the conf API directly.
3737 * src/maemo/modest-main-window.c: (connect_signals):
3738 Actually connect ot the ModestAccountStore::request-password signal,
3739 so that we show the dialog when the password is requested by Tinymail,
3740 for isntance if it is empty.
3742 * src/modest-marshal.list:
3743 * src/modest-tny-account-store.c:
3744 (modest_tny_account_store_class_init), (get_password),
3745 (modest_tny_account_store_alert):
3746 * src/modest-tny-account-store.h:
3747 * src/modest-ui-actions.h:
3748 * src/modest-ui-actions.c:
3749 (modest_ui_actions_on_password_requested):
3750 Change the signal parameters, so it is obvious that we are providing
3751 the non human-readable server name, and receiving both the username
3752 and password, though changing of the username is not yet implemented.
3753 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3754 for the GNOME version.
3756 This should fix the projects.maemo.org bug NB#56209, though it does not
3757 work on Bora, because the gconf_client_get() for the password fails
3758 immediately after we save it with gconf_client_set().
3760 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3763 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3764 caused an undefined symbol error:
3765 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3767 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3769 * src/modest-tny-account-store.c:
3770 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3771 using a GError instead of a string message, so we can translate it in
3774 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3776 * src/maemo/modest-address-book.c:
3777 (modest_address_book_check_names):
3778 * src/maemo/modest-msg-view-window.c:
3779 (modest_msg_view_window_clipboard_owner_change):
3780 * src/modest-init.c: (modest_init_init_ui):
3781 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3782 (update_folders_cb), (modest_mail_operation_update_account):
3783 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3784 (modest_ui_actions_on_msg_attachment_clicked),
3785 (modest_ui_actions_on_msg_recpt_activated):
3786 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3787 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3788 (modest_msg_view_search_next):
3789 * src/widgets/modest-recpt-editor.c:
3790 (modest_recpt_editor_on_button_release_event),
3791 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3792 g_message(). At this point we should only be seeing interesting errors on
3793 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3795 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3797 (modest_wizard_dialog_force_title_update):
3798 * src/maemo/easysetup/modest-wizard-dialog.h:
3799 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3800 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3801 can update the title when appropriate. Otherwise the title is wrong if the
3802 pages are added after adding the notebook to the dialog.
3803 This must be a problem in HildonWizardDialog too.
3804 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3806 * src/maemo/easysetup/modest-easysetup-wizard.c:
3807 (create_subsequent_customsetup_pages),
3808 (create_subsequent_easysetup_pages):
3809 Call modest_wizard_dialog_force_title_update() so that the title is
3810 correct even with GTK+ < 2.10.
3811 This fixes projects.maemo.org bug NB#56145 .
3813 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3815 * src/maemo/modest-platform.c:
3816 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3817 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3820 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3822 * src/widgets/modest-window.h:
3823 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3824 and modest_window_save_state(), which invokes it.
3826 * src/widgets/modest-window-mgr.h:
3827 * src/widgets/modest-window-mgr.c:
3828 Added modest_window_mgr_save_state_for_all_windows(), which calls
3829 the save_state vfunc on all registered windows, if implemented.
3831 * src/gnome/modest-msg-edit-window.c:
3832 * src/gnome/modest-msg-view-window.c:
3833 * src/maemo/modest-msg-edit-window.c:
3834 * src/maemo/modest-msg-view-window.c:
3835 * src/maemo/modest-main-window.c:
3836 Specify the existing save_settings functions as implementations of
3837 ModestWindow::save_state_func().
3839 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3840 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3841 enabling hibernation, for instance.
3843 We may need to do the same thing for restoring settings.
3846 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3848 * src/widgets/modest-window-mgr.c:
3849 * src/widgets/modest-window-mgr.h:
3850 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3851 modest_window_mgr_get_hibernation_is_prevented().
3853 * src/maemo/modest-main-window.c:
3854 (on_hildon_program_is_topmost_notify): Prevent hibernation
3855 (possible when the application goes to the background in the WM),
3856 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3858 * src/maemo/easysetup/modest-easysetup-wizard.c:
3859 (modest_easysetup_wizard_dialog_init):
3860 * src/maemo/modest-account-settings-dialog.c:
3861 (modest_account_settings_dialog_init):
3862 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3863 (modest_connection_specific_smtp_edit_window_init):
3864 * src/maemo/modest-connection-specific-smtp-window.c:
3865 (modest_connection_specific_smtp_window_init):
3866 * src/maemo/modest-signature-editor-dialog.c:
3867 (modest_signature_editor_dialog_init):
3868 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3869 prevent hibernation while any of these account settings dialogs are open.
3871 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3873 * src/maemo/Makefile.am:
3874 * src/maemo/modest-osso-state-saving.c:
3875 * src/maemo/modest-osso-state-saving.h: Added
3876 modest_osso_load_state() and modest_osso_save_state() though they do
3877 nothing now. They should iterate through all the open windows and load/save
3879 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3880 save state when closing.
3882 * src/maemo/modest-main-window.c:
3883 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3884 Add a notification handler for the HildonProgram::is-topmost property,
3885 so we can allow hibernation when the application goes into the background.
3886 But we still need to detect when the accounts setup windows are open so
3887 we can stop hibernation when they are open.
3888 To do this, I also added the main window the HildonProgram. This might have
3889 other side-effects/benefits, and should maybe be done for other windows.
3891 * src/maemo/modest-osso-autosave-callbacks.h:
3892 * src/maemo/modest-osso-autosave-callbacks.c:
3893 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3894 though it does not do anything yet, and we might never need this to do
3895 anything. For instance, we already save drafts.
3897 * src/maemo/modest-platform.c: (modest_platform_init):
3898 Specify the libosso auto-save callback.
3900 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3902 * src/maemo/modest-platform.c:
3903 (modest_platform_set_update_interval):
3904 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3905 aparently stays valid between application instances, so we can use this
3906 to remove and reset it later. According to a maemo-developers email from
3909 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3911 * configure.ac: Depend on libalarm for Maemo.
3913 * src/dbus_api/modest-dbus-api.h:
3914 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3915 (on_send_receive), (modest_dbus_req_handler):
3916 Handle a SEND_RECEIVE D-Bus method.
3918 * libmodest-dbus-client/libmodest-dbus-client.c:
3919 (libmodest_dbus_client_send_and_receive):
3920 * libmodest-dbus-client/libmodest-dbus-client.h:
3921 Add C convenience functions for calling the new D-Bus method.
3923 * src/modest-platform.h:
3924 * src/gnome/modest-platform.c:
3925 * src/maemo/modest-platform.c:
3926 Added modest_platform_set_update_interval(), which uses the
3927 alarmd API on Maemo.
3928 (modest_platform_init),
3929 Call modest_platform_set_update_interval(), using a hard-coded
3930 interval for now (until the global settings dialog is implemented),
3931 though I am not sure that this makes sense yet.
3933 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3935 * src/dbus_api/modest-dbus-callbacks.c:
3936 (modest_osso_cb_hw_state_handler):
3937 * src/dbus_api/modest-dbus-callbacks.h:
3938 * src/maemo/modest-platform.c: (modest_platform_init):
3939 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3940 in case this has some effect on the ability for Maemo to ping the
3943 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3945 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3946 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3947 warning. It is probably a logic error, but I need to fix the build.
3949 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3951 * src/modest-account-mgr.h:
3952 * src/modest-account-mgr.c:
3953 (modest_account_mgr_account_names): Add a gboolean enabled_only
3954 parameter, so we can get lists of onlt the enabled accounts.
3956 (modest_account_mgr_add_account),,
3957 (modest_account_mgr_account_with_display_name_exists):
3958 * src/maemo/modest-msg-edit-window.c: (get_transports):
3959 * src/modest-account-mgr-helpers.c:
3960 (modest_account_mgr_set_first_account_as_default):
3961 * src/modest-init.c: (init_default_account_maybe):
3962 * src/modest-tny-account-store.c: (get_accounts):
3963 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3964 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3965 * tests/check_account-mgr.c: (START_TEST):
3966 Provide the extra parameter, as appropriate.
3968 * src/widgets/modest-account-view.c: (update_account_view):
3969 Do not show disabled accounts (meaning that there is no way to
3970 enable/disable accounts in the UI (the feature is not in our UI
3971 specification), so we can use this internally only to mark unfinished
3972 or temporary account data.
3974 * src/maemo/easysetup/modest-easysetup-wizard.c:
3975 (create_account): Add boolean enable parameter, so we can specify FALSE
3976 to create the temporary account.
3977 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3978 (on_before_next): When finishing, when there is a temporary account, just
3980 Also, use a timeout to delay the showing of the dialog until gconf is likely
3981 to return correct information, due to a maemo gconf bug that is fixed in
3982 osso 1.1, but not yet in Bora.
3983 However, the dialog stays on screen after it is destroyed.
3985 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3986 for invalid data when cancelling. Use a hildon note instead of a dialog
3987 to complain about invalid data. Do not show the account-saved note if the
3988 account is disabled (a temporary account that will not really be saved for use
3991 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3993 * src/modest-account-mgr-helpers.h:
3994 * src/modest-account-mgr-helpers.c:
3995 Added modest_account_mgr_unset_default_account(),
3996 Added modest_account_mgr_set_first_account_as_default().
3998 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3999 If it was the default account, unset the default account name.
4001 * src/maemo/modest-account-view-window.c:
4002 (on_delete_button_clicked): If it was the default account,
4003 set the first remaining account as the default instead.
4005 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
4006 a NULL account or a NULL default account, to prevent a crash. This should
4007 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
4010 2007-04-30 Murray Cumming <murrayc@murrayc.com>
4012 * src/widgets/modest-recpt-editor.c:
4013 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
4014 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
4015 TODO comment for this. This fixes the build.
4017 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
4018 be the best place for it. This will in future update all auto-update accounts,
4019 rather than just the current/default account, when that gconf key exists.
4020 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
4021 if there are no accounts, before calling do_send_receive().
4022 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
4024 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
4025 * src/maemo/modest-main-window-ui.h:
4026 * src/maemo/modest-main-window.c: (on_connection_changed),
4027 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
4028 directly, becaue the signal handler does more.
4030 2007-04-30 Murray Cumming <murrayc@murrayc.com>
4032 * src/modest-account-mgr-helpers.c:
4033 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
4034 for the case that the account does not exist.
4036 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
4037 (equivalent to the modest account name) rather than the tinymail account name
4038 (equivalent to the modest account title - human readable) to get the account data.
4039 Check for null account data to prevent the crash, and add a TODO comment saying that
4040 this needs fixing because it is using the server account name instead of the account name.
4042 2007-04-29 Murray Cumming <murrayc@murrayc.com>
4044 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
4045 * src/maemo/modest-account-settings-dialog.c: (show_error),
4047 Use hildon_note_new_information() for informative and error messages,
4048 which seems to be expected for Maemo applications (no documentation that I know of
4049 says this). I am surprised that there is no distinction between info and error
4052 2007-04-29 Murray Cumming <murrayc@murrayc.com>
4054 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
4055 it is easy to find where this is used.
4057 * src/maemo/easysetup/modest-easysetup-wizard.c:
4058 (create_page_welcome), (create_page_account_details),
4059 (create_page_user_details), (create_page_complete_easysetup),
4060 (create_page_custom_incoming), (create_page_custom_outgoing),
4061 (create_page_complete_custom):
4062 * src/maemo/modest-account-settings-dialog.c:
4063 (create_page_account_details), (create_page_user_details),
4064 (create_page_incoming), (create_page_outgoing):
4065 * src/maemo/modest-account-view-window.c: (window_vbox_new):
4066 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4067 (modest_connection_specific_smtp_edit_window_init):
4068 * src/maemo/modest-connection-specific-smtp-window.c:
4069 (modest_connection_specific_smtp_window_init):
4070 * src/maemo/modest-signature-editor-dialog.c:
4071 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
4072 and scrolling policy as per the Email Application Layout Guide, if I have
4075 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4077 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
4078 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
4079 which were empty, because these vfuncs have been removed from TnyAccountStore.
4080 This fixes the build.
4082 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4084 * src/maemo/modest-main-window.c:
4085 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
4086 showing/hiding it. Added TODO because it probably should not be NULL.
4087 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
4088 because unnecessary g_warnings() make degugging difficult.
4090 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4092 * src/maemo/modest-msg-edit-window.c:
4093 (modest_msg_edit_window_select_color),
4094 (modest_msg_edit_window_select_background_color): 2 const corrections and
4095 moving 2 #endifs before closing brackets, to fix the build.
4097 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4099 * src/maemo/easysetup/modest-easysetup-wizard.h:
4100 * src/maemo/easysetup/modest-easysetup-wizard.c:
4101 (modest_easysetup_wizard_dialog_finalize),
4102 (on_button_edit_advanced_settings), (create_page_complete_custom),
4103 (on_response), (create_account):
4104 Implement the Advanced Settings edit button, by saving the account information,
4105 for the Advanded Settings dialog to use directly from gconf, and removing it
4106 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
4107 Bug #5533 in the projects.maemo.org bugzilla.
4109 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4111 * src/maemo/modest-msg-view-window.c:
4112 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
4113 when opening a message window.
4115 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4117 * src/maemo/easysetup/modest-easysetup-wizard.c:
4118 (create_page_custom_outgoing): Correct the position of the horizontal separator to
4121 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
4122 before showing/hiding them, to avoid a crash when clicking on folders when there are no
4123 gconf settings. I probably added more checks than necessary, but that is safer.
4125 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
4126 variable to fix the build, but this seems to be used when it is still NULL.
4128 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4130 * src/modest-platform.h:
4131 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
4132 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
4133 * src/modest-main.c: Implement this function so we can avoid using
4134 maemo-specific API from cross-platform code.
4136 * src/modest-tny-account-store.c:
4137 (get_smtp_specific_transport_account_for_open_connection):
4138 * src/modest-ui-actions.c: (check_for_connection),
4139 (modest_ui_actions_on_item_not_found):
4140 Use modest_platform_connect_and_wait() and put #idefs around other
4141 maemo-specific code, because only maemo currently has a way to
4142 identify connection names.
4144 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4146 * src/modest-tny-account-store.h:
4147 * src/modest-tny-account-store.c:
4148 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
4149 the connection-specific SMTP server settings in the configuration.
4151 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
4153 * src/maemo/modest-main-window.c: (on_connection_changed),
4155 * src/modest-main.c: (main), (start_ui), (send_mail):
4156 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
4157 that is what is intended.
4159 * src/modest-ui-actions.c: (action_send), (action_receive),
4160 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
4161 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
4162 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4163 SMTP server is used when it is specified.
4165 (modest_ui_actions_on_send_receive):
4166 Check that a connection is open before proceeding.
4167 Receive and then send, instead of vice-versa, as per the specification.
4169 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4171 * src/modest-mail-operation.c:
4172 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4173 though I guess it should be something other than NULL.
4175 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4177 * src/maemo/easysetup/modest-easysetup-wizard.c:
4178 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4179 combo twice, to avoid an g_warning and to make it visible again.
4180 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4181 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4182 (already intended) dereference when detaching, because we then recreate the menu.
4183 But I am not sure why the warning was happening, and it is possible that this is a memory
4186 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4188 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4189 and uri_parse_mailto() utility functions.
4190 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4192 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4194 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4196 * src/dbus_api/modest-dbus-api.h:
4197 * src/dbus_api/modest-dbus-callbacks.c:
4198 Use an idle callback to execute the modest code in the application's own thread.
4199 Remove the helloworld example method.
4200 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4201 parsed, and the open-message method is not implemented because this is not yet implemented in
4203 * libmodest-dbus-client/libmodest-dbus-client.c:
4204 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4205 (libmodest_dbus_client_open_message):
4206 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4208 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4209 body without crashing.
4211 * tests/dbus_api/Makefile.am:
4212 * tests/dbus_api/test_mail_to.c:
4213 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4215 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4217 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4218 Added file to fix the build. Sorry.
4220 * src/dbus_api/Makefile.am:
4221 * src/dbus_api/modest-dbus-api.h:
4222 * src/dbus_api/modest-dbus-callbacks.h:
4223 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4224 (modest_dbus_req_handler):
4225 Put constants in a separate header so it can be reused by the
4226 client library, without duplication
4228 * libmodest-dbus-client/Makefile.am:
4229 * libmodest-dbus-client/libmodest-dbus-client.c:
4230 (libmodest_dbus_client_call_helloworld),
4231 (libmodfest_dbus_client_send_mail),
4232 (libmodfest_dbus_client_mailto),
4233 (libmodfest_dbus_client_open_message):
4234 * libmodest-dbus-client/libmodest-dbus-client.h:
4235 (Partly) Implement a send_mail D-Bus method.
4237 * tests/dbus_api/Makefile.am:
4238 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4239 the send_email D-Bus method.
4241 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4245 * libmodest-dbus-client/Makefile.am:
4246 * libmodest-dbus-client/libmodest-dbus-client.c:
4247 * libmodest-dbus-client/libmodest-dbus-client.h:
4248 * tests/dbus_api/Makefile.am:
4249 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4250 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4252 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4254 * src/maemo/easysetup/modest-easysetup-wizard.c:
4255 (create_page_account_details):
4256 * src/maemo/modest-account-settings-dialog.c:
4257 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4258 widgets, because this might not be the default in future versions of the Maemo GTK+.
4259 However, I can not not get capitalization to work even in a simple test case.
4261 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4263 * src/maemo/easysetup/modest-easysetup-wizard.c:
4264 (create_page_custom_incoming), (create_page_custom_outgoing):
4265 * src/maemo/modest-account-settings-dialog.c:
4266 (create_page_account_details), (create_page_incoming),
4267 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4268 instead of using gtk_check_button_with_label(), so they are aligned like the other
4269 widgets, as per the UI spec.
4271 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4273 * src/maemo/easysetup/modest-easysetup-wizard.c:
4274 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4275 * src/widgets/modest-validating-entry.c:
4276 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4277 Modest prefix instead of an EasySetup prefix.
4279 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4281 * src/widgets/modest-validating-entry.h:
4282 * src/widgets/modest-validating-entry.c: (on_insert_text),
4283 Added easysetup_validating_entry_set_max_func(), used to set a callback
4284 to call when the max number of characters is reached. GtkEntry has a max-length
4285 already but is silent about it.
4287 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4288 (create_page_account_details), (create_page_user_details),
4290 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4291 (create_page_account_details), (create_page_user_details),
4292 (create_page_outgoing):
4293 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4294 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4295 the UI spec, when the user tries to enter more than the max number of characters.
4297 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4299 * src/maemo/easysetup/modest-easysetup-wizard.c:
4300 (create_page_user_details), (create_page_custom_incoming),
4301 (create_page_custom_outgoing):
4302 * src/maemo/modest-account-settings-dialog.c:
4303 (create_page_user_details), (create_page_incoming),
4304 (create_page_outgoing):
4305 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4306 (modest_connection_specific_smtp_edit_window_init):
4307 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4308 not appropriate. Bad Maemo-specific defaults!.
4310 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4312 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4313 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4314 (modest_signature_editor_dialog_set_settings):
4315 Disable the label and textview when the checkbox is disabled, and use the
4316 specified (UI spec) default signature text.
4318 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4320 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4321 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4323 * src/modest-defs.h:
4324 * src/modest-account-mgr-helpers.h:
4325 * src/modest-account-mgr-helpers.c:
4326 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4328 * src/maemo/Makefile.am:
4329 * src/maemo/modest-signature-editor-dialog.c:
4330 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4333 * src/maemo/modest-account-settings-dialog.h:
4334 * src/maemo/modest-account-settings-dialog.c:
4335 (modest_account_settings_dialog_finalize), (on_button_signature),
4336 (save_configuration): Use the new dialog when the Edit button is pressed, and
4337 save the changes if necessary, as per the UI spec.
4339 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4341 * src/maemo/Makefile.am:
4342 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4343 based on maemo-develoers email from Dirk.
4345 * src/maemo/easysetup/modest-easysetup-wizard.c:
4346 (create_page_welcome), (create_page_account_details),
4347 (create_page_user_details), (create_page_complete_easysetup),
4348 (create_page_custom_incoming), (create_page_custom_outgoing),
4349 (create_page_complete_custom),
4350 (modest_easysetup_wizard_dialog_init):
4351 * src/maemo/modest-account-settings-dialog.c:
4352 (create_page_account_details), (create_page_user_details),
4353 (create_page_incoming), (create_page_outgoing),
4354 (modest_account_settings_dialog_init):
4355 * src/maemo/modest-connection-specific-smtp-window.c:
4356 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4358 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4360 * src/maemo/easysetup/modest-easysetup-wizard.c:
4361 (create_page_account_details), (create_page_custom_outgoing),
4362 (create_page_complete_custom):
4363 * src/maemo/modest-account-settings-dialog.c:
4364 (create_page_user_details), (create_page_incoming),
4365 (create_page_outgoing):
4366 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4367 (modest_connection_specific_smtp_edit_window_init):
4368 Use the correct (UI spec) port min/max, and use horizontal separators,
4371 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4373 * src/maemo/easysetup/modest-easysetup-wizard.c:
4374 (set_default_custom_servernames):
4375 * src/maemo/modest-account-settings-dialog.c:
4376 (create_page_incoming), (on_combo_outgoing_security_changed),
4377 (on_combo_incoming_security_changed), (create_page_outgoing),
4378 (modest_account_settings_dialog_set_account_name),
4379 (save_configuration):
4380 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4381 (on_combo_security_changed),
4382 (modest_connection_specific_smtp_edit_window_init),
4383 (modest_connection_specific_smtp_edit_window_set_connection),
4384 (modest_connection_specific_smtp_edit_window_get_settings):
4385 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4388 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4391 * src/maemo/easysetup/modest-easysetup-wizard.c:
4392 (create_page_custom_outgoing), (create_page_complete_custom):
4393 * src/maemo/modest-account-settings-dialog.c:
4394 (create_page_user_details), (create_page_outgoing):
4395 * src/maemo/modest-account-view-window.c: (button_box_new):
4396 Use changed logical IDs as per the most recent UI spec:
4397 mcen_bd_emailsetup_edit -> mcen_bd_edit
4398 mcen_bd_emailsetup_delete -> mcen_bd_delete
4399 mcen_bd_emailsetup_close -> mcen_bd_close
4401 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4405 * src/dbus_api/Makefile.am:
4406 * src/dbus_api/modest-dbus-callbacks.c:
4407 * src/dbus_api/modest-dbus-callbacks.h:
4408 * src/maemo/modest-platform.c: (modest_platform_init):
4409 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4411 * tests/Makefile.am:
4412 * tests/dbus_api/Makefile.am:
4413 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4415 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4417 * src/maemo/modest-account-settings-dialog.c:
4418 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4419 Removed unnecessary includes.
4421 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4423 * src/maemo/easysetup/modest-easysetup-wizard.c:
4424 * src/maemo/modest-account-settings-dialog.c:
4425 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4426 * src/widgets/Makefile.am:
4427 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4428 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4429 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4430 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4431 * src/widgets/modest-secureauth-combo-box.c:
4432 * src/widgets/modest-secureauth-combo-box.h:
4433 * src/widgets/modest-serversecurity-combo-box.c:
4434 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4435 made the GObject names more consistent with the rest of the Modest code.
4437 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4439 * src/maemo/easysetup/Makefile.am:
4440 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4441 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4442 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4443 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4444 * src/maemo/easysetup/modest-easysetup-wizard.c:
4445 * src/maemo/easysetup/modest-validating-entry.c:
4446 * src/maemo/easysetup/modest-validating-entry.h:
4447 * src/maemo/modest-account-settings-dialog.c:
4448 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4449 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4450 widgets/ because they are used outside of easysetup too. After checking in,
4451 svn will allow me to rename them too.
4453 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4455 * src/gnome/modest-msg-edit-window.c:
4456 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4457 linker error, to fix the build on the GNOME platform.
4458 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4459 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4460 ifdefed out to avoid a warning.
4462 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4464 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4465 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4466 some alternative for GTK+ 2.6.
4468 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4470 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4472 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4473 specified for EmailAccountsDialog in UI spec.
4475 * src/maemo/easysetup/modest-easysetup-wizard.c:
4476 * src/maemo/easysetup/modest-easysetup-wizard.h:
4477 * src/maemo/modest-account-settings-dialog.c:
4478 * src/maemo/modest-account-settings-dialog.h:
4479 Reuse a member window widget for the connection-specific SMTP server accounts,
4480 so we can tell it to create/save the accounts only if we actually save changes.
4482 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4483 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4484 (modest_connection_specific_smtp_edit_window_get_settings):
4485 Return a struct instance for temporarily remembering the entered data.
4487 * src/maemo/modest-connection-specific-smtp-window.h:
4488 * src/maemo/modest-connection-specific-smtp-window.c:
4489 (modest_connection_specific_smtp_window_finalize),
4490 (modest_connection_specific_smtp_window_fill_with_connections),
4492 (modest_connection_specific_smtp_window_save_server_accounts),
4493 (update_model_server_names): Do not actually save data until asked,
4494 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4496 (on_selection_changed),
4497 (modest_connection_specific_smtp_window_init): Disable the edit
4498 button when nothing is selected.
4500 * src/modest-account-mgr-helpers.c:
4501 * src/modest-account-mgr-helpers.h:
4502 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4505 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4507 * src/modest-account-mgr-helpers.h:
4508 * src/modest-account-mgr-helpers.c:
4509 (modest_account_mgr_get_unused_account_name),
4510 (modest_account_mgr_get_unused_account_display_name): Added these
4511 utility functions, to avoid code duplication.
4513 * src/maemo/easysetup/modest-easysetup-wizard.c:
4514 (create_page_account_details), (create_account):
4515 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4516 (on_combo_security_changed),
4517 (modest_connection_specific_smtp_edit_window_init),
4518 (modest_connection_specific_smtp_edit_window_save_settings):
4519 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4520 * src/maemo/modest-connection-specific-smtp-window.c:
4521 (modest_connection_specific_smtp_window_finalize),
4522 (modest_connection_specific_smtp_window_fill_with_connections),
4523 (on_button_edit), (modest_connection_specific_smtp_window_init):
4524 * src/maemo/modest-connection-specific-smtp-window.h:
4525 Implementing saving of connection-specific server accounts.
4527 But I need to refactor this so we can save the data for each
4528 possible connection-specific account and only actually create the server accounts
4529 when the easysetup finished, or the OK button is pressed on the account settings
4532 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4534 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4535 (on_combo_security_changed):
4536 (modest_connection_specific_smtp_edit_window_init):
4537 Auto-fill the port number as in the account settings.
4539 (modest_connection_specific_smtp_edit_window_set_connection):
4540 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4541 * src/maemo/modest-connection-specific-smtp-window.c:
4542 (fill_with_connections), (on_button_edit),
4543 (modest_connection_specific_smtp_window_init):
4544 Turn the edit window into a dialog to simplify the code, and
4545 set a WM hint as in a GtkDialog, because only a popup can be on top of
4546 another window in Maemo, and popups usually have no WM decoration.
4548 * src/modest-defs.h:
4549 * src/modest-account-mgr-helpers.c:
4550 (modest_account_mgr_set_connection_specific_smtp),
4551 (modest_account_mgr_remove_connection_specific_smtp),
4552 (modest_account_mgr_get_connection_specific_smtp):
4553 * src/modest-account-mgr-helpers.h: Some functions to write the
4554 connection-specific SMTP server information. Not yet used.
4557 * src/widgets/modest-folder-view.c: (text_cell_data):
4558 Fix a warning about an uninitialized variable.
4559 (on_configuration_key_changed): Put an #ifdef around the use
4560 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4562 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4564 * src/maemo/modest-account-settings-dialog.h:
4565 * src/maemo/modest-account-settings-dialog.c:
4566 Added connect_for_modified() utility function to mark the new modified boolean.
4568 (create_page_account_details), (create_page_user_details),
4569 (create_page_incoming), (create_page_outgoing), (on_response),
4570 (modest_account_settings_dialog_init),
4571 (modest_account_settings_dialog_set_account_name):
4572 Only warn about unsaved changes when there are actually unsaved changes.
4574 * src/modest-account-mgr-helpers.c:
4575 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4576 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4577 to get the data from there in future.
4579 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4581 * src/modest-defs.h:
4583 * src/modest-account-mgr-helpers.h:
4584 * src/modest-account-mgr-helpers.c:
4585 Store the security account setting in a single conf key instead of using
4586 the options list, so that the list is left for just the to-be-removed camel hack,
4587 and because gconf_client_set_list() is failing for some reason.
4589 * src/modest-account-mgr.c:
4590 (modest_account_mgr_add_server_account):
4591 * src/maemo/modest-account-settings-dialog.c:
4592 (modest_account_settings_dialog_set_account_name),
4593 (save_configuration): Use the renamed functions.
4596 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4598 * src/widgets/Makefile.am:
4599 * src/widgets/modest-limit-retrieve-combo-box.c:
4600 * src/widgets/modest-limit-retrieve-combo-box.h:
4601 * src/widgets/modest-retrieve-combo-box.c:
4602 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4603 the account settings dialog.
4605 * src/modest-defs.h:
4606 * src/modest-account-mgr-helpers.h:
4607 * src/modest-account-mgr-helpers.c:
4608 (modest_server_account_get_option_secure_auth),
4609 (modest_server_account_set_option_secure_auth):
4610 * src/modest-account-mgr.c:
4611 (modest_account_mgr_add_server_account):
4612 Use the existing AUTH_MECH conf key for the secure-auth setting,
4613 instead of putting it in the list options, because this was actually used already.
4615 * src/maemo/modest-account-settings-dialog.c:
4616 (create_page_account_details),
4617 (modest_account_settings_dialog_set_account_name),
4618 (save_configuration):
4619 * src/maemo/modest-account-settings-dialog.h:
4620 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4621 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4623 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4625 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4626 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4627 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4629 * src/modest-defs.h:
4630 * src/maemo/modest-account-settings-dialog.c:
4631 (create_page_incoming), (on_combo_outgoing_security_changed),
4632 (on_combo_incoming_security_changed), (create_page_outgoing),
4633 (modest_account_settings_dialog_set_account_name),
4634 (save_configuration): Load/Save the port number, and change it when the
4635 security combo changes, to suitable defaults.
4637 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4639 * src/modest-account-mgr.c:
4640 (modest_account_mgr_add_server_account): Set the security and secure-auth
4641 options, and add a comment saying that the other camel-specific options should be
4644 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4646 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4648 * src/modest-tny-account-store.c: (account_list_free),
4649 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4650 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4653 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4655 * src/modest-protocol-info.c:
4656 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4657 is required by our UI spec. Maybe something in our implementation will use this eventually.
4658 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4659 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4660 instead of the previous 0 placeholder.
4662 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4663 secure-auth settings.
4664 * src/modest-account-mgr-helpers.h:
4665 * src/modest-account-mgr-helpers.c:
4666 (modest_server_account_data_get_option_secure_auth),
4667 (modest_server_account_set_option_secure_auth),
4668 (modest_server_account_data_get_option_security),
4669 (modest_server_account_set_option_security): Added this API for getting and setting the security
4670 and secure-auth settings.
4672 * src/maemo/modest-account-settings-dialog.h:
4673 * src/maemo/modest-account-settings-dialog.c:
4674 (modest_account_settings_dialog_finalize), (check_data),
4675 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4676 about changing titles.
4677 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4678 (save_configuration): Save the security and secure-auth settings.
4680 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4681 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4683 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4685 * src/modest-defs.h:
4686 * src/modest-account-mgr.c:
4687 (modest_account_mgr_add_server_account):
4688 Added and used defines for the options key and value pair strings,
4689 that are used so far, though they do not seem to correspond to anything in our
4690 UI specs or ModestProtocol enum.
4692 * src/modest-account-mgr-helpers.h:
4693 * src/modest-account-mgr-helpers.c:
4694 (compare_option_strings_for_name),
4695 (modest_server_account_data_get_option_value),
4696 (modest_server_account_data_get_option_bool),
4697 (modest_account_mgr_get_server_account_option):
4698 Added helper functions for parsing the options GSList.
4700 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4702 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4703 display name is based on the supplied account name.
4704 * src/modest-account-mgr.c:
4705 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4706 with an inefficient, but good-enough, implementation.
4708 * src/maemo/easysetup/modest-easysetup-wizard.c:
4709 (create_page_account_details), (on_before_next), (create_account):
4710 Check for existing display names rather than (non-user-visible) account names, and just
4711 create and set a unique account name at the end.
4713 * src/maemo/modest-account-settings-dialog.c:
4714 (modest_account_settings_dialog_init),
4715 (modest_account_settings_dialog_set_account_name),
4716 (create_page_incoming): Show the display name, instead of the account name.
4717 (on_response): Do some (not all) extra checks, as in the UI spec.
4718 (save_configuration): Save the display name if it was changed.
4720 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4722 * po/en_GB.po: Added needed logical ID and translation.
4723 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4724 (init_view): Made the is-default column clicking work.
4726 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4729 * src/maemo/easysetup/Makefile.am:
4730 * src/maemo/easysetup/modest-easysetup-wizard.c:
4731 (modest_easysetup_wizard_dialog_init):
4732 * src/maemo/easysetup/provider-data-test.keyfile:
4733 * src/maemo/easysetup/provider-data.keyfile:
4734 Moved the provider data file to the new modest-providers-data package and used it from there.
4736 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4738 * src/modest-local-folder-info.c:
4739 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4740 N_() was already used on the static strings, but this just marks it for translation without
4741 using the translation.
4743 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4745 * src/maemo/modest-account-settings-dialog.c:
4746 (create_page_incoming),
4747 (modest_account_settings_dialog_set_account_name):
4748 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4749 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4750 I will do this if nobody else gets there first.
4752 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4754 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4755 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4756 save the security stuff.
4758 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4760 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4761 Set the email address and user fullname, which I now see must be
4764 * src/maemo/modest-account-settings-dialog.h:
4765 * src/maemo/modest-account-settings-dialog.c:
4767 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4768 leave-on-server and authentication.
4769 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4772 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4775 * src/maemo/modest-account-settings-dialog.c:
4776 * src/maemo/modest-account-settings-dialog.h:
4777 Most (but not all) of the widgets are now present as specified by the UI spec.
4778 No changes are yet saved, and some details are not properly shown yet.
4780 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4782 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4784 * src/maemo/Makefile.am:
4785 * src/maemo/modest-account-settings-dialog.c:
4786 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4787 an existing account. Doesn't do much yet.
4789 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4790 Open the accounts settings dialog when Edit is clicked.
4792 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4794 * src/maemo/easysetup/Makefile.am:
4795 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4797 * src/maemo/easysetup/modest-easysetup-wizard.c:
4798 (modest_easysetup_wizard_dialog_init):
4799 Try to get the source directory from the build system,
4800 instead of hard-coding "./" into the source code, when opening our local
4801 copies of the configuration files.
4802 But this still fails when opening the wizard from the Accounts window,
4803 maybe because the working directory seems to change at runtime.
4804 So the wizard will fail the second time unless you copy the files into their
4805 proper locations - see the stdout warnings for the paths.
4807 (create_page_account_details),(on_before_next):
4808 Check for existing non-server accounts instead of server accounts,
4809 so the default account name is useful again, and to prevent trying to
4812 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4813 Show the wizard when New is clicked.
4815 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4816 (init_view): Show the column headers, and show the columns that are
4817 specified in the UI specs. However, something in Maemo's GTK+ prevents
4818 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4819 change the default account. This is despite unsetting the special properties.
4821 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4823 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4824 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4825 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4826 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4827 to make that clearer.
4828 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4830 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4832 * src/maemo/modest-account-view-window.c:
4833 (modest_account_view_window_init),
4834 (modest_account_view_window_new):
4835 Use the same buttons as specified in the
4836 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4837 the existing widgets, which never had a chance of working.
4838 Put the ModestAccountView treeview in a scrolled window.
4839 Do not repeat the initialization in both _init() and _new().
4841 * src/widgets/modest-account-view.c: (update_account_view):
4842 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4843 this widget and window shows no accounts.
4845 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4847 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4849 * src/maemo/easysetup/modest-easysetup-wizard.c:
4850 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4851 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4852 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4855 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4856 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4857 accounts exist yet, as in the UI spec.
4859 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4861 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4863 * src/maemo/Makefile.am:
4864 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4865 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4866 New window for editing connection-specific smtp details.
4867 Not fully implemented.
4869 * src/maemo/modest-connection-specific-smtp-window.c:
4870 (modest_connection_specific_smtp_window_finalize) :
4871 unref the tree model.
4872 (on_button_edit): Show the edit window.
4874 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4876 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4879 * src/maemo/Makefile.am:
4880 * src/maemo/modest-connection-specific-smtp-window.c:
4881 * src/maemo/modest-connection-specific-smtp-window.h:
4882 New window for showing the list of connections, for connection-specific
4883 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4884 * src/maemo/easysetup/modest-easysetup-wizard.c:
4885 (create_page_custom_outgoing): Show the new window when the button is clicked.
4887 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4889 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4890 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4891 * src/maemo/modest-msg-edit-window.c:
4892 (modest_msg_edit_window_insert_image):
4893 * src/modest-conf.c: (modest_conf_key_escape):
4894 * src/modest-mail-operation.c:
4895 (modest_mail_operation_send_new_mail):
4896 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4897 (modest_ui_actions_on_new_account):
4898 * src/widgets/modest-attachment-view.c: (update_filename_request):
4899 * src/widgets/modest-mail-header-view.c:
4900 Corrected warnings that were breaking the build, by commenting out unused variables,
4901 and a function, and by including a header.
4903 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4905 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4906 so we can #ifdef around platform-specific code when necessary.
4907 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4908 to allow this to build for the GNOME platform too.
4910 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4912 * src/maemo/easysetup/modest-easysetup-wizard.c:
4913 Added util_increment_name() and used it in create_page_account_details()
4914 to make sure that the default account name is always a new name.
4916 (modest_easysetup_wizard_dialog_init),
4917 (set_default_custom_servernames): Some minor memory management fixes.
4919 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4923 * src/modest-runtime.c: (init_i18n): Restored the translation
4924 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4925 are defined in config.h, and the translations are installed.
4927 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4928 is defined for translation.
4930 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4932 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4934 * src/maemo/easysetup/modest-easysetup-wizard.c:
4935 (modest_easysetup_wizard_dialog_init):
4936 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4937 Use realistic paths (though they should use $prefix generically) to the
4938 mcc_mapping and provider-data.keyfile files which might work when they
4939 are installed by the future version of the operator-wizard package,
4940 and then fallback to paths in our source code, with an explanatory
4943 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4947 * src/maemo/Makefile.am:
4948 * src/maemo/easysetup/: Added files from the previously-exernal
4949 osso-modest-easysetup.
4950 * src/maemo/modest-main-window-ui.h:
4951 * src/modest-ui-actions.c:
4952 * src/modest-ui-actions.h:
4953 Added modest_ui_actions_on_new_account() as a signal handler for the
4954 New Account menu item. It shows the easysetup wizard.
4955 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob