git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/modest-address-book.c:
   4         (modest_address_book_check_names):
   5         * src/maemo/modest-msg-view-window.c:
   6         (modest_msg_view_window_clipboard_owner_change):
   7         * src/modest-init.c: (modest_init_init_ui):
   8         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
   9         (update_folders_cb), (modest_mail_operation_update_account):
  10         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
  11         (modest_ui_actions_on_msg_attachment_clicked),
  12         (modest_ui_actions_on_msg_recpt_activated):
  13         * src/widgets/modest-header-view.c: (drag_data_get_cb):
  14         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
  15         (modest_msg_view_search_next):
  16         * src/widgets/modest-recpt-editor.c:
  17         (modest_recpt_editor_on_button_release_event),
  18         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
  19         g_message(). At this point we should only be seeing interesting errors on
  20         stdout. Debugging messages could be #ifdefed-out if they are still useful.
  21
  22 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  23
  24         (modest_wizard_dialog_force_title_update):
  25         * src/maemo/easysetup/modest-wizard-dialog.h:
  26         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
  27         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
  28         can update the title when appropriate. Otherwise the title is wrong if the
  29         pages are added after adding the notebook to the dialog.
  30         This must be a problem in HildonWizardDialog too.
  31         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
  32
  33         * src/maemo/easysetup/modest-easysetup-wizard.c:
  34         (create_subsequent_customsetup_pages),
  35         (create_subsequent_easysetup_pages):
  36         Call modest_wizard_dialog_force_title_update() so that the title is
  37         correct even with GTK+ < 2.10.
  38         This fixes projects.maemo.org bug NB#56145 .
  39
  40 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  41
  42         * src/maemo/modest-platform.c:
  43         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
  44         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
  45         from being shown.
  46
  47 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  48
  49         * src/widgets/modest-window.h:
  50         * src/widgets/modest-window.c: Added a save_state_func vfunc,
  51         and modest_window_save_state(), which invokes it.
  52
  53         * src/widgets/modest-window-mgr.h:
  54         * src/widgets/modest-window-mgr.c:
  55         Added modest_window_mgr_save_state_for_all_windows(), which calls
  56         the save_state vfunc on all registered windows, if implemented.
  57
  58         * src/gnome/modest-msg-edit-window.c:
  59         * src/gnome/modest-msg-view-window.c:
  60         * src/maemo/modest-msg-edit-window.c:
  61         * src/maemo/modest-msg-view-window.c:
  62         * src/maemo/modest-main-window.c:
  63         Specify the existing save_settings functions as implementations of
  64         ModestWindow::save_state_func().
  65
  66         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
  67         Call modest_window_mgr_save_state_for_all_windows(). This happens before
  68         enabling hibernation, for instance.
  69
  70         We may need to do the same thing for restoring settings.
  71
  72
  73 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  74
  75         * src/widgets/modest-window-mgr.c:
  76         * src/widgets/modest-window-mgr.h:
  77         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
  78         modest_window_mgr_get_hibernation_is_prevented().
  79
  80         * src/maemo/modest-main-window.c:
  81         (on_hildon_program_is_topmost_notify): Prevent hibernation
  82         (possible when the application goes to the background in the WM),
  83         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
  84
  85         * src/maemo/easysetup/modest-easysetup-wizard.c:
  86         (modest_easysetup_wizard_dialog_init):
  87         * src/maemo/modest-account-settings-dialog.c:
  88         (modest_account_settings_dialog_init):
  89         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  90         (modest_connection_specific_smtp_edit_window_init):
  91         * src/maemo/modest-connection-specific-smtp-window.c:
  92         (modest_connection_specific_smtp_window_init):
  93         * src/maemo/modest-signature-editor-dialog.c:
  94         (modest_signature_editor_dialog_init):
  95         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
  96         prevent hibernation while any of these account settings dialogs are open.
  97
  98 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
  99
 100         * src/maemo/Makefile.am:
 101         * src/maemo/modest-osso-state-saving.c:
 102         * src/maemo/modest-osso-state-saving.h: Added
 103         modest_osso_load_state() and modest_osso_save_state() though they do
 104         nothing now. They should iterate through all the open windows and load/save
 105         their state.
 106         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 107         save state when closing.
 108
 109         * src/maemo/modest-main-window.c:
 110         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 111         Add a notification handler for the HildonProgram::is-topmost property,
 112         so we can allow hibernation when the application goes into the background.
 113         But we still need to detect when the accounts setup windows are open so
 114         we can stop hibernation when they are open.
 115         To do this, I also added the main window the HildonProgram. This might have
 116         other side-effects/benefits, and should maybe be done for other windows.
 117
 118         * src/maemo/modest-osso-autosave-callbacks.h:
 119         * src/maemo/modest-osso-autosave-callbacks.c:
 120         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 121         though it does not do anything yet, and we might never need this to do
 122         anything. For instance, we already save drafts.
 123
 124         * src/maemo/modest-platform.c: (modest_platform_init):
 125         Specify the libosso auto-save callback.
 126
 127 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 128
 129         * src/maemo/modest-platform.c:
 130         (modest_platform_set_update_interval):
 131         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 132         aparently stays valid between application instances, so we can use this
 133         to remove and reset it later. According to a maemo-developers email from
 134         David Weinehall.
 135
 136 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 137
 138         * configure.ac: Depend on libalarm for Maemo.
 139
 140         * src/dbus_api/modest-dbus-api.h:
 141         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 142         (on_send_receive), (modest_dbus_req_handler):
 143         Handle a SEND_RECEIVE D-Bus method.
 144
 145         * libmodest-dbus-client/libmodest-dbus-client.c:
 146         (libmodest_dbus_client_send_and_receive):
 147         * libmodest-dbus-client/libmodest-dbus-client.h:
 148         Add C convenience functions for calling the new D-Bus method.
 149
 150         * src/modest-platform.h:
 151         * src/gnome/modest-platform.c:
 152         * src/maemo/modest-platform.c:
 153         Added modest_platform_set_update_interval(), which uses the
 154         alarmd API on Maemo.
 155         (modest_platform_init),
 156         Call modest_platform_set_update_interval(), using a hard-coded
 157         interval for now (until the global settings dialog is implemented),
 158         though I am not sure that this makes sense yet.
 159
 160 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 161
 162         * src/dbus_api/modest-dbus-callbacks.c:
 163         (modest_osso_cb_hw_state_handler):
 164         * src/dbus_api/modest-dbus-callbacks.h:
 165         * src/maemo/modest-platform.c: (modest_platform_init):
 166         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 167         in case this has some effect on the ability for Maemo to ping the
 168         application.
 169
 170 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 171
 172         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 173         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 174         warning. It is probably a logic error, but I need to fix the build.
 175
 176 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 177
 178         * src/modest-account-mgr.h:
 179         * src/modest-account-mgr.c:
 180         (modest_account_mgr_account_names): Add a gboolean enabled_only
 181         parameter, so we can get lists of onlt the enabled accounts.
 182
 183         (modest_account_mgr_add_account),,
 184         (modest_account_mgr_account_with_display_name_exists):
 185         * src/maemo/modest-msg-edit-window.c: (get_transports):
 186         * src/modest-account-mgr-helpers.c:
 187         (modest_account_mgr_set_first_account_as_default):
 188         * src/modest-init.c: (init_default_account_maybe):
 189         * src/modest-tny-account-store.c: (get_accounts):
 190         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 191         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 192         * tests/check_account-mgr.c: (START_TEST):
 193         Provide the extra parameter, as appropriate.
 194
 195         * src/widgets/modest-account-view.c: (update_account_view):
 196         Do not show disabled accounts (meaning that there is no way to
 197         enable/disable accounts in the UI (the feature is not in our UI
 198         specification), so we can use this internally only to mark unfinished
 199         or temporary account data.
 200
 201         * src/maemo/easysetup/modest-easysetup-wizard.c:
 202         (create_account): Add boolean enable parameter, so we can specify FALSE
 203         to create the temporary account.
 204         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 205         (on_before_next): When finishing, when there is a temporary account, just
 206         set it as enabled.
 207         Also, use a timeout to delay the showing of the dialog until gconf is likely
 208         to return correct information, due to a maemo gconf bug that is fixed in
 209         osso 1.1, but not yet in Bora.
 210         However, the dialog stays on screen after it is destroyed.
 211
 212         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 213         for invalid data when cancelling. Use a hildon note instead of a dialog
 214         to complain about invalid data. Do not show the account-saved note if the
 215         account is disabled (a temporary account that will not really be saved for use
 216         until later.)
 217
 218 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 219
 220         * src/modest-account-mgr-helpers.h:
 221         * src/modest-account-mgr-helpers.c:
 222         Added modest_account_mgr_unset_default_account(),
 223         Added modest_account_mgr_set_first_account_as_default().
 224
 225         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 226         If it was the default account, unset the default account name.
 227
 228         * src/maemo/modest-account-view-window.c:
 229         (on_delete_button_clicked): If it was the default account,
 230         set the first remaining account as the default instead.
 231
 232         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 233         a NULL account or a NULL default account, to prevent a crash. This should
 234         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 235
 236
 237 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 238
 239         * src/widgets/modest-recpt-editor.c:
 240         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 241         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 242         TODO comment for this. This fixes the build.
 243
 244         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 245         be the best place for it. This will in future update all auto-update accounts,
 246         rather than just the current/default account, when that gconf key exists.
 247         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 248         if there are no accounts, before calling do_send_receive().
 249         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 250
 251         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 252         * src/maemo/modest-main-window-ui.h:
 253         * src/maemo/modest-main-window.c: (on_connection_changed),
 254         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 255         directly, becaue the signal handler does more.
 256
 257 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 258
 259         * src/modest-account-mgr-helpers.c:
 260         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 261         for the case that the account does not exist.
 262
 263         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 264         (equivalent to the modest account name) rather than the tinymail account name
 265         (equivalent to the modest account title - human readable) to get the account data.
 266         Check for null account data to prevent the crash, and add a TODO comment saying that
 267         this needs fixing because it is using the server account name instead of the account name.
 268
 269 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 270
 271         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 272         * src/maemo/modest-account-settings-dialog.c: (show_error),
 273         (show_ok):
 274         Use hildon_note_new_information() for informative and error messages,
 275         which seems to be expected for Maemo applications (no documentation that I know of
 276         says this). I am surprised that there is no distinction between info and error
 277         dialogs.
 278
 279 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 280
 281         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 282         it is easy to find where this is used.
 283
 284         * src/maemo/easysetup/modest-easysetup-wizard.c:
 285         (create_page_welcome), (create_page_account_details),
 286         (create_page_user_details), (create_page_complete_easysetup),
 287         (create_page_custom_incoming), (create_page_custom_outgoing),
 288         (create_page_complete_custom):
 289         * src/maemo/modest-account-settings-dialog.c:
 290         (create_page_account_details), (create_page_user_details),
 291         (create_page_incoming), (create_page_outgoing):
 292         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 293         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 294         (modest_connection_specific_smtp_edit_window_init):
 295         * src/maemo/modest-connection-specific-smtp-window.c:
 296         (modest_connection_specific_smtp_window_init):
 297         * src/maemo/modest-signature-editor-dialog.c:
 298         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 299         and scrolling policy as per the Email Application Layout Guide, if I have
 300         understood it.
 301
 302 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 303
 304         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 305         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 306         which were empty, because these vfuncs have been removed from TnyAccountStore.
 307         This fixes the build.
 308
 309 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 310
 311         * src/maemo/modest-main-window.c:
 312         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 313         showing/hiding it. Added TODO because it probably should not be NULL.
 314         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 315         because unnecessary g_warnings() make degugging difficult.
 316
 317 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 318
 319         * src/maemo/modest-msg-edit-window.c:
 320         (modest_msg_edit_window_select_color),
 321         (modest_msg_edit_window_select_background_color): 2 const corrections and
 322         moving 2 #endifs before closing brackets, to fix the build.
 323
 324 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 325
 326         * src/maemo/easysetup/modest-easysetup-wizard.h:
 327         * src/maemo/easysetup/modest-easysetup-wizard.c:
 328         (modest_easysetup_wizard_dialog_finalize),
 329         (on_button_edit_advanced_settings), (create_page_complete_custom),
 330         (on_response), (create_account):
 331         Implement the Advanced Settings edit button, by saving the account information,
 332         for the Advanded Settings dialog to use directly from gconf, and removing it
 333         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 334         Bug #5533 in the projects.maemo.org bugzilla.
 335
 336 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 337
 338         * src/maemo/modest-msg-view-window.c:
 339         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 340         when opening a message window.
 341
 342 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 343
 344         * src/maemo/easysetup/modest-easysetup-wizard.c:
 345         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 346         match the UI spec.
 347
 348         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 349         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 350         gconf settings. I probably added more checks than necessary, but that is safer.
 351
 352         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 353         variable to fix the build, but this seems to be used when it is still NULL.
 354
 355 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 356
 357         * src/modest-platform.h:
 358         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 359         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 360         * src/modest-main.c: Implement this function so we can avoid using
 361         maemo-specific API from cross-platform code.
 362         (main):
 363         * src/modest-tny-account-store.c:
 364         (get_smtp_specific_transport_account_for_open_connection):
 365         * src/modest-ui-actions.c: (check_for_connection),
 366         (modest_ui_actions_on_item_not_found):
 367         Use modest_platform_connect_and_wait() and put #idefs around other
 368         maemo-specific code, because only maemo currently has a way to
 369         identify connection names.
 370
 371 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 372
 373         * src/modest-tny-account-store.h:
 374         * src/modest-tny-account-store.c:
 375         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 376         the connection-specific SMTP server settings in the configuration.
 377
 378         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 379         (on_idle_mail_to):
 380         * src/maemo/modest-main-window.c: (on_connection_changed),
 381         (connect_signals):
 382         * src/modest-main.c: (main), (start_ui), (send_mail):
 383         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 384         that is what is intended.
 385
 386         * src/modest-ui-actions.c: (action_send), (action_receive),
 387         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 388         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 389         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 390         SMTP server is used when it is specified.
 391
 392         (modest_ui_actions_on_send_receive):
 393         Check that a connection is open before proceeding.
 394         Receive and then send, instead of vice-versa, as per the specification.
 395
 396 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 397
 398         * src/modest-mail-operation.c:
 399         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 400         though I guess it should be something other than NULL.
 401
 402 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 403
 404         * src/maemo/easysetup/modest-easysetup-wizard.c:
 405         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 406         combo twice, to avoid an g_warning and to make it visible again.
 407         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 408         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 409         (already intended) dereference when detaching, because we then recreate the menu.
 410         But I am not sure why the warning was happening, and it is possible that this is a memory
 411         leak.
 412
 413 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 414
 415         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 416         and uri_parse_mailto() utility functions.
 417         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 418         the mailto URI.
 419         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 420
 421 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 422
 423         * src/dbus_api/modest-dbus-api.h:
 424         * src/dbus_api/modest-dbus-callbacks.c:
 425         Use an idle callback to execute the modest code in the application's own thread.
 426         Remove the helloworld example method.
 427         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 428         parsed, and the open-message method is not implemented because this is not yet implemented in
 429         modest itself.
 430         * libmodest-dbus-client/libmodest-dbus-client.c:
 431         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 432         (libmodest_dbus_client_open_message):
 433         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 434
 435         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 436         body without crashing.
 437
 438         * tests/dbus_api/Makefile.am:
 439         * tests/dbus_api/test_mail_to.c:
 440         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 441
 442 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 443
 444         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 445         Added file to fix the build. Sorry.
 446
 447         * src/dbus_api/Makefile.am:
 448         * src/dbus_api/modest-dbus-api.h:
 449         * src/dbus_api/modest-dbus-callbacks.h:
 450         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 451         (modest_dbus_req_handler):
 452         Put constants in a separate header so it can be reused by the
 453         client library, without duplication
 454
 455         * libmodest-dbus-client/Makefile.am:
 456         * libmodest-dbus-client/libmodest-dbus-client.c:
 457         (libmodest_dbus_client_call_helloworld),
 458         (libmodfest_dbus_client_send_mail),
 459         (libmodfest_dbus_client_mailto),
 460         (libmodfest_dbus_client_open_message):
 461         * libmodest-dbus-client/libmodest-dbus-client.h:
 462         (Partly) Implement a send_mail D-Bus method.
 463
 464         * tests/dbus_api/Makefile.am:
 465         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 466         the send_email D-Bus method.
 467
 468 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 469
 470         * Makefile.am:
 471         * configure.ac:
 472         * libmodest-dbus-client/Makefile.am:
 473         * libmodest-dbus-client/libmodest-dbus-client.c:
 474         * libmodest-dbus-client/libmodest-dbus-client.h:
 475         * tests/dbus_api/Makefile.am:
 476         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 477         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 478
 479 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 480
 481         * src/maemo/easysetup/modest-easysetup-wizard.c:
 482         (create_page_account_details):
 483         * src/maemo/modest-account-settings-dialog.c:
 484         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 485         widgets, because this might not be the default in future versions of the Maemo GTK+.
 486         However, I can not not get capitalization to work even in a simple test case.
 487
 488 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 489
 490         * src/maemo/easysetup/modest-easysetup-wizard.c:
 491         (create_page_custom_incoming), (create_page_custom_outgoing):
 492         * src/maemo/modest-account-settings-dialog.c:
 493         (create_page_account_details), (create_page_incoming),
 494         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 495         instead of using gtk_check_button_with_label(), so they are aligned like the other
 496         widgets, as per the UI spec.
 497
 498 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 499
 500         * src/maemo/easysetup/modest-easysetup-wizard.c:
 501         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 502         * src/widgets/modest-validating-entry.c:
 503         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 504         Modest prefix instead of an EasySetup prefix.
 505
 506 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 507
 508         * src/widgets/modest-validating-entry.h:
 509         * src/widgets/modest-validating-entry.c: (on_insert_text),
 510         Added easysetup_validating_entry_set_max_func(), used to set a callback
 511         to call when the max number of characters is reached. GtkEntry has a max-length
 512         already but is silent about it.
 513
 514         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 515         (create_page_account_details), (create_page_user_details),
 516         (create_account):
 517         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 518         (create_page_account_details), (create_page_user_details),
 519         (create_page_outgoing):
 520         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 521         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 522         the UI spec, when the user tries to enter more than the max number of characters.
 523
 524 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 525
 526         * src/maemo/easysetup/modest-easysetup-wizard.c:
 527         (create_page_user_details), (create_page_custom_incoming),
 528         (create_page_custom_outgoing):
 529         * src/maemo/modest-account-settings-dialog.c:
 530         (create_page_user_details), (create_page_incoming),
 531         (create_page_outgoing):
 532         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 533         (modest_connection_specific_smtp_edit_window_init):
 534         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 535         not appropriate. Bad Maemo-specific defaults!.
 536
 537 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 538
 539         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 540         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 541         (modest_signature_editor_dialog_set_settings):
 542         Disable the label and textview when the checkbox is disabled, and use the
 543         specified (UI spec) default signature text.
 544
 545 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 546
 547         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 548         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 549
 550         * src/modest-defs.h:
 551         * src/modest-account-mgr-helpers.h:
 552         * src/modest-account-mgr-helpers.c:
 553         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 554
 555         * src/maemo/Makefile.am:
 556         * src/maemo/modest-signature-editor-dialog.c:
 557         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 558         as per the UI spec.
 559
 560         * src/maemo/modest-account-settings-dialog.h:
 561         * src/maemo/modest-account-settings-dialog.c:
 562         (modest_account_settings_dialog_finalize), (on_button_signature),
 563         (save_configuration): Use the new dialog when the Edit button is pressed, and
 564         save the changes if necessary, as per the UI spec.
 565
 566 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 567
 568         * src/maemo/Makefile.am:
 569         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 570         based on maemo-develoers email from Dirk.
 571
 572         * src/maemo/easysetup/modest-easysetup-wizard.c:
 573         (create_page_welcome), (create_page_account_details),
 574         (create_page_user_details), (create_page_complete_easysetup),
 575         (create_page_custom_incoming), (create_page_custom_outgoing),
 576         (create_page_complete_custom),
 577         (modest_easysetup_wizard_dialog_init):
 578         * src/maemo/modest-account-settings-dialog.c:
 579         (create_page_account_details), (create_page_user_details),
 580         (create_page_incoming), (create_page_outgoing),
 581         (modest_account_settings_dialog_init):
 582         * src/maemo/modest-connection-specific-smtp-window.c:
 583         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 584
 585 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 586
 587         * src/maemo/easysetup/modest-easysetup-wizard.c:
 588         (create_page_account_details), (create_page_custom_outgoing),
 589         (create_page_complete_custom):
 590         * src/maemo/modest-account-settings-dialog.c:
 591         (create_page_user_details), (create_page_incoming),
 592         (create_page_outgoing):
 593         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 594         (modest_connection_specific_smtp_edit_window_init):
 595         Use the correct (UI spec) port min/max, and use horizontal separators,
 596         as per the UI spec.
 597
 598 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 599
 600         * src/maemo/easysetup/modest-easysetup-wizard.c:
 601         (set_default_custom_servernames):
 602         * src/maemo/modest-account-settings-dialog.c:
 603         (create_page_incoming), (on_combo_outgoing_security_changed),
 604         (on_combo_incoming_security_changed), (create_page_outgoing),
 605         (modest_account_settings_dialog_set_account_name),
 606         (save_configuration):
 607         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 608         (on_combo_security_changed),
 609         (modest_connection_specific_smtp_edit_window_init),
 610         (modest_connection_specific_smtp_edit_window_set_connection),
 611         (modest_connection_specific_smtp_edit_window_get_settings):
 612         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 613         as per the UI spec.
 614
 615 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 616
 617         * po/en_GB.po:
 618         * src/maemo/easysetup/modest-easysetup-wizard.c:
 619         (create_page_custom_outgoing), (create_page_complete_custom):
 620         * src/maemo/modest-account-settings-dialog.c:
 621         (create_page_user_details), (create_page_outgoing):
 622         * src/maemo/modest-account-view-window.c: (button_box_new):
 623         Use changed logical IDs as per the most recent UI spec:
 624         mcen_bd_emailsetup_edit -> mcen_bd_edit
 625         mcen_bd_emailsetup_delete -> mcen_bd_delete
 626         mcen_bd_emailsetup_close -> mcen_bd_close
 627
 628 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 629
 630         * configure.ac:
 631         * src/Makefile.am:
 632         * src/dbus_api/Makefile.am:
 633         * src/dbus_api/modest-dbus-callbacks.c:
 634         * src/dbus_api/modest-dbus-callbacks.h:
 635         * src/maemo/modest-platform.c: (modest_platform_init):
 636         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 637         method.
 638         * tests/Makefile.am:
 639         * tests/dbus_api/Makefile.am:
 640         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 641
 642 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 643
 644         * src/maemo/modest-account-settings-dialog.c:
 645         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 646         Removed unnecessary includes.
 647
 648 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 649
 650         * src/maemo/easysetup/modest-easysetup-wizard.c:
 651         * src/maemo/modest-account-settings-dialog.c:
 652         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 653         * src/widgets/Makefile.am:
 654         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 655         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 656         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 657         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 658         * src/widgets/modest-secureauth-combo-box.c:
 659         * src/widgets/modest-secureauth-combo-box.h:
 660         * src/widgets/modest-serversecurity-combo-box.c:
 661         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 662         made the GObject names more consistent with the rest of the Modest code.
 663
 664 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 665
 666         * src/maemo/easysetup/Makefile.am:
 667         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 668         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 669         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 670         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 671         * src/maemo/easysetup/modest-easysetup-wizard.c:
 672         * src/maemo/easysetup/modest-validating-entry.c:
 673         * src/maemo/easysetup/modest-validating-entry.h:
 674         * src/maemo/modest-account-settings-dialog.c:
 675         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 676         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 677         widgets/ because they are used outside of easysetup too. After checking in,
 678         svn will allow me to rename them too.
 679
 680 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 681
 682         * src/gnome/modest-msg-edit-window.c:
 683         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 684         linker error, to fix the build on the GNOME platform.
 685         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 686         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 687         ifdefed out to avoid a warning.
 688
 689 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 690
 691         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 692         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 693         some alternative for GTK+ 2.6.
 694
 695 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 696
 697         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 698
 699         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 700         specified for EmailAccountsDialog in UI spec.
 701
 702         * src/maemo/easysetup/modest-easysetup-wizard.c:
 703         * src/maemo/easysetup/modest-easysetup-wizard.h:
 704         * src/maemo/modest-account-settings-dialog.c:
 705         * src/maemo/modest-account-settings-dialog.h:
 706         Reuse a member window widget for the connection-specific SMTP server accounts,
 707         so we can tell it to create/save the accounts only if we actually save changes.
 708
 709         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 710         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 711         (modest_connection_specific_smtp_edit_window_get_settings):
 712         Return a struct instance for temporarily remembering the entered data.
 713
 714         * src/maemo/modest-connection-specific-smtp-window.h:
 715         * src/maemo/modest-connection-specific-smtp-window.c:
 716         (modest_connection_specific_smtp_window_finalize),
 717         (modest_connection_specific_smtp_window_fill_with_connections),
 718         (on_button_edit),
 719         (modest_connection_specific_smtp_window_save_server_accounts),
 720         (update_model_server_names): Do not actually save data until asked,
 721         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 722
 723         (on_selection_changed),
 724         (modest_connection_specific_smtp_window_init): Disable the edit
 725         button when nothing is selected.
 726
 727         * src/modest-account-mgr-helpers.c:
 728         * src/modest-account-mgr-helpers.h:
 729         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 730         elsewhere.
 731
 732 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 733
 734         * src/modest-account-mgr-helpers.h:
 735         * src/modest-account-mgr-helpers.c:
 736         (modest_account_mgr_get_unused_account_name),
 737         (modest_account_mgr_get_unused_account_display_name): Added these
 738         utility functions, to avoid code duplication.
 739
 740         * src/maemo/easysetup/modest-easysetup-wizard.c:
 741         (create_page_account_details), (create_account):
 742         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 743         (on_combo_security_changed),
 744         (modest_connection_specific_smtp_edit_window_init),
 745         (modest_connection_specific_smtp_edit_window_save_settings):
 746         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 747         * src/maemo/modest-connection-specific-smtp-window.c:
 748         (modest_connection_specific_smtp_window_finalize),
 749         (modest_connection_specific_smtp_window_fill_with_connections),
 750         (on_button_edit), (modest_connection_specific_smtp_window_init):
 751         * src/maemo/modest-connection-specific-smtp-window.h:
 752         Implementing saving of connection-specific server accounts.
 753
 754         But I need to refactor this so we can save the data for each
 755         possible connection-specific account and only actually create the server accounts
 756         when the easysetup finished, or the OK button is pressed on the account settings
 757         dialog.
 758
 759 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 760
 761         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 762         (on_combo_security_changed):
 763         (modest_connection_specific_smtp_edit_window_init):
 764         Auto-fill the port number as in the account settings.
 765
 766         (modest_connection_specific_smtp_edit_window_set_connection):
 767         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 768         * src/maemo/modest-connection-specific-smtp-window.c:
 769         (fill_with_connections), (on_button_edit),
 770         (modest_connection_specific_smtp_window_init):
 771         Turn the edit window into a dialog to simplify the code, and
 772         set a WM hint as in a GtkDialog, because only a popup can be on top of
 773         another window in Maemo, and popups usually have no WM decoration.
 774
 775         * src/modest-defs.h:
 776         * src/modest-account-mgr-helpers.c:
 777         (modest_account_mgr_set_connection_specific_smtp),
 778         (modest_account_mgr_remove_connection_specific_smtp),
 779         (modest_account_mgr_get_connection_specific_smtp):
 780         * src/modest-account-mgr-helpers.h: Some functions to write the
 781         connection-specific SMTP server information. Not yet used.
 782
 783
 784         * src/widgets/modest-folder-view.c: (text_cell_data):
 785         Fix a warning about an uninitialized variable.
 786         (on_configuration_key_changed): Put an #ifdef around the use
 787         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 788
 789 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 790
 791         * src/maemo/modest-account-settings-dialog.h:
 792         * src/maemo/modest-account-settings-dialog.c:
 793         Added connect_for_modified() utility function to mark the new modified boolean.
 794
 795         (create_page_account_details), (create_page_user_details),
 796         (create_page_incoming), (create_page_outgoing), (on_response),
 797         (modest_account_settings_dialog_init),
 798         (modest_account_settings_dialog_set_account_name):
 799         Only warn about unsaved changes when there are actually unsaved changes.
 800
 801         * src/modest-account-mgr-helpers.c:
 802         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 803         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 804         to get the data from there in future.
 805
 806 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 807
 808         * src/modest-defs.h:
 809
 810         * src/modest-account-mgr-helpers.h:
 811         * src/modest-account-mgr-helpers.c:
 812         Store the security account setting in a single conf key instead of using
 813         the options list, so that the list is left for just the to-be-removed camel hack,
 814         and because gconf_client_set_list() is failing for some reason.
 815
 816         * src/modest-account-mgr.c:
 817         (modest_account_mgr_add_server_account):
 818         * src/maemo/modest-account-settings-dialog.c:
 819         (modest_account_settings_dialog_set_account_name),
 820         (save_configuration): Use the renamed functions.
 821
 822
 823 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 824
 825         * src/widgets/Makefile.am:
 826         * src/widgets/modest-limit-retrieve-combo-box.c:
 827         * src/widgets/modest-limit-retrieve-combo-box.h:
 828         * src/widgets/modest-retrieve-combo-box.c:
 829         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 830         the account settings dialog.
 831
 832         * src/modest-defs.h:
 833         * src/modest-account-mgr-helpers.h:
 834         * src/modest-account-mgr-helpers.c:
 835         (modest_server_account_get_option_secure_auth),
 836         (modest_server_account_set_option_secure_auth):
 837         * src/modest-account-mgr.c:
 838         (modest_account_mgr_add_server_account):
 839         Use the existing AUTH_MECH conf key for the secure-auth setting,
 840         instead of putting it in the list options, because this was actually used already.
 841
 842         * src/maemo/modest-account-settings-dialog.c:
 843         (create_page_account_details),
 844         (modest_account_settings_dialog_set_account_name),
 845         (save_configuration):
 846         * src/maemo/modest-account-settings-dialog.h:
 847         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 848         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 849
 850 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 851
 852         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 853         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 854         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 855
 856         * src/modest-defs.h:
 857         * src/maemo/modest-account-settings-dialog.c:
 858         (create_page_incoming), (on_combo_outgoing_security_changed),
 859         (on_combo_incoming_security_changed), (create_page_outgoing),
 860         (modest_account_settings_dialog_set_account_name),
 861         (save_configuration): Load/Save the port number, and change it when the
 862         security combo changes, to suitable defaults.
 863
 864 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 865
 866         * src/modest-account-mgr.c:
 867         (modest_account_mgr_add_server_account): Set the security and secure-auth
 868         options, and add a comment saying that the other camel-specific options should be
 869         removed in future.
 870
 871 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 872
 873         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 874         found by valgrind.
 875         * src/modest-tny-account-store.c: (account_list_free),
 876         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 877         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 878         easy to fix.
 879
 880 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 881
 882         * src/modest-protocol-info.c:
 883         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 884         is required by our UI spec. Maybe something in our implementation will use this eventually.
 885         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 886         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 887         instead of the previous 0 placeholder.
 888
 889         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 890         secure-auth settings.
 891         * src/modest-account-mgr-helpers.h:
 892         * src/modest-account-mgr-helpers.c:
 893         (modest_server_account_data_get_option_secure_auth),
 894         (modest_server_account_set_option_secure_auth),
 895         (modest_server_account_data_get_option_security),
 896         (modest_server_account_set_option_security): Added this API for getting and setting the security
 897         and secure-auth settings.
 898
 899         * src/maemo/modest-account-settings-dialog.h:
 900         * src/maemo/modest-account-settings-dialog.c:
 901         (modest_account_settings_dialog_finalize), (check_data),
 902         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 903         about changing titles.
 904         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 905         (save_configuration): Save the security and secure-auth settings.
 906
 907         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 908         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 909
 910 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 911
 912         * src/modest-defs.h:
 913         * src/modest-account-mgr.c:
 914         (modest_account_mgr_add_server_account):
 915         Added and used defines for the options key and value pair strings,
 916         that are used so far, though they do not seem to correspond to anything in our
 917         UI specs or ModestProtocol enum.
 918
 919         * src/modest-account-mgr-helpers.h:
 920         * src/modest-account-mgr-helpers.c:
 921         (compare_option_strings_for_name),
 922         (modest_server_account_data_get_option_value),
 923         (modest_server_account_data_get_option_bool),
 924         (modest_account_mgr_get_server_account_option):
 925         Added helper functions for parsing the options GSList.
 926
 927 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 928
 929         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 930         display name is based on the supplied account name.
 931         * src/modest-account-mgr.c:
 932         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 933         with an inefficient, but good-enough, implementation.
 934
 935         * src/maemo/easysetup/modest-easysetup-wizard.c:
 936         (create_page_account_details), (on_before_next), (create_account):
 937         Check for existing display names rather than (non-user-visible) account names, and just
 938         create and set a unique account name at the end.
 939
 940         * src/maemo/modest-account-settings-dialog.c:
 941         (modest_account_settings_dialog_init),
 942         (modest_account_settings_dialog_set_account_name),
 943         (create_page_incoming): Show the display name, instead of the account name.
 944         (on_response): Do some (not all) extra checks, as in the UI spec.
 945         (save_configuration): Save the display name if it was changed.
 946
 947 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 948
 949         * po/en_GB.po: Added needed logical ID and translation.
 950         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 951         (init_view): Made the is-default column clicking work.
 952
 953 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 954
 955         * configure.ac:
 956         * src/maemo/easysetup/Makefile.am:
 957         * src/maemo/easysetup/modest-easysetup-wizard.c:
 958         (modest_easysetup_wizard_dialog_init):
 959         * src/maemo/easysetup/provider-data-test.keyfile:
 960         * src/maemo/easysetup/provider-data.keyfile:
 961         Moved the provider data file to the new modest-providers-data package and used it from there.
 962
 963 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 964
 965         * src/modest-local-folder-info.c:
 966         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 967         N_() was already used on the static strings, but this just marks it for translation without
 968         using the translation.
 969
 970 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 971
 972         * src/maemo/modest-account-settings-dialog.c:
 973         (create_page_incoming),
 974         (modest_account_settings_dialog_set_account_name):
 975         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 976         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 977         I will do this if nobody else gets there first.
 978
 979 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 980
 981         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 982         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 983         save the security stuff.
 984
 985 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 986
 987         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 988         Set the email address and user fullname, which I now see must be
 989         done separately.
 990
 991         * src/maemo/modest-account-settings-dialog.h:
 992         * src/maemo/modest-account-settings-dialog.c:
 993          (on_response),
 994         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 995         leave-on-server and authentication.
 996         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 997         how to do the rest.
 998
 999 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1000
1001
1002         * src/maemo/modest-account-settings-dialog.c:
1003         * src/maemo/modest-account-settings-dialog.h:
1004         Most (but not all) of the widgets are now present as specified by the UI spec.
1005         No changes are yet saved, and some details are not properly shown yet.
1006
1007         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1008
1009 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1010
1011         * src/maemo/Makefile.am:
1012         * src/maemo/modest-account-settings-dialog.c:
1013         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1014         an existing account. Doesn't do much yet.
1015
1016         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1017         Open the accounts settings dialog when Edit is clicked.
1018
1019 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1020
1021         * src/maemo/easysetup/Makefile.am:
1022         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1023         (load_from_file):
1024         * src/maemo/easysetup/modest-easysetup-wizard.c:
1025         (modest_easysetup_wizard_dialog_init):
1026         Try to get the source directory from the build system,
1027         instead of hard-coding "./" into the source code, when opening our local
1028         copies of the configuration files.
1029         But this still fails when opening the wizard from the Accounts window,
1030         maybe because the working directory seems to change at runtime.
1031         So the wizard will fail the second time unless you copy the files into their
1032         proper locations - see the stdout warnings for the paths.
1033
1034         (create_page_account_details),(on_before_next):
1035         Check for existing non-server accounts instead of server accounts,
1036         so the default account name is useful again, and to prevent trying to
1037         recreate accounts.
1038
1039         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1040         Show the wizard when New is clicked.
1041
1042         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1043         (init_view): Show the column headers, and show the columns that are
1044         specified in the UI specs. However, something in Maemo's GTK+ prevents
1045         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1046         change the default account. This is despite unsetting the special properties.
1047
1048 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1049
1050         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1051         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1052         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1053         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1054         to make that clearer.
1055         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1056
1057 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1058
1059         * src/maemo/modest-account-view-window.c:
1060         (modest_account_view_window_init),
1061         (modest_account_view_window_new):
1062         Use the same buttons as specified in the
1063         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1064         the existing widgets, which never had a chance of working.
1065         Put the ModestAccountView treeview in a scrolled window.
1066         Do not repeat the initialization in both _init() and _new().
1067
1068         * src/widgets/modest-account-view.c: (update_account_view):
1069         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1070         this widget and window shows no accounts.
1071
1072         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1073
1074 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1075
1076         * src/maemo/easysetup/modest-easysetup-wizard.c:
1077         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1078         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1079         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1080         which seems wrong.
1081
1082         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1083         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1084         accounts exist yet, as in the UI spec.
1085
1086         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1087
1088 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1089
1090         * src/maemo/Makefile.am:
1091         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1092         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1093         New window for editing connection-specific smtp details.
1094         Not fully implemented.
1095
1096         * src/maemo/modest-connection-specific-smtp-window.c:
1097         (modest_connection_specific_smtp_window_finalize) :
1098         unref the tree model.
1099         (on_button_edit): Show the edit window.
1100
1101 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1102
1103         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1104         error for me.
1105
1106         * src/maemo/Makefile.am:
1107         * src/maemo/modest-connection-specific-smtp-window.c:
1108         * src/maemo/modest-connection-specific-smtp-window.h:
1109         New window for showing the list of connections, for connection-specific
1110         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1111         * src/maemo/easysetup/modest-easysetup-wizard.c:
1112         (create_page_custom_outgoing): Show the new window when the button is clicked.
1113
1114 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1115
1116         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1117         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1118         * src/maemo/modest-msg-edit-window.c:
1119         (modest_msg_edit_window_insert_image):
1120         * src/modest-conf.c: (modest_conf_key_escape):
1121         * src/modest-mail-operation.c:
1122         (modest_mail_operation_send_new_mail):
1123         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1124         (modest_ui_actions_on_new_account):
1125         * src/widgets/modest-attachment-view.c: (update_filename_request):
1126         * src/widgets/modest-mail-header-view.c:
1127         Corrected warnings that were breaking the build, by commenting out unused variables,
1128         and a function, and by including a header.
1129
1130 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1131
1132         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1133         so we can #ifdef around platform-specific code when necessary.
1134         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1135         to allow this to build for the GNOME platform too.
1136
1137 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1138
1139         * src/maemo/easysetup/modest-easysetup-wizard.c:
1140         Added util_increment_name() and used it in create_page_account_details()
1141         to make sure that the default account name is always a new name.
1142
1143         (modest_easysetup_wizard_dialog_init),
1144         (set_default_custom_servernames): Some minor memory management fixes.
1145
1146 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1147
1148         * Makefile.am:
1149         * configure.ac:
1150         * src/modest-runtime.c: (init_i18n): Restored the translation
1151         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1152         are defined in config.h, and the translations are installed.
1153
1154         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1155         is defined for translation.
1156
1157 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1158
1159         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1160         (load_from_file):
1161         * src/maemo/easysetup/modest-easysetup-wizard.c:
1162         (modest_easysetup_wizard_dialog_init):
1163         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1164         Use realistic paths (though they should use $prefix generically) to the
1165         mcc_mapping and provider-data.keyfile files which might work when they
1166         are installed by the future version of the operator-wizard package,
1167         and then fallback to paths in our source code, with an explanatory
1168         warning.
1169
1170 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1171
1172         * configure.ac:
1173         * src/Makefile.am:
1174         * src/maemo/Makefile.am:
1175         * src/maemo/easysetup/: Added files from the previously-exernal
1176         osso-modest-easysetup.
1177         * src/maemo/modest-main-window-ui.h:
1178         * src/modest-ui-actions.c:
1179         * src/modest-ui-actions.h:
1180         Added modest_ui_actions_on_new_account() as a signal handler for the
1181         New Account menu item. It shows the easysetup wizard.
1182         * po/en_GB.po: Added additional needed logical IDs and translations.
1183
1184 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1185 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1186