1 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c:
4 * src/maemo/modest-account-settings-dialog.c:
5 * src/maemo/modest-connection-specific-smtp-edit-window.c:
6 * src/widgets/Makefile.am:
7 * src/widgets/modest-easysetup-secureauth-combo-box.c:
8 * src/widgets/modest-easysetup-secureauth-combo-box.h:
9 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
10 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
11 * src/widgets/modest-secureauth-combo-box.c:
12 * src/widgets/modest-secureauth-combo-box.h:
13 * src/widgets/modest-serversecurity-combo-box.c:
14 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
15 made the GObject names more consistent with the rest of the Modest code.
17 2007-04-20 Murray Cumming <murrayc@murrayc.com>
19 * src/maemo/easysetup/Makefile.am:
20 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
21 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
22 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
23 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
24 * src/maemo/easysetup/modest-easysetup-wizard.c:
25 * src/maemo/easysetup/modest-validating-entry.c:
26 * src/maemo/easysetup/modest-validating-entry.h:
27 * src/maemo/modest-account-settings-dialog.c:
28 * src/maemo/modest-connection-specific-smtp-edit-window.c:
29 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
30 widgets/ because they are used outside of easysetup too. After checking in,
31 svn will allow me to rename them too.
33 2007-04-20 Murray Cumming <murrayc@murrayc.com>
35 * src/gnome/modest-msg-edit-window.c:
36 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
37 linker error, to fix the build on the GNOME platform.
38 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
39 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
40 ifdefed out to avoid a warning.
42 2007-04-20 Murray Cumming <murrayc@murrayc.com>
44 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
45 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
46 some alternative for GTK+ 2.6.
48 2007-04-19 Murray Cumming <murrayc@murrayc.com>
50 * src/maemo/modest-address-book.c: Added include to avoid a warning.
52 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
53 specified for EmailAccountsDialog in UI spec.
55 * src/maemo/easysetup/modest-easysetup-wizard.c:
56 * src/maemo/easysetup/modest-easysetup-wizard.h:
57 * src/maemo/modest-account-settings-dialog.c:
58 * src/maemo/modest-account-settings-dialog.h:
59 Reuse a member window widget for the connection-specific SMTP server accounts,
60 so we can tell it to create/save the accounts only if we actually save changes.
62 * src/maemo/modest-connection-specific-smtp-edit-window.h:
63 * src/maemo/modest-connection-specific-smtp-edit-window.c:
64 (modest_connection_specific_smtp_edit_window_get_settings):
65 Return a struct instance for temporarily remembering the entered data.
67 * src/maemo/modest-connection-specific-smtp-window.h:
68 * src/maemo/modest-connection-specific-smtp-window.c:
69 (modest_connection_specific_smtp_window_finalize),
70 (modest_connection_specific_smtp_window_fill_with_connections),
72 (modest_connection_specific_smtp_window_save_server_accounts),
73 (update_model_server_names): Do not actually save data until asked,
74 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
76 (on_selection_changed),
77 (modest_connection_specific_smtp_window_init): Disable the edit
78 button when nothing is selected.
80 * src/modest-account-mgr-helpers.c:
81 * src/modest-account-mgr-helpers.h:
82 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
85 2007-04-19 Murray Cumming <murrayc@murrayc.com>
87 * src/modest-account-mgr-helpers.h:
88 * src/modest-account-mgr-helpers.c:
89 (modest_account_mgr_get_unused_account_name),
90 (modest_account_mgr_get_unused_account_display_name): Added these
91 utility functions, to avoid code duplication.
93 * src/maemo/easysetup/modest-easysetup-wizard.c:
94 (create_page_account_details), (create_account):
95 * src/maemo/modest-connection-specific-smtp-edit-window.c:
96 (on_combo_security_changed),
97 (modest_connection_specific_smtp_edit_window_init),
98 (modest_connection_specific_smtp_edit_window_save_settings):
99 * src/maemo/modest-connection-specific-smtp-edit-window.h:
100 * src/maemo/modest-connection-specific-smtp-window.c:
101 (modest_connection_specific_smtp_window_finalize),
102 (modest_connection_specific_smtp_window_fill_with_connections),
103 (on_button_edit), (modest_connection_specific_smtp_window_init):
104 * src/maemo/modest-connection-specific-smtp-window.h:
105 Implementing saving of connection-specific server accounts.
107 But I need to refactor this so we can save the data for each
108 possible connection-specific account and only actually create the server accounts
109 when the easysetup finished, or the OK button is pressed on the account settings
112 2007-04-18 Murray Cumming <murrayc@murrayc.com>
114 * src/maemo/modest-connection-specific-smtp-edit-window.c:
115 (on_combo_security_changed):
116 (modest_connection_specific_smtp_edit_window_init):
117 Auto-fill the port number as in the account settings.
119 (modest_connection_specific_smtp_edit_window_set_connection):
120 * src/maemo/modest-connection-specific-smtp-edit-window.h:
121 * src/maemo/modest-connection-specific-smtp-window.c:
122 (fill_with_connections), (on_button_edit),
123 (modest_connection_specific_smtp_window_init):
124 Turn the edit window into a dialog to simplify the code, and
125 set a WM hint as in a GtkDialog, because only a popup can be on top of
126 another window in Maemo, and popups usually have no WM decoration.
129 * src/modest-account-mgr-helpers.c:
130 (modest_account_mgr_set_connection_specific_smtp),
131 (modest_account_mgr_remove_connection_specific_smtp),
132 (modest_account_mgr_get_connection_specific_smtp):
133 * src/modest-account-mgr-helpers.h: Some functions to write the
134 connection-specific SMTP server information. Not yet used.
137 * src/widgets/modest-folder-view.c: (text_cell_data):
138 Fix a warning about an uninitialized variable.
139 (on_configuration_key_changed): Put an #ifdef around the use
140 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
142 2007-04-18 Murray Cumming <murrayc@murrayc.com>
144 * src/maemo/modest-account-settings-dialog.h:
145 * src/maemo/modest-account-settings-dialog.c:
146 Added connect_for_modified() utility function to mark the new modified boolean.
148 (create_page_account_details), (create_page_user_details),
149 (create_page_incoming), (create_page_outgoing), (on_response),
150 (modest_account_settings_dialog_init),
151 (modest_account_settings_dialog_set_account_name):
152 Only warn about unsaved changes when there are actually unsaved changes.
154 * src/modest-account-mgr-helpers.c:
155 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
156 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
157 to get the data from there in future.
159 2007-04-18 Murray Cumming <murrayc@murrayc.com>
163 * src/modest-account-mgr-helpers.h:
164 * src/modest-account-mgr-helpers.c:
165 Store the security account setting in a single conf key instead of using
166 the options list, so that the list is left for just the to-be-removed camel hack,
167 and because gconf_client_set_list() is failing for some reason.
169 * src/modest-account-mgr.c:
170 (modest_account_mgr_add_server_account):
171 * src/maemo/modest-account-settings-dialog.c:
172 (modest_account_settings_dialog_set_account_name),
173 (save_configuration): Use the renamed functions.
176 2007-04-18 Murray Cumming <murrayc@murrayc.com>
178 * src/widgets/Makefile.am:
179 * src/widgets/modest-limit-retrieve-combo-box.c:
180 * src/widgets/modest-limit-retrieve-combo-box.h:
181 * src/widgets/modest-retrieve-combo-box.c:
182 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
183 the account settings dialog.
186 * src/modest-account-mgr-helpers.h:
187 * src/modest-account-mgr-helpers.c:
188 (modest_server_account_get_option_secure_auth),
189 (modest_server_account_set_option_secure_auth):
190 * src/modest-account-mgr.c:
191 (modest_account_mgr_add_server_account):
192 Use the existing AUTH_MECH conf key for the secure-auth setting,
193 instead of putting it in the list options, because this was actually used already.
195 * src/maemo/modest-account-settings-dialog.c:
196 (create_page_account_details),
197 (modest_account_settings_dialog_set_account_name),
198 (save_configuration):
199 * src/maemo/modest-account-settings-dialog.h:
200 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
201 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
203 2007-04-18 Murray Cumming <murrayc@murrayc.com>
205 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
206 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
207 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
210 * src/maemo/modest-account-settings-dialog.c:
211 (create_page_incoming), (on_combo_outgoing_security_changed),
212 (on_combo_incoming_security_changed), (create_page_outgoing),
213 (modest_account_settings_dialog_set_account_name),
214 (save_configuration): Load/Save the port number, and change it when the
215 security combo changes, to suitable defaults.
217 2007-04-17 Murray Cumming <murrayc@murrayc.com>
219 * src/modest-account-mgr.c:
220 (modest_account_mgr_add_server_account): Set the security and secure-auth
221 options, and add a comment saying that the other camel-specific options should be
224 2007-04-17 Murray Cumming <murrayc@murrayc.com>
226 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
228 * src/modest-tny-account-store.c: (account_list_free),
229 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
230 cursor->data after unreffing it. But there is some strange stuff there so it might not be
233 2007-04-17 Murray Cumming <murrayc@murrayc.com>
235 * src/modest-protocol-info.c:
236 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
237 is required by our UI spec. Maybe something in our implementation will use this eventually.
238 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
239 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
240 instead of the previous 0 placeholder.
242 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
243 secure-auth settings.
244 * src/modest-account-mgr-helpers.h:
245 * src/modest-account-mgr-helpers.c:
246 (modest_server_account_data_get_option_secure_auth),
247 (modest_server_account_set_option_secure_auth),
248 (modest_server_account_data_get_option_security),
249 (modest_server_account_set_option_security): Added this API for getting and setting the security
250 and secure-auth settings.
252 * src/maemo/modest-account-settings-dialog.h:
253 * src/maemo/modest-account-settings-dialog.c:
254 (modest_account_settings_dialog_finalize), (check_data),
255 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
256 about changing titles.
257 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
258 (save_configuration): Save the security and secure-auth settings.
260 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
261 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
263 2007-04-17 Murray Cumming <murrayc@murrayc.com>
266 * src/modest-account-mgr.c:
267 (modest_account_mgr_add_server_account):
268 Added and used defines for the options key and value pair strings,
269 that are used so far, though they do not seem to correspond to anything in our
270 UI specs or ModestProtocol enum.
272 * src/modest-account-mgr-helpers.h:
273 * src/modest-account-mgr-helpers.c:
274 (compare_option_strings_for_name),
275 (modest_server_account_data_get_option_value),
276 (modest_server_account_data_get_option_bool),
277 (modest_account_mgr_get_server_account_option):
278 Added helper functions for parsing the options GSList.
280 2007-04-16 Murray Cumming <murrayc@murrayc.com>
282 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
283 display name is based on the supplied account name.
284 * src/modest-account-mgr.c:
285 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
286 with an inefficient, but good-enough, implementation.
288 * src/maemo/easysetup/modest-easysetup-wizard.c:
289 (create_page_account_details), (on_before_next), (create_account):
290 Check for existing display names rather than (non-user-visible) account names, and just
291 create and set a unique account name at the end.
293 * src/maemo/modest-account-settings-dialog.c:
294 (modest_account_settings_dialog_init),
295 (modest_account_settings_dialog_set_account_name),
296 (create_page_incoming): Show the display name, instead of the account name.
297 (on_response): Do some (not all) extra checks, as in the UI spec.
298 (save_configuration): Save the display name if it was changed.
300 2007-04-16 Murray Cumming <murrayc@murrayc.com>
302 * po/en_GB.po: Added needed logical ID and translation.
303 * src/widgets/modest-account-view.c: (on_account_default_toggled),
304 (init_view): Made the is-default column clicking work.
306 2007-04-16 Murray Cumming <murrayc@murrayc.com>
309 * src/maemo/easysetup/Makefile.am:
310 * src/maemo/easysetup/modest-easysetup-wizard.c:
311 (modest_easysetup_wizard_dialog_init):
312 * src/maemo/easysetup/provider-data-test.keyfile:
313 * src/maemo/easysetup/provider-data.keyfile:
314 Moved the provider data file to the new modest-providers-data package and used it from there.
316 2007-04-16 Murray Cumming <murrayc@murrayc.com>
318 * src/modest-local-folder-info.c:
319 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
320 N_() was already used on the static strings, but this just marks it for translation without
321 using the translation.
323 2007-04-06 Murray Cumming <murrayc@murrayc.com>
325 * src/maemo/modest-account-settings-dialog.c:
326 (create_page_incoming),
327 (modest_account_settings_dialog_set_account_name):
328 Added comments about the need for new API in ModestAccountMgr to handle the authentication
329 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
330 I will do this if nobody else gets there first.
332 2007-04-06 Murray Cumming <murrayc@murrayc.com>
334 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
335 Saved much of the incoming and outgoing data too, though I cannot yet see how to
336 save the security stuff.
338 2007-04-06 Murray Cumming <murrayc@murrayc.com>
340 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
341 Set the email address and user fullname, which I now see must be
344 * src/maemo/modest-account-settings-dialog.h:
345 * src/maemo/modest-account-settings-dialog.c:
347 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
348 leave-on-server and authentication.
349 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
352 2007-04-06 Murray Cumming <murrayc@murrayc.com>
355 * src/maemo/modest-account-settings-dialog.c:
356 * src/maemo/modest-account-settings-dialog.h:
357 Most (but not all) of the widgets are now present as specified by the UI spec.
358 No changes are yet saved, and some details are not properly shown yet.
360 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
362 2007-04-06 Murray Cumming <murrayc@murrayc.com>
364 * src/maemo/Makefile.am:
365 * src/maemo/modest-account-settings-dialog.c:
366 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
367 an existing account. Doesn't do much yet.
369 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
370 Open the accounts settings dialog when Edit is clicked.
372 2007-04-05 Murray Cumming <murrayc@murrayc.com>
374 * src/maemo/easysetup/Makefile.am:
375 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
377 * src/maemo/easysetup/modest-easysetup-wizard.c:
378 (modest_easysetup_wizard_dialog_init):
379 Try to get the source directory from the build system,
380 instead of hard-coding "./" into the source code, when opening our local
381 copies of the configuration files.
382 But this still fails when opening the wizard from the Accounts window,
383 maybe because the working directory seems to change at runtime.
384 So the wizard will fail the second time unless you copy the files into their
385 proper locations - see the stdout warnings for the paths.
387 (create_page_account_details),(on_before_next):
388 Check for existing non-server accounts instead of server accounts,
389 so the default account name is useful again, and to prevent trying to
392 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
393 Show the wizard when New is clicked.
395 * src/widgets/modest-account-view.c: (on_account_default_toggled),
396 (init_view): Show the column headers, and show the columns that are
397 specified in the UI specs. However, something in Maemo's GTK+ prevents
398 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
399 change the default account. This is despite unsetting the special properties.
401 2007-04-05 Murray Cumming <murrayc@murrayc.com>
403 * docs/reference/modest-design.sgml: Corrected spelling mistake.
404 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
405 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
406 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
407 to make that clearer.
408 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
410 2007-04-05 Murray Cumming <murrayc@murrayc.com>
412 * src/maemo/modest-account-view-window.c:
413 (modest_account_view_window_init),
414 (modest_account_view_window_new):
415 Use the same buttons as specified in the
416 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
417 the existing widgets, which never had a chance of working.
418 Put the ModestAccountView treeview in a scrolled window.
419 Do not repeat the initialization in both _init() and _new().
421 * src/widgets/modest-account-view.c: (update_account_view):
422 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
423 this widget and window shows no accounts.
425 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
427 2007-04-05 Murray Cumming <murrayc@murrayc.com>
429 * src/maemo/easysetup/modest-easysetup-wizard.c:
430 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
431 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
432 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
435 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
436 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
437 accounts exist yet, as in the UI spec.
439 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
441 2007-04-05 Murray Cumming <murrayc@murrayc.com>
443 * src/maemo/Makefile.am:
444 * src/maemo/modest-connection-specific-smtp-edit-window.c:
445 * src/maemo/modest-connection-specific-smtp-edit-window.h:
446 New window for editing connection-specific smtp details.
447 Not fully implemented.
449 * src/maemo/modest-connection-specific-smtp-window.c:
450 (modest_connection_specific_smtp_window_finalize) :
451 unref the tree model.
452 (on_button_edit): Show the edit window.
454 2007-04-05 Murray Cumming <murrayc@murrayc.com>
456 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
459 * src/maemo/Makefile.am:
460 * src/maemo/modest-connection-specific-smtp-window.c:
461 * src/maemo/modest-connection-specific-smtp-window.h:
462 New window for showing the list of connections, for connection-specific
463 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
464 * src/maemo/easysetup/modest-easysetup-wizard.c:
465 (create_page_custom_outgoing): Show the new window when the button is clicked.
467 2007-04-04 Murray Cumming <murrayc@murrayc.com>
469 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
470 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
471 * src/maemo/modest-msg-edit-window.c:
472 (modest_msg_edit_window_insert_image):
473 * src/modest-conf.c: (modest_conf_key_escape):
474 * src/modest-mail-operation.c:
475 (modest_mail_operation_send_new_mail):
476 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
477 (modest_ui_actions_on_new_account):
478 * src/widgets/modest-attachment-view.c: (update_filename_request):
479 * src/widgets/modest-mail-header-view.c:
480 Corrected warnings that were breaking the build, by commenting out unused variables,
481 and a function, and by including a header.
483 2007-04-04 Murray Cumming <murrayc@murrayc.com>
485 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
486 so we can #ifdef around platform-specific code when necessary.
487 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
488 to allow this to build for the GNOME platform too.
490 2007-04-04 Murray Cumming <murrayc@murrayc.com>
492 * src/maemo/easysetup/modest-easysetup-wizard.c:
493 Added util_increment_name() and used it in create_page_account_details()
494 to make sure that the default account name is always a new name.
496 (modest_easysetup_wizard_dialog_init),
497 (set_default_custom_servernames): Some minor memory management fixes.
499 2007-04-04 Murray Cumming <murrayc@murrayc.com>
503 * src/modest-runtime.c: (init_i18n): Restored the translation
504 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
505 are defined in config.h, and the translations are installed.
507 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
508 is defined for translation.
510 2007-04-03 Murray Cumming <murrayc@murrayc.com>
512 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
514 * src/maemo/easysetup/modest-easysetup-wizard.c:
515 (modest_easysetup_wizard_dialog_init):
516 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
517 Use realistic paths (though they should use $prefix generically) to the
518 mcc_mapping and provider-data.keyfile files which might work when they
519 are installed by the future version of the operator-wizard package,
520 and then fallback to paths in our source code, with an explanatory
523 2007-04-03 Murray Cumming <murrayc@murrayc.com>
527 * src/maemo/Makefile.am:
528 * src/maemo/easysetup/: Added files from the previously-exernal
529 osso-modest-easysetup.
530 * src/maemo/modest-main-window-ui.h:
531 * src/modest-ui-actions.c:
532 * src/modest-ui-actions.h:
533 Added modest_ui_actions_on_new_account() as a signal handler for the
534 New Account menu item. It shows the easysetup wizard.
535 * po/en_GB.po: Added additional needed logical IDs and translations.
537 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
538 Apparently ChangeLog is not used for some vague Nokia legal reasons.