1 2007-06-11 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-ui-actions.c:
4 (modest_ui_actions_on_password_requested): Check that the server name
5 is not NULL, because I just saw a password dialog with (null) as the
8 * src/modest-tny-folder.[h|c]: Added
9 modest_tny_folder_is_memory_card_folder().
10 * src/modest-ui-dimming-rules.c:
11 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
12 menu item for memory cards, as per the UI spec (section 7.4). This should
13 fix projects.maemo.org bug NB#59297.
15 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
17 * src/maemo/modest-main-window.c: (sync_accounts_cb):
18 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
19 is another problem with the code, see Murray's comment at line 772)
21 2007-06-08 Murray Cumming <murrayc@murrayc.com>
23 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
24 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
25 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
26 (load_from_file), (easysetup_country_combo_box_init),
27 (easysetup_country_combo_box_get_active_country_ids),
28 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
29 instead of just one ID, to avoid duplicate country names in the UI.
31 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
32 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
33 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
34 a single ID, avoiding duplicate providers.
35 * src/maemo/easysetup/modest-easysetup-wizard.c:
36 (on_combo_account_country): Adapt to use a list.
38 2007-06-08 Murray Cumming <murrayc@murrayc.com>
40 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
41 keys changed in the last X seconds.
43 * src/modest-account-mgr.h:
44 * src/modest-account-mgr.c: (on_timeout_notify_changes),
45 (on_key_change), (modest_account_mgr_class_init),
46 (modest_account_mgr_init), (modest_account_mgr_finalize):
47 As the keys are changed, save them in a GSList* and signal that GSList*
48 further every X seconds, to batch changes, to allow us to do just one
49 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
50 bug NB#56941 and other (UI-blocking) delays when changing account settings.
52 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
53 changed signal signature.
55 * src/modest-conf.c: (modest_conf_set_list),
56 (modest_conf_on_change): Reenable notification.
58 (modest_conf_maemo_fake_on_change): Comment out the hack that
59 notified immediately instead of asynchronously.
61 * src/widgets/modest-account-view.h:
62 * src/widgets/modest-account-view.c:
63 (update_account_view): Select the previously-selected account ID,
64 if possible. This fixes projects.maemo.org bug NB#56933.
66 (on_account_changed), (on_account_removed),
67 (modest_account_view_select_account):
69 Remove the block/unblock functions
70 because they were not useful.
72 * src/maemo/modest-account-view-window.c:
73 (on_delete_button_clicked), (on_edit_button_clicked),
74 (on_new_button_clicked): Remove the use of the non-working block/unblock.
76 2007-06-08 Murray Cumming <murrayc@murrayc.com>
78 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
79 Improve the error dialog to show Incorrect Account Settings, which seems
80 clearer, and say that the internal error message (to be removed from the
81 dialog later) is often misleading.
82 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
84 * src/modest-tny-account.c:
85 (modest_tny_account_new_from_server_account): Uncomment the printf of the
86 URL because this is so useful for debugging on the device.
88 * src/widgets/modest-serversecurity-combo-box.c:
89 (modest_serversecurity_combo_box_fill): Correct a logical ID.
91 2007-06-08 Murray Cumming <murrayc@murrayc.com>
93 * src/modest-mail-operation.c:
94 (modest_mail_operation_send_new_mail):
95 Added a comment about a nasty but apparently harmless message. Details
96 added to the wiki g_warnings() page.
98 2007-06-08 Murray Cumming <murrayc@murrayc.com>
100 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
101 (modest_tny_send_queue_class_init):
102 Do not use the priv struct because it is empty, to avoid g_warnings
103 about a non-existant priv struct.
105 * src/modest-tny-account-store.c:
106 (modest_tny_account_store_get_server_account),
107 (modest_tny_account_store_get_transport_account_for_open_connection
108 ): Do not try to get transport server accounts for local folders,
109 because they don't have any. This avoids a g_warning().
111 * src/maemo/modest-main-window.c:
112 (modest_main_window_notify_send_receive_initied),
113 (on_configuration_key_changed):
114 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
116 * src/modest-mail-operation.c:
117 (modest_mail_operation_update_account):
118 * src/modest-tny-account-store.h:
119 * src/modest-tny-account.c:
120 (modest_tny_account_get_special_folder),
121 (modest_tny_account_new_for_local_folders),
122 (modest_tny_account_new_for_per_account_local_outbox_folder):
123 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
124 * src/modest-tny-local-folders-account.c:
125 (add_account_folders_to_merged_folder):
126 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
127 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
128 (modest_ui_actions_on_send):
129 * src/widgets/modest-folder-view.c: (update_model):
130 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
131 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
132 modest_tny_account_store_get_tny_account_by_account() to
133 modest_tny_account_store_get_server_account() to make the code clearer.
135 2007-06-07 Marcus Bauer <marcusb@openismus.com>
137 * src/dbus_api/modest-dbus-api.h:
138 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
139 * src/maemo/modest-msg-edit-window.c:
140 (modest_msg_edit_window_attach_file_noninteractive):
141 added g_warning in case the file to be attached does not exist
142 * tests/dbus_api/test_compose_mail.c: (main):
143 removed obsolete comment, added generic files as test case
145 2007-06-07 Murray Cumming <murrayc@murrayc.com>
147 * src/modest-tny-account-store.c: (get_server_accounts):
148 Create the local folders account only once, not once for each outbox, and
149 not only when there are some outboxes.
151 2007-06-07 Murray Cumming <murrayc@murrayc.com>
153 * src/widgets/modest-folder-view.c: (update_model): Comment out some
154 code that is causing a crash at startup. Sergio says that he is fixing this.
156 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
158 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
159 * src/maemo/modest-account-settings-dialog.c:
160 (create_page_outgoing),
161 (modest_account_settings_dialog_set_account_name),
162 (save_configuration):
163 - Fixed handling of the "Use secure authentication" toggle to comply with
164 the ui specification. See also projects.maemo.org bug NB#58400
166 - Restore the Secure connection setting combo correctly when loading
169 * src/maemo/modest-maemo-utils.c:
170 (on_camel_account_get_supported_secure_authentication),
171 (modest_maemo_utils_get_supported_secure_authentication_methods):
172 Fixed a crasher if operation is canceled
174 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
175 (modest_protocol_info_auth_is_secure):
176 * src/modest-protocol-info.h:
178 Added two new methods to determine if a protocol/auth method is secure/encrypted in
179 the sense of the "Use secure authentication" toggle.
181 2007-06-07 Murray Cumming <murrayc@murrayc.com>
183 * src/modest-tny-account-store.h:
184 * src/modest-tny-account-store.c:
185 Added modest_tny_account_store_get_local_folders_account().
187 * src/modest-tny-folder.h:
188 * src/modest-tny-folder.c:
189 (modest_tny_folder_get_account):
190 Added this replacement for tny_folder_get_account() which returns
191 the local-folders account for TnyMergeFolders, to avoid the
192 warning about the unimplemented get_account_func() vfunc().
194 (modest_tny_folder_get_rules),
195 * src/modest-ui-actions.c:
196 (modest_ui_actions_on_folder_selection_changed):
197 * src/modest-mail-operation.c:
198 (modest_mail_operation_remove_folder),
199 (modest_mail_operation_xfer_folder),
200 (modest_mail_operation_rename_folder),
201 (modest_mail_operation_get_msg),
202 (modest_mail_operation_get_msgs_full),
203 (modest_mail_operation_remove_msg),
204 (modest_mail_operation_xfer_msgs),
205 (modest_mail_operation_refresh_folder):
206 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
208 2007-06-07 Murray Cumming <murrayc@murrayc.com>
210 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
211 (modest_server_account_set_security):
212 * src/modest-defs.h: Add comments explaining that our
213 UI spec means TLS when it says Normal, so these do not look like errors.
215 * src/modest-tny-account.c:
216 (modest_tny_account_new_from_server_account): Use the new tinymail
217 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
218 for TLS. This should fix projects.maemo.org bug NB#58460.
220 2007-06-06 Murray Cumming <murrayc@murrayc.com>
222 * src/maemo/easysetup/modest-easysetup-wizard.c:
223 (create_account): Correct the position of the gconf sanity check warning.
224 (on_button_edit_advanced_settings): Show the dialog immediately, instead
225 of using the g_idle_add() hack, because this does not seem to be necessary
226 on osso 1.1. It might even work on Maemo Bora if the problems were actually
227 caused by something other than maemo's gconf.
228 This fixes projects.maemo.org bug #59022.
230 2007-06-06 Murray Cumming <murrayc@murrayc.com>
232 * src/modest-account-mgr-helpers.c:
233 (modest_account_mgr_get_default_account): Do not check that the account
234 exists if there is no default account (NULL), to fix a runtime warning.
236 2007-06-06 Murray Cumming <murrayc@murrayc.com>
238 * src/widgets/modest-folder-view.c: (update_model):
239 Do not unref the treemodel before we have finished with it.
240 This prevents a valgrind warning and an occasional crash at startup.
242 2007-06-06 Marcus Bauer <marcusb@openismus.com>
244 * libmodest-dbus-client/libmodest-dbus-client.h:
245 added libmodest_dbus_client_compose_mail()
246 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
248 added functions needed for SendAsMail() functionality
249 * src/maemo/modest-msg-edit-window.c:
250 (modest_msg_edit_window_attach_file_noninteractive):
251 non interactively attaching files to message edit window
252 * src/widgets/modest-msg-edit-window.h:
253 * tests/dbus_api/Makefile.am:
254 added test_compose_mail.c
255 * tests/dbus_api/test_compose_mail.c: (main):
257 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
259 * src/modest-account-view.c:
260 Fixed bug projects.maemo.org bug NB#59307
262 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
264 * src/maemo/easysetup/modest-easysetup-wizard.c:
265 (get_serverport_incoming), (on_before_next), (create_account):
266 * src/maemo/modest-account-settings-dialog.c:
267 (modest_account_settings_dialog_set_account_name):
268 * src/maemo/modest-maemo-utils.c:
269 (on_camel_account_get_supported_secure_authentication_status),
270 (on_camel_account_get_supported_secure_authentication),
271 (on_secure_auth_cancel),
272 (modest_maemo_utils_get_supported_secure_authentication_methods):
274 Implemented security authentication for settings and easysetup.
276 2007-06-05 Murray Cumming <murrayc@murrayc.com>
278 * src/maemo/modest-main-window.c: (create_details_widget):
279 Show the total size for memory card accounts too, instead of showing
280 the name again. Fixes bug projects.maemo.org bug NB#59307.
282 2007-06-05 Murray Cumming <murrayc@murrayc.com>
285 * src/modest-tny-simple-folder-store.c:
286 * src/modest-tny-simple-folder-store.h: Removed.
288 * src/modest-tny-local-folders-account.h
289 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
290 for the local-folders maildir, with an extra TnyMergedFolder containing
291 the folders of the per-account outbox store accounts.
292 * src/modest-tny-account-store.c: (get_server_accounts):
293 Add the outboxes to the special local folders account after creating it.
295 * src/modest-tny-account.c:
296 (modest_tny_account_new_for_local_folders): Create the derived
297 account when creating the main local-folders account.
299 * src/maemo/modest-main-window.c: (create_details_widget),
300 (modest_main_window_set_contents_style):
301 Adapted to the use of the derived account instead of the folder store.
303 * src/modest-ui-actions.c:
304 (modest_ui_actions_on_folder_selection_changed):
305 * src/modest-ui-dimming-rules.c:
306 (modest_ui_dimming_rules_on_new_folder):
307 * src/widgets/modest-folder-view.c: (text_cell_data),
308 (icon_cell_data), (filter_row), (update_model),
309 (get_cmp_rows_type_pos):
312 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
313 Do not get the priv struct, because no priv struct has been set,
314 to avoid a runtime warning.
316 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
317 #ifelse with #else, to fix a warning, to fix the build.
320 2007-06-05 Christian Kellner <ckellner@openismus.com>
322 * libmodest-dbus-client/libmodest-dbus-client.c:
323 Fix small typo in doc (why do you always see them
324 AFTER committing stuff?)
327 2007-06-05 Christian Kellner <ckellner@openismus.com>
329 * libmodest-dbus-client/libmodest-dbus-client.c:
330 (libmodest_dbus_client_search):
331 Initialize hit list with NULL. Also set folder list
332 to "" if NULL was supplied.
335 2007-06-03 Christian Kellner <ckellner@openismus.com>
337 * libmodest-dbus-client/libmodest-dbus-client.c:
338 (modest_search_hit_list_free):
339 Make it save to call it with NULL.
341 * src/dbus_api/modest-dbus-callbacks.c:
342 * src/modest-search.c:
343 Return full ModestSearchHits as the search result list not TnyHeader
344 since can't be around withouth the correspoding TnyFolder.
346 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
348 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
349 Added currently commented code to check for secure auth
351 * src/maemo/modest-account-settings-dialog.c: (on_response),
352 (save_configuration), (show_ok):
353 Fixed projects.maemo.org bugs NB #59248 and #59251
355 * src/maemo/modest-maemo-utils.c:
356 (on_camel_account_get_supported_secure_authentication_status),
357 (on_camel_account_get_supported_secure_authentication),
358 (modest_maemo_utils_get_supported_secure_authentication_methods):
359 * src/maemo/modest-maemo-utils.h:
360 Moved get_supported_secure_authentication() method here to be able
361 to use it from easysetup wizard.
363 * src/modest-pair.c: (on_pair_compare_as_string):
364 Should compare string with first part of pair and not
365 strcmp pairs which will crash.
367 * src/modest-protocol-info.c:
368 (modest_protocol_info_protocol_is_store):
369 * src/modest-protocol-info.h:
370 Added modest_protocol_info_get_auth_protocol_name()
372 2007-06-03 Armin Burgmeier <armin@openismus.com>
374 * src/modest-mail-operation.c:
375 (modest_mail_operation_get_msgs_full): Set priv->account also when
376 only retrieving a single message. This avoids a crash when canceling
379 (modest_mail_operation_notify_end): Do not explicitely remove the
380 operation from the queue but only emit the progress_changed signal.
381 The queue itself listens to that signal to remove the operation when
382 it is finished. This reduces coupling and removes a potential deadlock
383 when modest_mail_operation_notify_end() is called from the queue
384 itself. If that is a problem performance-wise, I would suggest to
385 implement a status-changed signal or something.
387 * src/modest-mail-operation-queue.c: Make sure to never call a
388 function from another file while the queue is locked. This (hopefully)
389 fixes another deadlock when exiting the application while retrieving
392 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
394 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
395 Fixed build if libogs is not available
397 2007-06-03 Christian Kellner <ckellner@openismus.com>
399 * libmodest-dbus-client/libmodest-dbus-client.h:
400 * libmodest-dbus-client/libmodest-dbus-client.c:
401 (libmodest_dbus_client_delete_message):
402 Implement deletion of messages (Client side).
404 (modest_search_hit_free),
405 (modest_search_hit_list_free):
406 Utility functions to free the result hits.
408 * src/dbus_api/modest-dbus-api.h:
409 * src/dbus_api/modest-dbus-callbacks.c:
411 (modest_dbus_req_handler):
412 Implement deletion of messages (Server side).
414 * tests/dbus_api/test_search.c: (main):
417 * tests/dbus_api/Makefile.am:
418 * tests/dbus_api/test_delete_message:
419 Add little test for the message deletion logic
421 2007-06-03 Armin Burgmeier <armin@openismus.com>
423 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
424 when the operation queue was not empty. projects.maemo.org bug
427 2007-06-03 Armin Burgmeier <armin@openismus.com>
429 * src/widgets/modest-account-view.c
430 (on_account_default_toggled): Toggle default account column
431 explicitely instead of waiting for gconf notification (which is
432 currently ignored). This should fix projects.maemo.org bug NB#56910
433 for now. It should probably be removed when gconf notifications are
436 2007-06-03 Christian Kellner <ckellner@openismus.com>
438 * libmodest-dbus-client/libmodest-dbus-client.c:
439 Removed debugging spew.
441 * src/dbus_api/modest-dbus-callbacks.c:
442 Added debugging info.
444 * src/modest-search.c:
445 (modest_search_all_accounts):
446 Use tny_account_store_get_accounts () on the account store
447 to get all accounts which is the way to get all accounts.
449 * tests/dbus_api/test_search.c: (main):
450 Make it possible to supply the search term on the command line.
452 2007-06-03 Christian Kellner <ckellner@openismus.com>
454 * libmodest-dbus-client/libmodest-dbus-client.c:
455 * libmodest-dbus-client/libmodest-dbus-client.h:
456 Implement searching for mesages over raw dbus. (Client side)
458 * src/dbus_api/Makefile.am:
459 * src/dbus_api/modest-dbus-api.h:
460 * src/dbus_api/modest-dbus-callbacks.c:
461 * src/dbus_api/modest-dbus-callbacks.h:
462 Search framework (Server side). Also implement on_idle_open_message().
464 * src/maemo/modest-platform.c: (modest_platform_init):
465 Prepare for raw dbus/osso rpc interaction.
467 * src/modest-search.h:
468 Changed minsize from unspecific guint to guint32.
470 * src/modest-search.c:
472 Added strange hack which magically made tnymail work.
474 (modest_search_folder),
475 (modest_search_account),
476 (modest_search_all_accounts):
477 Implement helper functions to search all accounts, specific account
480 * tests/dbus_api/Makefile.am:
481 * tests/dbus_api/test_open_message.c:
482 Read url to open from commandline.
484 * tests/dbus_api/test_search.c:
485 Implement small test for dbus search stuff
487 2007-06-02 Armin Burgmeier <armin@openismus.com>
489 * src/maemo/modest-account-settings-dialog.c: Changed window title to
490 include account type and account title. This fixes projects.maemo.org
493 * src/maemo/modest-account-view-window.c: Set a title for the window.
495 2007-06-02 Armin Burgmeier <armin@openismus.com>
497 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
498 incoming and outgoing server name based on email address and server
499 types as long as the names have not been edited manually. This fixes
500 projects.maemo.org bug NB#58671.
502 2007-06-02 Armin Burgmeier <armin@openismus.com>
504 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
505 server type cannot be changed in future to the incoming details page
506 when creating an account. This fixes projects.maemo.org bug NB#59029.
508 2007-06-02 Armin Burgmeier <armin@openismus.com>
510 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
511 and assigned max width chars so that they wrap instead of being
512 truncated. Fixes projects.maemo.org bug NB#56126.
514 2007-06-02 Armin Burgmeier <armin@openismus.com>
516 * src/maemo/modest-connection-specific-smtp-window.c: Add an
517 introductory note to the connection specific smtp servers dialog, as
518 section 8.12 of the email UI specification requires. This fixes
519 projects.maemo.org bug NB#59212.
521 2007-06-01 Murray Cumming <murrayc@murrayc.com>
523 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
524 Check for running mail operations, and offer to cancel them, as per the UI
525 spec. This fixes projects.maemo.org bug NB#59041 .
526 However, I suspect that tinymail may still use the network connection
527 in ways that we cannot detect or cancel. But it should at least adapt to
530 2007-06-01 Murray Cumming <murrayc@murrayc.com>
532 * src/modest-tny-account-store.c: (recreate_all_accounts),
533 (get_cached_accounts), (get_server_accounts): Do more sensible
534 ref-counting of the temporarily-cached outbox accounts list. This seems
535 to fix a crash when entering the password when the password was wrong.
537 2007-06-01 Murray Cumming <murrayc@murrayc.com>
539 * src/gnome/modest-main-window.c: (connect_signals):
540 * src/modest-tny-account-store.c: (get_password),
541 (modest_tny_account_store_alert): Added comments and clues and
542 commented-out code about how we currently fail to deal with connection
543 errors and wrong passwords, and how we should.
545 2007-06-01 Murray Cumming <murrayc@murrayc.com>
547 * src/widgets/modest-retrieve-combo-box.c:
548 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
549 This fixes projects.maemo.org bug NB#58472 .
551 2007-06-01 Murray Cumming <murrayc@murrayc.com>
553 * src/maemo/easysetup/modest-easysetup-wizard.c:
554 (create_page_complete_easysetup):
555 (create_page_complete_custom): Correct the last commit,
556 putting the correct sentences in the correct pages.
558 2007-06-01 Murray Cumming <murrayc@murrayc.com>
560 * src/maemo/easysetup/modest-easysetup-wizard.c:
561 (create_page_complete_custom): Show the second sentence of text
562 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
565 2007-06-01 Murray Cumming <murrayc@murrayc.com>
567 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
568 Set the leave-on-server conf key by default. This fixes
569 projects.maemo.org bug NB#59258 .
571 2007-06-01 Murray Cumming <murrayc@murrayc.com>
573 * src/maemo/modest-account-view-window.c:
574 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
575 logical ID for the confirmation messages. Fixed projects.maemo.org bug
578 2007-06-01 Murray Cumming <murrayc@murrayc.com>
580 * src/maemo/easysetup/modest-easysetup-wizard.c:
581 (create_caption_new_with_asterisk):
582 * src/maemo/modest-account-settings-dialog.c:
583 (create_caption_new_with_asterisk):
584 Uncomment the code to add the asterisk, because they are no longer in the
585 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
586 (update_incoming_server_title): Add an asterisk here too.
588 2007-06-01 Murray Cumming <murrayc@murrayc.com>
590 * src/maemo/modest-maemo-global-settings-dialog.c:
591 (current_connection): Check that we are even connected before trying to
592 get the current connection name, to prevent a warning.
594 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
595 Change the comments because tny_maemo_conic_device_connect() is now meant to
597 * src/modest-mail-operation.c:
598 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
599 make sure we have a connection and fail if we can't connect.
601 2007-05-31 Murray Cumming <murrayc@murrayc.com>
603 * src/maemo/modest-main-window.c:
604 (on_account_store_connecting_finished): Do not try to get the
605 connection ID if we are not really connected. I am surprised that
606 this signal handler is called when we are not connected.
608 2007-05-31 Murray Cumming <murrayc@murrayc.com>
610 * src/modest-error.h:
611 * src/modest-ui-actions.c:
612 (modest_ui_actions_get_msgs_full_error_handler):
613 Renamed an enum, added comments, added an enum
614 for retrieve-limit errors.
616 * src/modest-mail-operation.c: (foreach_add_item),
617 (internal_folder_observer_update), (update_account_thread),
618 (modest_mail_operation_get_msgs_full):
619 (modest_mail_operation_update_account),
620 Added comments about how this works, and some code that should
621 (but does not) check the retrieve-limit. See the TODO comment.
623 2007-05-31 Murray Cumming <murrayc@murrayc.com>
625 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
626 Initialize help_id to fix the build. Warnings are good.
628 2007-05-31 Murray Cumming <murrayc@murrayc.com>
630 * src/widgets/modest-hbox-cell-renderer.c:
631 (modest_hbox_cell_renderer_append):
632 * src/widgets/modest-vbox-cell-renderer.c:
633 (modest_vbox_cell_renderer_append):
634 Fix the last commit by doing an extra ref.
636 2007-05-31 Murray Cumming <murrayc@murrayc.com>
638 * src/widgets/modest-hbox-cell-renderer.c:
639 (modest_hbox_cell_renderer_append):
640 * src/widgets/modest-vbox-cell-renderer.c:
641 (modest_vbox_cell_renderer_append):
642 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
643 to fix the build with Maemo Bora.
644 However, there seems to be a remaining crash, probably due to reference
647 2007-05-30 Murray Cumming <murrayc@murrayc.com>
649 * src/modest-tny-account.c:
650 (modest_tny_account_new_for_local_folders):
651 Use hildon_file_system_info_async_new() to get a better name for
652 the memory card account, setting it as the account name.
653 The timing seems to work, but this is probably
654 not the best place to do this. See the TODO comment.
655 * src/maemo/modest-main-window.c: (create_details_widget):
656 * src/widgets/modest-folder-view.c: (text_cell_data):
657 Use the tny account name instead of hardcoding a name.
659 2007-05-30 Christian Kellner <ckellner@openismus.com>
661 * src/modest-search.c: (modest_search):
662 Correctly set part_search_func even if we have already parsed
663 the query and thus a valid OgsTextSearcher object.
665 2007-05-30 Christian Kellner <ckellner@openismus.com>
668 Search and check for libogs.
671 Incooparte the ogs build env.
673 * src/modest-mime-part-search-stream.c:
674 * src/modest-mime-part-search-stream.h:
675 Removed since we do the real searching now in modest-search.c.
677 * src/modest-search.c:
678 * src/modest-search.h:
679 Implement support for ogs. We use that if available and requested
680 and fall back to modest_text_utils_utf8_strcmp (). The search logic
681 should now handle the corner case when the search term is spread
682 across multiple reads.
683 Also the logic in modest_search () was corrected to search all
684 requested fields until one is found.
686 2007-05-30 Murray Cumming <murrayc@murrayc.com>
688 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
691 * src/modest-init.c: Made modest_init_local_folders() take a
692 path and be public so we can iniitialize maildir folders on
695 * src/modest-local-folder-info.h:
696 * src/modest-local-folder-info.c:
697 (modest_local_folder_info_get_maildir_path): Add a path parameter.
699 * src/modest-tny-account.c:
700 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
701 still means the standard local-folders path on the local volume.
703 * src/modest-tny-account-store.c:
704 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
705 signal so we can detect mount/unmount of the MMC1 card, and do an update of
706 all accounts when that happens.
707 (get_server_accounts): If the MMC1 card is mounted, create a store account for
708 this too, so it shows up in the treeview.
710 2007-05-28 Murray Cumming <murrayc@murrayc.com>
712 * src/maemo/modest-maemo-global-settings-dialog.c:
713 (current_connection):
714 * src/widgets/modest-global-settings-dialog.c:
715 (current_connection_default):
716 Use the enum values instead of 0, 1 and -1,
717 to make the code clearer.
719 * src/modest-account-mgr-helpers.c:
720 (modest_account_mgr_get_connection_specific_smtp): Make this code
723 * src/modest-runtime.h:
724 * src/modest-runtime.c:
725 Added modest_runtime_remove_all_send_queues().
726 * src/maemo/modest-main-window.c:
727 (on_account_store_connecting_finished): Recreate the send queues,
728 using the appropriate transport accounts for this new connection.
729 Some futher adapting might be needed if the old send queues are not
730 automatically stopped at this point.
732 * src/modest-tny-account-store.c: (get_server_accounts):
733 Create the connection-specific transport accounts, so that they can
734 be found later by their ID.
736 * src/modest-tny-account.h:
737 * src/modest-tny-account.c:
738 Added modest_tny_account_new_from_server_account_name().
739 modest_tny_account_new_from_server_account(): Do not create the
740 send queues here, because they will be
741 recreated anyway when the connection changes for the first time.
743 2007-05-28 Murray Cumming <murrayc@murrayc.com>
745 * src/modest-local-folder-info.h:
746 * src/modest-local-folder-info.c:
747 (modest_per_account_local_outbox_folder_info_get_maildir_path),
748 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
749 tbox_folder): Take a modest account name instead of a server TnyAccount,
750 so we can have per-modest-account rather than per-transport-account
752 We must make sure that we change or recreate the exisitng send queues
753 when the connection changes for connection-specific transport accounts.
755 * src/modest-tny-account-store.c:
756 (create_per_account_local_outbox_folders): Create outboxed per modest
757 account, not per transport account.
759 * src/modest-tny-account.h:
760 * src/modest-tny-account.c:
761 (modest_tny_account_get_special_folder): For outboxes, get the
762 parent modest account name. The account is ignored for other folders.
763 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
764 modest account name rather than a server TnyAccount.
766 2007-05-25 Murray Cumming <murrayc@murrayc.com>
768 * src/modest-tny-account.c:
769 (modest_tny_account_new_from_server_account):
770 Call modest_runtime_get_send_queue() immediately after creating transport
771 accounts, so that they start trying to send email from the outbox as soon
772 as possible at startup. This is probably what we want.
774 * src/modest-mail-operation.c: (update_account_thread):
775 * src/modest-runtime.c: (modest_runtime_get_send_queue):
776 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
777 * src/modest-tny-send-queue.h:
778 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
779 (modest_ui_actions_on_send):
780 Added comments about how sending works, though it needs some more work.
782 2007-05-25 Murray Cumming <murrayc@murrayc.com>
784 * src/modest-tny-account.c:
785 (modest_tny_account_get_special_folder): Add TODO because this fails when
787 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
788 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
789 Do not try to show this window when there is no active account. The UI
790 specs does not tell us what to do in this case.
792 2007-05-24 Murray Cumming <murrayc@murrayc.com>
796 * src/maemo/Makefile.am:
797 * src/widgets/Makefile.am: Some dist fixes.
799 2007-05-24 Murray Cumming <murrayc@murrayc.com>
801 * src/maemo/modest-connection-specific-smtp-window.c:
802 (on_button_edit): Make the code clearer, to prevent a double free.
804 2007-05-24 Murray Cumming <murrayc@murrayc.com>
806 * src/maemo/modest-account-settings-dialog.c:
807 (modest_account_settings_dialog_set_account_name),
808 Check the connection-specific smtp servers checkbox if there are any.
810 * src/maemo/modest-connection-specific-smtp-edit-window.c:
811 (modest_connection_specific_smtp_edit_window_init):
812 Start with a suitable port number.
814 * src/modest-account-mgr-helpers.h:
815 * src/modest-account-mgr-helpers.c: Added
816 modest_account_mgr_get_has_connection_specific_smtp().
818 (modest_account_mgr_set_connection_specific_smtp),
819 (modest_account_mgr_remove_connection_specific_smtp),
820 (modest_account_mgr_get_has_connection_specific_smtp),
821 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
822 connection-specific smtp server accounts in the account, rather than
823 the server account conf dir.
825 This fixes bug projects.maemo.org bug NB#58263 .
827 * src/modest-tny-account-store.c:
828 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
829 if there are no server accounts yet, to prevent an infinite loop when there
830 are no accounts. Document that one must be called before the other.
832 2007-05-24 Murray Cumming <murrayc@murrayc.com>
834 * src/modest-account-mgr-helpers.c:
835 (modest_account_mgr_get_default_account): Make sure that at least
836 one account is always the default, if there are any enabled accounts.
837 This is just a sanity check that shouldn't be necessary.
839 * src/modest-account-mgr-priv.c:
840 (_modest_account_mgr_account_from_key): Unescape the conf key to
841 get the real account name. For instance, this is an issue if a space
842 was in the account name, which can happen because the account name
843 is generated from the display name.
844 (_modest_account_mgr_get_account_keyname): Always escape the
846 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
847 Unescape the conf keys to get the real account names.
849 For instance, previously the is-default radio button in the accounts
850 list was not checked for any accounts at first. This fixes that,
851 and might fix several similar bugs.
853 2007-05-23 Murray Cumming <murrayc@murrayc.com>
855 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
856 Removed some debug printfs.
858 2007-05-23 Murray Cumming <murrayc@murrayc.com>
860 Modest on-disk outbox directories are now here, for instance:
861 $HOME/.modest/outboxes/<account-id-1>/outbox
862 $HOME/.modest/outboxes/<account-id-2>/outbox
864 $HOME/.modest/local-folders/outbox
865 so we can have a separate outbox for each account.
866 But they are shown as one outbox in the GtkTreeView, by using a
867 TnyMergeFolder in a ModestTnySimpleFolderStore.
870 * src/modest-tny-simple-folder-store.c:
871 * src/modest-tny-simple-folder-store.h:
872 Added ModestTnySimpleFolderStore, used to contain folders from
873 other folder stores, such as other accounts.
875 * src/modest-tny-outbox-account.h:
876 * src/modest-tny-outbox-account.c:
877 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
878 used for the per-account local outbox folders.
880 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
881 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
882 only use this (internally) now for the non-outbox local folders.
885 * src/modest-init.c: Added modest_init_one_local_folder(), for
886 setting up the directory structure for each local folder.
888 * src/modest-local-folder-info.c:
889 (modest_per_account_local_outbox_folder_info_get_maildir_path),
890 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
892 * src/modest-local-folder-info.h:
893 * src/modest-tny-account-store.c: (on_account_removed),
894 (on_account_changed), (create_per_account_local_outbox_folders),
895 (get_server_accounts), (modest_tny_account_store_get_accounts),
896 (modest_tny_account_store_get_tny_account_by_account),
897 (modest_tny_folder_store_is_virtual_local_folders):
899 * src/modest-tny-account.h:
900 * src/modest-tny-account.c:
901 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
902 to create an on-disk per-account local outbox folder for each
904 (create_per_account_local_outbox_folders): Create a local outbox folder
905 for each transport account.
906 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
907 for all local folders.
909 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
910 instead of using g_object_get/set() directly. It is clearer.
912 (modest_tny_folder_store_get_message_count),
913 (modest_tny_folder_store_get_local_size
914 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
915 because we now use these with non-acount folder stores.
917 (modest_tny_account_get_special_folder),
918 (modest_tny_account_new_from_server_account),
919 (modest_tny_account_new_from_account):
920 (recurse_folders): Adjust to the new outbox system.
922 * src/modest-tny-folder.h:
923 * src/modest-tny-folder.c:
924 (modest_tny_folder_is_local_folder),
925 (modest_tny_folder_get_local_folder_type),
926 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
928 * src/widgets/modest-main-window.h:
929 * src/maemo/modest-main-window.c: (create_details_widget),
930 (modest_main_window_set_contents_style): Show details for any folder store,
933 (modest_tny_folder_get_rules):
934 Remove the const. C does not support constness enough for this.
936 * src/modest-ui-actions.c:
937 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
938 make all outboxes appear as one, in the usual local-folders tree node.
940 (set_active_account_from_tny_account),
941 (modest_ui_actions_on_folder_selection_changed):
942 * src/widgets/modest-folder-view.c: (text_cell_data),
943 (icon_cell_data), (filter_row),
944 (add_account_folders_to_merged_folder),
945 (add_account_folders_to_simple_folder_store), (),
946 (get_cmp_rows_type_pos), (cmp_rows),
947 (modest_folder_view_set_account_id_of_visible_server_account):
948 Adjust to the new outbox system, using generic folder stores and folders
951 2007-05-23 Christian Kellner <ckellner@openismus.com>
953 * src/modest-mail-operation.c:
954 (modest_mail_operation_update_account):
955 Use info->max_size instead of unintialized local var [small
956 build fix]. (Added TODO to review that change since I don't
959 2007-05-23 Marcus Bauer <marcusb@openismus.com>
961 * libmodest-dbus-client/libmodest-dbus-client.c:
962 (libmodest_dbus_client_compose_mail): function added
963 * src/dbus_api/modest-dbus-api.h:
964 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
965 (on_compose_mail): Implementation of the SendAsMail functionality
967 2007-05-22 Murray Cumming <murrayc@murrayc.com>
969 * src/modest-account-mgr.c:
970 (modest_account_mgr_add_server_account): Set the secure-connection
971 conf key for transport accounts as well as store accounts. I don't know
972 why the if was there. For instance, this makes sure that we use SSL
973 for the gmail preset from the easysetup wizard.
975 2007-05-22 Murray Cumming <murrayc@murrayc.com>
977 * src/gnome/modest-main-window.c:
978 (on_account_store_connecting_finished), (connect_signals):
979 * src/maemo/modest-main-window.c:
980 (on_account_store_connecting_finished), (connect_signals),
981 (modest_main_window_new):
982 Handle TnyAccountStore::connecting-finished instead of
983 TnyDevice::connection-changed, because we cannot actually perform
984 operations on accounts until TnyAccountStore has itself responded to
985 the TnyDevice::connection-changed signal. This prevents a GError from
987 Do not try to update at startup, because we (at least on scratchbox)
988 already do an update at startup when the device goes online.
989 This prevents a GError from tinymail.
990 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
991 Added TODO about stopping simultaneous operations.
993 2007-05-21 Murray Cumming <murrayc@murrayc.com>
995 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
996 * src/modest-mail-operation-queue.c:
997 (modest_mail_operation_queue_remove):
998 * src/modest-tny-account-store.c: When GErrors happen, give more clues
999 about where they happened.
1001 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1003 * src/modest-ui-actions.c:
1004 (modest_ui_actions_on_password_requested): Make sure that the remember
1005 output parameter is always TRUE.
1007 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1009 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1010 Show a OK/Cancel dialog if the error is a question, though we still do not
1011 know anything more about what we are asking the user.
1012 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1013 Fix an uninitialized variable (helper). This is a logic error, however.
1015 2007-05-21 Christian Kellner <ckellner@openismus.com>
1017 * src/modest-search.h:
1018 Correct bit shifting in the ModestSearchFlags enum.
1020 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1022 * src/modest-tny-account.c:
1023 (modest_tny_account_new_from_server_account): Do not use the lsub and
1024 check-all hard-coded IMAP options when using POP.
1026 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1028 * src/modest-tny-account.c:
1029 (modest_tny_account_new_from_server_account):
1030 Use NULL for the secure-auth method for POP when Password auth has been
1031 specified by the user, as we already do for IMAP. "auth=Login" causes
1032 an error from camel or the server.
1034 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1036 * src/maemo/modest-account-settings-dialog.c:
1037 (create_page_account_details),
1038 (modest_account_settings_dialog_set_account_name):
1039 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1040 for the leave-on-server checkbox, rathr than just the checkbox, when
1041 the protocol is not POP.
1043 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1045 * src/widgets/modest-account-view.c:
1046 * src/widgets/modest-account-view.h:
1047 Added modest_account_view_select_account() which will be useful later
1048 to asynchronously re-select the edited account.
1050 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1052 * src/maemo/modest-account-settings-dialog.c:
1053 (modest_account_settings_dialog_set_account_name):
1054 Automatically choose the port numbers based on the secure authentication
1055 methods, if they have not been chosen before.
1056 This fixes projects.maemo.org bug NB#56273 .
1058 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1060 * src/maemo/modest-main-window-ui.h:
1061 * src/modest-ui-actions.c:
1062 * src/modest-ui-actions.h:
1063 Connect the Tools/SMTP Servers menu item to
1064 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1065 SMTP servers dialog, as in the UI specification and saves changes when it
1066 is closed. This fixed projects.maemo.org bug NB#56305 .
1068 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1070 * src/maemo/modest-connection-specific-smtp-window.c:
1071 (modest_connection_specific_smtp_window_init):
1072 Use gtk_window_set_default_size() to make this window big enough, so
1073 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1075 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1077 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1078 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1079 (modest_connection_specific_smtp_edit_window_init),
1080 Do not try to connect to a combobox signal before the combobox exists.
1081 This fixes the cras in projects.maemo.org bug NB#56288 .
1082 (modest_connection_specific_smtp_edit_window_get_settings):
1083 Remove the server_account_name parameter which was being checked for NULL
1084 though it was not used.
1086 * src/maemo/modest-connection-specific-smtp-window.c:
1087 (modest_connection_specific_smtp_window_fill_with_connections),
1088 (on_button_edit), (modest_connection_specific_smtp_window_init):
1089 Correct the number of treemodel columns to prevent a warning.
1090 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1091 libconic does not work.
1093 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1095 * src/modest-tny-account.c:
1096 (modest_tny_account_new_from_server_account):
1097 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1098 SMTP when "None" was chosen by the user. However, with my SMTP server that
1099 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1102 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1104 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1105 to explain the memory management issue with the ID in the ModestPair.
1107 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1108 (add_sending_page), (modest_account_assistant_finalize):
1109 * src/gnome/modest-gnome-global-settings-dialog.c:
1110 (create_updating_page), (create_composing_page):
1111 * src/gnome/modest-msg-edit-window.c: (get_transports),
1112 (init_window), (modest_msg_edit_window_finalize),
1113 (modest_msg_edit_window_get_msg_data):
1114 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1115 * src/gnome/modest-transport-widget.c:
1116 (modest_transport_widget_finalize), (smtp_configuration):
1117 * src/maemo/modest-maemo-global-settings-dialog.c:
1118 (create_updating_page), (create_composing_page):
1119 * src/maemo/modest-msg-edit-window.c: (get_transports),
1120 (init_window), (modest_msg_edit_window_finalize),
1121 (modest_msg_edit_window_get_msg_data),
1122 (modest_msg_edit_window_free_msg_data):
1123 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1124 (modest_store_widget_finalize):
1125 * src/maemo/modest-transport-widget.c:
1126 (modest_transport_widget_finalize), (smtp_configuration):
1127 * src/modest-main.c: (send_mail):
1128 * src/widgets/modest-combo-box.h:
1129 * src/widgets/modest-global-settings-dialog-priv.h:
1130 * src/widgets/modest-global-settings-dialog.c:
1131 (modest_global_settings_dialog_finalize):
1132 * src/widgets/modest-msg-edit-window.h:
1133 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1134 as long as the combo box, to prevent use of freed memory for the ID.
1136 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1138 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1139 get_accounts(), to make this clearer. Do not check for the enabled gconf
1140 key, because we do not use this for server accounts (at least, not yet).
1141 This allows us to send email again.
1143 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1145 * src/maemo/modest-platform.c:
1146 (on_modest_conf_update_interval_changed), (modest_platform_init):
1147 Only respond to this particular key change. All these strcmp()s cannot be
1150 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1152 * src/maemo/modest-maemo-global-settings-dialog.c:
1153 (current_connection): Prevent a crash in scratchbox when
1154 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1155 * src/maemo/modest-platform.c:
1156 (on_modest_conf_update_interval_changed), (modest_platform_init):
1157 Get the update interval from gconf and reset it when the gconf key changes.
1159 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1161 * src/modest-protocol-info.c:
1162 * src/modest-protocol-info.h: Adde enum-specific get functions,
1163 instead of using a ModestProtocolType enum parameter.
1165 * src/gnome/modest-account-assistant.c:
1166 * src/gnome/modest-store-widget.c:
1167 * src/gnome/modest-store-widget.h:
1168 * src/gnome/modest-transport-widget.c:
1169 * src/gnome/modest-transport-widget.h:
1170 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1171 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1172 * src/maemo/easysetup/modest-easysetup-wizard.c:
1173 * src/maemo/modest-account-settings-dialog.c:
1174 * src/maemo/modest-account-settings-dialog.h:
1175 * src/maemo/modest-store-widget.c:
1176 * src/maemo/modest-store-widget.h:
1177 * src/maemo/modest-transport-widget.c:
1178 * src/maemo/modest-transport-widget.h:
1179 * src/modest-account-mgr-helpers.c:
1180 * src/modest-account-mgr-helpers.h:
1181 * src/modest-account-mgr.c:
1182 * src/modest-account-mgr.h:
1183 * src/modest-tny-account.c:
1184 * src/modest-tny-folder.c:
1185 * src/widgets/modest-account-view.c:
1186 * src/widgets/modest-retrieve-combo-box.c:
1187 * src/widgets/modest-retrieve-combo-box.h:
1188 * src/widgets/modest-secureauth-combo-box.c:
1189 * src/widgets/modest-serversecurity-combo-box.c:
1190 * src/widgets/modest-serversecurity-combo-box.h:
1191 * tests/check_account-mgr.c:
1192 Use the specific functions, and use the re-renamed enum values for GNOME too.
1194 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1196 * src/modest-pair.h:
1197 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1198 so we can get the second based on the first.
1200 * src/maemo/modest-account-settings-dialog.h:
1201 * src/maemo/modest-account-settings-dialog.c:
1202 Added get_supported_secure_authentication_methods(), though it is mostly
1203 commented-out for now until the necessary API is committed to tinymail.
1204 (modest_account_settings_dialog_set_account_name),
1205 (save_configuration): Request the supported authentication methods from the
1206 server, so we can choose a working method.
1208 * src/modest-tny-account-store.h:
1209 * src/modest-tny-account-store.c:
1210 (modest_tny_account_store_get_session): Rename from
1211 tny_account_store_get_session().
1213 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1215 * src/modest-protocol-info.h: Split the ModestProtocol enum
1216 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1217 There was no need to have these unrelated values in one enum.
1219 * src/: many files: Adapted to changed enum. This makes the code a bit
1220 clearer, and the compiler could catch some errors.
1222 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1224 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1225 Show the detailed internal camel error message when an error happens
1226 during the configuration, so that our testers can give us more clues.
1227 For instance, in projects.maemo.org bug NB#56910 .
1229 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1231 * src/modest-tny-account.c:
1232 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1233 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1235 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1237 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1238 * src/maemo/modest-account-settings-dialog.c:
1239 (modest_account_settings_dialog_set_account_name),
1240 (save_configuration): For the incoming secure authentication checkbox,
1241 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1242 the UI specification. PLAIN does not seem to be supported for most IMAP
1243 servers anyway, and I am not sure what it would mean.
1244 However, we probably need to discover which of the secure-authentication
1245 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1246 * src/modest-account-mgr-helpers.c:
1247 (modest_account_mgr_get_server_account_data):
1249 * src/modest-tny-account.c:
1250 (modest_tny_account_new_from_server_account):
1251 Use tny_account_set_mech() to set secure-authentication methods,
1252 with some special-casing for IMAP, based on my observations of how
1255 * src/modest-account-mgr-helpers.h:
1256 * src/modest-account-mgr.c:
1257 * src/modest-defs.h: Comment that the URI is only used for local folders.
1259 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1261 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1262 parameter const, just to be neat.
1263 * src/modest-text-utils.c: (modest_text_utils_inline):
1264 End g_strconcat() with NULL, as its documentation says. This is almost
1265 certainly the cause of my crash at startup on the device. Interestingly,
1266 valgrind doesn't tell us about these errors.
1268 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1270 * scripts/build-packages: Added more precise comments about how to use
1271 this script, though I still get this error:
1272 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1273 error building tinymail
1275 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1277 * src/maemo/modest-main-window.c: (on_account_update):
1278 Very slight cleanup, hoping to make it simpler to discover what causes
1279 a crash here sometimes.
1281 * src/modest-tny-account.c:
1282 (modest_tny_account_new_from_server_account): Set the port. Added
1283 comments about the options and a TODO comment because I need to find out
1284 how to specify the secure authentication method.
1286 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1288 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1289 changed CFlags paths form modest to libmodest
1291 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1293 * src/modest-account-mgr-helpers.c:
1294 (modest_account_mgr_get_server_account_data),
1295 (modest_account_mgr_free_server_account_data):
1296 * src/modest-account-mgr-helpers.h:
1297 * src/modest-account-mgr.c:
1298 (modest_account_mgr_add_server_account):
1299 * src/modest-defs.h:
1300 * src/modest-tny-account.c:
1301 (modest_tny_account_new_from_server_account):
1302 Determine the options for tny_camel_account_add_option() here,
1303 based on the settings, rather than storing them directly in gconf.
1305 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1307 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1308 Show a more friendly error dialog now that we expect (from the tinymail
1309 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1311 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1313 * src/maemo/modest-main-window.c: (on_account_update): Check that
1314 account_name is not NULL, to prevent a crash at startup that I am
1315 seeing on the N800. I do wonder why it is NULL.
1317 * src/maemo/easysetup/modest-easysetup-wizard.c:
1318 (create_page_user_details):
1319 * src/maemo/modest-account-settings-dialog.c:
1320 (create_page_user_details), (create_page_outgoing):
1321 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1322 (modest_connection_specific_smtp_edit_window_init):
1323 * src/modest-ui-actions.c:
1324 (modest_ui_actions_on_password_requested):
1325 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1326 might do something useful with the on-screen keyboard.
1328 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1330 * src/maemo/modest-main-window.c: (on_account_update):
1331 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1332 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1334 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1336 * src/modest-tny-account-store.c: (on_account_changed):
1337 Correct the signature of this signal handler.
1339 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1341 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1342 Show a HildonNote instead of a GtkDialog for Maemo.
1344 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1346 * src/widgets/modest-account-view.h:
1347 * src/widgets/modest-account-view.c: (on_account_changed),
1348 (on_account_removed). Added a boolean flag, set/unset by
1349 modest_account_view_block_conf_updates(),
1350 modest_account_view_unblock_conf_updates() to prevent unnecessary
1351 updates, but this is not very useful because the gconf notifications are
1352 so delays (maybe only on Maemo Bora).
1353 So auto-updating is turned off, and these functions do an explicit
1354 update when necessary.
1355 However, something else is still doing too much work when adding/removing
1356 accounts, probably in another part of the application.
1358 * src/maemo/modest-account-view-window.c:
1359 (on_delete_button_clicked), (on_edit_button_clicked),
1360 (on_new_button_clicked): Use the new functions.
1362 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1364 * src/modest-account-mgr-helpers.c:
1365 (modest_account_mgr_set_first_account_as_default):
1366 Sort the list of names alphabetically-by-title, so we choose the first one
1368 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1369 alphabetically by the title.
1371 This fixes projects.maemo.org bug NB#56418 .
1373 * src/modest-account-mgr-priv.c:
1374 (_modest_account_mgr_account_from_key):
1375 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1376 avoid a valgrind error, and possible random behaviour.
1378 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1380 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1381 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1382 tinymail documentation to say that this can be expected.
1383 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1384 pretty, and should not happen, but I would prefer to know when it does.
1386 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1388 * configure.ac: When using the older hildon version, probably on Bora,
1389 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1391 * src/widgets/modest-attachment-view.c:
1392 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1395 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1397 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1398 Implemented the prototype. Can be tested with
1399 tests/dbus_api/test_open_message:
1401 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1403 * src/modest-tny-account-store.c:
1404 (modest_tny_account_store_instance_init), (get_password):
1405 * src/modest-ui-actions.c:
1406 (modest_ui_actions_on_password_requested):
1407 Do not store the password in gconf, because this function is called
1408 for non-remembered passwords. Actually use the cached (in the hash map)
1409 password instead of releasing it.
1410 The password will now not be remembered if it is asked via the protected
1411 password dialog, as per the UI spec.
1413 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1415 * src/modest-defs.h:
1416 * src/modest-account-mgr-helpers.h:
1417 * src/modest-account-mgr-helpers.c:
1418 Added modest_server_account_get_username_has_succeeded(),
1419 modest_server_account_set_username_has_succeeded().
1420 (modest_server_account_set_username),
1421 Reset the has-succeeded flag if the username changes.
1423 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1424 * src/maemo/modest-connection-specific-smtp-window.c:
1425 (modest_connection_specific_smtp_window_save_server_accounts):
1426 Use modest_server_account_set_username() instead of using
1427 modest_conf_set_string() directly, so that the has-succeeded flag is always
1430 * src/modest-ui-actions.c:
1431 (modest_ui_actions_on_password_requested): Dim the username entry if
1432 the username has ever worked, as per the UI spec.
1434 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1436 * src/modest-tny-account-store.c: (get_password):
1437 * src/modest-ui-actions.c:
1438 (modest_ui_actions_on_password_requested):
1439 Allow the username to be changed too, though there is more work to
1440 be done on exactly how this behaves.
1442 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1444 * src/modest-account-mgr-helpers.h:
1445 * src/modest-account-mgr-helpers.c:
1446 Added modest_account_mgr_get_display_name(),
1447 modest_server_account_get_username(),
1448 modest_server_account_set_username(),
1449 modest_server_account_set_password(),
1450 modest_server_account_get_hostname() functions so we do not need to
1451 use the conf API directly.
1453 * src/maemo/modest-main-window.c: (connect_signals):
1454 Actually connect ot the ModestAccountStore::request-password signal,
1455 so that we show the dialog when the password is requested by Tinymail,
1456 for isntance if it is empty.
1458 * src/modest-marshal.list:
1459 * src/modest-tny-account-store.c:
1460 (modest_tny_account_store_class_init), (get_password),
1461 (modest_tny_account_store_alert):
1462 * src/modest-tny-account-store.h:
1463 * src/modest-ui-actions.h:
1464 * src/modest-ui-actions.c:
1465 (modest_ui_actions_on_password_requested):
1466 Change the signal parameters, so it is obvious that we are providing
1467 the non human-readable server name, and receiving both the username
1468 and password, though changing of the username is not yet implemented.
1469 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1470 for the GNOME version.
1472 This should fix the projects.maemo.org bug NB#56209, though it does not
1473 work on Bora, because the gconf_client_get() for the password fails
1474 immediately after we save it with gconf_client_set().
1476 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1479 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1480 caused an undefined symbol error:
1481 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1483 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1485 * src/modest-tny-account-store.c:
1486 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1487 using a GError instead of a string message, so we can translate it in
1490 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1492 * src/maemo/modest-address-book.c:
1493 (modest_address_book_check_names):
1494 * src/maemo/modest-msg-view-window.c:
1495 (modest_msg_view_window_clipboard_owner_change):
1496 * src/modest-init.c: (modest_init_init_ui):
1497 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1498 (update_folders_cb), (modest_mail_operation_update_account):
1499 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1500 (modest_ui_actions_on_msg_attachment_clicked),
1501 (modest_ui_actions_on_msg_recpt_activated):
1502 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1503 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1504 (modest_msg_view_search_next):
1505 * src/widgets/modest-recpt-editor.c:
1506 (modest_recpt_editor_on_button_release_event),
1507 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1508 g_message(). At this point we should only be seeing interesting errors on
1509 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1511 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1513 (modest_wizard_dialog_force_title_update):
1514 * src/maemo/easysetup/modest-wizard-dialog.h:
1515 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1516 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1517 can update the title when appropriate. Otherwise the title is wrong if the
1518 pages are added after adding the notebook to the dialog.
1519 This must be a problem in HildonWizardDialog too.
1520 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1522 * src/maemo/easysetup/modest-easysetup-wizard.c:
1523 (create_subsequent_customsetup_pages),
1524 (create_subsequent_easysetup_pages):
1525 Call modest_wizard_dialog_force_title_update() so that the title is
1526 correct even with GTK+ < 2.10.
1527 This fixes projects.maemo.org bug NB#56145 .
1529 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1531 * src/maemo/modest-platform.c:
1532 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1533 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1536 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1538 * src/widgets/modest-window.h:
1539 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1540 and modest_window_save_state(), which invokes it.
1542 * src/widgets/modest-window-mgr.h:
1543 * src/widgets/modest-window-mgr.c:
1544 Added modest_window_mgr_save_state_for_all_windows(), which calls
1545 the save_state vfunc on all registered windows, if implemented.
1547 * src/gnome/modest-msg-edit-window.c:
1548 * src/gnome/modest-msg-view-window.c:
1549 * src/maemo/modest-msg-edit-window.c:
1550 * src/maemo/modest-msg-view-window.c:
1551 * src/maemo/modest-main-window.c:
1552 Specify the existing save_settings functions as implementations of
1553 ModestWindow::save_state_func().
1555 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1556 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1557 enabling hibernation, for instance.
1559 We may need to do the same thing for restoring settings.
1562 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1564 * src/widgets/modest-window-mgr.c:
1565 * src/widgets/modest-window-mgr.h:
1566 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1567 modest_window_mgr_get_hibernation_is_prevented().
1569 * src/maemo/modest-main-window.c:
1570 (on_hildon_program_is_topmost_notify): Prevent hibernation
1571 (possible when the application goes to the background in the WM),
1572 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1574 * src/maemo/easysetup/modest-easysetup-wizard.c:
1575 (modest_easysetup_wizard_dialog_init):
1576 * src/maemo/modest-account-settings-dialog.c:
1577 (modest_account_settings_dialog_init):
1578 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1579 (modest_connection_specific_smtp_edit_window_init):
1580 * src/maemo/modest-connection-specific-smtp-window.c:
1581 (modest_connection_specific_smtp_window_init):
1582 * src/maemo/modest-signature-editor-dialog.c:
1583 (modest_signature_editor_dialog_init):
1584 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1585 prevent hibernation while any of these account settings dialogs are open.
1587 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1589 * src/maemo/Makefile.am:
1590 * src/maemo/modest-osso-state-saving.c:
1591 * src/maemo/modest-osso-state-saving.h: Added
1592 modest_osso_load_state() and modest_osso_save_state() though they do
1593 nothing now. They should iterate through all the open windows and load/save
1595 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1596 save state when closing.
1598 * src/maemo/modest-main-window.c:
1599 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1600 Add a notification handler for the HildonProgram::is-topmost property,
1601 so we can allow hibernation when the application goes into the background.
1602 But we still need to detect when the accounts setup windows are open so
1603 we can stop hibernation when they are open.
1604 To do this, I also added the main window the HildonProgram. This might have
1605 other side-effects/benefits, and should maybe be done for other windows.
1607 * src/maemo/modest-osso-autosave-callbacks.h:
1608 * src/maemo/modest-osso-autosave-callbacks.c:
1609 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1610 though it does not do anything yet, and we might never need this to do
1611 anything. For instance, we already save drafts.
1613 * src/maemo/modest-platform.c: (modest_platform_init):
1614 Specify the libosso auto-save callback.
1616 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1618 * src/maemo/modest-platform.c:
1619 (modest_platform_set_update_interval):
1620 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1621 aparently stays valid between application instances, so we can use this
1622 to remove and reset it later. According to a maemo-developers email from
1625 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1627 * configure.ac: Depend on libalarm for Maemo.
1629 * src/dbus_api/modest-dbus-api.h:
1630 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1631 (on_send_receive), (modest_dbus_req_handler):
1632 Handle a SEND_RECEIVE D-Bus method.
1634 * libmodest-dbus-client/libmodest-dbus-client.c:
1635 (libmodest_dbus_client_send_and_receive):
1636 * libmodest-dbus-client/libmodest-dbus-client.h:
1637 Add C convenience functions for calling the new D-Bus method.
1639 * src/modest-platform.h:
1640 * src/gnome/modest-platform.c:
1641 * src/maemo/modest-platform.c:
1642 Added modest_platform_set_update_interval(), which uses the
1643 alarmd API on Maemo.
1644 (modest_platform_init),
1645 Call modest_platform_set_update_interval(), using a hard-coded
1646 interval for now (until the global settings dialog is implemented),
1647 though I am not sure that this makes sense yet.
1649 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1651 * src/dbus_api/modest-dbus-callbacks.c:
1652 (modest_osso_cb_hw_state_handler):
1653 * src/dbus_api/modest-dbus-callbacks.h:
1654 * src/maemo/modest-platform.c: (modest_platform_init):
1655 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1656 in case this has some effect on the ability for Maemo to ping the
1659 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1661 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1662 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1663 warning. It is probably a logic error, but I need to fix the build.
1665 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1667 * src/modest-account-mgr.h:
1668 * src/modest-account-mgr.c:
1669 (modest_account_mgr_account_names): Add a gboolean enabled_only
1670 parameter, so we can get lists of onlt the enabled accounts.
1672 (modest_account_mgr_add_account),,
1673 (modest_account_mgr_account_with_display_name_exists):
1674 * src/maemo/modest-msg-edit-window.c: (get_transports):
1675 * src/modest-account-mgr-helpers.c:
1676 (modest_account_mgr_set_first_account_as_default):
1677 * src/modest-init.c: (init_default_account_maybe):
1678 * src/modest-tny-account-store.c: (get_accounts):
1679 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1680 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1681 * tests/check_account-mgr.c: (START_TEST):
1682 Provide the extra parameter, as appropriate.
1684 * src/widgets/modest-account-view.c: (update_account_view):
1685 Do not show disabled accounts (meaning that there is no way to
1686 enable/disable accounts in the UI (the feature is not in our UI
1687 specification), so we can use this internally only to mark unfinished
1688 or temporary account data.
1690 * src/maemo/easysetup/modest-easysetup-wizard.c:
1691 (create_account): Add boolean enable parameter, so we can specify FALSE
1692 to create the temporary account.
1693 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1694 (on_before_next): When finishing, when there is a temporary account, just
1696 Also, use a timeout to delay the showing of the dialog until gconf is likely
1697 to return correct information, due to a maemo gconf bug that is fixed in
1698 osso 1.1, but not yet in Bora.
1699 However, the dialog stays on screen after it is destroyed.
1701 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1702 for invalid data when cancelling. Use a hildon note instead of a dialog
1703 to complain about invalid data. Do not show the account-saved note if the
1704 account is disabled (a temporary account that will not really be saved for use
1707 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1709 * src/modest-account-mgr-helpers.h:
1710 * src/modest-account-mgr-helpers.c:
1711 Added modest_account_mgr_unset_default_account(),
1712 Added modest_account_mgr_set_first_account_as_default().
1714 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1715 If it was the default account, unset the default account name.
1717 * src/maemo/modest-account-view-window.c:
1718 (on_delete_button_clicked): If it was the default account,
1719 set the first remaining account as the default instead.
1721 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1722 a NULL account or a NULL default account, to prevent a crash. This should
1723 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1726 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1728 * src/widgets/modest-recpt-editor.c:
1729 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1730 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1731 TODO comment for this. This fixes the build.
1733 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1734 be the best place for it. This will in future update all auto-update accounts,
1735 rather than just the current/default account, when that gconf key exists.
1736 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1737 if there are no accounts, before calling do_send_receive().
1738 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1740 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1741 * src/maemo/modest-main-window-ui.h:
1742 * src/maemo/modest-main-window.c: (on_connection_changed),
1743 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1744 directly, becaue the signal handler does more.
1746 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1748 * src/modest-account-mgr-helpers.c:
1749 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1750 for the case that the account does not exist.
1752 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1753 (equivalent to the modest account name) rather than the tinymail account name
1754 (equivalent to the modest account title - human readable) to get the account data.
1755 Check for null account data to prevent the crash, and add a TODO comment saying that
1756 this needs fixing because it is using the server account name instead of the account name.
1758 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1760 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1761 * src/maemo/modest-account-settings-dialog.c: (show_error),
1763 Use hildon_note_new_information() for informative and error messages,
1764 which seems to be expected for Maemo applications (no documentation that I know of
1765 says this). I am surprised that there is no distinction between info and error
1768 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1770 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1771 it is easy to find where this is used.
1773 * src/maemo/easysetup/modest-easysetup-wizard.c:
1774 (create_page_welcome), (create_page_account_details),
1775 (create_page_user_details), (create_page_complete_easysetup),
1776 (create_page_custom_incoming), (create_page_custom_outgoing),
1777 (create_page_complete_custom):
1778 * src/maemo/modest-account-settings-dialog.c:
1779 (create_page_account_details), (create_page_user_details),
1780 (create_page_incoming), (create_page_outgoing):
1781 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1782 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1783 (modest_connection_specific_smtp_edit_window_init):
1784 * src/maemo/modest-connection-specific-smtp-window.c:
1785 (modest_connection_specific_smtp_window_init):
1786 * src/maemo/modest-signature-editor-dialog.c:
1787 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1788 and scrolling policy as per the Email Application Layout Guide, if I have
1791 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1793 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1794 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1795 which were empty, because these vfuncs have been removed from TnyAccountStore.
1796 This fixes the build.
1798 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1800 * src/maemo/modest-main-window.c:
1801 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1802 showing/hiding it. Added TODO because it probably should not be NULL.
1803 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1804 because unnecessary g_warnings() make degugging difficult.
1806 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1808 * src/maemo/modest-msg-edit-window.c:
1809 (modest_msg_edit_window_select_color),
1810 (modest_msg_edit_window_select_background_color): 2 const corrections and
1811 moving 2 #endifs before closing brackets, to fix the build.
1813 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1815 * src/maemo/easysetup/modest-easysetup-wizard.h:
1816 * src/maemo/easysetup/modest-easysetup-wizard.c:
1817 (modest_easysetup_wizard_dialog_finalize),
1818 (on_button_edit_advanced_settings), (create_page_complete_custom),
1819 (on_response), (create_account):
1820 Implement the Advanced Settings edit button, by saving the account information,
1821 for the Advanded Settings dialog to use directly from gconf, and removing it
1822 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1823 Bug #5533 in the projects.maemo.org bugzilla.
1825 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1827 * src/maemo/modest-msg-view-window.c:
1828 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1829 when opening a message window.
1831 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1833 * src/maemo/easysetup/modest-easysetup-wizard.c:
1834 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1837 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1838 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1839 gconf settings. I probably added more checks than necessary, but that is safer.
1841 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1842 variable to fix the build, but this seems to be used when it is still NULL.
1844 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1846 * src/modest-platform.h:
1847 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1848 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1849 * src/modest-main.c: Implement this function so we can avoid using
1850 maemo-specific API from cross-platform code.
1852 * src/modest-tny-account-store.c:
1853 (get_smtp_specific_transport_account_for_open_connection):
1854 * src/modest-ui-actions.c: (check_for_connection),
1855 (modest_ui_actions_on_item_not_found):
1856 Use modest_platform_connect_and_wait() and put #idefs around other
1857 maemo-specific code, because only maemo currently has a way to
1858 identify connection names.
1860 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1862 * src/modest-tny-account-store.h:
1863 * src/modest-tny-account-store.c:
1864 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1865 the connection-specific SMTP server settings in the configuration.
1867 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1869 * src/maemo/modest-main-window.c: (on_connection_changed),
1871 * src/modest-main.c: (main), (start_ui), (send_mail):
1872 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1873 that is what is intended.
1875 * src/modest-ui-actions.c: (action_send), (action_receive),
1876 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1877 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1878 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1879 SMTP server is used when it is specified.
1881 (modest_ui_actions_on_send_receive):
1882 Check that a connection is open before proceeding.
1883 Receive and then send, instead of vice-versa, as per the specification.
1885 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1887 * src/modest-mail-operation.c:
1888 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1889 though I guess it should be something other than NULL.
1891 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1893 * src/maemo/easysetup/modest-easysetup-wizard.c:
1894 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1895 combo twice, to avoid an g_warning and to make it visible again.
1896 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1897 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1898 (already intended) dereference when detaching, because we then recreate the menu.
1899 But I am not sure why the warning was happening, and it is possible that this is a memory
1902 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1904 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1905 and uri_parse_mailto() utility functions.
1906 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1908 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1910 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1912 * src/dbus_api/modest-dbus-api.h:
1913 * src/dbus_api/modest-dbus-callbacks.c:
1914 Use an idle callback to execute the modest code in the application's own thread.
1915 Remove the helloworld example method.
1916 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1917 parsed, and the open-message method is not implemented because this is not yet implemented in
1919 * libmodest-dbus-client/libmodest-dbus-client.c:
1920 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1921 (libmodest_dbus_client_open_message):
1922 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1924 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1925 body without crashing.
1927 * tests/dbus_api/Makefile.am:
1928 * tests/dbus_api/test_mail_to.c:
1929 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1931 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1933 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1934 Added file to fix the build. Sorry.
1936 * src/dbus_api/Makefile.am:
1937 * src/dbus_api/modest-dbus-api.h:
1938 * src/dbus_api/modest-dbus-callbacks.h:
1939 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1940 (modest_dbus_req_handler):
1941 Put constants in a separate header so it can be reused by the
1942 client library, without duplication
1944 * libmodest-dbus-client/Makefile.am:
1945 * libmodest-dbus-client/libmodest-dbus-client.c:
1946 (libmodest_dbus_client_call_helloworld),
1947 (libmodfest_dbus_client_send_mail),
1948 (libmodfest_dbus_client_mailto),
1949 (libmodfest_dbus_client_open_message):
1950 * libmodest-dbus-client/libmodest-dbus-client.h:
1951 (Partly) Implement a send_mail D-Bus method.
1953 * tests/dbus_api/Makefile.am:
1954 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1955 the send_email D-Bus method.
1957 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1961 * libmodest-dbus-client/Makefile.am:
1962 * libmodest-dbus-client/libmodest-dbus-client.c:
1963 * libmodest-dbus-client/libmodest-dbus-client.h:
1964 * tests/dbus_api/Makefile.am:
1965 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1966 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1968 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1970 * src/maemo/easysetup/modest-easysetup-wizard.c:
1971 (create_page_account_details):
1972 * src/maemo/modest-account-settings-dialog.c:
1973 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1974 widgets, because this might not be the default in future versions of the Maemo GTK+.
1975 However, I can not not get capitalization to work even in a simple test case.
1977 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1979 * src/maemo/easysetup/modest-easysetup-wizard.c:
1980 (create_page_custom_incoming), (create_page_custom_outgoing):
1981 * src/maemo/modest-account-settings-dialog.c:
1982 (create_page_account_details), (create_page_incoming),
1983 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1984 instead of using gtk_check_button_with_label(), so they are aligned like the other
1985 widgets, as per the UI spec.
1987 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1989 * src/maemo/easysetup/modest-easysetup-wizard.c:
1990 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1991 * src/widgets/modest-validating-entry.c:
1992 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1993 Modest prefix instead of an EasySetup prefix.
1995 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1997 * src/widgets/modest-validating-entry.h:
1998 * src/widgets/modest-validating-entry.c: (on_insert_text),
1999 Added easysetup_validating_entry_set_max_func(), used to set a callback
2000 to call when the max number of characters is reached. GtkEntry has a max-length
2001 already but is silent about it.
2003 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2004 (create_page_account_details), (create_page_user_details),
2006 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2007 (create_page_account_details), (create_page_user_details),
2008 (create_page_outgoing):
2009 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2010 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2011 the UI spec, when the user tries to enter more than the max number of characters.
2013 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2015 * src/maemo/easysetup/modest-easysetup-wizard.c:
2016 (create_page_user_details), (create_page_custom_incoming),
2017 (create_page_custom_outgoing):
2018 * src/maemo/modest-account-settings-dialog.c:
2019 (create_page_user_details), (create_page_incoming),
2020 (create_page_outgoing):
2021 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2022 (modest_connection_specific_smtp_edit_window_init):
2023 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2024 not appropriate. Bad Maemo-specific defaults!.
2026 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2028 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2029 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2030 (modest_signature_editor_dialog_set_settings):
2031 Disable the label and textview when the checkbox is disabled, and use the
2032 specified (UI spec) default signature text.
2034 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2036 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2037 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2039 * src/modest-defs.h:
2040 * src/modest-account-mgr-helpers.h:
2041 * src/modest-account-mgr-helpers.c:
2042 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2044 * src/maemo/Makefile.am:
2045 * src/maemo/modest-signature-editor-dialog.c:
2046 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2049 * src/maemo/modest-account-settings-dialog.h:
2050 * src/maemo/modest-account-settings-dialog.c:
2051 (modest_account_settings_dialog_finalize), (on_button_signature),
2052 (save_configuration): Use the new dialog when the Edit button is pressed, and
2053 save the changes if necessary, as per the UI spec.
2055 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2057 * src/maemo/Makefile.am:
2058 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2059 based on maemo-develoers email from Dirk.
2061 * src/maemo/easysetup/modest-easysetup-wizard.c:
2062 (create_page_welcome), (create_page_account_details),
2063 (create_page_user_details), (create_page_complete_easysetup),
2064 (create_page_custom_incoming), (create_page_custom_outgoing),
2065 (create_page_complete_custom),
2066 (modest_easysetup_wizard_dialog_init):
2067 * src/maemo/modest-account-settings-dialog.c:
2068 (create_page_account_details), (create_page_user_details),
2069 (create_page_incoming), (create_page_outgoing),
2070 (modest_account_settings_dialog_init):
2071 * src/maemo/modest-connection-specific-smtp-window.c:
2072 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2074 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2076 * src/maemo/easysetup/modest-easysetup-wizard.c:
2077 (create_page_account_details), (create_page_custom_outgoing),
2078 (create_page_complete_custom):
2079 * src/maemo/modest-account-settings-dialog.c:
2080 (create_page_user_details), (create_page_incoming),
2081 (create_page_outgoing):
2082 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2083 (modest_connection_specific_smtp_edit_window_init):
2084 Use the correct (UI spec) port min/max, and use horizontal separators,
2087 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2089 * src/maemo/easysetup/modest-easysetup-wizard.c:
2090 (set_default_custom_servernames):
2091 * src/maemo/modest-account-settings-dialog.c:
2092 (create_page_incoming), (on_combo_outgoing_security_changed),
2093 (on_combo_incoming_security_changed), (create_page_outgoing),
2094 (modest_account_settings_dialog_set_account_name),
2095 (save_configuration):
2096 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2097 (on_combo_security_changed),
2098 (modest_connection_specific_smtp_edit_window_init),
2099 (modest_connection_specific_smtp_edit_window_set_connection),
2100 (modest_connection_specific_smtp_edit_window_get_settings):
2101 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2104 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2107 * src/maemo/easysetup/modest-easysetup-wizard.c:
2108 (create_page_custom_outgoing), (create_page_complete_custom):
2109 * src/maemo/modest-account-settings-dialog.c:
2110 (create_page_user_details), (create_page_outgoing):
2111 * src/maemo/modest-account-view-window.c: (button_box_new):
2112 Use changed logical IDs as per the most recent UI spec:
2113 mcen_bd_emailsetup_edit -> mcen_bd_edit
2114 mcen_bd_emailsetup_delete -> mcen_bd_delete
2115 mcen_bd_emailsetup_close -> mcen_bd_close
2117 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2121 * src/dbus_api/Makefile.am:
2122 * src/dbus_api/modest-dbus-callbacks.c:
2123 * src/dbus_api/modest-dbus-callbacks.h:
2124 * src/maemo/modest-platform.c: (modest_platform_init):
2125 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2127 * tests/Makefile.am:
2128 * tests/dbus_api/Makefile.am:
2129 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2131 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2133 * src/maemo/modest-account-settings-dialog.c:
2134 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2135 Removed unnecessary includes.
2137 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2139 * src/maemo/easysetup/modest-easysetup-wizard.c:
2140 * src/maemo/modest-account-settings-dialog.c:
2141 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2142 * src/widgets/Makefile.am:
2143 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2144 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2145 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2146 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2147 * src/widgets/modest-secureauth-combo-box.c:
2148 * src/widgets/modest-secureauth-combo-box.h:
2149 * src/widgets/modest-serversecurity-combo-box.c:
2150 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2151 made the GObject names more consistent with the rest of the Modest code.
2153 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2155 * src/maemo/easysetup/Makefile.am:
2156 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2157 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2158 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2159 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2160 * src/maemo/easysetup/modest-easysetup-wizard.c:
2161 * src/maemo/easysetup/modest-validating-entry.c:
2162 * src/maemo/easysetup/modest-validating-entry.h:
2163 * src/maemo/modest-account-settings-dialog.c:
2164 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2165 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2166 widgets/ because they are used outside of easysetup too. After checking in,
2167 svn will allow me to rename them too.
2169 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2171 * src/gnome/modest-msg-edit-window.c:
2172 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2173 linker error, to fix the build on the GNOME platform.
2174 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2175 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2176 ifdefed out to avoid a warning.
2178 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2180 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2181 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2182 some alternative for GTK+ 2.6.
2184 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2186 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2188 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2189 specified for EmailAccountsDialog in UI spec.
2191 * src/maemo/easysetup/modest-easysetup-wizard.c:
2192 * src/maemo/easysetup/modest-easysetup-wizard.h:
2193 * src/maemo/modest-account-settings-dialog.c:
2194 * src/maemo/modest-account-settings-dialog.h:
2195 Reuse a member window widget for the connection-specific SMTP server accounts,
2196 so we can tell it to create/save the accounts only if we actually save changes.
2198 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2199 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2200 (modest_connection_specific_smtp_edit_window_get_settings):
2201 Return a struct instance for temporarily remembering the entered data.
2203 * src/maemo/modest-connection-specific-smtp-window.h:
2204 * src/maemo/modest-connection-specific-smtp-window.c:
2205 (modest_connection_specific_smtp_window_finalize),
2206 (modest_connection_specific_smtp_window_fill_with_connections),
2208 (modest_connection_specific_smtp_window_save_server_accounts),
2209 (update_model_server_names): Do not actually save data until asked,
2210 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2212 (on_selection_changed),
2213 (modest_connection_specific_smtp_window_init): Disable the edit
2214 button when nothing is selected.
2216 * src/modest-account-mgr-helpers.c:
2217 * src/modest-account-mgr-helpers.h:
2218 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2221 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2223 * src/modest-account-mgr-helpers.h:
2224 * src/modest-account-mgr-helpers.c:
2225 (modest_account_mgr_get_unused_account_name),
2226 (modest_account_mgr_get_unused_account_display_name): Added these
2227 utility functions, to avoid code duplication.
2229 * src/maemo/easysetup/modest-easysetup-wizard.c:
2230 (create_page_account_details), (create_account):
2231 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2232 (on_combo_security_changed),
2233 (modest_connection_specific_smtp_edit_window_init),
2234 (modest_connection_specific_smtp_edit_window_save_settings):
2235 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2236 * src/maemo/modest-connection-specific-smtp-window.c:
2237 (modest_connection_specific_smtp_window_finalize),
2238 (modest_connection_specific_smtp_window_fill_with_connections),
2239 (on_button_edit), (modest_connection_specific_smtp_window_init):
2240 * src/maemo/modest-connection-specific-smtp-window.h:
2241 Implementing saving of connection-specific server accounts.
2243 But I need to refactor this so we can save the data for each
2244 possible connection-specific account and only actually create the server accounts
2245 when the easysetup finished, or the OK button is pressed on the account settings
2248 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2250 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2251 (on_combo_security_changed):
2252 (modest_connection_specific_smtp_edit_window_init):
2253 Auto-fill the port number as in the account settings.
2255 (modest_connection_specific_smtp_edit_window_set_connection):
2256 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2257 * src/maemo/modest-connection-specific-smtp-window.c:
2258 (fill_with_connections), (on_button_edit),
2259 (modest_connection_specific_smtp_window_init):
2260 Turn the edit window into a dialog to simplify the code, and
2261 set a WM hint as in a GtkDialog, because only a popup can be on top of
2262 another window in Maemo, and popups usually have no WM decoration.
2264 * src/modest-defs.h:
2265 * src/modest-account-mgr-helpers.c:
2266 (modest_account_mgr_set_connection_specific_smtp),
2267 (modest_account_mgr_remove_connection_specific_smtp),
2268 (modest_account_mgr_get_connection_specific_smtp):
2269 * src/modest-account-mgr-helpers.h: Some functions to write the
2270 connection-specific SMTP server information. Not yet used.
2273 * src/widgets/modest-folder-view.c: (text_cell_data):
2274 Fix a warning about an uninitialized variable.
2275 (on_configuration_key_changed): Put an #ifdef around the use
2276 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2278 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2280 * src/maemo/modest-account-settings-dialog.h:
2281 * src/maemo/modest-account-settings-dialog.c:
2282 Added connect_for_modified() utility function to mark the new modified boolean.
2284 (create_page_account_details), (create_page_user_details),
2285 (create_page_incoming), (create_page_outgoing), (on_response),
2286 (modest_account_settings_dialog_init),
2287 (modest_account_settings_dialog_set_account_name):
2288 Only warn about unsaved changes when there are actually unsaved changes.
2290 * src/modest-account-mgr-helpers.c:
2291 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2292 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2293 to get the data from there in future.
2295 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2297 * src/modest-defs.h:
2299 * src/modest-account-mgr-helpers.h:
2300 * src/modest-account-mgr-helpers.c:
2301 Store the security account setting in a single conf key instead of using
2302 the options list, so that the list is left for just the to-be-removed camel hack,
2303 and because gconf_client_set_list() is failing for some reason.
2305 * src/modest-account-mgr.c:
2306 (modest_account_mgr_add_server_account):
2307 * src/maemo/modest-account-settings-dialog.c:
2308 (modest_account_settings_dialog_set_account_name),
2309 (save_configuration): Use the renamed functions.
2312 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2314 * src/widgets/Makefile.am:
2315 * src/widgets/modest-limit-retrieve-combo-box.c:
2316 * src/widgets/modest-limit-retrieve-combo-box.h:
2317 * src/widgets/modest-retrieve-combo-box.c:
2318 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2319 the account settings dialog.
2321 * src/modest-defs.h:
2322 * src/modest-account-mgr-helpers.h:
2323 * src/modest-account-mgr-helpers.c:
2324 (modest_server_account_get_option_secure_auth),
2325 (modest_server_account_set_option_secure_auth):
2326 * src/modest-account-mgr.c:
2327 (modest_account_mgr_add_server_account):
2328 Use the existing AUTH_MECH conf key for the secure-auth setting,
2329 instead of putting it in the list options, because this was actually used already.
2331 * src/maemo/modest-account-settings-dialog.c:
2332 (create_page_account_details),
2333 (modest_account_settings_dialog_set_account_name),
2334 (save_configuration):
2335 * src/maemo/modest-account-settings-dialog.h:
2336 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2337 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2339 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2341 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2342 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2343 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2345 * src/modest-defs.h:
2346 * src/maemo/modest-account-settings-dialog.c:
2347 (create_page_incoming), (on_combo_outgoing_security_changed),
2348 (on_combo_incoming_security_changed), (create_page_outgoing),
2349 (modest_account_settings_dialog_set_account_name),
2350 (save_configuration): Load/Save the port number, and change it when the
2351 security combo changes, to suitable defaults.
2353 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2355 * src/modest-account-mgr.c:
2356 (modest_account_mgr_add_server_account): Set the security and secure-auth
2357 options, and add a comment saying that the other camel-specific options should be
2360 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2362 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2364 * src/modest-tny-account-store.c: (account_list_free),
2365 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2366 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2369 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2371 * src/modest-protocol-info.c:
2372 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2373 is required by our UI spec. Maybe something in our implementation will use this eventually.
2374 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2375 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2376 instead of the previous 0 placeholder.
2378 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2379 secure-auth settings.
2380 * src/modest-account-mgr-helpers.h:
2381 * src/modest-account-mgr-helpers.c:
2382 (modest_server_account_data_get_option_secure_auth),
2383 (modest_server_account_set_option_secure_auth),
2384 (modest_server_account_data_get_option_security),
2385 (modest_server_account_set_option_security): Added this API for getting and setting the security
2386 and secure-auth settings.
2388 * src/maemo/modest-account-settings-dialog.h:
2389 * src/maemo/modest-account-settings-dialog.c:
2390 (modest_account_settings_dialog_finalize), (check_data),
2391 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2392 about changing titles.
2393 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2394 (save_configuration): Save the security and secure-auth settings.
2396 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2397 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2399 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2401 * src/modest-defs.h:
2402 * src/modest-account-mgr.c:
2403 (modest_account_mgr_add_server_account):
2404 Added and used defines for the options key and value pair strings,
2405 that are used so far, though they do not seem to correspond to anything in our
2406 UI specs or ModestProtocol enum.
2408 * src/modest-account-mgr-helpers.h:
2409 * src/modest-account-mgr-helpers.c:
2410 (compare_option_strings_for_name),
2411 (modest_server_account_data_get_option_value),
2412 (modest_server_account_data_get_option_bool),
2413 (modest_account_mgr_get_server_account_option):
2414 Added helper functions for parsing the options GSList.
2416 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2418 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2419 display name is based on the supplied account name.
2420 * src/modest-account-mgr.c:
2421 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2422 with an inefficient, but good-enough, implementation.
2424 * src/maemo/easysetup/modest-easysetup-wizard.c:
2425 (create_page_account_details), (on_before_next), (create_account):
2426 Check for existing display names rather than (non-user-visible) account names, and just
2427 create and set a unique account name at the end.
2429 * src/maemo/modest-account-settings-dialog.c:
2430 (modest_account_settings_dialog_init),
2431 (modest_account_settings_dialog_set_account_name),
2432 (create_page_incoming): Show the display name, instead of the account name.
2433 (on_response): Do some (not all) extra checks, as in the UI spec.
2434 (save_configuration): Save the display name if it was changed.
2436 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2438 * po/en_GB.po: Added needed logical ID and translation.
2439 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2440 (init_view): Made the is-default column clicking work.
2442 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2445 * src/maemo/easysetup/Makefile.am:
2446 * src/maemo/easysetup/modest-easysetup-wizard.c:
2447 (modest_easysetup_wizard_dialog_init):
2448 * src/maemo/easysetup/provider-data-test.keyfile:
2449 * src/maemo/easysetup/provider-data.keyfile:
2450 Moved the provider data file to the new modest-providers-data package and used it from there.
2452 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2454 * src/modest-local-folder-info.c:
2455 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2456 N_() was already used on the static strings, but this just marks it for translation without
2457 using the translation.
2459 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2461 * src/maemo/modest-account-settings-dialog.c:
2462 (create_page_incoming),
2463 (modest_account_settings_dialog_set_account_name):
2464 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2465 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2466 I will do this if nobody else gets there first.
2468 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2470 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2471 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2472 save the security stuff.
2474 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2476 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2477 Set the email address and user fullname, which I now see must be
2480 * src/maemo/modest-account-settings-dialog.h:
2481 * src/maemo/modest-account-settings-dialog.c:
2483 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2484 leave-on-server and authentication.
2485 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2488 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2491 * src/maemo/modest-account-settings-dialog.c:
2492 * src/maemo/modest-account-settings-dialog.h:
2493 Most (but not all) of the widgets are now present as specified by the UI spec.
2494 No changes are yet saved, and some details are not properly shown yet.
2496 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2498 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2500 * src/maemo/Makefile.am:
2501 * src/maemo/modest-account-settings-dialog.c:
2502 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2503 an existing account. Doesn't do much yet.
2505 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2506 Open the accounts settings dialog when Edit is clicked.
2508 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2510 * src/maemo/easysetup/Makefile.am:
2511 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2513 * src/maemo/easysetup/modest-easysetup-wizard.c:
2514 (modest_easysetup_wizard_dialog_init):
2515 Try to get the source directory from the build system,
2516 instead of hard-coding "./" into the source code, when opening our local
2517 copies of the configuration files.
2518 But this still fails when opening the wizard from the Accounts window,
2519 maybe because the working directory seems to change at runtime.
2520 So the wizard will fail the second time unless you copy the files into their
2521 proper locations - see the stdout warnings for the paths.
2523 (create_page_account_details),(on_before_next):
2524 Check for existing non-server accounts instead of server accounts,
2525 so the default account name is useful again, and to prevent trying to
2528 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2529 Show the wizard when New is clicked.
2531 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2532 (init_view): Show the column headers, and show the columns that are
2533 specified in the UI specs. However, something in Maemo's GTK+ prevents
2534 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2535 change the default account. This is despite unsetting the special properties.
2537 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2539 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2540 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2541 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2542 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2543 to make that clearer.
2544 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2546 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2548 * src/maemo/modest-account-view-window.c:
2549 (modest_account_view_window_init),
2550 (modest_account_view_window_new):
2551 Use the same buttons as specified in the
2552 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2553 the existing widgets, which never had a chance of working.
2554 Put the ModestAccountView treeview in a scrolled window.
2555 Do not repeat the initialization in both _init() and _new().
2557 * src/widgets/modest-account-view.c: (update_account_view):
2558 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2559 this widget and window shows no accounts.
2561 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2563 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2565 * src/maemo/easysetup/modest-easysetup-wizard.c:
2566 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2567 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2568 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2571 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2572 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2573 accounts exist yet, as in the UI spec.
2575 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2577 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2579 * src/maemo/Makefile.am:
2580 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2581 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2582 New window for editing connection-specific smtp details.
2583 Not fully implemented.
2585 * src/maemo/modest-connection-specific-smtp-window.c:
2586 (modest_connection_specific_smtp_window_finalize) :
2587 unref the tree model.
2588 (on_button_edit): Show the edit window.
2590 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2592 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2595 * src/maemo/Makefile.am:
2596 * src/maemo/modest-connection-specific-smtp-window.c:
2597 * src/maemo/modest-connection-specific-smtp-window.h:
2598 New window for showing the list of connections, for connection-specific
2599 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2600 * src/maemo/easysetup/modest-easysetup-wizard.c:
2601 (create_page_custom_outgoing): Show the new window when the button is clicked.
2603 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2605 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2606 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2607 * src/maemo/modest-msg-edit-window.c:
2608 (modest_msg_edit_window_insert_image):
2609 * src/modest-conf.c: (modest_conf_key_escape):
2610 * src/modest-mail-operation.c:
2611 (modest_mail_operation_send_new_mail):
2612 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2613 (modest_ui_actions_on_new_account):
2614 * src/widgets/modest-attachment-view.c: (update_filename_request):
2615 * src/widgets/modest-mail-header-view.c:
2616 Corrected warnings that were breaking the build, by commenting out unused variables,
2617 and a function, and by including a header.
2619 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2621 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2622 so we can #ifdef around platform-specific code when necessary.
2623 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2624 to allow this to build for the GNOME platform too.
2626 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2628 * src/maemo/easysetup/modest-easysetup-wizard.c:
2629 Added util_increment_name() and used it in create_page_account_details()
2630 to make sure that the default account name is always a new name.
2632 (modest_easysetup_wizard_dialog_init),
2633 (set_default_custom_servernames): Some minor memory management fixes.
2635 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2639 * src/modest-runtime.c: (init_i18n): Restored the translation
2640 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2641 are defined in config.h, and the translations are installed.
2643 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2644 is defined for translation.
2646 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2648 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2650 * src/maemo/easysetup/modest-easysetup-wizard.c:
2651 (modest_easysetup_wizard_dialog_init):
2652 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2653 Use realistic paths (though they should use $prefix generically) to the
2654 mcc_mapping and provider-data.keyfile files which might work when they
2655 are installed by the future version of the operator-wizard package,
2656 and then fallback to paths in our source code, with an explanatory
2659 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2663 * src/maemo/Makefile.am:
2664 * src/maemo/easysetup/: Added files from the previously-exernal
2665 osso-modest-easysetup.
2666 * src/maemo/modest-main-window-ui.h:
2667 * src/modest-ui-actions.c:
2668 * src/modest-ui-actions.h:
2669 Added modest_ui_actions_on_new_account() as a signal handler for the
2670 New Account menu item. It shows the easysetup wizard.
2671 * po/en_GB.po: Added additional needed logical IDs and translations.
2673 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2674 Apparently ChangeLog is not used for some vague Nokia legal reasons.