1 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
4 Fixed build if libogs is not available
6 2007-06-03 Christian Kellner <ckellner@openismus.com>
8 * libmodest-dbus-client/libmodest-dbus-client.h:
9 * libmodest-dbus-client/libmodest-dbus-client.c:
10 (libmodest_dbus_client_delete_message):
11 Implement deletion of messages (Client side).
13 (modest_search_hit_free),
14 (modest_search_hit_list_free):
15 Utility functions to free the result hits.
17 * src/dbus_api/modest-dbus-api.h:
18 * src/dbus_api/modest-dbus-callbacks.c:
20 (modest_dbus_req_handler):
21 Implement deletion of messages (Server side).
23 * tests/dbus_api/test_search.c: (main):
26 * tests/dbus_api/Makefile.am:
27 * tests/dbus_api/test_delete_message:
28 Add little test for the message deletion logic
30 2007-06-03 Armin Burgmeier <armin@openismus.com>
32 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
33 when the operation queue was not empty. projects.maemo.org bug
36 2007-06-03 Armin Burgmeier <armin@openismus.com>
38 * src/widgets/modest-account-view.c
39 (on_account_default_toggled): Toggle default account column
40 explicitely instead of waiting for gconf notification (which is
41 currently ignored). This should fix projects.maemo.org bug NB#56910
42 for now. It should probably be removed when gconf notifications are
45 2007-06-03 Christian Kellner <ckellner@openismus.com>
47 * libmodest-dbus-client/libmodest-dbus-client.c:
48 Removed debugging spew.
50 * src/dbus_api/modest-dbus-callbacks.c:
53 * src/modest-search.c:
54 (modest_search_all_accounts):
55 Use tny_account_store_get_accounts () on the account store
56 to get all accounts which is the way to get all accounts.
58 * tests/dbus_api/test_search.c: (main):
59 Make it possible to supply the search term on the command line.
61 2007-06-03 Christian Kellner <ckellner@openismus.com>
63 * libmodest-dbus-client/libmodest-dbus-client.c:
64 * libmodest-dbus-client/libmodest-dbus-client.h:
65 Implement searching for mesages over raw dbus. (Client side)
67 * src/dbus_api/Makefile.am:
68 * src/dbus_api/modest-dbus-api.h:
69 * src/dbus_api/modest-dbus-callbacks.c:
70 * src/dbus_api/modest-dbus-callbacks.h:
71 Search framework (Server side). Also implement on_idle_open_message().
73 * src/maemo/modest-platform.c: (modest_platform_init):
74 Prepare for raw dbus/osso rpc interaction.
76 * src/modest-search.h:
77 Changed minsize from unspecific guint to guint32.
79 * src/modest-search.c:
81 Added strange hack which magically made tnymail work.
83 (modest_search_folder),
84 (modest_search_account),
85 (modest_search_all_accounts):
86 Implement helper functions to search all accounts, specific account
89 * tests/dbus_api/Makefile.am:
90 * tests/dbus_api/test_open_message.c:
91 Read url to open from commandline.
93 * tests/dbus_api/test_search.c:
94 Implement small test for dbus search stuff
96 2007-06-02 Armin Burgmeier <armin@openismus.com>
98 * src/maemo/modest-account-settings-dialog.c: Changed window title to
99 include account type and account title. This fixes projects.maemo.org
102 * src/maemo/modest-account-view-window.c: Set a title for the window.
104 2007-06-02 Armin Burgmeier <armin@openismus.com>
106 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
107 incoming and outgoing server name based on email address and server
108 types as long as the names have not been edited manually. This fixes
109 projects.maemo.org bug NB#58671.
111 2007-06-02 Armin Burgmeier <armin@openismus.com>
113 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
114 server type cannot be changed in future to the incoming details page
115 when creating an account. This fixes projects.maemo.org bug NB#59029.
117 2007-06-02 Armin Burgmeier <armin@openismus.com>
119 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
120 and assigned max width chars so that they wrap instead of being
121 truncated. Fixes projects.maemo.org bug NB#56126.
123 2007-06-02 Armin Burgmeier <armin@openismus.com>
125 * src/maemo/modest-connection-specific-smtp-window.c: Add an
126 introductory note to the connection specific smtp servers dialog, as
127 section 8.12 of the email UI specification requires. This fixes
128 projects.maemo.org bug NB#59212.
130 2007-06-01 Murray Cumming <murrayc@murrayc.com>
132 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
133 Check for running mail operations, and offer to cancel them, as per the UI
134 spec. This fixes projects.maemo.org bug NB#59041 .
135 However, I suspect that tinymail may still use the network connection
136 in ways that we cannot detect or cancel. But it should at least adapt to
139 2007-06-01 Murray Cumming <murrayc@murrayc.com>
141 * src/modest-tny-account-store.c: (recreate_all_accounts),
142 (get_cached_accounts), (get_server_accounts): Do more sensible
143 ref-counting of the temporarily-cached outbox accounts list. This seems
144 to fix a crash when entering the password when the password was wrong.
146 2007-06-01 Murray Cumming <murrayc@murrayc.com>
148 * src/gnome/modest-main-window.c: (connect_signals):
149 * src/modest-tny-account-store.c: (get_password),
150 (modest_tny_account_store_alert): Added comments and clues and
151 commented-out code about how we currently fail to deal with connection
152 errors and wrong passwords, and how we should.
154 2007-06-01 Murray Cumming <murrayc@murrayc.com>
156 * src/widgets/modest-retrieve-combo-box.c:
157 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
158 This fixes projects.maemo.org bug NB#58472 .
160 2007-06-01 Murray Cumming <murrayc@murrayc.com>
162 * src/maemo/easysetup/modest-easysetup-wizard.c:
163 (create_page_complete_easysetup):
164 (create_page_complete_custom): Correct the last commit,
165 putting the correct sentences in the correct pages.
167 2007-06-01 Murray Cumming <murrayc@murrayc.com>
169 * src/maemo/easysetup/modest-easysetup-wizard.c:
170 (create_page_complete_custom): Show the second sentence of text
171 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
174 2007-06-01 Murray Cumming <murrayc@murrayc.com>
176 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
177 Set the leave-on-server conf key by default. This fixes
178 projects.maemo.org bug NB#59258 .
180 2007-06-01 Murray Cumming <murrayc@murrayc.com>
182 * src/maemo/modest-account-view-window.c:
183 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
184 logical ID for the confirmation messages. Fixed projects.maemo.org bug
187 2007-06-01 Murray Cumming <murrayc@murrayc.com>
189 * src/maemo/easysetup/modest-easysetup-wizard.c:
190 (create_caption_new_with_asterisk):
191 * src/maemo/modest-account-settings-dialog.c:
192 (create_caption_new_with_asterisk):
193 Uncomment the code to add the asterisk, because they are no longer in the
194 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
195 (update_incoming_server_title): Add an asterisk here too.
197 2007-06-01 Murray Cumming <murrayc@murrayc.com>
199 * src/maemo/modest-maemo-global-settings-dialog.c:
200 (current_connection): Check that we are even connected before trying to
201 get the current connection name, to prevent a warning.
203 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
204 Change the comments because tny_maemo_conic_device_connect() is now meant to
206 * src/modest-mail-operation.c:
207 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
208 make sure we have a connection and fail if we can't connect.
210 2007-05-31 Murray Cumming <murrayc@murrayc.com>
212 * src/maemo/modest-main-window.c:
213 (on_account_store_connecting_finished): Do not try to get the
214 connection ID if we are not really connected. I am surprised that
215 this signal handler is called when we are not connected.
217 2007-05-31 Murray Cumming <murrayc@murrayc.com>
219 * src/modest-error.h:
220 * src/modest-ui-actions.c:
221 (modest_ui_actions_get_msgs_full_error_handler):
222 Renamed an enum, added comments, added an enum
223 for retrieve-limit errors.
225 * src/modest-mail-operation.c: (foreach_add_item),
226 (internal_folder_observer_update), (update_account_thread),
227 (modest_mail_operation_get_msgs_full):
228 (modest_mail_operation_update_account),
229 Added comments about how this works, and some code that should
230 (but does not) check the retrieve-limit. See the TODO comment.
232 2007-05-31 Murray Cumming <murrayc@murrayc.com>
234 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
235 Initialize help_id to fix the build. Warnings are good.
237 2007-05-31 Murray Cumming <murrayc@murrayc.com>
239 * src/widgets/modest-hbox-cell-renderer.c:
240 (modest_hbox_cell_renderer_append):
241 * src/widgets/modest-vbox-cell-renderer.c:
242 (modest_vbox_cell_renderer_append):
243 Fix the last commit by doing an extra ref.
245 2007-05-31 Murray Cumming <murrayc@murrayc.com>
247 * src/widgets/modest-hbox-cell-renderer.c:
248 (modest_hbox_cell_renderer_append):
249 * src/widgets/modest-vbox-cell-renderer.c:
250 (modest_vbox_cell_renderer_append):
251 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
252 to fix the build with Maemo Bora.
253 However, there seems to be a remaining crash, probably due to reference
256 2007-05-30 Murray Cumming <murrayc@murrayc.com>
258 * src/modest-tny-account.c:
259 (modest_tny_account_new_for_local_folders):
260 Use hildon_file_system_info_async_new() to get a better name for
261 the memory card account, setting it as the account name.
262 The timing seems to work, but this is probably
263 not the best place to do this. See the TODO comment.
264 * src/maemo/modest-main-window.c: (create_details_widget):
265 * src/widgets/modest-folder-view.c: (text_cell_data):
266 Use the tny account name instead of hardcoding a name.
268 2007-05-30 Christian Kellner <ckellner@openismus.com>
270 * src/modest-search.c: (modest_search):
271 Correctly set part_search_func even if we have already parsed
272 the query and thus a valid OgsTextSearcher object.
274 2007-05-30 Christian Kellner <ckellner@openismus.com>
277 Search and check for libogs.
280 Incooparte the ogs build env.
282 * src/modest-mime-part-search-stream.c:
283 * src/modest-mime-part-search-stream.h:
284 Removed since we do the real searching now in modest-search.c.
286 * src/modest-search.c:
287 * src/modest-search.h:
288 Implement support for ogs. We use that if available and requested
289 and fall back to modest_text_utils_utf8_strcmp (). The search logic
290 should now handle the corner case when the search term is spread
291 across multiple reads.
292 Also the logic in modest_search () was corrected to search all
293 requested fields until one is found.
295 2007-05-30 Murray Cumming <murrayc@murrayc.com>
297 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
300 * src/modest-init.c: Made modest_init_local_folders() take a
301 path and be public so we can iniitialize maildir folders on
304 * src/modest-local-folder-info.h:
305 * src/modest-local-folder-info.c:
306 (modest_local_folder_info_get_maildir_path): Add a path parameter.
308 * src/modest-tny-account.c:
309 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
310 still means the standard local-folders path on the local volume.
312 * src/modest-tny-account-store.c:
313 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
314 signal so we can detect mount/unmount of the MMC1 card, and do an update of
315 all accounts when that happens.
316 (get_server_accounts): If the MMC1 card is mounted, create a store account for
317 this too, so it shows up in the treeview.
319 2007-05-28 Murray Cumming <murrayc@murrayc.com>
321 * src/maemo/modest-maemo-global-settings-dialog.c:
322 (current_connection):
323 * src/widgets/modest-global-settings-dialog.c:
324 (current_connection_default):
325 Use the enum values instead of 0, 1 and -1,
326 to make the code clearer.
328 * src/modest-account-mgr-helpers.c:
329 (modest_account_mgr_get_connection_specific_smtp): Make this code
332 * src/modest-runtime.h:
333 * src/modest-runtime.c:
334 Added modest_runtime_remove_all_send_queues().
335 * src/maemo/modest-main-window.c:
336 (on_account_store_connecting_finished): Recreate the send queues,
337 using the appropriate transport accounts for this new connection.
338 Some futher adapting might be needed if the old send queues are not
339 automatically stopped at this point.
341 * src/modest-tny-account-store.c: (get_server_accounts):
342 Create the connection-specific transport accounts, so that they can
343 be found later by their ID.
345 * src/modest-tny-account.h:
346 * src/modest-tny-account.c:
347 Added modest_tny_account_new_from_server_account_name().
348 modest_tny_account_new_from_server_account(): Do not create the
349 send queues here, because they will be
350 recreated anyway when the connection changes for the first time.
352 2007-05-28 Murray Cumming <murrayc@murrayc.com>
354 * src/modest-local-folder-info.h:
355 * src/modest-local-folder-info.c:
356 (modest_per_account_local_outbox_folder_info_get_maildir_path),
357 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
358 tbox_folder): Take a modest account name instead of a server TnyAccount,
359 so we can have per-modest-account rather than per-transport-account
361 We must make sure that we change or recreate the exisitng send queues
362 when the connection changes for connection-specific transport accounts.
364 * src/modest-tny-account-store.c:
365 (create_per_account_local_outbox_folders): Create outboxed per modest
366 account, not per transport account.
368 * src/modest-tny-account.h:
369 * src/modest-tny-account.c:
370 (modest_tny_account_get_special_folder): For outboxes, get the
371 parent modest account name. The account is ignored for other folders.
372 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
373 modest account name rather than a server TnyAccount.
375 2007-05-25 Murray Cumming <murrayc@murrayc.com>
377 * src/modest-tny-account.c:
378 (modest_tny_account_new_from_server_account):
379 Call modest_runtime_get_send_queue() immediately after creating transport
380 accounts, so that they start trying to send email from the outbox as soon
381 as possible at startup. This is probably what we want.
383 * src/modest-mail-operation.c: (update_account_thread):
384 * src/modest-runtime.c: (modest_runtime_get_send_queue):
385 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
386 * src/modest-tny-send-queue.h:
387 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
388 (modest_ui_actions_on_send):
389 Added comments about how sending works, though it needs some more work.
391 2007-05-25 Murray Cumming <murrayc@murrayc.com>
393 * src/modest-tny-account.c:
394 (modest_tny_account_get_special_folder): Add TODO because this fails when
396 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
397 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
398 Do not try to show this window when there is no active account. The UI
399 specs does not tell us what to do in this case.
401 2007-05-24 Murray Cumming <murrayc@murrayc.com>
405 * src/maemo/Makefile.am:
406 * src/widgets/Makefile.am: Some dist fixes.
408 2007-05-24 Murray Cumming <murrayc@murrayc.com>
410 * src/maemo/modest-connection-specific-smtp-window.c:
411 (on_button_edit): Make the code clearer, to prevent a double free.
413 2007-05-24 Murray Cumming <murrayc@murrayc.com>
415 * src/maemo/modest-account-settings-dialog.c:
416 (modest_account_settings_dialog_set_account_name),
417 Check the connection-specific smtp servers checkbox if there are any.
419 * src/maemo/modest-connection-specific-smtp-edit-window.c:
420 (modest_connection_specific_smtp_edit_window_init):
421 Start with a suitable port number.
423 * src/modest-account-mgr-helpers.h:
424 * src/modest-account-mgr-helpers.c: Added
425 modest_account_mgr_get_has_connection_specific_smtp().
427 (modest_account_mgr_set_connection_specific_smtp),
428 (modest_account_mgr_remove_connection_specific_smtp),
429 (modest_account_mgr_get_has_connection_specific_smtp),
430 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
431 connection-specific smtp server accounts in the account, rather than
432 the server account conf dir.
434 This fixes bug projects.maemo.org bug NB#58263 .
436 * src/modest-tny-account-store.c:
437 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
438 if there are no server accounts yet, to prevent an infinite loop when there
439 are no accounts. Document that one must be called before the other.
441 2007-05-24 Murray Cumming <murrayc@murrayc.com>
443 * src/modest-account-mgr-helpers.c:
444 (modest_account_mgr_get_default_account): Make sure that at least
445 one account is always the default, if there are any enabled accounts.
446 This is just a sanity check that shouldn't be necessary.
448 * src/modest-account-mgr-priv.c:
449 (_modest_account_mgr_account_from_key): Unescape the conf key to
450 get the real account name. For instance, this is an issue if a space
451 was in the account name, which can happen because the account name
452 is generated from the display name.
453 (_modest_account_mgr_get_account_keyname): Always escape the
455 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
456 Unescape the conf keys to get the real account names.
458 For instance, previously the is-default radio button in the accounts
459 list was not checked for any accounts at first. This fixes that,
460 and might fix several similar bugs.
462 2007-05-23 Murray Cumming <murrayc@murrayc.com>
464 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
465 Removed some debug printfs.
467 2007-05-23 Murray Cumming <murrayc@murrayc.com>
469 Modest on-disk outbox directories are now here, for instance:
470 $HOME/.modest/outboxes/<account-id-1>/outbox
471 $HOME/.modest/outboxes/<account-id-2>/outbox
473 $HOME/.modest/local-folders/outbox
474 so we can have a separate outbox for each account.
475 But they are shown as one outbox in the GtkTreeView, by using a
476 TnyMergeFolder in a ModestTnySimpleFolderStore.
479 * src/modest-tny-simple-folder-store.c:
480 * src/modest-tny-simple-folder-store.h:
481 Added ModestTnySimpleFolderStore, used to contain folders from
482 other folder stores, such as other accounts.
484 * src/modest-tny-outbox-account.h:
485 * src/modest-tny-outbox-account.c:
486 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
487 used for the per-account local outbox folders.
489 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
490 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
491 only use this (internally) now for the non-outbox local folders.
494 * src/modest-init.c: Added modest_init_one_local_folder(), for
495 setting up the directory structure for each local folder.
497 * src/modest-local-folder-info.c:
498 (modest_per_account_local_outbox_folder_info_get_maildir_path),
499 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
501 * src/modest-local-folder-info.h:
502 * src/modest-tny-account-store.c: (on_account_removed),
503 (on_account_changed), (create_per_account_local_outbox_folders),
504 (get_server_accounts), (modest_tny_account_store_get_accounts),
505 (modest_tny_account_store_get_tny_account_by_account),
506 (modest_tny_folder_store_is_virtual_local_folders):
508 * src/modest-tny-account.h:
509 * src/modest-tny-account.c:
510 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
511 to create an on-disk per-account local outbox folder for each
513 (create_per_account_local_outbox_folders): Create a local outbox folder
514 for each transport account.
515 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
516 for all local folders.
518 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
519 instead of using g_object_get/set() directly. It is clearer.
521 (modest_tny_folder_store_get_message_count),
522 (modest_tny_folder_store_get_local_size
523 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
524 because we now use these with non-acount folder stores.
526 (modest_tny_account_get_special_folder),
527 (modest_tny_account_new_from_server_account),
528 (modest_tny_account_new_from_account):
529 (recurse_folders): Adjust to the new outbox system.
531 * src/modest-tny-folder.h:
532 * src/modest-tny-folder.c:
533 (modest_tny_folder_is_local_folder),
534 (modest_tny_folder_get_local_folder_type),
535 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
537 * src/widgets/modest-main-window.h:
538 * src/maemo/modest-main-window.c: (create_details_widget),
539 (modest_main_window_set_contents_style): Show details for any folder store,
542 (modest_tny_folder_get_rules):
543 Remove the const. C does not support constness enough for this.
545 * src/modest-ui-actions.c:
546 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
547 make all outboxes appear as one, in the usual local-folders tree node.
549 (set_active_account_from_tny_account),
550 (modest_ui_actions_on_folder_selection_changed):
551 * src/widgets/modest-folder-view.c: (text_cell_data),
552 (icon_cell_data), (filter_row),
553 (add_account_folders_to_merged_folder),
554 (add_account_folders_to_simple_folder_store), (),
555 (get_cmp_rows_type_pos), (cmp_rows),
556 (modest_folder_view_set_account_id_of_visible_server_account):
557 Adjust to the new outbox system, using generic folder stores and folders
560 2007-05-23 Christian Kellner <ckellner@openismus.com>
562 * src/modest-mail-operation.c:
563 (modest_mail_operation_update_account):
564 Use info->max_size instead of unintialized local var [small
565 build fix]. (Added TODO to review that change since I don't
568 2007-05-23 Marcus Bauer <marcusb@openismus.com>
570 * libmodest-dbus-client/libmodest-dbus-client.c:
571 (libmodest_dbus_client_compose_mail): function added
572 * src/dbus_api/modest-dbus-api.h:
573 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
574 (on_compose_mail): Implementation of the SendAsMail functionality
576 2007-05-22 Murray Cumming <murrayc@murrayc.com>
578 * src/modest-account-mgr.c:
579 (modest_account_mgr_add_server_account): Set the secure-connection
580 conf key for transport accounts as well as store accounts. I don't know
581 why the if was there. For instance, this makes sure that we use SSL
582 for the gmail preset from the easysetup wizard.
584 2007-05-22 Murray Cumming <murrayc@murrayc.com>
586 * src/gnome/modest-main-window.c:
587 (on_account_store_connecting_finished), (connect_signals):
588 * src/maemo/modest-main-window.c:
589 (on_account_store_connecting_finished), (connect_signals),
590 (modest_main_window_new):
591 Handle TnyAccountStore::connecting-finished instead of
592 TnyDevice::connection-changed, because we cannot actually perform
593 operations on accounts until TnyAccountStore has itself responded to
594 the TnyDevice::connection-changed signal. This prevents a GError from
596 Do not try to update at startup, because we (at least on scratchbox)
597 already do an update at startup when the device goes online.
598 This prevents a GError from tinymail.
599 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
600 Added TODO about stopping simultaneous operations.
602 2007-05-21 Murray Cumming <murrayc@murrayc.com>
604 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
605 * src/modest-mail-operation-queue.c:
606 (modest_mail_operation_queue_remove):
607 * src/modest-tny-account-store.c: When GErrors happen, give more clues
608 about where they happened.
610 2007-05-21 Murray Cumming <murrayc@murrayc.com>
612 * src/modest-ui-actions.c:
613 (modest_ui_actions_on_password_requested): Make sure that the remember
614 output parameter is always TRUE.
616 2007-05-21 Murray Cumming <murrayc@murrayc.com>
618 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
619 Show a OK/Cancel dialog if the error is a question, though we still do not
620 know anything more about what we are asking the user.
621 * src/widgets/modest-folder-view.c: (on_drag_data_received):
622 Fix an uninitialized variable (helper). This is a logic error, however.
624 2007-05-21 Christian Kellner <ckellner@openismus.com>
626 * src/modest-search.h:
627 Correct bit shifting in the ModestSearchFlags enum.
629 2007-05-21 Murray Cumming <murrayc@murrayc.com>
631 * src/modest-tny-account.c:
632 (modest_tny_account_new_from_server_account): Do not use the lsub and
633 check-all hard-coded IMAP options when using POP.
635 2007-05-21 Murray Cumming <murrayc@murrayc.com>
637 * src/modest-tny-account.c:
638 (modest_tny_account_new_from_server_account):
639 Use NULL for the secure-auth method for POP when Password auth has been
640 specified by the user, as we already do for IMAP. "auth=Login" causes
641 an error from camel or the server.
643 2007-05-17 Murray Cumming <murrayc@murrayc.com>
645 * src/maemo/modest-account-settings-dialog.c:
646 (create_page_account_details),
647 (modest_account_settings_dialog_set_account_name):
648 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
649 for the leave-on-server checkbox, rathr than just the checkbox, when
650 the protocol is not POP.
652 2007-05-17 Murray Cumming <murrayc@murrayc.com>
654 * src/widgets/modest-account-view.c:
655 * src/widgets/modest-account-view.h:
656 Added modest_account_view_select_account() which will be useful later
657 to asynchronously re-select the edited account.
659 2007-05-17 Murray Cumming <murrayc@murrayc.com>
661 * src/maemo/modest-account-settings-dialog.c:
662 (modest_account_settings_dialog_set_account_name):
663 Automatically choose the port numbers based on the secure authentication
664 methods, if they have not been chosen before.
665 This fixes projects.maemo.org bug NB#56273 .
667 2007-05-17 Murray Cumming <murrayc@murrayc.com>
669 * src/maemo/modest-main-window-ui.h:
670 * src/modest-ui-actions.c:
671 * src/modest-ui-actions.h:
672 Connect the Tools/SMTP Servers menu item to
673 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
674 SMTP servers dialog, as in the UI specification and saves changes when it
675 is closed. This fixed projects.maemo.org bug NB#56305 .
677 2007-05-17 Murray Cumming <murrayc@murrayc.com>
679 * src/maemo/modest-connection-specific-smtp-window.c:
680 (modest_connection_specific_smtp_window_init):
681 Use gtk_window_set_default_size() to make this window big enough, so
682 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
684 2007-05-17 Murray Cumming <murrayc@murrayc.com>
686 * src/maemo/modest-connection-specific-smtp-edit-window.h:
687 * src/maemo/modest-connection-specific-smtp-edit-window.c:
688 (modest_connection_specific_smtp_edit_window_init),
689 Do not try to connect to a combobox signal before the combobox exists.
690 This fixes the cras in projects.maemo.org bug NB#56288 .
691 (modest_connection_specific_smtp_edit_window_get_settings):
692 Remove the server_account_name parameter which was being checked for NULL
693 though it was not used.
695 * src/maemo/modest-connection-specific-smtp-window.c:
696 (modest_connection_specific_smtp_window_fill_with_connections),
697 (on_button_edit), (modest_connection_specific_smtp_window_init):
698 Correct the number of treemodel columns to prevent a warning.
699 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
700 libconic does not work.
702 2007-05-16 Murray Cumming <murrayc@murrayc.com>
704 * src/modest-tny-account.c:
705 (modest_tny_account_new_from_server_account):
706 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
707 SMTP when "None" was chosen by the user. However, with my SMTP server that
708 does not support ANONYMOUS, the emails do not leave the Outbox and I see
711 2007-05-16 Murray Cumming <murrayc@murrayc.com>
713 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
714 to explain the memory management issue with the ID in the ModestPair.
716 * src/gnome/modest-account-assistant.c: (add_receiving_page),
717 (add_sending_page), (modest_account_assistant_finalize):
718 * src/gnome/modest-gnome-global-settings-dialog.c:
719 (create_updating_page), (create_composing_page):
720 * src/gnome/modest-msg-edit-window.c: (get_transports),
721 (init_window), (modest_msg_edit_window_finalize),
722 (modest_msg_edit_window_get_msg_data):
723 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
724 * src/gnome/modest-transport-widget.c:
725 (modest_transport_widget_finalize), (smtp_configuration):
726 * src/maemo/modest-maemo-global-settings-dialog.c:
727 (create_updating_page), (create_composing_page):
728 * src/maemo/modest-msg-edit-window.c: (get_transports),
729 (init_window), (modest_msg_edit_window_finalize),
730 (modest_msg_edit_window_get_msg_data),
731 (modest_msg_edit_window_free_msg_data):
732 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
733 (modest_store_widget_finalize):
734 * src/maemo/modest-transport-widget.c:
735 (modest_transport_widget_finalize), (smtp_configuration):
736 * src/modest-main.c: (send_mail):
737 * src/widgets/modest-combo-box.h:
738 * src/widgets/modest-global-settings-dialog-priv.h:
739 * src/widgets/modest-global-settings-dialog.c:
740 (modest_global_settings_dialog_finalize):
741 * src/widgets/modest-msg-edit-window.h:
742 Whenever using modest_combo_box_new(), keep the ModestPairList alive
743 as long as the combo box, to prevent use of freed memory for the ID.
745 2007-05-15 Murray Cumming <murrayc@murrayc.com>
747 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
748 get_accounts(), to make this clearer. Do not check for the enabled gconf
749 key, because we do not use this for server accounts (at least, not yet).
750 This allows us to send email again.
752 2007-05-15 Murray Cumming <murrayc@murrayc.com>
754 * src/maemo/modest-platform.c:
755 (on_modest_conf_update_interval_changed), (modest_platform_init):
756 Only respond to this particular key change. All these strcmp()s cannot be
759 2007-05-15 Murray Cumming <murrayc@murrayc.com>
761 * src/maemo/modest-maemo-global-settings-dialog.c:
762 (current_connection): Prevent a crash in scratchbox when
763 ny_maemo_conic_device_get_current_iap_id() returns NULL.
764 * src/maemo/modest-platform.c:
765 (on_modest_conf_update_interval_changed), (modest_platform_init):
766 Get the update interval from gconf and reset it when the gconf key changes.
768 2007-05-15 Murray Cumming <murrayc@murrayc.com>
770 * src/modest-protocol-info.c:
771 * src/modest-protocol-info.h: Adde enum-specific get functions,
772 instead of using a ModestProtocolType enum parameter.
774 * src/gnome/modest-account-assistant.c:
775 * src/gnome/modest-store-widget.c:
776 * src/gnome/modest-store-widget.h:
777 * src/gnome/modest-transport-widget.c:
778 * src/gnome/modest-transport-widget.h:
779 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
780 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
781 * src/maemo/easysetup/modest-easysetup-wizard.c:
782 * src/maemo/modest-account-settings-dialog.c:
783 * src/maemo/modest-account-settings-dialog.h:
784 * src/maemo/modest-store-widget.c:
785 * src/maemo/modest-store-widget.h:
786 * src/maemo/modest-transport-widget.c:
787 * src/maemo/modest-transport-widget.h:
788 * src/modest-account-mgr-helpers.c:
789 * src/modest-account-mgr-helpers.h:
790 * src/modest-account-mgr.c:
791 * src/modest-account-mgr.h:
792 * src/modest-tny-account.c:
793 * src/modest-tny-folder.c:
794 * src/widgets/modest-account-view.c:
795 * src/widgets/modest-retrieve-combo-box.c:
796 * src/widgets/modest-retrieve-combo-box.h:
797 * src/widgets/modest-secureauth-combo-box.c:
798 * src/widgets/modest-serversecurity-combo-box.c:
799 * src/widgets/modest-serversecurity-combo-box.h:
800 * tests/check_account-mgr.c:
801 Use the specific functions, and use the re-renamed enum values for GNOME too.
803 2007-05-15 Murray Cumming <murrayc@murrayc.com>
806 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
807 so we can get the second based on the first.
809 * src/maemo/modest-account-settings-dialog.h:
810 * src/maemo/modest-account-settings-dialog.c:
811 Added get_supported_secure_authentication_methods(), though it is mostly
812 commented-out for now until the necessary API is committed to tinymail.
813 (modest_account_settings_dialog_set_account_name),
814 (save_configuration): Request the supported authentication methods from the
815 server, so we can choose a working method.
817 * src/modest-tny-account-store.h:
818 * src/modest-tny-account-store.c:
819 (modest_tny_account_store_get_session): Rename from
820 tny_account_store_get_session().
822 2007-05-14 Murray Cumming <murrayc@murrayc.com>
824 * src/modest-protocol-info.h: Split the ModestProtocol enum
825 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
826 There was no need to have these unrelated values in one enum.
828 * src/: many files: Adapted to changed enum. This makes the code a bit
829 clearer, and the compiler could catch some errors.
831 2007-05-14 Murray Cumming <murrayc@murrayc.com>
833 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
834 Show the detailed internal camel error message when an error happens
835 during the configuration, so that our testers can give us more clues.
836 For instance, in projects.maemo.org bug NB#56910 .
838 2007-05-14 Murray Cumming <murrayc@murrayc.com>
840 * src/modest-tny-account.c:
841 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
842 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
844 2007-05-14 Murray Cumming <murrayc@murrayc.com>
846 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
847 * src/maemo/modest-account-settings-dialog.c:
848 (modest_account_settings_dialog_set_account_name),
849 (save_configuration): For the incoming secure authentication checkbox,
850 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
851 the UI specification. PLAIN does not seem to be supported for most IMAP
852 servers anyway, and I am not sure what it would mean.
853 However, we probably need to discover which of the secure-authentication
854 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
855 * src/modest-account-mgr-helpers.c:
856 (modest_account_mgr_get_server_account_data):
858 * src/modest-tny-account.c:
859 (modest_tny_account_new_from_server_account):
860 Use tny_account_set_mech() to set secure-authentication methods,
861 with some special-casing for IMAP, based on my observations of how
864 * src/modest-account-mgr-helpers.h:
865 * src/modest-account-mgr.c:
866 * src/modest-defs.h: Comment that the URI is only used for local folders.
868 2007-05-11 Murray Cumming <murrayc@murrayc.com>
870 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
871 parameter const, just to be neat.
872 * src/modest-text-utils.c: (modest_text_utils_inline):
873 End g_strconcat() with NULL, as its documentation says. This is almost
874 certainly the cause of my crash at startup on the device. Interestingly,
875 valgrind doesn't tell us about these errors.
877 2007-05-11 Murray Cumming <murrayc@murrayc.com>
879 * scripts/build-packages: Added more precise comments about how to use
880 this script, though I still get this error:
881 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
882 error building tinymail
884 2007-05-11 Murray Cumming <murrayc@murrayc.com>
886 * src/maemo/modest-main-window.c: (on_account_update):
887 Very slight cleanup, hoping to make it simpler to discover what causes
888 a crash here sometimes.
890 * src/modest-tny-account.c:
891 (modest_tny_account_new_from_server_account): Set the port. Added
892 comments about the options and a TODO comment because I need to find out
893 how to specify the secure authentication method.
895 2007-05-11 Marcus Bauer <marcusb@openismus.com>
897 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
898 changed CFlags paths form modest to libmodest
900 2007-05-10 Murray Cumming <murrayc@murrayc.com>
902 * src/modest-account-mgr-helpers.c:
903 (modest_account_mgr_get_server_account_data),
904 (modest_account_mgr_free_server_account_data):
905 * src/modest-account-mgr-helpers.h:
906 * src/modest-account-mgr.c:
907 (modest_account_mgr_add_server_account):
909 * src/modest-tny-account.c:
910 (modest_tny_account_new_from_server_account):
911 Determine the options for tny_camel_account_add_option() here,
912 based on the settings, rather than storing them directly in gconf.
914 2007-05-10 Murray Cumming <murrayc@murrayc.com>
916 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
917 Show a more friendly error dialog now that we expect (from the tinymail
918 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
920 2007-05-10 Murray Cumming <murrayc@murrayc.com>
922 * src/maemo/modest-main-window.c: (on_account_update): Check that
923 account_name is not NULL, to prevent a crash at startup that I am
924 seeing on the N800. I do wonder why it is NULL.
926 * src/maemo/easysetup/modest-easysetup-wizard.c:
927 (create_page_user_details):
928 * src/maemo/modest-account-settings-dialog.c:
929 (create_page_user_details), (create_page_outgoing):
930 * src/maemo/modest-connection-specific-smtp-edit-window.c:
931 (modest_connection_specific_smtp_edit_window_init):
932 * src/modest-ui-actions.c:
933 (modest_ui_actions_on_password_requested):
934 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
935 might do something useful with the on-screen keyboard.
937 2007-05-10 Murray Cumming <murrayc@murrayc.com>
939 * src/maemo/modest-main-window.c: (on_account_update):
940 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
941 NULL, to avoid lots of warnings. However, it probably should not be NULL.
943 2007-05-09 Murray Cumming <murrayc@murrayc.com>
945 * src/modest-tny-account-store.c: (on_account_changed):
946 Correct the signature of this signal handler.
948 2007-05-09 Murray Cumming <murrayc@murrayc.com>
950 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
951 Show a HildonNote instead of a GtkDialog for Maemo.
953 2007-05-09 Murray Cumming <murrayc@murrayc.com>
955 * src/widgets/modest-account-view.h:
956 * src/widgets/modest-account-view.c: (on_account_changed),
957 (on_account_removed). Added a boolean flag, set/unset by
958 modest_account_view_block_conf_updates(),
959 modest_account_view_unblock_conf_updates() to prevent unnecessary
960 updates, but this is not very useful because the gconf notifications are
961 so delays (maybe only on Maemo Bora).
962 So auto-updating is turned off, and these functions do an explicit
963 update when necessary.
964 However, something else is still doing too much work when adding/removing
965 accounts, probably in another part of the application.
967 * src/maemo/modest-account-view-window.c:
968 (on_delete_button_clicked), (on_edit_button_clicked),
969 (on_new_button_clicked): Use the new functions.
971 2007-05-09 Murray Cumming <murrayc@murrayc.com>
973 * src/modest-account-mgr-helpers.c:
974 (modest_account_mgr_set_first_account_as_default):
975 Sort the list of names alphabetically-by-title, so we choose the first one
977 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
978 alphabetically by the title.
980 This fixes projects.maemo.org bug NB#56418 .
982 * src/modest-account-mgr-priv.c:
983 (_modest_account_mgr_account_from_key):
984 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
985 avoid a valgrind error, and possible random behaviour.
987 2007-05-09 Murray Cumming <murrayc@murrayc.com>
989 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
990 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
991 tinymail documentation to say that this can be expected.
992 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
993 pretty, and should not happen, but I would prefer to know when it does.
995 2007-05-09 Murray Cumming <murrayc@murrayc.com>
997 * configure.ac: When using the older hildon version, probably on Bora,
998 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1000 * src/widgets/modest-attachment-view.c:
1001 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1004 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1006 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1007 Implemented the prototype. Can be tested with
1008 tests/dbus_api/test_open_message:
1010 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1012 * src/modest-tny-account-store.c:
1013 (modest_tny_account_store_instance_init), (get_password):
1014 * src/modest-ui-actions.c:
1015 (modest_ui_actions_on_password_requested):
1016 Do not store the password in gconf, because this function is called
1017 for non-remembered passwords. Actually use the cached (in the hash map)
1018 password instead of releasing it.
1019 The password will now not be remembered if it is asked via the protected
1020 password dialog, as per the UI spec.
1022 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1024 * src/modest-defs.h:
1025 * src/modest-account-mgr-helpers.h:
1026 * src/modest-account-mgr-helpers.c:
1027 Added modest_server_account_get_username_has_succeeded(),
1028 modest_server_account_set_username_has_succeeded().
1029 (modest_server_account_set_username),
1030 Reset the has-succeeded flag if the username changes.
1032 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1033 * src/maemo/modest-connection-specific-smtp-window.c:
1034 (modest_connection_specific_smtp_window_save_server_accounts):
1035 Use modest_server_account_set_username() instead of using
1036 modest_conf_set_string() directly, so that the has-succeeded flag is always
1039 * src/modest-ui-actions.c:
1040 (modest_ui_actions_on_password_requested): Dim the username entry if
1041 the username has ever worked, as per the UI spec.
1043 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1045 * src/modest-tny-account-store.c: (get_password):
1046 * src/modest-ui-actions.c:
1047 (modest_ui_actions_on_password_requested):
1048 Allow the username to be changed too, though there is more work to
1049 be done on exactly how this behaves.
1051 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1053 * src/modest-account-mgr-helpers.h:
1054 * src/modest-account-mgr-helpers.c:
1055 Added modest_account_mgr_get_display_name(),
1056 modest_server_account_get_username(),
1057 modest_server_account_set_username(),
1058 modest_server_account_set_password(),
1059 modest_server_account_get_hostname() functions so we do not need to
1060 use the conf API directly.
1062 * src/maemo/modest-main-window.c: (connect_signals):
1063 Actually connect ot the ModestAccountStore::request-password signal,
1064 so that we show the dialog when the password is requested by Tinymail,
1065 for isntance if it is empty.
1067 * src/modest-marshal.list:
1068 * src/modest-tny-account-store.c:
1069 (modest_tny_account_store_class_init), (get_password),
1070 (modest_tny_account_store_alert):
1071 * src/modest-tny-account-store.h:
1072 * src/modest-ui-actions.h:
1073 * src/modest-ui-actions.c:
1074 (modest_ui_actions_on_password_requested):
1075 Change the signal parameters, so it is obvious that we are providing
1076 the non human-readable server name, and receiving both the username
1077 and password, though changing of the username is not yet implemented.
1078 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1079 for the GNOME version.
1081 This should fix the projects.maemo.org bug NB#56209, though it does not
1082 work on Bora, because the gconf_client_get() for the password fails
1083 immediately after we save it with gconf_client_set().
1085 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1088 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1089 caused an undefined symbol error:
1090 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1092 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1094 * src/modest-tny-account-store.c:
1095 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1096 using a GError instead of a string message, so we can translate it in
1099 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1101 * src/maemo/modest-address-book.c:
1102 (modest_address_book_check_names):
1103 * src/maemo/modest-msg-view-window.c:
1104 (modest_msg_view_window_clipboard_owner_change):
1105 * src/modest-init.c: (modest_init_init_ui):
1106 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1107 (update_folders_cb), (modest_mail_operation_update_account):
1108 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1109 (modest_ui_actions_on_msg_attachment_clicked),
1110 (modest_ui_actions_on_msg_recpt_activated):
1111 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1112 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1113 (modest_msg_view_search_next):
1114 * src/widgets/modest-recpt-editor.c:
1115 (modest_recpt_editor_on_button_release_event),
1116 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1117 g_message(). At this point we should only be seeing interesting errors on
1118 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1120 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1122 (modest_wizard_dialog_force_title_update):
1123 * src/maemo/easysetup/modest-wizard-dialog.h:
1124 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1125 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1126 can update the title when appropriate. Otherwise the title is wrong if the
1127 pages are added after adding the notebook to the dialog.
1128 This must be a problem in HildonWizardDialog too.
1129 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1131 * src/maemo/easysetup/modest-easysetup-wizard.c:
1132 (create_subsequent_customsetup_pages),
1133 (create_subsequent_easysetup_pages):
1134 Call modest_wizard_dialog_force_title_update() so that the title is
1135 correct even with GTK+ < 2.10.
1136 This fixes projects.maemo.org bug NB#56145 .
1138 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1140 * src/maemo/modest-platform.c:
1141 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1142 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1145 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1147 * src/widgets/modest-window.h:
1148 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1149 and modest_window_save_state(), which invokes it.
1151 * src/widgets/modest-window-mgr.h:
1152 * src/widgets/modest-window-mgr.c:
1153 Added modest_window_mgr_save_state_for_all_windows(), which calls
1154 the save_state vfunc on all registered windows, if implemented.
1156 * src/gnome/modest-msg-edit-window.c:
1157 * src/gnome/modest-msg-view-window.c:
1158 * src/maemo/modest-msg-edit-window.c:
1159 * src/maemo/modest-msg-view-window.c:
1160 * src/maemo/modest-main-window.c:
1161 Specify the existing save_settings functions as implementations of
1162 ModestWindow::save_state_func().
1164 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1165 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1166 enabling hibernation, for instance.
1168 We may need to do the same thing for restoring settings.
1171 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1173 * src/widgets/modest-window-mgr.c:
1174 * src/widgets/modest-window-mgr.h:
1175 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1176 modest_window_mgr_get_hibernation_is_prevented().
1178 * src/maemo/modest-main-window.c:
1179 (on_hildon_program_is_topmost_notify): Prevent hibernation
1180 (possible when the application goes to the background in the WM),
1181 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1183 * src/maemo/easysetup/modest-easysetup-wizard.c:
1184 (modest_easysetup_wizard_dialog_init):
1185 * src/maemo/modest-account-settings-dialog.c:
1186 (modest_account_settings_dialog_init):
1187 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1188 (modest_connection_specific_smtp_edit_window_init):
1189 * src/maemo/modest-connection-specific-smtp-window.c:
1190 (modest_connection_specific_smtp_window_init):
1191 * src/maemo/modest-signature-editor-dialog.c:
1192 (modest_signature_editor_dialog_init):
1193 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1194 prevent hibernation while any of these account settings dialogs are open.
1196 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1198 * src/maemo/Makefile.am:
1199 * src/maemo/modest-osso-state-saving.c:
1200 * src/maemo/modest-osso-state-saving.h: Added
1201 modest_osso_load_state() and modest_osso_save_state() though they do
1202 nothing now. They should iterate through all the open windows and load/save
1204 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1205 save state when closing.
1207 * src/maemo/modest-main-window.c:
1208 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1209 Add a notification handler for the HildonProgram::is-topmost property,
1210 so we can allow hibernation when the application goes into the background.
1211 But we still need to detect when the accounts setup windows are open so
1212 we can stop hibernation when they are open.
1213 To do this, I also added the main window the HildonProgram. This might have
1214 other side-effects/benefits, and should maybe be done for other windows.
1216 * src/maemo/modest-osso-autosave-callbacks.h:
1217 * src/maemo/modest-osso-autosave-callbacks.c:
1218 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1219 though it does not do anything yet, and we might never need this to do
1220 anything. For instance, we already save drafts.
1222 * src/maemo/modest-platform.c: (modest_platform_init):
1223 Specify the libosso auto-save callback.
1225 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1227 * src/maemo/modest-platform.c:
1228 (modest_platform_set_update_interval):
1229 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1230 aparently stays valid between application instances, so we can use this
1231 to remove and reset it later. According to a maemo-developers email from
1234 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1236 * configure.ac: Depend on libalarm for Maemo.
1238 * src/dbus_api/modest-dbus-api.h:
1239 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1240 (on_send_receive), (modest_dbus_req_handler):
1241 Handle a SEND_RECEIVE D-Bus method.
1243 * libmodest-dbus-client/libmodest-dbus-client.c:
1244 (libmodest_dbus_client_send_and_receive):
1245 * libmodest-dbus-client/libmodest-dbus-client.h:
1246 Add C convenience functions for calling the new D-Bus method.
1248 * src/modest-platform.h:
1249 * src/gnome/modest-platform.c:
1250 * src/maemo/modest-platform.c:
1251 Added modest_platform_set_update_interval(), which uses the
1252 alarmd API on Maemo.
1253 (modest_platform_init),
1254 Call modest_platform_set_update_interval(), using a hard-coded
1255 interval for now (until the global settings dialog is implemented),
1256 though I am not sure that this makes sense yet.
1258 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1260 * src/dbus_api/modest-dbus-callbacks.c:
1261 (modest_osso_cb_hw_state_handler):
1262 * src/dbus_api/modest-dbus-callbacks.h:
1263 * src/maemo/modest-platform.c: (modest_platform_init):
1264 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1265 in case this has some effect on the ability for Maemo to ping the
1268 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1270 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1271 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1272 warning. It is probably a logic error, but I need to fix the build.
1274 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1276 * src/modest-account-mgr.h:
1277 * src/modest-account-mgr.c:
1278 (modest_account_mgr_account_names): Add a gboolean enabled_only
1279 parameter, so we can get lists of onlt the enabled accounts.
1281 (modest_account_mgr_add_account),,
1282 (modest_account_mgr_account_with_display_name_exists):
1283 * src/maemo/modest-msg-edit-window.c: (get_transports):
1284 * src/modest-account-mgr-helpers.c:
1285 (modest_account_mgr_set_first_account_as_default):
1286 * src/modest-init.c: (init_default_account_maybe):
1287 * src/modest-tny-account-store.c: (get_accounts):
1288 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1289 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1290 * tests/check_account-mgr.c: (START_TEST):
1291 Provide the extra parameter, as appropriate.
1293 * src/widgets/modest-account-view.c: (update_account_view):
1294 Do not show disabled accounts (meaning that there is no way to
1295 enable/disable accounts in the UI (the feature is not in our UI
1296 specification), so we can use this internally only to mark unfinished
1297 or temporary account data.
1299 * src/maemo/easysetup/modest-easysetup-wizard.c:
1300 (create_account): Add boolean enable parameter, so we can specify FALSE
1301 to create the temporary account.
1302 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1303 (on_before_next): When finishing, when there is a temporary account, just
1305 Also, use a timeout to delay the showing of the dialog until gconf is likely
1306 to return correct information, due to a maemo gconf bug that is fixed in
1307 osso 1.1, but not yet in Bora.
1308 However, the dialog stays on screen after it is destroyed.
1310 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1311 for invalid data when cancelling. Use a hildon note instead of a dialog
1312 to complain about invalid data. Do not show the account-saved note if the
1313 account is disabled (a temporary account that will not really be saved for use
1316 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1318 * src/modest-account-mgr-helpers.h:
1319 * src/modest-account-mgr-helpers.c:
1320 Added modest_account_mgr_unset_default_account(),
1321 Added modest_account_mgr_set_first_account_as_default().
1323 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1324 If it was the default account, unset the default account name.
1326 * src/maemo/modest-account-view-window.c:
1327 (on_delete_button_clicked): If it was the default account,
1328 set the first remaining account as the default instead.
1330 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1331 a NULL account or a NULL default account, to prevent a crash. This should
1332 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1335 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1337 * src/widgets/modest-recpt-editor.c:
1338 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1339 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1340 TODO comment for this. This fixes the build.
1342 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1343 be the best place for it. This will in future update all auto-update accounts,
1344 rather than just the current/default account, when that gconf key exists.
1345 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1346 if there are no accounts, before calling do_send_receive().
1347 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1349 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1350 * src/maemo/modest-main-window-ui.h:
1351 * src/maemo/modest-main-window.c: (on_connection_changed),
1352 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1353 directly, becaue the signal handler does more.
1355 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1357 * src/modest-account-mgr-helpers.c:
1358 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1359 for the case that the account does not exist.
1361 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1362 (equivalent to the modest account name) rather than the tinymail account name
1363 (equivalent to the modest account title - human readable) to get the account data.
1364 Check for null account data to prevent the crash, and add a TODO comment saying that
1365 this needs fixing because it is using the server account name instead of the account name.
1367 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1369 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1370 * src/maemo/modest-account-settings-dialog.c: (show_error),
1372 Use hildon_note_new_information() for informative and error messages,
1373 which seems to be expected for Maemo applications (no documentation that I know of
1374 says this). I am surprised that there is no distinction between info and error
1377 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1379 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1380 it is easy to find where this is used.
1382 * src/maemo/easysetup/modest-easysetup-wizard.c:
1383 (create_page_welcome), (create_page_account_details),
1384 (create_page_user_details), (create_page_complete_easysetup),
1385 (create_page_custom_incoming), (create_page_custom_outgoing),
1386 (create_page_complete_custom):
1387 * src/maemo/modest-account-settings-dialog.c:
1388 (create_page_account_details), (create_page_user_details),
1389 (create_page_incoming), (create_page_outgoing):
1390 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1391 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1392 (modest_connection_specific_smtp_edit_window_init):
1393 * src/maemo/modest-connection-specific-smtp-window.c:
1394 (modest_connection_specific_smtp_window_init):
1395 * src/maemo/modest-signature-editor-dialog.c:
1396 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1397 and scrolling policy as per the Email Application Layout Guide, if I have
1400 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1402 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1403 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1404 which were empty, because these vfuncs have been removed from TnyAccountStore.
1405 This fixes the build.
1407 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1409 * src/maemo/modest-main-window.c:
1410 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1411 showing/hiding it. Added TODO because it probably should not be NULL.
1412 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1413 because unnecessary g_warnings() make degugging difficult.
1415 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1417 * src/maemo/modest-msg-edit-window.c:
1418 (modest_msg_edit_window_select_color),
1419 (modest_msg_edit_window_select_background_color): 2 const corrections and
1420 moving 2 #endifs before closing brackets, to fix the build.
1422 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1424 * src/maemo/easysetup/modest-easysetup-wizard.h:
1425 * src/maemo/easysetup/modest-easysetup-wizard.c:
1426 (modest_easysetup_wizard_dialog_finalize),
1427 (on_button_edit_advanced_settings), (create_page_complete_custom),
1428 (on_response), (create_account):
1429 Implement the Advanced Settings edit button, by saving the account information,
1430 for the Advanded Settings dialog to use directly from gconf, and removing it
1431 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1432 Bug #5533 in the projects.maemo.org bugzilla.
1434 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1436 * src/maemo/modest-msg-view-window.c:
1437 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1438 when opening a message window.
1440 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1442 * src/maemo/easysetup/modest-easysetup-wizard.c:
1443 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1446 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1447 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1448 gconf settings. I probably added more checks than necessary, but that is safer.
1450 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1451 variable to fix the build, but this seems to be used when it is still NULL.
1453 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1455 * src/modest-platform.h:
1456 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1457 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1458 * src/modest-main.c: Implement this function so we can avoid using
1459 maemo-specific API from cross-platform code.
1461 * src/modest-tny-account-store.c:
1462 (get_smtp_specific_transport_account_for_open_connection):
1463 * src/modest-ui-actions.c: (check_for_connection),
1464 (modest_ui_actions_on_item_not_found):
1465 Use modest_platform_connect_and_wait() and put #idefs around other
1466 maemo-specific code, because only maemo currently has a way to
1467 identify connection names.
1469 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1471 * src/modest-tny-account-store.h:
1472 * src/modest-tny-account-store.c:
1473 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1474 the connection-specific SMTP server settings in the configuration.
1476 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1478 * src/maemo/modest-main-window.c: (on_connection_changed),
1480 * src/modest-main.c: (main), (start_ui), (send_mail):
1481 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1482 that is what is intended.
1484 * src/modest-ui-actions.c: (action_send), (action_receive),
1485 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1486 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1487 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1488 SMTP server is used when it is specified.
1490 (modest_ui_actions_on_send_receive):
1491 Check that a connection is open before proceeding.
1492 Receive and then send, instead of vice-versa, as per the specification.
1494 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1496 * src/modest-mail-operation.c:
1497 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1498 though I guess it should be something other than NULL.
1500 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1502 * src/maemo/easysetup/modest-easysetup-wizard.c:
1503 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1504 combo twice, to avoid an g_warning and to make it visible again.
1505 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1506 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1507 (already intended) dereference when detaching, because we then recreate the menu.
1508 But I am not sure why the warning was happening, and it is possible that this is a memory
1511 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1513 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1514 and uri_parse_mailto() utility functions.
1515 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1517 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1519 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1521 * src/dbus_api/modest-dbus-api.h:
1522 * src/dbus_api/modest-dbus-callbacks.c:
1523 Use an idle callback to execute the modest code in the application's own thread.
1524 Remove the helloworld example method.
1525 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1526 parsed, and the open-message method is not implemented because this is not yet implemented in
1528 * libmodest-dbus-client/libmodest-dbus-client.c:
1529 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1530 (libmodest_dbus_client_open_message):
1531 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1533 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1534 body without crashing.
1536 * tests/dbus_api/Makefile.am:
1537 * tests/dbus_api/test_mail_to.c:
1538 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1540 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1542 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1543 Added file to fix the build. Sorry.
1545 * src/dbus_api/Makefile.am:
1546 * src/dbus_api/modest-dbus-api.h:
1547 * src/dbus_api/modest-dbus-callbacks.h:
1548 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1549 (modest_dbus_req_handler):
1550 Put constants in a separate header so it can be reused by the
1551 client library, without duplication
1553 * libmodest-dbus-client/Makefile.am:
1554 * libmodest-dbus-client/libmodest-dbus-client.c:
1555 (libmodest_dbus_client_call_helloworld),
1556 (libmodfest_dbus_client_send_mail),
1557 (libmodfest_dbus_client_mailto),
1558 (libmodfest_dbus_client_open_message):
1559 * libmodest-dbus-client/libmodest-dbus-client.h:
1560 (Partly) Implement a send_mail D-Bus method.
1562 * tests/dbus_api/Makefile.am:
1563 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1564 the send_email D-Bus method.
1566 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1570 * libmodest-dbus-client/Makefile.am:
1571 * libmodest-dbus-client/libmodest-dbus-client.c:
1572 * libmodest-dbus-client/libmodest-dbus-client.h:
1573 * tests/dbus_api/Makefile.am:
1574 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1575 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1577 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1579 * src/maemo/easysetup/modest-easysetup-wizard.c:
1580 (create_page_account_details):
1581 * src/maemo/modest-account-settings-dialog.c:
1582 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1583 widgets, because this might not be the default in future versions of the Maemo GTK+.
1584 However, I can not not get capitalization to work even in a simple test case.
1586 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1588 * src/maemo/easysetup/modest-easysetup-wizard.c:
1589 (create_page_custom_incoming), (create_page_custom_outgoing):
1590 * src/maemo/modest-account-settings-dialog.c:
1591 (create_page_account_details), (create_page_incoming),
1592 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1593 instead of using gtk_check_button_with_label(), so they are aligned like the other
1594 widgets, as per the UI spec.
1596 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1598 * src/maemo/easysetup/modest-easysetup-wizard.c:
1599 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1600 * src/widgets/modest-validating-entry.c:
1601 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1602 Modest prefix instead of an EasySetup prefix.
1604 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1606 * src/widgets/modest-validating-entry.h:
1607 * src/widgets/modest-validating-entry.c: (on_insert_text),
1608 Added easysetup_validating_entry_set_max_func(), used to set a callback
1609 to call when the max number of characters is reached. GtkEntry has a max-length
1610 already but is silent about it.
1612 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1613 (create_page_account_details), (create_page_user_details),
1615 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1616 (create_page_account_details), (create_page_user_details),
1617 (create_page_outgoing):
1618 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1619 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1620 the UI spec, when the user tries to enter more than the max number of characters.
1622 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1624 * src/maemo/easysetup/modest-easysetup-wizard.c:
1625 (create_page_user_details), (create_page_custom_incoming),
1626 (create_page_custom_outgoing):
1627 * src/maemo/modest-account-settings-dialog.c:
1628 (create_page_user_details), (create_page_incoming),
1629 (create_page_outgoing):
1630 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1631 (modest_connection_specific_smtp_edit_window_init):
1632 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1633 not appropriate. Bad Maemo-specific defaults!.
1635 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1637 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1638 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1639 (modest_signature_editor_dialog_set_settings):
1640 Disable the label and textview when the checkbox is disabled, and use the
1641 specified (UI spec) default signature text.
1643 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1645 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1646 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1648 * src/modest-defs.h:
1649 * src/modest-account-mgr-helpers.h:
1650 * src/modest-account-mgr-helpers.c:
1651 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1653 * src/maemo/Makefile.am:
1654 * src/maemo/modest-signature-editor-dialog.c:
1655 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1658 * src/maemo/modest-account-settings-dialog.h:
1659 * src/maemo/modest-account-settings-dialog.c:
1660 (modest_account_settings_dialog_finalize), (on_button_signature),
1661 (save_configuration): Use the new dialog when the Edit button is pressed, and
1662 save the changes if necessary, as per the UI spec.
1664 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1666 * src/maemo/Makefile.am:
1667 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1668 based on maemo-develoers email from Dirk.
1670 * src/maemo/easysetup/modest-easysetup-wizard.c:
1671 (create_page_welcome), (create_page_account_details),
1672 (create_page_user_details), (create_page_complete_easysetup),
1673 (create_page_custom_incoming), (create_page_custom_outgoing),
1674 (create_page_complete_custom),
1675 (modest_easysetup_wizard_dialog_init):
1676 * src/maemo/modest-account-settings-dialog.c:
1677 (create_page_account_details), (create_page_user_details),
1678 (create_page_incoming), (create_page_outgoing),
1679 (modest_account_settings_dialog_init):
1680 * src/maemo/modest-connection-specific-smtp-window.c:
1681 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1683 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1685 * src/maemo/easysetup/modest-easysetup-wizard.c:
1686 (create_page_account_details), (create_page_custom_outgoing),
1687 (create_page_complete_custom):
1688 * src/maemo/modest-account-settings-dialog.c:
1689 (create_page_user_details), (create_page_incoming),
1690 (create_page_outgoing):
1691 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1692 (modest_connection_specific_smtp_edit_window_init):
1693 Use the correct (UI spec) port min/max, and use horizontal separators,
1696 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1698 * src/maemo/easysetup/modest-easysetup-wizard.c:
1699 (set_default_custom_servernames):
1700 * src/maemo/modest-account-settings-dialog.c:
1701 (create_page_incoming), (on_combo_outgoing_security_changed),
1702 (on_combo_incoming_security_changed), (create_page_outgoing),
1703 (modest_account_settings_dialog_set_account_name),
1704 (save_configuration):
1705 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1706 (on_combo_security_changed),
1707 (modest_connection_specific_smtp_edit_window_init),
1708 (modest_connection_specific_smtp_edit_window_set_connection),
1709 (modest_connection_specific_smtp_edit_window_get_settings):
1710 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1713 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1716 * src/maemo/easysetup/modest-easysetup-wizard.c:
1717 (create_page_custom_outgoing), (create_page_complete_custom):
1718 * src/maemo/modest-account-settings-dialog.c:
1719 (create_page_user_details), (create_page_outgoing):
1720 * src/maemo/modest-account-view-window.c: (button_box_new):
1721 Use changed logical IDs as per the most recent UI spec:
1722 mcen_bd_emailsetup_edit -> mcen_bd_edit
1723 mcen_bd_emailsetup_delete -> mcen_bd_delete
1724 mcen_bd_emailsetup_close -> mcen_bd_close
1726 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1730 * src/dbus_api/Makefile.am:
1731 * src/dbus_api/modest-dbus-callbacks.c:
1732 * src/dbus_api/modest-dbus-callbacks.h:
1733 * src/maemo/modest-platform.c: (modest_platform_init):
1734 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1736 * tests/Makefile.am:
1737 * tests/dbus_api/Makefile.am:
1738 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1740 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1742 * src/maemo/modest-account-settings-dialog.c:
1743 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1744 Removed unnecessary includes.
1746 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1748 * src/maemo/easysetup/modest-easysetup-wizard.c:
1749 * src/maemo/modest-account-settings-dialog.c:
1750 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1751 * src/widgets/Makefile.am:
1752 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1753 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1754 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1755 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1756 * src/widgets/modest-secureauth-combo-box.c:
1757 * src/widgets/modest-secureauth-combo-box.h:
1758 * src/widgets/modest-serversecurity-combo-box.c:
1759 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1760 made the GObject names more consistent with the rest of the Modest code.
1762 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1764 * src/maemo/easysetup/Makefile.am:
1765 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1766 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1767 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1768 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1769 * src/maemo/easysetup/modest-easysetup-wizard.c:
1770 * src/maemo/easysetup/modest-validating-entry.c:
1771 * src/maemo/easysetup/modest-validating-entry.h:
1772 * src/maemo/modest-account-settings-dialog.c:
1773 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1774 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1775 widgets/ because they are used outside of easysetup too. After checking in,
1776 svn will allow me to rename them too.
1778 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1780 * src/gnome/modest-msg-edit-window.c:
1781 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1782 linker error, to fix the build on the GNOME platform.
1783 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1784 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1785 ifdefed out to avoid a warning.
1787 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1789 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1790 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1791 some alternative for GTK+ 2.6.
1793 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1795 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1797 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1798 specified for EmailAccountsDialog in UI spec.
1800 * src/maemo/easysetup/modest-easysetup-wizard.c:
1801 * src/maemo/easysetup/modest-easysetup-wizard.h:
1802 * src/maemo/modest-account-settings-dialog.c:
1803 * src/maemo/modest-account-settings-dialog.h:
1804 Reuse a member window widget for the connection-specific SMTP server accounts,
1805 so we can tell it to create/save the accounts only if we actually save changes.
1807 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1808 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1809 (modest_connection_specific_smtp_edit_window_get_settings):
1810 Return a struct instance for temporarily remembering the entered data.
1812 * src/maemo/modest-connection-specific-smtp-window.h:
1813 * src/maemo/modest-connection-specific-smtp-window.c:
1814 (modest_connection_specific_smtp_window_finalize),
1815 (modest_connection_specific_smtp_window_fill_with_connections),
1817 (modest_connection_specific_smtp_window_save_server_accounts),
1818 (update_model_server_names): Do not actually save data until asked,
1819 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1821 (on_selection_changed),
1822 (modest_connection_specific_smtp_window_init): Disable the edit
1823 button when nothing is selected.
1825 * src/modest-account-mgr-helpers.c:
1826 * src/modest-account-mgr-helpers.h:
1827 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1830 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1832 * src/modest-account-mgr-helpers.h:
1833 * src/modest-account-mgr-helpers.c:
1834 (modest_account_mgr_get_unused_account_name),
1835 (modest_account_mgr_get_unused_account_display_name): Added these
1836 utility functions, to avoid code duplication.
1838 * src/maemo/easysetup/modest-easysetup-wizard.c:
1839 (create_page_account_details), (create_account):
1840 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1841 (on_combo_security_changed),
1842 (modest_connection_specific_smtp_edit_window_init),
1843 (modest_connection_specific_smtp_edit_window_save_settings):
1844 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1845 * src/maemo/modest-connection-specific-smtp-window.c:
1846 (modest_connection_specific_smtp_window_finalize),
1847 (modest_connection_specific_smtp_window_fill_with_connections),
1848 (on_button_edit), (modest_connection_specific_smtp_window_init):
1849 * src/maemo/modest-connection-specific-smtp-window.h:
1850 Implementing saving of connection-specific server accounts.
1852 But I need to refactor this so we can save the data for each
1853 possible connection-specific account and only actually create the server accounts
1854 when the easysetup finished, or the OK button is pressed on the account settings
1857 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1859 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1860 (on_combo_security_changed):
1861 (modest_connection_specific_smtp_edit_window_init):
1862 Auto-fill the port number as in the account settings.
1864 (modest_connection_specific_smtp_edit_window_set_connection):
1865 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1866 * src/maemo/modest-connection-specific-smtp-window.c:
1867 (fill_with_connections), (on_button_edit),
1868 (modest_connection_specific_smtp_window_init):
1869 Turn the edit window into a dialog to simplify the code, and
1870 set a WM hint as in a GtkDialog, because only a popup can be on top of
1871 another window in Maemo, and popups usually have no WM decoration.
1873 * src/modest-defs.h:
1874 * src/modest-account-mgr-helpers.c:
1875 (modest_account_mgr_set_connection_specific_smtp),
1876 (modest_account_mgr_remove_connection_specific_smtp),
1877 (modest_account_mgr_get_connection_specific_smtp):
1878 * src/modest-account-mgr-helpers.h: Some functions to write the
1879 connection-specific SMTP server information. Not yet used.
1882 * src/widgets/modest-folder-view.c: (text_cell_data):
1883 Fix a warning about an uninitialized variable.
1884 (on_configuration_key_changed): Put an #ifdef around the use
1885 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1887 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1889 * src/maemo/modest-account-settings-dialog.h:
1890 * src/maemo/modest-account-settings-dialog.c:
1891 Added connect_for_modified() utility function to mark the new modified boolean.
1893 (create_page_account_details), (create_page_user_details),
1894 (create_page_incoming), (create_page_outgoing), (on_response),
1895 (modest_account_settings_dialog_init),
1896 (modest_account_settings_dialog_set_account_name):
1897 Only warn about unsaved changes when there are actually unsaved changes.
1899 * src/modest-account-mgr-helpers.c:
1900 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1901 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1902 to get the data from there in future.
1904 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1906 * src/modest-defs.h:
1908 * src/modest-account-mgr-helpers.h:
1909 * src/modest-account-mgr-helpers.c:
1910 Store the security account setting in a single conf key instead of using
1911 the options list, so that the list is left for just the to-be-removed camel hack,
1912 and because gconf_client_set_list() is failing for some reason.
1914 * src/modest-account-mgr.c:
1915 (modest_account_mgr_add_server_account):
1916 * src/maemo/modest-account-settings-dialog.c:
1917 (modest_account_settings_dialog_set_account_name),
1918 (save_configuration): Use the renamed functions.
1921 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1923 * src/widgets/Makefile.am:
1924 * src/widgets/modest-limit-retrieve-combo-box.c:
1925 * src/widgets/modest-limit-retrieve-combo-box.h:
1926 * src/widgets/modest-retrieve-combo-box.c:
1927 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1928 the account settings dialog.
1930 * src/modest-defs.h:
1931 * src/modest-account-mgr-helpers.h:
1932 * src/modest-account-mgr-helpers.c:
1933 (modest_server_account_get_option_secure_auth),
1934 (modest_server_account_set_option_secure_auth):
1935 * src/modest-account-mgr.c:
1936 (modest_account_mgr_add_server_account):
1937 Use the existing AUTH_MECH conf key for the secure-auth setting,
1938 instead of putting it in the list options, because this was actually used already.
1940 * src/maemo/modest-account-settings-dialog.c:
1941 (create_page_account_details),
1942 (modest_account_settings_dialog_set_account_name),
1943 (save_configuration):
1944 * src/maemo/modest-account-settings-dialog.h:
1945 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1946 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1948 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1950 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1951 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1952 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1954 * src/modest-defs.h:
1955 * src/maemo/modest-account-settings-dialog.c:
1956 (create_page_incoming), (on_combo_outgoing_security_changed),
1957 (on_combo_incoming_security_changed), (create_page_outgoing),
1958 (modest_account_settings_dialog_set_account_name),
1959 (save_configuration): Load/Save the port number, and change it when the
1960 security combo changes, to suitable defaults.
1962 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1964 * src/modest-account-mgr.c:
1965 (modest_account_mgr_add_server_account): Set the security and secure-auth
1966 options, and add a comment saying that the other camel-specific options should be
1969 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1971 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1973 * src/modest-tny-account-store.c: (account_list_free),
1974 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1975 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1978 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1980 * src/modest-protocol-info.c:
1981 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1982 is required by our UI spec. Maybe something in our implementation will use this eventually.
1983 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1984 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1985 instead of the previous 0 placeholder.
1987 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1988 secure-auth settings.
1989 * src/modest-account-mgr-helpers.h:
1990 * src/modest-account-mgr-helpers.c:
1991 (modest_server_account_data_get_option_secure_auth),
1992 (modest_server_account_set_option_secure_auth),
1993 (modest_server_account_data_get_option_security),
1994 (modest_server_account_set_option_security): Added this API for getting and setting the security
1995 and secure-auth settings.
1997 * src/maemo/modest-account-settings-dialog.h:
1998 * src/maemo/modest-account-settings-dialog.c:
1999 (modest_account_settings_dialog_finalize), (check_data),
2000 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2001 about changing titles.
2002 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2003 (save_configuration): Save the security and secure-auth settings.
2005 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2006 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2008 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2010 * src/modest-defs.h:
2011 * src/modest-account-mgr.c:
2012 (modest_account_mgr_add_server_account):
2013 Added and used defines for the options key and value pair strings,
2014 that are used so far, though they do not seem to correspond to anything in our
2015 UI specs or ModestProtocol enum.
2017 * src/modest-account-mgr-helpers.h:
2018 * src/modest-account-mgr-helpers.c:
2019 (compare_option_strings_for_name),
2020 (modest_server_account_data_get_option_value),
2021 (modest_server_account_data_get_option_bool),
2022 (modest_account_mgr_get_server_account_option):
2023 Added helper functions for parsing the options GSList.
2025 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2027 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2028 display name is based on the supplied account name.
2029 * src/modest-account-mgr.c:
2030 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2031 with an inefficient, but good-enough, implementation.
2033 * src/maemo/easysetup/modest-easysetup-wizard.c:
2034 (create_page_account_details), (on_before_next), (create_account):
2035 Check for existing display names rather than (non-user-visible) account names, and just
2036 create and set a unique account name at the end.
2038 * src/maemo/modest-account-settings-dialog.c:
2039 (modest_account_settings_dialog_init),
2040 (modest_account_settings_dialog_set_account_name),
2041 (create_page_incoming): Show the display name, instead of the account name.
2042 (on_response): Do some (not all) extra checks, as in the UI spec.
2043 (save_configuration): Save the display name if it was changed.
2045 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2047 * po/en_GB.po: Added needed logical ID and translation.
2048 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2049 (init_view): Made the is-default column clicking work.
2051 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2054 * src/maemo/easysetup/Makefile.am:
2055 * src/maemo/easysetup/modest-easysetup-wizard.c:
2056 (modest_easysetup_wizard_dialog_init):
2057 * src/maemo/easysetup/provider-data-test.keyfile:
2058 * src/maemo/easysetup/provider-data.keyfile:
2059 Moved the provider data file to the new modest-providers-data package and used it from there.
2061 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2063 * src/modest-local-folder-info.c:
2064 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2065 N_() was already used on the static strings, but this just marks it for translation without
2066 using the translation.
2068 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2070 * src/maemo/modest-account-settings-dialog.c:
2071 (create_page_incoming),
2072 (modest_account_settings_dialog_set_account_name):
2073 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2074 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2075 I will do this if nobody else gets there first.
2077 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2079 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2080 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2081 save the security stuff.
2083 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2085 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2086 Set the email address and user fullname, which I now see must be
2089 * src/maemo/modest-account-settings-dialog.h:
2090 * src/maemo/modest-account-settings-dialog.c:
2092 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2093 leave-on-server and authentication.
2094 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2097 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2100 * src/maemo/modest-account-settings-dialog.c:
2101 * src/maemo/modest-account-settings-dialog.h:
2102 Most (but not all) of the widgets are now present as specified by the UI spec.
2103 No changes are yet saved, and some details are not properly shown yet.
2105 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2107 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2109 * src/maemo/Makefile.am:
2110 * src/maemo/modest-account-settings-dialog.c:
2111 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2112 an existing account. Doesn't do much yet.
2114 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2115 Open the accounts settings dialog when Edit is clicked.
2117 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2119 * src/maemo/easysetup/Makefile.am:
2120 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2122 * src/maemo/easysetup/modest-easysetup-wizard.c:
2123 (modest_easysetup_wizard_dialog_init):
2124 Try to get the source directory from the build system,
2125 instead of hard-coding "./" into the source code, when opening our local
2126 copies of the configuration files.
2127 But this still fails when opening the wizard from the Accounts window,
2128 maybe because the working directory seems to change at runtime.
2129 So the wizard will fail the second time unless you copy the files into their
2130 proper locations - see the stdout warnings for the paths.
2132 (create_page_account_details),(on_before_next):
2133 Check for existing non-server accounts instead of server accounts,
2134 so the default account name is useful again, and to prevent trying to
2137 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2138 Show the wizard when New is clicked.
2140 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2141 (init_view): Show the column headers, and show the columns that are
2142 specified in the UI specs. However, something in Maemo's GTK+ prevents
2143 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2144 change the default account. This is despite unsetting the special properties.
2146 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2148 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2149 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2150 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2151 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2152 to make that clearer.
2153 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2155 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2157 * src/maemo/modest-account-view-window.c:
2158 (modest_account_view_window_init),
2159 (modest_account_view_window_new):
2160 Use the same buttons as specified in the
2161 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2162 the existing widgets, which never had a chance of working.
2163 Put the ModestAccountView treeview in a scrolled window.
2164 Do not repeat the initialization in both _init() and _new().
2166 * src/widgets/modest-account-view.c: (update_account_view):
2167 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2168 this widget and window shows no accounts.
2170 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2172 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2174 * src/maemo/easysetup/modest-easysetup-wizard.c:
2175 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2176 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2177 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2180 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2181 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2182 accounts exist yet, as in the UI spec.
2184 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2186 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2188 * src/maemo/Makefile.am:
2189 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2190 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2191 New window for editing connection-specific smtp details.
2192 Not fully implemented.
2194 * src/maemo/modest-connection-specific-smtp-window.c:
2195 (modest_connection_specific_smtp_window_finalize) :
2196 unref the tree model.
2197 (on_button_edit): Show the edit window.
2199 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2201 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2204 * src/maemo/Makefile.am:
2205 * src/maemo/modest-connection-specific-smtp-window.c:
2206 * src/maemo/modest-connection-specific-smtp-window.h:
2207 New window for showing the list of connections, for connection-specific
2208 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2209 * src/maemo/easysetup/modest-easysetup-wizard.c:
2210 (create_page_custom_outgoing): Show the new window when the button is clicked.
2212 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2214 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2215 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2216 * src/maemo/modest-msg-edit-window.c:
2217 (modest_msg_edit_window_insert_image):
2218 * src/modest-conf.c: (modest_conf_key_escape):
2219 * src/modest-mail-operation.c:
2220 (modest_mail_operation_send_new_mail):
2221 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2222 (modest_ui_actions_on_new_account):
2223 * src/widgets/modest-attachment-view.c: (update_filename_request):
2224 * src/widgets/modest-mail-header-view.c:
2225 Corrected warnings that were breaking the build, by commenting out unused variables,
2226 and a function, and by including a header.
2228 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2230 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2231 so we can #ifdef around platform-specific code when necessary.
2232 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2233 to allow this to build for the GNOME platform too.
2235 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2237 * src/maemo/easysetup/modest-easysetup-wizard.c:
2238 Added util_increment_name() and used it in create_page_account_details()
2239 to make sure that the default account name is always a new name.
2241 (modest_easysetup_wizard_dialog_init),
2242 (set_default_custom_servernames): Some minor memory management fixes.
2244 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2248 * src/modest-runtime.c: (init_i18n): Restored the translation
2249 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2250 are defined in config.h, and the translations are installed.
2252 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2253 is defined for translation.
2255 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2257 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2259 * src/maemo/easysetup/modest-easysetup-wizard.c:
2260 (modest_easysetup_wizard_dialog_init):
2261 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2262 Use realistic paths (though they should use $prefix generically) to the
2263 mcc_mapping and provider-data.keyfile files which might work when they
2264 are installed by the future version of the operator-wizard package,
2265 and then fallback to paths in our source code, with an explanatory
2268 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2272 * src/maemo/Makefile.am:
2273 * src/maemo/easysetup/: Added files from the previously-exernal
2274 osso-modest-easysetup.
2275 * src/maemo/modest-main-window-ui.h:
2276 * src/modest-ui-actions.c:
2277 * src/modest-ui-actions.h:
2278 Added modest_ui_actions_on_new_account() as a signal handler for the
2279 New Account menu item. It shows the easysetup wizard.
2280 * po/en_GB.po: Added additional needed logical IDs and translations.
2282 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2283 Apparently ChangeLog is not used for some vague Nokia legal reasons.