1 2007-08-27 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
4 which checks every second, 10 times, to wait until the account is online
5 so that we can use it, if the account is in the process of going online.
6 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
7 so that searching works even when the application was not yet started before.
8 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
10 2007-08-24 Armin Burgmeier <armin@openismus.com>
12 * src/modest-widget-memory.c: Always show the default account when the
13 application is started, as stated in the UI spec. This fixes
14 projects.maemo.org bug NB#66630.
16 2007-08-24 Armin Burgmeier <armin@openismus.com>
18 * src/maemo/modest-platform.c:
19 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
20 english text for strings in the rename folder dialog, fixing
21 projects.maemo.org bug NB#66338.
23 2007-08-22 Armin Burgmeier <armin@openismus.com>
25 * src/widgets/modest-account-view.c: Fix for bora by using
26 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
27 latter seems not be used anymore.
29 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
32 * src/maemo/modest-main-window.c: Update menu items when the default
33 account changes so that the current default account is always bolded.
34 This fixes maemo.projects.org bug NB#66173.
36 2007-08-17 Murray Cumming <murrayc@murrayc.com>
38 * src/dbus_api/modest-dbus-callbacks.c:
39 (on_dbus_method_get_folders): Avoid trying to get the account name
40 when there are no accounts, to avoid critical g_warnings, fixing
41 projects.maemo.org bug NB#65574.
43 2007-08-17 Murray Cumming <murrayc@murrayc.com>
45 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
46 Use modest_account_mgr_get_signature() instead of accessing gconf
47 directly, to slightly simplify the code.
48 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
49 Append the signature also when opening via other applications,
50 fixing projects.maemo.org bug NB#65828.
52 2007-08-17 Murray Cumming <murrayc@murrayc.com>
54 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
55 Check for NULLs to prevent a crash when opening an email that is
56 an attachment in another email, fixing projects.maemo.org bug
59 2007-08-17 Murray Cumming <murrayc@murrayc.com>
61 * src/modest-ui-dimming-rules.c:
62 (modest_ui_dimming_rules_on_view_window_move_to):
63 Enable the Move To toolbar button for search results, fixing the
64 last part of projects.maemo.org bug NB#63807.
66 2007-08-17 Murray Cumming <murrayc@murrayc.com>
68 * src/dbus_api/modest-dbus-callbacks.c:
69 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
70 because this is called from idle handlers, to fix hangs afte the
72 (find_message_by_url): Added a TODO comment about a crash that
73 happens when tinymail was built with DBC checks.
75 2007-08-16 Murray Cumming <murrayc@murrayc.com>
77 * src/modest-search.c: (modest_search_folder):
78 * src/modest-search.h: Rename ModestSearch::before to start_date
79 and after to end_date, using the same names as the libogs struct
81 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
82 The start_date and end_date were swapped in the check. This
83 fixes date range searches, fixing projects.maemo.org bug NB#63407.
85 2007-08-16 Murray Cumming <murrayc@murrayc.com>
87 * src/maemo/modest-account-view-window.c:
88 Added (check_for_active_acount).
89 (on_delete_button_clicked), (on_edit_button_clicked):
90 When an account is doing something (such as refreshing),
91 show the same warning for account deletion as for account
92 editing, to fix projects.maemo.org bug NB#64588.
94 2007-08-16 Murray Cumming <murrayc@murrayc.com>
96 * src/widgets/modest-msg-view-window.h:
97 * src/gnome/modest-msg-view-window.c:
98 * src/maemo/modest-msg-view-window.c:
99 Added modest_msg_view_window_construct().
100 (modest_msg_view_window_new_with_header_model),
101 Added modest_msg_view_window_new_for_search_result),
102 Renamed modest_msg_view_window_new() to
103 modest_msg_view_window_new_for_attachment(),
104 and modest_msg_view_window_is_search_result(),
105 so we can explicitly know that the window is for an
106 attachment or a search result or a message from the list.
108 (modest_msg_view_window_view_attachment):
109 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
110 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
111 Use modest_msg_view_window_new_for_search_result().
113 * src/modest-ui-dimming-rules.c:
114 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
115 for search results, fixing projects.maemo.org bug NB#63811.
117 2007-08-16 Armin Burgmeier <armin@openismus.com>
119 * src/modest-ui-actions.c: Show a banner instead of a dialog when
120 renaming a folder fails, to stay consistent with what happens when
121 creating a folder fails.
123 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
124 slightly country loading from the mmc_mappings file, fixed a memory
127 2007-08-16 Murray Cumming <murrayc@murrayc.com>
129 * src/modest-tny-account-store.c: (volume_path_is_mounted):
130 Check the GnomeVFSVolume activation path instead of the device path,
131 so that the memory card is really really shown in the UI.
133 2007-08-16 Murray Cumming <murrayc@murrayc.com>
135 * src/maemo/easysetup/modest-easysetup-wizard.c:
136 (get_entered_account_title), (on_before_next), (entry_is_empty),
138 * src/maemo/modest-account-settings-dialog.c:
139 (get_entered_account_title), (on_button_signature), (check_data),
140 (save_configuration), (entry_is_empty):
141 Strip the account title of whitespace at the start and end before
142 using it or checking it. This means that an all-whitespace title
143 is not allowed, fixing projects.maemo.org bug NB#64977.
145 2007-08-15 Murray Cumming <murrayc@murrayc.com>
147 * src/modest-ui-actions.h:
148 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
149 to modest_run_account_setup_wizard() and made it public.
150 * src/dbus_api/modest-dbus-callbacks.c:
151 (check_and_offer_account_creation), (on_idle_mail_to),
152 (on_idle_compose_mail), (on_idle_open_default_inbox):
153 Offer account creation if necessary, fixing projects.maemo.org
156 2007-08-15 Murray Cumming <murrayc@murrayc.com>
158 * src/modest-ui-actions.c: (run_account_setup_wizard):
159 Return a gboolean to indicate success.
160 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
161 (modest_ui_actions_on_send): When offering account creation, only
162 give up (return) if account creation failed. Otherwise continue
163 with the original request. This fixed projects.maemo.org bug
166 2007-08-15 Murray Cumming <murrayc@murrayc.com>
168 * src/widgets/modest-recpt-editor.c:
169 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
170 to fix projects.maemo.org bug NB#63789.
172 2007-08-15 Murray Cumming <murrayc@murrayc.com>
174 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
175 (modest_tny_account_store_new): Properly detect the memory card at
176 startup, and add an account for it.
178 2007-08-14 Murray Cumming <murrayc@murrayc.com>
180 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
181 Commented out the MMC code again because it mistakenly detects
182 the card even when it isn't inserted.
184 2007-08-14 Murray Cumming <murrayc@murrayc.com>
186 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
187 Renabled the call to add_mmc_account() because I do not believe
188 it could be the cause of the mentioned hang (in scratchbox, where
189 there is no memory card), and because I have tested that it works
192 2007-08-14 Murray Cumming <murrayc@murrayc.com>
194 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
195 Comment out part of the last commit because it apparently causes
198 2007-08-14 Murray Cumming <murrayc@murrayc.com>
200 * src/modest-tny-account-store.c: Added the add_mmc_account()
201 function to save some copy/pasting.
202 (modest_tny_account_store_new): If the memory card is mounted,
203 create an account for it at the start, instead of waiting for the
204 user to unmount it and mount it.
206 2007-08-13 Murray Cumming <murrayc@murrayc.com>
208 * src/widgets/modest-account-view.c: (on_account_changed):
209 Do not try to use the human-readable TnyAccount name instead of the
210 ID of the modest account to get the transport account. And unref
211 the transport account. This prevents a g_warning(), and a possible
214 2007-08-13 Murray Cumming <murrayc@murrayc.com>
216 * src/maemo/modest-platform.c:
217 (modest_platform_set_update_interval): Handle the new
218 alarmd error to warn when alarmd is not running, as is the case in
219 scratchbox for me now because
220 "Module /usr/lib/alarmd/libretu.so initialization failed"
222 2007-08-13 Murray Cumming <murrayc@murrayc.com>
224 * src/widgets/modest-header-view-render.c:
225 (_modest_header_view_compact_header_cell_data):
226 NULL some strings after freeing them, trying to deal with
227 the double deletion found in projects.maemo.org bug 64183,
228 probably having no effect.
230 2007-08-13 Murray Cumming <murrayc@murrayc.com>
232 * src/maemo/modest-account-settings-dialog.c:
233 (create_page_incoming), (create_page_outgoing): Use a define
234 for the min and max port numbers.
236 (check_hildon_number_editor_and_warn_value_not_in_range),
237 (check_data): Do an extra check for an invalid port number, as needed
238 in projects.maemo.org bug #64275, when the number is cleared, but this
239 does not work due to bugs.maemo.org bug #1806.
241 2007-08-13 Murray Cumming <murrayc@murrayc.com>
243 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
244 Comment out the debug warning about the unexpected D-Bus methods.
245 They are just annoying now.
246 * src/maemo/modest-platform.c:
247 (modest_platform_set_update_interval): Correct the D-Bus path, instead
248 of using a file path, though it did not seem to break things before.
249 It might be needed now:
250 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
251 modest is not already running. This is the behaviour of the old client, and
252 Mox says it is what we should do for modest.
253 This closes projects.maemo.org bug NB#64327.
255 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
257 * src/modest-text-utils.c:
258 Fixed invalid jump due to incorrect string/pointer
260 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
263 2007-08-01 Murray Cumming <murrayc@murrayc.com>
265 * src/modest-account-mgr-helpers.h:
266 * src/modest-account-mgr-helpers.c:
267 Added modest_account_mgr_get_first_account_name(),
268 using code from modest_account_mgr_set_first_account_as_default().
270 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
271 (account_number_changed): Call set_at_least_one_account_visible() so that
272 the first account is visible when first added, without the user having to
274 I do wonder how this worked before.
276 2007-08-01 Murray Cumming <murrayc@murrayc.com>
278 * src/modest-tny-account-store.c: (show_password_warning_only),
279 (show_wrong_password), (request_password_and_wait), (get_password),
280 (modest_tny_account_store_alert): Remove the (incomplete anyway)
281 attempts to show UI only in the main context, which used g_idle_add()
282 and mainloops, because tinymail now guarantees that it only calls these
283 callbacks in the mainloop with the gdk lock. This makes everything much
286 2007-08-01 Murray Cumming <murrayc@murrayc.com>
288 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
289 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
290 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
291 error dialog, instead of ignoring it.
293 2007-08-01 Murray Cumming <murrayc@murrayc.com>
295 * src/maemo/modest-msg-view-window.c:
296 (modest_msg_view_window_get_header),
297 (modest_msg_view_window_last_message_selected):
298 Added comments to explain the use of priv->header_model.
299 * src/modest-ui-dimming-rules.c:
300 (modest_ui_dimming_rules_on_open_msg),
301 (modest_ui_dimming_rules_on_mark_as_read_msg),
302 (modest_ui_dimming_rules_on_mark_as_unread_msg),
303 (modest_ui_dimming_rules_on_remove_attachments),
304 (_invalid_attach_selected), (_selected_msg_marked_as):
305 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
306 and changed the parameter to a ModestMainWindow to make it clearer that
307 it never uses any other kind of window.
308 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
309 instead of the selected message.
310 I notice that much of the dimming code and the ModestMsgViewWindow code
311 hard-codes the assumption that the viewed message is always selected in
312 the header view. This does not seem wise or simple.
314 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
315 examine the actual message instead of whatever might be selected
316 in the header view. This stops the delete toolbar button and menu item
317 from being dimmed when opening a message view the search UI,
318 partially fixing projects.maemo.org bug NB#63811.
320 However, when actually deleting, I now get this warning:
321 "tny_header_set_flags: This is a header instance for a new message.
322 Only priority and attachment flags are supported"
324 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
326 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
328 Show account wizard if no accounts are defined while sending
329 (automatic sending after the account wizard finished does not
330 work because it takes some time until the account manager
331 synchronizes everything. (projects.maemo.org NB#62792)
333 2007-07-30 Murray Cumming <murrayc@murrayc.com>
335 * src/modest-tny-account-store.c: (on_account_removed),
336 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
337 account is removed from the View menu. We have TnyAccountStore
338 and ModestTnyAccountStore signals that seem very similar, but this
339 seems to work for now.
341 * src/maemo/modest-main-window.c:
342 (on_show_account_action_activated): Prevent dereference
343 of a NULL if the accoutn does not really exist, though that
344 should not happen anymore.
346 This fixes projects.maemo.org bug NB#64606.
348 2007-07-30 Murray Cumming <murrayc@murrayc.com>
350 * src/modest-ui-actions.c: (run_account_setup_wizard),
351 (modest_ui_actions_on_accounts): Revert a change that set these
352 to modal dialogs, freezing the UI when they show secondary dialogs.
353 This fixed projects.maemo.org bug NB#64519.
355 2007-07-27 Murray Cumming <murrayc@murrayc.com>
357 * src/widgets/modest-header-view-render.c:
358 (_modest_header_view_compact_header_cell_data):
359 Some checks and initialization to try to deal with a crash,
360 probably ineffective.
362 2007-07-27 Murray Cumming <murrayc@murrayc.com>
364 * src/maemo/modest-maemo-utils.c:
365 (modest_maemo_utils_get_supported_secure_authentication_methods):
366 Make sure that we have a connection, asking the user for one
368 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
369 Check for a connection before showing the wizard, because
370 the wizard needs a connection to check for server capabilities.
372 2007-07-27 Murray Cumming <murrayc@murrayc.com>
374 * src/maemo/modest-account-view-window.c:
375 (on_new_button_clicked): Remember the wizard dialog instance,
376 so we can just present it again if necessary. This prevents
377 multiple windows from appearing if you click again quickly on the
378 New button before the dialog appears, fixing projects.maemo.org
381 2007-07-27 Murray Cumming <murrayc@murrayc.com>
383 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
384 Offer a connection dialog if there is no connection when
385 starting modest. This should fix projects.maemo.org bug NB#61134.
387 2007-07-27 Murray Cumming <murrayc@murrayc.com>
389 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
390 Reverted my last commit. I was able to fix the build by doing
391 apt-get install wpeditor0 (replacing other wpeditor packages) and
392 an explicit apt-get install wpeditor-dev to upgrade the -dev
395 2007-07-27 Murray Cumming <murrayc@murrayc.com>
397 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
398 Commented out the use of wp_text_buffer_replace_image()
399 because it does not exist, to break the build. Added a TODO for it.
401 2007-07-26 Murray Cumming <murrayc@murrayc.com>
403 * src/modest-tny-account-store.c: (recreate_all_accounts):
404 Recreate them even if they were NULL before. I guess something
405 else was already creating them before, or this would never
407 (modest_tny_account_store_get_server_account): Make sure that
408 the tny accounts have been created before trying to find one.
409 This allows libmodest_dbus_client_compose_mail() to work
410 when the UI is not yet visible.
411 This is probably useful in other cases too.
413 (get_password): When the password is wrong after it is entered
414 in the protected password dialog, show an info banner (in an
415 idle handler) before showing the protected password dialog
418 2007-07-26 Murray Cumming <murrayc@murrayc.com>
420 * src/modest-ui-actions.h:
421 * src/modest-ui-actions.c: Added
422 modest_do_refresh_current_folder() containing some code from
423 modest_ui_actions_on_send_receive().
424 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
425 Call modest_do_refresh_current_folder() before refreshing the
426 requested account, as in modest_ui_actions_on_send_receive().
427 This is strange, but seems to be necessary to show new mails.
428 Now new emails are finally visible in the UI when downloaded
429 via the automatic update interval, fixing bug NB#57458.
430 This also works because bug NB#57458 has been fixed somehow.
432 2007-07-26 Murray Cumming <murrayc@murrayc.com>
434 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
435 printf more details when we get unhandled D-Bus methods, because
438 * src/modest-mail-operation.c: (update_account_thread):
439 Comment out the tny_camel_pop_store_account_reconnect(), because this
440 is apparently no longer needed, and it did not work before anyway.
441 See the comment in the code.
443 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
444 by checking the header flags. This fixes projects.maemo.org bug
447 2007-07-25 Murray Cumming <murrayc@murrayc.com>
449 * src/maemo/modest-maemo-utils.h:
450 * src/maemo/modest-maemo-utils.c: Added
451 modest_maemo_show_information_note_in_main_context_and_forget().
452 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
453 Use the new function to show simple error dialogs in the main
454 context, though question dialogs are still in the current context,
455 which is unfortunately usually not the main context. This should
458 2007-07-25 Murray Cumming <murrayc@murrayc.com>
460 * src/modest-tny-account-store.c: (get_password):
461 Never save the entered username and password in gconf,
462 because the UI spec says we should not. This helps
463 slightly with projects.maemo.org bug NB#63671.
465 2007-07-25 Murray Cumming <murrayc@murrayc.com>
467 * src/widgets/modest-msg-edit-window.h:
468 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
469 Moved some code here to make it simpler.
470 (modest_msg_edit_window_attach_file_one): Renamed from
471 modest_msg_edit_window_attach_file_interactive().
472 (modest_msg_edit_window_offer_attach_file): Renamed from
473 modest_msg_edit_window_attach_file() and used
474 modest_msg_edit_window_attach_file_one() instead of
475 copy/pasting the code. The old code for one was not using
476 GnomeVFS. This allows use of smb:// URLs when using send-as
477 from external applications, fixing bug NB#63741.
479 (modest_msg_edit_window_insert_image),
480 (modest_msg_edit_window_add_attachment_clicked):
481 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
482 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
483 Adapted to the new function names.
485 2007-07-25 Murray Cumming <murrayc@murrayc.com>
487 (modest_platform_set_update_interval): Set the alarm recurrence
488 fields so that auto-update does not just happen the first time.
489 This should have fixed projects.maemo.org bug NB#63938.
491 When this happens you can see a printf when the D-Bus method is
493 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
495 However, I do not actually seem to get new POP messages even when
496 clicking the refresh button manually. A restart gets them.
497 This might be a problem in today's tinymail only.
499 2007-07-24 Murray Cumming <murrayc@murrayc.com>
501 * src/maemo/modest-maemo-global-settings-dialog.c:
502 (current_connection):
503 Avoid a crash (probably only in scratchbox) when strcmp()ing a
504 NULL when closing the dialog.
506 2007-07-24 Murray Cumming <murrayc@murrayc.com>
508 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
509 Remove the hacky send/receive that didn't work, and instead
510 refilter the treemodel to make the deleted email really vanish from
511 the UI (though the delete-from-menu code does has commented out
512 the code that does that). This fixes projects.maemo.org bug
515 2007-07-24 Murray Cumming <murrayc@murrayc.com>
517 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
518 Try a couple of tricks to force the treeview to update (
519 poke the folder, and do a send/receive refresh), but the deleted
520 email still appears with a strike-through instead of really being
523 2007-07-23 Murray Cumming <murrayc@murrayc.com>
525 * src/dbus_api/modest-dbus-callbacks.c:
526 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
527 because their ID is not human-readable (see the comment about
528 improvements needed to the osso-email-interface API) and
529 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
531 2007-07-23 Murray Cumming <murrayc@murrayc.com>
533 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
534 (add_folders_to_list), (on_dbus_method_get_folders),
535 (modest_dbus_req_filter):
536 * src/maemo/modest-maemo-utils.c:
537 (on_camel_account_get_supported_secure_authentication):
538 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
539 (on_header_view_focus_in):
540 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
541 * src/modest-formatter.c: (modest_formatter_create_body_part):
542 * src/modest-mail-operation.c: (recurse_folders),
543 (update_account_thread), (get_msgs_full_thread),
544 (modest_mail_operation_get_msgs_full),
545 (modest_mail_operation_xfer_msgs):
546 * src/modest-search.c: (search_mime_part_and_child_parts),
547 (modest_search_account), (modest_search_all_accounts):
548 * src/modest-tny-account.c:
549 (modest_tny_account_get_special_folder), (recurse_folders):
550 * src/modest-tny-local-folders-account.c:
551 (modest_tny_local_folders_account_query_passes):
552 * src/modest-tny-msg.c: (copy_mime_part),
553 (modest_tny_msg_find_body_part_from_mime_part):
554 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
555 (modest_tny_send_queue_try_to_send):
556 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
557 (_modest_ui_actions_open), (download_uncached_messages),
558 (reply_forward), (modest_ui_actions_on_copy),
559 (modest_ui_actions_on_details), (has_retrieved_msgs),
560 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
562 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
563 (_selected_msg_marked_as), (_msg_download_completed),
564 (_selected_msg_sent_in_progress):
565 * src/widgets/modest-attachments-view.c:
566 (modest_attachments_view_set_message):
567 * src/widgets/modest-msg-view.c: (find_cid_image):
568 * tests/check_folder-transfer.c: (find_folders):
569 * tests/check_update-account.c: (func):
570 * tests/dbus_api/test_get_folders.c: (main):
571 Checked all uses of tny_iterator_get_current(), making sure
572 that the object is unreferenced (3 or 4 places did not),
573 and adding checks for NULL.
575 2007-07-23 Murray Cumming <murrayc@murrayc.com>
577 * src/dbus_api/modest-dbus-callbacks.c:
578 (on_idle_open_default_inbox): Make sure that the application UI is
580 * src/maemo/easysetup/modest-easysetup-wizard.c:
581 (on_entry_invalid_character): Show the word whitespace instead
582 of (null) in the banner when whitespace was entered.
583 (show_error): Add a comment that this does not work in
584 Maemo Bora, though we do not know why.
586 2007-07-23 Murray Cumming <murrayc@murrayc.com>
588 * src/modest-tny-account.c:
589 (modest_tny_account_get_special_folder): Use an if instead of
590 an assert for when the parent account name is NULL, because this
591 might be causing a crash in projects.maemo.org bug 63192.
592 * src/modest-mail-operation.c:
593 (modest_mail_operation_send_new_mail_cb),
594 (modest_mail_operation_remove_folder): unref the folder that is
595 returned from modest_tny_account_get_special_folder().
597 2007-07-23 Murray Cumming <murrayc@murrayc.com>
599 * src/modest-ui-actions.c:
600 (modest_ui_actions_on_password_requested):
601 Show mail_ib_login_cancelled info banner when the user cancels
602 the protected password dialog, to fix projects.maemo.org
605 2007-07-23 Murray Cumming <murrayc@murrayc.com>
607 * src/maemo/modest-account-settings-dialog.c:
608 (create_page_outgoing): Put this page in a GtkScrolledWindow,
609 matching the UI mock-up in the UI spec, and allowing access
610 to all widgets even when the on-screen keyboard is active.
612 2007-07-23 Murray Cumming <murrayc@murrayc.com>
614 Reverted this previous commit from Johannes,
615 because the scrollbars are always visible and because
616 I think we only need it on onepage of the account
617 settings, not the account wizard.
618 (I wrote the wrong instructions in the bug.)
620 * src/maemo/easysetup/modest-easysetup-wizard.c:
621 Added scrollbars to account wizard dialog.
622 Fixed projects.maemo.org NB #62744
624 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
626 * src/maemo/easysetup/modest-easysetup-wizard.c:
627 (create_page_user_details):
628 Use auto-cap for name (projects.maemo.org NB#63716)
629 * src/widgets/modest-account-view.c: (on_account_busy_changed):
631 2007-07-22 Armin Burgmeier <armin@openismus.com>
633 * src/maemo/modest-ui-actions.c: Use current account instead of
634 default account for creating viewer windows, so that the viewer
635 window knows to which account the viewed message belongs.
637 * src/maemo/modest-msg-view-window.c: Destroy the window when the
638 corresponding account is deleted. This fixes projects.maemo.org bug
641 2007-07-18 Armin Burgmeier <armin@openismus.com>
643 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
644 the dialog close after entering an invalid port number and clicking
645 OK. This fixes projects.maemo.org bug NB#63602.
647 2007-07-18 Armin Burgmeier <armin@openismus.com>
649 * src/modest-tny-account-store.c:
650 (get_server_accounts): Set parent modest account name for each
651 connection-specific transport account so that special folders of such
652 an account can be looked up. This fixes a crash when changing account
653 settings. This might also be related to projects.maemo.org bug
656 2007-07-16 Armin Burgmeier <armin@openismus.com>
658 * src/modest-ui-actions.c: Added a button to create a folder to the
659 move-to dialog. This fixes projects.maemo.org bug NB#59863.
661 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
663 * src/maemo/easysetup/modest-easysetup-wizard.c:
664 Added scrollbars to account wizard dialog.
665 Fixed projects.maemo.org NB #62744
667 2007-07-16 Murray Cumming <murrayc@murrayc.com>
669 * src/widgets/modest-msg-view.h:
670 * src/widgets/modest-msg-view.c:
671 Added modest_msg_view_get_message_is_empty() but this needs
673 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
674 Check if there is any text in the message yet.
675 But this needs to be implemented properly.
676 (modest_msg_edit_window_toggle_find_toolbar):
677 * src/maemo/modest-msg-view-window.c:
678 (modest_msg_view_window_toggle_find_toolbar):
679 Show a banner warning if there is no text to search, when
680 trying to start a search. This partially fixes
681 projects.maemo.org bug NB#62350.
683 2007-07-13 Murray Cumming <murrayc@murrayc.com>
685 * src/modest-mail-operation.c: (update_account_thread):
686 Initialized num_new_headers to fix the build.
688 2007-07-13 Murray Cumming <murrayc@murrayc.com>
690 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
691 Ignore modest accounts whose server accounts don't exist in gconf.
692 This prevents us trying to create TnyAccount instances for those
693 server accounts when the server account has been removed from gconf,
694 but the parent modest account has not yet been removed from modest.
695 I don't know why this is only noticeable now. It was probably just
696 a harmeless g_warning() anyway.
698 2007-07-13 Murray Cumming <murrayc@murrayc.com>
700 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
701 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
703 2007-07-12 Armin Burgmeier <armin@openismus.com>
705 * src/maemo/modest-main-window.c: Make default account appear bold
706 in view, tools/send & receive and toolbar/send & receive SCM menus.
707 This fixes projects.maemo.org bug NB#59010.
709 2007-07-12 Murray Cumming <murrayc@murrayc.com>
711 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
712 Add a short-cut, by checking if the folder store is an account.
713 This ensures that the Sort menu item and toolbar is dimmed for
714 the local-folders account root item, fixing
715 projects.maemo.org bug NB#62545.
717 2007-07-12 Murray Cumming <murrayc@murrayc.com>
719 * src/modest-tny-account-store.c: (get_password):
720 Show the password dialog (via the signal) only in the mainloop, via
721 an idle handler that we wait for. This could theoretically prevent
722 hangs, though I worry that it could introduce some too.
724 2007-07-12 Murray Cumming <murrayc@murrayc.com>
726 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
727 * src/maemo/modest-platform.c:
728 (modest_platform_connect_and_wait):
729 Take a TnyAccount* parameter and try to set it to online
730 (a TnyCamel-only API), because tinymail sets accounts to offline
731 when the user cancels a password dialog, and doesn't ask again until
732 it has been set to online.
733 However, this is commented out because it causes a hang now.
735 (modest_platform_connect_and_wait_if_network_account):
736 * src/modest-mail-operation.c:
737 (modest_mail_operation_update_account):
738 * src/modest-platform.h:
739 * src/modest-ui-actions.c: (_modest_ui_actions_open),
740 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
742 2007-07-12 Armin Burgmeier <armin@openismus.com>
744 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
746 * src/modest-mail-operation.c:
747 * src/modest-ui-actions.c: Check for already existing folder before
748 querying the server, show error message from camel if the request
749 still fails. This fixes projects.maemo.org bug NB#58701.
751 2007-07-12 Murray Cumming <murrayc@murrayc.com>
753 * src/modest-tny-account-store.h:
754 * src/modest-tny-account-store.c:
755 Added modest_tny_account_store_forget_password_in_memory(),
756 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
757 when creating a new account, so that new passwords will be used, instead of
758 us thinking that it's a second request as a result of a failed password again.
760 2007-07-12 Murray Cumming <murrayc@murrayc.com>
762 * src/dbus_api/modest-dbus-callbacks.c:
763 (on_idle_open_message): If the message is in drafts then open it
764 in an edit window instead of a view window. This fixes
765 projects.maemo.org bug NB#63005.
767 2007-07-12 Murray Cumming <murrayc@murrayc.com>
769 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
770 Avoided a harmless g_warning().
772 2007-07-12 Murray Cumming <murrayc@murrayc.com>
774 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
775 Pass the modest account name, not the TnyAccount display name to
776 modest_msg_view_window_new() so that the reply feature works,
777 fixing projects.maemo.org bug NB#62892.
779 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
780 (modest_msg_view_window_new_with_header_model):
781 * src/maemo/modest-msg-view-window.c:
782 (modest_msg_view_window_new_with_header_model),
783 (modest_msg_view_window_new):
784 * src/modest-ui-actions.c: (reply_forward):
785 * src/widgets/modest-msg-view-window.h:
786 * src/widgets/modest-window.c: (modest_window_set_active_account):
787 Rename an account parameter to modest_account_name to make this clearer.
789 2007-07-11 Murray Cumming <murrayc@murrayc.com>
791 * src/modest-ui-actions.h:
792 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
793 modest_do_message_delete().
794 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
795 Call modest_do_message_delete(), hoping that this would cause messages
796 to be really deleted from search instead of just marked with strike through.
797 Does not seem to help.
799 2007-07-11 Armin Burgmeier <armin@openismus.com>
801 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
802 priv->reselect to FALSE prior to calling
803 modest_folder_view_select_first_inbox_or_local() to prevent endless
804 recursion and thus a crash on startup.
806 2007-07-11 Armin Burgmeier <armin@openismus.com>
808 * src/maemo/modest-account-settings-dialog.h: Include
809 <gtk/gtknotebook.h> to fix the build (at least for me).
811 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
812 Use "New FolderN" as default suggested name if "New folder" already
813 exists, with N being the first free number, though never exceed "New
814 folder99" in which case we just fall back to "New Folder" even though
815 it already exists. This fixes projects.maemo.org bug NB#58663.
817 2007-07-11 Murray Cumming <murrayc@murrayc.com>
819 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
820 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
821 projects.maemo.org bug NB#62778.
823 2007-07-11 Murray Cumming <murrayc@murrayc.com>
825 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
826 Ignore the wrong (for now) secure-smtp setting in the presets -
827 just default to requiring secure authentication for SMTP, because
830 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
832 * src/widgets/modest-folder-view.c: (filter_row)
833 Do not show drafts folder (see UI specs)
835 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
837 * src/modest-ui-actions.c:
838 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
839 place and also not necessary.
841 * src/widgets/modest-folder-view.c: (filter_row)
842 Guess folder type and hide Sent & Outbox if necessary.
843 Fixed project.maemo.org NB#57328
845 2007-07-11 Murray Cumming <murrayc@murrayc.com>
847 * src/modest-ui-actions.h:
848 * src/modest-ui-actions.c:
849 (modest_ui_actions_on_delete_message):
850 Move some code into a new
851 modest_ui_actions_refresh_message_window_after_delete()
852 function so we can use it from elsewhere.
854 * src/dbus_api/modest-dbus-callbacks.c:
855 (on_idle_delete_message), (on_delete_message): Used an idle
856 handler, as we do for the other D-Bus method handlers.
857 Call modest_ui_actions_refresh_message_window_after_delete()
858 if the deleted message was open in a window. This fixed
859 projects.maemo.org bug NB#62862.
861 2007-07-11 Murray Cumming <murrayc@murrayc.com>
863 * src/modest-main.c: (main): Only show the UI at the start if
864 the showui command line option was given. For instance,
865 run-standalone src/modest showui
866 Otherwise, we wait for the top_application D-Bus method to
867 be sent by hildon-desktop when the application is selected
869 This allows us to run without a UI when osso-global-search
870 uses our D-Bus methods.
872 2007-07-11 Murray Cumming <murrayc@murrayc.com>
874 * src/dbus_api/modest-dbus-api.h: Added a define for a
875 top-application D-Bus method.
876 * src/dbus_api/modest-dbus-callbacks.c:
877 (on_top_application),
878 (modest_dbus_req_handler): Handle the top-application D-Bus
879 method, which might be an undocumented D-Bus signal sent by
880 hildon-desktop when it starts the application from the menu.
881 But I am not sure and I need to test it on the device, because
882 my scratchbox does not have the application in the menu now.
883 This method shows the main window, so that it can be invisible
884 when started, for instance, just for email searching from
887 * src/maemo/modest-main-window.c: (restore_settings),
888 (modest_main_window_new): Do not show the window immediately
889 upon creation. We show it later.
890 * src/modest-widget-memory.c: (save_settings_paned):
891 Try (unsuccessfully) to avoid saving the paned position when
892 it is not even visible.
893 (restore_settings_paned): Do not allow a silly paned position.
894 This seems necessary when not showing the window at first.
896 * tests/dbus_api/Makefile.am:
897 * tests/dbus_api/test_top_application.c: (main): Test for the
900 2007-07-10 Murray Cumming <murrayc@murrayc.com>
902 * src/modest-ui-dimming-rules.c:
903 (modest_ui_dimming_rules_on_new_msg),
904 (modest_ui_dimming_rules_on_reply_msg),
905 (modest_ui_dimming_rules_on_delete_msg),
906 (modest_ui_dimming_rules_on_details),
907 (modest_ui_dimming_rules_on_view_window_move_to),
908 (modest_ui_dimming_rules_on_view_previous),
909 (modest_ui_dimming_rules_on_view_next),
910 (_invalid_folder_for_purge): Added checks before
911 casting the window. This looks like an actual
912 logic error in _invalid_folder_for_purge(), because it
913 tries to use a ModestMainWindow as a message window.
915 2007-07-10 Murray Cumming <murrayc@murrayc.com>
917 * src/maemo/modest-account-settings-dialog.c:
918 (show_error): Use the same implementation as in
919 modest-easysetup-wizard.c:
920 (on_entry_invalid_character): The logical ID contains a %s.
921 Guessed what it should be.
922 (on_entry_max), (check_data), (on_response): Adapt to
923 changed show_error().
924 (create_page_account_details): Really call
925 modest_validating_entry_set_func() on the correct widgets.
926 * src/maemo/easysetup/modest-easysetup-wizard.c:
927 (on_entry_invalid_character): Fix the logical ID here too.
928 (create_page_account_details),
929 (create_page_user_details):
931 modest_validating_entry_set_func() on the correct widgets.
933 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
934 Do not try to use the account if it is NULL.
936 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
938 * src/modest-ui-actions.c: (create_move_to_dialog),
939 (modest_ui_actions_on_main_window_move_to),
940 (modest_ui_actions_on_msg_view_window_move_to):
941 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
942 (filter_row), (modest_folder_view_show_non_move_folders):
943 * src/widgets/modest-folder-view.h:
945 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
946 the Sent folder yet as it does not report the correct folder type.
948 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
950 * src/maemo/modest-msg-edit-window.c: (init_window):
953 2007-07-10 Murray Cumming <murrayc@murrayc.com>
955 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
956 Take a parent widget instead of a parent window, and
957 implement this with hildon_banner_show_information() instead.
958 Non-Maemo builds can just ifdef that there.
959 This fixed projects.maemo.org bug NB#62766.
961 (on_entry_invalid_character): Use show_error() again instead
962 of using hildon directly, and use the _CS() macro to use the correct
964 (create_account), (check_for_supported_auth_methods), (on_entry_max):
965 Pass a widget instead od a window to show_error().
967 2007-07-10 Murray Cumming <murrayc@murrayc.com>
969 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
970 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
971 This allows us to show the server name in the error message, fixing
972 projects.maemo.org bug NB#62904.
973 Also, use the appropriate logical ID message for the account protocol.
975 2007-07-10 Murray Cumming <murrayc@murrayc.com>
977 * src/modest-tny-account-store.c: (on_idle_wrong_password):
978 A compilation fix, though the build wasn't broken for me.
980 2007-07-09 Murray Cumming <murrayc@murrayc.com>
982 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
983 Do not try to unref a NULL folder store, to avoid a runtime warning.
984 This seems to happen sometimes when changing accounts settings.
986 2007-07-09 Murray Cumming <murrayc@murrayc.com>
988 * src/modest-tny-account-store.c:
989 (modest_tny_account_store_instance_init),
990 (modest_tny_account_store_finalize),
991 (on_account_settings_hide), (on_idle_wrong_password):
992 Use a GHashTable to ensure that we only show one account settings
993 dialog per modest account. This avoids us having a dialog open for
994 both the store and transport accounts, or due to repeated get_password()
995 calls that shouldn't happen anyway.
997 2007-07-09 Murray Cumming <murrayc@murrayc.com>
999 * src/maemo/modest-maemo-utils.c: (on_hide),
1000 (modest_maemo_show_dialog_and_forget): Handle the response, because
1001 the window is not even hidden by default.
1003 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1004 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1005 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1006 which seems to prevent some modality problems.
1008 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1009 Ignore user cancellation errors.
1011 * src/modest-account-mgr-helpers.h:
1012 * src/modest-account-mgr-helpers.c:
1013 Added modest_server_account_get_password() and
1014 modest_server_account_get_has_password() to avoid direct use of
1017 * src/maemo/modest-account-settings-dialog.h:
1018 * src/maemo/modest-account-settings-dialog.c:
1019 (modest_account_settings_dialog_init): Store the notebook so we can
1021 Added modest_account_settings_dialog_switch_to_user_info().
1023 * src/modest-tny-account-store.c:
1024 (get_password): When the password in the account settings is wrong (we think),
1025 show the relevant page of the account settings dialog, in the mainloop.
1026 However, we currently get many of these at once because cancel does not
1028 (forget_password): Do not forget the password
1029 from the account settings, because this causes side-effects when
1030 tinymail seems to call it at strange time, maybe because of how we
1031 are cancelling get_password().
1032 (modest_tny_account_store_alert): Ignore user cancellations.
1034 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1036 * src/maemo/modest-maemo-utils.h:
1037 * src/maemo/modest-maemo-utils.c:
1038 Added modest_maemo_show_information_note_and_forget() for use instead of
1039 gtk_dialog_run() when the response is not needed, to avoid an extra
1040 mainloop which could cause a hang.
1042 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1043 Use the logical IDs for the error message, though they are not
1044 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1045 because gtk_dialog_run() caused a hang here (the window did not close).
1046 This fixes projects.maemo.org bug NB#62646.
1048 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1050 * src/modest-account-mgr-helpers.h:
1051 * src/modest-account-mgr-helpers.c:
1052 Added modest_account_mgr_get_store_protocol().
1054 * src/maemo/modest-account-view-window.c:
1055 (on_delete_button_clicked): Show different warning text depending on
1056 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1057 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1060 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1062 * src/maemo/modest-msg-edit-window.c:
1063 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1064 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1066 2007-07-07 Armin Burgmeier <armin@openismus.com>
1068 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1069 ckdg_ib_maximum_characters_reached from correct package.
1071 * src/modest-ui-actions.c: Show an error message when a folder could
1072 not be created. Tinymail does not give us specific error codes about
1073 what has gone wrong, so we assume that a folder with that name
1074 already exists, though there might be other reasons.
1076 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1078 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1079 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1080 give a more exact error message that can be partly translated.
1082 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1084 * src/maemo/modest-address-book.c:
1085 (select_email_addrs_for_contact): Specify a default window size for the
1086 select-email-address dialog, so that it is probably big enough for the
1087 title. This should fix projects.maemo.org bug NB#62277.
1089 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1091 * src/maemo/easysetup/modest-easysetup-wizard.c:
1092 (create_page_complete_easysetup): Use
1093 gtk_widget_set_size() request to ensure that the text wraps
1096 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1098 * src/maemo/easysetup/modest-easysetup-wizard.c:
1099 (on_entry_invalid_character), (create_page_account_details),
1100 (create_page_user_details):
1101 Use new API of ModestValidatingEntry. But for some reason the banner is
1102 not shown. I will have to investigate that further.
1104 * src/widgets/modest-validating-entry.c: (on_insert_text),
1105 (modest_validating_entry_set_func):
1106 * src/widgets/modest-validating-entry.h:
1107 Added a new callback function to be able to react to prevented
1108 characters whitespaces to e.g show a banner.
1110 2007-07-05 Armin Burgmeier <armin@openismus.com>
1112 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1113 notification of HildonNumberEditor instead of remembering the port
1114 number. Thanks to Johannes for pointing this out.
1116 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1118 * src/maemo/easysetup/modest-easysetup-wizard.c:
1119 Check if there are any user changes before showing a confirmation
1120 dialog (projects.maemo.org NB#60946)
1122 2007-07-05 Armin Burgmeier <armin@openismus.com>
1124 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1125 number at the beginning of the dialog and set the modified flag at the
1126 end if the port number has changed. This is necessary because
1127 HildonNumberEditor does not support notification when the value has
1130 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1132 * src/modest-ui-actions.c:
1133 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1134 a connection before asking anything else. Correct the check for the destination
1135 folder so that it succeeds when online.
1136 This fixed projects.maemo.org bug NB#61645.
1138 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1140 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1141 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1142 to fix projects.maemo.org bug NB#62439.
1144 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1146 * src/modest-tny-account.c: (on_connection_status_changed):
1147 Really do not use tny_device_force_offline() here. See the previous comment.
1149 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1151 * src/modest-tny-account.c: (on_connection_status_changed):
1152 Do not use tny_device_force_offline() when tinymail says that something
1153 went wrong with the connection. It seems to report this unnecessarily.
1155 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1157 * src/maemo/modest-connection-specific-smtp-window.c:
1158 (modest_connection_specific_smtp_window_init):
1159 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1160 does not seem to have any effect in osso 1.1 (though it works in
1161 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1163 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1165 * src/maemo/modest-connection-specific-smtp-window.c:
1166 Fix UI specification problems with projects.meamo.org NB#60479
1168 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1170 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1171 clue when this has failed, because the error dialog is not always shown
1172 (at least in earlier version).
1174 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1175 GError message, because the generic error dialog is not helpful.
1177 'This message is not currently available (can't let a new connection go online)'
1178 when trying to open an IMAP message.
1180 (_modest_ui_actions_open): Offer a connection when some messages would
1181 have to be downloaded and we are offline.
1183 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1185 * src/widgets/modest-folder-view.c:
1186 Don't check for MERGE type anymore as we use the correct type
1188 NOTE: For the last two changes you need to update your tinymail copy
1189 because of API changes!
1191 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1193 * src/modest-tny-local-folders-account.c:
1194 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1195 (see projects.maemo.org NB#61580)
1197 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1199 * src/modest-tny-account.c: (on_connection_status_changed):
1200 Commented out the call to modest_platform_connect_and_wait() because this
1201 seems to always hang, and I would like to know if this is the only thing
1202 that causes a hang when showing the connection dialog.
1203 It is not very useful anyway.
1205 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1207 * src/maemo/modest-msg-view-window.c:
1208 (modest_msg_view_window_select_next_message):
1210 * src/modest-platform.h:
1211 * src/maemo/modest-platform.c:
1212 Added modest_platform_connect_and_wait(), which calls
1213 tny_maemo_conic_device_connect() always in the main thread, by calling it
1214 in an idle handler and waiting for the idle handler to run. It should be
1215 in the main thread because it uses GTK+ UI code. It just returns TRUE
1216 if the device is already online.
1218 There is some nasty code to ensure that subsequent calls to
1219 modest_platform_connect_and_wait() just wait for the first one to finish,
1220 by checking repeatedly in another idle handler. This is necessary,
1221 because other threads (or even the main thread, via another idle handler)
1222 can call modest_platform_connect_and_wait() while
1223 modest_platform_connect_and_wait() is running.
1225 (modest_platform_connect_and_wait_if_network_account),
1226 (modest_platform_connect_and_wait_if_network_folderstore):
1227 Convenience functions that calls modest_platform_connect_and_wait() if
1228 the account or folder might want network access.
1230 * src/modest-mail-operation.c:
1231 (modest_mail_operation_update_account):
1232 * src/modest-ui-actions.c: (download_uncached_messages),
1233 (modest_ui_actions_on_rename_folder), (delete_folder),
1234 (modest_ui_actions_on_main_window_move_to),
1235 (modest_ui_actions_on_msg_view_window_move_to):
1236 * src/widgets/modest-folder-view.c:
1237 (drag_and_drop_from_folder_view):
1238 Offer a connection if we are offline.
1240 * src/modest-tny-account.c: (on_connection_status_changed):
1241 Document this as only handling errors during network operations in progress,
1242 and replace the idle code with a simple call to
1243 modest_platform_connect_and_wait(), which does this instead.
1245 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1247 * src/modest-tny-account.c:
1248 (modest_tny_account_get_special_folder): (util_on_idle),
1249 Handle the GError so we can see when tny_folder_store_get_folders()
1250 fails, as it currently does while something else is connecting.
1252 Added util_run_in_main_thread_and_wait()
1253 which uses an idlen handler and mainloop to ensure that the function
1254 is called in the main thread.
1255 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1256 to make sure that we call attempt the connection in the mainloop only,
1257 which might solve some hangs.
1259 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1261 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1262 be found by their display name. This is never useful.
1263 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1264 by its ID, instead of trying to use its ID as its display name.
1266 * src/modest-tny-account-store.h:
1267 * src/modest-tny-account.c:
1268 (modest_tny_account_get_special_folder): Add a g_warning() when
1269 tny_folder_store_get_folders() returns an empty list for the maildir.
1271 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1272 Add a g_warning() when this returns NULL, because that it not allowed
1275 2007-07-02 Armin Burgmeier <armin@openismus.com>
1277 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1278 note when trying to cancel the wizard. This fixes projects.maemo.org
1281 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1283 * src/modest-tny-account.h:
1284 * src/modest-tny-account.c:
1285 (modest_tny_account_new_from_server_account),
1286 (modest_tny_account_new_from_server_account_name),
1287 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1288 because this must now be set before setting the proto. This is usd in
1289 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1290 warning in camel_session_get_service() caused by
1291 tny_camel_transport_account_prepare().
1293 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1296 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1298 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1300 (modest_connection_specific_smtp_edit_window_init):
1302 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1303 of "changed" for now
1305 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1307 * src/modest-tny-account.c:
1308 (modest_tny_account_new_from_server_account):
1309 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1310 now uses to request a connection when it needs one, and which it uses
1311 to tell us that something is wrong with the connection, so we can force
1312 the accounts offline to prevent further problems.
1314 * src/modest-defs.h:
1315 * src/modest-init.c: (init_default_settings):
1316 * src/modest-mail-operation.c:
1317 (modest_mail_operation_update_account):
1318 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1319 This should not be necessary anymore. Do not set the conf key that
1320 determined this (it was always TRUE and not set anywhere else).
1322 * src/modest-ui-actions.h: Remove unused and unimplemented
1323 modest_ui_actions_on_online_toggle_toggled().
1325 2007-06-29 Murray Cumming <murrayc@murrayc.com
1327 * src/maemo/modest-main-window.c: (connect_signals):
1328 Don't connect to delete_event twice. Maybe this was harmless.
1330 2007-06-29 Murray Cumming <murrayc@murrayc.com
1332 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1333 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1334 Debug output to give some more clue when a folder move is not allowed.
1336 2007-06-28 Murray Cumming <murrayc@murrayc.com
1338 * src/modest-tny-account.c: (on_modest_file_system_info),
1339 (modest_tny_account_get_mmc_account_name):
1340 Always call the callback, without checking whether the name has changed.
1341 * src/widgets/modest-folder-view.c: (strings_are_equal),
1342 (on_model_foreach_set_name), (on_get_mmc_account_name),
1343 (text_cell_data): Compare the name here, and use the name from
1344 the account rather than from the
1345 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1346 if the name was changed after the account was added to the model.
1347 That's a tinymail bug but not one that I want to fix now.
1349 This finally fixes projects.maemo.org bug NB#59301.
1351 2007-06-27 Armin Burgmeier <armin@openismus.com>
1353 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1356 2007-06-27 Murray Cumming <murrayc@murrayc.com
1358 * src/modest-tny-account.h:
1359 * src/modest-tny-account.c:
1360 Added modest_tny_account_get_mmc_account_name(), to set the memory
1361 card name asynchronously for the given account and then notify.
1362 (modest_tny_account_new_for_local_folders): Use this new function instead
1363 of using hildon_file_system_info_async_new() directly.
1365 * src/widgets/modest-folder-view.c: (text_cell_data):
1366 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1367 gtk_tree_model_row_changed() when it is available.
1369 This should fix projects.maemo.org bug NB#59301.
1371 2007-06-27 Murray Cumming <murrayc@murrayc.com
1373 * src/modest-mail-operation.c: (update_account_thread),
1374 (get_msgs_full_thread): Fix typo failures in the revert
1377 2007-06-27 Murray Cumming <murrayc@murrayc.com
1379 * src/maemo/modest-maemo-global-settings-dialog.c:
1380 (idle_select_default_focus):
1381 * src/modest-mail-operation.c: (idle_notify_progress),
1382 (idle_notify_progress_once), (set_last_updated_idle),
1383 (update_account_thread), (get_msgs_full_thread):
1384 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1385 * src/widgets/modest-header-view.c:
1386 (idle_notify_headers_count_changed_destroy),
1387 (idle_notify_headers_count_changed):
1388 Reverted the additions of gdk_threads_enter/leave(), in case this
1389 helps with a startup hang on the device.
1391 2007-06-26 Armin Burgmeier <armin@openismus.com>
1393 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1394 for supported secure authentication methods from server by
1395 gtk_dialog_run(), saving CPU time and a potential race condition.
1397 2007-06-26 Armin Burgmeier <armin@openismus.com>
1399 * src/maemo/modest-maemo-utils.h:
1400 * src/maemo/modest-maemo-utils.c: Added a
1401 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1402 only error code to tell the calling code when the user canceled the
1405 * src/maemo/modest-account-settings-dialog.h:
1406 * src/maemo/modest-account-settings-dialog.c:
1407 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1408 message if the retrieval of secure authentication methods was canceled
1409 by the user. Perform the check before saving anything to configuration
1410 to not end up with half-committed configuration changes, do not show
1411 a "Saving to configuration failed" note when authentication methods
1412 could not be retrieved.
1414 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1417 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1419 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1420 Only return the first level of folders under accounts, because the
1421 osso-global-search UI spec doesn't want the rest.
1422 This fixed projects.maemo.org bug NB#61811.
1424 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1426 * src/modest-tny-account-store.c:
1427 * src/modest-tny-account-store.h:
1428 Added modest_tny_account_is_memory_card_account().
1429 * src/maemo/modest-main-window.c: (create_details_widget):
1430 Show the same information items for the memory card as we show for the
1431 local-folders, to fix projects.maemo.org bug NB#59307.
1433 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1435 * src/modest-tny-account-store.c: (get_password):
1436 Added some checks for NULL to maybe prevent crashes, though I think
1437 it was Philip's last commit that actually prevented the crash here
1438 when creating a first new account.
1439 But the new account is still not usable (no messages are shown)
1440 until a restart of the application.
1442 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1444 * src/maemo/modest-maemo-global-settings-dialog.c:
1445 (idle_select_default_focus):
1446 * src/modest-mail-operation.c: (idle_notify_progress),
1447 (idle_notify_progress_once), (idle_notify_update_account_queue),
1448 (set_last_updated_idle), (update_account_thread),
1449 (notify_get_msgs_full), (get_msgs_full_destroyer),
1450 (get_msgs_full_thread):
1451 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1452 * src/widgets/modest-header-view.c:
1453 (idle_notify_headers_count_changed_destroy),
1454 (idle_notify_headers_count_changed):
1455 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1456 all idle handlers, because some other thread could be blocking
1457 the GDK lock, so that it can do GUI stuff.
1459 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1461 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1462 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1463 (on_idle_send_receive), (on_idle_open_default_inbox):
1464 * src/maemo/modest-msg-edit-window.c:
1465 (modest_msg_edit_window_attach_file_noninteractive):
1466 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1467 to prevent a hang. I don't quite understand why these are necessary,
1468 beause we should already be in the main loop. I guess something outside
1469 of the main loop is taking the lock.
1471 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1472 we are really using URIs, and use files that are more likely to exist.
1474 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1476 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1477 necessary because configure.ac now defines different variables.
1479 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1481 * libmodest-dbus-client/libmodest-dbus-client.c:
1482 * libmodest-dbus-client/libmodest-dbus-client.h:
1483 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1484 libmodest_dbus_client_compose_mail() is what things actually use.
1486 * src/dbus_api/modest-dbus-api.h:
1487 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1488 * tests/dbus_api/Makefile.am:
1489 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1492 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1494 * src/modest-init.c: (modest_init_local_folders):
1495 For memory-card (or other non local-folders) maildir accounts,
1496 always create an Archive folder, so that there is somewhere to put
1497 messages. This should be less confusing, because the user does not need
1498 to guess that the need to create a folder.
1500 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1502 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1503 Fixed icon size by using (50, 50) which is the same as defined by
1506 2007-06-25 Armin Burgmeier <armin@openismus.com>
1508 * src/widgets/modest-window-mgr.c:
1509 * src/modest-init.c:
1510 * configure.ac: Correctly recognize hildon-notify presence and fixed
1511 the build without it being installed.
1513 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1515 * libmodest-dbus-client/libmodest-dbus-client.c:
1516 (libmodest_dbus_client_search): Fix the build. Sorry.
1517 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1518 (reply_forward_cb): Initialize variables to fix the build.
1520 * src/modest-tny-account-store.c:
1521 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1522 comparison (a silly typo) so that email search results can be opened
1523 when there are more than one account.
1525 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1527 * libmodest-dbus-client/libmodest-dbus-client.c:
1528 (libmodest_dbus_client_search),
1529 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1530 instead of 1 second, because the search gets folders and messages from
1531 the server, which can take a long time. When it times out,
1532 osso-global-search will report no results.
1534 We need to specify whether we should search only cached information
1535 (maybe with a user preference), and the osso-email-search-plugin
1536 API should really be improved to allow that option, and to allow results
1537 to be delivered asynchronously in batches.
1539 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1541 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1542 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1543 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1545 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1547 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1548 that is an empty string. D-Bus seems to give us these instead of NULL.
1550 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1552 * src/dbus_api/modest-dbus-callbacks.c:
1553 * src/maemo/easysetup/modest-easysetup-wizard.h:
1554 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1555 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1556 (modest_connection_specific_smtp_edit_window_init):
1557 * src/maemo/modest-maemo-global-settings-dialog.c:
1559 * src/maemo/modest-maemo-utils.c:
1560 (modest_maemo_utils_setup_images_filechooser):
1561 * src/maemo/modest-main-window.c: (create_details_widget):
1562 * src/maemo/modest-msg-edit-window.c:
1563 (modest_msg_edit_window_attach_file_noninteractive),
1564 (modest_msg_edit_window_color_button_change),
1565 (modest_msg_edit_window_set_zoom):
1566 * src/modest-mail-operation.c: (update_account_thread):
1567 * src/modest-tny-account-store.c:
1568 * src/modest-tny-account.c:
1569 * src/widgets/modest-global-settings-dialog.c:
1570 * src/widgets/modest-window.h:
1572 Fixed build on bora!
1574 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1576 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1577 * src/modest-search.c: (modest_search_folder),
1578 (modest_search_all_accounts): Actually search only in the specified folder,
1579 doing a simple match on the folder ID.
1580 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1581 and added some documentation.
1583 2007-06-22 Armin Burgmeier <armin@openismus.com>
1585 * src/maemo/modest-maemo-utils.h:
1586 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1587 modest_maemo_utils_get_supported_secure_authentication_methods.
1589 * src/maemo/easysetup/modest-easysetup-wizard.c:
1590 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1591 one occured, not just "Server does not support secure authentication".
1593 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1595 * src/modest-tny-account-store.c: (get_password):
1596 Restored the call to tny_account_set_user() because Philip seems to have
1597 stopped this from crashing (by not using the freed string). It still does
1598 not work, but now we can test it.
1600 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1602 * src/maemo/modest-msg-edit-window.c: (init_window):
1603 Comment out use of an uninitialzed GtkScrolledWindow variable,
1604 to fix the build and stop a crash. Yet again.
1606 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1608 * src/modest-tny-account-store.c: (get_password):
1609 Remove the call to tny_account_set_user() because this actually crashes.
1610 As mentioned in the last commit, it is known to not work anyway.
1612 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1614 * src/modest-tny-account-store.c: (get_password):
1615 Use tny_account_set_username() to tell tinymail that the username might
1616 have changed too. But tinymail ignores this: see projects.maemo.org
1618 * src/modest-ui-actions.c:
1619 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1620 reset the connection when changing the username, and improve the comments.
1621 Save the changed username to gconf at least, so it is used when Modest is
1624 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1626 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1627 Do not use a query, so that we get all folders, including for POP and
1628 local-folders. They work as search criteria too.
1629 This fixes projects.maemo.org bug NB#57740.
1631 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1633 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1634 Comment out the use of hildon_notification_set_sound() because it is
1635 not declared, to fix the build. Warnings are serious, people.
1637 2007-06-21 Armin Burgmeier <armin@openismus.com>
1639 * src/maemo/modest-maemo-utils.h:
1640 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1641 modest_maemo_utils_get_supported_secure_authentication_methods()
1642 to query authentication methods for a specific user. This should fix
1643 projects.maemo.org bug NB#61369.
1645 * src/maemo/easysetup/modest-easysetup-wizard.c:
1646 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1649 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1651 * libmodest-dbus-client/libmodest-dbus-client.h:
1652 * libmodest-dbus-client/libmodest-dbus-client.c:
1653 (modest_dbus_message_iter_get_search_hit),
1654 (libmodest_dbus_client_search):
1655 Reorganised and commented this.
1656 Removed modest_search_hit_free() from the public API because it
1659 Added libmodest_dbus_client_get_folders() and
1660 modest_folder_result_list_free().
1662 * src/dbus_api/modest-dbus-api.h:
1663 * src/dbus_api/modest-dbus-callbacks.c:
1664 (modest_dbus_req_filter): Commented. Moved most code to
1665 on_dbus_method_search() and added on_dbus_method_get_folders().
1667 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1668 of the extra D-Bus handler.
1670 * tests/dbus_api/Makefile.am:
1671 * tests/dbus_api/test_get_folders.c: New test for
1672 libmodest_dbus_client_get_folders(). This seems to return an empty list
1673 at the moment. That could be the same error that causes the message list
1674 to be empty sometimes.
1675 This should help with projects.maemo.org bug NB#57740.
1677 2007-06-21 Armin Burgmeier <armin@openismus.com>
1679 * src/modest-mail-operation.c: Do not call
1680 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1681 notify the operation's end after having set the status to CANCELED for
1682 the operation queue to listen on. This fixes a deadlock when there
1683 were mail operations in the queue during its finalization.
1685 * src/modest-singletons.c: Reordered uninitialization of the account
1686 manager to happen after the mail operation queue was uninitialized
1687 because the mail operation's in the queue might still try to access
1688 the account manager (see modest_mail_operation_notify_end()). This
1689 fixes a potential crash when terminating the application.
1691 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1693 * src/modest-search.c:
1694 (search_mime_part_and_child_parts): Moved some code here so we
1695 can search recursively in child folders.
1696 (modest_search_folder): Search in the message as a mime part, instead
1697 of just its child mime parts.
1698 (read_chunk), (search_mime_part_ogs):
1699 Check how many bytes were read, to prevent an endless loop.
1700 Searching in message bodies now works. This finishes the fix for
1701 projects.maemo.org bug NB#61007.
1703 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1705 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1706 Add a g_warning when the item is not a folder.
1708 * src/modest-ui-dimming-rules.c:
1709 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1710 when selected item is not a folder (for instance, an account), because
1711 the UI spec only talks about folders.
1712 I am not sure what the UI spec wants, so this might not totally fix
1713 projects.maemo.org bug NB#60794.
1715 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1717 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1718 (load_from_file): Sort the list. The unsorted list would be more noticeable
1719 in non-English locales.
1721 * src/maemo/modest-msg-edit-window.c:
1722 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1723 warning and fix the build.
1725 * src/maemo/modest-progress-bar-widget.c:
1726 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1727 avoid a g_warning, and probably to avoid a crash.
1729 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1731 * src/modest-search.c: (modest_search_folder): Check for a GError
1732 when calling tny_folder_get_headers(), to show that this is not the cause
1735 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1737 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1738 Actually set the body query instead of the subject query.
1740 * src/modest-search.c: (search_mime_part_ogs),
1741 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1742 which would probably cause it to fail if we got this far.
1744 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1745 to simplify the code.
1746 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1747 be causing search-in-body to fail.
1749 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1751 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1753 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1754 Better debug message when the folder cannot be found.
1755 This should help with fixing projects.maemo.org bug #61287.
1756 * src/modest-search.c: (add_hit): Do not leak the furl string.
1758 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1760 * src/modest-ui-actions.c:
1761 (modest_ui_actions_on_folder_selection_changed):
1762 Do not special-case TNY_MERGE_FOLDER here, because
1763 modest_tny_folder_get_account() already does that. This fixes
1764 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1765 shown when the Outbox was selected).
1767 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1769 * libmodest-dbus-client/libmodest-dbus-client.c:
1770 (_dbus_iter_get_string_or_null): Initialize the string variable in
1771 case this helps with Dirk's crash.
1773 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1775 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1776 though it is not implemented yet (this function is maybe not even used),
1777 to avoid breaking ABI in future.
1778 * libmodest-dbus-client/libmodest-dbus-client.c:
1779 (get_attachments_string): Moved some code into this generic function.
1780 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1781 sends email. It is maybe not used.
1782 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1783 (on_send_mail): Use attachments.
1785 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1786 * src/maemo/modest-msg-edit-window.c:
1787 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1788 a filename before using it, to fix projects.maemo.org bug NB#58233.
1790 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1792 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1793 Initialize the continue_download variable to fix the build, and probably
1794 to fix randome behaviour.
1796 2007-06-18 Armin Burgmeier <armin@openismus.com>
1798 * src/modest-tny-send-queue.h:
1799 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1800 the queue so we can later show it in the UI. Replaced
1801 modest_tny_send_queue_msg_is_being_sent() by
1802 modest_tny_send_queue_get_msg_status().
1804 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1806 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1807 gpointer. This probably was not harmful, but just to be sure.
1809 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1811 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1812 Fix the build, but leave the function broken on Bora, because
1813 hildon_uri_action_get_service() does not exist.
1814 osso_uri_action_get_service() does not exist either, it seems.
1816 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1818 * src/modest-tny-account.c:
1819 (modest_tny_account_new_from_server_account):
1820 Uncommented the url debug output again, because it is useful for
1821 debugging, as I said in the comment.
1823 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1825 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1827 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1828 for Mameo Bora, to fix the build.
1830 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1833 Fixed build with hildon < 0.99
1835 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1836 Check if the selected account is busy instead of checking all accounts
1838 * src/modest-account-mgr-priv.h:
1839 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1840 (modest_account_mgr_init), (compare_account_name),
1841 (modest_account_mgr_set_account_busy),
1842 (modest_account_mgr_account_is_busy):
1843 * src/modest-account-mgr.h:
1844 Added busy information to the account manager. It possible to
1845 set an account to busy or not busy now.
1847 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1848 (modest_mail_operation_update_account),
1849 (modest_mail_operation_notify_end):
1850 Set the account to busy/not busy depending on the operation state.
1852 * src/widgets/modest-account-view.c:
1853 (modest_account_view_finalize), (get_last_updated_string),
1854 (update_account_view), (on_account_busy_changed), (init_view):
1855 Show string "Refreshing..." if the account is currently busy.
1857 All this fixes projects.maemo.org bug NB#59711
1859 2007-06-14 Armin Burgmeier <armin@openismus.com>
1861 * src/widgets/modest-attachments-view.h:
1862 * src/widgets/modest-attachments-view.c: Added
1863 modest_attachments_view_has_attachments() and fixed coordinate
1864 transformation in get_att_view_at_coords(). This fixes attachment
1867 * src/widgets/modest-msg-view.c: Make use of
1868 modest_attachments_view_has_attachments() to decide whether to show
1869 attachments in the header.
1871 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1873 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1874 (on_change), (on_combo_security_changed),
1875 (modest_connection_specific_smtp_edit_window_init),
1876 (modest_connection_specific_smtp_edit_window_set_connection),
1877 (modest_connection_specific_smtp_edit_window_is_dirty):
1878 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1879 * src/maemo/modest-connection-specific-smtp-window.c:
1882 Show an comfirmation dialog for the smpt-edit-window if there are
1883 unsaved changes and the user hits cancel.
1884 (projects.maemo.org bug NB#60479)
1886 2007-06-14 Armin Burgmeier <armin@openismus.com>
1888 * src/maemo/easysetup/modest-easysetup-wizard.c:
1889 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1890 address" info in banner instead of node, and select all the text as
1891 per UI spec. This fixes projects.maemo.org bug NB#60550.
1893 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1895 reviewed by: <delete if not using a buddy>
1897 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1898 * src/modest-ui-actions.c: (folder_refreshed_cb):
1900 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1902 * src/widgets/modest-folder-view.c: (filter_row):
1903 Explictly filter out the per-account outbox accounts. I don't know why
1904 these only sometimes show up, but now they should never show up in the UI.
1905 This should fix projects.maemo.org bug NB#60160.
1907 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1909 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1910 when the toolbar does not exist yet.
1911 * src/modest-widget-memory.c: (save_settings_header_view):
1912 Added g_warnings() to help us to discover when we are trying to set
1913 an empty columns list in gconf.
1915 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1917 * src/modest-init.h:
1918 * src/modest-init.c:
1919 Added modest_init_get_default_header_view_column_ids().
1921 * src/modest-widget-memory.c: (restore_settings_header_view):
1922 Use the new function to get defaults, if the gconf key is empty,
1923 instead of not creating any columns. This seems to fix the
1924 empty right-hand pane problems.
1926 * src/widgets/modest-header-view.h: Improved documentation.
1928 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1930 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1931 Revert the use of the display name as the account name, because this
1932 is generally wrong and would break the code that follows.
1934 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1936 * src/maemo/easysetup/modest-easysetup-wizard.c:
1937 (check_for_supported_auth_methods), (on_before_next),
1940 More correct fix for projects.maemo.org bug NB# 58991
1941 Do not longer accept AUTH_PASSWORD as secure method and choose
1942 correct method when creating the account.
1944 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1946 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1947 Fixed projects.maemo.org bug NB# 58991
1949 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1951 * src/modest-init.c: (modest_init_init_core),
1952 (modest_init_local_folders): Fixed compilation errors.
1954 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1956 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1957 Remove unnecessary lib/include, though it is good in principle when needed.
1959 * src/modest-init.c: (modest_init_one_local_folder),
1960 (modest_init_local_folders):
1961 * src/modest-init.h: Initialize the .modest library for memory cards,
1962 instead of just doing nothing for them. This should allow us to create
1963 folders there, fixing projects.maemo.org bug NB#59297.
1965 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1967 * libmodest-dbus-client/libmodest-dbus-client.c:
1968 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1969 (libmodest_dbus_client_compose_mail),
1970 (libmodest_dbus_client_open_message),
1971 (libmodest_dbus_client_send_and_receive),
1972 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1974 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1975 (on_idle_open_message), (modest_dbus_req_handler),
1976 (search_result_to_message), (modest_dbus_req_filter):
1977 * src/modest-search.c: (add_hit), (modest_search_folder),
1978 (modest_search_all_accounts): Improved debug messages.
1980 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1982 * src/modest-tny-account-store.c:
1983 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1986 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1989 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1991 * src/modest-tny-account-store.c: (get_server_accounts):
1992 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1993 even when there are no accounts, so that the Outbox folder is always
1994 visible. This fixes projects.maemo.org bug NB#60158.
1996 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1998 * src/maemo/modest-main-window.c: (create_details_widget):
1999 Use the mcen_va_never logical ID.
2001 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2003 * src/dbus_api/modest-dbus-api.h:
2004 * src/dbus_api/modest-dbus-callbacks.c:
2005 (on_idle_open_default_inbox), (on_open_default_inbox),
2006 (modest_dbus_req_handler):
2007 Added a new OpenDefaultInbox method.
2009 * libmodest-dbus-client/libmodest-dbus-client.h:
2010 * libmodest-dbus-client/libmodest-dbus-client.c:
2011 Added libmodest_dbus_client_open_default_inbox() to call the new
2012 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2013 though it should maybe be used by a new osso-email-interface function.
2015 * tests/dbus_api/Makefile.am:
2016 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2019 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2021 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2022 NULL, so that the signals get all the keys. This should not actually
2023 change any behaviour because we currently update everything when anything
2026 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2028 * src/widgets/modest-folder-view.c: (text_cell_data),
2029 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2030 (find_inbox_iter): If tinymail tells us that the folder is
2031 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2032 This causes the inbox to be selected at startup, fixing part of
2033 projects.maemo.org bug NB#56305.
2035 * src/modest-ui-dimming-rules.c:
2036 (modest_ui_dimming_rules_on_tools_smtp_servers):
2037 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2038 the SMTP servers menu item.
2039 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2040 that the SMTP Servers menu item is dimmed when there are no accounts,
2041 as a future version of the UI spec will require. This fixes
2042 projects.maemo.org bug NB#56305.
2044 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2046 * src/maemo/modest-maemo-utils.c:
2047 (modest_maemo_utils_get_supported_secure_authentication_methods):
2048 Added label to dialog instead of unreadable title
2050 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2051 (modest_main_window_new):
2052 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2055 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2056 * src/modest-account-mgr.h:
2057 Added method to avoid code duplication
2059 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2060 (modest_ui_actions_on_send_receive):
2061 Use modest_account_mgr_has_accounts
2063 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2065 * src/maemo/easysetup/modest-presets.c:
2066 (modest_presets_get_info_server_security): Do not report secure auth
2068 * src/modest-protocol-info.c: Use the defines for the gconf key names
2069 for secure authentication. This was not working because we were writing
2070 Password and reading password, and the check was case sensitive.
2071 With this, gmail now works for receiving and sending when created via
2074 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2076 * src/maemo/easysetup/modest-presets.c:
2077 (modest_presets_get_info_server_security): Correct the key name for
2078 SecureSmtp, because it seems to be case-sensitive.
2079 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2080 Do not try to get the 0th notebook page if there are 0 pages, to
2081 avoid a g_warning().
2083 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2085 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2086 Prevent use of the new notification feature for now, because it currently
2087 shows one dialog for each new email, which is annoying.
2089 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2091 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2092 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2093 when no country was selected, so that we show the global ones.
2094 * src/maemo/easysetup/modest-presets.c:
2095 (modest_presets_get_providers): Return only the global providers, not
2096 all providers when mmc=0 was requested.
2098 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2100 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2101 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2102 provider ID in the combo.
2104 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2105 Do not show the page numbers, because it would be confusing when we add
2106 the 2 extra pages for the custom setup, when the user chooses the "Other"
2107 provider. This fixes projects.maemo.org bug NB#59028
2109 * src/modest-init.c: (modest_init_init_core),
2110 (modest_init_local_folders):
2111 * src/modest-init.h:
2112 * src/modest-tny-account.c:
2113 (modest_tny_account_new_for_local_folders): Do not create default folders
2114 for the memory card. This should fix projects.maemo.org bug NB#59328.
2116 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2118 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2119 Free the changed_conf_keys string items. They are already freed in the
2120 idle handler if that runs first.
2122 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2124 * src/modest-ui-actions.c:
2125 (modest_ui_actions_on_password_requested): Check that the server name
2126 is not NULL, because I just saw a password dialog with (null) as the
2129 * src/modest-tny-folder.[h|c]: Added
2130 modest_tny_folder_is_memory_card_folder().
2131 * src/modest-ui-dimming-rules.c:
2132 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2133 menu item for memory cards, as per the UI spec (section 7.4). This should
2134 fix projects.maemo.org bug NB#59297.
2136 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2138 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2139 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2140 is another problem with the code, see Murray's comment at line 772)
2142 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2144 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2145 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2146 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2147 (load_from_file), (easysetup_country_combo_box_init),
2148 (easysetup_country_combo_box_get_active_country_ids),
2149 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2150 instead of just one ID, to avoid duplicate country names in the UI.
2152 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2153 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2154 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2155 a single ID, avoiding duplicate providers.
2156 * src/maemo/easysetup/modest-easysetup-wizard.c:
2157 (on_combo_account_country): Adapt to use a list.
2159 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2161 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2162 keys changed in the last X seconds.
2164 * src/modest-account-mgr.h:
2165 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2166 (on_key_change), (modest_account_mgr_class_init),
2167 (modest_account_mgr_init), (modest_account_mgr_finalize):
2168 As the keys are changed, save them in a GSList* and signal that GSList*
2169 further every X seconds, to batch changes, to allow us to do just one
2170 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2171 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2173 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2174 changed signal signature.
2176 * src/modest-conf.c: (modest_conf_set_list),
2177 (modest_conf_on_change): Reenable notification.
2179 (modest_conf_maemo_fake_on_change): Comment out the hack that
2180 notified immediately instead of asynchronously.
2182 * src/widgets/modest-account-view.h:
2183 * src/widgets/modest-account-view.c:
2184 (update_account_view): Select the previously-selected account ID,
2185 if possible. This fixes projects.maemo.org bug NB#56933.
2187 (on_account_changed), (on_account_removed),
2188 (modest_account_view_select_account):
2190 Remove the block/unblock functions
2191 because they were not useful.
2193 * src/maemo/modest-account-view-window.c:
2194 (on_delete_button_clicked), (on_edit_button_clicked),
2195 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2197 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2199 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2200 Improve the error dialog to show Incorrect Account Settings, which seems
2201 clearer, and say that the internal error message (to be removed from the
2202 dialog later) is often misleading.
2203 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2205 * src/modest-tny-account.c:
2206 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2207 URL because this is so useful for debugging on the device.
2209 * src/widgets/modest-serversecurity-combo-box.c:
2210 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2212 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2214 * src/modest-mail-operation.c:
2215 (modest_mail_operation_send_new_mail):
2216 Added a comment about a nasty but apparently harmless message. Details
2217 added to the wiki g_warnings() page.
2219 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2221 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2222 (modest_tny_send_queue_class_init):
2223 Do not use the priv struct because it is empty, to avoid g_warnings
2224 about a non-existant priv struct.
2226 * src/modest-tny-account-store.c:
2227 (modest_tny_account_store_get_server_account),
2228 (modest_tny_account_store_get_transport_account_for_open_connection
2229 ): Do not try to get transport server accounts for local folders,
2230 because they don't have any. This avoids a g_warning().
2232 * src/maemo/modest-main-window.c:
2233 (modest_main_window_notify_send_receive_initied),
2234 (on_configuration_key_changed):
2235 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2236 * src/modest-defs.h:
2237 * src/modest-mail-operation.c:
2238 (modest_mail_operation_update_account):
2239 * src/modest-tny-account-store.h:
2240 * src/modest-tny-account.c:
2241 (modest_tny_account_get_special_folder),
2242 (modest_tny_account_new_for_local_folders),
2243 (modest_tny_account_new_for_per_account_local_outbox_folder):
2244 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2245 * src/modest-tny-local-folders-account.c:
2246 (add_account_folders_to_merged_folder):
2247 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2248 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2249 (modest_ui_actions_on_send):
2250 * src/widgets/modest-folder-view.c: (update_model):
2251 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2252 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2253 modest_tny_account_store_get_tny_account_by_account() to
2254 modest_tny_account_store_get_server_account() to make the code clearer.
2256 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2258 * src/dbus_api/modest-dbus-api.h:
2259 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2260 * src/maemo/modest-msg-edit-window.c:
2261 (modest_msg_edit_window_attach_file_noninteractive):
2262 added g_warning in case the file to be attached does not exist
2263 * tests/dbus_api/test_compose_mail.c: (main):
2264 removed obsolete comment, added generic files as test case
2266 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2268 * src/modest-tny-account-store.c: (get_server_accounts):
2269 Create the local folders account only once, not once for each outbox, and
2270 not only when there are some outboxes.
2272 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2274 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2275 code that is causing a crash at startup. Sergio says that he is fixing this.
2277 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2279 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2280 * src/maemo/modest-account-settings-dialog.c:
2281 (create_page_outgoing),
2282 (modest_account_settings_dialog_set_account_name),
2283 (save_configuration):
2284 - Fixed handling of the "Use secure authentication" toggle to comply with
2285 the ui specification. See also projects.maemo.org bug NB#58400
2287 - Restore the Secure connection setting combo correctly when loading
2290 * src/maemo/modest-maemo-utils.c:
2291 (on_camel_account_get_supported_secure_authentication),
2292 (modest_maemo_utils_get_supported_secure_authentication_methods):
2293 Fixed a crasher if operation is canceled
2295 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2296 (modest_protocol_info_auth_is_secure):
2297 * src/modest-protocol-info.h:
2299 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2300 the sense of the "Use secure authentication" toggle.
2302 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2304 * src/modest-tny-account-store.h:
2305 * src/modest-tny-account-store.c:
2306 Added modest_tny_account_store_get_local_folders_account().
2308 * src/modest-tny-folder.h:
2309 * src/modest-tny-folder.c:
2310 (modest_tny_folder_get_account):
2311 Added this replacement for tny_folder_get_account() which returns
2312 the local-folders account for TnyMergeFolders, to avoid the
2313 warning about the unimplemented get_account_func() vfunc().
2315 (modest_tny_folder_get_rules),
2316 * src/modest-ui-actions.c:
2317 (modest_ui_actions_on_folder_selection_changed):
2318 * src/modest-mail-operation.c:
2319 (modest_mail_operation_remove_folder),
2320 (modest_mail_operation_xfer_folder),
2321 (modest_mail_operation_rename_folder),
2322 (modest_mail_operation_get_msg),
2323 (modest_mail_operation_get_msgs_full),
2324 (modest_mail_operation_remove_msg),
2325 (modest_mail_operation_xfer_msgs),
2326 (modest_mail_operation_refresh_folder):
2327 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2329 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2331 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2332 (modest_server_account_set_security):
2333 * src/modest-defs.h: Add comments explaining that our
2334 UI spec means TLS when it says Normal, so these do not look like errors.
2336 * src/modest-tny-account.c:
2337 (modest_tny_account_new_from_server_account): Use the new tinymail
2338 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2339 for TLS. This should fix projects.maemo.org bug NB#58460.
2341 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2343 * src/maemo/easysetup/modest-easysetup-wizard.c:
2344 (create_account): Correct the position of the gconf sanity check warning.
2345 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2346 of using the g_idle_add() hack, because this does not seem to be necessary
2347 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2348 caused by something other than maemo's gconf.
2349 This fixes projects.maemo.org bug #59022.
2351 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2353 * src/modest-account-mgr-helpers.c:
2354 (modest_account_mgr_get_default_account): Do not check that the account
2355 exists if there is no default account (NULL), to fix a runtime warning.
2357 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2359 * src/widgets/modest-folder-view.c: (update_model):
2360 Do not unref the treemodel before we have finished with it.
2361 This prevents a valgrind warning and an occasional crash at startup.
2363 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2365 * libmodest-dbus-client/libmodest-dbus-client.h:
2366 added libmodest_dbus_client_compose_mail()
2367 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2369 added functions needed for SendAsMail() functionality
2370 * src/maemo/modest-msg-edit-window.c:
2371 (modest_msg_edit_window_attach_file_noninteractive):
2372 non interactively attaching files to message edit window
2373 * src/widgets/modest-msg-edit-window.h:
2374 * tests/dbus_api/Makefile.am:
2375 added test_compose_mail.c
2376 * tests/dbus_api/test_compose_mail.c: (main):
2378 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2380 * src/modest-account-view.c:
2381 Fixed bug projects.maemo.org bug NB#59307
2383 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2385 * src/maemo/easysetup/modest-easysetup-wizard.c:
2386 (get_serverport_incoming), (on_before_next), (create_account):
2387 * src/maemo/modest-account-settings-dialog.c:
2388 (modest_account_settings_dialog_set_account_name):
2389 * src/maemo/modest-maemo-utils.c:
2390 (on_camel_account_get_supported_secure_authentication_status),
2391 (on_camel_account_get_supported_secure_authentication),
2392 (on_secure_auth_cancel),
2393 (modest_maemo_utils_get_supported_secure_authentication_methods):
2395 Implemented security authentication for settings and easysetup.
2397 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2399 * src/maemo/modest-main-window.c: (create_details_widget):
2400 Show the total size for memory card accounts too, instead of showing
2401 the name again. Fixes bug projects.maemo.org bug NB#59307.
2403 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2406 * src/modest-tny-simple-folder-store.c:
2407 * src/modest-tny-simple-folder-store.h: Removed.
2409 * src/modest-tny-local-folders-account.h
2410 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2411 for the local-folders maildir, with an extra TnyMergedFolder containing
2412 the folders of the per-account outbox store accounts.
2413 * src/modest-tny-account-store.c: (get_server_accounts):
2414 Add the outboxes to the special local folders account after creating it.
2416 * src/modest-tny-account.c:
2417 (modest_tny_account_new_for_local_folders): Create the derived
2418 account when creating the main local-folders account.
2420 * src/maemo/modest-main-window.c: (create_details_widget),
2421 (modest_main_window_set_contents_style):
2422 Adapted to the use of the derived account instead of the folder store.
2424 * src/modest-ui-actions.c:
2425 (modest_ui_actions_on_folder_selection_changed):
2426 * src/modest-ui-dimming-rules.c:
2427 (modest_ui_dimming_rules_on_new_folder):
2428 * src/widgets/modest-folder-view.c: (text_cell_data),
2429 (icon_cell_data), (filter_row), (update_model),
2430 (get_cmp_rows_type_pos):
2433 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2434 Do not get the priv struct, because no priv struct has been set,
2435 to avoid a runtime warning.
2437 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2438 #ifelse with #else, to fix a warning, to fix the build.
2441 2007-06-05 Christian Kellner <ckellner@openismus.com>
2443 * libmodest-dbus-client/libmodest-dbus-client.c:
2444 Fix small typo in doc (why do you always see them
2445 AFTER committing stuff?)
2448 2007-06-05 Christian Kellner <ckellner@openismus.com>
2450 * libmodest-dbus-client/libmodest-dbus-client.c:
2451 (libmodest_dbus_client_search):
2452 Initialize hit list with NULL. Also set folder list
2453 to "" if NULL was supplied.
2456 2007-06-03 Christian Kellner <ckellner@openismus.com>
2458 * libmodest-dbus-client/libmodest-dbus-client.c:
2459 (modest_search_hit_list_free):
2460 Make it save to call it with NULL.
2462 * src/dbus_api/modest-dbus-callbacks.c:
2463 * src/modest-search.c:
2464 Return full ModestSearchHits as the search result list not TnyHeader
2465 since can't be around withouth the correspoding TnyFolder.
2467 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2469 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2470 Added currently commented code to check for secure auth
2472 * src/maemo/modest-account-settings-dialog.c: (on_response),
2473 (save_configuration), (show_ok):
2474 Fixed projects.maemo.org bugs NB #59248 and #59251
2476 * src/maemo/modest-maemo-utils.c:
2477 (on_camel_account_get_supported_secure_authentication_status),
2478 (on_camel_account_get_supported_secure_authentication),
2479 (modest_maemo_utils_get_supported_secure_authentication_methods):
2480 * src/maemo/modest-maemo-utils.h:
2481 Moved get_supported_secure_authentication() method here to be able
2482 to use it from easysetup wizard.
2484 * src/modest-pair.c: (on_pair_compare_as_string):
2485 Should compare string with first part of pair and not
2486 strcmp pairs which will crash.
2488 * src/modest-protocol-info.c:
2489 (modest_protocol_info_protocol_is_store):
2490 * src/modest-protocol-info.h:
2491 Added modest_protocol_info_get_auth_protocol_name()
2493 2007-06-03 Armin Burgmeier <armin@openismus.com>
2495 * src/modest-mail-operation.c:
2496 (modest_mail_operation_get_msgs_full): Set priv->account also when
2497 only retrieving a single message. This avoids a crash when canceling
2500 (modest_mail_operation_notify_end): Do not explicitely remove the
2501 operation from the queue but only emit the progress_changed signal.
2502 The queue itself listens to that signal to remove the operation when
2503 it is finished. This reduces coupling and removes a potential deadlock
2504 when modest_mail_operation_notify_end() is called from the queue
2505 itself. If that is a problem performance-wise, I would suggest to
2506 implement a status-changed signal or something.
2508 * src/modest-mail-operation-queue.c: Make sure to never call a
2509 function from another file while the queue is locked. This (hopefully)
2510 fixes another deadlock when exiting the application while retrieving
2513 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2515 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2516 Fixed build if libogs is not available
2518 2007-06-03 Christian Kellner <ckellner@openismus.com>
2520 * libmodest-dbus-client/libmodest-dbus-client.h:
2521 * libmodest-dbus-client/libmodest-dbus-client.c:
2522 (libmodest_dbus_client_delete_message):
2523 Implement deletion of messages (Client side).
2525 (modest_search_hit_free),
2526 (modest_search_hit_list_free):
2527 Utility functions to free the result hits.
2529 * src/dbus_api/modest-dbus-api.h:
2530 * src/dbus_api/modest-dbus-callbacks.c:
2531 (on_delete_message),
2532 (modest_dbus_req_handler):
2533 Implement deletion of messages (Server side).
2535 * tests/dbus_api/test_search.c: (main):
2538 * tests/dbus_api/Makefile.am:
2539 * tests/dbus_api/test_delete_message:
2540 Add little test for the message deletion logic
2542 2007-06-03 Armin Burgmeier <armin@openismus.com>
2544 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2545 when the operation queue was not empty. projects.maemo.org bug
2548 2007-06-03 Armin Burgmeier <armin@openismus.com>
2550 * src/widgets/modest-account-view.c
2551 (on_account_default_toggled): Toggle default account column
2552 explicitely instead of waiting for gconf notification (which is
2553 currently ignored). This should fix projects.maemo.org bug NB#56910
2554 for now. It should probably be removed when gconf notifications are
2557 2007-06-03 Christian Kellner <ckellner@openismus.com>
2559 * libmodest-dbus-client/libmodest-dbus-client.c:
2560 Removed debugging spew.
2562 * src/dbus_api/modest-dbus-callbacks.c:
2563 Added debugging info.
2565 * src/modest-search.c:
2566 (modest_search_all_accounts):
2567 Use tny_account_store_get_accounts () on the account store
2568 to get all accounts which is the way to get all accounts.
2570 * tests/dbus_api/test_search.c: (main):
2571 Make it possible to supply the search term on the command line.
2573 2007-06-03 Christian Kellner <ckellner@openismus.com>
2575 * libmodest-dbus-client/libmodest-dbus-client.c:
2576 * libmodest-dbus-client/libmodest-dbus-client.h:
2577 Implement searching for mesages over raw dbus. (Client side)
2579 * src/dbus_api/Makefile.am:
2580 * src/dbus_api/modest-dbus-api.h:
2581 * src/dbus_api/modest-dbus-callbacks.c:
2582 * src/dbus_api/modest-dbus-callbacks.h:
2583 Search framework (Server side). Also implement on_idle_open_message().
2585 * src/maemo/modest-platform.c: (modest_platform_init):
2586 Prepare for raw dbus/osso rpc interaction.
2588 * src/modest-search.h:
2589 Changed minsize from unspecific guint to guint32.
2591 * src/modest-search.c:
2593 Added strange hack which magically made tnymail work.
2595 (modest_search_folder),
2596 (modest_search_account),
2597 (modest_search_all_accounts):
2598 Implement helper functions to search all accounts, specific account
2601 * tests/dbus_api/Makefile.am:
2602 * tests/dbus_api/test_open_message.c:
2603 Read url to open from commandline.
2605 * tests/dbus_api/test_search.c:
2606 Implement small test for dbus search stuff
2608 2007-06-02 Armin Burgmeier <armin@openismus.com>
2610 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2611 include account type and account title. This fixes projects.maemo.org
2614 * src/maemo/modest-account-view-window.c: Set a title for the window.
2616 2007-06-02 Armin Burgmeier <armin@openismus.com>
2618 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2619 incoming and outgoing server name based on email address and server
2620 types as long as the names have not been edited manually. This fixes
2621 projects.maemo.org bug NB#58671.
2623 2007-06-02 Armin Burgmeier <armin@openismus.com>
2625 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2626 server type cannot be changed in future to the incoming details page
2627 when creating an account. This fixes projects.maemo.org bug NB#59029.
2629 2007-06-02 Armin Burgmeier <armin@openismus.com>
2631 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2632 and assigned max width chars so that they wrap instead of being
2633 truncated. Fixes projects.maemo.org bug NB#56126.
2635 2007-06-02 Armin Burgmeier <armin@openismus.com>
2637 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2638 introductory note to the connection specific smtp servers dialog, as
2639 section 8.12 of the email UI specification requires. This fixes
2640 projects.maemo.org bug NB#59212.
2642 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2644 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2645 Check for running mail operations, and offer to cancel them, as per the UI
2646 spec. This fixes projects.maemo.org bug NB#59041 .
2647 However, I suspect that tinymail may still use the network connection
2648 in ways that we cannot detect or cancel. But it should at least adapt to
2649 changes fairly well.
2651 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2653 * src/modest-tny-account-store.c: (recreate_all_accounts),
2654 (get_cached_accounts), (get_server_accounts): Do more sensible
2655 ref-counting of the temporarily-cached outbox accounts list. This seems
2656 to fix a crash when entering the password when the password was wrong.
2658 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2660 * src/gnome/modest-main-window.c: (connect_signals):
2661 * src/modest-tny-account-store.c: (get_password),
2662 (modest_tny_account_store_alert): Added comments and clues and
2663 commented-out code about how we currently fail to deal with connection
2664 errors and wrong passwords, and how we should.
2666 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2668 * src/widgets/modest-retrieve-combo-box.c:
2669 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2670 This fixes projects.maemo.org bug NB#58472 .
2672 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2674 * src/maemo/easysetup/modest-easysetup-wizard.c:
2675 (create_page_complete_easysetup):
2676 (create_page_complete_custom): Correct the last commit,
2677 putting the correct sentences in the correct pages.
2679 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2681 * src/maemo/easysetup/modest-easysetup-wizard.c:
2682 (create_page_complete_custom): Show the second sentence of text
2683 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2686 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2688 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2689 Set the leave-on-server conf key by default. This fixes
2690 projects.maemo.org bug NB#59258 .
2692 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2694 * src/maemo/modest-account-view-window.c:
2695 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2696 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2699 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2701 * src/maemo/easysetup/modest-easysetup-wizard.c:
2702 (create_caption_new_with_asterisk):
2703 * src/maemo/modest-account-settings-dialog.c:
2704 (create_caption_new_with_asterisk):
2705 Uncomment the code to add the asterisk, because they are no longer in the
2706 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2707 (update_incoming_server_title): Add an asterisk here too.
2709 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2711 * src/maemo/modest-maemo-global-settings-dialog.c:
2712 (current_connection): Check that we are even connected before trying to
2713 get the current connection name, to prevent a warning.
2715 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2716 Change the comments because tny_maemo_conic_device_connect() is now meant to
2718 * src/modest-mail-operation.c:
2719 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2720 make sure we have a connection and fail if we can't connect.
2722 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2724 * src/maemo/modest-main-window.c:
2725 (on_account_store_connecting_finished): Do not try to get the
2726 connection ID if we are not really connected. I am surprised that
2727 this signal handler is called when we are not connected.
2729 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2731 * src/modest-error.h:
2732 * src/modest-ui-actions.c:
2733 (modest_ui_actions_get_msgs_full_error_handler):
2734 Renamed an enum, added comments, added an enum
2735 for retrieve-limit errors.
2737 * src/modest-mail-operation.c: (foreach_add_item),
2738 (internal_folder_observer_update), (update_account_thread),
2739 (modest_mail_operation_get_msgs_full):
2740 (modest_mail_operation_update_account),
2741 Added comments about how this works, and some code that should
2742 (but does not) check the retrieve-limit. See the TODO comment.
2744 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2746 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2747 Initialize help_id to fix the build. Warnings are good.
2749 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2751 * src/widgets/modest-hbox-cell-renderer.c:
2752 (modest_hbox_cell_renderer_append):
2753 * src/widgets/modest-vbox-cell-renderer.c:
2754 (modest_vbox_cell_renderer_append):
2755 Fix the last commit by doing an extra ref.
2757 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2759 * src/widgets/modest-hbox-cell-renderer.c:
2760 (modest_hbox_cell_renderer_append):
2761 * src/widgets/modest-vbox-cell-renderer.c:
2762 (modest_vbox_cell_renderer_append):
2763 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2764 to fix the build with Maemo Bora.
2765 However, there seems to be a remaining crash, probably due to reference
2768 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2770 * src/modest-tny-account.c:
2771 (modest_tny_account_new_for_local_folders):
2772 Use hildon_file_system_info_async_new() to get a better name for
2773 the memory card account, setting it as the account name.
2774 The timing seems to work, but this is probably
2775 not the best place to do this. See the TODO comment.
2776 * src/maemo/modest-main-window.c: (create_details_widget):
2777 * src/widgets/modest-folder-view.c: (text_cell_data):
2778 Use the tny account name instead of hardcoding a name.
2780 2007-05-30 Christian Kellner <ckellner@openismus.com>
2782 * src/modest-search.c: (modest_search):
2783 Correctly set part_search_func even if we have already parsed
2784 the query and thus a valid OgsTextSearcher object.
2786 2007-05-30 Christian Kellner <ckellner@openismus.com>
2789 Search and check for libogs.
2792 Incooparte the ogs build env.
2794 * src/modest-mime-part-search-stream.c:
2795 * src/modest-mime-part-search-stream.h:
2796 Removed since we do the real searching now in modest-search.c.
2798 * src/modest-search.c:
2799 * src/modest-search.h:
2800 Implement support for ogs. We use that if available and requested
2801 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2802 should now handle the corner case when the search term is spread
2803 across multiple reads.
2804 Also the logic in modest_search () was corrected to search all
2805 requested fields until one is found.
2807 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2809 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2811 * src/modest-init.h:
2812 * src/modest-init.c: Made modest_init_local_folders() take a
2813 path and be public so we can iniitialize maildir folders on
2816 * src/modest-local-folder-info.h:
2817 * src/modest-local-folder-info.c:
2818 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2820 * src/modest-tny-account.c:
2821 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2822 still means the standard local-folders path on the local volume.
2824 * src/modest-tny-account-store.c:
2825 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2826 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2827 all accounts when that happens.
2828 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2829 this too, so it shows up in the treeview.
2831 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2833 * src/maemo/modest-maemo-global-settings-dialog.c:
2834 (current_connection):
2835 * src/widgets/modest-global-settings-dialog.c:
2836 (current_connection_default):
2837 Use the enum values instead of 0, 1 and -1,
2838 to make the code clearer.
2840 * src/modest-account-mgr-helpers.c:
2841 (modest_account_mgr_get_connection_specific_smtp): Make this code
2844 * src/modest-runtime.h:
2845 * src/modest-runtime.c:
2846 Added modest_runtime_remove_all_send_queues().
2847 * src/maemo/modest-main-window.c:
2848 (on_account_store_connecting_finished): Recreate the send queues,
2849 using the appropriate transport accounts for this new connection.
2850 Some futher adapting might be needed if the old send queues are not
2851 automatically stopped at this point.
2853 * src/modest-tny-account-store.c: (get_server_accounts):
2854 Create the connection-specific transport accounts, so that they can
2855 be found later by their ID.
2857 * src/modest-tny-account.h:
2858 * src/modest-tny-account.c:
2859 Added modest_tny_account_new_from_server_account_name().
2860 modest_tny_account_new_from_server_account(): Do not create the
2861 send queues here, because they will be
2862 recreated anyway when the connection changes for the first time.
2864 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2866 * src/modest-local-folder-info.h:
2867 * src/modest-local-folder-info.c:
2868 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2869 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2870 tbox_folder): Take a modest account name instead of a server TnyAccount,
2871 so we can have per-modest-account rather than per-transport-account
2873 We must make sure that we change or recreate the exisitng send queues
2874 when the connection changes for connection-specific transport accounts.
2876 * src/modest-tny-account-store.c:
2877 (create_per_account_local_outbox_folders): Create outboxed per modest
2878 account, not per transport account.
2880 * src/modest-tny-account.h:
2881 * src/modest-tny-account.c:
2882 (modest_tny_account_get_special_folder): For outboxes, get the
2883 parent modest account name. The account is ignored for other folders.
2884 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2885 modest account name rather than a server TnyAccount.
2887 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2889 * src/modest-tny-account.c:
2890 (modest_tny_account_new_from_server_account):
2891 Call modest_runtime_get_send_queue() immediately after creating transport
2892 accounts, so that they start trying to send email from the outbox as soon
2893 as possible at startup. This is probably what we want.
2895 * src/modest-mail-operation.c: (update_account_thread):
2896 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2897 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2898 * src/modest-tny-send-queue.h:
2899 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2900 (modest_ui_actions_on_send):
2901 Added comments about how sending works, though it needs some more work.
2903 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2905 * src/modest-tny-account.c:
2906 (modest_tny_account_get_special_folder): Add TODO because this fails when
2907 the network is busy.
2908 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2909 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2910 Do not try to show this window when there is no active account. The UI
2911 specs does not tell us what to do in this case.
2913 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2917 * src/maemo/Makefile.am:
2918 * src/widgets/Makefile.am: Some dist fixes.
2920 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2922 * src/maemo/modest-connection-specific-smtp-window.c:
2923 (on_button_edit): Make the code clearer, to prevent a double free.
2925 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2927 * src/maemo/modest-account-settings-dialog.c:
2928 (modest_account_settings_dialog_set_account_name),
2929 Check the connection-specific smtp servers checkbox if there are any.
2931 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2932 (modest_connection_specific_smtp_edit_window_init):
2933 Start with a suitable port number.
2935 * src/modest-account-mgr-helpers.h:
2936 * src/modest-account-mgr-helpers.c: Added
2937 modest_account_mgr_get_has_connection_specific_smtp().
2939 (modest_account_mgr_set_connection_specific_smtp),
2940 (modest_account_mgr_remove_connection_specific_smtp),
2941 (modest_account_mgr_get_has_connection_specific_smtp),
2942 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2943 connection-specific smtp server accounts in the account, rather than
2944 the server account conf dir.
2946 This fixes bug projects.maemo.org bug NB#58263 .
2948 * src/modest-tny-account-store.c:
2949 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2950 if there are no server accounts yet, to prevent an infinite loop when there
2951 are no accounts. Document that one must be called before the other.
2953 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2955 * src/modest-account-mgr-helpers.c:
2956 (modest_account_mgr_get_default_account): Make sure that at least
2957 one account is always the default, if there are any enabled accounts.
2958 This is just a sanity check that shouldn't be necessary.
2960 * src/modest-account-mgr-priv.c:
2961 (_modest_account_mgr_account_from_key): Unescape the conf key to
2962 get the real account name. For instance, this is an issue if a space
2963 was in the account name, which can happen because the account name
2964 is generated from the display name.
2965 (_modest_account_mgr_get_account_keyname): Always escape the
2967 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2968 Unescape the conf keys to get the real account names.
2970 For instance, previously the is-default radio button in the accounts
2971 list was not checked for any accounts at first. This fixes that,
2972 and might fix several similar bugs.
2974 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2976 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2977 Removed some debug printfs.
2979 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2981 Modest on-disk outbox directories are now here, for instance:
2982 $HOME/.modest/outboxes/<account-id-1>/outbox
2983 $HOME/.modest/outboxes/<account-id-2>/outbox
2985 $HOME/.modest/local-folders/outbox
2986 so we can have a separate outbox for each account.
2987 But they are shown as one outbox in the GtkTreeView, by using a
2988 TnyMergeFolder in a ModestTnySimpleFolderStore.
2991 * src/modest-tny-simple-folder-store.c:
2992 * src/modest-tny-simple-folder-store.h:
2993 Added ModestTnySimpleFolderStore, used to contain folders from
2994 other folder stores, such as other accounts.
2996 * src/modest-tny-outbox-account.h:
2997 * src/modest-tny-outbox-account.c:
2998 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2999 used for the per-account local outbox folders.
3001 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3002 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3003 only use this (internally) now for the non-outbox local folders.
3005 * src/modest-init.h:
3006 * src/modest-init.c: Added modest_init_one_local_folder(), for
3007 setting up the directory structure for each local folder.
3009 * src/modest-local-folder-info.c:
3010 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3011 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3013 * src/modest-local-folder-info.h:
3014 * src/modest-tny-account-store.c: (on_account_removed),
3015 (on_account_changed), (create_per_account_local_outbox_folders),
3016 (get_server_accounts), (modest_tny_account_store_get_accounts),
3017 (modest_tny_account_store_get_tny_account_by_account),
3018 (modest_tny_folder_store_is_virtual_local_folders):
3020 * src/modest-tny-account.h:
3021 * src/modest-tny-account.c:
3022 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3023 to create an on-disk per-account local outbox folder for each
3025 (create_per_account_local_outbox_folders): Create a local outbox folder
3026 for each transport account.
3027 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3028 for all local folders.
3030 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3031 instead of using g_object_get/set() directly. It is clearer.
3033 (modest_tny_folder_store_get_message_count),
3034 (modest_tny_folder_store_get_local_size
3035 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3036 because we now use these with non-acount folder stores.
3038 (modest_tny_account_get_special_folder),
3039 (modest_tny_account_new_from_server_account),
3040 (modest_tny_account_new_from_account):
3041 (recurse_folders): Adjust to the new outbox system.
3043 * src/modest-tny-folder.h:
3044 * src/modest-tny-folder.c:
3045 (modest_tny_folder_is_local_folder),
3046 (modest_tny_folder_get_local_folder_type),
3047 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3049 * src/widgets/modest-main-window.h:
3050 * src/maemo/modest-main-window.c: (create_details_widget),
3051 (modest_main_window_set_contents_style): Show details for any folder store,
3054 (modest_tny_folder_get_rules):
3055 Remove the const. C does not support constness enough for this.
3057 * src/modest-ui-actions.c:
3058 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3059 make all outboxes appear as one, in the usual local-folders tree node.
3061 (set_active_account_from_tny_account),
3062 (modest_ui_actions_on_folder_selection_changed):
3063 * src/widgets/modest-folder-view.c: (text_cell_data),
3064 (icon_cell_data), (filter_row),
3065 (add_account_folders_to_merged_folder),
3066 (add_account_folders_to_simple_folder_store), (),
3067 (get_cmp_rows_type_pos), (cmp_rows),
3068 (modest_folder_view_set_account_id_of_visible_server_account):
3069 Adjust to the new outbox system, using generic folder stores and folders
3070 in the GtkTreeModel.
3072 2007-05-23 Christian Kellner <ckellner@openismus.com>
3074 * src/modest-mail-operation.c:
3075 (modest_mail_operation_update_account):
3076 Use info->max_size instead of unintialized local var [small
3077 build fix]. (Added TODO to review that change since I don't
3080 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3082 * libmodest-dbus-client/libmodest-dbus-client.c:
3083 (libmodest_dbus_client_compose_mail): function added
3084 * src/dbus_api/modest-dbus-api.h:
3085 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3086 (on_compose_mail): Implementation of the SendAsMail functionality
3088 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3090 * src/modest-account-mgr.c:
3091 (modest_account_mgr_add_server_account): Set the secure-connection
3092 conf key for transport accounts as well as store accounts. I don't know
3093 why the if was there. For instance, this makes sure that we use SSL
3094 for the gmail preset from the easysetup wizard.
3096 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3098 * src/gnome/modest-main-window.c:
3099 (on_account_store_connecting_finished), (connect_signals):
3100 * src/maemo/modest-main-window.c:
3101 (on_account_store_connecting_finished), (connect_signals),
3102 (modest_main_window_new):
3103 Handle TnyAccountStore::connecting-finished instead of
3104 TnyDevice::connection-changed, because we cannot actually perform
3105 operations on accounts until TnyAccountStore has itself responded to
3106 the TnyDevice::connection-changed signal. This prevents a GError from
3108 Do not try to update at startup, because we (at least on scratchbox)
3109 already do an update at startup when the device goes online.
3110 This prevents a GError from tinymail.
3111 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3112 Added TODO about stopping simultaneous operations.
3114 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3116 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3117 * src/modest-mail-operation-queue.c:
3118 (modest_mail_operation_queue_remove):
3119 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3120 about where they happened.
3122 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3124 * src/modest-ui-actions.c:
3125 (modest_ui_actions_on_password_requested): Make sure that the remember
3126 output parameter is always TRUE.
3128 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3130 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3131 Show a OK/Cancel dialog if the error is a question, though we still do not
3132 know anything more about what we are asking the user.
3133 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3134 Fix an uninitialized variable (helper). This is a logic error, however.
3136 2007-05-21 Christian Kellner <ckellner@openismus.com>
3138 * src/modest-search.h:
3139 Correct bit shifting in the ModestSearchFlags enum.
3141 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3143 * src/modest-tny-account.c:
3144 (modest_tny_account_new_from_server_account): Do not use the lsub and
3145 check-all hard-coded IMAP options when using POP.
3147 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3149 * src/modest-tny-account.c:
3150 (modest_tny_account_new_from_server_account):
3151 Use NULL for the secure-auth method for POP when Password auth has been
3152 specified by the user, as we already do for IMAP. "auth=Login" causes
3153 an error from camel or the server.
3155 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3157 * src/maemo/modest-account-settings-dialog.c:
3158 (create_page_account_details),
3159 (modest_account_settings_dialog_set_account_name):
3160 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3161 for the leave-on-server checkbox, rathr than just the checkbox, when
3162 the protocol is not POP.
3164 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3166 * src/widgets/modest-account-view.c:
3167 * src/widgets/modest-account-view.h:
3168 Added modest_account_view_select_account() which will be useful later
3169 to asynchronously re-select the edited account.
3171 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3173 * src/maemo/modest-account-settings-dialog.c:
3174 (modest_account_settings_dialog_set_account_name):
3175 Automatically choose the port numbers based on the secure authentication
3176 methods, if they have not been chosen before.
3177 This fixes projects.maemo.org bug NB#56273 .
3179 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3181 * src/maemo/modest-main-window-ui.h:
3182 * src/modest-ui-actions.c:
3183 * src/modest-ui-actions.h:
3184 Connect the Tools/SMTP Servers menu item to
3185 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3186 SMTP servers dialog, as in the UI specification and saves changes when it
3187 is closed. This fixed projects.maemo.org bug NB#56305 .
3189 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3191 * src/maemo/modest-connection-specific-smtp-window.c:
3192 (modest_connection_specific_smtp_window_init):
3193 Use gtk_window_set_default_size() to make this window big enough, so
3194 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3196 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3198 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3199 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3200 (modest_connection_specific_smtp_edit_window_init),
3201 Do not try to connect to a combobox signal before the combobox exists.
3202 This fixes the cras in projects.maemo.org bug NB#56288 .
3203 (modest_connection_specific_smtp_edit_window_get_settings):
3204 Remove the server_account_name parameter which was being checked for NULL
3205 though it was not used.
3207 * src/maemo/modest-connection-specific-smtp-window.c:
3208 (modest_connection_specific_smtp_window_fill_with_connections),
3209 (on_button_edit), (modest_connection_specific_smtp_window_init):
3210 Correct the number of treemodel columns to prevent a warning.
3211 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3212 libconic does not work.
3214 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3216 * src/modest-tny-account.c:
3217 (modest_tny_account_new_from_server_account):
3218 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3219 SMTP when "None" was chosen by the user. However, with my SMTP server that
3220 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3223 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3225 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3226 to explain the memory management issue with the ID in the ModestPair.
3228 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3229 (add_sending_page), (modest_account_assistant_finalize):
3230 * src/gnome/modest-gnome-global-settings-dialog.c:
3231 (create_updating_page), (create_composing_page):
3232 * src/gnome/modest-msg-edit-window.c: (get_transports),
3233 (init_window), (modest_msg_edit_window_finalize),
3234 (modest_msg_edit_window_get_msg_data):
3235 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3236 * src/gnome/modest-transport-widget.c:
3237 (modest_transport_widget_finalize), (smtp_configuration):
3238 * src/maemo/modest-maemo-global-settings-dialog.c:
3239 (create_updating_page), (create_composing_page):
3240 * src/maemo/modest-msg-edit-window.c: (get_transports),
3241 (init_window), (modest_msg_edit_window_finalize),
3242 (modest_msg_edit_window_get_msg_data),
3243 (modest_msg_edit_window_free_msg_data):
3244 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3245 (modest_store_widget_finalize):
3246 * src/maemo/modest-transport-widget.c:
3247 (modest_transport_widget_finalize), (smtp_configuration):
3248 * src/modest-main.c: (send_mail):
3249 * src/widgets/modest-combo-box.h:
3250 * src/widgets/modest-global-settings-dialog-priv.h:
3251 * src/widgets/modest-global-settings-dialog.c:
3252 (modest_global_settings_dialog_finalize):
3253 * src/widgets/modest-msg-edit-window.h:
3254 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3255 as long as the combo box, to prevent use of freed memory for the ID.
3257 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3259 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3260 get_accounts(), to make this clearer. Do not check for the enabled gconf
3261 key, because we do not use this for server accounts (at least, not yet).
3262 This allows us to send email again.
3264 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3266 * src/maemo/modest-platform.c:
3267 (on_modest_conf_update_interval_changed), (modest_platform_init):
3268 Only respond to this particular key change. All these strcmp()s cannot be
3271 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3273 * src/maemo/modest-maemo-global-settings-dialog.c:
3274 (current_connection): Prevent a crash in scratchbox when
3275 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3276 * src/maemo/modest-platform.c:
3277 (on_modest_conf_update_interval_changed), (modest_platform_init):
3278 Get the update interval from gconf and reset it when the gconf key changes.
3280 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3282 * src/modest-protocol-info.c:
3283 * src/modest-protocol-info.h: Adde enum-specific get functions,
3284 instead of using a ModestProtocolType enum parameter.
3286 * src/gnome/modest-account-assistant.c:
3287 * src/gnome/modest-store-widget.c:
3288 * src/gnome/modest-store-widget.h:
3289 * src/gnome/modest-transport-widget.c:
3290 * src/gnome/modest-transport-widget.h:
3291 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3292 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3293 * src/maemo/easysetup/modest-easysetup-wizard.c:
3294 * src/maemo/modest-account-settings-dialog.c:
3295 * src/maemo/modest-account-settings-dialog.h:
3296 * src/maemo/modest-store-widget.c:
3297 * src/maemo/modest-store-widget.h:
3298 * src/maemo/modest-transport-widget.c:
3299 * src/maemo/modest-transport-widget.h:
3300 * src/modest-account-mgr-helpers.c:
3301 * src/modest-account-mgr-helpers.h:
3302 * src/modest-account-mgr.c:
3303 * src/modest-account-mgr.h:
3304 * src/modest-tny-account.c:
3305 * src/modest-tny-folder.c:
3306 * src/widgets/modest-account-view.c:
3307 * src/widgets/modest-retrieve-combo-box.c:
3308 * src/widgets/modest-retrieve-combo-box.h:
3309 * src/widgets/modest-secureauth-combo-box.c:
3310 * src/widgets/modest-serversecurity-combo-box.c:
3311 * src/widgets/modest-serversecurity-combo-box.h:
3312 * tests/check_account-mgr.c:
3313 Use the specific functions, and use the re-renamed enum values for GNOME too.
3315 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3317 * src/modest-pair.h:
3318 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3319 so we can get the second based on the first.
3321 * src/maemo/modest-account-settings-dialog.h:
3322 * src/maemo/modest-account-settings-dialog.c:
3323 Added get_supported_secure_authentication_methods(), though it is mostly
3324 commented-out for now until the necessary API is committed to tinymail.
3325 (modest_account_settings_dialog_set_account_name),
3326 (save_configuration): Request the supported authentication methods from the
3327 server, so we can choose a working method.
3329 * src/modest-tny-account-store.h:
3330 * src/modest-tny-account-store.c:
3331 (modest_tny_account_store_get_session): Rename from
3332 tny_account_store_get_session().
3334 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3336 * src/modest-protocol-info.h: Split the ModestProtocol enum
3337 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3338 There was no need to have these unrelated values in one enum.
3340 * src/: many files: Adapted to changed enum. This makes the code a bit
3341 clearer, and the compiler could catch some errors.
3343 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3345 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3346 Show the detailed internal camel error message when an error happens
3347 during the configuration, so that our testers can give us more clues.
3348 For instance, in projects.maemo.org bug NB#56910 .
3350 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3352 * src/modest-tny-account.c:
3353 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3354 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3356 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3358 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3359 * src/maemo/modest-account-settings-dialog.c:
3360 (modest_account_settings_dialog_set_account_name),
3361 (save_configuration): For the incoming secure authentication checkbox,
3362 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3363 the UI specification. PLAIN does not seem to be supported for most IMAP
3364 servers anyway, and I am not sure what it would mean.
3365 However, we probably need to discover which of the secure-authentication
3366 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3367 * src/modest-account-mgr-helpers.c:
3368 (modest_account_mgr_get_server_account_data):
3370 * src/modest-tny-account.c:
3371 (modest_tny_account_new_from_server_account):
3372 Use tny_account_set_mech() to set secure-authentication methods,
3373 with some special-casing for IMAP, based on my observations of how
3376 * src/modest-account-mgr-helpers.h:
3377 * src/modest-account-mgr.c:
3378 * src/modest-defs.h: Comment that the URI is only used for local folders.
3380 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3382 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3383 parameter const, just to be neat.
3384 * src/modest-text-utils.c: (modest_text_utils_inline):
3385 End g_strconcat() with NULL, as its documentation says. This is almost
3386 certainly the cause of my crash at startup on the device. Interestingly,
3387 valgrind doesn't tell us about these errors.
3389 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3391 * scripts/build-packages: Added more precise comments about how to use
3392 this script, though I still get this error:
3393 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3394 error building tinymail
3396 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3398 * src/maemo/modest-main-window.c: (on_account_update):
3399 Very slight cleanup, hoping to make it simpler to discover what causes
3400 a crash here sometimes.
3402 * src/modest-tny-account.c:
3403 (modest_tny_account_new_from_server_account): Set the port. Added
3404 comments about the options and a TODO comment because I need to find out
3405 how to specify the secure authentication method.
3407 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3409 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3410 changed CFlags paths form modest to libmodest
3412 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3414 * src/modest-account-mgr-helpers.c:
3415 (modest_account_mgr_get_server_account_data),
3416 (modest_account_mgr_free_server_account_data):
3417 * src/modest-account-mgr-helpers.h:
3418 * src/modest-account-mgr.c:
3419 (modest_account_mgr_add_server_account):
3420 * src/modest-defs.h:
3421 * src/modest-tny-account.c:
3422 (modest_tny_account_new_from_server_account):
3423 Determine the options for tny_camel_account_add_option() here,
3424 based on the settings, rather than storing them directly in gconf.
3426 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3428 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3429 Show a more friendly error dialog now that we expect (from the tinymail
3430 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3432 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3434 * src/maemo/modest-main-window.c: (on_account_update): Check that
3435 account_name is not NULL, to prevent a crash at startup that I am
3436 seeing on the N800. I do wonder why it is NULL.
3438 * src/maemo/easysetup/modest-easysetup-wizard.c:
3439 (create_page_user_details):
3440 * src/maemo/modest-account-settings-dialog.c:
3441 (create_page_user_details), (create_page_outgoing):
3442 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3443 (modest_connection_specific_smtp_edit_window_init):
3444 * src/modest-ui-actions.c:
3445 (modest_ui_actions_on_password_requested):
3446 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3447 might do something useful with the on-screen keyboard.
3449 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3451 * src/maemo/modest-main-window.c: (on_account_update):
3452 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3453 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3455 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3457 * src/modest-tny-account-store.c: (on_account_changed):
3458 Correct the signature of this signal handler.
3460 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3462 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3463 Show a HildonNote instead of a GtkDialog for Maemo.
3465 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3467 * src/widgets/modest-account-view.h:
3468 * src/widgets/modest-account-view.c: (on_account_changed),
3469 (on_account_removed). Added a boolean flag, set/unset by
3470 modest_account_view_block_conf_updates(),
3471 modest_account_view_unblock_conf_updates() to prevent unnecessary
3472 updates, but this is not very useful because the gconf notifications are
3473 so delays (maybe only on Maemo Bora).
3474 So auto-updating is turned off, and these functions do an explicit
3475 update when necessary.
3476 However, something else is still doing too much work when adding/removing
3477 accounts, probably in another part of the application.
3479 * src/maemo/modest-account-view-window.c:
3480 (on_delete_button_clicked), (on_edit_button_clicked),
3481 (on_new_button_clicked): Use the new functions.
3483 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3485 * src/modest-account-mgr-helpers.c:
3486 (modest_account_mgr_set_first_account_as_default):
3487 Sort the list of names alphabetically-by-title, so we choose the first one
3489 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3490 alphabetically by the title.
3492 This fixes projects.maemo.org bug NB#56418 .
3494 * src/modest-account-mgr-priv.c:
3495 (_modest_account_mgr_account_from_key):
3496 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3497 avoid a valgrind error, and possible random behaviour.
3499 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3501 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3502 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3503 tinymail documentation to say that this can be expected.
3504 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3505 pretty, and should not happen, but I would prefer to know when it does.
3507 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3509 * configure.ac: When using the older hildon version, probably on Bora,
3510 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3512 * src/widgets/modest-attachment-view.c:
3513 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3516 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3518 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3519 Implemented the prototype. Can be tested with
3520 tests/dbus_api/test_open_message:
3522 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3524 * src/modest-tny-account-store.c:
3525 (modest_tny_account_store_instance_init), (get_password):
3526 * src/modest-ui-actions.c:
3527 (modest_ui_actions_on_password_requested):
3528 Do not store the password in gconf, because this function is called
3529 for non-remembered passwords. Actually use the cached (in the hash map)
3530 password instead of releasing it.
3531 The password will now not be remembered if it is asked via the protected
3532 password dialog, as per the UI spec.
3534 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3536 * src/modest-defs.h:
3537 * src/modest-account-mgr-helpers.h:
3538 * src/modest-account-mgr-helpers.c:
3539 Added modest_server_account_get_username_has_succeeded(),
3540 modest_server_account_set_username_has_succeeded().
3541 (modest_server_account_set_username),
3542 Reset the has-succeeded flag if the username changes.
3544 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3545 * src/maemo/modest-connection-specific-smtp-window.c:
3546 (modest_connection_specific_smtp_window_save_server_accounts):
3547 Use modest_server_account_set_username() instead of using
3548 modest_conf_set_string() directly, so that the has-succeeded flag is always
3551 * src/modest-ui-actions.c:
3552 (modest_ui_actions_on_password_requested): Dim the username entry if
3553 the username has ever worked, as per the UI spec.
3555 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3557 * src/modest-tny-account-store.c: (get_password):
3558 * src/modest-ui-actions.c:
3559 (modest_ui_actions_on_password_requested):
3560 Allow the username to be changed too, though there is more work to
3561 be done on exactly how this behaves.
3563 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3565 * src/modest-account-mgr-helpers.h:
3566 * src/modest-account-mgr-helpers.c:
3567 Added modest_account_mgr_get_display_name(),
3568 modest_server_account_get_username(),
3569 modest_server_account_set_username(),
3570 modest_server_account_set_password(),
3571 modest_server_account_get_hostname() functions so we do not need to
3572 use the conf API directly.
3574 * src/maemo/modest-main-window.c: (connect_signals):
3575 Actually connect ot the ModestAccountStore::request-password signal,
3576 so that we show the dialog when the password is requested by Tinymail,
3577 for isntance if it is empty.
3579 * src/modest-marshal.list:
3580 * src/modest-tny-account-store.c:
3581 (modest_tny_account_store_class_init), (get_password),
3582 (modest_tny_account_store_alert):
3583 * src/modest-tny-account-store.h:
3584 * src/modest-ui-actions.h:
3585 * src/modest-ui-actions.c:
3586 (modest_ui_actions_on_password_requested):
3587 Change the signal parameters, so it is obvious that we are providing
3588 the non human-readable server name, and receiving both the username
3589 and password, though changing of the username is not yet implemented.
3590 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3591 for the GNOME version.
3593 This should fix the projects.maemo.org bug NB#56209, though it does not
3594 work on Bora, because the gconf_client_get() for the password fails
3595 immediately after we save it with gconf_client_set().
3597 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3600 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3601 caused an undefined symbol error:
3602 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3604 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3606 * src/modest-tny-account-store.c:
3607 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3608 using a GError instead of a string message, so we can translate it in
3611 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3613 * src/maemo/modest-address-book.c:
3614 (modest_address_book_check_names):
3615 * src/maemo/modest-msg-view-window.c:
3616 (modest_msg_view_window_clipboard_owner_change):
3617 * src/modest-init.c: (modest_init_init_ui):
3618 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3619 (update_folders_cb), (modest_mail_operation_update_account):
3620 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3621 (modest_ui_actions_on_msg_attachment_clicked),
3622 (modest_ui_actions_on_msg_recpt_activated):
3623 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3624 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3625 (modest_msg_view_search_next):
3626 * src/widgets/modest-recpt-editor.c:
3627 (modest_recpt_editor_on_button_release_event),
3628 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3629 g_message(). At this point we should only be seeing interesting errors on
3630 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3632 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3634 (modest_wizard_dialog_force_title_update):
3635 * src/maemo/easysetup/modest-wizard-dialog.h:
3636 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3637 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3638 can update the title when appropriate. Otherwise the title is wrong if the
3639 pages are added after adding the notebook to the dialog.
3640 This must be a problem in HildonWizardDialog too.
3641 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3643 * src/maemo/easysetup/modest-easysetup-wizard.c:
3644 (create_subsequent_customsetup_pages),
3645 (create_subsequent_easysetup_pages):
3646 Call modest_wizard_dialog_force_title_update() so that the title is
3647 correct even with GTK+ < 2.10.
3648 This fixes projects.maemo.org bug NB#56145 .
3650 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3652 * src/maemo/modest-platform.c:
3653 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3654 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3657 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3659 * src/widgets/modest-window.h:
3660 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3661 and modest_window_save_state(), which invokes it.
3663 * src/widgets/modest-window-mgr.h:
3664 * src/widgets/modest-window-mgr.c:
3665 Added modest_window_mgr_save_state_for_all_windows(), which calls
3666 the save_state vfunc on all registered windows, if implemented.
3668 * src/gnome/modest-msg-edit-window.c:
3669 * src/gnome/modest-msg-view-window.c:
3670 * src/maemo/modest-msg-edit-window.c:
3671 * src/maemo/modest-msg-view-window.c:
3672 * src/maemo/modest-main-window.c:
3673 Specify the existing save_settings functions as implementations of
3674 ModestWindow::save_state_func().
3676 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3677 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3678 enabling hibernation, for instance.
3680 We may need to do the same thing for restoring settings.
3683 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3685 * src/widgets/modest-window-mgr.c:
3686 * src/widgets/modest-window-mgr.h:
3687 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3688 modest_window_mgr_get_hibernation_is_prevented().
3690 * src/maemo/modest-main-window.c:
3691 (on_hildon_program_is_topmost_notify): Prevent hibernation
3692 (possible when the application goes to the background in the WM),
3693 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3695 * src/maemo/easysetup/modest-easysetup-wizard.c:
3696 (modest_easysetup_wizard_dialog_init):
3697 * src/maemo/modest-account-settings-dialog.c:
3698 (modest_account_settings_dialog_init):
3699 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3700 (modest_connection_specific_smtp_edit_window_init):
3701 * src/maemo/modest-connection-specific-smtp-window.c:
3702 (modest_connection_specific_smtp_window_init):
3703 * src/maemo/modest-signature-editor-dialog.c:
3704 (modest_signature_editor_dialog_init):
3705 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3706 prevent hibernation while any of these account settings dialogs are open.
3708 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3710 * src/maemo/Makefile.am:
3711 * src/maemo/modest-osso-state-saving.c:
3712 * src/maemo/modest-osso-state-saving.h: Added
3713 modest_osso_load_state() and modest_osso_save_state() though they do
3714 nothing now. They should iterate through all the open windows and load/save
3716 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3717 save state when closing.
3719 * src/maemo/modest-main-window.c:
3720 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3721 Add a notification handler for the HildonProgram::is-topmost property,
3722 so we can allow hibernation when the application goes into the background.
3723 But we still need to detect when the accounts setup windows are open so
3724 we can stop hibernation when they are open.
3725 To do this, I also added the main window the HildonProgram. This might have
3726 other side-effects/benefits, and should maybe be done for other windows.
3728 * src/maemo/modest-osso-autosave-callbacks.h:
3729 * src/maemo/modest-osso-autosave-callbacks.c:
3730 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3731 though it does not do anything yet, and we might never need this to do
3732 anything. For instance, we already save drafts.
3734 * src/maemo/modest-platform.c: (modest_platform_init):
3735 Specify the libosso auto-save callback.
3737 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3739 * src/maemo/modest-platform.c:
3740 (modest_platform_set_update_interval):
3741 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3742 aparently stays valid between application instances, so we can use this
3743 to remove and reset it later. According to a maemo-developers email from
3746 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3748 * configure.ac: Depend on libalarm for Maemo.
3750 * src/dbus_api/modest-dbus-api.h:
3751 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3752 (on_send_receive), (modest_dbus_req_handler):
3753 Handle a SEND_RECEIVE D-Bus method.
3755 * libmodest-dbus-client/libmodest-dbus-client.c:
3756 (libmodest_dbus_client_send_and_receive):
3757 * libmodest-dbus-client/libmodest-dbus-client.h:
3758 Add C convenience functions for calling the new D-Bus method.
3760 * src/modest-platform.h:
3761 * src/gnome/modest-platform.c:
3762 * src/maemo/modest-platform.c:
3763 Added modest_platform_set_update_interval(), which uses the
3764 alarmd API on Maemo.
3765 (modest_platform_init),
3766 Call modest_platform_set_update_interval(), using a hard-coded
3767 interval for now (until the global settings dialog is implemented),
3768 though I am not sure that this makes sense yet.
3770 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3772 * src/dbus_api/modest-dbus-callbacks.c:
3773 (modest_osso_cb_hw_state_handler):
3774 * src/dbus_api/modest-dbus-callbacks.h:
3775 * src/maemo/modest-platform.c: (modest_platform_init):
3776 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3777 in case this has some effect on the ability for Maemo to ping the
3780 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3782 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3783 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3784 warning. It is probably a logic error, but I need to fix the build.
3786 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3788 * src/modest-account-mgr.h:
3789 * src/modest-account-mgr.c:
3790 (modest_account_mgr_account_names): Add a gboolean enabled_only
3791 parameter, so we can get lists of onlt the enabled accounts.
3793 (modest_account_mgr_add_account),,
3794 (modest_account_mgr_account_with_display_name_exists):
3795 * src/maemo/modest-msg-edit-window.c: (get_transports):
3796 * src/modest-account-mgr-helpers.c:
3797 (modest_account_mgr_set_first_account_as_default):
3798 * src/modest-init.c: (init_default_account_maybe):
3799 * src/modest-tny-account-store.c: (get_accounts):
3800 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3801 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3802 * tests/check_account-mgr.c: (START_TEST):
3803 Provide the extra parameter, as appropriate.
3805 * src/widgets/modest-account-view.c: (update_account_view):
3806 Do not show disabled accounts (meaning that there is no way to
3807 enable/disable accounts in the UI (the feature is not in our UI
3808 specification), so we can use this internally only to mark unfinished
3809 or temporary account data.
3811 * src/maemo/easysetup/modest-easysetup-wizard.c:
3812 (create_account): Add boolean enable parameter, so we can specify FALSE
3813 to create the temporary account.
3814 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3815 (on_before_next): When finishing, when there is a temporary account, just
3817 Also, use a timeout to delay the showing of the dialog until gconf is likely
3818 to return correct information, due to a maemo gconf bug that is fixed in
3819 osso 1.1, but not yet in Bora.
3820 However, the dialog stays on screen after it is destroyed.
3822 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3823 for invalid data when cancelling. Use a hildon note instead of a dialog
3824 to complain about invalid data. Do not show the account-saved note if the
3825 account is disabled (a temporary account that will not really be saved for use
3828 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3830 * src/modest-account-mgr-helpers.h:
3831 * src/modest-account-mgr-helpers.c:
3832 Added modest_account_mgr_unset_default_account(),
3833 Added modest_account_mgr_set_first_account_as_default().
3835 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3836 If it was the default account, unset the default account name.
3838 * src/maemo/modest-account-view-window.c:
3839 (on_delete_button_clicked): If it was the default account,
3840 set the first remaining account as the default instead.
3842 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3843 a NULL account or a NULL default account, to prevent a crash. This should
3844 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3847 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3849 * src/widgets/modest-recpt-editor.c:
3850 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3851 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3852 TODO comment for this. This fixes the build.
3854 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3855 be the best place for it. This will in future update all auto-update accounts,
3856 rather than just the current/default account, when that gconf key exists.
3857 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3858 if there are no accounts, before calling do_send_receive().
3859 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3861 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3862 * src/maemo/modest-main-window-ui.h:
3863 * src/maemo/modest-main-window.c: (on_connection_changed),
3864 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3865 directly, becaue the signal handler does more.
3867 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3869 * src/modest-account-mgr-helpers.c:
3870 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3871 for the case that the account does not exist.
3873 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3874 (equivalent to the modest account name) rather than the tinymail account name
3875 (equivalent to the modest account title - human readable) to get the account data.
3876 Check for null account data to prevent the crash, and add a TODO comment saying that
3877 this needs fixing because it is using the server account name instead of the account name.
3879 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3881 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3882 * src/maemo/modest-account-settings-dialog.c: (show_error),
3884 Use hildon_note_new_information() for informative and error messages,
3885 which seems to be expected for Maemo applications (no documentation that I know of
3886 says this). I am surprised that there is no distinction between info and error
3889 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3891 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3892 it is easy to find where this is used.
3894 * src/maemo/easysetup/modest-easysetup-wizard.c:
3895 (create_page_welcome), (create_page_account_details),
3896 (create_page_user_details), (create_page_complete_easysetup),
3897 (create_page_custom_incoming), (create_page_custom_outgoing),
3898 (create_page_complete_custom):
3899 * src/maemo/modest-account-settings-dialog.c:
3900 (create_page_account_details), (create_page_user_details),
3901 (create_page_incoming), (create_page_outgoing):
3902 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3903 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3904 (modest_connection_specific_smtp_edit_window_init):
3905 * src/maemo/modest-connection-specific-smtp-window.c:
3906 (modest_connection_specific_smtp_window_init):
3907 * src/maemo/modest-signature-editor-dialog.c:
3908 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3909 and scrolling policy as per the Email Application Layout Guide, if I have
3912 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3914 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3915 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3916 which were empty, because these vfuncs have been removed from TnyAccountStore.
3917 This fixes the build.
3919 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3921 * src/maemo/modest-main-window.c:
3922 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3923 showing/hiding it. Added TODO because it probably should not be NULL.
3924 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3925 because unnecessary g_warnings() make degugging difficult.
3927 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3929 * src/maemo/modest-msg-edit-window.c:
3930 (modest_msg_edit_window_select_color),
3931 (modest_msg_edit_window_select_background_color): 2 const corrections and
3932 moving 2 #endifs before closing brackets, to fix the build.
3934 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3936 * src/maemo/easysetup/modest-easysetup-wizard.h:
3937 * src/maemo/easysetup/modest-easysetup-wizard.c:
3938 (modest_easysetup_wizard_dialog_finalize),
3939 (on_button_edit_advanced_settings), (create_page_complete_custom),
3940 (on_response), (create_account):
3941 Implement the Advanced Settings edit button, by saving the account information,
3942 for the Advanded Settings dialog to use directly from gconf, and removing it
3943 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3944 Bug #5533 in the projects.maemo.org bugzilla.
3946 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3948 * src/maemo/modest-msg-view-window.c:
3949 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3950 when opening a message window.
3952 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3954 * src/maemo/easysetup/modest-easysetup-wizard.c:
3955 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3958 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3959 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3960 gconf settings. I probably added more checks than necessary, but that is safer.
3962 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3963 variable to fix the build, but this seems to be used when it is still NULL.
3965 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3967 * src/modest-platform.h:
3968 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3969 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3970 * src/modest-main.c: Implement this function so we can avoid using
3971 maemo-specific API from cross-platform code.
3973 * src/modest-tny-account-store.c:
3974 (get_smtp_specific_transport_account_for_open_connection):
3975 * src/modest-ui-actions.c: (check_for_connection),
3976 (modest_ui_actions_on_item_not_found):
3977 Use modest_platform_connect_and_wait() and put #idefs around other
3978 maemo-specific code, because only maemo currently has a way to
3979 identify connection names.
3981 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3983 * src/modest-tny-account-store.h:
3984 * src/modest-tny-account-store.c:
3985 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3986 the connection-specific SMTP server settings in the configuration.
3988 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3990 * src/maemo/modest-main-window.c: (on_connection_changed),
3992 * src/modest-main.c: (main), (start_ui), (send_mail):
3993 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3994 that is what is intended.
3996 * src/modest-ui-actions.c: (action_send), (action_receive),
3997 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3998 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3999 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4000 SMTP server is used when it is specified.
4002 (modest_ui_actions_on_send_receive):
4003 Check that a connection is open before proceeding.
4004 Receive and then send, instead of vice-versa, as per the specification.
4006 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4008 * src/modest-mail-operation.c:
4009 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4010 though I guess it should be something other than NULL.
4012 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4014 * src/maemo/easysetup/modest-easysetup-wizard.c:
4015 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4016 combo twice, to avoid an g_warning and to make it visible again.
4017 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4018 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4019 (already intended) dereference when detaching, because we then recreate the menu.
4020 But I am not sure why the warning was happening, and it is possible that this is a memory
4023 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4025 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4026 and uri_parse_mailto() utility functions.
4027 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4029 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4031 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4033 * src/dbus_api/modest-dbus-api.h:
4034 * src/dbus_api/modest-dbus-callbacks.c:
4035 Use an idle callback to execute the modest code in the application's own thread.
4036 Remove the helloworld example method.
4037 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4038 parsed, and the open-message method is not implemented because this is not yet implemented in
4040 * libmodest-dbus-client/libmodest-dbus-client.c:
4041 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4042 (libmodest_dbus_client_open_message):
4043 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4045 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4046 body without crashing.
4048 * tests/dbus_api/Makefile.am:
4049 * tests/dbus_api/test_mail_to.c:
4050 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4052 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4054 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4055 Added file to fix the build. Sorry.
4057 * src/dbus_api/Makefile.am:
4058 * src/dbus_api/modest-dbus-api.h:
4059 * src/dbus_api/modest-dbus-callbacks.h:
4060 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4061 (modest_dbus_req_handler):
4062 Put constants in a separate header so it can be reused by the
4063 client library, without duplication
4065 * libmodest-dbus-client/Makefile.am:
4066 * libmodest-dbus-client/libmodest-dbus-client.c:
4067 (libmodest_dbus_client_call_helloworld),
4068 (libmodfest_dbus_client_send_mail),
4069 (libmodfest_dbus_client_mailto),
4070 (libmodfest_dbus_client_open_message):
4071 * libmodest-dbus-client/libmodest-dbus-client.h:
4072 (Partly) Implement a send_mail D-Bus method.
4074 * tests/dbus_api/Makefile.am:
4075 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4076 the send_email D-Bus method.
4078 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4082 * libmodest-dbus-client/Makefile.am:
4083 * libmodest-dbus-client/libmodest-dbus-client.c:
4084 * libmodest-dbus-client/libmodest-dbus-client.h:
4085 * tests/dbus_api/Makefile.am:
4086 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4087 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4089 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4091 * src/maemo/easysetup/modest-easysetup-wizard.c:
4092 (create_page_account_details):
4093 * src/maemo/modest-account-settings-dialog.c:
4094 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4095 widgets, because this might not be the default in future versions of the Maemo GTK+.
4096 However, I can not not get capitalization to work even in a simple test case.
4098 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4100 * src/maemo/easysetup/modest-easysetup-wizard.c:
4101 (create_page_custom_incoming), (create_page_custom_outgoing):
4102 * src/maemo/modest-account-settings-dialog.c:
4103 (create_page_account_details), (create_page_incoming),
4104 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4105 instead of using gtk_check_button_with_label(), so they are aligned like the other
4106 widgets, as per the UI spec.
4108 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4110 * src/maemo/easysetup/modest-easysetup-wizard.c:
4111 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4112 * src/widgets/modest-validating-entry.c:
4113 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4114 Modest prefix instead of an EasySetup prefix.
4116 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4118 * src/widgets/modest-validating-entry.h:
4119 * src/widgets/modest-validating-entry.c: (on_insert_text),
4120 Added easysetup_validating_entry_set_max_func(), used to set a callback
4121 to call when the max number of characters is reached. GtkEntry has a max-length
4122 already but is silent about it.
4124 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4125 (create_page_account_details), (create_page_user_details),
4127 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4128 (create_page_account_details), (create_page_user_details),
4129 (create_page_outgoing):
4130 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4131 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4132 the UI spec, when the user tries to enter more than the max number of characters.
4134 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4136 * src/maemo/easysetup/modest-easysetup-wizard.c:
4137 (create_page_user_details), (create_page_custom_incoming),
4138 (create_page_custom_outgoing):
4139 * src/maemo/modest-account-settings-dialog.c:
4140 (create_page_user_details), (create_page_incoming),
4141 (create_page_outgoing):
4142 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4143 (modest_connection_specific_smtp_edit_window_init):
4144 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4145 not appropriate. Bad Maemo-specific defaults!.
4147 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4149 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4150 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4151 (modest_signature_editor_dialog_set_settings):
4152 Disable the label and textview when the checkbox is disabled, and use the
4153 specified (UI spec) default signature text.
4155 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4157 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4158 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4160 * src/modest-defs.h:
4161 * src/modest-account-mgr-helpers.h:
4162 * src/modest-account-mgr-helpers.c:
4163 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4165 * src/maemo/Makefile.am:
4166 * src/maemo/modest-signature-editor-dialog.c:
4167 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4170 * src/maemo/modest-account-settings-dialog.h:
4171 * src/maemo/modest-account-settings-dialog.c:
4172 (modest_account_settings_dialog_finalize), (on_button_signature),
4173 (save_configuration): Use the new dialog when the Edit button is pressed, and
4174 save the changes if necessary, as per the UI spec.
4176 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4178 * src/maemo/Makefile.am:
4179 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4180 based on maemo-develoers email from Dirk.
4182 * src/maemo/easysetup/modest-easysetup-wizard.c:
4183 (create_page_welcome), (create_page_account_details),
4184 (create_page_user_details), (create_page_complete_easysetup),
4185 (create_page_custom_incoming), (create_page_custom_outgoing),
4186 (create_page_complete_custom),
4187 (modest_easysetup_wizard_dialog_init):
4188 * src/maemo/modest-account-settings-dialog.c:
4189 (create_page_account_details), (create_page_user_details),
4190 (create_page_incoming), (create_page_outgoing),
4191 (modest_account_settings_dialog_init):
4192 * src/maemo/modest-connection-specific-smtp-window.c:
4193 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4195 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4197 * src/maemo/easysetup/modest-easysetup-wizard.c:
4198 (create_page_account_details), (create_page_custom_outgoing),
4199 (create_page_complete_custom):
4200 * src/maemo/modest-account-settings-dialog.c:
4201 (create_page_user_details), (create_page_incoming),
4202 (create_page_outgoing):
4203 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4204 (modest_connection_specific_smtp_edit_window_init):
4205 Use the correct (UI spec) port min/max, and use horizontal separators,
4208 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4210 * src/maemo/easysetup/modest-easysetup-wizard.c:
4211 (set_default_custom_servernames):
4212 * src/maemo/modest-account-settings-dialog.c:
4213 (create_page_incoming), (on_combo_outgoing_security_changed),
4214 (on_combo_incoming_security_changed), (create_page_outgoing),
4215 (modest_account_settings_dialog_set_account_name),
4216 (save_configuration):
4217 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4218 (on_combo_security_changed),
4219 (modest_connection_specific_smtp_edit_window_init),
4220 (modest_connection_specific_smtp_edit_window_set_connection),
4221 (modest_connection_specific_smtp_edit_window_get_settings):
4222 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4225 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4228 * src/maemo/easysetup/modest-easysetup-wizard.c:
4229 (create_page_custom_outgoing), (create_page_complete_custom):
4230 * src/maemo/modest-account-settings-dialog.c:
4231 (create_page_user_details), (create_page_outgoing):
4232 * src/maemo/modest-account-view-window.c: (button_box_new):
4233 Use changed logical IDs as per the most recent UI spec:
4234 mcen_bd_emailsetup_edit -> mcen_bd_edit
4235 mcen_bd_emailsetup_delete -> mcen_bd_delete
4236 mcen_bd_emailsetup_close -> mcen_bd_close
4238 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4242 * src/dbus_api/Makefile.am:
4243 * src/dbus_api/modest-dbus-callbacks.c:
4244 * src/dbus_api/modest-dbus-callbacks.h:
4245 * src/maemo/modest-platform.c: (modest_platform_init):
4246 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4248 * tests/Makefile.am:
4249 * tests/dbus_api/Makefile.am:
4250 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4252 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4254 * src/maemo/modest-account-settings-dialog.c:
4255 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4256 Removed unnecessary includes.
4258 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4260 * src/maemo/easysetup/modest-easysetup-wizard.c:
4261 * src/maemo/modest-account-settings-dialog.c:
4262 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4263 * src/widgets/Makefile.am:
4264 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4265 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4266 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4267 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4268 * src/widgets/modest-secureauth-combo-box.c:
4269 * src/widgets/modest-secureauth-combo-box.h:
4270 * src/widgets/modest-serversecurity-combo-box.c:
4271 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4272 made the GObject names more consistent with the rest of the Modest code.
4274 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4276 * src/maemo/easysetup/Makefile.am:
4277 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4278 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4279 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4280 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4281 * src/maemo/easysetup/modest-easysetup-wizard.c:
4282 * src/maemo/easysetup/modest-validating-entry.c:
4283 * src/maemo/easysetup/modest-validating-entry.h:
4284 * src/maemo/modest-account-settings-dialog.c:
4285 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4286 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4287 widgets/ because they are used outside of easysetup too. After checking in,
4288 svn will allow me to rename them too.
4290 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4292 * src/gnome/modest-msg-edit-window.c:
4293 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4294 linker error, to fix the build on the GNOME platform.
4295 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4296 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4297 ifdefed out to avoid a warning.
4299 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4301 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4302 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4303 some alternative for GTK+ 2.6.
4305 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4307 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4309 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4310 specified for EmailAccountsDialog in UI spec.
4312 * src/maemo/easysetup/modest-easysetup-wizard.c:
4313 * src/maemo/easysetup/modest-easysetup-wizard.h:
4314 * src/maemo/modest-account-settings-dialog.c:
4315 * src/maemo/modest-account-settings-dialog.h:
4316 Reuse a member window widget for the connection-specific SMTP server accounts,
4317 so we can tell it to create/save the accounts only if we actually save changes.
4319 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4320 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4321 (modest_connection_specific_smtp_edit_window_get_settings):
4322 Return a struct instance for temporarily remembering the entered data.
4324 * src/maemo/modest-connection-specific-smtp-window.h:
4325 * src/maemo/modest-connection-specific-smtp-window.c:
4326 (modest_connection_specific_smtp_window_finalize),
4327 (modest_connection_specific_smtp_window_fill_with_connections),
4329 (modest_connection_specific_smtp_window_save_server_accounts),
4330 (update_model_server_names): Do not actually save data until asked,
4331 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4333 (on_selection_changed),
4334 (modest_connection_specific_smtp_window_init): Disable the edit
4335 button when nothing is selected.
4337 * src/modest-account-mgr-helpers.c:
4338 * src/modest-account-mgr-helpers.h:
4339 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4342 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4344 * src/modest-account-mgr-helpers.h:
4345 * src/modest-account-mgr-helpers.c:
4346 (modest_account_mgr_get_unused_account_name),
4347 (modest_account_mgr_get_unused_account_display_name): Added these
4348 utility functions, to avoid code duplication.
4350 * src/maemo/easysetup/modest-easysetup-wizard.c:
4351 (create_page_account_details), (create_account):
4352 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4353 (on_combo_security_changed),
4354 (modest_connection_specific_smtp_edit_window_init),
4355 (modest_connection_specific_smtp_edit_window_save_settings):
4356 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4357 * src/maemo/modest-connection-specific-smtp-window.c:
4358 (modest_connection_specific_smtp_window_finalize),
4359 (modest_connection_specific_smtp_window_fill_with_connections),
4360 (on_button_edit), (modest_connection_specific_smtp_window_init):
4361 * src/maemo/modest-connection-specific-smtp-window.h:
4362 Implementing saving of connection-specific server accounts.
4364 But I need to refactor this so we can save the data for each
4365 possible connection-specific account and only actually create the server accounts
4366 when the easysetup finished, or the OK button is pressed on the account settings
4369 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4371 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4372 (on_combo_security_changed):
4373 (modest_connection_specific_smtp_edit_window_init):
4374 Auto-fill the port number as in the account settings.
4376 (modest_connection_specific_smtp_edit_window_set_connection):
4377 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4378 * src/maemo/modest-connection-specific-smtp-window.c:
4379 (fill_with_connections), (on_button_edit),
4380 (modest_connection_specific_smtp_window_init):
4381 Turn the edit window into a dialog to simplify the code, and
4382 set a WM hint as in a GtkDialog, because only a popup can be on top of
4383 another window in Maemo, and popups usually have no WM decoration.
4385 * src/modest-defs.h:
4386 * src/modest-account-mgr-helpers.c:
4387 (modest_account_mgr_set_connection_specific_smtp),
4388 (modest_account_mgr_remove_connection_specific_smtp),
4389 (modest_account_mgr_get_connection_specific_smtp):
4390 * src/modest-account-mgr-helpers.h: Some functions to write the
4391 connection-specific SMTP server information. Not yet used.
4394 * src/widgets/modest-folder-view.c: (text_cell_data):
4395 Fix a warning about an uninitialized variable.
4396 (on_configuration_key_changed): Put an #ifdef around the use
4397 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4399 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4401 * src/maemo/modest-account-settings-dialog.h:
4402 * src/maemo/modest-account-settings-dialog.c:
4403 Added connect_for_modified() utility function to mark the new modified boolean.
4405 (create_page_account_details), (create_page_user_details),
4406 (create_page_incoming), (create_page_outgoing), (on_response),
4407 (modest_account_settings_dialog_init),
4408 (modest_account_settings_dialog_set_account_name):
4409 Only warn about unsaved changes when there are actually unsaved changes.
4411 * src/modest-account-mgr-helpers.c:
4412 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4413 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4414 to get the data from there in future.
4416 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4418 * src/modest-defs.h:
4420 * src/modest-account-mgr-helpers.h:
4421 * src/modest-account-mgr-helpers.c:
4422 Store the security account setting in a single conf key instead of using
4423 the options list, so that the list is left for just the to-be-removed camel hack,
4424 and because gconf_client_set_list() is failing for some reason.
4426 * src/modest-account-mgr.c:
4427 (modest_account_mgr_add_server_account):
4428 * src/maemo/modest-account-settings-dialog.c:
4429 (modest_account_settings_dialog_set_account_name),
4430 (save_configuration): Use the renamed functions.
4433 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4435 * src/widgets/Makefile.am:
4436 * src/widgets/modest-limit-retrieve-combo-box.c:
4437 * src/widgets/modest-limit-retrieve-combo-box.h:
4438 * src/widgets/modest-retrieve-combo-box.c:
4439 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4440 the account settings dialog.
4442 * src/modest-defs.h:
4443 * src/modest-account-mgr-helpers.h:
4444 * src/modest-account-mgr-helpers.c:
4445 (modest_server_account_get_option_secure_auth),
4446 (modest_server_account_set_option_secure_auth):
4447 * src/modest-account-mgr.c:
4448 (modest_account_mgr_add_server_account):
4449 Use the existing AUTH_MECH conf key for the secure-auth setting,
4450 instead of putting it in the list options, because this was actually used already.
4452 * src/maemo/modest-account-settings-dialog.c:
4453 (create_page_account_details),
4454 (modest_account_settings_dialog_set_account_name),
4455 (save_configuration):
4456 * src/maemo/modest-account-settings-dialog.h:
4457 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4458 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4460 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4462 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4463 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4464 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4466 * src/modest-defs.h:
4467 * src/maemo/modest-account-settings-dialog.c:
4468 (create_page_incoming), (on_combo_outgoing_security_changed),
4469 (on_combo_incoming_security_changed), (create_page_outgoing),
4470 (modest_account_settings_dialog_set_account_name),
4471 (save_configuration): Load/Save the port number, and change it when the
4472 security combo changes, to suitable defaults.
4474 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4476 * src/modest-account-mgr.c:
4477 (modest_account_mgr_add_server_account): Set the security and secure-auth
4478 options, and add a comment saying that the other camel-specific options should be
4481 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4483 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4485 * src/modest-tny-account-store.c: (account_list_free),
4486 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4487 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4490 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4492 * src/modest-protocol-info.c:
4493 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4494 is required by our UI spec. Maybe something in our implementation will use this eventually.
4495 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4496 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4497 instead of the previous 0 placeholder.
4499 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4500 secure-auth settings.
4501 * src/modest-account-mgr-helpers.h:
4502 * src/modest-account-mgr-helpers.c:
4503 (modest_server_account_data_get_option_secure_auth),
4504 (modest_server_account_set_option_secure_auth),
4505 (modest_server_account_data_get_option_security),
4506 (modest_server_account_set_option_security): Added this API for getting and setting the security
4507 and secure-auth settings.
4509 * src/maemo/modest-account-settings-dialog.h:
4510 * src/maemo/modest-account-settings-dialog.c:
4511 (modest_account_settings_dialog_finalize), (check_data),
4512 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4513 about changing titles.
4514 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4515 (save_configuration): Save the security and secure-auth settings.
4517 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4518 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4520 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4522 * src/modest-defs.h:
4523 * src/modest-account-mgr.c:
4524 (modest_account_mgr_add_server_account):
4525 Added and used defines for the options key and value pair strings,
4526 that are used so far, though they do not seem to correspond to anything in our
4527 UI specs or ModestProtocol enum.
4529 * src/modest-account-mgr-helpers.h:
4530 * src/modest-account-mgr-helpers.c:
4531 (compare_option_strings_for_name),
4532 (modest_server_account_data_get_option_value),
4533 (modest_server_account_data_get_option_bool),
4534 (modest_account_mgr_get_server_account_option):
4535 Added helper functions for parsing the options GSList.
4537 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4539 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4540 display name is based on the supplied account name.
4541 * src/modest-account-mgr.c:
4542 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4543 with an inefficient, but good-enough, implementation.
4545 * src/maemo/easysetup/modest-easysetup-wizard.c:
4546 (create_page_account_details), (on_before_next), (create_account):
4547 Check for existing display names rather than (non-user-visible) account names, and just
4548 create and set a unique account name at the end.
4550 * src/maemo/modest-account-settings-dialog.c:
4551 (modest_account_settings_dialog_init),
4552 (modest_account_settings_dialog_set_account_name),
4553 (create_page_incoming): Show the display name, instead of the account name.
4554 (on_response): Do some (not all) extra checks, as in the UI spec.
4555 (save_configuration): Save the display name if it was changed.
4557 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4559 * po/en_GB.po: Added needed logical ID and translation.
4560 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4561 (init_view): Made the is-default column clicking work.
4563 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4566 * src/maemo/easysetup/Makefile.am:
4567 * src/maemo/easysetup/modest-easysetup-wizard.c:
4568 (modest_easysetup_wizard_dialog_init):
4569 * src/maemo/easysetup/provider-data-test.keyfile:
4570 * src/maemo/easysetup/provider-data.keyfile:
4571 Moved the provider data file to the new modest-providers-data package and used it from there.
4573 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4575 * src/modest-local-folder-info.c:
4576 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4577 N_() was already used on the static strings, but this just marks it for translation without
4578 using the translation.
4580 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4582 * src/maemo/modest-account-settings-dialog.c:
4583 (create_page_incoming),
4584 (modest_account_settings_dialog_set_account_name):
4585 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4586 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4587 I will do this if nobody else gets there first.
4589 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4591 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4592 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4593 save the security stuff.
4595 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4597 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4598 Set the email address and user fullname, which I now see must be
4601 * src/maemo/modest-account-settings-dialog.h:
4602 * src/maemo/modest-account-settings-dialog.c:
4604 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4605 leave-on-server and authentication.
4606 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4609 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4612 * src/maemo/modest-account-settings-dialog.c:
4613 * src/maemo/modest-account-settings-dialog.h:
4614 Most (but not all) of the widgets are now present as specified by the UI spec.
4615 No changes are yet saved, and some details are not properly shown yet.
4617 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4619 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4621 * src/maemo/Makefile.am:
4622 * src/maemo/modest-account-settings-dialog.c:
4623 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4624 an existing account. Doesn't do much yet.
4626 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4627 Open the accounts settings dialog when Edit is clicked.
4629 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4631 * src/maemo/easysetup/Makefile.am:
4632 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4634 * src/maemo/easysetup/modest-easysetup-wizard.c:
4635 (modest_easysetup_wizard_dialog_init):
4636 Try to get the source directory from the build system,
4637 instead of hard-coding "./" into the source code, when opening our local
4638 copies of the configuration files.
4639 But this still fails when opening the wizard from the Accounts window,
4640 maybe because the working directory seems to change at runtime.
4641 So the wizard will fail the second time unless you copy the files into their
4642 proper locations - see the stdout warnings for the paths.
4644 (create_page_account_details),(on_before_next):
4645 Check for existing non-server accounts instead of server accounts,
4646 so the default account name is useful again, and to prevent trying to
4649 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4650 Show the wizard when New is clicked.
4652 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4653 (init_view): Show the column headers, and show the columns that are
4654 specified in the UI specs. However, something in Maemo's GTK+ prevents
4655 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4656 change the default account. This is despite unsetting the special properties.
4658 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4660 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4661 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4662 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4663 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4664 to make that clearer.
4665 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4667 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4669 * src/maemo/modest-account-view-window.c:
4670 (modest_account_view_window_init),
4671 (modest_account_view_window_new):
4672 Use the same buttons as specified in the
4673 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4674 the existing widgets, which never had a chance of working.
4675 Put the ModestAccountView treeview in a scrolled window.
4676 Do not repeat the initialization in both _init() and _new().
4678 * src/widgets/modest-account-view.c: (update_account_view):
4679 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4680 this widget and window shows no accounts.
4682 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4684 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4686 * src/maemo/easysetup/modest-easysetup-wizard.c:
4687 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4688 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4689 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4692 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4693 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4694 accounts exist yet, as in the UI spec.
4696 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4698 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4700 * src/maemo/Makefile.am:
4701 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4702 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4703 New window for editing connection-specific smtp details.
4704 Not fully implemented.
4706 * src/maemo/modest-connection-specific-smtp-window.c:
4707 (modest_connection_specific_smtp_window_finalize) :
4708 unref the tree model.
4709 (on_button_edit): Show the edit window.
4711 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4713 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4716 * src/maemo/Makefile.am:
4717 * src/maemo/modest-connection-specific-smtp-window.c:
4718 * src/maemo/modest-connection-specific-smtp-window.h:
4719 New window for showing the list of connections, for connection-specific
4720 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4721 * src/maemo/easysetup/modest-easysetup-wizard.c:
4722 (create_page_custom_outgoing): Show the new window when the button is clicked.
4724 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4726 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4727 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4728 * src/maemo/modest-msg-edit-window.c:
4729 (modest_msg_edit_window_insert_image):
4730 * src/modest-conf.c: (modest_conf_key_escape):
4731 * src/modest-mail-operation.c:
4732 (modest_mail_operation_send_new_mail):
4733 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4734 (modest_ui_actions_on_new_account):
4735 * src/widgets/modest-attachment-view.c: (update_filename_request):
4736 * src/widgets/modest-mail-header-view.c:
4737 Corrected warnings that were breaking the build, by commenting out unused variables,
4738 and a function, and by including a header.
4740 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4742 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4743 so we can #ifdef around platform-specific code when necessary.
4744 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4745 to allow this to build for the GNOME platform too.
4747 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4749 * src/maemo/easysetup/modest-easysetup-wizard.c:
4750 Added util_increment_name() and used it in create_page_account_details()
4751 to make sure that the default account name is always a new name.
4753 (modest_easysetup_wizard_dialog_init),
4754 (set_default_custom_servernames): Some minor memory management fixes.
4756 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4760 * src/modest-runtime.c: (init_i18n): Restored the translation
4761 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4762 are defined in config.h, and the translations are installed.
4764 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4765 is defined for translation.
4767 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4769 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4771 * src/maemo/easysetup/modest-easysetup-wizard.c:
4772 (modest_easysetup_wizard_dialog_init):
4773 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4774 Use realistic paths (though they should use $prefix generically) to the
4775 mcc_mapping and provider-data.keyfile files which might work when they
4776 are installed by the future version of the operator-wizard package,
4777 and then fallback to paths in our source code, with an explanatory
4780 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4784 * src/maemo/Makefile.am:
4785 * src/maemo/easysetup/: Added files from the previously-exernal
4786 osso-modest-easysetup.
4787 * src/maemo/modest-main-window-ui.h:
4788 * src/modest-ui-actions.c:
4789 * src/modest-ui-actions.h:
4790 Added modest_ui_actions_on_new_account() as a signal handler for the
4791 New Account menu item. It shows the easysetup wizard.
4792 * po/en_GB.po: Added additional needed logical IDs and translations.