1 2007-06-01 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (recreate_all_accounts),
4 (get_cached_accounts), (get_server_accounts): Do more sensible
5 ref-counting of the temporarily-cached outbox accounts list. This seems
6 to fix a crash when entering the password when the password was wrong.
8 2007-06-01 Murray Cumming <murrayc@murrayc.com>
10 * src/gnome/modest-main-window.c: (connect_signals):
11 * src/modest-tny-account-store.c: (get_password),
12 (modest_tny_account_store_alert): Added comments and clues and
13 commented-out code about how we currently fail to deal with connection
14 errors and wrong passwords, and how we should.
16 2007-06-01 Murray Cumming <murrayc@murrayc.com>
18 * src/widgets/modest-retrieve-combo-box.c:
19 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
20 This fixes projects.maemo.org bug NB#58472 .
22 2007-06-01 Murray Cumming <murrayc@murrayc.com>
24 * src/maemo/easysetup/modest-easysetup-wizard.c:
25 (create_page_complete_easysetup):
26 (create_page_complete_custom): Correct the last commit,
27 putting the correct sentences in the correct pages.
29 2007-06-01 Murray Cumming <murrayc@murrayc.com>
31 * src/maemo/easysetup/modest-easysetup-wizard.c:
32 (create_page_complete_custom): Show the second sentence of text
33 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
36 2007-06-01 Murray Cumming <murrayc@murrayc.com>
38 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
39 Set the leave-on-server conf key by default. This fixes
40 projects.maemo.org bug NB#59258 .
42 2007-06-01 Murray Cumming <murrayc@murrayc.com>
44 * src/maemo/modest-account-view-window.c:
45 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
46 logical ID for the confirmation messages. Fixed projects.maemo.org bug
49 2007-06-01 Murray Cumming <murrayc@murrayc.com>
51 * src/maemo/easysetup/modest-easysetup-wizard.c:
52 (create_caption_new_with_asterisk):
53 * src/maemo/modest-account-settings-dialog.c:
54 (create_caption_new_with_asterisk):
55 Uncomment the code to add the asterisk, because they are no longer in the
56 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
57 (update_incoming_server_title): Add an asterisk here too.
59 2007-06-01 Murray Cumming <murrayc@murrayc.com>
61 * src/maemo/modest-maemo-global-settings-dialog.c:
62 (current_connection): Check that we are even connected before trying to
63 get the current connection name, to prevent a warning.
65 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
66 Change the comments because tny_maemo_conic_device_connect() is now meant to
68 * src/modest-mail-operation.c:
69 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
70 make sure we have a connection and fail if we can't connect.
72 2007-05-31 Murray Cumming <murrayc@murrayc.com>
74 * src/maemo/modest-main-window.c:
75 (on_account_store_connecting_finished): Do not try to get the
76 connection ID if we are not really connected. I am surprised that
77 this signal handler is called when we are not connected.
79 2007-05-31 Murray Cumming <murrayc@murrayc.com>
82 * src/modest-ui-actions.c:
83 (modest_ui_actions_get_msgs_full_error_handler):
84 Renamed an enum, added comments, added an enum
85 for retrieve-limit errors.
87 * src/modest-mail-operation.c: (foreach_add_item),
88 (internal_folder_observer_update), (update_account_thread),
89 (modest_mail_operation_get_msgs_full):
90 (modest_mail_operation_update_account),
91 Added comments about how this works, and some code that should
92 (but does not) check the retrieve-limit. See the TODO comment.
94 2007-05-31 Murray Cumming <murrayc@murrayc.com>
96 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
97 Initialize help_id to fix the build. Warnings are good.
99 2007-05-31 Murray Cumming <murrayc@murrayc.com>
101 * src/widgets/modest-hbox-cell-renderer.c:
102 (modest_hbox_cell_renderer_append):
103 * src/widgets/modest-vbox-cell-renderer.c:
104 (modest_vbox_cell_renderer_append):
105 Fix the last commit by doing an extra ref.
107 2007-05-31 Murray Cumming <murrayc@murrayc.com>
109 * src/widgets/modest-hbox-cell-renderer.c:
110 (modest_hbox_cell_renderer_append):
111 * src/widgets/modest-vbox-cell-renderer.c:
112 (modest_vbox_cell_renderer_append):
113 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
114 to fix the build with Maemo Bora.
115 However, there seems to be a remaining crash, probably due to reference
118 2007-05-30 Murray Cumming <murrayc@murrayc.com>
120 * src/modest-tny-account.c:
121 (modest_tny_account_new_for_local_folders):
122 Use hildon_file_system_info_async_new() to get a better name for
123 the memory card account, setting it as the account name.
124 The timing seems to work, but this is probably
125 not the best place to do this. See the TODO comment.
126 * src/maemo/modest-main-window.c: (create_details_widget):
127 * src/widgets/modest-folder-view.c: (text_cell_data):
128 Use the tny account name instead of hardcoding a name.
130 2007-05-30 Christian Kellner <ckellner@openismus.com>
132 * src/modest-search.c: (modest_search):
133 Correctly set part_search_func even if we have already parsed
134 the query and thus a valid OgsTextSearcher object.
136 2007-05-30 Christian Kellner <ckellner@openismus.com>
139 Search and check for libogs.
142 Incooparte the ogs build env.
144 * src/modest-mime-part-search-stream.c:
145 * src/modest-mime-part-search-stream.h:
146 Removed since we do the real searching now in modest-search.c.
148 * src/modest-search.c:
149 * src/modest-search.h:
150 Implement support for ogs. We use that if available and requested
151 and fall back to modest_text_utils_utf8_strcmp (). The search logic
152 should now handle the corner case when the search term is spread
153 across multiple reads.
154 Also the logic in modest_search () was corrected to search all
155 requested fields until one is found.
157 2007-05-30 Murray Cumming <murrayc@murrayc.com>
159 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
162 * src/modest-init.c: Made modest_init_local_folders() take a
163 path and be public so we can iniitialize maildir folders on
166 * src/modest-local-folder-info.h:
167 * src/modest-local-folder-info.c:
168 (modest_local_folder_info_get_maildir_path): Add a path parameter.
170 * src/modest-tny-account.c:
171 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
172 still means the standard local-folders path on the local volume.
174 * src/modest-tny-account-store.c:
175 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
176 signal so we can detect mount/unmount of the MMC1 card, and do an update of
177 all accounts when that happens.
178 (get_server_accounts): If the MMC1 card is mounted, create a store account for
179 this too, so it shows up in the treeview.
181 2007-05-28 Murray Cumming <murrayc@murrayc.com>
183 * src/maemo/modest-maemo-global-settings-dialog.c:
184 (current_connection):
185 * src/widgets/modest-global-settings-dialog.c:
186 (current_connection_default):
187 Use the enum values instead of 0, 1 and -1,
188 to make the code clearer.
190 * src/modest-account-mgr-helpers.c:
191 (modest_account_mgr_get_connection_specific_smtp): Make this code
194 * src/modest-runtime.h:
195 * src/modest-runtime.c:
196 Added modest_runtime_remove_all_send_queues().
197 * src/maemo/modest-main-window.c:
198 (on_account_store_connecting_finished): Recreate the send queues,
199 using the appropriate transport accounts for this new connection.
200 Some futher adapting might be needed if the old send queues are not
201 automatically stopped at this point.
203 * src/modest-tny-account-store.c: (get_server_accounts):
204 Create the connection-specific transport accounts, so that they can
205 be found later by their ID.
207 * src/modest-tny-account.h:
208 * src/modest-tny-account.c:
209 Added modest_tny_account_new_from_server_account_name().
210 modest_tny_account_new_from_server_account(): Do not create the
211 send queues here, because they will be
212 recreated anyway when the connection changes for the first time.
214 2007-05-28 Murray Cumming <murrayc@murrayc.com>
216 * src/modest-local-folder-info.h:
217 * src/modest-local-folder-info.c:
218 (modest_per_account_local_outbox_folder_info_get_maildir_path),
219 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
220 tbox_folder): Take a modest account name instead of a server TnyAccount,
221 so we can have per-modest-account rather than per-transport-account
223 We must make sure that we change or recreate the exisitng send queues
224 when the connection changes for connection-specific transport accounts.
226 * src/modest-tny-account-store.c:
227 (create_per_account_local_outbox_folders): Create outboxed per modest
228 account, not per transport account.
230 * src/modest-tny-account.h:
231 * src/modest-tny-account.c:
232 (modest_tny_account_get_special_folder): For outboxes, get the
233 parent modest account name. The account is ignored for other folders.
234 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
235 modest account name rather than a server TnyAccount.
237 2007-05-25 Murray Cumming <murrayc@murrayc.com>
239 * src/modest-tny-account.c:
240 (modest_tny_account_new_from_server_account):
241 Call modest_runtime_get_send_queue() immediately after creating transport
242 accounts, so that they start trying to send email from the outbox as soon
243 as possible at startup. This is probably what we want.
245 * src/modest-mail-operation.c: (update_account_thread):
246 * src/modest-runtime.c: (modest_runtime_get_send_queue):
247 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
248 * src/modest-tny-send-queue.h:
249 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
250 (modest_ui_actions_on_send):
251 Added comments about how sending works, though it needs some more work.
253 2007-05-25 Murray Cumming <murrayc@murrayc.com>
255 * src/modest-tny-account.c:
256 (modest_tny_account_get_special_folder): Add TODO because this fails when
258 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
259 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
260 Do not try to show this window when there is no active account. The UI
261 specs does not tell us what to do in this case.
263 2007-05-24 Murray Cumming <murrayc@murrayc.com>
267 * src/maemo/Makefile.am:
268 * src/widgets/Makefile.am: Some dist fixes.
270 2007-05-24 Murray Cumming <murrayc@murrayc.com>
272 * src/maemo/modest-connection-specific-smtp-window.c:
273 (on_button_edit): Make the code clearer, to prevent a double free.
275 2007-05-24 Murray Cumming <murrayc@murrayc.com>
277 * src/maemo/modest-account-settings-dialog.c:
278 (modest_account_settings_dialog_set_account_name),
279 Check the connection-specific smtp servers checkbox if there are any.
281 * src/maemo/modest-connection-specific-smtp-edit-window.c:
282 (modest_connection_specific_smtp_edit_window_init):
283 Start with a suitable port number.
285 * src/modest-account-mgr-helpers.h:
286 * src/modest-account-mgr-helpers.c: Added
287 modest_account_mgr_get_has_connection_specific_smtp().
289 (modest_account_mgr_set_connection_specific_smtp),
290 (modest_account_mgr_remove_connection_specific_smtp),
291 (modest_account_mgr_get_has_connection_specific_smtp),
292 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
293 connection-specific smtp server accounts in the account, rather than
294 the server account conf dir.
296 This fixes bug projects.maemo.org bug NB#58263 .
298 * src/modest-tny-account-store.c:
299 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
300 if there are no server accounts yet, to prevent an infinite loop when there
301 are no accounts. Document that one must be called before the other.
303 2007-05-24 Murray Cumming <murrayc@murrayc.com>
305 * src/modest-account-mgr-helpers.c:
306 (modest_account_mgr_get_default_account): Make sure that at least
307 one account is always the default, if there are any enabled accounts.
308 This is just a sanity check that shouldn't be necessary.
310 * src/modest-account-mgr-priv.c:
311 (_modest_account_mgr_account_from_key): Unescape the conf key to
312 get the real account name. For instance, this is an issue if a space
313 was in the account name, which can happen because the account name
314 is generated from the display name.
315 (_modest_account_mgr_get_account_keyname): Always escape the
317 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
318 Unescape the conf keys to get the real account names.
320 For instance, previously the is-default radio button in the accounts
321 list was not checked for any accounts at first. This fixes that,
322 and might fix several similar bugs.
324 2007-05-23 Murray Cumming <murrayc@murrayc.com>
326 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
327 Removed some debug printfs.
329 2007-05-23 Murray Cumming <murrayc@murrayc.com>
331 Modest on-disk outbox directories are now here, for instance:
332 $HOME/.modest/outboxes/<account-id-1>/outbox
333 $HOME/.modest/outboxes/<account-id-2>/outbox
335 $HOME/.modest/local-folders/outbox
336 so we can have a separate outbox for each account.
337 But they are shown as one outbox in the GtkTreeView, by using a
338 TnyMergeFolder in a ModestTnySimpleFolderStore.
341 * src/modest-tny-simple-folder-store.c:
342 * src/modest-tny-simple-folder-store.h:
343 Added ModestTnySimpleFolderStore, used to contain folders from
344 other folder stores, such as other accounts.
346 * src/modest-tny-outbox-account.h:
347 * src/modest-tny-outbox-account.c:
348 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
349 used for the per-account local outbox folders.
351 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
352 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
353 only use this (internally) now for the non-outbox local folders.
356 * src/modest-init.c: Added modest_init_one_local_folder(), for
357 setting up the directory structure for each local folder.
359 * src/modest-local-folder-info.c:
360 (modest_per_account_local_outbox_folder_info_get_maildir_path),
361 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
363 * src/modest-local-folder-info.h:
364 * src/modest-tny-account-store.c: (on_account_removed),
365 (on_account_changed), (create_per_account_local_outbox_folders),
366 (get_server_accounts), (modest_tny_account_store_get_accounts),
367 (modest_tny_account_store_get_tny_account_by_account),
368 (modest_tny_folder_store_is_virtual_local_folders):
370 * src/modest-tny-account.h:
371 * src/modest-tny-account.c:
372 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
373 to create an on-disk per-account local outbox folder for each
375 (create_per_account_local_outbox_folders): Create a local outbox folder
376 for each transport account.
377 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
378 for all local folders.
380 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
381 instead of using g_object_get/set() directly. It is clearer.
383 (modest_tny_folder_store_get_message_count),
384 (modest_tny_folder_store_get_local_size
385 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
386 because we now use these with non-acount folder stores.
388 (modest_tny_account_get_special_folder),
389 (modest_tny_account_new_from_server_account),
390 (modest_tny_account_new_from_account):
391 (recurse_folders): Adjust to the new outbox system.
393 * src/modest-tny-folder.h:
394 * src/modest-tny-folder.c:
395 (modest_tny_folder_is_local_folder),
396 (modest_tny_folder_get_local_folder_type),
397 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
399 * src/widgets/modest-main-window.h:
400 * src/maemo/modest-main-window.c: (create_details_widget),
401 (modest_main_window_set_contents_style): Show details for any folder store,
404 (modest_tny_folder_get_rules):
405 Remove the const. C does not support constness enough for this.
407 * src/modest-ui-actions.c:
408 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
409 make all outboxes appear as one, in the usual local-folders tree node.
411 (set_active_account_from_tny_account),
412 (modest_ui_actions_on_folder_selection_changed):
413 * src/widgets/modest-folder-view.c: (text_cell_data),
414 (icon_cell_data), (filter_row),
415 (add_account_folders_to_merged_folder),
416 (add_account_folders_to_simple_folder_store), (),
417 (get_cmp_rows_type_pos), (cmp_rows),
418 (modest_folder_view_set_account_id_of_visible_server_account):
419 Adjust to the new outbox system, using generic folder stores and folders
422 2007-05-23 Christian Kellner <ckellner@openismus.com>
424 * src/modest-mail-operation.c:
425 (modest_mail_operation_update_account):
426 Use info->max_size instead of unintialized local var [small
427 build fix]. (Added TODO to review that change since I don't
430 2007-05-23 Marcus Bauer <marcusb@openismus.com>
432 * libmodest-dbus-client/libmodest-dbus-client.c:
433 (libmodest_dbus_client_compose_mail): function added
434 * src/dbus_api/modest-dbus-api.h:
435 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
436 (on_compose_mail): Implementation of the SendAsMail functionality
438 2007-05-22 Murray Cumming <murrayc@murrayc.com>
440 * src/modest-account-mgr.c:
441 (modest_account_mgr_add_server_account): Set the secure-connection
442 conf key for transport accounts as well as store accounts. I don't know
443 why the if was there. For instance, this makes sure that we use SSL
444 for the gmail preset from the easysetup wizard.
446 2007-05-22 Murray Cumming <murrayc@murrayc.com>
448 * src/gnome/modest-main-window.c:
449 (on_account_store_connecting_finished), (connect_signals):
450 * src/maemo/modest-main-window.c:
451 (on_account_store_connecting_finished), (connect_signals),
452 (modest_main_window_new):
453 Handle TnyAccountStore::connecting-finished instead of
454 TnyDevice::connection-changed, because we cannot actually perform
455 operations on accounts until TnyAccountStore has itself responded to
456 the TnyDevice::connection-changed signal. This prevents a GError from
458 Do not try to update at startup, because we (at least on scratchbox)
459 already do an update at startup when the device goes online.
460 This prevents a GError from tinymail.
461 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
462 Added TODO about stopping simultaneous operations.
464 2007-05-21 Murray Cumming <murrayc@murrayc.com>
466 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
467 * src/modest-mail-operation-queue.c:
468 (modest_mail_operation_queue_remove):
469 * src/modest-tny-account-store.c: When GErrors happen, give more clues
470 about where they happened.
472 2007-05-21 Murray Cumming <murrayc@murrayc.com>
474 * src/modest-ui-actions.c:
475 (modest_ui_actions_on_password_requested): Make sure that the remember
476 output parameter is always TRUE.
478 2007-05-21 Murray Cumming <murrayc@murrayc.com>
480 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
481 Show a OK/Cancel dialog if the error is a question, though we still do not
482 know anything more about what we are asking the user.
483 * src/widgets/modest-folder-view.c: (on_drag_data_received):
484 Fix an uninitialized variable (helper). This is a logic error, however.
486 2007-05-21 Christian Kellner <ckellner@openismus.com>
488 * src/modest-search.h:
489 Correct bit shifting in the ModestSearchFlags enum.
491 2007-05-21 Murray Cumming <murrayc@murrayc.com>
493 * src/modest-tny-account.c:
494 (modest_tny_account_new_from_server_account): Do not use the lsub and
495 check-all hard-coded IMAP options when using POP.
497 2007-05-21 Murray Cumming <murrayc@murrayc.com>
499 * src/modest-tny-account.c:
500 (modest_tny_account_new_from_server_account):
501 Use NULL for the secure-auth method for POP when Password auth has been
502 specified by the user, as we already do for IMAP. "auth=Login" causes
503 an error from camel or the server.
505 2007-05-17 Murray Cumming <murrayc@murrayc.com>
507 * src/maemo/modest-account-settings-dialog.c:
508 (create_page_account_details),
509 (modest_account_settings_dialog_set_account_name):
510 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
511 for the leave-on-server checkbox, rathr than just the checkbox, when
512 the protocol is not POP.
514 2007-05-17 Murray Cumming <murrayc@murrayc.com>
516 * src/widgets/modest-account-view.c:
517 * src/widgets/modest-account-view.h:
518 Added modest_account_view_select_account() which will be useful later
519 to asynchronously re-select the edited account.
521 2007-05-17 Murray Cumming <murrayc@murrayc.com>
523 * src/maemo/modest-account-settings-dialog.c:
524 (modest_account_settings_dialog_set_account_name):
525 Automatically choose the port numbers based on the secure authentication
526 methods, if they have not been chosen before.
527 This fixes projects.maemo.org bug NB#56273 .
529 2007-05-17 Murray Cumming <murrayc@murrayc.com>
531 * src/maemo/modest-main-window-ui.h:
532 * src/modest-ui-actions.c:
533 * src/modest-ui-actions.h:
534 Connect the Tools/SMTP Servers menu item to
535 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
536 SMTP servers dialog, as in the UI specification and saves changes when it
537 is closed. This fixed projects.maemo.org bug NB#56305 .
539 2007-05-17 Murray Cumming <murrayc@murrayc.com>
541 * src/maemo/modest-connection-specific-smtp-window.c:
542 (modest_connection_specific_smtp_window_init):
543 Use gtk_window_set_default_size() to make this window big enough, so
544 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
546 2007-05-17 Murray Cumming <murrayc@murrayc.com>
548 * src/maemo/modest-connection-specific-smtp-edit-window.h:
549 * src/maemo/modest-connection-specific-smtp-edit-window.c:
550 (modest_connection_specific_smtp_edit_window_init),
551 Do not try to connect to a combobox signal before the combobox exists.
552 This fixes the cras in projects.maemo.org bug NB#56288 .
553 (modest_connection_specific_smtp_edit_window_get_settings):
554 Remove the server_account_name parameter which was being checked for NULL
555 though it was not used.
557 * src/maemo/modest-connection-specific-smtp-window.c:
558 (modest_connection_specific_smtp_window_fill_with_connections),
559 (on_button_edit), (modest_connection_specific_smtp_window_init):
560 Correct the number of treemodel columns to prevent a warning.
561 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
562 libconic does not work.
564 2007-05-16 Murray Cumming <murrayc@murrayc.com>
566 * src/modest-tny-account.c:
567 (modest_tny_account_new_from_server_account):
568 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
569 SMTP when "None" was chosen by the user. However, with my SMTP server that
570 does not support ANONYMOUS, the emails do not leave the Outbox and I see
573 2007-05-16 Murray Cumming <murrayc@murrayc.com>
575 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
576 to explain the memory management issue with the ID in the ModestPair.
578 * src/gnome/modest-account-assistant.c: (add_receiving_page),
579 (add_sending_page), (modest_account_assistant_finalize):
580 * src/gnome/modest-gnome-global-settings-dialog.c:
581 (create_updating_page), (create_composing_page):
582 * src/gnome/modest-msg-edit-window.c: (get_transports),
583 (init_window), (modest_msg_edit_window_finalize),
584 (modest_msg_edit_window_get_msg_data):
585 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
586 * src/gnome/modest-transport-widget.c:
587 (modest_transport_widget_finalize), (smtp_configuration):
588 * src/maemo/modest-maemo-global-settings-dialog.c:
589 (create_updating_page), (create_composing_page):
590 * src/maemo/modest-msg-edit-window.c: (get_transports),
591 (init_window), (modest_msg_edit_window_finalize),
592 (modest_msg_edit_window_get_msg_data),
593 (modest_msg_edit_window_free_msg_data):
594 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
595 (modest_store_widget_finalize):
596 * src/maemo/modest-transport-widget.c:
597 (modest_transport_widget_finalize), (smtp_configuration):
598 * src/modest-main.c: (send_mail):
599 * src/widgets/modest-combo-box.h:
600 * src/widgets/modest-global-settings-dialog-priv.h:
601 * src/widgets/modest-global-settings-dialog.c:
602 (modest_global_settings_dialog_finalize):
603 * src/widgets/modest-msg-edit-window.h:
604 Whenever using modest_combo_box_new(), keep the ModestPairList alive
605 as long as the combo box, to prevent use of freed memory for the ID.
607 2007-05-15 Murray Cumming <murrayc@murrayc.com>
609 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
610 get_accounts(), to make this clearer. Do not check for the enabled gconf
611 key, because we do not use this for server accounts (at least, not yet).
612 This allows us to send email again.
614 2007-05-15 Murray Cumming <murrayc@murrayc.com>
616 * src/maemo/modest-platform.c:
617 (on_modest_conf_update_interval_changed), (modest_platform_init):
618 Only respond to this particular key change. All these strcmp()s cannot be
621 2007-05-15 Murray Cumming <murrayc@murrayc.com>
623 * src/maemo/modest-maemo-global-settings-dialog.c:
624 (current_connection): Prevent a crash in scratchbox when
625 ny_maemo_conic_device_get_current_iap_id() returns NULL.
626 * src/maemo/modest-platform.c:
627 (on_modest_conf_update_interval_changed), (modest_platform_init):
628 Get the update interval from gconf and reset it when the gconf key changes.
630 2007-05-15 Murray Cumming <murrayc@murrayc.com>
632 * src/modest-protocol-info.c:
633 * src/modest-protocol-info.h: Adde enum-specific get functions,
634 instead of using a ModestProtocolType enum parameter.
636 * src/gnome/modest-account-assistant.c:
637 * src/gnome/modest-store-widget.c:
638 * src/gnome/modest-store-widget.h:
639 * src/gnome/modest-transport-widget.c:
640 * src/gnome/modest-transport-widget.h:
641 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
642 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
643 * src/maemo/easysetup/modest-easysetup-wizard.c:
644 * src/maemo/modest-account-settings-dialog.c:
645 * src/maemo/modest-account-settings-dialog.h:
646 * src/maemo/modest-store-widget.c:
647 * src/maemo/modest-store-widget.h:
648 * src/maemo/modest-transport-widget.c:
649 * src/maemo/modest-transport-widget.h:
650 * src/modest-account-mgr-helpers.c:
651 * src/modest-account-mgr-helpers.h:
652 * src/modest-account-mgr.c:
653 * src/modest-account-mgr.h:
654 * src/modest-tny-account.c:
655 * src/modest-tny-folder.c:
656 * src/widgets/modest-account-view.c:
657 * src/widgets/modest-retrieve-combo-box.c:
658 * src/widgets/modest-retrieve-combo-box.h:
659 * src/widgets/modest-secureauth-combo-box.c:
660 * src/widgets/modest-serversecurity-combo-box.c:
661 * src/widgets/modest-serversecurity-combo-box.h:
662 * tests/check_account-mgr.c:
663 Use the specific functions, and use the re-renamed enum values for GNOME too.
665 2007-05-15 Murray Cumming <murrayc@murrayc.com>
668 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
669 so we can get the second based on the first.
671 * src/maemo/modest-account-settings-dialog.h:
672 * src/maemo/modest-account-settings-dialog.c:
673 Added get_supported_secure_authentication_methods(), though it is mostly
674 commented-out for now until the necessary API is committed to tinymail.
675 (modest_account_settings_dialog_set_account_name),
676 (save_configuration): Request the supported authentication methods from the
677 server, so we can choose a working method.
679 * src/modest-tny-account-store.h:
680 * src/modest-tny-account-store.c:
681 (modest_tny_account_store_get_session): Rename from
682 tny_account_store_get_session().
684 2007-05-14 Murray Cumming <murrayc@murrayc.com>
686 * src/modest-protocol-info.h: Split the ModestProtocol enum
687 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
688 There was no need to have these unrelated values in one enum.
690 * src/: many files: Adapted to changed enum. This makes the code a bit
691 clearer, and the compiler could catch some errors.
693 2007-05-14 Murray Cumming <murrayc@murrayc.com>
695 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
696 Show the detailed internal camel error message when an error happens
697 during the configuration, so that our testers can give us more clues.
698 For instance, in projects.maemo.org bug NB#56910 .
700 2007-05-14 Murray Cumming <murrayc@murrayc.com>
702 * src/modest-tny-account.c:
703 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
704 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
706 2007-05-14 Murray Cumming <murrayc@murrayc.com>
708 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
709 * src/maemo/modest-account-settings-dialog.c:
710 (modest_account_settings_dialog_set_account_name),
711 (save_configuration): For the incoming secure authentication checkbox,
712 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
713 the UI specification. PLAIN does not seem to be supported for most IMAP
714 servers anyway, and I am not sure what it would mean.
715 However, we probably need to discover which of the secure-authentication
716 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
717 * src/modest-account-mgr-helpers.c:
718 (modest_account_mgr_get_server_account_data):
720 * src/modest-tny-account.c:
721 (modest_tny_account_new_from_server_account):
722 Use tny_account_set_mech() to set secure-authentication methods,
723 with some special-casing for IMAP, based on my observations of how
726 * src/modest-account-mgr-helpers.h:
727 * src/modest-account-mgr.c:
728 * src/modest-defs.h: Comment that the URI is only used for local folders.
730 2007-05-11 Murray Cumming <murrayc@murrayc.com>
732 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
733 parameter const, just to be neat.
734 * src/modest-text-utils.c: (modest_text_utils_inline):
735 End g_strconcat() with NULL, as its documentation says. This is almost
736 certainly the cause of my crash at startup on the device. Interestingly,
737 valgrind doesn't tell us about these errors.
739 2007-05-11 Murray Cumming <murrayc@murrayc.com>
741 * scripts/build-packages: Added more precise comments about how to use
742 this script, though I still get this error:
743 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
744 error building tinymail
746 2007-05-11 Murray Cumming <murrayc@murrayc.com>
748 * src/maemo/modest-main-window.c: (on_account_update):
749 Very slight cleanup, hoping to make it simpler to discover what causes
750 a crash here sometimes.
752 * src/modest-tny-account.c:
753 (modest_tny_account_new_from_server_account): Set the port. Added
754 comments about the options and a TODO comment because I need to find out
755 how to specify the secure authentication method.
757 2007-05-11 Marcus Bauer <marcusb@openismus.com>
759 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
760 changed CFlags paths form modest to libmodest
762 2007-05-10 Murray Cumming <murrayc@murrayc.com>
764 * src/modest-account-mgr-helpers.c:
765 (modest_account_mgr_get_server_account_data),
766 (modest_account_mgr_free_server_account_data):
767 * src/modest-account-mgr-helpers.h:
768 * src/modest-account-mgr.c:
769 (modest_account_mgr_add_server_account):
771 * src/modest-tny-account.c:
772 (modest_tny_account_new_from_server_account):
773 Determine the options for tny_camel_account_add_option() here,
774 based on the settings, rather than storing them directly in gconf.
776 2007-05-10 Murray Cumming <murrayc@murrayc.com>
778 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
779 Show a more friendly error dialog now that we expect (from the tinymail
780 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
782 2007-05-10 Murray Cumming <murrayc@murrayc.com>
784 * src/maemo/modest-main-window.c: (on_account_update): Check that
785 account_name is not NULL, to prevent a crash at startup that I am
786 seeing on the N800. I do wonder why it is NULL.
788 * src/maemo/easysetup/modest-easysetup-wizard.c:
789 (create_page_user_details):
790 * src/maemo/modest-account-settings-dialog.c:
791 (create_page_user_details), (create_page_outgoing):
792 * src/maemo/modest-connection-specific-smtp-edit-window.c:
793 (modest_connection_specific_smtp_edit_window_init):
794 * src/modest-ui-actions.c:
795 (modest_ui_actions_on_password_requested):
796 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
797 might do something useful with the on-screen keyboard.
799 2007-05-10 Murray Cumming <murrayc@murrayc.com>
801 * src/maemo/modest-main-window.c: (on_account_update):
802 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
803 NULL, to avoid lots of warnings. However, it probably should not be NULL.
805 2007-05-09 Murray Cumming <murrayc@murrayc.com>
807 * src/modest-tny-account-store.c: (on_account_changed):
808 Correct the signature of this signal handler.
810 2007-05-09 Murray Cumming <murrayc@murrayc.com>
812 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
813 Show a HildonNote instead of a GtkDialog for Maemo.
815 2007-05-09 Murray Cumming <murrayc@murrayc.com>
817 * src/widgets/modest-account-view.h:
818 * src/widgets/modest-account-view.c: (on_account_changed),
819 (on_account_removed). Added a boolean flag, set/unset by
820 modest_account_view_block_conf_updates(),
821 modest_account_view_unblock_conf_updates() to prevent unnecessary
822 updates, but this is not very useful because the gconf notifications are
823 so delays (maybe only on Maemo Bora).
824 So auto-updating is turned off, and these functions do an explicit
825 update when necessary.
826 However, something else is still doing too much work when adding/removing
827 accounts, probably in another part of the application.
829 * src/maemo/modest-account-view-window.c:
830 (on_delete_button_clicked), (on_edit_button_clicked),
831 (on_new_button_clicked): Use the new functions.
833 2007-05-09 Murray Cumming <murrayc@murrayc.com>
835 * src/modest-account-mgr-helpers.c:
836 (modest_account_mgr_set_first_account_as_default):
837 Sort the list of names alphabetically-by-title, so we choose the first one
839 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
840 alphabetically by the title.
842 This fixes projects.maemo.org bug NB#56418 .
844 * src/modest-account-mgr-priv.c:
845 (_modest_account_mgr_account_from_key):
846 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
847 avoid a valgrind error, and possible random behaviour.
849 2007-05-09 Murray Cumming <murrayc@murrayc.com>
851 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
852 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
853 tinymail documentation to say that this can be expected.
854 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
855 pretty, and should not happen, but I would prefer to know when it does.
857 2007-05-09 Murray Cumming <murrayc@murrayc.com>
859 * configure.ac: When using the older hildon version, probably on Bora,
860 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
862 * src/widgets/modest-attachment-view.c:
863 (modest_attachment_view_set_part_default): Initialize variables, to fix the
866 2007-05-09 Marcus Bauer <marcusb@openismus.com>
868 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
869 Implemented the prototype. Can be tested with
870 tests/dbus_api/test_open_message:
872 2007-05-08 Murray Cumming <murrayc@murrayc.com>
874 * src/modest-tny-account-store.c:
875 (modest_tny_account_store_instance_init), (get_password):
876 * src/modest-ui-actions.c:
877 (modest_ui_actions_on_password_requested):
878 Do not store the password in gconf, because this function is called
879 for non-remembered passwords. Actually use the cached (in the hash map)
880 password instead of releasing it.
881 The password will now not be remembered if it is asked via the protected
882 password dialog, as per the UI spec.
884 2007-05-08 Murray Cumming <murrayc@murrayc.com>
887 * src/modest-account-mgr-helpers.h:
888 * src/modest-account-mgr-helpers.c:
889 Added modest_server_account_get_username_has_succeeded(),
890 modest_server_account_set_username_has_succeeded().
891 (modest_server_account_set_username),
892 Reset the has-succeeded flag if the username changes.
894 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
895 * src/maemo/modest-connection-specific-smtp-window.c:
896 (modest_connection_specific_smtp_window_save_server_accounts):
897 Use modest_server_account_set_username() instead of using
898 modest_conf_set_string() directly, so that the has-succeeded flag is always
901 * src/modest-ui-actions.c:
902 (modest_ui_actions_on_password_requested): Dim the username entry if
903 the username has ever worked, as per the UI spec.
905 2007-05-08 Murray Cumming <murrayc@murrayc.com>
907 * src/modest-tny-account-store.c: (get_password):
908 * src/modest-ui-actions.c:
909 (modest_ui_actions_on_password_requested):
910 Allow the username to be changed too, though there is more work to
911 be done on exactly how this behaves.
913 2007-05-08 Murray Cumming <murrayc@murrayc.com>
915 * src/modest-account-mgr-helpers.h:
916 * src/modest-account-mgr-helpers.c:
917 Added modest_account_mgr_get_display_name(),
918 modest_server_account_get_username(),
919 modest_server_account_set_username(),
920 modest_server_account_set_password(),
921 modest_server_account_get_hostname() functions so we do not need to
922 use the conf API directly.
924 * src/maemo/modest-main-window.c: (connect_signals):
925 Actually connect ot the ModestAccountStore::request-password signal,
926 so that we show the dialog when the password is requested by Tinymail,
927 for isntance if it is empty.
929 * src/modest-marshal.list:
930 * src/modest-tny-account-store.c:
931 (modest_tny_account_store_class_init), (get_password),
932 (modest_tny_account_store_alert):
933 * src/modest-tny-account-store.h:
934 * src/modest-ui-actions.h:
935 * src/modest-ui-actions.c:
936 (modest_ui_actions_on_password_requested):
937 Change the signal parameters, so it is obvious that we are providing
938 the non human-readable server name, and receiving both the username
939 and password, though changing of the username is not yet implemented.
940 Change the dialog UI to match the Maemo UI specifications, with #idfefing
941 for the GNOME version.
943 This should fix the projects.maemo.org bug NB#56209, though it does not
944 work on Bora, because the gconf_client_get() for the password fails
945 immediately after we save it with gconf_client_set().
947 2007-05-08 Murray Cumming <murrayc@murrayc.com>
950 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
951 caused an undefined symbol error:
952 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
954 2007-05-08 Murray Cumming <murrayc@murrayc.com>
956 * src/modest-tny-account-store.c:
957 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
958 using a GError instead of a string message, so we can translate it in
961 2007-05-08 Murray Cumming <murrayc@murrayc.com>
963 * src/maemo/modest-address-book.c:
964 (modest_address_book_check_names):
965 * src/maemo/modest-msg-view-window.c:
966 (modest_msg_view_window_clipboard_owner_change):
967 * src/modest-init.c: (modest_init_init_ui):
968 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
969 (update_folders_cb), (modest_mail_operation_update_account):
970 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
971 (modest_ui_actions_on_msg_attachment_clicked),
972 (modest_ui_actions_on_msg_recpt_activated):
973 * src/widgets/modest-header-view.c: (drag_data_get_cb):
974 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
975 (modest_msg_view_search_next):
976 * src/widgets/modest-recpt-editor.c:
977 (modest_recpt_editor_on_button_release_event),
978 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
979 g_message(). At this point we should only be seeing interesting errors on
980 stdout. Debugging messages could be #ifdefed-out if they are still useful.
982 2007-05-07 Murray Cumming <murrayc@murrayc.com>
984 (modest_wizard_dialog_force_title_update):
985 * src/maemo/easysetup/modest-wizard-dialog.h:
986 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
987 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
988 can update the title when appropriate. Otherwise the title is wrong if the
989 pages are added after adding the notebook to the dialog.
990 This must be a problem in HildonWizardDialog too.
991 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
993 * src/maemo/easysetup/modest-easysetup-wizard.c:
994 (create_subsequent_customsetup_pages),
995 (create_subsequent_easysetup_pages):
996 Call modest_wizard_dialog_force_title_update() so that the title is
997 correct even with GTK+ < 2.10.
998 This fixes projects.maemo.org bug NB#56145 .
1000 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1002 * src/maemo/modest-platform.c:
1003 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1004 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1007 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1009 * src/widgets/modest-window.h:
1010 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1011 and modest_window_save_state(), which invokes it.
1013 * src/widgets/modest-window-mgr.h:
1014 * src/widgets/modest-window-mgr.c:
1015 Added modest_window_mgr_save_state_for_all_windows(), which calls
1016 the save_state vfunc on all registered windows, if implemented.
1018 * src/gnome/modest-msg-edit-window.c:
1019 * src/gnome/modest-msg-view-window.c:
1020 * src/maemo/modest-msg-edit-window.c:
1021 * src/maemo/modest-msg-view-window.c:
1022 * src/maemo/modest-main-window.c:
1023 Specify the existing save_settings functions as implementations of
1024 ModestWindow::save_state_func().
1026 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1027 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1028 enabling hibernation, for instance.
1030 We may need to do the same thing for restoring settings.
1033 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1035 * src/widgets/modest-window-mgr.c:
1036 * src/widgets/modest-window-mgr.h:
1037 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1038 modest_window_mgr_get_hibernation_is_prevented().
1040 * src/maemo/modest-main-window.c:
1041 (on_hildon_program_is_topmost_notify): Prevent hibernation
1042 (possible when the application goes to the background in the WM),
1043 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1045 * src/maemo/easysetup/modest-easysetup-wizard.c:
1046 (modest_easysetup_wizard_dialog_init):
1047 * src/maemo/modest-account-settings-dialog.c:
1048 (modest_account_settings_dialog_init):
1049 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1050 (modest_connection_specific_smtp_edit_window_init):
1051 * src/maemo/modest-connection-specific-smtp-window.c:
1052 (modest_connection_specific_smtp_window_init):
1053 * src/maemo/modest-signature-editor-dialog.c:
1054 (modest_signature_editor_dialog_init):
1055 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1056 prevent hibernation while any of these account settings dialogs are open.
1058 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1060 * src/maemo/Makefile.am:
1061 * src/maemo/modest-osso-state-saving.c:
1062 * src/maemo/modest-osso-state-saving.h: Added
1063 modest_osso_load_state() and modest_osso_save_state() though they do
1064 nothing now. They should iterate through all the open windows and load/save
1066 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1067 save state when closing.
1069 * src/maemo/modest-main-window.c:
1070 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1071 Add a notification handler for the HildonProgram::is-topmost property,
1072 so we can allow hibernation when the application goes into the background.
1073 But we still need to detect when the accounts setup windows are open so
1074 we can stop hibernation when they are open.
1075 To do this, I also added the main window the HildonProgram. This might have
1076 other side-effects/benefits, and should maybe be done for other windows.
1078 * src/maemo/modest-osso-autosave-callbacks.h:
1079 * src/maemo/modest-osso-autosave-callbacks.c:
1080 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1081 though it does not do anything yet, and we might never need this to do
1082 anything. For instance, we already save drafts.
1084 * src/maemo/modest-platform.c: (modest_platform_init):
1085 Specify the libosso auto-save callback.
1087 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1089 * src/maemo/modest-platform.c:
1090 (modest_platform_set_update_interval):
1091 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1092 aparently stays valid between application instances, so we can use this
1093 to remove and reset it later. According to a maemo-developers email from
1096 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1098 * configure.ac: Depend on libalarm for Maemo.
1100 * src/dbus_api/modest-dbus-api.h:
1101 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1102 (on_send_receive), (modest_dbus_req_handler):
1103 Handle a SEND_RECEIVE D-Bus method.
1105 * libmodest-dbus-client/libmodest-dbus-client.c:
1106 (libmodest_dbus_client_send_and_receive):
1107 * libmodest-dbus-client/libmodest-dbus-client.h:
1108 Add C convenience functions for calling the new D-Bus method.
1110 * src/modest-platform.h:
1111 * src/gnome/modest-platform.c:
1112 * src/maemo/modest-platform.c:
1113 Added modest_platform_set_update_interval(), which uses the
1114 alarmd API on Maemo.
1115 (modest_platform_init),
1116 Call modest_platform_set_update_interval(), using a hard-coded
1117 interval for now (until the global settings dialog is implemented),
1118 though I am not sure that this makes sense yet.
1120 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1122 * src/dbus_api/modest-dbus-callbacks.c:
1123 (modest_osso_cb_hw_state_handler):
1124 * src/dbus_api/modest-dbus-callbacks.h:
1125 * src/maemo/modest-platform.c: (modest_platform_init):
1126 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1127 in case this has some effect on the ability for Maemo to ping the
1130 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1132 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1133 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1134 warning. It is probably a logic error, but I need to fix the build.
1136 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1138 * src/modest-account-mgr.h:
1139 * src/modest-account-mgr.c:
1140 (modest_account_mgr_account_names): Add a gboolean enabled_only
1141 parameter, so we can get lists of onlt the enabled accounts.
1143 (modest_account_mgr_add_account),,
1144 (modest_account_mgr_account_with_display_name_exists):
1145 * src/maemo/modest-msg-edit-window.c: (get_transports):
1146 * src/modest-account-mgr-helpers.c:
1147 (modest_account_mgr_set_first_account_as_default):
1148 * src/modest-init.c: (init_default_account_maybe):
1149 * src/modest-tny-account-store.c: (get_accounts):
1150 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1151 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1152 * tests/check_account-mgr.c: (START_TEST):
1153 Provide the extra parameter, as appropriate.
1155 * src/widgets/modest-account-view.c: (update_account_view):
1156 Do not show disabled accounts (meaning that there is no way to
1157 enable/disable accounts in the UI (the feature is not in our UI
1158 specification), so we can use this internally only to mark unfinished
1159 or temporary account data.
1161 * src/maemo/easysetup/modest-easysetup-wizard.c:
1162 (create_account): Add boolean enable parameter, so we can specify FALSE
1163 to create the temporary account.
1164 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1165 (on_before_next): When finishing, when there is a temporary account, just
1167 Also, use a timeout to delay the showing of the dialog until gconf is likely
1168 to return correct information, due to a maemo gconf bug that is fixed in
1169 osso 1.1, but not yet in Bora.
1170 However, the dialog stays on screen after it is destroyed.
1172 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1173 for invalid data when cancelling. Use a hildon note instead of a dialog
1174 to complain about invalid data. Do not show the account-saved note if the
1175 account is disabled (a temporary account that will not really be saved for use
1178 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1180 * src/modest-account-mgr-helpers.h:
1181 * src/modest-account-mgr-helpers.c:
1182 Added modest_account_mgr_unset_default_account(),
1183 Added modest_account_mgr_set_first_account_as_default().
1185 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1186 If it was the default account, unset the default account name.
1188 * src/maemo/modest-account-view-window.c:
1189 (on_delete_button_clicked): If it was the default account,
1190 set the first remaining account as the default instead.
1192 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1193 a NULL account or a NULL default account, to prevent a crash. This should
1194 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1197 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1199 * src/widgets/modest-recpt-editor.c:
1200 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1201 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1202 TODO comment for this. This fixes the build.
1204 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1205 be the best place for it. This will in future update all auto-update accounts,
1206 rather than just the current/default account, when that gconf key exists.
1207 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1208 if there are no accounts, before calling do_send_receive().
1209 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1211 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1212 * src/maemo/modest-main-window-ui.h:
1213 * src/maemo/modest-main-window.c: (on_connection_changed),
1214 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1215 directly, becaue the signal handler does more.
1217 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1219 * src/modest-account-mgr-helpers.c:
1220 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1221 for the case that the account does not exist.
1223 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1224 (equivalent to the modest account name) rather than the tinymail account name
1225 (equivalent to the modest account title - human readable) to get the account data.
1226 Check for null account data to prevent the crash, and add a TODO comment saying that
1227 this needs fixing because it is using the server account name instead of the account name.
1229 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1231 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1232 * src/maemo/modest-account-settings-dialog.c: (show_error),
1234 Use hildon_note_new_information() for informative and error messages,
1235 which seems to be expected for Maemo applications (no documentation that I know of
1236 says this). I am surprised that there is no distinction between info and error
1239 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1241 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1242 it is easy to find where this is used.
1244 * src/maemo/easysetup/modest-easysetup-wizard.c:
1245 (create_page_welcome), (create_page_account_details),
1246 (create_page_user_details), (create_page_complete_easysetup),
1247 (create_page_custom_incoming), (create_page_custom_outgoing),
1248 (create_page_complete_custom):
1249 * src/maemo/modest-account-settings-dialog.c:
1250 (create_page_account_details), (create_page_user_details),
1251 (create_page_incoming), (create_page_outgoing):
1252 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1253 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1254 (modest_connection_specific_smtp_edit_window_init):
1255 * src/maemo/modest-connection-specific-smtp-window.c:
1256 (modest_connection_specific_smtp_window_init):
1257 * src/maemo/modest-signature-editor-dialog.c:
1258 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1259 and scrolling policy as per the Email Application Layout Guide, if I have
1262 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1264 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1265 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1266 which were empty, because these vfuncs have been removed from TnyAccountStore.
1267 This fixes the build.
1269 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1271 * src/maemo/modest-main-window.c:
1272 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1273 showing/hiding it. Added TODO because it probably should not be NULL.
1274 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1275 because unnecessary g_warnings() make degugging difficult.
1277 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1279 * src/maemo/modest-msg-edit-window.c:
1280 (modest_msg_edit_window_select_color),
1281 (modest_msg_edit_window_select_background_color): 2 const corrections and
1282 moving 2 #endifs before closing brackets, to fix the build.
1284 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1286 * src/maemo/easysetup/modest-easysetup-wizard.h:
1287 * src/maemo/easysetup/modest-easysetup-wizard.c:
1288 (modest_easysetup_wizard_dialog_finalize),
1289 (on_button_edit_advanced_settings), (create_page_complete_custom),
1290 (on_response), (create_account):
1291 Implement the Advanced Settings edit button, by saving the account information,
1292 for the Advanded Settings dialog to use directly from gconf, and removing it
1293 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1294 Bug #5533 in the projects.maemo.org bugzilla.
1296 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1298 * src/maemo/modest-msg-view-window.c:
1299 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1300 when opening a message window.
1302 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1304 * src/maemo/easysetup/modest-easysetup-wizard.c:
1305 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1308 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1309 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1310 gconf settings. I probably added more checks than necessary, but that is safer.
1312 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1313 variable to fix the build, but this seems to be used when it is still NULL.
1315 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1317 * src/modest-platform.h:
1318 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1319 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1320 * src/modest-main.c: Implement this function so we can avoid using
1321 maemo-specific API from cross-platform code.
1323 * src/modest-tny-account-store.c:
1324 (get_smtp_specific_transport_account_for_open_connection):
1325 * src/modest-ui-actions.c: (check_for_connection),
1326 (modest_ui_actions_on_item_not_found):
1327 Use modest_platform_connect_and_wait() and put #idefs around other
1328 maemo-specific code, because only maemo currently has a way to
1329 identify connection names.
1331 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1333 * src/modest-tny-account-store.h:
1334 * src/modest-tny-account-store.c:
1335 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1336 the connection-specific SMTP server settings in the configuration.
1338 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1340 * src/maemo/modest-main-window.c: (on_connection_changed),
1342 * src/modest-main.c: (main), (start_ui), (send_mail):
1343 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1344 that is what is intended.
1346 * src/modest-ui-actions.c: (action_send), (action_receive),
1347 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1348 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1349 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1350 SMTP server is used when it is specified.
1352 (modest_ui_actions_on_send_receive):
1353 Check that a connection is open before proceeding.
1354 Receive and then send, instead of vice-versa, as per the specification.
1356 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1358 * src/modest-mail-operation.c:
1359 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1360 though I guess it should be something other than NULL.
1362 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1364 * src/maemo/easysetup/modest-easysetup-wizard.c:
1365 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1366 combo twice, to avoid an g_warning and to make it visible again.
1367 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1368 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1369 (already intended) dereference when detaching, because we then recreate the menu.
1370 But I am not sure why the warning was happening, and it is possible that this is a memory
1373 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1375 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1376 and uri_parse_mailto() utility functions.
1377 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1379 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1381 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1383 * src/dbus_api/modest-dbus-api.h:
1384 * src/dbus_api/modest-dbus-callbacks.c:
1385 Use an idle callback to execute the modest code in the application's own thread.
1386 Remove the helloworld example method.
1387 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1388 parsed, and the open-message method is not implemented because this is not yet implemented in
1390 * libmodest-dbus-client/libmodest-dbus-client.c:
1391 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1392 (libmodest_dbus_client_open_message):
1393 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1395 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1396 body without crashing.
1398 * tests/dbus_api/Makefile.am:
1399 * tests/dbus_api/test_mail_to.c:
1400 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1402 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1404 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1405 Added file to fix the build. Sorry.
1407 * src/dbus_api/Makefile.am:
1408 * src/dbus_api/modest-dbus-api.h:
1409 * src/dbus_api/modest-dbus-callbacks.h:
1410 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1411 (modest_dbus_req_handler):
1412 Put constants in a separate header so it can be reused by the
1413 client library, without duplication
1415 * libmodest-dbus-client/Makefile.am:
1416 * libmodest-dbus-client/libmodest-dbus-client.c:
1417 (libmodest_dbus_client_call_helloworld),
1418 (libmodfest_dbus_client_send_mail),
1419 (libmodfest_dbus_client_mailto),
1420 (libmodfest_dbus_client_open_message):
1421 * libmodest-dbus-client/libmodest-dbus-client.h:
1422 (Partly) Implement a send_mail D-Bus method.
1424 * tests/dbus_api/Makefile.am:
1425 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1426 the send_email D-Bus method.
1428 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1432 * libmodest-dbus-client/Makefile.am:
1433 * libmodest-dbus-client/libmodest-dbus-client.c:
1434 * libmodest-dbus-client/libmodest-dbus-client.h:
1435 * tests/dbus_api/Makefile.am:
1436 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1437 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1439 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1441 * src/maemo/easysetup/modest-easysetup-wizard.c:
1442 (create_page_account_details):
1443 * src/maemo/modest-account-settings-dialog.c:
1444 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1445 widgets, because this might not be the default in future versions of the Maemo GTK+.
1446 However, I can not not get capitalization to work even in a simple test case.
1448 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1450 * src/maemo/easysetup/modest-easysetup-wizard.c:
1451 (create_page_custom_incoming), (create_page_custom_outgoing):
1452 * src/maemo/modest-account-settings-dialog.c:
1453 (create_page_account_details), (create_page_incoming),
1454 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1455 instead of using gtk_check_button_with_label(), so they are aligned like the other
1456 widgets, as per the UI spec.
1458 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1460 * src/maemo/easysetup/modest-easysetup-wizard.c:
1461 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1462 * src/widgets/modest-validating-entry.c:
1463 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1464 Modest prefix instead of an EasySetup prefix.
1466 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1468 * src/widgets/modest-validating-entry.h:
1469 * src/widgets/modest-validating-entry.c: (on_insert_text),
1470 Added easysetup_validating_entry_set_max_func(), used to set a callback
1471 to call when the max number of characters is reached. GtkEntry has a max-length
1472 already but is silent about it.
1474 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1475 (create_page_account_details), (create_page_user_details),
1477 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1478 (create_page_account_details), (create_page_user_details),
1479 (create_page_outgoing):
1480 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1481 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1482 the UI spec, when the user tries to enter more than the max number of characters.
1484 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1486 * src/maemo/easysetup/modest-easysetup-wizard.c:
1487 (create_page_user_details), (create_page_custom_incoming),
1488 (create_page_custom_outgoing):
1489 * src/maemo/modest-account-settings-dialog.c:
1490 (create_page_user_details), (create_page_incoming),
1491 (create_page_outgoing):
1492 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1493 (modest_connection_specific_smtp_edit_window_init):
1494 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1495 not appropriate. Bad Maemo-specific defaults!.
1497 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1499 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1500 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1501 (modest_signature_editor_dialog_set_settings):
1502 Disable the label and textview when the checkbox is disabled, and use the
1503 specified (UI spec) default signature text.
1505 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1507 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1508 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1510 * src/modest-defs.h:
1511 * src/modest-account-mgr-helpers.h:
1512 * src/modest-account-mgr-helpers.c:
1513 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1515 * src/maemo/Makefile.am:
1516 * src/maemo/modest-signature-editor-dialog.c:
1517 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1520 * src/maemo/modest-account-settings-dialog.h:
1521 * src/maemo/modest-account-settings-dialog.c:
1522 (modest_account_settings_dialog_finalize), (on_button_signature),
1523 (save_configuration): Use the new dialog when the Edit button is pressed, and
1524 save the changes if necessary, as per the UI spec.
1526 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1528 * src/maemo/Makefile.am:
1529 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1530 based on maemo-develoers email from Dirk.
1532 * src/maemo/easysetup/modest-easysetup-wizard.c:
1533 (create_page_welcome), (create_page_account_details),
1534 (create_page_user_details), (create_page_complete_easysetup),
1535 (create_page_custom_incoming), (create_page_custom_outgoing),
1536 (create_page_complete_custom),
1537 (modest_easysetup_wizard_dialog_init):
1538 * src/maemo/modest-account-settings-dialog.c:
1539 (create_page_account_details), (create_page_user_details),
1540 (create_page_incoming), (create_page_outgoing),
1541 (modest_account_settings_dialog_init):
1542 * src/maemo/modest-connection-specific-smtp-window.c:
1543 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1545 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1547 * src/maemo/easysetup/modest-easysetup-wizard.c:
1548 (create_page_account_details), (create_page_custom_outgoing),
1549 (create_page_complete_custom):
1550 * src/maemo/modest-account-settings-dialog.c:
1551 (create_page_user_details), (create_page_incoming),
1552 (create_page_outgoing):
1553 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1554 (modest_connection_specific_smtp_edit_window_init):
1555 Use the correct (UI spec) port min/max, and use horizontal separators,
1558 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1560 * src/maemo/easysetup/modest-easysetup-wizard.c:
1561 (set_default_custom_servernames):
1562 * src/maemo/modest-account-settings-dialog.c:
1563 (create_page_incoming), (on_combo_outgoing_security_changed),
1564 (on_combo_incoming_security_changed), (create_page_outgoing),
1565 (modest_account_settings_dialog_set_account_name),
1566 (save_configuration):
1567 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1568 (on_combo_security_changed),
1569 (modest_connection_specific_smtp_edit_window_init),
1570 (modest_connection_specific_smtp_edit_window_set_connection),
1571 (modest_connection_specific_smtp_edit_window_get_settings):
1572 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1575 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1578 * src/maemo/easysetup/modest-easysetup-wizard.c:
1579 (create_page_custom_outgoing), (create_page_complete_custom):
1580 * src/maemo/modest-account-settings-dialog.c:
1581 (create_page_user_details), (create_page_outgoing):
1582 * src/maemo/modest-account-view-window.c: (button_box_new):
1583 Use changed logical IDs as per the most recent UI spec:
1584 mcen_bd_emailsetup_edit -> mcen_bd_edit
1585 mcen_bd_emailsetup_delete -> mcen_bd_delete
1586 mcen_bd_emailsetup_close -> mcen_bd_close
1588 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1592 * src/dbus_api/Makefile.am:
1593 * src/dbus_api/modest-dbus-callbacks.c:
1594 * src/dbus_api/modest-dbus-callbacks.h:
1595 * src/maemo/modest-platform.c: (modest_platform_init):
1596 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1598 * tests/Makefile.am:
1599 * tests/dbus_api/Makefile.am:
1600 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1602 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1604 * src/maemo/modest-account-settings-dialog.c:
1605 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1606 Removed unnecessary includes.
1608 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1610 * src/maemo/easysetup/modest-easysetup-wizard.c:
1611 * src/maemo/modest-account-settings-dialog.c:
1612 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1613 * src/widgets/Makefile.am:
1614 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1615 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1616 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1617 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1618 * src/widgets/modest-secureauth-combo-box.c:
1619 * src/widgets/modest-secureauth-combo-box.h:
1620 * src/widgets/modest-serversecurity-combo-box.c:
1621 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1622 made the GObject names more consistent with the rest of the Modest code.
1624 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1626 * src/maemo/easysetup/Makefile.am:
1627 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1628 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1629 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1630 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1631 * src/maemo/easysetup/modest-easysetup-wizard.c:
1632 * src/maemo/easysetup/modest-validating-entry.c:
1633 * src/maemo/easysetup/modest-validating-entry.h:
1634 * src/maemo/modest-account-settings-dialog.c:
1635 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1636 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1637 widgets/ because they are used outside of easysetup too. After checking in,
1638 svn will allow me to rename them too.
1640 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1642 * src/gnome/modest-msg-edit-window.c:
1643 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1644 linker error, to fix the build on the GNOME platform.
1645 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1646 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1647 ifdefed out to avoid a warning.
1649 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1651 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1652 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1653 some alternative for GTK+ 2.6.
1655 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1657 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1659 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1660 specified for EmailAccountsDialog in UI spec.
1662 * src/maemo/easysetup/modest-easysetup-wizard.c:
1663 * src/maemo/easysetup/modest-easysetup-wizard.h:
1664 * src/maemo/modest-account-settings-dialog.c:
1665 * src/maemo/modest-account-settings-dialog.h:
1666 Reuse a member window widget for the connection-specific SMTP server accounts,
1667 so we can tell it to create/save the accounts only if we actually save changes.
1669 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1670 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1671 (modest_connection_specific_smtp_edit_window_get_settings):
1672 Return a struct instance for temporarily remembering the entered data.
1674 * src/maemo/modest-connection-specific-smtp-window.h:
1675 * src/maemo/modest-connection-specific-smtp-window.c:
1676 (modest_connection_specific_smtp_window_finalize),
1677 (modest_connection_specific_smtp_window_fill_with_connections),
1679 (modest_connection_specific_smtp_window_save_server_accounts),
1680 (update_model_server_names): Do not actually save data until asked,
1681 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1683 (on_selection_changed),
1684 (modest_connection_specific_smtp_window_init): Disable the edit
1685 button when nothing is selected.
1687 * src/modest-account-mgr-helpers.c:
1688 * src/modest-account-mgr-helpers.h:
1689 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1692 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1694 * src/modest-account-mgr-helpers.h:
1695 * src/modest-account-mgr-helpers.c:
1696 (modest_account_mgr_get_unused_account_name),
1697 (modest_account_mgr_get_unused_account_display_name): Added these
1698 utility functions, to avoid code duplication.
1700 * src/maemo/easysetup/modest-easysetup-wizard.c:
1701 (create_page_account_details), (create_account):
1702 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1703 (on_combo_security_changed),
1704 (modest_connection_specific_smtp_edit_window_init),
1705 (modest_connection_specific_smtp_edit_window_save_settings):
1706 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1707 * src/maemo/modest-connection-specific-smtp-window.c:
1708 (modest_connection_specific_smtp_window_finalize),
1709 (modest_connection_specific_smtp_window_fill_with_connections),
1710 (on_button_edit), (modest_connection_specific_smtp_window_init):
1711 * src/maemo/modest-connection-specific-smtp-window.h:
1712 Implementing saving of connection-specific server accounts.
1714 But I need to refactor this so we can save the data for each
1715 possible connection-specific account and only actually create the server accounts
1716 when the easysetup finished, or the OK button is pressed on the account settings
1719 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1721 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1722 (on_combo_security_changed):
1723 (modest_connection_specific_smtp_edit_window_init):
1724 Auto-fill the port number as in the account settings.
1726 (modest_connection_specific_smtp_edit_window_set_connection):
1727 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1728 * src/maemo/modest-connection-specific-smtp-window.c:
1729 (fill_with_connections), (on_button_edit),
1730 (modest_connection_specific_smtp_window_init):
1731 Turn the edit window into a dialog to simplify the code, and
1732 set a WM hint as in a GtkDialog, because only a popup can be on top of
1733 another window in Maemo, and popups usually have no WM decoration.
1735 * src/modest-defs.h:
1736 * src/modest-account-mgr-helpers.c:
1737 (modest_account_mgr_set_connection_specific_smtp),
1738 (modest_account_mgr_remove_connection_specific_smtp),
1739 (modest_account_mgr_get_connection_specific_smtp):
1740 * src/modest-account-mgr-helpers.h: Some functions to write the
1741 connection-specific SMTP server information. Not yet used.
1744 * src/widgets/modest-folder-view.c: (text_cell_data):
1745 Fix a warning about an uninitialized variable.
1746 (on_configuration_key_changed): Put an #ifdef around the use
1747 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1749 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1751 * src/maemo/modest-account-settings-dialog.h:
1752 * src/maemo/modest-account-settings-dialog.c:
1753 Added connect_for_modified() utility function to mark the new modified boolean.
1755 (create_page_account_details), (create_page_user_details),
1756 (create_page_incoming), (create_page_outgoing), (on_response),
1757 (modest_account_settings_dialog_init),
1758 (modest_account_settings_dialog_set_account_name):
1759 Only warn about unsaved changes when there are actually unsaved changes.
1761 * src/modest-account-mgr-helpers.c:
1762 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1763 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1764 to get the data from there in future.
1766 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1768 * src/modest-defs.h:
1770 * src/modest-account-mgr-helpers.h:
1771 * src/modest-account-mgr-helpers.c:
1772 Store the security account setting in a single conf key instead of using
1773 the options list, so that the list is left for just the to-be-removed camel hack,
1774 and because gconf_client_set_list() is failing for some reason.
1776 * src/modest-account-mgr.c:
1777 (modest_account_mgr_add_server_account):
1778 * src/maemo/modest-account-settings-dialog.c:
1779 (modest_account_settings_dialog_set_account_name),
1780 (save_configuration): Use the renamed functions.
1783 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1785 * src/widgets/Makefile.am:
1786 * src/widgets/modest-limit-retrieve-combo-box.c:
1787 * src/widgets/modest-limit-retrieve-combo-box.h:
1788 * src/widgets/modest-retrieve-combo-box.c:
1789 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1790 the account settings dialog.
1792 * src/modest-defs.h:
1793 * src/modest-account-mgr-helpers.h:
1794 * src/modest-account-mgr-helpers.c:
1795 (modest_server_account_get_option_secure_auth),
1796 (modest_server_account_set_option_secure_auth):
1797 * src/modest-account-mgr.c:
1798 (modest_account_mgr_add_server_account):
1799 Use the existing AUTH_MECH conf key for the secure-auth setting,
1800 instead of putting it in the list options, because this was actually used already.
1802 * src/maemo/modest-account-settings-dialog.c:
1803 (create_page_account_details),
1804 (modest_account_settings_dialog_set_account_name),
1805 (save_configuration):
1806 * src/maemo/modest-account-settings-dialog.h:
1807 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1808 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1810 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1812 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1813 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1814 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1816 * src/modest-defs.h:
1817 * src/maemo/modest-account-settings-dialog.c:
1818 (create_page_incoming), (on_combo_outgoing_security_changed),
1819 (on_combo_incoming_security_changed), (create_page_outgoing),
1820 (modest_account_settings_dialog_set_account_name),
1821 (save_configuration): Load/Save the port number, and change it when the
1822 security combo changes, to suitable defaults.
1824 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1826 * src/modest-account-mgr.c:
1827 (modest_account_mgr_add_server_account): Set the security and secure-auth
1828 options, and add a comment saying that the other camel-specific options should be
1831 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1833 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1835 * src/modest-tny-account-store.c: (account_list_free),
1836 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1837 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1840 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1842 * src/modest-protocol-info.c:
1843 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1844 is required by our UI spec. Maybe something in our implementation will use this eventually.
1845 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1846 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1847 instead of the previous 0 placeholder.
1849 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1850 secure-auth settings.
1851 * src/modest-account-mgr-helpers.h:
1852 * src/modest-account-mgr-helpers.c:
1853 (modest_server_account_data_get_option_secure_auth),
1854 (modest_server_account_set_option_secure_auth),
1855 (modest_server_account_data_get_option_security),
1856 (modest_server_account_set_option_security): Added this API for getting and setting the security
1857 and secure-auth settings.
1859 * src/maemo/modest-account-settings-dialog.h:
1860 * src/maemo/modest-account-settings-dialog.c:
1861 (modest_account_settings_dialog_finalize), (check_data),
1862 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1863 about changing titles.
1864 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1865 (save_configuration): Save the security and secure-auth settings.
1867 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1868 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1870 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1872 * src/modest-defs.h:
1873 * src/modest-account-mgr.c:
1874 (modest_account_mgr_add_server_account):
1875 Added and used defines for the options key and value pair strings,
1876 that are used so far, though they do not seem to correspond to anything in our
1877 UI specs or ModestProtocol enum.
1879 * src/modest-account-mgr-helpers.h:
1880 * src/modest-account-mgr-helpers.c:
1881 (compare_option_strings_for_name),
1882 (modest_server_account_data_get_option_value),
1883 (modest_server_account_data_get_option_bool),
1884 (modest_account_mgr_get_server_account_option):
1885 Added helper functions for parsing the options GSList.
1887 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1889 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1890 display name is based on the supplied account name.
1891 * src/modest-account-mgr.c:
1892 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1893 with an inefficient, but good-enough, implementation.
1895 * src/maemo/easysetup/modest-easysetup-wizard.c:
1896 (create_page_account_details), (on_before_next), (create_account):
1897 Check for existing display names rather than (non-user-visible) account names, and just
1898 create and set a unique account name at the end.
1900 * src/maemo/modest-account-settings-dialog.c:
1901 (modest_account_settings_dialog_init),
1902 (modest_account_settings_dialog_set_account_name),
1903 (create_page_incoming): Show the display name, instead of the account name.
1904 (on_response): Do some (not all) extra checks, as in the UI spec.
1905 (save_configuration): Save the display name if it was changed.
1907 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1909 * po/en_GB.po: Added needed logical ID and translation.
1910 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1911 (init_view): Made the is-default column clicking work.
1913 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1916 * src/maemo/easysetup/Makefile.am:
1917 * src/maemo/easysetup/modest-easysetup-wizard.c:
1918 (modest_easysetup_wizard_dialog_init):
1919 * src/maemo/easysetup/provider-data-test.keyfile:
1920 * src/maemo/easysetup/provider-data.keyfile:
1921 Moved the provider data file to the new modest-providers-data package and used it from there.
1923 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1925 * src/modest-local-folder-info.c:
1926 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1927 N_() was already used on the static strings, but this just marks it for translation without
1928 using the translation.
1930 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1932 * src/maemo/modest-account-settings-dialog.c:
1933 (create_page_incoming),
1934 (modest_account_settings_dialog_set_account_name):
1935 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1936 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1937 I will do this if nobody else gets there first.
1939 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1941 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1942 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1943 save the security stuff.
1945 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1947 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1948 Set the email address and user fullname, which I now see must be
1951 * src/maemo/modest-account-settings-dialog.h:
1952 * src/maemo/modest-account-settings-dialog.c:
1954 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1955 leave-on-server and authentication.
1956 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1959 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1962 * src/maemo/modest-account-settings-dialog.c:
1963 * src/maemo/modest-account-settings-dialog.h:
1964 Most (but not all) of the widgets are now present as specified by the UI spec.
1965 No changes are yet saved, and some details are not properly shown yet.
1967 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1969 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1971 * src/maemo/Makefile.am:
1972 * src/maemo/modest-account-settings-dialog.c:
1973 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1974 an existing account. Doesn't do much yet.
1976 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1977 Open the accounts settings dialog when Edit is clicked.
1979 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1981 * src/maemo/easysetup/Makefile.am:
1982 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1984 * src/maemo/easysetup/modest-easysetup-wizard.c:
1985 (modest_easysetup_wizard_dialog_init):
1986 Try to get the source directory from the build system,
1987 instead of hard-coding "./" into the source code, when opening our local
1988 copies of the configuration files.
1989 But this still fails when opening the wizard from the Accounts window,
1990 maybe because the working directory seems to change at runtime.
1991 So the wizard will fail the second time unless you copy the files into their
1992 proper locations - see the stdout warnings for the paths.
1994 (create_page_account_details),(on_before_next):
1995 Check for existing non-server accounts instead of server accounts,
1996 so the default account name is useful again, and to prevent trying to
1999 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2000 Show the wizard when New is clicked.
2002 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2003 (init_view): Show the column headers, and show the columns that are
2004 specified in the UI specs. However, something in Maemo's GTK+ prevents
2005 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2006 change the default account. This is despite unsetting the special properties.
2008 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2010 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2011 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2012 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2013 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2014 to make that clearer.
2015 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2017 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2019 * src/maemo/modest-account-view-window.c:
2020 (modest_account_view_window_init),
2021 (modest_account_view_window_new):
2022 Use the same buttons as specified in the
2023 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2024 the existing widgets, which never had a chance of working.
2025 Put the ModestAccountView treeview in a scrolled window.
2026 Do not repeat the initialization in both _init() and _new().
2028 * src/widgets/modest-account-view.c: (update_account_view):
2029 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2030 this widget and window shows no accounts.
2032 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2034 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2036 * src/maemo/easysetup/modest-easysetup-wizard.c:
2037 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2038 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2039 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2042 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2043 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2044 accounts exist yet, as in the UI spec.
2046 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2048 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2050 * src/maemo/Makefile.am:
2051 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2052 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2053 New window for editing connection-specific smtp details.
2054 Not fully implemented.
2056 * src/maemo/modest-connection-specific-smtp-window.c:
2057 (modest_connection_specific_smtp_window_finalize) :
2058 unref the tree model.
2059 (on_button_edit): Show the edit window.
2061 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2063 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2066 * src/maemo/Makefile.am:
2067 * src/maemo/modest-connection-specific-smtp-window.c:
2068 * src/maemo/modest-connection-specific-smtp-window.h:
2069 New window for showing the list of connections, for connection-specific
2070 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2071 * src/maemo/easysetup/modest-easysetup-wizard.c:
2072 (create_page_custom_outgoing): Show the new window when the button is clicked.
2074 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2076 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2077 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2078 * src/maemo/modest-msg-edit-window.c:
2079 (modest_msg_edit_window_insert_image):
2080 * src/modest-conf.c: (modest_conf_key_escape):
2081 * src/modest-mail-operation.c:
2082 (modest_mail_operation_send_new_mail):
2083 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2084 (modest_ui_actions_on_new_account):
2085 * src/widgets/modest-attachment-view.c: (update_filename_request):
2086 * src/widgets/modest-mail-header-view.c:
2087 Corrected warnings that were breaking the build, by commenting out unused variables,
2088 and a function, and by including a header.
2090 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2092 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2093 so we can #ifdef around platform-specific code when necessary.
2094 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2095 to allow this to build for the GNOME platform too.
2097 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2099 * src/maemo/easysetup/modest-easysetup-wizard.c:
2100 Added util_increment_name() and used it in create_page_account_details()
2101 to make sure that the default account name is always a new name.
2103 (modest_easysetup_wizard_dialog_init),
2104 (set_default_custom_servernames): Some minor memory management fixes.
2106 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2110 * src/modest-runtime.c: (init_i18n): Restored the translation
2111 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2112 are defined in config.h, and the translations are installed.
2114 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2115 is defined for translation.
2117 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2119 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2121 * src/maemo/easysetup/modest-easysetup-wizard.c:
2122 (modest_easysetup_wizard_dialog_init):
2123 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2124 Use realistic paths (though they should use $prefix generically) to the
2125 mcc_mapping and provider-data.keyfile files which might work when they
2126 are installed by the future version of the operator-wizard package,
2127 and then fallback to paths in our source code, with an explanatory
2130 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2134 * src/maemo/Makefile.am:
2135 * src/maemo/easysetup/: Added files from the previously-exernal
2136 osso-modest-easysetup.
2137 * src/maemo/modest-main-window-ui.h:
2138 * src/modest-ui-actions.c:
2139 * src/modest-ui-actions.h:
2140 Added modest_ui_actions_on_new_account() as a signal handler for the
2141 New Account menu item. It shows the easysetup wizard.
2142 * po/en_GB.po: Added additional needed logical IDs and translations.
2144 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2145 Apparently ChangeLog is not used for some vague Nokia legal reasons.