1 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account.c:
4 (modest_tny_account_new_from_server_account):
5 Use NULL for the secure-auth method for POP when Password auth has been
6 specified by the user, as we already do for IMAP. "auth=Login" causes
7 an error from camel or the server.
9 2007-05-17 Murray Cumming <murrayc@murrayc.com>
11 * src/maemo/modest-account-settings-dialog.c:
12 (create_page_account_details),
13 (modest_account_settings_dialog_set_account_name):
14 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
15 for the leave-on-server checkbox, rathr than just the checkbox, when
16 the protocol is not POP.
18 2007-05-17 Murray Cumming <murrayc@murrayc.com>
20 * src/widgets/modest-account-view.c:
21 * src/widgets/modest-account-view.h:
22 Added modest_account_view_select_account() which will be useful later
23 to asynchronously re-select the edited account.
25 2007-05-17 Murray Cumming <murrayc@murrayc.com>
27 * src/maemo/modest-account-settings-dialog.c:
28 (modest_account_settings_dialog_set_account_name):
29 Automatically choose the port numbers based on the secure authentication
30 methods, if they have not been chosen before.
31 This fixes projects.maemo.org bug NB#56273 .
33 2007-05-17 Murray Cumming <murrayc@murrayc.com>
35 * src/maemo/modest-main-window-ui.h:
36 * src/modest-ui-actions.c:
37 * src/modest-ui-actions.h:
38 Connect the Tools/SMTP Servers menu item to
39 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
40 SMTP servers dialog, as in the UI specification and saves changes when it
41 is closed. This fixed projects.maemo.org bug NB#56305 .
43 2007-05-17 Murray Cumming <murrayc@murrayc.com>
45 * src/maemo/modest-connection-specific-smtp-window.c:
46 (modest_connection_specific_smtp_window_init):
47 Use gtk_window_set_default_size() to make this window big enough, so
48 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
50 2007-05-17 Murray Cumming <murrayc@murrayc.com>
52 * src/maemo/modest-connection-specific-smtp-edit-window.h:
53 * src/maemo/modest-connection-specific-smtp-edit-window.c:
54 (modest_connection_specific_smtp_edit_window_init),
55 Do not try to connect to a combobox signal before the combobox exists.
56 This fixes the cras in projects.maemo.org bug NB#56288 .
57 (modest_connection_specific_smtp_edit_window_get_settings):
58 Remove the server_account_name parameter which was being checked for NULL
59 though it was not used.
61 * src/maemo/modest-connection-specific-smtp-window.c:
62 (modest_connection_specific_smtp_window_fill_with_connections),
63 (on_button_edit), (modest_connection_specific_smtp_window_init):
64 Correct the number of treemodel columns to prevent a warning.
65 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
66 libconic does not work.
68 2007-05-16 Murray Cumming <murrayc@murrayc.com>
70 * src/modest-tny-account.c:
71 (modest_tny_account_new_from_server_account):
72 Excplicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
73 SMTP when "None" was chosen by the user. However, with my SMTP server that
74 does not support ANONYMOUS, the emails do not leave the Outbox and I see
77 2007-05-16 Murray Cumming <murrayc@murrayc.com>
79 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
80 to explain the memory management issue with the ID in the ModestPair.
82 * src/gnome/modest-account-assistant.c: (add_receiving_page),
83 (add_sending_page), (modest_account_assistant_finalize):
84 * src/gnome/modest-gnome-global-settings-dialog.c:
85 (create_updating_page), (create_composing_page):
86 * src/gnome/modest-msg-edit-window.c: (get_transports),
87 (init_window), (modest_msg_edit_window_finalize),
88 (modest_msg_edit_window_get_msg_data):
89 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
90 * src/gnome/modest-transport-widget.c:
91 (modest_transport_widget_finalize), (smtp_configuration):
92 * src/maemo/modest-maemo-global-settings-dialog.c:
93 (create_updating_page), (create_composing_page):
94 * src/maemo/modest-msg-edit-window.c: (get_transports),
95 (init_window), (modest_msg_edit_window_finalize),
96 (modest_msg_edit_window_get_msg_data),
97 (modest_msg_edit_window_free_msg_data):
98 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
99 (modest_store_widget_finalize):
100 * src/maemo/modest-transport-widget.c:
101 (modest_transport_widget_finalize), (smtp_configuration):
102 * src/modest-main.c: (send_mail):
103 * src/widgets/modest-combo-box.h:
104 * src/widgets/modest-global-settings-dialog-priv.h:
105 * src/widgets/modest-global-settings-dialog.c:
106 (modest_global_settings_dialog_finalize):
107 * src/widgets/modest-msg-edit-window.h:
108 Whenever using modest_combo_box_new(), keep the ModestPairList alive
109 as long as the combo box, to prevent use of freed memory for the ID.
111 2007-05-15 Murray Cumming <murrayc@murrayc.com>
113 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
114 get_accounts(), to make this clearer. Do not check for the enabled gconf
115 key, because we do not use this for server accounts (at least, not yet).
116 This allows us to send email again.
118 2007-05-15 Murray Cumming <murrayc@murrayc.com>
120 * src/maemo/modest-platform.c:
121 (on_modest_conf_update_interval_changed), (modest_platform_init):
122 Only respond to this particular key change. All these strcmp()s cannot be
125 2007-05-15 Murray Cumming <murrayc@murrayc.com>
127 * src/maemo/modest-maemo-global-settings-dialog.c:
128 (current_connection): Prevent a crash in scratchbox when
129 ny_maemo_conic_device_get_current_iap_id() returns NULL.
130 * src/maemo/modest-platform.c:
131 (on_modest_conf_update_interval_changed), (modest_platform_init):
132 Get the update interval from gconf and reset it when the gconf key changes.
134 2007-05-15 Murray Cumming <murrayc@murrayc.com>
136 * src/modest-protocol-info.c:
137 * src/modest-protocol-info.h: Adde enum-specific get functions,
138 instead of using a ModestProtocolType enum parameter.
140 * src/gnome/modest-account-assistant.c:
141 * src/gnome/modest-store-widget.c:
142 * src/gnome/modest-store-widget.h:
143 * src/gnome/modest-transport-widget.c:
144 * src/gnome/modest-transport-widget.h:
145 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
146 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
147 * src/maemo/easysetup/modest-easysetup-wizard.c:
148 * src/maemo/modest-account-settings-dialog.c:
149 * src/maemo/modest-account-settings-dialog.h:
150 * src/maemo/modest-store-widget.c:
151 * src/maemo/modest-store-widget.h:
152 * src/maemo/modest-transport-widget.c:
153 * src/maemo/modest-transport-widget.h:
154 * src/modest-account-mgr-helpers.c:
155 * src/modest-account-mgr-helpers.h:
156 * src/modest-account-mgr.c:
157 * src/modest-account-mgr.h:
158 * src/modest-tny-account.c:
159 * src/modest-tny-folder.c:
160 * src/widgets/modest-account-view.c:
161 * src/widgets/modest-retrieve-combo-box.c:
162 * src/widgets/modest-retrieve-combo-box.h:
163 * src/widgets/modest-secureauth-combo-box.c:
164 * src/widgets/modest-serversecurity-combo-box.c:
165 * src/widgets/modest-serversecurity-combo-box.h:
166 * tests/check_account-mgr.c:
167 Use the specific functions, and use the re-renamed enum values for GNOME too.
169 2007-05-15 Murray Cumming <murrayc@murrayc.com>
172 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
173 so we can get the second based on the first.
175 * src/maemo/modest-account-settings-dialog.h:
176 * src/maemo/modest-account-settings-dialog.c:
177 Added get_supported_secure_authentication_methods(), though it is mostly
178 commented-out for now until the necessary API is committed to tinymail.
179 (modest_account_settings_dialog_set_account_name),
180 (save_configuration): Request the supported authentication methods from the
181 server, so we can choose a working method.
183 * src/modest-tny-account-store.h:
184 * src/modest-tny-account-store.c:
185 (modest_tny_account_store_get_session): Rename from
186 tny_account_store_get_session().
188 2007-05-14 Murray Cumming <murrayc@murrayc.com>
190 * src/modest-protocol-info.h: Split the ModestProtocol enum
191 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
192 There was no need to have these unrelated values in one enum.
194 * src/: many files: Adapted to changed enum. This makes the code a bit
195 clearer, and the compiler could catch some errors.
197 2007-05-14 Murray Cumming <murrayc@murrayc.com>
199 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
200 Show the detailed internal camel error message when an error happens
201 during the configuration, so that our testers can give us more clues.
202 For instance, in projects.maemo.org bug NB#56910 .
204 2007-05-14 Murray Cumming <murrayc@murrayc.com>
206 * src/modest-tny-account.c:
207 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
208 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
210 2007-05-14 Murray Cumming <murrayc@murrayc.com>
212 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
213 * src/maemo/modest-account-settings-dialog.c:
214 (modest_account_settings_dialog_set_account_name),
215 (save_configuration): For the incoming secure authentication checkbox,
216 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
217 the UI specification. PLAIN does not seem to be supported for most IMAP
218 servers anyway, and I am not sure what it would mean.
219 However, we probably need to discover which of the secure-authentication
220 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
221 * src/modest-account-mgr-helpers.c:
222 (modest_account_mgr_get_server_account_data):
224 * src/modest-tny-account.c:
225 (modest_tny_account_new_from_server_account):
226 Use tny_account_set_mech() to set secure-authentication methods,
227 with some special-casing for IMAP, based on my observations of how
230 * src/modest-account-mgr-helpers.h:
231 * src/modest-account-mgr.c:
232 * src/modest-defs.h: Comment that the URI is only used for local folders.
234 2007-05-11 Murray Cumming <murrayc@murrayc.com>
236 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
237 parameter const, just to be neat.
238 * src/modest-text-utils.c: (modest_text_utils_inline):
239 End g_strconcat() with NULL, as its documentation says. This is almost
240 certainly the cause of my crash at startup on the device. Interestingly,
241 valgrind doesn't tell us about these errors.
243 2007-05-11 Murray Cumming <murrayc@murrayc.com>
245 * scripts/build-packages: Added more precise comments about how to use
246 this script, though I still get this error:
247 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
248 error building tinymail
250 2007-05-11 Murray Cumming <murrayc@murrayc.com>
252 * src/maemo/modest-main-window.c: (on_account_update):
253 Very slight cleanup, hoping to make it simpler to discover what causes
254 a crash here sometimes.
256 * src/modest-tny-account.c:
257 (modest_tny_account_new_from_server_account): Set the port. Added
258 comments about the options and a TODO comment because I need to find out
259 how to specify the secure authentication method.
261 2007-05-11 Marcus Bauer <marcusb@openismus.com>
263 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
264 changed CFlags paths form modest to libmodest
266 2007-05-10 Murray Cumming <murrayc@murrayc.com>
268 * src/modest-account-mgr-helpers.c:
269 (modest_account_mgr_get_server_account_data),
270 (modest_account_mgr_free_server_account_data):
271 * src/modest-account-mgr-helpers.h:
272 * src/modest-account-mgr.c:
273 (modest_account_mgr_add_server_account):
275 * src/modest-tny-account.c:
276 (modest_tny_account_new_from_server_account):
277 Determine the options for tny_camel_account_add_option() here,
278 based on the settings, rather than storing them directly in gconf.
280 2007-05-10 Murray Cumming <murrayc@murrayc.com>
282 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
283 Show a more friendly error dialog now that we expect (from the tinymail
284 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
286 2007-05-10 Murray Cumming <murrayc@murrayc.com>
288 * src/maemo/modest-main-window.c: (on_account_update): Check that
289 account_name is not NULL, to prevent a crash at startup that I am
290 seeing on the N800. I do wonder why it is NULL.
292 * src/maemo/easysetup/modest-easysetup-wizard.c:
293 (create_page_user_details):
294 * src/maemo/modest-account-settings-dialog.c:
295 (create_page_user_details), (create_page_outgoing):
296 * src/maemo/modest-connection-specific-smtp-edit-window.c:
297 (modest_connection_specific_smtp_edit_window_init):
298 * src/modest-ui-actions.c:
299 (modest_ui_actions_on_password_requested):
300 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
301 might do something useful with the on-screen keyboard.
303 2007-05-10 Murray Cumming <murrayc@murrayc.com>
305 * src/maemo/modest-main-window.c: (on_account_update):
306 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
307 NULL, to avoid lots of warnings. However, it probably should not be NULL.
309 2007-05-09 Murray Cumming <murrayc@murrayc.com>
311 * src/modest-tny-account-store.c: (on_account_changed):
312 Correct the signature of this signal handler.
314 2007-05-09 Murray Cumming <murrayc@murrayc.com>
316 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
317 Show a HildonNote instead of a GtkDialog for Maemo.
319 2007-05-09 Murray Cumming <murrayc@murrayc.com>
321 * src/widgets/modest-account-view.h:
322 * src/widgets/modest-account-view.c: (on_account_changed),
323 (on_account_removed). Added a boolean flag, set/unset by
324 modest_account_view_block_conf_updates(),
325 modest_account_view_unblock_conf_updates() to prevent unnecessary
326 updates, but this is not very useful because the gconf notifications are
327 so delays (maybe only on Maemo Bora).
328 So auto-updating is turned off, and these functions do an explicit
329 update when necessary.
330 However, something else is still doing too much work when adding/removing
331 accounts, probably in another part of the application.
333 * src/maemo/modest-account-view-window.c:
334 (on_delete_button_clicked), (on_edit_button_clicked),
335 (on_new_button_clicked): Use the new functions.
337 2007-05-09 Murray Cumming <murrayc@murrayc.com>
339 * src/modest-account-mgr-helpers.c:
340 (modest_account_mgr_set_first_account_as_default):
341 Sort the list of names alphabetically-by-title, so we choose the first one
343 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
344 alphabetically by the title.
346 This fixes projects.maemo.org bug NB#56418 .
348 * src/modest-account-mgr-priv.c:
349 (_modest_account_mgr_account_from_key):
350 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
351 avoid a valgrind error, and possible random behaviour.
353 2007-05-09 Murray Cumming <murrayc@murrayc.com>
355 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
356 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
357 tinymail documentation to say that this can be expected.
358 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
359 pretty, and should not happen, but I would prefer to know when it does.
361 2007-05-09 Murray Cumming <murrayc@murrayc.com>
363 * configure.ac: When using the older hildon version, probably on Bora,
364 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
366 * src/widgets/modest-attachment-view.c:
367 (modest_attachment_view_set_part_default): Initialize variables, to fix the
370 2007-05-09 Marcus Bauer <marcusb@openismus.com>
372 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
373 Implemented the prototype. Can be tested with
374 tests/dbus_api/test_open_message:
376 2007-05-08 Murray Cumming <murrayc@murrayc.com>
378 * src/modest-tny-account-store.c:
379 (modest_tny_account_store_instance_init), (get_password):
380 * src/modest-ui-actions.c:
381 (modest_ui_actions_on_password_requested):
382 Do not store the password in gconf, because this function is called
383 for non-remembered passwords. Actually use the cached (in the hash map)
384 password instead of releasing it.
385 The password will now not be remembered if it is asked via the protected
386 password dialog, as per the UI spec.
388 2007-05-08 Murray Cumming <murrayc@murrayc.com>
391 * src/modest-account-mgr-helpers.h:
392 * src/modest-account-mgr-helpers.c:
393 Added modest_server_account_get_username_has_succeeded(),
394 modest_server_account_set_username_has_succeeded().
395 (modest_server_account_set_username),
396 Reset the has-succeeded flag if the username changes.
398 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
399 * src/maemo/modest-connection-specific-smtp-window.c:
400 (modest_connection_specific_smtp_window_save_server_accounts):
401 Use modest_server_account_set_username() instead of using
402 modest_conf_set_string() directly, so that the has-succeeded flag is always
405 * src/modest-ui-actions.c:
406 (modest_ui_actions_on_password_requested): Dim the username entry if
407 the username has ever worked, as per the UI spec.
409 2007-05-08 Murray Cumming <murrayc@murrayc.com>
411 * src/modest-tny-account-store.c: (get_password):
412 * src/modest-ui-actions.c:
413 (modest_ui_actions_on_password_requested):
414 Allow the username to be changed too, though there is more work to
415 be done on exactly how this behaves.
417 2007-05-08 Murray Cumming <murrayc@murrayc.com>
419 * src/modest-account-mgr-helpers.h:
420 * src/modest-account-mgr-helpers.c:
421 Added modest_account_mgr_get_display_name(),
422 modest_server_account_get_username(),
423 modest_server_account_set_username(),
424 modest_server_account_set_password(),
425 modest_server_account_get_hostname() functions so we do not need to
426 use the conf API directly.
428 * src/maemo/modest-main-window.c: (connect_signals):
429 Actually connect ot the ModestAccountStore::request-password signal,
430 so that we show the dialog when the password is requested by Tinymail,
431 for isntance if it is empty.
433 * src/modest-marshal.list:
434 * src/modest-tny-account-store.c:
435 (modest_tny_account_store_class_init), (get_password),
436 (modest_tny_account_store_alert):
437 * src/modest-tny-account-store.h:
438 * src/modest-ui-actions.h:
439 * src/modest-ui-actions.c:
440 (modest_ui_actions_on_password_requested):
441 Change the signal parameters, so it is obvious that we are providing
442 the non human-readable server name, and receiving both the username
443 and password, though changing of the username is not yet implemented.
444 Change the dialog UI to match the Maemo UI specifications, with #idfefing
445 for the GNOME version.
447 This should fix the projects.maemo.org bug NB#56209, though it does not
448 work on Bora, because the gconf_client_get() for the password fails
449 immediately after we save it with gconf_client_set().
451 2007-05-08 Murray Cumming <murrayc@murrayc.com>
454 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
455 caused an undefined symbol error:
456 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
458 2007-05-08 Murray Cumming <murrayc@murrayc.com>
460 * src/modest-tny-account-store.c:
461 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
462 using a GError instead of a string message, so we can translate it in
465 2007-05-08 Murray Cumming <murrayc@murrayc.com>
467 * src/maemo/modest-address-book.c:
468 (modest_address_book_check_names):
469 * src/maemo/modest-msg-view-window.c:
470 (modest_msg_view_window_clipboard_owner_change):
471 * src/modest-init.c: (modest_init_init_ui):
472 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
473 (update_folders_cb), (modest_mail_operation_update_account):
474 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
475 (modest_ui_actions_on_msg_attachment_clicked),
476 (modest_ui_actions_on_msg_recpt_activated):
477 * src/widgets/modest-header-view.c: (drag_data_get_cb):
478 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
479 (modest_msg_view_search_next):
480 * src/widgets/modest-recpt-editor.c:
481 (modest_recpt_editor_on_button_release_event),
482 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
483 g_message(). At this point we should only be seeing interesting errors on
484 stdout. Debugging messages could be #ifdefed-out if they are still useful.
486 2007-05-07 Murray Cumming <murrayc@murrayc.com>
488 (modest_wizard_dialog_force_title_update):
489 * src/maemo/easysetup/modest-wizard-dialog.h:
490 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
491 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
492 can update the title when appropriate. Otherwise the title is wrong if the
493 pages are added after adding the notebook to the dialog.
494 This must be a problem in HildonWizardDialog too.
495 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
497 * src/maemo/easysetup/modest-easysetup-wizard.c:
498 (create_subsequent_customsetup_pages),
499 (create_subsequent_easysetup_pages):
500 Call modest_wizard_dialog_force_title_update() so that the title is
501 correct even with GTK+ < 2.10.
502 This fixes projects.maemo.org bug NB#56145 .
504 2007-05-07 Murray Cumming <murrayc@murrayc.com>
506 * src/maemo/modest-platform.c:
507 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
508 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
511 2007-05-07 Murray Cumming <murrayc@murrayc.com>
513 * src/widgets/modest-window.h:
514 * src/widgets/modest-window.c: Added a save_state_func vfunc,
515 and modest_window_save_state(), which invokes it.
517 * src/widgets/modest-window-mgr.h:
518 * src/widgets/modest-window-mgr.c:
519 Added modest_window_mgr_save_state_for_all_windows(), which calls
520 the save_state vfunc on all registered windows, if implemented.
522 * src/gnome/modest-msg-edit-window.c:
523 * src/gnome/modest-msg-view-window.c:
524 * src/maemo/modest-msg-edit-window.c:
525 * src/maemo/modest-msg-view-window.c:
526 * src/maemo/modest-main-window.c:
527 Specify the existing save_settings functions as implementations of
528 ModestWindow::save_state_func().
530 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
531 Call modest_window_mgr_save_state_for_all_windows(). This happens before
532 enabling hibernation, for instance.
534 We may need to do the same thing for restoring settings.
537 2007-05-07 Murray Cumming <murrayc@murrayc.com>
539 * src/widgets/modest-window-mgr.c:
540 * src/widgets/modest-window-mgr.h:
541 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
542 modest_window_mgr_get_hibernation_is_prevented().
544 * src/maemo/modest-main-window.c:
545 (on_hildon_program_is_topmost_notify): Prevent hibernation
546 (possible when the application goes to the background in the WM),
547 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
549 * src/maemo/easysetup/modest-easysetup-wizard.c:
550 (modest_easysetup_wizard_dialog_init):
551 * src/maemo/modest-account-settings-dialog.c:
552 (modest_account_settings_dialog_init):
553 * src/maemo/modest-connection-specific-smtp-edit-window.c:
554 (modest_connection_specific_smtp_edit_window_init):
555 * src/maemo/modest-connection-specific-smtp-window.c:
556 (modest_connection_specific_smtp_window_init):
557 * src/maemo/modest-signature-editor-dialog.c:
558 (modest_signature_editor_dialog_init):
559 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
560 prevent hibernation while any of these account settings dialogs are open.
562 2007-05-04 Murray Cumming <murrayc@murrayc.com>
564 * src/maemo/Makefile.am:
565 * src/maemo/modest-osso-state-saving.c:
566 * src/maemo/modest-osso-state-saving.h: Added
567 modest_osso_load_state() and modest_osso_save_state() though they do
568 nothing now. They should iterate through all the open windows and load/save
570 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
571 save state when closing.
573 * src/maemo/modest-main-window.c:
574 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
575 Add a notification handler for the HildonProgram::is-topmost property,
576 so we can allow hibernation when the application goes into the background.
577 But we still need to detect when the accounts setup windows are open so
578 we can stop hibernation when they are open.
579 To do this, I also added the main window the HildonProgram. This might have
580 other side-effects/benefits, and should maybe be done for other windows.
582 * src/maemo/modest-osso-autosave-callbacks.h:
583 * src/maemo/modest-osso-autosave-callbacks.c:
584 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
585 though it does not do anything yet, and we might never need this to do
586 anything. For instance, we already save drafts.
588 * src/maemo/modest-platform.c: (modest_platform_init):
589 Specify the libosso auto-save callback.
591 2007-05-03 Murray Cumming <murrayc@murrayc.com>
593 * src/maemo/modest-platform.c:
594 (modest_platform_set_update_interval):
595 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
596 aparently stays valid between application instances, so we can use this
597 to remove and reset it later. According to a maemo-developers email from
600 2007-05-03 Murray Cumming <murrayc@murrayc.com>
602 * configure.ac: Depend on libalarm for Maemo.
604 * src/dbus_api/modest-dbus-api.h:
605 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
606 (on_send_receive), (modest_dbus_req_handler):
607 Handle a SEND_RECEIVE D-Bus method.
609 * libmodest-dbus-client/libmodest-dbus-client.c:
610 (libmodest_dbus_client_send_and_receive):
611 * libmodest-dbus-client/libmodest-dbus-client.h:
612 Add C convenience functions for calling the new D-Bus method.
614 * src/modest-platform.h:
615 * src/gnome/modest-platform.c:
616 * src/maemo/modest-platform.c:
617 Added modest_platform_set_update_interval(), which uses the
619 (modest_platform_init),
620 Call modest_platform_set_update_interval(), using a hard-coded
621 interval for now (until the global settings dialog is implemented),
622 though I am not sure that this makes sense yet.
624 2007-05-02 Murray Cumming <murrayc@murrayc.com>
626 * src/dbus_api/modest-dbus-callbacks.c:
627 (modest_osso_cb_hw_state_handler):
628 * src/dbus_api/modest-dbus-callbacks.h:
629 * src/maemo/modest-platform.c: (modest_platform_init):
630 Registered (empty) callbacks for the osso hardware state D-Bus signals,
631 in case this has some effect on the ability for Maemo to ping the
634 2007-05-02 Murray Cumming <murrayc@murrayc.com>
636 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
637 Comment out an if() that checks a gchar for < 0, causing a build-breaking
638 warning. It is probably a logic error, but I need to fix the build.
640 2007-05-02 Murray Cumming <murrayc@murrayc.com>
642 * src/modest-account-mgr.h:
643 * src/modest-account-mgr.c:
644 (modest_account_mgr_account_names): Add a gboolean enabled_only
645 parameter, so we can get lists of onlt the enabled accounts.
647 (modest_account_mgr_add_account),,
648 (modest_account_mgr_account_with_display_name_exists):
649 * src/maemo/modest-msg-edit-window.c: (get_transports):
650 * src/modest-account-mgr-helpers.c:
651 (modest_account_mgr_set_first_account_as_default):
652 * src/modest-init.c: (init_default_account_maybe):
653 * src/modest-tny-account-store.c: (get_accounts):
654 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
655 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
656 * tests/check_account-mgr.c: (START_TEST):
657 Provide the extra parameter, as appropriate.
659 * src/widgets/modest-account-view.c: (update_account_view):
660 Do not show disabled accounts (meaning that there is no way to
661 enable/disable accounts in the UI (the feature is not in our UI
662 specification), so we can use this internally only to mark unfinished
663 or temporary account data.
665 * src/maemo/easysetup/modest-easysetup-wizard.c:
666 (create_account): Add boolean enable parameter, so we can specify FALSE
667 to create the temporary account.
668 (on_button_edit_advanced_settings): Create the temporary account as disabled.
669 (on_before_next): When finishing, when there is a temporary account, just
671 Also, use a timeout to delay the showing of the dialog until gconf is likely
672 to return correct information, due to a maemo gconf bug that is fixed in
673 osso 1.1, but not yet in Bora.
674 However, the dialog stays on screen after it is destroyed.
676 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
677 for invalid data when cancelling. Use a hildon note instead of a dialog
678 to complain about invalid data. Do not show the account-saved note if the
679 account is disabled (a temporary account that will not really be saved for use
682 2007-04-30 Murray Cumming <murrayc@murrayc.com>
684 * src/modest-account-mgr-helpers.h:
685 * src/modest-account-mgr-helpers.c:
686 Added modest_account_mgr_unset_default_account(),
687 Added modest_account_mgr_set_first_account_as_default().
689 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
690 If it was the default account, unset the default account name.
692 * src/maemo/modest-account-view-window.c:
693 (on_delete_button_clicked): If it was the default account,
694 set the first remaining account as the default instead.
696 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
697 a NULL account or a NULL default account, to prevent a crash. This should
698 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
701 2007-04-30 Murray Cumming <murrayc@murrayc.com>
703 * src/widgets/modest-recpt-editor.c:
704 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
705 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
706 TODO comment for this. This fixes the build.
708 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
709 be the best place for it. This will in future update all auto-update accounts,
710 rather than just the current/default account, when that gconf key exists.
711 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
712 if there are no accounts, before calling do_send_receive().
713 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
715 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
716 * src/maemo/modest-main-window-ui.h:
717 * src/maemo/modest-main-window.c: (on_connection_changed),
718 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
719 directly, becaue the signal handler does more.
721 2007-04-30 Murray Cumming <murrayc@murrayc.com>
723 * src/modest-account-mgr-helpers.c:
724 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
725 for the case that the account does not exist.
727 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
728 (equivalent to the modest account name) rather than the tinymail account name
729 (equivalent to the modest account title - human readable) to get the account data.
730 Check for null account data to prevent the crash, and add a TODO comment saying that
731 this needs fixing because it is using the server account name instead of the account name.
733 2007-04-29 Murray Cumming <murrayc@murrayc.com>
735 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
736 * src/maemo/modest-account-settings-dialog.c: (show_error),
738 Use hildon_note_new_information() for informative and error messages,
739 which seems to be expected for Maemo applications (no documentation that I know of
740 says this). I am surprised that there is no distinction between info and error
743 2007-04-29 Murray Cumming <murrayc@murrayc.com>
745 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
746 it is easy to find where this is used.
748 * src/maemo/easysetup/modest-easysetup-wizard.c:
749 (create_page_welcome), (create_page_account_details),
750 (create_page_user_details), (create_page_complete_easysetup),
751 (create_page_custom_incoming), (create_page_custom_outgoing),
752 (create_page_complete_custom):
753 * src/maemo/modest-account-settings-dialog.c:
754 (create_page_account_details), (create_page_user_details),
755 (create_page_incoming), (create_page_outgoing):
756 * src/maemo/modest-account-view-window.c: (window_vbox_new):
757 * src/maemo/modest-connection-specific-smtp-edit-window.c:
758 (modest_connection_specific_smtp_edit_window_init):
759 * src/maemo/modest-connection-specific-smtp-window.c:
760 (modest_connection_specific_smtp_window_init):
761 * src/maemo/modest-signature-editor-dialog.c:
762 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
763 and scrolling policy as per the Email Application Layout Guide, if I have
766 2007-04-27 Murray Cumming <murrayc@murrayc.com>
768 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
769 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
770 which were empty, because these vfuncs have been removed from TnyAccountStore.
771 This fixes the build.
773 2007-04-27 Murray Cumming <murrayc@murrayc.com>
775 * src/maemo/modest-main-window.c:
776 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
777 showing/hiding it. Added TODO because it probably should not be NULL.
778 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
779 because unnecessary g_warnings() make degugging difficult.
781 2007-04-27 Murray Cumming <murrayc@murrayc.com>
783 * src/maemo/modest-msg-edit-window.c:
784 (modest_msg_edit_window_select_color),
785 (modest_msg_edit_window_select_background_color): 2 const corrections and
786 moving 2 #endifs before closing brackets, to fix the build.
788 2007-04-27 Murray Cumming <murrayc@murrayc.com>
790 * src/maemo/easysetup/modest-easysetup-wizard.h:
791 * src/maemo/easysetup/modest-easysetup-wizard.c:
792 (modest_easysetup_wizard_dialog_finalize),
793 (on_button_edit_advanced_settings), (create_page_complete_custom),
794 (on_response), (create_account):
795 Implement the Advanced Settings edit button, by saving the account information,
796 for the Advanded Settings dialog to use directly from gconf, and removing it
797 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
798 Bug #5533 in the projects.maemo.org bugzilla.
800 2007-04-27 Murray Cumming <murrayc@murrayc.com>
802 * src/maemo/modest-msg-view-window.c:
803 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
804 when opening a message window.
806 2007-04-27 Murray Cumming <murrayc@murrayc.com>
808 * src/maemo/easysetup/modest-easysetup-wizard.c:
809 (create_page_custom_outgoing): Correct the position of the horizontal separator to
812 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
813 before showing/hiding them, to avoid a crash when clicking on folders when there are no
814 gconf settings. I probably added more checks than necessary, but that is safer.
816 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
817 variable to fix the build, but this seems to be used when it is still NULL.
819 2007-04-27 Murray Cumming <murrayc@murrayc.com>
821 * src/modest-platform.h:
822 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
823 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
824 * src/modest-main.c: Implement this function so we can avoid using
825 maemo-specific API from cross-platform code.
827 * src/modest-tny-account-store.c:
828 (get_smtp_specific_transport_account_for_open_connection):
829 * src/modest-ui-actions.c: (check_for_connection),
830 (modest_ui_actions_on_item_not_found):
831 Use modest_platform_connect_and_wait() and put #idefs around other
832 maemo-specific code, because only maemo currently has a way to
833 identify connection names.
835 2007-04-27 Murray Cumming <murrayc@murrayc.com>
837 * src/modest-tny-account-store.h:
838 * src/modest-tny-account-store.c:
839 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
840 the connection-specific SMTP server settings in the configuration.
842 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
844 * src/maemo/modest-main-window.c: (on_connection_changed),
846 * src/modest-main.c: (main), (start_ui), (send_mail):
847 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
848 that is what is intended.
850 * src/modest-ui-actions.c: (action_send), (action_receive),
851 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
852 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
853 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
854 SMTP server is used when it is specified.
856 (modest_ui_actions_on_send_receive):
857 Check that a connection is open before proceeding.
858 Receive and then send, instead of vice-versa, as per the specification.
860 2007-04-26 Murray Cumming <murrayc@murrayc.com>
862 * src/modest-mail-operation.c:
863 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
864 though I guess it should be something other than NULL.
866 2007-04-26 Murray Cumming <murrayc@murrayc.com>
868 * src/maemo/easysetup/modest-easysetup-wizard.c:
869 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
870 combo twice, to avoid an g_warning and to make it visible again.
871 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
872 attached before detaching it, to avoid a g_warning, and add comment about the implicit
873 (already intended) dereference when detaching, because we then recreate the menu.
874 But I am not sure why the warning was happening, and it is possible that this is a memory
877 2007-04-25 Murray Cumming <murrayc@murrayc.com>
879 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
880 and uri_parse_mailto() utility functions.
881 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
883 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
885 2007-04-24 Murray Cumming <murrayc@murrayc.com>
887 * src/dbus_api/modest-dbus-api.h:
888 * src/dbus_api/modest-dbus-callbacks.c:
889 Use an idle callback to execute the modest code in the application's own thread.
890 Remove the helloworld example method.
891 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
892 parsed, and the open-message method is not implemented because this is not yet implemented in
894 * libmodest-dbus-client/libmodest-dbus-client.c:
895 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
896 (libmodest_dbus_client_open_message):
897 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
899 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
900 body without crashing.
902 * tests/dbus_api/Makefile.am:
903 * tests/dbus_api/test_mail_to.c:
904 * tests/dbus_api/test_open_message.c: New tests for the new methods.
906 2007-04-24 Murray Cumming <murrayc@murrayc.com>
908 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
909 Added file to fix the build. Sorry.
911 * src/dbus_api/Makefile.am:
912 * src/dbus_api/modest-dbus-api.h:
913 * src/dbus_api/modest-dbus-callbacks.h:
914 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
915 (modest_dbus_req_handler):
916 Put constants in a separate header so it can be reused by the
917 client library, without duplication
919 * libmodest-dbus-client/Makefile.am:
920 * libmodest-dbus-client/libmodest-dbus-client.c:
921 (libmodest_dbus_client_call_helloworld),
922 (libmodfest_dbus_client_send_mail),
923 (libmodfest_dbus_client_mailto),
924 (libmodfest_dbus_client_open_message):
925 * libmodest-dbus-client/libmodest-dbus-client.h:
926 (Partly) Implement a send_mail D-Bus method.
928 * tests/dbus_api/Makefile.am:
929 * tests/dbus_api/test_send_mail.c: (main): Added a test for
930 the send_email D-Bus method.
932 2007-04-24 Murray Cumming <murrayc@murrayc.com>
936 * libmodest-dbus-client/Makefile.am:
937 * libmodest-dbus-client/libmodest-dbus-client.c:
938 * libmodest-dbus-client/libmodest-dbus-client.h:
939 * tests/dbus_api/Makefile.am:
940 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
941 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
943 2007-04-24 Murray Cumming <murrayc@murrayc.com>
945 * src/maemo/easysetup/modest-easysetup-wizard.c:
946 (create_page_account_details):
947 * src/maemo/modest-account-settings-dialog.c:
948 (create_page_account_details): Explicitly set auto-capitalization mode for the title
949 widgets, because this might not be the default in future versions of the Maemo GTK+.
950 However, I can not not get capitalization to work even in a simple test case.
952 2007-04-24 Murray Cumming <murrayc@murrayc.com>
954 * src/maemo/easysetup/modest-easysetup-wizard.c:
955 (create_page_custom_incoming), (create_page_custom_outgoing):
956 * src/maemo/modest-account-settings-dialog.c:
957 (create_page_account_details), (create_page_incoming),
958 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
959 instead of using gtk_check_button_with_label(), so they are aligned like the other
960 widgets, as per the UI spec.
962 2007-04-24 Murray Cumming <murrayc@murrayc.com>
964 * src/maemo/easysetup/modest-easysetup-wizard.c:
965 * src/maemo/modest-connection-specific-smtp-edit-window.c:
966 * src/widgets/modest-validating-entry.c:
967 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
968 Modest prefix instead of an EasySetup prefix.
970 2007-04-23 Murray Cumming <murrayc@murrayc.com>
972 * src/widgets/modest-validating-entry.h:
973 * src/widgets/modest-validating-entry.c: (on_insert_text),
974 Added easysetup_validating_entry_set_max_func(), used to set a callback
975 to call when the max number of characters is reached. GtkEntry has a max-length
976 already but is silent about it.
978 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
979 (create_page_account_details), (create_page_user_details),
981 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
982 (create_page_account_details), (create_page_user_details),
983 (create_page_outgoing):
984 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
985 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
986 the UI spec, when the user tries to enter more than the max number of characters.
988 2007-04-23 Murray Cumming <murrayc@murrayc.com>
990 * src/maemo/easysetup/modest-easysetup-wizard.c:
991 (create_page_user_details), (create_page_custom_incoming),
992 (create_page_custom_outgoing):
993 * src/maemo/modest-account-settings-dialog.c:
994 (create_page_user_details), (create_page_incoming),
995 (create_page_outgoing):
996 * src/maemo/modest-connection-specific-smtp-edit-window.c:
997 (modest_connection_specific_smtp_edit_window_init):
998 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
999 not appropriate. Bad Maemo-specific defaults!.
1001 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1003 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1004 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1005 (modest_signature_editor_dialog_set_settings):
1006 Disable the label and textview when the checkbox is disabled, and use the
1007 specified (UI spec) default signature text.
1009 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1011 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1012 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1014 * src/modest-defs.h:
1015 * src/modest-account-mgr-helpers.h:
1016 * src/modest-account-mgr-helpers.c:
1017 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1019 * src/maemo/Makefile.am:
1020 * src/maemo/modest-signature-editor-dialog.c:
1021 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1024 * src/maemo/modest-account-settings-dialog.h:
1025 * src/maemo/modest-account-settings-dialog.c:
1026 (modest_account_settings_dialog_finalize), (on_button_signature),
1027 (save_configuration): Use the new dialog when the Edit button is pressed, and
1028 save the changes if necessary, as per the UI spec.
1030 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1032 * src/maemo/Makefile.am:
1033 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1034 based on maemo-develoers email from Dirk.
1036 * src/maemo/easysetup/modest-easysetup-wizard.c:
1037 (create_page_welcome), (create_page_account_details),
1038 (create_page_user_details), (create_page_complete_easysetup),
1039 (create_page_custom_incoming), (create_page_custom_outgoing),
1040 (create_page_complete_custom),
1041 (modest_easysetup_wizard_dialog_init):
1042 * src/maemo/modest-account-settings-dialog.c:
1043 (create_page_account_details), (create_page_user_details),
1044 (create_page_incoming), (create_page_outgoing),
1045 (modest_account_settings_dialog_init):
1046 * src/maemo/modest-connection-specific-smtp-window.c:
1047 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1049 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1051 * src/maemo/easysetup/modest-easysetup-wizard.c:
1052 (create_page_account_details), (create_page_custom_outgoing),
1053 (create_page_complete_custom):
1054 * src/maemo/modest-account-settings-dialog.c:
1055 (create_page_user_details), (create_page_incoming),
1056 (create_page_outgoing):
1057 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1058 (modest_connection_specific_smtp_edit_window_init):
1059 Use the correct (UI spec) port min/max, and use horizontal separators,
1062 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1064 * src/maemo/easysetup/modest-easysetup-wizard.c:
1065 (set_default_custom_servernames):
1066 * src/maemo/modest-account-settings-dialog.c:
1067 (create_page_incoming), (on_combo_outgoing_security_changed),
1068 (on_combo_incoming_security_changed), (create_page_outgoing),
1069 (modest_account_settings_dialog_set_account_name),
1070 (save_configuration):
1071 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1072 (on_combo_security_changed),
1073 (modest_connection_specific_smtp_edit_window_init),
1074 (modest_connection_specific_smtp_edit_window_set_connection),
1075 (modest_connection_specific_smtp_edit_window_get_settings):
1076 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1079 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1082 * src/maemo/easysetup/modest-easysetup-wizard.c:
1083 (create_page_custom_outgoing), (create_page_complete_custom):
1084 * src/maemo/modest-account-settings-dialog.c:
1085 (create_page_user_details), (create_page_outgoing):
1086 * src/maemo/modest-account-view-window.c: (button_box_new):
1087 Use changed logical IDs as per the most recent UI spec:
1088 mcen_bd_emailsetup_edit -> mcen_bd_edit
1089 mcen_bd_emailsetup_delete -> mcen_bd_delete
1090 mcen_bd_emailsetup_close -> mcen_bd_close
1092 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1096 * src/dbus_api/Makefile.am:
1097 * src/dbus_api/modest-dbus-callbacks.c:
1098 * src/dbus_api/modest-dbus-callbacks.h:
1099 * src/maemo/modest-platform.c: (modest_platform_init):
1100 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1102 * tests/Makefile.am:
1103 * tests/dbus_api/Makefile.am:
1104 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1106 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1108 * src/maemo/modest-account-settings-dialog.c:
1109 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1110 Removed unnecessary includes.
1112 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1114 * src/maemo/easysetup/modest-easysetup-wizard.c:
1115 * src/maemo/modest-account-settings-dialog.c:
1116 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1117 * src/widgets/Makefile.am:
1118 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1119 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1120 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1121 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1122 * src/widgets/modest-secureauth-combo-box.c:
1123 * src/widgets/modest-secureauth-combo-box.h:
1124 * src/widgets/modest-serversecurity-combo-box.c:
1125 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1126 made the GObject names more consistent with the rest of the Modest code.
1128 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1130 * src/maemo/easysetup/Makefile.am:
1131 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1132 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1133 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1134 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1135 * src/maemo/easysetup/modest-easysetup-wizard.c:
1136 * src/maemo/easysetup/modest-validating-entry.c:
1137 * src/maemo/easysetup/modest-validating-entry.h:
1138 * src/maemo/modest-account-settings-dialog.c:
1139 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1140 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1141 widgets/ because they are used outside of easysetup too. After checking in,
1142 svn will allow me to rename them too.
1144 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1146 * src/gnome/modest-msg-edit-window.c:
1147 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1148 linker error, to fix the build on the GNOME platform.
1149 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1150 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1151 ifdefed out to avoid a warning.
1153 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1155 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1156 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1157 some alternative for GTK+ 2.6.
1159 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1161 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1163 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1164 specified for EmailAccountsDialog in UI spec.
1166 * src/maemo/easysetup/modest-easysetup-wizard.c:
1167 * src/maemo/easysetup/modest-easysetup-wizard.h:
1168 * src/maemo/modest-account-settings-dialog.c:
1169 * src/maemo/modest-account-settings-dialog.h:
1170 Reuse a member window widget for the connection-specific SMTP server accounts,
1171 so we can tell it to create/save the accounts only if we actually save changes.
1173 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1174 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1175 (modest_connection_specific_smtp_edit_window_get_settings):
1176 Return a struct instance for temporarily remembering the entered data.
1178 * src/maemo/modest-connection-specific-smtp-window.h:
1179 * src/maemo/modest-connection-specific-smtp-window.c:
1180 (modest_connection_specific_smtp_window_finalize),
1181 (modest_connection_specific_smtp_window_fill_with_connections),
1183 (modest_connection_specific_smtp_window_save_server_accounts),
1184 (update_model_server_names): Do not actually save data until asked,
1185 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1187 (on_selection_changed),
1188 (modest_connection_specific_smtp_window_init): Disable the edit
1189 button when nothing is selected.
1191 * src/modest-account-mgr-helpers.c:
1192 * src/modest-account-mgr-helpers.h:
1193 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1196 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1198 * src/modest-account-mgr-helpers.h:
1199 * src/modest-account-mgr-helpers.c:
1200 (modest_account_mgr_get_unused_account_name),
1201 (modest_account_mgr_get_unused_account_display_name): Added these
1202 utility functions, to avoid code duplication.
1204 * src/maemo/easysetup/modest-easysetup-wizard.c:
1205 (create_page_account_details), (create_account):
1206 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1207 (on_combo_security_changed),
1208 (modest_connection_specific_smtp_edit_window_init),
1209 (modest_connection_specific_smtp_edit_window_save_settings):
1210 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1211 * src/maemo/modest-connection-specific-smtp-window.c:
1212 (modest_connection_specific_smtp_window_finalize),
1213 (modest_connection_specific_smtp_window_fill_with_connections),
1214 (on_button_edit), (modest_connection_specific_smtp_window_init):
1215 * src/maemo/modest-connection-specific-smtp-window.h:
1216 Implementing saving of connection-specific server accounts.
1218 But I need to refactor this so we can save the data for each
1219 possible connection-specific account and only actually create the server accounts
1220 when the easysetup finished, or the OK button is pressed on the account settings
1223 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1225 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1226 (on_combo_security_changed):
1227 (modest_connection_specific_smtp_edit_window_init):
1228 Auto-fill the port number as in the account settings.
1230 (modest_connection_specific_smtp_edit_window_set_connection):
1231 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1232 * src/maemo/modest-connection-specific-smtp-window.c:
1233 (fill_with_connections), (on_button_edit),
1234 (modest_connection_specific_smtp_window_init):
1235 Turn the edit window into a dialog to simplify the code, and
1236 set a WM hint as in a GtkDialog, because only a popup can be on top of
1237 another window in Maemo, and popups usually have no WM decoration.
1239 * src/modest-defs.h:
1240 * src/modest-account-mgr-helpers.c:
1241 (modest_account_mgr_set_connection_specific_smtp),
1242 (modest_account_mgr_remove_connection_specific_smtp),
1243 (modest_account_mgr_get_connection_specific_smtp):
1244 * src/modest-account-mgr-helpers.h: Some functions to write the
1245 connection-specific SMTP server information. Not yet used.
1248 * src/widgets/modest-folder-view.c: (text_cell_data):
1249 Fix a warning about an uninitialized variable.
1250 (on_configuration_key_changed): Put an #ifdef around the use
1251 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1253 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1255 * src/maemo/modest-account-settings-dialog.h:
1256 * src/maemo/modest-account-settings-dialog.c:
1257 Added connect_for_modified() utility function to mark the new modified boolean.
1259 (create_page_account_details), (create_page_user_details),
1260 (create_page_incoming), (create_page_outgoing), (on_response),
1261 (modest_account_settings_dialog_init),
1262 (modest_account_settings_dialog_set_account_name):
1263 Only warn about unsaved changes when there are actually unsaved changes.
1265 * src/modest-account-mgr-helpers.c:
1266 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1267 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1268 to get the data from there in future.
1270 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1272 * src/modest-defs.h:
1274 * src/modest-account-mgr-helpers.h:
1275 * src/modest-account-mgr-helpers.c:
1276 Store the security account setting in a single conf key instead of using
1277 the options list, so that the list is left for just the to-be-removed camel hack,
1278 and because gconf_client_set_list() is failing for some reason.
1280 * src/modest-account-mgr.c:
1281 (modest_account_mgr_add_server_account):
1282 * src/maemo/modest-account-settings-dialog.c:
1283 (modest_account_settings_dialog_set_account_name),
1284 (save_configuration): Use the renamed functions.
1287 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1289 * src/widgets/Makefile.am:
1290 * src/widgets/modest-limit-retrieve-combo-box.c:
1291 * src/widgets/modest-limit-retrieve-combo-box.h:
1292 * src/widgets/modest-retrieve-combo-box.c:
1293 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1294 the account settings dialog.
1296 * src/modest-defs.h:
1297 * src/modest-account-mgr-helpers.h:
1298 * src/modest-account-mgr-helpers.c:
1299 (modest_server_account_get_option_secure_auth),
1300 (modest_server_account_set_option_secure_auth):
1301 * src/modest-account-mgr.c:
1302 (modest_account_mgr_add_server_account):
1303 Use the existing AUTH_MECH conf key for the secure-auth setting,
1304 instead of putting it in the list options, because this was actually used already.
1306 * src/maemo/modest-account-settings-dialog.c:
1307 (create_page_account_details),
1308 (modest_account_settings_dialog_set_account_name),
1309 (save_configuration):
1310 * src/maemo/modest-account-settings-dialog.h:
1311 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1312 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1314 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1316 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1317 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1318 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1320 * src/modest-defs.h:
1321 * src/maemo/modest-account-settings-dialog.c:
1322 (create_page_incoming), (on_combo_outgoing_security_changed),
1323 (on_combo_incoming_security_changed), (create_page_outgoing),
1324 (modest_account_settings_dialog_set_account_name),
1325 (save_configuration): Load/Save the port number, and change it when the
1326 security combo changes, to suitable defaults.
1328 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1330 * src/modest-account-mgr.c:
1331 (modest_account_mgr_add_server_account): Set the security and secure-auth
1332 options, and add a comment saying that the other camel-specific options should be
1335 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1337 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1339 * src/modest-tny-account-store.c: (account_list_free),
1340 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1341 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1344 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1346 * src/modest-protocol-info.c:
1347 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1348 is required by our UI spec. Maybe something in our implementation will use this eventually.
1349 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1350 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1351 instead of the previous 0 placeholder.
1353 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1354 secure-auth settings.
1355 * src/modest-account-mgr-helpers.h:
1356 * src/modest-account-mgr-helpers.c:
1357 (modest_server_account_data_get_option_secure_auth),
1358 (modest_server_account_set_option_secure_auth),
1359 (modest_server_account_data_get_option_security),
1360 (modest_server_account_set_option_security): Added this API for getting and setting the security
1361 and secure-auth settings.
1363 * src/maemo/modest-account-settings-dialog.h:
1364 * src/maemo/modest-account-settings-dialog.c:
1365 (modest_account_settings_dialog_finalize), (check_data),
1366 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1367 about changing titles.
1368 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1369 (save_configuration): Save the security and secure-auth settings.
1371 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1372 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1374 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1376 * src/modest-defs.h:
1377 * src/modest-account-mgr.c:
1378 (modest_account_mgr_add_server_account):
1379 Added and used defines for the options key and value pair strings,
1380 that are used so far, though they do not seem to correspond to anything in our
1381 UI specs or ModestProtocol enum.
1383 * src/modest-account-mgr-helpers.h:
1384 * src/modest-account-mgr-helpers.c:
1385 (compare_option_strings_for_name),
1386 (modest_server_account_data_get_option_value),
1387 (modest_server_account_data_get_option_bool),
1388 (modest_account_mgr_get_server_account_option):
1389 Added helper functions for parsing the options GSList.
1391 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1393 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1394 display name is based on the supplied account name.
1395 * src/modest-account-mgr.c:
1396 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1397 with an inefficient, but good-enough, implementation.
1399 * src/maemo/easysetup/modest-easysetup-wizard.c:
1400 (create_page_account_details), (on_before_next), (create_account):
1401 Check for existing display names rather than (non-user-visible) account names, and just
1402 create and set a unique account name at the end.
1404 * src/maemo/modest-account-settings-dialog.c:
1405 (modest_account_settings_dialog_init),
1406 (modest_account_settings_dialog_set_account_name),
1407 (create_page_incoming): Show the display name, instead of the account name.
1408 (on_response): Do some (not all) extra checks, as in the UI spec.
1409 (save_configuration): Save the display name if it was changed.
1411 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1413 * po/en_GB.po: Added needed logical ID and translation.
1414 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1415 (init_view): Made the is-default column clicking work.
1417 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1420 * src/maemo/easysetup/Makefile.am:
1421 * src/maemo/easysetup/modest-easysetup-wizard.c:
1422 (modest_easysetup_wizard_dialog_init):
1423 * src/maemo/easysetup/provider-data-test.keyfile:
1424 * src/maemo/easysetup/provider-data.keyfile:
1425 Moved the provider data file to the new modest-providers-data package and used it from there.
1427 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1429 * src/modest-local-folder-info.c:
1430 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1431 N_() was already used on the static strings, but this just marks it for translation without
1432 using the translation.
1434 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1436 * src/maemo/modest-account-settings-dialog.c:
1437 (create_page_incoming),
1438 (modest_account_settings_dialog_set_account_name):
1439 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1440 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1441 I will do this if nobody else gets there first.
1443 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1445 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1446 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1447 save the security stuff.
1449 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1451 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1452 Set the email address and user fullname, which I now see must be
1455 * src/maemo/modest-account-settings-dialog.h:
1456 * src/maemo/modest-account-settings-dialog.c:
1458 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1459 leave-on-server and authentication.
1460 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1463 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1466 * src/maemo/modest-account-settings-dialog.c:
1467 * src/maemo/modest-account-settings-dialog.h:
1468 Most (but not all) of the widgets are now present as specified by the UI spec.
1469 No changes are yet saved, and some details are not properly shown yet.
1471 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1473 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1475 * src/maemo/Makefile.am:
1476 * src/maemo/modest-account-settings-dialog.c:
1477 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1478 an existing account. Doesn't do much yet.
1480 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1481 Open the accounts settings dialog when Edit is clicked.
1483 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1485 * src/maemo/easysetup/Makefile.am:
1486 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1488 * src/maemo/easysetup/modest-easysetup-wizard.c:
1489 (modest_easysetup_wizard_dialog_init):
1490 Try to get the source directory from the build system,
1491 instead of hard-coding "./" into the source code, when opening our local
1492 copies of the configuration files.
1493 But this still fails when opening the wizard from the Accounts window,
1494 maybe because the working directory seems to change at runtime.
1495 So the wizard will fail the second time unless you copy the files into their
1496 proper locations - see the stdout warnings for the paths.
1498 (create_page_account_details),(on_before_next):
1499 Check for existing non-server accounts instead of server accounts,
1500 so the default account name is useful again, and to prevent trying to
1503 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1504 Show the wizard when New is clicked.
1506 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1507 (init_view): Show the column headers, and show the columns that are
1508 specified in the UI specs. However, something in Maemo's GTK+ prevents
1509 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1510 change the default account. This is despite unsetting the special properties.
1512 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1514 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1515 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1516 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1517 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1518 to make that clearer.
1519 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1521 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1523 * src/maemo/modest-account-view-window.c:
1524 (modest_account_view_window_init),
1525 (modest_account_view_window_new):
1526 Use the same buttons as specified in the
1527 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1528 the existing widgets, which never had a chance of working.
1529 Put the ModestAccountView treeview in a scrolled window.
1530 Do not repeat the initialization in both _init() and _new().
1532 * src/widgets/modest-account-view.c: (update_account_view):
1533 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1534 this widget and window shows no accounts.
1536 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1538 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1540 * src/maemo/easysetup/modest-easysetup-wizard.c:
1541 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1542 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1543 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1546 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1547 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1548 accounts exist yet, as in the UI spec.
1550 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1552 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1554 * src/maemo/Makefile.am:
1555 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1556 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1557 New window for editing connection-specific smtp details.
1558 Not fully implemented.
1560 * src/maemo/modest-connection-specific-smtp-window.c:
1561 (modest_connection_specific_smtp_window_finalize) :
1562 unref the tree model.
1563 (on_button_edit): Show the edit window.
1565 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1567 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1570 * src/maemo/Makefile.am:
1571 * src/maemo/modest-connection-specific-smtp-window.c:
1572 * src/maemo/modest-connection-specific-smtp-window.h:
1573 New window for showing the list of connections, for connection-specific
1574 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1575 * src/maemo/easysetup/modest-easysetup-wizard.c:
1576 (create_page_custom_outgoing): Show the new window when the button is clicked.
1578 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1580 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1581 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1582 * src/maemo/modest-msg-edit-window.c:
1583 (modest_msg_edit_window_insert_image):
1584 * src/modest-conf.c: (modest_conf_key_escape):
1585 * src/modest-mail-operation.c:
1586 (modest_mail_operation_send_new_mail):
1587 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1588 (modest_ui_actions_on_new_account):
1589 * src/widgets/modest-attachment-view.c: (update_filename_request):
1590 * src/widgets/modest-mail-header-view.c:
1591 Corrected warnings that were breaking the build, by commenting out unused variables,
1592 and a function, and by including a header.
1594 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1596 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1597 so we can #ifdef around platform-specific code when necessary.
1598 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1599 to allow this to build for the GNOME platform too.
1601 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1603 * src/maemo/easysetup/modest-easysetup-wizard.c:
1604 Added util_increment_name() and used it in create_page_account_details()
1605 to make sure that the default account name is always a new name.
1607 (modest_easysetup_wizard_dialog_init),
1608 (set_default_custom_servernames): Some minor memory management fixes.
1610 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1614 * src/modest-runtime.c: (init_i18n): Restored the translation
1615 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1616 are defined in config.h, and the translations are installed.
1618 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1619 is defined for translation.
1621 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1623 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1625 * src/maemo/easysetup/modest-easysetup-wizard.c:
1626 (modest_easysetup_wizard_dialog_init):
1627 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1628 Use realistic paths (though they should use $prefix generically) to the
1629 mcc_mapping and provider-data.keyfile files which might work when they
1630 are installed by the future version of the operator-wizard package,
1631 and then fallback to paths in our source code, with an explanatory
1634 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1638 * src/maemo/Makefile.am:
1639 * src/maemo/easysetup/: Added files from the previously-exernal
1640 osso-modest-easysetup.
1641 * src/maemo/modest-main-window-ui.h:
1642 * src/modest-ui-actions.c:
1643 * src/modest-ui-actions.h:
1644 Added modest_ui_actions_on_new_account() as a signal handler for the
1645 New Account menu item. It shows the easysetup wizard.
1646 * po/en_GB.po: Added additional needed logical IDs and translations.
1648 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1649 Apparently ChangeLog is not used for some vague Nokia legal reasons.