git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/widgets/modest-account-view.h:
   4         * src/widgets/modest-account-view.c: (on_account_changed),
   5         (on_account_removed). Added a boolean flag, set/unset by
   6         modest_account_view_block_conf_updates(),
   7         modest_account_view_unblock_conf_updates() to prevent unnecessary
   8         updates, but this is not very useful because the gconf notifications are
   9         so delays (maybe only on Maemo Bora).
  10         So auto-updating is turned off, and these functions do an explicit
  11         update when necessary.
  12         However, something else is still doing too much work when adding/removing
  13         accounts, probably in another part of the application.
  14
  15         * src/maemo/modest-account-view-window.c:
  16         (on_delete_button_clicked), (on_edit_button_clicked),
  17         (on_new_button_clicked): Use the new functions.
  18
  19 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  20
  21         * src/modest-account-mgr-helpers.c:
  22         (modest_account_mgr_set_first_account_as_default):
  23         Sort the list of names alphabetically-by-title, so we choose the first one
  24         based on that.
  25         * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
  26         alphabetically by the title.
  27
  28         This fixes projects.maemo.org bug NB#56418 .
  29
  30         * src/modest-account-mgr-priv.c:
  31         (_modest_account_mgr_account_from_key):
  32         * src/modest-account-mgr.c: (on_key_change): Initialize variables to
  33         avoid a valgrind error, and possible random behaviour.
  34
  35 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  36
  37         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
  38         Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
  39         tinymail documentation to say that this can be expected.
  40         Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
  41         pretty, and should not happen, but I would prefer to know when it does.
  42
  43 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  44
  45         * configure.ac: When using the older hildon version, probably on Bora,
  46         require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
  47         to fix the build.
  48         * src/widgets/modest-attachment-view.c:
  49         (modest_attachment_view_set_part_default): Initialize variables, to fix the
  50         build.
  51
  52 2007-05-09  Marcus Bauer  <marcusb@openismus.com>
  53
  54         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
  55         Implemented the prototype. Can be tested with
  56         tests/dbus_api/test_open_message:
  57
  58 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  59
  60         * src/modest-tny-account-store.c:
  61         (modest_tny_account_store_instance_init), (get_password):
  62         * src/modest-ui-actions.c:
  63         (modest_ui_actions_on_password_requested):
  64         Do not store the password in gconf, because this function is called
  65         for non-remembered passwords. Actually use the cached (in the hash map)
  66         password instead of releasing it.
  67         The password will now not be remembered if it is asked via the protected
  68         password dialog, as per the UI spec.
  69
  70 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  71
  72         * src/modest-defs.h:
  73         * src/modest-account-mgr-helpers.h:
  74         * src/modest-account-mgr-helpers.c:
  75         Added modest_server_account_get_username_has_succeeded(),
  76         modest_server_account_set_username_has_succeeded().
  77         (modest_server_account_set_username),
  78         Reset the has-succeeded flag if the username changes.
  79
  80         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
  81         * src/maemo/modest-connection-specific-smtp-window.c:
  82         (modest_connection_specific_smtp_window_save_server_accounts):
  83         Use modest_server_account_set_username() instead of using
  84         modest_conf_set_string() directly, so that the has-succeeded flag is always
  85         reset.
  86
  87         * src/modest-ui-actions.c:
  88         (modest_ui_actions_on_password_requested): Dim the username entry if
  89         the username has ever worked, as per the UI spec.
  90
  91 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  92
  93         * src/modest-tny-account-store.c: (get_password):
  94         * src/modest-ui-actions.c:
  95         (modest_ui_actions_on_password_requested):
  96         Allow the username to be changed too, though there is more work to
  97         be done on exactly how this behaves.
  98
  99 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 100
 101         * src/modest-account-mgr-helpers.h:
 102         * src/modest-account-mgr-helpers.c:
 103         Added modest_account_mgr_get_display_name(),
 104         modest_server_account_get_username(),
 105         modest_server_account_set_username(),
 106         modest_server_account_set_password(),
 107         modest_server_account_get_hostname() functions so we do not need to
 108         use the conf API directly.
 109
 110         * src/maemo/modest-main-window.c: (connect_signals):
 111         Actually connect ot the ModestAccountStore::request-password signal,
 112         so that we show the dialog when the password is requested by Tinymail,
 113         for isntance if it is empty.
 114
 115         * src/modest-marshal.list:
 116         * src/modest-tny-account-store.c:
 117         (modest_tny_account_store_class_init), (get_password),
 118         (modest_tny_account_store_alert):
 119         * src/modest-tny-account-store.h:
 120         * src/modest-ui-actions.h:
 121         * src/modest-ui-actions.c:
 122         (modest_ui_actions_on_password_requested):
 123         Change the signal parameters, so it is obvious that we are providing
 124         the non human-readable server name, and receiving both the username
 125         and password, though changing of the username is not yet implemented.
 126         Change the dialog UI to match the Maemo UI specifications, with #idfefing
 127         for the GNOME version.
 128
 129         This should fix the projects.maemo.org bug NB#56209, though it does not
 130         work on Bora, because the gconf_client_get() for the password fails
 131         immediately after we save it with gconf_client_set().
 132
 133 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 134
 135         * configure.ac:
 136         * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
 137         caused an undefined symbol error:
 138         modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
 139
 140 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 141
 142         * src/modest-tny-account-store.c:
 143         (modest_tny_account_store_alert): Adapt to the changed tinymail API,
 144         using a GError instead of a string message, so we can translate it in
 145         Modest.
 146
 147 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 148
 149         * src/maemo/modest-address-book.c:
 150         (modest_address_book_check_names):
 151         * src/maemo/modest-msg-view-window.c:
 152         (modest_msg_view_window_clipboard_owner_change):
 153         * src/modest-init.c: (modest_init_init_ui):
 154         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
 155         (update_folders_cb), (modest_mail_operation_update_account):
 156         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
 157         (modest_ui_actions_on_msg_attachment_clicked),
 158         (modest_ui_actions_on_msg_recpt_activated):
 159         * src/widgets/modest-header-view.c: (drag_data_get_cb):
 160         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
 161         (modest_msg_view_search_next):
 162         * src/widgets/modest-recpt-editor.c:
 163         (modest_recpt_editor_on_button_release_event),
 164         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
 165         g_message(). At this point we should only be seeing interesting errors on
 166         stdout. Debugging messages could be #ifdefed-out if they are still useful.
 167
 168 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 169
 170         (modest_wizard_dialog_force_title_update):
 171         * src/maemo/easysetup/modest-wizard-dialog.h:
 172         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
 173         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
 174         can update the title when appropriate. Otherwise the title is wrong if the
 175         pages are added after adding the notebook to the dialog.
 176         This must be a problem in HildonWizardDialog too.
 177         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
 178
 179         * src/maemo/easysetup/modest-easysetup-wizard.c:
 180         (create_subsequent_customsetup_pages),
 181         (create_subsequent_easysetup_pages):
 182         Call modest_wizard_dialog_force_title_update() so that the title is
 183         correct even with GTK+ < 2.10.
 184         This fixes projects.maemo.org bug NB#56145 .
 185
 186 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 187
 188         * src/maemo/modest-platform.c:
 189         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
 190         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
 191         from being shown.
 192
 193 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 194
 195         * src/widgets/modest-window.h:
 196         * src/widgets/modest-window.c: Added a save_state_func vfunc,
 197         and modest_window_save_state(), which invokes it.
 198
 199         * src/widgets/modest-window-mgr.h:
 200         * src/widgets/modest-window-mgr.c:
 201         Added modest_window_mgr_save_state_for_all_windows(), which calls
 202         the save_state vfunc on all registered windows, if implemented.
 203
 204         * src/gnome/modest-msg-edit-window.c:
 205         * src/gnome/modest-msg-view-window.c:
 206         * src/maemo/modest-msg-edit-window.c:
 207         * src/maemo/modest-msg-view-window.c:
 208         * src/maemo/modest-main-window.c:
 209         Specify the existing save_settings functions as implementations of
 210         ModestWindow::save_state_func().
 211
 212         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
 213         Call modest_window_mgr_save_state_for_all_windows(). This happens before
 214         enabling hibernation, for instance.
 215
 216         We may need to do the same thing for restoring settings.
 217
 218
 219 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 220
 221         * src/widgets/modest-window-mgr.c:
 222         * src/widgets/modest-window-mgr.h:
 223         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
 224         modest_window_mgr_get_hibernation_is_prevented().
 225
 226         * src/maemo/modest-main-window.c:
 227         (on_hildon_program_is_topmost_notify): Prevent hibernation
 228         (possible when the application goes to the background in the WM),
 229         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
 230
 231         * src/maemo/easysetup/modest-easysetup-wizard.c:
 232         (modest_easysetup_wizard_dialog_init):
 233         * src/maemo/modest-account-settings-dialog.c:
 234         (modest_account_settings_dialog_init):
 235         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 236         (modest_connection_specific_smtp_edit_window_init):
 237         * src/maemo/modest-connection-specific-smtp-window.c:
 238         (modest_connection_specific_smtp_window_init):
 239         * src/maemo/modest-signature-editor-dialog.c:
 240         (modest_signature_editor_dialog_init):
 241         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
 242         prevent hibernation while any of these account settings dialogs are open.
 243
 244 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
 245
 246         * src/maemo/Makefile.am:
 247         * src/maemo/modest-osso-state-saving.c:
 248         * src/maemo/modest-osso-state-saving.h: Added
 249         modest_osso_load_state() and modest_osso_save_state() though they do
 250         nothing now. They should iterate through all the open windows and load/save
 251         their state.
 252         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 253         save state when closing.
 254
 255         * src/maemo/modest-main-window.c:
 256         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 257         Add a notification handler for the HildonProgram::is-topmost property,
 258         so we can allow hibernation when the application goes into the background.
 259         But we still need to detect when the accounts setup windows are open so
 260         we can stop hibernation when they are open.
 261         To do this, I also added the main window the HildonProgram. This might have
 262         other side-effects/benefits, and should maybe be done for other windows.
 263
 264         * src/maemo/modest-osso-autosave-callbacks.h:
 265         * src/maemo/modest-osso-autosave-callbacks.c:
 266         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 267         though it does not do anything yet, and we might never need this to do
 268         anything. For instance, we already save drafts.
 269
 270         * src/maemo/modest-platform.c: (modest_platform_init):
 271         Specify the libosso auto-save callback.
 272
 273 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 274
 275         * src/maemo/modest-platform.c:
 276         (modest_platform_set_update_interval):
 277         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 278         aparently stays valid between application instances, so we can use this
 279         to remove and reset it later. According to a maemo-developers email from
 280         David Weinehall.
 281
 282 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 283
 284         * configure.ac: Depend on libalarm for Maemo.
 285
 286         * src/dbus_api/modest-dbus-api.h:
 287         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 288         (on_send_receive), (modest_dbus_req_handler):
 289         Handle a SEND_RECEIVE D-Bus method.
 290
 291         * libmodest-dbus-client/libmodest-dbus-client.c:
 292         (libmodest_dbus_client_send_and_receive):
 293         * libmodest-dbus-client/libmodest-dbus-client.h:
 294         Add C convenience functions for calling the new D-Bus method.
 295
 296         * src/modest-platform.h:
 297         * src/gnome/modest-platform.c:
 298         * src/maemo/modest-platform.c:
 299         Added modest_platform_set_update_interval(), which uses the
 300         alarmd API on Maemo.
 301         (modest_platform_init),
 302         Call modest_platform_set_update_interval(), using a hard-coded
 303         interval for now (until the global settings dialog is implemented),
 304         though I am not sure that this makes sense yet.
 305
 306 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 307
 308         * src/dbus_api/modest-dbus-callbacks.c:
 309         (modest_osso_cb_hw_state_handler):
 310         * src/dbus_api/modest-dbus-callbacks.h:
 311         * src/maemo/modest-platform.c: (modest_platform_init):
 312         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 313         in case this has some effect on the ability for Maemo to ping the
 314         application.
 315
 316 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 317
 318         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 319         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 320         warning. It is probably a logic error, but I need to fix the build.
 321
 322 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 323
 324         * src/modest-account-mgr.h:
 325         * src/modest-account-mgr.c:
 326         (modest_account_mgr_account_names): Add a gboolean enabled_only
 327         parameter, so we can get lists of onlt the enabled accounts.
 328
 329         (modest_account_mgr_add_account),,
 330         (modest_account_mgr_account_with_display_name_exists):
 331         * src/maemo/modest-msg-edit-window.c: (get_transports):
 332         * src/modest-account-mgr-helpers.c:
 333         (modest_account_mgr_set_first_account_as_default):
 334         * src/modest-init.c: (init_default_account_maybe):
 335         * src/modest-tny-account-store.c: (get_accounts):
 336         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 337         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 338         * tests/check_account-mgr.c: (START_TEST):
 339         Provide the extra parameter, as appropriate.
 340
 341         * src/widgets/modest-account-view.c: (update_account_view):
 342         Do not show disabled accounts (meaning that there is no way to
 343         enable/disable accounts in the UI (the feature is not in our UI
 344         specification), so we can use this internally only to mark unfinished
 345         or temporary account data.
 346
 347         * src/maemo/easysetup/modest-easysetup-wizard.c:
 348         (create_account): Add boolean enable parameter, so we can specify FALSE
 349         to create the temporary account.
 350         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 351         (on_before_next): When finishing, when there is a temporary account, just
 352         set it as enabled.
 353         Also, use a timeout to delay the showing of the dialog until gconf is likely
 354         to return correct information, due to a maemo gconf bug that is fixed in
 355         osso 1.1, but not yet in Bora.
 356         However, the dialog stays on screen after it is destroyed.
 357
 358         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 359         for invalid data when cancelling. Use a hildon note instead of a dialog
 360         to complain about invalid data. Do not show the account-saved note if the
 361         account is disabled (a temporary account that will not really be saved for use
 362         until later.)
 363
 364 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 365
 366         * src/modest-account-mgr-helpers.h:
 367         * src/modest-account-mgr-helpers.c:
 368         Added modest_account_mgr_unset_default_account(),
 369         Added modest_account_mgr_set_first_account_as_default().
 370
 371         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 372         If it was the default account, unset the default account name.
 373
 374         * src/maemo/modest-account-view-window.c:
 375         (on_delete_button_clicked): If it was the default account,
 376         set the first remaining account as the default instead.
 377
 378         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 379         a NULL account or a NULL default account, to prevent a crash. This should
 380         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 381
 382
 383 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 384
 385         * src/widgets/modest-recpt-editor.c:
 386         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 387         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 388         TODO comment for this. This fixes the build.
 389
 390         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 391         be the best place for it. This will in future update all auto-update accounts,
 392         rather than just the current/default account, when that gconf key exists.
 393         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 394         if there are no accounts, before calling do_send_receive().
 395         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 396
 397         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 398         * src/maemo/modest-main-window-ui.h:
 399         * src/maemo/modest-main-window.c: (on_connection_changed),
 400         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 401         directly, becaue the signal handler does more.
 402
 403 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 404
 405         * src/modest-account-mgr-helpers.c:
 406         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 407         for the case that the account does not exist.
 408
 409         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 410         (equivalent to the modest account name) rather than the tinymail account name
 411         (equivalent to the modest account title - human readable) to get the account data.
 412         Check for null account data to prevent the crash, and add a TODO comment saying that
 413         this needs fixing because it is using the server account name instead of the account name.
 414
 415 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 416
 417         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 418         * src/maemo/modest-account-settings-dialog.c: (show_error),
 419         (show_ok):
 420         Use hildon_note_new_information() for informative and error messages,
 421         which seems to be expected for Maemo applications (no documentation that I know of
 422         says this). I am surprised that there is no distinction between info and error
 423         dialogs.
 424
 425 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 426
 427         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 428         it is easy to find where this is used.
 429
 430         * src/maemo/easysetup/modest-easysetup-wizard.c:
 431         (create_page_welcome), (create_page_account_details),
 432         (create_page_user_details), (create_page_complete_easysetup),
 433         (create_page_custom_incoming), (create_page_custom_outgoing),
 434         (create_page_complete_custom):
 435         * src/maemo/modest-account-settings-dialog.c:
 436         (create_page_account_details), (create_page_user_details),
 437         (create_page_incoming), (create_page_outgoing):
 438         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 439         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 440         (modest_connection_specific_smtp_edit_window_init):
 441         * src/maemo/modest-connection-specific-smtp-window.c:
 442         (modest_connection_specific_smtp_window_init):
 443         * src/maemo/modest-signature-editor-dialog.c:
 444         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 445         and scrolling policy as per the Email Application Layout Guide, if I have
 446         understood it.
 447
 448 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 449
 450         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 451         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 452         which were empty, because these vfuncs have been removed from TnyAccountStore.
 453         This fixes the build.
 454
 455 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 456
 457         * src/maemo/modest-main-window.c:
 458         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 459         showing/hiding it. Added TODO because it probably should not be NULL.
 460         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 461         because unnecessary g_warnings() make degugging difficult.
 462
 463 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 464
 465         * src/maemo/modest-msg-edit-window.c:
 466         (modest_msg_edit_window_select_color),
 467         (modest_msg_edit_window_select_background_color): 2 const corrections and
 468         moving 2 #endifs before closing brackets, to fix the build.
 469
 470 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 471
 472         * src/maemo/easysetup/modest-easysetup-wizard.h:
 473         * src/maemo/easysetup/modest-easysetup-wizard.c:
 474         (modest_easysetup_wizard_dialog_finalize),
 475         (on_button_edit_advanced_settings), (create_page_complete_custom),
 476         (on_response), (create_account):
 477         Implement the Advanced Settings edit button, by saving the account information,
 478         for the Advanded Settings dialog to use directly from gconf, and removing it
 479         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 480         Bug #5533 in the projects.maemo.org bugzilla.
 481
 482 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 483
 484         * src/maemo/modest-msg-view-window.c:
 485         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 486         when opening a message window.
 487
 488 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 489
 490         * src/maemo/easysetup/modest-easysetup-wizard.c:
 491         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 492         match the UI spec.
 493
 494         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 495         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 496         gconf settings. I probably added more checks than necessary, but that is safer.
 497
 498         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 499         variable to fix the build, but this seems to be used when it is still NULL.
 500
 501 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 502
 503         * src/modest-platform.h:
 504         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 505         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 506         * src/modest-main.c: Implement this function so we can avoid using
 507         maemo-specific API from cross-platform code.
 508         (main):
 509         * src/modest-tny-account-store.c:
 510         (get_smtp_specific_transport_account_for_open_connection):
 511         * src/modest-ui-actions.c: (check_for_connection),
 512         (modest_ui_actions_on_item_not_found):
 513         Use modest_platform_connect_and_wait() and put #idefs around other
 514         maemo-specific code, because only maemo currently has a way to
 515         identify connection names.
 516
 517 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 518
 519         * src/modest-tny-account-store.h:
 520         * src/modest-tny-account-store.c:
 521         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 522         the connection-specific SMTP server settings in the configuration.
 523
 524         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 525         (on_idle_mail_to):
 526         * src/maemo/modest-main-window.c: (on_connection_changed),
 527         (connect_signals):
 528         * src/modest-main.c: (main), (start_ui), (send_mail):
 529         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 530         that is what is intended.
 531
 532         * src/modest-ui-actions.c: (action_send), (action_receive),
 533         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 534         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 535         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 536         SMTP server is used when it is specified.
 537
 538         (modest_ui_actions_on_send_receive):
 539         Check that a connection is open before proceeding.
 540         Receive and then send, instead of vice-versa, as per the specification.
 541
 542 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 543
 544         * src/modest-mail-operation.c:
 545         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 546         though I guess it should be something other than NULL.
 547
 548 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 549
 550         * src/maemo/easysetup/modest-easysetup-wizard.c:
 551         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 552         combo twice, to avoid an g_warning and to make it visible again.
 553         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 554         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 555         (already intended) dereference when detaching, because we then recreate the menu.
 556         But I am not sure why the warning was happening, and it is possible that this is a memory
 557         leak.
 558
 559 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 560
 561         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 562         and uri_parse_mailto() utility functions.
 563         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 564         the mailto URI.
 565         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 566
 567 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 568
 569         * src/dbus_api/modest-dbus-api.h:
 570         * src/dbus_api/modest-dbus-callbacks.c:
 571         Use an idle callback to execute the modest code in the application's own thread.
 572         Remove the helloworld example method.
 573         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 574         parsed, and the open-message method is not implemented because this is not yet implemented in
 575         modest itself.
 576         * libmodest-dbus-client/libmodest-dbus-client.c:
 577         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 578         (libmodest_dbus_client_open_message):
 579         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 580
 581         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 582         body without crashing.
 583
 584         * tests/dbus_api/Makefile.am:
 585         * tests/dbus_api/test_mail_to.c:
 586         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 587
 588 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 589
 590         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 591         Added file to fix the build. Sorry.
 592
 593         * src/dbus_api/Makefile.am:
 594         * src/dbus_api/modest-dbus-api.h:
 595         * src/dbus_api/modest-dbus-callbacks.h:
 596         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 597         (modest_dbus_req_handler):
 598         Put constants in a separate header so it can be reused by the
 599         client library, without duplication
 600
 601         * libmodest-dbus-client/Makefile.am:
 602         * libmodest-dbus-client/libmodest-dbus-client.c:
 603         (libmodest_dbus_client_call_helloworld),
 604         (libmodfest_dbus_client_send_mail),
 605         (libmodfest_dbus_client_mailto),
 606         (libmodfest_dbus_client_open_message):
 607         * libmodest-dbus-client/libmodest-dbus-client.h:
 608         (Partly) Implement a send_mail D-Bus method.
 609
 610         * tests/dbus_api/Makefile.am:
 611         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 612         the send_email D-Bus method.
 613
 614 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 615
 616         * Makefile.am:
 617         * configure.ac:
 618         * libmodest-dbus-client/Makefile.am:
 619         * libmodest-dbus-client/libmodest-dbus-client.c:
 620         * libmodest-dbus-client/libmodest-dbus-client.h:
 621         * tests/dbus_api/Makefile.am:
 622         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 623         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 624
 625 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 626
 627         * src/maemo/easysetup/modest-easysetup-wizard.c:
 628         (create_page_account_details):
 629         * src/maemo/modest-account-settings-dialog.c:
 630         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 631         widgets, because this might not be the default in future versions of the Maemo GTK+.
 632         However, I can not not get capitalization to work even in a simple test case.
 633
 634 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 635
 636         * src/maemo/easysetup/modest-easysetup-wizard.c:
 637         (create_page_custom_incoming), (create_page_custom_outgoing):
 638         * src/maemo/modest-account-settings-dialog.c:
 639         (create_page_account_details), (create_page_incoming),
 640         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 641         instead of using gtk_check_button_with_label(), so they are aligned like the other
 642         widgets, as per the UI spec.
 643
 644 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 645
 646         * src/maemo/easysetup/modest-easysetup-wizard.c:
 647         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 648         * src/widgets/modest-validating-entry.c:
 649         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 650         Modest prefix instead of an EasySetup prefix.
 651
 652 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 653
 654         * src/widgets/modest-validating-entry.h:
 655         * src/widgets/modest-validating-entry.c: (on_insert_text),
 656         Added easysetup_validating_entry_set_max_func(), used to set a callback
 657         to call when the max number of characters is reached. GtkEntry has a max-length
 658         already but is silent about it.
 659
 660         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 661         (create_page_account_details), (create_page_user_details),
 662         (create_account):
 663         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 664         (create_page_account_details), (create_page_user_details),
 665         (create_page_outgoing):
 666         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 667         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 668         the UI spec, when the user tries to enter more than the max number of characters.
 669
 670 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 671
 672         * src/maemo/easysetup/modest-easysetup-wizard.c:
 673         (create_page_user_details), (create_page_custom_incoming),
 674         (create_page_custom_outgoing):
 675         * src/maemo/modest-account-settings-dialog.c:
 676         (create_page_user_details), (create_page_incoming),
 677         (create_page_outgoing):
 678         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 679         (modest_connection_specific_smtp_edit_window_init):
 680         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 681         not appropriate. Bad Maemo-specific defaults!.
 682
 683 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 684
 685         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 686         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 687         (modest_signature_editor_dialog_set_settings):
 688         Disable the label and textview when the checkbox is disabled, and use the
 689         specified (UI spec) default signature text.
 690
 691 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 692
 693         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 694         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 695
 696         * src/modest-defs.h:
 697         * src/modest-account-mgr-helpers.h:
 698         * src/modest-account-mgr-helpers.c:
 699         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 700
 701         * src/maemo/Makefile.am:
 702         * src/maemo/modest-signature-editor-dialog.c:
 703         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 704         as per the UI spec.
 705
 706         * src/maemo/modest-account-settings-dialog.h:
 707         * src/maemo/modest-account-settings-dialog.c:
 708         (modest_account_settings_dialog_finalize), (on_button_signature),
 709         (save_configuration): Use the new dialog when the Edit button is pressed, and
 710         save the changes if necessary, as per the UI spec.
 711
 712 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 713
 714         * src/maemo/Makefile.am:
 715         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 716         based on maemo-develoers email from Dirk.
 717
 718         * src/maemo/easysetup/modest-easysetup-wizard.c:
 719         (create_page_welcome), (create_page_account_details),
 720         (create_page_user_details), (create_page_complete_easysetup),
 721         (create_page_custom_incoming), (create_page_custom_outgoing),
 722         (create_page_complete_custom),
 723         (modest_easysetup_wizard_dialog_init):
 724         * src/maemo/modest-account-settings-dialog.c:
 725         (create_page_account_details), (create_page_user_details),
 726         (create_page_incoming), (create_page_outgoing),
 727         (modest_account_settings_dialog_init):
 728         * src/maemo/modest-connection-specific-smtp-window.c:
 729         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 730
 731 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 732
 733         * src/maemo/easysetup/modest-easysetup-wizard.c:
 734         (create_page_account_details), (create_page_custom_outgoing),
 735         (create_page_complete_custom):
 736         * src/maemo/modest-account-settings-dialog.c:
 737         (create_page_user_details), (create_page_incoming),
 738         (create_page_outgoing):
 739         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 740         (modest_connection_specific_smtp_edit_window_init):
 741         Use the correct (UI spec) port min/max, and use horizontal separators,
 742         as per the UI spec.
 743
 744 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 745
 746         * src/maemo/easysetup/modest-easysetup-wizard.c:
 747         (set_default_custom_servernames):
 748         * src/maemo/modest-account-settings-dialog.c:
 749         (create_page_incoming), (on_combo_outgoing_security_changed),
 750         (on_combo_incoming_security_changed), (create_page_outgoing),
 751         (modest_account_settings_dialog_set_account_name),
 752         (save_configuration):
 753         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 754         (on_combo_security_changed),
 755         (modest_connection_specific_smtp_edit_window_init),
 756         (modest_connection_specific_smtp_edit_window_set_connection),
 757         (modest_connection_specific_smtp_edit_window_get_settings):
 758         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 759         as per the UI spec.
 760
 761 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 762
 763         * po/en_GB.po:
 764         * src/maemo/easysetup/modest-easysetup-wizard.c:
 765         (create_page_custom_outgoing), (create_page_complete_custom):
 766         * src/maemo/modest-account-settings-dialog.c:
 767         (create_page_user_details), (create_page_outgoing):
 768         * src/maemo/modest-account-view-window.c: (button_box_new):
 769         Use changed logical IDs as per the most recent UI spec:
 770         mcen_bd_emailsetup_edit -> mcen_bd_edit
 771         mcen_bd_emailsetup_delete -> mcen_bd_delete
 772         mcen_bd_emailsetup_close -> mcen_bd_close
 773
 774 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 775
 776         * configure.ac:
 777         * src/Makefile.am:
 778         * src/dbus_api/Makefile.am:
 779         * src/dbus_api/modest-dbus-callbacks.c:
 780         * src/dbus_api/modest-dbus-callbacks.h:
 781         * src/maemo/modest-platform.c: (modest_platform_init):
 782         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 783         method.
 784         * tests/Makefile.am:
 785         * tests/dbus_api/Makefile.am:
 786         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 787
 788 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 789
 790         * src/maemo/modest-account-settings-dialog.c:
 791         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 792         Removed unnecessary includes.
 793
 794 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 795
 796         * src/maemo/easysetup/modest-easysetup-wizard.c:
 797         * src/maemo/modest-account-settings-dialog.c:
 798         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 799         * src/widgets/Makefile.am:
 800         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 801         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 802         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 803         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 804         * src/widgets/modest-secureauth-combo-box.c:
 805         * src/widgets/modest-secureauth-combo-box.h:
 806         * src/widgets/modest-serversecurity-combo-box.c:
 807         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 808         made the GObject names more consistent with the rest of the Modest code.
 809
 810 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 811
 812         * src/maemo/easysetup/Makefile.am:
 813         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 814         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 815         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 816         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 817         * src/maemo/easysetup/modest-easysetup-wizard.c:
 818         * src/maemo/easysetup/modest-validating-entry.c:
 819         * src/maemo/easysetup/modest-validating-entry.h:
 820         * src/maemo/modest-account-settings-dialog.c:
 821         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 822         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 823         widgets/ because they are used outside of easysetup too. After checking in,
 824         svn will allow me to rename them too.
 825
 826 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 827
 828         * src/gnome/modest-msg-edit-window.c:
 829         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 830         linker error, to fix the build on the GNOME platform.
 831         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 832         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 833         ifdefed out to avoid a warning.
 834
 835 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 836
 837         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 838         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 839         some alternative for GTK+ 2.6.
 840
 841 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 842
 843         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 844
 845         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 846         specified for EmailAccountsDialog in UI spec.
 847
 848         * src/maemo/easysetup/modest-easysetup-wizard.c:
 849         * src/maemo/easysetup/modest-easysetup-wizard.h:
 850         * src/maemo/modest-account-settings-dialog.c:
 851         * src/maemo/modest-account-settings-dialog.h:
 852         Reuse a member window widget for the connection-specific SMTP server accounts,
 853         so we can tell it to create/save the accounts only if we actually save changes.
 854
 855         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 856         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 857         (modest_connection_specific_smtp_edit_window_get_settings):
 858         Return a struct instance for temporarily remembering the entered data.
 859
 860         * src/maemo/modest-connection-specific-smtp-window.h:
 861         * src/maemo/modest-connection-specific-smtp-window.c:
 862         (modest_connection_specific_smtp_window_finalize),
 863         (modest_connection_specific_smtp_window_fill_with_connections),
 864         (on_button_edit),
 865         (modest_connection_specific_smtp_window_save_server_accounts),
 866         (update_model_server_names): Do not actually save data until asked,
 867         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 868
 869         (on_selection_changed),
 870         (modest_connection_specific_smtp_window_init): Disable the edit
 871         button when nothing is selected.
 872
 873         * src/modest-account-mgr-helpers.c:
 874         * src/modest-account-mgr-helpers.h:
 875         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 876         elsewhere.
 877
 878 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 879
 880         * src/modest-account-mgr-helpers.h:
 881         * src/modest-account-mgr-helpers.c:
 882         (modest_account_mgr_get_unused_account_name),
 883         (modest_account_mgr_get_unused_account_display_name): Added these
 884         utility functions, to avoid code duplication.
 885
 886         * src/maemo/easysetup/modest-easysetup-wizard.c:
 887         (create_page_account_details), (create_account):
 888         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 889         (on_combo_security_changed),
 890         (modest_connection_specific_smtp_edit_window_init),
 891         (modest_connection_specific_smtp_edit_window_save_settings):
 892         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 893         * src/maemo/modest-connection-specific-smtp-window.c:
 894         (modest_connection_specific_smtp_window_finalize),
 895         (modest_connection_specific_smtp_window_fill_with_connections),
 896         (on_button_edit), (modest_connection_specific_smtp_window_init):
 897         * src/maemo/modest-connection-specific-smtp-window.h:
 898         Implementing saving of connection-specific server accounts.
 899
 900         But I need to refactor this so we can save the data for each
 901         possible connection-specific account and only actually create the server accounts
 902         when the easysetup finished, or the OK button is pressed on the account settings
 903         dialog.
 904
 905 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 906
 907         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 908         (on_combo_security_changed):
 909         (modest_connection_specific_smtp_edit_window_init):
 910         Auto-fill the port number as in the account settings.
 911
 912         (modest_connection_specific_smtp_edit_window_set_connection):
 913         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 914         * src/maemo/modest-connection-specific-smtp-window.c:
 915         (fill_with_connections), (on_button_edit),
 916         (modest_connection_specific_smtp_window_init):
 917         Turn the edit window into a dialog to simplify the code, and
 918         set a WM hint as in a GtkDialog, because only a popup can be on top of
 919         another window in Maemo, and popups usually have no WM decoration.
 920
 921         * src/modest-defs.h:
 922         * src/modest-account-mgr-helpers.c:
 923         (modest_account_mgr_set_connection_specific_smtp),
 924         (modest_account_mgr_remove_connection_specific_smtp),
 925         (modest_account_mgr_get_connection_specific_smtp):
 926         * src/modest-account-mgr-helpers.h: Some functions to write the
 927         connection-specific SMTP server information. Not yet used.
 928
 929
 930         * src/widgets/modest-folder-view.c: (text_cell_data):
 931         Fix a warning about an uninitialized variable.
 932         (on_configuration_key_changed): Put an #ifdef around the use
 933         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 934
 935 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 936
 937         * src/maemo/modest-account-settings-dialog.h:
 938         * src/maemo/modest-account-settings-dialog.c:
 939         Added connect_for_modified() utility function to mark the new modified boolean.
 940
 941         (create_page_account_details), (create_page_user_details),
 942         (create_page_incoming), (create_page_outgoing), (on_response),
 943         (modest_account_settings_dialog_init),
 944         (modest_account_settings_dialog_set_account_name):
 945         Only warn about unsaved changes when there are actually unsaved changes.
 946
 947         * src/modest-account-mgr-helpers.c:
 948         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 949         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 950         to get the data from there in future.
 951
 952 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 953
 954         * src/modest-defs.h:
 955
 956         * src/modest-account-mgr-helpers.h:
 957         * src/modest-account-mgr-helpers.c:
 958         Store the security account setting in a single conf key instead of using
 959         the options list, so that the list is left for just the to-be-removed camel hack,
 960         and because gconf_client_set_list() is failing for some reason.
 961
 962         * src/modest-account-mgr.c:
 963         (modest_account_mgr_add_server_account):
 964         * src/maemo/modest-account-settings-dialog.c:
 965         (modest_account_settings_dialog_set_account_name),
 966         (save_configuration): Use the renamed functions.
 967
 968
 969 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 970
 971         * src/widgets/Makefile.am:
 972         * src/widgets/modest-limit-retrieve-combo-box.c:
 973         * src/widgets/modest-limit-retrieve-combo-box.h:
 974         * src/widgets/modest-retrieve-combo-box.c:
 975         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 976         the account settings dialog.
 977
 978         * src/modest-defs.h:
 979         * src/modest-account-mgr-helpers.h:
 980         * src/modest-account-mgr-helpers.c:
 981         (modest_server_account_get_option_secure_auth),
 982         (modest_server_account_set_option_secure_auth):
 983         * src/modest-account-mgr.c:
 984         (modest_account_mgr_add_server_account):
 985         Use the existing AUTH_MECH conf key for the secure-auth setting,
 986         instead of putting it in the list options, because this was actually used already.
 987
 988         * src/maemo/modest-account-settings-dialog.c:
 989         (create_page_account_details),
 990         (modest_account_settings_dialog_set_account_name),
 991         (save_configuration):
 992         * src/maemo/modest-account-settings-dialog.h:
 993         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 994         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 995
 996 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 997
 998         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 999         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1000         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1001
1002         * src/modest-defs.h:
1003         * src/maemo/modest-account-settings-dialog.c:
1004         (create_page_incoming), (on_combo_outgoing_security_changed),
1005         (on_combo_incoming_security_changed), (create_page_outgoing),
1006         (modest_account_settings_dialog_set_account_name),
1007         (save_configuration): Load/Save the port number, and change it when the
1008         security combo changes, to suitable defaults.
1009
1010 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1011
1012         * src/modest-account-mgr.c:
1013         (modest_account_mgr_add_server_account): Set the security and secure-auth
1014         options, and add a comment saying that the other camel-specific options should be
1015         removed in future.
1016
1017 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1018
1019         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1020         found by valgrind.
1021         * src/modest-tny-account-store.c: (account_list_free),
1022         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1023         cursor->data after unreffing it. But there is some strange stuff there so it might not be
1024         easy to fix.
1025
1026 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1027
1028         * src/modest-protocol-info.c:
1029         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1030         is required by our UI spec. Maybe something in our implementation will use this eventually.
1031         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1032         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1033         instead of the previous 0 placeholder.
1034
1035         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1036         secure-auth settings.
1037         * src/modest-account-mgr-helpers.h:
1038         * src/modest-account-mgr-helpers.c:
1039         (modest_server_account_data_get_option_secure_auth),
1040         (modest_server_account_set_option_secure_auth),
1041         (modest_server_account_data_get_option_security),
1042         (modest_server_account_set_option_security): Added this API for getting and setting the security
1043         and secure-auth settings.
1044
1045         * src/maemo/modest-account-settings-dialog.h:
1046         * src/maemo/modest-account-settings-dialog.c:
1047         (modest_account_settings_dialog_finalize), (check_data),
1048         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1049         about changing titles.
1050         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1051         (save_configuration): Save the security and secure-auth settings.
1052
1053         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1054         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1055
1056 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1057
1058         * src/modest-defs.h:
1059         * src/modest-account-mgr.c:
1060         (modest_account_mgr_add_server_account):
1061         Added and used defines for the options key and value pair strings,
1062         that are used so far, though they do not seem to correspond to anything in our
1063         UI specs or ModestProtocol enum.
1064
1065         * src/modest-account-mgr-helpers.h:
1066         * src/modest-account-mgr-helpers.c:
1067         (compare_option_strings_for_name),
1068         (modest_server_account_data_get_option_value),
1069         (modest_server_account_data_get_option_bool),
1070         (modest_account_mgr_get_server_account_option):
1071         Added helper functions for parsing the options GSList.
1072
1073 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1074
1075         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1076         display name is based on the supplied account name.
1077         * src/modest-account-mgr.c:
1078         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1079         with an inefficient, but good-enough, implementation.
1080
1081         * src/maemo/easysetup/modest-easysetup-wizard.c:
1082         (create_page_account_details), (on_before_next), (create_account):
1083         Check for existing display names rather than (non-user-visible) account names, and just
1084         create and set a unique account name at the end.
1085
1086         * src/maemo/modest-account-settings-dialog.c:
1087         (modest_account_settings_dialog_init),
1088         (modest_account_settings_dialog_set_account_name),
1089         (create_page_incoming): Show the display name, instead of the account name.
1090         (on_response): Do some (not all) extra checks, as in the UI spec.
1091         (save_configuration): Save the display name if it was changed.
1092
1093 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1094
1095         * po/en_GB.po: Added needed logical ID and translation.
1096         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1097         (init_view): Made the is-default column clicking work.
1098
1099 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1100
1101         * configure.ac:
1102         * src/maemo/easysetup/Makefile.am:
1103         * src/maemo/easysetup/modest-easysetup-wizard.c:
1104         (modest_easysetup_wizard_dialog_init):
1105         * src/maemo/easysetup/provider-data-test.keyfile:
1106         * src/maemo/easysetup/provider-data.keyfile:
1107         Moved the provider data file to the new modest-providers-data package and used it from there.
1108
1109 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1110
1111         * src/modest-local-folder-info.c:
1112         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1113         N_() was already used on the static strings, but this just marks it for translation without
1114         using the translation.
1115
1116 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1117
1118         * src/maemo/modest-account-settings-dialog.c:
1119         (create_page_incoming),
1120         (modest_account_settings_dialog_set_account_name):
1121         Added comments about the need for new API in ModestAccountMgr to handle the authentication
1122         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1123         I will do this if nobody else gets there first.
1124
1125 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1126
1127         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1128         Saved much of the incoming and outgoing data too, though I cannot yet see how to
1129         save the security stuff.
1130
1131 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1132
1133         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1134         Set the email address and user fullname, which I now see must be
1135         done separately.
1136
1137         * src/maemo/modest-account-settings-dialog.h:
1138         * src/maemo/modest-account-settings-dialog.c:
1139          (on_response),
1140         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1141         leave-on-server and authentication.
1142         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1143         how to do the rest.
1144
1145 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1146
1147
1148         * src/maemo/modest-account-settings-dialog.c:
1149         * src/maemo/modest-account-settings-dialog.h:
1150         Most (but not all) of the widgets are now present as specified by the UI spec.
1151         No changes are yet saved, and some details are not properly shown yet.
1152
1153         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1154
1155 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1156
1157         * src/maemo/Makefile.am:
1158         * src/maemo/modest-account-settings-dialog.c:
1159         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1160         an existing account. Doesn't do much yet.
1161
1162         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1163         Open the accounts settings dialog when Edit is clicked.
1164
1165 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1166
1167         * src/maemo/easysetup/Makefile.am:
1168         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1169         (load_from_file):
1170         * src/maemo/easysetup/modest-easysetup-wizard.c:
1171         (modest_easysetup_wizard_dialog_init):
1172         Try to get the source directory from the build system,
1173         instead of hard-coding "./" into the source code, when opening our local
1174         copies of the configuration files.
1175         But this still fails when opening the wizard from the Accounts window,
1176         maybe because the working directory seems to change at runtime.
1177         So the wizard will fail the second time unless you copy the files into their
1178         proper locations - see the stdout warnings for the paths.
1179
1180         (create_page_account_details),(on_before_next):
1181         Check for existing non-server accounts instead of server accounts,
1182         so the default account name is useful again, and to prevent trying to
1183         recreate accounts.
1184
1185         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1186         Show the wizard when New is clicked.
1187
1188         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1189         (init_view): Show the column headers, and show the columns that are
1190         specified in the UI specs. However, something in Maemo's GTK+ prevents
1191         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1192         change the default account. This is despite unsetting the special properties.
1193
1194 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1195
1196         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1197         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1198         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1199         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1200         to make that clearer.
1201         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1202
1203 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1204
1205         * src/maemo/modest-account-view-window.c:
1206         (modest_account_view_window_init),
1207         (modest_account_view_window_new):
1208         Use the same buttons as specified in the
1209         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1210         the existing widgets, which never had a chance of working.
1211         Put the ModestAccountView treeview in a scrolled window.
1212         Do not repeat the initialization in both _init() and _new().
1213
1214         * src/widgets/modest-account-view.c: (update_account_view):
1215         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1216         this widget and window shows no accounts.
1217
1218         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1219
1220 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1221
1222         * src/maemo/easysetup/modest-easysetup-wizard.c:
1223         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1224         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1225         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1226         which seems wrong.
1227
1228         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1229         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1230         accounts exist yet, as in the UI spec.
1231
1232         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1233
1234 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1235
1236         * src/maemo/Makefile.am:
1237         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1238         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1239         New window for editing connection-specific smtp details.
1240         Not fully implemented.
1241
1242         * src/maemo/modest-connection-specific-smtp-window.c:
1243         (modest_connection_specific_smtp_window_finalize) :
1244         unref the tree model.
1245         (on_button_edit): Show the edit window.
1246
1247 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1248
1249         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1250         error for me.
1251
1252         * src/maemo/Makefile.am:
1253         * src/maemo/modest-connection-specific-smtp-window.c:
1254         * src/maemo/modest-connection-specific-smtp-window.h:
1255         New window for showing the list of connections, for connection-specific
1256         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1257         * src/maemo/easysetup/modest-easysetup-wizard.c:
1258         (create_page_custom_outgoing): Show the new window when the button is clicked.
1259
1260 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1261
1262         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1263         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1264         * src/maemo/modest-msg-edit-window.c:
1265         (modest_msg_edit_window_insert_image):
1266         * src/modest-conf.c: (modest_conf_key_escape):
1267         * src/modest-mail-operation.c:
1268         (modest_mail_operation_send_new_mail):
1269         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1270         (modest_ui_actions_on_new_account):
1271         * src/widgets/modest-attachment-view.c: (update_filename_request):
1272         * src/widgets/modest-mail-header-view.c:
1273         Corrected warnings that were breaking the build, by commenting out unused variables,
1274         and a function, and by including a header.
1275
1276 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1277
1278         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1279         so we can #ifdef around platform-specific code when necessary.
1280         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1281         to allow this to build for the GNOME platform too.
1282
1283 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1284
1285         * src/maemo/easysetup/modest-easysetup-wizard.c:
1286         Added util_increment_name() and used it in create_page_account_details()
1287         to make sure that the default account name is always a new name.
1288
1289         (modest_easysetup_wizard_dialog_init),
1290         (set_default_custom_servernames): Some minor memory management fixes.
1291
1292 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1293
1294         * Makefile.am:
1295         * configure.ac:
1296         * src/modest-runtime.c: (init_i18n): Restored the translation
1297         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1298         are defined in config.h, and the translations are installed.
1299
1300         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1301         is defined for translation.
1302
1303 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1304
1305         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1306         (load_from_file):
1307         * src/maemo/easysetup/modest-easysetup-wizard.c:
1308         (modest_easysetup_wizard_dialog_init):
1309         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1310         Use realistic paths (though they should use $prefix generically) to the
1311         mcc_mapping and provider-data.keyfile files which might work when they
1312         are installed by the future version of the operator-wizard package,
1313         and then fallback to paths in our source code, with an explanatory
1314         warning.
1315
1316 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1317
1318         * configure.ac:
1319         * src/Makefile.am:
1320         * src/maemo/Makefile.am:
1321         * src/maemo/easysetup/: Added files from the previously-exernal
1322         osso-modest-easysetup.
1323         * src/maemo/modest-main-window-ui.h:
1324         * src/modest-ui-actions.c:
1325         * src/modest-ui-actions.h:
1326         Added modest_ui_actions_on_new_account() as a signal handler for the
1327         New Account menu item. It shows the easysetup wizard.
1328         * po/en_GB.po: Added additional needed logical IDs and translations.
1329
1330 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1331 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1332