1 2007-08-16 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-search.c: (modest_search_folder):
4 * src/modest-search.h: Rename ModestSearch::before to start_date
5 and after to end_date, using the same names as the libogs struct
7 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
8 The start_date and end_date were swapped in the check. This
9 fixes date range searches, fixing projects.maemo.org bug NB#63407.
11 2007-08-16 Murray Cumming <murrayc@murrayc.com>
13 * src/maemo/modest-account-view-window.c:
14 Added (check_for_active_acount).
15 (on_delete_button_clicked), (on_edit_button_clicked):
16 When an account is doing something (such as refreshing),
17 show the same warning for account deletion as for account
18 editing, to fix projects.maemo.org bug NB#64588.
20 2007-08-16 Murray Cumming <murrayc@murrayc.com>
22 * src/widgets/modest-msg-view-window.h:
23 * src/gnome/modest-msg-view-window.c:
24 * src/maemo/modest-msg-view-window.c:
25 Added modest_msg_view_window_construct().
26 (modest_msg_view_window_new_with_header_model),
27 Added modest_msg_view_window_new_for_search_result),
28 Renamed modest_msg_view_window_new() to
29 modest_msg_view_window_new_for_attachment(),
30 and modest_msg_view_window_is_search_result(),
31 so we can explicitly know that the window is for an
32 attachment or a search result or a message from the list.
34 (modest_msg_view_window_view_attachment):
35 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
36 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
37 Use modest_msg_view_window_new_for_search_result().
39 * src/modest-ui-dimming-rules.c:
40 (modest_ui_dimming_rules_on_delete_msg): Dim the delete button
41 for search results, fixing projects.maemo.org bug NB#63811.
43 2007-08-16 Armin Burgmeier <armin@openismus.com>
45 * src/modest-ui-actions.c: Show a banner instead of a dialog when
46 renaming a folder fails, to stay consistent with what happens when
47 creating a folder fails.
49 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
50 slightly country loading from the mmc_mappings file, fixed a memory
53 2007-08-16 Murray Cumming <murrayc@murrayc.com>
55 * src/modest-tny-account-store.c: (volume_path_is_mounted):
56 Check the GnomeVFSVolume activation path instead of the device path,
57 so that the memory card is really really shown in the UI.
59 2007-08-16 Murray Cumming <murrayc@murrayc.com>
61 * src/maemo/easysetup/modest-easysetup-wizard.c:
62 (get_entered_account_title), (on_before_next), (entry_is_empty),
64 * src/maemo/modest-account-settings-dialog.c:
65 (get_entered_account_title), (on_button_signature), (check_data),
66 (save_configuration), (entry_is_empty):
67 Strip the account title of whitespace at the start and end before
68 using it or checking it. This means that an all-whitespace title
69 is not allowed, fixing projects.maemo.org bug NB#64977.
71 2007-08-15 Murray Cumming <murrayc@murrayc.com>
73 * src/modest-ui-actions.h:
74 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
75 to modest_run_account_setup_wizard() and made it public.
76 * src/dbus_api/modest-dbus-callbacks.c:
77 (check_and_offer_account_creation), (on_idle_mail_to),
78 (on_idle_compose_mail), (on_idle_open_default_inbox):
79 Offer account creation if necessary, fixing projects.maemo.org
82 2007-08-15 Murray Cumming <murrayc@murrayc.com>
84 * src/modest-ui-actions.c: (run_account_setup_wizard):
85 Return a gboolean to indicate success.
86 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
87 (modest_ui_actions_on_send): When offering account creation, only
88 give up (return) if account creation failed. Otherwise continue
89 with the original request. This fixed projects.maemo.org bug
92 2007-08-15 Murray Cumming <murrayc@murrayc.com>
94 * src/widgets/modest-recpt-editor.c:
95 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
96 to fix projects.maemo.org bug NB#63789.
98 2007-08-15 Murray Cumming <murrayc@murrayc.com>
100 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
101 (modest_tny_account_store_new): Properly detect the memory card at
102 startup, and add an account for it.
104 2007-08-14 Murray Cumming <murrayc@murrayc.com>
106 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
107 Commented out the MMC code again because it mistakenly detects
108 the card even when it isn't inserted.
110 2007-08-14 Murray Cumming <murrayc@murrayc.com>
112 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
113 Renabled the call to add_mmc_account() because I do not believe
114 it could be the cause of the mentioned hang (in scratchbox, where
115 there is no memory card), and because I have tested that it works
118 2007-08-14 Murray Cumming <murrayc@murrayc.com>
120 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
121 Comment out part of the last commit because it apparently causes
124 2007-08-14 Murray Cumming <murrayc@murrayc.com>
126 * src/modest-tny-account-store.c: Added the add_mmc_account()
127 function to save some copy/pasting.
128 (modest_tny_account_store_new): If the memory card is mounted,
129 create an account for it at the start, instead of waiting for the
130 user to unmount it and mount it.
132 2007-08-13 Murray Cumming <murrayc@murrayc.com>
134 * src/widgets/modest-account-view.c: (on_account_changed):
135 Do not try to use the human-readable TnyAccount name instead of the
136 ID of the modest account to get the transport account. And unref
137 the transport account. This prevents a g_warning(), and a possible
140 2007-08-13 Murray Cumming <murrayc@murrayc.com>
142 * src/maemo/modest-platform.c:
143 (modest_platform_set_update_interval): Handle the new
144 alarmd error to warn when alarmd is not running, as is the case in
145 scratchbox for me now because
146 "Module /usr/lib/alarmd/libretu.so initialization failed"
148 2007-08-13 Murray Cumming <murrayc@murrayc.com>
150 * src/widgets/modest-header-view-render.c:
151 (_modest_header_view_compact_header_cell_data):
152 NULL some strings after freeing them, trying to deal with
153 the double deletion found in projects.maemo.org bug 64183,
154 probably having no effect.
156 2007-08-13 Murray Cumming <murrayc@murrayc.com>
158 * src/maemo/modest-account-settings-dialog.c:
159 (create_page_incoming), (create_page_outgoing): Use a define
160 for the min and max port numbers.
162 (check_hildon_number_editor_and_warn_value_not_in_range),
163 (check_data): Do an extra check for an invalid port number, as needed
164 in projects.maemo.org bug #64275, when the number is cleared, but this
165 does not work due to bugs.maemo.org bug #1806.
167 2007-08-13 Murray Cumming <murrayc@murrayc.com>
169 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
170 Comment out the debug warning about the unexpected D-Bus methods.
171 They are just annoying now.
172 * src/maemo/modest-platform.c:
173 (modest_platform_set_update_interval): Correct the D-Bus path, instead
174 of using a file path, though it did not seem to break things before.
175 It might be needed now:
176 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
177 modest is not already running. This is the behaviour of the old client, and
178 Mox says it is what we should do for modest.
179 This closes projects.maemo.org bug NB#64327.
181 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
183 * src/modest-text-utils.c:
184 Fixed invalid jump due to incorrect string/pointer
186 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
189 2007-08-01 Murray Cumming <murrayc@murrayc.com>
191 * src/modest-account-mgr-helpers.h:
192 * src/modest-account-mgr-helpers.c:
193 Added modest_account_mgr_get_first_account_name(),
194 using code from modest_account_mgr_set_first_account_as_default().
196 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
197 (account_number_changed): Call set_at_least_one_account_visible() so that
198 the first account is visible when first added, without the user having to
200 I do wonder how this worked before.
202 2007-08-01 Murray Cumming <murrayc@murrayc.com>
204 * src/modest-tny-account-store.c: (show_password_warning_only),
205 (show_wrong_password), (request_password_and_wait), (get_password),
206 (modest_tny_account_store_alert): Remove the (incomplete anyway)
207 attempts to show UI only in the main context, which used g_idle_add()
208 and mainloops, because tinymail now guarantees that it only calls these
209 callbacks in the mainloop with the gdk lock. This makes everything much
212 2007-08-01 Murray Cumming <murrayc@murrayc.com>
214 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
215 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
216 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
217 error dialog, instead of ignoring it.
219 2007-08-01 Murray Cumming <murrayc@murrayc.com>
221 * src/maemo/modest-msg-view-window.c:
222 (modest_msg_view_window_get_header),
223 (modest_msg_view_window_last_message_selected):
224 Added comments to explain the use of priv->header_model.
225 * src/modest-ui-dimming-rules.c:
226 (modest_ui_dimming_rules_on_open_msg),
227 (modest_ui_dimming_rules_on_mark_as_read_msg),
228 (modest_ui_dimming_rules_on_mark_as_unread_msg),
229 (modest_ui_dimming_rules_on_remove_attachments),
230 (_invalid_attach_selected), (_selected_msg_marked_as):
231 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
232 and changed the parameter to a ModestMainWindow to make it clearer that
233 it never uses any other kind of window.
234 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
235 instead of the selected message.
236 I notice that much of the dimming code and the ModestMsgViewWindow code
237 hard-codes the assumption that the viewed message is always selected in
238 the header view. This does not seem wise or simple.
240 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
241 examine the actual message instead of whatever might be selected
242 in the header view. This stops the delete toolbar button and menu item
243 from being dimmed when opening a message view the search UI,
244 partially fixing projects.maemo.org bug NB#63811.
246 However, when actually deleting, I now get this warning:
247 "tny_header_set_flags: This is a header instance for a new message.
248 Only priority and attachment flags are supported"
250 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
252 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
254 Show account wizard if no accounts are defined while sending
255 (automatic sending after the account wizard finished does not
256 work because it takes some time until the account manager
257 synchronizes everything. (projects.maemo.org NB#62792)
259 2007-07-30 Murray Cumming <murrayc@murrayc.com>
261 * src/modest-tny-account-store.c: (on_account_removed),
262 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
263 account is removed from the View menu. We have TnyAccountStore
264 and ModestTnyAccountStore signals that seem very similar, but this
265 seems to work for now.
267 * src/maemo/modest-main-window.c:
268 (on_show_account_action_activated): Prevent dereference
269 of a NULL if the accoutn does not really exist, though that
270 should not happen anymore.
272 This fixes projects.maemo.org bug NB#64606.
274 2007-07-30 Murray Cumming <murrayc@murrayc.com>
276 * src/modest-ui-actions.c: (run_account_setup_wizard),
277 (modest_ui_actions_on_accounts): Revert a change that set these
278 to modal dialogs, freezing the UI when they show secondary dialogs.
279 This fixed projects.maemo.org bug NB#64519.
281 2007-07-27 Murray Cumming <murrayc@murrayc.com>
283 * src/widgets/modest-header-view-render.c:
284 (_modest_header_view_compact_header_cell_data):
285 Some checks and initialization to try to deal with a crash,
286 probably ineffective.
288 2007-07-27 Murray Cumming <murrayc@murrayc.com>
290 * src/maemo/modest-maemo-utils.c:
291 (modest_maemo_utils_get_supported_secure_authentication_methods):
292 Make sure that we have a connection, asking the user for one
294 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
295 Check for a connection before showing the wizard, because
296 the wizard needs a connection to check for server capabilities.
298 2007-07-27 Murray Cumming <murrayc@murrayc.com>
300 * src/maemo/modest-account-view-window.c:
301 (on_new_button_clicked): Remember the wizard dialog instance,
302 so we can just present it again if necessary. This prevents
303 multiple windows from appearing if you click again quickly on the
304 New button before the dialog appears, fixing projects.maemo.org
307 2007-07-27 Murray Cumming <murrayc@murrayc.com>
309 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
310 Offer a connection dialog if there is no connection when
311 starting modest. This should fix projects.maemo.org bug NB#61134.
313 2007-07-27 Murray Cumming <murrayc@murrayc.com>
315 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
316 Reverted my last commit. I was able to fix the build by doing
317 apt-get install wpeditor0 (replacing other wpeditor packages) and
318 an explicit apt-get install wpeditor-dev to upgrade the -dev
321 2007-07-27 Murray Cumming <murrayc@murrayc.com>
323 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
324 Commented out the use of wp_text_buffer_replace_image()
325 because it does not exist, to break the build. Added a TODO for it.
327 2007-07-26 Murray Cumming <murrayc@murrayc.com>
329 * src/modest-tny-account-store.c: (recreate_all_accounts):
330 Recreate them even if they were NULL before. I guess something
331 else was already creating them before, or this would never
333 (modest_tny_account_store_get_server_account): Make sure that
334 the tny accounts have been created before trying to find one.
335 This allows libmodest_dbus_client_compose_mail() to work
336 when the UI is not yet visible.
337 This is probably useful in other cases too.
339 (get_password): When the password is wrong after it is entered
340 in the protected password dialog, show an info banner (in an
341 idle handler) before showing the protected password dialog
344 2007-07-26 Murray Cumming <murrayc@murrayc.com>
346 * src/modest-ui-actions.h:
347 * src/modest-ui-actions.c: Added
348 modest_do_refresh_current_folder() containing some code from
349 modest_ui_actions_on_send_receive().
350 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
351 Call modest_do_refresh_current_folder() before refreshing the
352 requested account, as in modest_ui_actions_on_send_receive().
353 This is strange, but seems to be necessary to show new mails.
354 Now new emails are finally visible in the UI when downloaded
355 via the automatic update interval, fixing bug NB#57458.
356 This also works because bug NB#57458 has been fixed somehow.
358 2007-07-26 Murray Cumming <murrayc@murrayc.com>
360 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
361 printf more details when we get unhandled D-Bus methods, because
364 * src/modest-mail-operation.c: (update_account_thread):
365 Comment out the tny_camel_pop_store_account_reconnect(), because this
366 is apparently no longer needed, and it did not work before anyway.
367 See the comment in the code.
369 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
370 by checking the header flags. This fixes projects.maemo.org bug
373 2007-07-25 Murray Cumming <murrayc@murrayc.com>
375 * src/maemo/modest-maemo-utils.h:
376 * src/maemo/modest-maemo-utils.c: Added
377 modest_maemo_show_information_note_in_main_context_and_forget().
378 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
379 Use the new function to show simple error dialogs in the main
380 context, though question dialogs are still in the current context,
381 which is unfortunately usually not the main context. This should
384 2007-07-25 Murray Cumming <murrayc@murrayc.com>
386 * src/modest-tny-account-store.c: (get_password):
387 Never save the entered username and password in gconf,
388 because the UI spec says we should not. This helps
389 slightly with projects.maemo.org bug NB#63671.
391 2007-07-25 Murray Cumming <murrayc@murrayc.com>
393 * src/widgets/modest-msg-edit-window.h:
394 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
395 Moved some code here to make it simpler.
396 (modest_msg_edit_window_attach_file_one): Renamed from
397 modest_msg_edit_window_attach_file_interactive().
398 (modest_msg_edit_window_offer_attach_file): Renamed from
399 modest_msg_edit_window_attach_file() and used
400 modest_msg_edit_window_attach_file_one() instead of
401 copy/pasting the code. The old code for one was not using
402 GnomeVFS. This allows use of smb:// URLs when using send-as
403 from external applications, fixing bug NB#63741.
405 (modest_msg_edit_window_insert_image),
406 (modest_msg_edit_window_add_attachment_clicked):
407 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
408 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
409 Adapted to the new function names.
411 2007-07-25 Murray Cumming <murrayc@murrayc.com>
413 (modest_platform_set_update_interval): Set the alarm recurrence
414 fields so that auto-update does not just happen the first time.
415 This should have fixed projects.maemo.org bug NB#63938.
417 When this happens you can see a printf when the D-Bus method is
419 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
421 However, I do not actually seem to get new POP messages even when
422 clicking the refresh button manually. A restart gets them.
423 This might be a problem in today's tinymail only.
425 2007-07-24 Murray Cumming <murrayc@murrayc.com>
427 * src/maemo/modest-maemo-global-settings-dialog.c:
428 (current_connection):
429 Avoid a crash (probably only in scratchbox) when strcmp()ing a
430 NULL when closing the dialog.
432 2007-07-24 Murray Cumming <murrayc@murrayc.com>
434 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
435 Remove the hacky send/receive that didn't work, and instead
436 refilter the treemodel to make the deleted email really vanish from
437 the UI (though the delete-from-menu code does has commented out
438 the code that does that). This fixes projects.maemo.org bug
441 2007-07-24 Murray Cumming <murrayc@murrayc.com>
443 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
444 Try a couple of tricks to force the treeview to update (
445 poke the folder, and do a send/receive refresh), but the deleted
446 email still appears with a strike-through instead of really being
449 2007-07-23 Murray Cumming <murrayc@murrayc.com>
451 * src/dbus_api/modest-dbus-callbacks.c:
452 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
453 because their ID is not human-readable (see the comment about
454 improvements needed to the osso-email-interface API) and
455 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
457 2007-07-23 Murray Cumming <murrayc@murrayc.com>
459 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
460 (add_folders_to_list), (on_dbus_method_get_folders),
461 (modest_dbus_req_filter):
462 * src/maemo/modest-maemo-utils.c:
463 (on_camel_account_get_supported_secure_authentication):
464 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
465 (on_header_view_focus_in):
466 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
467 * src/modest-formatter.c: (modest_formatter_create_body_part):
468 * src/modest-mail-operation.c: (recurse_folders),
469 (update_account_thread), (get_msgs_full_thread),
470 (modest_mail_operation_get_msgs_full),
471 (modest_mail_operation_xfer_msgs):
472 * src/modest-search.c: (search_mime_part_and_child_parts),
473 (modest_search_account), (modest_search_all_accounts):
474 * src/modest-tny-account.c:
475 (modest_tny_account_get_special_folder), (recurse_folders):
476 * src/modest-tny-local-folders-account.c:
477 (modest_tny_local_folders_account_query_passes):
478 * src/modest-tny-msg.c: (copy_mime_part),
479 (modest_tny_msg_find_body_part_from_mime_part):
480 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
481 (modest_tny_send_queue_try_to_send):
482 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
483 (_modest_ui_actions_open), (download_uncached_messages),
484 (reply_forward), (modest_ui_actions_on_copy),
485 (modest_ui_actions_on_details), (has_retrieved_msgs),
486 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
488 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
489 (_selected_msg_marked_as), (_msg_download_completed),
490 (_selected_msg_sent_in_progress):
491 * src/widgets/modest-attachments-view.c:
492 (modest_attachments_view_set_message):
493 * src/widgets/modest-msg-view.c: (find_cid_image):
494 * tests/check_folder-transfer.c: (find_folders):
495 * tests/check_update-account.c: (func):
496 * tests/dbus_api/test_get_folders.c: (main):
497 Checked all uses of tny_iterator_get_current(), making sure
498 that the object is unreferenced (3 or 4 places did not),
499 and adding checks for NULL.
501 2007-07-23 Murray Cumming <murrayc@murrayc.com>
503 * src/dbus_api/modest-dbus-callbacks.c:
504 (on_idle_open_default_inbox): Make sure that the application UI is
506 * src/maemo/easysetup/modest-easysetup-wizard.c:
507 (on_entry_invalid_character): Show the word whitespace instead
508 of (null) in the banner when whitespace was entered.
509 (show_error): Add a comment that this does not work in
510 Maemo Bora, though we do not know why.
512 2007-07-23 Murray Cumming <murrayc@murrayc.com>
514 * src/modest-tny-account.c:
515 (modest_tny_account_get_special_folder): Use an if instead of
516 an assert for when the parent account name is NULL, because this
517 might be causing a crash in projects.maemo.org bug 63192.
518 * src/modest-mail-operation.c:
519 (modest_mail_operation_send_new_mail_cb),
520 (modest_mail_operation_remove_folder): unref the folder that is
521 returned from modest_tny_account_get_special_folder().
523 2007-07-23 Murray Cumming <murrayc@murrayc.com>
525 * src/modest-ui-actions.c:
526 (modest_ui_actions_on_password_requested):
527 Show mail_ib_login_cancelled info banner when the user cancels
528 the protected password dialog, to fix projects.maemo.org
531 2007-07-23 Murray Cumming <murrayc@murrayc.com>
533 * src/maemo/modest-account-settings-dialog.c:
534 (create_page_outgoing): Put this page in a GtkScrolledWindow,
535 matching the UI mock-up in the UI spec, and allowing access
536 to all widgets even when the on-screen keyboard is active.
538 2007-07-23 Murray Cumming <murrayc@murrayc.com>
540 Reverted this previous commit from Johannes,
541 because the scrollbars are always visible and because
542 I think we only need it on onepage of the account
543 settings, not the account wizard.
544 (I wrote the wrong instructions in the bug.)
546 * src/maemo/easysetup/modest-easysetup-wizard.c:
547 Added scrollbars to account wizard dialog.
548 Fixed projects.maemo.org NB #62744
550 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
552 * src/maemo/easysetup/modest-easysetup-wizard.c:
553 (create_page_user_details):
554 Use auto-cap for name (projects.maemo.org NB#63716)
555 * src/widgets/modest-account-view.c: (on_account_busy_changed):
557 2007-07-22 Armin Burgmeier <armin@openismus.com>
559 * src/maemo/modest-ui-actions.c: Use current account instead of
560 default account for creating viewer windows, so that the viewer
561 window knows to which account the viewed message belongs.
563 * src/maemo/modest-msg-view-window.c: Destroy the window when the
564 corresponding account is deleted. This fixes projects.maemo.org bug
567 2007-07-18 Armin Burgmeier <armin@openismus.com>
569 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
570 the dialog close after entering an invalid port number and clicking
571 OK. This fixes projects.maemo.org bug NB#63602.
573 2007-07-18 Armin Burgmeier <armin@openismus.com>
575 * src/modest-tny-account-store.c:
576 (get_server_accounts): Set parent modest account name for each
577 connection-specific transport account so that special folders of such
578 an account can be looked up. This fixes a crash when changing account
579 settings. This might also be related to projects.maemo.org bug
582 2007-07-16 Armin Burgmeier <armin@openismus.com>
584 * src/modest-ui-actions.c: Added a button to create a folder to the
585 move-to dialog. This fixes projects.maemo.org bug NB#59863.
587 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
589 * src/maemo/easysetup/modest-easysetup-wizard.c:
590 Added scrollbars to account wizard dialog.
591 Fixed projects.maemo.org NB #62744
593 2007-07-16 Murray Cumming <murrayc@murrayc.com>
595 * src/widgets/modest-msg-view.h:
596 * src/widgets/modest-msg-view.c:
597 Added modest_msg_view_get_message_is_empty() but this needs
599 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
600 Check if there is any text in the message yet.
601 But this needs to be implemented properly.
602 (modest_msg_edit_window_toggle_find_toolbar):
603 * src/maemo/modest-msg-view-window.c:
604 (modest_msg_view_window_toggle_find_toolbar):
605 Show a banner warning if there is no text to search, when
606 trying to start a search. This partially fixes
607 projects.maemo.org bug NB#62350.
609 2007-07-13 Murray Cumming <murrayc@murrayc.com>
611 * src/modest-mail-operation.c: (update_account_thread):
612 Initialized num_new_headers to fix the build.
614 2007-07-13 Murray Cumming <murrayc@murrayc.com>
616 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
617 Ignore modest accounts whose server accounts don't exist in gconf.
618 This prevents us trying to create TnyAccount instances for those
619 server accounts when the server account has been removed from gconf,
620 but the parent modest account has not yet been removed from modest.
621 I don't know why this is only noticeable now. It was probably just
622 a harmeless g_warning() anyway.
624 2007-07-13 Murray Cumming <murrayc@murrayc.com>
626 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
627 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
629 2007-07-12 Armin Burgmeier <armin@openismus.com>
631 * src/maemo/modest-main-window.c: Make default account appear bold
632 in view, tools/send & receive and toolbar/send & receive SCM menus.
633 This fixes projects.maemo.org bug NB#59010.
635 2007-07-12 Murray Cumming <murrayc@murrayc.com>
637 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
638 Add a short-cut, by checking if the folder store is an account.
639 This ensures that the Sort menu item and toolbar is dimmed for
640 the local-folders account root item, fixing
641 projects.maemo.org bug NB#62545.
643 2007-07-12 Murray Cumming <murrayc@murrayc.com>
645 * src/modest-tny-account-store.c: (get_password):
646 Show the password dialog (via the signal) only in the mainloop, via
647 an idle handler that we wait for. This could theoretically prevent
648 hangs, though I worry that it could introduce some too.
650 2007-07-12 Murray Cumming <murrayc@murrayc.com>
652 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
653 * src/maemo/modest-platform.c:
654 (modest_platform_connect_and_wait):
655 Take a TnyAccount* parameter and try to set it to online
656 (a TnyCamel-only API), because tinymail sets accounts to offline
657 when the user cancels a password dialog, and doesn't ask again until
658 it has been set to online.
659 However, this is commented out because it causes a hang now.
661 (modest_platform_connect_and_wait_if_network_account):
662 * src/modest-mail-operation.c:
663 (modest_mail_operation_update_account):
664 * src/modest-platform.h:
665 * src/modest-ui-actions.c: (_modest_ui_actions_open),
666 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
668 2007-07-12 Armin Burgmeier <armin@openismus.com>
670 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
672 * src/modest-mail-operation.c:
673 * src/modest-ui-actions.c: Check for already existing folder before
674 querying the server, show error message from camel if the request
675 still fails. This fixes projects.maemo.org bug NB#58701.
677 2007-07-12 Murray Cumming <murrayc@murrayc.com>
679 * src/modest-tny-account-store.h:
680 * src/modest-tny-account-store.c:
681 Added modest_tny_account_store_forget_password_in_memory(),
682 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
683 when creating a new account, so that new passwords will be used, instead of
684 us thinking that it's a second request as a result of a failed password again.
686 2007-07-12 Murray Cumming <murrayc@murrayc.com>
688 * src/dbus_api/modest-dbus-callbacks.c:
689 (on_idle_open_message): If the message is in drafts then open it
690 in an edit window instead of a view window. This fixes
691 projects.maemo.org bug NB#63005.
693 2007-07-12 Murray Cumming <murrayc@murrayc.com>
695 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
696 Avoided a harmless g_warning().
698 2007-07-12 Murray Cumming <murrayc@murrayc.com>
700 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
701 Pass the modest account name, not the TnyAccount display name to
702 modest_msg_view_window_new() so that the reply feature works,
703 fixing projects.maemo.org bug NB#62892.
705 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
706 (modest_msg_view_window_new_with_header_model):
707 * src/maemo/modest-msg-view-window.c:
708 (modest_msg_view_window_new_with_header_model),
709 (modest_msg_view_window_new):
710 * src/modest-ui-actions.c: (reply_forward):
711 * src/widgets/modest-msg-view-window.h:
712 * src/widgets/modest-window.c: (modest_window_set_active_account):
713 Rename an account parameter to modest_account_name to make this clearer.
715 2007-07-11 Murray Cumming <murrayc@murrayc.com>
717 * src/modest-ui-actions.h:
718 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
719 modest_do_message_delete().
720 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
721 Call modest_do_message_delete(), hoping that this would cause messages
722 to be really deleted from search instead of just marked with strike through.
723 Does not seem to help.
725 2007-07-11 Armin Burgmeier <armin@openismus.com>
727 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
728 priv->reselect to FALSE prior to calling
729 modest_folder_view_select_first_inbox_or_local() to prevent endless
730 recursion and thus a crash on startup.
732 2007-07-11 Armin Burgmeier <armin@openismus.com>
734 * src/maemo/modest-account-settings-dialog.h: Include
735 <gtk/gtknotebook.h> to fix the build (at least for me).
737 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
738 Use "New FolderN" as default suggested name if "New folder" already
739 exists, with N being the first free number, though never exceed "New
740 folder99" in which case we just fall back to "New Folder" even though
741 it already exists. This fixes projects.maemo.org bug NB#58663.
743 2007-07-11 Murray Cumming <murrayc@murrayc.com>
745 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
746 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
747 projects.maemo.org bug NB#62778.
749 2007-07-11 Murray Cumming <murrayc@murrayc.com>
751 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
752 Ignore the wrong (for now) secure-smtp setting in the presets -
753 just default to requiring secure authentication for SMTP, because
756 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
758 * src/widgets/modest-folder-view.c: (filter_row)
759 Do not show drafts folder (see UI specs)
761 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
763 * src/modest-ui-actions.c:
764 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
765 place and also not necessary.
767 * src/widgets/modest-folder-view.c: (filter_row)
768 Guess folder type and hide Sent & Outbox if necessary.
769 Fixed project.maemo.org NB#57328
771 2007-07-11 Murray Cumming <murrayc@murrayc.com>
773 * src/modest-ui-actions.h:
774 * src/modest-ui-actions.c:
775 (modest_ui_actions_on_delete_message):
776 Move some code into a new
777 modest_ui_actions_refresh_message_window_after_delete()
778 function so we can use it from elsewhere.
780 * src/dbus_api/modest-dbus-callbacks.c:
781 (on_idle_delete_message), (on_delete_message): Used an idle
782 handler, as we do for the other D-Bus method handlers.
783 Call modest_ui_actions_refresh_message_window_after_delete()
784 if the deleted message was open in a window. This fixed
785 projects.maemo.org bug NB#62862.
787 2007-07-11 Murray Cumming <murrayc@murrayc.com>
789 * src/modest-main.c: (main): Only show the UI at the start if
790 the showui command line option was given. For instance,
791 run-standalone src/modest showui
792 Otherwise, we wait for the top_application D-Bus method to
793 be sent by hildon-desktop when the application is selected
795 This allows us to run without a UI when osso-global-search
796 uses our D-Bus methods.
798 2007-07-11 Murray Cumming <murrayc@murrayc.com>
800 * src/dbus_api/modest-dbus-api.h: Added a define for a
801 top-application D-Bus method.
802 * src/dbus_api/modest-dbus-callbacks.c:
803 (on_top_application),
804 (modest_dbus_req_handler): Handle the top-application D-Bus
805 method, which might be an undocumented D-Bus signal sent by
806 hildon-desktop when it starts the application from the menu.
807 But I am not sure and I need to test it on the device, because
808 my scratchbox does not have the application in the menu now.
809 This method shows the main window, so that it can be invisible
810 when started, for instance, just for email searching from
813 * src/maemo/modest-main-window.c: (restore_settings),
814 (modest_main_window_new): Do not show the window immediately
815 upon creation. We show it later.
816 * src/modest-widget-memory.c: (save_settings_paned):
817 Try (unsuccessfully) to avoid saving the paned position when
818 it is not even visible.
819 (restore_settings_paned): Do not allow a silly paned position.
820 This seems necessary when not showing the window at first.
822 * tests/dbus_api/Makefile.am:
823 * tests/dbus_api/test_top_application.c: (main): Test for the
826 2007-07-10 Murray Cumming <murrayc@murrayc.com>
828 * src/modest-ui-dimming-rules.c:
829 (modest_ui_dimming_rules_on_new_msg),
830 (modest_ui_dimming_rules_on_reply_msg),
831 (modest_ui_dimming_rules_on_delete_msg),
832 (modest_ui_dimming_rules_on_details),
833 (modest_ui_dimming_rules_on_view_window_move_to),
834 (modest_ui_dimming_rules_on_view_previous),
835 (modest_ui_dimming_rules_on_view_next),
836 (_invalid_folder_for_purge): Added checks before
837 casting the window. This looks like an actual
838 logic error in _invalid_folder_for_purge(), because it
839 tries to use a ModestMainWindow as a message window.
841 2007-07-10 Murray Cumming <murrayc@murrayc.com>
843 * src/maemo/modest-account-settings-dialog.c:
844 (show_error): Use the same implementation as in
845 modest-easysetup-wizard.c:
846 (on_entry_invalid_character): The logical ID contains a %s.
847 Guessed what it should be.
848 (on_entry_max), (check_data), (on_response): Adapt to
849 changed show_error().
850 (create_page_account_details): Really call
851 modest_validating_entry_set_func() on the correct widgets.
852 * src/maemo/easysetup/modest-easysetup-wizard.c:
853 (on_entry_invalid_character): Fix the logical ID here too.
854 (create_page_account_details),
855 (create_page_user_details):
857 modest_validating_entry_set_func() on the correct widgets.
859 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
860 Do not try to use the account if it is NULL.
862 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
864 * src/modest-ui-actions.c: (create_move_to_dialog),
865 (modest_ui_actions_on_main_window_move_to),
866 (modest_ui_actions_on_msg_view_window_move_to):
867 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
868 (filter_row), (modest_folder_view_show_non_move_folders):
869 * src/widgets/modest-folder-view.h:
871 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
872 the Sent folder yet as it does not report the correct folder type.
874 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
876 * src/maemo/modest-msg-edit-window.c: (init_window):
879 2007-07-10 Murray Cumming <murrayc@murrayc.com>
881 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
882 Take a parent widget instead of a parent window, and
883 implement this with hildon_banner_show_information() instead.
884 Non-Maemo builds can just ifdef that there.
885 This fixed projects.maemo.org bug NB#62766.
887 (on_entry_invalid_character): Use show_error() again instead
888 of using hildon directly, and use the _CS() macro to use the correct
890 (create_account), (check_for_supported_auth_methods), (on_entry_max):
891 Pass a widget instead od a window to show_error().
893 2007-07-10 Murray Cumming <murrayc@murrayc.com>
895 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
896 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
897 This allows us to show the server name in the error message, fixing
898 projects.maemo.org bug NB#62904.
899 Also, use the appropriate logical ID message for the account protocol.
901 2007-07-10 Murray Cumming <murrayc@murrayc.com>
903 * src/modest-tny-account-store.c: (on_idle_wrong_password):
904 A compilation fix, though the build wasn't broken for me.
906 2007-07-09 Murray Cumming <murrayc@murrayc.com>
908 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
909 Do not try to unref a NULL folder store, to avoid a runtime warning.
910 This seems to happen sometimes when changing accounts settings.
912 2007-07-09 Murray Cumming <murrayc@murrayc.com>
914 * src/modest-tny-account-store.c:
915 (modest_tny_account_store_instance_init),
916 (modest_tny_account_store_finalize),
917 (on_account_settings_hide), (on_idle_wrong_password):
918 Use a GHashTable to ensure that we only show one account settings
919 dialog per modest account. This avoids us having a dialog open for
920 both the store and transport accounts, or due to repeated get_password()
921 calls that shouldn't happen anyway.
923 2007-07-09 Murray Cumming <murrayc@murrayc.com>
925 * src/maemo/modest-maemo-utils.c: (on_hide),
926 (modest_maemo_show_dialog_and_forget): Handle the response, because
927 the window is not even hidden by default.
929 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
930 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
931 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
932 which seems to prevent some modality problems.
934 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
935 Ignore user cancellation errors.
937 * src/modest-account-mgr-helpers.h:
938 * src/modest-account-mgr-helpers.c:
939 Added modest_server_account_get_password() and
940 modest_server_account_get_has_password() to avoid direct use of
943 * src/maemo/modest-account-settings-dialog.h:
944 * src/maemo/modest-account-settings-dialog.c:
945 (modest_account_settings_dialog_init): Store the notebook so we can
947 Added modest_account_settings_dialog_switch_to_user_info().
949 * src/modest-tny-account-store.c:
950 (get_password): When the password in the account settings is wrong (we think),
951 show the relevant page of the account settings dialog, in the mainloop.
952 However, we currently get many of these at once because cancel does not
954 (forget_password): Do not forget the password
955 from the account settings, because this causes side-effects when
956 tinymail seems to call it at strange time, maybe because of how we
957 are cancelling get_password().
958 (modest_tny_account_store_alert): Ignore user cancellations.
960 2007-07-09 Murray Cumming <murrayc@murrayc.com>
962 * src/maemo/modest-maemo-utils.h:
963 * src/maemo/modest-maemo-utils.c:
964 Added modest_maemo_show_information_note_and_forget() for use instead of
965 gtk_dialog_run() when the response is not needed, to avoid an extra
966 mainloop which could cause a hang.
968 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
969 Use the logical IDs for the error message, though they are not
970 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
971 because gtk_dialog_run() caused a hang here (the window did not close).
972 This fixes projects.maemo.org bug NB#62646.
974 2007-07-09 Murray Cumming <murrayc@murrayc.com>
976 * src/modest-account-mgr-helpers.h:
977 * src/modest-account-mgr-helpers.c:
978 Added modest_account_mgr_get_store_protocol().
980 * src/maemo/modest-account-view-window.c:
981 (on_delete_button_clicked): Show different warning text depending on
982 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
983 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
986 2007-07-09 Murray Cumming <murrayc@murrayc.com>
988 * src/maemo/modest-msg-edit-window.c:
989 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
990 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
992 2007-07-07 Armin Burgmeier <armin@openismus.com>
994 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
995 ckdg_ib_maximum_characters_reached from correct package.
997 * src/modest-ui-actions.c: Show an error message when a folder could
998 not be created. Tinymail does not give us specific error codes about
999 what has gone wrong, so we assume that a folder with that name
1000 already exists, though there might be other reasons.
1002 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1004 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1005 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1006 give a more exact error message that can be partly translated.
1008 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1010 * src/maemo/modest-address-book.c:
1011 (select_email_addrs_for_contact): Specify a default window size for the
1012 select-email-address dialog, so that it is probably big enough for the
1013 title. This should fix projects.maemo.org bug NB#62277.
1015 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1017 * src/maemo/easysetup/modest-easysetup-wizard.c:
1018 (create_page_complete_easysetup): Use
1019 gtk_widget_set_size() request to ensure that the text wraps
1022 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1024 * src/maemo/easysetup/modest-easysetup-wizard.c:
1025 (on_entry_invalid_character), (create_page_account_details),
1026 (create_page_user_details):
1027 Use new API of ModestValidatingEntry. But for some reason the banner is
1028 not shown. I will have to investigate that further.
1030 * src/widgets/modest-validating-entry.c: (on_insert_text),
1031 (modest_validating_entry_set_func):
1032 * src/widgets/modest-validating-entry.h:
1033 Added a new callback function to be able to react to prevented
1034 characters whitespaces to e.g show a banner.
1036 2007-07-05 Armin Burgmeier <armin@openismus.com>
1038 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1039 notification of HildonNumberEditor instead of remembering the port
1040 number. Thanks to Johannes for pointing this out.
1042 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1044 * src/maemo/easysetup/modest-easysetup-wizard.c:
1045 Check if there are any user changes before showing a confirmation
1046 dialog (projects.maemo.org NB#60946)
1048 2007-07-05 Armin Burgmeier <armin@openismus.com>
1050 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1051 number at the beginning of the dialog and set the modified flag at the
1052 end if the port number has changed. This is necessary because
1053 HildonNumberEditor does not support notification when the value has
1056 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1058 * src/modest-ui-actions.c:
1059 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1060 a connection before asking anything else. Correct the check for the destination
1061 folder so that it succeeds when online.
1062 This fixed projects.maemo.org bug NB#61645.
1064 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1066 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1067 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1068 to fix projects.maemo.org bug NB#62439.
1070 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1072 * src/modest-tny-account.c: (on_connection_status_changed):
1073 Really do not use tny_device_force_offline() here. See the previous comment.
1075 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1077 * src/modest-tny-account.c: (on_connection_status_changed):
1078 Do not use tny_device_force_offline() when tinymail says that something
1079 went wrong with the connection. It seems to report this unnecessarily.
1081 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1083 * src/maemo/modest-connection-specific-smtp-window.c:
1084 (modest_connection_specific_smtp_window_init):
1085 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1086 does not seem to have any effect in osso 1.1 (though it works in
1087 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1089 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1091 * src/maemo/modest-connection-specific-smtp-window.c:
1092 Fix UI specification problems with projects.meamo.org NB#60479
1094 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1096 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1097 clue when this has failed, because the error dialog is not always shown
1098 (at least in earlier version).
1100 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1101 GError message, because the generic error dialog is not helpful.
1103 'This message is not currently available (can't let a new connection go online)'
1104 when trying to open an IMAP message.
1106 (_modest_ui_actions_open): Offer a connection when some messages would
1107 have to be downloaded and we are offline.
1109 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1111 * src/widgets/modest-folder-view.c:
1112 Don't check for MERGE type anymore as we use the correct type
1114 NOTE: For the last two changes you need to update your tinymail copy
1115 because of API changes!
1117 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1119 * src/modest-tny-local-folders-account.c:
1120 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1121 (see projects.maemo.org NB#61580)
1123 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1125 * src/modest-tny-account.c: (on_connection_status_changed):
1126 Commented out the call to modest_platform_connect_and_wait() because this
1127 seems to always hang, and I would like to know if this is the only thing
1128 that causes a hang when showing the connection dialog.
1129 It is not very useful anyway.
1131 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1133 * src/maemo/modest-msg-view-window.c:
1134 (modest_msg_view_window_select_next_message):
1136 * src/modest-platform.h:
1137 * src/maemo/modest-platform.c:
1138 Added modest_platform_connect_and_wait(), which calls
1139 tny_maemo_conic_device_connect() always in the main thread, by calling it
1140 in an idle handler and waiting for the idle handler to run. It should be
1141 in the main thread because it uses GTK+ UI code. It just returns TRUE
1142 if the device is already online.
1144 There is some nasty code to ensure that subsequent calls to
1145 modest_platform_connect_and_wait() just wait for the first one to finish,
1146 by checking repeatedly in another idle handler. This is necessary,
1147 because other threads (or even the main thread, via another idle handler)
1148 can call modest_platform_connect_and_wait() while
1149 modest_platform_connect_and_wait() is running.
1151 (modest_platform_connect_and_wait_if_network_account),
1152 (modest_platform_connect_and_wait_if_network_folderstore):
1153 Convenience functions that calls modest_platform_connect_and_wait() if
1154 the account or folder might want network access.
1156 * src/modest-mail-operation.c:
1157 (modest_mail_operation_update_account):
1158 * src/modest-ui-actions.c: (download_uncached_messages),
1159 (modest_ui_actions_on_rename_folder), (delete_folder),
1160 (modest_ui_actions_on_main_window_move_to),
1161 (modest_ui_actions_on_msg_view_window_move_to):
1162 * src/widgets/modest-folder-view.c:
1163 (drag_and_drop_from_folder_view):
1164 Offer a connection if we are offline.
1166 * src/modest-tny-account.c: (on_connection_status_changed):
1167 Document this as only handling errors during network operations in progress,
1168 and replace the idle code with a simple call to
1169 modest_platform_connect_and_wait(), which does this instead.
1171 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1173 * src/modest-tny-account.c:
1174 (modest_tny_account_get_special_folder): (util_on_idle),
1175 Handle the GError so we can see when tny_folder_store_get_folders()
1176 fails, as it currently does while something else is connecting.
1178 Added util_run_in_main_thread_and_wait()
1179 which uses an idlen handler and mainloop to ensure that the function
1180 is called in the main thread.
1181 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1182 to make sure that we call attempt the connection in the mainloop only,
1183 which might solve some hangs.
1185 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1187 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1188 be found by their display name. This is never useful.
1189 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1190 by its ID, instead of trying to use its ID as its display name.
1192 * src/modest-tny-account-store.h:
1193 * src/modest-tny-account.c:
1194 (modest_tny_account_get_special_folder): Add a g_warning() when
1195 tny_folder_store_get_folders() returns an empty list for the maildir.
1197 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1198 Add a g_warning() when this returns NULL, because that it not allowed
1201 2007-07-02 Armin Burgmeier <armin@openismus.com>
1203 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1204 note when trying to cancel the wizard. This fixes projects.maemo.org
1207 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1209 * src/modest-tny-account.h:
1210 * src/modest-tny-account.c:
1211 (modest_tny_account_new_from_server_account),
1212 (modest_tny_account_new_from_server_account_name),
1213 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1214 because this must now be set before setting the proto. This is usd in
1215 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1216 warning in camel_session_get_service() caused by
1217 tny_camel_transport_account_prepare().
1219 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1222 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1224 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1226 (modest_connection_specific_smtp_edit_window_init):
1228 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1229 of "changed" for now
1231 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1233 * src/modest-tny-account.c:
1234 (modest_tny_account_new_from_server_account):
1235 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1236 now uses to request a connection when it needs one, and which it uses
1237 to tell us that something is wrong with the connection, so we can force
1238 the accounts offline to prevent further problems.
1240 * src/modest-defs.h:
1241 * src/modest-init.c: (init_default_settings):
1242 * src/modest-mail-operation.c:
1243 (modest_mail_operation_update_account):
1244 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1245 This should not be necessary anymore. Do not set the conf key that
1246 determined this (it was always TRUE and not set anywhere else).
1248 * src/modest-ui-actions.h: Remove unused and unimplemented
1249 modest_ui_actions_on_online_toggle_toggled().
1251 2007-06-29 Murray Cumming <murrayc@murrayc.com
1253 * src/maemo/modest-main-window.c: (connect_signals):
1254 Don't connect to delete_event twice. Maybe this was harmless.
1256 2007-06-29 Murray Cumming <murrayc@murrayc.com
1258 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1259 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1260 Debug output to give some more clue when a folder move is not allowed.
1262 2007-06-28 Murray Cumming <murrayc@murrayc.com
1264 * src/modest-tny-account.c: (on_modest_file_system_info),
1265 (modest_tny_account_get_mmc_account_name):
1266 Always call the callback, without checking whether the name has changed.
1267 * src/widgets/modest-folder-view.c: (strings_are_equal),
1268 (on_model_foreach_set_name), (on_get_mmc_account_name),
1269 (text_cell_data): Compare the name here, and use the name from
1270 the account rather than from the
1271 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1272 if the name was changed after the account was added to the model.
1273 That's a tinymail bug but not one that I want to fix now.
1275 This finally fixes projects.maemo.org bug NB#59301.
1277 2007-06-27 Armin Burgmeier <armin@openismus.com>
1279 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1282 2007-06-27 Murray Cumming <murrayc@murrayc.com
1284 * src/modest-tny-account.h:
1285 * src/modest-tny-account.c:
1286 Added modest_tny_account_get_mmc_account_name(), to set the memory
1287 card name asynchronously for the given account and then notify.
1288 (modest_tny_account_new_for_local_folders): Use this new function instead
1289 of using hildon_file_system_info_async_new() directly.
1291 * src/widgets/modest-folder-view.c: (text_cell_data):
1292 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1293 gtk_tree_model_row_changed() when it is available.
1295 This should fix projects.maemo.org bug NB#59301.
1297 2007-06-27 Murray Cumming <murrayc@murrayc.com
1299 * src/modest-mail-operation.c: (update_account_thread),
1300 (get_msgs_full_thread): Fix typo failures in the revert
1303 2007-06-27 Murray Cumming <murrayc@murrayc.com
1305 * src/maemo/modest-maemo-global-settings-dialog.c:
1306 (idle_select_default_focus):
1307 * src/modest-mail-operation.c: (idle_notify_progress),
1308 (idle_notify_progress_once), (set_last_updated_idle),
1309 (update_account_thread), (get_msgs_full_thread):
1310 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1311 * src/widgets/modest-header-view.c:
1312 (idle_notify_headers_count_changed_destroy),
1313 (idle_notify_headers_count_changed):
1314 Reverted the additions of gdk_threads_enter/leave(), in case this
1315 helps with a startup hang on the device.
1317 2007-06-26 Armin Burgmeier <armin@openismus.com>
1319 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1320 for supported secure authentication methods from server by
1321 gtk_dialog_run(), saving CPU time and a potential race condition.
1323 2007-06-26 Armin Burgmeier <armin@openismus.com>
1325 * src/maemo/modest-maemo-utils.h:
1326 * src/maemo/modest-maemo-utils.c: Added a
1327 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1328 only error code to tell the calling code when the user canceled the
1331 * src/maemo/modest-account-settings-dialog.h:
1332 * src/maemo/modest-account-settings-dialog.c:
1333 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1334 message if the retrieval of secure authentication methods was canceled
1335 by the user. Perform the check before saving anything to configuration
1336 to not end up with half-committed configuration changes, do not show
1337 a "Saving to configuration failed" note when authentication methods
1338 could not be retrieved.
1340 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1343 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1345 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1346 Only return the first level of folders under accounts, because the
1347 osso-global-search UI spec doesn't want the rest.
1348 This fixed projects.maemo.org bug NB#61811.
1350 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1352 * src/modest-tny-account-store.c:
1353 * src/modest-tny-account-store.h:
1354 Added modest_tny_account_is_memory_card_account().
1355 * src/maemo/modest-main-window.c: (create_details_widget):
1356 Show the same information items for the memory card as we show for the
1357 local-folders, to fix projects.maemo.org bug NB#59307.
1359 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1361 * src/modest-tny-account-store.c: (get_password):
1362 Added some checks for NULL to maybe prevent crashes, though I think
1363 it was Philip's last commit that actually prevented the crash here
1364 when creating a first new account.
1365 But the new account is still not usable (no messages are shown)
1366 until a restart of the application.
1368 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1370 * src/maemo/modest-maemo-global-settings-dialog.c:
1371 (idle_select_default_focus):
1372 * src/modest-mail-operation.c: (idle_notify_progress),
1373 (idle_notify_progress_once), (idle_notify_update_account_queue),
1374 (set_last_updated_idle), (update_account_thread),
1375 (notify_get_msgs_full), (get_msgs_full_destroyer),
1376 (get_msgs_full_thread):
1377 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1378 * src/widgets/modest-header-view.c:
1379 (idle_notify_headers_count_changed_destroy),
1380 (idle_notify_headers_count_changed):
1381 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1382 all idle handlers, because some other thread could be blocking
1383 the GDK lock, so that it can do GUI stuff.
1385 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1387 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1388 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1389 (on_idle_send_receive), (on_idle_open_default_inbox):
1390 * src/maemo/modest-msg-edit-window.c:
1391 (modest_msg_edit_window_attach_file_noninteractive):
1392 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1393 to prevent a hang. I don't quite understand why these are necessary,
1394 beause we should already be in the main loop. I guess something outside
1395 of the main loop is taking the lock.
1397 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1398 we are really using URIs, and use files that are more likely to exist.
1400 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1402 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1403 necessary because configure.ac now defines different variables.
1405 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1407 * libmodest-dbus-client/libmodest-dbus-client.c:
1408 * libmodest-dbus-client/libmodest-dbus-client.h:
1409 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1410 libmodest_dbus_client_compose_mail() is what things actually use.
1412 * src/dbus_api/modest-dbus-api.h:
1413 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1414 * tests/dbus_api/Makefile.am:
1415 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1418 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1420 * src/modest-init.c: (modest_init_local_folders):
1421 For memory-card (or other non local-folders) maildir accounts,
1422 always create an Archive folder, so that there is somewhere to put
1423 messages. This should be less confusing, because the user does not need
1424 to guess that the need to create a folder.
1426 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1428 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1429 Fixed icon size by using (50, 50) which is the same as defined by
1432 2007-06-25 Armin Burgmeier <armin@openismus.com>
1434 * src/widgets/modest-window-mgr.c:
1435 * src/modest-init.c:
1436 * configure.ac: Correctly recognize hildon-notify presence and fixed
1437 the build without it being installed.
1439 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1441 * libmodest-dbus-client/libmodest-dbus-client.c:
1442 (libmodest_dbus_client_search): Fix the build. Sorry.
1443 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1444 (reply_forward_cb): Initialize variables to fix the build.
1446 * src/modest-tny-account-store.c:
1447 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1448 comparison (a silly typo) so that email search results can be opened
1449 when there are more than one account.
1451 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1453 * libmodest-dbus-client/libmodest-dbus-client.c:
1454 (libmodest_dbus_client_search),
1455 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1456 instead of 1 second, because the search gets folders and messages from
1457 the server, which can take a long time. When it times out,
1458 osso-global-search will report no results.
1460 We need to specify whether we should search only cached information
1461 (maybe with a user preference), and the osso-email-search-plugin
1462 API should really be improved to allow that option, and to allow results
1463 to be delivered asynchronously in batches.
1465 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1467 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1468 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1469 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1471 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1473 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1474 that is an empty string. D-Bus seems to give us these instead of NULL.
1476 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1478 * src/dbus_api/modest-dbus-callbacks.c:
1479 * src/maemo/easysetup/modest-easysetup-wizard.h:
1480 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1481 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1482 (modest_connection_specific_smtp_edit_window_init):
1483 * src/maemo/modest-maemo-global-settings-dialog.c:
1485 * src/maemo/modest-maemo-utils.c:
1486 (modest_maemo_utils_setup_images_filechooser):
1487 * src/maemo/modest-main-window.c: (create_details_widget):
1488 * src/maemo/modest-msg-edit-window.c:
1489 (modest_msg_edit_window_attach_file_noninteractive),
1490 (modest_msg_edit_window_color_button_change),
1491 (modest_msg_edit_window_set_zoom):
1492 * src/modest-mail-operation.c: (update_account_thread):
1493 * src/modest-tny-account-store.c:
1494 * src/modest-tny-account.c:
1495 * src/widgets/modest-global-settings-dialog.c:
1496 * src/widgets/modest-window.h:
1498 Fixed build on bora!
1500 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1502 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1503 * src/modest-search.c: (modest_search_folder),
1504 (modest_search_all_accounts): Actually search only in the specified folder,
1505 doing a simple match on the folder ID.
1506 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1507 and added some documentation.
1509 2007-06-22 Armin Burgmeier <armin@openismus.com>
1511 * src/maemo/modest-maemo-utils.h:
1512 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1513 modest_maemo_utils_get_supported_secure_authentication_methods.
1515 * src/maemo/easysetup/modest-easysetup-wizard.c:
1516 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1517 one occured, not just "Server does not support secure authentication".
1519 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1521 * src/modest-tny-account-store.c: (get_password):
1522 Restored the call to tny_account_set_user() because Philip seems to have
1523 stopped this from crashing (by not using the freed string). It still does
1524 not work, but now we can test it.
1526 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1528 * src/maemo/modest-msg-edit-window.c: (init_window):
1529 Comment out use of an uninitialzed GtkScrolledWindow variable,
1530 to fix the build and stop a crash. Yet again.
1532 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1534 * src/modest-tny-account-store.c: (get_password):
1535 Remove the call to tny_account_set_user() because this actually crashes.
1536 As mentioned in the last commit, it is known to not work anyway.
1538 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1540 * src/modest-tny-account-store.c: (get_password):
1541 Use tny_account_set_username() to tell tinymail that the username might
1542 have changed too. But tinymail ignores this: see projects.maemo.org
1544 * src/modest-ui-actions.c:
1545 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1546 reset the connection when changing the username, and improve the comments.
1547 Save the changed username to gconf at least, so it is used when Modest is
1550 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1552 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1553 Do not use a query, so that we get all folders, including for POP and
1554 local-folders. They work as search criteria too.
1555 This fixes projects.maemo.org bug NB#57740.
1557 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1559 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1560 Comment out the use of hildon_notification_set_sound() because it is
1561 not declared, to fix the build. Warnings are serious, people.
1563 2007-06-21 Armin Burgmeier <armin@openismus.com>
1565 * src/maemo/modest-maemo-utils.h:
1566 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1567 modest_maemo_utils_get_supported_secure_authentication_methods()
1568 to query authentication methods for a specific user. This should fix
1569 projects.maemo.org bug NB#61369.
1571 * src/maemo/easysetup/modest-easysetup-wizard.c:
1572 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1575 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1577 * libmodest-dbus-client/libmodest-dbus-client.h:
1578 * libmodest-dbus-client/libmodest-dbus-client.c:
1579 (modest_dbus_message_iter_get_search_hit),
1580 (libmodest_dbus_client_search):
1581 Reorganised and commented this.
1582 Removed modest_search_hit_free() from the public API because it
1585 Added libmodest_dbus_client_get_folders() and
1586 modest_folder_result_list_free().
1588 * src/dbus_api/modest-dbus-api.h:
1589 * src/dbus_api/modest-dbus-callbacks.c:
1590 (modest_dbus_req_filter): Commented. Moved most code to
1591 on_dbus_method_search() and added on_dbus_method_get_folders().
1593 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1594 of the extra D-Bus handler.
1596 * tests/dbus_api/Makefile.am:
1597 * tests/dbus_api/test_get_folders.c: New test for
1598 libmodest_dbus_client_get_folders(). This seems to return an empty list
1599 at the moment. That could be the same error that causes the message list
1600 to be empty sometimes.
1601 This should help with projects.maemo.org bug NB#57740.
1603 2007-06-21 Armin Burgmeier <armin@openismus.com>
1605 * src/modest-mail-operation.c: Do not call
1606 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1607 notify the operation's end after having set the status to CANCELED for
1608 the operation queue to listen on. This fixes a deadlock when there
1609 were mail operations in the queue during its finalization.
1611 * src/modest-singletons.c: Reordered uninitialization of the account
1612 manager to happen after the mail operation queue was uninitialized
1613 because the mail operation's in the queue might still try to access
1614 the account manager (see modest_mail_operation_notify_end()). This
1615 fixes a potential crash when terminating the application.
1617 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1619 * src/modest-search.c:
1620 (search_mime_part_and_child_parts): Moved some code here so we
1621 can search recursively in child folders.
1622 (modest_search_folder): Search in the message as a mime part, instead
1623 of just its child mime parts.
1624 (read_chunk), (search_mime_part_ogs):
1625 Check how many bytes were read, to prevent an endless loop.
1626 Searching in message bodies now works. This finishes the fix for
1627 projects.maemo.org bug NB#61007.
1629 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1631 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1632 Add a g_warning when the item is not a folder.
1634 * src/modest-ui-dimming-rules.c:
1635 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1636 when selected item is not a folder (for instance, an account), because
1637 the UI spec only talks about folders.
1638 I am not sure what the UI spec wants, so this might not totally fix
1639 projects.maemo.org bug NB#60794.
1641 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1643 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1644 (load_from_file): Sort the list. The unsorted list would be more noticeable
1645 in non-English locales.
1647 * src/maemo/modest-msg-edit-window.c:
1648 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1649 warning and fix the build.
1651 * src/maemo/modest-progress-bar-widget.c:
1652 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1653 avoid a g_warning, and probably to avoid a crash.
1655 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1657 * src/modest-search.c: (modest_search_folder): Check for a GError
1658 when calling tny_folder_get_headers(), to show that this is not the cause
1661 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1663 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1664 Actually set the body query instead of the subject query.
1666 * src/modest-search.c: (search_mime_part_ogs),
1667 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1668 which would probably cause it to fail if we got this far.
1670 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1671 to simplify the code.
1672 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1673 be causing search-in-body to fail.
1675 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1677 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1679 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1680 Better debug message when the folder cannot be found.
1681 This should help with fixing projects.maemo.org bug #61287.
1682 * src/modest-search.c: (add_hit): Do not leak the furl string.
1684 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1686 * src/modest-ui-actions.c:
1687 (modest_ui_actions_on_folder_selection_changed):
1688 Do not special-case TNY_MERGE_FOLDER here, because
1689 modest_tny_folder_get_account() already does that. This fixes
1690 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1691 shown when the Outbox was selected).
1693 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1695 * libmodest-dbus-client/libmodest-dbus-client.c:
1696 (_dbus_iter_get_string_or_null): Initialize the string variable in
1697 case this helps with Dirk's crash.
1699 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1701 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1702 though it is not implemented yet (this function is maybe not even used),
1703 to avoid breaking ABI in future.
1704 * libmodest-dbus-client/libmodest-dbus-client.c:
1705 (get_attachments_string): Moved some code into this generic function.
1706 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1707 sends email. It is maybe not used.
1708 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1709 (on_send_mail): Use attachments.
1711 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1712 * src/maemo/modest-msg-edit-window.c:
1713 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1714 a filename before using it, to fix projects.maemo.org bug NB#58233.
1716 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1718 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1719 Initialize the continue_download variable to fix the build, and probably
1720 to fix randome behaviour.
1722 2007-06-18 Armin Burgmeier <armin@openismus.com>
1724 * src/modest-tny-send-queue.h:
1725 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1726 the queue so we can later show it in the UI. Replaced
1727 modest_tny_send_queue_msg_is_being_sent() by
1728 modest_tny_send_queue_get_msg_status().
1730 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1732 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1733 gpointer. This probably was not harmful, but just to be sure.
1735 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1737 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1738 Fix the build, but leave the function broken on Bora, because
1739 hildon_uri_action_get_service() does not exist.
1740 osso_uri_action_get_service() does not exist either, it seems.
1742 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1744 * src/modest-tny-account.c:
1745 (modest_tny_account_new_from_server_account):
1746 Uncommented the url debug output again, because it is useful for
1747 debugging, as I said in the comment.
1749 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1751 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1753 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1754 for Mameo Bora, to fix the build.
1756 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1759 Fixed build with hildon < 0.99
1761 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1762 Check if the selected account is busy instead of checking all accounts
1764 * src/modest-account-mgr-priv.h:
1765 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1766 (modest_account_mgr_init), (compare_account_name),
1767 (modest_account_mgr_set_account_busy),
1768 (modest_account_mgr_account_is_busy):
1769 * src/modest-account-mgr.h:
1770 Added busy information to the account manager. It possible to
1771 set an account to busy or not busy now.
1773 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1774 (modest_mail_operation_update_account),
1775 (modest_mail_operation_notify_end):
1776 Set the account to busy/not busy depending on the operation state.
1778 * src/widgets/modest-account-view.c:
1779 (modest_account_view_finalize), (get_last_updated_string),
1780 (update_account_view), (on_account_busy_changed), (init_view):
1781 Show string "Refreshing..." if the account is currently busy.
1783 All this fixes projects.maemo.org bug NB#59711
1785 2007-06-14 Armin Burgmeier <armin@openismus.com>
1787 * src/widgets/modest-attachments-view.h:
1788 * src/widgets/modest-attachments-view.c: Added
1789 modest_attachments_view_has_attachments() and fixed coordinate
1790 transformation in get_att_view_at_coords(). This fixes attachment
1793 * src/widgets/modest-msg-view.c: Make use of
1794 modest_attachments_view_has_attachments() to decide whether to show
1795 attachments in the header.
1797 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1799 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1800 (on_change), (on_combo_security_changed),
1801 (modest_connection_specific_smtp_edit_window_init),
1802 (modest_connection_specific_smtp_edit_window_set_connection),
1803 (modest_connection_specific_smtp_edit_window_is_dirty):
1804 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1805 * src/maemo/modest-connection-specific-smtp-window.c:
1808 Show an comfirmation dialog for the smpt-edit-window if there are
1809 unsaved changes and the user hits cancel.
1810 (projects.maemo.org bug NB#60479)
1812 2007-06-14 Armin Burgmeier <armin@openismus.com>
1814 * src/maemo/easysetup/modest-easysetup-wizard.c:
1815 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1816 address" info in banner instead of node, and select all the text as
1817 per UI spec. This fixes projects.maemo.org bug NB#60550.
1819 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1821 reviewed by: <delete if not using a buddy>
1823 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1824 * src/modest-ui-actions.c: (folder_refreshed_cb):
1826 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1828 * src/widgets/modest-folder-view.c: (filter_row):
1829 Explictly filter out the per-account outbox accounts. I don't know why
1830 these only sometimes show up, but now they should never show up in the UI.
1831 This should fix projects.maemo.org bug NB#60160.
1833 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1835 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1836 when the toolbar does not exist yet.
1837 * src/modest-widget-memory.c: (save_settings_header_view):
1838 Added g_warnings() to help us to discover when we are trying to set
1839 an empty columns list in gconf.
1841 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1843 * src/modest-init.h:
1844 * src/modest-init.c:
1845 Added modest_init_get_default_header_view_column_ids().
1847 * src/modest-widget-memory.c: (restore_settings_header_view):
1848 Use the new function to get defaults, if the gconf key is empty,
1849 instead of not creating any columns. This seems to fix the
1850 empty right-hand pane problems.
1852 * src/widgets/modest-header-view.h: Improved documentation.
1854 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1856 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1857 Revert the use of the display name as the account name, because this
1858 is generally wrong and would break the code that follows.
1860 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1862 * src/maemo/easysetup/modest-easysetup-wizard.c:
1863 (check_for_supported_auth_methods), (on_before_next),
1866 More correct fix for projects.maemo.org bug NB# 58991
1867 Do not longer accept AUTH_PASSWORD as secure method and choose
1868 correct method when creating the account.
1870 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1872 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1873 Fixed projects.maemo.org bug NB# 58991
1875 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1877 * src/modest-init.c: (modest_init_init_core),
1878 (modest_init_local_folders): Fixed compilation errors.
1880 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1882 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1883 Remove unnecessary lib/include, though it is good in principle when needed.
1885 * src/modest-init.c: (modest_init_one_local_folder),
1886 (modest_init_local_folders):
1887 * src/modest-init.h: Initialize the .modest library for memory cards,
1888 instead of just doing nothing for them. This should allow us to create
1889 folders there, fixing projects.maemo.org bug NB#59297.
1891 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1893 * libmodest-dbus-client/libmodest-dbus-client.c:
1894 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1895 (libmodest_dbus_client_compose_mail),
1896 (libmodest_dbus_client_open_message),
1897 (libmodest_dbus_client_send_and_receive),
1898 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1900 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1901 (on_idle_open_message), (modest_dbus_req_handler),
1902 (search_result_to_message), (modest_dbus_req_filter):
1903 * src/modest-search.c: (add_hit), (modest_search_folder),
1904 (modest_search_all_accounts): Improved debug messages.
1906 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1908 * src/modest-tny-account-store.c:
1909 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1912 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1915 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1917 * src/modest-tny-account-store.c: (get_server_accounts):
1918 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1919 even when there are no accounts, so that the Outbox folder is always
1920 visible. This fixes projects.maemo.org bug NB#60158.
1922 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1924 * src/maemo/modest-main-window.c: (create_details_widget):
1925 Use the mcen_va_never logical ID.
1927 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1929 * src/dbus_api/modest-dbus-api.h:
1930 * src/dbus_api/modest-dbus-callbacks.c:
1931 (on_idle_open_default_inbox), (on_open_default_inbox),
1932 (modest_dbus_req_handler):
1933 Added a new OpenDefaultInbox method.
1935 * libmodest-dbus-client/libmodest-dbus-client.h:
1936 * libmodest-dbus-client/libmodest-dbus-client.c:
1937 Added libmodest_dbus_client_open_default_inbox() to call the new
1938 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1939 though it should maybe be used by a new osso-email-interface function.
1941 * tests/dbus_api/Makefile.am:
1942 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1945 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1947 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1948 NULL, so that the signals get all the keys. This should not actually
1949 change any behaviour because we currently update everything when anything
1952 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1954 * src/widgets/modest-folder-view.c: (text_cell_data),
1955 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1956 (find_inbox_iter): If tinymail tells us that the folder is
1957 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1958 This causes the inbox to be selected at startup, fixing part of
1959 projects.maemo.org bug NB#56305.
1961 * src/modest-ui-dimming-rules.c:
1962 (modest_ui_dimming_rules_on_tools_smtp_servers):
1963 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1964 the SMTP servers menu item.
1965 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1966 that the SMTP Servers menu item is dimmed when there are no accounts,
1967 as a future version of the UI spec will require. This fixes
1968 projects.maemo.org bug NB#56305.
1970 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1972 * src/maemo/modest-maemo-utils.c:
1973 (modest_maemo_utils_get_supported_secure_authentication_methods):
1974 Added label to dialog instead of unreadable title
1976 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1977 (modest_main_window_new):
1978 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1981 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1982 * src/modest-account-mgr.h:
1983 Added method to avoid code duplication
1985 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1986 (modest_ui_actions_on_send_receive):
1987 Use modest_account_mgr_has_accounts
1989 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1991 * src/maemo/easysetup/modest-presets.c:
1992 (modest_presets_get_info_server_security): Do not report secure auth
1994 * src/modest-protocol-info.c: Use the defines for the gconf key names
1995 for secure authentication. This was not working because we were writing
1996 Password and reading password, and the check was case sensitive.
1997 With this, gmail now works for receiving and sending when created via
2000 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2002 * src/maemo/easysetup/modest-presets.c:
2003 (modest_presets_get_info_server_security): Correct the key name for
2004 SecureSmtp, because it seems to be case-sensitive.
2005 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2006 Do not try to get the 0th notebook page if there are 0 pages, to
2007 avoid a g_warning().
2009 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2011 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2012 Prevent use of the new notification feature for now, because it currently
2013 shows one dialog for each new email, which is annoying.
2015 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2017 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2018 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2019 when no country was selected, so that we show the global ones.
2020 * src/maemo/easysetup/modest-presets.c:
2021 (modest_presets_get_providers): Return only the global providers, not
2022 all providers when mmc=0 was requested.
2024 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2026 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2027 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2028 provider ID in the combo.
2030 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2031 Do not show the page numbers, because it would be confusing when we add
2032 the 2 extra pages for the custom setup, when the user chooses the "Other"
2033 provider. This fixes projects.maemo.org bug NB#59028
2035 * src/modest-init.c: (modest_init_init_core),
2036 (modest_init_local_folders):
2037 * src/modest-init.h:
2038 * src/modest-tny-account.c:
2039 (modest_tny_account_new_for_local_folders): Do not create default folders
2040 for the memory card. This should fix projects.maemo.org bug NB#59328.
2042 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2044 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2045 Free the changed_conf_keys string items. They are already freed in the
2046 idle handler if that runs first.
2048 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2050 * src/modest-ui-actions.c:
2051 (modest_ui_actions_on_password_requested): Check that the server name
2052 is not NULL, because I just saw a password dialog with (null) as the
2055 * src/modest-tny-folder.[h|c]: Added
2056 modest_tny_folder_is_memory_card_folder().
2057 * src/modest-ui-dimming-rules.c:
2058 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2059 menu item for memory cards, as per the UI spec (section 7.4). This should
2060 fix projects.maemo.org bug NB#59297.
2062 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2064 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2065 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2066 is another problem with the code, see Murray's comment at line 772)
2068 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2070 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2071 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2072 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2073 (load_from_file), (easysetup_country_combo_box_init),
2074 (easysetup_country_combo_box_get_active_country_ids),
2075 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2076 instead of just one ID, to avoid duplicate country names in the UI.
2078 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2079 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2080 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2081 a single ID, avoiding duplicate providers.
2082 * src/maemo/easysetup/modest-easysetup-wizard.c:
2083 (on_combo_account_country): Adapt to use a list.
2085 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2087 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2088 keys changed in the last X seconds.
2090 * src/modest-account-mgr.h:
2091 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2092 (on_key_change), (modest_account_mgr_class_init),
2093 (modest_account_mgr_init), (modest_account_mgr_finalize):
2094 As the keys are changed, save them in a GSList* and signal that GSList*
2095 further every X seconds, to batch changes, to allow us to do just one
2096 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2097 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2099 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2100 changed signal signature.
2102 * src/modest-conf.c: (modest_conf_set_list),
2103 (modest_conf_on_change): Reenable notification.
2105 (modest_conf_maemo_fake_on_change): Comment out the hack that
2106 notified immediately instead of asynchronously.
2108 * src/widgets/modest-account-view.h:
2109 * src/widgets/modest-account-view.c:
2110 (update_account_view): Select the previously-selected account ID,
2111 if possible. This fixes projects.maemo.org bug NB#56933.
2113 (on_account_changed), (on_account_removed),
2114 (modest_account_view_select_account):
2116 Remove the block/unblock functions
2117 because they were not useful.
2119 * src/maemo/modest-account-view-window.c:
2120 (on_delete_button_clicked), (on_edit_button_clicked),
2121 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2123 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2125 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2126 Improve the error dialog to show Incorrect Account Settings, which seems
2127 clearer, and say that the internal error message (to be removed from the
2128 dialog later) is often misleading.
2129 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2131 * src/modest-tny-account.c:
2132 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2133 URL because this is so useful for debugging on the device.
2135 * src/widgets/modest-serversecurity-combo-box.c:
2136 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2138 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2140 * src/modest-mail-operation.c:
2141 (modest_mail_operation_send_new_mail):
2142 Added a comment about a nasty but apparently harmless message. Details
2143 added to the wiki g_warnings() page.
2145 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2147 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2148 (modest_tny_send_queue_class_init):
2149 Do not use the priv struct because it is empty, to avoid g_warnings
2150 about a non-existant priv struct.
2152 * src/modest-tny-account-store.c:
2153 (modest_tny_account_store_get_server_account),
2154 (modest_tny_account_store_get_transport_account_for_open_connection
2155 ): Do not try to get transport server accounts for local folders,
2156 because they don't have any. This avoids a g_warning().
2158 * src/maemo/modest-main-window.c:
2159 (modest_main_window_notify_send_receive_initied),
2160 (on_configuration_key_changed):
2161 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2162 * src/modest-defs.h:
2163 * src/modest-mail-operation.c:
2164 (modest_mail_operation_update_account):
2165 * src/modest-tny-account-store.h:
2166 * src/modest-tny-account.c:
2167 (modest_tny_account_get_special_folder),
2168 (modest_tny_account_new_for_local_folders),
2169 (modest_tny_account_new_for_per_account_local_outbox_folder):
2170 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2171 * src/modest-tny-local-folders-account.c:
2172 (add_account_folders_to_merged_folder):
2173 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2174 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2175 (modest_ui_actions_on_send):
2176 * src/widgets/modest-folder-view.c: (update_model):
2177 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2178 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2179 modest_tny_account_store_get_tny_account_by_account() to
2180 modest_tny_account_store_get_server_account() to make the code clearer.
2182 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2184 * src/dbus_api/modest-dbus-api.h:
2185 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2186 * src/maemo/modest-msg-edit-window.c:
2187 (modest_msg_edit_window_attach_file_noninteractive):
2188 added g_warning in case the file to be attached does not exist
2189 * tests/dbus_api/test_compose_mail.c: (main):
2190 removed obsolete comment, added generic files as test case
2192 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2194 * src/modest-tny-account-store.c: (get_server_accounts):
2195 Create the local folders account only once, not once for each outbox, and
2196 not only when there are some outboxes.
2198 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2200 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2201 code that is causing a crash at startup. Sergio says that he is fixing this.
2203 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2205 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2206 * src/maemo/modest-account-settings-dialog.c:
2207 (create_page_outgoing),
2208 (modest_account_settings_dialog_set_account_name),
2209 (save_configuration):
2210 - Fixed handling of the "Use secure authentication" toggle to comply with
2211 the ui specification. See also projects.maemo.org bug NB#58400
2213 - Restore the Secure connection setting combo correctly when loading
2216 * src/maemo/modest-maemo-utils.c:
2217 (on_camel_account_get_supported_secure_authentication),
2218 (modest_maemo_utils_get_supported_secure_authentication_methods):
2219 Fixed a crasher if operation is canceled
2221 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2222 (modest_protocol_info_auth_is_secure):
2223 * src/modest-protocol-info.h:
2225 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2226 the sense of the "Use secure authentication" toggle.
2228 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2230 * src/modest-tny-account-store.h:
2231 * src/modest-tny-account-store.c:
2232 Added modest_tny_account_store_get_local_folders_account().
2234 * src/modest-tny-folder.h:
2235 * src/modest-tny-folder.c:
2236 (modest_tny_folder_get_account):
2237 Added this replacement for tny_folder_get_account() which returns
2238 the local-folders account for TnyMergeFolders, to avoid the
2239 warning about the unimplemented get_account_func() vfunc().
2241 (modest_tny_folder_get_rules),
2242 * src/modest-ui-actions.c:
2243 (modest_ui_actions_on_folder_selection_changed):
2244 * src/modest-mail-operation.c:
2245 (modest_mail_operation_remove_folder),
2246 (modest_mail_operation_xfer_folder),
2247 (modest_mail_operation_rename_folder),
2248 (modest_mail_operation_get_msg),
2249 (modest_mail_operation_get_msgs_full),
2250 (modest_mail_operation_remove_msg),
2251 (modest_mail_operation_xfer_msgs),
2252 (modest_mail_operation_refresh_folder):
2253 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2255 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2257 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2258 (modest_server_account_set_security):
2259 * src/modest-defs.h: Add comments explaining that our
2260 UI spec means TLS when it says Normal, so these do not look like errors.
2262 * src/modest-tny-account.c:
2263 (modest_tny_account_new_from_server_account): Use the new tinymail
2264 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2265 for TLS. This should fix projects.maemo.org bug NB#58460.
2267 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2269 * src/maemo/easysetup/modest-easysetup-wizard.c:
2270 (create_account): Correct the position of the gconf sanity check warning.
2271 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2272 of using the g_idle_add() hack, because this does not seem to be necessary
2273 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2274 caused by something other than maemo's gconf.
2275 This fixes projects.maemo.org bug #59022.
2277 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2279 * src/modest-account-mgr-helpers.c:
2280 (modest_account_mgr_get_default_account): Do not check that the account
2281 exists if there is no default account (NULL), to fix a runtime warning.
2283 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2285 * src/widgets/modest-folder-view.c: (update_model):
2286 Do not unref the treemodel before we have finished with it.
2287 This prevents a valgrind warning and an occasional crash at startup.
2289 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2291 * libmodest-dbus-client/libmodest-dbus-client.h:
2292 added libmodest_dbus_client_compose_mail()
2293 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2295 added functions needed for SendAsMail() functionality
2296 * src/maemo/modest-msg-edit-window.c:
2297 (modest_msg_edit_window_attach_file_noninteractive):
2298 non interactively attaching files to message edit window
2299 * src/widgets/modest-msg-edit-window.h:
2300 * tests/dbus_api/Makefile.am:
2301 added test_compose_mail.c
2302 * tests/dbus_api/test_compose_mail.c: (main):
2304 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2306 * src/modest-account-view.c:
2307 Fixed bug projects.maemo.org bug NB#59307
2309 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2311 * src/maemo/easysetup/modest-easysetup-wizard.c:
2312 (get_serverport_incoming), (on_before_next), (create_account):
2313 * src/maemo/modest-account-settings-dialog.c:
2314 (modest_account_settings_dialog_set_account_name):
2315 * src/maemo/modest-maemo-utils.c:
2316 (on_camel_account_get_supported_secure_authentication_status),
2317 (on_camel_account_get_supported_secure_authentication),
2318 (on_secure_auth_cancel),
2319 (modest_maemo_utils_get_supported_secure_authentication_methods):
2321 Implemented security authentication for settings and easysetup.
2323 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2325 * src/maemo/modest-main-window.c: (create_details_widget):
2326 Show the total size for memory card accounts too, instead of showing
2327 the name again. Fixes bug projects.maemo.org bug NB#59307.
2329 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2332 * src/modest-tny-simple-folder-store.c:
2333 * src/modest-tny-simple-folder-store.h: Removed.
2335 * src/modest-tny-local-folders-account.h
2336 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2337 for the local-folders maildir, with an extra TnyMergedFolder containing
2338 the folders of the per-account outbox store accounts.
2339 * src/modest-tny-account-store.c: (get_server_accounts):
2340 Add the outboxes to the special local folders account after creating it.
2342 * src/modest-tny-account.c:
2343 (modest_tny_account_new_for_local_folders): Create the derived
2344 account when creating the main local-folders account.
2346 * src/maemo/modest-main-window.c: (create_details_widget),
2347 (modest_main_window_set_contents_style):
2348 Adapted to the use of the derived account instead of the folder store.
2350 * src/modest-ui-actions.c:
2351 (modest_ui_actions_on_folder_selection_changed):
2352 * src/modest-ui-dimming-rules.c:
2353 (modest_ui_dimming_rules_on_new_folder):
2354 * src/widgets/modest-folder-view.c: (text_cell_data),
2355 (icon_cell_data), (filter_row), (update_model),
2356 (get_cmp_rows_type_pos):
2359 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2360 Do not get the priv struct, because no priv struct has been set,
2361 to avoid a runtime warning.
2363 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2364 #ifelse with #else, to fix a warning, to fix the build.
2367 2007-06-05 Christian Kellner <ckellner@openismus.com>
2369 * libmodest-dbus-client/libmodest-dbus-client.c:
2370 Fix small typo in doc (why do you always see them
2371 AFTER committing stuff?)
2374 2007-06-05 Christian Kellner <ckellner@openismus.com>
2376 * libmodest-dbus-client/libmodest-dbus-client.c:
2377 (libmodest_dbus_client_search):
2378 Initialize hit list with NULL. Also set folder list
2379 to "" if NULL was supplied.
2382 2007-06-03 Christian Kellner <ckellner@openismus.com>
2384 * libmodest-dbus-client/libmodest-dbus-client.c:
2385 (modest_search_hit_list_free):
2386 Make it save to call it with NULL.
2388 * src/dbus_api/modest-dbus-callbacks.c:
2389 * src/modest-search.c:
2390 Return full ModestSearchHits as the search result list not TnyHeader
2391 since can't be around withouth the correspoding TnyFolder.
2393 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2395 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2396 Added currently commented code to check for secure auth
2398 * src/maemo/modest-account-settings-dialog.c: (on_response),
2399 (save_configuration), (show_ok):
2400 Fixed projects.maemo.org bugs NB #59248 and #59251
2402 * src/maemo/modest-maemo-utils.c:
2403 (on_camel_account_get_supported_secure_authentication_status),
2404 (on_camel_account_get_supported_secure_authentication),
2405 (modest_maemo_utils_get_supported_secure_authentication_methods):
2406 * src/maemo/modest-maemo-utils.h:
2407 Moved get_supported_secure_authentication() method here to be able
2408 to use it from easysetup wizard.
2410 * src/modest-pair.c: (on_pair_compare_as_string):
2411 Should compare string with first part of pair and not
2412 strcmp pairs which will crash.
2414 * src/modest-protocol-info.c:
2415 (modest_protocol_info_protocol_is_store):
2416 * src/modest-protocol-info.h:
2417 Added modest_protocol_info_get_auth_protocol_name()
2419 2007-06-03 Armin Burgmeier <armin@openismus.com>
2421 * src/modest-mail-operation.c:
2422 (modest_mail_operation_get_msgs_full): Set priv->account also when
2423 only retrieving a single message. This avoids a crash when canceling
2426 (modest_mail_operation_notify_end): Do not explicitely remove the
2427 operation from the queue but only emit the progress_changed signal.
2428 The queue itself listens to that signal to remove the operation when
2429 it is finished. This reduces coupling and removes a potential deadlock
2430 when modest_mail_operation_notify_end() is called from the queue
2431 itself. If that is a problem performance-wise, I would suggest to
2432 implement a status-changed signal or something.
2434 * src/modest-mail-operation-queue.c: Make sure to never call a
2435 function from another file while the queue is locked. This (hopefully)
2436 fixes another deadlock when exiting the application while retrieving
2439 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2441 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2442 Fixed build if libogs is not available
2444 2007-06-03 Christian Kellner <ckellner@openismus.com>
2446 * libmodest-dbus-client/libmodest-dbus-client.h:
2447 * libmodest-dbus-client/libmodest-dbus-client.c:
2448 (libmodest_dbus_client_delete_message):
2449 Implement deletion of messages (Client side).
2451 (modest_search_hit_free),
2452 (modest_search_hit_list_free):
2453 Utility functions to free the result hits.
2455 * src/dbus_api/modest-dbus-api.h:
2456 * src/dbus_api/modest-dbus-callbacks.c:
2457 (on_delete_message),
2458 (modest_dbus_req_handler):
2459 Implement deletion of messages (Server side).
2461 * tests/dbus_api/test_search.c: (main):
2464 * tests/dbus_api/Makefile.am:
2465 * tests/dbus_api/test_delete_message:
2466 Add little test for the message deletion logic
2468 2007-06-03 Armin Burgmeier <armin@openismus.com>
2470 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2471 when the operation queue was not empty. projects.maemo.org bug
2474 2007-06-03 Armin Burgmeier <armin@openismus.com>
2476 * src/widgets/modest-account-view.c
2477 (on_account_default_toggled): Toggle default account column
2478 explicitely instead of waiting for gconf notification (which is
2479 currently ignored). This should fix projects.maemo.org bug NB#56910
2480 for now. It should probably be removed when gconf notifications are
2483 2007-06-03 Christian Kellner <ckellner@openismus.com>
2485 * libmodest-dbus-client/libmodest-dbus-client.c:
2486 Removed debugging spew.
2488 * src/dbus_api/modest-dbus-callbacks.c:
2489 Added debugging info.
2491 * src/modest-search.c:
2492 (modest_search_all_accounts):
2493 Use tny_account_store_get_accounts () on the account store
2494 to get all accounts which is the way to get all accounts.
2496 * tests/dbus_api/test_search.c: (main):
2497 Make it possible to supply the search term on the command line.
2499 2007-06-03 Christian Kellner <ckellner@openismus.com>
2501 * libmodest-dbus-client/libmodest-dbus-client.c:
2502 * libmodest-dbus-client/libmodest-dbus-client.h:
2503 Implement searching for mesages over raw dbus. (Client side)
2505 * src/dbus_api/Makefile.am:
2506 * src/dbus_api/modest-dbus-api.h:
2507 * src/dbus_api/modest-dbus-callbacks.c:
2508 * src/dbus_api/modest-dbus-callbacks.h:
2509 Search framework (Server side). Also implement on_idle_open_message().
2511 * src/maemo/modest-platform.c: (modest_platform_init):
2512 Prepare for raw dbus/osso rpc interaction.
2514 * src/modest-search.h:
2515 Changed minsize from unspecific guint to guint32.
2517 * src/modest-search.c:
2519 Added strange hack which magically made tnymail work.
2521 (modest_search_folder),
2522 (modest_search_account),
2523 (modest_search_all_accounts):
2524 Implement helper functions to search all accounts, specific account
2527 * tests/dbus_api/Makefile.am:
2528 * tests/dbus_api/test_open_message.c:
2529 Read url to open from commandline.
2531 * tests/dbus_api/test_search.c:
2532 Implement small test for dbus search stuff
2534 2007-06-02 Armin Burgmeier <armin@openismus.com>
2536 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2537 include account type and account title. This fixes projects.maemo.org
2540 * src/maemo/modest-account-view-window.c: Set a title for the window.
2542 2007-06-02 Armin Burgmeier <armin@openismus.com>
2544 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2545 incoming and outgoing server name based on email address and server
2546 types as long as the names have not been edited manually. This fixes
2547 projects.maemo.org bug NB#58671.
2549 2007-06-02 Armin Burgmeier <armin@openismus.com>
2551 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2552 server type cannot be changed in future to the incoming details page
2553 when creating an account. This fixes projects.maemo.org bug NB#59029.
2555 2007-06-02 Armin Burgmeier <armin@openismus.com>
2557 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2558 and assigned max width chars so that they wrap instead of being
2559 truncated. Fixes projects.maemo.org bug NB#56126.
2561 2007-06-02 Armin Burgmeier <armin@openismus.com>
2563 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2564 introductory note to the connection specific smtp servers dialog, as
2565 section 8.12 of the email UI specification requires. This fixes
2566 projects.maemo.org bug NB#59212.
2568 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2570 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2571 Check for running mail operations, and offer to cancel them, as per the UI
2572 spec. This fixes projects.maemo.org bug NB#59041 .
2573 However, I suspect that tinymail may still use the network connection
2574 in ways that we cannot detect or cancel. But it should at least adapt to
2575 changes fairly well.
2577 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2579 * src/modest-tny-account-store.c: (recreate_all_accounts),
2580 (get_cached_accounts), (get_server_accounts): Do more sensible
2581 ref-counting of the temporarily-cached outbox accounts list. This seems
2582 to fix a crash when entering the password when the password was wrong.
2584 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2586 * src/gnome/modest-main-window.c: (connect_signals):
2587 * src/modest-tny-account-store.c: (get_password),
2588 (modest_tny_account_store_alert): Added comments and clues and
2589 commented-out code about how we currently fail to deal with connection
2590 errors and wrong passwords, and how we should.
2592 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2594 * src/widgets/modest-retrieve-combo-box.c:
2595 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2596 This fixes projects.maemo.org bug NB#58472 .
2598 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2600 * src/maemo/easysetup/modest-easysetup-wizard.c:
2601 (create_page_complete_easysetup):
2602 (create_page_complete_custom): Correct the last commit,
2603 putting the correct sentences in the correct pages.
2605 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2607 * src/maemo/easysetup/modest-easysetup-wizard.c:
2608 (create_page_complete_custom): Show the second sentence of text
2609 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2612 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2614 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2615 Set the leave-on-server conf key by default. This fixes
2616 projects.maemo.org bug NB#59258 .
2618 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2620 * src/maemo/modest-account-view-window.c:
2621 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2622 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2625 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2627 * src/maemo/easysetup/modest-easysetup-wizard.c:
2628 (create_caption_new_with_asterisk):
2629 * src/maemo/modest-account-settings-dialog.c:
2630 (create_caption_new_with_asterisk):
2631 Uncomment the code to add the asterisk, because they are no longer in the
2632 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2633 (update_incoming_server_title): Add an asterisk here too.
2635 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2637 * src/maemo/modest-maemo-global-settings-dialog.c:
2638 (current_connection): Check that we are even connected before trying to
2639 get the current connection name, to prevent a warning.
2641 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2642 Change the comments because tny_maemo_conic_device_connect() is now meant to
2644 * src/modest-mail-operation.c:
2645 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2646 make sure we have a connection and fail if we can't connect.
2648 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2650 * src/maemo/modest-main-window.c:
2651 (on_account_store_connecting_finished): Do not try to get the
2652 connection ID if we are not really connected. I am surprised that
2653 this signal handler is called when we are not connected.
2655 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2657 * src/modest-error.h:
2658 * src/modest-ui-actions.c:
2659 (modest_ui_actions_get_msgs_full_error_handler):
2660 Renamed an enum, added comments, added an enum
2661 for retrieve-limit errors.
2663 * src/modest-mail-operation.c: (foreach_add_item),
2664 (internal_folder_observer_update), (update_account_thread),
2665 (modest_mail_operation_get_msgs_full):
2666 (modest_mail_operation_update_account),
2667 Added comments about how this works, and some code that should
2668 (but does not) check the retrieve-limit. See the TODO comment.
2670 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2672 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2673 Initialize help_id to fix the build. Warnings are good.
2675 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2677 * src/widgets/modest-hbox-cell-renderer.c:
2678 (modest_hbox_cell_renderer_append):
2679 * src/widgets/modest-vbox-cell-renderer.c:
2680 (modest_vbox_cell_renderer_append):
2681 Fix the last commit by doing an extra ref.
2683 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2685 * src/widgets/modest-hbox-cell-renderer.c:
2686 (modest_hbox_cell_renderer_append):
2687 * src/widgets/modest-vbox-cell-renderer.c:
2688 (modest_vbox_cell_renderer_append):
2689 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2690 to fix the build with Maemo Bora.
2691 However, there seems to be a remaining crash, probably due to reference
2694 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2696 * src/modest-tny-account.c:
2697 (modest_tny_account_new_for_local_folders):
2698 Use hildon_file_system_info_async_new() to get a better name for
2699 the memory card account, setting it as the account name.
2700 The timing seems to work, but this is probably
2701 not the best place to do this. See the TODO comment.
2702 * src/maemo/modest-main-window.c: (create_details_widget):
2703 * src/widgets/modest-folder-view.c: (text_cell_data):
2704 Use the tny account name instead of hardcoding a name.
2706 2007-05-30 Christian Kellner <ckellner@openismus.com>
2708 * src/modest-search.c: (modest_search):
2709 Correctly set part_search_func even if we have already parsed
2710 the query and thus a valid OgsTextSearcher object.
2712 2007-05-30 Christian Kellner <ckellner@openismus.com>
2715 Search and check for libogs.
2718 Incooparte the ogs build env.
2720 * src/modest-mime-part-search-stream.c:
2721 * src/modest-mime-part-search-stream.h:
2722 Removed since we do the real searching now in modest-search.c.
2724 * src/modest-search.c:
2725 * src/modest-search.h:
2726 Implement support for ogs. We use that if available and requested
2727 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2728 should now handle the corner case when the search term is spread
2729 across multiple reads.
2730 Also the logic in modest_search () was corrected to search all
2731 requested fields until one is found.
2733 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2735 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2737 * src/modest-init.h:
2738 * src/modest-init.c: Made modest_init_local_folders() take a
2739 path and be public so we can iniitialize maildir folders on
2742 * src/modest-local-folder-info.h:
2743 * src/modest-local-folder-info.c:
2744 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2746 * src/modest-tny-account.c:
2747 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2748 still means the standard local-folders path on the local volume.
2750 * src/modest-tny-account-store.c:
2751 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2752 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2753 all accounts when that happens.
2754 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2755 this too, so it shows up in the treeview.
2757 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2759 * src/maemo/modest-maemo-global-settings-dialog.c:
2760 (current_connection):
2761 * src/widgets/modest-global-settings-dialog.c:
2762 (current_connection_default):
2763 Use the enum values instead of 0, 1 and -1,
2764 to make the code clearer.
2766 * src/modest-account-mgr-helpers.c:
2767 (modest_account_mgr_get_connection_specific_smtp): Make this code
2770 * src/modest-runtime.h:
2771 * src/modest-runtime.c:
2772 Added modest_runtime_remove_all_send_queues().
2773 * src/maemo/modest-main-window.c:
2774 (on_account_store_connecting_finished): Recreate the send queues,
2775 using the appropriate transport accounts for this new connection.
2776 Some futher adapting might be needed if the old send queues are not
2777 automatically stopped at this point.
2779 * src/modest-tny-account-store.c: (get_server_accounts):
2780 Create the connection-specific transport accounts, so that they can
2781 be found later by their ID.
2783 * src/modest-tny-account.h:
2784 * src/modest-tny-account.c:
2785 Added modest_tny_account_new_from_server_account_name().
2786 modest_tny_account_new_from_server_account(): Do not create the
2787 send queues here, because they will be
2788 recreated anyway when the connection changes for the first time.
2790 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2792 * src/modest-local-folder-info.h:
2793 * src/modest-local-folder-info.c:
2794 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2795 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2796 tbox_folder): Take a modest account name instead of a server TnyAccount,
2797 so we can have per-modest-account rather than per-transport-account
2799 We must make sure that we change or recreate the exisitng send queues
2800 when the connection changes for connection-specific transport accounts.
2802 * src/modest-tny-account-store.c:
2803 (create_per_account_local_outbox_folders): Create outboxed per modest
2804 account, not per transport account.
2806 * src/modest-tny-account.h:
2807 * src/modest-tny-account.c:
2808 (modest_tny_account_get_special_folder): For outboxes, get the
2809 parent modest account name. The account is ignored for other folders.
2810 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2811 modest account name rather than a server TnyAccount.
2813 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2815 * src/modest-tny-account.c:
2816 (modest_tny_account_new_from_server_account):
2817 Call modest_runtime_get_send_queue() immediately after creating transport
2818 accounts, so that they start trying to send email from the outbox as soon
2819 as possible at startup. This is probably what we want.
2821 * src/modest-mail-operation.c: (update_account_thread):
2822 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2823 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2824 * src/modest-tny-send-queue.h:
2825 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2826 (modest_ui_actions_on_send):
2827 Added comments about how sending works, though it needs some more work.
2829 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2831 * src/modest-tny-account.c:
2832 (modest_tny_account_get_special_folder): Add TODO because this fails when
2833 the network is busy.
2834 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2835 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2836 Do not try to show this window when there is no active account. The UI
2837 specs does not tell us what to do in this case.
2839 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2843 * src/maemo/Makefile.am:
2844 * src/widgets/Makefile.am: Some dist fixes.
2846 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2848 * src/maemo/modest-connection-specific-smtp-window.c:
2849 (on_button_edit): Make the code clearer, to prevent a double free.
2851 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2853 * src/maemo/modest-account-settings-dialog.c:
2854 (modest_account_settings_dialog_set_account_name),
2855 Check the connection-specific smtp servers checkbox if there are any.
2857 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2858 (modest_connection_specific_smtp_edit_window_init):
2859 Start with a suitable port number.
2861 * src/modest-account-mgr-helpers.h:
2862 * src/modest-account-mgr-helpers.c: Added
2863 modest_account_mgr_get_has_connection_specific_smtp().
2865 (modest_account_mgr_set_connection_specific_smtp),
2866 (modest_account_mgr_remove_connection_specific_smtp),
2867 (modest_account_mgr_get_has_connection_specific_smtp),
2868 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2869 connection-specific smtp server accounts in the account, rather than
2870 the server account conf dir.
2872 This fixes bug projects.maemo.org bug NB#58263 .
2874 * src/modest-tny-account-store.c:
2875 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2876 if there are no server accounts yet, to prevent an infinite loop when there
2877 are no accounts. Document that one must be called before the other.
2879 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2881 * src/modest-account-mgr-helpers.c:
2882 (modest_account_mgr_get_default_account): Make sure that at least
2883 one account is always the default, if there are any enabled accounts.
2884 This is just a sanity check that shouldn't be necessary.
2886 * src/modest-account-mgr-priv.c:
2887 (_modest_account_mgr_account_from_key): Unescape the conf key to
2888 get the real account name. For instance, this is an issue if a space
2889 was in the account name, which can happen because the account name
2890 is generated from the display name.
2891 (_modest_account_mgr_get_account_keyname): Always escape the
2893 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2894 Unescape the conf keys to get the real account names.
2896 For instance, previously the is-default radio button in the accounts
2897 list was not checked for any accounts at first. This fixes that,
2898 and might fix several similar bugs.
2900 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2902 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2903 Removed some debug printfs.
2905 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2907 Modest on-disk outbox directories are now here, for instance:
2908 $HOME/.modest/outboxes/<account-id-1>/outbox
2909 $HOME/.modest/outboxes/<account-id-2>/outbox
2911 $HOME/.modest/local-folders/outbox
2912 so we can have a separate outbox for each account.
2913 But they are shown as one outbox in the GtkTreeView, by using a
2914 TnyMergeFolder in a ModestTnySimpleFolderStore.
2917 * src/modest-tny-simple-folder-store.c:
2918 * src/modest-tny-simple-folder-store.h:
2919 Added ModestTnySimpleFolderStore, used to contain folders from
2920 other folder stores, such as other accounts.
2922 * src/modest-tny-outbox-account.h:
2923 * src/modest-tny-outbox-account.c:
2924 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2925 used for the per-account local outbox folders.
2927 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2928 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2929 only use this (internally) now for the non-outbox local folders.
2931 * src/modest-init.h:
2932 * src/modest-init.c: Added modest_init_one_local_folder(), for
2933 setting up the directory structure for each local folder.
2935 * src/modest-local-folder-info.c:
2936 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2937 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2939 * src/modest-local-folder-info.h:
2940 * src/modest-tny-account-store.c: (on_account_removed),
2941 (on_account_changed), (create_per_account_local_outbox_folders),
2942 (get_server_accounts), (modest_tny_account_store_get_accounts),
2943 (modest_tny_account_store_get_tny_account_by_account),
2944 (modest_tny_folder_store_is_virtual_local_folders):
2946 * src/modest-tny-account.h:
2947 * src/modest-tny-account.c:
2948 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2949 to create an on-disk per-account local outbox folder for each
2951 (create_per_account_local_outbox_folders): Create a local outbox folder
2952 for each transport account.
2953 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2954 for all local folders.
2956 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2957 instead of using g_object_get/set() directly. It is clearer.
2959 (modest_tny_folder_store_get_message_count),
2960 (modest_tny_folder_store_get_local_size
2961 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2962 because we now use these with non-acount folder stores.
2964 (modest_tny_account_get_special_folder),
2965 (modest_tny_account_new_from_server_account),
2966 (modest_tny_account_new_from_account):
2967 (recurse_folders): Adjust to the new outbox system.
2969 * src/modest-tny-folder.h:
2970 * src/modest-tny-folder.c:
2971 (modest_tny_folder_is_local_folder),
2972 (modest_tny_folder_get_local_folder_type),
2973 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2975 * src/widgets/modest-main-window.h:
2976 * src/maemo/modest-main-window.c: (create_details_widget),
2977 (modest_main_window_set_contents_style): Show details for any folder store,
2980 (modest_tny_folder_get_rules):
2981 Remove the const. C does not support constness enough for this.
2983 * src/modest-ui-actions.c:
2984 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2985 make all outboxes appear as one, in the usual local-folders tree node.
2987 (set_active_account_from_tny_account),
2988 (modest_ui_actions_on_folder_selection_changed):
2989 * src/widgets/modest-folder-view.c: (text_cell_data),
2990 (icon_cell_data), (filter_row),
2991 (add_account_folders_to_merged_folder),
2992 (add_account_folders_to_simple_folder_store), (),
2993 (get_cmp_rows_type_pos), (cmp_rows),
2994 (modest_folder_view_set_account_id_of_visible_server_account):
2995 Adjust to the new outbox system, using generic folder stores and folders
2996 in the GtkTreeModel.
2998 2007-05-23 Christian Kellner <ckellner@openismus.com>
3000 * src/modest-mail-operation.c:
3001 (modest_mail_operation_update_account):
3002 Use info->max_size instead of unintialized local var [small
3003 build fix]. (Added TODO to review that change since I don't
3006 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3008 * libmodest-dbus-client/libmodest-dbus-client.c:
3009 (libmodest_dbus_client_compose_mail): function added
3010 * src/dbus_api/modest-dbus-api.h:
3011 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3012 (on_compose_mail): Implementation of the SendAsMail functionality
3014 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3016 * src/modest-account-mgr.c:
3017 (modest_account_mgr_add_server_account): Set the secure-connection
3018 conf key for transport accounts as well as store accounts. I don't know
3019 why the if was there. For instance, this makes sure that we use SSL
3020 for the gmail preset from the easysetup wizard.
3022 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3024 * src/gnome/modest-main-window.c:
3025 (on_account_store_connecting_finished), (connect_signals):
3026 * src/maemo/modest-main-window.c:
3027 (on_account_store_connecting_finished), (connect_signals),
3028 (modest_main_window_new):
3029 Handle TnyAccountStore::connecting-finished instead of
3030 TnyDevice::connection-changed, because we cannot actually perform
3031 operations on accounts until TnyAccountStore has itself responded to
3032 the TnyDevice::connection-changed signal. This prevents a GError from
3034 Do not try to update at startup, because we (at least on scratchbox)
3035 already do an update at startup when the device goes online.
3036 This prevents a GError from tinymail.
3037 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3038 Added TODO about stopping simultaneous operations.
3040 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3042 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3043 * src/modest-mail-operation-queue.c:
3044 (modest_mail_operation_queue_remove):
3045 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3046 about where they happened.
3048 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3050 * src/modest-ui-actions.c:
3051 (modest_ui_actions_on_password_requested): Make sure that the remember
3052 output parameter is always TRUE.
3054 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3056 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3057 Show a OK/Cancel dialog if the error is a question, though we still do not
3058 know anything more about what we are asking the user.
3059 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3060 Fix an uninitialized variable (helper). This is a logic error, however.
3062 2007-05-21 Christian Kellner <ckellner@openismus.com>
3064 * src/modest-search.h:
3065 Correct bit shifting in the ModestSearchFlags enum.
3067 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3069 * src/modest-tny-account.c:
3070 (modest_tny_account_new_from_server_account): Do not use the lsub and
3071 check-all hard-coded IMAP options when using POP.
3073 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3075 * src/modest-tny-account.c:
3076 (modest_tny_account_new_from_server_account):
3077 Use NULL for the secure-auth method for POP when Password auth has been
3078 specified by the user, as we already do for IMAP. "auth=Login" causes
3079 an error from camel or the server.
3081 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3083 * src/maemo/modest-account-settings-dialog.c:
3084 (create_page_account_details),
3085 (modest_account_settings_dialog_set_account_name):
3086 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3087 for the leave-on-server checkbox, rathr than just the checkbox, when
3088 the protocol is not POP.
3090 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3092 * src/widgets/modest-account-view.c:
3093 * src/widgets/modest-account-view.h:
3094 Added modest_account_view_select_account() which will be useful later
3095 to asynchronously re-select the edited account.
3097 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3099 * src/maemo/modest-account-settings-dialog.c:
3100 (modest_account_settings_dialog_set_account_name):
3101 Automatically choose the port numbers based on the secure authentication
3102 methods, if they have not been chosen before.
3103 This fixes projects.maemo.org bug NB#56273 .
3105 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3107 * src/maemo/modest-main-window-ui.h:
3108 * src/modest-ui-actions.c:
3109 * src/modest-ui-actions.h:
3110 Connect the Tools/SMTP Servers menu item to
3111 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3112 SMTP servers dialog, as in the UI specification and saves changes when it
3113 is closed. This fixed projects.maemo.org bug NB#56305 .
3115 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3117 * src/maemo/modest-connection-specific-smtp-window.c:
3118 (modest_connection_specific_smtp_window_init):
3119 Use gtk_window_set_default_size() to make this window big enough, so
3120 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3122 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3124 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3125 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3126 (modest_connection_specific_smtp_edit_window_init),
3127 Do not try to connect to a combobox signal before the combobox exists.
3128 This fixes the cras in projects.maemo.org bug NB#56288 .
3129 (modest_connection_specific_smtp_edit_window_get_settings):
3130 Remove the server_account_name parameter which was being checked for NULL
3131 though it was not used.
3133 * src/maemo/modest-connection-specific-smtp-window.c:
3134 (modest_connection_specific_smtp_window_fill_with_connections),
3135 (on_button_edit), (modest_connection_specific_smtp_window_init):
3136 Correct the number of treemodel columns to prevent a warning.
3137 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3138 libconic does not work.
3140 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3142 * src/modest-tny-account.c:
3143 (modest_tny_account_new_from_server_account):
3144 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3145 SMTP when "None" was chosen by the user. However, with my SMTP server that
3146 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3149 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3151 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3152 to explain the memory management issue with the ID in the ModestPair.
3154 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3155 (add_sending_page), (modest_account_assistant_finalize):
3156 * src/gnome/modest-gnome-global-settings-dialog.c:
3157 (create_updating_page), (create_composing_page):
3158 * src/gnome/modest-msg-edit-window.c: (get_transports),
3159 (init_window), (modest_msg_edit_window_finalize),
3160 (modest_msg_edit_window_get_msg_data):
3161 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3162 * src/gnome/modest-transport-widget.c:
3163 (modest_transport_widget_finalize), (smtp_configuration):
3164 * src/maemo/modest-maemo-global-settings-dialog.c:
3165 (create_updating_page), (create_composing_page):
3166 * src/maemo/modest-msg-edit-window.c: (get_transports),
3167 (init_window), (modest_msg_edit_window_finalize),
3168 (modest_msg_edit_window_get_msg_data),
3169 (modest_msg_edit_window_free_msg_data):
3170 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3171 (modest_store_widget_finalize):
3172 * src/maemo/modest-transport-widget.c:
3173 (modest_transport_widget_finalize), (smtp_configuration):
3174 * src/modest-main.c: (send_mail):
3175 * src/widgets/modest-combo-box.h:
3176 * src/widgets/modest-global-settings-dialog-priv.h:
3177 * src/widgets/modest-global-settings-dialog.c:
3178 (modest_global_settings_dialog_finalize):
3179 * src/widgets/modest-msg-edit-window.h:
3180 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3181 as long as the combo box, to prevent use of freed memory for the ID.
3183 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3185 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3186 get_accounts(), to make this clearer. Do not check for the enabled gconf
3187 key, because we do not use this for server accounts (at least, not yet).
3188 This allows us to send email again.
3190 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3192 * src/maemo/modest-platform.c:
3193 (on_modest_conf_update_interval_changed), (modest_platform_init):
3194 Only respond to this particular key change. All these strcmp()s cannot be
3197 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3199 * src/maemo/modest-maemo-global-settings-dialog.c:
3200 (current_connection): Prevent a crash in scratchbox when
3201 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3202 * src/maemo/modest-platform.c:
3203 (on_modest_conf_update_interval_changed), (modest_platform_init):
3204 Get the update interval from gconf and reset it when the gconf key changes.
3206 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3208 * src/modest-protocol-info.c:
3209 * src/modest-protocol-info.h: Adde enum-specific get functions,
3210 instead of using a ModestProtocolType enum parameter.
3212 * src/gnome/modest-account-assistant.c:
3213 * src/gnome/modest-store-widget.c:
3214 * src/gnome/modest-store-widget.h:
3215 * src/gnome/modest-transport-widget.c:
3216 * src/gnome/modest-transport-widget.h:
3217 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3218 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3219 * src/maemo/easysetup/modest-easysetup-wizard.c:
3220 * src/maemo/modest-account-settings-dialog.c:
3221 * src/maemo/modest-account-settings-dialog.h:
3222 * src/maemo/modest-store-widget.c:
3223 * src/maemo/modest-store-widget.h:
3224 * src/maemo/modest-transport-widget.c:
3225 * src/maemo/modest-transport-widget.h:
3226 * src/modest-account-mgr-helpers.c:
3227 * src/modest-account-mgr-helpers.h:
3228 * src/modest-account-mgr.c:
3229 * src/modest-account-mgr.h:
3230 * src/modest-tny-account.c:
3231 * src/modest-tny-folder.c:
3232 * src/widgets/modest-account-view.c:
3233 * src/widgets/modest-retrieve-combo-box.c:
3234 * src/widgets/modest-retrieve-combo-box.h:
3235 * src/widgets/modest-secureauth-combo-box.c:
3236 * src/widgets/modest-serversecurity-combo-box.c:
3237 * src/widgets/modest-serversecurity-combo-box.h:
3238 * tests/check_account-mgr.c:
3239 Use the specific functions, and use the re-renamed enum values for GNOME too.
3241 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3243 * src/modest-pair.h:
3244 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3245 so we can get the second based on the first.
3247 * src/maemo/modest-account-settings-dialog.h:
3248 * src/maemo/modest-account-settings-dialog.c:
3249 Added get_supported_secure_authentication_methods(), though it is mostly
3250 commented-out for now until the necessary API is committed to tinymail.
3251 (modest_account_settings_dialog_set_account_name),
3252 (save_configuration): Request the supported authentication methods from the
3253 server, so we can choose a working method.
3255 * src/modest-tny-account-store.h:
3256 * src/modest-tny-account-store.c:
3257 (modest_tny_account_store_get_session): Rename from
3258 tny_account_store_get_session().
3260 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3262 * src/modest-protocol-info.h: Split the ModestProtocol enum
3263 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3264 There was no need to have these unrelated values in one enum.
3266 * src/: many files: Adapted to changed enum. This makes the code a bit
3267 clearer, and the compiler could catch some errors.
3269 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3271 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3272 Show the detailed internal camel error message when an error happens
3273 during the configuration, so that our testers can give us more clues.
3274 For instance, in projects.maemo.org bug NB#56910 .
3276 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3278 * src/modest-tny-account.c:
3279 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3280 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3282 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3284 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3285 * src/maemo/modest-account-settings-dialog.c:
3286 (modest_account_settings_dialog_set_account_name),
3287 (save_configuration): For the incoming secure authentication checkbox,
3288 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3289 the UI specification. PLAIN does not seem to be supported for most IMAP
3290 servers anyway, and I am not sure what it would mean.
3291 However, we probably need to discover which of the secure-authentication
3292 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3293 * src/modest-account-mgr-helpers.c:
3294 (modest_account_mgr_get_server_account_data):
3296 * src/modest-tny-account.c:
3297 (modest_tny_account_new_from_server_account):
3298 Use tny_account_set_mech() to set secure-authentication methods,
3299 with some special-casing for IMAP, based on my observations of how
3302 * src/modest-account-mgr-helpers.h:
3303 * src/modest-account-mgr.c:
3304 * src/modest-defs.h: Comment that the URI is only used for local folders.
3306 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3308 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3309 parameter const, just to be neat.
3310 * src/modest-text-utils.c: (modest_text_utils_inline):
3311 End g_strconcat() with NULL, as its documentation says. This is almost
3312 certainly the cause of my crash at startup on the device. Interestingly,
3313 valgrind doesn't tell us about these errors.
3315 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3317 * scripts/build-packages: Added more precise comments about how to use
3318 this script, though I still get this error:
3319 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3320 error building tinymail
3322 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3324 * src/maemo/modest-main-window.c: (on_account_update):
3325 Very slight cleanup, hoping to make it simpler to discover what causes
3326 a crash here sometimes.
3328 * src/modest-tny-account.c:
3329 (modest_tny_account_new_from_server_account): Set the port. Added
3330 comments about the options and a TODO comment because I need to find out
3331 how to specify the secure authentication method.
3333 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3335 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3336 changed CFlags paths form modest to libmodest
3338 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3340 * src/modest-account-mgr-helpers.c:
3341 (modest_account_mgr_get_server_account_data),
3342 (modest_account_mgr_free_server_account_data):
3343 * src/modest-account-mgr-helpers.h:
3344 * src/modest-account-mgr.c:
3345 (modest_account_mgr_add_server_account):
3346 * src/modest-defs.h:
3347 * src/modest-tny-account.c:
3348 (modest_tny_account_new_from_server_account):
3349 Determine the options for tny_camel_account_add_option() here,
3350 based on the settings, rather than storing them directly in gconf.
3352 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3354 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3355 Show a more friendly error dialog now that we expect (from the tinymail
3356 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3358 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3360 * src/maemo/modest-main-window.c: (on_account_update): Check that
3361 account_name is not NULL, to prevent a crash at startup that I am
3362 seeing on the N800. I do wonder why it is NULL.
3364 * src/maemo/easysetup/modest-easysetup-wizard.c:
3365 (create_page_user_details):
3366 * src/maemo/modest-account-settings-dialog.c:
3367 (create_page_user_details), (create_page_outgoing):
3368 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3369 (modest_connection_specific_smtp_edit_window_init):
3370 * src/modest-ui-actions.c:
3371 (modest_ui_actions_on_password_requested):
3372 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3373 might do something useful with the on-screen keyboard.
3375 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3377 * src/maemo/modest-main-window.c: (on_account_update):
3378 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3379 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3381 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3383 * src/modest-tny-account-store.c: (on_account_changed):
3384 Correct the signature of this signal handler.
3386 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3388 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3389 Show a HildonNote instead of a GtkDialog for Maemo.
3391 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3393 * src/widgets/modest-account-view.h:
3394 * src/widgets/modest-account-view.c: (on_account_changed),
3395 (on_account_removed). Added a boolean flag, set/unset by
3396 modest_account_view_block_conf_updates(),
3397 modest_account_view_unblock_conf_updates() to prevent unnecessary
3398 updates, but this is not very useful because the gconf notifications are
3399 so delays (maybe only on Maemo Bora).
3400 So auto-updating is turned off, and these functions do an explicit
3401 update when necessary.
3402 However, something else is still doing too much work when adding/removing
3403 accounts, probably in another part of the application.
3405 * src/maemo/modest-account-view-window.c:
3406 (on_delete_button_clicked), (on_edit_button_clicked),
3407 (on_new_button_clicked): Use the new functions.
3409 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3411 * src/modest-account-mgr-helpers.c:
3412 (modest_account_mgr_set_first_account_as_default):
3413 Sort the list of names alphabetically-by-title, so we choose the first one
3415 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3416 alphabetically by the title.
3418 This fixes projects.maemo.org bug NB#56418 .
3420 * src/modest-account-mgr-priv.c:
3421 (_modest_account_mgr_account_from_key):
3422 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3423 avoid a valgrind error, and possible random behaviour.
3425 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3427 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3428 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3429 tinymail documentation to say that this can be expected.
3430 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3431 pretty, and should not happen, but I would prefer to know when it does.
3433 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3435 * configure.ac: When using the older hildon version, probably on Bora,
3436 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3438 * src/widgets/modest-attachment-view.c:
3439 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3442 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3444 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3445 Implemented the prototype. Can be tested with
3446 tests/dbus_api/test_open_message:
3448 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3450 * src/modest-tny-account-store.c:
3451 (modest_tny_account_store_instance_init), (get_password):
3452 * src/modest-ui-actions.c:
3453 (modest_ui_actions_on_password_requested):
3454 Do not store the password in gconf, because this function is called
3455 for non-remembered passwords. Actually use the cached (in the hash map)
3456 password instead of releasing it.
3457 The password will now not be remembered if it is asked via the protected
3458 password dialog, as per the UI spec.
3460 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3462 * src/modest-defs.h:
3463 * src/modest-account-mgr-helpers.h:
3464 * src/modest-account-mgr-helpers.c:
3465 Added modest_server_account_get_username_has_succeeded(),
3466 modest_server_account_set_username_has_succeeded().
3467 (modest_server_account_set_username),
3468 Reset the has-succeeded flag if the username changes.
3470 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3471 * src/maemo/modest-connection-specific-smtp-window.c:
3472 (modest_connection_specific_smtp_window_save_server_accounts):
3473 Use modest_server_account_set_username() instead of using
3474 modest_conf_set_string() directly, so that the has-succeeded flag is always
3477 * src/modest-ui-actions.c:
3478 (modest_ui_actions_on_password_requested): Dim the username entry if
3479 the username has ever worked, as per the UI spec.
3481 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3483 * src/modest-tny-account-store.c: (get_password):
3484 * src/modest-ui-actions.c:
3485 (modest_ui_actions_on_password_requested):
3486 Allow the username to be changed too, though there is more work to
3487 be done on exactly how this behaves.
3489 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3491 * src/modest-account-mgr-helpers.h:
3492 * src/modest-account-mgr-helpers.c:
3493 Added modest_account_mgr_get_display_name(),
3494 modest_server_account_get_username(),
3495 modest_server_account_set_username(),
3496 modest_server_account_set_password(),
3497 modest_server_account_get_hostname() functions so we do not need to
3498 use the conf API directly.
3500 * src/maemo/modest-main-window.c: (connect_signals):
3501 Actually connect ot the ModestAccountStore::request-password signal,
3502 so that we show the dialog when the password is requested by Tinymail,
3503 for isntance if it is empty.
3505 * src/modest-marshal.list:
3506 * src/modest-tny-account-store.c:
3507 (modest_tny_account_store_class_init), (get_password),
3508 (modest_tny_account_store_alert):
3509 * src/modest-tny-account-store.h:
3510 * src/modest-ui-actions.h:
3511 * src/modest-ui-actions.c:
3512 (modest_ui_actions_on_password_requested):
3513 Change the signal parameters, so it is obvious that we are providing
3514 the non human-readable server name, and receiving both the username
3515 and password, though changing of the username is not yet implemented.
3516 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3517 for the GNOME version.
3519 This should fix the projects.maemo.org bug NB#56209, though it does not
3520 work on Bora, because the gconf_client_get() for the password fails
3521 immediately after we save it with gconf_client_set().
3523 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3526 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3527 caused an undefined symbol error:
3528 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3530 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3532 * src/modest-tny-account-store.c:
3533 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3534 using a GError instead of a string message, so we can translate it in
3537 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3539 * src/maemo/modest-address-book.c:
3540 (modest_address_book_check_names):
3541 * src/maemo/modest-msg-view-window.c:
3542 (modest_msg_view_window_clipboard_owner_change):
3543 * src/modest-init.c: (modest_init_init_ui):
3544 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3545 (update_folders_cb), (modest_mail_operation_update_account):
3546 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3547 (modest_ui_actions_on_msg_attachment_clicked),
3548 (modest_ui_actions_on_msg_recpt_activated):
3549 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3550 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3551 (modest_msg_view_search_next):
3552 * src/widgets/modest-recpt-editor.c:
3553 (modest_recpt_editor_on_button_release_event),
3554 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3555 g_message(). At this point we should only be seeing interesting errors on
3556 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3558 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3560 (modest_wizard_dialog_force_title_update):
3561 * src/maemo/easysetup/modest-wizard-dialog.h:
3562 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3563 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3564 can update the title when appropriate. Otherwise the title is wrong if the
3565 pages are added after adding the notebook to the dialog.
3566 This must be a problem in HildonWizardDialog too.
3567 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3569 * src/maemo/easysetup/modest-easysetup-wizard.c:
3570 (create_subsequent_customsetup_pages),
3571 (create_subsequent_easysetup_pages):
3572 Call modest_wizard_dialog_force_title_update() so that the title is
3573 correct even with GTK+ < 2.10.
3574 This fixes projects.maemo.org bug NB#56145 .
3576 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3578 * src/maemo/modest-platform.c:
3579 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3580 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3583 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3585 * src/widgets/modest-window.h:
3586 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3587 and modest_window_save_state(), which invokes it.
3589 * src/widgets/modest-window-mgr.h:
3590 * src/widgets/modest-window-mgr.c:
3591 Added modest_window_mgr_save_state_for_all_windows(), which calls
3592 the save_state vfunc on all registered windows, if implemented.
3594 * src/gnome/modest-msg-edit-window.c:
3595 * src/gnome/modest-msg-view-window.c:
3596 * src/maemo/modest-msg-edit-window.c:
3597 * src/maemo/modest-msg-view-window.c:
3598 * src/maemo/modest-main-window.c:
3599 Specify the existing save_settings functions as implementations of
3600 ModestWindow::save_state_func().
3602 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3603 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3604 enabling hibernation, for instance.
3606 We may need to do the same thing for restoring settings.
3609 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3611 * src/widgets/modest-window-mgr.c:
3612 * src/widgets/modest-window-mgr.h:
3613 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3614 modest_window_mgr_get_hibernation_is_prevented().
3616 * src/maemo/modest-main-window.c:
3617 (on_hildon_program_is_topmost_notify): Prevent hibernation
3618 (possible when the application goes to the background in the WM),
3619 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3621 * src/maemo/easysetup/modest-easysetup-wizard.c:
3622 (modest_easysetup_wizard_dialog_init):
3623 * src/maemo/modest-account-settings-dialog.c:
3624 (modest_account_settings_dialog_init):
3625 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3626 (modest_connection_specific_smtp_edit_window_init):
3627 * src/maemo/modest-connection-specific-smtp-window.c:
3628 (modest_connection_specific_smtp_window_init):
3629 * src/maemo/modest-signature-editor-dialog.c:
3630 (modest_signature_editor_dialog_init):
3631 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3632 prevent hibernation while any of these account settings dialogs are open.
3634 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3636 * src/maemo/Makefile.am:
3637 * src/maemo/modest-osso-state-saving.c:
3638 * src/maemo/modest-osso-state-saving.h: Added
3639 modest_osso_load_state() and modest_osso_save_state() though they do
3640 nothing now. They should iterate through all the open windows and load/save
3642 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3643 save state when closing.
3645 * src/maemo/modest-main-window.c:
3646 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3647 Add a notification handler for the HildonProgram::is-topmost property,
3648 so we can allow hibernation when the application goes into the background.
3649 But we still need to detect when the accounts setup windows are open so
3650 we can stop hibernation when they are open.
3651 To do this, I also added the main window the HildonProgram. This might have
3652 other side-effects/benefits, and should maybe be done for other windows.
3654 * src/maemo/modest-osso-autosave-callbacks.h:
3655 * src/maemo/modest-osso-autosave-callbacks.c:
3656 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3657 though it does not do anything yet, and we might never need this to do
3658 anything. For instance, we already save drafts.
3660 * src/maemo/modest-platform.c: (modest_platform_init):
3661 Specify the libosso auto-save callback.
3663 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3665 * src/maemo/modest-platform.c:
3666 (modest_platform_set_update_interval):
3667 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3668 aparently stays valid between application instances, so we can use this
3669 to remove and reset it later. According to a maemo-developers email from
3672 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3674 * configure.ac: Depend on libalarm for Maemo.
3676 * src/dbus_api/modest-dbus-api.h:
3677 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3678 (on_send_receive), (modest_dbus_req_handler):
3679 Handle a SEND_RECEIVE D-Bus method.
3681 * libmodest-dbus-client/libmodest-dbus-client.c:
3682 (libmodest_dbus_client_send_and_receive):
3683 * libmodest-dbus-client/libmodest-dbus-client.h:
3684 Add C convenience functions for calling the new D-Bus method.
3686 * src/modest-platform.h:
3687 * src/gnome/modest-platform.c:
3688 * src/maemo/modest-platform.c:
3689 Added modest_platform_set_update_interval(), which uses the
3690 alarmd API on Maemo.
3691 (modest_platform_init),
3692 Call modest_platform_set_update_interval(), using a hard-coded
3693 interval for now (until the global settings dialog is implemented),
3694 though I am not sure that this makes sense yet.
3696 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3698 * src/dbus_api/modest-dbus-callbacks.c:
3699 (modest_osso_cb_hw_state_handler):
3700 * src/dbus_api/modest-dbus-callbacks.h:
3701 * src/maemo/modest-platform.c: (modest_platform_init):
3702 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3703 in case this has some effect on the ability for Maemo to ping the
3706 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3708 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3709 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3710 warning. It is probably a logic error, but I need to fix the build.
3712 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3714 * src/modest-account-mgr.h:
3715 * src/modest-account-mgr.c:
3716 (modest_account_mgr_account_names): Add a gboolean enabled_only
3717 parameter, so we can get lists of onlt the enabled accounts.
3719 (modest_account_mgr_add_account),,
3720 (modest_account_mgr_account_with_display_name_exists):
3721 * src/maemo/modest-msg-edit-window.c: (get_transports):
3722 * src/modest-account-mgr-helpers.c:
3723 (modest_account_mgr_set_first_account_as_default):
3724 * src/modest-init.c: (init_default_account_maybe):
3725 * src/modest-tny-account-store.c: (get_accounts):
3726 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3727 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3728 * tests/check_account-mgr.c: (START_TEST):
3729 Provide the extra parameter, as appropriate.
3731 * src/widgets/modest-account-view.c: (update_account_view):
3732 Do not show disabled accounts (meaning that there is no way to
3733 enable/disable accounts in the UI (the feature is not in our UI
3734 specification), so we can use this internally only to mark unfinished
3735 or temporary account data.
3737 * src/maemo/easysetup/modest-easysetup-wizard.c:
3738 (create_account): Add boolean enable parameter, so we can specify FALSE
3739 to create the temporary account.
3740 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3741 (on_before_next): When finishing, when there is a temporary account, just
3743 Also, use a timeout to delay the showing of the dialog until gconf is likely
3744 to return correct information, due to a maemo gconf bug that is fixed in
3745 osso 1.1, but not yet in Bora.
3746 However, the dialog stays on screen after it is destroyed.
3748 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3749 for invalid data when cancelling. Use a hildon note instead of a dialog
3750 to complain about invalid data. Do not show the account-saved note if the
3751 account is disabled (a temporary account that will not really be saved for use
3754 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3756 * src/modest-account-mgr-helpers.h:
3757 * src/modest-account-mgr-helpers.c:
3758 Added modest_account_mgr_unset_default_account(),
3759 Added modest_account_mgr_set_first_account_as_default().
3761 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3762 If it was the default account, unset the default account name.
3764 * src/maemo/modest-account-view-window.c:
3765 (on_delete_button_clicked): If it was the default account,
3766 set the first remaining account as the default instead.
3768 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3769 a NULL account or a NULL default account, to prevent a crash. This should
3770 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3773 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3775 * src/widgets/modest-recpt-editor.c:
3776 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3777 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3778 TODO comment for this. This fixes the build.
3780 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3781 be the best place for it. This will in future update all auto-update accounts,
3782 rather than just the current/default account, when that gconf key exists.
3783 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3784 if there are no accounts, before calling do_send_receive().
3785 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3787 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3788 * src/maemo/modest-main-window-ui.h:
3789 * src/maemo/modest-main-window.c: (on_connection_changed),
3790 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3791 directly, becaue the signal handler does more.
3793 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3795 * src/modest-account-mgr-helpers.c:
3796 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3797 for the case that the account does not exist.
3799 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3800 (equivalent to the modest account name) rather than the tinymail account name
3801 (equivalent to the modest account title - human readable) to get the account data.
3802 Check for null account data to prevent the crash, and add a TODO comment saying that
3803 this needs fixing because it is using the server account name instead of the account name.
3805 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3807 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3808 * src/maemo/modest-account-settings-dialog.c: (show_error),
3810 Use hildon_note_new_information() for informative and error messages,
3811 which seems to be expected for Maemo applications (no documentation that I know of
3812 says this). I am surprised that there is no distinction between info and error
3815 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3817 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3818 it is easy to find where this is used.
3820 * src/maemo/easysetup/modest-easysetup-wizard.c:
3821 (create_page_welcome), (create_page_account_details),
3822 (create_page_user_details), (create_page_complete_easysetup),
3823 (create_page_custom_incoming), (create_page_custom_outgoing),
3824 (create_page_complete_custom):
3825 * src/maemo/modest-account-settings-dialog.c:
3826 (create_page_account_details), (create_page_user_details),
3827 (create_page_incoming), (create_page_outgoing):
3828 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3829 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3830 (modest_connection_specific_smtp_edit_window_init):
3831 * src/maemo/modest-connection-specific-smtp-window.c:
3832 (modest_connection_specific_smtp_window_init):
3833 * src/maemo/modest-signature-editor-dialog.c:
3834 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3835 and scrolling policy as per the Email Application Layout Guide, if I have
3838 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3840 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3841 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3842 which were empty, because these vfuncs have been removed from TnyAccountStore.
3843 This fixes the build.
3845 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3847 * src/maemo/modest-main-window.c:
3848 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3849 showing/hiding it. Added TODO because it probably should not be NULL.
3850 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3851 because unnecessary g_warnings() make degugging difficult.
3853 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3855 * src/maemo/modest-msg-edit-window.c:
3856 (modest_msg_edit_window_select_color),
3857 (modest_msg_edit_window_select_background_color): 2 const corrections and
3858 moving 2 #endifs before closing brackets, to fix the build.
3860 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3862 * src/maemo/easysetup/modest-easysetup-wizard.h:
3863 * src/maemo/easysetup/modest-easysetup-wizard.c:
3864 (modest_easysetup_wizard_dialog_finalize),
3865 (on_button_edit_advanced_settings), (create_page_complete_custom),
3866 (on_response), (create_account):
3867 Implement the Advanced Settings edit button, by saving the account information,
3868 for the Advanded Settings dialog to use directly from gconf, and removing it
3869 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3870 Bug #5533 in the projects.maemo.org bugzilla.
3872 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3874 * src/maemo/modest-msg-view-window.c:
3875 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3876 when opening a message window.
3878 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3880 * src/maemo/easysetup/modest-easysetup-wizard.c:
3881 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3884 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3885 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3886 gconf settings. I probably added more checks than necessary, but that is safer.
3888 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3889 variable to fix the build, but this seems to be used when it is still NULL.
3891 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3893 * src/modest-platform.h:
3894 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3895 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3896 * src/modest-main.c: Implement this function so we can avoid using
3897 maemo-specific API from cross-platform code.
3899 * src/modest-tny-account-store.c:
3900 (get_smtp_specific_transport_account_for_open_connection):
3901 * src/modest-ui-actions.c: (check_for_connection),
3902 (modest_ui_actions_on_item_not_found):
3903 Use modest_platform_connect_and_wait() and put #idefs around other
3904 maemo-specific code, because only maemo currently has a way to
3905 identify connection names.
3907 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3909 * src/modest-tny-account-store.h:
3910 * src/modest-tny-account-store.c:
3911 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3912 the connection-specific SMTP server settings in the configuration.
3914 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3916 * src/maemo/modest-main-window.c: (on_connection_changed),
3918 * src/modest-main.c: (main), (start_ui), (send_mail):
3919 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3920 that is what is intended.
3922 * src/modest-ui-actions.c: (action_send), (action_receive),
3923 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3924 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3925 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3926 SMTP server is used when it is specified.
3928 (modest_ui_actions_on_send_receive):
3929 Check that a connection is open before proceeding.
3930 Receive and then send, instead of vice-versa, as per the specification.
3932 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3934 * src/modest-mail-operation.c:
3935 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3936 though I guess it should be something other than NULL.
3938 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3940 * src/maemo/easysetup/modest-easysetup-wizard.c:
3941 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3942 combo twice, to avoid an g_warning and to make it visible again.
3943 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3944 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3945 (already intended) dereference when detaching, because we then recreate the menu.
3946 But I am not sure why the warning was happening, and it is possible that this is a memory
3949 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3951 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3952 and uri_parse_mailto() utility functions.
3953 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3955 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3957 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3959 * src/dbus_api/modest-dbus-api.h:
3960 * src/dbus_api/modest-dbus-callbacks.c:
3961 Use an idle callback to execute the modest code in the application's own thread.
3962 Remove the helloworld example method.
3963 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3964 parsed, and the open-message method is not implemented because this is not yet implemented in
3966 * libmodest-dbus-client/libmodest-dbus-client.c:
3967 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3968 (libmodest_dbus_client_open_message):
3969 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3971 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3972 body without crashing.
3974 * tests/dbus_api/Makefile.am:
3975 * tests/dbus_api/test_mail_to.c:
3976 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3978 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3980 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3981 Added file to fix the build. Sorry.
3983 * src/dbus_api/Makefile.am:
3984 * src/dbus_api/modest-dbus-api.h:
3985 * src/dbus_api/modest-dbus-callbacks.h:
3986 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3987 (modest_dbus_req_handler):
3988 Put constants in a separate header so it can be reused by the
3989 client library, without duplication
3991 * libmodest-dbus-client/Makefile.am:
3992 * libmodest-dbus-client/libmodest-dbus-client.c:
3993 (libmodest_dbus_client_call_helloworld),
3994 (libmodfest_dbus_client_send_mail),
3995 (libmodfest_dbus_client_mailto),
3996 (libmodfest_dbus_client_open_message):
3997 * libmodest-dbus-client/libmodest-dbus-client.h:
3998 (Partly) Implement a send_mail D-Bus method.
4000 * tests/dbus_api/Makefile.am:
4001 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4002 the send_email D-Bus method.
4004 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4008 * libmodest-dbus-client/Makefile.am:
4009 * libmodest-dbus-client/libmodest-dbus-client.c:
4010 * libmodest-dbus-client/libmodest-dbus-client.h:
4011 * tests/dbus_api/Makefile.am:
4012 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4013 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4015 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4017 * src/maemo/easysetup/modest-easysetup-wizard.c:
4018 (create_page_account_details):
4019 * src/maemo/modest-account-settings-dialog.c:
4020 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4021 widgets, because this might not be the default in future versions of the Maemo GTK+.
4022 However, I can not not get capitalization to work even in a simple test case.
4024 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4026 * src/maemo/easysetup/modest-easysetup-wizard.c:
4027 (create_page_custom_incoming), (create_page_custom_outgoing):
4028 * src/maemo/modest-account-settings-dialog.c:
4029 (create_page_account_details), (create_page_incoming),
4030 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4031 instead of using gtk_check_button_with_label(), so they are aligned like the other
4032 widgets, as per the UI spec.
4034 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4036 * src/maemo/easysetup/modest-easysetup-wizard.c:
4037 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4038 * src/widgets/modest-validating-entry.c:
4039 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4040 Modest prefix instead of an EasySetup prefix.
4042 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4044 * src/widgets/modest-validating-entry.h:
4045 * src/widgets/modest-validating-entry.c: (on_insert_text),
4046 Added easysetup_validating_entry_set_max_func(), used to set a callback
4047 to call when the max number of characters is reached. GtkEntry has a max-length
4048 already but is silent about it.
4050 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4051 (create_page_account_details), (create_page_user_details),
4053 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4054 (create_page_account_details), (create_page_user_details),
4055 (create_page_outgoing):
4056 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4057 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4058 the UI spec, when the user tries to enter more than the max number of characters.
4060 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4062 * src/maemo/easysetup/modest-easysetup-wizard.c:
4063 (create_page_user_details), (create_page_custom_incoming),
4064 (create_page_custom_outgoing):
4065 * src/maemo/modest-account-settings-dialog.c:
4066 (create_page_user_details), (create_page_incoming),
4067 (create_page_outgoing):
4068 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4069 (modest_connection_specific_smtp_edit_window_init):
4070 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4071 not appropriate. Bad Maemo-specific defaults!.
4073 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4075 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4076 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4077 (modest_signature_editor_dialog_set_settings):
4078 Disable the label and textview when the checkbox is disabled, and use the
4079 specified (UI spec) default signature text.
4081 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4083 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4084 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4086 * src/modest-defs.h:
4087 * src/modest-account-mgr-helpers.h:
4088 * src/modest-account-mgr-helpers.c:
4089 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4091 * src/maemo/Makefile.am:
4092 * src/maemo/modest-signature-editor-dialog.c:
4093 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4096 * src/maemo/modest-account-settings-dialog.h:
4097 * src/maemo/modest-account-settings-dialog.c:
4098 (modest_account_settings_dialog_finalize), (on_button_signature),
4099 (save_configuration): Use the new dialog when the Edit button is pressed, and
4100 save the changes if necessary, as per the UI spec.
4102 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4104 * src/maemo/Makefile.am:
4105 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4106 based on maemo-develoers email from Dirk.
4108 * src/maemo/easysetup/modest-easysetup-wizard.c:
4109 (create_page_welcome), (create_page_account_details),
4110 (create_page_user_details), (create_page_complete_easysetup),
4111 (create_page_custom_incoming), (create_page_custom_outgoing),
4112 (create_page_complete_custom),
4113 (modest_easysetup_wizard_dialog_init):
4114 * src/maemo/modest-account-settings-dialog.c:
4115 (create_page_account_details), (create_page_user_details),
4116 (create_page_incoming), (create_page_outgoing),
4117 (modest_account_settings_dialog_init):
4118 * src/maemo/modest-connection-specific-smtp-window.c:
4119 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4121 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4123 * src/maemo/easysetup/modest-easysetup-wizard.c:
4124 (create_page_account_details), (create_page_custom_outgoing),
4125 (create_page_complete_custom):
4126 * src/maemo/modest-account-settings-dialog.c:
4127 (create_page_user_details), (create_page_incoming),
4128 (create_page_outgoing):
4129 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4130 (modest_connection_specific_smtp_edit_window_init):
4131 Use the correct (UI spec) port min/max, and use horizontal separators,
4134 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4136 * src/maemo/easysetup/modest-easysetup-wizard.c:
4137 (set_default_custom_servernames):
4138 * src/maemo/modest-account-settings-dialog.c:
4139 (create_page_incoming), (on_combo_outgoing_security_changed),
4140 (on_combo_incoming_security_changed), (create_page_outgoing),
4141 (modest_account_settings_dialog_set_account_name),
4142 (save_configuration):
4143 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4144 (on_combo_security_changed),
4145 (modest_connection_specific_smtp_edit_window_init),
4146 (modest_connection_specific_smtp_edit_window_set_connection),
4147 (modest_connection_specific_smtp_edit_window_get_settings):
4148 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4151 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4154 * src/maemo/easysetup/modest-easysetup-wizard.c:
4155 (create_page_custom_outgoing), (create_page_complete_custom):
4156 * src/maemo/modest-account-settings-dialog.c:
4157 (create_page_user_details), (create_page_outgoing):
4158 * src/maemo/modest-account-view-window.c: (button_box_new):
4159 Use changed logical IDs as per the most recent UI spec:
4160 mcen_bd_emailsetup_edit -> mcen_bd_edit
4161 mcen_bd_emailsetup_delete -> mcen_bd_delete
4162 mcen_bd_emailsetup_close -> mcen_bd_close
4164 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4168 * src/dbus_api/Makefile.am:
4169 * src/dbus_api/modest-dbus-callbacks.c:
4170 * src/dbus_api/modest-dbus-callbacks.h:
4171 * src/maemo/modest-platform.c: (modest_platform_init):
4172 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4174 * tests/Makefile.am:
4175 * tests/dbus_api/Makefile.am:
4176 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4178 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4180 * src/maemo/modest-account-settings-dialog.c:
4181 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4182 Removed unnecessary includes.
4184 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4186 * src/maemo/easysetup/modest-easysetup-wizard.c:
4187 * src/maemo/modest-account-settings-dialog.c:
4188 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4189 * src/widgets/Makefile.am:
4190 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4191 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4192 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4193 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4194 * src/widgets/modest-secureauth-combo-box.c:
4195 * src/widgets/modest-secureauth-combo-box.h:
4196 * src/widgets/modest-serversecurity-combo-box.c:
4197 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4198 made the GObject names more consistent with the rest of the Modest code.
4200 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4202 * src/maemo/easysetup/Makefile.am:
4203 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4204 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4205 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4206 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4207 * src/maemo/easysetup/modest-easysetup-wizard.c:
4208 * src/maemo/easysetup/modest-validating-entry.c:
4209 * src/maemo/easysetup/modest-validating-entry.h:
4210 * src/maemo/modest-account-settings-dialog.c:
4211 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4212 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4213 widgets/ because they are used outside of easysetup too. After checking in,
4214 svn will allow me to rename them too.
4216 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4218 * src/gnome/modest-msg-edit-window.c:
4219 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4220 linker error, to fix the build on the GNOME platform.
4221 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4222 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4223 ifdefed out to avoid a warning.
4225 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4227 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4228 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4229 some alternative for GTK+ 2.6.
4231 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4233 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4235 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4236 specified for EmailAccountsDialog in UI spec.
4238 * src/maemo/easysetup/modest-easysetup-wizard.c:
4239 * src/maemo/easysetup/modest-easysetup-wizard.h:
4240 * src/maemo/modest-account-settings-dialog.c:
4241 * src/maemo/modest-account-settings-dialog.h:
4242 Reuse a member window widget for the connection-specific SMTP server accounts,
4243 so we can tell it to create/save the accounts only if we actually save changes.
4245 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4246 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4247 (modest_connection_specific_smtp_edit_window_get_settings):
4248 Return a struct instance for temporarily remembering the entered data.
4250 * src/maemo/modest-connection-specific-smtp-window.h:
4251 * src/maemo/modest-connection-specific-smtp-window.c:
4252 (modest_connection_specific_smtp_window_finalize),
4253 (modest_connection_specific_smtp_window_fill_with_connections),
4255 (modest_connection_specific_smtp_window_save_server_accounts),
4256 (update_model_server_names): Do not actually save data until asked,
4257 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4259 (on_selection_changed),
4260 (modest_connection_specific_smtp_window_init): Disable the edit
4261 button when nothing is selected.
4263 * src/modest-account-mgr-helpers.c:
4264 * src/modest-account-mgr-helpers.h:
4265 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4268 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4270 * src/modest-account-mgr-helpers.h:
4271 * src/modest-account-mgr-helpers.c:
4272 (modest_account_mgr_get_unused_account_name),
4273 (modest_account_mgr_get_unused_account_display_name): Added these
4274 utility functions, to avoid code duplication.
4276 * src/maemo/easysetup/modest-easysetup-wizard.c:
4277 (create_page_account_details), (create_account):
4278 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4279 (on_combo_security_changed),
4280 (modest_connection_specific_smtp_edit_window_init),
4281 (modest_connection_specific_smtp_edit_window_save_settings):
4282 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4283 * src/maemo/modest-connection-specific-smtp-window.c:
4284 (modest_connection_specific_smtp_window_finalize),
4285 (modest_connection_specific_smtp_window_fill_with_connections),
4286 (on_button_edit), (modest_connection_specific_smtp_window_init):
4287 * src/maemo/modest-connection-specific-smtp-window.h:
4288 Implementing saving of connection-specific server accounts.
4290 But I need to refactor this so we can save the data for each
4291 possible connection-specific account and only actually create the server accounts
4292 when the easysetup finished, or the OK button is pressed on the account settings
4295 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4297 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4298 (on_combo_security_changed):
4299 (modest_connection_specific_smtp_edit_window_init):
4300 Auto-fill the port number as in the account settings.
4302 (modest_connection_specific_smtp_edit_window_set_connection):
4303 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4304 * src/maemo/modest-connection-specific-smtp-window.c:
4305 (fill_with_connections), (on_button_edit),
4306 (modest_connection_specific_smtp_window_init):
4307 Turn the edit window into a dialog to simplify the code, and
4308 set a WM hint as in a GtkDialog, because only a popup can be on top of
4309 another window in Maemo, and popups usually have no WM decoration.
4311 * src/modest-defs.h:
4312 * src/modest-account-mgr-helpers.c:
4313 (modest_account_mgr_set_connection_specific_smtp),
4314 (modest_account_mgr_remove_connection_specific_smtp),
4315 (modest_account_mgr_get_connection_specific_smtp):
4316 * src/modest-account-mgr-helpers.h: Some functions to write the
4317 connection-specific SMTP server information. Not yet used.
4320 * src/widgets/modest-folder-view.c: (text_cell_data):
4321 Fix a warning about an uninitialized variable.
4322 (on_configuration_key_changed): Put an #ifdef around the use
4323 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4325 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4327 * src/maemo/modest-account-settings-dialog.h:
4328 * src/maemo/modest-account-settings-dialog.c:
4329 Added connect_for_modified() utility function to mark the new modified boolean.
4331 (create_page_account_details), (create_page_user_details),
4332 (create_page_incoming), (create_page_outgoing), (on_response),
4333 (modest_account_settings_dialog_init),
4334 (modest_account_settings_dialog_set_account_name):
4335 Only warn about unsaved changes when there are actually unsaved changes.
4337 * src/modest-account-mgr-helpers.c:
4338 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4339 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4340 to get the data from there in future.
4342 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4344 * src/modest-defs.h:
4346 * src/modest-account-mgr-helpers.h:
4347 * src/modest-account-mgr-helpers.c:
4348 Store the security account setting in a single conf key instead of using
4349 the options list, so that the list is left for just the to-be-removed camel hack,
4350 and because gconf_client_set_list() is failing for some reason.
4352 * src/modest-account-mgr.c:
4353 (modest_account_mgr_add_server_account):
4354 * src/maemo/modest-account-settings-dialog.c:
4355 (modest_account_settings_dialog_set_account_name),
4356 (save_configuration): Use the renamed functions.
4359 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4361 * src/widgets/Makefile.am:
4362 * src/widgets/modest-limit-retrieve-combo-box.c:
4363 * src/widgets/modest-limit-retrieve-combo-box.h:
4364 * src/widgets/modest-retrieve-combo-box.c:
4365 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4366 the account settings dialog.
4368 * src/modest-defs.h:
4369 * src/modest-account-mgr-helpers.h:
4370 * src/modest-account-mgr-helpers.c:
4371 (modest_server_account_get_option_secure_auth),
4372 (modest_server_account_set_option_secure_auth):
4373 * src/modest-account-mgr.c:
4374 (modest_account_mgr_add_server_account):
4375 Use the existing AUTH_MECH conf key for the secure-auth setting,
4376 instead of putting it in the list options, because this was actually used already.
4378 * src/maemo/modest-account-settings-dialog.c:
4379 (create_page_account_details),
4380 (modest_account_settings_dialog_set_account_name),
4381 (save_configuration):
4382 * src/maemo/modest-account-settings-dialog.h:
4383 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4384 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4386 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4388 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4389 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4390 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4392 * src/modest-defs.h:
4393 * src/maemo/modest-account-settings-dialog.c:
4394 (create_page_incoming), (on_combo_outgoing_security_changed),
4395 (on_combo_incoming_security_changed), (create_page_outgoing),
4396 (modest_account_settings_dialog_set_account_name),
4397 (save_configuration): Load/Save the port number, and change it when the
4398 security combo changes, to suitable defaults.
4400 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4402 * src/modest-account-mgr.c:
4403 (modest_account_mgr_add_server_account): Set the security and secure-auth
4404 options, and add a comment saying that the other camel-specific options should be
4407 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4409 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4411 * src/modest-tny-account-store.c: (account_list_free),
4412 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4413 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4416 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4418 * src/modest-protocol-info.c:
4419 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4420 is required by our UI spec. Maybe something in our implementation will use this eventually.
4421 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4422 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4423 instead of the previous 0 placeholder.
4425 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4426 secure-auth settings.
4427 * src/modest-account-mgr-helpers.h:
4428 * src/modest-account-mgr-helpers.c:
4429 (modest_server_account_data_get_option_secure_auth),
4430 (modest_server_account_set_option_secure_auth),
4431 (modest_server_account_data_get_option_security),
4432 (modest_server_account_set_option_security): Added this API for getting and setting the security
4433 and secure-auth settings.
4435 * src/maemo/modest-account-settings-dialog.h:
4436 * src/maemo/modest-account-settings-dialog.c:
4437 (modest_account_settings_dialog_finalize), (check_data),
4438 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4439 about changing titles.
4440 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4441 (save_configuration): Save the security and secure-auth settings.
4443 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4444 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4446 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4448 * src/modest-defs.h:
4449 * src/modest-account-mgr.c:
4450 (modest_account_mgr_add_server_account):
4451 Added and used defines for the options key and value pair strings,
4452 that are used so far, though they do not seem to correspond to anything in our
4453 UI specs or ModestProtocol enum.
4455 * src/modest-account-mgr-helpers.h:
4456 * src/modest-account-mgr-helpers.c:
4457 (compare_option_strings_for_name),
4458 (modest_server_account_data_get_option_value),
4459 (modest_server_account_data_get_option_bool),
4460 (modest_account_mgr_get_server_account_option):
4461 Added helper functions for parsing the options GSList.
4463 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4465 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4466 display name is based on the supplied account name.
4467 * src/modest-account-mgr.c:
4468 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4469 with an inefficient, but good-enough, implementation.
4471 * src/maemo/easysetup/modest-easysetup-wizard.c:
4472 (create_page_account_details), (on_before_next), (create_account):
4473 Check for existing display names rather than (non-user-visible) account names, and just
4474 create and set a unique account name at the end.
4476 * src/maemo/modest-account-settings-dialog.c:
4477 (modest_account_settings_dialog_init),
4478 (modest_account_settings_dialog_set_account_name),
4479 (create_page_incoming): Show the display name, instead of the account name.
4480 (on_response): Do some (not all) extra checks, as in the UI spec.
4481 (save_configuration): Save the display name if it was changed.
4483 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4485 * po/en_GB.po: Added needed logical ID and translation.
4486 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4487 (init_view): Made the is-default column clicking work.
4489 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4492 * src/maemo/easysetup/Makefile.am:
4493 * src/maemo/easysetup/modest-easysetup-wizard.c:
4494 (modest_easysetup_wizard_dialog_init):
4495 * src/maemo/easysetup/provider-data-test.keyfile:
4496 * src/maemo/easysetup/provider-data.keyfile:
4497 Moved the provider data file to the new modest-providers-data package and used it from there.
4499 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4501 * src/modest-local-folder-info.c:
4502 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4503 N_() was already used on the static strings, but this just marks it for translation without
4504 using the translation.
4506 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4508 * src/maemo/modest-account-settings-dialog.c:
4509 (create_page_incoming),
4510 (modest_account_settings_dialog_set_account_name):
4511 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4512 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4513 I will do this if nobody else gets there first.
4515 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4517 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4518 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4519 save the security stuff.
4521 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4523 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4524 Set the email address and user fullname, which I now see must be
4527 * src/maemo/modest-account-settings-dialog.h:
4528 * src/maemo/modest-account-settings-dialog.c:
4530 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4531 leave-on-server and authentication.
4532 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4535 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4538 * src/maemo/modest-account-settings-dialog.c:
4539 * src/maemo/modest-account-settings-dialog.h:
4540 Most (but not all) of the widgets are now present as specified by the UI spec.
4541 No changes are yet saved, and some details are not properly shown yet.
4543 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4545 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4547 * src/maemo/Makefile.am:
4548 * src/maemo/modest-account-settings-dialog.c:
4549 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4550 an existing account. Doesn't do much yet.
4552 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4553 Open the accounts settings dialog when Edit is clicked.
4555 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4557 * src/maemo/easysetup/Makefile.am:
4558 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4560 * src/maemo/easysetup/modest-easysetup-wizard.c:
4561 (modest_easysetup_wizard_dialog_init):
4562 Try to get the source directory from the build system,
4563 instead of hard-coding "./" into the source code, when opening our local
4564 copies of the configuration files.
4565 But this still fails when opening the wizard from the Accounts window,
4566 maybe because the working directory seems to change at runtime.
4567 So the wizard will fail the second time unless you copy the files into their
4568 proper locations - see the stdout warnings for the paths.
4570 (create_page_account_details),(on_before_next):
4571 Check for existing non-server accounts instead of server accounts,
4572 so the default account name is useful again, and to prevent trying to
4575 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4576 Show the wizard when New is clicked.
4578 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4579 (init_view): Show the column headers, and show the columns that are
4580 specified in the UI specs. However, something in Maemo's GTK+ prevents
4581 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4582 change the default account. This is despite unsetting the special properties.
4584 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4586 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4587 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4588 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4589 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4590 to make that clearer.
4591 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4593 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4595 * src/maemo/modest-account-view-window.c:
4596 (modest_account_view_window_init),
4597 (modest_account_view_window_new):
4598 Use the same buttons as specified in the
4599 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4600 the existing widgets, which never had a chance of working.
4601 Put the ModestAccountView treeview in a scrolled window.
4602 Do not repeat the initialization in both _init() and _new().
4604 * src/widgets/modest-account-view.c: (update_account_view):
4605 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4606 this widget and window shows no accounts.
4608 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4610 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4612 * src/maemo/easysetup/modest-easysetup-wizard.c:
4613 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4614 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4615 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4618 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4619 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4620 accounts exist yet, as in the UI spec.
4622 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4624 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4626 * src/maemo/Makefile.am:
4627 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4628 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4629 New window for editing connection-specific smtp details.
4630 Not fully implemented.
4632 * src/maemo/modest-connection-specific-smtp-window.c:
4633 (modest_connection_specific_smtp_window_finalize) :
4634 unref the tree model.
4635 (on_button_edit): Show the edit window.
4637 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4639 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4642 * src/maemo/Makefile.am:
4643 * src/maemo/modest-connection-specific-smtp-window.c:
4644 * src/maemo/modest-connection-specific-smtp-window.h:
4645 New window for showing the list of connections, for connection-specific
4646 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4647 * src/maemo/easysetup/modest-easysetup-wizard.c:
4648 (create_page_custom_outgoing): Show the new window when the button is clicked.
4650 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4652 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4653 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4654 * src/maemo/modest-msg-edit-window.c:
4655 (modest_msg_edit_window_insert_image):
4656 * src/modest-conf.c: (modest_conf_key_escape):
4657 * src/modest-mail-operation.c:
4658 (modest_mail_operation_send_new_mail):
4659 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4660 (modest_ui_actions_on_new_account):
4661 * src/widgets/modest-attachment-view.c: (update_filename_request):
4662 * src/widgets/modest-mail-header-view.c:
4663 Corrected warnings that were breaking the build, by commenting out unused variables,
4664 and a function, and by including a header.
4666 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4668 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4669 so we can #ifdef around platform-specific code when necessary.
4670 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4671 to allow this to build for the GNOME platform too.
4673 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4675 * src/maemo/easysetup/modest-easysetup-wizard.c:
4676 Added util_increment_name() and used it in create_page_account_details()
4677 to make sure that the default account name is always a new name.
4679 (modest_easysetup_wizard_dialog_init),
4680 (set_default_custom_servernames): Some minor memory management fixes.
4682 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4686 * src/modest-runtime.c: (init_i18n): Restored the translation
4687 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4688 are defined in config.h, and the translations are installed.
4690 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4691 is defined for translation.
4693 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4695 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4697 * src/maemo/easysetup/modest-easysetup-wizard.c:
4698 (modest_easysetup_wizard_dialog_init):
4699 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4700 Use realistic paths (though they should use $prefix generically) to the
4701 mcc_mapping and provider-data.keyfile files which might work when they
4702 are installed by the future version of the operator-wizard package,
4703 and then fallback to paths in our source code, with an explanatory
4706 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4710 * src/maemo/Makefile.am:
4711 * src/maemo/easysetup/: Added files from the previously-exernal
4712 osso-modest-easysetup.
4713 * src/maemo/modest-main-window-ui.h:
4714 * src/modest-ui-actions.c:
4715 * src/modest-ui-actions.h:
4716 Added modest_ui_actions_on_new_account() as a signal handler for the
4717 New Account menu item. It shows the easysetup wizard.
4718 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob