1 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/Makefile.am:
4 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
5 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
6 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
7 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
8 * src/maemo/easysetup/modest-easysetup-wizard.c:
9 * src/maemo/easysetup/modest-validating-entry.c:
10 * src/maemo/easysetup/modest-validating-entry.h:
11 * src/maemo/modest-account-settings-dialog.c:
12 * src/maemo/modest-connection-specific-smtp-edit-window.c:
13 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
14 widgets/ because they are used outside of easysetup too. After checking in,
15 svn will allow me to rename them too.
17 2007-04-20 Murray Cumming <murrayc@murrayc.com>
19 * src/gnome/modest-msg-edit-window.c:
20 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
21 linker error, to fix the build on the GNOME platform.
22 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
23 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
24 ifdefed out to avoid a warning.
26 2007-04-20 Murray Cumming <murrayc@murrayc.com>
28 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
29 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
30 some alternative for GTK+ 2.6.
32 2007-04-19 Murray Cumming <murrayc@murrayc.com>
34 * src/maemo/modest-address-book.c: Added include to avoid a warning.
36 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
37 specified for EmailAccountsDialog in UI spec.
39 * src/maemo/easysetup/modest-easysetup-wizard.c:
40 * src/maemo/easysetup/modest-easysetup-wizard.h:
41 * src/maemo/modest-account-settings-dialog.c:
42 * src/maemo/modest-account-settings-dialog.h:
43 Reuse a member window widget for the connection-specific SMTP server accounts,
44 so we can tell it to create/save the accounts only if we actually save changes.
46 * src/maemo/modest-connection-specific-smtp-edit-window.h:
47 * src/maemo/modest-connection-specific-smtp-edit-window.c:
48 (modest_connection_specific_smtp_edit_window_get_settings):
49 Return a struct instance for temporarily remembering the entered data.
51 * src/maemo/modest-connection-specific-smtp-window.h:
52 * src/maemo/modest-connection-specific-smtp-window.c:
53 (modest_connection_specific_smtp_window_finalize),
54 (modest_connection_specific_smtp_window_fill_with_connections),
56 (modest_connection_specific_smtp_window_save_server_accounts),
57 (update_model_server_names): Do not actually save data until asked,
58 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
60 (on_selection_changed),
61 (modest_connection_specific_smtp_window_init): Disable the edit
62 button when nothing is selected.
64 * src/modest-account-mgr-helpers.c:
65 * src/modest-account-mgr-helpers.h:
66 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
69 2007-04-19 Murray Cumming <murrayc@murrayc.com>
71 * src/modest-account-mgr-helpers.h:
72 * src/modest-account-mgr-helpers.c:
73 (modest_account_mgr_get_unused_account_name),
74 (modest_account_mgr_get_unused_account_display_name): Added these
75 utility functions, to avoid code duplication.
77 * src/maemo/easysetup/modest-easysetup-wizard.c:
78 (create_page_account_details), (create_account):
79 * src/maemo/modest-connection-specific-smtp-edit-window.c:
80 (on_combo_security_changed),
81 (modest_connection_specific_smtp_edit_window_init),
82 (modest_connection_specific_smtp_edit_window_save_settings):
83 * src/maemo/modest-connection-specific-smtp-edit-window.h:
84 * src/maemo/modest-connection-specific-smtp-window.c:
85 (modest_connection_specific_smtp_window_finalize),
86 (modest_connection_specific_smtp_window_fill_with_connections),
87 (on_button_edit), (modest_connection_specific_smtp_window_init):
88 * src/maemo/modest-connection-specific-smtp-window.h:
89 Implementing saving of connection-specific server accounts.
91 But I need to refactor this so we can save the data for each
92 possible connection-specific account and only actually create the server accounts
93 when the easysetup finished, or the OK button is pressed on the account settings
96 2007-04-18 Murray Cumming <murrayc@murrayc.com>
98 * src/maemo/modest-connection-specific-smtp-edit-window.c:
99 (on_combo_security_changed):
100 (modest_connection_specific_smtp_edit_window_init):
101 Auto-fill the port number as in the account settings.
103 (modest_connection_specific_smtp_edit_window_set_connection):
104 * src/maemo/modest-connection-specific-smtp-edit-window.h:
105 * src/maemo/modest-connection-specific-smtp-window.c:
106 (fill_with_connections), (on_button_edit),
107 (modest_connection_specific_smtp_window_init):
108 Turn the edit window into a dialog to simplify the code, and
109 set a WM hint as in a GtkDialog, because only a popup can be on top of
110 another window in Maemo, and popups usually have no WM decoration.
113 * src/modest-account-mgr-helpers.c:
114 (modest_account_mgr_set_connection_specific_smtp),
115 (modest_account_mgr_remove_connection_specific_smtp),
116 (modest_account_mgr_get_connection_specific_smtp):
117 * src/modest-account-mgr-helpers.h: Some functions to write the
118 connection-specific SMTP server information. Not yet used.
121 * src/widgets/modest-folder-view.c: (text_cell_data):
122 Fix a warning about an uninitialized variable.
123 (on_configuration_key_changed): Put an #ifdef around the use
124 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
126 2007-04-18 Murray Cumming <murrayc@murrayc.com>
128 * src/maemo/modest-account-settings-dialog.h:
129 * src/maemo/modest-account-settings-dialog.c:
130 Added connect_for_modified() utility function to mark the new modified boolean.
132 (create_page_account_details), (create_page_user_details),
133 (create_page_incoming), (create_page_outgoing), (on_response),
134 (modest_account_settings_dialog_init),
135 (modest_account_settings_dialog_set_account_name):
136 Only warn about unsaved changes when there are actually unsaved changes.
138 * src/modest-account-mgr-helpers.c:
139 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
140 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
141 to get the data from there in future.
143 2007-04-18 Murray Cumming <murrayc@murrayc.com>
147 * src/modest-account-mgr-helpers.h:
148 * src/modest-account-mgr-helpers.c:
149 Store the security account setting in a single conf key instead of using
150 the options list, so that the list is left for just the to-be-removed camel hack,
151 and because gconf_client_set_list() is failing for some reason.
153 * src/modest-account-mgr.c:
154 (modest_account_mgr_add_server_account):
155 * src/maemo/modest-account-settings-dialog.c:
156 (modest_account_settings_dialog_set_account_name),
157 (save_configuration): Use the renamed functions.
160 2007-04-18 Murray Cumming <murrayc@murrayc.com>
162 * src/widgets/Makefile.am:
163 * src/widgets/modest-limit-retrieve-combo-box.c:
164 * src/widgets/modest-limit-retrieve-combo-box.h:
165 * src/widgets/modest-retrieve-combo-box.c:
166 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
167 the account settings dialog.
170 * src/modest-account-mgr-helpers.h:
171 * src/modest-account-mgr-helpers.c:
172 (modest_server_account_get_option_secure_auth),
173 (modest_server_account_set_option_secure_auth):
174 * src/modest-account-mgr.c:
175 (modest_account_mgr_add_server_account):
176 Use the existing AUTH_MECH conf key for the secure-auth setting,
177 instead of putting it in the list options, because this was actually used already.
179 * src/maemo/modest-account-settings-dialog.c:
180 (create_page_account_details),
181 (modest_account_settings_dialog_set_account_name),
182 (save_configuration):
183 * src/maemo/modest-account-settings-dialog.h:
184 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
185 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
187 2007-04-18 Murray Cumming <murrayc@murrayc.com>
189 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
190 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
191 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
194 * src/maemo/modest-account-settings-dialog.c:
195 (create_page_incoming), (on_combo_outgoing_security_changed),
196 (on_combo_incoming_security_changed), (create_page_outgoing),
197 (modest_account_settings_dialog_set_account_name),
198 (save_configuration): Load/Save the port number, and change it when the
199 security combo changes, to suitable defaults.
201 2007-04-17 Murray Cumming <murrayc@murrayc.com>
203 * src/modest-account-mgr.c:
204 (modest_account_mgr_add_server_account): Set the security and secure-auth
205 options, and add a comment saying that the other camel-specific options should be
208 2007-04-17 Murray Cumming <murrayc@murrayc.com>
210 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
212 * src/modest-tny-account-store.c: (account_list_free),
213 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
214 cursor->data after unreffing it. But there is some strange stuff there so it might not be
217 2007-04-17 Murray Cumming <murrayc@murrayc.com>
219 * src/modest-protocol-info.c:
220 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
221 is required by our UI spec. Maybe something in our implementation will use this eventually.
222 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
223 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
224 instead of the previous 0 placeholder.
226 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
227 secure-auth settings.
228 * src/modest-account-mgr-helpers.h:
229 * src/modest-account-mgr-helpers.c:
230 (modest_server_account_data_get_option_secure_auth),
231 (modest_server_account_set_option_secure_auth),
232 (modest_server_account_data_get_option_security),
233 (modest_server_account_set_option_security): Added this API for getting and setting the security
234 and secure-auth settings.
236 * src/maemo/modest-account-settings-dialog.h:
237 * src/maemo/modest-account-settings-dialog.c:
238 (modest_account_settings_dialog_finalize), (check_data),
239 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
240 about changing titles.
241 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
242 (save_configuration): Save the security and secure-auth settings.
244 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
245 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
247 2007-04-17 Murray Cumming <murrayc@murrayc.com>
250 * src/modest-account-mgr.c:
251 (modest_account_mgr_add_server_account):
252 Added and used defines for the options key and value pair strings,
253 that are used so far, though they do not seem to correspond to anything in our
254 UI specs or ModestProtocol enum.
256 * src/modest-account-mgr-helpers.h:
257 * src/modest-account-mgr-helpers.c:
258 (compare_option_strings_for_name),
259 (modest_server_account_data_get_option_value),
260 (modest_server_account_data_get_option_bool),
261 (modest_account_mgr_get_server_account_option):
262 Added helper functions for parsing the options GSList.
264 2007-04-16 Murray Cumming <murrayc@murrayc.com>
266 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
267 display name is based on the supplied account name.
268 * src/modest-account-mgr.c:
269 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
270 with an inefficient, but good-enough, implementation.
272 * src/maemo/easysetup/modest-easysetup-wizard.c:
273 (create_page_account_details), (on_before_next), (create_account):
274 Check for existing display names rather than (non-user-visible) account names, and just
275 create and set a unique account name at the end.
277 * src/maemo/modest-account-settings-dialog.c:
278 (modest_account_settings_dialog_init),
279 (modest_account_settings_dialog_set_account_name),
280 (create_page_incoming): Show the display name, instead of the account name.
281 (on_response): Do some (not all) extra checks, as in the UI spec.
282 (save_configuration): Save the display name if it was changed.
284 2007-04-16 Murray Cumming <murrayc@murrayc.com>
286 * po/en_GB.po: Added needed logical ID and translation.
287 * src/widgets/modest-account-view.c: (on_account_default_toggled),
288 (init_view): Made the is-default column clicking work.
290 2007-04-16 Murray Cumming <murrayc@murrayc.com>
293 * src/maemo/easysetup/Makefile.am:
294 * src/maemo/easysetup/modest-easysetup-wizard.c:
295 (modest_easysetup_wizard_dialog_init):
296 * src/maemo/easysetup/provider-data-test.keyfile:
297 * src/maemo/easysetup/provider-data.keyfile:
298 Moved the provider data file to the new modest-providers-data package and used it from there.
300 2007-04-16 Murray Cumming <murrayc@murrayc.com>
302 * src/modest-local-folder-info.c:
303 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
304 N_() was already used on the static strings, but this just marks it for translation without
305 using the translation.
307 2007-04-06 Murray Cumming <murrayc@murrayc.com>
309 * src/maemo/modest-account-settings-dialog.c:
310 (create_page_incoming),
311 (modest_account_settings_dialog_set_account_name):
312 Added comments about the need for new API in ModestAccountMgr to handle the authentication
313 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
314 I will do this if nobody else gets there first.
316 2007-04-06 Murray Cumming <murrayc@murrayc.com>
318 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
319 Saved much of the incoming and outgoing data too, though I cannot yet see how to
320 save the security stuff.
322 2007-04-06 Murray Cumming <murrayc@murrayc.com>
324 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
325 Set the email address and user fullname, which I now see must be
328 * src/maemo/modest-account-settings-dialog.h:
329 * src/maemo/modest-account-settings-dialog.c:
331 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
332 leave-on-server and authentication.
333 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
336 2007-04-06 Murray Cumming <murrayc@murrayc.com>
339 * src/maemo/modest-account-settings-dialog.c:
340 * src/maemo/modest-account-settings-dialog.h:
341 Most (but not all) of the widgets are now present as specified by the UI spec.
342 No changes are yet saved, and some details are not properly shown yet.
344 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
346 2007-04-06 Murray Cumming <murrayc@murrayc.com>
348 * src/maemo/Makefile.am:
349 * src/maemo/modest-account-settings-dialog.c:
350 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
351 an existing account. Doesn't do much yet.
353 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
354 Open the accounts settings dialog when Edit is clicked.
356 2007-04-05 Murray Cumming <murrayc@murrayc.com>
358 * src/maemo/easysetup/Makefile.am:
359 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
361 * src/maemo/easysetup/modest-easysetup-wizard.c:
362 (modest_easysetup_wizard_dialog_init):
363 Try to get the source directory from the build system,
364 instead of hard-coding "./" into the source code, when opening our local
365 copies of the configuration files.
366 But this still fails when opening the wizard from the Accounts window,
367 maybe because the working directory seems to change at runtime.
368 So the wizard will fail the second time unless you copy the files into their
369 proper locations - see the stdout warnings for the paths.
371 (create_page_account_details),(on_before_next):
372 Check for existing non-server accounts instead of server accounts,
373 so the default account name is useful again, and to prevent trying to
376 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
377 Show the wizard when New is clicked.
379 * src/widgets/modest-account-view.c: (on_account_default_toggled),
380 (init_view): Show the column headers, and show the columns that are
381 specified in the UI specs. However, something in Maemo's GTK+ prevents
382 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
383 change the default account. This is despite unsetting the special properties.
385 2007-04-05 Murray Cumming <murrayc@murrayc.com>
387 * docs/reference/modest-design.sgml: Corrected spelling mistake.
388 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
389 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
390 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
391 to make that clearer.
392 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
394 2007-04-05 Murray Cumming <murrayc@murrayc.com>
396 * src/maemo/modest-account-view-window.c:
397 (modest_account_view_window_init),
398 (modest_account_view_window_new):
399 Use the same buttons as specified in the
400 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
401 the existing widgets, which never had a chance of working.
402 Put the ModestAccountView treeview in a scrolled window.
403 Do not repeat the initialization in both _init() and _new().
405 * src/widgets/modest-account-view.c: (update_account_view):
406 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
407 this widget and window shows no accounts.
409 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
411 2007-04-05 Murray Cumming <murrayc@murrayc.com>
413 * src/maemo/easysetup/modest-easysetup-wizard.c:
414 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
415 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
416 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
419 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
420 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
421 accounts exist yet, as in the UI spec.
423 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
425 2007-04-05 Murray Cumming <murrayc@murrayc.com>
427 * src/maemo/Makefile.am:
428 * src/maemo/modest-connection-specific-smtp-edit-window.c:
429 * src/maemo/modest-connection-specific-smtp-edit-window.h:
430 New window for editing connection-specific smtp details.
431 Not fully implemented.
433 * src/maemo/modest-connection-specific-smtp-window.c:
434 (modest_connection_specific_smtp_window_finalize) :
435 unref the tree model.
436 (on_button_edit): Show the edit window.
438 2007-04-05 Murray Cumming <murrayc@murrayc.com>
440 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
443 * src/maemo/Makefile.am:
444 * src/maemo/modest-connection-specific-smtp-window.c:
445 * src/maemo/modest-connection-specific-smtp-window.h:
446 New window for showing the list of connections, for connection-specific
447 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
448 * src/maemo/easysetup/modest-easysetup-wizard.c:
449 (create_page_custom_outgoing): Show the new window when the button is clicked.
451 2007-04-04 Murray Cumming <murrayc@murrayc.com>
453 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
454 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
455 * src/maemo/modest-msg-edit-window.c:
456 (modest_msg_edit_window_insert_image):
457 * src/modest-conf.c: (modest_conf_key_escape):
458 * src/modest-mail-operation.c:
459 (modest_mail_operation_send_new_mail):
460 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
461 (modest_ui_actions_on_new_account):
462 * src/widgets/modest-attachment-view.c: (update_filename_request):
463 * src/widgets/modest-mail-header-view.c:
464 Corrected warnings that were breaking the build, by commenting out unused variables,
465 and a function, and by including a header.
467 2007-04-04 Murray Cumming <murrayc@murrayc.com>
469 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
470 so we can #ifdef around platform-specific code when necessary.
471 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
472 to allow this to build for the GNOME platform too.
474 2007-04-04 Murray Cumming <murrayc@murrayc.com>
476 * src/maemo/easysetup/modest-easysetup-wizard.c:
477 Added util_increment_name() and used it in create_page_account_details()
478 to make sure that the default account name is always a new name.
480 (modest_easysetup_wizard_dialog_init),
481 (set_default_custom_servernames): Some minor memory management fixes.
483 2007-04-04 Murray Cumming <murrayc@murrayc.com>
487 * src/modest-runtime.c: (init_i18n): Restored the translation
488 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
489 are defined in config.h, and the translations are installed.
491 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
492 is defined for translation.
494 2007-04-03 Murray Cumming <murrayc@murrayc.com>
496 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
498 * src/maemo/easysetup/modest-easysetup-wizard.c:
499 (modest_easysetup_wizard_dialog_init):
500 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
501 Use realistic paths (though they should use $prefix generically) to the
502 mcc_mapping and provider-data.keyfile files which might work when they
503 are installed by the future version of the operator-wizard package,
504 and then fallback to paths in our source code, with an explanatory
507 2007-04-03 Murray Cumming <murrayc@murrayc.com>
511 * src/maemo/Makefile.am:
512 * src/maemo/easysetup/: Added files from the previously-exernal
513 osso-modest-easysetup.
514 * src/maemo/modest-main-window-ui.h:
515 * src/modest-ui-actions.c:
516 * src/modest-ui-actions.h:
517 Added modest_ui_actions_on_new_account() as a signal handler for the
518 New Account menu item. It shows the easysetup wizard.
519 * po/en_GB.po: Added additional needed logical IDs and translations.
521 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
522 Apparently ChangeLog is not used for some vague Nokia legal reasons.