git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
   4         Show a more friendly error dialog now that we expect (from the tinymail
   5         documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
   6
   7 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
   8
   9         * src/maemo/modest-main-window.c: (on_account_update): Check that
  10         account_name is not NULL, to prevent a crash at startup that I am
  11         seeing on the N800. I do wonder why it is NULL.
  12
  13         * src/maemo/easysetup/modest-easysetup-wizard.c:
  14         (create_page_user_details):
  15         * src/maemo/modest-account-settings-dialog.c:
  16         (create_page_user_details), (create_page_outgoing):
  17         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  18         (modest_connection_specific_smtp_edit_window_init):
  19         * src/modest-ui-actions.c:
  20         (modest_ui_actions_on_password_requested):
  21         Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
  22         might do something useful with the on-screen keyboard.
  23
  24 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
  25
  26         * src/maemo/modest-main-window.c: (on_account_update):
  27         Avoid adding a menu item to priv->accounts_popup if accounts_popup is
  28         NULL, to avoid lots of warnings. However, it probably should not be NULL.
  29
  30 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  31
  32         * src/modest-tny-account-store.c: (on_account_changed):
  33         Correct the signature of this signal handler.
  34
  35 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  36
  37         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
  38         Show a HildonNote instead of a GtkDialog for Maemo.
  39
  40 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  41
  42         * src/widgets/modest-account-view.h:
  43         * src/widgets/modest-account-view.c: (on_account_changed),
  44         (on_account_removed). Added a boolean flag, set/unset by
  45         modest_account_view_block_conf_updates(),
  46         modest_account_view_unblock_conf_updates() to prevent unnecessary
  47         updates, but this is not very useful because the gconf notifications are
  48         so delays (maybe only on Maemo Bora).
  49         So auto-updating is turned off, and these functions do an explicit
  50         update when necessary.
  51         However, something else is still doing too much work when adding/removing
  52         accounts, probably in another part of the application.
  53
  54         * src/maemo/modest-account-view-window.c:
  55         (on_delete_button_clicked), (on_edit_button_clicked),
  56         (on_new_button_clicked): Use the new functions.
  57
  58 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  59
  60         * src/modest-account-mgr-helpers.c:
  61         (modest_account_mgr_set_first_account_as_default):
  62         Sort the list of names alphabetically-by-title, so we choose the first one
  63         based on that.
  64         * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
  65         alphabetically by the title.
  66
  67         This fixes projects.maemo.org bug NB#56418 .
  68
  69         * src/modest-account-mgr-priv.c:
  70         (_modest_account_mgr_account_from_key):
  71         * src/modest-account-mgr.c: (on_key_change): Initialize variables to
  72         avoid a valgrind error, and possible random behaviour.
  73
  74 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  75
  76         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
  77         Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
  78         tinymail documentation to say that this can be expected.
  79         Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
  80         pretty, and should not happen, but I would prefer to know when it does.
  81
  82 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  83
  84         * configure.ac: When using the older hildon version, probably on Bora,
  85         require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
  86         to fix the build.
  87         * src/widgets/modest-attachment-view.c:
  88         (modest_attachment_view_set_part_default): Initialize variables, to fix the
  89         build.
  90
  91 2007-05-09  Marcus Bauer  <marcusb@openismus.com>
  92
  93         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
  94         Implemented the prototype. Can be tested with
  95         tests/dbus_api/test_open_message:
  96
  97 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  98
  99         * src/modest-tny-account-store.c:
 100         (modest_tny_account_store_instance_init), (get_password):
 101         * src/modest-ui-actions.c:
 102         (modest_ui_actions_on_password_requested):
 103         Do not store the password in gconf, because this function is called
 104         for non-remembered passwords. Actually use the cached (in the hash map)
 105         password instead of releasing it.
 106         The password will now not be remembered if it is asked via the protected
 107         password dialog, as per the UI spec.
 108
 109 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 110
 111         * src/modest-defs.h:
 112         * src/modest-account-mgr-helpers.h:
 113         * src/modest-account-mgr-helpers.c:
 114         Added modest_server_account_get_username_has_succeeded(),
 115         modest_server_account_set_username_has_succeeded().
 116         (modest_server_account_set_username),
 117         Reset the has-succeeded flag if the username changes.
 118
 119         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 120         * src/maemo/modest-connection-specific-smtp-window.c:
 121         (modest_connection_specific_smtp_window_save_server_accounts):
 122         Use modest_server_account_set_username() instead of using
 123         modest_conf_set_string() directly, so that the has-succeeded flag is always
 124         reset.
 125
 126         * src/modest-ui-actions.c:
 127         (modest_ui_actions_on_password_requested): Dim the username entry if
 128         the username has ever worked, as per the UI spec.
 129
 130 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 131
 132         * src/modest-tny-account-store.c: (get_password):
 133         * src/modest-ui-actions.c:
 134         (modest_ui_actions_on_password_requested):
 135         Allow the username to be changed too, though there is more work to
 136         be done on exactly how this behaves.
 137
 138 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 139
 140         * src/modest-account-mgr-helpers.h:
 141         * src/modest-account-mgr-helpers.c:
 142         Added modest_account_mgr_get_display_name(),
 143         modest_server_account_get_username(),
 144         modest_server_account_set_username(),
 145         modest_server_account_set_password(),
 146         modest_server_account_get_hostname() functions so we do not need to
 147         use the conf API directly.
 148
 149         * src/maemo/modest-main-window.c: (connect_signals):
 150         Actually connect ot the ModestAccountStore::request-password signal,
 151         so that we show the dialog when the password is requested by Tinymail,
 152         for isntance if it is empty.
 153
 154         * src/modest-marshal.list:
 155         * src/modest-tny-account-store.c:
 156         (modest_tny_account_store_class_init), (get_password),
 157         (modest_tny_account_store_alert):
 158         * src/modest-tny-account-store.h:
 159         * src/modest-ui-actions.h:
 160         * src/modest-ui-actions.c:
 161         (modest_ui_actions_on_password_requested):
 162         Change the signal parameters, so it is obvious that we are providing
 163         the non human-readable server name, and receiving both the username
 164         and password, though changing of the username is not yet implemented.
 165         Change the dialog UI to match the Maemo UI specifications, with #idfefing
 166         for the GNOME version.
 167
 168         This should fix the projects.maemo.org bug NB#56209, though it does not
 169         work on Bora, because the gconf_client_get() for the password fails
 170         immediately after we save it with gconf_client_set().
 171
 172 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 173
 174         * configure.ac:
 175         * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
 176         caused an undefined symbol error:
 177         modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
 178
 179 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 180
 181         * src/modest-tny-account-store.c:
 182         (modest_tny_account_store_alert): Adapt to the changed tinymail API,
 183         using a GError instead of a string message, so we can translate it in
 184         Modest.
 185
 186 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 187
 188         * src/maemo/modest-address-book.c:
 189         (modest_address_book_check_names):
 190         * src/maemo/modest-msg-view-window.c:
 191         (modest_msg_view_window_clipboard_owner_change):
 192         * src/modest-init.c: (modest_init_init_ui):
 193         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
 194         (update_folders_cb), (modest_mail_operation_update_account):
 195         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
 196         (modest_ui_actions_on_msg_attachment_clicked),
 197         (modest_ui_actions_on_msg_recpt_activated):
 198         * src/widgets/modest-header-view.c: (drag_data_get_cb):
 199         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
 200         (modest_msg_view_search_next):
 201         * src/widgets/modest-recpt-editor.c:
 202         (modest_recpt_editor_on_button_release_event),
 203         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
 204         g_message(). At this point we should only be seeing interesting errors on
 205         stdout. Debugging messages could be #ifdefed-out if they are still useful.
 206
 207 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 208
 209         (modest_wizard_dialog_force_title_update):
 210         * src/maemo/easysetup/modest-wizard-dialog.h:
 211         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
 212         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
 213         can update the title when appropriate. Otherwise the title is wrong if the
 214         pages are added after adding the notebook to the dialog.
 215         This must be a problem in HildonWizardDialog too.
 216         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
 217
 218         * src/maemo/easysetup/modest-easysetup-wizard.c:
 219         (create_subsequent_customsetup_pages),
 220         (create_subsequent_easysetup_pages):
 221         Call modest_wizard_dialog_force_title_update() so that the title is
 222         correct even with GTK+ < 2.10.
 223         This fixes projects.maemo.org bug NB#56145 .
 224
 225 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 226
 227         * src/maemo/modest-platform.c:
 228         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
 229         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
 230         from being shown.
 231
 232 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 233
 234         * src/widgets/modest-window.h:
 235         * src/widgets/modest-window.c: Added a save_state_func vfunc,
 236         and modest_window_save_state(), which invokes it.
 237
 238         * src/widgets/modest-window-mgr.h:
 239         * src/widgets/modest-window-mgr.c:
 240         Added modest_window_mgr_save_state_for_all_windows(), which calls
 241         the save_state vfunc on all registered windows, if implemented.
 242
 243         * src/gnome/modest-msg-edit-window.c:
 244         * src/gnome/modest-msg-view-window.c:
 245         * src/maemo/modest-msg-edit-window.c:
 246         * src/maemo/modest-msg-view-window.c:
 247         * src/maemo/modest-main-window.c:
 248         Specify the existing save_settings functions as implementations of
 249         ModestWindow::save_state_func().
 250
 251         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
 252         Call modest_window_mgr_save_state_for_all_windows(). This happens before
 253         enabling hibernation, for instance.
 254
 255         We may need to do the same thing for restoring settings.
 256
 257
 258 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 259
 260         * src/widgets/modest-window-mgr.c:
 261         * src/widgets/modest-window-mgr.h:
 262         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
 263         modest_window_mgr_get_hibernation_is_prevented().
 264
 265         * src/maemo/modest-main-window.c:
 266         (on_hildon_program_is_topmost_notify): Prevent hibernation
 267         (possible when the application goes to the background in the WM),
 268         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
 269
 270         * src/maemo/easysetup/modest-easysetup-wizard.c:
 271         (modest_easysetup_wizard_dialog_init):
 272         * src/maemo/modest-account-settings-dialog.c:
 273         (modest_account_settings_dialog_init):
 274         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 275         (modest_connection_specific_smtp_edit_window_init):
 276         * src/maemo/modest-connection-specific-smtp-window.c:
 277         (modest_connection_specific_smtp_window_init):
 278         * src/maemo/modest-signature-editor-dialog.c:
 279         (modest_signature_editor_dialog_init):
 280         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
 281         prevent hibernation while any of these account settings dialogs are open.
 282
 283 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
 284
 285         * src/maemo/Makefile.am:
 286         * src/maemo/modest-osso-state-saving.c:
 287         * src/maemo/modest-osso-state-saving.h: Added
 288         modest_osso_load_state() and modest_osso_save_state() though they do
 289         nothing now. They should iterate through all the open windows and load/save
 290         their state.
 291         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 292         save state when closing.
 293
 294         * src/maemo/modest-main-window.c:
 295         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 296         Add a notification handler for the HildonProgram::is-topmost property,
 297         so we can allow hibernation when the application goes into the background.
 298         But we still need to detect when the accounts setup windows are open so
 299         we can stop hibernation when they are open.
 300         To do this, I also added the main window the HildonProgram. This might have
 301         other side-effects/benefits, and should maybe be done for other windows.
 302
 303         * src/maemo/modest-osso-autosave-callbacks.h:
 304         * src/maemo/modest-osso-autosave-callbacks.c:
 305         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 306         though it does not do anything yet, and we might never need this to do
 307         anything. For instance, we already save drafts.
 308
 309         * src/maemo/modest-platform.c: (modest_platform_init):
 310         Specify the libosso auto-save callback.
 311
 312 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 313
 314         * src/maemo/modest-platform.c:
 315         (modest_platform_set_update_interval):
 316         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 317         aparently stays valid between application instances, so we can use this
 318         to remove and reset it later. According to a maemo-developers email from
 319         David Weinehall.
 320
 321 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 322
 323         * configure.ac: Depend on libalarm for Maemo.
 324
 325         * src/dbus_api/modest-dbus-api.h:
 326         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 327         (on_send_receive), (modest_dbus_req_handler):
 328         Handle a SEND_RECEIVE D-Bus method.
 329
 330         * libmodest-dbus-client/libmodest-dbus-client.c:
 331         (libmodest_dbus_client_send_and_receive):
 332         * libmodest-dbus-client/libmodest-dbus-client.h:
 333         Add C convenience functions for calling the new D-Bus method.
 334
 335         * src/modest-platform.h:
 336         * src/gnome/modest-platform.c:
 337         * src/maemo/modest-platform.c:
 338         Added modest_platform_set_update_interval(), which uses the
 339         alarmd API on Maemo.
 340         (modest_platform_init),
 341         Call modest_platform_set_update_interval(), using a hard-coded
 342         interval for now (until the global settings dialog is implemented),
 343         though I am not sure that this makes sense yet.
 344
 345 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 346
 347         * src/dbus_api/modest-dbus-callbacks.c:
 348         (modest_osso_cb_hw_state_handler):
 349         * src/dbus_api/modest-dbus-callbacks.h:
 350         * src/maemo/modest-platform.c: (modest_platform_init):
 351         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 352         in case this has some effect on the ability for Maemo to ping the
 353         application.
 354
 355 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 356
 357         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 358         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 359         warning. It is probably a logic error, but I need to fix the build.
 360
 361 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 362
 363         * src/modest-account-mgr.h:
 364         * src/modest-account-mgr.c:
 365         (modest_account_mgr_account_names): Add a gboolean enabled_only
 366         parameter, so we can get lists of onlt the enabled accounts.
 367
 368         (modest_account_mgr_add_account),,
 369         (modest_account_mgr_account_with_display_name_exists):
 370         * src/maemo/modest-msg-edit-window.c: (get_transports):
 371         * src/modest-account-mgr-helpers.c:
 372         (modest_account_mgr_set_first_account_as_default):
 373         * src/modest-init.c: (init_default_account_maybe):
 374         * src/modest-tny-account-store.c: (get_accounts):
 375         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 376         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 377         * tests/check_account-mgr.c: (START_TEST):
 378         Provide the extra parameter, as appropriate.
 379
 380         * src/widgets/modest-account-view.c: (update_account_view):
 381         Do not show disabled accounts (meaning that there is no way to
 382         enable/disable accounts in the UI (the feature is not in our UI
 383         specification), so we can use this internally only to mark unfinished
 384         or temporary account data.
 385
 386         * src/maemo/easysetup/modest-easysetup-wizard.c:
 387         (create_account): Add boolean enable parameter, so we can specify FALSE
 388         to create the temporary account.
 389         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 390         (on_before_next): When finishing, when there is a temporary account, just
 391         set it as enabled.
 392         Also, use a timeout to delay the showing of the dialog until gconf is likely
 393         to return correct information, due to a maemo gconf bug that is fixed in
 394         osso 1.1, but not yet in Bora.
 395         However, the dialog stays on screen after it is destroyed.
 396
 397         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 398         for invalid data when cancelling. Use a hildon note instead of a dialog
 399         to complain about invalid data. Do not show the account-saved note if the
 400         account is disabled (a temporary account that will not really be saved for use
 401         until later.)
 402
 403 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 404
 405         * src/modest-account-mgr-helpers.h:
 406         * src/modest-account-mgr-helpers.c:
 407         Added modest_account_mgr_unset_default_account(),
 408         Added modest_account_mgr_set_first_account_as_default().
 409
 410         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 411         If it was the default account, unset the default account name.
 412
 413         * src/maemo/modest-account-view-window.c:
 414         (on_delete_button_clicked): If it was the default account,
 415         set the first remaining account as the default instead.
 416
 417         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 418         a NULL account or a NULL default account, to prevent a crash. This should
 419         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 420
 421
 422 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 423
 424         * src/widgets/modest-recpt-editor.c:
 425         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 426         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 427         TODO comment for this. This fixes the build.
 428
 429         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 430         be the best place for it. This will in future update all auto-update accounts,
 431         rather than just the current/default account, when that gconf key exists.
 432         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 433         if there are no accounts, before calling do_send_receive().
 434         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 435
 436         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 437         * src/maemo/modest-main-window-ui.h:
 438         * src/maemo/modest-main-window.c: (on_connection_changed),
 439         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 440         directly, becaue the signal handler does more.
 441
 442 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 443
 444         * src/modest-account-mgr-helpers.c:
 445         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 446         for the case that the account does not exist.
 447
 448         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 449         (equivalent to the modest account name) rather than the tinymail account name
 450         (equivalent to the modest account title - human readable) to get the account data.
 451         Check for null account data to prevent the crash, and add a TODO comment saying that
 452         this needs fixing because it is using the server account name instead of the account name.
 453
 454 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 455
 456         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 457         * src/maemo/modest-account-settings-dialog.c: (show_error),
 458         (show_ok):
 459         Use hildon_note_new_information() for informative and error messages,
 460         which seems to be expected for Maemo applications (no documentation that I know of
 461         says this). I am surprised that there is no distinction between info and error
 462         dialogs.
 463
 464 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 465
 466         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 467         it is easy to find where this is used.
 468
 469         * src/maemo/easysetup/modest-easysetup-wizard.c:
 470         (create_page_welcome), (create_page_account_details),
 471         (create_page_user_details), (create_page_complete_easysetup),
 472         (create_page_custom_incoming), (create_page_custom_outgoing),
 473         (create_page_complete_custom):
 474         * src/maemo/modest-account-settings-dialog.c:
 475         (create_page_account_details), (create_page_user_details),
 476         (create_page_incoming), (create_page_outgoing):
 477         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 478         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 479         (modest_connection_specific_smtp_edit_window_init):
 480         * src/maemo/modest-connection-specific-smtp-window.c:
 481         (modest_connection_specific_smtp_window_init):
 482         * src/maemo/modest-signature-editor-dialog.c:
 483         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 484         and scrolling policy as per the Email Application Layout Guide, if I have
 485         understood it.
 486
 487 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 488
 489         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 490         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 491         which were empty, because these vfuncs have been removed from TnyAccountStore.
 492         This fixes the build.
 493
 494 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 495
 496         * src/maemo/modest-main-window.c:
 497         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 498         showing/hiding it. Added TODO because it probably should not be NULL.
 499         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 500         because unnecessary g_warnings() make degugging difficult.
 501
 502 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 503
 504         * src/maemo/modest-msg-edit-window.c:
 505         (modest_msg_edit_window_select_color),
 506         (modest_msg_edit_window_select_background_color): 2 const corrections and
 507         moving 2 #endifs before closing brackets, to fix the build.
 508
 509 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 510
 511         * src/maemo/easysetup/modest-easysetup-wizard.h:
 512         * src/maemo/easysetup/modest-easysetup-wizard.c:
 513         (modest_easysetup_wizard_dialog_finalize),
 514         (on_button_edit_advanced_settings), (create_page_complete_custom),
 515         (on_response), (create_account):
 516         Implement the Advanced Settings edit button, by saving the account information,
 517         for the Advanded Settings dialog to use directly from gconf, and removing it
 518         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 519         Bug #5533 in the projects.maemo.org bugzilla.
 520
 521 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 522
 523         * src/maemo/modest-msg-view-window.c:
 524         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 525         when opening a message window.
 526
 527 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 528
 529         * src/maemo/easysetup/modest-easysetup-wizard.c:
 530         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 531         match the UI spec.
 532
 533         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 534         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 535         gconf settings. I probably added more checks than necessary, but that is safer.
 536
 537         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 538         variable to fix the build, but this seems to be used when it is still NULL.
 539
 540 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 541
 542         * src/modest-platform.h:
 543         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 544         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 545         * src/modest-main.c: Implement this function so we can avoid using
 546         maemo-specific API from cross-platform code.
 547         (main):
 548         * src/modest-tny-account-store.c:
 549         (get_smtp_specific_transport_account_for_open_connection):
 550         * src/modest-ui-actions.c: (check_for_connection),
 551         (modest_ui_actions_on_item_not_found):
 552         Use modest_platform_connect_and_wait() and put #idefs around other
 553         maemo-specific code, because only maemo currently has a way to
 554         identify connection names.
 555
 556 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 557
 558         * src/modest-tny-account-store.h:
 559         * src/modest-tny-account-store.c:
 560         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 561         the connection-specific SMTP server settings in the configuration.
 562
 563         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 564         (on_idle_mail_to):
 565         * src/maemo/modest-main-window.c: (on_connection_changed),
 566         (connect_signals):
 567         * src/modest-main.c: (main), (start_ui), (send_mail):
 568         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 569         that is what is intended.
 570
 571         * src/modest-ui-actions.c: (action_send), (action_receive),
 572         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 573         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 574         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 575         SMTP server is used when it is specified.
 576
 577         (modest_ui_actions_on_send_receive):
 578         Check that a connection is open before proceeding.
 579         Receive and then send, instead of vice-versa, as per the specification.
 580
 581 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 582
 583         * src/modest-mail-operation.c:
 584         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 585         though I guess it should be something other than NULL.
 586
 587 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 588
 589         * src/maemo/easysetup/modest-easysetup-wizard.c:
 590         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 591         combo twice, to avoid an g_warning and to make it visible again.
 592         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 593         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 594         (already intended) dereference when detaching, because we then recreate the menu.
 595         But I am not sure why the warning was happening, and it is possible that this is a memory
 596         leak.
 597
 598 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 599
 600         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 601         and uri_parse_mailto() utility functions.
 602         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 603         the mailto URI.
 604         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 605
 606 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 607
 608         * src/dbus_api/modest-dbus-api.h:
 609         * src/dbus_api/modest-dbus-callbacks.c:
 610         Use an idle callback to execute the modest code in the application's own thread.
 611         Remove the helloworld example method.
 612         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 613         parsed, and the open-message method is not implemented because this is not yet implemented in
 614         modest itself.
 615         * libmodest-dbus-client/libmodest-dbus-client.c:
 616         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 617         (libmodest_dbus_client_open_message):
 618         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 619
 620         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 621         body without crashing.
 622
 623         * tests/dbus_api/Makefile.am:
 624         * tests/dbus_api/test_mail_to.c:
 625         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 626
 627 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 628
 629         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 630         Added file to fix the build. Sorry.
 631
 632         * src/dbus_api/Makefile.am:
 633         * src/dbus_api/modest-dbus-api.h:
 634         * src/dbus_api/modest-dbus-callbacks.h:
 635         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 636         (modest_dbus_req_handler):
 637         Put constants in a separate header so it can be reused by the
 638         client library, without duplication
 639
 640         * libmodest-dbus-client/Makefile.am:
 641         * libmodest-dbus-client/libmodest-dbus-client.c:
 642         (libmodest_dbus_client_call_helloworld),
 643         (libmodfest_dbus_client_send_mail),
 644         (libmodfest_dbus_client_mailto),
 645         (libmodfest_dbus_client_open_message):
 646         * libmodest-dbus-client/libmodest-dbus-client.h:
 647         (Partly) Implement a send_mail D-Bus method.
 648
 649         * tests/dbus_api/Makefile.am:
 650         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 651         the send_email D-Bus method.
 652
 653 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 654
 655         * Makefile.am:
 656         * configure.ac:
 657         * libmodest-dbus-client/Makefile.am:
 658         * libmodest-dbus-client/libmodest-dbus-client.c:
 659         * libmodest-dbus-client/libmodest-dbus-client.h:
 660         * tests/dbus_api/Makefile.am:
 661         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 662         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 663
 664 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 665
 666         * src/maemo/easysetup/modest-easysetup-wizard.c:
 667         (create_page_account_details):
 668         * src/maemo/modest-account-settings-dialog.c:
 669         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 670         widgets, because this might not be the default in future versions of the Maemo GTK+.
 671         However, I can not not get capitalization to work even in a simple test case.
 672
 673 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 674
 675         * src/maemo/easysetup/modest-easysetup-wizard.c:
 676         (create_page_custom_incoming), (create_page_custom_outgoing):
 677         * src/maemo/modest-account-settings-dialog.c:
 678         (create_page_account_details), (create_page_incoming),
 679         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 680         instead of using gtk_check_button_with_label(), so they are aligned like the other
 681         widgets, as per the UI spec.
 682
 683 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 684
 685         * src/maemo/easysetup/modest-easysetup-wizard.c:
 686         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 687         * src/widgets/modest-validating-entry.c:
 688         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 689         Modest prefix instead of an EasySetup prefix.
 690
 691 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 692
 693         * src/widgets/modest-validating-entry.h:
 694         * src/widgets/modest-validating-entry.c: (on_insert_text),
 695         Added easysetup_validating_entry_set_max_func(), used to set a callback
 696         to call when the max number of characters is reached. GtkEntry has a max-length
 697         already but is silent about it.
 698
 699         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 700         (create_page_account_details), (create_page_user_details),
 701         (create_account):
 702         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 703         (create_page_account_details), (create_page_user_details),
 704         (create_page_outgoing):
 705         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 706         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 707         the UI spec, when the user tries to enter more than the max number of characters.
 708
 709 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 710
 711         * src/maemo/easysetup/modest-easysetup-wizard.c:
 712         (create_page_user_details), (create_page_custom_incoming),
 713         (create_page_custom_outgoing):
 714         * src/maemo/modest-account-settings-dialog.c:
 715         (create_page_user_details), (create_page_incoming),
 716         (create_page_outgoing):
 717         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 718         (modest_connection_specific_smtp_edit_window_init):
 719         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 720         not appropriate. Bad Maemo-specific defaults!.
 721
 722 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 723
 724         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 725         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 726         (modest_signature_editor_dialog_set_settings):
 727         Disable the label and textview when the checkbox is disabled, and use the
 728         specified (UI spec) default signature text.
 729
 730 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 731
 732         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 733         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 734
 735         * src/modest-defs.h:
 736         * src/modest-account-mgr-helpers.h:
 737         * src/modest-account-mgr-helpers.c:
 738         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 739
 740         * src/maemo/Makefile.am:
 741         * src/maemo/modest-signature-editor-dialog.c:
 742         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 743         as per the UI spec.
 744
 745         * src/maemo/modest-account-settings-dialog.h:
 746         * src/maemo/modest-account-settings-dialog.c:
 747         (modest_account_settings_dialog_finalize), (on_button_signature),
 748         (save_configuration): Use the new dialog when the Edit button is pressed, and
 749         save the changes if necessary, as per the UI spec.
 750
 751 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 752
 753         * src/maemo/Makefile.am:
 754         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 755         based on maemo-develoers email from Dirk.
 756
 757         * src/maemo/easysetup/modest-easysetup-wizard.c:
 758         (create_page_welcome), (create_page_account_details),
 759         (create_page_user_details), (create_page_complete_easysetup),
 760         (create_page_custom_incoming), (create_page_custom_outgoing),
 761         (create_page_complete_custom),
 762         (modest_easysetup_wizard_dialog_init):
 763         * src/maemo/modest-account-settings-dialog.c:
 764         (create_page_account_details), (create_page_user_details),
 765         (create_page_incoming), (create_page_outgoing),
 766         (modest_account_settings_dialog_init):
 767         * src/maemo/modest-connection-specific-smtp-window.c:
 768         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 769
 770 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 771
 772         * src/maemo/easysetup/modest-easysetup-wizard.c:
 773         (create_page_account_details), (create_page_custom_outgoing),
 774         (create_page_complete_custom):
 775         * src/maemo/modest-account-settings-dialog.c:
 776         (create_page_user_details), (create_page_incoming),
 777         (create_page_outgoing):
 778         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 779         (modest_connection_specific_smtp_edit_window_init):
 780         Use the correct (UI spec) port min/max, and use horizontal separators,
 781         as per the UI spec.
 782
 783 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 784
 785         * src/maemo/easysetup/modest-easysetup-wizard.c:
 786         (set_default_custom_servernames):
 787         * src/maemo/modest-account-settings-dialog.c:
 788         (create_page_incoming), (on_combo_outgoing_security_changed),
 789         (on_combo_incoming_security_changed), (create_page_outgoing),
 790         (modest_account_settings_dialog_set_account_name),
 791         (save_configuration):
 792         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 793         (on_combo_security_changed),
 794         (modest_connection_specific_smtp_edit_window_init),
 795         (modest_connection_specific_smtp_edit_window_set_connection),
 796         (modest_connection_specific_smtp_edit_window_get_settings):
 797         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 798         as per the UI spec.
 799
 800 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 801
 802         * po/en_GB.po:
 803         * src/maemo/easysetup/modest-easysetup-wizard.c:
 804         (create_page_custom_outgoing), (create_page_complete_custom):
 805         * src/maemo/modest-account-settings-dialog.c:
 806         (create_page_user_details), (create_page_outgoing):
 807         * src/maemo/modest-account-view-window.c: (button_box_new):
 808         Use changed logical IDs as per the most recent UI spec:
 809         mcen_bd_emailsetup_edit -> mcen_bd_edit
 810         mcen_bd_emailsetup_delete -> mcen_bd_delete
 811         mcen_bd_emailsetup_close -> mcen_bd_close
 812
 813 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 814
 815         * configure.ac:
 816         * src/Makefile.am:
 817         * src/dbus_api/Makefile.am:
 818         * src/dbus_api/modest-dbus-callbacks.c:
 819         * src/dbus_api/modest-dbus-callbacks.h:
 820         * src/maemo/modest-platform.c: (modest_platform_init):
 821         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 822         method.
 823         * tests/Makefile.am:
 824         * tests/dbus_api/Makefile.am:
 825         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 826
 827 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 828
 829         * src/maemo/modest-account-settings-dialog.c:
 830         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 831         Removed unnecessary includes.
 832
 833 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 834
 835         * src/maemo/easysetup/modest-easysetup-wizard.c:
 836         * src/maemo/modest-account-settings-dialog.c:
 837         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 838         * src/widgets/Makefile.am:
 839         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 840         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 841         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 842         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 843         * src/widgets/modest-secureauth-combo-box.c:
 844         * src/widgets/modest-secureauth-combo-box.h:
 845         * src/widgets/modest-serversecurity-combo-box.c:
 846         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 847         made the GObject names more consistent with the rest of the Modest code.
 848
 849 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 850
 851         * src/maemo/easysetup/Makefile.am:
 852         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 853         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 854         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 855         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 856         * src/maemo/easysetup/modest-easysetup-wizard.c:
 857         * src/maemo/easysetup/modest-validating-entry.c:
 858         * src/maemo/easysetup/modest-validating-entry.h:
 859         * src/maemo/modest-account-settings-dialog.c:
 860         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 861         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 862         widgets/ because they are used outside of easysetup too. After checking in,
 863         svn will allow me to rename them too.
 864
 865 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 866
 867         * src/gnome/modest-msg-edit-window.c:
 868         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 869         linker error, to fix the build on the GNOME platform.
 870         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 871         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 872         ifdefed out to avoid a warning.
 873
 874 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 875
 876         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 877         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 878         some alternative for GTK+ 2.6.
 879
 880 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 881
 882         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 883
 884         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 885         specified for EmailAccountsDialog in UI spec.
 886
 887         * src/maemo/easysetup/modest-easysetup-wizard.c:
 888         * src/maemo/easysetup/modest-easysetup-wizard.h:
 889         * src/maemo/modest-account-settings-dialog.c:
 890         * src/maemo/modest-account-settings-dialog.h:
 891         Reuse a member window widget for the connection-specific SMTP server accounts,
 892         so we can tell it to create/save the accounts only if we actually save changes.
 893
 894         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 895         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 896         (modest_connection_specific_smtp_edit_window_get_settings):
 897         Return a struct instance for temporarily remembering the entered data.
 898
 899         * src/maemo/modest-connection-specific-smtp-window.h:
 900         * src/maemo/modest-connection-specific-smtp-window.c:
 901         (modest_connection_specific_smtp_window_finalize),
 902         (modest_connection_specific_smtp_window_fill_with_connections),
 903         (on_button_edit),
 904         (modest_connection_specific_smtp_window_save_server_accounts),
 905         (update_model_server_names): Do not actually save data until asked,
 906         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 907
 908         (on_selection_changed),
 909         (modest_connection_specific_smtp_window_init): Disable the edit
 910         button when nothing is selected.
 911
 912         * src/modest-account-mgr-helpers.c:
 913         * src/modest-account-mgr-helpers.h:
 914         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 915         elsewhere.
 916
 917 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 918
 919         * src/modest-account-mgr-helpers.h:
 920         * src/modest-account-mgr-helpers.c:
 921         (modest_account_mgr_get_unused_account_name),
 922         (modest_account_mgr_get_unused_account_display_name): Added these
 923         utility functions, to avoid code duplication.
 924
 925         * src/maemo/easysetup/modest-easysetup-wizard.c:
 926         (create_page_account_details), (create_account):
 927         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 928         (on_combo_security_changed),
 929         (modest_connection_specific_smtp_edit_window_init),
 930         (modest_connection_specific_smtp_edit_window_save_settings):
 931         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 932         * src/maemo/modest-connection-specific-smtp-window.c:
 933         (modest_connection_specific_smtp_window_finalize),
 934         (modest_connection_specific_smtp_window_fill_with_connections),
 935         (on_button_edit), (modest_connection_specific_smtp_window_init):
 936         * src/maemo/modest-connection-specific-smtp-window.h:
 937         Implementing saving of connection-specific server accounts.
 938
 939         But I need to refactor this so we can save the data for each
 940         possible connection-specific account and only actually create the server accounts
 941         when the easysetup finished, or the OK button is pressed on the account settings
 942         dialog.
 943
 944 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 945
 946         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 947         (on_combo_security_changed):
 948         (modest_connection_specific_smtp_edit_window_init):
 949         Auto-fill the port number as in the account settings.
 950
 951         (modest_connection_specific_smtp_edit_window_set_connection):
 952         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 953         * src/maemo/modest-connection-specific-smtp-window.c:
 954         (fill_with_connections), (on_button_edit),
 955         (modest_connection_specific_smtp_window_init):
 956         Turn the edit window into a dialog to simplify the code, and
 957         set a WM hint as in a GtkDialog, because only a popup can be on top of
 958         another window in Maemo, and popups usually have no WM decoration.
 959
 960         * src/modest-defs.h:
 961         * src/modest-account-mgr-helpers.c:
 962         (modest_account_mgr_set_connection_specific_smtp),
 963         (modest_account_mgr_remove_connection_specific_smtp),
 964         (modest_account_mgr_get_connection_specific_smtp):
 965         * src/modest-account-mgr-helpers.h: Some functions to write the
 966         connection-specific SMTP server information. Not yet used.
 967
 968
 969         * src/widgets/modest-folder-view.c: (text_cell_data):
 970         Fix a warning about an uninitialized variable.
 971         (on_configuration_key_changed): Put an #ifdef around the use
 972         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 973
 974 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 975
 976         * src/maemo/modest-account-settings-dialog.h:
 977         * src/maemo/modest-account-settings-dialog.c:
 978         Added connect_for_modified() utility function to mark the new modified boolean.
 979
 980         (create_page_account_details), (create_page_user_details),
 981         (create_page_incoming), (create_page_outgoing), (on_response),
 982         (modest_account_settings_dialog_init),
 983         (modest_account_settings_dialog_set_account_name):
 984         Only warn about unsaved changes when there are actually unsaved changes.
 985
 986         * src/modest-account-mgr-helpers.c:
 987         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 988         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 989         to get the data from there in future.
 990
 991 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 992
 993         * src/modest-defs.h:
 994
 995         * src/modest-account-mgr-helpers.h:
 996         * src/modest-account-mgr-helpers.c:
 997         Store the security account setting in a single conf key instead of using
 998         the options list, so that the list is left for just the to-be-removed camel hack,
 999         and because gconf_client_set_list() is failing for some reason.
1000
1001         * src/modest-account-mgr.c:
1002         (modest_account_mgr_add_server_account):
1003         * src/maemo/modest-account-settings-dialog.c:
1004         (modest_account_settings_dialog_set_account_name),
1005         (save_configuration): Use the renamed functions.
1006
1007
1008 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1009
1010         * src/widgets/Makefile.am:
1011         * src/widgets/modest-limit-retrieve-combo-box.c:
1012         * src/widgets/modest-limit-retrieve-combo-box.h:
1013         * src/widgets/modest-retrieve-combo-box.c:
1014         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1015         the account settings dialog.
1016
1017         * src/modest-defs.h:
1018         * src/modest-account-mgr-helpers.h:
1019         * src/modest-account-mgr-helpers.c:
1020         (modest_server_account_get_option_secure_auth),
1021         (modest_server_account_set_option_secure_auth):
1022         * src/modest-account-mgr.c:
1023         (modest_account_mgr_add_server_account):
1024         Use the existing AUTH_MECH conf key for the secure-auth setting,
1025         instead of putting it in the list options, because this was actually used already.
1026
1027         * src/maemo/modest-account-settings-dialog.c:
1028         (create_page_account_details),
1029         (modest_account_settings_dialog_set_account_name),
1030         (save_configuration):
1031         * src/maemo/modest-account-settings-dialog.h:
1032         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1033         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1034
1035 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1036
1037         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1038         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1039         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1040
1041         * src/modest-defs.h:
1042         * src/maemo/modest-account-settings-dialog.c:
1043         (create_page_incoming), (on_combo_outgoing_security_changed),
1044         (on_combo_incoming_security_changed), (create_page_outgoing),
1045         (modest_account_settings_dialog_set_account_name),
1046         (save_configuration): Load/Save the port number, and change it when the
1047         security combo changes, to suitable defaults.
1048
1049 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1050
1051         * src/modest-account-mgr.c:
1052         (modest_account_mgr_add_server_account): Set the security and secure-auth
1053         options, and add a comment saying that the other camel-specific options should be
1054         removed in future.
1055
1056 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1057
1058         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1059         found by valgrind.
1060         * src/modest-tny-account-store.c: (account_list_free),
1061         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1062         cursor->data after unreffing it. But there is some strange stuff there so it might not be
1063         easy to fix.
1064
1065 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1066
1067         * src/modest-protocol-info.c:
1068         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1069         is required by our UI spec. Maybe something in our implementation will use this eventually.
1070         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1071         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1072         instead of the previous 0 placeholder.
1073
1074         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1075         secure-auth settings.
1076         * src/modest-account-mgr-helpers.h:
1077         * src/modest-account-mgr-helpers.c:
1078         (modest_server_account_data_get_option_secure_auth),
1079         (modest_server_account_set_option_secure_auth),
1080         (modest_server_account_data_get_option_security),
1081         (modest_server_account_set_option_security): Added this API for getting and setting the security
1082         and secure-auth settings.
1083
1084         * src/maemo/modest-account-settings-dialog.h:
1085         * src/maemo/modest-account-settings-dialog.c:
1086         (modest_account_settings_dialog_finalize), (check_data),
1087         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1088         about changing titles.
1089         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1090         (save_configuration): Save the security and secure-auth settings.
1091
1092         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1093         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1094
1095 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1096
1097         * src/modest-defs.h:
1098         * src/modest-account-mgr.c:
1099         (modest_account_mgr_add_server_account):
1100         Added and used defines for the options key and value pair strings,
1101         that are used so far, though they do not seem to correspond to anything in our
1102         UI specs or ModestProtocol enum.
1103
1104         * src/modest-account-mgr-helpers.h:
1105         * src/modest-account-mgr-helpers.c:
1106         (compare_option_strings_for_name),
1107         (modest_server_account_data_get_option_value),
1108         (modest_server_account_data_get_option_bool),
1109         (modest_account_mgr_get_server_account_option):
1110         Added helper functions for parsing the options GSList.
1111
1112 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1113
1114         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1115         display name is based on the supplied account name.
1116         * src/modest-account-mgr.c:
1117         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1118         with an inefficient, but good-enough, implementation.
1119
1120         * src/maemo/easysetup/modest-easysetup-wizard.c:
1121         (create_page_account_details), (on_before_next), (create_account):
1122         Check for existing display names rather than (non-user-visible) account names, and just
1123         create and set a unique account name at the end.
1124
1125         * src/maemo/modest-account-settings-dialog.c:
1126         (modest_account_settings_dialog_init),
1127         (modest_account_settings_dialog_set_account_name),
1128         (create_page_incoming): Show the display name, instead of the account name.
1129         (on_response): Do some (not all) extra checks, as in the UI spec.
1130         (save_configuration): Save the display name if it was changed.
1131
1132 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1133
1134         * po/en_GB.po: Added needed logical ID and translation.
1135         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1136         (init_view): Made the is-default column clicking work.
1137
1138 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1139
1140         * configure.ac:
1141         * src/maemo/easysetup/Makefile.am:
1142         * src/maemo/easysetup/modest-easysetup-wizard.c:
1143         (modest_easysetup_wizard_dialog_init):
1144         * src/maemo/easysetup/provider-data-test.keyfile:
1145         * src/maemo/easysetup/provider-data.keyfile:
1146         Moved the provider data file to the new modest-providers-data package and used it from there.
1147
1148 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1149
1150         * src/modest-local-folder-info.c:
1151         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1152         N_() was already used on the static strings, but this just marks it for translation without
1153         using the translation.
1154
1155 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1156
1157         * src/maemo/modest-account-settings-dialog.c:
1158         (create_page_incoming),
1159         (modest_account_settings_dialog_set_account_name):
1160         Added comments about the need for new API in ModestAccountMgr to handle the authentication
1161         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1162         I will do this if nobody else gets there first.
1163
1164 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1165
1166         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1167         Saved much of the incoming and outgoing data too, though I cannot yet see how to
1168         save the security stuff.
1169
1170 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1171
1172         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1173         Set the email address and user fullname, which I now see must be
1174         done separately.
1175
1176         * src/maemo/modest-account-settings-dialog.h:
1177         * src/maemo/modest-account-settings-dialog.c:
1178          (on_response),
1179         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1180         leave-on-server and authentication.
1181         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1182         how to do the rest.
1183
1184 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1185
1186
1187         * src/maemo/modest-account-settings-dialog.c:
1188         * src/maemo/modest-account-settings-dialog.h:
1189         Most (but not all) of the widgets are now present as specified by the UI spec.
1190         No changes are yet saved, and some details are not properly shown yet.
1191
1192         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1193
1194 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1195
1196         * src/maemo/Makefile.am:
1197         * src/maemo/modest-account-settings-dialog.c:
1198         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1199         an existing account. Doesn't do much yet.
1200
1201         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1202         Open the accounts settings dialog when Edit is clicked.
1203
1204 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1205
1206         * src/maemo/easysetup/Makefile.am:
1207         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1208         (load_from_file):
1209         * src/maemo/easysetup/modest-easysetup-wizard.c:
1210         (modest_easysetup_wizard_dialog_init):
1211         Try to get the source directory from the build system,
1212         instead of hard-coding "./" into the source code, when opening our local
1213         copies of the configuration files.
1214         But this still fails when opening the wizard from the Accounts window,
1215         maybe because the working directory seems to change at runtime.
1216         So the wizard will fail the second time unless you copy the files into their
1217         proper locations - see the stdout warnings for the paths.
1218
1219         (create_page_account_details),(on_before_next):
1220         Check for existing non-server accounts instead of server accounts,
1221         so the default account name is useful again, and to prevent trying to
1222         recreate accounts.
1223
1224         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1225         Show the wizard when New is clicked.
1226
1227         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1228         (init_view): Show the column headers, and show the columns that are
1229         specified in the UI specs. However, something in Maemo's GTK+ prevents
1230         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1231         change the default account. This is despite unsetting the special properties.
1232
1233 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1234
1235         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1236         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1237         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1238         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1239         to make that clearer.
1240         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1241
1242 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1243
1244         * src/maemo/modest-account-view-window.c:
1245         (modest_account_view_window_init),
1246         (modest_account_view_window_new):
1247         Use the same buttons as specified in the
1248         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1249         the existing widgets, which never had a chance of working.
1250         Put the ModestAccountView treeview in a scrolled window.
1251         Do not repeat the initialization in both _init() and _new().
1252
1253         * src/widgets/modest-account-view.c: (update_account_view):
1254         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1255         this widget and window shows no accounts.
1256
1257         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1258
1259 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1260
1261         * src/maemo/easysetup/modest-easysetup-wizard.c:
1262         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1263         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1264         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1265         which seems wrong.
1266
1267         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1268         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1269         accounts exist yet, as in the UI spec.
1270
1271         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1272
1273 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1274
1275         * src/maemo/Makefile.am:
1276         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1277         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1278         New window for editing connection-specific smtp details.
1279         Not fully implemented.
1280
1281         * src/maemo/modest-connection-specific-smtp-window.c:
1282         (modest_connection_specific_smtp_window_finalize) :
1283         unref the tree model.
1284         (on_button_edit): Show the edit window.
1285
1286 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1287
1288         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1289         error for me.
1290
1291         * src/maemo/Makefile.am:
1292         * src/maemo/modest-connection-specific-smtp-window.c:
1293         * src/maemo/modest-connection-specific-smtp-window.h:
1294         New window for showing the list of connections, for connection-specific
1295         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1296         * src/maemo/easysetup/modest-easysetup-wizard.c:
1297         (create_page_custom_outgoing): Show the new window when the button is clicked.
1298
1299 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1300
1301         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1302         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1303         * src/maemo/modest-msg-edit-window.c:
1304         (modest_msg_edit_window_insert_image):
1305         * src/modest-conf.c: (modest_conf_key_escape):
1306         * src/modest-mail-operation.c:
1307         (modest_mail_operation_send_new_mail):
1308         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1309         (modest_ui_actions_on_new_account):
1310         * src/widgets/modest-attachment-view.c: (update_filename_request):
1311         * src/widgets/modest-mail-header-view.c:
1312         Corrected warnings that were breaking the build, by commenting out unused variables,
1313         and a function, and by including a header.
1314
1315 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1316
1317         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1318         so we can #ifdef around platform-specific code when necessary.
1319         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1320         to allow this to build for the GNOME platform too.
1321
1322 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1323
1324         * src/maemo/easysetup/modest-easysetup-wizard.c:
1325         Added util_increment_name() and used it in create_page_account_details()
1326         to make sure that the default account name is always a new name.
1327
1328         (modest_easysetup_wizard_dialog_init),
1329         (set_default_custom_servernames): Some minor memory management fixes.
1330
1331 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1332
1333         * Makefile.am:
1334         * configure.ac:
1335         * src/modest-runtime.c: (init_i18n): Restored the translation
1336         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1337         are defined in config.h, and the translations are installed.
1338
1339         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1340         is defined for translation.
1341
1342 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1343
1344         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1345         (load_from_file):
1346         * src/maemo/easysetup/modest-easysetup-wizard.c:
1347         (modest_easysetup_wizard_dialog_init):
1348         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1349         Use realistic paths (though they should use $prefix generically) to the
1350         mcc_mapping and provider-data.keyfile files which might work when they
1351         are installed by the future version of the operator-wizard package,
1352         and then fallback to paths in our source code, with an explanatory
1353         warning.
1354
1355 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1356
1357         * configure.ac:
1358         * src/Makefile.am:
1359         * src/maemo/Makefile.am:
1360         * src/maemo/easysetup/: Added files from the previously-exernal
1361         osso-modest-easysetup.
1362         * src/maemo/modest-main-window-ui.h:
1363         * src/modest-ui-actions.c:
1364         * src/modest-ui-actions.h:
1365         Added modest_ui_actions_on_new_account() as a signal handler for the
1366         New Account menu item. It shows the easysetup wizard.
1367         * po/en_GB.po: Added additional needed logical IDs and translations.
1368
1369 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1370 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1371