git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
   4         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
   5         which were empty, because these vfuncs have been removed from TnyAccountStore.
   6         This fixes the build.
   7
   8 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
   9
  10         * src/maemo/modest-main-window.c:
  11         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
  12         showing/hiding it. Added TODO because it probably should not be NULL.
  13         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
  14         because unnecessary g_warnings() make degugging difficult.
  15
  16 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  17
  18         * src/maemo/modest-msg-edit-window.c:
  19         (modest_msg_edit_window_select_color),
  20         (modest_msg_edit_window_select_background_color): 2 const corrections and
  21         moving 2 #endifs before closing brackets, to fix the build.
  22
  23 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  24
  25         * src/maemo/easysetup/modest-easysetup-wizard.h:
  26         * src/maemo/easysetup/modest-easysetup-wizard.c:
  27         (modest_easysetup_wizard_dialog_finalize),
  28         (on_button_edit_advanced_settings), (create_page_complete_custom),
  29         (on_response), (create_account):
  30         Implement the Advanced Settings edit button, by saving the account information,
  31         for the Advanded Settings dialog to use directly from gconf, and removing it
  32         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
  33         Bug #5533 in the projects.maemo.org bugzilla.
  34
  35 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  36
  37         * src/maemo/modest-msg-view-window.c:
  38         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
  39         when opening a message window.
  40
  41 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  42
  43         * src/maemo/easysetup/modest-easysetup-wizard.c:
  44         (create_page_custom_outgoing): Correct the position of the horizontal separator to
  45         match the UI spec.
  46
  47         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
  48         before showing/hiding them, to avoid a crash when clicking on folders when there are no
  49         gconf settings. I probably added more checks than necessary, but that is safer.
  50
  51         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
  52         variable to fix the build, but this seems to be used when it is still NULL.
  53
  54 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  55
  56         * src/modest-platform.h:
  57         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
  58         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
  59         * src/modest-main.c: Implement this function so we can avoid using
  60         maemo-specific API from cross-platform code.
  61         (main):
  62         * src/modest-tny-account-store.c:
  63         (get_smtp_specific_transport_account_for_open_connection):
  64         * src/modest-ui-actions.c: (check_for_connection),
  65         (modest_ui_actions_on_item_not_found):
  66         Use modest_platform_connect_and_wait() and put #idefs around other
  67         maemo-specific code, because only maemo currently has a way to
  68         identify connection names.
  69
  70 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  71
  72         * src/modest-tny-account-store.h:
  73         * src/modest-tny-account-store.c:
  74         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
  75         the connection-specific SMTP server settings in the configuration.
  76
  77         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
  78         (on_idle_mail_to):
  79         * src/maemo/modest-main-window.c: (on_connection_changed),
  80         (connect_signals):
  81         * src/modest-main.c: (main), (start_ui), (send_mail):
  82         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
  83         that is what is intended.
  84
  85         * src/modest-ui-actions.c: (action_send), (action_receive),
  86         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
  87         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
  88         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
  89         SMTP server is used when it is specified.
  90
  91         (modest_ui_actions_on_send_receive):
  92         Check that a connection is open before proceeding.
  93         Receive and then send, instead of vice-versa, as per the specification.
  94
  95 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
  96
  97         * src/modest-mail-operation.c:
  98         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
  99         though I guess it should be something other than NULL.
 100
 101 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 102
 103         * src/maemo/easysetup/modest-easysetup-wizard.c:
 104         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 105         combo twice, to avoid an g_warning and to make it visible again.
 106         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 107         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 108         (already intended) dereference when detaching, because we then recreate the menu.
 109         But I am not sure why the warning was happening, and it is possible that this is a memory
 110         leak.
 111
 112 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 113
 114         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 115         and uri_parse_mailto() utility functions.
 116         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 117         the mailto URI.
 118         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 119
 120 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 121
 122         * src/dbus_api/modest-dbus-api.h:
 123         * src/dbus_api/modest-dbus-callbacks.c:
 124         Use an idle callback to execute the modest code in the application's own thread.
 125         Remove the helloworld example method.
 126         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 127         parsed, and the open-message method is not implemented because this is not yet implemented in
 128         modest itself.
 129         * libmodest-dbus-client/libmodest-dbus-client.c:
 130         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 131         (libmodest_dbus_client_open_message):
 132         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 133
 134         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 135         body without crashing.
 136
 137         * tests/dbus_api/Makefile.am:
 138         * tests/dbus_api/test_mail_to.c:
 139         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 140
 141 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 142
 143         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 144         Added file to fix the build. Sorry.
 145
 146         * src/dbus_api/Makefile.am:
 147         * src/dbus_api/modest-dbus-api.h:
 148         * src/dbus_api/modest-dbus-callbacks.h:
 149         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 150         (modest_dbus_req_handler):
 151         Put constants in a separate header so it can be reused by the
 152         client library, without duplication
 153
 154         * libmodest-dbus-client/Makefile.am:
 155         * libmodest-dbus-client/libmodest-dbus-client.c:
 156         (libmodest_dbus_client_call_helloworld),
 157         (libmodfest_dbus_client_send_mail),
 158         (libmodfest_dbus_client_mailto),
 159         (libmodfest_dbus_client_open_message):
 160         * libmodest-dbus-client/libmodest-dbus-client.h:
 161         (Partly) Implement a send_mail D-Bus method.
 162
 163         * tests/dbus_api/Makefile.am:
 164         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 165         the send_email D-Bus method.
 166
 167 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 168
 169         * Makefile.am:
 170         * configure.ac:
 171         * libmodest-dbus-client/Makefile.am:
 172         * libmodest-dbus-client/libmodest-dbus-client.c:
 173         * libmodest-dbus-client/libmodest-dbus-client.h:
 174         * tests/dbus_api/Makefile.am:
 175         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 176         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 177
 178 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 179
 180         * src/maemo/easysetup/modest-easysetup-wizard.c:
 181         (create_page_account_details):
 182         * src/maemo/modest-account-settings-dialog.c:
 183         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 184         widgets, because this might not be the default in future versions of the Maemo GTK+.
 185         However, I can not not get capitalization to work even in a simple test case.
 186
 187 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 188
 189         * src/maemo/easysetup/modest-easysetup-wizard.c:
 190         (create_page_custom_incoming), (create_page_custom_outgoing):
 191         * src/maemo/modest-account-settings-dialog.c:
 192         (create_page_account_details), (create_page_incoming),
 193         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 194         instead of using gtk_check_button_with_label(), so they are aligned like the other
 195         widgets, as per the UI spec.
 196
 197 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 198
 199         * src/maemo/easysetup/modest-easysetup-wizard.c:
 200         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 201         * src/widgets/modest-validating-entry.c:
 202         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 203         Modest prefix instead of an EasySetup prefix.
 204
 205 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 206
 207         * src/widgets/modest-validating-entry.h:
 208         * src/widgets/modest-validating-entry.c: (on_insert_text),
 209         Added easysetup_validating_entry_set_max_func(), used to set a callback
 210         to call when the max number of characters is reached. GtkEntry has a max-length
 211         already but is silent about it.
 212
 213         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 214         (create_page_account_details), (create_page_user_details),
 215         (create_account):
 216         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 217         (create_page_account_details), (create_page_user_details),
 218         (create_page_outgoing):
 219         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 220         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 221         the UI spec, when the user tries to enter more than the max number of characters.
 222
 223 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 224
 225         * src/maemo/easysetup/modest-easysetup-wizard.c:
 226         (create_page_user_details), (create_page_custom_incoming),
 227         (create_page_custom_outgoing):
 228         * src/maemo/modest-account-settings-dialog.c:
 229         (create_page_user_details), (create_page_incoming),
 230         (create_page_outgoing):
 231         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 232         (modest_connection_specific_smtp_edit_window_init):
 233         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 234         not appropriate. Bad Maemo-specific defaults!.
 235
 236 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 237
 238         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 239         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 240         (modest_signature_editor_dialog_set_settings):
 241         Disable the label and textview when the checkbox is disabled, and use the
 242         specified (UI spec) default signature text.
 243
 244 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 245
 246         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 247         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 248
 249         * src/modest-defs.h:
 250         * src/modest-account-mgr-helpers.h:
 251         * src/modest-account-mgr-helpers.c:
 252         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 253
 254         * src/maemo/Makefile.am:
 255         * src/maemo/modest-signature-editor-dialog.c:
 256         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 257         as per the UI spec.
 258
 259         * src/maemo/modest-account-settings-dialog.h:
 260         * src/maemo/modest-account-settings-dialog.c:
 261         (modest_account_settings_dialog_finalize), (on_button_signature),
 262         (save_configuration): Use the new dialog when the Edit button is pressed, and
 263         save the changes if necessary, as per the UI spec.
 264
 265 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 266
 267         * src/maemo/Makefile.am:
 268         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 269         based on maemo-develoers email from Dirk.
 270
 271         * src/maemo/easysetup/modest-easysetup-wizard.c:
 272         (create_page_welcome), (create_page_account_details),
 273         (create_page_user_details), (create_page_complete_easysetup),
 274         (create_page_custom_incoming), (create_page_custom_outgoing),
 275         (create_page_complete_custom),
 276         (modest_easysetup_wizard_dialog_init):
 277         * src/maemo/modest-account-settings-dialog.c:
 278         (create_page_account_details), (create_page_user_details),
 279         (create_page_incoming), (create_page_outgoing),
 280         (modest_account_settings_dialog_init):
 281         * src/maemo/modest-connection-specific-smtp-window.c:
 282         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 283
 284 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 285
 286         * src/maemo/easysetup/modest-easysetup-wizard.c:
 287         (create_page_account_details), (create_page_custom_outgoing),
 288         (create_page_complete_custom):
 289         * src/maemo/modest-account-settings-dialog.c:
 290         (create_page_user_details), (create_page_incoming),
 291         (create_page_outgoing):
 292         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 293         (modest_connection_specific_smtp_edit_window_init):
 294         Use the correct (UI spec) port min/max, and use horizontal separators,
 295         as per the UI spec.
 296
 297 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 298
 299         * src/maemo/easysetup/modest-easysetup-wizard.c:
 300         (set_default_custom_servernames):
 301         * src/maemo/modest-account-settings-dialog.c:
 302         (create_page_incoming), (on_combo_outgoing_security_changed),
 303         (on_combo_incoming_security_changed), (create_page_outgoing),
 304         (modest_account_settings_dialog_set_account_name),
 305         (save_configuration):
 306         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 307         (on_combo_security_changed),
 308         (modest_connection_specific_smtp_edit_window_init),
 309         (modest_connection_specific_smtp_edit_window_set_connection),
 310         (modest_connection_specific_smtp_edit_window_get_settings):
 311         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 312         as per the UI spec.
 313
 314 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 315
 316         * po/en_GB.po:
 317         * src/maemo/easysetup/modest-easysetup-wizard.c:
 318         (create_page_custom_outgoing), (create_page_complete_custom):
 319         * src/maemo/modest-account-settings-dialog.c:
 320         (create_page_user_details), (create_page_outgoing):
 321         * src/maemo/modest-account-view-window.c: (button_box_new):
 322         Use changed logical IDs as per the most recent UI spec:
 323         mcen_bd_emailsetup_edit -> mcen_bd_edit
 324         mcen_bd_emailsetup_delete -> mcen_bd_delete
 325         mcen_bd_emailsetup_close -> mcen_bd_close
 326
 327 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 328
 329         * configure.ac:
 330         * src/Makefile.am:
 331         * src/dbus_api/Makefile.am:
 332         * src/dbus_api/modest-dbus-callbacks.c:
 333         * src/dbus_api/modest-dbus-callbacks.h:
 334         * src/maemo/modest-platform.c: (modest_platform_init):
 335         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 336         method.
 337         * tests/Makefile.am:
 338         * tests/dbus_api/Makefile.am:
 339         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 340
 341 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 342
 343         * src/maemo/modest-account-settings-dialog.c:
 344         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 345         Removed unnecessary includes.
 346
 347 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 348
 349         * src/maemo/easysetup/modest-easysetup-wizard.c:
 350         * src/maemo/modest-account-settings-dialog.c:
 351         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 352         * src/widgets/Makefile.am:
 353         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 354         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 355         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 356         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 357         * src/widgets/modest-secureauth-combo-box.c:
 358         * src/widgets/modest-secureauth-combo-box.h:
 359         * src/widgets/modest-serversecurity-combo-box.c:
 360         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 361         made the GObject names more consistent with the rest of the Modest code.
 362
 363 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 364
 365         * src/maemo/easysetup/Makefile.am:
 366         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 367         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 368         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 369         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 370         * src/maemo/easysetup/modest-easysetup-wizard.c:
 371         * src/maemo/easysetup/modest-validating-entry.c:
 372         * src/maemo/easysetup/modest-validating-entry.h:
 373         * src/maemo/modest-account-settings-dialog.c:
 374         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 375         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 376         widgets/ because they are used outside of easysetup too. After checking in,
 377         svn will allow me to rename them too.
 378
 379 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 380
 381         * src/gnome/modest-msg-edit-window.c:
 382         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 383         linker error, to fix the build on the GNOME platform.
 384         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 385         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 386         ifdefed out to avoid a warning.
 387
 388 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 389
 390         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 391         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 392         some alternative for GTK+ 2.6.
 393
 394 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 395
 396         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 397
 398         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 399         specified for EmailAccountsDialog in UI spec.
 400
 401         * src/maemo/easysetup/modest-easysetup-wizard.c:
 402         * src/maemo/easysetup/modest-easysetup-wizard.h:
 403         * src/maemo/modest-account-settings-dialog.c:
 404         * src/maemo/modest-account-settings-dialog.h:
 405         Reuse a member window widget for the connection-specific SMTP server accounts,
 406         so we can tell it to create/save the accounts only if we actually save changes.
 407
 408         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 409         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 410         (modest_connection_specific_smtp_edit_window_get_settings):
 411         Return a struct instance for temporarily remembering the entered data.
 412
 413         * src/maemo/modest-connection-specific-smtp-window.h:
 414         * src/maemo/modest-connection-specific-smtp-window.c:
 415         (modest_connection_specific_smtp_window_finalize),
 416         (modest_connection_specific_smtp_window_fill_with_connections),
 417         (on_button_edit),
 418         (modest_connection_specific_smtp_window_save_server_accounts),
 419         (update_model_server_names): Do not actually save data until asked,
 420         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 421
 422         (on_selection_changed),
 423         (modest_connection_specific_smtp_window_init): Disable the edit
 424         button when nothing is selected.
 425
 426         * src/modest-account-mgr-helpers.c:
 427         * src/modest-account-mgr-helpers.h:
 428         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 429         elsewhere.
 430
 431 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 432
 433         * src/modest-account-mgr-helpers.h:
 434         * src/modest-account-mgr-helpers.c:
 435         (modest_account_mgr_get_unused_account_name),
 436         (modest_account_mgr_get_unused_account_display_name): Added these
 437         utility functions, to avoid code duplication.
 438
 439         * src/maemo/easysetup/modest-easysetup-wizard.c:
 440         (create_page_account_details), (create_account):
 441         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 442         (on_combo_security_changed),
 443         (modest_connection_specific_smtp_edit_window_init),
 444         (modest_connection_specific_smtp_edit_window_save_settings):
 445         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 446         * src/maemo/modest-connection-specific-smtp-window.c:
 447         (modest_connection_specific_smtp_window_finalize),
 448         (modest_connection_specific_smtp_window_fill_with_connections),
 449         (on_button_edit), (modest_connection_specific_smtp_window_init):
 450         * src/maemo/modest-connection-specific-smtp-window.h:
 451         Implementing saving of connection-specific server accounts.
 452
 453         But I need to refactor this so we can save the data for each
 454         possible connection-specific account and only actually create the server accounts
 455         when the easysetup finished, or the OK button is pressed on the account settings
 456         dialog.
 457
 458 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 459
 460         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 461         (on_combo_security_changed):
 462         (modest_connection_specific_smtp_edit_window_init):
 463         Auto-fill the port number as in the account settings.
 464
 465         (modest_connection_specific_smtp_edit_window_set_connection):
 466         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 467         * src/maemo/modest-connection-specific-smtp-window.c:
 468         (fill_with_connections), (on_button_edit),
 469         (modest_connection_specific_smtp_window_init):
 470         Turn the edit window into a dialog to simplify the code, and
 471         set a WM hint as in a GtkDialog, because only a popup can be on top of
 472         another window in Maemo, and popups usually have no WM decoration.
 473
 474         * src/modest-defs.h:
 475         * src/modest-account-mgr-helpers.c:
 476         (modest_account_mgr_set_connection_specific_smtp),
 477         (modest_account_mgr_remove_connection_specific_smtp),
 478         (modest_account_mgr_get_connection_specific_smtp):
 479         * src/modest-account-mgr-helpers.h: Some functions to write the
 480         connection-specific SMTP server information. Not yet used.
 481
 482
 483         * src/widgets/modest-folder-view.c: (text_cell_data):
 484         Fix a warning about an uninitialized variable.
 485         (on_configuration_key_changed): Put an #ifdef around the use
 486         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 487
 488 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 489
 490         * src/maemo/modest-account-settings-dialog.h:
 491         * src/maemo/modest-account-settings-dialog.c:
 492         Added connect_for_modified() utility function to mark the new modified boolean.
 493
 494         (create_page_account_details), (create_page_user_details),
 495         (create_page_incoming), (create_page_outgoing), (on_response),
 496         (modest_account_settings_dialog_init),
 497         (modest_account_settings_dialog_set_account_name):
 498         Only warn about unsaved changes when there are actually unsaved changes.
 499
 500         * src/modest-account-mgr-helpers.c:
 501         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 502         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 503         to get the data from there in future.
 504
 505 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 506
 507         * src/modest-defs.h:
 508
 509         * src/modest-account-mgr-helpers.h:
 510         * src/modest-account-mgr-helpers.c:
 511         Store the security account setting in a single conf key instead of using
 512         the options list, so that the list is left for just the to-be-removed camel hack,
 513         and because gconf_client_set_list() is failing for some reason.
 514
 515         * src/modest-account-mgr.c:
 516         (modest_account_mgr_add_server_account):
 517         * src/maemo/modest-account-settings-dialog.c:
 518         (modest_account_settings_dialog_set_account_name),
 519         (save_configuration): Use the renamed functions.
 520
 521
 522 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 523
 524         * src/widgets/Makefile.am:
 525         * src/widgets/modest-limit-retrieve-combo-box.c:
 526         * src/widgets/modest-limit-retrieve-combo-box.h:
 527         * src/widgets/modest-retrieve-combo-box.c:
 528         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 529         the account settings dialog.
 530
 531         * src/modest-defs.h:
 532         * src/modest-account-mgr-helpers.h:
 533         * src/modest-account-mgr-helpers.c:
 534         (modest_server_account_get_option_secure_auth),
 535         (modest_server_account_set_option_secure_auth):
 536         * src/modest-account-mgr.c:
 537         (modest_account_mgr_add_server_account):
 538         Use the existing AUTH_MECH conf key for the secure-auth setting,
 539         instead of putting it in the list options, because this was actually used already.
 540
 541         * src/maemo/modest-account-settings-dialog.c:
 542         (create_page_account_details),
 543         (modest_account_settings_dialog_set_account_name),
 544         (save_configuration):
 545         * src/maemo/modest-account-settings-dialog.h:
 546         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 547         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 548
 549 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 550
 551         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 552         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 553         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 554
 555         * src/modest-defs.h:
 556         * src/maemo/modest-account-settings-dialog.c:
 557         (create_page_incoming), (on_combo_outgoing_security_changed),
 558         (on_combo_incoming_security_changed), (create_page_outgoing),
 559         (modest_account_settings_dialog_set_account_name),
 560         (save_configuration): Load/Save the port number, and change it when the
 561         security combo changes, to suitable defaults.
 562
 563 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 564
 565         * src/modest-account-mgr.c:
 566         (modest_account_mgr_add_server_account): Set the security and secure-auth
 567         options, and add a comment saying that the other camel-specific options should be
 568         removed in future.
 569
 570 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 571
 572         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 573         found by valgrind.
 574         * src/modest-tny-account-store.c: (account_list_free),
 575         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 576         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 577         easy to fix.
 578
 579 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 580
 581         * src/modest-protocol-info.c:
 582         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 583         is required by our UI spec. Maybe something in our implementation will use this eventually.
 584         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 585         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 586         instead of the previous 0 placeholder.
 587
 588         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 589         secure-auth settings.
 590         * src/modest-account-mgr-helpers.h:
 591         * src/modest-account-mgr-helpers.c:
 592         (modest_server_account_data_get_option_secure_auth),
 593         (modest_server_account_set_option_secure_auth),
 594         (modest_server_account_data_get_option_security),
 595         (modest_server_account_set_option_security): Added this API for getting and setting the security
 596         and secure-auth settings.
 597
 598         * src/maemo/modest-account-settings-dialog.h:
 599         * src/maemo/modest-account-settings-dialog.c:
 600         (modest_account_settings_dialog_finalize), (check_data),
 601         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 602         about changing titles.
 603         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 604         (save_configuration): Save the security and secure-auth settings.
 605
 606         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 607         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 608
 609 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 610
 611         * src/modest-defs.h:
 612         * src/modest-account-mgr.c:
 613         (modest_account_mgr_add_server_account):
 614         Added and used defines for the options key and value pair strings,
 615         that are used so far, though they do not seem to correspond to anything in our
 616         UI specs or ModestProtocol enum.
 617
 618         * src/modest-account-mgr-helpers.h:
 619         * src/modest-account-mgr-helpers.c:
 620         (compare_option_strings_for_name),
 621         (modest_server_account_data_get_option_value),
 622         (modest_server_account_data_get_option_bool),
 623         (modest_account_mgr_get_server_account_option):
 624         Added helper functions for parsing the options GSList.
 625
 626 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 627
 628         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 629         display name is based on the supplied account name.
 630         * src/modest-account-mgr.c:
 631         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 632         with an inefficient, but good-enough, implementation.
 633
 634         * src/maemo/easysetup/modest-easysetup-wizard.c:
 635         (create_page_account_details), (on_before_next), (create_account):
 636         Check for existing display names rather than (non-user-visible) account names, and just
 637         create and set a unique account name at the end.
 638
 639         * src/maemo/modest-account-settings-dialog.c:
 640         (modest_account_settings_dialog_init),
 641         (modest_account_settings_dialog_set_account_name),
 642         (create_page_incoming): Show the display name, instead of the account name.
 643         (on_response): Do some (not all) extra checks, as in the UI spec.
 644         (save_configuration): Save the display name if it was changed.
 645
 646 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 647
 648         * po/en_GB.po: Added needed logical ID and translation.
 649         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 650         (init_view): Made the is-default column clicking work.
 651
 652 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 653
 654         * configure.ac:
 655         * src/maemo/easysetup/Makefile.am:
 656         * src/maemo/easysetup/modest-easysetup-wizard.c:
 657         (modest_easysetup_wizard_dialog_init):
 658         * src/maemo/easysetup/provider-data-test.keyfile:
 659         * src/maemo/easysetup/provider-data.keyfile:
 660         Moved the provider data file to the new modest-providers-data package and used it from there.
 661
 662 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 663
 664         * src/modest-local-folder-info.c:
 665         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 666         N_() was already used on the static strings, but this just marks it for translation without
 667         using the translation.
 668
 669 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 670
 671         * src/maemo/modest-account-settings-dialog.c:
 672         (create_page_incoming),
 673         (modest_account_settings_dialog_set_account_name):
 674         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 675         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 676         I will do this if nobody else gets there first.
 677
 678 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 679
 680         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 681         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 682         save the security stuff.
 683
 684 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 685
 686         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 687         Set the email address and user fullname, which I now see must be
 688         done separately.
 689
 690         * src/maemo/modest-account-settings-dialog.h:
 691         * src/maemo/modest-account-settings-dialog.c:
 692          (on_response),
 693         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 694         leave-on-server and authentication.
 695         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 696         how to do the rest.
 697
 698 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 699
 700
 701         * src/maemo/modest-account-settings-dialog.c:
 702         * src/maemo/modest-account-settings-dialog.h:
 703         Most (but not all) of the widgets are now present as specified by the UI spec.
 704         No changes are yet saved, and some details are not properly shown yet.
 705
 706         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 707
 708 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 709
 710         * src/maemo/Makefile.am:
 711         * src/maemo/modest-account-settings-dialog.c:
 712         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 713         an existing account. Doesn't do much yet.
 714
 715         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 716         Open the accounts settings dialog when Edit is clicked.
 717
 718 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 719
 720         * src/maemo/easysetup/Makefile.am:
 721         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 722         (load_from_file):
 723         * src/maemo/easysetup/modest-easysetup-wizard.c:
 724         (modest_easysetup_wizard_dialog_init):
 725         Try to get the source directory from the build system,
 726         instead of hard-coding "./" into the source code, when opening our local
 727         copies of the configuration files.
 728         But this still fails when opening the wizard from the Accounts window,
 729         maybe because the working directory seems to change at runtime.
 730         So the wizard will fail the second time unless you copy the files into their
 731         proper locations - see the stdout warnings for the paths.
 732
 733         (create_page_account_details),(on_before_next):
 734         Check for existing non-server accounts instead of server accounts,
 735         so the default account name is useful again, and to prevent trying to
 736         recreate accounts.
 737
 738         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 739         Show the wizard when New is clicked.
 740
 741         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 742         (init_view): Show the column headers, and show the columns that are
 743         specified in the UI specs. However, something in Maemo's GTK+ prevents
 744         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 745         change the default account. This is despite unsetting the special properties.
 746
 747 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 748
 749         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 750         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 751         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 752         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 753         to make that clearer.
 754         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 755
 756 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 757
 758         * src/maemo/modest-account-view-window.c:
 759         (modest_account_view_window_init),
 760         (modest_account_view_window_new):
 761         Use the same buttons as specified in the
 762         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 763         the existing widgets, which never had a chance of working.
 764         Put the ModestAccountView treeview in a scrolled window.
 765         Do not repeat the initialization in both _init() and _new().
 766
 767         * src/widgets/modest-account-view.c: (update_account_view):
 768         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 769         this widget and window shows no accounts.
 770
 771         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 772
 773 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 774
 775         * src/maemo/easysetup/modest-easysetup-wizard.c:
 776         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 777         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 778         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 779         which seems wrong.
 780
 781         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 782         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 783         accounts exist yet, as in the UI spec.
 784
 785         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 786
 787 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 788
 789         * src/maemo/Makefile.am:
 790         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 791         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 792         New window for editing connection-specific smtp details.
 793         Not fully implemented.
 794
 795         * src/maemo/modest-connection-specific-smtp-window.c:
 796         (modest_connection_specific_smtp_window_finalize) :
 797         unref the tree model.
 798         (on_button_edit): Show the edit window.
 799
 800 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 801
 802         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 803         error for me.
 804
 805         * src/maemo/Makefile.am:
 806         * src/maemo/modest-connection-specific-smtp-window.c:
 807         * src/maemo/modest-connection-specific-smtp-window.h:
 808         New window for showing the list of connections, for connection-specific
 809         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 810         * src/maemo/easysetup/modest-easysetup-wizard.c:
 811         (create_page_custom_outgoing): Show the new window when the button is clicked.
 812
 813 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 814
 815         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 816         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 817         * src/maemo/modest-msg-edit-window.c:
 818         (modest_msg_edit_window_insert_image):
 819         * src/modest-conf.c: (modest_conf_key_escape):
 820         * src/modest-mail-operation.c:
 821         (modest_mail_operation_send_new_mail):
 822         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 823         (modest_ui_actions_on_new_account):
 824         * src/widgets/modest-attachment-view.c: (update_filename_request):
 825         * src/widgets/modest-mail-header-view.c:
 826         Corrected warnings that were breaking the build, by commenting out unused variables,
 827         and a function, and by including a header.
 828
 829 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 830
 831         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 832         so we can #ifdef around platform-specific code when necessary.
 833         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 834         to allow this to build for the GNOME platform too.
 835
 836 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 837
 838         * src/maemo/easysetup/modest-easysetup-wizard.c:
 839         Added util_increment_name() and used it in create_page_account_details()
 840         to make sure that the default account name is always a new name.
 841
 842         (modest_easysetup_wizard_dialog_init),
 843         (set_default_custom_servernames): Some minor memory management fixes.
 844
 845 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 846
 847         * Makefile.am:
 848         * configure.ac:
 849         * src/modest-runtime.c: (init_i18n): Restored the translation
 850         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 851         are defined in config.h, and the translations are installed.
 852
 853         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 854         is defined for translation.
 855
 856 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 857
 858         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 859         (load_from_file):
 860         * src/maemo/easysetup/modest-easysetup-wizard.c:
 861         (modest_easysetup_wizard_dialog_init):
 862         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 863         Use realistic paths (though they should use $prefix generically) to the
 864         mcc_mapping and provider-data.keyfile files which might work when they
 865         are installed by the future version of the operator-wizard package,
 866         and then fallback to paths in our source code, with an explanatory
 867         warning.
 868
 869 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 870
 871         * configure.ac:
 872         * src/Makefile.am:
 873         * src/maemo/Makefile.am:
 874         * src/maemo/easysetup/: Added files from the previously-exernal
 875         osso-modest-easysetup.
 876         * src/maemo/modest-main-window-ui.h:
 877         * src/modest-ui-actions.c:
 878         * src/modest-ui-actions.h:
 879         Added modest_ui_actions_on_new_account() as a signal handler for the
 880         New Account menu item. It shows the easysetup wizard.
 881         * po/en_GB.po: Added additional needed logical IDs and translations.
 882
 883 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 884 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 885