1 2007-08-29 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
4 Use the mail_ni_ssl_certificate_error ("Secure connection failed")
5 logical ID when the secure authentication method is not supported by
6 the server, as requested by Mox on the wiki, though I hate not
7 giving the user the clue.
9 2007-08-29 Murray Cumming <murrayc@murrayc.com>
11 * src/modest-search.c: (modest_search_all_accounts):
12 * src/modest-platform.h:
13 * src/maemo/modest-platform.c: Moved and renamed
14 check_and_wait_for_account_is_online() to
15 modest_platform_check_and_wait_for_account_is_online() so it
16 can be used in more places.
18 2007-08-29 Murray Cumming <murrayc@murrayc.com>
20 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
21 Removed the sleep(1) experiment because it does not seem to help,
22 and I should not have checked the experiment in anyway.
23 The problem is maybe in the TnyAccount connected state - I will
24 investigate that instead.
26 2007-08-28 Murray Cumming <murrayc@murrayc.com>
28 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
29 Added a sleep(1) in case it helps with bug #66769.
31 2007-08-28 Murray Cumming <murrayc@murrayc.com>
33 * src/modest-search.c: (on_timeout_check_account_is_online),
34 (check_and_wait_for_account_is_online):
35 It is OK for local-folder and mmc accounts to be used when they
36 are in the _INIT folder, instead of waiting for them to change
38 For POP and IMAP, wait from them to stop being _INIT, rather than
39 waiting from them to be _CONNECTED, because that seems to be
40 the status that causes the problems.
42 2007-08-28 Murray Cumming <murrayc@murrayc.com>
44 * src/modest-search.c: (check_and_wait_for_account_is_online):
45 Actually pass the account to the timeout callback.
47 2007-08-28 Murray Cumming <murrayc@murrayc.com>
49 * src/modest-search.c: (on_timeout_check_account_is_online):
50 Added some debug output to help me debug a problem on the N800.
51 (check_and_wait_for_account_is_online): Fail immediately if the
53 modest_search_all_accounts(): Try the search even if the account does
54 not seem to be online, because this can work sometimes, and should work
55 with the cache if there is no active libconic connection.
57 2007-08-27 Armin Burgmeier <armin@openismus.com>
59 * src/modest-tny-send-queue.c: Implement TnyFolderObserver and
60 observe outbox for added messages to assign them a status. Previously,
61 this was done in modest_tny_send_queue_add(), but the message id might
62 not yet be known at that point. This reduces warnings when sending
63 mail, though I am not sure how this even worked before.
65 2007-08-27 Murray Cumming <murrayc@murrayc.com>
67 * src/maemo/modest-account-settings-dialog.c:
68 (modest_account_settings_dialog_init):
69 * src/maemo/modest-connection-specific-smtp-edit-window.c:
70 (modest_connection_specific_smtp_edit_window_init):
71 * src/maemo/modest-connection-specific-smtp-window.c:
72 (modest_connection_specific_smtp_window_init):
73 * src/maemo/modest-maemo-utils.c:
74 (modest_maemo_utils_get_supported_secure_authentication_methods):
75 * src/maemo/modest-platform.c:
76 (modest_platform_run_folder_name_dialog):
77 * src/maemo/modest-signature-editor-dialog.c:
78 (modest_signature_editor_dialog_init):
79 * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
80 (modest_ui_actions_on_password_requested), (create_move_to_dialog):
81 * src/widgets/modest-global-settings-dialog.c:
82 (modest_global_settings_dialog_init):
83 Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
85 GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
86 GTK_STOCK_EDIT with mcen_bd_edit, and
87 GTK_STOCK_CLOSE with mcen_bd_close,
88 to fix projects.maemo.org bug NB#64995.
89 I strongly believe that Maemo's GTK+ should have the wanted translations
90 instead of duplicating this in each application and complicating the code.
92 2007-08-27 Armin Burgmeier <armin@openismus.com>
94 * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
95 recursion when entering text in the subject field.
97 2007-08-27 Murray Cumming <murrayc@murrayc.com>
99 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
100 which checks every second, 10 times, to wait until the account is online
101 so that we can use it, if the account is in the process of going online.
102 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
103 so that searching works even when the application was not yet started before.
104 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
106 2007-08-24 Armin Burgmeier <armin@openismus.com>
108 * src/modest-widget-memory.c: Always show the default account when the
109 application is started, as stated in the UI spec. This fixes
110 projects.maemo.org bug NB#66630.
112 2007-08-24 Armin Burgmeier <armin@openismus.com>
114 * src/maemo/modest-platform.c:
115 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
116 english text for strings in the rename folder dialog, fixing
117 projects.maemo.org bug NB#66338.
119 2007-08-22 Armin Burgmeier <armin@openismus.com>
121 * src/widgets/modest-account-view.c: Fix for bora by using
122 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
123 latter seems not be used anymore.
125 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
128 * src/maemo/modest-main-window.c: Update menu items when the default
129 account changes so that the current default account is always bolded.
130 This fixes maemo.projects.org bug NB#66173.
132 2007-08-17 Murray Cumming <murrayc@murrayc.com>
134 * src/dbus_api/modest-dbus-callbacks.c:
135 (on_dbus_method_get_folders): Avoid trying to get the account name
136 when there are no accounts, to avoid critical g_warnings, fixing
137 projects.maemo.org bug NB#65574.
139 2007-08-17 Murray Cumming <murrayc@murrayc.com>
141 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
142 Use modest_account_mgr_get_signature() instead of accessing gconf
143 directly, to slightly simplify the code.
144 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
145 Append the signature also when opening via other applications,
146 fixing projects.maemo.org bug NB#65828.
148 2007-08-17 Murray Cumming <murrayc@murrayc.com>
150 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
151 Check for NULLs to prevent a crash when opening an email that is
152 an attachment in another email, fixing projects.maemo.org bug
155 2007-08-17 Murray Cumming <murrayc@murrayc.com>
157 * src/modest-ui-dimming-rules.c:
158 (modest_ui_dimming_rules_on_view_window_move_to):
159 Enable the Move To toolbar button for search results, fixing the
160 last part of projects.maemo.org bug NB#63807.
162 2007-08-17 Murray Cumming <murrayc@murrayc.com>
164 * src/dbus_api/modest-dbus-callbacks.c:
165 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
166 because this is called from idle handlers, to fix hangs afte the
168 (find_message_by_url): Added a TODO comment about a crash that
169 happens when tinymail was built with DBC checks.
171 2007-08-16 Murray Cumming <murrayc@murrayc.com>
173 * src/modest-search.c: (modest_search_folder):
174 * src/modest-search.h: Rename ModestSearch::before to start_date
175 and after to end_date, using the same names as the libogs struct
177 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
178 The start_date and end_date were swapped in the check. This
179 fixes date range searches, fixing projects.maemo.org bug NB#63407.
181 2007-08-16 Murray Cumming <murrayc@murrayc.com>
183 * src/maemo/modest-account-view-window.c:
184 Added (check_for_active_acount).
185 (on_delete_button_clicked), (on_edit_button_clicked):
186 When an account is doing something (such as refreshing),
187 show the same warning for account deletion as for account
188 editing, to fix projects.maemo.org bug NB#64588.
190 2007-08-16 Murray Cumming <murrayc@murrayc.com>
192 * src/widgets/modest-msg-view-window.h:
193 * src/gnome/modest-msg-view-window.c:
194 * src/maemo/modest-msg-view-window.c:
195 Added modest_msg_view_window_construct().
196 (modest_msg_view_window_new_with_header_model),
197 Added modest_msg_view_window_new_for_search_result),
198 Renamed modest_msg_view_window_new() to
199 modest_msg_view_window_new_for_attachment(),
200 and modest_msg_view_window_is_search_result(),
201 so we can explicitly know that the window is for an
202 attachment or a search result or a message from the list.
204 (modest_msg_view_window_view_attachment):
205 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
206 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
207 Use modest_msg_view_window_new_for_search_result().
209 * src/modest-ui-dimming-rules.c:
210 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
211 for search results, fixing projects.maemo.org bug NB#63811.
213 2007-08-16 Armin Burgmeier <armin@openismus.com>
215 * src/modest-ui-actions.c: Show a banner instead of a dialog when
216 renaming a folder fails, to stay consistent with what happens when
217 creating a folder fails.
219 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
220 slightly country loading from the mmc_mappings file, fixed a memory
223 2007-08-16 Murray Cumming <murrayc@murrayc.com>
225 * src/modest-tny-account-store.c: (volume_path_is_mounted):
226 Check the GnomeVFSVolume activation path instead of the device path,
227 so that the memory card is really really shown in the UI.
229 2007-08-16 Murray Cumming <murrayc@murrayc.com>
231 * src/maemo/easysetup/modest-easysetup-wizard.c:
232 (get_entered_account_title), (on_before_next), (entry_is_empty),
234 * src/maemo/modest-account-settings-dialog.c:
235 (get_entered_account_title), (on_button_signature), (check_data),
236 (save_configuration), (entry_is_empty):
237 Strip the account title of whitespace at the start and end before
238 using it or checking it. This means that an all-whitespace title
239 is not allowed, fixing projects.maemo.org bug NB#64977.
241 2007-08-15 Murray Cumming <murrayc@murrayc.com>
243 * src/modest-ui-actions.h:
244 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
245 to modest_run_account_setup_wizard() and made it public.
246 * src/dbus_api/modest-dbus-callbacks.c:
247 (check_and_offer_account_creation), (on_idle_mail_to),
248 (on_idle_compose_mail), (on_idle_open_default_inbox):
249 Offer account creation if necessary, fixing projects.maemo.org
252 2007-08-15 Murray Cumming <murrayc@murrayc.com>
254 * src/modest-ui-actions.c: (run_account_setup_wizard):
255 Return a gboolean to indicate success.
256 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
257 (modest_ui_actions_on_send): When offering account creation, only
258 give up (return) if account creation failed. Otherwise continue
259 with the original request. This fixed projects.maemo.org bug
262 2007-08-15 Murray Cumming <murrayc@murrayc.com>
264 * src/widgets/modest-recpt-editor.c:
265 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
266 to fix projects.maemo.org bug NB#63789.
268 2007-08-15 Murray Cumming <murrayc@murrayc.com>
270 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
271 (modest_tny_account_store_new): Properly detect the memory card at
272 startup, and add an account for it.
274 2007-08-14 Murray Cumming <murrayc@murrayc.com>
276 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
277 Commented out the MMC code again because it mistakenly detects
278 the card even when it isn't inserted.
280 2007-08-14 Murray Cumming <murrayc@murrayc.com>
282 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
283 Renabled the call to add_mmc_account() because I do not believe
284 it could be the cause of the mentioned hang (in scratchbox, where
285 there is no memory card), and because I have tested that it works
288 2007-08-14 Murray Cumming <murrayc@murrayc.com>
290 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
291 Comment out part of the last commit because it apparently causes
294 2007-08-14 Murray Cumming <murrayc@murrayc.com>
296 * src/modest-tny-account-store.c: Added the add_mmc_account()
297 function to save some copy/pasting.
298 (modest_tny_account_store_new): If the memory card is mounted,
299 create an account for it at the start, instead of waiting for the
300 user to unmount it and mount it.
302 2007-08-13 Murray Cumming <murrayc@murrayc.com>
304 * src/widgets/modest-account-view.c: (on_account_changed):
305 Do not try to use the human-readable TnyAccount name instead of the
306 ID of the modest account to get the transport account. And unref
307 the transport account. This prevents a g_warning(), and a possible
310 2007-08-13 Murray Cumming <murrayc@murrayc.com>
312 * src/maemo/modest-platform.c:
313 (modest_platform_set_update_interval): Handle the new
314 alarmd error to warn when alarmd is not running, as is the case in
315 scratchbox for me now because
316 "Module /usr/lib/alarmd/libretu.so initialization failed"
318 2007-08-13 Murray Cumming <murrayc@murrayc.com>
320 * src/widgets/modest-header-view-render.c:
321 (_modest_header_view_compact_header_cell_data):
322 NULL some strings after freeing them, trying to deal with
323 the double deletion found in projects.maemo.org bug 64183,
324 probably having no effect.
326 2007-08-13 Murray Cumming <murrayc@murrayc.com>
328 * src/maemo/modest-account-settings-dialog.c:
329 (create_page_incoming), (create_page_outgoing): Use a define
330 for the min and max port numbers.
332 (check_hildon_number_editor_and_warn_value_not_in_range),
333 (check_data): Do an extra check for an invalid port number, as needed
334 in projects.maemo.org bug #64275, when the number is cleared, but this
335 does not work due to bugs.maemo.org bug #1806.
337 2007-08-13 Murray Cumming <murrayc@murrayc.com>
339 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
340 Comment out the debug warning about the unexpected D-Bus methods.
341 They are just annoying now.
342 * src/maemo/modest-platform.c:
343 (modest_platform_set_update_interval): Correct the D-Bus path, instead
344 of using a file path, though it did not seem to break things before.
345 It might be needed now:
346 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
347 modest is not already running. This is the behaviour of the old client, and
348 Mox says it is what we should do for modest.
349 This closes projects.maemo.org bug NB#64327.
351 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
353 * src/modest-text-utils.c:
354 Fixed invalid jump due to incorrect string/pointer
356 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
359 2007-08-01 Murray Cumming <murrayc@murrayc.com>
361 * src/modest-account-mgr-helpers.h:
362 * src/modest-account-mgr-helpers.c:
363 Added modest_account_mgr_get_first_account_name(),
364 using code from modest_account_mgr_set_first_account_as_default().
366 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
367 (account_number_changed): Call set_at_least_one_account_visible() so that
368 the first account is visible when first added, without the user having to
370 I do wonder how this worked before.
372 2007-08-01 Murray Cumming <murrayc@murrayc.com>
374 * src/modest-tny-account-store.c: (show_password_warning_only),
375 (show_wrong_password), (request_password_and_wait), (get_password),
376 (modest_tny_account_store_alert): Remove the (incomplete anyway)
377 attempts to show UI only in the main context, which used g_idle_add()
378 and mainloops, because tinymail now guarantees that it only calls these
379 callbacks in the mainloop with the gdk lock. This makes everything much
382 2007-08-01 Murray Cumming <murrayc@murrayc.com>
384 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
385 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
386 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
387 error dialog, instead of ignoring it.
389 2007-08-01 Murray Cumming <murrayc@murrayc.com>
391 * src/maemo/modest-msg-view-window.c:
392 (modest_msg_view_window_get_header),
393 (modest_msg_view_window_last_message_selected):
394 Added comments to explain the use of priv->header_model.
395 * src/modest-ui-dimming-rules.c:
396 (modest_ui_dimming_rules_on_open_msg),
397 (modest_ui_dimming_rules_on_mark_as_read_msg),
398 (modest_ui_dimming_rules_on_mark_as_unread_msg),
399 (modest_ui_dimming_rules_on_remove_attachments),
400 (_invalid_attach_selected), (_selected_msg_marked_as):
401 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
402 and changed the parameter to a ModestMainWindow to make it clearer that
403 it never uses any other kind of window.
404 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
405 instead of the selected message.
406 I notice that much of the dimming code and the ModestMsgViewWindow code
407 hard-codes the assumption that the viewed message is always selected in
408 the header view. This does not seem wise or simple.
410 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
411 examine the actual message instead of whatever might be selected
412 in the header view. This stops the delete toolbar button and menu item
413 from being dimmed when opening a message view the search UI,
414 partially fixing projects.maemo.org bug NB#63811.
416 However, when actually deleting, I now get this warning:
417 "tny_header_set_flags: This is a header instance for a new message.
418 Only priority and attachment flags are supported"
420 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
422 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
424 Show account wizard if no accounts are defined while sending
425 (automatic sending after the account wizard finished does not
426 work because it takes some time until the account manager
427 synchronizes everything. (projects.maemo.org NB#62792)
429 2007-07-30 Murray Cumming <murrayc@murrayc.com>
431 * src/modest-tny-account-store.c: (on_account_removed),
432 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
433 account is removed from the View menu. We have TnyAccountStore
434 and ModestTnyAccountStore signals that seem very similar, but this
435 seems to work for now.
437 * src/maemo/modest-main-window.c:
438 (on_show_account_action_activated): Prevent dereference
439 of a NULL if the accoutn does not really exist, though that
440 should not happen anymore.
442 This fixes projects.maemo.org bug NB#64606.
444 2007-07-30 Murray Cumming <murrayc@murrayc.com>
446 * src/modest-ui-actions.c: (run_account_setup_wizard),
447 (modest_ui_actions_on_accounts): Revert a change that set these
448 to modal dialogs, freezing the UI when they show secondary dialogs.
449 This fixed projects.maemo.org bug NB#64519.
451 2007-07-27 Murray Cumming <murrayc@murrayc.com>
453 * src/widgets/modest-header-view-render.c:
454 (_modest_header_view_compact_header_cell_data):
455 Some checks and initialization to try to deal with a crash,
456 probably ineffective.
458 2007-07-27 Murray Cumming <murrayc@murrayc.com>
460 * src/maemo/modest-maemo-utils.c:
461 (modest_maemo_utils_get_supported_secure_authentication_methods):
462 Make sure that we have a connection, asking the user for one
464 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
465 Check for a connection before showing the wizard, because
466 the wizard needs a connection to check for server capabilities.
468 2007-07-27 Murray Cumming <murrayc@murrayc.com>
470 * src/maemo/modest-account-view-window.c:
471 (on_new_button_clicked): Remember the wizard dialog instance,
472 so we can just present it again if necessary. This prevents
473 multiple windows from appearing if you click again quickly on the
474 New button before the dialog appears, fixing projects.maemo.org
477 2007-07-27 Murray Cumming <murrayc@murrayc.com>
479 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
480 Offer a connection dialog if there is no connection when
481 starting modest. This should fix projects.maemo.org bug NB#61134.
483 2007-07-27 Murray Cumming <murrayc@murrayc.com>
485 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
486 Reverted my last commit. I was able to fix the build by doing
487 apt-get install wpeditor0 (replacing other wpeditor packages) and
488 an explicit apt-get install wpeditor-dev to upgrade the -dev
491 2007-07-27 Murray Cumming <murrayc@murrayc.com>
493 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
494 Commented out the use of wp_text_buffer_replace_image()
495 because it does not exist, to break the build. Added a TODO for it.
497 2007-07-26 Murray Cumming <murrayc@murrayc.com>
499 * src/modest-tny-account-store.c: (recreate_all_accounts):
500 Recreate them even if they were NULL before. I guess something
501 else was already creating them before, or this would never
503 (modest_tny_account_store_get_server_account): Make sure that
504 the tny accounts have been created before trying to find one.
505 This allows libmodest_dbus_client_compose_mail() to work
506 when the UI is not yet visible.
507 This is probably useful in other cases too.
509 (get_password): When the password is wrong after it is entered
510 in the protected password dialog, show an info banner (in an
511 idle handler) before showing the protected password dialog
514 2007-07-26 Murray Cumming <murrayc@murrayc.com>
516 * src/modest-ui-actions.h:
517 * src/modest-ui-actions.c: Added
518 modest_do_refresh_current_folder() containing some code from
519 modest_ui_actions_on_send_receive().
520 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
521 Call modest_do_refresh_current_folder() before refreshing the
522 requested account, as in modest_ui_actions_on_send_receive().
523 This is strange, but seems to be necessary to show new mails.
524 Now new emails are finally visible in the UI when downloaded
525 via the automatic update interval, fixing bug NB#57458.
526 This also works because bug NB#57458 has been fixed somehow.
528 2007-07-26 Murray Cumming <murrayc@murrayc.com>
530 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
531 printf more details when we get unhandled D-Bus methods, because
534 * src/modest-mail-operation.c: (update_account_thread):
535 Comment out the tny_camel_pop_store_account_reconnect(), because this
536 is apparently no longer needed, and it did not work before anyway.
537 See the comment in the code.
539 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
540 by checking the header flags. This fixes projects.maemo.org bug
543 2007-07-25 Murray Cumming <murrayc@murrayc.com>
545 * src/maemo/modest-maemo-utils.h:
546 * src/maemo/modest-maemo-utils.c: Added
547 modest_maemo_show_information_note_in_main_context_and_forget().
548 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
549 Use the new function to show simple error dialogs in the main
550 context, though question dialogs are still in the current context,
551 which is unfortunately usually not the main context. This should
554 2007-07-25 Murray Cumming <murrayc@murrayc.com>
556 * src/modest-tny-account-store.c: (get_password):
557 Never save the entered username and password in gconf,
558 because the UI spec says we should not. This helps
559 slightly with projects.maemo.org bug NB#63671.
561 2007-07-25 Murray Cumming <murrayc@murrayc.com>
563 * src/widgets/modest-msg-edit-window.h:
564 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
565 Moved some code here to make it simpler.
566 (modest_msg_edit_window_attach_file_one): Renamed from
567 modest_msg_edit_window_attach_file_interactive().
568 (modest_msg_edit_window_offer_attach_file): Renamed from
569 modest_msg_edit_window_attach_file() and used
570 modest_msg_edit_window_attach_file_one() instead of
571 copy/pasting the code. The old code for one was not using
572 GnomeVFS. This allows use of smb:// URLs when using send-as
573 from external applications, fixing bug NB#63741.
575 (modest_msg_edit_window_insert_image),
576 (modest_msg_edit_window_add_attachment_clicked):
577 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
578 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
579 Adapted to the new function names.
581 2007-07-25 Murray Cumming <murrayc@murrayc.com>
583 (modest_platform_set_update_interval): Set the alarm recurrence
584 fields so that auto-update does not just happen the first time.
585 This should have fixed projects.maemo.org bug NB#63938.
587 When this happens you can see a printf when the D-Bus method is
589 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
591 However, I do not actually seem to get new POP messages even when
592 clicking the refresh button manually. A restart gets them.
593 This might be a problem in today's tinymail only.
595 2007-07-24 Murray Cumming <murrayc@murrayc.com>
597 * src/maemo/modest-maemo-global-settings-dialog.c:
598 (current_connection):
599 Avoid a crash (probably only in scratchbox) when strcmp()ing a
600 NULL when closing the dialog.
602 2007-07-24 Murray Cumming <murrayc@murrayc.com>
604 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
605 Remove the hacky send/receive that didn't work, and instead
606 refilter the treemodel to make the deleted email really vanish from
607 the UI (though the delete-from-menu code does has commented out
608 the code that does that). This fixes projects.maemo.org bug
611 2007-07-24 Murray Cumming <murrayc@murrayc.com>
613 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
614 Try a couple of tricks to force the treeview to update (
615 poke the folder, and do a send/receive refresh), but the deleted
616 email still appears with a strike-through instead of really being
619 2007-07-23 Murray Cumming <murrayc@murrayc.com>
621 * src/dbus_api/modest-dbus-callbacks.c:
622 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
623 because their ID is not human-readable (see the comment about
624 improvements needed to the osso-email-interface API) and
625 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
627 2007-07-23 Murray Cumming <murrayc@murrayc.com>
629 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
630 (add_folders_to_list), (on_dbus_method_get_folders),
631 (modest_dbus_req_filter):
632 * src/maemo/modest-maemo-utils.c:
633 (on_camel_account_get_supported_secure_authentication):
634 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
635 (on_header_view_focus_in):
636 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
637 * src/modest-formatter.c: (modest_formatter_create_body_part):
638 * src/modest-mail-operation.c: (recurse_folders),
639 (update_account_thread), (get_msgs_full_thread),
640 (modest_mail_operation_get_msgs_full),
641 (modest_mail_operation_xfer_msgs):
642 * src/modest-search.c: (search_mime_part_and_child_parts),
643 (modest_search_account), (modest_search_all_accounts):
644 * src/modest-tny-account.c:
645 (modest_tny_account_get_special_folder), (recurse_folders):
646 * src/modest-tny-local-folders-account.c:
647 (modest_tny_local_folders_account_query_passes):
648 * src/modest-tny-msg.c: (copy_mime_part),
649 (modest_tny_msg_find_body_part_from_mime_part):
650 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
651 (modest_tny_send_queue_try_to_send):
652 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
653 (_modest_ui_actions_open), (download_uncached_messages),
654 (reply_forward), (modest_ui_actions_on_copy),
655 (modest_ui_actions_on_details), (has_retrieved_msgs),
656 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
658 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
659 (_selected_msg_marked_as), (_msg_download_completed),
660 (_selected_msg_sent_in_progress):
661 * src/widgets/modest-attachments-view.c:
662 (modest_attachments_view_set_message):
663 * src/widgets/modest-msg-view.c: (find_cid_image):
664 * tests/check_folder-transfer.c: (find_folders):
665 * tests/check_update-account.c: (func):
666 * tests/dbus_api/test_get_folders.c: (main):
667 Checked all uses of tny_iterator_get_current(), making sure
668 that the object is unreferenced (3 or 4 places did not),
669 and adding checks for NULL.
671 2007-07-23 Murray Cumming <murrayc@murrayc.com>
673 * src/dbus_api/modest-dbus-callbacks.c:
674 (on_idle_open_default_inbox): Make sure that the application UI is
676 * src/maemo/easysetup/modest-easysetup-wizard.c:
677 (on_entry_invalid_character): Show the word whitespace instead
678 of (null) in the banner when whitespace was entered.
679 (show_error): Add a comment that this does not work in
680 Maemo Bora, though we do not know why.
682 2007-07-23 Murray Cumming <murrayc@murrayc.com>
684 * src/modest-tny-account.c:
685 (modest_tny_account_get_special_folder): Use an if instead of
686 an assert for when the parent account name is NULL, because this
687 might be causing a crash in projects.maemo.org bug 63192.
688 * src/modest-mail-operation.c:
689 (modest_mail_operation_send_new_mail_cb),
690 (modest_mail_operation_remove_folder): unref the folder that is
691 returned from modest_tny_account_get_special_folder().
693 2007-07-23 Murray Cumming <murrayc@murrayc.com>
695 * src/modest-ui-actions.c:
696 (modest_ui_actions_on_password_requested):
697 Show mail_ib_login_cancelled info banner when the user cancels
698 the protected password dialog, to fix projects.maemo.org
701 2007-07-23 Murray Cumming <murrayc@murrayc.com>
703 * src/maemo/modest-account-settings-dialog.c:
704 (create_page_outgoing): Put this page in a GtkScrolledWindow,
705 matching the UI mock-up in the UI spec, and allowing access
706 to all widgets even when the on-screen keyboard is active.
708 2007-07-23 Murray Cumming <murrayc@murrayc.com>
710 Reverted this previous commit from Johannes,
711 because the scrollbars are always visible and because
712 I think we only need it on onepage of the account
713 settings, not the account wizard.
714 (I wrote the wrong instructions in the bug.)
716 * src/maemo/easysetup/modest-easysetup-wizard.c:
717 Added scrollbars to account wizard dialog.
718 Fixed projects.maemo.org NB #62744
720 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
722 * src/maemo/easysetup/modest-easysetup-wizard.c:
723 (create_page_user_details):
724 Use auto-cap for name (projects.maemo.org NB#63716)
725 * src/widgets/modest-account-view.c: (on_account_busy_changed):
727 2007-07-22 Armin Burgmeier <armin@openismus.com>
729 * src/maemo/modest-ui-actions.c: Use current account instead of
730 default account for creating viewer windows, so that the viewer
731 window knows to which account the viewed message belongs.
733 * src/maemo/modest-msg-view-window.c: Destroy the window when the
734 corresponding account is deleted. This fixes projects.maemo.org bug
737 2007-07-18 Armin Burgmeier <armin@openismus.com>
739 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
740 the dialog close after entering an invalid port number and clicking
741 OK. This fixes projects.maemo.org bug NB#63602.
743 2007-07-18 Armin Burgmeier <armin@openismus.com>
745 * src/modest-tny-account-store.c:
746 (get_server_accounts): Set parent modest account name for each
747 connection-specific transport account so that special folders of such
748 an account can be looked up. This fixes a crash when changing account
749 settings. This might also be related to projects.maemo.org bug
752 2007-07-16 Armin Burgmeier <armin@openismus.com>
754 * src/modest-ui-actions.c: Added a button to create a folder to the
755 move-to dialog. This fixes projects.maemo.org bug NB#59863.
757 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
759 * src/maemo/easysetup/modest-easysetup-wizard.c:
760 Added scrollbars to account wizard dialog.
761 Fixed projects.maemo.org NB #62744
763 2007-07-16 Murray Cumming <murrayc@murrayc.com>
765 * src/widgets/modest-msg-view.h:
766 * src/widgets/modest-msg-view.c:
767 Added modest_msg_view_get_message_is_empty() but this needs
769 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
770 Check if there is any text in the message yet.
771 But this needs to be implemented properly.
772 (modest_msg_edit_window_toggle_find_toolbar):
773 * src/maemo/modest-msg-view-window.c:
774 (modest_msg_view_window_toggle_find_toolbar):
775 Show a banner warning if there is no text to search, when
776 trying to start a search. This partially fixes
777 projects.maemo.org bug NB#62350.
779 2007-07-13 Murray Cumming <murrayc@murrayc.com>
781 * src/modest-mail-operation.c: (update_account_thread):
782 Initialized num_new_headers to fix the build.
784 2007-07-13 Murray Cumming <murrayc@murrayc.com>
786 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
787 Ignore modest accounts whose server accounts don't exist in gconf.
788 This prevents us trying to create TnyAccount instances for those
789 server accounts when the server account has been removed from gconf,
790 but the parent modest account has not yet been removed from modest.
791 I don't know why this is only noticeable now. It was probably just
792 a harmeless g_warning() anyway.
794 2007-07-13 Murray Cumming <murrayc@murrayc.com>
796 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
797 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
799 2007-07-12 Armin Burgmeier <armin@openismus.com>
801 * src/maemo/modest-main-window.c: Make default account appear bold
802 in view, tools/send & receive and toolbar/send & receive SCM menus.
803 This fixes projects.maemo.org bug NB#59010.
805 2007-07-12 Murray Cumming <murrayc@murrayc.com>
807 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
808 Add a short-cut, by checking if the folder store is an account.
809 This ensures that the Sort menu item and toolbar is dimmed for
810 the local-folders account root item, fixing
811 projects.maemo.org bug NB#62545.
813 2007-07-12 Murray Cumming <murrayc@murrayc.com>
815 * src/modest-tny-account-store.c: (get_password):
816 Show the password dialog (via the signal) only in the mainloop, via
817 an idle handler that we wait for. This could theoretically prevent
818 hangs, though I worry that it could introduce some too.
820 2007-07-12 Murray Cumming <murrayc@murrayc.com>
822 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
823 * src/maemo/modest-platform.c:
824 (modest_platform_connect_and_wait):
825 Take a TnyAccount* parameter and try to set it to online
826 (a TnyCamel-only API), because tinymail sets accounts to offline
827 when the user cancels a password dialog, and doesn't ask again until
828 it has been set to online.
829 However, this is commented out because it causes a hang now.
831 (modest_platform_connect_and_wait_if_network_account):
832 * src/modest-mail-operation.c:
833 (modest_mail_operation_update_account):
834 * src/modest-platform.h:
835 * src/modest-ui-actions.c: (_modest_ui_actions_open),
836 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
838 2007-07-12 Armin Burgmeier <armin@openismus.com>
840 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
842 * src/modest-mail-operation.c:
843 * src/modest-ui-actions.c: Check for already existing folder before
844 querying the server, show error message from camel if the request
845 still fails. This fixes projects.maemo.org bug NB#58701.
847 2007-07-12 Murray Cumming <murrayc@murrayc.com>
849 * src/modest-tny-account-store.h:
850 * src/modest-tny-account-store.c:
851 Added modest_tny_account_store_forget_password_in_memory(),
852 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
853 when creating a new account, so that new passwords will be used, instead of
854 us thinking that it's a second request as a result of a failed password again.
856 2007-07-12 Murray Cumming <murrayc@murrayc.com>
858 * src/dbus_api/modest-dbus-callbacks.c:
859 (on_idle_open_message): If the message is in drafts then open it
860 in an edit window instead of a view window. This fixes
861 projects.maemo.org bug NB#63005.
863 2007-07-12 Murray Cumming <murrayc@murrayc.com>
865 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
866 Avoided a harmless g_warning().
868 2007-07-12 Murray Cumming <murrayc@murrayc.com>
870 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
871 Pass the modest account name, not the TnyAccount display name to
872 modest_msg_view_window_new() so that the reply feature works,
873 fixing projects.maemo.org bug NB#62892.
875 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
876 (modest_msg_view_window_new_with_header_model):
877 * src/maemo/modest-msg-view-window.c:
878 (modest_msg_view_window_new_with_header_model),
879 (modest_msg_view_window_new):
880 * src/modest-ui-actions.c: (reply_forward):
881 * src/widgets/modest-msg-view-window.h:
882 * src/widgets/modest-window.c: (modest_window_set_active_account):
883 Rename an account parameter to modest_account_name to make this clearer.
885 2007-07-11 Murray Cumming <murrayc@murrayc.com>
887 * src/modest-ui-actions.h:
888 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
889 modest_do_message_delete().
890 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
891 Call modest_do_message_delete(), hoping that this would cause messages
892 to be really deleted from search instead of just marked with strike through.
893 Does not seem to help.
895 2007-07-11 Armin Burgmeier <armin@openismus.com>
897 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
898 priv->reselect to FALSE prior to calling
899 modest_folder_view_select_first_inbox_or_local() to prevent endless
900 recursion and thus a crash on startup.
902 2007-07-11 Armin Burgmeier <armin@openismus.com>
904 * src/maemo/modest-account-settings-dialog.h: Include
905 <gtk/gtknotebook.h> to fix the build (at least for me).
907 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
908 Use "New FolderN" as default suggested name if "New folder" already
909 exists, with N being the first free number, though never exceed "New
910 folder99" in which case we just fall back to "New Folder" even though
911 it already exists. This fixes projects.maemo.org bug NB#58663.
913 2007-07-11 Murray Cumming <murrayc@murrayc.com>
915 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
916 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
917 projects.maemo.org bug NB#62778.
919 2007-07-11 Murray Cumming <murrayc@murrayc.com>
921 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
922 Ignore the wrong (for now) secure-smtp setting in the presets -
923 just default to requiring secure authentication for SMTP, because
926 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
928 * src/widgets/modest-folder-view.c: (filter_row)
929 Do not show drafts folder (see UI specs)
931 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
933 * src/modest-ui-actions.c:
934 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
935 place and also not necessary.
937 * src/widgets/modest-folder-view.c: (filter_row)
938 Guess folder type and hide Sent & Outbox if necessary.
939 Fixed project.maemo.org NB#57328
941 2007-07-11 Murray Cumming <murrayc@murrayc.com>
943 * src/modest-ui-actions.h:
944 * src/modest-ui-actions.c:
945 (modest_ui_actions_on_delete_message):
946 Move some code into a new
947 modest_ui_actions_refresh_message_window_after_delete()
948 function so we can use it from elsewhere.
950 * src/dbus_api/modest-dbus-callbacks.c:
951 (on_idle_delete_message), (on_delete_message): Used an idle
952 handler, as we do for the other D-Bus method handlers.
953 Call modest_ui_actions_refresh_message_window_after_delete()
954 if the deleted message was open in a window. This fixed
955 projects.maemo.org bug NB#62862.
957 2007-07-11 Murray Cumming <murrayc@murrayc.com>
959 * src/modest-main.c: (main): Only show the UI at the start if
960 the showui command line option was given. For instance,
961 run-standalone src/modest showui
962 Otherwise, we wait for the top_application D-Bus method to
963 be sent by hildon-desktop when the application is selected
965 This allows us to run without a UI when osso-global-search
966 uses our D-Bus methods.
968 2007-07-11 Murray Cumming <murrayc@murrayc.com>
970 * src/dbus_api/modest-dbus-api.h: Added a define for a
971 top-application D-Bus method.
972 * src/dbus_api/modest-dbus-callbacks.c:
973 (on_top_application),
974 (modest_dbus_req_handler): Handle the top-application D-Bus
975 method, which might be an undocumented D-Bus signal sent by
976 hildon-desktop when it starts the application from the menu.
977 But I am not sure and I need to test it on the device, because
978 my scratchbox does not have the application in the menu now.
979 This method shows the main window, so that it can be invisible
980 when started, for instance, just for email searching from
983 * src/maemo/modest-main-window.c: (restore_settings),
984 (modest_main_window_new): Do not show the window immediately
985 upon creation. We show it later.
986 * src/modest-widget-memory.c: (save_settings_paned):
987 Try (unsuccessfully) to avoid saving the paned position when
988 it is not even visible.
989 (restore_settings_paned): Do not allow a silly paned position.
990 This seems necessary when not showing the window at first.
992 * tests/dbus_api/Makefile.am:
993 * tests/dbus_api/test_top_application.c: (main): Test for the
996 2007-07-10 Murray Cumming <murrayc@murrayc.com>
998 * src/modest-ui-dimming-rules.c:
999 (modest_ui_dimming_rules_on_new_msg),
1000 (modest_ui_dimming_rules_on_reply_msg),
1001 (modest_ui_dimming_rules_on_delete_msg),
1002 (modest_ui_dimming_rules_on_details),
1003 (modest_ui_dimming_rules_on_view_window_move_to),
1004 (modest_ui_dimming_rules_on_view_previous),
1005 (modest_ui_dimming_rules_on_view_next),
1006 (_invalid_folder_for_purge): Added checks before
1007 casting the window. This looks like an actual
1008 logic error in _invalid_folder_for_purge(), because it
1009 tries to use a ModestMainWindow as a message window.
1011 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1013 * src/maemo/modest-account-settings-dialog.c:
1014 (show_error): Use the same implementation as in
1015 modest-easysetup-wizard.c:
1016 (on_entry_invalid_character): The logical ID contains a %s.
1017 Guessed what it should be.
1018 (on_entry_max), (check_data), (on_response): Adapt to
1019 changed show_error().
1020 (create_page_account_details): Really call
1021 modest_validating_entry_set_func() on the correct widgets.
1022 * src/maemo/easysetup/modest-easysetup-wizard.c:
1023 (on_entry_invalid_character): Fix the logical ID here too.
1024 (create_page_account_details),
1025 (create_page_user_details):
1027 modest_validating_entry_set_func() on the correct widgets.
1029 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1030 Do not try to use the account if it is NULL.
1032 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1034 * src/modest-ui-actions.c: (create_move_to_dialog),
1035 (modest_ui_actions_on_main_window_move_to),
1036 (modest_ui_actions_on_msg_view_window_move_to):
1037 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
1038 (filter_row), (modest_folder_view_show_non_move_folders):
1039 * src/widgets/modest-folder-view.h:
1041 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
1042 the Sent folder yet as it does not report the correct folder type.
1044 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1046 * src/maemo/modest-msg-edit-window.c: (init_window):
1049 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1051 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1052 Take a parent widget instead of a parent window, and
1053 implement this with hildon_banner_show_information() instead.
1054 Non-Maemo builds can just ifdef that there.
1055 This fixed projects.maemo.org bug NB#62766.
1057 (on_entry_invalid_character): Use show_error() again instead
1058 of using hildon directly, and use the _CS() macro to use the correct
1060 (create_account), (check_for_supported_auth_methods), (on_entry_max):
1061 Pass a widget instead od a window to show_error().
1063 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1065 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1066 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
1067 This allows us to show the server name in the error message, fixing
1068 projects.maemo.org bug NB#62904.
1069 Also, use the appropriate logical ID message for the account protocol.
1071 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1073 * src/modest-tny-account-store.c: (on_idle_wrong_password):
1074 A compilation fix, though the build wasn't broken for me.
1076 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1078 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
1079 Do not try to unref a NULL folder store, to avoid a runtime warning.
1080 This seems to happen sometimes when changing accounts settings.
1082 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1084 * src/modest-tny-account-store.c:
1085 (modest_tny_account_store_instance_init),
1086 (modest_tny_account_store_finalize),
1087 (on_account_settings_hide), (on_idle_wrong_password):
1088 Use a GHashTable to ensure that we only show one account settings
1089 dialog per modest account. This avoids us having a dialog open for
1090 both the store and transport accounts, or due to repeated get_password()
1091 calls that shouldn't happen anyway.
1093 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1095 * src/maemo/modest-maemo-utils.c: (on_hide),
1096 (modest_maemo_show_dialog_and_forget): Handle the response, because
1097 the window is not even hidden by default.
1099 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1100 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1101 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1102 which seems to prevent some modality problems.
1104 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1105 Ignore user cancellation errors.
1107 * src/modest-account-mgr-helpers.h:
1108 * src/modest-account-mgr-helpers.c:
1109 Added modest_server_account_get_password() and
1110 modest_server_account_get_has_password() to avoid direct use of
1113 * src/maemo/modest-account-settings-dialog.h:
1114 * src/maemo/modest-account-settings-dialog.c:
1115 (modest_account_settings_dialog_init): Store the notebook so we can
1117 Added modest_account_settings_dialog_switch_to_user_info().
1119 * src/modest-tny-account-store.c:
1120 (get_password): When the password in the account settings is wrong (we think),
1121 show the relevant page of the account settings dialog, in the mainloop.
1122 However, we currently get many of these at once because cancel does not
1124 (forget_password): Do not forget the password
1125 from the account settings, because this causes side-effects when
1126 tinymail seems to call it at strange time, maybe because of how we
1127 are cancelling get_password().
1128 (modest_tny_account_store_alert): Ignore user cancellations.
1130 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1132 * src/maemo/modest-maemo-utils.h:
1133 * src/maemo/modest-maemo-utils.c:
1134 Added modest_maemo_show_information_note_and_forget() for use instead of
1135 gtk_dialog_run() when the response is not needed, to avoid an extra
1136 mainloop which could cause a hang.
1138 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1139 Use the logical IDs for the error message, though they are not
1140 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1141 because gtk_dialog_run() caused a hang here (the window did not close).
1142 This fixes projects.maemo.org bug NB#62646.
1144 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1146 * src/modest-account-mgr-helpers.h:
1147 * src/modest-account-mgr-helpers.c:
1148 Added modest_account_mgr_get_store_protocol().
1150 * src/maemo/modest-account-view-window.c:
1151 (on_delete_button_clicked): Show different warning text depending on
1152 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1153 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1156 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1158 * src/maemo/modest-msg-edit-window.c:
1159 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1160 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1162 2007-07-07 Armin Burgmeier <armin@openismus.com>
1164 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1165 ckdg_ib_maximum_characters_reached from correct package.
1167 * src/modest-ui-actions.c: Show an error message when a folder could
1168 not be created. Tinymail does not give us specific error codes about
1169 what has gone wrong, so we assume that a folder with that name
1170 already exists, though there might be other reasons.
1172 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1174 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1175 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1176 give a more exact error message that can be partly translated.
1178 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1180 * src/maemo/modest-address-book.c:
1181 (select_email_addrs_for_contact): Specify a default window size for the
1182 select-email-address dialog, so that it is probably big enough for the
1183 title. This should fix projects.maemo.org bug NB#62277.
1185 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1187 * src/maemo/easysetup/modest-easysetup-wizard.c:
1188 (create_page_complete_easysetup): Use
1189 gtk_widget_set_size() request to ensure that the text wraps
1192 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1194 * src/maemo/easysetup/modest-easysetup-wizard.c:
1195 (on_entry_invalid_character), (create_page_account_details),
1196 (create_page_user_details):
1197 Use new API of ModestValidatingEntry. But for some reason the banner is
1198 not shown. I will have to investigate that further.
1200 * src/widgets/modest-validating-entry.c: (on_insert_text),
1201 (modest_validating_entry_set_func):
1202 * src/widgets/modest-validating-entry.h:
1203 Added a new callback function to be able to react to prevented
1204 characters whitespaces to e.g show a banner.
1206 2007-07-05 Armin Burgmeier <armin@openismus.com>
1208 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1209 notification of HildonNumberEditor instead of remembering the port
1210 number. Thanks to Johannes for pointing this out.
1212 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1214 * src/maemo/easysetup/modest-easysetup-wizard.c:
1215 Check if there are any user changes before showing a confirmation
1216 dialog (projects.maemo.org NB#60946)
1218 2007-07-05 Armin Burgmeier <armin@openismus.com>
1220 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1221 number at the beginning of the dialog and set the modified flag at the
1222 end if the port number has changed. This is necessary because
1223 HildonNumberEditor does not support notification when the value has
1226 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1228 * src/modest-ui-actions.c:
1229 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1230 a connection before asking anything else. Correct the check for the destination
1231 folder so that it succeeds when online.
1232 This fixed projects.maemo.org bug NB#61645.
1234 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1236 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1237 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1238 to fix projects.maemo.org bug NB#62439.
1240 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1242 * src/modest-tny-account.c: (on_connection_status_changed):
1243 Really do not use tny_device_force_offline() here. See the previous comment.
1245 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1247 * src/modest-tny-account.c: (on_connection_status_changed):
1248 Do not use tny_device_force_offline() when tinymail says that something
1249 went wrong with the connection. It seems to report this unnecessarily.
1251 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1253 * src/maemo/modest-connection-specific-smtp-window.c:
1254 (modest_connection_specific_smtp_window_init):
1255 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1256 does not seem to have any effect in osso 1.1 (though it works in
1257 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1259 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1261 * src/maemo/modest-connection-specific-smtp-window.c:
1262 Fix UI specification problems with projects.meamo.org NB#60479
1264 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1266 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1267 clue when this has failed, because the error dialog is not always shown
1268 (at least in earlier version).
1270 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1271 GError message, because the generic error dialog is not helpful.
1273 'This message is not currently available (can't let a new connection go online)'
1274 when trying to open an IMAP message.
1276 (_modest_ui_actions_open): Offer a connection when some messages would
1277 have to be downloaded and we are offline.
1279 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1281 * src/widgets/modest-folder-view.c:
1282 Don't check for MERGE type anymore as we use the correct type
1284 NOTE: For the last two changes you need to update your tinymail copy
1285 because of API changes!
1287 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1289 * src/modest-tny-local-folders-account.c:
1290 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1291 (see projects.maemo.org NB#61580)
1293 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1295 * src/modest-tny-account.c: (on_connection_status_changed):
1296 Commented out the call to modest_platform_connect_and_wait() because this
1297 seems to always hang, and I would like to know if this is the only thing
1298 that causes a hang when showing the connection dialog.
1299 It is not very useful anyway.
1301 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1303 * src/maemo/modest-msg-view-window.c:
1304 (modest_msg_view_window_select_next_message):
1306 * src/modest-platform.h:
1307 * src/maemo/modest-platform.c:
1308 Added modest_platform_connect_and_wait(), which calls
1309 tny_maemo_conic_device_connect() always in the main thread, by calling it
1310 in an idle handler and waiting for the idle handler to run. It should be
1311 in the main thread because it uses GTK+ UI code. It just returns TRUE
1312 if the device is already online.
1314 There is some nasty code to ensure that subsequent calls to
1315 modest_platform_connect_and_wait() just wait for the first one to finish,
1316 by checking repeatedly in another idle handler. This is necessary,
1317 because other threads (or even the main thread, via another idle handler)
1318 can call modest_platform_connect_and_wait() while
1319 modest_platform_connect_and_wait() is running.
1321 (modest_platform_connect_and_wait_if_network_account),
1322 (modest_platform_connect_and_wait_if_network_folderstore):
1323 Convenience functions that calls modest_platform_connect_and_wait() if
1324 the account or folder might want network access.
1326 * src/modest-mail-operation.c:
1327 (modest_mail_operation_update_account):
1328 * src/modest-ui-actions.c: (download_uncached_messages),
1329 (modest_ui_actions_on_rename_folder), (delete_folder),
1330 (modest_ui_actions_on_main_window_move_to),
1331 (modest_ui_actions_on_msg_view_window_move_to):
1332 * src/widgets/modest-folder-view.c:
1333 (drag_and_drop_from_folder_view):
1334 Offer a connection if we are offline.
1336 * src/modest-tny-account.c: (on_connection_status_changed):
1337 Document this as only handling errors during network operations in progress,
1338 and replace the idle code with a simple call to
1339 modest_platform_connect_and_wait(), which does this instead.
1341 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1343 * src/modest-tny-account.c:
1344 (modest_tny_account_get_special_folder): (util_on_idle),
1345 Handle the GError so we can see when tny_folder_store_get_folders()
1346 fails, as it currently does while something else is connecting.
1348 Added util_run_in_main_thread_and_wait()
1349 which uses an idlen handler and mainloop to ensure that the function
1350 is called in the main thread.
1351 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1352 to make sure that we call attempt the connection in the mainloop only,
1353 which might solve some hangs.
1355 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1357 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1358 be found by their display name. This is never useful.
1359 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1360 by its ID, instead of trying to use its ID as its display name.
1362 * src/modest-tny-account-store.h:
1363 * src/modest-tny-account.c:
1364 (modest_tny_account_get_special_folder): Add a g_warning() when
1365 tny_folder_store_get_folders() returns an empty list for the maildir.
1367 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1368 Add a g_warning() when this returns NULL, because that it not allowed
1371 2007-07-02 Armin Burgmeier <armin@openismus.com>
1373 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1374 note when trying to cancel the wizard. This fixes projects.maemo.org
1377 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1379 * src/modest-tny-account.h:
1380 * src/modest-tny-account.c:
1381 (modest_tny_account_new_from_server_account),
1382 (modest_tny_account_new_from_server_account_name),
1383 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1384 because this must now be set before setting the proto. This is usd in
1385 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1386 warning in camel_session_get_service() caused by
1387 tny_camel_transport_account_prepare().
1389 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1392 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1394 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1396 (modest_connection_specific_smtp_edit_window_init):
1398 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1399 of "changed" for now
1401 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1403 * src/modest-tny-account.c:
1404 (modest_tny_account_new_from_server_account):
1405 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1406 now uses to request a connection when it needs one, and which it uses
1407 to tell us that something is wrong with the connection, so we can force
1408 the accounts offline to prevent further problems.
1410 * src/modest-defs.h:
1411 * src/modest-init.c: (init_default_settings):
1412 * src/modest-mail-operation.c:
1413 (modest_mail_operation_update_account):
1414 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1415 This should not be necessary anymore. Do not set the conf key that
1416 determined this (it was always TRUE and not set anywhere else).
1418 * src/modest-ui-actions.h: Remove unused and unimplemented
1419 modest_ui_actions_on_online_toggle_toggled().
1421 2007-06-29 Murray Cumming <murrayc@murrayc.com
1423 * src/maemo/modest-main-window.c: (connect_signals):
1424 Don't connect to delete_event twice. Maybe this was harmless.
1426 2007-06-29 Murray Cumming <murrayc@murrayc.com
1428 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1429 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1430 Debug output to give some more clue when a folder move is not allowed.
1432 2007-06-28 Murray Cumming <murrayc@murrayc.com
1434 * src/modest-tny-account.c: (on_modest_file_system_info),
1435 (modest_tny_account_get_mmc_account_name):
1436 Always call the callback, without checking whether the name has changed.
1437 * src/widgets/modest-folder-view.c: (strings_are_equal),
1438 (on_model_foreach_set_name), (on_get_mmc_account_name),
1439 (text_cell_data): Compare the name here, and use the name from
1440 the account rather than from the
1441 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1442 if the name was changed after the account was added to the model.
1443 That's a tinymail bug but not one that I want to fix now.
1445 This finally fixes projects.maemo.org bug NB#59301.
1447 2007-06-27 Armin Burgmeier <armin@openismus.com>
1449 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1452 2007-06-27 Murray Cumming <murrayc@murrayc.com
1454 * src/modest-tny-account.h:
1455 * src/modest-tny-account.c:
1456 Added modest_tny_account_get_mmc_account_name(), to set the memory
1457 card name asynchronously for the given account and then notify.
1458 (modest_tny_account_new_for_local_folders): Use this new function instead
1459 of using hildon_file_system_info_async_new() directly.
1461 * src/widgets/modest-folder-view.c: (text_cell_data):
1462 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1463 gtk_tree_model_row_changed() when it is available.
1465 This should fix projects.maemo.org bug NB#59301.
1467 2007-06-27 Murray Cumming <murrayc@murrayc.com
1469 * src/modest-mail-operation.c: (update_account_thread),
1470 (get_msgs_full_thread): Fix typo failures in the revert
1473 2007-06-27 Murray Cumming <murrayc@murrayc.com
1475 * src/maemo/modest-maemo-global-settings-dialog.c:
1476 (idle_select_default_focus):
1477 * src/modest-mail-operation.c: (idle_notify_progress),
1478 (idle_notify_progress_once), (set_last_updated_idle),
1479 (update_account_thread), (get_msgs_full_thread):
1480 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1481 * src/widgets/modest-header-view.c:
1482 (idle_notify_headers_count_changed_destroy),
1483 (idle_notify_headers_count_changed):
1484 Reverted the additions of gdk_threads_enter/leave(), in case this
1485 helps with a startup hang on the device.
1487 2007-06-26 Armin Burgmeier <armin@openismus.com>
1489 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1490 for supported secure authentication methods from server by
1491 gtk_dialog_run(), saving CPU time and a potential race condition.
1493 2007-06-26 Armin Burgmeier <armin@openismus.com>
1495 * src/maemo/modest-maemo-utils.h:
1496 * src/maemo/modest-maemo-utils.c: Added a
1497 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1498 only error code to tell the calling code when the user canceled the
1501 * src/maemo/modest-account-settings-dialog.h:
1502 * src/maemo/modest-account-settings-dialog.c:
1503 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1504 message if the retrieval of secure authentication methods was canceled
1505 by the user. Perform the check before saving anything to configuration
1506 to not end up with half-committed configuration changes, do not show
1507 a "Saving to configuration failed" note when authentication methods
1508 could not be retrieved.
1510 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1513 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1515 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1516 Only return the first level of folders under accounts, because the
1517 osso-global-search UI spec doesn't want the rest.
1518 This fixed projects.maemo.org bug NB#61811.
1520 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1522 * src/modest-tny-account-store.c:
1523 * src/modest-tny-account-store.h:
1524 Added modest_tny_account_is_memory_card_account().
1525 * src/maemo/modest-main-window.c: (create_details_widget):
1526 Show the same information items for the memory card as we show for the
1527 local-folders, to fix projects.maemo.org bug NB#59307.
1529 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1531 * src/modest-tny-account-store.c: (get_password):
1532 Added some checks for NULL to maybe prevent crashes, though I think
1533 it was Philip's last commit that actually prevented the crash here
1534 when creating a first new account.
1535 But the new account is still not usable (no messages are shown)
1536 until a restart of the application.
1538 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1540 * src/maemo/modest-maemo-global-settings-dialog.c:
1541 (idle_select_default_focus):
1542 * src/modest-mail-operation.c: (idle_notify_progress),
1543 (idle_notify_progress_once), (idle_notify_update_account_queue),
1544 (set_last_updated_idle), (update_account_thread),
1545 (notify_get_msgs_full), (get_msgs_full_destroyer),
1546 (get_msgs_full_thread):
1547 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1548 * src/widgets/modest-header-view.c:
1549 (idle_notify_headers_count_changed_destroy),
1550 (idle_notify_headers_count_changed):
1551 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1552 all idle handlers, because some other thread could be blocking
1553 the GDK lock, so that it can do GUI stuff.
1555 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1557 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1558 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1559 (on_idle_send_receive), (on_idle_open_default_inbox):
1560 * src/maemo/modest-msg-edit-window.c:
1561 (modest_msg_edit_window_attach_file_noninteractive):
1562 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1563 to prevent a hang. I don't quite understand why these are necessary,
1564 beause we should already be in the main loop. I guess something outside
1565 of the main loop is taking the lock.
1567 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1568 we are really using URIs, and use files that are more likely to exist.
1570 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1572 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1573 necessary because configure.ac now defines different variables.
1575 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1577 * libmodest-dbus-client/libmodest-dbus-client.c:
1578 * libmodest-dbus-client/libmodest-dbus-client.h:
1579 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1580 libmodest_dbus_client_compose_mail() is what things actually use.
1582 * src/dbus_api/modest-dbus-api.h:
1583 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1584 * tests/dbus_api/Makefile.am:
1585 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1588 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1590 * src/modest-init.c: (modest_init_local_folders):
1591 For memory-card (or other non local-folders) maildir accounts,
1592 always create an Archive folder, so that there is somewhere to put
1593 messages. This should be less confusing, because the user does not need
1594 to guess that the need to create a folder.
1596 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1598 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1599 Fixed icon size by using (50, 50) which is the same as defined by
1602 2007-06-25 Armin Burgmeier <armin@openismus.com>
1604 * src/widgets/modest-window-mgr.c:
1605 * src/modest-init.c:
1606 * configure.ac: Correctly recognize hildon-notify presence and fixed
1607 the build without it being installed.
1609 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1611 * libmodest-dbus-client/libmodest-dbus-client.c:
1612 (libmodest_dbus_client_search): Fix the build. Sorry.
1613 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1614 (reply_forward_cb): Initialize variables to fix the build.
1616 * src/modest-tny-account-store.c:
1617 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1618 comparison (a silly typo) so that email search results can be opened
1619 when there are more than one account.
1621 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1623 * libmodest-dbus-client/libmodest-dbus-client.c:
1624 (libmodest_dbus_client_search),
1625 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1626 instead of 1 second, because the search gets folders and messages from
1627 the server, which can take a long time. When it times out,
1628 osso-global-search will report no results.
1630 We need to specify whether we should search only cached information
1631 (maybe with a user preference), and the osso-email-search-plugin
1632 API should really be improved to allow that option, and to allow results
1633 to be delivered asynchronously in batches.
1635 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1637 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1638 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1639 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1641 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1643 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1644 that is an empty string. D-Bus seems to give us these instead of NULL.
1646 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1648 * src/dbus_api/modest-dbus-callbacks.c:
1649 * src/maemo/easysetup/modest-easysetup-wizard.h:
1650 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1651 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1652 (modest_connection_specific_smtp_edit_window_init):
1653 * src/maemo/modest-maemo-global-settings-dialog.c:
1655 * src/maemo/modest-maemo-utils.c:
1656 (modest_maemo_utils_setup_images_filechooser):
1657 * src/maemo/modest-main-window.c: (create_details_widget):
1658 * src/maemo/modest-msg-edit-window.c:
1659 (modest_msg_edit_window_attach_file_noninteractive),
1660 (modest_msg_edit_window_color_button_change),
1661 (modest_msg_edit_window_set_zoom):
1662 * src/modest-mail-operation.c: (update_account_thread):
1663 * src/modest-tny-account-store.c:
1664 * src/modest-tny-account.c:
1665 * src/widgets/modest-global-settings-dialog.c:
1666 * src/widgets/modest-window.h:
1668 Fixed build on bora!
1670 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1672 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1673 * src/modest-search.c: (modest_search_folder),
1674 (modest_search_all_accounts): Actually search only in the specified folder,
1675 doing a simple match on the folder ID.
1676 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1677 and added some documentation.
1679 2007-06-22 Armin Burgmeier <armin@openismus.com>
1681 * src/maemo/modest-maemo-utils.h:
1682 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1683 modest_maemo_utils_get_supported_secure_authentication_methods.
1685 * src/maemo/easysetup/modest-easysetup-wizard.c:
1686 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1687 one occured, not just "Server does not support secure authentication".
1689 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1691 * src/modest-tny-account-store.c: (get_password):
1692 Restored the call to tny_account_set_user() because Philip seems to have
1693 stopped this from crashing (by not using the freed string). It still does
1694 not work, but now we can test it.
1696 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1698 * src/maemo/modest-msg-edit-window.c: (init_window):
1699 Comment out use of an uninitialzed GtkScrolledWindow variable,
1700 to fix the build and stop a crash. Yet again.
1702 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1704 * src/modest-tny-account-store.c: (get_password):
1705 Remove the call to tny_account_set_user() because this actually crashes.
1706 As mentioned in the last commit, it is known to not work anyway.
1708 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1710 * src/modest-tny-account-store.c: (get_password):
1711 Use tny_account_set_username() to tell tinymail that the username might
1712 have changed too. But tinymail ignores this: see projects.maemo.org
1714 * src/modest-ui-actions.c:
1715 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1716 reset the connection when changing the username, and improve the comments.
1717 Save the changed username to gconf at least, so it is used when Modest is
1720 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1722 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1723 Do not use a query, so that we get all folders, including for POP and
1724 local-folders. They work as search criteria too.
1725 This fixes projects.maemo.org bug NB#57740.
1727 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1729 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1730 Comment out the use of hildon_notification_set_sound() because it is
1731 not declared, to fix the build. Warnings are serious, people.
1733 2007-06-21 Armin Burgmeier <armin@openismus.com>
1735 * src/maemo/modest-maemo-utils.h:
1736 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1737 modest_maemo_utils_get_supported_secure_authentication_methods()
1738 to query authentication methods for a specific user. This should fix
1739 projects.maemo.org bug NB#61369.
1741 * src/maemo/easysetup/modest-easysetup-wizard.c:
1742 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1745 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1747 * libmodest-dbus-client/libmodest-dbus-client.h:
1748 * libmodest-dbus-client/libmodest-dbus-client.c:
1749 (modest_dbus_message_iter_get_search_hit),
1750 (libmodest_dbus_client_search):
1751 Reorganised and commented this.
1752 Removed modest_search_hit_free() from the public API because it
1755 Added libmodest_dbus_client_get_folders() and
1756 modest_folder_result_list_free().
1758 * src/dbus_api/modest-dbus-api.h:
1759 * src/dbus_api/modest-dbus-callbacks.c:
1760 (modest_dbus_req_filter): Commented. Moved most code to
1761 on_dbus_method_search() and added on_dbus_method_get_folders().
1763 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1764 of the extra D-Bus handler.
1766 * tests/dbus_api/Makefile.am:
1767 * tests/dbus_api/test_get_folders.c: New test for
1768 libmodest_dbus_client_get_folders(). This seems to return an empty list
1769 at the moment. That could be the same error that causes the message list
1770 to be empty sometimes.
1771 This should help with projects.maemo.org bug NB#57740.
1773 2007-06-21 Armin Burgmeier <armin@openismus.com>
1775 * src/modest-mail-operation.c: Do not call
1776 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1777 notify the operation's end after having set the status to CANCELED for
1778 the operation queue to listen on. This fixes a deadlock when there
1779 were mail operations in the queue during its finalization.
1781 * src/modest-singletons.c: Reordered uninitialization of the account
1782 manager to happen after the mail operation queue was uninitialized
1783 because the mail operation's in the queue might still try to access
1784 the account manager (see modest_mail_operation_notify_end()). This
1785 fixes a potential crash when terminating the application.
1787 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1789 * src/modest-search.c:
1790 (search_mime_part_and_child_parts): Moved some code here so we
1791 can search recursively in child folders.
1792 (modest_search_folder): Search in the message as a mime part, instead
1793 of just its child mime parts.
1794 (read_chunk), (search_mime_part_ogs):
1795 Check how many bytes were read, to prevent an endless loop.
1796 Searching in message bodies now works. This finishes the fix for
1797 projects.maemo.org bug NB#61007.
1799 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1801 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1802 Add a g_warning when the item is not a folder.
1804 * src/modest-ui-dimming-rules.c:
1805 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1806 when selected item is not a folder (for instance, an account), because
1807 the UI spec only talks about folders.
1808 I am not sure what the UI spec wants, so this might not totally fix
1809 projects.maemo.org bug NB#60794.
1811 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1813 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1814 (load_from_file): Sort the list. The unsorted list would be more noticeable
1815 in non-English locales.
1817 * src/maemo/modest-msg-edit-window.c:
1818 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1819 warning and fix the build.
1821 * src/maemo/modest-progress-bar-widget.c:
1822 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1823 avoid a g_warning, and probably to avoid a crash.
1825 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1827 * src/modest-search.c: (modest_search_folder): Check for a GError
1828 when calling tny_folder_get_headers(), to show that this is not the cause
1831 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1833 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1834 Actually set the body query instead of the subject query.
1836 * src/modest-search.c: (search_mime_part_ogs),
1837 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1838 which would probably cause it to fail if we got this far.
1840 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1841 to simplify the code.
1842 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1843 be causing search-in-body to fail.
1845 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1847 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1849 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1850 Better debug message when the folder cannot be found.
1851 This should help with fixing projects.maemo.org bug #61287.
1852 * src/modest-search.c: (add_hit): Do not leak the furl string.
1854 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1856 * src/modest-ui-actions.c:
1857 (modest_ui_actions_on_folder_selection_changed):
1858 Do not special-case TNY_MERGE_FOLDER here, because
1859 modest_tny_folder_get_account() already does that. This fixes
1860 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1861 shown when the Outbox was selected).
1863 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1865 * libmodest-dbus-client/libmodest-dbus-client.c:
1866 (_dbus_iter_get_string_or_null): Initialize the string variable in
1867 case this helps with Dirk's crash.
1869 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1871 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1872 though it is not implemented yet (this function is maybe not even used),
1873 to avoid breaking ABI in future.
1874 * libmodest-dbus-client/libmodest-dbus-client.c:
1875 (get_attachments_string): Moved some code into this generic function.
1876 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1877 sends email. It is maybe not used.
1878 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1879 (on_send_mail): Use attachments.
1881 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1882 * src/maemo/modest-msg-edit-window.c:
1883 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1884 a filename before using it, to fix projects.maemo.org bug NB#58233.
1886 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1888 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1889 Initialize the continue_download variable to fix the build, and probably
1890 to fix randome behaviour.
1892 2007-06-18 Armin Burgmeier <armin@openismus.com>
1894 * src/modest-tny-send-queue.h:
1895 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1896 the queue so we can later show it in the UI. Replaced
1897 modest_tny_send_queue_msg_is_being_sent() by
1898 modest_tny_send_queue_get_msg_status().
1900 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1902 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1903 gpointer. This probably was not harmful, but just to be sure.
1905 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1907 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1908 Fix the build, but leave the function broken on Bora, because
1909 hildon_uri_action_get_service() does not exist.
1910 osso_uri_action_get_service() does not exist either, it seems.
1912 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1914 * src/modest-tny-account.c:
1915 (modest_tny_account_new_from_server_account):
1916 Uncommented the url debug output again, because it is useful for
1917 debugging, as I said in the comment.
1919 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1921 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1923 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1924 for Mameo Bora, to fix the build.
1926 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1929 Fixed build with hildon < 0.99
1931 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1932 Check if the selected account is busy instead of checking all accounts
1934 * src/modest-account-mgr-priv.h:
1935 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1936 (modest_account_mgr_init), (compare_account_name),
1937 (modest_account_mgr_set_account_busy),
1938 (modest_account_mgr_account_is_busy):
1939 * src/modest-account-mgr.h:
1940 Added busy information to the account manager. It possible to
1941 set an account to busy or not busy now.
1943 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1944 (modest_mail_operation_update_account),
1945 (modest_mail_operation_notify_end):
1946 Set the account to busy/not busy depending on the operation state.
1948 * src/widgets/modest-account-view.c:
1949 (modest_account_view_finalize), (get_last_updated_string),
1950 (update_account_view), (on_account_busy_changed), (init_view):
1951 Show string "Refreshing..." if the account is currently busy.
1953 All this fixes projects.maemo.org bug NB#59711
1955 2007-06-14 Armin Burgmeier <armin@openismus.com>
1957 * src/widgets/modest-attachments-view.h:
1958 * src/widgets/modest-attachments-view.c: Added
1959 modest_attachments_view_has_attachments() and fixed coordinate
1960 transformation in get_att_view_at_coords(). This fixes attachment
1963 * src/widgets/modest-msg-view.c: Make use of
1964 modest_attachments_view_has_attachments() to decide whether to show
1965 attachments in the header.
1967 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1969 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1970 (on_change), (on_combo_security_changed),
1971 (modest_connection_specific_smtp_edit_window_init),
1972 (modest_connection_specific_smtp_edit_window_set_connection),
1973 (modest_connection_specific_smtp_edit_window_is_dirty):
1974 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1975 * src/maemo/modest-connection-specific-smtp-window.c:
1978 Show an comfirmation dialog for the smpt-edit-window if there are
1979 unsaved changes and the user hits cancel.
1980 (projects.maemo.org bug NB#60479)
1982 2007-06-14 Armin Burgmeier <armin@openismus.com>
1984 * src/maemo/easysetup/modest-easysetup-wizard.c:
1985 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1986 address" info in banner instead of node, and select all the text as
1987 per UI spec. This fixes projects.maemo.org bug NB#60550.
1989 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1991 reviewed by: <delete if not using a buddy>
1993 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1994 * src/modest-ui-actions.c: (folder_refreshed_cb):
1996 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1998 * src/widgets/modest-folder-view.c: (filter_row):
1999 Explictly filter out the per-account outbox accounts. I don't know why
2000 these only sometimes show up, but now they should never show up in the UI.
2001 This should fix projects.maemo.org bug NB#60160.
2003 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2005 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
2006 when the toolbar does not exist yet.
2007 * src/modest-widget-memory.c: (save_settings_header_view):
2008 Added g_warnings() to help us to discover when we are trying to set
2009 an empty columns list in gconf.
2011 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2013 * src/modest-init.h:
2014 * src/modest-init.c:
2015 Added modest_init_get_default_header_view_column_ids().
2017 * src/modest-widget-memory.c: (restore_settings_header_view):
2018 Use the new function to get defaults, if the gconf key is empty,
2019 instead of not creating any columns. This seems to fix the
2020 empty right-hand pane problems.
2022 * src/widgets/modest-header-view.h: Improved documentation.
2024 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2026 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2027 Revert the use of the display name as the account name, because this
2028 is generally wrong and would break the code that follows.
2030 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2032 * src/maemo/easysetup/modest-easysetup-wizard.c:
2033 (check_for_supported_auth_methods), (on_before_next),
2036 More correct fix for projects.maemo.org bug NB# 58991
2037 Do not longer accept AUTH_PASSWORD as secure method and choose
2038 correct method when creating the account.
2040 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2042 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2043 Fixed projects.maemo.org bug NB# 58991
2045 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2047 * src/modest-init.c: (modest_init_init_core),
2048 (modest_init_local_folders): Fixed compilation errors.
2050 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2052 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2053 Remove unnecessary lib/include, though it is good in principle when needed.
2055 * src/modest-init.c: (modest_init_one_local_folder),
2056 (modest_init_local_folders):
2057 * src/modest-init.h: Initialize the .modest library for memory cards,
2058 instead of just doing nothing for them. This should allow us to create
2059 folders there, fixing projects.maemo.org bug NB#59297.
2061 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2063 * libmodest-dbus-client/libmodest-dbus-client.c:
2064 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2065 (libmodest_dbus_client_compose_mail),
2066 (libmodest_dbus_client_open_message),
2067 (libmodest_dbus_client_send_and_receive),
2068 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
2070 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
2071 (on_idle_open_message), (modest_dbus_req_handler),
2072 (search_result_to_message), (modest_dbus_req_filter):
2073 * src/modest-search.c: (add_hit), (modest_search_folder),
2074 (modest_search_all_accounts): Improved debug messages.
2076 * tests/dbus_api/test_open_message.c: (main): Improved comments.
2078 * src/modest-tny-account-store.c:
2079 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
2082 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2085 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2087 * src/modest-tny-account-store.c: (get_server_accounts):
2088 Call modest_tny_local_folders_account_add_merged_outbox_folders()
2089 even when there are no accounts, so that the Outbox folder is always
2090 visible. This fixes projects.maemo.org bug NB#60158.
2092 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2094 * src/maemo/modest-main-window.c: (create_details_widget):
2095 Use the mcen_va_never logical ID.
2097 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2099 * src/dbus_api/modest-dbus-api.h:
2100 * src/dbus_api/modest-dbus-callbacks.c:
2101 (on_idle_open_default_inbox), (on_open_default_inbox),
2102 (modest_dbus_req_handler):
2103 Added a new OpenDefaultInbox method.
2105 * libmodest-dbus-client/libmodest-dbus-client.h:
2106 * libmodest-dbus-client/libmodest-dbus-client.c:
2107 Added libmodest_dbus_client_open_default_inbox() to call the new
2108 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2109 though it should maybe be used by a new osso-email-interface function.
2111 * tests/dbus_api/Makefile.am:
2112 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2115 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2117 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2118 NULL, so that the signals get all the keys. This should not actually
2119 change any behaviour because we currently update everything when anything
2122 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2124 * src/widgets/modest-folder-view.c: (text_cell_data),
2125 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2126 (find_inbox_iter): If tinymail tells us that the folder is
2127 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2128 This causes the inbox to be selected at startup, fixing part of
2129 projects.maemo.org bug NB#56305.
2131 * src/modest-ui-dimming-rules.c:
2132 (modest_ui_dimming_rules_on_tools_smtp_servers):
2133 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2134 the SMTP servers menu item.
2135 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2136 that the SMTP Servers menu item is dimmed when there are no accounts,
2137 as a future version of the UI spec will require. This fixes
2138 projects.maemo.org bug NB#56305.
2140 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2142 * src/maemo/modest-maemo-utils.c:
2143 (modest_maemo_utils_get_supported_secure_authentication_methods):
2144 Added label to dialog instead of unreadable title
2146 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2147 (modest_main_window_new):
2148 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2151 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2152 * src/modest-account-mgr.h:
2153 Added method to avoid code duplication
2155 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2156 (modest_ui_actions_on_send_receive):
2157 Use modest_account_mgr_has_accounts
2159 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2161 * src/maemo/easysetup/modest-presets.c:
2162 (modest_presets_get_info_server_security): Do not report secure auth
2164 * src/modest-protocol-info.c: Use the defines for the gconf key names
2165 for secure authentication. This was not working because we were writing
2166 Password and reading password, and the check was case sensitive.
2167 With this, gmail now works for receiving and sending when created via
2170 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2172 * src/maemo/easysetup/modest-presets.c:
2173 (modest_presets_get_info_server_security): Correct the key name for
2174 SecureSmtp, because it seems to be case-sensitive.
2175 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2176 Do not try to get the 0th notebook page if there are 0 pages, to
2177 avoid a g_warning().
2179 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2181 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2182 Prevent use of the new notification feature for now, because it currently
2183 shows one dialog for each new email, which is annoying.
2185 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2187 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2188 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2189 when no country was selected, so that we show the global ones.
2190 * src/maemo/easysetup/modest-presets.c:
2191 (modest_presets_get_providers): Return only the global providers, not
2192 all providers when mmc=0 was requested.
2194 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2196 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2197 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2198 provider ID in the combo.
2200 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2201 Do not show the page numbers, because it would be confusing when we add
2202 the 2 extra pages for the custom setup, when the user chooses the "Other"
2203 provider. This fixes projects.maemo.org bug NB#59028
2205 * src/modest-init.c: (modest_init_init_core),
2206 (modest_init_local_folders):
2207 * src/modest-init.h:
2208 * src/modest-tny-account.c:
2209 (modest_tny_account_new_for_local_folders): Do not create default folders
2210 for the memory card. This should fix projects.maemo.org bug NB#59328.
2212 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2214 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2215 Free the changed_conf_keys string items. They are already freed in the
2216 idle handler if that runs first.
2218 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2220 * src/modest-ui-actions.c:
2221 (modest_ui_actions_on_password_requested): Check that the server name
2222 is not NULL, because I just saw a password dialog with (null) as the
2225 * src/modest-tny-folder.[h|c]: Added
2226 modest_tny_folder_is_memory_card_folder().
2227 * src/modest-ui-dimming-rules.c:
2228 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2229 menu item for memory cards, as per the UI spec (section 7.4). This should
2230 fix projects.maemo.org bug NB#59297.
2232 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2234 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2235 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2236 is another problem with the code, see Murray's comment at line 772)
2238 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2240 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2241 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2242 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2243 (load_from_file), (easysetup_country_combo_box_init),
2244 (easysetup_country_combo_box_get_active_country_ids),
2245 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2246 instead of just one ID, to avoid duplicate country names in the UI.
2248 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2249 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2250 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2251 a single ID, avoiding duplicate providers.
2252 * src/maemo/easysetup/modest-easysetup-wizard.c:
2253 (on_combo_account_country): Adapt to use a list.
2255 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2257 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2258 keys changed in the last X seconds.
2260 * src/modest-account-mgr.h:
2261 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2262 (on_key_change), (modest_account_mgr_class_init),
2263 (modest_account_mgr_init), (modest_account_mgr_finalize):
2264 As the keys are changed, save them in a GSList* and signal that GSList*
2265 further every X seconds, to batch changes, to allow us to do just one
2266 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2267 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2269 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2270 changed signal signature.
2272 * src/modest-conf.c: (modest_conf_set_list),
2273 (modest_conf_on_change): Reenable notification.
2275 (modest_conf_maemo_fake_on_change): Comment out the hack that
2276 notified immediately instead of asynchronously.
2278 * src/widgets/modest-account-view.h:
2279 * src/widgets/modest-account-view.c:
2280 (update_account_view): Select the previously-selected account ID,
2281 if possible. This fixes projects.maemo.org bug NB#56933.
2283 (on_account_changed), (on_account_removed),
2284 (modest_account_view_select_account):
2286 Remove the block/unblock functions
2287 because they were not useful.
2289 * src/maemo/modest-account-view-window.c:
2290 (on_delete_button_clicked), (on_edit_button_clicked),
2291 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2293 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2295 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2296 Improve the error dialog to show Incorrect Account Settings, which seems
2297 clearer, and say that the internal error message (to be removed from the
2298 dialog later) is often misleading.
2299 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2301 * src/modest-tny-account.c:
2302 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2303 URL because this is so useful for debugging on the device.
2305 * src/widgets/modest-serversecurity-combo-box.c:
2306 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2308 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2310 * src/modest-mail-operation.c:
2311 (modest_mail_operation_send_new_mail):
2312 Added a comment about a nasty but apparently harmless message. Details
2313 added to the wiki g_warnings() page.
2315 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2317 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2318 (modest_tny_send_queue_class_init):
2319 Do not use the priv struct because it is empty, to avoid g_warnings
2320 about a non-existant priv struct.
2322 * src/modest-tny-account-store.c:
2323 (modest_tny_account_store_get_server_account),
2324 (modest_tny_account_store_get_transport_account_for_open_connection
2325 ): Do not try to get transport server accounts for local folders,
2326 because they don't have any. This avoids a g_warning().
2328 * src/maemo/modest-main-window.c:
2329 (modest_main_window_notify_send_receive_initied),
2330 (on_configuration_key_changed):
2331 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2332 * src/modest-defs.h:
2333 * src/modest-mail-operation.c:
2334 (modest_mail_operation_update_account):
2335 * src/modest-tny-account-store.h:
2336 * src/modest-tny-account.c:
2337 (modest_tny_account_get_special_folder),
2338 (modest_tny_account_new_for_local_folders),
2339 (modest_tny_account_new_for_per_account_local_outbox_folder):
2340 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2341 * src/modest-tny-local-folders-account.c:
2342 (add_account_folders_to_merged_folder):
2343 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2344 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2345 (modest_ui_actions_on_send):
2346 * src/widgets/modest-folder-view.c: (update_model):
2347 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2348 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2349 modest_tny_account_store_get_tny_account_by_account() to
2350 modest_tny_account_store_get_server_account() to make the code clearer.
2352 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2354 * src/dbus_api/modest-dbus-api.h:
2355 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2356 * src/maemo/modest-msg-edit-window.c:
2357 (modest_msg_edit_window_attach_file_noninteractive):
2358 added g_warning in case the file to be attached does not exist
2359 * tests/dbus_api/test_compose_mail.c: (main):
2360 removed obsolete comment, added generic files as test case
2362 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2364 * src/modest-tny-account-store.c: (get_server_accounts):
2365 Create the local folders account only once, not once for each outbox, and
2366 not only when there are some outboxes.
2368 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2370 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2371 code that is causing a crash at startup. Sergio says that he is fixing this.
2373 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2375 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2376 * src/maemo/modest-account-settings-dialog.c:
2377 (create_page_outgoing),
2378 (modest_account_settings_dialog_set_account_name),
2379 (save_configuration):
2380 - Fixed handling of the "Use secure authentication" toggle to comply with
2381 the ui specification. See also projects.maemo.org bug NB#58400
2383 - Restore the Secure connection setting combo correctly when loading
2386 * src/maemo/modest-maemo-utils.c:
2387 (on_camel_account_get_supported_secure_authentication),
2388 (modest_maemo_utils_get_supported_secure_authentication_methods):
2389 Fixed a crasher if operation is canceled
2391 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2392 (modest_protocol_info_auth_is_secure):
2393 * src/modest-protocol-info.h:
2395 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2396 the sense of the "Use secure authentication" toggle.
2398 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2400 * src/modest-tny-account-store.h:
2401 * src/modest-tny-account-store.c:
2402 Added modest_tny_account_store_get_local_folders_account().
2404 * src/modest-tny-folder.h:
2405 * src/modest-tny-folder.c:
2406 (modest_tny_folder_get_account):
2407 Added this replacement for tny_folder_get_account() which returns
2408 the local-folders account for TnyMergeFolders, to avoid the
2409 warning about the unimplemented get_account_func() vfunc().
2411 (modest_tny_folder_get_rules),
2412 * src/modest-ui-actions.c:
2413 (modest_ui_actions_on_folder_selection_changed):
2414 * src/modest-mail-operation.c:
2415 (modest_mail_operation_remove_folder),
2416 (modest_mail_operation_xfer_folder),
2417 (modest_mail_operation_rename_folder),
2418 (modest_mail_operation_get_msg),
2419 (modest_mail_operation_get_msgs_full),
2420 (modest_mail_operation_remove_msg),
2421 (modest_mail_operation_xfer_msgs),
2422 (modest_mail_operation_refresh_folder):
2423 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2425 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2427 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2428 (modest_server_account_set_security):
2429 * src/modest-defs.h: Add comments explaining that our
2430 UI spec means TLS when it says Normal, so these do not look like errors.
2432 * src/modest-tny-account.c:
2433 (modest_tny_account_new_from_server_account): Use the new tinymail
2434 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2435 for TLS. This should fix projects.maemo.org bug NB#58460.
2437 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2439 * src/maemo/easysetup/modest-easysetup-wizard.c:
2440 (create_account): Correct the position of the gconf sanity check warning.
2441 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2442 of using the g_idle_add() hack, because this does not seem to be necessary
2443 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2444 caused by something other than maemo's gconf.
2445 This fixes projects.maemo.org bug #59022.
2447 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2449 * src/modest-account-mgr-helpers.c:
2450 (modest_account_mgr_get_default_account): Do not check that the account
2451 exists if there is no default account (NULL), to fix a runtime warning.
2453 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2455 * src/widgets/modest-folder-view.c: (update_model):
2456 Do not unref the treemodel before we have finished with it.
2457 This prevents a valgrind warning and an occasional crash at startup.
2459 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2461 * libmodest-dbus-client/libmodest-dbus-client.h:
2462 added libmodest_dbus_client_compose_mail()
2463 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2465 added functions needed for SendAsMail() functionality
2466 * src/maemo/modest-msg-edit-window.c:
2467 (modest_msg_edit_window_attach_file_noninteractive):
2468 non interactively attaching files to message edit window
2469 * src/widgets/modest-msg-edit-window.h:
2470 * tests/dbus_api/Makefile.am:
2471 added test_compose_mail.c
2472 * tests/dbus_api/test_compose_mail.c: (main):
2474 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2476 * src/modest-account-view.c:
2477 Fixed bug projects.maemo.org bug NB#59307
2479 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2481 * src/maemo/easysetup/modest-easysetup-wizard.c:
2482 (get_serverport_incoming), (on_before_next), (create_account):
2483 * src/maemo/modest-account-settings-dialog.c:
2484 (modest_account_settings_dialog_set_account_name):
2485 * src/maemo/modest-maemo-utils.c:
2486 (on_camel_account_get_supported_secure_authentication_status),
2487 (on_camel_account_get_supported_secure_authentication),
2488 (on_secure_auth_cancel),
2489 (modest_maemo_utils_get_supported_secure_authentication_methods):
2491 Implemented security authentication for settings and easysetup.
2493 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2495 * src/maemo/modest-main-window.c: (create_details_widget):
2496 Show the total size for memory card accounts too, instead of showing
2497 the name again. Fixes bug projects.maemo.org bug NB#59307.
2499 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2502 * src/modest-tny-simple-folder-store.c:
2503 * src/modest-tny-simple-folder-store.h: Removed.
2505 * src/modest-tny-local-folders-account.h
2506 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2507 for the local-folders maildir, with an extra TnyMergedFolder containing
2508 the folders of the per-account outbox store accounts.
2509 * src/modest-tny-account-store.c: (get_server_accounts):
2510 Add the outboxes to the special local folders account after creating it.
2512 * src/modest-tny-account.c:
2513 (modest_tny_account_new_for_local_folders): Create the derived
2514 account when creating the main local-folders account.
2516 * src/maemo/modest-main-window.c: (create_details_widget),
2517 (modest_main_window_set_contents_style):
2518 Adapted to the use of the derived account instead of the folder store.
2520 * src/modest-ui-actions.c:
2521 (modest_ui_actions_on_folder_selection_changed):
2522 * src/modest-ui-dimming-rules.c:
2523 (modest_ui_dimming_rules_on_new_folder):
2524 * src/widgets/modest-folder-view.c: (text_cell_data),
2525 (icon_cell_data), (filter_row), (update_model),
2526 (get_cmp_rows_type_pos):
2529 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2530 Do not get the priv struct, because no priv struct has been set,
2531 to avoid a runtime warning.
2533 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2534 #ifelse with #else, to fix a warning, to fix the build.
2537 2007-06-05 Christian Kellner <ckellner@openismus.com>
2539 * libmodest-dbus-client/libmodest-dbus-client.c:
2540 Fix small typo in doc (why do you always see them
2541 AFTER committing stuff?)
2544 2007-06-05 Christian Kellner <ckellner@openismus.com>
2546 * libmodest-dbus-client/libmodest-dbus-client.c:
2547 (libmodest_dbus_client_search):
2548 Initialize hit list with NULL. Also set folder list
2549 to "" if NULL was supplied.
2552 2007-06-03 Christian Kellner <ckellner@openismus.com>
2554 * libmodest-dbus-client/libmodest-dbus-client.c:
2555 (modest_search_hit_list_free):
2556 Make it save to call it with NULL.
2558 * src/dbus_api/modest-dbus-callbacks.c:
2559 * src/modest-search.c:
2560 Return full ModestSearchHits as the search result list not TnyHeader
2561 since can't be around withouth the correspoding TnyFolder.
2563 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2565 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2566 Added currently commented code to check for secure auth
2568 * src/maemo/modest-account-settings-dialog.c: (on_response),
2569 (save_configuration), (show_ok):
2570 Fixed projects.maemo.org bugs NB #59248 and #59251
2572 * src/maemo/modest-maemo-utils.c:
2573 (on_camel_account_get_supported_secure_authentication_status),
2574 (on_camel_account_get_supported_secure_authentication),
2575 (modest_maemo_utils_get_supported_secure_authentication_methods):
2576 * src/maemo/modest-maemo-utils.h:
2577 Moved get_supported_secure_authentication() method here to be able
2578 to use it from easysetup wizard.
2580 * src/modest-pair.c: (on_pair_compare_as_string):
2581 Should compare string with first part of pair and not
2582 strcmp pairs which will crash.
2584 * src/modest-protocol-info.c:
2585 (modest_protocol_info_protocol_is_store):
2586 * src/modest-protocol-info.h:
2587 Added modest_protocol_info_get_auth_protocol_name()
2589 2007-06-03 Armin Burgmeier <armin@openismus.com>
2591 * src/modest-mail-operation.c:
2592 (modest_mail_operation_get_msgs_full): Set priv->account also when
2593 only retrieving a single message. This avoids a crash when canceling
2596 (modest_mail_operation_notify_end): Do not explicitely remove the
2597 operation from the queue but only emit the progress_changed signal.
2598 The queue itself listens to that signal to remove the operation when
2599 it is finished. This reduces coupling and removes a potential deadlock
2600 when modest_mail_operation_notify_end() is called from the queue
2601 itself. If that is a problem performance-wise, I would suggest to
2602 implement a status-changed signal or something.
2604 * src/modest-mail-operation-queue.c: Make sure to never call a
2605 function from another file while the queue is locked. This (hopefully)
2606 fixes another deadlock when exiting the application while retrieving
2609 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2611 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2612 Fixed build if libogs is not available
2614 2007-06-03 Christian Kellner <ckellner@openismus.com>
2616 * libmodest-dbus-client/libmodest-dbus-client.h:
2617 * libmodest-dbus-client/libmodest-dbus-client.c:
2618 (libmodest_dbus_client_delete_message):
2619 Implement deletion of messages (Client side).
2621 (modest_search_hit_free),
2622 (modest_search_hit_list_free):
2623 Utility functions to free the result hits.
2625 * src/dbus_api/modest-dbus-api.h:
2626 * src/dbus_api/modest-dbus-callbacks.c:
2627 (on_delete_message),
2628 (modest_dbus_req_handler):
2629 Implement deletion of messages (Server side).
2631 * tests/dbus_api/test_search.c: (main):
2634 * tests/dbus_api/Makefile.am:
2635 * tests/dbus_api/test_delete_message:
2636 Add little test for the message deletion logic
2638 2007-06-03 Armin Burgmeier <armin@openismus.com>
2640 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2641 when the operation queue was not empty. projects.maemo.org bug
2644 2007-06-03 Armin Burgmeier <armin@openismus.com>
2646 * src/widgets/modest-account-view.c
2647 (on_account_default_toggled): Toggle default account column
2648 explicitely instead of waiting for gconf notification (which is
2649 currently ignored). This should fix projects.maemo.org bug NB#56910
2650 for now. It should probably be removed when gconf notifications are
2653 2007-06-03 Christian Kellner <ckellner@openismus.com>
2655 * libmodest-dbus-client/libmodest-dbus-client.c:
2656 Removed debugging spew.
2658 * src/dbus_api/modest-dbus-callbacks.c:
2659 Added debugging info.
2661 * src/modest-search.c:
2662 (modest_search_all_accounts):
2663 Use tny_account_store_get_accounts () on the account store
2664 to get all accounts which is the way to get all accounts.
2666 * tests/dbus_api/test_search.c: (main):
2667 Make it possible to supply the search term on the command line.
2669 2007-06-03 Christian Kellner <ckellner@openismus.com>
2671 * libmodest-dbus-client/libmodest-dbus-client.c:
2672 * libmodest-dbus-client/libmodest-dbus-client.h:
2673 Implement searching for mesages over raw dbus. (Client side)
2675 * src/dbus_api/Makefile.am:
2676 * src/dbus_api/modest-dbus-api.h:
2677 * src/dbus_api/modest-dbus-callbacks.c:
2678 * src/dbus_api/modest-dbus-callbacks.h:
2679 Search framework (Server side). Also implement on_idle_open_message().
2681 * src/maemo/modest-platform.c: (modest_platform_init):
2682 Prepare for raw dbus/osso rpc interaction.
2684 * src/modest-search.h:
2685 Changed minsize from unspecific guint to guint32.
2687 * src/modest-search.c:
2689 Added strange hack which magically made tnymail work.
2691 (modest_search_folder),
2692 (modest_search_account),
2693 (modest_search_all_accounts):
2694 Implement helper functions to search all accounts, specific account
2697 * tests/dbus_api/Makefile.am:
2698 * tests/dbus_api/test_open_message.c:
2699 Read url to open from commandline.
2701 * tests/dbus_api/test_search.c:
2702 Implement small test for dbus search stuff
2704 2007-06-02 Armin Burgmeier <armin@openismus.com>
2706 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2707 include account type and account title. This fixes projects.maemo.org
2710 * src/maemo/modest-account-view-window.c: Set a title for the window.
2712 2007-06-02 Armin Burgmeier <armin@openismus.com>
2714 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2715 incoming and outgoing server name based on email address and server
2716 types as long as the names have not been edited manually. This fixes
2717 projects.maemo.org bug NB#58671.
2719 2007-06-02 Armin Burgmeier <armin@openismus.com>
2721 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2722 server type cannot be changed in future to the incoming details page
2723 when creating an account. This fixes projects.maemo.org bug NB#59029.
2725 2007-06-02 Armin Burgmeier <armin@openismus.com>
2727 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2728 and assigned max width chars so that they wrap instead of being
2729 truncated. Fixes projects.maemo.org bug NB#56126.
2731 2007-06-02 Armin Burgmeier <armin@openismus.com>
2733 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2734 introductory note to the connection specific smtp servers dialog, as
2735 section 8.12 of the email UI specification requires. This fixes
2736 projects.maemo.org bug NB#59212.
2738 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2740 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2741 Check for running mail operations, and offer to cancel them, as per the UI
2742 spec. This fixes projects.maemo.org bug NB#59041 .
2743 However, I suspect that tinymail may still use the network connection
2744 in ways that we cannot detect or cancel. But it should at least adapt to
2745 changes fairly well.
2747 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2749 * src/modest-tny-account-store.c: (recreate_all_accounts),
2750 (get_cached_accounts), (get_server_accounts): Do more sensible
2751 ref-counting of the temporarily-cached outbox accounts list. This seems
2752 to fix a crash when entering the password when the password was wrong.
2754 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2756 * src/gnome/modest-main-window.c: (connect_signals):
2757 * src/modest-tny-account-store.c: (get_password),
2758 (modest_tny_account_store_alert): Added comments and clues and
2759 commented-out code about how we currently fail to deal with connection
2760 errors and wrong passwords, and how we should.
2762 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2764 * src/widgets/modest-retrieve-combo-box.c:
2765 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2766 This fixes projects.maemo.org bug NB#58472 .
2768 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2770 * src/maemo/easysetup/modest-easysetup-wizard.c:
2771 (create_page_complete_easysetup):
2772 (create_page_complete_custom): Correct the last commit,
2773 putting the correct sentences in the correct pages.
2775 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2777 * src/maemo/easysetup/modest-easysetup-wizard.c:
2778 (create_page_complete_custom): Show the second sentence of text
2779 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2782 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2784 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2785 Set the leave-on-server conf key by default. This fixes
2786 projects.maemo.org bug NB#59258 .
2788 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2790 * src/maemo/modest-account-view-window.c:
2791 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2792 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2795 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2797 * src/maemo/easysetup/modest-easysetup-wizard.c:
2798 (create_caption_new_with_asterisk):
2799 * src/maemo/modest-account-settings-dialog.c:
2800 (create_caption_new_with_asterisk):
2801 Uncomment the code to add the asterisk, because they are no longer in the
2802 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2803 (update_incoming_server_title): Add an asterisk here too.
2805 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2807 * src/maemo/modest-maemo-global-settings-dialog.c:
2808 (current_connection): Check that we are even connected before trying to
2809 get the current connection name, to prevent a warning.
2811 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2812 Change the comments because tny_maemo_conic_device_connect() is now meant to
2814 * src/modest-mail-operation.c:
2815 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2816 make sure we have a connection and fail if we can't connect.
2818 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2820 * src/maemo/modest-main-window.c:
2821 (on_account_store_connecting_finished): Do not try to get the
2822 connection ID if we are not really connected. I am surprised that
2823 this signal handler is called when we are not connected.
2825 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2827 * src/modest-error.h:
2828 * src/modest-ui-actions.c:
2829 (modest_ui_actions_get_msgs_full_error_handler):
2830 Renamed an enum, added comments, added an enum
2831 for retrieve-limit errors.
2833 * src/modest-mail-operation.c: (foreach_add_item),
2834 (internal_folder_observer_update), (update_account_thread),
2835 (modest_mail_operation_get_msgs_full):
2836 (modest_mail_operation_update_account),
2837 Added comments about how this works, and some code that should
2838 (but does not) check the retrieve-limit. See the TODO comment.
2840 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2842 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2843 Initialize help_id to fix the build. Warnings are good.
2845 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2847 * src/widgets/modest-hbox-cell-renderer.c:
2848 (modest_hbox_cell_renderer_append):
2849 * src/widgets/modest-vbox-cell-renderer.c:
2850 (modest_vbox_cell_renderer_append):
2851 Fix the last commit by doing an extra ref.
2853 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2855 * src/widgets/modest-hbox-cell-renderer.c:
2856 (modest_hbox_cell_renderer_append):
2857 * src/widgets/modest-vbox-cell-renderer.c:
2858 (modest_vbox_cell_renderer_append):
2859 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2860 to fix the build with Maemo Bora.
2861 However, there seems to be a remaining crash, probably due to reference
2864 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2866 * src/modest-tny-account.c:
2867 (modest_tny_account_new_for_local_folders):
2868 Use hildon_file_system_info_async_new() to get a better name for
2869 the memory card account, setting it as the account name.
2870 The timing seems to work, but this is probably
2871 not the best place to do this. See the TODO comment.
2872 * src/maemo/modest-main-window.c: (create_details_widget):
2873 * src/widgets/modest-folder-view.c: (text_cell_data):
2874 Use the tny account name instead of hardcoding a name.
2876 2007-05-30 Christian Kellner <ckellner@openismus.com>
2878 * src/modest-search.c: (modest_search):
2879 Correctly set part_search_func even if we have already parsed
2880 the query and thus a valid OgsTextSearcher object.
2882 2007-05-30 Christian Kellner <ckellner@openismus.com>
2885 Search and check for libogs.
2888 Incooparte the ogs build env.
2890 * src/modest-mime-part-search-stream.c:
2891 * src/modest-mime-part-search-stream.h:
2892 Removed since we do the real searching now in modest-search.c.
2894 * src/modest-search.c:
2895 * src/modest-search.h:
2896 Implement support for ogs. We use that if available and requested
2897 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2898 should now handle the corner case when the search term is spread
2899 across multiple reads.
2900 Also the logic in modest_search () was corrected to search all
2901 requested fields until one is found.
2903 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2905 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2907 * src/modest-init.h:
2908 * src/modest-init.c: Made modest_init_local_folders() take a
2909 path and be public so we can iniitialize maildir folders on
2912 * src/modest-local-folder-info.h:
2913 * src/modest-local-folder-info.c:
2914 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2916 * src/modest-tny-account.c:
2917 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2918 still means the standard local-folders path on the local volume.
2920 * src/modest-tny-account-store.c:
2921 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2922 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2923 all accounts when that happens.
2924 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2925 this too, so it shows up in the treeview.
2927 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2929 * src/maemo/modest-maemo-global-settings-dialog.c:
2930 (current_connection):
2931 * src/widgets/modest-global-settings-dialog.c:
2932 (current_connection_default):
2933 Use the enum values instead of 0, 1 and -1,
2934 to make the code clearer.
2936 * src/modest-account-mgr-helpers.c:
2937 (modest_account_mgr_get_connection_specific_smtp): Make this code
2940 * src/modest-runtime.h:
2941 * src/modest-runtime.c:
2942 Added modest_runtime_remove_all_send_queues().
2943 * src/maemo/modest-main-window.c:
2944 (on_account_store_connecting_finished): Recreate the send queues,
2945 using the appropriate transport accounts for this new connection.
2946 Some futher adapting might be needed if the old send queues are not
2947 automatically stopped at this point.
2949 * src/modest-tny-account-store.c: (get_server_accounts):
2950 Create the connection-specific transport accounts, so that they can
2951 be found later by their ID.
2953 * src/modest-tny-account.h:
2954 * src/modest-tny-account.c:
2955 Added modest_tny_account_new_from_server_account_name().
2956 modest_tny_account_new_from_server_account(): Do not create the
2957 send queues here, because they will be
2958 recreated anyway when the connection changes for the first time.
2960 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2962 * src/modest-local-folder-info.h:
2963 * src/modest-local-folder-info.c:
2964 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2965 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2966 tbox_folder): Take a modest account name instead of a server TnyAccount,
2967 so we can have per-modest-account rather than per-transport-account
2969 We must make sure that we change or recreate the exisitng send queues
2970 when the connection changes for connection-specific transport accounts.
2972 * src/modest-tny-account-store.c:
2973 (create_per_account_local_outbox_folders): Create outboxed per modest
2974 account, not per transport account.
2976 * src/modest-tny-account.h:
2977 * src/modest-tny-account.c:
2978 (modest_tny_account_get_special_folder): For outboxes, get the
2979 parent modest account name. The account is ignored for other folders.
2980 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2981 modest account name rather than a server TnyAccount.
2983 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2985 * src/modest-tny-account.c:
2986 (modest_tny_account_new_from_server_account):
2987 Call modest_runtime_get_send_queue() immediately after creating transport
2988 accounts, so that they start trying to send email from the outbox as soon
2989 as possible at startup. This is probably what we want.
2991 * src/modest-mail-operation.c: (update_account_thread):
2992 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2993 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2994 * src/modest-tny-send-queue.h:
2995 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2996 (modest_ui_actions_on_send):
2997 Added comments about how sending works, though it needs some more work.
2999 2007-05-25 Murray Cumming <murrayc@murrayc.com>
3001 * src/modest-tny-account.c:
3002 (modest_tny_account_get_special_folder): Add TODO because this fails when
3003 the network is busy.
3004 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
3005 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
3006 Do not try to show this window when there is no active account. The UI
3007 specs does not tell us what to do in this case.
3009 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3013 * src/maemo/Makefile.am:
3014 * src/widgets/Makefile.am: Some dist fixes.
3016 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3018 * src/maemo/modest-connection-specific-smtp-window.c:
3019 (on_button_edit): Make the code clearer, to prevent a double free.
3021 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3023 * src/maemo/modest-account-settings-dialog.c:
3024 (modest_account_settings_dialog_set_account_name),
3025 Check the connection-specific smtp servers checkbox if there are any.
3027 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3028 (modest_connection_specific_smtp_edit_window_init):
3029 Start with a suitable port number.
3031 * src/modest-account-mgr-helpers.h:
3032 * src/modest-account-mgr-helpers.c: Added
3033 modest_account_mgr_get_has_connection_specific_smtp().
3035 (modest_account_mgr_set_connection_specific_smtp),
3036 (modest_account_mgr_remove_connection_specific_smtp),
3037 (modest_account_mgr_get_has_connection_specific_smtp),
3038 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
3039 connection-specific smtp server accounts in the account, rather than
3040 the server account conf dir.
3042 This fixes bug projects.maemo.org bug NB#58263 .
3044 * src/modest-tny-account-store.c:
3045 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
3046 if there are no server accounts yet, to prevent an infinite loop when there
3047 are no accounts. Document that one must be called before the other.
3049 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3051 * src/modest-account-mgr-helpers.c:
3052 (modest_account_mgr_get_default_account): Make sure that at least
3053 one account is always the default, if there are any enabled accounts.
3054 This is just a sanity check that shouldn't be necessary.
3056 * src/modest-account-mgr-priv.c:
3057 (_modest_account_mgr_account_from_key): Unescape the conf key to
3058 get the real account name. For instance, this is an issue if a space
3059 was in the account name, which can happen because the account name
3060 is generated from the display name.
3061 (_modest_account_mgr_get_account_keyname): Always escape the
3063 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
3064 Unescape the conf keys to get the real account names.
3066 For instance, previously the is-default radio button in the accounts
3067 list was not checked for any accounts at first. This fixes that,
3068 and might fix several similar bugs.
3070 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3072 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
3073 Removed some debug printfs.
3075 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3077 Modest on-disk outbox directories are now here, for instance:
3078 $HOME/.modest/outboxes/<account-id-1>/outbox
3079 $HOME/.modest/outboxes/<account-id-2>/outbox
3081 $HOME/.modest/local-folders/outbox
3082 so we can have a separate outbox for each account.
3083 But they are shown as one outbox in the GtkTreeView, by using a
3084 TnyMergeFolder in a ModestTnySimpleFolderStore.
3087 * src/modest-tny-simple-folder-store.c:
3088 * src/modest-tny-simple-folder-store.h:
3089 Added ModestTnySimpleFolderStore, used to contain folders from
3090 other folder stores, such as other accounts.
3092 * src/modest-tny-outbox-account.h:
3093 * src/modest-tny-outbox-account.c:
3094 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
3095 used for the per-account local outbox folders.
3097 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3098 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3099 only use this (internally) now for the non-outbox local folders.
3101 * src/modest-init.h:
3102 * src/modest-init.c: Added modest_init_one_local_folder(), for
3103 setting up the directory structure for each local folder.
3105 * src/modest-local-folder-info.c:
3106 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3107 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3109 * src/modest-local-folder-info.h:
3110 * src/modest-tny-account-store.c: (on_account_removed),
3111 (on_account_changed), (create_per_account_local_outbox_folders),
3112 (get_server_accounts), (modest_tny_account_store_get_accounts),
3113 (modest_tny_account_store_get_tny_account_by_account),
3114 (modest_tny_folder_store_is_virtual_local_folders):
3116 * src/modest-tny-account.h:
3117 * src/modest-tny-account.c:
3118 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3119 to create an on-disk per-account local outbox folder for each
3121 (create_per_account_local_outbox_folders): Create a local outbox folder
3122 for each transport account.
3123 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3124 for all local folders.
3126 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3127 instead of using g_object_get/set() directly. It is clearer.
3129 (modest_tny_folder_store_get_message_count),
3130 (modest_tny_folder_store_get_local_size
3131 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3132 because we now use these with non-acount folder stores.
3134 (modest_tny_account_get_special_folder),
3135 (modest_tny_account_new_from_server_account),
3136 (modest_tny_account_new_from_account):
3137 (recurse_folders): Adjust to the new outbox system.
3139 * src/modest-tny-folder.h:
3140 * src/modest-tny-folder.c:
3141 (modest_tny_folder_is_local_folder),
3142 (modest_tny_folder_get_local_folder_type),
3143 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3145 * src/widgets/modest-main-window.h:
3146 * src/maemo/modest-main-window.c: (create_details_widget),
3147 (modest_main_window_set_contents_style): Show details for any folder store,
3150 (modest_tny_folder_get_rules):
3151 Remove the const. C does not support constness enough for this.
3153 * src/modest-ui-actions.c:
3154 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3155 make all outboxes appear as one, in the usual local-folders tree node.
3157 (set_active_account_from_tny_account),
3158 (modest_ui_actions_on_folder_selection_changed):
3159 * src/widgets/modest-folder-view.c: (text_cell_data),
3160 (icon_cell_data), (filter_row),
3161 (add_account_folders_to_merged_folder),
3162 (add_account_folders_to_simple_folder_store), (),
3163 (get_cmp_rows_type_pos), (cmp_rows),
3164 (modest_folder_view_set_account_id_of_visible_server_account):
3165 Adjust to the new outbox system, using generic folder stores and folders
3166 in the GtkTreeModel.
3168 2007-05-23 Christian Kellner <ckellner@openismus.com>
3170 * src/modest-mail-operation.c:
3171 (modest_mail_operation_update_account):
3172 Use info->max_size instead of unintialized local var [small
3173 build fix]. (Added TODO to review that change since I don't
3176 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3178 * libmodest-dbus-client/libmodest-dbus-client.c:
3179 (libmodest_dbus_client_compose_mail): function added
3180 * src/dbus_api/modest-dbus-api.h:
3181 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3182 (on_compose_mail): Implementation of the SendAsMail functionality
3184 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3186 * src/modest-account-mgr.c:
3187 (modest_account_mgr_add_server_account): Set the secure-connection
3188 conf key for transport accounts as well as store accounts. I don't know
3189 why the if was there. For instance, this makes sure that we use SSL
3190 for the gmail preset from the easysetup wizard.
3192 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3194 * src/gnome/modest-main-window.c:
3195 (on_account_store_connecting_finished), (connect_signals):
3196 * src/maemo/modest-main-window.c:
3197 (on_account_store_connecting_finished), (connect_signals),
3198 (modest_main_window_new):
3199 Handle TnyAccountStore::connecting-finished instead of
3200 TnyDevice::connection-changed, because we cannot actually perform
3201 operations on accounts until TnyAccountStore has itself responded to
3202 the TnyDevice::connection-changed signal. This prevents a GError from
3204 Do not try to update at startup, because we (at least on scratchbox)
3205 already do an update at startup when the device goes online.
3206 This prevents a GError from tinymail.
3207 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3208 Added TODO about stopping simultaneous operations.
3210 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3212 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3213 * src/modest-mail-operation-queue.c:
3214 (modest_mail_operation_queue_remove):
3215 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3216 about where they happened.
3218 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3220 * src/modest-ui-actions.c:
3221 (modest_ui_actions_on_password_requested): Make sure that the remember
3222 output parameter is always TRUE.
3224 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3226 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3227 Show a OK/Cancel dialog if the error is a question, though we still do not
3228 know anything more about what we are asking the user.
3229 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3230 Fix an uninitialized variable (helper). This is a logic error, however.
3232 2007-05-21 Christian Kellner <ckellner@openismus.com>
3234 * src/modest-search.h:
3235 Correct bit shifting in the ModestSearchFlags enum.
3237 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3239 * src/modest-tny-account.c:
3240 (modest_tny_account_new_from_server_account): Do not use the lsub and
3241 check-all hard-coded IMAP options when using POP.
3243 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3245 * src/modest-tny-account.c:
3246 (modest_tny_account_new_from_server_account):
3247 Use NULL for the secure-auth method for POP when Password auth has been
3248 specified by the user, as we already do for IMAP. "auth=Login" causes
3249 an error from camel or the server.
3251 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3253 * src/maemo/modest-account-settings-dialog.c:
3254 (create_page_account_details),
3255 (modest_account_settings_dialog_set_account_name):
3256 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3257 for the leave-on-server checkbox, rathr than just the checkbox, when
3258 the protocol is not POP.
3260 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3262 * src/widgets/modest-account-view.c:
3263 * src/widgets/modest-account-view.h:
3264 Added modest_account_view_select_account() which will be useful later
3265 to asynchronously re-select the edited account.
3267 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3269 * src/maemo/modest-account-settings-dialog.c:
3270 (modest_account_settings_dialog_set_account_name):
3271 Automatically choose the port numbers based on the secure authentication
3272 methods, if they have not been chosen before.
3273 This fixes projects.maemo.org bug NB#56273 .
3275 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3277 * src/maemo/modest-main-window-ui.h:
3278 * src/modest-ui-actions.c:
3279 * src/modest-ui-actions.h:
3280 Connect the Tools/SMTP Servers menu item to
3281 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3282 SMTP servers dialog, as in the UI specification and saves changes when it
3283 is closed. This fixed projects.maemo.org bug NB#56305 .
3285 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3287 * src/maemo/modest-connection-specific-smtp-window.c:
3288 (modest_connection_specific_smtp_window_init):
3289 Use gtk_window_set_default_size() to make this window big enough, so
3290 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3292 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3294 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3295 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3296 (modest_connection_specific_smtp_edit_window_init),
3297 Do not try to connect to a combobox signal before the combobox exists.
3298 This fixes the cras in projects.maemo.org bug NB#56288 .
3299 (modest_connection_specific_smtp_edit_window_get_settings):
3300 Remove the server_account_name parameter which was being checked for NULL
3301 though it was not used.
3303 * src/maemo/modest-connection-specific-smtp-window.c:
3304 (modest_connection_specific_smtp_window_fill_with_connections),
3305 (on_button_edit), (modest_connection_specific_smtp_window_init):
3306 Correct the number of treemodel columns to prevent a warning.
3307 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3308 libconic does not work.
3310 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3312 * src/modest-tny-account.c:
3313 (modest_tny_account_new_from_server_account):
3314 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3315 SMTP when "None" was chosen by the user. However, with my SMTP server that
3316 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3319 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3321 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3322 to explain the memory management issue with the ID in the ModestPair.
3324 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3325 (add_sending_page), (modest_account_assistant_finalize):
3326 * src/gnome/modest-gnome-global-settings-dialog.c:
3327 (create_updating_page), (create_composing_page):
3328 * src/gnome/modest-msg-edit-window.c: (get_transports),
3329 (init_window), (modest_msg_edit_window_finalize),
3330 (modest_msg_edit_window_get_msg_data):
3331 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3332 * src/gnome/modest-transport-widget.c:
3333 (modest_transport_widget_finalize), (smtp_configuration):
3334 * src/maemo/modest-maemo-global-settings-dialog.c:
3335 (create_updating_page), (create_composing_page):
3336 * src/maemo/modest-msg-edit-window.c: (get_transports),
3337 (init_window), (modest_msg_edit_window_finalize),
3338 (modest_msg_edit_window_get_msg_data),
3339 (modest_msg_edit_window_free_msg_data):
3340 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3341 (modest_store_widget_finalize):
3342 * src/maemo/modest-transport-widget.c:
3343 (modest_transport_widget_finalize), (smtp_configuration):
3344 * src/modest-main.c: (send_mail):
3345 * src/widgets/modest-combo-box.h:
3346 * src/widgets/modest-global-settings-dialog-priv.h:
3347 * src/widgets/modest-global-settings-dialog.c:
3348 (modest_global_settings_dialog_finalize):
3349 * src/widgets/modest-msg-edit-window.h:
3350 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3351 as long as the combo box, to prevent use of freed memory for the ID.
3353 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3355 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3356 get_accounts(), to make this clearer. Do not check for the enabled gconf
3357 key, because we do not use this for server accounts (at least, not yet).
3358 This allows us to send email again.
3360 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3362 * src/maemo/modest-platform.c:
3363 (on_modest_conf_update_interval_changed), (modest_platform_init):
3364 Only respond to this particular key change. All these strcmp()s cannot be
3367 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3369 * src/maemo/modest-maemo-global-settings-dialog.c:
3370 (current_connection): Prevent a crash in scratchbox when
3371 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3372 * src/maemo/modest-platform.c:
3373 (on_modest_conf_update_interval_changed), (modest_platform_init):
3374 Get the update interval from gconf and reset it when the gconf key changes.
3376 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3378 * src/modest-protocol-info.c:
3379 * src/modest-protocol-info.h: Adde enum-specific get functions,
3380 instead of using a ModestProtocolType enum parameter.
3382 * src/gnome/modest-account-assistant.c:
3383 * src/gnome/modest-store-widget.c:
3384 * src/gnome/modest-store-widget.h:
3385 * src/gnome/modest-transport-widget.c:
3386 * src/gnome/modest-transport-widget.h:
3387 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3388 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3389 * src/maemo/easysetup/modest-easysetup-wizard.c:
3390 * src/maemo/modest-account-settings-dialog.c:
3391 * src/maemo/modest-account-settings-dialog.h:
3392 * src/maemo/modest-store-widget.c:
3393 * src/maemo/modest-store-widget.h:
3394 * src/maemo/modest-transport-widget.c:
3395 * src/maemo/modest-transport-widget.h:
3396 * src/modest-account-mgr-helpers.c:
3397 * src/modest-account-mgr-helpers.h:
3398 * src/modest-account-mgr.c:
3399 * src/modest-account-mgr.h:
3400 * src/modest-tny-account.c:
3401 * src/modest-tny-folder.c:
3402 * src/widgets/modest-account-view.c:
3403 * src/widgets/modest-retrieve-combo-box.c:
3404 * src/widgets/modest-retrieve-combo-box.h:
3405 * src/widgets/modest-secureauth-combo-box.c:
3406 * src/widgets/modest-serversecurity-combo-box.c:
3407 * src/widgets/modest-serversecurity-combo-box.h:
3408 * tests/check_account-mgr.c:
3409 Use the specific functions, and use the re-renamed enum values for GNOME too.
3411 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3413 * src/modest-pair.h:
3414 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3415 so we can get the second based on the first.
3417 * src/maemo/modest-account-settings-dialog.h:
3418 * src/maemo/modest-account-settings-dialog.c:
3419 Added get_supported_secure_authentication_methods(), though it is mostly
3420 commented-out for now until the necessary API is committed to tinymail.
3421 (modest_account_settings_dialog_set_account_name),
3422 (save_configuration): Request the supported authentication methods from the
3423 server, so we can choose a working method.
3425 * src/modest-tny-account-store.h:
3426 * src/modest-tny-account-store.c:
3427 (modest_tny_account_store_get_session): Rename from
3428 tny_account_store_get_session().
3430 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3432 * src/modest-protocol-info.h: Split the ModestProtocol enum
3433 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3434 There was no need to have these unrelated values in one enum.
3436 * src/: many files: Adapted to changed enum. This makes the code a bit
3437 clearer, and the compiler could catch some errors.
3439 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3441 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3442 Show the detailed internal camel error message when an error happens
3443 during the configuration, so that our testers can give us more clues.
3444 For instance, in projects.maemo.org bug NB#56910 .
3446 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3448 * src/modest-tny-account.c:
3449 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3450 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3452 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3454 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3455 * src/maemo/modest-account-settings-dialog.c:
3456 (modest_account_settings_dialog_set_account_name),
3457 (save_configuration): For the incoming secure authentication checkbox,
3458 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3459 the UI specification. PLAIN does not seem to be supported for most IMAP
3460 servers anyway, and I am not sure what it would mean.
3461 However, we probably need to discover which of the secure-authentication
3462 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3463 * src/modest-account-mgr-helpers.c:
3464 (modest_account_mgr_get_server_account_data):
3466 * src/modest-tny-account.c:
3467 (modest_tny_account_new_from_server_account):
3468 Use tny_account_set_mech() to set secure-authentication methods,
3469 with some special-casing for IMAP, based on my observations of how
3472 * src/modest-account-mgr-helpers.h:
3473 * src/modest-account-mgr.c:
3474 * src/modest-defs.h: Comment that the URI is only used for local folders.
3476 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3478 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3479 parameter const, just to be neat.
3480 * src/modest-text-utils.c: (modest_text_utils_inline):
3481 End g_strconcat() with NULL, as its documentation says. This is almost
3482 certainly the cause of my crash at startup on the device. Interestingly,
3483 valgrind doesn't tell us about these errors.
3485 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3487 * scripts/build-packages: Added more precise comments about how to use
3488 this script, though I still get this error:
3489 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3490 error building tinymail
3492 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3494 * src/maemo/modest-main-window.c: (on_account_update):
3495 Very slight cleanup, hoping to make it simpler to discover what causes
3496 a crash here sometimes.
3498 * src/modest-tny-account.c:
3499 (modest_tny_account_new_from_server_account): Set the port. Added
3500 comments about the options and a TODO comment because I need to find out
3501 how to specify the secure authentication method.
3503 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3505 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3506 changed CFlags paths form modest to libmodest
3508 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3510 * src/modest-account-mgr-helpers.c:
3511 (modest_account_mgr_get_server_account_data),
3512 (modest_account_mgr_free_server_account_data):
3513 * src/modest-account-mgr-helpers.h:
3514 * src/modest-account-mgr.c:
3515 (modest_account_mgr_add_server_account):
3516 * src/modest-defs.h:
3517 * src/modest-tny-account.c:
3518 (modest_tny_account_new_from_server_account):
3519 Determine the options for tny_camel_account_add_option() here,
3520 based on the settings, rather than storing them directly in gconf.
3522 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3524 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3525 Show a more friendly error dialog now that we expect (from the tinymail
3526 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3528 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3530 * src/maemo/modest-main-window.c: (on_account_update): Check that
3531 account_name is not NULL, to prevent a crash at startup that I am
3532 seeing on the N800. I do wonder why it is NULL.
3534 * src/maemo/easysetup/modest-easysetup-wizard.c:
3535 (create_page_user_details):
3536 * src/maemo/modest-account-settings-dialog.c:
3537 (create_page_user_details), (create_page_outgoing):
3538 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3539 (modest_connection_specific_smtp_edit_window_init):
3540 * src/modest-ui-actions.c:
3541 (modest_ui_actions_on_password_requested):
3542 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3543 might do something useful with the on-screen keyboard.
3545 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3547 * src/maemo/modest-main-window.c: (on_account_update):
3548 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3549 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3551 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3553 * src/modest-tny-account-store.c: (on_account_changed):
3554 Correct the signature of this signal handler.
3556 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3558 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3559 Show a HildonNote instead of a GtkDialog for Maemo.
3561 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3563 * src/widgets/modest-account-view.h:
3564 * src/widgets/modest-account-view.c: (on_account_changed),
3565 (on_account_removed). Added a boolean flag, set/unset by
3566 modest_account_view_block_conf_updates(),
3567 modest_account_view_unblock_conf_updates() to prevent unnecessary
3568 updates, but this is not very useful because the gconf notifications are
3569 so delays (maybe only on Maemo Bora).
3570 So auto-updating is turned off, and these functions do an explicit
3571 update when necessary.
3572 However, something else is still doing too much work when adding/removing
3573 accounts, probably in another part of the application.
3575 * src/maemo/modest-account-view-window.c:
3576 (on_delete_button_clicked), (on_edit_button_clicked),
3577 (on_new_button_clicked): Use the new functions.
3579 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3581 * src/modest-account-mgr-helpers.c:
3582 (modest_account_mgr_set_first_account_as_default):
3583 Sort the list of names alphabetically-by-title, so we choose the first one
3585 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3586 alphabetically by the title.
3588 This fixes projects.maemo.org bug NB#56418 .
3590 * src/modest-account-mgr-priv.c:
3591 (_modest_account_mgr_account_from_key):
3592 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3593 avoid a valgrind error, and possible random behaviour.
3595 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3597 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3598 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3599 tinymail documentation to say that this can be expected.
3600 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3601 pretty, and should not happen, but I would prefer to know when it does.
3603 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3605 * configure.ac: When using the older hildon version, probably on Bora,
3606 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3608 * src/widgets/modest-attachment-view.c:
3609 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3612 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3614 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3615 Implemented the prototype. Can be tested with
3616 tests/dbus_api/test_open_message:
3618 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3620 * src/modest-tny-account-store.c:
3621 (modest_tny_account_store_instance_init), (get_password):
3622 * src/modest-ui-actions.c:
3623 (modest_ui_actions_on_password_requested):
3624 Do not store the password in gconf, because this function is called
3625 for non-remembered passwords. Actually use the cached (in the hash map)
3626 password instead of releasing it.
3627 The password will now not be remembered if it is asked via the protected
3628 password dialog, as per the UI spec.
3630 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3632 * src/modest-defs.h:
3633 * src/modest-account-mgr-helpers.h:
3634 * src/modest-account-mgr-helpers.c:
3635 Added modest_server_account_get_username_has_succeeded(),
3636 modest_server_account_set_username_has_succeeded().
3637 (modest_server_account_set_username),
3638 Reset the has-succeeded flag if the username changes.
3640 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3641 * src/maemo/modest-connection-specific-smtp-window.c:
3642 (modest_connection_specific_smtp_window_save_server_accounts):
3643 Use modest_server_account_set_username() instead of using
3644 modest_conf_set_string() directly, so that the has-succeeded flag is always
3647 * src/modest-ui-actions.c:
3648 (modest_ui_actions_on_password_requested): Dim the username entry if
3649 the username has ever worked, as per the UI spec.
3651 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3653 * src/modest-tny-account-store.c: (get_password):
3654 * src/modest-ui-actions.c:
3655 (modest_ui_actions_on_password_requested):
3656 Allow the username to be changed too, though there is more work to
3657 be done on exactly how this behaves.
3659 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3661 * src/modest-account-mgr-helpers.h:
3662 * src/modest-account-mgr-helpers.c:
3663 Added modest_account_mgr_get_display_name(),
3664 modest_server_account_get_username(),
3665 modest_server_account_set_username(),
3666 modest_server_account_set_password(),
3667 modest_server_account_get_hostname() functions so we do not need to
3668 use the conf API directly.
3670 * src/maemo/modest-main-window.c: (connect_signals):
3671 Actually connect ot the ModestAccountStore::request-password signal,
3672 so that we show the dialog when the password is requested by Tinymail,
3673 for isntance if it is empty.
3675 * src/modest-marshal.list:
3676 * src/modest-tny-account-store.c:
3677 (modest_tny_account_store_class_init), (get_password),
3678 (modest_tny_account_store_alert):
3679 * src/modest-tny-account-store.h:
3680 * src/modest-ui-actions.h:
3681 * src/modest-ui-actions.c:
3682 (modest_ui_actions_on_password_requested):
3683 Change the signal parameters, so it is obvious that we are providing
3684 the non human-readable server name, and receiving both the username
3685 and password, though changing of the username is not yet implemented.
3686 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3687 for the GNOME version.
3689 This should fix the projects.maemo.org bug NB#56209, though it does not
3690 work on Bora, because the gconf_client_get() for the password fails
3691 immediately after we save it with gconf_client_set().
3693 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3696 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3697 caused an undefined symbol error:
3698 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3700 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3702 * src/modest-tny-account-store.c:
3703 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3704 using a GError instead of a string message, so we can translate it in
3707 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3709 * src/maemo/modest-address-book.c:
3710 (modest_address_book_check_names):
3711 * src/maemo/modest-msg-view-window.c:
3712 (modest_msg_view_window_clipboard_owner_change):
3713 * src/modest-init.c: (modest_init_init_ui):
3714 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3715 (update_folders_cb), (modest_mail_operation_update_account):
3716 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3717 (modest_ui_actions_on_msg_attachment_clicked),
3718 (modest_ui_actions_on_msg_recpt_activated):
3719 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3720 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3721 (modest_msg_view_search_next):
3722 * src/widgets/modest-recpt-editor.c:
3723 (modest_recpt_editor_on_button_release_event),
3724 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3725 g_message(). At this point we should only be seeing interesting errors on
3726 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3728 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3730 (modest_wizard_dialog_force_title_update):
3731 * src/maemo/easysetup/modest-wizard-dialog.h:
3732 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3733 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3734 can update the title when appropriate. Otherwise the title is wrong if the
3735 pages are added after adding the notebook to the dialog.
3736 This must be a problem in HildonWizardDialog too.
3737 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3739 * src/maemo/easysetup/modest-easysetup-wizard.c:
3740 (create_subsequent_customsetup_pages),
3741 (create_subsequent_easysetup_pages):
3742 Call modest_wizard_dialog_force_title_update() so that the title is
3743 correct even with GTK+ < 2.10.
3744 This fixes projects.maemo.org bug NB#56145 .
3746 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3748 * src/maemo/modest-platform.c:
3749 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3750 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3753 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3755 * src/widgets/modest-window.h:
3756 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3757 and modest_window_save_state(), which invokes it.
3759 * src/widgets/modest-window-mgr.h:
3760 * src/widgets/modest-window-mgr.c:
3761 Added modest_window_mgr_save_state_for_all_windows(), which calls
3762 the save_state vfunc on all registered windows, if implemented.
3764 * src/gnome/modest-msg-edit-window.c:
3765 * src/gnome/modest-msg-view-window.c:
3766 * src/maemo/modest-msg-edit-window.c:
3767 * src/maemo/modest-msg-view-window.c:
3768 * src/maemo/modest-main-window.c:
3769 Specify the existing save_settings functions as implementations of
3770 ModestWindow::save_state_func().
3772 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3773 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3774 enabling hibernation, for instance.
3776 We may need to do the same thing for restoring settings.
3779 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3781 * src/widgets/modest-window-mgr.c:
3782 * src/widgets/modest-window-mgr.h:
3783 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3784 modest_window_mgr_get_hibernation_is_prevented().
3786 * src/maemo/modest-main-window.c:
3787 (on_hildon_program_is_topmost_notify): Prevent hibernation
3788 (possible when the application goes to the background in the WM),
3789 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3791 * src/maemo/easysetup/modest-easysetup-wizard.c:
3792 (modest_easysetup_wizard_dialog_init):
3793 * src/maemo/modest-account-settings-dialog.c:
3794 (modest_account_settings_dialog_init):
3795 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3796 (modest_connection_specific_smtp_edit_window_init):
3797 * src/maemo/modest-connection-specific-smtp-window.c:
3798 (modest_connection_specific_smtp_window_init):
3799 * src/maemo/modest-signature-editor-dialog.c:
3800 (modest_signature_editor_dialog_init):
3801 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3802 prevent hibernation while any of these account settings dialogs are open.
3804 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3806 * src/maemo/Makefile.am:
3807 * src/maemo/modest-osso-state-saving.c:
3808 * src/maemo/modest-osso-state-saving.h: Added
3809 modest_osso_load_state() and modest_osso_save_state() though they do
3810 nothing now. They should iterate through all the open windows and load/save
3812 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3813 save state when closing.
3815 * src/maemo/modest-main-window.c:
3816 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3817 Add a notification handler for the HildonProgram::is-topmost property,
3818 so we can allow hibernation when the application goes into the background.
3819 But we still need to detect when the accounts setup windows are open so
3820 we can stop hibernation when they are open.
3821 To do this, I also added the main window the HildonProgram. This might have
3822 other side-effects/benefits, and should maybe be done for other windows.
3824 * src/maemo/modest-osso-autosave-callbacks.h:
3825 * src/maemo/modest-osso-autosave-callbacks.c:
3826 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3827 though it does not do anything yet, and we might never need this to do
3828 anything. For instance, we already save drafts.
3830 * src/maemo/modest-platform.c: (modest_platform_init):
3831 Specify the libosso auto-save callback.
3833 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3835 * src/maemo/modest-platform.c:
3836 (modest_platform_set_update_interval):
3837 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3838 aparently stays valid between application instances, so we can use this
3839 to remove and reset it later. According to a maemo-developers email from
3842 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3844 * configure.ac: Depend on libalarm for Maemo.
3846 * src/dbus_api/modest-dbus-api.h:
3847 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3848 (on_send_receive), (modest_dbus_req_handler):
3849 Handle a SEND_RECEIVE D-Bus method.
3851 * libmodest-dbus-client/libmodest-dbus-client.c:
3852 (libmodest_dbus_client_send_and_receive):
3853 * libmodest-dbus-client/libmodest-dbus-client.h:
3854 Add C convenience functions for calling the new D-Bus method.
3856 * src/modest-platform.h:
3857 * src/gnome/modest-platform.c:
3858 * src/maemo/modest-platform.c:
3859 Added modest_platform_set_update_interval(), which uses the
3860 alarmd API on Maemo.
3861 (modest_platform_init),
3862 Call modest_platform_set_update_interval(), using a hard-coded
3863 interval for now (until the global settings dialog is implemented),
3864 though I am not sure that this makes sense yet.
3866 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3868 * src/dbus_api/modest-dbus-callbacks.c:
3869 (modest_osso_cb_hw_state_handler):
3870 * src/dbus_api/modest-dbus-callbacks.h:
3871 * src/maemo/modest-platform.c: (modest_platform_init):
3872 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3873 in case this has some effect on the ability for Maemo to ping the
3876 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3878 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3879 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3880 warning. It is probably a logic error, but I need to fix the build.
3882 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3884 * src/modest-account-mgr.h:
3885 * src/modest-account-mgr.c:
3886 (modest_account_mgr_account_names): Add a gboolean enabled_only
3887 parameter, so we can get lists of onlt the enabled accounts.
3889 (modest_account_mgr_add_account),,
3890 (modest_account_mgr_account_with_display_name_exists):
3891 * src/maemo/modest-msg-edit-window.c: (get_transports):
3892 * src/modest-account-mgr-helpers.c:
3893 (modest_account_mgr_set_first_account_as_default):
3894 * src/modest-init.c: (init_default_account_maybe):
3895 * src/modest-tny-account-store.c: (get_accounts):
3896 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3897 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3898 * tests/check_account-mgr.c: (START_TEST):
3899 Provide the extra parameter, as appropriate.
3901 * src/widgets/modest-account-view.c: (update_account_view):
3902 Do not show disabled accounts (meaning that there is no way to
3903 enable/disable accounts in the UI (the feature is not in our UI
3904 specification), so we can use this internally only to mark unfinished
3905 or temporary account data.
3907 * src/maemo/easysetup/modest-easysetup-wizard.c:
3908 (create_account): Add boolean enable parameter, so we can specify FALSE
3909 to create the temporary account.
3910 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3911 (on_before_next): When finishing, when there is a temporary account, just
3913 Also, use a timeout to delay the showing of the dialog until gconf is likely
3914 to return correct information, due to a maemo gconf bug that is fixed in
3915 osso 1.1, but not yet in Bora.
3916 However, the dialog stays on screen after it is destroyed.
3918 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3919 for invalid data when cancelling. Use a hildon note instead of a dialog
3920 to complain about invalid data. Do not show the account-saved note if the
3921 account is disabled (a temporary account that will not really be saved for use
3924 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3926 * src/modest-account-mgr-helpers.h:
3927 * src/modest-account-mgr-helpers.c:
3928 Added modest_account_mgr_unset_default_account(),
3929 Added modest_account_mgr_set_first_account_as_default().
3931 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3932 If it was the default account, unset the default account name.
3934 * src/maemo/modest-account-view-window.c:
3935 (on_delete_button_clicked): If it was the default account,
3936 set the first remaining account as the default instead.
3938 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3939 a NULL account or a NULL default account, to prevent a crash. This should
3940 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3943 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3945 * src/widgets/modest-recpt-editor.c:
3946 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3947 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3948 TODO comment for this. This fixes the build.
3950 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3951 be the best place for it. This will in future update all auto-update accounts,
3952 rather than just the current/default account, when that gconf key exists.
3953 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3954 if there are no accounts, before calling do_send_receive().
3955 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3957 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3958 * src/maemo/modest-main-window-ui.h:
3959 * src/maemo/modest-main-window.c: (on_connection_changed),
3960 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3961 directly, becaue the signal handler does more.
3963 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3965 * src/modest-account-mgr-helpers.c:
3966 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3967 for the case that the account does not exist.
3969 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3970 (equivalent to the modest account name) rather than the tinymail account name
3971 (equivalent to the modest account title - human readable) to get the account data.
3972 Check for null account data to prevent the crash, and add a TODO comment saying that
3973 this needs fixing because it is using the server account name instead of the account name.
3975 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3977 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3978 * src/maemo/modest-account-settings-dialog.c: (show_error),
3980 Use hildon_note_new_information() for informative and error messages,
3981 which seems to be expected for Maemo applications (no documentation that I know of
3982 says this). I am surprised that there is no distinction between info and error
3985 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3987 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3988 it is easy to find where this is used.
3990 * src/maemo/easysetup/modest-easysetup-wizard.c:
3991 (create_page_welcome), (create_page_account_details),
3992 (create_page_user_details), (create_page_complete_easysetup),
3993 (create_page_custom_incoming), (create_page_custom_outgoing),
3994 (create_page_complete_custom):
3995 * src/maemo/modest-account-settings-dialog.c:
3996 (create_page_account_details), (create_page_user_details),
3997 (create_page_incoming), (create_page_outgoing):
3998 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3999 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4000 (modest_connection_specific_smtp_edit_window_init):
4001 * src/maemo/modest-connection-specific-smtp-window.c:
4002 (modest_connection_specific_smtp_window_init):
4003 * src/maemo/modest-signature-editor-dialog.c:
4004 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
4005 and scrolling policy as per the Email Application Layout Guide, if I have
4008 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4010 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
4011 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
4012 which were empty, because these vfuncs have been removed from TnyAccountStore.
4013 This fixes the build.
4015 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4017 * src/maemo/modest-main-window.c:
4018 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
4019 showing/hiding it. Added TODO because it probably should not be NULL.
4020 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
4021 because unnecessary g_warnings() make degugging difficult.
4023 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4025 * src/maemo/modest-msg-edit-window.c:
4026 (modest_msg_edit_window_select_color),
4027 (modest_msg_edit_window_select_background_color): 2 const corrections and
4028 moving 2 #endifs before closing brackets, to fix the build.
4030 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4032 * src/maemo/easysetup/modest-easysetup-wizard.h:
4033 * src/maemo/easysetup/modest-easysetup-wizard.c:
4034 (modest_easysetup_wizard_dialog_finalize),
4035 (on_button_edit_advanced_settings), (create_page_complete_custom),
4036 (on_response), (create_account):
4037 Implement the Advanced Settings edit button, by saving the account information,
4038 for the Advanded Settings dialog to use directly from gconf, and removing it
4039 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
4040 Bug #5533 in the projects.maemo.org bugzilla.
4042 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4044 * src/maemo/modest-msg-view-window.c:
4045 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
4046 when opening a message window.
4048 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4050 * src/maemo/easysetup/modest-easysetup-wizard.c:
4051 (create_page_custom_outgoing): Correct the position of the horizontal separator to
4054 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
4055 before showing/hiding them, to avoid a crash when clicking on folders when there are no
4056 gconf settings. I probably added more checks than necessary, but that is safer.
4058 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
4059 variable to fix the build, but this seems to be used when it is still NULL.
4061 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4063 * src/modest-platform.h:
4064 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
4065 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
4066 * src/modest-main.c: Implement this function so we can avoid using
4067 maemo-specific API from cross-platform code.
4069 * src/modest-tny-account-store.c:
4070 (get_smtp_specific_transport_account_for_open_connection):
4071 * src/modest-ui-actions.c: (check_for_connection),
4072 (modest_ui_actions_on_item_not_found):
4073 Use modest_platform_connect_and_wait() and put #idefs around other
4074 maemo-specific code, because only maemo currently has a way to
4075 identify connection names.
4077 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4079 * src/modest-tny-account-store.h:
4080 * src/modest-tny-account-store.c:
4081 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
4082 the connection-specific SMTP server settings in the configuration.
4084 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
4086 * src/maemo/modest-main-window.c: (on_connection_changed),
4088 * src/modest-main.c: (main), (start_ui), (send_mail):
4089 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
4090 that is what is intended.
4092 * src/modest-ui-actions.c: (action_send), (action_receive),
4093 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
4094 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
4095 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4096 SMTP server is used when it is specified.
4098 (modest_ui_actions_on_send_receive):
4099 Check that a connection is open before proceeding.
4100 Receive and then send, instead of vice-versa, as per the specification.
4102 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4104 * src/modest-mail-operation.c:
4105 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4106 though I guess it should be something other than NULL.
4108 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4110 * src/maemo/easysetup/modest-easysetup-wizard.c:
4111 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4112 combo twice, to avoid an g_warning and to make it visible again.
4113 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4114 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4115 (already intended) dereference when detaching, because we then recreate the menu.
4116 But I am not sure why the warning was happening, and it is possible that this is a memory
4119 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4121 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4122 and uri_parse_mailto() utility functions.
4123 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4125 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4127 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4129 * src/dbus_api/modest-dbus-api.h:
4130 * src/dbus_api/modest-dbus-callbacks.c:
4131 Use an idle callback to execute the modest code in the application's own thread.
4132 Remove the helloworld example method.
4133 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4134 parsed, and the open-message method is not implemented because this is not yet implemented in
4136 * libmodest-dbus-client/libmodest-dbus-client.c:
4137 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4138 (libmodest_dbus_client_open_message):
4139 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4141 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4142 body without crashing.
4144 * tests/dbus_api/Makefile.am:
4145 * tests/dbus_api/test_mail_to.c:
4146 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4148 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4150 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4151 Added file to fix the build. Sorry.
4153 * src/dbus_api/Makefile.am:
4154 * src/dbus_api/modest-dbus-api.h:
4155 * src/dbus_api/modest-dbus-callbacks.h:
4156 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4157 (modest_dbus_req_handler):
4158 Put constants in a separate header so it can be reused by the
4159 client library, without duplication
4161 * libmodest-dbus-client/Makefile.am:
4162 * libmodest-dbus-client/libmodest-dbus-client.c:
4163 (libmodest_dbus_client_call_helloworld),
4164 (libmodfest_dbus_client_send_mail),
4165 (libmodfest_dbus_client_mailto),
4166 (libmodfest_dbus_client_open_message):
4167 * libmodest-dbus-client/libmodest-dbus-client.h:
4168 (Partly) Implement a send_mail D-Bus method.
4170 * tests/dbus_api/Makefile.am:
4171 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4172 the send_email D-Bus method.
4174 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4178 * libmodest-dbus-client/Makefile.am:
4179 * libmodest-dbus-client/libmodest-dbus-client.c:
4180 * libmodest-dbus-client/libmodest-dbus-client.h:
4181 * tests/dbus_api/Makefile.am:
4182 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4183 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4185 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4187 * src/maemo/easysetup/modest-easysetup-wizard.c:
4188 (create_page_account_details):
4189 * src/maemo/modest-account-settings-dialog.c:
4190 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4191 widgets, because this might not be the default in future versions of the Maemo GTK+.
4192 However, I can not not get capitalization to work even in a simple test case.
4194 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4196 * src/maemo/easysetup/modest-easysetup-wizard.c:
4197 (create_page_custom_incoming), (create_page_custom_outgoing):
4198 * src/maemo/modest-account-settings-dialog.c:
4199 (create_page_account_details), (create_page_incoming),
4200 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4201 instead of using gtk_check_button_with_label(), so they are aligned like the other
4202 widgets, as per the UI spec.
4204 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4206 * src/maemo/easysetup/modest-easysetup-wizard.c:
4207 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4208 * src/widgets/modest-validating-entry.c:
4209 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4210 Modest prefix instead of an EasySetup prefix.
4212 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4214 * src/widgets/modest-validating-entry.h:
4215 * src/widgets/modest-validating-entry.c: (on_insert_text),
4216 Added easysetup_validating_entry_set_max_func(), used to set a callback
4217 to call when the max number of characters is reached. GtkEntry has a max-length
4218 already but is silent about it.
4220 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4221 (create_page_account_details), (create_page_user_details),
4223 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4224 (create_page_account_details), (create_page_user_details),
4225 (create_page_outgoing):
4226 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4227 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4228 the UI spec, when the user tries to enter more than the max number of characters.
4230 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4232 * src/maemo/easysetup/modest-easysetup-wizard.c:
4233 (create_page_user_details), (create_page_custom_incoming),
4234 (create_page_custom_outgoing):
4235 * src/maemo/modest-account-settings-dialog.c:
4236 (create_page_user_details), (create_page_incoming),
4237 (create_page_outgoing):
4238 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4239 (modest_connection_specific_smtp_edit_window_init):
4240 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4241 not appropriate. Bad Maemo-specific defaults!.
4243 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4245 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4246 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4247 (modest_signature_editor_dialog_set_settings):
4248 Disable the label and textview when the checkbox is disabled, and use the
4249 specified (UI spec) default signature text.
4251 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4253 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4254 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4256 * src/modest-defs.h:
4257 * src/modest-account-mgr-helpers.h:
4258 * src/modest-account-mgr-helpers.c:
4259 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4261 * src/maemo/Makefile.am:
4262 * src/maemo/modest-signature-editor-dialog.c:
4263 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4266 * src/maemo/modest-account-settings-dialog.h:
4267 * src/maemo/modest-account-settings-dialog.c:
4268 (modest_account_settings_dialog_finalize), (on_button_signature),
4269 (save_configuration): Use the new dialog when the Edit button is pressed, and
4270 save the changes if necessary, as per the UI spec.
4272 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4274 * src/maemo/Makefile.am:
4275 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4276 based on maemo-develoers email from Dirk.
4278 * src/maemo/easysetup/modest-easysetup-wizard.c:
4279 (create_page_welcome), (create_page_account_details),
4280 (create_page_user_details), (create_page_complete_easysetup),
4281 (create_page_custom_incoming), (create_page_custom_outgoing),
4282 (create_page_complete_custom),
4283 (modest_easysetup_wizard_dialog_init):
4284 * src/maemo/modest-account-settings-dialog.c:
4285 (create_page_account_details), (create_page_user_details),
4286 (create_page_incoming), (create_page_outgoing),
4287 (modest_account_settings_dialog_init):
4288 * src/maemo/modest-connection-specific-smtp-window.c:
4289 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4291 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4293 * src/maemo/easysetup/modest-easysetup-wizard.c:
4294 (create_page_account_details), (create_page_custom_outgoing),
4295 (create_page_complete_custom):
4296 * src/maemo/modest-account-settings-dialog.c:
4297 (create_page_user_details), (create_page_incoming),
4298 (create_page_outgoing):
4299 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4300 (modest_connection_specific_smtp_edit_window_init):
4301 Use the correct (UI spec) port min/max, and use horizontal separators,
4304 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4306 * src/maemo/easysetup/modest-easysetup-wizard.c:
4307 (set_default_custom_servernames):
4308 * src/maemo/modest-account-settings-dialog.c:
4309 (create_page_incoming), (on_combo_outgoing_security_changed),
4310 (on_combo_incoming_security_changed), (create_page_outgoing),
4311 (modest_account_settings_dialog_set_account_name),
4312 (save_configuration):
4313 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4314 (on_combo_security_changed),
4315 (modest_connection_specific_smtp_edit_window_init),
4316 (modest_connection_specific_smtp_edit_window_set_connection),
4317 (modest_connection_specific_smtp_edit_window_get_settings):
4318 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4321 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4324 * src/maemo/easysetup/modest-easysetup-wizard.c:
4325 (create_page_custom_outgoing), (create_page_complete_custom):
4326 * src/maemo/modest-account-settings-dialog.c:
4327 (create_page_user_details), (create_page_outgoing):
4328 * src/maemo/modest-account-view-window.c: (button_box_new):
4329 Use changed logical IDs as per the most recent UI spec:
4330 mcen_bd_emailsetup_edit -> mcen_bd_edit
4331 mcen_bd_emailsetup_delete -> mcen_bd_delete
4332 mcen_bd_emailsetup_close -> mcen_bd_close
4334 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4338 * src/dbus_api/Makefile.am:
4339 * src/dbus_api/modest-dbus-callbacks.c:
4340 * src/dbus_api/modest-dbus-callbacks.h:
4341 * src/maemo/modest-platform.c: (modest_platform_init):
4342 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4344 * tests/Makefile.am:
4345 * tests/dbus_api/Makefile.am:
4346 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4348 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4350 * src/maemo/modest-account-settings-dialog.c:
4351 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4352 Removed unnecessary includes.
4354 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4356 * src/maemo/easysetup/modest-easysetup-wizard.c:
4357 * src/maemo/modest-account-settings-dialog.c:
4358 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4359 * src/widgets/Makefile.am:
4360 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4361 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4362 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4363 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4364 * src/widgets/modest-secureauth-combo-box.c:
4365 * src/widgets/modest-secureauth-combo-box.h:
4366 * src/widgets/modest-serversecurity-combo-box.c:
4367 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4368 made the GObject names more consistent with the rest of the Modest code.
4370 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4372 * src/maemo/easysetup/Makefile.am:
4373 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4374 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4375 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4376 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4377 * src/maemo/easysetup/modest-easysetup-wizard.c:
4378 * src/maemo/easysetup/modest-validating-entry.c:
4379 * src/maemo/easysetup/modest-validating-entry.h:
4380 * src/maemo/modest-account-settings-dialog.c:
4381 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4382 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4383 widgets/ because they are used outside of easysetup too. After checking in,
4384 svn will allow me to rename them too.
4386 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4388 * src/gnome/modest-msg-edit-window.c:
4389 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4390 linker error, to fix the build on the GNOME platform.
4391 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4392 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4393 ifdefed out to avoid a warning.
4395 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4397 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4398 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4399 some alternative for GTK+ 2.6.
4401 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4403 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4405 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4406 specified for EmailAccountsDialog in UI spec.
4408 * src/maemo/easysetup/modest-easysetup-wizard.c:
4409 * src/maemo/easysetup/modest-easysetup-wizard.h:
4410 * src/maemo/modest-account-settings-dialog.c:
4411 * src/maemo/modest-account-settings-dialog.h:
4412 Reuse a member window widget for the connection-specific SMTP server accounts,
4413 so we can tell it to create/save the accounts only if we actually save changes.
4415 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4416 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4417 (modest_connection_specific_smtp_edit_window_get_settings):
4418 Return a struct instance for temporarily remembering the entered data.
4420 * src/maemo/modest-connection-specific-smtp-window.h:
4421 * src/maemo/modest-connection-specific-smtp-window.c:
4422 (modest_connection_specific_smtp_window_finalize),
4423 (modest_connection_specific_smtp_window_fill_with_connections),
4425 (modest_connection_specific_smtp_window_save_server_accounts),
4426 (update_model_server_names): Do not actually save data until asked,
4427 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4429 (on_selection_changed),
4430 (modest_connection_specific_smtp_window_init): Disable the edit
4431 button when nothing is selected.
4433 * src/modest-account-mgr-helpers.c:
4434 * src/modest-account-mgr-helpers.h:
4435 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4438 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4440 * src/modest-account-mgr-helpers.h:
4441 * src/modest-account-mgr-helpers.c:
4442 (modest_account_mgr_get_unused_account_name),
4443 (modest_account_mgr_get_unused_account_display_name): Added these
4444 utility functions, to avoid code duplication.
4446 * src/maemo/easysetup/modest-easysetup-wizard.c:
4447 (create_page_account_details), (create_account):
4448 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4449 (on_combo_security_changed),
4450 (modest_connection_specific_smtp_edit_window_init),
4451 (modest_connection_specific_smtp_edit_window_save_settings):
4452 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4453 * src/maemo/modest-connection-specific-smtp-window.c:
4454 (modest_connection_specific_smtp_window_finalize),
4455 (modest_connection_specific_smtp_window_fill_with_connections),
4456 (on_button_edit), (modest_connection_specific_smtp_window_init):
4457 * src/maemo/modest-connection-specific-smtp-window.h:
4458 Implementing saving of connection-specific server accounts.
4460 But I need to refactor this so we can save the data for each
4461 possible connection-specific account and only actually create the server accounts
4462 when the easysetup finished, or the OK button is pressed on the account settings
4465 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4467 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4468 (on_combo_security_changed):
4469 (modest_connection_specific_smtp_edit_window_init):
4470 Auto-fill the port number as in the account settings.
4472 (modest_connection_specific_smtp_edit_window_set_connection):
4473 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4474 * src/maemo/modest-connection-specific-smtp-window.c:
4475 (fill_with_connections), (on_button_edit),
4476 (modest_connection_specific_smtp_window_init):
4477 Turn the edit window into a dialog to simplify the code, and
4478 set a WM hint as in a GtkDialog, because only a popup can be on top of
4479 another window in Maemo, and popups usually have no WM decoration.
4481 * src/modest-defs.h:
4482 * src/modest-account-mgr-helpers.c:
4483 (modest_account_mgr_set_connection_specific_smtp),
4484 (modest_account_mgr_remove_connection_specific_smtp),
4485 (modest_account_mgr_get_connection_specific_smtp):
4486 * src/modest-account-mgr-helpers.h: Some functions to write the
4487 connection-specific SMTP server information. Not yet used.
4490 * src/widgets/modest-folder-view.c: (text_cell_data):
4491 Fix a warning about an uninitialized variable.
4492 (on_configuration_key_changed): Put an #ifdef around the use
4493 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4495 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4497 * src/maemo/modest-account-settings-dialog.h:
4498 * src/maemo/modest-account-settings-dialog.c:
4499 Added connect_for_modified() utility function to mark the new modified boolean.
4501 (create_page_account_details), (create_page_user_details),
4502 (create_page_incoming), (create_page_outgoing), (on_response),
4503 (modest_account_settings_dialog_init),
4504 (modest_account_settings_dialog_set_account_name):
4505 Only warn about unsaved changes when there are actually unsaved changes.
4507 * src/modest-account-mgr-helpers.c:
4508 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4509 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4510 to get the data from there in future.
4512 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4514 * src/modest-defs.h:
4516 * src/modest-account-mgr-helpers.h:
4517 * src/modest-account-mgr-helpers.c:
4518 Store the security account setting in a single conf key instead of using
4519 the options list, so that the list is left for just the to-be-removed camel hack,
4520 and because gconf_client_set_list() is failing for some reason.
4522 * src/modest-account-mgr.c:
4523 (modest_account_mgr_add_server_account):
4524 * src/maemo/modest-account-settings-dialog.c:
4525 (modest_account_settings_dialog_set_account_name),
4526 (save_configuration): Use the renamed functions.
4529 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4531 * src/widgets/Makefile.am:
4532 * src/widgets/modest-limit-retrieve-combo-box.c:
4533 * src/widgets/modest-limit-retrieve-combo-box.h:
4534 * src/widgets/modest-retrieve-combo-box.c:
4535 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4536 the account settings dialog.
4538 * src/modest-defs.h:
4539 * src/modest-account-mgr-helpers.h:
4540 * src/modest-account-mgr-helpers.c:
4541 (modest_server_account_get_option_secure_auth),
4542 (modest_server_account_set_option_secure_auth):
4543 * src/modest-account-mgr.c:
4544 (modest_account_mgr_add_server_account):
4545 Use the existing AUTH_MECH conf key for the secure-auth setting,
4546 instead of putting it in the list options, because this was actually used already.
4548 * src/maemo/modest-account-settings-dialog.c:
4549 (create_page_account_details),
4550 (modest_account_settings_dialog_set_account_name),
4551 (save_configuration):
4552 * src/maemo/modest-account-settings-dialog.h:
4553 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4554 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4556 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4558 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4559 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4560 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4562 * src/modest-defs.h:
4563 * src/maemo/modest-account-settings-dialog.c:
4564 (create_page_incoming), (on_combo_outgoing_security_changed),
4565 (on_combo_incoming_security_changed), (create_page_outgoing),
4566 (modest_account_settings_dialog_set_account_name),
4567 (save_configuration): Load/Save the port number, and change it when the
4568 security combo changes, to suitable defaults.
4570 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4572 * src/modest-account-mgr.c:
4573 (modest_account_mgr_add_server_account): Set the security and secure-auth
4574 options, and add a comment saying that the other camel-specific options should be
4577 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4579 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4581 * src/modest-tny-account-store.c: (account_list_free),
4582 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4583 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4586 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4588 * src/modest-protocol-info.c:
4589 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4590 is required by our UI spec. Maybe something in our implementation will use this eventually.
4591 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4592 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4593 instead of the previous 0 placeholder.
4595 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4596 secure-auth settings.
4597 * src/modest-account-mgr-helpers.h:
4598 * src/modest-account-mgr-helpers.c:
4599 (modest_server_account_data_get_option_secure_auth),
4600 (modest_server_account_set_option_secure_auth),
4601 (modest_server_account_data_get_option_security),
4602 (modest_server_account_set_option_security): Added this API for getting and setting the security
4603 and secure-auth settings.
4605 * src/maemo/modest-account-settings-dialog.h:
4606 * src/maemo/modest-account-settings-dialog.c:
4607 (modest_account_settings_dialog_finalize), (check_data),
4608 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4609 about changing titles.
4610 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4611 (save_configuration): Save the security and secure-auth settings.
4613 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4614 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4616 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4618 * src/modest-defs.h:
4619 * src/modest-account-mgr.c:
4620 (modest_account_mgr_add_server_account):
4621 Added and used defines for the options key and value pair strings,
4622 that are used so far, though they do not seem to correspond to anything in our
4623 UI specs or ModestProtocol enum.
4625 * src/modest-account-mgr-helpers.h:
4626 * src/modest-account-mgr-helpers.c:
4627 (compare_option_strings_for_name),
4628 (modest_server_account_data_get_option_value),
4629 (modest_server_account_data_get_option_bool),
4630 (modest_account_mgr_get_server_account_option):
4631 Added helper functions for parsing the options GSList.
4633 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4635 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4636 display name is based on the supplied account name.
4637 * src/modest-account-mgr.c:
4638 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4639 with an inefficient, but good-enough, implementation.
4641 * src/maemo/easysetup/modest-easysetup-wizard.c:
4642 (create_page_account_details), (on_before_next), (create_account):
4643 Check for existing display names rather than (non-user-visible) account names, and just
4644 create and set a unique account name at the end.
4646 * src/maemo/modest-account-settings-dialog.c:
4647 (modest_account_settings_dialog_init),
4648 (modest_account_settings_dialog_set_account_name),
4649 (create_page_incoming): Show the display name, instead of the account name.
4650 (on_response): Do some (not all) extra checks, as in the UI spec.
4651 (save_configuration): Save the display name if it was changed.
4653 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4655 * po/en_GB.po: Added needed logical ID and translation.
4656 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4657 (init_view): Made the is-default column clicking work.
4659 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4662 * src/maemo/easysetup/Makefile.am:
4663 * src/maemo/easysetup/modest-easysetup-wizard.c:
4664 (modest_easysetup_wizard_dialog_init):
4665 * src/maemo/easysetup/provider-data-test.keyfile:
4666 * src/maemo/easysetup/provider-data.keyfile:
4667 Moved the provider data file to the new modest-providers-data package and used it from there.
4669 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4671 * src/modest-local-folder-info.c:
4672 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4673 N_() was already used on the static strings, but this just marks it for translation without
4674 using the translation.
4676 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4678 * src/maemo/modest-account-settings-dialog.c:
4679 (create_page_incoming),
4680 (modest_account_settings_dialog_set_account_name):
4681 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4682 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4683 I will do this if nobody else gets there first.
4685 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4687 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4688 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4689 save the security stuff.
4691 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4693 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4694 Set the email address and user fullname, which I now see must be
4697 * src/maemo/modest-account-settings-dialog.h:
4698 * src/maemo/modest-account-settings-dialog.c:
4700 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4701 leave-on-server and authentication.
4702 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4705 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4708 * src/maemo/modest-account-settings-dialog.c:
4709 * src/maemo/modest-account-settings-dialog.h:
4710 Most (but not all) of the widgets are now present as specified by the UI spec.
4711 No changes are yet saved, and some details are not properly shown yet.
4713 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4715 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4717 * src/maemo/Makefile.am:
4718 * src/maemo/modest-account-settings-dialog.c:
4719 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4720 an existing account. Doesn't do much yet.
4722 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4723 Open the accounts settings dialog when Edit is clicked.
4725 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4727 * src/maemo/easysetup/Makefile.am:
4728 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4730 * src/maemo/easysetup/modest-easysetup-wizard.c:
4731 (modest_easysetup_wizard_dialog_init):
4732 Try to get the source directory from the build system,
4733 instead of hard-coding "./" into the source code, when opening our local
4734 copies of the configuration files.
4735 But this still fails when opening the wizard from the Accounts window,
4736 maybe because the working directory seems to change at runtime.
4737 So the wizard will fail the second time unless you copy the files into their
4738 proper locations - see the stdout warnings for the paths.
4740 (create_page_account_details),(on_before_next):
4741 Check for existing non-server accounts instead of server accounts,
4742 so the default account name is useful again, and to prevent trying to
4745 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4746 Show the wizard when New is clicked.
4748 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4749 (init_view): Show the column headers, and show the columns that are
4750 specified in the UI specs. However, something in Maemo's GTK+ prevents
4751 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4752 change the default account. This is despite unsetting the special properties.
4754 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4756 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4757 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4758 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4759 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4760 to make that clearer.
4761 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4763 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4765 * src/maemo/modest-account-view-window.c:
4766 (modest_account_view_window_init),
4767 (modest_account_view_window_new):
4768 Use the same buttons as specified in the
4769 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4770 the existing widgets, which never had a chance of working.
4771 Put the ModestAccountView treeview in a scrolled window.
4772 Do not repeat the initialization in both _init() and _new().
4774 * src/widgets/modest-account-view.c: (update_account_view):
4775 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4776 this widget and window shows no accounts.
4778 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4780 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4782 * src/maemo/easysetup/modest-easysetup-wizard.c:
4783 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4784 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4785 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4788 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4789 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4790 accounts exist yet, as in the UI spec.
4792 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4794 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4796 * src/maemo/Makefile.am:
4797 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4798 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4799 New window for editing connection-specific smtp details.
4800 Not fully implemented.
4802 * src/maemo/modest-connection-specific-smtp-window.c:
4803 (modest_connection_specific_smtp_window_finalize) :
4804 unref the tree model.
4805 (on_button_edit): Show the edit window.
4807 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4809 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4812 * src/maemo/Makefile.am:
4813 * src/maemo/modest-connection-specific-smtp-window.c:
4814 * src/maemo/modest-connection-specific-smtp-window.h:
4815 New window for showing the list of connections, for connection-specific
4816 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4817 * src/maemo/easysetup/modest-easysetup-wizard.c:
4818 (create_page_custom_outgoing): Show the new window when the button is clicked.
4820 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4822 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4823 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4824 * src/maemo/modest-msg-edit-window.c:
4825 (modest_msg_edit_window_insert_image):
4826 * src/modest-conf.c: (modest_conf_key_escape):
4827 * src/modest-mail-operation.c:
4828 (modest_mail_operation_send_new_mail):
4829 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4830 (modest_ui_actions_on_new_account):
4831 * src/widgets/modest-attachment-view.c: (update_filename_request):
4832 * src/widgets/modest-mail-header-view.c:
4833 Corrected warnings that were breaking the build, by commenting out unused variables,
4834 and a function, and by including a header.
4836 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4838 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4839 so we can #ifdef around platform-specific code when necessary.
4840 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4841 to allow this to build for the GNOME platform too.
4843 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4845 * src/maemo/easysetup/modest-easysetup-wizard.c:
4846 Added util_increment_name() and used it in create_page_account_details()
4847 to make sure that the default account name is always a new name.
4849 (modest_easysetup_wizard_dialog_init),
4850 (set_default_custom_servernames): Some minor memory management fixes.
4852 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4856 * src/modest-runtime.c: (init_i18n): Restored the translation
4857 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4858 are defined in config.h, and the translations are installed.
4860 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4861 is defined for translation.
4863 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4865 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4867 * src/maemo/easysetup/modest-easysetup-wizard.c:
4868 (modest_easysetup_wizard_dialog_init):
4869 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4870 Use realistic paths (though they should use $prefix generically) to the
4871 mcc_mapping and provider-data.keyfile files which might work when they
4872 are installed by the future version of the operator-wizard package,
4873 and then fallback to paths in our source code, with an explanatory
4876 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4880 * src/maemo/Makefile.am:
4881 * src/maemo/easysetup/: Added files from the previously-exernal
4882 osso-modest-easysetup.
4883 * src/maemo/modest-main-window-ui.h:
4884 * src/modest-ui-actions.c:
4885 * src/modest-ui-actions.h:
4886 Added modest_ui_actions_on_new_account() as a signal handler for the
4887 New Account menu item. It shows the easysetup wizard.
4888 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob