1 2007-06-07 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
4 (modest_server_account_set_security):
5 * src/modest-defs.h: Add comments explaining that our
6 UI spec means TLS when it says Normal, so these do not look like errors.
8 * src/modest-tny-account.c:
9 (modest_tny_account_new_from_server_account): Use the new tinymail
10 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
11 for TLS. This should fix projects.maemo.org bug NB#58460.
13 2007-06-06 Murray Cumming <murrayc@murrayc.com>
15 * src/maemo/easysetup/modest-easysetup-wizard.c:
16 (create_account): Correct the position of the gconf sanity check warning.
17 (on_button_edit_advanced_settings): Show the dialog immediately, instead
18 of using the g_idle_add() hack, because this does not seem to be necessary
19 on osso 1.1. It might even work on Maemo Bora if the problems were actually
20 caused by something other than maemo's gconf.
21 This fixes projects.maemo.org bug #59022.
23 2007-06-06 Murray Cumming <murrayc@murrayc.com>
25 * src/modest-account-mgr-helpers.c:
26 (modest_account_mgr_get_default_account): Do not check that the account
27 exists if there is no default account (NULL), to fix a runtime warning.
29 2007-06-06 Murray Cumming <murrayc@murrayc.com>
31 * src/widgets/modest-folder-view.c: (update_model):
32 Do not unref the treemodel before we have finished with it.
33 This prevents a valgrind warning and an occasional crash at startup.
35 2007-06-06 Marcus Bauer <marcusb@openismus.com>
37 * libmodest-dbus-client/libmodest-dbus-client.h:
38 added libmodest_dbus_client_compose_mail()
39 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
41 added functions needed for SendAsMail() functionality
42 * src/maemo/modest-msg-edit-window.c:
43 (modest_msg_edit_window_attach_file_noninteractive):
44 non interactively attaching files to message edit window
45 * src/widgets/modest-msg-edit-window.h:
46 * tests/dbus_api/Makefile.am:
47 added test_compose_mail.c
48 * tests/dbus_api/test_compose_mail.c: (main):
50 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
52 * src/modest-account-view.c:
53 Fixed bug projects.maemo.org bug NB#59307
55 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
57 * src/maemo/easysetup/modest-easysetup-wizard.c:
58 (get_serverport_incoming), (on_before_next), (create_account):
59 * src/maemo/modest-account-settings-dialog.c:
60 (modest_account_settings_dialog_set_account_name):
61 * src/maemo/modest-maemo-utils.c:
62 (on_camel_account_get_supported_secure_authentication_status),
63 (on_camel_account_get_supported_secure_authentication),
64 (on_secure_auth_cancel),
65 (modest_maemo_utils_get_supported_secure_authentication_methods):
67 Implemented security authentication for settings and easysetup.
69 2007-06-05 Murray Cumming <murrayc@murrayc.com>
71 * src/maemo/modest-main-window.c: (create_details_widget):
72 Show the total size for memory card accounts too, instead of showing
73 the name again. Fixes bug projects.maemo.org bug NB#59307.
75 2007-06-05 Murray Cumming <murrayc@murrayc.com>
78 * src/modest-tny-simple-folder-store.c:
79 * src/modest-tny-simple-folder-store.h: Removed.
81 * src/modest-tny-local-folders-account.h
82 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
83 for the local-folders maildir, with an extra TnyMergedFolder containing
84 the folders of the per-account outbox store accounts.
85 * src/modest-tny-account-store.c: (get_server_accounts):
86 Add the outboxes to the special local folders account after creating it.
88 * src/modest-tny-account.c:
89 (modest_tny_account_new_for_local_folders): Create the derived
90 account when creating the main local-folders account.
92 * src/maemo/modest-main-window.c: (create_details_widget),
93 (modest_main_window_set_contents_style):
94 Adapted to the use of the derived account instead of the folder store.
96 * src/modest-ui-actions.c:
97 (modest_ui_actions_on_folder_selection_changed):
98 * src/modest-ui-dimming-rules.c:
99 (modest_ui_dimming_rules_on_new_folder):
100 * src/widgets/modest-folder-view.c: (text_cell_data),
101 (icon_cell_data), (filter_row), (update_model),
102 (get_cmp_rows_type_pos):
105 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
106 Do not get the priv struct, because no priv struct has been set,
107 to avoid a runtime warning.
109 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
110 #ifelse with #else, to fix a warning, to fix the build.
113 2007-06-05 Christian Kellner <ckellner@openismus.com>
115 * libmodest-dbus-client/libmodest-dbus-client.c:
116 Fix small typo in doc (why do you always see them
117 AFTER committing stuff?)
120 2007-06-05 Christian Kellner <ckellner@openismus.com>
122 * libmodest-dbus-client/libmodest-dbus-client.c:
123 (libmodest_dbus_client_search):
124 Initialize hit list with NULL. Also set folder list
125 to "" if NULL was supplied.
128 2007-06-03 Christian Kellner <ckellner@openismus.com>
130 * libmodest-dbus-client/libmodest-dbus-client.c:
131 (modest_search_hit_list_free):
132 Make it save to call it with NULL.
134 * src/dbus_api/modest-dbus-callbacks.c:
135 * src/modest-search.c:
136 Return full ModestSearchHits as the search result list not TnyHeader
137 since can't be around withouth the correspoding TnyFolder.
139 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
141 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
142 Added currently commented code to check for secure auth
144 * src/maemo/modest-account-settings-dialog.c: (on_response),
145 (save_configuration), (show_ok):
146 Fixed projects.maemo.org bugs NB #59248 and #59251
148 * src/maemo/modest-maemo-utils.c:
149 (on_camel_account_get_supported_secure_authentication_status),
150 (on_camel_account_get_supported_secure_authentication),
151 (modest_maemo_utils_get_supported_secure_authentication_methods):
152 * src/maemo/modest-maemo-utils.h:
153 Moved get_supported_secure_authentication() method here to be able
154 to use it from easysetup wizard.
156 * src/modest-pair.c: (on_pair_compare_as_string):
157 Should compare string with first part of pair and not
158 strcmp pairs which will crash.
160 * src/modest-protocol-info.c:
161 (modest_protocol_info_protocol_is_store):
162 * src/modest-protocol-info.h:
163 Added modest_protocol_info_get_auth_protocol_name()
165 2007-06-03 Armin Burgmeier <armin@openismus.com>
167 * src/modest-mail-operation.c:
168 (modest_mail_operation_get_msgs_full): Set priv->account also when
169 only retrieving a single message. This avoids a crash when canceling
172 (modest_mail_operation_notify_end): Do not explicitely remove the
173 operation from the queue but only emit the progress_changed signal.
174 The queue itself listens to that signal to remove the operation when
175 it is finished. This reduces coupling and removes a potential deadlock
176 when modest_mail_operation_notify_end() is called from the queue
177 itself. If that is a problem performance-wise, I would suggest to
178 implement a status-changed signal or something.
180 * src/modest-mail-operation-queue.c: Make sure to never call a
181 function from another file while the queue is locked. This (hopefully)
182 fixes another deadlock when exiting the application while retrieving
185 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
187 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
188 Fixed build if libogs is not available
190 2007-06-03 Christian Kellner <ckellner@openismus.com>
192 * libmodest-dbus-client/libmodest-dbus-client.h:
193 * libmodest-dbus-client/libmodest-dbus-client.c:
194 (libmodest_dbus_client_delete_message):
195 Implement deletion of messages (Client side).
197 (modest_search_hit_free),
198 (modest_search_hit_list_free):
199 Utility functions to free the result hits.
201 * src/dbus_api/modest-dbus-api.h:
202 * src/dbus_api/modest-dbus-callbacks.c:
204 (modest_dbus_req_handler):
205 Implement deletion of messages (Server side).
207 * tests/dbus_api/test_search.c: (main):
210 * tests/dbus_api/Makefile.am:
211 * tests/dbus_api/test_delete_message:
212 Add little test for the message deletion logic
214 2007-06-03 Armin Burgmeier <armin@openismus.com>
216 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
217 when the operation queue was not empty. projects.maemo.org bug
220 2007-06-03 Armin Burgmeier <armin@openismus.com>
222 * src/widgets/modest-account-view.c
223 (on_account_default_toggled): Toggle default account column
224 explicitely instead of waiting for gconf notification (which is
225 currently ignored). This should fix projects.maemo.org bug NB#56910
226 for now. It should probably be removed when gconf notifications are
229 2007-06-03 Christian Kellner <ckellner@openismus.com>
231 * libmodest-dbus-client/libmodest-dbus-client.c:
232 Removed debugging spew.
234 * src/dbus_api/modest-dbus-callbacks.c:
235 Added debugging info.
237 * src/modest-search.c:
238 (modest_search_all_accounts):
239 Use tny_account_store_get_accounts () on the account store
240 to get all accounts which is the way to get all accounts.
242 * tests/dbus_api/test_search.c: (main):
243 Make it possible to supply the search term on the command line.
245 2007-06-03 Christian Kellner <ckellner@openismus.com>
247 * libmodest-dbus-client/libmodest-dbus-client.c:
248 * libmodest-dbus-client/libmodest-dbus-client.h:
249 Implement searching for mesages over raw dbus. (Client side)
251 * src/dbus_api/Makefile.am:
252 * src/dbus_api/modest-dbus-api.h:
253 * src/dbus_api/modest-dbus-callbacks.c:
254 * src/dbus_api/modest-dbus-callbacks.h:
255 Search framework (Server side). Also implement on_idle_open_message().
257 * src/maemo/modest-platform.c: (modest_platform_init):
258 Prepare for raw dbus/osso rpc interaction.
260 * src/modest-search.h:
261 Changed minsize from unspecific guint to guint32.
263 * src/modest-search.c:
265 Added strange hack which magically made tnymail work.
267 (modest_search_folder),
268 (modest_search_account),
269 (modest_search_all_accounts):
270 Implement helper functions to search all accounts, specific account
273 * tests/dbus_api/Makefile.am:
274 * tests/dbus_api/test_open_message.c:
275 Read url to open from commandline.
277 * tests/dbus_api/test_search.c:
278 Implement small test for dbus search stuff
280 2007-06-02 Armin Burgmeier <armin@openismus.com>
282 * src/maemo/modest-account-settings-dialog.c: Changed window title to
283 include account type and account title. This fixes projects.maemo.org
286 * src/maemo/modest-account-view-window.c: Set a title for the window.
288 2007-06-02 Armin Burgmeier <armin@openismus.com>
290 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
291 incoming and outgoing server name based on email address and server
292 types as long as the names have not been edited manually. This fixes
293 projects.maemo.org bug NB#58671.
295 2007-06-02 Armin Burgmeier <armin@openismus.com>
297 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
298 server type cannot be changed in future to the incoming details page
299 when creating an account. This fixes projects.maemo.org bug NB#59029.
301 2007-06-02 Armin Burgmeier <armin@openismus.com>
303 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
304 and assigned max width chars so that they wrap instead of being
305 truncated. Fixes projects.maemo.org bug NB#56126.
307 2007-06-02 Armin Burgmeier <armin@openismus.com>
309 * src/maemo/modest-connection-specific-smtp-window.c: Add an
310 introductory note to the connection specific smtp servers dialog, as
311 section 8.12 of the email UI specification requires. This fixes
312 projects.maemo.org bug NB#59212.
314 2007-06-01 Murray Cumming <murrayc@murrayc.com>
316 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
317 Check for running mail operations, and offer to cancel them, as per the UI
318 spec. This fixes projects.maemo.org bug NB#59041 .
319 However, I suspect that tinymail may still use the network connection
320 in ways that we cannot detect or cancel. But it should at least adapt to
323 2007-06-01 Murray Cumming <murrayc@murrayc.com>
325 * src/modest-tny-account-store.c: (recreate_all_accounts),
326 (get_cached_accounts), (get_server_accounts): Do more sensible
327 ref-counting of the temporarily-cached outbox accounts list. This seems
328 to fix a crash when entering the password when the password was wrong.
330 2007-06-01 Murray Cumming <murrayc@murrayc.com>
332 * src/gnome/modest-main-window.c: (connect_signals):
333 * src/modest-tny-account-store.c: (get_password),
334 (modest_tny_account_store_alert): Added comments and clues and
335 commented-out code about how we currently fail to deal with connection
336 errors and wrong passwords, and how we should.
338 2007-06-01 Murray Cumming <murrayc@murrayc.com>
340 * src/widgets/modest-retrieve-combo-box.c:
341 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
342 This fixes projects.maemo.org bug NB#58472 .
344 2007-06-01 Murray Cumming <murrayc@murrayc.com>
346 * src/maemo/easysetup/modest-easysetup-wizard.c:
347 (create_page_complete_easysetup):
348 (create_page_complete_custom): Correct the last commit,
349 putting the correct sentences in the correct pages.
351 2007-06-01 Murray Cumming <murrayc@murrayc.com>
353 * src/maemo/easysetup/modest-easysetup-wizard.c:
354 (create_page_complete_custom): Show the second sentence of text
355 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
358 2007-06-01 Murray Cumming <murrayc@murrayc.com>
360 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
361 Set the leave-on-server conf key by default. This fixes
362 projects.maemo.org bug NB#59258 .
364 2007-06-01 Murray Cumming <murrayc@murrayc.com>
366 * src/maemo/modest-account-view-window.c:
367 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
368 logical ID for the confirmation messages. Fixed projects.maemo.org bug
371 2007-06-01 Murray Cumming <murrayc@murrayc.com>
373 * src/maemo/easysetup/modest-easysetup-wizard.c:
374 (create_caption_new_with_asterisk):
375 * src/maemo/modest-account-settings-dialog.c:
376 (create_caption_new_with_asterisk):
377 Uncomment the code to add the asterisk, because they are no longer in the
378 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
379 (update_incoming_server_title): Add an asterisk here too.
381 2007-06-01 Murray Cumming <murrayc@murrayc.com>
383 * src/maemo/modest-maemo-global-settings-dialog.c:
384 (current_connection): Check that we are even connected before trying to
385 get the current connection name, to prevent a warning.
387 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
388 Change the comments because tny_maemo_conic_device_connect() is now meant to
390 * src/modest-mail-operation.c:
391 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
392 make sure we have a connection and fail if we can't connect.
394 2007-05-31 Murray Cumming <murrayc@murrayc.com>
396 * src/maemo/modest-main-window.c:
397 (on_account_store_connecting_finished): Do not try to get the
398 connection ID if we are not really connected. I am surprised that
399 this signal handler is called when we are not connected.
401 2007-05-31 Murray Cumming <murrayc@murrayc.com>
403 * src/modest-error.h:
404 * src/modest-ui-actions.c:
405 (modest_ui_actions_get_msgs_full_error_handler):
406 Renamed an enum, added comments, added an enum
407 for retrieve-limit errors.
409 * src/modest-mail-operation.c: (foreach_add_item),
410 (internal_folder_observer_update), (update_account_thread),
411 (modest_mail_operation_get_msgs_full):
412 (modest_mail_operation_update_account),
413 Added comments about how this works, and some code that should
414 (but does not) check the retrieve-limit. See the TODO comment.
416 2007-05-31 Murray Cumming <murrayc@murrayc.com>
418 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
419 Initialize help_id to fix the build. Warnings are good.
421 2007-05-31 Murray Cumming <murrayc@murrayc.com>
423 * src/widgets/modest-hbox-cell-renderer.c:
424 (modest_hbox_cell_renderer_append):
425 * src/widgets/modest-vbox-cell-renderer.c:
426 (modest_vbox_cell_renderer_append):
427 Fix the last commit by doing an extra ref.
429 2007-05-31 Murray Cumming <murrayc@murrayc.com>
431 * src/widgets/modest-hbox-cell-renderer.c:
432 (modest_hbox_cell_renderer_append):
433 * src/widgets/modest-vbox-cell-renderer.c:
434 (modest_vbox_cell_renderer_append):
435 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
436 to fix the build with Maemo Bora.
437 However, there seems to be a remaining crash, probably due to reference
440 2007-05-30 Murray Cumming <murrayc@murrayc.com>
442 * src/modest-tny-account.c:
443 (modest_tny_account_new_for_local_folders):
444 Use hildon_file_system_info_async_new() to get a better name for
445 the memory card account, setting it as the account name.
446 The timing seems to work, but this is probably
447 not the best place to do this. See the TODO comment.
448 * src/maemo/modest-main-window.c: (create_details_widget):
449 * src/widgets/modest-folder-view.c: (text_cell_data):
450 Use the tny account name instead of hardcoding a name.
452 2007-05-30 Christian Kellner <ckellner@openismus.com>
454 * src/modest-search.c: (modest_search):
455 Correctly set part_search_func even if we have already parsed
456 the query and thus a valid OgsTextSearcher object.
458 2007-05-30 Christian Kellner <ckellner@openismus.com>
461 Search and check for libogs.
464 Incooparte the ogs build env.
466 * src/modest-mime-part-search-stream.c:
467 * src/modest-mime-part-search-stream.h:
468 Removed since we do the real searching now in modest-search.c.
470 * src/modest-search.c:
471 * src/modest-search.h:
472 Implement support for ogs. We use that if available and requested
473 and fall back to modest_text_utils_utf8_strcmp (). The search logic
474 should now handle the corner case when the search term is spread
475 across multiple reads.
476 Also the logic in modest_search () was corrected to search all
477 requested fields until one is found.
479 2007-05-30 Murray Cumming <murrayc@murrayc.com>
481 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
484 * src/modest-init.c: Made modest_init_local_folders() take a
485 path and be public so we can iniitialize maildir folders on
488 * src/modest-local-folder-info.h:
489 * src/modest-local-folder-info.c:
490 (modest_local_folder_info_get_maildir_path): Add a path parameter.
492 * src/modest-tny-account.c:
493 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
494 still means the standard local-folders path on the local volume.
496 * src/modest-tny-account-store.c:
497 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
498 signal so we can detect mount/unmount of the MMC1 card, and do an update of
499 all accounts when that happens.
500 (get_server_accounts): If the MMC1 card is mounted, create a store account for
501 this too, so it shows up in the treeview.
503 2007-05-28 Murray Cumming <murrayc@murrayc.com>
505 * src/maemo/modest-maemo-global-settings-dialog.c:
506 (current_connection):
507 * src/widgets/modest-global-settings-dialog.c:
508 (current_connection_default):
509 Use the enum values instead of 0, 1 and -1,
510 to make the code clearer.
512 * src/modest-account-mgr-helpers.c:
513 (modest_account_mgr_get_connection_specific_smtp): Make this code
516 * src/modest-runtime.h:
517 * src/modest-runtime.c:
518 Added modest_runtime_remove_all_send_queues().
519 * src/maemo/modest-main-window.c:
520 (on_account_store_connecting_finished): Recreate the send queues,
521 using the appropriate transport accounts for this new connection.
522 Some futher adapting might be needed if the old send queues are not
523 automatically stopped at this point.
525 * src/modest-tny-account-store.c: (get_server_accounts):
526 Create the connection-specific transport accounts, so that they can
527 be found later by their ID.
529 * src/modest-tny-account.h:
530 * src/modest-tny-account.c:
531 Added modest_tny_account_new_from_server_account_name().
532 modest_tny_account_new_from_server_account(): Do not create the
533 send queues here, because they will be
534 recreated anyway when the connection changes for the first time.
536 2007-05-28 Murray Cumming <murrayc@murrayc.com>
538 * src/modest-local-folder-info.h:
539 * src/modest-local-folder-info.c:
540 (modest_per_account_local_outbox_folder_info_get_maildir_path),
541 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
542 tbox_folder): Take a modest account name instead of a server TnyAccount,
543 so we can have per-modest-account rather than per-transport-account
545 We must make sure that we change or recreate the exisitng send queues
546 when the connection changes for connection-specific transport accounts.
548 * src/modest-tny-account-store.c:
549 (create_per_account_local_outbox_folders): Create outboxed per modest
550 account, not per transport account.
552 * src/modest-tny-account.h:
553 * src/modest-tny-account.c:
554 (modest_tny_account_get_special_folder): For outboxes, get the
555 parent modest account name. The account is ignored for other folders.
556 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
557 modest account name rather than a server TnyAccount.
559 2007-05-25 Murray Cumming <murrayc@murrayc.com>
561 * src/modest-tny-account.c:
562 (modest_tny_account_new_from_server_account):
563 Call modest_runtime_get_send_queue() immediately after creating transport
564 accounts, so that they start trying to send email from the outbox as soon
565 as possible at startup. This is probably what we want.
567 * src/modest-mail-operation.c: (update_account_thread):
568 * src/modest-runtime.c: (modest_runtime_get_send_queue):
569 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
570 * src/modest-tny-send-queue.h:
571 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
572 (modest_ui_actions_on_send):
573 Added comments about how sending works, though it needs some more work.
575 2007-05-25 Murray Cumming <murrayc@murrayc.com>
577 * src/modest-tny-account.c:
578 (modest_tny_account_get_special_folder): Add TODO because this fails when
580 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
581 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
582 Do not try to show this window when there is no active account. The UI
583 specs does not tell us what to do in this case.
585 2007-05-24 Murray Cumming <murrayc@murrayc.com>
589 * src/maemo/Makefile.am:
590 * src/widgets/Makefile.am: Some dist fixes.
592 2007-05-24 Murray Cumming <murrayc@murrayc.com>
594 * src/maemo/modest-connection-specific-smtp-window.c:
595 (on_button_edit): Make the code clearer, to prevent a double free.
597 2007-05-24 Murray Cumming <murrayc@murrayc.com>
599 * src/maemo/modest-account-settings-dialog.c:
600 (modest_account_settings_dialog_set_account_name),
601 Check the connection-specific smtp servers checkbox if there are any.
603 * src/maemo/modest-connection-specific-smtp-edit-window.c:
604 (modest_connection_specific_smtp_edit_window_init):
605 Start with a suitable port number.
607 * src/modest-account-mgr-helpers.h:
608 * src/modest-account-mgr-helpers.c: Added
609 modest_account_mgr_get_has_connection_specific_smtp().
611 (modest_account_mgr_set_connection_specific_smtp),
612 (modest_account_mgr_remove_connection_specific_smtp),
613 (modest_account_mgr_get_has_connection_specific_smtp),
614 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
615 connection-specific smtp server accounts in the account, rather than
616 the server account conf dir.
618 This fixes bug projects.maemo.org bug NB#58263 .
620 * src/modest-tny-account-store.c:
621 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
622 if there are no server accounts yet, to prevent an infinite loop when there
623 are no accounts. Document that one must be called before the other.
625 2007-05-24 Murray Cumming <murrayc@murrayc.com>
627 * src/modest-account-mgr-helpers.c:
628 (modest_account_mgr_get_default_account): Make sure that at least
629 one account is always the default, if there are any enabled accounts.
630 This is just a sanity check that shouldn't be necessary.
632 * src/modest-account-mgr-priv.c:
633 (_modest_account_mgr_account_from_key): Unescape the conf key to
634 get the real account name. For instance, this is an issue if a space
635 was in the account name, which can happen because the account name
636 is generated from the display name.
637 (_modest_account_mgr_get_account_keyname): Always escape the
639 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
640 Unescape the conf keys to get the real account names.
642 For instance, previously the is-default radio button in the accounts
643 list was not checked for any accounts at first. This fixes that,
644 and might fix several similar bugs.
646 2007-05-23 Murray Cumming <murrayc@murrayc.com>
648 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
649 Removed some debug printfs.
651 2007-05-23 Murray Cumming <murrayc@murrayc.com>
653 Modest on-disk outbox directories are now here, for instance:
654 $HOME/.modest/outboxes/<account-id-1>/outbox
655 $HOME/.modest/outboxes/<account-id-2>/outbox
657 $HOME/.modest/local-folders/outbox
658 so we can have a separate outbox for each account.
659 But they are shown as one outbox in the GtkTreeView, by using a
660 TnyMergeFolder in a ModestTnySimpleFolderStore.
663 * src/modest-tny-simple-folder-store.c:
664 * src/modest-tny-simple-folder-store.h:
665 Added ModestTnySimpleFolderStore, used to contain folders from
666 other folder stores, such as other accounts.
668 * src/modest-tny-outbox-account.h:
669 * src/modest-tny-outbox-account.c:
670 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
671 used for the per-account local outbox folders.
673 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
674 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
675 only use this (internally) now for the non-outbox local folders.
678 * src/modest-init.c: Added modest_init_one_local_folder(), for
679 setting up the directory structure for each local folder.
681 * src/modest-local-folder-info.c:
682 (modest_per_account_local_outbox_folder_info_get_maildir_path),
683 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
685 * src/modest-local-folder-info.h:
686 * src/modest-tny-account-store.c: (on_account_removed),
687 (on_account_changed), (create_per_account_local_outbox_folders),
688 (get_server_accounts), (modest_tny_account_store_get_accounts),
689 (modest_tny_account_store_get_tny_account_by_account),
690 (modest_tny_folder_store_is_virtual_local_folders):
692 * src/modest-tny-account.h:
693 * src/modest-tny-account.c:
694 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
695 to create an on-disk per-account local outbox folder for each
697 (create_per_account_local_outbox_folders): Create a local outbox folder
698 for each transport account.
699 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
700 for all local folders.
702 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
703 instead of using g_object_get/set() directly. It is clearer.
705 (modest_tny_folder_store_get_message_count),
706 (modest_tny_folder_store_get_local_size
707 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
708 because we now use these with non-acount folder stores.
710 (modest_tny_account_get_special_folder),
711 (modest_tny_account_new_from_server_account),
712 (modest_tny_account_new_from_account):
713 (recurse_folders): Adjust to the new outbox system.
715 * src/modest-tny-folder.h:
716 * src/modest-tny-folder.c:
717 (modest_tny_folder_is_local_folder),
718 (modest_tny_folder_get_local_folder_type),
719 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
721 * src/widgets/modest-main-window.h:
722 * src/maemo/modest-main-window.c: (create_details_widget),
723 (modest_main_window_set_contents_style): Show details for any folder store,
726 (modest_tny_folder_get_rules):
727 Remove the const. C does not support constness enough for this.
729 * src/modest-ui-actions.c:
730 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
731 make all outboxes appear as one, in the usual local-folders tree node.
733 (set_active_account_from_tny_account),
734 (modest_ui_actions_on_folder_selection_changed):
735 * src/widgets/modest-folder-view.c: (text_cell_data),
736 (icon_cell_data), (filter_row),
737 (add_account_folders_to_merged_folder),
738 (add_account_folders_to_simple_folder_store), (),
739 (get_cmp_rows_type_pos), (cmp_rows),
740 (modest_folder_view_set_account_id_of_visible_server_account):
741 Adjust to the new outbox system, using generic folder stores and folders
744 2007-05-23 Christian Kellner <ckellner@openismus.com>
746 * src/modest-mail-operation.c:
747 (modest_mail_operation_update_account):
748 Use info->max_size instead of unintialized local var [small
749 build fix]. (Added TODO to review that change since I don't
752 2007-05-23 Marcus Bauer <marcusb@openismus.com>
754 * libmodest-dbus-client/libmodest-dbus-client.c:
755 (libmodest_dbus_client_compose_mail): function added
756 * src/dbus_api/modest-dbus-api.h:
757 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
758 (on_compose_mail): Implementation of the SendAsMail functionality
760 2007-05-22 Murray Cumming <murrayc@murrayc.com>
762 * src/modest-account-mgr.c:
763 (modest_account_mgr_add_server_account): Set the secure-connection
764 conf key for transport accounts as well as store accounts. I don't know
765 why the if was there. For instance, this makes sure that we use SSL
766 for the gmail preset from the easysetup wizard.
768 2007-05-22 Murray Cumming <murrayc@murrayc.com>
770 * src/gnome/modest-main-window.c:
771 (on_account_store_connecting_finished), (connect_signals):
772 * src/maemo/modest-main-window.c:
773 (on_account_store_connecting_finished), (connect_signals),
774 (modest_main_window_new):
775 Handle TnyAccountStore::connecting-finished instead of
776 TnyDevice::connection-changed, because we cannot actually perform
777 operations on accounts until TnyAccountStore has itself responded to
778 the TnyDevice::connection-changed signal. This prevents a GError from
780 Do not try to update at startup, because we (at least on scratchbox)
781 already do an update at startup when the device goes online.
782 This prevents a GError from tinymail.
783 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
784 Added TODO about stopping simultaneous operations.
786 2007-05-21 Murray Cumming <murrayc@murrayc.com>
788 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
789 * src/modest-mail-operation-queue.c:
790 (modest_mail_operation_queue_remove):
791 * src/modest-tny-account-store.c: When GErrors happen, give more clues
792 about where they happened.
794 2007-05-21 Murray Cumming <murrayc@murrayc.com>
796 * src/modest-ui-actions.c:
797 (modest_ui_actions_on_password_requested): Make sure that the remember
798 output parameter is always TRUE.
800 2007-05-21 Murray Cumming <murrayc@murrayc.com>
802 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
803 Show a OK/Cancel dialog if the error is a question, though we still do not
804 know anything more about what we are asking the user.
805 * src/widgets/modest-folder-view.c: (on_drag_data_received):
806 Fix an uninitialized variable (helper). This is a logic error, however.
808 2007-05-21 Christian Kellner <ckellner@openismus.com>
810 * src/modest-search.h:
811 Correct bit shifting in the ModestSearchFlags enum.
813 2007-05-21 Murray Cumming <murrayc@murrayc.com>
815 * src/modest-tny-account.c:
816 (modest_tny_account_new_from_server_account): Do not use the lsub and
817 check-all hard-coded IMAP options when using POP.
819 2007-05-21 Murray Cumming <murrayc@murrayc.com>
821 * src/modest-tny-account.c:
822 (modest_tny_account_new_from_server_account):
823 Use NULL for the secure-auth method for POP when Password auth has been
824 specified by the user, as we already do for IMAP. "auth=Login" causes
825 an error from camel or the server.
827 2007-05-17 Murray Cumming <murrayc@murrayc.com>
829 * src/maemo/modest-account-settings-dialog.c:
830 (create_page_account_details),
831 (modest_account_settings_dialog_set_account_name):
832 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
833 for the leave-on-server checkbox, rathr than just the checkbox, when
834 the protocol is not POP.
836 2007-05-17 Murray Cumming <murrayc@murrayc.com>
838 * src/widgets/modest-account-view.c:
839 * src/widgets/modest-account-view.h:
840 Added modest_account_view_select_account() which will be useful later
841 to asynchronously re-select the edited account.
843 2007-05-17 Murray Cumming <murrayc@murrayc.com>
845 * src/maemo/modest-account-settings-dialog.c:
846 (modest_account_settings_dialog_set_account_name):
847 Automatically choose the port numbers based on the secure authentication
848 methods, if they have not been chosen before.
849 This fixes projects.maemo.org bug NB#56273 .
851 2007-05-17 Murray Cumming <murrayc@murrayc.com>
853 * src/maemo/modest-main-window-ui.h:
854 * src/modest-ui-actions.c:
855 * src/modest-ui-actions.h:
856 Connect the Tools/SMTP Servers menu item to
857 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
858 SMTP servers dialog, as in the UI specification and saves changes when it
859 is closed. This fixed projects.maemo.org bug NB#56305 .
861 2007-05-17 Murray Cumming <murrayc@murrayc.com>
863 * src/maemo/modest-connection-specific-smtp-window.c:
864 (modest_connection_specific_smtp_window_init):
865 Use gtk_window_set_default_size() to make this window big enough, so
866 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
868 2007-05-17 Murray Cumming <murrayc@murrayc.com>
870 * src/maemo/modest-connection-specific-smtp-edit-window.h:
871 * src/maemo/modest-connection-specific-smtp-edit-window.c:
872 (modest_connection_specific_smtp_edit_window_init),
873 Do not try to connect to a combobox signal before the combobox exists.
874 This fixes the cras in projects.maemo.org bug NB#56288 .
875 (modest_connection_specific_smtp_edit_window_get_settings):
876 Remove the server_account_name parameter which was being checked for NULL
877 though it was not used.
879 * src/maemo/modest-connection-specific-smtp-window.c:
880 (modest_connection_specific_smtp_window_fill_with_connections),
881 (on_button_edit), (modest_connection_specific_smtp_window_init):
882 Correct the number of treemodel columns to prevent a warning.
883 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
884 libconic does not work.
886 2007-05-16 Murray Cumming <murrayc@murrayc.com>
888 * src/modest-tny-account.c:
889 (modest_tny_account_new_from_server_account):
890 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
891 SMTP when "None" was chosen by the user. However, with my SMTP server that
892 does not support ANONYMOUS, the emails do not leave the Outbox and I see
895 2007-05-16 Murray Cumming <murrayc@murrayc.com>
897 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
898 to explain the memory management issue with the ID in the ModestPair.
900 * src/gnome/modest-account-assistant.c: (add_receiving_page),
901 (add_sending_page), (modest_account_assistant_finalize):
902 * src/gnome/modest-gnome-global-settings-dialog.c:
903 (create_updating_page), (create_composing_page):
904 * src/gnome/modest-msg-edit-window.c: (get_transports),
905 (init_window), (modest_msg_edit_window_finalize),
906 (modest_msg_edit_window_get_msg_data):
907 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
908 * src/gnome/modest-transport-widget.c:
909 (modest_transport_widget_finalize), (smtp_configuration):
910 * src/maemo/modest-maemo-global-settings-dialog.c:
911 (create_updating_page), (create_composing_page):
912 * src/maemo/modest-msg-edit-window.c: (get_transports),
913 (init_window), (modest_msg_edit_window_finalize),
914 (modest_msg_edit_window_get_msg_data),
915 (modest_msg_edit_window_free_msg_data):
916 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
917 (modest_store_widget_finalize):
918 * src/maemo/modest-transport-widget.c:
919 (modest_transport_widget_finalize), (smtp_configuration):
920 * src/modest-main.c: (send_mail):
921 * src/widgets/modest-combo-box.h:
922 * src/widgets/modest-global-settings-dialog-priv.h:
923 * src/widgets/modest-global-settings-dialog.c:
924 (modest_global_settings_dialog_finalize):
925 * src/widgets/modest-msg-edit-window.h:
926 Whenever using modest_combo_box_new(), keep the ModestPairList alive
927 as long as the combo box, to prevent use of freed memory for the ID.
929 2007-05-15 Murray Cumming <murrayc@murrayc.com>
931 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
932 get_accounts(), to make this clearer. Do not check for the enabled gconf
933 key, because we do not use this for server accounts (at least, not yet).
934 This allows us to send email again.
936 2007-05-15 Murray Cumming <murrayc@murrayc.com>
938 * src/maemo/modest-platform.c:
939 (on_modest_conf_update_interval_changed), (modest_platform_init):
940 Only respond to this particular key change. All these strcmp()s cannot be
943 2007-05-15 Murray Cumming <murrayc@murrayc.com>
945 * src/maemo/modest-maemo-global-settings-dialog.c:
946 (current_connection): Prevent a crash in scratchbox when
947 ny_maemo_conic_device_get_current_iap_id() returns NULL.
948 * src/maemo/modest-platform.c:
949 (on_modest_conf_update_interval_changed), (modest_platform_init):
950 Get the update interval from gconf and reset it when the gconf key changes.
952 2007-05-15 Murray Cumming <murrayc@murrayc.com>
954 * src/modest-protocol-info.c:
955 * src/modest-protocol-info.h: Adde enum-specific get functions,
956 instead of using a ModestProtocolType enum parameter.
958 * src/gnome/modest-account-assistant.c:
959 * src/gnome/modest-store-widget.c:
960 * src/gnome/modest-store-widget.h:
961 * src/gnome/modest-transport-widget.c:
962 * src/gnome/modest-transport-widget.h:
963 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
964 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
965 * src/maemo/easysetup/modest-easysetup-wizard.c:
966 * src/maemo/modest-account-settings-dialog.c:
967 * src/maemo/modest-account-settings-dialog.h:
968 * src/maemo/modest-store-widget.c:
969 * src/maemo/modest-store-widget.h:
970 * src/maemo/modest-transport-widget.c:
971 * src/maemo/modest-transport-widget.h:
972 * src/modest-account-mgr-helpers.c:
973 * src/modest-account-mgr-helpers.h:
974 * src/modest-account-mgr.c:
975 * src/modest-account-mgr.h:
976 * src/modest-tny-account.c:
977 * src/modest-tny-folder.c:
978 * src/widgets/modest-account-view.c:
979 * src/widgets/modest-retrieve-combo-box.c:
980 * src/widgets/modest-retrieve-combo-box.h:
981 * src/widgets/modest-secureauth-combo-box.c:
982 * src/widgets/modest-serversecurity-combo-box.c:
983 * src/widgets/modest-serversecurity-combo-box.h:
984 * tests/check_account-mgr.c:
985 Use the specific functions, and use the re-renamed enum values for GNOME too.
987 2007-05-15 Murray Cumming <murrayc@murrayc.com>
990 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
991 so we can get the second based on the first.
993 * src/maemo/modest-account-settings-dialog.h:
994 * src/maemo/modest-account-settings-dialog.c:
995 Added get_supported_secure_authentication_methods(), though it is mostly
996 commented-out for now until the necessary API is committed to tinymail.
997 (modest_account_settings_dialog_set_account_name),
998 (save_configuration): Request the supported authentication methods from the
999 server, so we can choose a working method.
1001 * src/modest-tny-account-store.h:
1002 * src/modest-tny-account-store.c:
1003 (modest_tny_account_store_get_session): Rename from
1004 tny_account_store_get_session().
1006 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1008 * src/modest-protocol-info.h: Split the ModestProtocol enum
1009 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1010 There was no need to have these unrelated values in one enum.
1012 * src/: many files: Adapted to changed enum. This makes the code a bit
1013 clearer, and the compiler could catch some errors.
1015 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1017 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1018 Show the detailed internal camel error message when an error happens
1019 during the configuration, so that our testers can give us more clues.
1020 For instance, in projects.maemo.org bug NB#56910 .
1022 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1024 * src/modest-tny-account.c:
1025 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1026 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1028 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1030 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1031 * src/maemo/modest-account-settings-dialog.c:
1032 (modest_account_settings_dialog_set_account_name),
1033 (save_configuration): For the incoming secure authentication checkbox,
1034 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1035 the UI specification. PLAIN does not seem to be supported for most IMAP
1036 servers anyway, and I am not sure what it would mean.
1037 However, we probably need to discover which of the secure-authentication
1038 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1039 * src/modest-account-mgr-helpers.c:
1040 (modest_account_mgr_get_server_account_data):
1042 * src/modest-tny-account.c:
1043 (modest_tny_account_new_from_server_account):
1044 Use tny_account_set_mech() to set secure-authentication methods,
1045 with some special-casing for IMAP, based on my observations of how
1048 * src/modest-account-mgr-helpers.h:
1049 * src/modest-account-mgr.c:
1050 * src/modest-defs.h: Comment that the URI is only used for local folders.
1052 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1054 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1055 parameter const, just to be neat.
1056 * src/modest-text-utils.c: (modest_text_utils_inline):
1057 End g_strconcat() with NULL, as its documentation says. This is almost
1058 certainly the cause of my crash at startup on the device. Interestingly,
1059 valgrind doesn't tell us about these errors.
1061 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1063 * scripts/build-packages: Added more precise comments about how to use
1064 this script, though I still get this error:
1065 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1066 error building tinymail
1068 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1070 * src/maemo/modest-main-window.c: (on_account_update):
1071 Very slight cleanup, hoping to make it simpler to discover what causes
1072 a crash here sometimes.
1074 * src/modest-tny-account.c:
1075 (modest_tny_account_new_from_server_account): Set the port. Added
1076 comments about the options and a TODO comment because I need to find out
1077 how to specify the secure authentication method.
1079 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1081 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1082 changed CFlags paths form modest to libmodest
1084 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1086 * src/modest-account-mgr-helpers.c:
1087 (modest_account_mgr_get_server_account_data),
1088 (modest_account_mgr_free_server_account_data):
1089 * src/modest-account-mgr-helpers.h:
1090 * src/modest-account-mgr.c:
1091 (modest_account_mgr_add_server_account):
1092 * src/modest-defs.h:
1093 * src/modest-tny-account.c:
1094 (modest_tny_account_new_from_server_account):
1095 Determine the options for tny_camel_account_add_option() here,
1096 based on the settings, rather than storing them directly in gconf.
1098 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1100 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1101 Show a more friendly error dialog now that we expect (from the tinymail
1102 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1104 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1106 * src/maemo/modest-main-window.c: (on_account_update): Check that
1107 account_name is not NULL, to prevent a crash at startup that I am
1108 seeing on the N800. I do wonder why it is NULL.
1110 * src/maemo/easysetup/modest-easysetup-wizard.c:
1111 (create_page_user_details):
1112 * src/maemo/modest-account-settings-dialog.c:
1113 (create_page_user_details), (create_page_outgoing):
1114 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1115 (modest_connection_specific_smtp_edit_window_init):
1116 * src/modest-ui-actions.c:
1117 (modest_ui_actions_on_password_requested):
1118 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1119 might do something useful with the on-screen keyboard.
1121 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1123 * src/maemo/modest-main-window.c: (on_account_update):
1124 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1125 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1127 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1129 * src/modest-tny-account-store.c: (on_account_changed):
1130 Correct the signature of this signal handler.
1132 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1134 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1135 Show a HildonNote instead of a GtkDialog for Maemo.
1137 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1139 * src/widgets/modest-account-view.h:
1140 * src/widgets/modest-account-view.c: (on_account_changed),
1141 (on_account_removed). Added a boolean flag, set/unset by
1142 modest_account_view_block_conf_updates(),
1143 modest_account_view_unblock_conf_updates() to prevent unnecessary
1144 updates, but this is not very useful because the gconf notifications are
1145 so delays (maybe only on Maemo Bora).
1146 So auto-updating is turned off, and these functions do an explicit
1147 update when necessary.
1148 However, something else is still doing too much work when adding/removing
1149 accounts, probably in another part of the application.
1151 * src/maemo/modest-account-view-window.c:
1152 (on_delete_button_clicked), (on_edit_button_clicked),
1153 (on_new_button_clicked): Use the new functions.
1155 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1157 * src/modest-account-mgr-helpers.c:
1158 (modest_account_mgr_set_first_account_as_default):
1159 Sort the list of names alphabetically-by-title, so we choose the first one
1161 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1162 alphabetically by the title.
1164 This fixes projects.maemo.org bug NB#56418 .
1166 * src/modest-account-mgr-priv.c:
1167 (_modest_account_mgr_account_from_key):
1168 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1169 avoid a valgrind error, and possible random behaviour.
1171 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1173 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1174 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1175 tinymail documentation to say that this can be expected.
1176 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1177 pretty, and should not happen, but I would prefer to know when it does.
1179 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1181 * configure.ac: When using the older hildon version, probably on Bora,
1182 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1184 * src/widgets/modest-attachment-view.c:
1185 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1188 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1190 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1191 Implemented the prototype. Can be tested with
1192 tests/dbus_api/test_open_message:
1194 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1196 * src/modest-tny-account-store.c:
1197 (modest_tny_account_store_instance_init), (get_password):
1198 * src/modest-ui-actions.c:
1199 (modest_ui_actions_on_password_requested):
1200 Do not store the password in gconf, because this function is called
1201 for non-remembered passwords. Actually use the cached (in the hash map)
1202 password instead of releasing it.
1203 The password will now not be remembered if it is asked via the protected
1204 password dialog, as per the UI spec.
1206 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1208 * src/modest-defs.h:
1209 * src/modest-account-mgr-helpers.h:
1210 * src/modest-account-mgr-helpers.c:
1211 Added modest_server_account_get_username_has_succeeded(),
1212 modest_server_account_set_username_has_succeeded().
1213 (modest_server_account_set_username),
1214 Reset the has-succeeded flag if the username changes.
1216 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1217 * src/maemo/modest-connection-specific-smtp-window.c:
1218 (modest_connection_specific_smtp_window_save_server_accounts):
1219 Use modest_server_account_set_username() instead of using
1220 modest_conf_set_string() directly, so that the has-succeeded flag is always
1223 * src/modest-ui-actions.c:
1224 (modest_ui_actions_on_password_requested): Dim the username entry if
1225 the username has ever worked, as per the UI spec.
1227 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1229 * src/modest-tny-account-store.c: (get_password):
1230 * src/modest-ui-actions.c:
1231 (modest_ui_actions_on_password_requested):
1232 Allow the username to be changed too, though there is more work to
1233 be done on exactly how this behaves.
1235 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1237 * src/modest-account-mgr-helpers.h:
1238 * src/modest-account-mgr-helpers.c:
1239 Added modest_account_mgr_get_display_name(),
1240 modest_server_account_get_username(),
1241 modest_server_account_set_username(),
1242 modest_server_account_set_password(),
1243 modest_server_account_get_hostname() functions so we do not need to
1244 use the conf API directly.
1246 * src/maemo/modest-main-window.c: (connect_signals):
1247 Actually connect ot the ModestAccountStore::request-password signal,
1248 so that we show the dialog when the password is requested by Tinymail,
1249 for isntance if it is empty.
1251 * src/modest-marshal.list:
1252 * src/modest-tny-account-store.c:
1253 (modest_tny_account_store_class_init), (get_password),
1254 (modest_tny_account_store_alert):
1255 * src/modest-tny-account-store.h:
1256 * src/modest-ui-actions.h:
1257 * src/modest-ui-actions.c:
1258 (modest_ui_actions_on_password_requested):
1259 Change the signal parameters, so it is obvious that we are providing
1260 the non human-readable server name, and receiving both the username
1261 and password, though changing of the username is not yet implemented.
1262 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1263 for the GNOME version.
1265 This should fix the projects.maemo.org bug NB#56209, though it does not
1266 work on Bora, because the gconf_client_get() for the password fails
1267 immediately after we save it with gconf_client_set().
1269 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1272 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1273 caused an undefined symbol error:
1274 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1276 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1278 * src/modest-tny-account-store.c:
1279 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1280 using a GError instead of a string message, so we can translate it in
1283 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1285 * src/maemo/modest-address-book.c:
1286 (modest_address_book_check_names):
1287 * src/maemo/modest-msg-view-window.c:
1288 (modest_msg_view_window_clipboard_owner_change):
1289 * src/modest-init.c: (modest_init_init_ui):
1290 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1291 (update_folders_cb), (modest_mail_operation_update_account):
1292 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1293 (modest_ui_actions_on_msg_attachment_clicked),
1294 (modest_ui_actions_on_msg_recpt_activated):
1295 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1296 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1297 (modest_msg_view_search_next):
1298 * src/widgets/modest-recpt-editor.c:
1299 (modest_recpt_editor_on_button_release_event),
1300 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1301 g_message(). At this point we should only be seeing interesting errors on
1302 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1304 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1306 (modest_wizard_dialog_force_title_update):
1307 * src/maemo/easysetup/modest-wizard-dialog.h:
1308 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1309 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1310 can update the title when appropriate. Otherwise the title is wrong if the
1311 pages are added after adding the notebook to the dialog.
1312 This must be a problem in HildonWizardDialog too.
1313 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1315 * src/maemo/easysetup/modest-easysetup-wizard.c:
1316 (create_subsequent_customsetup_pages),
1317 (create_subsequent_easysetup_pages):
1318 Call modest_wizard_dialog_force_title_update() so that the title is
1319 correct even with GTK+ < 2.10.
1320 This fixes projects.maemo.org bug NB#56145 .
1322 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1324 * src/maemo/modest-platform.c:
1325 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1326 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1329 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1331 * src/widgets/modest-window.h:
1332 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1333 and modest_window_save_state(), which invokes it.
1335 * src/widgets/modest-window-mgr.h:
1336 * src/widgets/modest-window-mgr.c:
1337 Added modest_window_mgr_save_state_for_all_windows(), which calls
1338 the save_state vfunc on all registered windows, if implemented.
1340 * src/gnome/modest-msg-edit-window.c:
1341 * src/gnome/modest-msg-view-window.c:
1342 * src/maemo/modest-msg-edit-window.c:
1343 * src/maemo/modest-msg-view-window.c:
1344 * src/maemo/modest-main-window.c:
1345 Specify the existing save_settings functions as implementations of
1346 ModestWindow::save_state_func().
1348 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1349 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1350 enabling hibernation, for instance.
1352 We may need to do the same thing for restoring settings.
1355 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1357 * src/widgets/modest-window-mgr.c:
1358 * src/widgets/modest-window-mgr.h:
1359 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1360 modest_window_mgr_get_hibernation_is_prevented().
1362 * src/maemo/modest-main-window.c:
1363 (on_hildon_program_is_topmost_notify): Prevent hibernation
1364 (possible when the application goes to the background in the WM),
1365 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1367 * src/maemo/easysetup/modest-easysetup-wizard.c:
1368 (modest_easysetup_wizard_dialog_init):
1369 * src/maemo/modest-account-settings-dialog.c:
1370 (modest_account_settings_dialog_init):
1371 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1372 (modest_connection_specific_smtp_edit_window_init):
1373 * src/maemo/modest-connection-specific-smtp-window.c:
1374 (modest_connection_specific_smtp_window_init):
1375 * src/maemo/modest-signature-editor-dialog.c:
1376 (modest_signature_editor_dialog_init):
1377 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1378 prevent hibernation while any of these account settings dialogs are open.
1380 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1382 * src/maemo/Makefile.am:
1383 * src/maemo/modest-osso-state-saving.c:
1384 * src/maemo/modest-osso-state-saving.h: Added
1385 modest_osso_load_state() and modest_osso_save_state() though they do
1386 nothing now. They should iterate through all the open windows and load/save
1388 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1389 save state when closing.
1391 * src/maemo/modest-main-window.c:
1392 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1393 Add a notification handler for the HildonProgram::is-topmost property,
1394 so we can allow hibernation when the application goes into the background.
1395 But we still need to detect when the accounts setup windows are open so
1396 we can stop hibernation when they are open.
1397 To do this, I also added the main window the HildonProgram. This might have
1398 other side-effects/benefits, and should maybe be done for other windows.
1400 * src/maemo/modest-osso-autosave-callbacks.h:
1401 * src/maemo/modest-osso-autosave-callbacks.c:
1402 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1403 though it does not do anything yet, and we might never need this to do
1404 anything. For instance, we already save drafts.
1406 * src/maemo/modest-platform.c: (modest_platform_init):
1407 Specify the libosso auto-save callback.
1409 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1411 * src/maemo/modest-platform.c:
1412 (modest_platform_set_update_interval):
1413 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1414 aparently stays valid between application instances, so we can use this
1415 to remove and reset it later. According to a maemo-developers email from
1418 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1420 * configure.ac: Depend on libalarm for Maemo.
1422 * src/dbus_api/modest-dbus-api.h:
1423 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1424 (on_send_receive), (modest_dbus_req_handler):
1425 Handle a SEND_RECEIVE D-Bus method.
1427 * libmodest-dbus-client/libmodest-dbus-client.c:
1428 (libmodest_dbus_client_send_and_receive):
1429 * libmodest-dbus-client/libmodest-dbus-client.h:
1430 Add C convenience functions for calling the new D-Bus method.
1432 * src/modest-platform.h:
1433 * src/gnome/modest-platform.c:
1434 * src/maemo/modest-platform.c:
1435 Added modest_platform_set_update_interval(), which uses the
1436 alarmd API on Maemo.
1437 (modest_platform_init),
1438 Call modest_platform_set_update_interval(), using a hard-coded
1439 interval for now (until the global settings dialog is implemented),
1440 though I am not sure that this makes sense yet.
1442 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1444 * src/dbus_api/modest-dbus-callbacks.c:
1445 (modest_osso_cb_hw_state_handler):
1446 * src/dbus_api/modest-dbus-callbacks.h:
1447 * src/maemo/modest-platform.c: (modest_platform_init):
1448 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1449 in case this has some effect on the ability for Maemo to ping the
1452 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1454 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1455 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1456 warning. It is probably a logic error, but I need to fix the build.
1458 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1460 * src/modest-account-mgr.h:
1461 * src/modest-account-mgr.c:
1462 (modest_account_mgr_account_names): Add a gboolean enabled_only
1463 parameter, so we can get lists of onlt the enabled accounts.
1465 (modest_account_mgr_add_account),,
1466 (modest_account_mgr_account_with_display_name_exists):
1467 * src/maemo/modest-msg-edit-window.c: (get_transports):
1468 * src/modest-account-mgr-helpers.c:
1469 (modest_account_mgr_set_first_account_as_default):
1470 * src/modest-init.c: (init_default_account_maybe):
1471 * src/modest-tny-account-store.c: (get_accounts):
1472 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1473 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1474 * tests/check_account-mgr.c: (START_TEST):
1475 Provide the extra parameter, as appropriate.
1477 * src/widgets/modest-account-view.c: (update_account_view):
1478 Do not show disabled accounts (meaning that there is no way to
1479 enable/disable accounts in the UI (the feature is not in our UI
1480 specification), so we can use this internally only to mark unfinished
1481 or temporary account data.
1483 * src/maemo/easysetup/modest-easysetup-wizard.c:
1484 (create_account): Add boolean enable parameter, so we can specify FALSE
1485 to create the temporary account.
1486 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1487 (on_before_next): When finishing, when there is a temporary account, just
1489 Also, use a timeout to delay the showing of the dialog until gconf is likely
1490 to return correct information, due to a maemo gconf bug that is fixed in
1491 osso 1.1, but not yet in Bora.
1492 However, the dialog stays on screen after it is destroyed.
1494 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1495 for invalid data when cancelling. Use a hildon note instead of a dialog
1496 to complain about invalid data. Do not show the account-saved note if the
1497 account is disabled (a temporary account that will not really be saved for use
1500 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1502 * src/modest-account-mgr-helpers.h:
1503 * src/modest-account-mgr-helpers.c:
1504 Added modest_account_mgr_unset_default_account(),
1505 Added modest_account_mgr_set_first_account_as_default().
1507 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1508 If it was the default account, unset the default account name.
1510 * src/maemo/modest-account-view-window.c:
1511 (on_delete_button_clicked): If it was the default account,
1512 set the first remaining account as the default instead.
1514 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1515 a NULL account or a NULL default account, to prevent a crash. This should
1516 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1519 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1521 * src/widgets/modest-recpt-editor.c:
1522 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1523 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1524 TODO comment for this. This fixes the build.
1526 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1527 be the best place for it. This will in future update all auto-update accounts,
1528 rather than just the current/default account, when that gconf key exists.
1529 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1530 if there are no accounts, before calling do_send_receive().
1531 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1533 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1534 * src/maemo/modest-main-window-ui.h:
1535 * src/maemo/modest-main-window.c: (on_connection_changed),
1536 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1537 directly, becaue the signal handler does more.
1539 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1541 * src/modest-account-mgr-helpers.c:
1542 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1543 for the case that the account does not exist.
1545 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1546 (equivalent to the modest account name) rather than the tinymail account name
1547 (equivalent to the modest account title - human readable) to get the account data.
1548 Check for null account data to prevent the crash, and add a TODO comment saying that
1549 this needs fixing because it is using the server account name instead of the account name.
1551 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1553 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1554 * src/maemo/modest-account-settings-dialog.c: (show_error),
1556 Use hildon_note_new_information() for informative and error messages,
1557 which seems to be expected for Maemo applications (no documentation that I know of
1558 says this). I am surprised that there is no distinction between info and error
1561 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1563 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1564 it is easy to find where this is used.
1566 * src/maemo/easysetup/modest-easysetup-wizard.c:
1567 (create_page_welcome), (create_page_account_details),
1568 (create_page_user_details), (create_page_complete_easysetup),
1569 (create_page_custom_incoming), (create_page_custom_outgoing),
1570 (create_page_complete_custom):
1571 * src/maemo/modest-account-settings-dialog.c:
1572 (create_page_account_details), (create_page_user_details),
1573 (create_page_incoming), (create_page_outgoing):
1574 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1575 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1576 (modest_connection_specific_smtp_edit_window_init):
1577 * src/maemo/modest-connection-specific-smtp-window.c:
1578 (modest_connection_specific_smtp_window_init):
1579 * src/maemo/modest-signature-editor-dialog.c:
1580 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1581 and scrolling policy as per the Email Application Layout Guide, if I have
1584 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1586 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1587 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1588 which were empty, because these vfuncs have been removed from TnyAccountStore.
1589 This fixes the build.
1591 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1593 * src/maemo/modest-main-window.c:
1594 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1595 showing/hiding it. Added TODO because it probably should not be NULL.
1596 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1597 because unnecessary g_warnings() make degugging difficult.
1599 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1601 * src/maemo/modest-msg-edit-window.c:
1602 (modest_msg_edit_window_select_color),
1603 (modest_msg_edit_window_select_background_color): 2 const corrections and
1604 moving 2 #endifs before closing brackets, to fix the build.
1606 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1608 * src/maemo/easysetup/modest-easysetup-wizard.h:
1609 * src/maemo/easysetup/modest-easysetup-wizard.c:
1610 (modest_easysetup_wizard_dialog_finalize),
1611 (on_button_edit_advanced_settings), (create_page_complete_custom),
1612 (on_response), (create_account):
1613 Implement the Advanced Settings edit button, by saving the account information,
1614 for the Advanded Settings dialog to use directly from gconf, and removing it
1615 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1616 Bug #5533 in the projects.maemo.org bugzilla.
1618 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1620 * src/maemo/modest-msg-view-window.c:
1621 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1622 when opening a message window.
1624 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1626 * src/maemo/easysetup/modest-easysetup-wizard.c:
1627 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1630 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1631 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1632 gconf settings. I probably added more checks than necessary, but that is safer.
1634 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1635 variable to fix the build, but this seems to be used when it is still NULL.
1637 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1639 * src/modest-platform.h:
1640 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1641 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1642 * src/modest-main.c: Implement this function so we can avoid using
1643 maemo-specific API from cross-platform code.
1645 * src/modest-tny-account-store.c:
1646 (get_smtp_specific_transport_account_for_open_connection):
1647 * src/modest-ui-actions.c: (check_for_connection),
1648 (modest_ui_actions_on_item_not_found):
1649 Use modest_platform_connect_and_wait() and put #idefs around other
1650 maemo-specific code, because only maemo currently has a way to
1651 identify connection names.
1653 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1655 * src/modest-tny-account-store.h:
1656 * src/modest-tny-account-store.c:
1657 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1658 the connection-specific SMTP server settings in the configuration.
1660 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1662 * src/maemo/modest-main-window.c: (on_connection_changed),
1664 * src/modest-main.c: (main), (start_ui), (send_mail):
1665 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1666 that is what is intended.
1668 * src/modest-ui-actions.c: (action_send), (action_receive),
1669 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1670 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1671 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1672 SMTP server is used when it is specified.
1674 (modest_ui_actions_on_send_receive):
1675 Check that a connection is open before proceeding.
1676 Receive and then send, instead of vice-versa, as per the specification.
1678 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1680 * src/modest-mail-operation.c:
1681 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1682 though I guess it should be something other than NULL.
1684 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1686 * src/maemo/easysetup/modest-easysetup-wizard.c:
1687 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1688 combo twice, to avoid an g_warning and to make it visible again.
1689 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1690 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1691 (already intended) dereference when detaching, because we then recreate the menu.
1692 But I am not sure why the warning was happening, and it is possible that this is a memory
1695 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1697 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1698 and uri_parse_mailto() utility functions.
1699 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1701 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1703 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1705 * src/dbus_api/modest-dbus-api.h:
1706 * src/dbus_api/modest-dbus-callbacks.c:
1707 Use an idle callback to execute the modest code in the application's own thread.
1708 Remove the helloworld example method.
1709 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1710 parsed, and the open-message method is not implemented because this is not yet implemented in
1712 * libmodest-dbus-client/libmodest-dbus-client.c:
1713 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1714 (libmodest_dbus_client_open_message):
1715 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1717 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1718 body without crashing.
1720 * tests/dbus_api/Makefile.am:
1721 * tests/dbus_api/test_mail_to.c:
1722 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1724 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1726 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1727 Added file to fix the build. Sorry.
1729 * src/dbus_api/Makefile.am:
1730 * src/dbus_api/modest-dbus-api.h:
1731 * src/dbus_api/modest-dbus-callbacks.h:
1732 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1733 (modest_dbus_req_handler):
1734 Put constants in a separate header so it can be reused by the
1735 client library, without duplication
1737 * libmodest-dbus-client/Makefile.am:
1738 * libmodest-dbus-client/libmodest-dbus-client.c:
1739 (libmodest_dbus_client_call_helloworld),
1740 (libmodfest_dbus_client_send_mail),
1741 (libmodfest_dbus_client_mailto),
1742 (libmodfest_dbus_client_open_message):
1743 * libmodest-dbus-client/libmodest-dbus-client.h:
1744 (Partly) Implement a send_mail D-Bus method.
1746 * tests/dbus_api/Makefile.am:
1747 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1748 the send_email D-Bus method.
1750 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1754 * libmodest-dbus-client/Makefile.am:
1755 * libmodest-dbus-client/libmodest-dbus-client.c:
1756 * libmodest-dbus-client/libmodest-dbus-client.h:
1757 * tests/dbus_api/Makefile.am:
1758 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1759 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1761 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1763 * src/maemo/easysetup/modest-easysetup-wizard.c:
1764 (create_page_account_details):
1765 * src/maemo/modest-account-settings-dialog.c:
1766 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1767 widgets, because this might not be the default in future versions of the Maemo GTK+.
1768 However, I can not not get capitalization to work even in a simple test case.
1770 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1772 * src/maemo/easysetup/modest-easysetup-wizard.c:
1773 (create_page_custom_incoming), (create_page_custom_outgoing):
1774 * src/maemo/modest-account-settings-dialog.c:
1775 (create_page_account_details), (create_page_incoming),
1776 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1777 instead of using gtk_check_button_with_label(), so they are aligned like the other
1778 widgets, as per the UI spec.
1780 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1782 * src/maemo/easysetup/modest-easysetup-wizard.c:
1783 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1784 * src/widgets/modest-validating-entry.c:
1785 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1786 Modest prefix instead of an EasySetup prefix.
1788 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1790 * src/widgets/modest-validating-entry.h:
1791 * src/widgets/modest-validating-entry.c: (on_insert_text),
1792 Added easysetup_validating_entry_set_max_func(), used to set a callback
1793 to call when the max number of characters is reached. GtkEntry has a max-length
1794 already but is silent about it.
1796 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1797 (create_page_account_details), (create_page_user_details),
1799 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1800 (create_page_account_details), (create_page_user_details),
1801 (create_page_outgoing):
1802 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1803 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1804 the UI spec, when the user tries to enter more than the max number of characters.
1806 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1808 * src/maemo/easysetup/modest-easysetup-wizard.c:
1809 (create_page_user_details), (create_page_custom_incoming),
1810 (create_page_custom_outgoing):
1811 * src/maemo/modest-account-settings-dialog.c:
1812 (create_page_user_details), (create_page_incoming),
1813 (create_page_outgoing):
1814 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1815 (modest_connection_specific_smtp_edit_window_init):
1816 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1817 not appropriate. Bad Maemo-specific defaults!.
1819 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1821 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1822 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1823 (modest_signature_editor_dialog_set_settings):
1824 Disable the label and textview when the checkbox is disabled, and use the
1825 specified (UI spec) default signature text.
1827 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1829 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1830 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1832 * src/modest-defs.h:
1833 * src/modest-account-mgr-helpers.h:
1834 * src/modest-account-mgr-helpers.c:
1835 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1837 * src/maemo/Makefile.am:
1838 * src/maemo/modest-signature-editor-dialog.c:
1839 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1842 * src/maemo/modest-account-settings-dialog.h:
1843 * src/maemo/modest-account-settings-dialog.c:
1844 (modest_account_settings_dialog_finalize), (on_button_signature),
1845 (save_configuration): Use the new dialog when the Edit button is pressed, and
1846 save the changes if necessary, as per the UI spec.
1848 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1850 * src/maemo/Makefile.am:
1851 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1852 based on maemo-develoers email from Dirk.
1854 * src/maemo/easysetup/modest-easysetup-wizard.c:
1855 (create_page_welcome), (create_page_account_details),
1856 (create_page_user_details), (create_page_complete_easysetup),
1857 (create_page_custom_incoming), (create_page_custom_outgoing),
1858 (create_page_complete_custom),
1859 (modest_easysetup_wizard_dialog_init):
1860 * src/maemo/modest-account-settings-dialog.c:
1861 (create_page_account_details), (create_page_user_details),
1862 (create_page_incoming), (create_page_outgoing),
1863 (modest_account_settings_dialog_init):
1864 * src/maemo/modest-connection-specific-smtp-window.c:
1865 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1867 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1869 * src/maemo/easysetup/modest-easysetup-wizard.c:
1870 (create_page_account_details), (create_page_custom_outgoing),
1871 (create_page_complete_custom):
1872 * src/maemo/modest-account-settings-dialog.c:
1873 (create_page_user_details), (create_page_incoming),
1874 (create_page_outgoing):
1875 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1876 (modest_connection_specific_smtp_edit_window_init):
1877 Use the correct (UI spec) port min/max, and use horizontal separators,
1880 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1882 * src/maemo/easysetup/modest-easysetup-wizard.c:
1883 (set_default_custom_servernames):
1884 * src/maemo/modest-account-settings-dialog.c:
1885 (create_page_incoming), (on_combo_outgoing_security_changed),
1886 (on_combo_incoming_security_changed), (create_page_outgoing),
1887 (modest_account_settings_dialog_set_account_name),
1888 (save_configuration):
1889 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1890 (on_combo_security_changed),
1891 (modest_connection_specific_smtp_edit_window_init),
1892 (modest_connection_specific_smtp_edit_window_set_connection),
1893 (modest_connection_specific_smtp_edit_window_get_settings):
1894 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1897 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1900 * src/maemo/easysetup/modest-easysetup-wizard.c:
1901 (create_page_custom_outgoing), (create_page_complete_custom):
1902 * src/maemo/modest-account-settings-dialog.c:
1903 (create_page_user_details), (create_page_outgoing):
1904 * src/maemo/modest-account-view-window.c: (button_box_new):
1905 Use changed logical IDs as per the most recent UI spec:
1906 mcen_bd_emailsetup_edit -> mcen_bd_edit
1907 mcen_bd_emailsetup_delete -> mcen_bd_delete
1908 mcen_bd_emailsetup_close -> mcen_bd_close
1910 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1914 * src/dbus_api/Makefile.am:
1915 * src/dbus_api/modest-dbus-callbacks.c:
1916 * src/dbus_api/modest-dbus-callbacks.h:
1917 * src/maemo/modest-platform.c: (modest_platform_init):
1918 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1920 * tests/Makefile.am:
1921 * tests/dbus_api/Makefile.am:
1922 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1924 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1926 * src/maemo/modest-account-settings-dialog.c:
1927 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1928 Removed unnecessary includes.
1930 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1932 * src/maemo/easysetup/modest-easysetup-wizard.c:
1933 * src/maemo/modest-account-settings-dialog.c:
1934 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1935 * src/widgets/Makefile.am:
1936 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1937 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1938 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1939 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1940 * src/widgets/modest-secureauth-combo-box.c:
1941 * src/widgets/modest-secureauth-combo-box.h:
1942 * src/widgets/modest-serversecurity-combo-box.c:
1943 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1944 made the GObject names more consistent with the rest of the Modest code.
1946 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1948 * src/maemo/easysetup/Makefile.am:
1949 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1950 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1951 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1952 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1953 * src/maemo/easysetup/modest-easysetup-wizard.c:
1954 * src/maemo/easysetup/modest-validating-entry.c:
1955 * src/maemo/easysetup/modest-validating-entry.h:
1956 * src/maemo/modest-account-settings-dialog.c:
1957 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1958 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1959 widgets/ because they are used outside of easysetup too. After checking in,
1960 svn will allow me to rename them too.
1962 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1964 * src/gnome/modest-msg-edit-window.c:
1965 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1966 linker error, to fix the build on the GNOME platform.
1967 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1968 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1969 ifdefed out to avoid a warning.
1971 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1973 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1974 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1975 some alternative for GTK+ 2.6.
1977 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1979 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1981 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1982 specified for EmailAccountsDialog in UI spec.
1984 * src/maemo/easysetup/modest-easysetup-wizard.c:
1985 * src/maemo/easysetup/modest-easysetup-wizard.h:
1986 * src/maemo/modest-account-settings-dialog.c:
1987 * src/maemo/modest-account-settings-dialog.h:
1988 Reuse a member window widget for the connection-specific SMTP server accounts,
1989 so we can tell it to create/save the accounts only if we actually save changes.
1991 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1992 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1993 (modest_connection_specific_smtp_edit_window_get_settings):
1994 Return a struct instance for temporarily remembering the entered data.
1996 * src/maemo/modest-connection-specific-smtp-window.h:
1997 * src/maemo/modest-connection-specific-smtp-window.c:
1998 (modest_connection_specific_smtp_window_finalize),
1999 (modest_connection_specific_smtp_window_fill_with_connections),
2001 (modest_connection_specific_smtp_window_save_server_accounts),
2002 (update_model_server_names): Do not actually save data until asked,
2003 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2005 (on_selection_changed),
2006 (modest_connection_specific_smtp_window_init): Disable the edit
2007 button when nothing is selected.
2009 * src/modest-account-mgr-helpers.c:
2010 * src/modest-account-mgr-helpers.h:
2011 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2014 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2016 * src/modest-account-mgr-helpers.h:
2017 * src/modest-account-mgr-helpers.c:
2018 (modest_account_mgr_get_unused_account_name),
2019 (modest_account_mgr_get_unused_account_display_name): Added these
2020 utility functions, to avoid code duplication.
2022 * src/maemo/easysetup/modest-easysetup-wizard.c:
2023 (create_page_account_details), (create_account):
2024 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2025 (on_combo_security_changed),
2026 (modest_connection_specific_smtp_edit_window_init),
2027 (modest_connection_specific_smtp_edit_window_save_settings):
2028 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2029 * src/maemo/modest-connection-specific-smtp-window.c:
2030 (modest_connection_specific_smtp_window_finalize),
2031 (modest_connection_specific_smtp_window_fill_with_connections),
2032 (on_button_edit), (modest_connection_specific_smtp_window_init):
2033 * src/maemo/modest-connection-specific-smtp-window.h:
2034 Implementing saving of connection-specific server accounts.
2036 But I need to refactor this so we can save the data for each
2037 possible connection-specific account and only actually create the server accounts
2038 when the easysetup finished, or the OK button is pressed on the account settings
2041 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2043 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2044 (on_combo_security_changed):
2045 (modest_connection_specific_smtp_edit_window_init):
2046 Auto-fill the port number as in the account settings.
2048 (modest_connection_specific_smtp_edit_window_set_connection):
2049 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2050 * src/maemo/modest-connection-specific-smtp-window.c:
2051 (fill_with_connections), (on_button_edit),
2052 (modest_connection_specific_smtp_window_init):
2053 Turn the edit window into a dialog to simplify the code, and
2054 set a WM hint as in a GtkDialog, because only a popup can be on top of
2055 another window in Maemo, and popups usually have no WM decoration.
2057 * src/modest-defs.h:
2058 * src/modest-account-mgr-helpers.c:
2059 (modest_account_mgr_set_connection_specific_smtp),
2060 (modest_account_mgr_remove_connection_specific_smtp),
2061 (modest_account_mgr_get_connection_specific_smtp):
2062 * src/modest-account-mgr-helpers.h: Some functions to write the
2063 connection-specific SMTP server information. Not yet used.
2066 * src/widgets/modest-folder-view.c: (text_cell_data):
2067 Fix a warning about an uninitialized variable.
2068 (on_configuration_key_changed): Put an #ifdef around the use
2069 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2071 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2073 * src/maemo/modest-account-settings-dialog.h:
2074 * src/maemo/modest-account-settings-dialog.c:
2075 Added connect_for_modified() utility function to mark the new modified boolean.
2077 (create_page_account_details), (create_page_user_details),
2078 (create_page_incoming), (create_page_outgoing), (on_response),
2079 (modest_account_settings_dialog_init),
2080 (modest_account_settings_dialog_set_account_name):
2081 Only warn about unsaved changes when there are actually unsaved changes.
2083 * src/modest-account-mgr-helpers.c:
2084 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2085 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2086 to get the data from there in future.
2088 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2090 * src/modest-defs.h:
2092 * src/modest-account-mgr-helpers.h:
2093 * src/modest-account-mgr-helpers.c:
2094 Store the security account setting in a single conf key instead of using
2095 the options list, so that the list is left for just the to-be-removed camel hack,
2096 and because gconf_client_set_list() is failing for some reason.
2098 * src/modest-account-mgr.c:
2099 (modest_account_mgr_add_server_account):
2100 * src/maemo/modest-account-settings-dialog.c:
2101 (modest_account_settings_dialog_set_account_name),
2102 (save_configuration): Use the renamed functions.
2105 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2107 * src/widgets/Makefile.am:
2108 * src/widgets/modest-limit-retrieve-combo-box.c:
2109 * src/widgets/modest-limit-retrieve-combo-box.h:
2110 * src/widgets/modest-retrieve-combo-box.c:
2111 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2112 the account settings dialog.
2114 * src/modest-defs.h:
2115 * src/modest-account-mgr-helpers.h:
2116 * src/modest-account-mgr-helpers.c:
2117 (modest_server_account_get_option_secure_auth),
2118 (modest_server_account_set_option_secure_auth):
2119 * src/modest-account-mgr.c:
2120 (modest_account_mgr_add_server_account):
2121 Use the existing AUTH_MECH conf key for the secure-auth setting,
2122 instead of putting it in the list options, because this was actually used already.
2124 * src/maemo/modest-account-settings-dialog.c:
2125 (create_page_account_details),
2126 (modest_account_settings_dialog_set_account_name),
2127 (save_configuration):
2128 * src/maemo/modest-account-settings-dialog.h:
2129 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2130 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2132 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2134 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2135 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2136 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2138 * src/modest-defs.h:
2139 * src/maemo/modest-account-settings-dialog.c:
2140 (create_page_incoming), (on_combo_outgoing_security_changed),
2141 (on_combo_incoming_security_changed), (create_page_outgoing),
2142 (modest_account_settings_dialog_set_account_name),
2143 (save_configuration): Load/Save the port number, and change it when the
2144 security combo changes, to suitable defaults.
2146 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2148 * src/modest-account-mgr.c:
2149 (modest_account_mgr_add_server_account): Set the security and secure-auth
2150 options, and add a comment saying that the other camel-specific options should be
2153 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2155 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2157 * src/modest-tny-account-store.c: (account_list_free),
2158 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2159 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2162 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2164 * src/modest-protocol-info.c:
2165 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2166 is required by our UI spec. Maybe something in our implementation will use this eventually.
2167 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2168 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2169 instead of the previous 0 placeholder.
2171 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2172 secure-auth settings.
2173 * src/modest-account-mgr-helpers.h:
2174 * src/modest-account-mgr-helpers.c:
2175 (modest_server_account_data_get_option_secure_auth),
2176 (modest_server_account_set_option_secure_auth),
2177 (modest_server_account_data_get_option_security),
2178 (modest_server_account_set_option_security): Added this API for getting and setting the security
2179 and secure-auth settings.
2181 * src/maemo/modest-account-settings-dialog.h:
2182 * src/maemo/modest-account-settings-dialog.c:
2183 (modest_account_settings_dialog_finalize), (check_data),
2184 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2185 about changing titles.
2186 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2187 (save_configuration): Save the security and secure-auth settings.
2189 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2190 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2192 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2194 * src/modest-defs.h:
2195 * src/modest-account-mgr.c:
2196 (modest_account_mgr_add_server_account):
2197 Added and used defines for the options key and value pair strings,
2198 that are used so far, though they do not seem to correspond to anything in our
2199 UI specs or ModestProtocol enum.
2201 * src/modest-account-mgr-helpers.h:
2202 * src/modest-account-mgr-helpers.c:
2203 (compare_option_strings_for_name),
2204 (modest_server_account_data_get_option_value),
2205 (modest_server_account_data_get_option_bool),
2206 (modest_account_mgr_get_server_account_option):
2207 Added helper functions for parsing the options GSList.
2209 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2211 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2212 display name is based on the supplied account name.
2213 * src/modest-account-mgr.c:
2214 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2215 with an inefficient, but good-enough, implementation.
2217 * src/maemo/easysetup/modest-easysetup-wizard.c:
2218 (create_page_account_details), (on_before_next), (create_account):
2219 Check for existing display names rather than (non-user-visible) account names, and just
2220 create and set a unique account name at the end.
2222 * src/maemo/modest-account-settings-dialog.c:
2223 (modest_account_settings_dialog_init),
2224 (modest_account_settings_dialog_set_account_name),
2225 (create_page_incoming): Show the display name, instead of the account name.
2226 (on_response): Do some (not all) extra checks, as in the UI spec.
2227 (save_configuration): Save the display name if it was changed.
2229 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2231 * po/en_GB.po: Added needed logical ID and translation.
2232 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2233 (init_view): Made the is-default column clicking work.
2235 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2238 * src/maemo/easysetup/Makefile.am:
2239 * src/maemo/easysetup/modest-easysetup-wizard.c:
2240 (modest_easysetup_wizard_dialog_init):
2241 * src/maemo/easysetup/provider-data-test.keyfile:
2242 * src/maemo/easysetup/provider-data.keyfile:
2243 Moved the provider data file to the new modest-providers-data package and used it from there.
2245 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2247 * src/modest-local-folder-info.c:
2248 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2249 N_() was already used on the static strings, but this just marks it for translation without
2250 using the translation.
2252 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2254 * src/maemo/modest-account-settings-dialog.c:
2255 (create_page_incoming),
2256 (modest_account_settings_dialog_set_account_name):
2257 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2258 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2259 I will do this if nobody else gets there first.
2261 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2263 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2264 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2265 save the security stuff.
2267 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2269 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2270 Set the email address and user fullname, which I now see must be
2273 * src/maemo/modest-account-settings-dialog.h:
2274 * src/maemo/modest-account-settings-dialog.c:
2276 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2277 leave-on-server and authentication.
2278 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2281 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2284 * src/maemo/modest-account-settings-dialog.c:
2285 * src/maemo/modest-account-settings-dialog.h:
2286 Most (but not all) of the widgets are now present as specified by the UI spec.
2287 No changes are yet saved, and some details are not properly shown yet.
2289 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2291 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2293 * src/maemo/Makefile.am:
2294 * src/maemo/modest-account-settings-dialog.c:
2295 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2296 an existing account. Doesn't do much yet.
2298 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2299 Open the accounts settings dialog when Edit is clicked.
2301 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2303 * src/maemo/easysetup/Makefile.am:
2304 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2306 * src/maemo/easysetup/modest-easysetup-wizard.c:
2307 (modest_easysetup_wizard_dialog_init):
2308 Try to get the source directory from the build system,
2309 instead of hard-coding "./" into the source code, when opening our local
2310 copies of the configuration files.
2311 But this still fails when opening the wizard from the Accounts window,
2312 maybe because the working directory seems to change at runtime.
2313 So the wizard will fail the second time unless you copy the files into their
2314 proper locations - see the stdout warnings for the paths.
2316 (create_page_account_details),(on_before_next):
2317 Check for existing non-server accounts instead of server accounts,
2318 so the default account name is useful again, and to prevent trying to
2321 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2322 Show the wizard when New is clicked.
2324 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2325 (init_view): Show the column headers, and show the columns that are
2326 specified in the UI specs. However, something in Maemo's GTK+ prevents
2327 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2328 change the default account. This is despite unsetting the special properties.
2330 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2332 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2333 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2334 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2335 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2336 to make that clearer.
2337 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2339 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2341 * src/maemo/modest-account-view-window.c:
2342 (modest_account_view_window_init),
2343 (modest_account_view_window_new):
2344 Use the same buttons as specified in the
2345 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2346 the existing widgets, which never had a chance of working.
2347 Put the ModestAccountView treeview in a scrolled window.
2348 Do not repeat the initialization in both _init() and _new().
2350 * src/widgets/modest-account-view.c: (update_account_view):
2351 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2352 this widget and window shows no accounts.
2354 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2356 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2358 * src/maemo/easysetup/modest-easysetup-wizard.c:
2359 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2360 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2361 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2364 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2365 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2366 accounts exist yet, as in the UI spec.
2368 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2370 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2372 * src/maemo/Makefile.am:
2373 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2374 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2375 New window for editing connection-specific smtp details.
2376 Not fully implemented.
2378 * src/maemo/modest-connection-specific-smtp-window.c:
2379 (modest_connection_specific_smtp_window_finalize) :
2380 unref the tree model.
2381 (on_button_edit): Show the edit window.
2383 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2385 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2388 * src/maemo/Makefile.am:
2389 * src/maemo/modest-connection-specific-smtp-window.c:
2390 * src/maemo/modest-connection-specific-smtp-window.h:
2391 New window for showing the list of connections, for connection-specific
2392 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2393 * src/maemo/easysetup/modest-easysetup-wizard.c:
2394 (create_page_custom_outgoing): Show the new window when the button is clicked.
2396 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2398 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2399 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2400 * src/maemo/modest-msg-edit-window.c:
2401 (modest_msg_edit_window_insert_image):
2402 * src/modest-conf.c: (modest_conf_key_escape):
2403 * src/modest-mail-operation.c:
2404 (modest_mail_operation_send_new_mail):
2405 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2406 (modest_ui_actions_on_new_account):
2407 * src/widgets/modest-attachment-view.c: (update_filename_request):
2408 * src/widgets/modest-mail-header-view.c:
2409 Corrected warnings that were breaking the build, by commenting out unused variables,
2410 and a function, and by including a header.
2412 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2414 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2415 so we can #ifdef around platform-specific code when necessary.
2416 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2417 to allow this to build for the GNOME platform too.
2419 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2421 * src/maemo/easysetup/modest-easysetup-wizard.c:
2422 Added util_increment_name() and used it in create_page_account_details()
2423 to make sure that the default account name is always a new name.
2425 (modest_easysetup_wizard_dialog_init),
2426 (set_default_custom_servernames): Some minor memory management fixes.
2428 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2432 * src/modest-runtime.c: (init_i18n): Restored the translation
2433 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2434 are defined in config.h, and the translations are installed.
2436 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2437 is defined for translation.
2439 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2441 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2443 * src/maemo/easysetup/modest-easysetup-wizard.c:
2444 (modest_easysetup_wizard_dialog_init):
2445 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2446 Use realistic paths (though they should use $prefix generically) to the
2447 mcc_mapping and provider-data.keyfile files which might work when they
2448 are installed by the future version of the operator-wizard package,
2449 and then fallback to paths in our source code, with an explanatory
2452 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2456 * src/maemo/Makefile.am:
2457 * src/maemo/easysetup/: Added files from the previously-exernal
2458 osso-modest-easysetup.
2459 * src/maemo/modest-main-window-ui.h:
2460 * src/modest-ui-actions.c:
2461 * src/modest-ui-actions.h:
2462 Added modest_ui_actions_on_new_account() as a signal handler for the
2463 New Account menu item. It shows the easysetup wizard.
2464 * po/en_GB.po: Added additional needed logical IDs and translations.
2466 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2467 Apparently ChangeLog is not used for some vague Nokia legal reasons.